#instantbird log on 09 20 2013

All times are UTC.

00:25:55 --> jb has joined #instantbird
01:00:45 <-- Mook_as has quit (Quit: Mook_as)
01:01:52 --> flo-retina has joined #instantbird
01:01:52 * ChanServ sets mode +qo flo-retina flo-retina 
01:07:39 <-- clokep_work has quit (Ping timeout)
01:12:06 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
01:46:39 <clokep> qheaden: ping
02:14:37 <instant-buildbot> build #1093 of win32-nightly-default is complete: Failure [failed shell]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1093
02:20:33 <-- jb has quit (Ping timeout)
02:29:12 <-- mconley has quit (Input/output error)
02:32:42 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:42:34 <-- EionRobb has quit (Quit: Leaving.)
02:59:44 --> mconley has joined #instantbird
03:05:38 <-- mconley has quit (Ping timeout)
03:08:27 --> clokep_work has joined #instantbird
03:10:57 --> mconley has joined #instantbird
03:12:18 --> EionRobb has joined #instantbird
03:13:30 <-- mconley has quit (Input/output error)
03:19:24 <instant-buildbot> build #976 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/976
03:24:18 <-- clokep_work has quit (Ping timeout)
03:34:08 <instant-buildbot> build #998 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/998
03:44:49 <qheaden> clokep: Sorry I missed your ping. I was afk.
03:52:46 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2897 on bug 2136.
03:52:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account
03:52:57 --> Mook has joined #instantbird
04:02:59 --> mconley has joined #instantbird
04:05:00 --> jb has joined #instantbird
04:26:06 <-- mconley has quit (Input/output error)
04:31:02 <-- wnayes has quit (Quit: wnayes)
05:21:38 <-- EionRobb has quit (Quit: Leaving.)
05:24:42 --> clokep_work has joined #instantbird
05:25:43 <-- Mook has quit (Quit: Mook)
05:31:00 <-- jb has quit (Ping timeout)
05:31:20 --> flo-retina has joined #instantbird
05:31:20 * ChanServ sets mode +qo flo-retina flo-retina 
05:31:48 <flo-retina> clokep: which version of Visual Studio did you use?
05:41:39 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
07:42:47 --> nhnt11 has joined #instantbird
08:05:14 --> EionRobb has joined #instantbird
08:22:16 --> BWMerlin has joined #instantbird
08:34:38 --> chrisccoulson has joined #instantbird
08:50:32 <-- gerard-majax has quit (Ping timeout)
08:52:02 <-- nhnt11 has quit (Ping timeout)
08:56:00 --> nhnt11 has joined #instantbird
09:12:47 <-- nhnt11 has quit (Ping timeout)
09:25:58 --> nhnt11 has joined #instantbird
09:28:28 <-- nhnt11 has quit (Ping timeout)
09:31:22 --> gerard-majax has joined #instantbird
09:46:18 <-- EionRobb has quit (Quit: Leaving.)
10:04:30 --> clokep has joined #instantbird
10:04:30 * ChanServ sets mode +o clokep 
10:05:15 <clokep> flo-retina: 2010 Express
10:32:07 --> aleth has joined #instantbird
10:32:07 * ChanServ sets mode +h aleth 
10:39:17 --> nhnt11 has joined #instantbird
10:48:51 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:01:32 --> jb has joined #instantbird
11:03:01 <-- dew has quit (Ping timeout)
11:03:04 --> dew1 has joined #instantbird
11:03:05 <-- jb has quit (Excess Flood)
11:03:08 --> jb has joined #instantbird
11:42:24 <-- nhnt11 has quit (Ping timeout)
11:57:08 <clokep_work> aleth: Do we usually allow overwriting input parameters (re bug 2136)
11:57:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account
11:58:24 <aleth> clokep_work: We have it in existing code in places where it makes the code easier to read.
11:59:02 <aleth> In this case what makes it seem odd is that we are "overwriting" something that is actually not defined at all
12:00:16 <aleth> "// When defining just the message, set aStatus to undefined." Do we like passing undefined as a parameter?
12:00:53 * aleth thinks setBuddyStatus("clokep", undefined, "Statusmessage") looks odd.
12:02:46 <clokep_work> aleth: Unfortunately you missed the decision to decide that looks odd. ;)
12:02:58 <clokep_work> It looks a lot better than the previous revision where there are two methods that are almost identical.
12:05:31 <instant-buildbot> build #1094 of win32-nightly-default is complete: Exception [exception]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1094
12:06:36 <aleth> clokep_work: Why not use null rather than undefined? ;)
12:07:27 <aleth> But I haven't been following that bug at all, so...
12:08:48 <clokep_work> undefined or null would both work IMO.
12:08:56 <clokep_work> I don't have a strong opinion either way.
12:09:13 <aleth> Idk the context, what's calling it, etc...
12:09:35 <clokep_work> You and make keep using the excuse of not knowing this code. :P
12:10:30 <aleth> What, you want me to waltz in after 30s of looking at the patch and declare undefined to be harmful, r-? :P
12:11:43 <clokep_work> Yes. :-D
12:11:45 <instantbot> clokep@gmail.com granted review for attachment 2897 on bug 2136.
12:11:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account
12:11:59 * clokep_work is half just tired of looking at that patch. :(
12:12:59 <aleth> Then again, you do seem to actually have yahoo friends with mobile status ;)
12:16:00 <qheaden> Hello.
12:16:57 <qheaden> clokep_work: It seems that bug 2136 wont rest. :P
12:17:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account
12:17:42 <aleth> qheaden: It's r+, just go with your own preference and add checkin-needed (or not) ;)
12:19:15 <qheaden> aleth: I think undefined is better. The reason for that is because parameters at the end that are not included in a call, such as aMessage in this case, are declared undefined.
12:19:35 <qheaden> I have to use an === check because if I use ==, empty strings also qualify as null or undefined.
12:21:45 <aleth> OK
12:25:33 <qheaden> clokep_work: Were you actually able to test the patch against your mobile friend?
12:33:15 <-- jb has quit (Ping timeout)
12:54:00 <clokep_work> qheaden: I have not. I do have a working tree now though, thanks to Florian. :P
12:54:03 <clokep_work> So I can do that tonight.
12:54:07 * clokep_work should have thought of that yesterday.
12:54:38 <aleth> Is that a working /moz24/ tree?
12:54:39 <qheaden> clokep_work: I let you try it first before adding checkin-needed.
13:12:18 --> mconley has joined #instantbird
13:32:58 --> jb has joined #instantbird
13:38:42 <-- jb has quit (Write error: Connection reset by peer)
13:39:52 --> jb has joined #instantbird
13:40:54 <clokep_work> qheaden: Sounds good. :)
13:41:04 <clokep_work> aleth: No.
13:41:11 <clokep_work> It's a working moz 23 tree. :-D
13:53:46 <aleth> clokep_work: I was just wondering if you were trying to reproduce the build slave issues or working on the next update...
13:54:09 <clokep_work> aleth: Build slave issues during distribution, yes.
13:54:14 <clokep_work> I also have a moz24 build tree going though.
15:44:16 --> flo-retina has joined #instantbird
15:44:17 * ChanServ sets mode +qo flo-retina flo-retina 
15:44:43 <flo-retina> hello :)
15:49:44 --> wnayes has joined #instantbird
16:00:28 <-- jb has quit (Ping timeout)
16:10:19 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:15:08 --> flo-retina has joined #instantbird
16:15:08 * ChanServ sets mode +qo flo-retina flo-retina 
16:35:25 --> jb has joined #instantbird
16:40:24 --> Mook_as has joined #instantbird
16:41:13 --> jb1 has joined #instantbird
16:41:26 <-- jb has quit (Ping timeout)
16:43:49 <-- flo-retina has quit (Ping timeout)
16:47:23 <-- jb1 has quit (Connection reset by peer)
16:47:38 --> flo-retina has joined #instantbird
16:47:38 * ChanServ sets mode +qo flo-retina flo-retina 
16:48:05 --> jb has joined #instantbird
16:54:17 <-- jb has quit (Ping timeout)
16:54:45 <clokep_work> flo-retina: aleth I have no ideas. :)
16:54:47 <clokep_work> It worked fine for me.
17:03:17 --> jb has joined #instantbird
17:13:12 <-- gerard-majax has quit (Ping timeout)
17:16:25 <instantbot> aleth@instantbird.org denied review for attachment 2894 on bug 2143.
17:16:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
17:25:53 <-- jb has quit (Ping timeout)
17:37:35 --> jb has joined #instantbird
17:44:34 <-- jb has quit (Ping timeout)
17:47:09 --> gerard-majax has joined #instantbird
18:03:36 --> jb has joined #instantbird
18:19:27 <-- jb has quit (Ping timeout)
18:29:05 --> jb has joined #instantbird
18:46:59 <-- aleth has quit (Quit: Ciao)
18:50:15 <-- jb has quit (Ping timeout)
18:52:25 <-- gerard-majax has quit (Ping timeout)
18:52:46 <-- flo-retina has quit (Ping timeout)
18:55:02 --> gerard-majax has joined #instantbird
18:58:11 --> qlum has joined #instantbird
19:06:38 --> jb has joined #instantbird
19:16:31 <-- jb has quit (Ping timeout)
19:57:43 --> EionRobb has joined #instantbird
19:59:02 --> jb has joined #instantbird
20:12:07 <-- jb has quit (Ping timeout)
20:26:08 --> flo-retina has joined #instantbird
20:26:08 * ChanServ sets mode +qo flo-retina flo-retina 
20:27:32 --> flo-retina1 has joined #instantbird
20:28:39 <-- flo-retina has quit (Ping timeout)
21:13:45 <-- mconley has quit (Input/output error)
21:17:14 --> jb has joined #instantbird
21:19:18 <-- jb has quit (No route to host)
21:23:57 --> jb has joined #instantbird
21:26:50 <-- jb has quit (Ping timeout)
21:26:55 --> jb has joined #instantbird
21:30:07 --> mconley has joined #instantbird
21:40:54 <-- jb has quit (Connection reset by peer)
22:07:12 --> rosonline has joined #instantbird
22:29:19 <-- rosonline has quit (Client exited)
22:33:22 <-- EionRobb has quit (Ping timeout)
22:35:35 --> EionRobb has joined #instantbird
22:35:56 <-- mconley has quit (Connection reset by peer)
22:36:09 --> mconley has joined #instantbird
23:07:10 <-- EionRobb has quit (Ping timeout)
23:09:46 --> EionRobb has joined #instantbird
23:13:42 <-- qlum has quit (Quit: Getting the <censored> out.)
23:24:45 <-- EionRobb has quit (Ping timeout)
23:26:44 --> EionRobb has joined #instantbird
23:42:07 <flo-retina1> I don't remember if I mentioned it yet, but Even has found something he dislikes in the new Windows VM, and decided to recreate it from scratch again.
23:43:04 <flo-retina1> something he dislikes = initially the system hard disk wasn't large enough, he resized it while installing something. And he now discovered that had messed up some system files, so he will feel more confident in the overall stability of the system if he reinstalls everything.
23:46:27 <-- mconley has quit (Input/output error)