All times are UTC.
00:07:33 <-- jb has quit (Ping timeout) 00:31:17 <instant-buildbot> build #972 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/972 00:40:11 <qheaden> clokep: I have no clue why I never thought of what you said in your last comment on bug 2136. 00:40:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account 00:40:43 <clokep> qheaden: Well Idk why it took me like 4 review iterations to think of it either. :) 00:40:49 <clokep> So I'm just glad one of us did! 00:40:57 <qheaden> :P 00:55:12 <-- Mook_as has quit (Quit: Mook_as) 00:56:50 <-- flo-retina has quit (Ping timeout) 01:12:03 <-- Suiseiseki has quit (Quit: Leaving) 01:12:36 <qheaden> clokep: What do you think of this code instead for buddy statuses? http://pastebin.instantbird.com/343571 01:13:29 <clokep> qheaden: What do YOU think of it? :) 01:13:33 <clokep> I think it's a lot simpler. 01:13:42 <qheaden> I love it. :) 01:13:52 <qheaden> It is a whole lot simpler. 01:13:53 <clokep> Throw it in a bug and I'll review it in the morning. 01:14:00 <qheaden> Okay. 01:14:05 <clokep> :) 01:14:12 <clokep> Simpler = better! 01:17:57 <qheaden> clokep: Did you want me to ask a review from Mic as well? 01:18:09 <clokep> No, it's fine. 01:18:21 <qheaden> OK. 01:18:35 <qheaden> We're getting closer. :) 01:19:03 <qheaden> So when JS Yahoo is turned on by default, we are going to remove the libpurple Yahoo code? 01:19:17 <clokep> I think we'll want to do a release with both? 01:19:26 <clokep> So if someone runs into issues they can pref it back on. 01:19:30 <clokep> But that's not what we did with IRC. 01:19:34 <clokep> So....I'm not sure. :) 01:19:40 <qheaden> I agree with releasing both. 01:20:10 <qheaden> Lets get some more user feedback on it, and then in the release after, we can probably remove the old code. 01:21:09 <clokep> Seems reaosnable. :) 01:26:30 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2895 on bug 2136. 01:26:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2136 min, --, ---, qheaden, ASSI, Yahoo! Mobile status not taken into account 01:34:32 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:08:23 --> Suiseiseki has joined #instantbird 02:53:12 --> Mook has joined #instantbird 03:03:31 <instant-buildbot> build #973 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/973 03:54:54 * dew1 is now known as dew 04:15:50 --> nhnt11 has joined #instantbird 04:27:56 <-- mconley has quit (Input/output error) 04:39:07 <instant-buildbot> build #995 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/995 04:41:54 <-- nhnt11 has quit (Ping timeout) 04:45:36 --> nhnt11 has joined #instantbird 04:54:08 <-- nhnt11 has quit (Ping timeout) 04:55:01 --> nhnt11 has joined #instantbird 04:58:21 <-- nhnt11 has quit (Ping timeout) 04:58:24 --> nhnt11 has joined #instantbird 05:03:56 <-- nhnt11 has quit (Ping timeout) 05:03:59 --> nhnt11 has joined #instantbird 05:06:29 <-- nhnt11 has quit (Ping timeout) 05:07:22 --> nhnt11 has joined #instantbird 05:28:24 --> mconley has joined #instantbird 05:34:18 <-- mconley has quit (Ping timeout) 05:35:50 <-- EionRobb has quit (Quit: Leaving.) 05:37:26 <-- nhnt11 has quit (Ping timeout) 06:30:21 <-- Mook has quit (Quit: Mook) 06:49:34 --> FireFly_TB has joined #instantbird 06:59:54 <-- FireFly_TB has quit (Quit: FireFly_TB) 08:03:25 <-- Even has quit (Ping timeout) 08:04:18 --> Even has joined #instantbird 08:04:18 * ChanServ sets mode +o Even 08:07:54 <-- gerard-majax_ has quit (Quit: Ex-Chat) 09:02:24 --> dionisos has joined #instantbird 09:40:45 --> gerard-majax has joined #instantbird 09:58:56 <-- gerard-majax has quit (Ping timeout) 10:04:38 --> clokep has joined #instantbird 10:04:39 * ChanServ sets mode +o clokep 10:48:09 --> gerard-majax has joined #instantbird 11:00:27 --> FireFly_TB has joined #instantbird 11:02:45 <-- dew has quit (Ping timeout) 11:02:46 --> dew1 has joined #instantbird 11:53:47 --> clokep_ has joined #instantbird 11:59:09 <clokep_> qheaden: ping. 12:46:27 <-- clokep has quit (Ping timeout) 12:50:05 <-- FireFly_TB has quit (Ping timeout) 13:19:26 --> nhnt11 has joined #instantbird 13:20:16 --> mconley has joined #instantbird 13:26:33 --> jb has joined #instantbird 13:27:45 <-- jb has quit (Connection reset by peer) 13:28:04 --> jb has joined #instantbird 13:51:26 <-- jb has quit (Ping timeout) 13:59:02 <-- nhnt11 has quit (Ping timeout) 14:33:42 <-- ivan has quit (Ping timeout) 14:35:58 --> jb has joined #instantbird 14:37:53 --> ivan has joined #instantbird 14:41:07 <-- jb has quit (Quit: jb) 14:42:53 --> nhnt11 has joined #instantbird 14:46:10 --> jb has joined #instantbird 14:56:28 --> jb1 has joined #instantbird 14:56:31 <-- jb has quit (Connection reset by peer) 14:57:54 * mconley is now known as mconley|interview 15:36:38 <-- jb1 has quit (Connection reset by peer) 16:03:32 * mconley|interview is now known as mconley 16:05:54 --> jb has joined #instantbird 16:21:21 --> flo-retina has joined #instantbird 16:21:21 * ChanServ sets mode +qo flo-retina flo-retina 16:26:14 --> Mook_as has joined #instantbird 16:26:37 <-- jb has quit (Ping timeout) 16:29:30 --> jb has joined #instantbird 16:39:35 <flo-retina> anybody knows what's up / what the status is with the Windows VM? 16:42:38 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:44:59 <-- jb has quit (Ping timeout) 16:49:30 <clokep_> flo-retina: Nol, I meant to email Even this morning. :( 16:56:16 <-- gerard-majax has quit (Ping timeout) 17:03:36 * mconley is now known as mconley|mtg 17:32:06 --> qlum has joined #instantbird 17:32:17 <-- qlum has quit (Quit: Getting the <censored> out.) 17:35:31 --> qlum has joined #instantbird 17:48:31 --> gerard-majax has joined #instantbird 17:50:51 --> jb has joined #instantbird 18:17:59 --> FireFly_TB has joined #instantbird 18:18:28 <-- jb has quit (Ping timeout) 18:22:31 * mconley|mtg is now known as mconley 18:37:17 <-- FireFly_TB has quit (Ping timeout) 18:39:40 --> jb has joined #instantbird 18:55:19 <-- mconley has quit (Connection reset by peer) 18:55:38 --> mconley has joined #instantbird 18:56:16 <-- mconley has quit (Connection reset by peer) 18:56:33 --> mconley has joined #instantbird 19:00:40 * mconley is now known as mconley|mrg 19:00:43 * mconley|mrg is now known as mconley|mtg 19:21:56 <-- jb has quit (Ping timeout) 19:28:17 <-- flo-retina has quit (Ping timeout) 19:28:40 --> flo-retina has joined #instantbird 19:28:40 * ChanServ sets mode +qo flo-retina flo-retina 19:35:13 --> jb has joined #instantbird 19:37:48 <-- jb has quit (Connection reset by peer) 19:39:07 --> jb has joined #instantbird 19:41:15 * mconley|mtg is now known as mconley 19:51:17 --> Mic has joined #instantbird 19:51:18 * ChanServ sets mode +h Mic 19:53:47 <clokep_> Hello Mic! 19:54:01 <Mic> Hi, how are you? 19:54:28 <clokep_> Tired, how're you! 19:55:43 <Mic> I'm fine, thanks. 19:56:45 <clokep_> I didn't have qheaden re-request r? from you, but if you'd like to look at that mobile status bug again, feel free! :) 19:56:57 <clokep_> https://bugzilla.instantbird.org/attachment.cgi?id=2895&action=diff 19:57:05 * clokep_ is curious what your thoughts are on the two separate setStatus methods. 20:17:29 <Mic> What about this? 20:17:35 <Mic> |setBuddyStatus: function(aName, aStatus = buddy.statusType, aMessage = buddy.statusText)| 20:18:14 <Mic> And call it with an undefined value for the status if you only want to set the message? 20:18:33 <Mic> The second method could go away then. 20:18:57 <Mic> With second method I meant "setBuddyStatusMessage" 20:21:10 <clokep_> Mic: That's what I was thinking too. 20:21:13 <Mic> Or use |buddy.setStatus(aStatus || buddy.statusType, aMessage || buddy.statusText);| if that's more the coding style in the Yahoo! code (we still have the default parameters patch sitting around btw). 20:22:04 <clokep_> Mic: The other wouldn't work... buddy isn't defined. ;) 20:23:08 <Mic> d'oh ;) 20:27:38 <-- jb has quit (Connection reset by peer) 20:33:47 --> jb has joined #instantbird 20:47:19 --> EionRobb has joined #instantbird 20:52:34 <Mook_as> so you can't set status or message to empty string? :p 21:03:11 <Mic> True... 21:07:28 <Mic> qheaden: there's a "aMessage || buddy.statusText" in your patch which would prevent clearing the status message in combination with a status change. 21:13:41 <-- jb has quit (Ping timeout) 21:22:11 --> jb has joined #instantbird 21:31:34 <-- jb has quit (Ping timeout) 21:38:58 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:52:29 <-- mconley has quit (Input/output error) 22:10:45 --> jb has joined #instantbird 22:15:45 <-- jb has quit (Ping timeout) 22:15:51 --> jb has joined #instantbird 22:18:28 <-- jb has quit (Ping timeout) 22:44:52 <-- flo-retina has quit (Ping timeout) 22:45:40 --> flo-retina has joined #instantbird 22:45:40 * ChanServ sets mode +qo flo-retina flo-retina 22:45:45 --> jb has joined #instantbird 22:46:16 <-- qlum has quit (Quit: Getting the <censored> out.) 22:46:33 <-- jb has quit (Write error: Connection reset by peer) 22:55:43 --> jb has joined #instantbird 22:56:47 <-- flo-retina has quit (Ping timeout) 22:58:47 --> flo-retina has joined #instantbird 22:58:47 * ChanServ sets mode +qo flo-retina flo-retina 23:04:15 <-- jb has quit (Ping timeout) 23:11:09 <qheaden> Hello. 23:13:33 <qheaden> clokep_: I just read the scollback. I'll make those changes to the mobile status patch. 23:17:18 --> clokep has joined #instantbird 23:17:18 * ChanServ sets mode +o clokep 23:18:40 <clokep> qheaden: Sounds good. :) 23:21:36 <-- flo-retina has quit (Ping timeout) 23:30:30 <-- EionRobb has quit (Ping timeout) 23:32:08 --> flo-retina has joined #instantbird 23:32:08 * ChanServ sets mode +qo flo-retina flo-retina 23:36:06 --> EionRobb has joined #instantbird 23:38:06 --> jb has joined #instantbird 23:49:06 <-- gerard-majax has quit (Ping timeout) 23:53:58 <-- flo-retina has quit (Ping timeout) 23:55:25 --> flo-retina has joined #instantbird 23:55:25 * ChanServ sets mode +qo flo-retina flo-retina