All times are UTC.
00:26:43 --> EionRobb has joined #instantbird 00:42:46 <-- EionRobb has quit (Connection reset by peer) 00:52:47 --> EionRobb has joined #instantbird 00:55:29 <-- qlum has quit (Quit: Getting the <censored> out.) 01:02:58 <-- EionRobb has quit (Quit: Leaving.) 01:06:13 --> EionRobb has joined #instantbird 01:07:53 <-- EionRobb has quit (Connection reset by peer) 01:09:18 --> EionRobb has joined #instantbird 01:15:44 <-- EionRobb has quit (Connection reset by peer) 01:20:11 --> EionRobb has joined #instantbird 01:20:27 <-- EionRobb has quit (Quit: Leaving.) 02:35:43 <-- Suiseiseki has quit (Ping timeout) 02:37:06 --> Suiseiseki has joined #instantbird 03:01:25 <-- skeledrew has quit (Connection reset by peer) 03:14:15 --> nhnt11 has joined #instantbird 03:32:44 <instant-buildbot> build #971 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/971 03:51:41 --> EionRobb has joined #instantbird 03:54:41 --> clokep has joined #instantbird 03:54:41 * ChanServ sets mode +o clokep 03:55:05 <instant-buildbot> build #1077 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1077 03:59:49 <-- wnayes has quit (Quit: wnayes) 04:10:08 <-- EionRobb has quit (Quit: Leaving.) 04:21:14 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:30:05 --> mconley has joined #instantbird 05:11:12 <-- nhnt11 has quit (Ping timeout) 05:13:43 --> nhnt11 has joined #instantbird 05:21:42 <-- mconley has quit (Input/output error) 05:41:07 <-- nhnt11 has quit (Input/output error) 05:47:55 --> nhnt11 has joined #instantbird 06:29:37 <-- nhnt11 has quit (Ping timeout) 06:49:47 --> jb has joined #instantbird 07:05:01 <-- jb has quit (Ping timeout) 07:45:45 --> EionRobb has joined #instantbird 07:51:48 --> jb has joined #instantbird 07:57:22 <-- EionRobb has quit (Quit: Leaving.) 08:23:14 <-- jb has quit (Ping timeout) 08:24:09 --> EionRobb has joined #instantbird 08:25:53 <-- Even has quit (Ping timeout) 08:27:46 <-- EionRobb has quit (Connection reset by peer) 08:37:00 --> Mic has joined #instantbird 08:37:00 * ChanServ sets mode +h Mic 08:44:56 --> Even has joined #instantbird 08:44:56 * ChanServ sets mode +o Even 08:48:20 <-- Mic has quit (Ping timeout) 08:54:38 <-- jamesw has quit (Client exited) 09:12:32 <-- Even has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:15:56 --> jamesw has joined #instantbird 09:29:21 --> jb has joined #instantbird 09:40:25 --> qlum has joined #instantbird 09:40:32 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:42:12 <-- florian has quit (Ping timeout) 09:46:57 <-- jb has quit (Quit: jb) 09:49:58 --> jb has joined #instantbird 09:59:27 <-- jb has quit (Quit: jb) 10:08:27 <-- jamesw has quit (Ping timeout) 10:18:41 --> Even has joined #instantbird 10:18:42 * ChanServ sets mode +o Even 11:02:02 <-- dew has quit (Ping timeout) 11:02:28 --> dew has joined #instantbird 11:06:24 --> jamesw has joined #instantbird 12:04:34 --> clokep has joined #instantbird 12:04:34 * ChanServ sets mode +o clokep 12:10:07 --> aleth has joined #instantbird 12:10:07 * ChanServ sets mode +h aleth 12:17:05 --> florian has joined #instantbird 12:19:05 <aleth> I'm not super concerned by the "wastes too much space" aspect of bubbles, whitespace isn't a bad thing in layout for readability. We could provide a denser default alternative though with some bubbles features. 12:20:01 <aleth> I fixed the waste-of-space issue I personally cared about in Fitted-Bubbles ;) 12:21:39 --> flo-retina has joined #instantbird 12:21:40 * ChanServ sets mode +qo flo-retina flo-retina 12:22:12 <-- florian has quit (Ping timeout) 12:22:17 * aleth likes the hr improvements though :) 12:23:12 --> florian has joined #instantbird 12:23:25 <flo-retina> I was frustrated that the mac builder went offline 2 days ago (likely because of the fast but flaky internet connection I have at home) and didn't reconnect, so I configured the mac mini to turn itself off automatically at 1pm and start automatically at 6pm. I don't think we ever push anything during that time frame, and that should ensure it never stays offline more than 24h due to connection flakiness. 12:23:57 <aleth> Saves power as well :) 12:24:17 <flo-retina> not much 12:24:17 <flo-retina> mac minis are <30W IIRC 12:24:20 <flo-retina> bah, < 30W 12:24:21 * aleth suspects the packaging issue also broke incremental updates 12:24:33 <flo-retina> packaging issue? 12:24:54 <aleth> The broken include-everything packaging of nightlies 12:24:58 <flo-retina> Even is working on the Windows VM right now :). 12:25:10 <aleth> Thanks Even :) 12:25:15 <Even> no problem 12:25:19 <Even> though it's a boring process 12:25:20 <Even> :P 12:25:34 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:25:42 <Even> new Windows - check 12:25:45 <aleth> Updating the Linux VM may be less boring (but more frustrating) ;) 12:25:48 <Even> VS 2010 on it - check 12:25:51 <Even> that's the current status 12:26:05 <Even> coming : DirectX SDK + mozilla build 12:28:15 <-- florian has quit (Ping timeout) 12:28:20 <-- flo-retina has quit (Ping timeout) 12:29:09 --> florian has joined #instantbird 12:30:49 <-- florian has quit (Ping timeout) 12:31:49 --> florian has joined #instantbird 12:33:01 <florian> aleth: I think there are 2 problems related to wasting space in Bubbles: 1. It's unusable for busy channels. 2. People may assume '1.' is obviously true (even if we find ways to address it) and decide that it's not a theme they can use (or say non sense like 'an IM client can't be usable for IRC'). 12:33:31 <florian> 14:27:27 - flo-retina: aleth: if you like the modified hr, feel free to review the patch ;) 12:33:52 <florian> (I should stop trying to use IRC in trains, it's too unreliable :() 12:34:12 <aleth> Trying to optimize for a pretty layout for normal conversations and for busy IRC channels at the same time is hard. 12:34:39 <florian> That doesn't mean it's impossible 12:35:11 <florian> I think Bubbles could go above each other when people are talking at the same second 12:35:13 <florian> that may be ugly, but it would convey well that people are talking past each other 12:35:30 <aleth> Isn't it also harder to read? 12:36:48 --> florian1 has joined #instantbird 12:36:49 <aleth> If you do want to experiment with that, I'd try for making the Bubbles more "schematic" when messages arrive really quickly. i.e. drop the curved shape, less borders, just background colour to differentiate the speaker 12:36:53 <-- florian has quit (Ping timeout) 12:36:59 <instant-buildbot> build #993 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/993 12:37:30 <florian1> we still need to display the nick somewhere 12:38:00 <florian1> btw, getting rid of the system message bubble's border helps a lot with the nick outline there that looked strange. 12:38:02 <aleth> It could act as a hanging indent 12:38:31 <aleth> Did you ever try my patch for that btw? 12:39:04 <florian1> I don't remember which patch you are talking about, so the answer is likely no 12:39:04 <florian1> ah, the one for nick outlines? 12:39:12 <aleth> Yes 12:39:49 <aleth> (not as an alternative to what you were saying, I just think it works quite well) 12:40:44 <-- florian1 has quit (Ping timeout) 12:41:03 <-- BWMerlin has quit (Quit: BWMerlin) 12:41:24 --> florian has joined #instantbird 12:43:03 <-- florian has quit (Ping timeout) 12:45:01 --> florian has joined #instantbird 12:45:25 <florian> 14:41:55 - florian: 14:39:07 - florian1: ah, the one for nick outlines? 12:45:25 <florian> 14:41:55 - florian: 14:39:22 - florian1: no, I didn't (I think you showed a screenshot or two though) 12:45:26 <florian> 14:41:55 - florian: 14:40:02 - florian1: "There's a problem with the hr patch I attached yesterday: the hr in system message bubbles end up darker than the shadow of system bubbles. I think I need to change the color of the shadow to make it more visible." never arrived :( 12:45:33 <instantbot> aleth@instantbird.org set the Resolution field on bug 1936 to WONTFIX. 12:45:34 <instantbot> aleth@instantbird.org cancelled feedback?(benediktp@ymail.c om) for attachment 2391 on bug 1936. 12:45:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1936 enh, --, ---, aleth, RESO WONTFIX, Use logical weeks for "this/last week" groups in log viewer 12:45:53 <florian> (and the train is almost at the airport, so I'll stop trying to connect with the phone for now) 12:45:58 * aleth wonders if you got told they weren't sent, in a system message? 12:46:08 <florian> aleth: not at all 12:46:13 <aleth> :( 12:46:16 <florian> aleth: I just checked instantbot's log 12:47:00 <aleth> I guess that means your socket thought it sent them 12:47:56 <-- florian has quit (Ping timeout) 13:02:23 <-- aleth has quit (Quit: Ciao) 13:02:27 --> aleth has joined #instantbird 13:02:27 * ChanServ sets mode +h aleth 13:26:26 <instant-buildbot> build #1081 of win32-nightly-default is complete: Exception [exception interrupted] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1081 13:30:25 <Even> ok, first build :) 13:30:28 <Even> hope this works 13:30:42 <Even> configure passed 13:30:45 <Even> that's a good point 13:30:46 <Even> :) 13:31:15 <Even> it's build #1082 13:32:46 <Even> status 13:32:56 <Even> instant-buildbot: status 13:32:56 <instant-buildbot> linux-nightly-default: offline 13:32:57 <instant-buildbot> linux-onCommit: offline 13:32:57 <instant-buildbot> macosx-nightly-default: idle, last build 55m57s ago: build successful 13:32:57 <instant-buildbot> macosx-onCommit: idle, last build 49h55m36s ago: build successful 13:32:57 <instant-buildbot> win32-nightly-default: building(compiling) [ETA 4h37m12s] 13:32:57 <instant-buildbot> win32-onCommit: idle, last build 31h19m46s ago: failed compile 13:33:05 <Even> cool :) 13:38:56 --> FireFly_TB has joined #instantbird 13:41:48 <instantbot> New Core - Yahoo! Messenger bug 2174 filed by aleth@instantbird.org. 13:41:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2174 nor, --, ---, nobody, NEW, No handler for Yahoo! packet 84. 13:53:18 <instantbot> aleth@instantbird.org granted review for attachment 2885 on bug 2171. 13:53:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2171 nor, --, ---, nobody, NEW, bubbles shouldn't fade in when displayed in the log viewer 14:10:12 <-- FireFly_TB has quit (Ping timeout) 14:12:44 <qheaden> Hello. 14:12:57 <qheaden> aleth: I'm looking more into bug 2149. 14:13:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2149 nor, --, ---, nobody, NEW, Attempting to store duplicate buddy error after failed auth request 14:40:06 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2888 on bug 2173. 14:40:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, aleth, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 14:49:45 --> clokep has joined #instantbird 14:49:46 * ChanServ sets mode +o clokep 14:53:18 <clokep> aleth: Did you confirm that we're not sending anything to the server in bug 2173? 14:53:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, nobody, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 14:53:31 <clokep> (And that that fixes it, if we are.) 15:20:19 --> mconley has joined #instantbird 15:21:57 <-- mconley has quit (Input/output error) 15:31:52 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2888 on bug 2173. 15:31:53 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2890 on bug 2173. 15:31:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, aleth, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 15:33:23 <aleth> clokep: Now it doesn't ;) 15:33:54 <aleth> That was worth checking... 15:36:01 <clokep> aleth: That has a dupm call stil. 15:36:08 <aleth> :( 15:37:29 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2890 on bug 2173. 15:37:30 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2891 on bug 2173. 15:37:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, aleth, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 15:38:23 <clokep> aleth: Still there. ;) 15:38:41 <clokep> aleth: Why the !this._topicSetter check? 15:40:30 <aleth> Because if the topic setter isn't set, then we shouldn't rely on a comparison with it 15:42:31 <clokep> OK, when does that happen? 15:42:50 <aleth> I can't think of a case, but I thought I should fix the edge case anyway in case it ever does. 15:42:59 <clokep> OK. 15:43:04 * clokep needs to think a bit more about this. :) 15:43:12 <aleth> Some protocols may always have null as the topic setter for example... 15:43:26 <clokep> Wouldn't we just have null == null? :-S 15:44:17 <aleth> I mean they may not tell us who set the topic when we join. 15:44:28 <aleth> But we may keep track of it once we are joined 15:44:44 <clokep> OK. 15:45:38 <instantbot> aleth@instantbird.org cancelled review?(clokep@gmail.com) for attachment 2891 on bug 2173. 15:45:39 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2892 on bug 2173. 15:45:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, aleth, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 15:46:34 <aleth> Or did I confuse myself there? 16:24:41 <qheaden> Hey clokep. 16:25:29 <clokep> Hello qheaden. 16:26:09 <qheaden> clokep: So tomorrow is the soft pencils down date. Should I just continue my development as I am doing now, or do I need to divert my attention elsewhere? 16:26:57 <clokep> qheaden: Continuing on the things blocking us from enabling it by default. 16:27:06 <qheaden> clokep: Okay, great. 16:30:27 <qheaden> clokep: As for bug 2131, I think the main solution is to simply keep key 14 empty instead of using the localized message. After looking at the libpurple packets in WireShark, it seems that key 14 isn't filled. 16:30:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2131 nor, --, ---, nobody, NEW, "Would you like to be my chat buddy" sent on accepting buddy auth request 16:31:44 <clokep> qheaden: I'll need to refresh myself, but OK. 16:33:15 <qheaden> aleth: I tried following your STR on bug 2149, but I'm not getting any errors. 16:33:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2149 nor, --, ---, nobody, NEW, Attempting to store duplicate buddy error after failed auth request 16:38:17 --> mikk_s has joined #instantbird 16:38:29 <-- mikk_s has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 16:45:45 <aleth> qheaden: You're not getting any errors anymore because you now check before trying to store a duplicate buddy. That doesn't mean the code is doing the right thing... 16:46:24 <aleth> Though it's possible it is doing the right thing. As I said in my comment, what's the expected behaviour? 16:46:49 <qheaden> aleth: Ahh yeah, that's true. I'm still not sure though why they both collided. When a domain is included with the username, and it isn't @yahoo.*, it shouldn't have any problems. 16:47:32 <qheaden> aleth: I tried your STR and I got two separate buddies. 16:48:09 <aleth> Two separate buddies is correct if those are also two buddies from the yahoo pov 16:48:49 <aleth> Maybe try to talk to both those buddies and see if things get mixed up or not 16:49:24 --> nhnt11 has joined #instantbird 16:51:16 <dew> man I feel like just looking at the omegle plugin is over my head 16:53:56 <clokep> dew: Start off slow, just create the initial objects and add feature by feature. :) 17:03:45 <dew> I'm just trying to comprehend what's going on 17:06:36 <clokep> Ask questions if you have 'em. :) 17:09:01 * nhnt11 hopes he gets time to try and write a WhatsApp plugin sometime before next summer 17:10:57 * aleth wonders if qheaden will have to change the yahoo icon now they've changed their favicon 17:11:11 * qheaden wondered the same thing. 17:25:51 --> wnayes has joined #instantbird 17:27:07 <dew> I just feel like I need some background on JavaScript 17:31:51 --> mconley has joined #instantbird 17:32:25 <dew> like the purpose of the prototype keyword, it's throwing me off for whatever reason 17:34:34 <nhnt11> dew: This article was a good read for me when I was confused by OOP in js - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Introduction_to_Object-Oriented_JavaScript 17:35:03 <dew> thank you. I will give it a read! 17:35:20 <aleth> dew: Do you know about inheritance? 17:35:37 <nhnt11> Particularly the bit about inheritance in that article was useful 17:36:09 <dew> yes I know about inheritance a bit from C++ 17:37:59 <-- mconley has quit (Input/output error) 17:38:07 <aleth> If you don't want to get into the nitty gritty, just think of the object inheriting stuff from its prototype. 17:41:52 <dew> Thanks! I will read these just so I can cover my bases before asking more questions :) 18:10:46 <nhnt11> Hmm, I think I have some time to look at bug 2143 now 18:10:46 <nhnt11> :D 18:10:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 18:12:27 <nhnt11> aleth: I'm not clear on the status of bug 2168. Mic r+'d the patch which I thought was decided against for now? 18:12:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2168 nor, --, ---, nhnt11, NEW, Tab key doesn't behave as expected in the new conversation tab. 18:13:24 * nhnt11 always seems to miss Mic. 18:14:42 <aleth> I'm not sure what the correct thing to do is there. We could simply try that patch in nightlies and see if it feels right. 18:15:21 <aleth> Mic has tried it so let's go with that :) 18:15:43 <nhnt11> Ok, fine by me. Just wanted to clear it up 18:16:45 <aleth> My comment on that bug was just to point out a different possible approach (taken eg by the awesomebar), not sure if for the newtab that would actually be better than the patch that is there 18:17:41 <nhnt11> aleth: I don't think the awesomebar behavior is very suitable for the newtab, becaue the awesomebar shows only 12 entries at a time whereas the newtab could be showing 100's. 18:18:10 <nhnt11> (so shift-tab/tab should work for selecting the filterbox directly from the middle of the list) 18:18:29 <aleth> Good point 18:19:12 <nhnt11> Bah. I'm not going to worry about this more now. I don't have too much time and 2143 is a priority ;) 18:19:54 <nhnt11> Btw, I'm going to use the global gStatsService variable if it makes things easier, as flo suggested. 18:20:33 <aleth> In your last patch it didn't seem like it was needed? 18:21:20 <nhnt11> Yeah, but making ConversationStats listen for observer notifications from prplConversations makes a lot of sense 18:21:57 <nhnt11> and if I do that, having a gStatsService variable would be nice. And it would allow me to shift some of the code for getting stats/scores for conversations to the PossibleConversation prototype. 18:22:37 <aleth> If you feel it helps... I kind of agreed with your comment "why shouldn't the stats service handle the stats" ;) 18:23:31 <nhnt11> Yay. The way I wrote this made sense to me. 18:23:54 <nhnt11> If I'm not the only one who thinks it makes sense then, I'd rather /not/ move the code to PossibleConversation :P 18:24:30 <aleth> Maybe I missed the reason for moving it? ;) 18:25:39 <aleth> What I'd look at is getFilteredConvs and the way existingConvs are handled there 18:26:06 <aleth> It seems that could be simplified now the existingConvs are exactly the ones you are continually updating and moving around for stats 18:26:13 <nhnt11> flo seemed to think computedScore fit better in PossibleConversation (from his review comments) 18:26:18 <aleth> Maybe it's enough to move them around in getFilteredConv for example 18:26:24 <nhnt11> Yeah I'm going to think about that now. 18:28:14 <aleth> Or keep the existingConvs around and have them observe their conversations and update the corresponding stats 18:28:31 <aleth> Lots of possible permutations... 18:28:36 <nhnt11> That's an interesting idea 18:28:57 <nhnt11> in that case it would make sense for an existing conv to have the same idea as the corresponding (not-existing) conv. 18:29:04 <nhnt11> same id* 18:29:20 <aleth> As far as stats are concerned there is no difference 18:29:39 <aleth> (Apart from the contact/buddy issue I guess) 18:29:59 <nhnt11> aleth: That's not an issue 18:30:09 <nhnt11> an existing conv needs to update the stats for the buddy currently in conversation. 18:30:45 <aleth> Right 18:30:57 <aleth> And that's no problem... 18:35:37 <instantbot> clokep@gmail.com granted review for attachment 2892 on bug 2173. 18:35:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2173 min, --, ---, aleth, ASSI, Clicking the topic in the header of an IRC channel with no topic and focusing something else without 18:44:48 <-- aleth has quit (Quit: Ciao) 19:01:31 --> mconley has joined #instantbird 19:24:58 <nhnt11> OK, I've done some experimenting on this. 19:26:13 <nhnt11> I no longer think it's a great idea to try and maintain one list of conversations for both observing for new texts and for replacing PossibleConversations with Existing ones. 19:26:32 <-- mconley has quit (Ping timeout) 19:26:47 <nhnt11> This is because I need to listen to the /prplConversation/ for new-texts, since the prplConversation for a given UI conversation can change 19:26:58 <nhnt11> (if the user changes the account from which he's conversing with the buddy in question) 19:27:33 <nhnt11> As of now, I can think of no way to maintain a unified list of some sort that would simplify things. 19:29:20 <nhnt11> There's the argument that I can use the imConversation's target every time I get a new text and be guaranteed to be referring to the correct prplConversation 19:29:47 <nhnt11> But in that case, I would have to ensure the stats for the prplConversation exist on every new text, and "compute" the id every time as well 19:30:36 <nhnt11> The alternative is to listen for both new-ui-conversation and new-conversation (and the corresponding conversation-closed notifications) 19:30:44 <nhnt11> But this is just over-complicating things imho. 19:32:19 <nhnt11> I don't have any time to explore this further right now, so I'm going to leave it as it is (keep references to prplConversation id's, and get ui conversations at filter time). 19:32:49 <nhnt11> (I hope all of this is clear) 19:56:32 <nhnt11> clokep: ping 19:57:02 <clokep> nhnt11: Yes? 19:57:31 <nhnt11> Pastebinning.. 19:57:56 <nhnt11> clokep: http://pastebin.instantbird.com/341005 19:58:09 <nhnt11> Does that make sense? Also I can't think of a better name for that function. 19:59:13 <nhnt11> (I realize the "else if" can just be an "if" btw) 20:00:35 --> mconley has joined #instantbird 20:01:27 <clokep> nhnt11: Get rid of the else. 20:01:38 <nhnt11> Already did :) 20:02:07 <clokep> I don't know exactly how it's being used and stuff so I'm not sure what else to say... 20:02:36 <nhnt11> clokep: I use it on two conversations, and subtract the values I get to compare. 20:02:41 <nhnt11> It's used for sorting. 20:03:05 <clokep> nhnt11: Why don't you just create a sorting method then? 20:03:17 <nhnt11> clokep: The function is /in/ the sorting method. 20:03:31 <nhnt11> This is one parameter that it uses to compare two chats. 20:03:46 <nhnt11> I made it a function to avoid duplication since I have to get the priority of both chats. 20:03:51 <nhnt11> convs* 20:04:23 <nhnt11> Er, convs* in both of those messages 20:05:29 <clokep> OK. 20:07:57 <nhnt11> So.. is it reasonable? 20:08:21 <nhnt11> And as usual I'm not great with naming these things so I was wondering if that was ok. 20:14:17 <clokep> Umm...why can't you just compare the fields one by one? I'm unsure why you need to have an extra method. 20:14:21 <clokep> But I don't have the full context. 20:14:24 <clokep> Soooooooo 20:15:17 <nhnt11> clokep: Would you like to see the whole sortComparator method if you're free? It may clear it up... 20:15:27 <clokep> nhnt11: Yes. 20:15:54 <nhnt11> clokep: http://pastebin.instantbird.com/341026 20:16:42 <clokep> nhnt11: Personally I find that code essentially unreadable. 20:16:57 <nhnt11> :( 20:17:13 <nhnt11> Some empty lines are probably in order 20:17:20 <clokep> Sure. 20:17:49 <clokep> But why can't you do if (scoreA > scoreB) return 1, if (scoreA < scoreB) return -1, if foo, return blah, etc. 20:17:50 <clokep> Step by step. 20:17:55 <clokep> Instead of trying to do it all at once. 20:18:39 <nhnt11> Well the score priority thing is the most important parameter, and it requires me to compute the scores first 20:18:57 <clokep> Yes, so? 20:19:11 <nhnt11> You're saying the return statement is unreadable? 20:19:54 <nhnt11> There are four parameters, which would mean 8 if's 20:20:11 <clokep> OK. 20:20:15 <clokep> I don't see what the issue is. 20:20:36 <clokep> Besides which, isn't that only returning true or false right now? 20:20:50 <clokep> If this is really a sort comparator, it needs to return 1, 0 or -1. 20:21:20 <nhnt11> Wow 20:21:24 <nhnt11> How did I not see that 20:21:38 <nhnt11> I figured it would keep evaluating those expressions and return the first one that wasn't 0 20:24:03 <clokep> Um, it'll return true if any are true, yes. 20:26:11 --> EionRobb has joined #instantbird 20:26:31 <nhnt11> clokep: So I dumped the value of that return statement and it's returning an integer. 20:26:59 <clokep> nhnt11: OK, I'm not saying it doesn't do what you want it to, I'm saying it's confusing. 20:28:18 <nhnt11> The current sortComparator looks so simple :( http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#125 20:28:55 <clokep> What're you trying to do, exactly? 20:29:04 <clokep> Are you dealing with review comments or just trying to get it tow ork or what? 20:29:52 <nhnt11> Dealing with review comments 20:30:03 <nhnt11> And making it less confusing in general 20:30:07 <nhnt11> I'm not happy with the code. 20:30:29 <nhnt11> It looks a /lot/ better if I make getScoreForConv a property of the stats service 20:33:15 <nhnt11> clokep: This looks better I think: http://pastebin.instantbird.com/341059, and with your suggestion of having multiple if's: http://pastebin.instantbird.com/341058 20:34:32 <clokep> nhnt11: I'd suggest asking whoever is going to review this. ;) 20:35:14 <nhnt11> ok 20:38:56 <nhnt11> Bah, it's late 20:40:29 --> nhnt11-testing has joined #instantbird 20:45:50 <nhnt11> qheaden: I think I found out the reason buddy icons for contacts weren't being properly set in the newtab :) 20:46:03 <nhnt11> (Until you open a conversation with the contact) 20:46:18 <-- nhnt11-testing has quit (Client exited) 20:51:01 <nhnt11> Hmm, I can't remember who else was experiencing this problem. Maybe I'll r? qheaden ;) 20:51:46 * nhnt11 will r? the wind. 21:12:36 <-- mconley has quit (Input/output error) 21:31:31 <instantbot> New Instantbird (UI) bug 2175 filed by nhnt11@gmail.com. 21:31:32 <instantbot> nhnt11@gmail.com requested review from the wind for attachment 2893 on bug 2175. 21:31:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2175 nor, --, ---, nobody, NEW, Buddy icons for contacts are not updated in the new conversation tab 22:03:17 <-- clokep has quit (Ping timeout) 22:10:14 <-- wnayes has quit (Ping timeout) 22:10:20 <-- dew has quit (Ping timeout) 22:13:38 --> wnayes has joined #instantbird 22:20:11 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2884 on bug 2143. 22:20:12 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2894 on bug 2143. 22:20:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 22:20:33 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:30:02 --> dew has joined #instantbird 22:43:48 <-- qlum has quit (Quit: Getting the <censored> out.) 23:08:46 --> Mic has joined #instantbird 23:08:46 * ChanServ sets mode +h Mic 23:21:37 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:22:04 --> mconley has joined #instantbird 23:22:58 <-- mconley has quit (Input/output error) 23:26:02 --> mconley has joined #instantbird 23:37:22 <-- mconley has quit (Input/output error) 23:37:59 --> mconley has joined #instantbird 23:43:38 <instantbot> benediktp@ymail.com requested review from benediktp@ymail.com for attachment 2893 on bug 2175. 23:43:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2175 nor, --, ---, nobody, NEW, Buddy icons for contacts are not updated in the new conversation tab 23:44:28 <-- mconley has quit (Input/output error)