#instantbird log on 09 10 2013

All times are UTC.

00:00:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy
00:01:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f0cd4b1b5222 - Nihanth Subramanya - Bug 2157 - Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos, r=clokep,fqueze.
00:03:04 * clokep has cleared out his review queue. ;)
00:03:53 * clokep can't steal any of flo retina's reviews. :(
00:04:42 <clokep> Although it looks like flo-retina already r+ed https://bugzilla.instantbird.org/attachment.cgi?id=2833&action=edit and just never put it in the bug. :)
00:06:14 <instantbot> florian@instantbird.org granted review for attachment 2833 on bug 2066.
00:06:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab should suggest chat rooms
00:10:29 <instant-buildbot> build #465 of linux-onCommit is complete: Failure [failed shell_1]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/465  blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com>
00:11:36 <clokep> flo-retina: Did that fail again or is that from last time? :-S
00:12:37 <flo-retina> from last time
00:21:38 <-- dionisos has quit (Ping timeout)
00:22:28 <instant-buildbot> build #463 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/463
00:30:47 <instant-buildbot> build #464 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/464  blamelist: Nihanth Subramanya <nhnt11@gmail.com>
00:35:38 <flo-retina> "make[7]: *** [../../dist/include/nsCSSPseudoElements.h] Segmentation fault: 11" :-S
00:35:57 <flo-retina> (anyway, pretend I didn't see this, and am already asleep ;))
00:36:02 <flo-retina> Good night
00:38:52 <instant-buildbot> build #466 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/466
00:41:17 <clokep> Not me. :)
00:49:59 <-- nhnt11 has quit (Input/output error)
00:56:51 * clokep pokes qheaden.
00:59:16 <-- Mook_as has quit (Quit: Mook_as)
01:20:38 <qheaden> Hello again.
01:21:07 <qheaden> clokep: Sorry about that test failure.
01:23:31 <clokep> qheaden: No problem, just wanted to slap your wrists for it. :)
01:23:39 <qheaden> :P
01:23:53 * qheaden needs to remember to run tests.
01:27:19 <clokep> :)
01:27:28 <clokep> qheaden: So I think you're getting close then?
01:27:45 <qheaden> clokep: I think so. I'm pretty excited. :)
01:28:15 <qheaden> When the nightly builds with the new changes, we can run another test. Perhaps tomorrow.
01:28:18 <clokep> :)
01:28:35 <clokep> If Windows builds, sure.
01:29:16 <qheaden> :)
01:37:51 <-- mconley has quit (Ping timeout)
01:38:25 --> mconley has joined #instantbird
01:40:12 <-- dew has quit (Ping timeout)
01:41:10 --> dew has joined #instantbird
01:46:48 <qheaden> clokep: In bug 2102, you want me to use the ping functionality of Socket to send keepalive packets, and use a separate timer for pings?
01:46:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings
01:47:27 <clokep> qheaden: I don't know. I feel like we should be using thebuilt in timer for one of them.
01:48:17 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
01:49:13 <qheaden> clokep: I don't think the Yahoo servers send back an acknowledgement for keepalive packets. So I wouldn't know when to call cancelDisconnectTimer to prevent a disconnection.
01:49:42 <qheaden> Ping packets get acknowledgements, but their timing requirements don't fit what Socket provides, unless we provide away of changing the ping timing.
01:51:18 <clokep> qheaden: OK, do what you think is best.
01:56:55 <-- mconley has quit (Ping timeout)
01:57:17 --> mconley has joined #instantbird
02:03:19 <qheaden> clokep: How about we leave the patch for 2102 as-is, and then we can make another bug to improve ping functionality in socket.jsm?
02:03:41 <clokep> qheaden: I'd rather do it all at once.
02:04:20 <qheaden> clokep: Okay. I'm going to modify the code in socket.jsm to allow us to set the ping time.
02:04:45 <qheaden> As for keepalive packets, I think we can still send those out from our own Yahoo code.
02:04:59 <qheaden> It also seems quite confusing to send out keepalive packets in a sendPing method.
02:05:23 <clokep> qheaden: rgr
02:18:13 <-- mconley has quit (Input/output error)
03:06:03 <qheaden> clokep: I'm really confused on what I should do with 2102. Looking at the Socket ping code, the timer is reset whenever we know the socket is still open. Pings are only sent when we don't receive data after the given time. libpurple sent pings and keepalive requests regardless of messages sent/received.
03:06:24 <qheaden> Well, at least keepalive. I never waited around an hour to view ping messages.
03:08:15 <clokep> qheaden: If the API doesn't seem to fit, then justify in the bug why we should take the current patch.
03:09:36 <clokep> Remember that reviews are also a discussion. :)
03:12:11 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:23:12 <-- qheaden has quit (Quit: ZNC - http://znc.in)
03:24:16 <instant-buildbot> build #966 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/966
03:28:56 --> mconley has joined #instantbird
03:29:44 --> qheaden has joined #instantbird
03:33:39 <instant-buildbot> build #989 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/989
03:54:55 --> FireFly_TB has joined #instantbird
04:24:15 <-- mconley has quit (Input/output error)
04:29:13 <instant-buildbot> build #1067 of win32-nightly-default is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1067
04:45:39 <-- dew has quit (Ping timeout)
04:59:29 <-- ivan has quit (Ping timeout)
05:01:29 --> ivan has joined #instantbird
05:33:42 <-- micahg has quit (Ping timeout)
05:34:24 --> micahg has joined #instantbird
06:17:45 --> gerard-majax_ has joined #instantbird
06:21:01 <-- EionRobb has quit (Quit: Leaving.)
06:31:11 <instant-buildbot> build #455 of win32-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/455  blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com>
06:35:17 --> dionisos has joined #instantbird
06:49:44 --> jb has joined #instantbird
07:26:26 <-- gerard-majax_ has quit (Ping timeout)
07:30:12 <instant-buildbot> build #456 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/456
07:43:15 <-- Suiseiseki has quit (Ping timeout)
07:44:44 --> Suiseiseki has joined #instantbird
07:47:50 --> gerard-majax_ has joined #instantbird
07:56:45 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
07:56:47 --> flo-retina has joined #instantbird
07:56:48 * ChanServ sets mode +qo flo-retina flo-retina 
09:17:45 <-- dionisos has quit (Ping timeout)
09:23:58 <-- jb has quit (Ping timeout)
09:32:12 --> Mic has joined #instantbird
09:32:12 * ChanServ sets mode +h Mic 
09:33:09 <Mic> Hi
09:34:04 <-- flo-retina has quit (Ping timeout)
09:34:15 --> flo-retina has joined #instantbird
09:34:15 * ChanServ sets mode +qo flo-retina flo-retina 
09:35:15 <Mic> flo-retina: could we maybe have a workaround for the Windows build problem if the build VM isn't going to be ready soon?
09:35:33 <flo-retina> do you have a suggestion for a valid workaround?
09:36:20 <flo-retina> Mic: what's the status of bug 1322, bug 2042 and bug 2107?
09:36:21 <Mic> Didn't you suggest that disabling parts of the platform might reduce the size enough to build? WebRTC or something like that?
09:36:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1322 tri, --, ---, nobody, NEW, Tags should be sorted using localeCompare
09:36:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nhnt11, ASSI, Starting conversations on unrelated keyboard- or mouse-events
09:36:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2107 nor, --, ---, nobody, NEW, Fix theming of the overflow "+" button on Windows
09:36:45 <flo-retina> yeah, if people think it's acceptable, we could turn off webrtc
09:38:42 <Mic> If nobody's having plans to use it in the near future (i.e. before we get the new build VM), it would be cool if we could try if that helps.
09:39:08 <flo-retina> hmm, ok
09:39:20 <flo-retina> (btw, the ETA for the new VM is the end of this week).
09:39:33 <Mic> If it would get in someone's way then I'd be patient ofcourse.
09:40:47 <flo-retina> bbiab
09:40:48 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:43:03 <Mic> I'll have a look at these bugs today.
09:56:16 <instantbot> benediktp@ymail.com granted review for attachment 2711 on bug 2107.
09:56:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2107 nor, --, ---, nobody, NEW, Fix theming of the overflow "+" button on Windows
10:05:31 --> clokep has joined #instantbird
10:05:31 * ChanServ sets mode +o clokep 
10:15:31 --> flo-retina has joined #instantbird
10:15:31 * ChanServ sets mode +qo flo-retina flo-retina 
10:24:24 <clokep> flo-retina: I think a new VM by the end of the week is fine.
10:35:31 --> dionisos has joined #instantbird
10:42:20 <clokep> flo-retina: What's the dealwith our l10n stuff? That's still broken, I assume?
10:42:33 <flo-retina> nobody fixed it, so yes
10:49:54 <clokep> Hm, OK.
10:50:00 * clokep isn't sure what's even wrong w/ it.
10:51:42 <flo-retina> looks like it means I need to fix it myself :-/
10:55:34 <clokep> Ah, right "configure: error: Can't find header linux/joystick.h, needed for gamepad support. Please install Linux kernel headers or reconfigure with --disable-gamepad to disable gamepad support.", do we need to update the VM?
10:55:49 <flo-retina> no
10:56:11 <flo-retina> do you really think joystick.h is required to compare .properties files with a python tool? ;)
10:58:58 <clokep> I have no idea how the l10n VM works.
10:59:11 <clokep> l10n build, rather.
10:59:15 <flo-retina> it's unrelated to the VM
10:59:24 <clokep> Yes, that was a typo.
10:59:34 <flo-retina> configure has a --disable-compile environment that is intended to let configure pass even if there's no compiler installed
10:59:46 <flo-retina> so that makefiles are created, and we can use make in the locales/ folders.
11:00:15 <clokep> Ah, but it doesn't work anymore?
11:00:20 <flo-retina> http://lxr.instantbird.org/instantbird/source/configure.in#139
11:00:56 <flo-retina> we miss a |if test "$COMPILE_ENVIRONMENT"; then| or two somewhere in configure.in
11:02:13 <flo-retina> in http://buildbot-l10n.instantbird.org/builders/translate/builds/698/steps/compile/logs/stdio, all the lines from "checking for pango" to "checking for linux/joystick.h" look just wrong
11:02:35 <flo-retina> and "checking for custom <stdint.h> implementation... none specified" is a bit strange, but it looks harmless
11:05:44 <clokep> Interesting.
11:06:54 * clokep thought our configure pretty much matched c-r's at this point.
11:07:03 <flo-retina> clokep: it does.
11:07:10 <flo-retina> even the one in m-c has this bug
11:10:14 <-- clokep has quit (Ping timeout)
11:22:04 --> novabyte has joined #instantbird
11:33:32 --> jb has joined #instantbird
12:02:54 --> clokep_ has joined #instantbird
12:09:11 * clokep_ sighs.
12:09:16 <clokep_> Moz24 next week.
12:13:08 <flo-retina> time to release! ;)
12:16:50 <clokep_> I'll start the upgrade tonight, most likely.
12:17:17 <flo-retina> good luck!
12:17:35 <flo-retina> btw, I'm going to Paris for the next 2 days.
12:18:37 <flo-retina> would be nice if the ranking patch was ready for a review for my train ride tomorrow morning ;).
12:25:51 --> mconley has joined #instantbird
12:26:38 <clokep_> :)
12:26:57 <clokep_> If you have time, I'd appreciate you looking over the Http.jsm changes so we can have qheaden fix that before it lands.
12:27:10 <clokep_> s/before it lands/before we enable Yahoo/
12:27:58 <flo-retina> bug number?
12:29:30 --> nhnt11_phone has joined #instantbird
12:31:32 <clokep_> bug 2159
12:31:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2159 nor, --, ---, nobody, ASSI, Port bug 884319
12:32:47 <nhnt11_phone> flo-retina: I'll try to have that patch ready for you :)
12:32:57 <-- mconley has quit (Input/output error)
12:33:38 * nhnt11_phone can't wait to have a clear mq
12:34:32 <flo-retina> nhnt11_phone: would also be nice to finish optimizing the list stuff, and pref it on; but I think you are blocked on waiting for reviews from aleth for that.
12:37:26 * clokep_ never has a hope of a clear mq anymore. ;)
12:37:50 * nhnt11_phone has to go.
12:37:58 <nhnt11_phone> I'll be online later tonight..
12:38:06 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
13:39:54 --> dew has joined #instantbird
13:43:41 * clokep_ wonders if flo-retina has an opinion on https://bugzilla.instantbird.org/show_bug.cgi?id=2102#c4
13:43:44 <instantbot> Bug 2102 nor, --, ---, qheaden, ASSI, Support Server Pings
13:44:13 <flo-retina> about whether we should use Socket.jsm's ping?
13:44:25 <clokep_> Yes.
13:45:19 <flo-retina> I don't think we should complicate the socket.jsm code to handle cases that aren't what it was designed to do
13:46:11 <flo-retina> the other part of the question is: can Yahoo's pinging behavior be changed to match what socket.jsm offers? I have really no idea there.
13:52:14 <clokep_> OK. :)
13:54:38 --> mconley has joined #instantbird
13:54:43 --> deltafalcon has joined #instantbird
14:13:38 <-- novabyte has quit (Quit: bye bye)
14:16:13 <Mic> Any idea why I have these Test* files in my Instantbird program folder?
14:16:15 <Mic> http://pastebin.instantbird.com/329664
14:18:10 <flo-retina> because our packaging sucks since the moz23 update
14:18:18 <flo-retina> aleth filed a bug about it, but thought it was linux-only
14:23:34 <Mic> The other problem are also there on Windows. I changed the bug accordingly.
14:23:40 <Mic> *problems
14:23:54 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
14:24:50 --> Mic has joined #instantbird
14:24:50 * ChanServ sets mode +h Mic 
14:25:18 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
14:26:00 --> Mic has joined #instantbird
14:26:00 * ChanServ sets mode +h Mic 
14:28:40 <clokep_> :(
14:28:43 <clokep_> That's frustrating.
14:28:46 <clokep_> I wonder what we broke.
14:30:10 --> novabyte has joined #instantbird
14:48:23 <-- novabyte has quit (Quit: bye bye)
14:53:45 <instantbot> benediktp@ymail.com granted review for attachment 2710 on bug 2042.
14:53:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nhnt11, ASSI, Starting conversations on unrelated keyboard- or mouse-events
15:06:47 <-- FireFly_TB has quit (Ping timeout)
15:16:10 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
15:25:02 <flo-retina> uh, if moz24 is next week, I really need to get that libpurple add-on for Tb working for Tb24 :(
16:08:41 <clokep_> :-/
16:09:05 <flo-retina> and there's no hope of getting that reviewed by amo editors in time anyway :-S
16:09:09 <flo-retina> oh well
16:22:22 --> jamesw has joined #instantbird
16:39:50 --> Mook_as has joined #instantbird
16:40:45 --> myk has joined #instantbird
16:41:33 <myk> instantbirds! should i expect /ping to work on irc.mozilla.org?
16:50:17 <clokep_> myk: I don't know if we even have a ping command...
16:50:25 <clokep_> Can you be more specific about "work"?
16:50:30 <clokep_> What happens when you try it?
16:51:22 <clokep_> myk: As in, what are you actually trying to do?
16:51:26 <clokep_> What are you typing?
16:51:49 <clokep_> I'm getting errors that you're pinging me, but maybe Mibbit doesn't respond to PINGs.
16:52:13 <myk> clokep_: if i |/ping clokep_|, then nothing happens; if i merely |/ping|, then i get the response |ping [<nick>]: Asks how much lag a user (or the server if no user specified) has.|
16:52:17 <qheaden> Hello.
16:52:32 <clokep_> myk: OK, /ping clokep_ won't work because Mibbit doesn't respond to PINGs.
16:52:44 <clokep_> And it doesn't seem like we allow pinging the server, even though the help text says we do.
16:52:47 <clokep_> qheaden: Hello.
16:52:53 <myk> clokep_: |/ping myk| should work, though, even though i'm pinging myself; yet it doesn't
16:53:07 <clokep_> Um, maybe.
16:53:22 <clokep_> Again, can you be more specific about "should work"? What happens? Nothing? Is there an error in the console?
16:53:25 <qheaden> clokep_: I see you guys were talking about bug 2102
16:53:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings
16:53:48 * clokep_ has to walk away.
16:54:03 <-- jamesw has quit (Ping timeout)
16:58:09 <Mook_as> in thunderbird, when I ping myself I get a conversation with myself that just says "PING" (in upper case); presumably it doesn't understand CTCP PING.
16:58:47 <qheaden> flo-retina: So do you agree with keeping the patch the same in bug 2102?
16:58:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings
16:59:11 <clokep_> qheaden: Did you read our conversation about this earlier?
16:59:14 <qheaden> Yahoo's pinging behavior is strange. Well, at least that's the way libpurple does it, and I trust they are correct.
16:59:47 <clokep_> qheaden: Did you read our conversation from earlier?
17:00:05 <clokep_> myk: Also, are you on 1.3 or 1.4 or 1.5a1pre?
17:00:17 <qheaden> clokep_: Yes I was reading it.
17:00:30 <qheaden> I'm not so sure if Yahoo's behavior can be changed to fit socket.jsm.
17:00:31 <myk> clokep_: i expect to see a message like |pong: the server/user responded in 3.14159 seconds|
17:01:02 <clokep_> Yes, like this message: http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/irc.properties#39
17:01:11 <clokep_> But you haven't told me what you ARE seeing, or if you're seeing an error anywhere.
17:01:34 <clokep_> qheaden: OK, then I guess we'll need to go with the patch that you have.
17:02:09 <flo-retina> qheaden: "that's the way libpurple does it, and I trust they are correct." I don't trust libpurple's correctness.
17:02:15 <qheaden> clokep_: Okay. 
17:03:39 <qheaden> flo-retina: The best way for me to test this is to stop sending pings, and wait for an hour to see what the server will do with no client activity.
17:03:46 <flo-retina> clokep_: http://i6.minus.com/i4rXCxNGdqq33.png
17:04:13 <-- mconley has quit (Connection reset by peer)
17:04:18 --> mconley_ has joined #instantbird
17:04:52 <myk> clokep_: it looks like i'm seeing three warnings in the console; here's the first:
17:04:52 <myk> Timestamp: 2013/09/10 09:51:21
17:04:52 <myk> Warning: clokep_ returned an invalid timestamp from a CTCP PING: 
17:04:52 <myk> Source File: resource://gre/modules/ircCTCP.jsm
17:04:52 <myk> Line: 167
17:04:53 <myk> Source Code:
17:04:53 <myk> prpl-irc
17:04:57 <flo-retina> qheaden: or send pings after 1h without receiving anything
17:05:04 <myk> clokep_: here's the second:
17:05:04 <myk> Timestamp: 2013/09/10 09:51:21
17:05:04 <myk> Warning: Unhandled CTCP message: PING
17:05:04 <myk> PING
17:05:04 <myk> Source File: resource://gre/modules/ircCTCP.jsm
17:05:04 <myk> Line: 104
17:05:04 <myk> Source Code:
17:05:04 <myk> prpl-irc: ctcpHandleMessage
17:05:15 <myk> clokep_: and here's the third:
17:05:15 <myk> Timestamp: 2013/09/10 10:02:46
17:05:15 <myk> Warning: flo-retina failed to handle CTCP message: PING :Unhandled CTCP command
17:05:15 <myk> Source File: resource://gre/modules/ircCTCP.jsm
17:05:15 <myk> Line: 138
17:05:15 <myk> Source Code:
17:05:15 <myk> prpl-irc
17:05:18 <clokep_> myk: I don't know how else to say this.... PING WILL NOT work with me.
17:05:21 <clokep_> You CANNOT ping me.
17:05:34 <clokep_> Ping florian or someone using Instantbird.
17:05:35 <flo-retina> clokep_: well, I assume both myk and me are on Instantbird.
17:05:48 <clokep_> I typed that before I saw that one. ;)
17:05:50 <flo-retina> clokep_: we pinged each other in the logs (I gave a screenshot of my console)
17:05:52 <myk> clokep_: i get the same three messages when i ping myself
17:06:20 <myk> clokep_: and at least two of them when i ping flo-retina
17:06:30 * myk is on Instantbird
17:07:54 <clokep_> flo-retina: I don't understand your screenshot, is that all from one message or multiple messages or what?
17:08:21 <flo-retina> clokep_: another one: http://i4.minus.com/iJG6KCPYGgeID.png
17:08:56 <flo-retina> clokep_: I would guess myk pinged me at 18:41, and I pinged him at 19:02.
17:09:25 <clokep_> flo-retina: That looks like improper escaping somewhere.
17:09:31 <flo-retina> the error one?
17:10:02 <clokep_> Yes.
17:10:09 <clokep_> It doesn't look like we're responding to PINGs appropriately.
17:10:12 <flo-retina> I've got to go, will be back in half an hour or so
17:10:15 <clokep_> And we're sending ERRMSG instead.
17:10:20 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:10:31 <clokep_> It'd be a lot more useful to have the actual messages from the debug log though. :)
17:14:22 <clokep_> myk: You should be able to get that by right clicking on the account and clicking "copy debug logs"
17:20:08 <myk> clokep_: ok, i've copied a log and identified a subset at the end that should encompass the entire time i just sent myself a ping
17:20:20 <myk> clokep_: where should i post it?
17:21:14 <clokep_> myk: pastebin.instantbird.org, please.
17:21:31 <clokep_> (And yes, that log could have private conversations and such, but it seems liek you got rid of that already)
17:22:44 <myk> clokep_: http://pastebin.instantbird.com/329936
17:23:02 <myk> clokep_: yes, i think i did; i see a lot of PRIVMSG references, but they appear to be all messages in public channels
17:27:47 <clokep_> OK. I see the issue.
17:29:07 <-- sabret00the has quit (Ping timeout)
17:30:45 <-- jb has quit (Ping timeout)
17:33:49 --> flo-retina has joined #instantbird
17:33:49 * ChanServ sets mode +qo flo-retina flo-retina 
17:35:01 <clokep_> myk: Is your email your nick @ mozilla?
17:35:32 <flo-retina> clokep_: it is.
17:37:11 <myk> clokep_: yes, myk@mozilla.org (or .com; both work)
17:38:57 <instantbot> New Core - IRC bug 2165 filed by clokep@gmail.com.
17:38:58 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2859 on bug 2165.
17:38:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2165 nor, --, ---, clokep, ASSI, IRC ping does not properly send a timestamp
17:41:05 * clokep_ has no idea how we thought that code EVER worked. :(
17:41:29 <myk> clokep_: woot!
17:41:41 <myk> clokep_: fwiw, i thought it worked at one point, but perhaps i'm mistaken
17:41:51 <clokep_> myk: Me too. I'm looking through our hg logs...
17:43:02 * clokep_ chuckles at http://hg.instantbird.org/instantbird/rev/807352f96729
17:43:32 <flo-retina> clokep_: I don't think we have ever tested all irc commands.
17:44:40 <clokep_> Doesn't look like it ever worked: http://hg.instantbird.org/instantbird/file/920499b108a1/chat/protocols/irc/ircCommands.jsm#l244
17:44:50 <clokep_> I thought we had this issue once before (Mook_as found it) and that I fixed it.
17:44:53 <clokep_> Maybe that was something else though.
17:45:42 <flo-retina> clokep_: wasn't it about the /time command?
17:46:19 <clokep_> flo-retina: Ah, you're right! :)
17:46:49 <flo-retina> clokep_: btw, the /time command just results in "Warning: Unhandled IRC message: :concrete.mozilla.org 391 flo-retina concrete.mozilla.org :Tuesday September 10 2013 -- 10:45 -07:00"
17:47:34 <clokep_> flo-retina: I thought we removed that command personally...
17:47:58 <clokep_> flo-retina: Expected behavior ;) http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#1077
17:48:18 <flo-retina> "action <action to perform>: Perform an action." That help message is particularly unhelpful. Could we make it even more unhelpful by rephrasing it to "Execute the action command." ? :-P
17:48:55 <Mook_as> "slap a large trout about"
17:49:02 <flo-retina> clokep_: well, it's a "TODO", not the behavior the user would expect ;)
17:49:17 <clokep_> File a bug? :P
17:49:36 <flo-retina> there are more interesting bugs to fix :-P
17:49:50 <flo-retina> if I fix something tonight, it will likely be the resetPingTimer one
17:51:27 <flo-retina> clokep_: is it difficult to ping the server?
17:51:58 <clokep_> flo-retina: I feel like /time one of those commands that you're going to want to display in the conversation it was typed.
17:52:09 <clokep_> flo-retina: We already ping the server.
17:52:12 <clokep_> It's not difficult at all.
17:52:38 <clokep_> But figuring out when we're pinging the server because of the command vs. because we're keeping our connection open probably requires me to think more than it did to make that patch.
17:53:14 <flo-retina> clokep_: yeah, it should go in the conversation that used the command
17:53:50 <flo-retina> so /remove is just an alias to /kick?
17:53:58 * flo-retina wonders why we have that alias :-S
17:54:10 <clokep_> Because libpurple did. :)
17:56:00 <clokep_> flo-retina: So the thing that was never clear to me...should it go into the conversation that used the command or the current conversation?
17:56:08 <clokep_> That's part of why I like it going in a conversation "from" the person.
17:56:47 <flo-retina> the conv that used the command seems to make more sense to me
17:57:08 * clokep_ isn't sure what the expected behavior is. :(
18:01:36 <-- gerard-majax_ has quit (Ping timeout)
18:02:14 <clokep_> flo-retina: If you remind me I'll try to take a look at the IRC command bugs later tonight.
18:02:57 <clokep_> I'll see if I can make it remember where we typed commands...(although that seems difficult).
18:03:45 --> unghost has joined #instantbird
18:03:57 <flo-retina> clokep_: I likely won't remind you; I don't care that much
18:04:50 <Mook_as> memoserv yourself without the tail?
18:09:38 * flo-retina wonders if aleth is going to show up and do reviews today :-].
18:12:34 <clokep_> qheaden: Did you want to re-request review on bug 2102?
18:12:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, qheaden, ASSI, Support Server Pings
18:13:33 --> jnimz has joined #instantbird
18:13:45 --> unghost_ has joined #instantbird
18:16:27 <jnimz> Hey all, trying to get some assistance with connecting Instantbird to an OpenFire chat server.
18:16:49 <clokep_> jnimz: Did you just send that email to the mailing list? ;)
18:16:54 * clokep_ just approved it.
18:16:58 <clokep_> Probably easier to help you ehre though.
18:16:58 <jnimz> Yes  :)
18:17:04 <jnimz> OK, either way
18:17:10 <-- myk has quit (Ping timeout)
18:17:59 <jnimz> So, my challenge is that none of the conenction options seem to allow connection, yet I can conenct up on the same computer, to the same server with multiple other clients
18:18:07 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
18:18:09 --> Mnyromyr has joined #instantbird
18:18:23 <clokep_> jnimz: I assume it's an invalid/self-signed certificate, right?
18:18:31 <-- unghost_ has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
18:18:45 --> unghost has joined #instantbird
18:19:08 <clokep_> jnimz: https://bugzilla.instantbird.org/show_bug.cgi?id=1100#c3 Should have the directions to import it.
18:19:12 <instantbot> Bug 1100 cri, --, 1.4, clokep, RESO FIXED, Use Firefox untrusted cert dialog for "SSL Handshake failed" errors
18:19:19 <clokep_> (We, unlike Pidgin, actually check certificates by default.)
18:20:22 <jnimz> I believe I have a valid signed cert.  It appears in the Servers list, and I have it set to trust the authenticity.
18:20:30 <jnimz> I'll look over that link though
18:21:02 <clokep_> jnimz: I don't know what "It appears in the Servers list, and I have it set to trust the authenticity." means.
18:23:21 <jnimz> You asked about the certificate.  It is not self-signed.  The server's certificate appears in the Server list under Options-->Encryption-->Viee Certificates
18:23:55 <flo-retina> jnimz: try clicking the "Add Exception…" button
18:24:08 <jnimz> Under the Servers tab, my server is there, and when I select it, and go to Edit Trust, "Trust the authenticity of this certificate" is selected
18:24:21 <flo-retina> in the location, type "https://<server name>:<port>" and click the "get certificate" button
18:24:27 <flo-retina> it should tell you what's wrong with it
18:26:01 <jnimz> "Unable to obtain identification status for the given site"
18:37:41 <flo-retina> jnimz: do you have a proxy?
18:40:53 <jnimz> I do, but this URL is in the proxy exclusion list
18:45:35 <flo-retina> jnimz: I wonder if unchecking "Use the online certificate status protocol to confirm the current validity of certificates" in the "Validation" dialog would help
18:50:03 <jnimz> flo-retina, where would I find that option please?
18:50:30 <flo-retina> Advanced->encryption->Validation
18:51:41 <jnimz> That is already unchecked.  Additionally, I have set purple.ssl.check_certificates to false
18:51:55 --> gerard-majax_ has joined #instantbird
18:52:54 <flo-retina> and you still can't connect the account with purple.ssl.check_certificates set to false? :-o
18:54:03 --> rosonline has joined #instantbird
18:54:07 <jnimz> No.  I am receiving "SSL Connection failed" no matter which options I select under "Accounts->Properties->Advanced"
18:57:26 <jnimz> That is the message I receive when I try to log in
18:59:03 <flo-retina> ah
18:59:33 <flo-retina> can you telnet to the server?
18:59:52 <jnimz> Yes
19:00:10 <jnimz> And I can connect with Spark, and Pidgin
19:00:53 * flo-retina wonders if there could be a dns srv issue
19:01:04 --> qlum has joined #instantbird
19:01:51 <flo-retina> jnimz: so you are saying you now get "SSL Connection Failed" and before you were getting "SSL Handshake Failed". What change caused the change of error message?
19:03:22 <jnimz> What changes the error is whatever option is selected under "Accounts->Properties->Advanced"
19:06:44 <jnimz> If I select Require encryption I get SSL Handshake failed
19:09:21 --> nhnt11 has joined #instantbird
19:10:25 <jnimz> If I select "Use Old-style" or "Use encryption if available" I get SSL connection failed
19:10:48 <jnimz> adn I am not sure how this would be a DNS SRV issue, if I can telenet to the server without issue?
19:21:37 <jnimz>  Today?
19:25:50 --> chrisccoulson has joined #instantbird
19:36:03 <-- nhnt11 has quit (Ping timeout)
19:38:43 --> nhnt11 has joined #instantbird
19:39:09 --> myk has joined #instantbird
19:49:37 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
19:56:31 --> FireFly_TB has joined #instantbird
19:58:48 <-- gerard-majax_ has quit (Ping timeout)
19:59:33 --> gerard-majax_ has joined #instantbird
19:59:52 <-- nhnt11 has quit (Ping timeout)
19:59:55 --> nhnt11 has joined #instantbird
20:00:51 <clokep_> nhnt11: What's next for you then? Are you blocked on reviews?
20:01:07 <nhnt11> clokep_: I need to get a new patch up for bug 2143
20:01:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
20:02:22 <clokep_> OK! :)
20:02:26 * clokep_ can't wait to play w/ this.
20:02:33 <clokep_> I also can't wait to get nightly builds back. ;)
20:06:14 <-- nhnt11 has quit (Ping timeout)
20:06:17 --> nhnt11 has joined #instantbird
20:06:34 <flo-retina> nhnt11: hey :)
20:06:38 <nhnt11> Hi flo-retina
20:08:41 --> jb has joined #instantbird
20:10:26 <flo-retina> alright, let's see what it takes to build purple/ in comm-beta
20:23:42 <flo-retina> I'm starting to wonder if it wouldn't be easier to just use Instantbird's purplexpcom.dll files, once we are on moz24
20:28:36 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:31:56 --> EionRobb has joined #instantbird
20:51:08 <-- jnimz has left #instantbird ()
20:52:22 <flo-retina> bah "/Users/florian/buildhg/comm-beta/config/rules.mk:30: *** Variable DIRS is defined in /Users/florian/buildhg/comm-beta/obj-tbird-dbg/purple/Makefile. It should only be defined in moz.build files.  Stop.
20:52:22 <flo-retina> " :(
20:56:51 <-- jb has quit (Ping timeout)
21:05:10 <flo-retina> hasOwnProperty is 1.1% in the profile I'm getting after applying all the optimization patches that we have in progress.
21:05:32 <flo-retina> it's the call at http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircHandlers.jsm#103
21:05:33 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:06:14 <flo-retina> I wonder if changing hasOwnProperty(handler.commands, aCommand) into handler.commands[aCommand] && hasOwnProperty(handler.commands, aCommand)  would be faster
21:21:50 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2860 on bug 2164.
21:21:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2164 nor, --, ---, florian, NEW, Socket.resetPingTimer shows up in LIST profiles
21:26:23 <-- qlum has quit (Quit: Getting the <censored> out.)
21:28:37 <-- FireFly_TB has quit (Quit: FireFly_TB)
21:36:14 <nhnt11> flo-retina: We decided not to care about the old .txt log files right?
21:36:28 * nhnt11 thinks so, judging by this: http://log.bezut.info/instantbird/130905/#m149
21:36:28 <flo-retina> for ranking?
21:36:41 <nhnt11> Yeah.
21:36:54 <flo-retina> IIRC there wasn't a strong agreement. aleth thought we should take them into account, and I thought they were irrelevant.
21:37:39 <flo-retina> http://log.bezut.info/instantbird/130905/#m157
21:37:54 <nhnt11> aleth was mostly worried that non-contacts that one has talked to that have only txt files won't appear in the newtab if we don't look at them at all.
21:38:11 <nhnt11> Hmm, ok.
21:38:35 <Mook_as> flo-retina: http://jsperf.com/hasownrh9to67 seems to say no
21:38:54 <Mook_as> (it's possible that a microbenchmark like that screws things up of course)
21:39:22 <Mook_as> also, it's buggy. (a["a"] != "a" in a)
21:40:33 <flo-retina> Mook_as: hasOwnProperty likely involves a few cross compartment wrappers.
21:47:21 <flo-retina> Mook_as: http://jsperf.com/hasownrh9to67/2
21:47:47 <flo-retina> we can likely speed this up a bit if we decided that an object having "hasOwnProperty" as a handler name is unlikely
21:48:07 <nhnt11> flo-retina: Do you have any suggestions for this? http://pastebin.instantbird.com/330330
21:48:17 <flo-retina> oh wait, no, maybe the handler name comes from the socket :-S
21:49:22 * nhnt11 is having trouble thinking of a "good way"
21:57:28 <-- mconley_ has quit (Input/output error)
21:57:57 <-- gerard-majax_ has quit (Ping timeout)
22:34:56 --> mconley has joined #instantbird
22:36:38 <nhnt11> Bah, I need to sleep :(
22:36:45 <nhnt11> I'll upload what I have currently anyway...
22:37:42 <nhnt11> I just need to add support for txt logs and think of "a good way to instead call [getScoreForConv and getStatusForConv] lazily only once per sort process and conv"
22:38:15 <instantbot> New Core - IRC bug 2166 filed by florian@instantbird.org.
22:38:16 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2861 on bug 2166.
22:38:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2166 nor, --, ---, nobody, NEW, JS-IRC spends more time than it needs in hasOwnProperty calls
22:39:15 <flo-retina> nhnt11: ah, I got distracted before reaching the question in your pastebin
22:39:32 <flo-retina> do you mean you would like to store the result of these computations inside the possibleconversation object?
22:40:19 <nhnt11> flo-retina: Not necessarily. aleth is right that we shouldn't need to compute them every time we compare, but if we store scores, how do we know when they need to be recomputed?
22:41:04 <nhnt11> I can think of ways to do this (clear them out after a timeout, etc) but I don't like any of them
22:41:26 <nhnt11> I really need to get to bed though (I'm too tired to think further) so I'll look into this again tomorrow.
22:41:38 <flo-retina> I need to sleep too
22:41:52 <flo-retina> tomorrow will be a long day
22:42:00 <flo-retina> I'll likely be in the office until 23:30
22:42:28 * nhnt11 has a long day too :(
22:42:32 <nhnt11> Wow.
22:44:54 <flo-retina> Good night
22:45:02 <nhnt11> Good night.
22:45:13 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2823 on bug 2143.
22:45:14 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2862 on bug 2143.
22:45:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting.
22:45:38 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:57:46 <-- rosonline has quit (Ping timeout)
23:03:05 --> rosonline has joined #instantbird
23:09:37 --> clokep has joined #instantbird
23:09:37 * ChanServ sets mode +o clokep 
23:32:57 <-- dionisos has quit (Ping timeout)
23:34:07 <instantbot> clokep@gmail.com granted review for attachment 2861 on bug 2166.
23:34:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2166 nor, --, ---, nobody, NEW, JS-IRC spends more time than it needs in hasOwnProperty calls
23:48:40 <instantbot> clokep@gmail.com granted review for attachment 2860 on bug 2164.
23:48:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2164 nor, --, ---, florian, NEW, Socket.resetPingTimer shows up in LIST profiles
23:58:19 --> dionisos has joined #instantbird