All times are UTC.
00:18:33 --> mconley has joined #instantbird 00:30:30 <clokep> Is BIO down for anyone else? 00:44:14 <-- mconley has quit (Ping timeout) 00:45:13 --> mconley has joined #instantbird 01:07:19 <-- mconley has quit (Input/output error) 01:25:50 <qheaden> clokep: Yeah, down for me. 01:25:58 <clokep> :( 01:26:10 <qheaden> FF is giving me a sec_error_ocsp_unknown_cert error. 01:26:41 <clokep> qheaden: Me too. 01:26:48 <clokep> I wonder if our cert expired or something weird. 01:26:49 <qheaden> Hmm. 01:26:53 <qheaden> I hope it is up tomorrow. 01:39:19 --> mconley has joined #instantbird 01:40:10 <-- dew has quit (Ping timeout) 01:40:35 --> dew has joined #instantbird 02:02:20 --> nhnt11 has joined #instantbird 02:02:30 <nhnt11> clokep, qheaden: BIO is up for me 02:05:02 <qheaden> nhnt11, clokep: Now its up for me too. 02:05:11 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:05:25 <clokep> Not for me. 02:05:27 * clokep shrugs. 02:20:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:15:43 <-- wnayes has quit (Quit: wnayes) 03:52:02 <instant-buildbot> build #988 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/988 04:04:38 --> FireFly_TB has joined #instantbird 04:06:32 <-- mconley has quit (Input/output error) 04:15:09 <instant-buildbot> build #965 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/965 04:58:44 --> mconley has joined #instantbird 05:37:37 <-- qheaden has quit (Quit: ZNC - http://znc.in) 06:20:46 --> gerard-majax_ has joined #instantbird 06:22:10 <-- EionRobb has quit (Quit: Leaving.) 06:33:32 <-- gerard-majax_ has quit (Ping timeout) 06:34:19 <-- mconley has quit (Input/output error) 06:56:58 --> jb has joined #instantbird 07:12:09 <-- jb has quit (Ping timeout) 07:21:10 --> gerard-majax_ has joined #instantbird 07:28:33 <-- gerard-majax_ has quit (Quit: Ex-Chat) 07:28:38 --> gerard-majax_ has joined #instantbird 07:31:57 --> dionisos has joined #instantbird 08:15:54 --> jb has joined #instantbird 09:03:23 <-- jb has quit (Quit: jb) 09:07:27 --> jb has joined #instantbird 09:09:17 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:29:29 <-- Tonnes has quit (Connection reset by peer) 09:45:28 --> Tonnes has joined #instantbird 10:05:17 --> clokep has joined #instantbird 10:05:18 * ChanServ sets mode +o clokep 10:05:44 --> flo-retina has joined #instantbird 10:05:44 * ChanServ sets mode +qo flo-retina flo-retina 10:06:02 <-- flo-retina has quit (Input/output error) 10:06:06 --> flo-retina has joined #instantbird 10:06:06 * ChanServ sets mode +qo flo-retina flo-retina 10:17:48 <flo-retina> what's making BIO so slow today :( 10:37:10 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:39:39 <-- FireFly_TB has quit (Ping timeout) 11:00:01 <-- dionisos has quit (Ping timeout) 11:17:40 <-- GeekShadow has quit (Ping timeout) 11:17:50 --> GeekShadow has joined #instantbird 11:20:22 <-- jb has quit (Ping timeout) 11:22:55 --> jb has joined #instantbird 11:42:05 <-- jb has quit (Connection reset by peer) 11:43:26 --> jb has joined #instantbird 11:51:03 --> clokep_ has joined #instantbird 11:51:45 <-- stux has quit (Ping timeout) 11:53:16 <clokep_> At least it works now. :) 11:56:02 --> stux has joined #instantbird 11:59:00 <instantbot> clokep@gmail.com denied review for attachment 2846 on bug 2153. 11:59:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 12:03:15 <instantbot> clokep@gmail.com denied review for attachment 2848 on bug 2162. 12:03:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nobody, NEW, IRC's /list command should use the requestRoomInfo API 12:07:46 <flo-retina> clokep_ seems in his r- mood, I'll hide all my patches for now :-P 12:09:42 <clokep_> flo-retina: I'm 3 for 3. :) 12:09:50 <instantbot> clokep@gmail.com denied review for attachment 2852 on bug 2157. 12:09:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 12:10:24 * flo-retina is happy he didn't request any review from clokep_ 12:10:42 <clokep_> r-s are a lot more work than r+. :( 12:10:43 <flo-retina> aleth r-'ed my patch anyway :-S 12:10:50 <flo-retina> clokep_: I know... 12:10:52 <clokep_> I wanted to r+ /something/, so maybe if you give me a good patch. 12:12:22 <-- stux has quit (Quit: Aloha!) 12:13:34 --> stux has joined #instantbird 12:17:42 --> wnayes has joined #instantbird 12:17:56 <-- stux has quit (Ping timeout) 12:19:04 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:20:08 --> clokep_ has joined #instantbird 12:22:05 --> stux has joined #instantbird 12:23:12 --> mconley has joined #instantbird 12:31:19 * clokep_ feels like flo-retina and him have reversed rolls on l10n. ;) 12:32:32 <flo-retina> clokep_: maybe we are just adding extra lols to bugs? ;) 12:33:24 <clokep_> bugmail for everyone. :-D 12:33:35 <clokep_> Anyway, the l10n stuff wasn't my r-s, just comments. :) 12:55:55 <-- mconley has quit (Input/output error) 13:00:40 --> sabret00the has joined #instantbird 13:04:47 --> qheaden has joined #instantbird 13:08:37 --> novabyte has joined #instantbird 13:10:19 <-- novabyte has quit (Ping timeout) 13:11:20 --> mconley has joined #instantbird 13:12:39 --> novabyte has joined #instantbird 13:13:41 <-- mconley has quit (Input/output error) 13:34:57 <-- sabret00the has quit (Quit: Leaving) 13:47:19 --> mconley has joined #instantbird 14:04:37 <-- novabyte has quit (Quit: bye bye) 14:15:49 --> sabret00the has joined #instantbird 14:48:26 <-- jb has quit (Ping timeout) 14:49:03 --> dionisos has joined #instantbird 14:50:32 <-- flo-retina has quit (Ping timeout) 14:59:50 --> flo-retina has joined #instantbird 14:59:50 * ChanServ sets mode +qo flo-retina flo-retina 16:01:10 <-- gerard-majax_ has quit (Ping timeout) 16:15:39 --> jamesw has joined #instantbird 16:21:11 * mconley is now known as mconley|food 16:39:36 <-- jamesw has quit (Ping timeout) 16:43:15 --> jb has joined #instantbird 16:44:58 * mconley|food is now known as mconley 16:46:49 --> Mook_as has joined #instantbird 16:47:53 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:10:26 --> qlum has joined #instantbird 17:26:59 <-- mconley has quit (Connection reset by peer) 17:27:19 --> mconley has joined #instantbird 17:52:13 <-- mconley has quit (Connection reset by peer) 17:52:32 --> mconley has joined #instantbird 17:58:32 <-- jb has quit (Ping timeout) 18:26:31 --> unghost has joined #instantbird 18:27:29 --> flo-retina has joined #instantbird 18:27:29 * ChanServ sets mode +qo flo-retina flo-retina 18:32:39 --> rosonline has joined #instantbird 18:43:39 <flo-retina> I just profiled joining #ubuntu. The freeze lasted only 700ms (maybe my machine is too fast. Or we improved at lot on it! :)) If anybody is curious: http://people.mozilla.com/~bgirard/cleopatra/#report=58787c2e981b0250cff3269d9bd590557e21e479 (I strongly suggest checking the "Show Jank Only" and "Javascript only" checkboxes to look at this one). 18:46:26 <clokep_> That's not TOO awful. :) 18:55:34 --> nhnt11 has joined #instantbird 18:56:17 <nhnt11> Hi 18:58:53 <clokep_> Hello nhnt11! 18:59:05 <nhnt11> Is joining #ubuntu supposed to make Ib freeze? :S 18:59:24 <clokep_> Supposed to? Of course not. 18:59:30 * clokep_ doesn't understand that question. :-S 19:00:14 <nhnt11> I guess my question is, what's the need to profile joining it? 19:00:42 <clokep_> Oh, are you asking DOES IT make IB freeze? 19:00:48 <clokep_> It might, I don't join #ubuntu. 19:01:01 <flo-retina> nhnt11: historically, it did. 19:01:11 <nhnt11> Er, by supposed to, I meant it doesn't freeze when I join it, and so should I have been expecting it to freeze 19:01:12 <nhnt11> ok 19:01:36 <flo-retina> nhnt11: it's the only channel I know with ~2000 participants. So basically when I say "profiling joining #ubuntu" I mean "profiling the display of the list of participants". 19:01:45 <nhnt11> ah ok. 19:02:41 <nhnt11> (I understood that #ubuntu has some characteristics suitable for testing, but I didn't know what these were) 19:04:19 <flo-retina> it took only 700ms here, so you likely don't notice it. 19:04:35 * clokep_ wonders if nhnt11 has seen his comments yet. 19:04:36 <flo-retina> it used to be several minutes, but that code already went through several rounds of optimizations ;). 19:05:11 <nhnt11> clokep_: I have 19:05:16 <-- mconley has quit (Connection reset by peer) 19:05:27 <nhnt11> I read my bugmail as it arrives, usually :) 19:05:34 --> mconley has joined #instantbird 19:05:37 * nhnt11 hasn't been in his room all evening 19:06:05 <qlum> another channel I know is #osu at irc.ppy.sh 19:06:18 <qlum> mainly because of the insane number of join/leave 19:06:32 <clokep_> nhnt11: OK. :) I meant more that I hope it makes sense. 19:07:13 <qlum> Should be around 6000 people there now 19:07:15 <nhnt11> flo-retina: I notice the lag when I open it from hold 19:07:57 <clokep_> flo-retina: Are we currently not checking things in right now waiting for Windows to come back? 19:08:52 <flo-retina> nhnt11: now that I told you it's too slow, I'm sure you'll notice every time ;) 19:08:53 <qlum> hmm Nope it doesn't even fucking connect 19:09:02 <flo-retina> clokep_: no. I'll do some checkins tonight. 19:09:21 <flo-retina> (maybe not all though) 19:09:33 <flo-retina> clokep_: the ETA for the new Windows VM isn't soon enough :( 19:10:02 <nhnt11> flo-retina: Nah, I'm not usually on freenode. 19:14:31 --> Mic has joined #instantbird 19:14:31 * ChanServ sets mode +h Mic 19:14:44 <clokep_> flo-retina: Understood, I was going to do them last night, but wasn't sure what our ETA was. 19:14:50 <Mic> Good evening! 19:15:17 <Mic> flo-retina: can't you disable cores if you suspect that your computer is too fast to do profiling? 19:15:27 <nhnt11> Hi Mic 19:15:47 * clokep_ has a computer from like 2004 he could hook up to profile w/. ;) 19:20:39 <nhnt11> Btw, flo-retina, the MOTD is shown as an incoming message. 19:20:52 <nhnt11> Aaaaaaaah 19:21:02 <nhnt11> I think I know why LIST messages weren't incoming messages before 19:21:08 <nhnt11> My speakers just screeched 19:21:15 <nhnt11> from all the incoming message sounds 19:23:15 * nhnt11 's terminal is currently full of "2013-09-10 00:51:51.836 instantbird-bin[8812:707] Critical failure: the LastResort font is unavailable." 19:23:32 <nhnt11> (And opening a new tab no longer works) 19:23:47 <nhnt11> Just shows a blank tab with "newtab.init is not a function" in the error console 19:24:05 <nhnt11> This is after doing a /list, but closing the servertab midway while receiving results 19:24:53 * mconley is now known as mconley|brb 19:26:38 <nhnt11> Opening the preferences dialog while receiving results gives me this: https://puu.sh/4neLK.png 19:27:13 <nhnt11> It shows the dialog properly eventually though... 19:31:44 <flo-retina> Mic: disabling some cores wouldn't really help, as JS is single threaded 19:33:42 <Mic> Ah, OK, but what was the goal with these while(true)-programs then that you discussed with nhnt11? 19:33:52 <Mic> I thought you used to put load on the other cores? 19:33:55 <Mic> *them 19:34:20 <nhnt11> I used them to put load on /every/ core 19:35:11 <clokep_> nhnt11: Yes, it beeps for every message. 19:35:40 <nhnt11> clokep_: So what do you suggest? Keep it as a system message (mimic existing behavior) for now? 19:36:55 <clokep_> nhnt11: I don't see what the issue is. :-S 19:37:00 <clokep_> I suggest doing what we suggested in the bug. 19:37:23 <nhnt11> clokep_: LIST sends a ton of messages at once = a ton of beeps 19:37:32 <nhnt11> My ears are cursing me :P 19:37:46 <clokep_> nhnt11: Make it so that doesn't happen then. :P 19:37:55 <clokep_> The fix shouldn't be to make the list output unusable. 19:37:59 * mconley|brb is now known as mconley 19:38:34 <flo-retina> Mic: my wifi stopped working when I used that while(1) program. 19:38:41 <nhnt11> Hmm yeah, system messages are unusable because they get folded and when I try to expand them it freezes for ~10 seconds 19:39:08 * nhnt11 doesn't know how to disable the sound only for these messages 19:39:20 <flo-retina> "it freezes for ~10 seconds" is it only in layout code? (hint: you have a profiler now ;)) 19:39:41 <nhnt11> flo-retina: What other code could it be? 19:39:48 <nhnt11> This is after all LIST results have been received 19:40:02 <clokep_> nhnt11: My suggestion was to batch beeps or something, i.e. fix the bug. :) 19:40:13 <flo-retina> nhnt11: I don't pretend to know before looking at real data. Sometimes there are silly things ;) 19:40:32 <nhnt11> clokep_: Batching beeps? I don't want more than one beep for all the thousands of results I get from LIST 19:41:06 <Mook_as> would you want to batch beeps if there's a flood in an IRC channel? 19:41:18 <Mook_as> (that is: batching beeps sounds like a generally useful thing to do anyway) 19:42:19 <nhnt11> It seems like every bug I touch branches out into more bugs that I could never have foreseen :P 19:42:53 <clokep_> nhnt11: This is already an issue we have, you don't need to fix it. 19:42:56 <clokep_> Mook_as: I agree. 19:43:07 <flo-retina> nhnt11: filing a bug still seems like a good idea ;) 19:43:22 <flo-retina> we probably shouldn't attempt to play more than 5 or 10 bips per second :) 19:43:39 <nhnt11> clokep_: "i.e. fix the bug" and "you don't need to fix it" seem contradicting :P 19:43:47 <clokep_> nhnt11: I'm suggesting we have ONE beep for all those messages. 19:43:47 <Mic> 5 to 10 per second still seems a lot. 19:43:59 <clokep_> nhnt11: If it really annoys you, then fix it, if you're willing to say "Well this is just the status quo", ignore it. 19:44:19 <flo-retina> clokep_: I don't think one is enough 19:44:32 <nhnt11> flo-retina: I think it is for /list at least 19:44:35 <flo-retina> clokep_: it's useful that the sound isn't exactly the same when there's one message, or a bunch of them 19:44:57 * clokep_ sees this as a totally separate bug. ;) 19:44:59 <clokep_> ALso our sounds suck anyway. 19:45:00 <nhnt11> When you do /list you /expect/ a ton of messages, unlike a flood :S 19:45:04 <flo-retina> nhnt11: ah well, you could also display all the channels in the same message, like we did for the MOTD IIRC 19:45:20 <nhnt11> flo-retina: But then I'd have to add all of them at once ;) 19:45:54 <flo-retina> clokep_: "ALso our sounds suck anyway." I think that's something we say once or twice a year without doing anything about it. If we plan on continuing this way, maybe we could automate and instruct a bot to say it for us :-P 19:50:40 <clokep_> flo-retina: Maybe. :) 19:55:37 <clokep_> nhnt11: Are our expectations clear now? 19:56:15 <nhnt11> clokep_: I think so, just address the review comments and file a separate bug for the beeping? 19:57:14 <clokep_> Please. :) 20:00:00 <flo-retina> nhnt11: so what are your current priorities right now? 20:00:35 <nhnt11> flo-retina: Getting new patches up for bug 2157, bug 2162, then looking at aleth's comments again on bug 2143 20:00:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 20:00:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nhnt11, ASSI, IRC's /list command should use the requestRoomInfo API 20:00:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2143 enh, --, ---, nhnt11, NEW, Stats service should maintain statistical data for conversations and use it for sorting. 20:05:01 <flo-retina> nhnt11: what about bug 2160? 20:05:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 20:05:53 <nhnt11> Yeah that's before 2143, I think I addressed all the comments already on that though, just need to upload a patch 20:06:39 <flo-retina> "just need to upload a patch" doesn't seem like much effort; maybe that should be at the top? 20:07:30 <nhnt11> Actually I think all three are at the same state, so I'm just going through all the review comments again before uploading patches for all of them :) 20:08:48 <flo-retina> :) 20:08:49 <nhnt11> Ah, there's one thing. clokep_: "I think it would be easier to store a reference to the account" - I thought we didn't want to store references to accounts/contacts/etc? 20:09:24 <flo-retina> nhnt11: I think clokep meant a reference to the unwrapped account. 20:09:39 <nhnt11> oh wait 20:09:40 <nhnt11> yeah 20:09:40 <nhnt11> ok 20:10:54 <clokep_> I did, yes. 20:11:00 <clokep_> Not via xpcom, just via the constructor. 20:11:11 <nhnt11> Got it. 20:11:31 <nhnt11> I was confused, for some reason I was thinking we were storing it in PossibleChat 20:15:32 <-- qlum has quit (Ping timeout) 20:16:04 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 20:17:55 --> qlum has joined #instantbird 20:18:45 --> gerard-majax_ has joined #instantbird 20:22:50 <clokep_> Probably my fault, sorry. :) 20:23:51 <nhnt11> flo-retina: About the |for (let time = 0; time < 40 && this._pendingChats.length; time = Date.now() - begin)| suggestion, this would require me to check pendingChats.length again before calling executeSoon(this._addPendingChats), wouldn't it? 20:24:13 <nhnt11> the reason there's two checks for the end of the loop is that one check needs to do something more than just break. 20:24:43 <flo-retina> yes 20:25:12 <nhnt11> So do you still want me to use the for loop or just leave it? 20:26:15 <-- qlum has quit (Ping timeout) 20:26:20 <nhnt11> clokep_: Not really, I think your review comments were pretty clear. Just me being a bit slow :) 20:28:40 <nhnt11> flo-retina: So I'll leave the while loop as it is? 20:29:05 <flo-retina> I don't understand 20:29:26 <flo-retina> Once you have exited the loop, why would it be a problem to check why? 20:29:58 <nhnt11> It's not. 20:30:01 <nhnt11> just an extra check 20:30:03 <nhnt11> Ok. 20:31:27 <nhnt11> flo-retina: Is _accountsRequestingRoomInfo an ok name for the number of accounts we're requesting room info from? 20:32:10 <flo-retina> seems ok 20:32:35 <flo-retina> you likely want a comment above it explaining what it is (and especially what happens when it reaches 0) 20:33:07 --> qlum has joined #instantbird 20:33:40 --> jb has joined #instantbird 20:33:45 <nhnt11> Yeah, "Number of accounts from which chat room info has been requested. We send an update notification to observers if this is 0 after adding chat rooms." 20:35:57 --> EionRobb has joined #instantbird 20:49:30 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2848 on bug 2162. 20:49:31 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2853 on bug 2162. 20:49:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nhnt11, ASSI, IRC's /list command should use the requestRoomInfo API 20:50:20 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2852 on bug 2157. 20:50:22 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2854 on bug 2157. 20:50:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 20:50:52 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2855 on bug 2160. 20:50:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 20:52:25 <qheaden> Hello. 20:52:42 <nhnt11> Hey qheaden 20:52:49 <qheaden> Hey there nhnt11. 20:53:17 <qheaden> I can't stay in for long unfortunately. :( 20:53:33 <qheaden> I'll do a little work now, and then I will do some more later this evening. 20:55:07 <clokep_> nhnt11: Should "__proto__: ClassInfo("prplIRoomInfo", "RoomInfo Object")," be more specific description for classInfo? 20:56:16 <instantbot> clokep@gmail.com granted review for attachment 2853 on bug 2162. 20:56:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2162 nor, --, ---, nhnt11, ASSI, IRC's /list command should use the requestRoomInfo API 20:57:17 * nhnt11 doesn't know. 20:57:21 * clokep_ isn't sure if he should r- or r+ that. 20:57:37 <clokep_> I also debated asking for ircRoomInfo to be called channelInfo, but I can't decide if I like that or not. 20:57:58 <nhnt11> clokep_: ircChannelInfo? 20:58:09 * nhnt11 doesn't really have an opinion on this 21:00:12 * clokep_ goes home. 21:03:14 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:10:11 <flo-retina> nhnt11: ah, so now you see why I was saying that the RoomInfo thing in jsProtoHelper didn't add much value as is ;) 21:10:21 <flo-retina> I think you forgot to remove it from the "exports" 21:10:39 <nhnt11> yeah and yeah 21:10:58 <flo-retina> ""RoomInfo Object"" -> put "IRC " before "RoomInfo 21:11:10 <nhnt11> ok 21:11:39 <flo-retina> why are you storing the imAccount? 21:12:19 <nhnt11> Because I don't need the prplAccount? 21:12:28 <flo-retina> you _have_ the prplAccount 21:12:43 <flo-retina> and you are doing more work to get the im one. 21:12:57 <-- jb has quit (Ping timeout) 21:13:39 <flo-retina> hmm 21:13:50 <nhnt11> I'll need to use this._account.imAccount.id for get accountId() then 21:13:57 <flo-retina> looks like imAccount is just a property in jsProtoHelper and not a getter 21:14:17 <flo-retina> so touching it is possibly fine 21:15:01 <flo-retina> getChatRoomDefaultFieldValues is from the prplAccount though 21:15:22 <flo-retina> nhnt11: so yes, use this._account.imAccount.id for get accountId() 21:15:30 <nhnt11> ok 21:16:47 <flo-retina> "get _accountId() this._roomInfo.accountId," can be inlined 21:17:40 <flo-retina> oh wait 21:19:07 <flo-retina> nhnt11: why is it get _displayName() and not get displayName() ? 21:21:09 <flo-retina> is there anything useful that we get by inheriting from PossibleConversation? 21:24:13 <-- gerard-majax_ has quit (Ping timeout) 21:36:11 <instantbot> florian@instantbird.org denied review for attachment 2854 on bug 2157. 21:36:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 21:36:27 <flo-retina> if I give the r- now, maybe clokep will be able to r+ once he's back online ;) 21:38:47 <nhnt11> flo-retina: I guess not 21:38:57 <nhnt11> (about inheriting PossibleConversation 21:39:08 <nhnt11> We get QueryInterface though 21:39:13 <nhnt11> And buddyIconFilename 21:39:18 <nhnt11> Oh wait 21:40:19 <nhnt11> flo-retina: Would you rather I added QueryInterface to PossibleChat and removed the prototype? On principle I'd rather inherit it ;) 21:41:26 <flo-retina> I suspect reducing inheritance levels is a perf win. So if we are calling this thousands of times, I won't raise a "code duplication!" warning ;). 21:41:41 --> jb has joined #instantbird 21:42:22 <flo-retina> I would actually like to test how much of a perf win it would be to directly implement QueryInterface on some objects and drop the ClassInfo inheritance. 21:43:19 <Mook_as> PossibleChat.prototype.QueryInterface = ClassInfo(...).prototype.QueryInterface, etc? 21:43:42 --> jb1 has joined #instantbird 21:43:49 <-- jb has quit (Connection reset by peer) 21:45:22 <flo-retina> Mook_as: come on... 21:47:40 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 21:49:15 <instantbot> florian@instantbird.org granted review for attachment 2855 on bug 2160. 21:49:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 22:01:19 <-- jb1 has quit (Ping timeout) 22:02:39 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2854 on bug 2157. 22:02:40 <instantbot> nhnt11@gmail.com requested review from florian@instantbird.org for attachment 2856 on bug 2157. 22:02:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 22:04:41 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2856 on bug 2157. 22:04:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 22:05:22 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2813 on bug 2147. 22:05:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2147 nor, --, ---, nobody, NEW, Bubbles' last message sometimes doesn't auto-scroll 22:05:34 <flo-retina> heh, the problem of drive by r- is that then you get more r? ;) 22:05:46 <nhnt11> :P 22:07:50 <flo-retina> nhnt11: what about lowerCaseName? 22:08:14 <nhnt11> There's always something... :( 22:09:07 <nhnt11> flo-retina: I'd still rather just inherit PossibleConversation by the way 22:09:28 <flo-retina> get lowerCaseName() this._lowerCaseName || (this._lowerCaseName = this.displayName.toLowerCase()) 22:10:08 <nhnt11> Er. 22:10:12 <nhnt11> I know? :) 22:10:31 <flo-retina> I don't know (what your question is) :-) 22:10:57 <nhnt11> I don't really have one, so never mind. 22:11:33 * flo-retina was wondering why the existing lowerCaseName getter is more complicated than what he just typed 22:12:02 <nhnt11> flo-retina: I can change that in the same patch if you'd like 22:12:40 <flo-retina> would be nice to be consistent I guess 22:17:45 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2856 on bug 2157. 22:17:46 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2857 on bug 2157. 22:17:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 22:30:27 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2858 on bug 2163. 22:30:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2163 min, --, ---, florian, NEW, Displaying a large conversation log freezes the UI for a while before the first messages get display 22:32:40 <instantbot> florian@instantbird.org granted review for attachment 2857 on bug 2157. 22:32:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 22:37:36 <-- qlum has quit (Connection reset by peer) 22:40:57 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7fa8c8c68347 - Quentin Headen - Bug 2111 - JS-Yahoo: Yahoo Web Client Causes Endless Typing Notification, r=clokep. 22:40:58 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7bdbfa0b739f - Quentin Headen - Bug 2089 - JS-Yahoo: Debug logs are binary only, r=clokep,fqueze. 22:40:59 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1b7a09391357 - Quentin Headen - Bug 2150 - JS-Yahoo: Conference invites don't work, r=clokep. 22:41:00 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/644a37f59e3e - Florian Quèze - Bug 2161 - Bubbles' updateLastInsertTime function wastes a lot of time setting and clearing timeouts, r=aleth. 22:41:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/ed26aded5b7d - Quentin Headen - Bug 2093 - JS-Yahoo: "Adding chat buddy twice" error when inviting someone to a chatroom, r=clokep. 22:48:14 <-- EionRobb has quit (Connection reset by peer) 22:48:31 --> EionRobb has joined #instantbird 23:10:26 <instant-buildbot> build #462 of macosx-onCommit is complete: Failure [failed shell_1] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/462 blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com> 23:10:30 <-- nhnt11 has quit (Ping timeout) 23:10:35 <flo-retina> nhnt11: have we filed a bug yet to reduce the time wasted in Socket.resetPingTimer? 23:11:40 <flo-retina> qheaden: chat/protocols/yahoo/test/test_yahooAccount.js -> resource:///components/yahoo.js | TypeError: conv.updateTyping is not a function 23:22:10 --> nhnt11 has joined #instantbird 23:24:44 <flo-retina> nhnt11: I've just applied the patch from bug 2160 to profile before/after. 23:24:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2160 nor, --, ---, nobody, NEW, UI lags while stats service is receiving chat rooms 23:24:50 <flo-retina> It seems a great improvement 23:27:39 <instantbot> New Core - IRC bug 2164 filed by florian@instantbird.org. 23:27:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2164 nor, --, ---, nobody, NEW, Socket.resetPingTimer shows up in LIST profiles 23:27:51 <flo-retina> now the things that show up very obviously in the profile are bug 2153, bug 2157, bug 2164 and QueryInterface/getInterfaces 23:27:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2153 nor, --, ---, aleth, ASSI, Make UTF-8 conversion warnings less noisy 23:27:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 23:28:30 <flo-retina> once we get these 4 things addressed, we should profile again, but I think we will be in position of preff'ing on automaticList :) 23:29:17 <-- mconley has quit (Input/output error) 23:31:15 --> clokep has joined #instantbird 23:31:15 * ChanServ sets mode +o clokep 23:32:11 <flo-retina> clokep: can you look into the yahoo failure please? (either fix it if it's trivial, or backout bug 2111) 23:32:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2111 nor, --, ---, qheaden, ASSI, Yahoo Web Client Causes Endless Typing Notification 23:32:41 <clokep> flo-retina: OK. 23:32:48 <flo-retina> great, thanks! :) 23:34:36 <clokep> flo-retina: I know what the issue is. 23:35:19 <clokep> I'll fix it. 23:35:26 <clokep> rs=bustage? 23:35:37 <flo-retina> yes 23:35:49 <instantbot> clokep@gmail.com set the Resolution field on bug 2089 to FIXED. 23:35:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2089 nor, --, 1.5, qheaden, RESO FIXED, Debug logs are binary only 23:36:19 <instantbot> clokep@gmail.com set the Resolution field on bug 2150 to FIXED. 23:36:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2150 maj, --, 1.5, qheaden, RESO FIXED, Conference invites don't work 23:37:09 <instantbot> clokep@gmail.com set the Resolution field on bug 2161 to FIXED. 23:37:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2161 tri, --, 1.5, florian, RESO FIXED, Bubbles' updateLastInsertTime function wastes a lot of time setting and clearing timeouts 23:37:30 <instantbot> clokep@gmail.com set the Resolution field on bug 2093 to FIXED. 23:37:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2093 nor, --, 1.5, qheaden, RESO FIXED, "Adding chat buddy twice" error when inviting someone to a chatroom 23:37:35 <flo-retina> a pretty readable profile of the jank caused on the IRC prpl side when receiving LIST results: http://i7.minus.com/ibivGwVUKq9UVK.png 23:37:44 <flo-retina> it's nice to see that most of this is already being addressed :) 23:38:37 <flo-retina> we already have solutions to get rid of >50% of the time spent here! :) 23:40:17 <flo-retina> I'm surprised that GenericAccountPrototype.connected() shows up. I wonder what we do in it for it to be that slow (although only 16 samples isn't much, and it's possible the 1.7% figure is largely exaggerated) 23:41:24 <flo-retina> it seems to just forward http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#49 :-S 23:41:43 <flo-retina> that's strange 23:41:57 <flo-retina> I'll assume it just means we need to profile again once the other stuff is fixed, to get more meaningful data 23:47:53 <instantbot> clokep@gmail.com set the Resolution field on bug 2111 to FIXED. 23:47:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2111 nor, --, 1.5, qheaden, RESO FIXED, Yahoo Web Client Causes Endless Typing Notification 23:48:12 <clokep> flo-retina: Well...hopefully that'll all be fixed soon! :) 23:50:47 <instantbot> clokep@gmail.com granted review for attachment 2857 on bug 2157. 23:50:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, ---, nhnt11, NEW, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 23:51:02 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5028524d29b8 - Patrick Cloke - Bug 2111 - Yahoo Web Client Causes Endless Typing Notification, rs=bustage-fix. 23:51:05 <clokep> Do we want to wait for a review of that from aleth? 23:51:08 <clokep> Thanks instantbot. :P 23:53:03 <flo-retina> looks like he hasn't r-'ed any of the previous iterations, so I guess we can just check it in 23:53:17 <clokep> Want me to do that? 23:56:02 <instantbot> clokep@gmail.com set the Resolution field on bug 2157 to FIXED. 23:56:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2157 nor, --, 1.5, nhnt11, RESO FIXED, Call getChatRoomDefaultFieldValues lazily for awesometab roomInfos 23:57:04 <instantbot> clokep@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2857 on bug 2157. 23:58:14 <instantbot> clokep@gmail.com cancelled feedback?(clokep@gmail.com) for attachment 2589 on bug 2039. 23:58:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2039 nor, --, ---, atuljangra66, ASSI, File Transfer Backend 23:58:35 <instantbot> clokep@gmail.com cancelled feedback?(clokep@gmail.com) for attachment 2624 on bug 2064. 23:58:36 <instantbot> clokep@gmail.com cancelled feedback?(clokep@gmail.com) for attachment 2588 on bug 2037. 23:58:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2064 nor, --, ---, atuljangra66, NEW, file link backend for instantbird 23:58:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP 23:58:55 --> mconley has joined #instantbird 23:59:57 <instantbot> clokep@gmail.com denied review for attachment 2845 on bug 2153.