All times are UTC.
00:00:09 <flo-retina> what's the number of the bug that added this code? 00:00:45 <flo-retina> bug 2055? 00:00:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab needs to display open conversations and those on hold. 00:00:51 <nhnt11> I think so 00:01:22 <nhnt11> (checking) 00:01:32 <instantbot> New Instantbird (UI) bug 2125 filed by florian@instantbird.org. 00:01:32 <nhnt11> yeah it is 00:01:33 <flo-retina> just r+ the patch if you like it 00:01:33 <instantbot> florian@instantbird.org requested review from nhnt11@gmail.com for attachment 2781 on bug 2125. 00:01:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2125 maj, --, ---, florian, NEW, Opening the newtab causes the whole conversation window to be leaked 00:01:49 * flo-retina will do checkins and go to bed 00:02:02 <flo-retina> I've had enough debugging for today ;) 00:02:15 <flo-retina> and tomorrow I'll need to figure out why the system message grouping is broken on bubbles 00:02:25 <flo-retina> (or just port Mook's patch if that fixes it :-D) 00:02:28 <nhnt11> :) 00:03:24 <instantbot> nhnt11@gmail.com granted review for attachment 2781 on bug 2125. 00:06:41 * flo-retina hopes the next nightly won't be full of regressions :-D 00:09:21 <instantbot> florian@instantbird.org set the Resolution field on bug 2125 to FIXED. 00:09:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2125 maj, --, 1.5, florian, RESO FIXED, Opening the newtab causes the whole conversation window to be leaked 00:09:51 <instantbot> florian@instantbird.org set the Resolution field on bug 2009 to FIXED. 00:09:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2009 nor, --, 1.5, aleth, RESO FIXED, Accounts don't automatically reconnect when back online if the "offline" status was set while the co 00:10:32 <instantbot> florian@instantbird.org set the Resolution field on bug 1994 to FIXED. 00:10:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, 1.5, aleth, RESO FIXED, Account reconnects after using the /quit command 00:11:21 <flo-retina> rainy week-ends are quite productive for Instantbird ;) 00:11:37 <nhnt11> :) 00:17:48 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/db3e7619a857 - Florian Quèze - Bug 2125 - Opening the newtab causes the whole conversation window to be leaked, r=nhnt11. 00:17:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6dfbf1f5adba - aleth - Bug 2009 - Accounts don't automatically reconnect when back online if the 'offline' status was set while the computer was offline, r=fqueze. 00:17:50 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7991bfbc4d28 - aleth - Bug 1994 - Account reconnects after using the /quit command, r=fqueze,clokep. 00:28:31 <instant-buildbot> build #449 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/449 00:33:45 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:56:09 <-- dew has quit (Ping timeout) 00:56:18 --> dew has joined #instantbird 01:00:55 --> nakp has joined #instantbird 01:01:05 --> nhnt11 has joined #instantbird 01:04:16 <-- nakp has quit (Quit: Saliendo) 01:37:01 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:12:44 <-- wnayes has quit (Quit: wnayes) 02:23:56 --> nhnt11 has joined #instantbird 02:34:11 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:38:38 --> nhnt11 has joined #instantbird 02:59:16 <-- nhnt11 has quit (Input/output error) 03:02:11 --> nhnt11 has joined #instantbird 03:10:47 <-- flo-retina has quit (Ping timeout) 03:11:26 --> flo-retina has joined #instantbird 03:11:26 * ChanServ sets mode +qo flo-retina flo-retina 03:14:13 <-- mconley has quit (Input/output error) 03:15:13 --> mconley has joined #instantbird 03:17:41 --> nhnt12 has joined #instantbird 03:19:02 <-- nhnt11 has quit (Ping timeout) 03:19:36 <-- mconley has quit (Input/output error) 03:20:52 --> mconley has joined #instantbird 03:21:23 <-- mconley has quit (Input/output error) 03:23:08 --> mconley has joined #instantbird 03:36:04 <-- mconley has quit (Input/output error) 03:38:41 <instant-buildbot> build #950 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/950 03:52:30 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 03:52:35 --> nhnt11 has joined #instantbird 04:15:16 <-- dionisos has quit (Ping timeout) 04:18:56 * nhnt11 got his debug build to build 04:18:57 <nhnt11> finally 04:42:54 <-- nhnt11 has quit (Input/output error) 04:43:16 --> nhnt11 has joined #instantbird 05:42:18 <-- nhnt11 has quit (Ping timeout) 05:43:32 --> nhnt11 has joined #instantbird 07:54:12 --> qlum has joined #instantbird 08:00:21 <-- Even has quit (Input/output error) 08:02:22 <flo-retina> nhnt11: I'm curious, what was breaking it? 08:02:41 <nhnt11> flo-retina: I'm not sure. I did some reinstalling and all is good 08:02:47 <nhnt11> (Xcode and command line tools) 08:02:57 <flo-retina> 16 commits since the latest successful Windows nightly :( 08:02:58 --> Even has joined #instantbird 08:02:58 * ChanServ sets mode +o Even 08:03:08 <flo-retina> Even: good morning :) 08:05:20 * flo-retina wonders if https://bugzilla.mozilla.org/show_bug.cgi?id=909006 will get some traction now that it has easy steps to reproduce 08:13:20 * nhnt11 really likes the new look of BMO 08:20:38 <flo-retina> uh, displaying a large log (1.1MB from #developers yesterday) is so slow in my debug build :( 08:22:20 * nhnt11 goes to eat lunch 08:22:26 <-- nhnt11 has quit (Input/output error) 08:24:33 <qlum> that is one large log 08:26:33 <flo-retina> qlum: yeah, there were some spamming bot 08:27:47 <qlum> hmm seems I have at least 3 log files bigger then that 08:27:59 <qlum> but they are pretty old 08:28:16 <flo-retina> debug builds are also super slow 08:28:40 <flo-retina> but my computer isn't, so that should compensate, and may bring things close to what someone on a typical low end machine would see 08:29:56 <flo-retina> let's see if the gecko profiler can tell me what's taking so much time 08:32:52 <flo-retina> the profiler agrees with me that this isn't snappy at all: http://i7.minus.com/ibkVkyTBup5qiO.png 08:33:57 <flo-retina> (for those not used to reading charts of the gecko profiler: black is OK, red means = UI is frozen. Colors in between (dark red, ...) is when the UI is sluggish but still handling user events a bit) 08:35:41 <qlum> ah, either way lots of red is usually not that great 08:35:46 <qlum> whatever it displays 08:36:19 <flo-retina> qlum: when it's all red, users start throwing rotten tomatoes at the developers ;) 08:36:53 <qlum> Nah, they just think what a peace of shit, gonna use another client next time 08:37:12 <flo-retina> yeah, and they usually do a great job of finding one that's worse :) 08:38:43 <qlum> Well if its all red all the time finding something better is not that hard 09:29:24 --> nhnt11 has joined #instantbird 10:01:18 <flo-retina> bah, Bubbles' system message collapsing code has no change to work right with a MutationObserver... 10:27:46 <flo-retina> at shutdown on my debug build: [Exception... "'TypeError: this._account is undefined' when calling method: [nsITransportEventSink::onTransportStatus]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0" data: no] 10:28:48 <flo-retina> I guess that's http://lxr.instantbird.org/instantbird/source/chat/modules/socket.jsm#450 10:31:52 --> FireFly_TB has joined #instantbird 10:47:35 <-- nhnt11 has quit (Input/output error) 10:48:57 --> nhnt11 has joined #instantbird 11:03:53 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2782 on bug 1994. 11:03:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, 1.5, aleth, RESO FIXED, Account reconnects after using the /quit command 11:21:50 <-- Even has quit (Input/output error) 11:26:58 --> jb has joined #instantbird 11:37:41 --> Even has joined #instantbird 11:37:42 * ChanServ sets mode +o Even 11:40:53 <-- jb has quit (Quit: jb) 11:43:41 <flo-retina> alright, my mutation observer patch only broke Bubbles 11:43:50 <flo-retina> but I'll cleanup PaperSheet too anyway :) 11:48:13 <-- Even has quit (Input/output error) 11:49:49 <nhnt11> flo-retina: What's wrong with paper sheets? 11:49:50 * nhnt11 uses it 11:56:43 --> dionisos has joined #instantbird 12:10:20 --> gerard-majax has joined #instantbird 12:27:34 <-- EionRobb has quit (Quit: Leaving.) 12:29:24 <-- FireFly_TB has quit (Quit: FireFly_TB) 12:40:40 --> clokep has joined #instantbird 12:40:40 * ChanServ sets mode +o clokep 12:54:51 <flo-retina> nhnt11: some JS code in it is ugly, can we can simplify by using new CSS features instead of it. 12:55:00 <nhnt11> Cool 12:55:01 <flo-retina> *and we can 12:57:59 * nhnt11 has been busy today and is going out for dinner... :( 12:59:41 <instantbot> clokep@gmail.com granted review for attachment 2782 on bug 1994. 12:59:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, 1.5, aleth, RESO FIXED, Account reconnects after using the /quit command 13:00:09 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:00:14 --> clokep has joined #instantbird 13:00:14 * ChanServ sets mode +o clokep 13:14:57 <-- flo-retina has quit (Ping timeout) 13:42:06 <-- nhnt11 has quit (Input/output error) 14:44:36 --> wnayes has joined #instantbird 15:00:33 --> FireFly_TB has joined #instantbird 15:03:21 --> mconley has joined #instantbird 16:39:56 <-- skeledrew has quit (Ping timeout) 16:40:27 --> skeledrew has joined #instantbird 16:55:34 --> flo-retina has joined #instantbird 16:55:35 * ChanServ sets mode +qo flo-retina flo-retina 16:58:12 <flo-retina> heh, my guess was right, bug 898760 got closed when merging into m-c :-/ 17:03:59 <-- clokep has quit (Ping timeout) 17:35:10 <instantbot> New Instantbird (UI) bug 2126 filed by florian@instantbird.org. 17:35:11 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2783 on bug 2126. 17:35:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2126 nor, --, ---, nobody, NEW, Simplify system message collapsing 17:35:22 <flo-retina> an now that I'm _really_ familiar with this code, I can go r- Mook's patch :-P 17:41:57 <-- mconley has quit (Input/output error) 18:02:20 <flo-retina> hmm, bug 2125 means we were leaking the whole conversation window; maybe I should stop searching for explanation of the 3 or so MB that were leaked in imConversations.js :) 18:02:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2125 maj, --, 1.5, florian, RESO FIXED, Opening the newtab causes the whole conversation window to be leaked 18:44:22 --> chrisccoulson has joined #instantbird 18:56:39 <-- FireFly_TB has quit (Ping timeout) 18:59:15 --> FireFly_TB has joined #instantbird 19:04:19 --> mconley has joined #instantbird 19:08:20 <-- FireFly_TB has quit (Ping timeout) 19:11:32 <-- mconley has quit (Ping timeout) 19:12:09 --> FireFly_TB has joined #instantbird 19:24:06 <-- FireFly_TB has quit (Ping timeout) 19:24:12 --> mconley has joined #instantbird 19:32:57 <-- mconley has quit (Ping timeout) 19:39:53 --> jb has joined #instantbird 19:51:39 --> mconley has joined #instantbird 19:51:56 <-- jb has quit (Ping timeout) 19:57:54 --> jb has joined #instantbird 20:23:43 <-- wnayes has quit (Ping timeout) 20:25:17 --> EionRobb has joined #instantbird 20:28:24 --> wnayes has joined #instantbird 20:34:18 <-- jb has quit (Ping timeout) 20:36:40 --> jb has joined #instantbird 20:39:12 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:46:04 --> rosonline has joined #instantbird 20:46:24 <-- mconley has quit (Ping timeout) 21:09:55 <-- jb has quit (Ping timeout) 21:56:35 --> clokep has joined #instantbird 21:56:35 * ChanServ sets mode +o clokep 22:00:15 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:00:19 --> clokep has joined #instantbird 22:00:19 * ChanServ sets mode +o clokep 22:04:15 <clokep> Hello. 22:10:34 <-- rosonline has quit (Ping timeout) 22:43:09 <-- qlum has quit (Quit: Getting the <censored> out.) 22:45:29 --> flo-retina has joined #instantbird 22:45:29 * ChanServ sets mode +qo flo-retina flo-retina 22:47:06 <flo-retina> clokep: hey :) 22:47:29 <clokep> flo-retina: Hello. Looks like you've been busy 22:47:36 <flo-retina> the mac mini has been relocated to my place. 22:47:42 <flo-retina> clokep: well, the week-end has been rainy ;) 22:48:25 <clokep> :) 22:48:28 <clokep> Good for us. 22:52:15 <flo-retina> looks like bug 1994 is the only one that needs a checkin now 22:52:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1994 nor, --, 1.5, aleth, RESO FIXED, Account reconnects after using the /quit command 22:52:38 <flo-retina> clokep: even though I spent most of the week-end on Instantbird, I still haven't done half of what I hoped to do 22:52:51 <flo-retina> obviously I spent more time fighting regressions than I would have expected 22:52:54 <clokep> flo-retina: Don't feel too bad, I haven't done anything in forever... 22:53:01 <clokep> And I'm not motivated at all to right now. :-/ 22:53:21 <flo-retina> clokep: hg log disagrees, you've done plenty of reviews ;) 22:53:40 <clokep> Reviews don't feel nearly as...awesome as writing patches. 22:54:00 <flo-retina> yeah 22:54:26 <flo-retina> it's important sometimes to ignore the review queue and just spend an hour or two coding something you know you'll enjoy using / scratching an itch 22:54:55 <clokep> Understood. :) 22:55:32 <flo-retina> the other thing I wanted to handle today is fixing the freeze when displaying a large log that I looked at with the profiler 22:55:48 <flo-retina> I now know it's all wrong. I would like it to be less wrong 22:55:57 <clokep> "it"=? 22:58:03 <flo-retina> clokep: we have 2 for loops that go over ALL the messages of the log before we start the part that is pseudo asynchronous. 22:58:43 <flo-retina> the first for loop freezes my debug build for ~2 seconds, and the second for 15 or so seconds with the 1.3MB log I had from #developers yesterday. 22:59:07 <clokep> Wow! 22:59:15 <clokep> That seems inefficient, yes. :) 22:59:17 <flo-retina> (on my non-debug build the total delay is less than 2s; but it's a super fast machine, so I assume these loops are painful for people with low end hardware) 23:00:06 <flo-retina> clokep: yeah, that seems... *wrong* ;). That's why I was tempted to go fix it the day I noticed it ;). 23:05:19 <flo-retina> clokep: screenshot of the profiler, if you haven't seen in the log: http://i7.minus.com/ibkVkyTBup5qiO.png 23:06:06 <clokep> flo-retina: I did see it. :( 23:06:14 <flo-retina> looks like I wasn't even exaggerating, the 2 large red areas at the beginning last 19s on the chart 23:06:53 <flo-retina> on the plus side... it's nice that I have a working profiler ;) 23:07:23 <flo-retina> not sure I'll fix it more, so maybe I should just share the file I have (if I can find it again :-S) 23:10:00 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3a003ed296a6 - Florian Quèze - Bug 1994 - Account reconnects after using the /quit command - follow-up to fix a shutdown warning, r=clokep. 23:19:22 --> mconley has joined #instantbird 23:22:52 <instant-buildbot> build #450 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/450 23:58:16 <-- mconley has quit (Input/output error)