#instantbird log on 08 19 2013

All times are UTC.

00:02:57 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
00:55:19 <-- dew has quit (Ping timeout)
00:55:39 --> dew has joined #instantbird
01:02:33 --> clokep has joined #instantbird
01:02:33 * ChanServ sets mode +o clokep 
01:02:46 <-- clokep has quit (Input/output error)
01:09:42 --> clokep has joined #instantbird
01:09:42 * ChanServ sets mode +o clokep 
01:23:11 <-- clokep has quit (Ping timeout)
02:18:56 <-- mconley has quit (Input/output error)
03:08:27 <instant-buildbot> build #945 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/945
03:14:08 --> FireFly_TB has joined #instantbird
03:37:58 <-- FireFly_TB has quit (Quit: FireFly_TB)
03:44:55 <-- wnayes has quit (Quit: wnayes)
04:01:12 --> jb has joined #instantbird
04:51:27 <-- sabret00the has quit (Connection reset by peer)
04:51:50 --> sabret00the has joined #instantbird
05:32:17 <-- jb has quit (Ping timeout)
06:11:23 <instant-buildbot> build #1042 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1042
06:31:35 --> FireFly_TB has joined #instantbird
06:37:28 <-- FireFly_TB has quit (Input/output error)
06:39:21 --> jb has joined #instantbird
06:40:52 <-- EionRobb has quit (Quit: Leaving.)
07:21:55 --> gerard-majax__ has joined #instantbird
08:00:23 --> florian has joined #instantbird
08:28:43 <-- florian has quit (Ping timeout)
08:57:12 --> aleth has joined #instantbird
08:57:12 * ChanServ sets mode +h aleth 
09:24:32 --> nhnt11 has joined #instantbird
09:27:25 --> flo-retina has joined #instantbird
09:27:25 * ChanServ sets mode +qo flo-retina flo-retina 
09:46:04 * nhnt11 wants to submit a patch for ranking today
09:50:22 <flo-retina> cool :)
10:17:16 --> clokep has joined #instantbird
10:17:16 * ChanServ sets mode +o clokep 
10:32:57 <flo-retina> oh, BMO is now using gravatar
10:33:58 <aleth> :(
10:34:04 <aleth> I hope there's a pref...
10:34:08 <flo-retina> aleth: you dislike it?
10:34:24 <aleth> Yes, it takes up space and slows down loading pages
10:34:25 <flo-retina> aleth: I guess you can use ad block if you really dislike it ;)
10:35:15 <aleth> I would have preferred the use of colours to distinguish who is speaking, but I realize I'm in the minority on that one...
10:36:22 <aleth> I find gravatars distracting somehow.
10:36:38 <flo-retina> aleth: "Show gravatar images when viewing bugs "
10:36:42 <flo-retina> there's a pref, just for you ;)
10:36:50 <aleth> Thankyou BMO :D
10:52:32 <-- clokep has quit (Ping timeout)
10:52:58 * flo-retina now has less than 20 unread emails in his "bugzilla" tag :).
10:53:09 <flo-retina> (that means they all fit on the same page in gmail :))
10:55:06 <aleth> Actually, the way they've used gravatars on BMO is pretty unobtrusive, so I take my premature complaining back (though I'll probably still end up turning them off) ;)
11:55:56 * qheaden_away is now known as qheaden
11:55:59 <qheaden> Hello everyone.
12:12:00 * aleth has empty Friends tags on all his profiles now
12:12:38 <qheaden> aleth: Is it my fault in bug 2105?
12:12:38 <aleth> qheaden: Would you be interested in fixing bug 2027? ;)
12:12:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2027 nor, --, ---, nobody, NEW, Delete a tag when it has no contacts associated with it
12:12:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, 1.5, qheaden, RESO FIXED, Tags Service Should Provide a Default Contact Group
12:13:30 <aleth> qheaden: It's from my js-yahoo testing (bug 2088)
12:13:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, 1.5, qheaden, RESO FIXED, New contact does not get added to the correct tag
12:13:50 <qheaden> Ahh. So it's still my fault. :P
12:14:05 <aleth> Yeah, /and/ you bitrotted one of my patches :P
12:14:14 <qheaden> :P
12:14:29 <aleth> Not that I mind as it will actually make the code cleaner :)
12:14:39 <qheaden> I'll CC myself to 2027. I'm working on 2112 at the moment.
12:15:19 --> dionisos has joined #instantbird
12:43:21 --> clokep_ has joined #instantbird
12:46:38 <flo-retina> not a terrible bitrot ;)
12:53:08 <clokep_> Hello.
12:53:13 * clokep_ has caught up on logs, not bugmail.
12:53:59 <aleth> wb :)
12:54:34 <clokep_> Thanks.
12:54:42 <clokep_> No more vacations planned until September. ;)
12:55:01 * nhnt11 waves at clokep_
12:57:02 <clokep_> Are there any reviews still waiting for me that are blocking people?
12:57:52 <aleth> clokep_: A quick look at the IRC half of bug 2066 might speed its way ;)
12:57:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms
12:59:56 * clokep_ decided from the conversation he probably doesn't like what's happened in that bug. ;)
13:00:00 <clokep_> I'll try to take a look today
13:02:03 <qheaden> clokep_: Welcome back. :)
13:03:58 <clokep_> Thanks qheaden .
13:04:19 <qheaden> clokep_: Right now, I'm working on abstracting buddy request code.
13:07:12 <aleth> clokep_: well, you can always r- ;)
13:13:59 <qheaden> clokep_: Are there any plans to check in bug 2090?
13:14:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2090 nor, --, ---, qheaden, ASSI, /invite command is broken in private conversations
13:14:31 <clokep_> qheaden: I had no idea that needed to be checked in.
13:14:39 <clokep_> No one marked it as checkin needed. ;)
13:15:01 <qheaden> Oh okay. I just noticed it yesterday. I didn't want to place checkin needed myself. :)
13:15:10 <clokep_> You should be placing it.
13:15:56 <qheaden> clokep_: Okay. I'll place it next time.
13:16:39 <clokep_> qheaden: Usually the reviewer does it, but it requires a second change to the bug so it's not uncommon for us to forget.
13:16:59 <qheaden> I can understand that. :)
13:23:21 <instantbot> clokep@gmail.com set the Resolution field on bug 2090 to FIXED.
13:23:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2090 nor, --, 1.5, qheaden, RESO FIXED, /invite command is broken in private conversations
13:23:41 <qheaden> clokep_: Thanks.
13:25:49 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/48b236700aca - Quentin Headen - Bug 2090 - /invite command is broken in private conversations, r=clokep.
13:53:33 --> mconley has joined #instantbird
14:08:55 <qheaden> clokep_: What do you think of this abstraction so far? http://pastebin.instantbird.com/297733
14:09:01 <qheaden> I haven't made any changes to JS-XMPP yet.
14:11:29 <clokep_> qheaden: Looks reasonable.
14:11:47 <qheaden> Good. :)
14:12:45 <clokep_> qheaden: I feel like username should be passed to the callbacks?
14:12:49 <clokep_> Or what do the callbacks receive?
14:13:06 <qheaden> clokep_: The interface specify the callbacks as void method.
14:13:16 <qheaden> I mean, no arguments.
14:13:54 <qheaden> But we can wrap the callback within an argumentless method, and pass the username there if you would like.
14:14:03 <qheaden> Like I am doing in my JS-Yahoo changes.
14:43:01 <-- jb has quit (Quit: jb)
14:44:12 --> jb has joined #instantbird
14:46:59 <-- jb has quit (Ping timeout)
15:09:08 <clokep_> qheaden: Yes, I'm asking if that makes sense. ;)
15:09:20 <qheaden> It does. :)
15:10:06 <clokep_> Does it?
15:10:10 <clokep_> Let me rephrase.
15:10:16 <clokep_> I'm asking if it makes sense for those methods to be void.
15:18:44 <-- Suiseiseki has quit (Ping timeout)
15:19:43 --> Suiseiseki has joined #instantbird
15:32:02 <qheaden> clokep_: Not really. I mean, we should be getting the username of the buddy asking for the request.
15:32:20 <qheaden> Are you suggesting I change the prplIBuddyRequest interface?
15:36:08 --> wnayes has joined #instantbird
15:37:57 <clokep_> qheaden: I'm asking if it would make sense to, yes.
15:38:47 <clokep_> In particular, I wonder if we should give the prplIBuddyRequest back to the callback.
15:38:49 <clokep_> flo-retina: ^
15:41:17 <qheaden> clokep_: I agree that we need to provide the callbacks with more information. Each protocol has different ways of handling buddy requests, so this info is needed to correctly form packets that need to be sent.
15:44:32 <qheaden> clokep_: I'm just going to include some interface changes in the patch, and put it up for review to see how it is received.
15:49:00 <flo-retina> clokep_: not sure what callback is being discussed here
15:49:18 <clokep_> flo-retina: The callbacks in prplIBuddyReqest.
15:49:20 <clokep_> Request
15:57:35 <qheaden> On second thought, I'm going to leave the interface alone for now.
15:57:50 <-- gerard-majax__ has quit (Ping timeout)
15:58:37 <instantbot> New Core - General bug 2115 filed by aleth@instantbird.org.
15:58:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2115 nor, --, ---, nobody, NEW, Provide a way to obtain the normalizedName of a nick
16:00:16 * clokep_ sighs.
16:00:54 <aleth> That's the appropriate response, yes...
16:01:39 <flo-retina> aleth: :-D
16:02:00 <flo-retina> clokep_: so what was the problem with this buddy request interface?
16:02:47 <clokep_> flo-retina: qheaden is passing in the userName to each callback and has some funky anon functions to do that.
16:02:53 <clokep_> He can tell you more, I'm going to get a burrito.
16:04:01 <flo-retina> clokep_: bon appétit :)
16:05:33 <flo-retina> aleth: this bug may be quite tricky to fix right for XMPP btw :(
16:06:13 <flo-retina> naively (with IRC in mind) I would say that the fix is to just expose a normalize method on the account
16:06:32 <flo-retina> but normalizing the 'normalized' name of a participant of a MUC will give... the MUC's name :(
16:10:57 <aleth> Sounds like a headache.
16:14:34 <flo-retina> aleth: the problem is that XMPP MUCs can hide the users' usernames. So a chat participant name is room@conference.server.tld/nick but a JID is usually name@server.tld/resource, and normalizing a JID is usually taking off the resource part ;).
16:15:36 <flo-retina> related: bug 1527 (especially the "* handle sending private messages to a MUC participant" line :))
16:15:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1527 nor, --, ---, nobody, NEW, Finish the implementation of basic MUC support in JS-XMPP
16:18:00 <flo-retina> I wonder how Pidgin logs private messages sent to XMPP MUC participants.
16:20:10 --> jb has joined #instantbird
16:21:18 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:26:47 --> Mook_as has joined #instantbird
16:47:16 <qheaden> Okay, I was AFK.
16:47:40 <qheaden> flo-retina: Let me know if you have further questions about my buddy request callbacks.
16:48:49 --> flo-retina has joined #instantbird
16:48:49 * ChanServ sets mode +qo flo-retina flo-retina 
16:51:34 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:52:51 --> nhnt11 has joined #instantbird
16:56:56 <qheaden> clokep_: It looks like it will be easier for us to pass the entire authRequest object instead of just the username.
16:57:22 <qheaden> The XMPP method used to accept or deny a buddy makes use of the authRequest object itself
16:58:24 <clokep_> qheaden: That probably makes sense to do then.
16:58:55 <qheaden> It's best to provide the prpls lots of flexibility in this case. The protocols vary so much.
16:59:14 * flo-retina is still not sure of what API change is being discussed here
16:59:39 <qheaden> flo-retina: http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIRequest.idl#31
16:59:55 <qheaden> The grant() and deny() methods should be passed a reference to the request object.
17:00:11 <qheaden> Right now, they accept no parameters.
17:01:12 <flo-retina> qheaden: they are part of the request object
17:01:17 <flo-retina> the reference is "this"
17:02:20 * qheaden feels stupid again for getting lost in JS "this" changes.
17:11:04 <clokep_> Ah, yeah. If all you need is the username...that's easy. :)
17:13:17 <qheaden> Unfortunately, I can access the authRequest object using "this", but it won't let me access the account via the account() get property.
17:13:35 <qheaden> It works if I store the account in an _account property.
17:13:47 <qheaden> I need the account in order to access the YahooSession object.
17:14:13 <qheaden> So I guess I will just use _account
17:17:32 <-- aleth has quit (Quit: Ciao)
17:17:37 <clokep_> qheaden: The account property would only let you access things that are available via the interface, yes.
17:17:39 <clokep_> That's expected.
17:17:51 <clokep_> Just store it somewhere else if you need it for Yahoo.
17:17:58 <qheaden> Oh okay.
17:20:53 <qheaden> clokep_: this.userName cannot be accessed either. :-S
17:21:04 <qheaden> I hate to store all of this stuff in additional private properties.
17:31:16 <-- nhnt11 has quit (Ping timeout)
17:42:27 --> rosonline has joined #instantbird
17:43:41 --> Mnyromyr has joined #instantbird
17:43:51 <clokep_> qheaden: You need to give more information.
17:43:54 <clokep_> "Cannot be accessed"?
17:43:56 <clokep_> What is "this"?
17:44:00 <clokep_> What error is thrown?
17:44:35 <qheaden> clokep_: No error is thrown. "this" is supposed to be the authRequest object. When I try to use this.userName, I get an undefined value. The same for this.account().
17:44:40 <qheaden> *this.account
17:46:38 <qheaden> clokep_: It looks like something that has to do with idl interface boundaries and such.
17:47:22 <clokep_> qheaden: You didn't answer my question of what "this" is. ;)
17:47:25 <clokep_> Just what it's supposed to be.
17:47:28 <clokep_> Did you check that it is that?
17:47:52 <qheaden> clokep_: When I Cu.reportError(this), it gives me [object Object]
17:48:01 <clokep_> Something seems to be wrong thne.
17:48:03 --> qlum has joined #instantbird
17:56:08 <qheaden> clokep_: Looks like passing authRequest as an object to the callback solves the issues. It must be something fishy with XPCOM, so I'm just going to pass it as a parameter.
18:02:29 <flo-retina> and get an r- ;)
18:07:28 <qheaden> :(
18:09:08 <flo-retina> qheaden: if you really can't figure it out, using bind on the callbacks in the Yahoo code should hide the issue.
18:14:42 <-- jb has quit (Ping timeout)
18:16:09 <qheaden> I'll be back in a little bit.
18:37:04 --> unghost has joined #instantbird
18:46:34 --> gerard-majax__ has joined #instantbird
18:50:32 <-- qlum has quit (Client exited)
18:52:34 --> qlum has joined #instantbird
18:55:44 --> jb has joined #instantbird
18:59:19 * chrisccoulson_ is now known as chrisccoulson
19:30:16 <-- jb has quit (Ping timeout)
19:52:51 <-- Suiseiseki has quit (Ping timeout)
19:54:14 --> Suiseiseki has joined #instantbird
20:07:30 --> nhnt11 has joined #instantbird
20:23:12 <-- gerard-majax__ has quit (Ping timeout)
20:45:00 <-- nhnt11 has quit (Ping timeout)
21:13:01 <-- mconley has quit (Input/output error)
21:26:27 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:31:33 --> nhnt11 has joined #instantbird
21:32:38 <-- rosonline has quit (Client exited)
21:33:16 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:44:15 <-- wnayes has quit (Ping timeout)
21:45:22 --> wnayes has joined #instantbird
21:45:31 --> jb has joined #instantbird
21:56:19 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:59:40 --> EionRobb has joined #instantbird
22:21:02 <-- unghost has quit (Ping timeout)
22:27:02 <-- jb has quit (Ping timeout)
22:49:07 <-- qlum has quit (Quit: Getting the <censored> out.)
23:20:23 --> clokep has joined #instantbird
23:20:23 * ChanServ sets mode +o clokep 
23:22:00 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:22:12 --> clokep has joined #instantbird
23:22:12 * ChanServ sets mode +o clokep 
23:30:11 <clokep> qheaden: It'll probably help if you pastebin your code?
23:55:14 <qheaden> clokep: Okay. I can't think of what else I've copied from other prpls. I'll scan the code to look for duplicate stuff.
23:55:24 <qheaden> I think I did copy some buddy icon stuff.
23:56:23 <clokep> Good.
23:58:25 <instant-buildbot> build #453 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/453
23:58:29 <-- dionisos has quit (Ping timeout)