All times are UTC.
00:00:36 --> nhnt11 has joined #instantbird 00:01:38 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:01:44 --> nhnt11 has joined #instantbird 00:02:07 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:02:12 --> nhnt11 has joined #instantbird 00:03:50 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:03:55 --> nhnt11 has joined #instantbird 00:05:36 <qheaden> clokep: How does !== work? 00:06:03 * flo-retina goes to bed, good night 00:06:16 <nhnt11> flo-retina: 1 second 00:06:34 <nhnt11> flo-retina: goDoCommand won't work because there's no doCommand in the conversations window in Windows 00:06:41 <nhnt11> So I'll have to duplicate code 00:06:42 <nhnt11> is that ok? 00:06:47 * clokep wonders what flo-retina thinks of http://pastebin.instantbird.com/289445 00:07:21 <clokep> (We now use python files to create the ico files from pngs...so we end up with pyc files in the tree.) 00:09:01 <nhnt11> Meh, it's not really that much duplication anyway. I'm going to go ahead and submit a patch 00:11:37 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:11:57 --> nhnt11 has joined #instantbird 00:18:57 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:19:04 --> nhnt11 has joined #instantbird 00:20:25 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:20:30 --> nhnt11 has joined #instantbird 00:21:12 * clokep sighs and starts a clobber build. 00:22:11 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:23:22 --> nhnt11 has joined #instantbird 00:24:03 <Mook_as> nhnt11: you really don't want to set the clock in windows, unless you tell it to use UTC... linux machines usually use UTC for the clock, windows ones usually use local time 00:25:25 <clokep> Yay, timezones! :-D 00:26:49 --> jb has joined #instantbird 00:28:20 <nhnt11> Mook_as: I've told it to use UTC ;) 00:36:20 <nhnt11> Hmm, bug 2051 was r+ but didn't have checkin-needed. 00:36:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, ---, nhnt11, ASSI, Styling of new conversation listbox 00:39:02 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:40:30 --> nhnt11 has joined #instantbird 00:41:29 <-- jb has quit (Ping timeout) 00:41:40 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:41:46 --> nhnt11 has joined #instantbird 00:42:15 <-- clokep has quit (Ping timeout) 00:42:51 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:42:56 --> nhnt11 has joined #instantbird 00:43:00 --> clokep has joined #instantbird 00:43:00 * ChanServ sets mode +o clokep 00:43:57 --> mconley has joined #instantbird 00:44:03 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:45:11 --> nhnt11 has joined #instantbird 00:45:27 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:45:38 --> nhnt11 has joined #instantbird 00:45:54 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:49:06 <clokep> qheaden: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Comparison_Operators 00:50:52 --> nhnt11 has joined #instantbird 00:51:22 * nhnt11 is back on Mac to create some patches :) 01:00:49 <-- Mook_as has quit (Quit: Mook_as) 01:03:34 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2710 on bug 2042. 01:03:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nhnt11, ASSI, Starting conversations on unrelated keyboard- or mouse-events 01:05:19 <-- rosonline has quit (Client exited) 01:11:12 <nhnt11> BIO seems to be pretty slow today :S 01:12:45 <clokep> BIO seems to be pretty slow everyday. ;) 01:13:29 <nhnt11> :P 01:21:15 <instantbot> New Instantbird (UI) bug 2107 filed by nhnt11@gmail.com. 01:21:16 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2711 on bug 2107. 01:21:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2107 nor, --, ---, nobody, NEW, Fix theming of the overflow "+" button on Windows 01:31:57 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2712 on bug 2078. 01:31:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2078 nor, --, 1.5, nhnt11, REOP, Home/End in newtab filterbox don't work as expected 01:39:23 <qheaden> clokep: So did you have any comments about my get-icons patch? 01:39:41 <clokep> qheaden: I already gave you them on IRC. 01:41:57 <qheaden> clokep: So just simplifying the !buddy.iconChecksum part? 01:42:03 <clokep> Yes. 01:42:12 <clokep> That's all I noticed. 01:42:27 <qheaden> Great. I'll fix it and upload a patch. I would like to get this landed. :) 01:42:54 <clokep> Mmhmm. :) 01:44:37 <qheaden> It'd be cool if there was a 3D source control visualization software with an actual 3D tree and branches representing the source repo. :P 01:44:52 <clokep> Why would that be better than 2D? :P 01:44:55 * qheaden scribbles that in his idea book for possible development later this year. 01:45:32 <qheaden> Not necessarily better, but cooler. :P 01:45:38 <clokep> Hmm, OK. 01:45:51 <clokep> nhnt11: Looks like you've made some progress on all the minor bugs, how goes the stats sorting? 01:45:58 <qheaden> And have a bird "land" on the "tip" of a tree branch when a patch is landed. :P 01:46:53 <nhnt11> qheaden: Fun! Please write it! :P 01:47:06 * qheaden is seriously thinking about it now. 01:47:09 <nhnt11> clokep: I haven't worked on that the last two nights. 01:47:22 <clokep> Yes, but I just meant in general. 01:47:25 <nhnt11> I want to get some of these minor ones out of the way 01:47:27 <clokep> I have no idea where it's at, so I'm curious 01:47:35 <nhnt11> Er, it's on my blog :P 01:47:44 <clokep> Yeah your RSS feed keeps not working for me. 01:47:57 * clokep is going to bed though. 01:47:59 <clokep> I'll check tomorrow. 01:48:09 <nhnt11> Basically now I'm storing and using frequency and recency as parameters for ranking 01:48:28 <nhnt11> The algorithm I'm using is very arbitrary, and currently doesn't work too well (simple multiplication0 01:48:47 <nhnt11> I need to introduce some constantts/work out a normalization algorithm 01:48:55 <nhnt11> Good night! 01:50:16 <qheaden> clokep: I think using != is best for comparing our checksum values. 01:50:50 <qheaden> Wait, nevermind. forgot that !== also checks non-equality for values as well. 01:53:30 <instantbot> qheaden@phaseshiftsoftware.com cancelled review?(clokep@gmail.com) for attachment 2709 on bug 2070. 01:53:31 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2713 on bug 2070. 01:53:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, ASSI, Add Support for Buddy Icons 01:55:34 <qheaden> Also, bug 2090 is r+, but doesn't have [checkin-needed]. 01:55:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2090 nor, --, ---, qheaden, ASSI, /invite command is broken in private conversations 01:58:35 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2714 on bug 2065. 01:58:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 02:00:57 <instantbot> clokep@gmail.com granted review for attachment 2713 on bug 2070. 02:00:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, ASSI, Add Support for Buddy Icons 02:03:09 <qheaden> clokep: Thanks for the r+. :) 02:04:41 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2714 on bug 2065. 02:04:42 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2715 on bug 2065. 02:04:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 02:14:32 <-- chrisccoulson_ has quit (Ping timeout) 02:16:02 <nhnt11> bbl 02:30:49 --> chrisccoulson_ has joined #instantbird 02:57:01 <-- wnayes has quit (Quit: wnayes) 03:03:09 <-- clokep has quit (Ping timeout) 03:12:01 <instant-buildbot> build #940 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/940 03:17:31 --> Mook has joined #instantbird 03:22:29 <instant-buildbot> build #941 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/941 03:30:02 --> nakp has joined #instantbird 03:34:34 <Mook> hmm, I see nothing interesting in the nickserv logs... but I also don't see my manual /identify. 03:36:18 <Mook> oh, I guess it's http://pastebin.instantbird.com/289601 - for some reason it's not in the log viewer... 03:37:03 <Mook> also, that's the only log from this year. interesting. 03:37:51 <Mook> ah, the nickserv I usually see is oftc.net. 03:38:12 <Mook> (and the only way to tell was to look for logs...) 03:48:11 * qheaden is now known as qheaden_away 03:52:07 --> jb has joined #instantbird 04:13:22 <-- jb has quit (Ping timeout) 04:22:15 <-- mconley has quit (Input/output error) 04:25:44 <-- nakp has quit (Quit: Saliendo) 04:52:52 <-- Mook has quit (Quit: Mook) 05:22:44 --> mconley has joined #instantbird 05:28:40 <-- mconley has quit (Ping timeout) 05:36:58 --> FireFly_TB has joined #instantbird 05:53:35 <-- EionRobb has quit (Ping timeout) 05:54:52 --> EionRobb has joined #instantbird 05:59:27 <-- EionRobb has quit (Quit: Leaving.) 06:09:45 <-- Even has quit (Input/output error) 06:13:52 --> Even has joined #instantbird 06:13:52 * ChanServ sets mode +o Even 06:32:22 <-- nhnt11 has quit (Ping timeout) 06:58:08 --> nhnt11 has joined #instantbird 07:09:35 --> EionRobb has joined #instantbird 07:57:08 <flo-retina> clokep: hg ignoring .pyc is ok with me 08:05:19 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:15:21 <-- dew has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 08:29:04 <-- chrisccoulson_ has quit (Ping timeout) 08:39:35 --> gerv has joined #instantbird 08:41:18 <-- gerv has quit (Ping timeout) 08:42:34 --> chrisccoulson has joined #instantbird 08:44:07 --> gerv has joined #instantbird 08:58:30 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:01:10 --> jb has joined #instantbird 09:28:20 --> flo-retina has joined #instantbird 09:28:21 * ChanServ sets mode +qo flo-retina flo-retina 09:37:18 --> dionisos has joined #instantbird 09:37:54 <-- jb has quit (Ping timeout) 10:04:07 <EionRobb> not sure who it was the other day saying that VK doesn't use xmpp any more, but http://vk.com/dev/messages.get 10:04:43 <flo-retina> EionRobb: I think it was rosonline 10:04:54 <flo-retina> EionRobb: does that mean they have released a proprietary API? 10:05:48 <EionRobb> perhaps? 10:06:34 <EionRobb> looks similar to something else 10:06:44 <EionRobb> is it... opensocial api or something? 10:08:03 --> clokep has joined #instantbird 10:08:03 * ChanServ sets mode +o clokep 10:13:30 --> dew has joined #instantbird 10:33:46 <clokep> flo-retina: So can I just push that or do I need to file a bug? ;) 10:35:42 <flo-retina> the .pyc ignore? Just push 10:35:50 <clokep> That VK API doesn't look awful, but it's obviously easier when they just use XMPP. :P 10:38:36 <flo-retina> clokep: but oauth based stuff are more fun, developers have to deal with keys ;) 10:39:07 <EionRobb> oauth is terrible when there's no api to refresh the token 10:39:53 <clokep> I think what you actually mean is "oauth is terrible" ;) 10:39:58 <EionRobb> yeah :) 10:40:13 <clokep> I keep getting friend auth requests...and I have no idea what account they're on or anything about the person. :( 10:40:20 <clokep> Can't we add like tooltips or something there? 10:40:39 <EionRobb> or a protocol icon? 10:41:09 <clokep> I have multiple accounts of the same protocol. :) 10:41:23 <EionRobb> can you customise the icon per account? :) 10:42:52 <flo-retina> clokep: auth requests currently have a very poor UI :( 10:48:49 <-- EionRobb has quit (Quit: Leaving.) 10:49:54 <clokep> Yes. :) 10:54:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fd91ec38d605 - Patrick Cloke - Add *.pyc to .hgignore. 11:42:43 <instant-buildbot> build #439 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/439 11:45:18 --> clokep_ has joined #instantbird 12:09:24 <-- Tonnes has quit (Connection reset by peer) 12:12:18 --> Tonnes has joined #instantbird 12:29:48 <instantbot> florian@instantbird.org granted review for attachment 2706 on bug 1999. 12:29:48 <flo-retina> bah, yesterday evening I wanted to review wnayes' patch and then checkin bug 1999 but I didn't have time for the former than so forgot the latter :( 12:29:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1999 nor, --, ---, nobody, NEW, TypeError on moving the mouse over the close button on a tab on OS X 12:50:22 <clokep_> flo-retina: I think there's a bunch in the queue anyway. So...could do a few check-ins tonight. :) 12:50:44 <flo-retina> yeah, one of us will do :) 12:50:55 <flo-retina> anyway, the nightly failed this night, so that doesn't make a big difference ;) 12:57:45 --> jb has joined #instantbird 13:19:15 * clokep_ was thinking of doing the check-in needed now actually... 13:21:54 <flo-retina> are "File transfer server/port" reasonable strings for something used to fetch buddy icons? 13:22:14 <flo-retina> why is this exposed in the UI? 13:22:19 <clokep_> They would also be used for file transfers. 13:22:20 <flo-retina> is there any reason why a user would want to change it? 13:22:33 <clokep_> I could see why a user might change the port (to get through a firewall?) 13:22:44 <flo-retina> 80 would be blocked for http traffic ? 13:22:47 <clokep_> It was just to match what libpurple does. 13:23:22 <flo-retina> "Pager port" doesn't make much sense either :-S 13:23:47 * clokep_ wonders if we can leave it for now and then discuss each of them and remove them if we think they're not useful? 13:23:51 <flo-retina> alright, I don't want to block ongoing work with string bikeshedding 13:24:15 <flo-retina> "Ignore conference and chatroom invitations" why is this a prpl specific option? 13:24:26 <flo-retina> yeah, at some point in the future we should review all the options exposed 13:24:31 <flo-retina> and kill most of them :-P 13:27:19 <flo-retina> but yeah, doing checkins now is a good way to ensure we don't forget :) 13:28:04 <clokep_> Do youw ant me to do them then? 13:28:18 <clokep_> We have a global option for it, currently the code respects both. 13:28:31 <flo-retina> yeah 13:28:52 <flo-retina> I glanced quickly at what was in the queue and didn't see anything worth holding a patch 13:31:29 <-- clokep has quit (Ping timeout) 13:35:00 --> mconley has joined #instantbird 13:35:20 <-- mconley has quit (Connection reset by peer) 13:36:03 --> mconley has joined #instantbird 13:39:25 <clokep_> qheaden_away: None of your patches apply. 13:42:54 <flo-retina> clokep_: are you sure they applied them in the right order? 13:43:46 <flo-retina> bug 2088 is clearly above bug 2070 13:43:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 13:43:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, ASSI, Add Support for Buddy Icons 13:46:20 <clokep_> flo-retina: I did. 13:46:29 <flo-retina> ok :) 13:46:31 <clokep_> "clearly above" means "clearly after"? 13:46:39 <flo-retina> yeah, sorry 13:46:39 * clokep_ doesn't know what above/below would mean in this context. 13:46:58 <flo-retina> above wasn't very explicit :-S 13:47:08 <clokep_> Ah, no I applied them in the wrong order. 13:47:13 <clokep_> But it was easy enough to fix. 13:47:27 * clokep_ was more of complaining about the order of the patches in 2070. :) 13:48:03 <instantbot> clokep@gmail.com set the Resolution field on bug 1999 to FIXED. 13:48:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1999 nor, --, 1.5, nhnt11, RESO FIXED, TypeError on moving the mouse over the close button on a tab on OS X 13:48:13 <instantbot> clokep@gmail.com set the Resolution field on bug 2051 to FIXED. 13:48:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, 1.5, nhnt11, RESO FIXED, Styling of new conversation listbox 13:49:25 <instantbot> clokep@gmail.com set the Resolution field on bug 2088 to FIXED. 13:49:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, 1.5, qheaden, RESO FIXED, New contact does not get added to the correct tag 13:50:05 <instantbot> clokep@gmail.com set the Resolution field on bug 2070 to FIXED. 13:50:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, 1.5, qheaden, RESO FIXED, Add Support for Buddy Icons 13:54:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/73f7d0fb0426 - Nihanth Subramanya - Bug 1999 - TypeError on moving the mouse over the close button on a tab on OS X, r=fqueze. 13:54:37 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/786546c3527f - Nihanth Subramanya - Bug 2051 - Styling of new conversation listbox, r=Mic. 13:54:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1eea25566706 - Quentin Headen - Bug 2088 - New contact does not get added to the correct tag, r=clokep. 13:54:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8094f80f354c - Quentin Headen - Bug 2070 - Add Support for getting Buddy Icons, r=clokep. 13:54:40 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/38a4fa8c9eaf - Quentin Headen - Bug 2070 - Add support for setting Buddy Icons, r=clokep. 14:15:17 --> wnayes has joined #instantbird 14:21:44 <instant-buildbot> build #442 of macosx-onCommit is complete: Failure [failed shell_1] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/442 blamelist: Quentin Headen <qheaden@phaseshiftsoftware.com>, Nihanth Subramanya <nhnt11@gmail.com> 14:27:31 <flo-retina> clokep_: have we decided what we want to do for bug 2104? 14:27:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2104 nor, --, ---, nobody, NEW, Filenames for buddy icons are not null-checked in the new conversation tab. 14:31:51 <flo-retina> wow, dump can output colored messages :) 14:32:59 <-- jb has quit (Ping timeout) 14:36:20 --> nhnt11 has joined #instantbird 14:36:47 <nhnt11> Hi 14:37:03 <flo-retina> nhnt11: good evening :) 14:37:19 <nhnt11> I won't be online much tonight, been up all day. Tomorrow is a holiday for Independence day though so expect me to be coding away :) 14:38:20 * nhnt11 is glad to be rid of those TypeErrors. 14:38:32 <flo-retina> thanks for cleaning this up! :) 14:38:49 <flo-retina> maybe by the end of the summer we can have an empty console? :) 14:39:01 <nhnt11> They were very annoying when testing UI changes, they kept flooding the console. 14:39:05 <nhnt11> Heh 14:39:35 <flo-retina> the mutationobserver noise is also starting to get annoying ;) 14:39:49 <nhnt11> That shows up in Warnings though, so not as much :P 14:40:04 <flo-retina> I'm interested in warnings too 14:40:13 <flo-retina> they often give valuable hints 14:40:33 <nhnt11> Sure, I'm just saying they're not /as/ annoying when testing small things. 14:41:20 <flo-retina> clokep_: I don't remember the outcome of our last discussion about "Error: Registration completed before SASL authentication completed." Did you need a debug log? Do we have an understanding of what's going on there? 14:42:09 <flo-retina> There's "Warning: The server does not support SASL PLAIN authentication." before. 14:42:43 <flo-retina> iirc it was related to connecting an account that isn't the first nick of a group. 14:46:13 <flo-retina> qheaden_away, clokep_: test_yahooLoginHelper.js is failing: http://buildbot.instantbird.org/builders/macosx-onCommit/builds/442/steps/shell_1/logs/stdio 14:59:24 --> jb has joined #instantbird 15:04:41 <-- FireFly_TB has quit (Ping timeout) 15:22:03 <-- gerv has quit (Ping timeout) 15:23:01 --> gerv has joined #instantbird 15:32:51 <clokep_> flo-retina: I tihnk we decided on "" making more sense. 15:37:47 <-- dionisos has quit (Ping timeout) 15:39:42 <-- nhnt11 has quit (Ping timeout) 15:39:47 <clokep_> flo-retina: I think I need a debug log / the server you're connecting to / some knowledge of WTF is going on. :) 15:40:01 <clokep_> Do they support a differet mechanism? or just no mechanisms and SASL is configured wrong. 15:40:12 <flo-retina> I'm only connected to moznet and freenode 15:40:15 <clokep_> (In which case, there's probably a bug in our code that doesn't properly kill our sasl attempt.) 15:47:11 * qheaden_away is now known as qheaden 15:47:16 <qheaden> Hi all. 15:48:25 <flo-retina> clokep_: I don't even remember if I ever filed a bug about it 15:48:29 <clokep_> qheaden: You broke the world! :P 15:48:33 <clokep_> flo-retina: I don't think we did. :( 15:49:26 <qheaden> clokep_: I just noticed from the scrollback. :-S 16:02:50 <qheaden> clokep_: Should I create a separate bug for the test fix? 16:08:21 --> FireFly_TB has joined #instantbird 16:12:51 <-- FireFly_TB has quit (Ping timeout) 16:23:20 <instantbot> New Core - Yahoo! Messenger bug 2108 filed by qheaden@phaseshiftsoftware.com. 16:23:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2108 maj, --, ---, nobody, NEW, Test Fail Due to Bug 2070 Patch 16:27:46 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2716 on bug 2108. 16:27:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2108 maj, --, ---, qheaden, ASSI, Test Fail Due to Bug 2070 Patch 16:28:19 <qheaden> Okay, test failure fixed! :) 16:28:32 --> Mook_as has joined #instantbird 16:34:54 <-- IRCMonkey7815 has quit (Quit: Leaving) 16:53:29 * flo-retina things qheaden should try to run his tests before submitting patches ;) 16:53:33 <flo-retina> *thinks 17:04:18 <qheaden> flo-retina: I really should. :P 17:16:00 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:22:22 <clokep_> qheaden: No. 17:25:05 <-- jb has quit (Quit: jb) 17:26:01 --> jb has joined #instantbird 17:27:49 <qheaden> clokep_: I'm now looking at adding the default tag to the Tags service. How about I create a new method in its interface getDefaultTag(), and have it return the default "Contacts" tag? 17:31:25 <instantbot> clokep@gmail.com granted review for attachment 2716 on bug 2108. 17:31:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2108 maj, --, ---, qheaden, ASSI, Test Fail Due to Bug 2070 Patch 17:31:35 <clokep_> qheaden: I think that's exactly what Florian wants! 17:33:07 <instantbot> clokep@gmail.com set the Resolution field on bug 2108 to FIXED. 17:33:42 <qheaden> instantbot: uuid 17:33:43 <instantbot> ea9bfc0f-ae71-42a7-a97c-ba6484136dc0 (/msg instantbot cid for CID form) 17:34:59 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b94254c3277b - Quentin Headen - Bug 2108 - Test Fail Due to Bug 2070, r=clokep. 17:46:08 --> qlum has joined #instantbird 17:51:29 <instant-buildbot> build #443 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/443 17:53:15 <clokep_> :) 17:53:20 <qheaden> :) 17:53:20 <clokep_> Thanks for fixing that before the nightly qheaden . 17:53:33 <qheaden> clokep_: No prob. Sorry I broke it in the first place. 17:53:48 <qheaden> Failed tests prevent nightly releases right? 17:55:25 <clokep_> qheaden: Yes. 17:55:31 <qheaden> :( 17:55:43 <clokep_> We should make sure we run tests before putting up patches. :-/ 17:55:46 * clokep_ does it a lot too. 17:56:44 <qheaden> Yeah. 17:58:32 <qheaden> clokep_: What do you think of this approach? http://pastebin.instantbird.com/290697 Also, ignore the fact that I hardcoded "Contacts" as the name. I will localize it. 17:58:50 <qheaden> Which is why I made defaultTagName a get accessor. 18:00:27 <clokep_> qheaden: Seems reasonable-ish. flo might have more opinions. 18:01:27 <qheaden> clokep_: Is there any .properties file for services like this I can use? 18:01:32 <qheaden> For localizationl 18:03:47 <clokep_> qheaden: If not, create one. 18:03:57 <qheaden> Okay. 18:08:17 <clokep_> qheaden: Don't forget to change the usage of that in XMPP too. 18:08:30 <qheaden> clokep_: Yes, I will. 18:08:45 <clokep_> :) 18:08:49 <clokep_> I don't think IRC uses that so, we're good there. 18:15:02 <qheaden> clokep_: Looks like I'm going to have to create a new l10n file. Should I name it tags.properties? 18:17:49 * qheaden is liking the adding of *.pyc to the ignore file. 18:18:18 <-- gerv has quit (Ping timeout) 18:27:28 <qheaden> Ahh okay. We don't need a new localization file, we have this: http://lxr.instantbird.org/instantbird/source/instantbird/locales/en-US/chrome/instantbird/instantbird.properties#16 18:35:30 --> Suiseiseki has joined #instantbird 18:41:27 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2717 on bug 2105. 18:41:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 18:41:53 * qheaden wonders if he should have given the r? to flo on this one. 18:54:27 --> rosonline has joined #instantbird 18:57:24 --> chrisccoulson_ has joined #instantbird 18:57:30 <-- chrisccoulson has quit (Ping timeout) 18:59:20 --> nhnt11 has joined #instantbird 19:01:56 --> unghost has joined #instantbird 19:20:25 <instantbot> clokep@gmail.com denied review for attachment 2717 on bug 2105. 19:20:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 19:30:06 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2718 on bug 2105. 19:30:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 19:43:13 * qheaden wants to one day fix bug 376 19:43:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=376 enh, --, ---, nobody, NEW, Start with OS / on sign-on 19:45:11 --> mikk_s has joined #instantbird 19:48:07 <instantbot> New Core - General bug 2109 filed by qheaden@phaseshiftsoftware.com. 19:48:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2109 enh, --, ---, nobody, NEW, jsProtoHelper Should Provide Automatic Buddy Icon Caching 19:49:35 <-- mikk_s has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 19:55:31 <clokep_> qheaden: Someone is looking at fixing that for Thunderbird, I just CC'd myself, we shold be able to just copy their code after. 19:55:53 <qheaden> clokep_: Excellent. Do you know the bug number? 19:57:43 <clokep_> qheaden: https://bugzilla.mozilla.org/show_bug.cgi?id=899913 19:58:57 --> gerv has joined #instantbird 20:00:37 <qheaden> Cool, thanks. 20:07:02 <instantbot> clokep@gmail.com requested review from florian@instantbird.org for attachment 2718 on bug 2105. 20:07:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2105 min, --, ---, qheaden, ASSI, Tags Service Should Provide a Default Contact Group 20:10:08 <-- gerv has quit (Ping timeout) 20:13:35 <-- jb has quit (Ping timeout) 20:25:05 --> flo-retina has joined #instantbird 20:25:05 * ChanServ sets mode +qo flo-retina flo-retina 20:28:57 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:49:41 --> EionRobb has joined #instantbird 20:50:04 <-- nhnt11 has quit (Ping timeout) 20:51:49 --> jb has joined #instantbird 20:53:22 * flo-retina is busy assembling an IKEA sofa (Mook_as ;)) 20:53:36 <Mook_as> oooh! which one did you get? :D 20:54:01 <flo-retina> the one that was in parts in my garage since December! 20:54:29 <flo-retina> but otherwise, it's http://www.apartmenttherapy.com/manstad-sofa-bed-with-storage-45592 20:57:28 --> nhnt11 has joined #instantbird 21:02:35 <-- jb has quit (Ping timeout) 21:05:04 <qheaden> flo-retina: That's an awesome sofa! 21:05:22 <Mook_as> yep, that's way better than my ikea sofa 21:05:25 * qheaden gets flashbacks of his futon he used to love. 21:05:57 <flo-retina> qheaden: :) 21:06:18 <qheaden> Aww man. The nearest Ikea store to where I live is 153 miles away. :( 21:06:26 <flo-retina> Mook_as: and it's pretty cheap too. I got it second hand for ~ $200 21:07:21 <Mook_as> wow, that is nice. 21:09:11 <flo-retina> and today I got http://193.164.197.50/images/309/309313037793279.jpg 21:09:25 <flo-retina> ~ $40 21:09:49 * qheaden imagines that will be flo-retina's new patch reviewing chair. :P 21:10:03 <flo-retina> qheaden: that's quite possible 21:10:07 <qheaden> :) 21:10:13 <flo-retina> although I would need a table to hold the computer 21:10:13 <qheaden> r+'s for everyone! 21:10:34 <flo-retina> it was more intended to be a place to comfortably read offline ;) 21:10:38 <flo-retina> I don't really like reading in the bed 21:11:12 <qheaden> Me either. 21:11:14 <flo-retina> a nice char is the last piece of furniture I wanted for my bedroom 21:12:04 <flo-retina> *chair 21:12:05 <qheaden> flo-retina: So you have a home office right? 21:12:15 <flo-retina> in theory yes 21:12:25 * qheaden begins to wonder why we aren't talking in chatdev. :P 21:13:13 <flo-retina> right now it's the room upstairs where I dumped everything that was downstairs before the construction work started back in December, so it's pretty messy and unusable. It's the next room that needs furniture ;) 21:13:24 <flo-retina> qheaden: not sure why :-D 21:14:01 <flo-retina> qheaden: I typically work from a coworking space 21:14:16 * qheaden needs to move his work area outside of his bedroom. 21:15:05 <qheaden> For sleepiness reasons. ;) 21:24:13 --> Mic|web has joined #instantbird 21:24:16 --> jb has joined #instantbird 21:26:32 <Mic|web> clokep, qheaden: would it be possible to have a attribute "defaultTag" defined on the tag service interface and implement it using a getter? 21:27:37 <qheaden> Mic|web: That's possible. 21:27:45 <Mic|web> It's not like the other get* methods of the interface that need to take parameters. 21:28:12 <flo-retina> Mic|web: I wanted to suggest that too 21:28:56 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:28:57 <Mic|web> Oh, cool. Maybe I just should have waited then ;) 21:29:54 * qheaden needs to start using accessors more. 21:30:04 <qheaden> Once again, excuse my C++ frame of mind. :P 21:30:05 <instantbot> c++ is e-- ah, nevermind. 21:30:58 <qheaden> flo-retina: If you had a look at the patch, do you have any other suggestions? 21:31:15 <Mic|web> I need to go again, have a nice day! 21:31:37 <flo-retina> qheaden: another obvious comment is that some code in chat/ can't use a string defined in instantbird/ 21:32:17 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 21:34:19 <flo-retina> qheaden: that's purely bikeshedding, but I think I would move the 2 new lines in imITagsService to the top (before createTag) 21:34:49 <-- jb has quit (Ping timeout) 21:35:26 <flo-retina> qheaden: and "Get the default tag." for something called "getDefaultTag" is the kind of comments I hate (ie. comments that tell me nothing that I would not know if I just read the prototype without the comment, and so just waste my time when reading them) 21:35:51 <flo-retina> you could make it "Get the default tag (ie. "Contacts" for en-US)." to make it more useful 21:37:32 <flo-retina> qheaden: http://lxr.instantbird.org/instantbird/source/instantbird/content/addbuddy.js#34 also looks like it wants to be simplified 21:51:17 <-- qlum has quit (Client exited) 22:01:53 <-- unghost has quit (Input/output error) 22:07:57 <-- mconley has quit (Input/output error) 22:13:28 <qheaden> flo-retina: Okay, thanks for the comments. I'll work on the improvements later tonight. 22:13:36 <qheaden> As for now I have to go. :( 22:13:45 * qheaden is now known as qheaden_away 22:51:52 <-- chrisccoulson_ has quit (Quit: OSError: [Errno 130] Owner died) 22:51:58 --> chrisccoulson has joined #instantbird 23:01:06 --> mconley has joined #instantbird 23:02:44 <-- EionRobb has quit (Quit: Leaving.) 23:03:11 --> EionRobb has joined #instantbird 23:04:08 <-- dew has quit (Connection reset by peer) 23:19:13 <-- mconley has quit (Input/output error) 23:31:25 <instant-buildbot> build #1037 of win32-nightly-default is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1037 23:33:23 --> gerv has joined #instantbird 23:48:23 --> dew has joined #instantbird 23:54:55 --> mconley has joined #instantbird