All times are UTC.
00:11:27 --> nakp has joined #instantbird 00:11:36 <nakp> sorry :P was installing a new lamp 00:12:08 <nakp> and its still building 00:16:06 <-- nakp has quit (Quit: Saliendo) 00:17:16 --> nakp has joined #instantbird 00:18:21 <-- nakp has quit (Quit: Saliendo) 00:19:22 --> nakp has joined #instantbird 00:20:59 <nakp> chrisccoulson, is because the global menu is no longer mantained, firefox doesnt use libnotify anymore? 00:24:36 --> mconley_ has joined #instantbird 00:38:22 <-- wnayes has quit (Ping timeout) 00:39:28 --> wnayes has joined #instantbird 00:39:38 <-- wnayes has quit (Quit: wnayes) 00:52:26 <-- rosonline has quit (Ping timeout) 01:22:16 <nakp> clokep, could you believe its still building? -_- 01:22:25 <clokep> nakp: Yes. :) 01:22:31 <nakp> omg really??? 01:22:47 <clokep> If you have bad computer and didn't build it with multiple cores, sure. 01:22:59 <nakp> yeah :( 01:23:12 <nakp> will be like this everytime? 01:23:16 <clokep> No. 01:23:19 <clokep> Rebuilds will be < 1 minute. 01:23:27 <clokep> Except for when we update Mozilla, then you have to build from scratch. 01:23:34 <clokep> But that's at most once every six weeks. 01:23:52 <EionRobb> no pre-built environment you can use? 01:24:23 * clokep has no idea what that means. 01:24:36 <nakp> already built stuff from mozilla to build instantbird 01:24:39 <nakp> i think 01:25:01 <clokep> You might be able to build with the xulrunner distributable, but I don't know. 01:25:21 <nakp> at least testing and debugging? 01:25:32 <nakp> would be awesome xD 01:25:47 <clokep> If you're just changing JS files you can just unpack a nightly build. 01:26:04 <nakp> im building everything from scratch because I added.. 5 lines 01:26:06 <nakp> yes 01:26:30 <nakp> .-. 01:29:38 <nakp> I changed the components/ibCommandLineHandler.js 01:29:46 <clokep> Yes. 01:29:53 <clokep> You could have unpacked it and just modified it in place 01:29:54 <nakp> and I have the nightly 01:29:57 <clokep> I don't know how to do that though... 01:30:01 <clokep> Mic does it all the time. 01:30:06 <nakp> i cant find it xD 01:30:41 <nakp> where are the js files? 01:30:42 <clokep> It's inside of omni.ja, which is just a zipfile. 01:30:46 <nakp> ahh ok 01:33:26 <EionRobb> clokep: as in eg a zip file you can download that has all the deps precompiled so you don't have to wait for hours for everything to compile 01:33:45 <clokep> EionRobb: Mozilla doesn't even do that. 01:33:53 <EionRobb> so? 01:34:05 <clokep> We don't have the resources for that. 01:34:25 <EionRobb> how big is the source after it's been compiled? 01:34:52 <clokep> My objdir is ~4 GB. 01:34:55 <EionRobb> your buildbot server thingee does it, just needs to zip up the output 01:34:58 <EionRobb> that's insane 01:36:13 <clokep> Insanely....big? :P 01:38:07 <EionRobb> yeah 01:38:37 <clokep> Sorry? :P 01:39:06 <EionRobb> apology accepted. just don't do it again :) 01:41:38 <nakp> lol 01:52:45 <nakp> clokep, is that the only file I need to change? 01:53:10 <nakp> do i have to register anywhere else? 01:53:13 <nakp> it^ 01:53:49 <clokep> nakp: No, but when you start instantbird, call it with the -purgecaches flag. 01:54:15 * clokep isn't sure exactly what it does, but always uses that when developing. :) 01:54:29 <nakp> lol 01:54:51 <clokep> I think it's usually for XUL files? 01:55:19 <nakp> seems like 01:55:50 <nakp> hmmm i just added the accounts flag, almost a copy of preferences flag 01:56:10 <nakp> hmm a sec 01:57:25 * qheaden_away is now known as qheaden 01:57:35 <qheaden> clokep: Hey there! You're back? 01:58:04 * qheaden notices the flood of bugmail he got. 01:58:33 <clokep> qheaden: Yes. For a few days. I'm on vacation the end of this week. 01:58:52 <qheaden> Okay. 01:59:14 <qheaden> clokep: This week, along with bug fixing, I'm going to start improving jsProtoHelper. 02:00:12 <clokep> qheaden: Excellent! I hope my review comments all make sense. 02:00:33 <qheaden> clokep: I was out most of today, so i didn't get a chance to really read them much, but I'm sure they do. 02:00:44 <qheaden> Anything that is cloudy to me, I'll ask questions. ;) 02:01:20 <nakp> clokep, all i did was adding an if cmdLine.handleFlag 02:01:22 <clokep> Sure thing. 02:01:29 <clokep> nakp: OK. 02:01:36 <nakp> but didnt work -_- 02:01:58 <clokep> Define "didn't work" 02:02:24 <clokep> Were there errors or something in the error onsole? 02:02:48 <nakp> ok i copied the preferences handleFlag and changed to "accounts" 02:02:49 <nakp> http://lxr.instantbird.org/instantbird/source/instantbird/components/ibCommandLineHandler.js#14 02:02:54 <nakp> nope, nothing at all 02:03:04 <nakp> didnt even show preferences with -accounts 02:04:04 <nakp> i was about to change it for Core.showAccounts() :) 02:04:43 <nakp> http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#155 02:05:30 <clokep> nakp: Showing diffs is usually useful. :) 02:05:42 <clokep> You most likely repacked something wrong then? :_/ 02:06:37 <nakp> http://hastebin.com/gofiliwece.avrasm 02:07:29 <nakp> i dont think so, I moved away the omni.ja to avoid conflicts 02:07:50 <nakp> is there any "special" way to repack it? 02:24:59 <clokep> nakp: Just zip it back up. 02:25:27 <clokep> nakp: Those changes look reasonable, yes. 02:26:51 <clokep> Bed time for me though. :) Goodnight. 02:27:00 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:29:45 * qheaden is now known as qheaden_away 03:11:59 <instant-buildbot> build #938 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/938 03:34:13 <instant-buildbot> build #939 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/939 03:39:26 <-- mconley_ has quit (Input/output error) 03:42:45 --> mconley_ has joined #instantbird 04:05:42 <-- mconley_ has quit (Input/output error) 04:36:10 --> mconley_ has joined #instantbird 04:42:06 <-- mconley_ has quit (Ping timeout) 04:49:25 <-- EionRobb has quit (Quit: Leaving.) 06:00:34 <-- nakp has quit (Quit: Saliendo) 06:13:47 <instant-buildbot> build #1034 of win32-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1034 06:13:48 <-- instant-buildbot has quit (Quit: buildmaster reconfigured: bot disconnecting) 07:14:47 --> EionRobb has joined #instantbird 08:18:28 --> instant-buildbot has joined #instantbird 08:18:28 * ChanServ sets mode +v instant-buildbot 09:03:35 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:07:43 <gerv> Hi guys. 09:07:51 <gerv> Are the timestamps on the IRC logs on log.bezut.info in UTC? 09:20:08 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 09:21:39 --> chrisccoulson has joined #instantbird 09:23:22 <-- chrisccoulson has quit (Ping timeout) 09:24:43 --> Mic has joined #instantbird 09:24:43 * ChanServ sets mode +h Mic 09:25:29 <Mic> Gerv: yes 09:25:34 <gerv> OK, thanks. 09:26:41 <Mic> Anything else I can help you with? I'd need to go again otherwise.. 09:29:46 <Mic> Bye! 09:29:57 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 09:30:24 <gerv> Mic: wait, come back! 09:30:28 <gerv> :-( 09:34:24 --> flo-retina has joined #instantbird 09:34:25 * ChanServ sets mode +qo flo-retina flo-retina 09:39:08 --> chrisccoulson has joined #instantbird 09:54:45 --> Mic has joined #instantbird 09:54:45 * ChanServ sets mode +h Mic 09:54:59 <Mic> Gerv: ping 09:55:05 <gerv> Pong. 09:55:06 <Mic> Is it something e.g. flo could help you with? 09:55:15 <gerv> I'm online with flo now :-) 09:55:17 <Mic> I'm in a hurry ;) 09:55:21 <gerv> No problem. 09:55:33 <gerv> I'm sure flo can sort it out. 09:55:35 <Mic> OK, good. Just wanted to check if it's important or urgent :) 09:55:55 <Mic> Then I'm off again... 09:56:19 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:16:34 --> clokep has joined #instantbird 10:16:34 * ChanServ sets mode +o clokep 10:37:59 * qheaden_away is now known as qheaden 10:38:08 <qheaden> Hello everyone. 10:47:45 <qheaden> clokep: You mention the add buddy dialog in your feedback for bug 2088, but does that show when you authorize a buddy? 10:47:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 10:49:24 <clokep> qheaden: No, I think that whole UX sucks too much. 10:49:33 <clokep> I think I misunderstood what was happening. 10:49:40 <clokep> Regardless, "Friends" probably needs to be localized. 10:50:02 <qheaden> Okay. Yeah, that whole patch only applies to when someone wants to be *your* buddy. 10:50:20 <clokep> This is why I want more lines of context. ;) 10:51:14 <qheaden> Does hg export allow you to specify the amount of context lines? 10:51:52 * flo-retina wonders what a localizable Friend is 10:51:58 <clokep> qheaden: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F 10:52:15 <qheaden> Ahh okay. 10:54:18 <clokep> The showfunc is important too. 10:54:24 <flo-retina> uh, who broke my log viewer? 10:54:34 * clokep hides. 10:57:02 * flo-retina files a bug 10:59:16 <-- EionRobb has quit (Quit: Leaving.) 11:00:35 <instantbot> New Instantbird (UI) bug 2100 filed by email@example.com. 11:00:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2100 nor, --, ---, nobody, NEW, Displaying the logs of a different conversation in an existing log viewer window is broken 11:01:01 <flo-retina> now that I've seen that resizing fixes it, I suspect the moz22 update 11:05:32 <flo-retina> random (maybe not so good) idea for nhnt11: give existing conversation tabs a low rank, but give them a high rank if the conversation has unread messages 11:11:55 <qheaden> clokep: The first line 86 characters. Should I split it? http://pastebin.instantbird.com/286651 11:13:43 <-- clokep has quit (Ping timeout) 11:16:50 <qheaden> flo-retina: Should we worry about splitting that ^ 11:25:17 <instantbot> firstname.lastname@example.org requested review from email@example.com for attachment 2693 on bug 2088. 11:25:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 11:37:52 --> dionisos has joined #instantbird 12:02:09 --> clokep_ has joined #instantbird 12:19:55 <flo-retina> qheaden: you don't really need to "worry" about it, but it's easy as http://pastebin.instantbird.com/286736 12:21:31 <flo-retina> qheaden: how would you feel if I asked you to unify http://lxr.instantbird.org/instantbird/search?string=defaultGroup by adding Services.tags.defaultGroup ? 12:21:36 <flo-retina> maybe for another bug though 12:23:15 <qheaden> flo-retina: I didn't realize defaultGroup is used so much. That could definitely be an improvement. 12:26:44 <clokep_> qheaden: flo-retina That bug is really simple, you can probably just do it in there. 12:28:55 <flo-retina> clokep_: I would prefer a separate bug because that change touches UI and JS-XMPP too. 12:29:56 <clokep_> flo-retina: Ah, I didn't realize that didn't already exist. :) 12:29:59 * clokep_ should have read the patch first. 12:31:58 <instantbot> firstname.lastname@example.org denied review for attachment 2693 on bug 2088. 12:32:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 12:34:42 <qheaden> clokep_: I'm about to submit a fix patch for bug 2088, and I'm going to use the line-splitting flo-retina showed here http://pastebin.instantbird.com/286736. 12:34:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 12:35:14 * qheaden doesn't like making too many exceptions to the 80-character rule. 12:35:24 <clokep_> qheaden: OK. 12:35:28 <clokep_> Fix the comment too? :P 12:35:44 <qheaden> clokep_: Did that. ;) 12:37:54 <clokep_> :) 12:39:57 <instantbot> email@example.com requested review from firstname.lastname@example.org for attachment 2694 on bug 2088. 12:39:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 12:43:09 <qheaden> clokep_: I think the first improvement that could be made to jsProtoHelper is adding universal support for "Typing" notifications. 12:45:08 <clokep_> qheaden: Isn't that already handled? 12:46:01 <flo-retina> universal? 12:47:09 <qheaden> Aren't typing notifications (timers and such) handled by each proto individually? 12:47:59 <clokep_> No... 12:49:41 <qheaden> Hmm. It looks like only JS-XMPP and JS-Yahoo only use typing timers. 12:53:40 <flo-retina> qheaden: there are 2 ways to handle typing notifications at the protocol level: either sending a 'typing' message every few seconds, or sending a 'stop typing' message after the user has stopped typing, and assuming he's still typing if that message hasn't been received 13:04:16 <clokep_> qheaden: "this method will + // do nothing since the buddy will already be in our list. + let tag = Services.tags.createTag(_("buddy.auth.defaultGroup")); + this._account.addBuddy(tag, this.userName);" 13:04:22 <clokep_> Will that really do nothing? Won't it create that tag? 13:04:28 <clokep_> Or add that tag to that buddy if they already exist? 13:22:18 <qheaden> clokep_: Well, it will create the tag, but addBuddy immediately returns if the buddy exists, so it does nothing. 13:23:52 <instantbot> email@example.com denied review for attachment 2682 on bug 2066. 13:24:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should suggest chat rooms 13:24:02 <clokep_> qheaden: But we probably don't want to create the tag at all in that situation, do we? 13:24:23 <qheaden> clokep_: No. So perhaps I will move tag creation into addBuddy itself. 13:25:00 * qheaden wonders why he didn't place it there in the first place. 13:26:13 <clokep_> qheaden: Do you want me to r- it with a comment so you remember or 13:26:55 <qheaden> clokep_: I'll remember, but I think you should r- to clarify our discussion to other viewers of the bug. 13:27:16 <instantbot> firstname.lastname@example.org denied review for attachment 2694 on bug 2088. 13:27:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 13:34:38 <clokep_> :) 13:43:06 --> mconley_ has joined #instantbird 13:55:49 <qheaden> clokep_: How do these changes look? http://pastebin.instantbird.com/286858 13:58:08 <clokep_> qheaden: Is addBuddy really only called in one place? 13:58:13 <clokep_> Is that not part of the interface? 13:59:08 <qheaden> Oh wow! I completely forgot it was part of the interface. :-S 14:00:06 <qheaden> clokep_: So addBuddy expects a tag object then. 14:02:50 <qheaden> How about we perform the "buddy already exists" check outside of addBuddy? Perhaps we can create a hasBuddy method on YahooAccount. 14:09:11 <flo-retina> can addBuddy take a null tag parameter? 14:11:00 <-- flo-retina has quit (Input/output error) 14:16:03 --> flo-retina has joined #instantbird 14:16:04 * ChanServ sets mode +qo flo-retina flo-retina 14:20:49 <qheaden> flo-retina: Not sure if it can take a null tag. 14:36:35 <-- flo-retina has quit (Input/output error) 14:36:42 <qheaden> clokep_: This seems a bit cleaner. http://pastebin.instantbird.com/286940 14:37:07 --> flo-retina has joined #instantbird 14:37:08 * ChanServ sets mode +qo flo-retina flo-retina 14:37:55 <qheaden> Because addBuddy is an interface-defined method called within Instantbird. We are calling it from the authorization code for reusability. So we should perform the check outside of the method. 14:53:24 <flo-retina> qheaden: I guess my question is, why can't we just null check aTag at http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#107 and replace it with the default tag? 14:53:49 <flo-retina> but it's possible that question doesn't fully make sense :) 14:53:56 <flo-retina> as I don't remember that code well 14:54:43 <qheaden> flo-retina: That's a good suggestion, but I'm not sure if it applies to our issue. We are trying to determine when we should create the needed tag. 14:55:27 <qheaden> If a buddy already exists, the code exits to prevent errors, but it still ends up creating a tag. So clokep_ is saying that if a buddy wasn't created, his tag shouldn't be created either, which I agree with. 15:00:39 --> wnayes has joined #instantbird 15:01:12 <qheaden> I'll be back in a few hours, have somewhere to go. 15:01:15 * qheaden is now known as qheaden_away 15:15:33 * mconley_ is now known as mconley 15:15:44 <clokep_> qheaden_away: That probably is fine, but your calling the wrong method. It should be hasBuddy. 15:25:37 <-- wnayes has quit (Ping timeout) 15:29:56 --> wnayes has joined #instantbird 16:06:13 <flo-retina> Firefox's findbar seems to have changed significantly and now be at the top instead of at the bottom 16:10:14 --> Nakp has joined #instantbird 16:11:11 <-- Nakp has quit (Quit: retirada!) 16:33:20 --> Mook_as has joined #instantbird 17:01:35 --> qlum has joined #instantbird 17:04:43 <clokep_> flo-retina: Yes, I thought I pointed this out beforE? :) 17:09:08 <flo-retina> maybe? I didn't read IRC logs of when I wasn't around. 17:10:16 <clokep_> Ah, maybe you had gone alrady. 17:10:20 <clokep_> Yes, they added it to nightly a while ago. 17:10:22 <clokep_> It's OK. :) 17:15:39 <flo-retina> I find it quite interesting 17:15:53 <flo-retina> and history is now in a left sidebar by default apparently when pressing command+shift+H 17:16:14 <flo-retina> so we could likely have both the findbar at the top and the left sidebar, and just use that as the UI for searching indexed logs 17:17:27 * qheaden_away is now known as qheaden 17:17:38 <qheaden> Okay, I'm back. 17:30:08 <-- mconley has quit (Connection reset by peer) 17:30:58 --> mconley has joined #instantbird 17:33:09 <instantbot> email@example.com requested review from firstname.lastname@example.org for attachment 2695 on bug 2088. 17:33:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 17:33:27 <-- mconley has quit (Connection reset by peer) 17:33:35 --> mconley_ has joined #instantbird 17:36:37 * qheaden wonders what's the purpose of Mozilla creating the Rust language. 17:38:05 <instantbot> New Instantbird (UI) bug 2101 filed by email@example.com. 17:38:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2101 blo, --, ---, nobody, UNCO, Crashes on startup - portable and installed versions 17:54:25 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:58:43 * mconley_ is now known as mconley 18:07:59 --> Mic has joined #instantbird 18:07:59 * ChanServ sets mode +h Mic 18:08:40 <Mic> flo-retina: regarding http://log.bezut.info/instantbird/today#m254: is that any different from what Ctrl+H does/did already? 18:09:21 <Mic> I don't run nightlies but I've often used the history in a sidebar (I believe it has "always" been there;) 18:10:05 <Mic> Ctrl+Shift+H opens a separate window though. 18:10:07 <clokep_> Yeah, Ctrl+H has always been history in a sidebar. 18:12:47 --> unghost has joined #instantbird 18:14:00 <qheaden> clokep_: What do you think should be my first jsProtoHelper improvement? 18:16:44 --> flo-retina has joined #instantbird 18:16:44 * ChanServ sets mode +qo flo-retina flo-retina 18:18:29 <clokep_> qheaden: Maybe the auth requests? 18:18:51 <qheaden> Also, do you think we should create another "post-landing" Etherpad for the extra stuff we need to work on. Since most of the tasks on the old Etherpad are complete, a new one would be cleaner. 18:21:13 <Mic> qheaden: you can clear everything from the etherpad and still have it in the timeline/history of it. 18:22:59 <clokep_> qheaden: I'm pretty confident that "most of the old etherpad is complete" is an overstatement. 18:24:34 <qheaden> clokep_: When I say most is completed, I mean that there are mostly strikethroughts throughout the pad, making it hard to read at times. 18:25:20 <qheaden> Can we just removed the things we determined to be "done"? 18:25:23 <qheaden> *remove 18:28:43 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 18:49:48 <clokep_> qheaden: Or you can reorganize it so things not done are on top. 18:50:16 <clokep_> qheaden: Btw what is "Server pings" on that list? that sounds important 18:51:19 <qheaden> clokep_: I think the server listens for client pings to ensure it is still alive. But I've also read that it determines it being alive by the TCP connection staying open. 18:52:49 <instantbot> firstname.lastname@example.org granted review for attachment 2695 on bug 2088. 18:52:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2088 maj, --, ---, qheaden, ASSI, New contact does not get added to the correct tag 18:52:52 <clokep_> qheaden: Usually you send pings to keep the TCP connection open. 18:54:49 <qheaden> clokep_: In the Etherpad, should we remove options determined to be obsolete? Like public chat room options? 18:55:32 <clokep_> I'd prefer you don't. 18:55:40 * clokep_ wants that to be a list of everything. 19:01:02 <qheaden> Okay, the list is a bit cleaner now. 19:04:10 * qheaden now has a better sense of direction. 19:04:51 <qheaden> Let me look into server pings. 19:08:37 <instantbot> New Core - Yahoo! Messenger bug 2102 filed by email@example.com. 19:08:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2102 nor, --, ---, nobody, NEW, Support Server Pings 19:09:09 <-- Suiseiseki has quit (Ping timeout) 19:12:45 --> Suiseiseki has joined #instantbird 19:28:46 <-- wnayes has quit (Quit: wnayes) 19:29:50 --> nhnt11 has joined #instantbird 19:31:23 * nhnt11 will have to get used to the new location of Firefox's findbar ;) 19:31:25 <-- gerv has quit (Ping timeout) 19:31:45 --> gerv has joined #instantbird 19:32:44 --> nhnt12 has joined #instantbird 19:33:37 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt12)) 19:33:39 * nhnt12 is now known as nhnt11 19:34:43 <nhnt11> flo-retina: This is an interesting idea. Why "maybe not so good"? http://log.bezut.info/instantbird/today/#m165 19:36:19 <flo-retina> nhnt11: because I'm not sure encouraging people top press Command+T <enter> to find the newest unread message is a great thing 19:36:22 * nhnt11 thought about it for more than 10 seconds and decides the "maybe not so good" can stay :P 19:36:38 <flo-retina> maybe we should just add an other keyboard shortcut to focus the tab that received an unread message the most recently 19:36:40 <nhnt11> Yeah it doesn't sound very compliant with the main goal of awesometab. 19:36:47 <nhnt11> Interesting. 19:37:11 <flo-retina> ie. "show me the reason why I just heard some sound" 19:37:45 <nhnt11> Don't we have notifications for that? 19:38:13 <flo-retina> don't they suck? 19:38:42 <nhnt11> Do they? I've never had a problem with them. 19:38:56 <flo-retina> they are off for me so I assume there was a problem with them 19:39:03 <flo-retina> I don't really know why they are off though 19:39:21 <nhnt11> Before the moz22 update they required Growl to be installed (on Mac) afaik. 19:39:28 * flo-retina turns that on again to figure it out 19:39:40 <nhnt11> I noticed that because I don't have Growl on my new Macbook and notifications suddenly started showing up in the new nightlies ;) 19:41:09 * clokep_ thought you were talking about the sounds. 19:41:12 <clokep_> Which are on by default 19:41:29 <nhnt11> Uh, I was talking about the popups. sorry for not being clear about that. 19:43:06 * nhnt11 wants to work on followups tonight 19:47:30 <qheaden> The new location for findbar just came out in the release Firefox channel? 19:47:43 * qheaden has been using Firefox Nightly for a little while. 19:48:06 <nhnt11> I'm not on the release channel :S 19:48:15 <nhnt11> I was on the beta channel till a couple of days ago when I switched to UX 19:48:23 <qheaden> Ahh. 19:48:39 <nhnt11> Maybe UX had it all along and I didn't notice ;) But I do use findbar a lot... 19:48:50 <clokep_> I think it just got to beta, yes. 19:49:53 <nhnt11> flo-retina: What do you think about me taking an hour tonight to get retina tab images working on Ib? :) 19:50:08 <flo-retina> <3 19:51:37 * qheaden is conflicted on what to work on next. :-S 19:51:47 * nhnt11 takes that as a yes :P 19:52:26 <flo-retina> nhnt11: if that hour finishes before I got to bed, we will have great looking tabs tomorrow ;) 19:52:32 <clokep_> qheaden: That sounds like a waste of time. 19:52:34 <clokep_> What's confusing you? 19:52:43 * clokep_ feels like you haven't been focused and that it's his fault. 19:52:44 * nhnt11 gets started 19:53:23 <qheaden> clokep_: No, it isn't your fault. I've got some elusive bugs to work on, but also some more features to implement. 19:53:41 <qheaden> Actually, I need to keep working with buddy icon stuff. I'm not finished with that. 19:54:25 <clokep_> Right, I think I gave you comments on a whole bunch of bugs. 19:54:29 <clokep_> + there are new features to do too. 19:54:54 <qheaden> Yeah. 19:55:52 <clokep_> I'd suggest trying to get another set of stuff up for review first. :) 19:56:01 <qheaden> My resizing code for buddy icons is wrong. When looking at my icon, it looks distorted. 19:56:45 <flo-retina> isn't there xmpp code doing that already? 19:56:52 <flo-retina> (that could be abstracted) 19:57:10 <qheaden> flo-retina: Yes, I borrowed my code from JS-XMPP. 19:57:58 <qheaden> clokep_: Also, libpurple seems to hard code the expiration time of the icon to 7 days. I'm not sure why. There are no comments on it. 19:58:08 <qheaden> Perhaps that is the max time? 19:58:23 <clokep_> qheaden: Maybe, try sniffing the protocol? Or seeing when that was added in the history? 19:58:33 <clokep_> And, yes. That should definitely be abstracted. 19:58:37 <clokep_> (That would be a nice place to start...) 19:59:39 <clokep_> flo-retina: crash-stats.instantbird.org is giving me Fatal error: Call to undefined function curl_init() in /www/instantbird/socorro/src/webapp-php/application/libraries/Web_Service.php on line 104 19:59:41 <clokep_> Even: ^ 20:05:21 <qheaden> flo-retina: When it comes to setting a buddy icon, there isn't a whole lot that can be abstracted between JS-XMPP and JS-Yahoo. XMPP uses the XML approach, but Yahoo uses the binary/HTTP request approach. 20:05:42 <qheaden> The only thing that is the same is how the icon files are loaded. I'm not sure if that is enough code to abstract. 20:05:50 <flo-retina> qheaden: I was thinking about the code to get the icon from the profile and resize it 20:06:09 <qheaden> Oh 20:06:24 * nhnt11 is done with retina tabs 20:06:56 <nhnt11> Er, I mean I have them working, not necessarily "done" 20:07:18 <nhnt11> http://puu.sh/40oKO.png :) 20:07:35 <nhnt11> Now the close button 20:08:47 <clokep_> qheaden: Yes, I want that stuff abstracted (the resizing, getting the icon, etc.). 20:09:27 <qheaden> clokep_: Should the abstraction be included in bug 2070? 20:09:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, ASSI, Add Support for Buddy Icons 20:09:47 <clokep_> qheaden: And I want http://lxr.instantbird.org/instantbird/source/chat/protocols/yahoo/yahoo-session.jsm#842 to be abstracted. 20:09:51 <clokep_> qheaden: You could do it all at once, yes. 20:10:02 <clokep_> If it's a separate patch it should be a separate bug. 20:10:10 <qheaden> Okay. 20:10:21 <qheaden> I'll work on those two right now. 20:10:31 <qheaden> And the rest of the icon code. 20:24:07 <-- mconley has quit (Ping timeout) 20:25:36 --> mconley has joined #instantbird 20:29:04 --> FireFly_TB has joined #instantbird 20:30:06 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:31:33 <clokep_> Sounds like a plan! 20:34:00 --> nhnt11 has joined #instantbird 20:34:07 <-- mconley has quit (Ping timeout) 20:34:41 --> mconley has joined #instantbird 20:36:35 <qheaden> Okay, so it looks like all icons are always resized to a 96px width, but the height depends on the aspect ratio of the original picture. 20:36:47 <qheaden> So height = width / aspect_ratio 20:38:17 --> EionRobb has joined #instantbird 20:39:54 * qheaden hates when unrelated patches in his patch queue become dependent on one another because of nearby code changes. 20:46:16 <-- Mook_as has quit (Quit: Mook_as) 20:47:34 <flo-retina> nhnt11: don't forget the left/right arrow and the all tabs button that are visible in case of overflow ;) 20:47:40 <nhnt11> I'm doing that now 20:48:38 <nhnt11> I was having a bit of trouble with it 20:48:47 <nhnt11> but I think I know what's happening now 20:48:52 <nhnt11> The image sizes are different 20:49:16 <flo-retina> are there rules in Firefox to fix the size? 20:49:23 <nhnt11> The -moz-image-region dimensions are different in Fx 20:49:29 <nhnt11> For both retina and non-retina icons 20:49:36 <nhnt11> I'm investigating right now 20:50:02 <-- dionisos has quit (Ping timeout) 20:51:19 <nhnt11> flo-retina: How much time do I have before you go to bed? :P 20:51:30 <flo-retina> at least one hour 20:51:38 <nhnt11> Cool. 20:52:05 <flo-retina> I'm trying to understand https://bugzilla.mozilla.org/show_bug.cgi?id=904126 20:55:43 <nhnt11> flo-retina: Ok, using the firefox dimensions fixes the issues I was having. I'm going to go ahead and update the non-retina dimensions too (if needed - checking now) 20:56:51 <flo-retina> if you can plug an external monitor, that's useful to compare retina/non-retina 20:57:00 <flo-retina> (you can just drag the window around to see both versions) 20:57:02 <nhnt11> I don't have one :( 20:57:32 <nhnt11> flo-retina: The dimensions are fine for the non-retina icons, because the icon files themselves are old. 20:57:50 <-- FireFly_TB has quit (Ping timeout) 20:58:12 <nhnt11> I mean, the latest images in Firefox seem to have different dimensions 20:58:17 <nhnt11> than the ones we're using 20:58:23 <nhnt11> Should I update them or leave them as is? 21:01:59 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 Ð¸Ð»Ð¸ ÑÑÐ°ÑÑÐµ)) 21:03:00 <nhnt11> flo-retina: Firefox has separate icons for lion and above, and pre-lion. We support 10.6 right? 21:03:15 <nhnt11> (In which case I will have to add the rules for lion and pre-lion too) 21:03:34 * nhnt11 scolds himself for being lazy and looks it up 21:04:22 <nhnt11> So we do support 10.6. Alright. 21:05:44 <flo-retina> yes we support 10.6 21:06:00 <flo-retina> although I'm not sure we have anybody around with a machine to test it 21:24:28 <-- mconley has quit (Input/output error) 21:26:19 <qheaden> clokep_: Also, when setting the icon, I'm not sure about the User-Agent string. I just used Mozilla/5.0 because that's what libpurple had hardcoded, but I'm sure it doesn't matter. Should I change the User-Agent to reflect the current Mozilla platform Ib is running? 21:27:11 <qheaden> TBH, I just did some copy-pasting with the icon setting code, since I can't seem to find any docs on it. 21:27:15 --> rosonline has joined #instantbird 21:31:17 --> dionisos has joined #instantbird 21:33:58 * nhnt11 is uploading a patch 21:38:17 <instantbot> New Instantbird (UI) bug 2103 filed by firstname.lastname@example.org. 21:38:18 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 2696 on bug 2103. 21:38:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2103 nor, --, ---, nobody, NEW, Update tabbrowser images for retina displays 21:54:57 <nhnt11> flo-retina: I fixed the awkward border here - http://puu.sh/40udF.png - with this: http://pastebin.instantbird.com/287462 21:55:02 <nhnt11> Does that change look ok? 21:55:41 <nhnt11> I couldn't figure out what "brokenness of the native theming caused by the tab bar not being a toolbar" was referring to. 21:59:43 <flo-retina> if it looks good it's probably ok :-D 22:00:21 <nhnt11> Heh then I will qrefresh and upload a new patch including that. 22:06:20 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 2696 on bug 2103. 22:06:21 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 2698 on bug 2103. 22:06:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2103 nor, --, ---, nobody, NEW, Update tabbrowser images for retina displays 22:08:24 --> clokep has joined #instantbird 22:08:24 * ChanServ sets mode +o clokep 22:09:48 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:12:07 --> nhnt11 has joined #instantbird 22:12:07 <clokep> qheaden: You can just hard code it for now, was just curious. :) 22:16:43 <qheaden> clokep: Should I update the version though? 22:17:05 <clokep> qheaden: Either leave it as it is or get the real user agent 22:18:09 <-- qlum has quit (Client exited) 22:19:06 --> Mook_as has joined #instantbird 22:32:02 <qheaden> clokep: How can I obtain the real user agent? 22:32:26 <clokep> qheaden: I don't know. :p 22:32:30 <clokep> I'd say don't worry about it for now. 22:32:31 <qheaden> :P 22:32:33 <clokep> I was just asking why we do it. 22:32:36 <clokep> Not saying you have to change it. 22:32:42 <qheaden> Okay. 22:32:49 * qheaden looks at MXR out of curiosity. 22:33:14 <clokep> My guess is you just load the pref. 22:33:26 <Mook_as> are you JS or C++? 22:33:40 <clokep> JS 22:33:57 <Mook_as> do you have a | navigator.userAgent | ? :D 22:34:26 <qheaden> Well, it looks like the latest (Nightly) Firefox still uses Mozilla/5.0 anyway. 22:34:29 <qheaden> I'll just leave it. 22:34:39 <Mook_as> otherwise you can always go the long way for Services.io.getProtocolHandler("http").QueryInterface(Components.interfaces.nsIHttpProtocolHandler).userAgent 22:35:08 <Mook_as> and yes, the Mozilla/5.0 prefix is hard coded. 22:35:47 <qheaden> Mook_as: Ahh okay. Well, for our purposes, that's kinda overkill. :P 22:35:52 <qheaden> I'll leave it for now. 22:36:26 <Mook_as> and now you know! (and know that doing it is silly) 22:36:49 <clokep> :) 22:40:25 <-- chrisccoulson has quit (Ping timeout) 22:44:53 <nhnt11> clokep: Do you think room info callbacks should keep receiving room info after they've already gotten the whole list? 22:45:23 <nhnt11> Consumers are expected to call requestRoomInfo with a callback, and they will receive the list of available rooms /once/ 22:45:31 <clokep> nhnt11: I don't really understand that API, so I don't want to answer a question about a specific part of it. 22:46:20 <nhnt11> Er, I meant, is that it looked like when you read the code? 22:46:51 <nhnt11> I'm trying to figure out how best to answer "can you give a text description of what consumers are expected to do?" 22:48:00 <clokep> nhnt11: I want you to explain the API to me in a list of steps about what happens. 22:51:26 <nhnt11> 1) Consumer calls requestRoomInfo(...) on the prplAccount. 22:51:26 <nhnt11> 2) a) If chat rooms are already cached, the account returns them through the callback provided in requestRoomInfo. 22:51:26 <nhnt11> b) If not, the account initiates a server request (LIST in case of IRC). It passes rooms to the callback in batches as room info is received from the server. 22:51:26 <nhnt11> That's pretty much it. The callback can do what it wants with the room info that it receives. 22:51:36 <flo-retina> I think I'm done poking at https://bugzilla.mozilla.org/show_bug.cgi?id=904126 for tonight :) 22:51:39 <clokep> nhnt11: I want it in the bug... 22:51:42 <nhnt11> Ok. 22:51:45 <clokep> I'm not really reading IRC right now. 22:51:56 <nhnt11> Sure. 22:52:00 <flo-retina> time to look at these tabs :) 22:56:57 <flo-retina> nhnt11: tabDragIndicator@2x.png's got no love from you? 22:57:21 <nhnt11> Seems like I missed it 22:58:07 <nhnt11> I don't see tabDragIndicator@2x.png in mozilla/browser/themes/osx/tabbrowser 22:58:29 * nhnt11 searches elsewhere 22:58:33 <nhnt11> (mxr) 22:58:54 <flo-retina> nhnt11: shouldn't that % override line at the end be inside an ifdef? 22:59:14 <flo-retina> nhnt11: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/jar.mn#210 22:59:29 <nhnt11> Ah 22:59:40 <nhnt11> The jar.mn in browser/ is osx specific 22:59:42 <nhnt11> ok 22:59:47 <flo-retina> http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/tabbrowser/tabDragIndicator@2x.png 23:00:55 <nhnt11> flo-retina: I don't see it in instantbird/mozilla/ :S 23:00:58 <nhnt11> but thanks. 23:01:12 <flo-retina> don't see what? 23:01:17 <clokep> nhnt11: So what does callback get removed or what? 23:01:24 <flo-retina> it's possible it wasn't in mozilla22 yet 23:01:35 <nhnt11> Right. 23:01:47 <flo-retina> nhnt11: your indent is wrong on the second part of 3 lines in jar.mn 23:01:51 <nhnt11> clokep: The callback gets removed after all rooms have been passed to it 23:02:23 <flo-retina> err, 4, and maybe even 6 23:02:35 <clokep> Hm, OK. 23:02:59 <-- dew has quit (Ping timeout) 23:06:23 --> dew has joined #instantbird 23:07:18 <nhnt11> The indenting in jar.mn is confusing :( 23:07:35 <flo-retina> it's usually "best effort" in there 23:07:43 <flo-retina> and just "don't make it worse" ;) 23:08:21 <Mook_as> flo-retina: your comment in bug 904126 says you filed bug 904126 for the real issue? 23:08:34 <flo-retina> arg 23:08:40 <Mook_as> oh, I see a bug 904263 from the dep list 23:09:09 <nhnt11> flo-retina: Is it ok if I change the indenting on a couple of already-existing lines to make it look prettier? 23:09:23 <flo-retina> Mook_as: thanks 23:09:50 <flo-retina> nhnt11: I would say don't do it (you would be exposing yourself to more bikeshedding ;)) 23:10:00 <nhnt11> ok 23:10:08 --> wnayes has joined #instantbird 23:10:19 <Mook_as> np 23:10:27 <-- dionisos has quit (Ping timeout) 23:11:29 <nhnt11> flo-retina: http://pastebin.instantbird.com/287569 23:11:56 <nhnt11> Is that alright? Lines 1 and 3 aren't showing up properly in the pastebin, those are tabs. And those are already-existing lines ;) 23:12:29 <flo-retina> I was going to say that I think pastebin butchers tabs 23:13:13 <nhnt11> Here's what it looks like in Komodo: http://puu.sh/40xTL.png 23:13:16 <qheaden> clokep: What did you mean by this comment? http://pastebin.instantbird.com/287570 23:13:34 <qheaden> clokep: Did you mean the wording of the comment should be changed, or the way the line is formatted? 23:13:37 <clokep> qheaden: The first line should attempt to go out to 80 characters. 23:13:43 <qheaden> Ahh okay. 23:13:49 <clokep> qheaden: I mean the formatting, hence my usage of the word "reformatted" ;) 23:13:56 <qheaden> :) 23:14:37 <flo-retina> nhnt11: assuming things aren't how they look; it should be ok :-P 23:14:56 <qheaden> clokep: Also, is this alphabetized correctly? 23:15:11 <clokep> qheaden: What? 23:15:15 <qheaden> I wasn't sure how to handle the //gre, since it has one less forward slash. 23:15:18 <flo-retina> nhnt11: looks like komodo is as messed up as pastebin 23:15:25 <flo-retina> nhnt11: a tab is 8 spaces 23:15:27 <nhnt11> Yeah it's.. weird 23:15:36 <qheaden> clokep: Oh, link: http://pastebin.instantbird.com/287571 23:15:37 <qheaden> :P 23:15:39 <nhnt11> Komodo isn't translating tabs to a fixed number of spaces 23:15:49 <flo-retina> that's the expected behavior 23:16:13 <flo-retina> but just look at https://bugzilla.instantbird.org/attachment.cgi?id=2698 in Firefox to see what needs adjusting 23:16:15 <Mook_as> a tab is "jump to the next column such that column number % 8 is 0", or something along those lines 23:16:27 <nhnt11> ok 23:16:43 <nhnt11> Right 23:17:17 <qheaden> nhnt11: So, my mom was able to try out Awesometab. She loves it. :) 23:17:24 <nhnt11> :D 23:17:34 <clokep> qheaden: Put the gre ones first. 23:17:43 <qheaden> clokep: Okay. 23:21:50 <flo-retina> nhnt11: how soon is the next patch coming? 23:21:51 <qheaden> clokep: As for this comment: http://pastebin.instantbird.com/287572, should we leave it as is? 23:22:10 <nhnt11> flo-retina: A few minutes, I'm fixing the tab drop indicator 23:22:21 * qheaden doesn't think it is possible to have a buddy with an unknown status on Yahoo. 23:22:41 --> chrisccoulson has joined #instantbird 23:22:44 <flo-retina> heh, I guessed that part would be annoying :-D 23:23:11 <clokep> qheaden: I asked YOU that, you haven't given me an answer. 23:23:37 <qheaden> clokep: I say we leave it. 23:24:26 <clokep> The other way is more general. 23:25:51 <qheaden> clokep: getOnlineBuddies is used in situations where packets need to be relayed to other users who are online. If a person has an unknown status, should we even be sending them stuff? 23:27:58 * qheaden thinks 23:28:15 <qheaden> Well, I guess we'll just cover the general case. It won't hurt anything. 23:29:21 <clokep> qheaden: Hm. We don't use the status at all, just leave it then. 23:32:52 <qheaden> clokep: I see you are logged into your YMSG account, could you tell me what my profile image is? 23:33:05 <qheaden> The ibprpltest profile. 23:34:02 * nhnt11 cries 23:34:11 <clokep> qheaden: You don't have one... 23:34:15 <clokep> I'm using your code btw. 23:34:47 <qheaden> clokep: If you are using the Nightly Ib code, it doesn't have the get-icon patch in the tree yet. 23:35:15 <clokep> Yes, I know. :) 23:36:16 <qheaden> :) 23:37:21 <flo-retina> nhnt11: what's wrong? 23:37:45 <nhnt11> the drag indicator isn't scaling down :S 23:37:59 <nhnt11> Er scratch that 23:38:08 <nhnt11> I meant it's getting scaled up 23:39:32 <nhnt11> fixed it! 23:40:10 <qheaden> clokep: Should I add an XXX comment next to the expiration time? I really don't understand how that works. I was just following libpurple. 23:40:37 <clokep> qheaden: Add a TODO. 23:40:41 * clokep leaves for 5 minutes. 23:41:30 <nhnt11> flo-retina: The tab drag indicator is clipped at the top. Should I leave that as it is or fix it? 23:41:38 * nhnt11 doens't now how long that may take. 23:43:39 <flo-retina> isn't it already clipped at the top anyway? 23:43:47 <nhnt11> yes 23:43:55 <nhnt11> I'm asking if I should fix that 23:44:00 <nhnt11> I think I have it fixed 23:44:01 <flo-retina> isn't it on purpose? 23:44:07 <nhnt11> Is it? 23:44:16 <nhnt11> It looks odd to me 23:45:38 <flo-retina> have you put it back in the same direction as on Firefox? 23:45:59 <nhnt11> No. Does firefox even use that at all anymore? 23:46:08 <nhnt11> I thought it was flipped on purpose? 23:47:01 <nhnt11> Ah, it's used when dropping tabs from other windows 23:47:08 <flo-retina> it was flipped and the circle part was at the bottom right between 2 tabs at the place where there's already a rounded shape 23:47:45 <flo-retina> at the time we couldn't use the exact same behavior as Firefox because Firefox had a toolbar above the tabbar, and we didn't. 23:48:19 <flo-retina> anyway, if you want me to try a patch tonight, upload it very soon ;) 23:48:35 <nhnt11> ok 23:50:14 <qheaden> nhnt11: Countdown! 23:50:19 <qheaden> Sorry, I couldn't resist. 23:51:15 <nhnt11> flo-retina: I'm uploading a patch without modifying the flipping/clipped part 23:54:04 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 2698 on bug 2103. 23:54:05 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 2699 on bug 2103. 23:54:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2103 nor, --, ---, nhnt11, ASSI, Update tabbrowser images for retina displays 23:54:22 <nhnt11> Ew, the indenting is still wrong :S 23:54:29 <nhnt11> Sorry, give me 1 minute. 23:55:58 <nhnt11> :O 23:56:03 * nhnt11 has no clue what just happened 23:56:08 <nhnt11> Somehow the whole patch got posted as a comment 23:56:10 <nhnt11> :S 23:56:39 <instantbot> firstname.lastname@example.org requested review from email@example.com for attachment 2700 on bug 2070. 23:56:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, ASSI, Add Support for Buddy Icons 23:57:19 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 2699 on bug 2103. 23:57:20 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 2701 on bug 2103. 23:57:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2103 nor, --, ---, nhnt11, ASSI, Update tabbrowser images for retina displays 23:58:40 <nhnt11> flo-retina: Er, I missed the 2x image for the tab drag indicator 23:58:46 <nhnt11> I mean I forgot hg add 23:58:47 <nhnt11> :'(