#instantbird log on 08 03 2013

All times are UTC.

00:10:09 <-- dew has quit (Ping timeout)
00:14:40 --> dew has joined #instantbird
00:32:06 <-- wnayes has quit (Ping timeout)
00:36:08 --> wnayes has joined #instantbird
00:44:14 <-- Mook_as has quit (Quit: Mook_as)
00:58:35 <instant-buildbot> build #432 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/432
01:23:06 --> clokep_ has joined #instantbird
01:25:08 <instantbot> clokep@gmail.com granted review for attachment 2674 on bug 2083.
01:25:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
01:25:19 <instantbot> clokep@gmail.com granted review for attachment 2676 on bug 2083.
01:28:22 <instantbot> clokep@gmail.com denied review for attachment 2666 on bug 2079.
01:28:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2079 nor, --, ---, qheaden, ASSI, JS-Yahoo has no protocol icon
01:29:03 <clokep_> qheaden_away: Can you export your patches? It would make committing them easier. :)
01:33:32 <-- mmkmou has quit (Ping timeout)
01:37:28 --> mmkmou has joined #instantbird
01:39:17 <instantbot> clokep@gmail.com denied review for attachment 2672 on bug 2066.
01:39:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
02:23:30 <-- dionisos has quit (Ping timeout)
02:31:51 <-- wnayes has quit (Ping timeout)
02:35:58 --> wnayes has joined #instantbird
03:02:25 <-- wnayes has quit (Quit: wnayes)
03:05:41 <instant-buildbot> build #929 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/929
03:13:08 <instant-buildbot> build #929 of macosx-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/929
03:19:57 --> tabris has joined #instantbird
03:27:08 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
03:39:40 <-- tabris has left #instantbird ()
03:46:51 --> tabris has joined #instantbird
03:57:47 <-- mmkmou has quit (Client exited)
03:59:45 --> mpmc has joined #instantbird
04:00:18 --> jb has joined #instantbird
04:28:31 <-- tabris has left #instantbird ()
04:53:29 <-- dew has quit (Connection reset by peer)
04:54:24 --> dew has joined #instantbird
05:09:51 <-- jb has quit (Ping timeout)
05:19:50 --> EionRobb has joined #instantbird
05:45:28 <-- flo-retina has quit (Ping timeout)
05:45:31 --> flo-retina has joined #instantbird
05:45:31 * ChanServ sets mode +qo flo-retina flo-retina 
05:51:46 <instant-buildbot> build #1025 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1025
06:05:32 --> FireFly_TB has joined #instantbird
06:40:14 --> Mook has joined #instantbird
07:01:19 <-- Mook has quit (Ping timeout)
07:04:51 --> Mook has joined #instantbird
07:08:01 <-- flo-retina has quit (Ping timeout)
07:08:08 --> flo-retina has joined #instantbird
07:08:08 * ChanServ sets mode +qo flo-retina flo-retina 
07:12:18 <-- flo-retina has quit (Ping timeout)
07:12:31 --> flo-retina has joined #instantbird
07:12:31 * ChanServ sets mode +qo flo-retina flo-retina 
07:15:51 <-- flo-retina has quit (Ping timeout)
07:17:27 --> flo-retina has joined #instantbird
07:17:27 * ChanServ sets mode +qo flo-retina flo-retina 
07:30:19 <-- FireFly_TB has quit (Ping timeout)
07:50:32 --> Mic has joined #instantbird
07:50:32 * ChanServ sets mode +h Mic 
07:54:59 <-- gerv has quit (Ping timeout)
07:56:05 <Mic> nhnt11: thank you so much for fixing bug 2082, it was really annoying me :)
07:56:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2082 nor, --, ---, nhnt11, RESO FIXED, Error when opening a new conversation tab when a conversation exists with someone not on the buddy l
08:12:01 <-- Mook has quit (Quit: Mook)
08:16:44 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:35:03 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:31:42 --> qlum has joined #instantbird
09:43:07 --> aleth has joined #instantbird
09:43:07 * ChanServ sets mode +h aleth 
09:56:07 <-- flo-retina has quit (Ping timeout)
09:58:10 --> flo-retina has joined #instantbird
09:58:10 * ChanServ sets mode +qo flo-retina flo-retina 
10:02:57 --> nhnt11 has joined #instantbird
10:03:25 <nhnt11> Mic: You're welcome, but it wasn't like I was just going to leave it ;)
10:09:19 * flo-retina is trying to build with the first 2 patches of bug 1997 and that doesn't work "out of the box" :(
10:09:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1997 nor, --, ---, clokep, ASSI, Update to Mozilla 22
10:12:16 <flo-retina> uh, the last 6 mac nightly failed, and nobody complained?!?
10:19:03 --> mpmc has joined #instantbird
10:21:02 --> rosonline has joined #instantbird
10:22:37 <nhnt11> flo-retina: The last /6/ ???
10:22:48 <flo-retina> yeah :(
10:22:50 <nhnt11> Wow.
10:23:21 <nhnt11> I didn't notice because I was having issues with campus internet and was using 3g until yesterday...
10:23:31 <nhnt11> (So I wasn't updating)
10:23:34 <nhnt11> Weird.
10:25:15 <nhnt11> Apparently I need to go to the academic block because of some issue with one of my courses. bbl
10:46:14 --> jb has joined #instantbird
10:46:19 <-- rosonline has quit (No route to host)
10:58:38 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:11:49 <-- aleth has quit (Quit: Ciao)
11:11:59 --> aleth has joined #instantbird
11:11:59 * ChanServ sets mode +h aleth 
11:17:21 <-- jb has quit (Ping timeout)
11:19:38 <-- flo-retina has quit (Ping timeout)
11:20:57 --> flo-retina has joined #instantbird
11:20:58 * ChanServ sets mode +qo flo-retina flo-retina 
11:34:11 <instantbot> clokep@gmail.com set the Resolution field on bug 2086 to FIXED.
11:34:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2086 min, --, 1.5, qheaden, RESO FIXED, Could not deccode UTF-8 message into UTF-16.
11:34:31 <instantbot> clokep@gmail.com set the Resolution field on bug 2083 to FIXED.
11:34:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, 1.5, qheaden, RESO FIXED, Account created with username@yahoo.* instead of username is handled badly
11:40:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5455835719e4 - Quentin Headen - Bug 2086 - Could not decode UTF-8 message into UTF-16, r=aleth.
11:40:34 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/05965ac4df2e - Quentin Headen - Bug 2083 - Account created with username@yahoo.* instead of username is handled badly, r=clokep.
11:40:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6f33ac73b9ee - Quentin Headen - Bug 2083 - Account created with username@yahoo.* instead of username is handled badly: tests, r=clokep.
11:45:43 --> mpmc has joined #instantbird
11:48:52 --> clokep_wp8 has joined #instantbird
11:49:44 <clokep_wp8> flo-retina: Sorry about :-) failed nightlies. :-(
11:50:04 <clokep_wp8> I was ensuring the commit builds completed.
11:51:01 <-- clokep_wp8 has quit (Connection reset by peer)
11:52:18 <instant-buildbot> build #430 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/430
11:55:11 <-- EionRobb has quit (Ping timeout)
11:55:24 --> EionRobb has joined #instantbird
12:03:13 <-- EionRobb has quit (Quit: Leaving.)
12:04:10 <flo-retina> clokep_wp8: I don't think you could have done anything about the failed nightlies (except maybe pinging Even). It looks to me like a broken .mar file on the server prevents the creation of new partial update files.
12:16:53 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2680 on bug 1997.
12:16:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1997 nor, --, ---, clokep, ASSI, Update to Mozilla 22
12:23:02 <flo-retina> uh, the symbols in http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/923/steps/shell_3/logs/stdio are all broken
12:24:01 <flo-retina> looks like they have been broken for a while :(
12:27:44 --> atuljangra has joined #instantbird
12:57:36 <atuljangra> flo-retina: Ping.
12:59:34 <instantbot> clokep@gmail.com granted review for attachment 2680 on bug 1997.
12:59:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1997 nor, --, ---, clokep, ASSI, Update to Mozilla 22
13:09:59 <atuljangra> flo-retina: Please look at email when you are free. I'll be back later.
13:10:05 <atuljangra> Good evening.
13:10:09 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:33:22 <-- qlum has quit (Ping timeout)
13:33:44 --> qlum has joined #instantbird
14:18:33 <instant-buildbot> build #930 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/930
14:29:41 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:29:47 --> flo-retina has joined #instantbird
14:29:47 * ChanServ sets mode +qo flo-retina flo-retina 
14:36:41 <-- Tonnes has quit (Connection reset by peer)
14:38:03 <instantbot> florian@instantbird.org set the Resolution field on bug 1997 to FIXED.
14:38:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1997 nor, --, 1.5, clokep, RESO FIXED, Update to Mozilla 22
14:40:50 <instant-buildbot> build #431 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/431  blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com>
14:40:51 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f320335ca999 - Patrick Cloke - Bug 1997 - Port |Port bug 852950 to comm-central - Kill xpcom.dll/libxpcom.so/xpcom.dylib - to fix bustage|, r=fqueze.
14:40:52 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e681f6027c91 - Patrick Cloke - Bug 1997 - Port |Bug 863672 - Port MOZ_WEBSPEECH and MOZ_GAMEPAD changes from mozilla-aurora configure.in to comm-aurora configure.in|, r=fqueze.
14:40:53 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9dc201a3a063 - Patrick Cloke - Bug 1997 - Port |Bug 831485 comm-central should use mozilla-central's virtualenv|, r=fqueze.
14:40:54 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c07b7e017883 - Patrick Cloke - Bug 1997 - Update to Mozilla 22, r=fqueze.
14:40:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/904f4dd6b8e7 - Florian Qu├Ęze - Bug 1997 - Update to Mozilla 22 - Use moz.build only for mozilla/, r=clokep.
14:40:56 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a40f5c1fade9 - Patrick Cloke - Bug 1997 - Port |Bug 793953 - Support autoconf2.13 installed through fink|, r=fqueze.
14:41:23 <aleth> That looks like it was painful ;)
14:56:36 --> dionisos has joined #instantbird
15:11:16 --> wnayes has joined #instantbird
15:20:40 <-- aleth has quit (Quit: Ciao)
15:28:04 --> aleth has joined #instantbird
15:28:04 * ChanServ sets mode +h aleth 
15:33:12 --> mconley has joined #instantbird
15:36:35 <-- aleth has quit (Quit: Ciao)
15:49:54 --> clokep_ has joined #instantbird
15:53:44 <-- wnayes has quit (Ping timeout)
15:57:49 --> wnayes has joined #instantbird
16:08:23 <clokep_> qheaden_away: So, what have you been working on besides aleth's minor bugs?
16:26:14 <-- qlum has quit (Ping timeout)
16:26:36 --> qlum has joined #instantbird
16:37:00 --> rosonline has joined #instantbird
16:38:40 <-- rosonline has quit (Ping timeout)
16:41:12 --> rosonline has joined #instantbird
16:41:26 <-- mconley has quit (Input/output error)
17:00:27 <nhnt11> re
17:07:13 <clokep_> Hello.l
17:11:35 --> mconley has joined #instantbird
17:23:09 --> atuljangra has joined #instantbird
17:38:52 * atuljangra wonders when flo-retina will reply to the mail :-/ :s
17:39:02 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:53:46 <-- wnayes has quit (Ping timeout)
17:54:21 <clokep_> atuljangra: When he is ready. Commenting here will not make it come faster.
17:54:27 <clokep_> (And in fact might do the opposite.)
17:54:45 <atuljangra> clokep_: Okay :) Sorry.
17:57:02 --> Tonnes has joined #instantbird
17:57:48 --> wnayes has joined #instantbird
18:02:28 <-- mconley has quit (Input/output error)
18:18:23 <-- wnayes has quit (Quit: wnayes)
18:27:42 <atuljangra> clokep_: Many of the information is out of date(in the mail). And I do not agree with most of it.
18:28:19 <atuljangra> Sorry for being rude, but I guess much time wasn't given to the code that I submitted.
18:29:51 <atuljangra> And I'm really sorry if you think I was not focused. I am seriously surprised at this. 
18:31:41 <atuljangra> I'll reply to this later. It's really unfortunate of all the happenings. I am so disappointed.
18:34:31 <flo-retina> "much time wasn't given to the code that I submitted." which code?
18:35:30 <atuljangra> On my repository.
18:39:33 <flo-retina> we don't review the code in your repository as it's a moving target, we only offer drive by comments there. Real reviews happen on bugzilla and take time. Writing this code is (or should be) your full time job. Reviewing it isn't the full time job of anybody, so it's done whenever someone has time. Don't expect reviews of large pieces of code to happen immediately. I think we gave timely feedback whenever possible.
18:40:42 <clokep_> atuljangra: The second half of that sentence is important: "but even if these have changed in the past few days it will not really change my opinion", as in...if this hasn't changed in the past week I'm not confident it will change.
18:40:45 <atuljangra> I'm not saying that. My point is much of what Patrick said is outdated.
18:41:33 <atuljangra> clokep_: Okay. I need some time now. All of what I've coded is said to be null. This is really disappointing.
18:42:30 <atuljangra> I'll respond to the mail after some thinking.
18:43:26 <atuljangra> flo-retina: Did gerv discussed anything about continuation of project. I've been waiting for having a chat with you and gerv concurrently.
18:44:39 <flo-retina> "All of what I've coded is said to be null." That's not what we are saying. What we are saying is that it doesn't match what's expected of a GSoC student for half a summer.
18:45:11 <flo-retina> atuljangra: my understand is that gerv is away in London with his family today
18:46:51 <atuljangra> flo-retina: Okay, when will he come back. I really need to resolve gsoc thing.
18:46:52 <atuljangra> Letting all the hard work go like this is difficult thing to do.
18:47:03 <atuljangra> "it doesn't match what's expected of a GSoC student for half a summer." This maybe due to lack of communication. And failing cos of this in not acceptable to me. Filelink would be ready to land in 10 days, and I guess that is within your expectations.
18:47:40 <flo-retina> atuljangra: I don't understand how you can make statements like "Filelink would be ready to land in 10 days".
18:48:26 <flo-retina> it will take several review cycles before being ready to land. You can't guess how long review will take. Even if we had a team (both developers and reviewers) paid full time on it, I couldn't make a guess at how long it would take.
18:49:17 <atuljangra> flo-retina: What makes you believe it won't. We decided that download panel ui would not be included in the initial landing. So three days to complete UI. And 1 day to fix everything. And then 6-7 days for reviews.
18:49:24 <atuljangra> I took one week for reviews into account.
18:49:31 <atuljangra> I guess that is achievable. 
18:52:23 <atuljangra> I cannot take failing in midterm. You could've failed me on final eval if I did not achieve anything. But failing while work is going good is bad for me :(
18:52:26 <atuljangra> Give me another chance :s
18:52:51 <clokep_> I find that my expectations for how long it takes me to code something are almost always at least half of what it actually takes.
18:53:57 <atuljangra> clokep_: I gave my schedule on the etherpad, and I was ahead of the schedule till last 2 days.
18:54:20 <atuljangra> So how did this lead to my failure?
19:28:03 <atuljangra> :s
19:41:01 --> mconley has joined #instantbird
19:47:47 <-- mconley has quit (Input/output error)
19:51:51 --> mconley has joined #instantbird
19:52:22 <-- mconley has quit (Input/output error)
19:55:50 --> Mook has joined #instantbird
19:59:41 <nhnt11> clokep_: ping
20:01:55 <nhnt11> "Do callbacks ever get removed? What if I want to receive them from an
20:01:55 <nhnt11> extension?" I initially removed them at LISTEND, but then I realized that receiving that if a newtab was opened after this but before the channel list refresh interval, then the stats service would request channels again and would receive the whole list of cached channels at once, which was slow. Thinking about it, I guess cached channels should also be returned in batches.
20:02:21 <nhnt11> s/realized that receiving that/realized that
20:07:12 <nhnt11> I found a bug. the channel list is never cleared so successive LISTs will keep adding duplicates
20:11:51 <clokep_> nhnt11: You didn't answer my question at all there. :-/
20:12:03 <clokep_> If you can't remove the callback...then...you can't properly unregister an extension.
20:12:06 <clokep_> There would still be a reference to i.t
20:12:15 <nhnt11> Callbacks don't get removed in the current patch
20:12:30 <nhnt11> I realize it's a huge flaw
20:13:54 <nhnt11> Either I need to change to the observer model (which I hesitate to do just for channel lists, but I'm fine with it if you are) or I need to add a simple method to the prplIAccount interface to unregister chat room list callbacks.
20:14:41 <nhnt11> clokep_: What do you feel about "(un)registerChatRoomCallback" instead of "requestChatRooms"?
20:14:52 <nhnt11> Bah, also I need to change that to RoomInfo
20:15:39 <nhnt11> flo-retina: ^
20:17:28 <clokep_> nhnt11: registering doesn't really imply requesting it.
20:17:42 <nhnt11> That's true..
20:18:08 <nhnt11> How about keeping requestRoomInfo, and adding unregisterRoomInfoCallback? The second one seems way too long though
20:19:46 <nhnt11> "remove" is probably better than unregister
20:21:00 --> mconley has joined #instantbird
20:21:29 * clokep_ doesn't know.
20:21:32 <clokep_> I"m busy, sorry.
20:21:40 <nhnt11> Okay, no problem
20:27:48 <-- mconley has quit (Input/output error)
20:41:01 <flo-retina> it's possible I missed some of the context, but is this a case where weak references would help?
20:42:25 <-- qlum has quit (Ping timeout)
20:42:47 --> qlum has joined #instantbird
20:43:15 <nhnt11> The account would have to null check before invoking the callback then
20:43:37 <nhnt11> I think I prefer having a removeRoomInfoCallback function...
20:47:29 <flo-retina> nhnt11: can you point me to the code that you are trying to improve?
20:47:59 <nhnt11> It's in a patch, but let me try...
20:48:35 <flo-retina> bug number then? :)
20:48:38 <nhnt11> flo-retina: https://bugzilla.instantbird.org/attachment.cgi?id=2672&action=diff#a/chat/protocols/irc/irc.js_sec3 - callbacks are never removed.
20:48:46 <flo-retina> thanks
20:49:09 <nhnt11> I was trying to solve one problem and created another one :S
20:52:05 <flo-retina> so I guess I should actually look at the other patch with the idl changes :)
20:52:42 <nhnt11> Er, maybe yeah :]
20:53:35 <flo-retina> the stuff you added to purpleAccount.cpp is really strange. I assume that's a copy/paste from a generated .h file, but I can't guess what you were trying to do
20:54:32 <flo-retina> (to be clear, I'm not talking about the NS_IMETHODIMP purpleAccount::RequestChatRooms part. You just need to fix the indent there)
20:55:21 <nhnt11> flo-retina: Honestly I just copy pasted stuff into there and then changed things from what I saw in code elsewhere in the cpp file to make it work.
20:55:42 <nhnt11> But didn't do much more than make it work :P
20:56:36 <nhnt11> I'll look more closely at the other code in that file and fix it for the next patch.
20:57:25 <flo-retina> nhnt11: it's not clear to me why you would need it at all. It seems like dead code.
20:58:30 * nhnt11 is missing something here
20:58:37 <nhnt11> I thought all that was required to implement the interface?
20:59:17 <flo-retina> but you don't implement it
20:59:48 <nhnt11> So it should work even if I remove that completely?
21:00:20 <nhnt11> I thought I was supposed to do a minimum implementation in purplexpcom to complement the idl interface
21:02:11 <nhnt11> So it works without it. thanks.
21:02:25 * nhnt11 understood.
21:03:02 <flo-retina> it's the 3 lines starting with NS_IMETHODIMP purpleAccount::RequestChatRooms that are the minimal implementation you needed
21:03:09 <nhnt11> Yep, got it
21:03:17 <nhnt11> Because prplIAccount /is/ implemented
21:03:23 <flo-retina> ye
21:03:24 <flo-retina> s
21:03:46 <nhnt11> I hadn't given it too much thought before, I just pasted whatever code I found in the header file that was related to my changes :P
21:05:06 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:09:38 <flo-retina> nhnt11: that part wasn't worth wasting time on it :)
21:10:17 <nhnt11> Oh well :)
21:11:28 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:11:32 --> nhnt11 has joined #instantbird
21:16:15 * nhnt11 doesn't know how he's supposed to find out which IRC servers include channel modes in LIST results.
21:16:32 <nhnt11> clokep_, aleth: ^
21:16:57 <flo-retina> nhnt11: so that API is intended to be used only by the stats service?
21:17:03 <nhnt11> All I've seen is that Moznet does it and it runs Unreal 3.2.8.. Freenode doesn't and they use ircd-seven (which is custom I think?)
21:17:19 <nhnt11> flo-retina: No, I guess addons could use it
21:17:35 * nhnt11 doesn't want to try and predict what addons may or may not want to do ;)
21:18:48 <nhnt11> flo-retina: let me pastebin the modifications I've made since that patch for you
21:21:58 <clokep_> nhnt11: "which is custom" doesn't mean anything. ;)
21:22:15 <clokep_> nhnt11: It might only be unreal, yes.
21:22:17 <nhnt11> Er, in a couple minutes, I'm just addressing a few review comments...
21:22:25 <nhnt11> clokep_: I meant they run a custom ircd :P
21:22:30 <clokep_> There ar ea few websites that list responses, I couldn't find any information.
21:22:34 <clokep_> nhnt11: What is a "custom ircd"? :-S
21:22:40 <clokep_> That implies there is a non-custom one.
21:23:12 <nhnt11> I remember reading somewhere that freenode wrote their own server software or something. I may be totally wrong.
21:23:33 <nhnt11> Basically I guess I meant nothing else uses it? Which is a bad assumption
21:23:39 <nhnt11> disregard all these comments :P
21:23:59 <flo-retina> nhnt11: the "receiveChatRooms" name is horrible btw
21:24:39 <nhnt11> flo-retina: processRoomInfo? roomInfoReceived?
21:24:45 * nhnt11 shrugs
21:24:52 <clokep_> nhnt11: ircd-seven is a modifed version of another server (maybe inspircd?)
21:24:54 <flo-retina> clokep_: have you really not understood what nhnt11 meant by "custom"?
21:25:07 <clokep_> flo-retina: I really don't understand, no.
21:25:09 <nhnt11> clokep_: Yes that's what I meant.
21:25:19 <clokep_> nhnt11: But a lot of networks run it, I Think.
21:25:31 <nhnt11> That's why I said it's a bad assumption and disregard whatever I've said :P
21:25:43 <clokep_> euirc runs totally custom software that isn't even open source.
21:25:48 <flo-retina> clokep_: I think he meant "something they are the only one to use, as opposed to something that could be deployed in lots of different places"
21:25:59 <clokep_> Ah.
21:26:08 <nhnt11> What flo-retina said.
21:26:18 <flo-retina> clokep_: and you just used the word "custom" yourself ;)
21:26:48 <clokep_> flo-retina: Yes, but I used it in the sense of "proprietary".
21:27:31 <nhnt11> flo-retina: So.. er.. about the "receiveChatRooms" name.. do you like any of those alternatives I suggested?
21:29:16 <flo-retina> nhnt11: I think just making it receive*d*ChatRooms would suck a bit less
21:29:42 <flo-retina> nhnt11: but I'm not really interested in discussing the name until I understand why you think using observers isn't a good idea
21:29:53 * nhnt11 shrugs.
21:29:57 <nhnt11> I don't mind switching to observers
21:30:30 <flo-retina> nhnt11: yeah, I know it's possible. What I want to know is why you think it's not a good solution :).
21:30:38 <flo-retina> (I haven't read all the code yet)
21:30:55 <nhnt11> Well for the kind of data I need to return, I didn't like the aSubject aData model
21:31:23 <nhnt11> I don't really have a strong reason for not liking
21:31:24 <nhnt11> it
21:31:38 <nhnt11> s/a strong/any
21:32:27 * qheaden_away is now known as qheaden
21:32:29 <qheaden> Hi everyone.
21:32:39 <nhnt11> Whenever I've seen notifyObservers, there are usually multiple possilbe topics
21:32:45 <nhnt11> where as here there's only one case.
21:32:47 <nhnt11> Hi qheaden :)
21:34:00 <flo-retina> nhnt11: what's the expectation when calling requestChatRooms?
21:34:20 <qheaden> clokep_: I won't be on for long, but I just wanted to ask about you wanting me to export my patches. Do you mean use hg export?
21:34:26 <flo-retina> isn't this just returning asynchronously a list of chat rooms?
21:34:35 <nhnt11> The account is expected to find out what chat rooms are available (if they aren't cached already) and return them.
21:34:37 <nhnt11> Yes.
21:34:58 <flo-retina> so as soon as the account is done returning the list of rooms, the reference to the callback is dropped, right?
21:35:24 <nhnt11> No. The callback is kept and future refreshes of chat room lists are passed to it
21:35:31 <nhnt11> So I guess in that way the callback is an observer.
21:35:50 <nhnt11> Like I said, I'm willing to switch to an observer model.
21:36:19 <nhnt11> The consumer is expected to check for duplicate chat rooms, btw. the account won't bother with that. as of now.
21:36:52 <nhnt11> I guess we can have more notifications for all channels received, and fresh channel list refresh if we use observers
21:37:06 <flo-retina> will IRC accounts ever find new rooms if the method isn't called again?
21:37:14 <nhnt11> No.
21:38:02 <clokep_> qheaden: Yes.
21:38:12 <flo-retina> wouldn't things be much clearer if you dropped the "future refreshes of chat room lists are passed to it" part then?
21:38:29 <qheaden> clokep_: Okay, I'll do that for now on.
21:39:19 <nhnt11> flo-retina: I kept the callback references so that I don't return the whole list of cached channels every time a request is made, if the callback already received them.
21:39:40 <nhnt11> (this is before the refresh interval has ellapsed)
21:43:27 * qheaden is now known as qheaden_away
21:45:53 <flo-retina> nhnt11: that seems complicated
21:46:06 <flo-retina> nhnt11: can't you just avoid requesting it again at all if you requested it recently?
21:46:58 <nhnt11> Ok. I would need to keep track of when I last requested in the stats service in addition to the account implementation then.
21:47:33 <nhnt11> flo-retina: Do you think it's ok to ask accounts for chat room lists only once? Is it necessary to keep refreshing it periodically?
21:47:38 * nhnt11 thinks it's a bit of an edge case.
21:48:34 <flo-retina> nhnt11: would the account still need to care?
21:48:52 <nhnt11> Nope.
21:49:03 <nhnt11> Wait I may have misunderstood that
21:49:24 <nhnt11> The account would still need to ensure it doesn't refresh the list if two different consumers request it within seconds
21:49:30 <flo-retina> If people keep Instantbird running for days, the list is likely to get out of date
21:49:58 <flo-retina> nhnt11: so maybe it would just cache the list somewhere, with a timestamp of when the list was cached for the last time?
21:50:12 <nhnt11> That's done already
21:50:21 <flo-retina> ok, looks like what the current code does :)
21:59:15 <nhnt11> flo-retina: So I'm going to switch to observers.. ok?
21:59:42 <flo-retina> what's the value of aSubject?
22:00:01 <nhnt11> aSubject will be the list of chat rooms and aData will be the account id.
22:01:37 <flo-retina> do you need a new interface for "list of chat rooms"?
22:01:44 <flo-retina> or are you going to use http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsIArray.idl ?
22:02:20 <nhnt11> The latter (thanks :P )
22:03:31 * nhnt11 still likes the callback :P
22:04:12 <flo-retina> you can copy/paste some of the implementation from http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/preferences/in-content/applications.js#544
22:05:16 <nhnt11> Ah, thanks again.
22:05:49 <flo-retina> for the enumerate method, you want to use http://lxr.instantbird.org/instantbird/source/chat/modules/imXPCOMUtils.jsm#236 instead of http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/preferences/in-content/applications.js#114
22:06:11 <flo-retina> you may want to add an nsArray in imXPCOMUtils.jsm btw
22:06:43 <nhnt11> Yeah that makes sense.
22:07:06 <flo-retina> when you say you are going to switch to observers, you mean use nsIObserver instead of prplIRequestChatRoomsCallback? Not using Services.obs, right?
22:07:15 <nhnt11> Yes.
22:07:55 <flo-retina> I'm not sure observers are really helpful here
22:08:04 <flo-retina> I guess it depends if you have more than one topic or not
22:08:18 <flo-retina> maybe you use a different topic to tell the observer that the list is finished?
22:08:18 <nhnt11> that was kind of my point :P
22:08:22 <nhnt11> Yeah
22:08:36 <nhnt11> It only makes more sense than a callback if we have notifications for list finished and list starting
22:08:48 <nhnt11> (Are these necessary?)
22:09:43 <nhnt11> I don't see any advantages in using callbacks vs. nsIObserver otherwise
22:09:45 <flo-retina> list started seems pointless
22:10:08 <nhnt11> It would let observers know that their lists will be updating.. in case they want to do something
22:10:24 <nhnt11> but yeah I don't see a case practically...
22:10:33 <flo-retina> they know it; because they just requested a list
22:10:46 <nhnt11> What if a different observer requested it?
22:11:15 <flo-retina> I don't think you should keep references to observers in the account implementation after you have returned a full list
22:11:49 <nhnt11> Then the observers are temporary? The callbacks seem to make more sense in this case imo.
22:15:23 <nhnt11> Here are the updated patches as of now btw...
22:15:23 <nhnt11> API: http://pastebin.instantbird.com/272803
22:15:23 <nhnt11> LIST: http://pastebin.instantbird.com/272807
22:16:24 <flo-retina> nhnt11: I think they are temporary. This has the advantage that you don't need an API to remove them ;)
22:17:09 <nhnt11> So.. can I keep the callbacks? :P
22:17:38 <flo-retina> I guess yes
22:18:09 <flo-retina> why do you pass the account to the callback btw?
22:18:51 <nhnt11> I now need to make sure the stats service doesn't request chat rooms every time a new tab is opened.
22:19:18 <nhnt11> The callback needs to know which account the rooms are from, and simply taking it from one of the rooms in the list seemed gross to me.
22:19:30 <nhnt11> I don't mind doing that though if you think it's better.
22:20:18 <flo-retina> I don't really mind either way
22:20:35 <nhnt11> ok
22:20:48 <flo-retina> if you keep the callback, you should use the function keyword (example: http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsIObserver.idl#13)
22:21:53 <nhnt11> Ah thanks.
22:22:22 <flo-retina> https://developer.mozilla.org/en-US/docs/XPIDL/Function_modifier
22:22:38 <flo-retina> I'm going to bed, good night
22:22:43 <nhnt11> I assume it's so that I can just do requestRoomInfo(function() {...})
22:22:53 <nhnt11> Looks like I'm right
22:22:54 <flo-retina> exactly :)
22:22:57 <nhnt11> Ok, good night!
22:23:14 <flo-retina> so that you don't have to create an object with a method, and to implement QueryInterface in there
22:23:36 <nhnt11> Got it
22:29:38 <nhnt11> flo-retina: We still may need an api to remove the callback. What if a consumer wants to remove itself before the end of the list?
22:29:44 <nhnt11> (In an addon for e.g.)
22:30:27 <nhnt11> I'm going to include it and submit a patch, we can discuss in the morning.
22:30:30 <clokep_> qheaden_away: Not a big deal, just would be easier to check things in.
22:30:33 * clokep_ now feels flo's pain.
22:32:41 <nhnt11> clokep_: Is it ok to use setInterval?
22:35:54 <nhnt11> I'm probably going to use setTimeout, never mind.
22:39:48 <-- dionisos has quit (Ping timeout)
22:40:14 <clokep_> nhnt11: setTimeout should probably be OK.
22:44:21 --> mconley has joined #instantbird
22:49:26 <nhnt11> clokep_: How often do you think we need to refresh LIST data? I'm thinking every hour would be enough, or maybe even less often.
22:50:15 <-- qlum has quit (Connection reset by peer)
22:51:08 <clokep_> nhnt11: Rarely.
22:52:05 <nhnt11> Every 24 hours perhaps?
23:04:19 --> atuljangra has joined #instantbird
23:11:03 --> Mic has joined #instantbird
23:11:04 * ChanServ sets mode +h Mic 
23:11:24 <Mic> Good evening
23:13:19 <atuljangra> Good Evening.
23:13:22 <atuljangra> :)
23:14:55 <-- Suiseiseki has quit (Ping timeout)
23:19:42 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
23:20:38 <nhnt11> Hi Mic
23:21:04 <Mic> Hi
23:21:27 <Mic> I haven't checked the logs yet, please let me do that first ;)
23:21:42 <nhnt11> I wanted to discuss the future of my project, is now a bad time? (it's pretty late)
23:21:50 <nhnt11> Sure.
23:22:39 <Mic> It's pretty late and I've had a glass of wine too many to be honest ;)
23:22:53 <Mic> What time would suit you tomorrow?
23:23:01 <nhnt11> I'll save it for tomorrow then :)
23:23:15 <Mic> I'll try to make it possible if you name something ;)
23:23:41 <nhnt11> Er, I'm not sure. I'll almost surely be online in the evening, or past 11pm my time.
23:24:07 <nhnt11> (That's 8pm-ish for you?) 
23:26:38 <nhnt11> I've got nothing big to discuss btw, just wanted to share thoughts on what's left and making sure I meet the deadline. So I can just bring it up next time we're online at the same time.
23:27:44 <Mic> OK, sounds good :)
23:36:41 <instant-buildbot> build #446 of linux-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/446  blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com>, Patrick Cloke <clokep@gmail.com>
23:36:48 * Mic decided to catch up with the backlog tomorrow morning.
23:36:53 <Mic> Good night!
23:36:57 <nhnt11> Night
23:37:07 <instant-buildbot> build #433 of win32-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/433  blamelist: Florian Qu?ze <florian@instantbird.org>, Quentin Headen <qheaden@phaseshiftsoftware.com>, Patrick Cloke <clokep@gmail.com>
23:49:48 <Mic> nhnt11++ ;)
23:50:15 <atuljangra> heh
23:50:21 <nhnt11> Mic: Er.. what for? :P
23:50:42 <Mic> For not being in the blame-list of that failed on-commit build ;)
23:50:47 <nhnt11> :D
23:53:58 <atuljangra> Can I somehow open just preferences window :-/
23:54:14 <Mic> atuljangra: what for?
23:54:29 <atuljangra> Debugging takes quite a time going through the whole procedure.
23:54:31 <Mic> I think it's possible with "-preferences" on the command line.
23:54:43 <atuljangra> Mic: I'm trying to implement filelink pane in preferences.
23:55:12 <Mic> Try this command line parameter. I think it will just open the preferences window and nothing else.
23:55:28 <atuljangra> Worked like charm :D
23:55:33 <atuljangra> Thanks Mic 
23:55:46 <Mic> You're welcome :)
23:56:58 <Mic> Yes, things get very slow as soon as you have some UI interaction in your debugging steps :S
23:57:22 <atuljangra> yes :-/
23:57:59 <atuljangra> I do some changes, then make ib and then get to see the changes. This iteration is done for small small changes :s