#instantbird log on 08 01 2013

All times are UTC.

00:07:16 --> mconley has joined #instantbird
00:07:57 <-- dew has quit (Connection reset by peer)
00:08:01 --> dew has joined #instantbird
00:29:26 <-- Mook_as has quit (Quit: Mook_as)
00:35:41 <-- rosonline has quit (Ping timeout)
00:36:33 <-- Tonnes has quit (Ping timeout)
00:41:36 --> rosonline has joined #instantbird
00:41:49 <-- mconley has quit (Input/output error)
00:41:50 <-- wnayes has quit (Ping timeout)
00:45:20 --> wnayes has joined #instantbird
01:12:37 --> mpmc has joined #instantbird
01:13:33 --> Tonnes has joined #instantbird
01:13:39 --> mconley has joined #instantbird
01:16:13 <-- mconley has quit (Input/output error)
01:32:27 <-- rosonline has quit (Client exited)
01:51:04 --> mconley has joined #instantbird
01:59:11 --> jb has joined #instantbird
02:40:39 <-- jb has quit (Quit: jb)
02:41:51 <-- wnayes has quit (Ping timeout)
02:45:48 --> wnayes has joined #instantbird
02:52:26 <-- wnayes has quit (Quit: wnayes)
03:05:54 <instant-buildbot> build #927 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/927
03:12:46 <instant-buildbot> build #927 of macosx-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/927
03:22:13 <-- mconley has quit (Input/output error)
03:43:59 * qheaden_away is now known as qheaden
03:44:16 <qheaden> Hello to... whoever is on. :P
03:49:35 <instantbot> clokep@gmail.com set the Resolution field on bug 2075 to FIXED.
03:49:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2075 nor, --, 1.5, nhnt11, RESO FIXED, TypeError: setting a property that has only a getter
03:49:45 <instantbot> clokep@gmail.com set the Resolution field on bug 2078 to FIXED.
03:49:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2078 nor, --, 1.5, nhnt11, RESO FIXED, Home/End in newtab filterbox don't work as expected
03:50:15 <instantbot> clokep@gmail.com set the Resolution field on bug 2080 to FIXED.
03:50:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2080 maj, --, 1.5, qheaden, RESO FIXED, Buddy Authorization Handler Doesn't Work
03:54:29 --> clokep_ has joined #instantbird
03:54:44 <clokep_> qheaden: Yes, you can use MD5s for knowing if you need to update the cache.
03:54:59 <clokep_> Again, I'll say you should check what XMPP does (does it cache the icons?) If not, don't bother, if it does, we should too.
03:55:07 <qheaden> clokep_: Okay.
03:55:18 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/981fe83f55c0 - Quentin Headen - Bug 2080 - Buddy Authorization Handler Doesn't Work, r=clokep.
03:55:18 <clokep_> Have you made any progress?
03:55:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9deb70968e96 - Nihanth Subramanya - Bug 2075 - TypeError: setting a property that has only a getter, r=aleth.
03:55:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f493da9bf7bd - Nihanth Subramanya - Bug 2078 - Home/End in newtab filterbox don't work as expected, r=aleth.
03:55:54 <qheaden> clokep_: Not today. I had to take care of a number of things today. I plan on working through tonight to catch up.
03:56:01 <clokep_> qheaden: Cool. :)
03:56:14 <clokep_> The initial patch looked pretty good though, I didn't have any major thoughts against it.
03:56:24 <qheaden> Okay, great.
03:56:28 * clokep_ suspects setting the picture will be more difficult.
03:56:33 <clokep_> Easy that it's just a URL though. :)
03:56:44 <clokep_> I figured you'd have to decode the raw binary image.
03:57:11 <qheaden> I wonder if we have to do any conversion and resizing, or if the server handles that.
03:57:36 <clokep_> For uploading?
03:57:38 <clokep_> Probably a bit of both.
03:57:43 * clokep_ needs to go hunt for scorpions.
03:57:45 <qheaden> Okay.
03:57:51 <clokep_> ("needs" might be a strong word...)
03:58:08 <qheaden> LOL. Where are you, in the desert?
03:58:33 * clokep_ is now known as clokep_away
04:07:43 <instant-buildbot> build #428 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/428
04:09:49 <instant-buildbot> build #444 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/444
04:22:41 --> mconley has joined #instantbird
04:27:47 <-- mconley has quit (Ping timeout)
05:07:32 <-- mpmc has quit (Connection reset by peer)
05:53:43 <instant-buildbot> build #1023 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1023
05:54:02 <-- dew has quit (Ping timeout)
06:56:18 --> dew has joined #instantbird
06:58:23 <-- EionRobb has quit (Connection reset by peer)
07:13:53 --> qlum has joined #instantbird
07:15:34 <instant-buildbot> build #431 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/431
07:44:10 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2665 on bug 2079.
07:44:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2079 nor, --, ---, qheaden, ASSI, JS-Yahoo has no protocol icon
07:48:04 <instantbot> qheaden@phaseshiftsoftware.com cancelled review?(clokep@gmail.com) for attachment 2665 on bug 2079.
07:48:05 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2666 on bug 2079.
07:48:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2079 nor, --, ---, qheaden, ASSI, JS-Yahoo has no protocol icon
08:10:37 --> mpmc has joined #instantbird
08:45:41 --> nhnt11 has joined #instantbird
08:47:28 <-- nhnt11 has left #instantbird ()
09:17:53 --> aleth has joined #instantbird
09:17:53 * ChanServ sets mode +h aleth 
09:22:13 <-- qlum has quit (Ping timeout)
09:22:35 --> qlum has joined #instantbird
09:23:25 <instantbot> aleth@instantbird.org granted review for attachment 2664 on bug 2081.
09:23:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, nhnt11, ASSI, Pressing the up key in the top row of the newtab should refocus the filterbox
09:24:09 --> nhnt11 has joined #instantbird
09:37:42 <-- aleth has quit (Quit: Ciao)
09:37:51 --> aleth has joined #instantbird
09:37:51 * ChanServ sets mode +h aleth 
09:48:18 <-- dew has quit (Ping timeout)
09:49:03 --> dew has joined #instantbird
10:10:23 * qheaden is now known as qheaden_away
10:40:40 <-- mpmc has quit (Connection reset by peer)
10:48:33 <-- nhnt11 has quit (Ping timeout)
10:49:26 --> nhnt11 has joined #instantbird
10:59:05 <aleth> Recently I'm occasionally seeing "404: Remote server not found" as the status of (offline) gmail.com contacts added to the roster of a non-gtalk XMPP account.
11:00:49 <aleth> I'm not sure if those contacts are actually offline.
11:18:00 <aleth> nhnt11: Any progress with bug 2066? It didn't seem /that/ far from being done.
11:18:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
11:18:06 <flo-retina> aleth: I suspect it means the XMPP federation between the 2 servers is broken
11:18:26 <nhnt11> aleth: Yes, working on a new patch.
11:18:47 * nhnt11 found bugs :-/
11:18:55 <aleth> flo-retina: That's what I was wondering too, if it is a symptom of google turning off its federation support. But I don't know enough about how that works internally.
11:19:09 <aleth> wb btw :)
11:20:01 * flo-retina came home with ~800 photos (mostly photos of other AMIs), and lots of parts
11:20:35 <aleth> Parts you need now or for future emergencies?
11:22:09 <-- nhnt11 has quit (Ping timeout)
11:22:13 <flo-retina> some parts I need now, some that I would need to improve a few things on my AMI, and lots that aren't exactly compatible with my AMI, but could be used to exchange with other AMI owners with parts I really need during future emergencies ;)
11:22:48 <flo-retina> The mess currently in the garage: http://queze.net/goinfre/mamie/nationale2013/leboncoin/IMG_2179.jpg http://queze.net/goinfre/mamie/nationale2013/leboncoin/IMG_2185.jpg http://queze.net/goinfre/mamie/nationale2013/leboncoin/IMG_2180.jpg
11:23:08 <aleth> lots of parts indeed :)
11:23:40 <flo-retina> and a gearbox I really need: http://queze.net/goinfre/mamie/nationale2013/leboncoin/IMG_2182.jpg
11:23:54 --> nhnt11 has joined #instantbird
11:24:30 <nhnt11> aleth, flo-retina: What are your opinions on the interface name "prplIChatRoom"?
11:24:45 <nhnt11> I don't know what else to call it, clokep says it's confusing.
11:25:08 <flo-retina> traffic jam purely caused by AMIs: http://queze.net/goinfre/mamie/nationale2013/vendredi/IMG_1624.jpg :)
11:25:23 <flo-retina> nhnt11: I would need to know what it contains to have an opinion on the name
11:25:26 --> jb has joined #instantbird
11:25:53 <nhnt11> flo-retina: It represents a chat room, and PossibleChats build from instances of it. I'll pastebin it for you.
11:26:05 <nhnt11> That's a lot of AMIs! :)
11:26:06 <flo-retina> but it does sound confusing, as when reading only the name I would assume it's the same thing as prplIConvChat
11:26:24 <flo-retina> we had ~50 AMIs during the week-end :)
11:26:36 <aleth> Now that is a rare sight :) 
11:26:45 <aleth> great picture...
11:27:32 <flo-retina> nhnt11: I would say it's not a chat room, but a description of a chat room. What about prplIRoomInfo? or prplIRoomDescription ?
11:27:39 <flo-retina> aleth: thanks :)
11:28:18 <nhnt11> flo-retina: http://pastebin.instantbird.com/269380
11:28:42 <flo-retina> I've got lots of nice pictures in there, but I'm not going to paste links here to hundreds of them ;). You can explore a bit in http://queze.net/goinfre/mamie/nationale2013/ if you are curious
11:29:44 <flo-retina> nhnt11: ok, thanks. How do you feel about prplIRoomInfo or prplIRoomDescription?
11:29:45 <aleth> Those directories could do with an hmtl file with some js that throws up thumbnails ;)
11:29:59 <nhnt11> flo-retina: I like prplIRoomInfo better.
11:30:23 <flo-retina> aleth: well, they are not meant to be browsers like that :-/
11:30:54 <nhnt11> Or even ChatRoomInfo
11:30:57 <flo-retina> I just throw lots of pictures in there so that I can put lots of pictures at once in a forum without going through sucky image hosters
11:31:15 <aleth> It's definitely much better than image hosters...
11:31:26 <flo-retina> aleth: I just execute this on my shell to generate the stuff I need to paste on the forum: for i in goinfre/mamie/nationale2013/dimanche/*.jpg; do echo [img]http://queze.net/$i[/img]; done
11:31:37 <-- clokep_away has quit (Quit: http://www.mibbit.com ajax IRC Client)
11:31:56 <flo-retina> my previous server had a script that automatically generated html pages with all the images of the folder
11:32:00 <flo-retina> maybe I should code that up again
11:36:00 <-- jb has quit (Ping timeout)
11:38:35 --> jb has joined #instantbird
11:44:12 <nhnt11> Bah, LIST results from freenode make everything laggy :(
11:45:42 <aleth> I kind of expected your current batching would need some tweaking...
11:45:52 <nhnt11> aleth: It's not the batching, I think
11:46:05 <nhnt11> It gets laggy even without my code...
11:46:21 <aleth> You said that was only on debug builds.
11:46:33 <nhnt11> on debug builds it was a complete UI freeze
11:46:34 <aleth> If that's not the case then it needs investigating.
11:46:37 <nhnt11> let me do more testing...
11:47:00 <nhnt11> Btw, I'm returning 200 channels per batch currently
11:47:34 <aleth> I didn't mean just the number of channels, but whether the processing itself has to be throttled somehow.
11:47:42 <nhnt11> Yeah..
11:47:52 <nhnt11> I'm starting to rethink this api
11:48:10 <aleth> Doesn't really affect the API, this is lower level
11:48:21 <nhnt11> IRC allows you to limit results from LIST
11:48:32 <nhnt11> LIST <channel names> will give you info about those channels
11:48:42 <nhnt11> So why not request this only when the user starts typing?
11:48:45 <aleth> But for that you need to know the channel names.
11:48:47 <nhnt11> Instead of requesting all of them.
11:48:51 <aleth> It won't help you.
11:49:16 <nhnt11> There are so many channels that filtering the list is lagging :/
11:50:02 <aleth> There are not so many that a modern PC shouldn't be able to cope though ;)
11:50:32 <aleth> Also the problem of filtering when you have the data is different from the problem of receiving the data.
11:50:42 <nhnt11> True
11:52:27 <nhnt11> Btw, when I say filtering is lagging I mean it freezes for a second
11:52:32 <aleth> For receiving the data, if the issue really exist even without any of your added code then one would have to look at the way the socket currently pushes data to the account (for the case when the server sends a lot of data)
11:52:54 <nhnt11> No, receiving the data is fine.
11:53:03 <nhnt11> I thought it was lagging
11:53:10 <nhnt11> but further testing reveals.. it's fine
11:53:13 <aleth> For your filtering, that is a code optimization problem.
11:53:31 <nhnt11> I'm really worried about the filtering though. Looks like I can't use Array.filter anymore if this is a problem.
11:54:09 <aleth> I'm tempted to say leave this until you look at ranking and sorting, because that'll require something better than Array.filter anyway.
11:54:19 <nhnt11> Right..
11:56:07 <aleth> For now try to get the MUCs appearing reasonably nicely, and the IRC code polished enough to land.
11:56:23 <nhnt11> ok then
11:56:37 <nhnt11> I think that should be nearly done
11:56:41 <aleth> nhnt11: This may or may not be of interest later http://dutherenverseauborddelatable.wordpress.com/2013/07/19/asynchronous-database-connections-in-the-mozilla-platform/
11:57:18 <aleth> But you should discuss with flo while he is around what the "database" options are ;)
11:57:46 <nhnt11> aleth: Flo suggested IndexedDB, another option is just plain JSON
11:59:41 <aleth> The advantage of using something like indexedDB is that you don't have to reinvent rapid searching etc, and it's async already.
11:59:46 <nhnt11> aleth: Thanks for that link.
11:59:59 <nhnt11> Right. It does seem good.
12:00:08 <nhnt11> I really need to eat something, bbl.
12:00:16 <aleth> But I don't know anything much about it as I've never used it ;)
12:00:32 <nhnt11> :P
12:01:53 <aleth> nhnt11: Btw quick idea to improve your filtering: Don't filter the whole list every time. Filter the currently displayed sublist only if the user only added letters to the search string.
12:02:16 <-- nhnt11 has quit (Ping timeout)
12:39:31 <-- jb has quit (Ping timeout)
13:11:07 --> mpmc has joined #instantbird
13:34:14 --> jb has joined #instantbird
13:45:36 --> mconley has joined #instantbird
13:50:18 <-- mconley has quit (Input/output error)
13:59:28 --> mconley has joined #instantbird
14:12:15 <-- Tonnes has quit (Connection reset by peer)
14:16:46 --> Tonnes has joined #instantbird
14:16:47 <-- jb has quit (Ping timeout)
14:28:08 --> jb has joined #instantbird
14:48:54 <-- jb has quit (Ping timeout)
14:50:33 --> jb has joined #instantbird
15:42:05 --> atuljangra has joined #instantbird
15:55:45 <-- Tonnes has quit (Connection reset by peer)
16:03:55 --> nhnt11 has joined #instantbird
16:05:48 * qheaden_away is now known as qheaden
16:05:51 <qheaden> Hello everyone.
16:08:23 <nhnt11> aleth: I thought of that, but it'll need some changes to implement ;)
16:08:35 <nhnt11> (http://log.bezut.info/instantbird/130801#m179)
16:09:19 <qheaden> flo-retina: What account callbacks are fired when someone sets their profile image?
16:11:22 <aleth> qheaden: None, as far as I know. Unless accounts watch the pref or the user-icon-changed notification, it's independent.
16:12:05 <qheaden> Okay. Do any of the account plug-ins support icon changes from Ib?
16:14:19 <qheaden> I see JS XMPP supports it.
16:15:27 <aleth> Libpurple also uses it I think, but I don't know which protocols exactly.
16:17:25 <aleth> The notification is observed by http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccount.cpp#873 and http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#691 for JS-XMPP
16:22:18 <-- flo-retina has quit (Ping timeout)
16:22:25 --> flo-retina has joined #instantbird
16:22:25 * ChanServ sets mode +qo flo-retina flo-retina 
16:30:05 <-- qlum has quit (Ping timeout)
16:30:27 --> qlum has joined #instantbird
16:30:59 --> Tonnes has joined #instantbird
16:36:41 --> nhnt12 has joined #instantbird
16:36:54 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt12))
16:36:56 * nhnt12 is now known as nhnt11
16:49:43 --> Mook_as has joined #instantbird
16:51:33 <-- Mook_as has quit (Quit: Mook_as)
16:51:50 --> Mook_as has joined #instantbird
16:55:33 <qheaden> Yahoo's buddy icon upload process is extremely messy. :-S
17:08:03 <qheaden> aleth: So have you been able to use JS Yahoo anymore?
17:15:27 <-- qlum has quit (Ping timeout)
17:15:49 --> qlum has joined #instantbird
17:16:27 <aleth> qheaden: I've played with it a bit and it works well :) But I don't have any Yahoo contacts so I haven't used it much
17:17:02 <aleth> I plan to connect to it with the Yahoo messenger app on my old mobile and see what happens...
17:27:33 <-- nhnt11 has quit (Ping timeout)
17:27:41 --> nhnt11 has joined #instantbird
17:43:37 --> rosonline has joined #instantbird
17:58:16 <qheaden> aleth: Okay, cool. Glad it is working so far.
18:24:38 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:58:22 <nhnt11> aleth: So.. about these performance issues
18:58:31 <-- rosonline has quit (Connection reset by peer)
18:58:44 <nhnt11> I'm not sure if just leaving it for now is a good idea
18:58:59 <nhnt11> It'll be pretty broken for nightly users who use freenode.
18:59:55 <nhnt11> I really want to get started on the stats and ranking stuff though
19:00:13 <aleth> Can't you implement some "quick win" improvements that make it useable but not perfect?
19:00:34 <aleth> Also, put a patch up of what you have for feedback anyway.
19:01:10 <nhnt11> So what I propose is to upload a patch for now, and get the ranking stuff done. Then come back to this and tackle it properly, without risking the database changes further bitrotting any improvements I try to make now.
19:01:41 <aleth> I think it would be better if we could land this before you work on the ranking, which will take a while
19:02:22 <aleth> Even if it's not perfect in terms of performance.
19:02:30 <aleth> poor Even :-/
19:03:43 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:04:35 --> rosonline has joined #instantbird
19:04:47 <aleth> nhnt11: What do you think?
19:05:01 <nhnt11> I'll spend some more time
19:05:08 <nhnt11> And see if I can improve it to the point that it's not painful
19:05:25 --> atuljangra has joined #instantbird
19:05:29 <aleth> That way, we could file followups, and because all the key listitems will be present, we can get a11y feedback etc while you do the database stuff.
19:05:48 <nhnt11> ok
19:06:57 <aleth> Also, as long as it's OK with moznet it's not a dealbreaker for nightlies I suspect ;)
19:07:07 <nhnt11> Heh, true
19:07:12 <nhnt11> It's absolutely fine with moznet.
19:07:22 <aleth> An order of magnitude less channels...
19:07:29 <aleth> at least.
19:08:00 <aleth> Efnet would probably be painful too. And being logged in to multiple such accounts, well...
19:08:43 <aleth> So I think your instincts are right not to spend /too/ much time on premature optimization.
19:11:33 <nhnt11> also, all this makes me think whether awesometab is the right UI to handle LIST results.
19:11:52 <nhnt11> Considering we want it to be something that knows what you want to open, rather than something to use when you don't yet know what you want.
19:11:55 <nhnt11> If that makes sense.
19:12:10 <nhnt11> I may be thinking like an escapist here though, bah :P
19:12:29 <aleth> Hopefully we can be clever and do both ;)
19:14:41 <aleth> Roughly, the predictive part is important when entering only a very short search string, or none at all, and for *what is on the first page* which iirc you ultimately wanted to display differently anyway. The sorting part and LIST is important when scrolling, and when the search term is longer, eg a whole word.
19:15:11 <nhnt11> right
19:15:47 <nhnt11> Honestly I think this will be much faster when we do database lookups instead of Array.filter ;)
19:16:10 <aleth> Yeah, that might just take care of it.
19:17:21 <aleth> Still, worth keeping in mind that e.g. it's probably not needed to ever display LIST results on the first page. Stuff like that gives room to optimize.
19:17:41 <nhnt11> Yeah..
19:18:14 <instantbot> New Core - Yahoo! Messenger bug 2083 filed by aleth@instantbird.org.
19:18:14 <nhnt11> Another thing that would help a lot would be if the stats service returned results async.
19:18:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, nobody, NEW, Account created with username@yahoo.* instead of username is handled badly
19:18:33 <nhnt11> Which will probably be a necessary change anyway.
19:18:53 <atuljangra> aleth: How do we review UI? Should I upload images and show it to you?
19:19:03 <aleth> nhnt11: That wouldn't surprise me at all.
19:19:25 <aleth> atuljangra: If you just want quick feedback, screenshots are great :)
19:19:36 <nhnt11> I'm thinking of implementing async results now.
19:19:47 <aleth> If you are at the mockup stage, just sketch it and take a picture or something.
19:20:09 <nhnt11> Probably with a callback like for chat room list requests... and we could put a throbber in the search bar to indicate filtering was going on, or something.
19:20:18 <aleth> nhnt11: Could that be a separate bug?
19:20:22 <nhnt11> Yeha
19:20:23 <nhnt11> yeah*
19:20:26 <nhnt11> ok
19:20:26 <atuljangra> aleth: OK. :)
19:20:26 <nhnt11> fine
19:20:32 <nhnt11> I think I'm decided for now.
19:20:45 <aleth> nhnt11: Just so that clokep doesn't have to wade through those changes too ;)
19:20:46 <aleth> Cool :)
19:21:03 <nhnt11> I'll submit this as it is now, and hopefully the performance issues will go away when the stats-storing stuff comes in.
19:24:14 <instantbot> New Core - Yahoo! Messenger bug 2084 filed by aleth@instantbird.org.
19:24:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2084 nor, --, ---, nobody, NEW, No handler for Yahoo! packet e4.
19:24:51 <aleth> qheaden: How long does a Yahoo account usually stay locked? ;)
19:27:38 <nhnt11> aleth: I don't think we came to a decision on the chat list item UI, btw, what are your thoughts? How about #instantbird         (MUC icon) Join chat for now, and then we do the name and server info in a followup?
19:28:29 <aleth> I think I'd prefer if you replaced "Join chat" with the server name or account name for now, just so that it is there for testing.
19:28:40 <nhnt11> ok
19:28:41 <aleth> Otherwise, sounds good.
19:28:57 <nhnt11> #instantbird          (MUC icon) name@server  ?
19:29:04 <aleth> OK
19:29:24 <aleth> I'm sure we'll want to tweak it, but let's not get distracted ;)
19:30:20 <nhnt11> Btw, I played around with the number of channels returned per batch and it didn't make too much of a difference (I tried from 50 to 1k)
19:30:25 <nhnt11> So I'll leave it at 250 for now.
19:30:30 <nhnt11> (Kinda middle ground)
19:33:33 <aleth> It would be nice to have the profiler and be able to see exactly where the bottlenecks are.
19:33:45 <qheaden> aleth: Not entirely sure. I guess a few hours.
19:33:45 <nhnt11> Yeah..
19:33:59 <aleth> Hopefully that ongoing TB gsoc project will help with that ;) From the bug, looks like much progress happening there.
19:34:12 <nhnt11> :)
19:34:15 <aleth> Though flo-retina already got the profiler working once, it wasn't easy.
19:34:30 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:35:05 <aleth> (bug 876636 if you are interested)
19:35:24 <nhnt11> I'll check it out later, thanks.
19:41:42 <qheaden> aleth: Do you have another account you can test?
19:42:01 <qheaden> aleth: Perhaps try the same thing on the libpurple Yahoo plug-in and see what happens.
19:45:47 <nhnt11> Something isn't right.
19:46:01 <nhnt11> Filtering is slightly laggy with only moznet
19:46:12 <nhnt11> I timed the actual filtering, it's less than 20ms
19:46:28 <nhnt11> Rebuilding list items, < 10ms.
19:46:39 <nhnt11> It shouldn't be choppy at all.
19:47:16 <aleth> Intriguing...
19:47:28 * nhnt11 is investigating...
19:47:57 <-- aleth has quit (Quit: Ciao)
19:48:08 --> aleth has joined #instantbird
19:48:08 * ChanServ sets mode +h aleth 
19:51:29 <nhnt11> The error console is getting cleared somehow before errors can be displayed
19:51:49 <nhnt11> I think there's some memory issue going on
19:54:36 <aleth> qheaden: There is nothing interesting in the debug log, which isn't great in its own right: according to the log, we just get disconnected. No error message is received.
19:55:34 <qheaden> aleth: That's very strange. When I tested with an @yahoo.com domain, it gave me an invalid username error, and stopped the sign-in process.
19:55:55 <aleth> qheaden: I could reproduce with a yahoo.co.uk account.
19:56:22 <qheaden> aleth: Did you try it using the libpurple Yahoo?
19:56:44 <aleth> qheaden: No, I'm locked out of all my yahoo accounts now :P
19:56:49 <qheaden> :(
19:57:06 <qheaden> Let me try with a yahoo.com account.
19:57:26 <-- aleth has quit (Quit: Ciao)
19:59:20 --> aleth has joined #instantbird
19:59:20 * ChanServ sets mode +h aleth 
19:59:54 <flo-retina> nhnt11: from reading quickly the above discussion, it sounds like you really need the profiler
20:00:30 <nhnt11> Yeah..
20:00:49 <flo-retina> nhnt11: also, if the only thing that prevents you from starting the work on the ranking is that LIST results are sluggish on freenode, what about just landing the LIST stuff pref'ed off until we debug/optimize it, and start working on ranking while we/I fix the profiler?
20:01:41 <nhnt11> I think I've narrowed it down to something in the Array.filter call... Everything that is printed to the error console before that is cleared.
20:01:45 <nhnt11> flo-retina: Ok, sounds good.
20:04:14 <aleth> I agree, I already suggested getting that code up for review before worrying about performance.
20:05:23 <flo-retina> aleth: I saw that. My point is that we should not just get the patch in bugzilla, but actually land it if we don't want bitrot with the ranking stuff.
20:05:36 <aleth> Though if nhnt11 is finding the unexpected already, the investigation was useful...
20:05:44 <aleth> flo-retina: Sure! :)
20:05:54 <nhnt11> I strongly suspect that splicing while filtering may be a problem
20:05:55 <aleth> My hope was that it could land this weekend
20:06:01 <nhnt11> because it requires shifting the array multiple times.
20:06:10 <flo-retina> nhnt11: pastebin that part of the code please :)
20:06:14 <nhnt11> Ok.
20:06:46 * flo-retina hasn't looked at Instantbird code in a week, and misses some context
20:07:03 <nhnt11> Well.. assuming Array.filter uses splice(). That was a bad assumption sorry. I replaced the filter with a manual for loop filter that does use splice, and got the same results.
20:07:45 <nhnt11> Here's the for loop version: http://pastebin.instantbird.com/269876
20:08:12 <nhnt11> The filter() version: http://pastebin.instantbird.com/269877
20:09:18 <nhnt11> Hmm, filter() creates a new array so slice can't be the problem...
20:10:01 <aleth> Are you actually sure its' that block of code that is the slow part?
20:11:06 <nhnt11> It isn't technically slow, but there seems to be some sort of garbage collection going or something during it that's causing the error console to be cleared.
20:11:17 <nhnt11> (The garbage collection thing is a wild guess, don't hold me to it)
20:11:39 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2667 on bug 2083.
20:11:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
20:11:43 <flo-retina> "error console to be cleared"?
20:11:48 <flo-retina> are you looking at the "error" tab?
20:11:52 <aleth> The error console clearing is a very strange symptom. Never heard of that before :-S
20:12:26 <flo-retina> the error console keeps the last N messages, so if plenty of stuff gets logged in a category you aren't looking at, stuff in the category you are looking at disappears
20:13:15 <flo-retina> nhnt11: what's the point of the "c.lowerCaseName.startsWith(aFilterStr) ||" part in the test?
20:13:51 <nhnt11> It checks if the display name of the possible conv starts with the given filter string :S
20:14:00 <nhnt11> I don't understand the question, sorry
20:14:39 <aleth> I assumed it was there as an attempt to avoid having to split ?
20:15:27 <nhnt11> Oh that way.
20:15:28 <nhnt11> Yes.
20:15:41 <nhnt11> More than that, it's to make sure that if you type "John smith", then it will still match
20:15:51 <flo-retina> ah, ok
20:15:52 <nhnt11> Because neither word matches the whole sentence.
20:16:35 <flo-retina> I think that would be worth a short comment
20:16:51 <flo-retina> although I think we want to handle spaces in filter strings differently eventually
20:17:05 <aleth> That code should go away once the ranking database exists anyway.
20:17:24 <aleth> Ultimately, like the awesomebar, we should match substrings too.
20:18:02 <nhnt11> yeah
20:18:43 <flo-retina> and be awesome ;)
20:20:16 * nhnt11 facepalms
20:20:18 <nhnt11> very hard
20:20:22 <nhnt11> I found the problem
20:20:35 <nhnt11> It was the TypeError with the lowerCaseName getter
20:20:36 <flo-retina> ah?
20:20:49 <nhnt11> There were a ton of them
20:20:56 * nhnt11 is very annoyed
20:21:00 <aleth> So flo was right? ;)
20:21:01 <flo-retina> and throwing lots of errors was very slow? :)
20:21:05 <nhnt11> Yeah
20:21:18 <nhnt11> Yay
20:21:21 <nhnt11> It's all snappy again
20:21:22 <nhnt11> :D
20:21:36 <aleth> I thought that fix landed?
20:22:17 <flo-retina> nhnt11: that happened to my code too. And unfortunately, I wasn't the one testing it. My code was reported as extremely slow by the profiler. And it turned out the profiler was throwing errors while profiling my code... and 90% of the time was spent reporting the errors of the profiler.
20:22:37 <aleth> flo-retina: Oh no.
20:22:45 <nhnt11> So it turns out
20:22:50 <nhnt11> Freenode is no longer super slow 
20:22:50 <nhnt11> :D
20:22:55 <flo-retina> nhnt11: \o/
20:23:05 <aleth> nhnt11: :D
20:23:10 <nhnt11> It's not the snappiest
20:23:13 <nhnt11> but... not painful
20:23:15 <flo-retina> so maybe I should got to bed instead of fixing the profiler? (I was getting started on it...)
20:23:20 <flo-retina> *go
20:23:23 <aleth> flo-retina: That must have taken some time to figure out ;)
20:23:37 <nhnt11> So I guess I learned something today...
20:23:38 <flo-retina> it just took some time to convince people it wasn't my fault ;)
20:23:42 <nhnt11> Heh
20:23:57 <flo-retina> aleth: and actually, it wasn't the profiler's fault either. Just a bug in the addon sdk. (grr)
20:24:10 <aleth> grr indeed.
20:29:19 <flo-retina> pfff, git :(
20:33:18 <-- qlum has quit (Ping timeout)
20:33:40 --> qlum has joined #instantbird
20:36:37 <instantbot> clokep@gmail.com denied review for attachment 2667 on bug 2083.
20:36:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
20:46:49 * nhnt11 thinks a patch is nearly ready
20:46:58 <nhnt11> This took too long :(
20:48:48 <aleth> Well, you discovered another reason why we try to fix warnings ;)
20:49:32 <nhnt11> :)
20:52:07 * aleth is puzzled by http://lxr.instantbird.org/instantbird/source/instantbird/components/ibConvStatsService.js#162 given http://hg.instantbird.org/instantbird/rev/9deb70968e96
20:53:50 <nhnt11> aleth: I was puzzled too :-/
20:54:13 <aleth> Checkin failure?
20:55:32 <nhnt11> It seems fine here: http://hg.instantbird.org/instantbird/file/9deb70968e96/instantbird/components/ibConvStatsService.js#l161
20:56:06 <aleth> Right, but my "latest" nightly also doesn't have it.
20:56:55 * nhnt11 has no clue.
20:57:45 <aleth> ^^ flo-retina
20:58:43 <nhnt11> aleth: Do you have any ideas for where to put the participant count in the ui?
20:58:49 <nhnt11> I forgot to do that
20:59:05 <nhnt11> #instantbird (xx)? Or (xx) Ask about Instantbird....?
20:59:13 <aleth> nstead of the little MUC icon on the right maybe? :D
20:59:23 <aleth> Use the styling from the blist.
20:59:39 <flo-retina> maybe lxr is only updated once a day and the checkin happened after the update?
20:59:46 <nhnt11> The blist doesn't show participant counts from what I se...
20:59:50 <nhnt11> see*
21:00:21 <aleth> flo-retina: Then the checkin must also have happened after\ the last nightly build
21:01:20 <aleth> nhnt11: Ah, you are right of course. I meant the unread counter
21:01:40 <aleth> But my suggestion isn't ideal, just maybe something we can use for now.
21:02:01 <aleth> Or you could overlay the number over the big icon on the left somehow.
21:02:07 <flo-retina> aleth: yes, the push was around 5:50am, nightlies start at 4:10am
21:02:21 <nhnt11> aleth: That's an interesting idea...
21:02:22 <aleth> flo-retina: OK, mystery solved then :)
21:02:55 <aleth> The web interface never shows the push date/time.
21:04:39 <nhnt11> i'll be back in a bit.
21:06:34 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2668 on bug 2083.
21:06:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
21:07:36 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2669 on bug 2083.
21:12:31 <instantbot> clokep@gmail.com granted review for attachment 2668 on bug 2083.
21:12:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
21:13:42 --> Mnyromyr has joined #instantbird
21:13:44 <qheaden> aleth: I see clokep r+'d my patch, so if it gets checked in soon, your issue should be fixed in the next nightly.
21:13:50 <qheaden> aleth: Thanks for finding that one! :)
21:14:02 <instantbot> clokep@gmail.com denied review for attachment 2669 on bug 2083.
21:14:30 <aleth> qheaden: Thanks
21:19:25 <flo-retina> aleth: you can see the time on http://buildbot.instantbird.org/waterfall
21:20:14 <aleth> flo-retina: Where do you see the last checkin time on that?
21:20:31 <flo-retina> first column has time, second has checkins
21:20:41 <aleth> aha!
21:20:49 <aleth> Thanks, I never noticed that column before :D
21:21:17 <aleth> (the 'changes' one)
21:24:04 --> EionRobb has joined #instantbird
21:26:10 <flo-retina> uh, code using the add-on sdk can't access Components.* directly :(
21:27:22 <Mook_as> yeah, you need to require("chrome") I think
21:27:29 <Mook_as> that has Cc, Ci, Cu, etc.
21:27:41 <flo-retina> yeah
21:27:42 <-- aleth has quit (Quit: Ciao)
21:28:06 <flo-retina> it's still not clear to me in which case the "sdk" is easier to use than a regular add-on
21:28:40 <Mook_as> me neither. maybe trying to port chrome extensions over? (hypothesis only, I don't have any chrome extensions to port)
21:37:50 <flo-retina> Mook_as: if I openDialog("http://people.mozilla.com/~bgirard/cleopatra/") from the error console, that window never appears
21:37:56 <flo-retina> it's listed in the "Window" menu on Mac though.
21:38:04 <flo-retina> any idea of what could be causing that?
21:38:25 <-- mconley has quit (Input/output error)
21:40:16 <flo-retina> if I click on the window's item in the Window menu, I get this error: JavaScript error: chrome://global/content/macWindowMenu.js, line 29: aWindow.document.commandDispatcher is undefined
21:40:20 <Mook_as> is it perhaps 0x0 ?
21:41:47 <flo-retina> the window has a DOM (I can inspect it with DOM Inspector)
21:43:48 <flo-retina> that JS error seems to be for all HTML windows. (If I open about:credits in a dialog, I get the same error when clicking on the "Our contributors" item of the Window menu). The credits get displayed correctly though :-S.
21:56:37 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2670 on bug 2083.
21:56:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
22:00:01 <qheaden> I have to leave now.
22:00:05 <qheaden> Bye everyone.
22:00:27 * qheaden is now known as qheaden_away
22:06:09 <instantbot> clokep@gmail.com denied review for attachment 2670 on bug 2083.
22:06:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2083 nor, --, ---, qheaden, ASSI, Account created with username@yahoo.* instead of username is handled badly
22:10:52 <-- EionRobb has quit (Ping timeout)
22:10:55 --> EionRobb has joined #instantbird
22:12:21 <-- qlum has quit (Quit: Getting the <censored> out.)
22:20:57 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2648 on bug 2066.
22:20:58 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2671 on bug 2066.
22:20:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
22:22:09 <flo-retina> http://i4.minus.com/iJo3yhGVomWvM.png (or http://people.mozilla.com/~bgirard/cleopatra/#report=0f4cce0cdc5389758f35f0cfc1430e90cae294c7) :-)
22:24:17 <nhnt11> flo-retina: Awesome!
22:24:33 * nhnt11 doesn't know how much/what kind of work that must have taken.
22:29:27 <flo-retina> not too terrible
22:29:32 <flo-retina> but you don't need it any more, right? ;)
22:30:10 <nhnt11> I might at some point -_-'
22:35:27 <flo-retina> yeah, that seems likely
22:35:39 <flo-retina> I should stop playing with this and go to bed.
22:35:49 * nhnt11 yawns.
22:35:50 <flo-retina> the results I get are pointless anyway, as I'm running a debug build.
22:35:55 <nhnt11> hah
22:35:55 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2672 on bug 2066.
22:35:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
22:41:44 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:43:45 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2671 on bug 2066.
22:43:46 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2673 on bug 2066.
22:43:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms
22:43:54 * nhnt11 goes to bed.
22:43:56 <nhnt11> Good night.
22:44:01 <flo-retina> Good night :)
22:45:41 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:37:02 --> wnayes has joined #instantbird