All times are UTC.
00:06:34 <-- dew has quit (Ping timeout) 00:12:50 --> dew has joined #instantbird 00:30:43 <qheaden> clokep: Looking at the libpurple code, it seems that buddy icons are requested through the pager server, not the profile page. I guess that's why its still working. 00:37:06 <clokep> qheaden: Yes, that doesn't surprise me ;) 00:38:43 <qheaden> clokep: Sadly, it seems that alias are also linked with Yahoo profiles now. 00:38:46 <-- wnayes has quit (Ping timeout) 00:38:48 <qheaden> *aliases 00:40:06 --> wnayes has joined #instantbird 01:13:30 <clokep> qheaden: That stinks. :( 01:13:39 * clokep wonders what's left that we can even do then. 01:14:58 <-- Mook_as has quit (Quit: Mook_as) 01:23:37 <clokep> qheaden: I'm getting rid of this "features added to Bugzilla" category on the etherpad, if you file bugs just put the bug number next to it in parenthesis. 01:23:41 <clokep> That's more useful information 01:32:34 <qheaden> clokep: Okay. 01:41:03 <qheaden> Well, I'm going to head in for the day. I'll work some more tomorrow. Enjoy your trip clokep. 01:41:09 <clokep> qheaden: Bye. 01:41:09 <-- rosonline has quit (Connection reset by peer) 01:41:18 * qheaden is now known as qheaden_away 01:51:27 --> jb has joined #instantbird 02:04:21 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:05:12 <-- jb has quit (Quit: jb) 02:24:31 --> jb has joined #instantbird 02:33:04 --> Mook has joined #instantbird 02:38:41 <-- wnayes has quit (Ping timeout) 02:42:22 --> wnayes has joined #instantbird 02:43:21 <-- wnayes has quit (Quit: wnayes) 02:54:23 --> mconley has joined #instantbird 03:02:24 <-- jb has quit (Ping timeout) 03:15:16 <instant-buildbot> build #925 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/925 03:18:21 <instant-buildbot> build #925 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/925 03:41:16 <-- mconley has quit (Input/output error) 04:23:26 --> nhnt11 has joined #instantbird 04:56:07 <-- nhnt11 has quit (Ping timeout) 05:03:24 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:15:09 --> Tonnes has joined #instantbird 05:19:01 --> FireFly_TB has joined #instantbird 06:03:44 <instant-buildbot> build #1021 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1021 06:22:42 <-- Mook has quit (Quit: Mook) 06:44:56 <-- FireFly_TB has quit (Quit: FireFly_TB) 07:26:37 <-- EionRobb has quit (Quit: Leaving.) 08:34:50 <-- sabret00the_ has quit (Connection reset by peer) 08:35:15 --> sabret00the_ has joined #instantbird 09:17:26 --> aleth has joined #instantbird 09:17:26 * ChanServ sets mode +h aleth 09:22:06 --> mpmc has joined #instantbird 09:36:30 --> qlum has joined #instantbird 09:53:58 --> nhnt11 has joined #instantbird 09:54:11 <nhnt11> Hi 09:55:51 <-- nhnt11 has quit (Ping timeout) 10:04:24 --> nhnt11 has joined #instantbird 10:06:54 <-- nhnt11 has quit (Ping timeout) 10:09:01 --> nhnt11 has joined #instantbird 10:12:21 <-- nhnt11 has quit (Ping timeout) 10:20:38 --> nhnt11 has joined #instantbird 10:23:08 <-- skeledrew has quit (Ping timeout) 10:24:17 --> skeledrew has joined #instantbird 10:25:13 <-- Optimizer has quit (Ping timeout) 10:32:29 <aleth> nhnt11: How's things? 10:32:44 <aleth> Any chance of getting some of those followup bugs fixed? ;) 10:33:00 * aleth has an error console full of newtab spam 10:33:11 <-- nhnt11 has quit (Ping timeout) 10:58:10 <-- qlum has quit (Ping timeout) 10:58:32 --> qlum has joined #instantbird 11:04:20 --> nhnt11 has joined #instantbird 11:05:46 <nhnt11> aleth: Errors? :o 11:06:03 <nhnt11> I haven't seen any :( 11:06:06 <aleth> Check your bugmail :P 11:06:12 <nhnt11> Checking 11:06:34 <nhnt11> Re-checking, rather 11:07:07 <nhnt11> aleth: Is this about that TypeError with the getter? 11:08:10 <aleth> nhnt11: https://i.minus.com/jbqFaWpxLgjtyb.png 11:08:41 <aleth> and that's not the only followup... ;) 11:08:49 <nhnt11> Yeah 11:08:56 * nhnt11 gets to work. 11:18:52 <nhnt11> aleth: I can't reproduce the TypeError :S 11:19:32 <aleth> That's very strange. 11:19:54 <nhnt11> I even did an hg pull to be sure I'm on the latest code. 11:19:57 <aleth> Do you have the js-strict pref set? 11:20:03 <nhnt11> I do afaik 11:20:08 <nhnt11> Let me double check 11:20:27 --> nhnt11-testing has joined #instantbird 11:20:47 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:20:54 <-- sabret00the_ has quit (Connection reset by peer) 11:20:55 <nhnt11> Ah, it was off. 11:21:20 --> sabret00the_ has joined #instantbird 11:21:29 <nhnt11> Still no errors.. 11:21:31 <aleth> Mic put a minimal example in the bug report afaik\ 11:22:18 <nhnt11> Ah, got the error now 11:24:38 <aleth> Do you understand what's causing it? 11:25:38 <-- nhnt11 has quit (Ping timeout) 11:27:27 --> nhnt11 has joined #instantbird 11:28:02 <nhnt11> aleth: I'm not totally sure 11:28:12 <nhnt11> the delete line should've taken care of it 11:31:23 <aleth> There's two issues here, one is the fact that something in the prototype is not the own property of the object. The other is that what Mic suggested is a bit of a hack for "overwriting" what previously used the getter/setter mechanism with a straightforward property. 11:33:39 <nhnt11> I understand the second part 11:34:18 <nhnt11> I'm not sure I fully understand "Something in the prototype is not the own property of the object" though. 11:34:23 <nhnt11> Ah 11:35:15 <aleth> delete this.x deletes the property x in the object which reactivates the property of the same name in the prototype if it exists. 11:35:50 <nhnt11> Deep stuff :D 11:36:15 <aleth> Well, you've used https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty already ;) 11:36:30 <nhnt11> That means this whole thing shouldn't work at all. I guess the return statement is returning the this._displayName.toLowerCase() without actually assigning it 11:36:40 <nhnt11> Thereby making the whole "lazy getter" redundant 11:37:08 <aleth> It's assigning it, but the getter wasn't deleted. 11:37:31 <aleth> And so there is an error because if there's a getter, there's supposed to be a setter if you make an assignment. 11:37:49 <nhnt11> But setting still works even without a setter? 11:38:04 <nhnt11> I suppose that's why it's only a strict mode warning and not a full error.. 11:38:26 <aleth> So yeah, the whole idea just doesn't work well in this case. 11:38:36 <nhnt11> Right so I'll just revert to the original way 11:39:00 <aleth> The setting "works" but the getter never gets removed. 11:39:19 <nhnt11> Got it. 11:41:19 <nhnt11> Sorry for being offline yesterday 11:41:24 <nhnt11> (by the way) 11:42:38 <aleth> Most of us will be away next week so it's important you all get yourselves unblocked before that for what you plan to do then. 11:43:06 <nhnt11> Ok. 11:46:24 <aleth> Actually, from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/get it appears the assignment fails due to the presence of the getter. 11:47:31 <aleth> Even if the getter is in the prototype. 11:48:57 <-- nhnt11 has quit (Ping timeout) 11:49:11 --> nhnt11 has joined #instantbird 11:50:51 <-- nhnt11 has quit (Ping timeout) 11:51:02 --> nhnt11 has joined #instantbird 11:51:10 <nhnt11> That's what I expected. 11:51:56 <aleth> Yes, it makes sense. I thought the fact that it was js-strict only meant the assignment would be carried out, but ignored due to the getter, but then that would be inconsistent. 11:52:42 <aleth> So I looked it up ;) 11:54:07 <nhnt11> :) 11:58:55 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2655 on bug 2075. 11:58:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2075 nor, --, ---, nhnt11, ASSI, TypeError: setting a property that has only a getter 12:03:19 <-- nhnt11 has quit (Ping timeout) 12:04:00 <instantbot> aleth@instantbird.org granted review for attachment 2655 on bug 2075. 12:04:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2075 nor, --, ---, nhnt11, ASSI, TypeError: setting a property that has only a getter 12:04:13 --> nhnt11 has joined #instantbird 12:21:25 <nhnt11> aleth: Do you know how to assign click/double click events to an existing command? 12:21:28 <nhnt11> Other than goDoCommand 12:21:55 <nhnt11> (The global overlay isn't included in the conversation window and I'm not sure whether it's the right idea to include it now or not) 12:22:28 <nhnt11> This is for bug 2065 btw 12:22:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 12:23:43 * nhnt11 goes to look at firefox's code 12:25:35 <aleth> Why does command="cmd_newtab" on the newtab button work but goDoCommand fail? 12:26:08 <nhnt11> aleth: goDoCommand is defined in globalOverlay.js 12:26:19 <nhnt11> So the function is missing 12:28:49 <-- nhnt11 has quit (Ping timeout) 12:29:50 <aleth> This is in toolkit, right? 12:30:07 <aleth> Is there any reason not to include that file in the conversation window on all OS? 12:30:36 --> nhnt11 has joined #instantbird 12:30:43 <nhnt11> Yeah it's in toolkit 12:30:46 <nhnt11> It's not included in any OS in the conv window 12:30:52 <nhnt11> It's included in all of them in menus.xul 12:31:02 <nhnt11> But on mac, menus is included in /every/ window 12:31:03 <nhnt11> So 12:31:06 <nhnt11> Kinda weird 12:31:46 <nhnt11> I think I found a fix 12:32:12 <aleth> I don't know the background to that, so I'm not going to suggest anything. flo would be the person to ask. 12:32:13 <nhnt11> I can set the command attribute of tabbrowser-strip to "cmd_newtab" and then use doCommand() in click and dblclick 12:32:27 <aleth> That sounds hackish. 12:32:46 <nhnt11> Why? 12:33:04 <nhnt11> Well.. maybe. 12:33:05 <aleth> You'd also have to check whether the command is enabled and at that point you are pretty much reimplementing goDoCommand. 12:33:39 <aleth> I'd say leave that for now and ask flo when he is next around. 12:33:52 <nhnt11> Ok then. 12:35:05 <aleth> I'm just not sure whether what you suggest is the best way to do it, or whether it would be cleaner to just include globalOverlay.js. 12:35:32 <-- nhnt11 has quit (Ping timeout) 12:36:16 --> nhnt11 has joined #instantbird 12:36:26 * nhnt11 finds bug 2042 weird. 12:36:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nobody, NEW, Starting conversations on unrelated keyboard- or mouse-events 12:37:18 <aleth> I can't reproduce that. 12:38:06 <-- nhnt11 has quit (Ping timeout) 12:38:18 <aleth> Looks like it would require some debugging on Windows. 12:44:06 --> nhnt11 has joined #instantbird 12:47:39 <-- nhnt11 has quit (Ping timeout) 12:50:55 --> nhnt11 has joined #instantbird 12:51:54 <nhnt11> Yeah.. 12:52:38 <aleth> Maybe Mic can tell you what event handler is actually being called. 12:53:34 <-- nhnt11 has quit (Ping timeout) 12:54:13 --> nhnt11 has joined #instantbird 12:54:21 <nhnt11> aleth: What? 12:54:26 <nhnt11> The correct event handler is being called 12:54:32 <nhnt11> click/dblclick 12:54:42 <nhnt11> I'm probably misunderstanding 12:55:21 <aleth> If I click on the titlebar, I don't expect an onclick handler on the richlistbox to fire ;) 12:58:17 <nhnt11> Oh, I was thinking of the wrong bug 12:58:18 <nhnt11> :P 12:58:38 <nhnt11> I'm not even sure that bug still exists anymore 12:58:47 <nhnt11> considering event handlers have changed.. 13:19:43 <nhnt11> I'll be back later tonight. 13:19:46 <nhnt11> Bye 13:19:52 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:43:23 --> jb has joined #instantbird 13:52:08 --> mconley has joined #instantbird 14:06:52 <-- qlum has quit (Ping timeout) 14:07:14 --> qlum has joined #instantbird 14:10:16 <-- jb has quit (Ping timeout) 14:13:44 --> nhnt11 has joined #instantbird 14:13:47 <-- nhnt11 has quit (Input/output error) 14:15:35 --> jb has joined #instantbird 14:19:18 <-- sabret00the_ has quit (Quit: Leaving) 14:45:22 <-- jb has quit (Ping timeout) 15:32:25 * qheaden_away is now known as qheaden 15:32:37 <qheaden> Hello everyone. 16:14:44 <-- qlum has quit (Ping timeout) 16:15:06 --> qlum has joined #instantbird 16:26:52 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:32:41 <qheaden> How are buddy icons set? 16:34:35 <qheaden> Nevermind. I found a method in GenericAccountBuddy. 16:48:32 --> nhnt11 has joined #instantbird 16:49:16 <qheaden> Cool. I got buddy icons showing for Yahoo! :) 16:53:43 <aleth> :) 16:54:12 --> atuljangra has joined #instantbird 16:55:49 --> Mook_as has joined #instantbird 16:56:06 --> rosonline has joined #instantbird 17:06:45 --> clokep_wp8 has joined #instantbird 17:07:07 * clokep_wp8 wants to see the code. 17:07:23 <clokep_wp8> qheadrn ^ 17:07:32 <clokep_wp8> qheaden, rather 17:08:20 <-- clokep_wp8 has quit (Connection reset by peer) 17:43:49 --> Mic has joined #instantbird 17:43:49 * ChanServ sets mode +h Mic 17:45:39 <Mic> nhnt11: I'm still seeing bug 2042 :( 17:45:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nobody, NEW, Starting conversations on unrelated keyboard- or mouse-events 17:45:53 <Mic> I'll try on Win7 later and see if I can reproduce it there. 17:47:26 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 17:48:15 --> Mic has joined #instantbird 17:48:15 * ChanServ sets mode +h Mic 17:48:23 <nhnt11> Mic: :( 17:48:28 <nhnt11> Let me try.. 17:49:51 --> nhnt12 has joined #instantbird 17:51:12 <nhnt12> Mic: It's happening in Win8 17:51:17 <Mic> :( 17:51:46 <nhnt12> The enter key handler seems to be getting activated in the second case 17:51:56 <nhnt12> as for the double click case, I have no clue 17:52:07 <Mic> With current OS' it's definitely not WONTFIX in my opinion. 17:52:17 <nhnt12> Yeah 17:55:12 <qheaden> Gah! Missed clokep 17:55:38 <nhnt12> Btw, Mic, double clicking to maximize isn't opening a conv with the first item in the list 17:55:42 <qheaden> clokep: Whenever you come back, I'm still working things out. 17:55:50 <nhnt12> it's opening a conv with the item right under the mouse, after the maximize happens 17:55:57 <Mook_as> qheaden: memoserv? :D 17:55:57 <nhnt12> That actually makes more sense. 17:56:09 <qheaden> Mook_as: Completely forgot about that. :P 17:57:56 <qheaden> nhnt11: Out of curiosity, how does one activate awesometab? 17:58:15 <nhnt11> qheaden: Er, Ctrl+t or click the "+" button 17:58:22 <qheaden> Okay. 17:59:04 <qheaden> nhnt11: Wow! Cool stuff! :) 17:59:20 <nhnt11> Thanks :) 17:59:47 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:59:57 --> nhnt12 has joined #instantbird 18:00:17 * qheaden should start using the nightly Instantbird on a regular basis. 18:01:01 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 18:01:57 <nhnt11> Mic: Does it still do the jumping thing for you when you are scrolling down the list using the down key? 18:02:19 <nhnt11> I thought I fixed that (it doesn't happen on Mac) but it just happened on Windows for me :( 18:02:47 <aleth> nhnt11: Maybe if you fix bug 2048 it will fix that Windows issue automatically 18:02:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2048 nor, --, ---, nobody, NEW, Click on awesometab when window is unfocused should not open conversation 18:02:56 <qheaden> nhnt11: Is it ever possible to open awesometab without opening a buddy conversation first? 18:03:06 <nhnt11> qheaden: yes. 18:03:11 <nhnt11> From the buddy list, Ctrl+t 18:03:22 <nhnt11> or File.. New Conversation 18:03:31 <nhnt11> I should file a bug for Ctrl+N... 18:03:33 <qheaden> Gotcha. Thanks. 18:03:46 <nhnt11> aleth: Hmm. Maybe. 18:04:03 <nhnt11> But the window still has focus during the scenarios in 2042. 18:04:22 <aleth> nhnt11: Yeah, but if you check that the richlistbox or filterlist has focus then it might help.\ 18:04:29 <qheaden> nhnt11: Finally, I see that Ctrl-t doesn't work if no account is connected. Is this intentional? 18:04:53 <nhnt11> Very weird, my nightly on windows just updated, and I thought it was latest.. but it turns out it was from 2 weeks ago and is updating again 18:04:53 <nhnt11> :S 18:04:55 <qheaden> I'm asking because I'm trying to determine where in the code is best to request my buddy icons. 18:04:55 <nhnt11> qheaden: Yes. 18:05:08 <qheaden> Okay great. Thans. 18:05:10 <qheaden> *thanks 18:05:19 <nhnt11> What does awesometab have to do with that? :S 18:05:52 <qheaden> Just wondering if I needed to request buddy icons even when the account is logged off. 18:06:17 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:06:53 <nhnt11> If you say so :) 18:07:08 --> nhnt12 has joined #instantbird 18:07:18 <qheaden> :P 18:08:34 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:08:40 --> nhnt12 has joined #instantbird 18:12:07 <nhnt11> Instantbird is refusing to update on Windows :( 0 bytes of 20.8MB (0 bytes/sec) 18:14:47 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:14:53 --> nhnt12 has joined #instantbird 18:16:59 <nhnt11> Mic: You wanted Home and End to work only when the filterbox is empty right? 18:17:09 <nhnt11> Are there any other navigation keys that don't work properly? 18:19:55 <instantbot> New Instantbird (UI) bug 2081 filed by aleth@instantbird.org. 18:19:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, nobody, NEW, Pressing the up key in the top row of the newtab should refocus the filterbox 18:20:56 <qheaden> Hmm, with Awesometab it seems that buddy icons don't show next to their name unless I first open a conversation tab with them. 18:21:39 <nhnt11> qheaden: If these are facebook buddies, Facebook has been having some problems. 18:21:56 <qheaden> nhnt11: No, GTalk buddies. 18:22:05 <nhnt11> GTalk buddies are working fine for me :S 18:22:14 <qheaden> Hmm. 18:22:33 <qheaden> I see the icons next to the names, but they don't seem to show unless I open the conv window and then close it. 18:22:35 <qheaden> Weird. 18:23:02 <nhnt11> Here's cloke_p and he's not even online: http://puu.sh/3PyPP.png 18:23:23 * nhnt11 hates this kind of bug :( 18:23:30 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:23:38 --> nhnt12 has joined #instantbird 18:26:21 <nhnt11> Maybe Awesometab does need a bugzilla section so I can keep track of these followup bugs... 18:26:58 <aleth> Yep, there should be a section. Also for the log viewer. 18:27:39 <aleth> For now you can just look at the list of bugs in bug 2015 and bug 2055 18:27:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, 1.5, nhnt11, RESO FIXED, Display buddy list in a tab. 18:27:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab needs to display open conversations and those on hold. 18:28:03 <nhnt11> Can you or Mic add sections or can only clokep and flo do that? 18:28:14 <nhnt11> I guess. But there are more after 2055 as well... 18:28:29 <aleth> No idea, I certainly can't. 18:28:53 <aleth> Right, but they should all be marked as blocking 2055 or 2015 18:29:16 <nhnt11> Ah right. I noticed you did that for quite a few of them, thanks a lot. 18:29:23 * nhnt11 should have done that.... 18:29:26 <aleth> We generally do this for followups. 18:31:35 <Mic> nhnt11: No (Does it still do the jumping thing for you when you are scrolling down the list using the down key?) 18:31:58 <nhnt11> Mic: Right, turns out my nightly updated but not to the latest. It's fine now :) 18:33:25 <Mic> nhnt11: I can't edit components on BIO, sorry. 18:35:43 <Mic> "You wanted Home and End to work only when the filterbox is empty right?", not necessarily. Maybe forwarding the keys also when the text cursor is already at start or end of the textbox might work too? That's maybe even something I would like to try to see if it's working intuitively. 18:36:16 <qheaden> nhnt11: Even stranger, the icons seem to disappear when I type in a filter. :-S 18:36:21 <qheaden> Maybe I need to rebuild. 18:36:54 * nhnt11 has no idea. 18:37:01 <qheaden> lol 18:37:11 <nhnt11> Mic: Hmm. I can't comment too much since I don't have any of those keys :S 18:37:31 <nhnt11> Nor did I use them when back when I was using windows... but that's just me of course. 18:43:12 <Mic> nhnt11: just forward the keys when the input box is empty. 18:43:25 <Mic> I could still try that with an add-on if I like. 18:44:39 <nhnt11> Mic: How about I give you a patch, and if it feels fine I'll upload it on BIO? :) 18:45:33 <Mic> No, that's not necessary. 18:45:44 * qheaden goes for a full rebuild. 18:46:15 <nhnt11> ok 18:46:23 <nhnt11> qheaden: On windows? Ouch :P 18:46:27 <Mic> qheaden: http://xkcd.com/303/ ? ;) 18:46:55 <-- aleth has quit (Quit: Ciao) 19:00:27 <nhnt11> be back in a bit. 19:02:01 <-- nhnt12 has quit (Ping timeout) 19:02:07 <-- nhnt11 has quit (Ping timeout) 19:28:54 <qheaden> I'll be back in a bit. 19:28:57 * qheaden is now known as qheaden_away 19:31:15 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 19:31:23 --> rosonline has joined #instantbird 19:35:56 <-- qlum has quit (Ping timeout) 19:36:18 --> qlum has joined #instantbird 20:18:48 --> Mnyromyr has joined #instantbird 20:19:53 --> nhnt11 has joined #instantbird 20:45:32 --> flo-retina has joined #instantbird 20:45:32 * ChanServ sets mode +qo flo-retina flo-retina 20:48:58 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:49:06 --> nhnt11 has joined #instantbird 20:54:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:54:28 --> nhnt11 has joined #instantbird 20:55:08 <flo-retina> qheaden_away: at http://hg.instantbird.org/instantbird/rev/8cdc81c96b7d#l2.14 it would be nice to have a comment explaining what %S will be replaced with. Is it a number? An error code? A human-readable string? Should there be a ": " before the %S? Or quotes around it? (these are questions localizers will need to answer; the point of a localization note is to help answer that kind of questions) 20:55:31 --> EionRobb has joined #instantbird 20:55:42 <flo-retina> qheaden_away: http://hg.instantbird.org/instantbird/rev/8cdc81c96b7d#l2.29 the notion of "account proxy" doesn't exist at all for prpls in JS, so we should just remove that option completely. 21:08:44 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2656 on bug 2076. 21:08:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2076 nor, --, ---, nhnt11, ASSI, Offline contacts no longer appear with reduced opacity 21:18:05 <nhnt11> Is there an easy way to tell if a window had focus before the click, within a click event handler? 21:22:14 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:22:31 <nhnt11> Mic: Btw, could you look at the patch on bug 2051? 21:22:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, ---, nhnt11, ASSI, Styling of new conversation listbox 21:28:16 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2657 on bug 2068. 21:28:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2068 min, --, ---, nhnt11, ASSI, Mobile icon missing on items of new conversation tab 21:29:44 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 21:31:26 <-- qlum has quit (Client exited) 21:32:31 <instantbot> benediktp@ymail.com granted review for attachment 2634 on bug 2051. 21:32:32 --> Mic has joined #instantbird 21:32:33 * ChanServ sets mode +h Mic 21:32:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, ---, nhnt11, ASSI, Styling of new conversation listbox 21:34:41 <Mic> Does putting a conversation from nickserv/memoserv on hold also break the new conv tab for you? 21:35:09 <Mic> http://pastebin.instantbird.com/267255 21:37:10 <nhnt11> Yeah :( 21:37:17 <flo-retina> Mic: I think it's "a conversation with someone not in your buddy list" ;) 21:37:32 <flo-retina> seems like it's just a missing null check 21:37:40 <Mic> Eventually it's that, yes. 21:37:42 <nhnt11> Yeah. 21:37:59 <nhnt11> fyi i'm attaching a new patch to 2076 21:40:29 <flo-retina> btw, I'm at home (so close to a computer with Internet access), but still on holiday (so likely not going to be online more than once or twice a day), and I already have plenty (200+) of unread email/bugmail, so I'm unlikely to catch up with them soon. If some review really deserves some attention sooner than next week, don't hesitate to mention it when I'm around ;) 21:41:44 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2656 on bug 2076. 21:41:45 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2658 on bug 2076. 21:41:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2076 nor, --, ---, nhnt11, ASSI, Offline contacts no longer appear with reduced opacity 21:41:51 <nhnt11> flo-retina: Sure. I just sent a review request your way ;) 21:41:56 <nhnt11> Not too important though.. 21:43:13 <nhnt11> flo-retina: Oh yeah, I wanted to ask you about bug 2065. Is it too hackish to set the command attribute of tabbrowser-strip to cmd_newtab, and then do ondblclick="doCommand()" (as well as for middle click)? 21:43:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2065 nor, --, ---, nhnt11, NEW, Double and middle-clicks on the tab bar should open new conversation tab 21:43:57 <flo-retina> nhnt11: you have a "<xul:hbox flex="1">" element that contains everything in that binding (I would usually say that it should be removed if there's not a good reason to have it), can't you put the opacity on that instead of on the list item, to keep the highlight as usual? 21:44:16 <flo-retina> (just a random thought, I haven't tried the patch to see if the partially transparent highlight is an issue) 21:44:32 <nhnt11> I actually didn't know whether to keep the slightly faded highlight or not 21:44:37 <nhnt11> I think not actually 21:44:44 <nhnt11> Let me try your idea. 21:45:47 <flo-retina> maybe screenshots would be helpful to decide if it looks good or bad? .) 21:45:49 <flo-retina> *;) 21:46:19 <nhnt11> Your idea works, but makes scrolling choppy again 21:46:21 <nhnt11> :-/ 21:47:00 <nhnt11> I'll post a screenshot in a second.. 21:47:26 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:47:29 --> nhnt11 has joined #instantbird 21:48:08 <nhnt11> flo-retina, Mic: http://puu.sh/3PIz6.png 21:48:23 <nhnt11> Maybe that needs comparison... 21:54:51 <instantbot> qheaden@phaseshiftsoftware.com requested feedback from clokep@gmail.com for attachment 2659 on bug 2070. 21:54:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2070 enh, --, ---, qheaden, NEW, Add Support for Buddy Icons 22:08:16 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2660 on bug 2078. 22:08:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2078 nor, --, ---, nhnt11, ASSI, Home/End in newtab filterbox don't work as expected 22:12:20 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:12:30 --> nhnt11 has joined #instantbird 22:12:51 <nhnt11> Mic: Are the Page up/down keys useful in awesometab? 22:13:13 <nhnt11> Hmm, I suppose they are. 22:24:53 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2661 on bug 2081. 22:24:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, nhnt11, ASSI, Pressing the up key in the top row of the newtab should refocus the filterbox 22:26:58 * nhnt11 is happy to get those follow ups out of the way (excluding review modifications but still) 22:28:21 <-- mconley has quit (Input/output error) 22:29:01 <nhnt11> flo-retina: Can we have a new BIO component for awesometab? It would help me keep track of followup bugs better 22:29:51 --> wnayes has joined #instantbird 22:29:59 <flo-retina> is the Instantbird::Conversations component not enough? 22:30:34 <nhnt11> I guess all the new Conversation bugs are awesometab related... 22:30:59 <nhnt11> ok then 22:31:13 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:31:20 --> nhnt11 has joined #instantbird 22:31:40 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 22:31:55 --> nhnt11 has joined #instantbird 22:32:32 <flo-retina> I'm not against creating a new component, but I'm just afraid the difference between "Conversation" and "New Conversation" may be confusing for people who are new to BIO 22:32:51 <nhnt11> Hmm good point 22:33:34 <instantbot> New Instantbird (UI) bug 2082 filed by nhnt11@gmail.com. 22:33:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2082 nor, --, ---, nobody, NEW, Error when opening a new conversation tab when a conversation exists with someone not on the buddy l 22:41:04 <Mic> nhnt11: if page down focuses the first item when the input box has focus, shouldn't page up do the opposite when the first item of the list is focused then? 22:41:20 <nhnt11> Doesn't it? 22:41:21 <nhnt11> oops 22:42:33 <Mic> I'll actually try it tomorrow :) 22:42:36 <Mic> Good night! 22:42:39 <nhnt11> Good night 22:43:10 <nhnt11> flo-retina: Which formatting do you prefer? http://pastebin.instantbird.com/267338 22:44:18 <flo-retina> the second one 22:44:33 <nhnt11> ok, thanks 22:44:54 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:47:41 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2662 on bug 2082. 22:47:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2082 nor, --, ---, nhnt11, ASSI, Error when opening a new conversation tab when a conversation exists with someone not on the buddy l 22:51:25 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2661 on bug 2081. 22:51:26 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2663 on bug 2081. 22:51:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2081 min, --, ---, nhnt11, ASSI, Pressing the up key in the top row of the newtab should refocus the filterbox 22:51:34 <nhnt11> Good night. 22:51:40 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 23:29:04 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)