All times are UTC.
00:16:17 * qheaden is now known as qheaden_away 00:51:45 <-- wnayes has quit (Ping timeout) 00:55:18 --> wnayes has joined #instantbird 00:58:28 <instant-buildbot> build #429 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/429 01:01:42 <-- Mook_as has quit (Quit: Mook_as) 01:14:33 <-- mconley has quit (Input/output error) 01:17:00 <-- dew has quit (Ping timeout) 01:38:16 --> dew has joined #instantbird 02:36:02 --> mconley has joined #instantbird 02:41:47 <-- mpmc has quit (Connection reset by peer) 02:51:31 <-- wnayes has quit (Ping timeout) 02:55:01 --> wnayes has joined #instantbird 03:06:14 <instant-buildbot> build #922 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/922 03:09:02 <-- mconley has quit (Input/output error) 03:29:22 <instant-buildbot> build #922 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/922 03:31:07 <-- wnayes has quit (Quit: wnayes) 03:31:12 --> wnayes has joined #instantbird 03:32:36 <-- wnayes has quit (Connection reset by peer) 03:32:41 --> wnayes has joined #instantbird 03:46:59 --> clokep has joined #instantbird 03:46:59 * ChanServ sets mode +o clokep 03:53:43 <clokep> Mic: Subject == topic. 03:53:53 <clokep> Mic: Use the hg bundles mozilla puts up, don't do a straight up clone. 03:57:51 <-- wnayes has quit (Quit: wnayes) 04:05:59 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:29:39 --> Mook has joined #instantbird 04:41:27 <-- sabret00the has quit (Ping timeout) 05:00:17 --> sabret00the has joined #instantbird 05:53:09 <instant-buildbot> build #1018 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1018 06:33:25 <-- Mook has quit (Quit: Mook) 07:34:32 --> nhnt11 has joined #instantbird 07:44:50 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 07:44:53 --> nhnt11 has joined #instantbird 07:45:20 <nhnt11> Aweometab is broken in the latest nightly 07:45:21 <nhnt11> :S 07:48:53 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 07:48:56 --> nhnt11 has joined #instantbird 07:49:13 <nhnt11> It works fine when I build from default branch though.. 08:13:53 --> Mic has joined #instantbird 08:13:53 * ChanServ sets mode +h Mic 08:14:56 <Mic> Hi 08:16:33 <nhnt11> Hi 08:17:00 <Mic> Good morning 08:17:21 <Mic> I'm already looking at your problem. It seems that the interface isn't defined... 08:17:28 <nhnt11> Yeah 08:17:37 <nhnt11> I think I need to add the xpt file to package manifest 08:17:39 <nhnt11> I was about to test that. 08:21:22 <Mic> It worked for you and clokep because you weren't trying the packaged but the 'flat' result of compiling? 08:21:36 <nhnt11> Yes 08:21:39 <nhnt11> Lesson learned :) 08:24:58 <Mic> clokep: why isn't it set as topic of the room on my screenshot then? :( http://log.bezut.info/instantbird/130727#m21, http://i5.minus.com/jf4fm5kfDZmTP.png 08:26:34 <Mic> You don't happen to have a working interfaces.xpt file for me? ;) 08:26:55 * nhnt11 doesn't know what that file is :S 08:29:08 <Mic> It's the result of all compiled interface files from what I know. 08:34:21 * nhnt11 can't find it 08:35:09 <Mic> Don't bother. 08:36:21 <Mic> OK, apparantely we receive a <message> stanza with subject and a body tag, while subject changes should only contain a subject tag and not body. 08:36:24 <Mic> http://pastebin.instantbird.com/262011 08:36:27 <Mic> http://xmpp.org/extensions/xep-0045.html#enter-subject 08:36:52 <Mic> I can't seem to find where the topic of MUCs is managed in our code though. Maybe it even isn't? 08:41:32 <nhnt11> One of my friends seems to be switching to Instantbird from Pidgin :) 08:41:34 --> FireFly_TB has joined #instantbird 08:57:57 <Mic> Today's nightly is more broken than I thought. The new conversation tab is gone from the tab bar but I can still Ctrl+Tab to it. :D 08:58:13 <nhnt11> yeah 08:58:21 <nhnt11> :( 08:58:43 <Mic> That's why it's a nightly and not a release build :P 08:58:57 <nhnt11> :P 08:59:11 * nhnt11 expects at least one person to complain on #instantbird 09:01:30 * Mic has a Facebook user icon for one of his contacts again. 09:01:33 <Mic> Surprise! 09:01:55 <-- gerard-majax_ has quit (Connection reset by peer) 09:02:00 --> gerard-majax__ has joined #instantbird 09:02:02 <Mic> For all of them as it seems :) 09:02:21 <Mic> Just appeared in mid-conversation. 09:02:22 <nhnt11> Mic: It works when you re-login 09:02:24 <nhnt11> wow 09:02:28 <nhnt11> Oh 09:02:29 <nhnt11> Still not working here 09:02:51 <Mic> And they're gone again :O 09:08:21 <-- nhnt11 has quit (Ping timeout) 09:08:37 <Mic> Bug 1527 09:08:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1527 nor, --, ---, nobody, NEW, Finish the implementation of basic MUC support in JS-XMPP 09:12:21 <Mic> qheaden_away: there's an error saying "No 'prpl-yahoo' protocol plugin" on my Yahoo account :( 09:23:44 --> nhnt11 has joined #instantbird 09:25:00 <-- Suiseiseki has quit (Ping timeout) 09:25:22 <nhnt11> Mic: Do you have any idea how to fix this broken nightly issue? :( 09:25:34 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:25:52 --> mpmc has joined #instantbird 09:26:12 --> nhnt11 has joined #instantbird 09:26:27 --> Suiseiseki has joined #instantbird 09:41:10 <Mic> Do you have a fix for the packaging problem that you said it is? 09:41:29 <nhnt11> That didn't work 09:43:19 <-- skeledrew has quit (Ping timeout) 09:43:32 --> skeledrew has joined #instantbird 09:46:50 <nhnt11> Mic: I got the idea from this: https://bugzilla.mozilla.org/show_bug.cgi?id=753142 09:48:05 <Mic> Do you have a diff of what you've tried? 09:48:51 <nhnt11> No, but what I did was add @BINPATH@/components/ibConvStatsService.xpt to instantbird/installer/package-manifest.in 09:50:03 <nhnt11> Ah, the xpt file isn't in the components directory 09:50:09 <nhnt11> So I guess I need to make it go there? 09:55:44 <nhnt11> Aha 09:57:20 <nhnt11> Mic: I fixed it 09:57:40 <nhnt11> I needed to add instantbird.xpt to package-manifest.in 10:00:24 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2646 on bug 2055. 10:00:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab needs to display open conversations and those on hold. 10:00:33 <Mic> There is an instantbird.xpt in my omni.ja already so I'm a bit surprised that you would need to add that? 10:01:07 <nhnt11> It was in bin, but not registered, or something 10:01:20 <nhnt11> What I know for sure is that this fixed it :P 10:02:25 <nhnt11> bbl 10:02:31 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:11:05 --> nhnt11_phone has joined #instantbird 10:16:01 <-- nhnt11_phone has quit (Connection reset by peer) 10:16:27 --> nhnt11_phone has joined #instantbird 10:17:14 <-- FireFly_TB has quit (Ping timeout) 10:18:46 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:19:08 --> Mic has joined #instantbird 10:19:08 * ChanServ sets mode +h Mic 10:21:37 --> clokep_wp8 has joined #instantbird 10:22:05 <clokep_wp8> I don't think that's the roght fix. 10:22:45 <clokep_wp8> Mic: Is Yahoo onky broken when you change about:config? 10:22:56 <nhnt11_phone> clokep_wp8: It makes sense to me because I believe that's what the MODULE line in the Makefile specifies 10:23:05 <clokep_wp8> I can do checkins in a few hours to fix things. 10:23:05 <nhnt11_phone> And the analogous chat.xpt is included 10:23:13 <nhnt11_phone> So it made sense to me 10:23:37 <clokep_wp8> nhnt11: Prove that to me. 10:23:54 <nhnt11_phone> I'll try in a bit 10:23:56 <-- clokep_wp8 has quit (Connection reset by peer) 10:24:53 <instantbot> benediktp@ymail.com requested review from florian@instantbird.org for attachment 2646 on bug 2055. 10:24:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab needs to display open conversations and those on hold. 10:27:13 --> nhnt11|phone has joined #instantbird 10:27:14 <-- nhnt11_phone has quit (Connection reset by peer) 10:29:07 <-- Tonnes has quit (Connection reset by peer) 10:32:02 --> aleth has joined #instantbird 10:32:02 * ChanServ sets mode +h aleth 10:34:28 --> nhnt11 has joined #instantbird 10:36:54 <-- chrisccoulson has quit (Ping timeout) 10:38:18 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:42:35 <-- nhnt11|phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 10:57:55 <-- Mic has quit (Connection reset by peer) 11:02:21 --> chrisccoulson has joined #instantbird 11:03:12 <-- chrisccoulson has quit (Connection reset by peer) 11:13:09 <-- aleth has quit (Quit: Ciao) 11:13:23 --> aleth has joined #instantbird 11:13:23 * ChanServ sets mode +h aleth 11:28:46 --> atuljangra has joined #instantbird 11:35:35 --> nhnt11 has joined #instantbird 11:37:07 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 11:37:51 * nhnt11 wonders if aleth has any ideas about the packaging issue. 11:53:01 * aleth doesn't know anything about packaging 11:53:52 <aleth> Find out who to ask on #developers maybe? 11:54:52 <aleth> Mook might have some ideas. 11:55:18 --> atuljangra has joined #instantbird 11:55:40 <nhnt11> Good idea 11:57:32 <nhnt11> I'm not sure exactly how to explain my situation to someone who isn't familiar with Instantbird though :/ 11:58:09 <nhnt11> I don't know if something similar would have cropped up if I added something to chat/, since that stuff is already packaged properly. 12:00:19 <aleth> Maybe find out in general about the packaging of components 12:01:45 <nhnt11> Ok! 12:06:16 * nhnt11 has no clue if what he said on #developers makes sense 12:06:42 <nhnt11> (http://pastebin.instantbird.com/262222) 12:13:13 * atuljangra was stuck at some problem, and after half an hour realizes that he was changing a readonly attributes :( 12:13:25 * atuljangra bangs his head on table :s 12:13:34 --> Mic has joined #instantbird 12:13:34 * ChanServ sets mode +h Mic 12:13:51 <nhnt11> aleth, Mic, clokep: smaug on #developers says adding instantbird.xpt to the package manifest (as I did) is the right thing to do. 12:14:50 <Mic> Ah, OK. Was ist instantbird.xpt? ... I've had misread then, my comment about the file being already packaged makes no sense then. 12:15:00 <aleth> Why do you call the MODULE instantbird ? 12:15:06 <nhnt11> To quote: "17:42:25 - smaug: but sounds like packaging instantbird.xpt is the right thing to do, if it is missing from instantbird right now" 12:15:28 <nhnt11> aleth: Because the components in chat/ had MODULE = chat, and I asked flo and he said instantbird was fine. 12:15:38 <aleth> OK then :) 12:16:24 <nhnt11> Mic: What did you misread it as? I'm curious :) 12:16:47 <Mic> "interfaces.xpt" as it currently is packaged in omni.ja's components folder. 12:17:00 <nhnt11> Ah. 12:17:16 <nhnt11> Now I get why you were asking about it :) 12:17:41 <Mic> Starts with "in", ends with "xpt", must be the same :P 12:17:51 <nhnt11> :P 12:27:51 * nhnt11 needs to find a better way to manage his code so that he doesn't have to struggle with merging the default branch over and over. 12:28:04 <nhnt11> Hmm, I should actually be doing the chat room stuff in a new branch. 12:28:42 <Mic> I've never worked with branches. MQs were good enough for everything I had to do. 12:29:11 <nhnt11> I would prefer to use MQs, but I guess for that I would need to put my mq repository on BitBucket. 12:42:19 <Mic> atuljangra: you can always ask when you run into a problem and can't seem to solve it. 12:42:45 <aleth> atuljangra: Have you managed to do without imIFilelinkOffer yet? 12:42:56 <atuljangra> Mic: Of course. I just like to put 1-2 hours to the problem before asking. 12:43:10 <atuljangra> aleth: Yes, I've removed the imIFileLink offer. 12:43:32 <Mic> Ask much earlier then. 12:43:33 <atuljangra> I'm just handling the various cases, and then will push the code. 12:43:40 <aleth> Great :) 12:43:40 <atuljangra> Mic: Okay :) 12:43:45 <atuljangra> :D 12:44:02 <Mic> Being blocked for 1-2 hours means that you can run into 4 problems and a whole workday is gone :( 12:44:04 <aleth> 1-2 hours seems far too much, unless you are actually learning something new ;) 12:44:30 <atuljangra> Agreed. Will ask after 15 mins then? :s 12:44:39 <Mic> Would be fine with me. 12:45:09 <atuljangra> :) 12:45:29 <Mic> 10 minutes if you like if that helps making good progress. 12:46:25 <Mic> I can't guarantee that I'm around all the time though, unlike you students we usually don't announce everytime we go afk :P 12:46:58 * nhnt11 asks after three attempts to fix fail, or when he has no idea what's happening. 12:47:10 <Mic> Sounds good too! 12:47:11 <atuljangra> Mic: hehe :P 12:52:58 <nhnt11> I'm switching to an observer model to return chat room lists. Does this look ok? http://pastebin.instantbird.com/262272 12:53:42 <nhnt11> Mic, aleth: ^ 12:53:44 <aleth> Why chat-room-list-request-init and not instead chat-room-list-complete 12:54:05 <nhnt11> Oops, I was actually planning on having both 12:54:14 <nhnt11> But yeah I guess init is redundant 12:55:08 <nhnt11> What do you think about making aData hold the account id or something instead of the nth batch? 12:55:13 <aleth> This might be a useful example for passing data that way http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#900 12:55:21 <nhnt11> I don't see a use-case for nth batch, but I wasn't totally sure. 12:56:20 <Mic> Having the init notification makes sense. 12:56:44 <aleth> Mic: why? 12:56:48 <Mic> Otherwise you can't be sure that you haven't missed anything when adding an observer (later). 12:56:57 <nhnt11> Good point. 12:57:27 <nhnt11> That makes my callback thing make more sense actually 12:57:47 <nhnt11> What if a request has been initiated, and an observer is added in the middle before it's completed? 12:57:59 <aleth> Who would add such an observer? 12:58:02 <nhnt11> I would need to implement add/remove/notifyObservers in prplIAccount itself. 12:58:16 <Mic> aleth: add-ons can be started any time? 12:58:27 <Mic> nhnt11: ? 12:59:14 <nhnt11> Mic: currently prplIAccount doesn't maintain a list of observers. Observers have to add themselves to the global service, and they're notified through that. 12:59:35 <nhnt11> So if an observer is added after a request is initiated, there's no way to tell that observer about previous batches. 12:59:40 <aleth> "add-ons can be started any time?" yeah, well... if you insist. 13:00:06 <nhnt11> Assuming stats service is the only consumer, it doesn't matter, but I don't like to make such assumptions. 13:00:29 <Mic> aleth: most of my add-ons can be started any time at least :P 13:00:34 <aleth> "So if an observer is added after a request is initiated, there's no way to tell that observer about previous batches." sounds to me like a feature. 13:00:53 <nhnt11> aleth: I don't understand 13:00:58 <nhnt11> New batches would keep coming 13:01:05 <nhnt11> And the new observer wouldn't know that it missed some 13:01:12 <nhnt11> Unless we had the init notification 13:01:31 <nhnt11> I may be misunderstanding what you're trying to say though 13:01:45 <aleth> Maybe I am confused - feel free to keep the init notificiation for now. 13:02:18 <nhnt11> I want to keep the callback 13:02:29 <nhnt11> That way the account could return already received batches too 13:02:35 <nhnt11> Cached rooms I mean. 13:03:06 <aleth> I don't see a problem with using a callback if you prefer. 13:03:29 <aleth> But maybe I'm missing something... Mic? 13:04:36 <nhnt11> The alternative is to make prplIAccount instances store a list of observers - these could be used for other things in the future too instead of only returning chat room lists 13:04:36 <nhnt11> That would take a lot more work though, I think :S 13:06:11 <aleth> Stick with the callback for now. 13:07:18 <aleth> It has some advantages in this case (we may be returning cached data, as opposed to notifying about incoming data as it arrives) 13:07:37 <Mic> aleth: iirc clokep said that we're using notifications and not callbacks everywhere and so why not here as well? 13:07:54 <aleth> Mic: "we may be returning cached data, as opposed to notifying about incoming data as it arrives" this would be the reason 13:08:39 <aleth> e.g. chat-buddy-add is the notification that means a participant has joined a channel. We don't resend a ton of chat-buddy-add's when we want to get the participants currently in a room. 13:09:19 <Mic> The caching argument makes sense. 13:11:56 <nhnt11> Mic, aleth: What do you think about removing the account attribute from prplIChatRoom, and pass it as a parameter to receiveChatRooms in the callback? I want to keep both (each may be useful to other consumers). 13:15:15 <aleth> I don't think anything about that until I see the next patch ;) Do what you think makes the most sense. 13:15:34 <nhnt11> Ok then. 13:40:11 <nhnt11> Hmm, clokep doesn't like LISTInitiated as a variable name. I don't either... aleth, Mic: Do you have any suggestions? 13:40:54 <nhnt11> _gettingLISTData? 13:41:37 <nhnt11> I like _gettingChannelList. 13:41:42 <Mic> ++ 13:41:43 <aleth> What does it actually mean? True if we've sent LIST and not got to LISTEND? 13:41:50 <nhnt11> Yes. 13:42:01 <Mic> I was about to suggest eaxctly the last name. 13:42:08 <nhnt11> Mic: :) 13:42:09 <aleth> Sounds OK to me. 13:42:49 <nhnt11> I should store the last channel list refresh time as a Date right? 13:43:12 <aleth> Yes 13:44:27 <nhnt11> Can I subtract dates? I know i can compare them with > and < 13:44:37 <-- Optimizer has quit (Ping timeout) 13:45:14 <nhnt11> Bah, I should be googling this. sorry. 13:45:26 <aleth> Yes 13:45:30 <Mic> You can use the ms representation for example. 13:45:30 --> Optimizer has joined #instantbird 13:45:39 <Mic> (ms since beginning of epoch) 13:46:10 <nhnt11> Yeah. stackoverflow suggests initial.getTime() - final.getTime() for millis elapsed between them. 13:51:29 <nhnt11> brb 13:52:34 <atuljangra> ms representation ++ 13:52:44 * atuljangra is using it all over in his code. 13:53:09 <-- nhnt11 has quit (Ping timeout) 13:54:44 <Mic> atuljangra: what were you working on when being blocked by the way? 13:55:17 <atuljangra> Mic: Fallback backend. 13:57:55 <-- Optimizer has quit (Ping timeout) 14:03:23 * qheaden_away is now known as qheaden 14:03:29 <qheaden> Hello everyone. 14:05:19 <-- aleth has quit (Quit: Ciao) 14:05:28 --> aleth has joined #instantbird 14:05:28 * ChanServ sets mode +h aleth 14:07:03 <aleth> qheaden: So, I've removed the yahoo entries from chat.prpls.forcePurple 14:07:23 <aleth> And restarted 14:07:24 <qheaden> aleth: And? Did your PC explode? :P 14:07:43 <aleth> And now I'd like to create a Yahoo account 14:07:49 <qheaden> Yay! :) 14:07:56 <aleth> And unless I'm blind, it's not in the list :( 14:08:11 <qheaden> :-O 14:08:25 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:08:38 <qheaden> aleth: You tried showing all of the plug-ins right? 14:08:58 <aleth> New account -> show all protocols 14:09:12 <aleth> Does it show up for you? 14:09:26 <qheaden> aleth: Can you try it using a different profile. 14:09:56 <qheaden> Are you using the nightly build, or a self-compiled version? 14:10:02 <aleth> Latest nightly 14:10:22 * qheaden goes to download the latest nightly. 14:11:18 <aleth> Before changing the pref, Yahoo shows up just fine. 14:11:27 <aleth> Different profile makes no difference. 14:11:31 <-- deltafalcon has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 14:12:06 --> deltafalcon has joined #instantbird 14:12:07 <qheaden> aleth: Anything strange in the error console? 14:12:12 <aleth> No :( 14:14:45 <aleth> Possibly a packaging issue like the one nhnt11 encountered? 14:15:08 <qheaden> aleth: Yeah, it doesn't show up in the nightly for me either. :( 14:15:26 <qheaden> Must be a packaging issues. 14:15:28 <qheaden> *issue 14:16:11 --> Optimizer has joined #instantbird 14:16:39 --> nhnt11 has joined #instantbird 14:16:49 <qheaden> aleth: You might have to update and build your tree to try it for now. 14:16:56 <nhnt11> aleth, qheaden: Yahoo! doesn't show up for me either 14:17:01 <nhnt11> If I remove it from that pref. 14:17:15 <aleth> qheaden: Shouldn't you add it around here? http://lxr.instantbird.org/instantbird/source/instantbird/installer/package-manifest.in#464 14:17:31 <nhnt11> I have an error though. 14:17:45 <nhnt11> 2 errors. I'm assuming they're due to the prpl? 14:17:48 <nhnt11> lmpbtfy 14:18:23 <nhnt11> http://pastebin.instantbird.com/262370 14:18:27 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:18:34 <aleth> qheaden: I'll wait until it gets fixed in the nightlies (proper dogfooding ;) ) 14:19:01 <aleth> nhnt11: Those are unrelated 14:21:01 <qheaden> aleth: Yeah, that's probably the issue. I never knew about that file. :( 14:21:25 * qheaden wishes flo or clokep were here. 14:21:35 <qheaden> I'll create a bug for it. 14:23:15 <aleth> qheaden: Get a patch up anyway and mark it r?clokep, he might be able to look at it at some point in the next few days 14:23:27 <qheaden> Okay. 14:24:42 <aleth> FWIW I think adding the missing files to package.manifest should be enough to fix it. 14:25:20 <qheaden> I think so. 14:31:12 <instantbot> New Core - Yahoo! Messenger bug 2074 filed by qheaden@phaseshiftsoftware.com. 14:31:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2074 cri, --, ---, qheaden, NEW, Yahoo Plug-in Doesn't Show in Nightly Build 14:38:48 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2647 on bug 2074. 14:38:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2074 cri, --, ---, qheaden, NEW, Yahoo Plug-in Doesn't Show in Nightly Build 14:42:14 <aleth> qheaden: Don't you also need a jar.mn in /chat/protocols/yahoo/ for the icons? 14:42:33 <qheaden> aleth: I do, but we haven't moved the icons yet. 14:42:39 <aleth> OK 14:56:40 --> qlum has joined #instantbird 14:58:05 <-- qlum has quit (Quit: Getting the <censored> out.) 14:58:11 --> qlum has joined #instantbird 15:16:30 --> mconley has joined #instantbird 15:43:56 --> wnayes has joined #instantbird 16:04:27 --> clokep_ has joined #instantbird 16:04:51 <clokep_> nhnt11: So really this all goes back to my question of why did you add the MODULE line and not really understanding it? 16:05:25 <clokep_> Bah you guys should have used the same bugs for these... 16:06:44 <clokep_> qheaden: Did you try that aptch? 16:08:53 <clokep_> aleth: nhnt11: Mic I think caring about if an observer only gets partial data for a list is a super super edge case. 16:09:44 <instantbot> clokep@gmail.com granted review for attachment 2646 on bug 2055. 16:09:45 <instantbot> clokep@gmail.com granted review for attachment 2647 on bug 2074. 16:09:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2074 cri, --, ---, qheaden, NEW, Yahoo Plug-in Doesn't Show in Nightly Build 16:09:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, 1.5, nhnt11, RESO FIXED, New conversation tab needs to display open conversations and those on hold. 16:11:08 <aleth> "I think caring about if an observer only gets partial data for a list is a super super edge case." That's what I was trying to say too... But I don't mind using a callback for this, it seems reasonable. Nobody is going to want to continually listen for these notifications, this is data provided on request. 16:12:15 --> nhnt11_phone has joined #instantbird 16:12:28 <clokep_> aleth: I want a callback. 16:12:33 <clokep_> I agree. :) 16:13:39 <nhnt11_phone> clokep: I did use the same bug :S 16:21:33 <clokep_> nhnt11_phone: Yes, I see that now. 16:24:39 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 16:25:18 <instantbot> clokep@gmail.com set the Resolution field on bug 2074 to FIXED. 16:25:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2074 nor, --, 1.5, qheaden, RESO FIXED, Yahoo Plug-in Doesn't Show in Nightly Build 16:26:00 <clokep_> Hopefully that fixes it. 16:26:06 <clokep_> If not I'll be online at some point tomorrow. 16:26:26 <clokep_> qheaden: nhnt11_phone You can test the packaging btw by |make package| or |make dist| or something like that and then install it. :) 16:26:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/616ba6de2d81 - Quentin Headen - Bug 2074 - Yahoo Plug-in Doesn't Show in Nightly Build, r=clokep. 16:26:56 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d069c5374c3f - Nihanth Subramanya - Bug 2055 - New conversation tab needs to display open conversations and those on hold, r=clokep. 16:27:24 <nhnt11_phone> clokep: Its make package, i tested my patch with it :) 16:27:25 <qheaden> clokep_: Thanks for the review. :) 16:28:08 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client) 16:28:09 * qheaden wonders if he should use Mercurial Queues from here on. 16:41:05 <qheaden> nhnt11_phone: Where do the files end up when you run make package? 16:41:30 <nhnt11_phone> qheaden: objdir/mozilla/dist 16:41:38 <qheaden> Thanks. 16:42:02 <nhnt11_phone> 99 pi 16:42:21 <nhnt11_phone> Typo sorry 16:42:50 --> nhnt11|phone has joined #instantbird 16:43:26 <instant-buildbot> build #427 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/427 16:44:04 <qheaden> aleth: Okay, the next nightly should be fixed. I just tried my own package and it works. 16:44:10 <-- nhnt11_phone has quit (Ping timeout) 16:44:32 --> unghost has joined #instantbird 16:50:17 <-- Optimizer has quit (Ping timeout) 17:00:16 <-- nhnt11|phone has quit (Ping timeout) 17:04:03 --> rosonline has joined #instantbird 17:05:09 <-- rosonline has quit (Connection reset by peer) 17:05:13 --> rosonline has joined #instantbird 17:05:19 <-- dew has quit (Ping timeout) 17:19:22 <-- aleth has quit (Quit: Ciao) 17:24:47 --> nhnt11 has joined #instantbird 17:27:07 <-- wnayes has quit (Ping timeout) 17:29:29 --> Optimizer has joined #instantbird 17:30:41 --> wnayes has joined #instantbird 17:37:33 --> Mic has joined #instantbird 17:37:33 * ChanServ sets mode +h Mic 17:40:44 <-- deltafalcon has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 17:48:15 <-- Optimizer has quit (Ping timeout) 17:49:00 --> Optimizer has joined #instantbird 17:51:16 <nhnt11> Mic, aleth, clokep: Fyi I (probably) won't be online tomorrow, I'm traveling to campus. I'll be completely free till Wednesday-ish though. 17:51:38 <Mic> OK. 17:51:42 <-- Optimizer has quit (Ping timeout) 17:52:39 --> Optimizer has joined #instantbird 17:55:21 <-- Optimizer has quit (Ping timeout) 17:57:14 --> Optimizer has joined #instantbird 17:59:04 <-- mconley has quit (Input/output error) 18:03:53 <nhnt11> Since -0 and 0 are different in JavaScript, array.slice(-0) would return an empty array right? 18:04:25 <nhnt11> Never mind, I don't need it (still would be good to know though) 18:04:27 * nhnt11 googles. 18:05:05 <Mic> According to the errorconsole -0 === 0 18:05:35 <Mic> I think Maps treat -0 and 0 as different keys though. 18:05:49 <nhnt11> Yeah. slice(-0) returns the full array. 18:17:17 <nhnt11> Mic: Should MUCs be sorted among contacts, or should they all go at the end of the list separately? 18:17:45 <nhnt11> Considering the sheer number that LIST may return, I want to just add them at the end of the list.. 18:29:24 --> mconley has joined #instantbird 18:36:24 <nhnt11> Should I be worried about channels that are un-registered/expire? (i.e. don't appear in LIST data anymore) 18:36:54 <nhnt11> I'm not going to for now, it seems highly unlikely we'd need to handle that. It can be a follow up. Is this ok? 18:50:33 * nhnt11 wonders if he can use html in the value of an xul label. 18:50:44 <Mic> Maybe add them at the end, yes. 18:51:22 <Mic> It shouldn't matter as soon as you've got ranking data. I guess these automated suggestions will be ranked quite low by default? 18:51:29 <nhnt11> Yes. 18:52:01 <Mic> I think I've used <span> in a label once iirc btw 18:52:22 <nhnt11> That's awesome, thanks. 18:55:19 <Mic> in DOMi it works to add span as child of a label. 18:56:05 <Mic> I'm not sure if it will work in the value-attribute if you meant that. 18:56:17 <Mic> I'd guess that it doesn't. 18:56:29 <nhnt11> Oh ok. 18:56:47 <nhnt11> Good enough I think. 19:06:46 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:06:51 --> nhnt11 has joined #instantbird 19:12:49 <-- mconley has quit (Input/output error) 19:16:23 <nhnt11> Mic: How does this look? I want make the "@concrete.blabla" part greyed out and need to fix the alignment of the "Join chat" string. http://puu.sh/3NafL.png 19:18:04 <nhnt11> I like the Join chat (username) idea, what do you think? 19:26:52 <-- wnayes has quit (Ping timeout) 19:30:21 --> wnayes has joined #instantbird 19:32:59 <nhnt11> Here it is with both of those things done: http://puu.sh/3NaVR.png 19:50:49 <-- Optimizer has quit (Connection reset by peer) 19:52:38 --> Optimizer has joined #instantbird 20:08:37 <instantbot> nhnt11@gmail.com cancelled feedback?(benediktp@ymail.c om) for attachment 2636 on bug 2066. 20:08:38 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2648 on bug 2066. 20:08:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms 20:12:40 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2650 on bug 2066. 20:12:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms 20:14:41 * qheaden is now known as qheaden_away 20:18:14 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2650 on bug 2066. 20:18:15 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2651 on bug 2066. 20:18:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms 20:18:53 <nhnt11> Aaaah 20:19:04 <nhnt11> Found /another/ stupid mistake in the new patch 20:19:05 <nhnt11> :( 20:19:21 <nhnt11> aleth, clokep: Sorry for the bugmail.. 20:19:47 * nhnt11 is sleepy 20:21:08 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2651 on bug 2066. 20:21:09 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2652 on bug 2066. 20:21:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2066 enh, --, ---, nhnt11, NEW, New conversation tab should display chat rooms 20:21:13 * nhnt11 goes to bed. 20:21:20 <nhnt11> Good night 20:23:41 <nhnt11> Bah, that patch still needs to request chat rooms when an empty filter string is encountered instead of when an account connects 20:23:43 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:35:40 <Mic> re 20:37:54 <atuljangra> Mic: Why do we need to pass the file transfer instance? We can pass file in subject, and the topic can be "file-transfer-fail" in case of failure, and "file-transfer-success" in case of completion. 20:39:51 <atuljangra> re line no 14 https://etherpad.mozilla.org/filelink 20:46:30 <Mic> You wouldn't know which conversation this file transfer belongs or belonged to then, would you? 20:47:37 <Mic> You could also store the progress on the file transfer object, maybe? 20:48:32 <atuljangra> I can get the conv. But yes progress thing makes sense. 20:48:51 <atuljangra> Then when do I delete the file transfer object? 20:49:04 <atuljangra> I guess after the ui deals with it? 20:51:05 <atuljangra> Also, if we are sending the file transfer instance, then we can have a common topic, say "file-transfer-response" and UI can decide the case based on the status in the file transfer instance and act accordingly. 20:51:20 * atuljangra shouldn't throw so many questions at once on Mic :s 20:53:58 <Mic> Don't worry about that. 20:55:21 <Mic> I wouldn't really want to recommend anything as I don't know what flo had in mind... 20:56:24 <atuljangra> Mic: Ok. Acc to me single topic makes sense and ui can decide the things based on this. 20:56:43 <Mic> Maybe a file-transfer-status-updated notification might make sense when some fields change but sending it on every progress update sounds excessive. 20:57:15 <atuljangra> yes. 20:58:03 <Mic> Having separate topics for start and end of a file transfer would be OK imo but that's also only something that I've thought a minute about now. 20:58:31 <atuljangra> Maybe we can send a progress update when every 4kb is sent? 20:58:40 <Mic> Why not add one for start and end for now? 20:58:57 <Mic> You could still remove it if it turns out to be unnecessary. 20:59:31 <atuljangra> I like having common topic, we can just look at the currentStatus in file transfer instance that we are passing and decide evrything. 20:59:40 <atuljangra> okay I'll add start and end 20:59:54 <atuljangra> and also, "failure" 21:00:19 <Mic> Other possibilities would be a certain fraction of the file transferred (1%?) or a certain period of time elapsed since beginning of the transfer? 21:00:34 <atuljangra> So three separate topics: {start, end, failure} 21:00:40 <atuljangra> yes that seems plausible 21:01:07 <Mic> Failure would need to make details available of how it failed. 21:02:03 <Mic> It should rather be "file-transfer-failed" opinion by the way. 21:02:32 <atuljangra> All those details would be in the file transfer instance. 21:02:36 <atuljangra> that we are passing. 21:02:46 <Mic> If that's there then it's fine. 21:03:17 <atuljangra> Just to speed things up, I;ll take your separate topics approach and submit a patch acc to that. 21:03:23 <atuljangra> Would that be okay? 21:04:27 <Mic> Sure, do what you think that is appropriate. 21:04:46 <atuljangra> Okay. :) 21:07:21 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 21:27:22 <-- wnayes has quit (Ping timeout) 21:30:50 --> wnayes has joined #instantbird 22:05:02 <atuljangra> Good night. 22:05:12 --> mpmc has joined #instantbird 22:08:12 <Mic> Good night 23:14:06 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 23:14:47 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!) 23:15:29 <-- qlum has quit (Connection reset by peer) 23:27:12 <-- wnayes has quit (Ping timeout) 23:30:47 --> wnayes has joined #instantbird 23:55:59 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 23:58:15 <instant-buildbot> build #443 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/443