#instantbird log on 07 22 2013

All times are UTC.

00:05:19 <-- mconley has quit (Input/output error)
00:11:51 <-- wnayes has quit (Ping timeout)
00:15:12 --> wnayes has joined #instantbird
00:29:19 <instant-buildbot> build #916 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/916
00:31:13 --> clokep has joined #instantbird
00:31:14 * ChanServ sets mode +o clokep 
00:37:54 <-- skeledrew has quit (Ping timeout)
00:44:13 <-- rosonline has quit (Client exited)
00:48:33 <instant-buildbot> build #440 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/440
00:49:41 --> skeledrew has joined #instantbird
00:51:33 <clokep> dew: Use Mercurial.
00:57:59 <instant-buildbot> build #427 of win32-onCommit is complete: Exception [exception]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/427  blamelist: Florian Qu?ze <florian@instantbird.org>, aleth <aleth@instantbird.org>, Nihanth Subramanya <nhnt11@gmail.com>
01:02:01 <instant-buildbot> build #1012 of win32-nightly-default is complete: Failure [failed shell]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1012
01:35:24 <-- clokep has quit (Connection reset by peer)
01:35:32 --> clokep has joined #instantbird
01:35:32 * ChanServ sets mode +o clokep 
01:43:12 <-- clokep has quit (Connection reset by peer)
02:01:31 --> mconley has joined #instantbird
02:03:03 --> Nirgali has joined #instantbird
02:11:31 <-- wnayes has quit (Ping timeout)
02:23:27 <dew> the worst part about this is trying to get my ssh key to work with bitbucket :<
02:33:49 <-- dew has quit (Ping timeout)
02:33:53 --> dew has joined #instantbird
02:41:25 <-- dew has quit (Ping timeout)
02:59:36 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:02:23 <instant-buildbot> build #917 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/917
03:09:37 <-- skeledrew has quit (Ping timeout)
03:13:32 --> jb has joined #instantbird
03:23:01 <-- mpmc has quit (Connection reset by peer)
03:23:59 --> dew has joined #instantbird
03:43:25 <-- jb has quit (Ping timeout)
03:45:14 <-- gerard-majax_ has quit (Ping timeout)
03:48:00 <instant-buildbot> build #917 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/917
03:56:46 <-- EionRobb has quit (Quit: Leaving.)
04:04:45 --> skeledrew has joined #instantbird
04:32:31 --> EionRobb has joined #instantbird
05:05:15 <-- EionRobb has quit (Quit: Leaving.)
05:15:41 <-- mconley has quit (Input/output error)
05:48:57 <instant-buildbot> build #1013 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1013
05:52:24 --> atuljangra has joined #instantbird
05:53:23 <atuljangra> Sorry I wasn't able to write up the daily progress before sleeping. Anyway I was working on fallback mechanism. I expect to complete it by tomorrow.
06:00:20 --> EionRobb has joined #instantbird
06:37:13 --> gerard-majax_ has joined #instantbird
06:38:37 --> gerard-majax__ has joined #instantbird
06:38:53 <-- gerard-majax_ has quit (Ping timeout)
07:52:00 <-- EionRobb has quit (Ping timeout)
08:01:36 --> EionRobb has joined #instantbird
08:35:36 --> nhnt11 has joined #instantbird
08:56:38 --> flo-retina has joined #instantbird
08:56:38 * ChanServ sets mode +qo flo-retina flo-retina 
08:57:04 <flo-retina> I'm seeing plenty of "mobile" icons today ;)
08:57:29 <nhnt11> flo-retina: \o/
08:57:37 <atuljangra> heh, due to recently landed patch \m/
08:57:42 <nhnt11> Now if we can get it working for facebook... :P
08:58:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:58:17 --> nhnt11 has joined #instantbird
08:58:43 <flo-retina> are there official google talk clients for iPhone, blackberry, windows phone, etc... that we should take into account too?
08:58:46 <nhnt11> Wow, I just updated.
08:58:57 <nhnt11> Nearly all of my contacts who are idle/away are mobile :D
08:58:59 <atuljangra> flo-retina: yes there are.
08:59:18 <flo-retina> atuljangra: I see you have a blackberry resource and a gmail one (no Instantbird? :-P)
09:00:05 <atuljangra> I don't know about windows phone though :D
09:00:12 <atuljangra> flo-retina: Proxy issues :'(
09:00:42 <atuljangra> When I go to lab, I'm on IB. I've a workaround for the same there. :D
09:00:50 <flo-retina> your blackberry resource announced http://code.google.com/p/qxmpp/ as the capacities node URI, doesn't seem like something we could use to decide you are mobile :-S
09:01:50 <flo-retina> nhnt11: the mobile icon is not displayed on the awesometab
09:02:33 <flo-retina> nhnt11: I would guess it's related to the last paragraph of https://bugzilla.instantbird.org/show_bug.cgi?id=1221#c11
09:02:39 <instantbot> Bug 1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips
09:03:03 <atuljangra> flo-retina: Oh! we cannot decide then :(
09:03:04 <nhnt11> Yeah
09:03:11 <nhnt11> I'll file a bug
09:03:25 <flo-retina> nhnt11: or convince wnayes to finish his patch soon :-D
09:03:51 <flo-retina> but yeah, you can just file a bug (mark it blocking wnayes' bug, to be sure he notices), and get it fixed today :)
09:03:58 <nhnt11> flo-retina: He added it to tooltip.css for now, that won't help newtab. We'll still need a new bug
09:04:07 <flo-retina> nhnt11: see my review comments
09:04:19 <nhnt11> oh
09:04:25 <nhnt11> alright then
09:04:39 <flo-retina> (last line of comment 12)
09:04:43 <nhnt11> Saw it.
09:04:51 <flo-retina> you can still fix it in another bug if you don't want to wait though :)
09:05:05 <flo-retina> I'm afraid the tooltip stuff still needs a bit of work
09:05:13 <flo-retina> I just hope it's not platform specific work :-S
09:14:25 --> aleth has joined #instantbird
09:14:25 * ChanServ sets mode +h aleth 
09:36:00 <-- aleth has quit (Quit: Ciao)
09:36:09 --> aleth has joined #instantbird
09:36:09 * ChanServ sets mode +h aleth 
09:37:11 <aleth> atuljangra: Are you still wondering how to detect whether an upload is taking too long or did you figure it out?
09:42:45 <nhnt11> aleth: I hope my new patch addresses your comments :)
09:43:37 <aleth> nhnt11: I only took a quick glance so far and it looks much better :)
09:44:34 <nhnt11> :)
09:44:41 <nhnt11> be back in an hour or two.
09:45:03 <flo-retina> nhnt11: do you hope it could land soon?
09:45:16 <flo-retina> (ie do I have to prioritize giving feedback on it before going in vacations?)
09:53:57 <-- nhnt11 has quit (Ping timeout)
09:56:01 --> mpmc has joined #instantbird
09:56:24 --> Mic has joined #instantbird
09:56:24 * ChanServ sets mode +h Mic 
09:56:29 <aleth> flo-retina: I wonder if it would be useful for nhnt11 looking forward to the next weeks to have a discussion on how the ranking system is expected to gather/store/retrieve data.
09:56:44 --> nhnt11 has joined #instantbird
09:56:48 <nhnt11> flo-retina: Yes I do.
09:57:13 <Mic> Hi
09:57:19 <nhnt11> Hi Mic
09:57:25 <flo-retina> nhnt11: something at first glance: |var NewTabBundle =| ... is not correct.
09:57:33 <flo-retina> first it wouldn't start with an upper case letter
09:57:42 <flo-retina> if it was global you would have a "g" prefix
09:58:02 <nhnt11> Ok. I wasn't sure about doing that either.
09:58:09 <flo-retina> but I think you want something like this: http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#24
09:58:12 <nhnt11> What's the best way to do it? I didn't want to create a new bundle every time
09:58:14 <nhnt11> Looking.
09:58:24 <nhnt11> ah ok
09:59:44 <aleth> nhnt11: ordering nit: put _removePossibleContact under _addPossibleContact ;)
09:59:53 <flo-retina> Nit: "193  } else {" Always a line break before "else"
10:00:18 * flo-retina isn't sure what a "PossibleContact" is, but that feels wrong
10:00:27 <nhnt11> Done, done, and done.
10:00:29 <nhnt11> Er.
10:00:30 <flo-retina> I suspect you mean PossibleConvIM or something like that
10:00:43 <aleth> PossibleConvIm is even worse :-S
10:00:47 <nhnt11> ConvIM? It represents an imIContact
10:01:04 <flo-retina> nhnt11: When reading "PossibleContact", what I have in mind is "the user entered a string that doesn't exist in the contact list, and we may want to create a contact from it"
10:01:32 <nhnt11> flo-retina: ExistingContact then?
10:01:36 <flo-retina> nhnt11: no, it doesn't represent an imIContact. It represents a possible *conversation* with a contact.
10:01:47 <nhnt11> Hmm
10:01:51 <flo-retina> do you have non existing contacts?
10:02:05 <flo-retina> ghosts maybe? :)
10:02:09 <aleth> nhnt11: I suggested previously to call those methods simply _addContact
10:02:40 <nhnt11> flo-retina: How about ContactConversation?
10:02:58 <nhnt11> aleth: Oops, I'll change that.
10:03:17 --> clokep has joined #instantbird
10:03:17 * ChanServ sets mode +o clokep 
10:03:19 <aleth> Though I'm not sure s/possibleContact/contact everywhere will help much.
10:03:34 <atuljangra> aleth: I wanted to know, I skipped that part.
10:04:18 <flo-retina> nhnt11: "readonly attribute AUTF8String type;" the possible values of this attribute need to be documented in the .idl file
10:04:31 <aleth> The idl file generally needs comments
10:04:36 * nhnt11 forgot to add comments in the idl file
10:04:38 <nhnt11> :S
10:04:48 <nhnt11> Maybe I should do that before you guys spend more time on this patch
10:05:19 <flo-retina> atuljangra: wanted to know what?
10:05:52 <aleth> atuljangra: Doesn't this answer your questions? http://log.bezut.info/instantbird/130718/#m441
10:05:59 <flo-retina> nhnt11: so "PossibleContact" is really meaningless. If we want to be super explicit, we can do "PossibleConversationFromContact" (that feels too long)
10:06:10 <Mic> nhnt11: I published the blog entry by the way (manually, as you seem to still need to press the publish button after scheduling it. I thought scheduling would imply wanting to publish it...) If you'd like to read that later.
10:06:16 <aleth> atuljangra: e.g. http://log.bezut.info/instantbird/130718/#m449
10:06:21 <nhnt11> Mic: Thanks!
10:06:32 <flo-retina> atuljangra, aleth: and specifically http://log.bezut.info/instantbird/130718/#m449
10:06:35 <nhnt11> flo-retina: What's your opinion on ContactConversation?
10:06:38 * atuljangra looks
10:06:44 <flo-retina> nhnt11: what is it?
10:06:49 <nhnt11> That seems to be consistent with PossibleConversation/ExistingConversation
10:06:58 <nhnt11> flo-retina: A replacement name for PossibleContact
10:07:07 <flo-retina> even worse
10:07:13 <flo-retina> it's a possible conversation, not an existing conversation
10:07:28 <atuljangra> flo-retina: aleth seems okay :-) Will implement this :D
10:07:35 <aleth> Thinking about it, I think you should refer to contacts when storing contact id's and to possibleconversations when referring to those.
10:08:20 <aleth> atuljangra: It is a little frustrating that I already linked to exactly that conversation here a few days ago https://bitbucket.org/atuljangra/instantbird-gsoc-2013/commits/27097ad8e3b05d5588a1a7fdc42fb4eb7aa214de#comment-342672
10:08:41 <nhnt11> flo-retina: How does ContactConversation imply that it already exists
10:08:52 <flo-retina> nhnt11: it imply it's a conversation
10:08:57 <nhnt11> Hmm ok
10:08:59 <flo-retina> "Possible" means it's not one yet
10:09:03 <nhnt11> PossibleContactConversation?
10:09:22 <flo-retina> PossibleConvFromContact?
10:09:31 <atuljangra> aleth: I looked at it, I was thinking if there is a way we can check this beforehand, without even spending 2 mins. :S
10:09:31 <nhnt11> Ok.
10:09:39 <aleth> nhnt11: But I think you should refer to contacts when storing contact id's and to possibleConv* when referring to possible conversations.
10:09:43 <flo-retina> "uiconv" is also a really sucky name :(
10:10:17 <aleth> flo-retina: not his fault ;)
10:10:21 <flo-retina> the only reason why it's not confusing in http://lxr.instantbird.org/instantbird/source/chat/components/public/imIConversationsService.idl#56 is that the returned type is clearly visible (imIConversation), and it's clear that "UI" here is as opposed to the other conversations that are "prplIConversation"
10:10:44 <flo-retina> aleth: well. I'm thinking we shouldn't make the situation even worse
10:11:12 <nhnt11> flo-retina: Do you want me to change that? I'm against using a new name for something that's already used elsewhere. How about adding a comment above it that states that it's an imIConversation?
10:11:51 <flo-retina> I think ExistingConversation's type getter should return "existing" rather than "uiconv".
10:11:56 <flo-retina> and maybe it should be "source" instead of "type"
10:12:12 <nhnt11> Oh you were talking about the type getter
10:12:18 <nhnt11> I thought you were talking about get uiConv()
10:12:27 <nhnt11> Or maybe you /were/
10:14:05 <flo-retina> nhnt11: I think I would s/uiConv/imConv/ in most of the code.
10:14:14 <nhnt11> ok
10:14:31 <flo-retina> nhnt11: but I'm more concerned about names that don't make sense in things that are APIs, so yes, my real concern is the type getter
10:16:25 <clokep> flo-retina: Windows Phone doesn't have any official Google Talk client, unfortunately.
10:18:34 <atuljangra> BB, Android and iOS do have.
10:19:47 <nhnt11> flo-retina: I've changed the type getter, but I still think the uiConv getter makes sense. It is Services.conversations.getUIConversation after all
10:24:41 <nhnt11> brb after lunch
10:27:05 <Mic> Just an idea, what about names with Surrogate* ?
10:27:49 <Mic> Like SurrogateConvIM/SurrogateConvChat?
10:31:17 * clokep dislikes that.
10:31:19 <aleth> Mic: I don't understand :-S Surrogate means replacement?
10:31:27 <clokep> Yeah.
10:31:40 <aleth> Replacement for what?
10:40:15 <aleth> Ah, maybe Mic meant representative
10:42:00 <Mic> aleth: isn't that the meaning of it?
10:42:41 <Mic> ah, sorry. 
10:43:08 <Mic> Too bad I need to go :S
10:43:23 <aleth> clokep: I thought we closed TB bugs when fixed in IB, not on merge? (As nobody will remember to do it then)
10:43:57 <clokep> aleth: No, we don't.
10:43:59 <clokep> We fix them on merge.
10:44:09 <clokep> aleth: I remember. ;)
10:44:18 <aleth> clokep: Thanks, then! :)
10:44:50 <clokep> aleth: We do have a bunch waiting that we should probably file a merge bug and start marking things as depending on it.
10:45:38 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:51:44 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:16:24 <flo-retina> or maybe we should just merge :-S
11:27:56 <aleth> nhnt11, flo-retina: : How about ExistingConversation, PossibleConversation (for contacts) and PossibleChat (for MUCs)?
11:28:57 <flo-retina> it's fun that somehow they computer a list of possible reviewers for all bugzilla components, and the reviewers for "Thunderbird::Instant Messaging" are clokep and aleth but I'm not there :). Nice, I won't have a longer review queue :-P.
11:29:02 <flo-retina> *computed 
11:29:52 <flo-retina> aleth: I wouldn't object to it. Although "PossibleConversation" is potentially slightly ambiguous.
11:30:17 <aleth> It's ambiguous only because that's what the interface is currently called.
11:31:21 * flo-retina wonders if they took the module peers but ignored the owners
11:31:34 <aleth> flo-retina: Sounds like an incomplete database query...
11:31:47 <aleth> ...but do you want to tell them? ;)
11:31:55 <flo-retina> aleth: there's no database, they took the data from https://wiki.mozilla.org/Modules/All
11:32:06 --> jb has joined #instantbird
11:32:06 <flo-retina> aleth: not sure I want to tell them indeed :-P
11:35:22 <flo-retina> aleth: ah, I know the problem
11:35:49 <flo-retina> I'm listed as florian AT mozilla.com on the module owner page. I've no bugzilla account at that address.
11:37:12 <-- nhnt11 has quit (Ping timeout)
11:38:36 --> nhnt11 has joined #instantbird
11:39:58 <nhnt11> flo-retina, aleth: Are you guys ok with PossibleConversation and PossibleChat then?
11:40:05 * nhnt11 wants to finalize these names
11:40:26 <flo-retina> nhnt11: the "PossibleChat" part isn't implemented yet, is it?
11:41:27 <nhnt11> Not in the patch, but I have a rough WIP from a commit a while ago
11:41:44 <nhnt11> (It works but may need tweaking
11:41:50 <aleth> nhnt11: Really, you've got a WIP for LIST ? :-O
11:42:30 <nhnt11> aleth: Not LIST, but for a PossibleChat that can build from LIST data
11:42:31 <aleth> If you do I'd suggest you show it to clokep ;)
11:43:31 * nhnt11 wants to make good progress on LIST today.
11:43:56 <aleth> nhnt11: The first question will be what to add to the account interface
11:44:28 <nhnt11> aleth: Right. I think I need a boolean to check if the account supports public chats, and a method that returns the list data
11:44:41 <nhnt11> er, /discoverable/ public chats
11:46:18 <aleth> Can't the method just return not_implemented if there are no public chats?
11:46:26 --> clokep_ has joined #instantbird
11:46:50 <nhnt11> Yeah ok.
11:47:18 <nhnt11> (It would do that even if the boolean was there, but I guess there's no necessity for it)
11:47:19 <aleth> And "returns the list data", think about whether you want to return all of it or only a filtered subset. And how/when that data is to be updated.
11:47:35 <aleth> It should certainly be stored on the account.
11:48:03 <nhnt11> Yeah.
11:48:05 <aleth> It's not OK to simply call LIST on connection.
11:48:17 <flo-retina> nhnt11, atuljangra: I'll be on vacations and mostly offline (ie. not on IRC at all, 'maybe' checking emails a few times a week) from Wednesday (July 24th) evening to August 7th.
11:48:24 <aleth> (at least that would be my current preference)
11:48:36 <flo-retina> so if you need to discuss things to be sure you aren't blocked during that period of time, please start these discussions today or tomorrow.
11:49:07 <atuljangra> flo-retina: Okay. I'll just finish some of this fallback mechanism and will discuss further work tonight :-)
11:49:11 <flo-retina> I'm thinking mostly about the ranking system for nhnt11, and for atuljangra I don't know yet (I assume I'll know better what needs to be discussed once I've tried the existing code)
11:49:14 <nhnt11> aleth: I'm thinking the stats service will call it as soon as it starts though, so it will almost be like on-connection anyway
11:49:34 <aleth> nhnt11: That may be OK for now, but not as a final solution.
11:49:56 <nhnt11> flo-retina: I'll think about it and let you know if there's something I want to discuss
11:50:00 <aleth> ^^ clokep_ do you agree?
11:50:48 <atuljangra> flo-retina: I've completed what you asked for and presently working on implementation of fallback mechanism.
11:50:51 <aleth> nhnt11: I think once you have ranking data then a lot more things can be fetched lazily as you will then already know what to display when there is no filter string (i.e. when opening the awesometab)
11:51:11 <clokep_> aleth: Which part?
11:51:33 <nhnt11> aleth: Ah, that's what you meant. Yes! When the ranking stuff is stored, everything can be  lazier (\o/) :D
11:51:33 <aleth> clokep_: Calling LIST for connected accounts on startup.
11:51:56 <clokep_> Yes, that's not reasonable.
11:52:16 <aleth> nhnt11: So when you design the LIST interface you should try to take that into account.
11:53:52 <nhnt11> Cool
11:55:14 <nhnt11> aleth: Does the rest of that patch look ok?
11:57:04 * clokep_ is more interested in what the prpl returns to the service than when we call LIST. ;)
11:57:26 <flo-retina> atuljangra: it would be easier to review the code for this proof of concept if you could just attach a diff on bugzilla.
11:58:00 <flo-retina> (and yes, we know the patch will be large, as it will contains plenty of files copied from Thunderbird)
11:58:17 <atuljangra> flo-retina: Okay. I'll do so. Should I file a new bug for the same?
11:58:23 <nhnt11> clokep_: Actually clokep_ I think we can return an array of prplIChatRoomFieldValues
11:58:34 * nhnt11 mentioned cloke_p_ twice
11:58:34 <atuljangra> I'll attach it tonight :)
11:58:41 <flo-retina> why not now?
11:58:52 <aleth> atuljangra: I would recommend you tidy it up a bit first (in particular, remove any obsolete or commented-out code). This should not take long.
11:59:10 * flo-retina didn't know there was still dead code in there :(
11:59:29 <aleth> Admittedly I've only spotted one block so far ;)
11:59:52 <aleth> But I mentioned it in case there was more. https://bitbucket.org/atuljangra/instantbird-gsoc-2013/src/69e9e8e889f2a9f2ec1014f303183743aeb903c6/instantbird/content/conversation.xml?at=Filelink#cl-168
11:59:58 <clokep_> nhnt11: I doubt that. :) (Also it needs to be async, so both of us shouldn't be saying "returned" but I think we both understand that?)
12:00:16 <atuljangra> Currently, code include some more things regarding fallback mech and then will cleanup the code and submit it. I need to eat something right now, dinner+lunch :P
12:00:19 <nhnt11> Yes I understand that :)
12:00:24 <nhnt11> Why do you doubt it?
12:00:29 <aleth> nhnt11: the chatroomfields stuff is enough to open a chat, but does not contain info about it
12:00:35 <clokep_> nhnt11: Because that does not include topics or names.
12:00:43 <nhnt11> Hmm right, silly me
12:00:58 <nhnt11> Well sounds like a new interface then
12:01:09 <atuljangra> aleth: Yes, I planned to remove all such code, I just wanted you guys to test it first. It was for my testing.
12:01:25 <nhnt11> It should contain the account, name, topic, and chatroomfieldvalues for that chat.
12:01:40 <aleth> atuljangra: That's fine, but do it before you attach a patch on BIO ;) Ditto for any duplicate files left etc
12:02:02 <atuljangra> aleth: Sure :D I'll be out for a while now.
12:02:03 <atuljangra> Cya
12:02:04 <clokep_> nhnt11: Why the account? :-S
12:02:29 <nhnt11> clokep_: If it's returned aSync, and we're querying multiple accounts, we need info on which account it's been returned from
12:02:57 <nhnt11> But I need to design the callback mechanism first before I can say that for sure
12:03:01 <nhnt11> Maybe I'm missing something
12:04:24 <nhnt11> I'm currently planning to add a "prplIChatRoom" interface in imIAccount.idl. Right above prplIChatRoomFieldValues
12:05:20 <clokep_> atuljangra: I'd really prefer if you took the version of the code that you said "works" and create a patch and upload it now to Bugzilla, that should take < 5 minutes. It does not need to be "cleaned" up first.
12:07:31 --> novabyte has joined #instantbird
12:07:41 <flo-retina> I would also prefer if you could stop promising random deadlines like "tonight" "by the end of the day", etc... for uploading patches to bugzilla. It's neither difficult nor long to upload a patch.
12:17:53 <-- EionRobb has quit (Quit: Leaving.)
12:20:03 <-- jb has quit (Ping timeout)
12:24:11 <clokep_> nhnt11: Yes, that's true. I guess it depends on how it is returned.
12:32:57 --> jb has joined #instantbird
12:50:25 <nhnt11> clokep_, flo-retina, aleth: Do you think the method to return the list of rooms should be in prplIAccount or imIAccount?
12:51:11 <flo-retina> I would say prplIAccount
12:52:02 <clokep_> It has to be prplIAccount.
12:55:10 <nhnt11> I just read the comments in the idl
12:55:16 <nhnt11> so yeah prplIAccount it is
12:55:32 <-- jb has quit (Ping timeout)
12:59:41 --> jb has joined #instantbird
12:59:59 <clokep_> :)
13:00:08 <nhnt11> Hmm, so I need another interface for the callback object
13:00:26 <clokep_> You have to add a method to prplIAccount and then have some type for the callback, yes.
13:02:00 <-- mpmc has quit (Connection reset by peer)
13:10:54 * qheaden_away is now known as qheaden
13:11:35 <qheaden> Hello everyone.
13:16:33 <clokep_> Hello qheaden.
13:16:38 <instantbot> clokep@gmail.com granted feedback for attachment 2622 on bug 2055.
13:16:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
13:17:02 <clokep_> qheaden: I tried some of your Yahoo code the other day...I apparently typed my password in wrong and immediately got locked out of my account, it look like it attempted the auto-reconnect when a wrong password was given. :(
13:17:55 <flo-retina> clokep_: I'm not sure inheriting from imIStatusInfo is a great idea, but it's absurd, and I don't think it would be difficult to change it later if we decide we can do something better… So I don't really mind either way.
13:17:58 --> mconley has joined #instantbird
13:18:09 <flo-retina> *it's not absurd
13:18:32 * flo-retina hates it when forgetting a few letters changes completely the meaning of the whole sentence :(
13:18:42 <qheaden> clokep_: What?!?! I'll look into it.
13:19:48 <qheaden> At least we know the account lockout error is working. ;)
13:22:38 <nhnt11> clokep_: That's your only comment? Yay :)
13:25:17 <nhnt11> clokep_: Could you please try this when you've got a minute? (I suppose it'll be after work?) http://log.bezut.info/instantbird/130721/#m173
13:27:08 <clokep_> qheaden: Yes. :P My guess is that you're not checking if the account is in a disconnected state when the socket disconnects.
13:27:16 <clokep_> nhnt11: If you remind me after work. ;)
13:27:21 <nhnt11> Sure.
13:27:30 <clokep_> nhnt11: That's my only comment, but I didn't look for nits or anything, just the overall design.
13:27:35 <clokep_> And quickly. :)
13:28:04 <nhnt11> That's alright, it still means I understood all your comments
13:31:15 <aleth> nhnt11: re the LIST interface, you might want to keep the possibility of returning the results in batches to the caller, as the whole process may take some time if they are not already cached on the account.
13:40:58 <nhnt11> aleth: Noted.
13:41:10 <clokep_> I'm sure that could be modified later, if need be.
13:41:53 <nhnt11> Yeah should be simple enough (I think)
13:51:46 <clokep_> nhnt11: Are you being blocked by anything or just waiting for that review?
13:53:23 <nhnt11> clokep_: Not blocked. Considering the new patch has received generally positive reactions from you all, I've started on the LIST work
13:53:52 <clokep_> qheaden: Once you can figure out that psasword issue btw I'll take a look over the new patch.
13:53:58 * clokep_ is afraid it'll involve some reorganization. :)
13:54:26 <qheaden> clokep_: OK
14:12:59 <aleth> nhnt11: iirc flo suggested that for now you request LIST info for the first time when the filter string is nonzero for the first time.
14:13:18 <aleth> I hope to take a closer look at your new patch later
14:19:48 <-- aleth has quit (Quit: Ciao)
14:21:54 --> mpmc has joined #instantbird
14:25:39 <nhnt11> aleth: That sounds good.
14:26:47 <-- novabyte has quit (Quit: bye bye)
14:39:11 * qheaden is confused as to why his plug-in keeps trying to reconnect. :-S
14:50:53 <qheaden> clokep_: Okay, I think your suggestion worked. I added a check for the account being disconnected in onConnectionClosed.
14:59:30 <-- jb has quit (Ping timeout)
15:01:48 <nhnt11> Aaah
15:02:03 <nhnt11> I was debugging a problem with l10nHelper
15:02:18 <nhnt11> It turns out I've typed chrome://instantbird/locale*s* instead of locale xD
15:02:29 <flo-retina> I didn't know l10nHelper had problems ;)
15:02:46 <nhnt11> flo-retina: A problem with using it*
15:02:47 <flo-retina> a debug build would have helped in that case
15:02:57 <nhnt11> I have a debug build
15:03:01 <nhnt11> And am using it.
15:03:08 <nhnt11> Didn't see anything that helped much :/
15:03:30 <flo-retina> there should be a message in the terminal saying that there was an attempt to access a chrome file that doesn't exist
15:03:47 <nhnt11> Ah
15:03:53 <nhnt11> I was looking at Errors in the error console
15:03:56 <nhnt11> it shows up in Messages
15:04:10 --> jb has joined #instantbird
15:04:26 <flo-retina> I'm talking about the terminal (stdout/stderr), not the error console (that shows almost the same thing with a regular build)
15:05:36 <nhnt11> Oh really? And my terminal doesn't show /anything/ because I open the build using |$open mozilla/dist/InstantbirdDebug.app|
15:05:53 <qheaden> clokep_: So other than being reported as disconnected, when will using !connected be at an advantage than using disconnected?
15:06:26 <nhnt11> Hmm, launching instantbird-bin from inside the package seems to show a lot more stuff
15:06:31 <nhnt11> than what I can see in the error console
15:08:09 <clokep_> qheaden: !connected means disconnecting or disconnected or connecting
15:08:21 <qheaden> clokep_: Ahh okay.
15:08:52 <clokep_> qheaden: I'm NOT saying it's the right thing to do.
15:08:57 <clokep_> I'm saying you need to think about it. ;)
15:09:03 * clokep_ has too many things going on to go through the logic right now.
15:09:09 <clokep_> You could also just check what other protocols do. :p
15:09:30 <qheaden> clokep_: I've tried it, and it seems to work well.
15:10:09 <qheaden> clokep_: The problem is that disconnects are being reported twice, because on an error, the Yahoo pager server closes the socket, firing onConnectionClosed.
15:10:17 <qheaden> So adding a check there is the best thing to do.
15:11:17 <clokep_> Yes, I know that. It's the check I told you to add. :P
15:11:42 <clokep_> OK, that should be fine then.
15:17:31 <qheaden> clokep_: Locked two of my accounts in the process. :-S
15:17:45 <clokep_> qheaden: Well hopefully that won't happen anymore. :)
15:17:51 <qheaden> :)
15:27:29 <-- jb has quit (Ping timeout)
15:33:33 <-- gerard-majax__ has quit (Ping timeout)
15:33:39 <qheaden> clokep_: So I'm going to work on more tests today.
15:34:58 --> aleth has joined #instantbird
15:34:58 * ChanServ sets mode +h aleth 
15:47:35 <-- nhnt11 has quit (Client exited)
15:47:47 --> nhnt11 has joined #instantbird
15:54:48 * flo-retina has just started a real conversation with the awesometab for the first time :) (real conversation = I needed to say something to someone, as opposed to I wanted to play with the tab).
16:01:29 * nhnt11 has been using it pretty often
16:01:46 * clokep_ doesn't ever close his tabs. :(
16:01:57 --> Nirgali has joined #instantbird
16:02:05 <flo-retina> clokep_: I don't either
16:02:18 <qheaden> clokep_: I'm still a little fuzzy on what needs to be and what can be tested.
16:02:49 <clokep_> qheaden: OK, what do we test currently?
16:03:00 <qheaden> clokep_: We test YahooLoginHelper and YahooPacket.
16:04:41 <clokep_> qheaden: OK. Does everything else pretty much involve UI?
16:04:49 <qheaden> clokep_: I think so.
16:04:49 <clokep_> flo-retina: Any idea what else we should / can test?
16:05:04 <flo-retina> maybe test the world? :-P
16:05:23 <qheaden> YahooLoginHelper and YahooPacket are the foundation of everything else. YahooSession is there, but its methods are invoked by UI actions.
16:05:37 <qheaden> And YahooSession involves a real connection to a server.
16:05:48 <flo-retina> clokep_: stuff that "involves UI" isn't necessarily difficult to test. You can just check that the correct notifications are emitted.
16:06:04 <flo-retina> clokep_: it's the stuff that involves a Yahoo server implementation that may be trickier to test / not worth it.
16:10:54 <nhnt11> flo-retina: So I want to finalize the Possible* naming. Will PossibleConvFromContact, ExistingConversation, and PossibleConvFromChat be acceptable to you?
16:11:17 <nhnt11> (I see that the discussion on that morphed into a discussion on the LIST stuff and never got finished)
16:12:01 <flo-retina> what's a chat?
16:12:30 <flo-retina> Isn't a Chat already a conversation? I think you meant "PossibleChat" rather than "PossibleConvFromChat".
16:13:10 <-- nhnt11 has quit (Client exited)
16:13:13 --> nhnt11 has joined #instantbird
16:13:41 <nhnt11> flo-retina: Er, PossibleConvFromChatRoom
16:13:54 <flo-retina> can we find a longer name?
16:14:04 <nhnt11> It's not already a conversation, it'll be used to create one from LIST data
16:14:06 <nhnt11> Heh :P
16:14:16 <flo-retina> I just suggested PossibleChat
16:14:22 <flo-retina> what's wrong with it?
16:14:25 <nhnt11> Nothing
16:14:28 <nhnt11> I'll use it
16:14:30 <nhnt11> Not objecting.
16:14:55 * flo-retina suspects nhnt11 is tired of bikeshedding names and will just accept whatever is suggested :-P.
16:15:32 <nhnt11> flo-retina: Yes! PossibleConvFromContact isn't too long then? :S
16:15:46 <instantbot> aleth@instantbird.org cancelled review?(aleth@instantbird.o rg) for attachment 2622 on bug 2055.
16:15:47 <instantbot> aleth@instantbird.org granted feedback for attachment 2622 on bug 2055.
16:15:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
16:15:53 <flo-retina> do you have another suggestion?
16:16:13 <nhnt11> Not really
16:16:34 <aleth> I put a suggestion in my comment ^^ but basically I think we've all pretty much converged ;)
16:16:42 <nhnt11> I like aleth's suggestions 
16:16:45 <nhnt11> in his new comment
16:16:48 <nhnt11> Yeah
16:17:02 <qheaden> clokep_: I see I need to add more tests for some of the new methods I had added to YahooPacket. I'll start with that.
16:17:15 <flo-retina> aleth: http://log.bezut.info/instantbird/130722#m116 :-P
16:17:34 <nhnt11> Yeah
16:17:35 <aleth> flo-retina: Where did you think I got the idea from? :P
16:17:51 <flo-retina> so you are suggesting we use the "even worse" suggestion? :-P
16:18:32 <nhnt11> I like PossibleIM and PossibleChat actually
16:18:37 <flo-retina> btw, I think PossibleConvIM and PossibleConvFromContact aren't exactly the same
16:18:46 <nhnt11> flo-retina: I just had the same thought
16:18:49 <aleth> flo-retina: I reconsidered after remembering there was a prplIConvIM, which I had completely forgotten about :D (I still dislike ConvIM but as it already exists...)
16:18:58 <flo-retina> PossibleConvIM would also cover cases where you want to start again a private IRC conversation with someone not in the blist
16:19:02 <nhnt11> PossibleConvIM could also be related to buddies that aren't contacts
16:19:03 <nhnt11> yeah
16:19:28 <aleth> flo-retina: "PossibleConvIM would also cover cases where you want to start again a private IRC conversation with someone not in the blist" is exactly why in my comment I suggested moving away from ...Contact.
16:19:48 <flo-retina> "buddies that aren't contacts" doesn't make much sense ;)
16:19:57 <nhnt11> aleth: The current PossibleContact kinda /depends/ on being related to a contact
16:20:01 <nhnt11> Since it builds from one.
16:20:15 <flo-retina> aleth: the current implementation is just a wrapper above an imIContact
16:20:17 <nhnt11> flo-retina: Account buddies*? I don't know, excuse my naming difficulties here.
16:20:40 <flo-retina> nhnt11: if you have an account buddy, you have a buddy and you have a contact (even a dummy one) automatically.
16:20:50 <nhnt11> Oh
16:21:31 <flo-retina> but having an account buddy depends on adding to the contact list ;)
16:22:53 <aleth> nhnt11: Hmm, that's true, but that is something to be solved when you actually have (from the logs) conversations without contacts, as I'm not sure what you'll be initializing from in that case at this point.
16:23:04 <nhnt11> aleth: "possibly causing it to repaint much more often than needed" - executeSoon was used to avoid this.
16:23:25 <aleth> nhnt11: Great, I was just asking to make sure you dont call the filter function tons of times ;)
16:24:29 <flo-retina> aleth: " createConversation: this.contact.createConversation," unless .contact is a lazy getter
16:24:34 <flo-retina> (I haven't checked)
16:24:38 <nhnt11> flo-retina: It is.
16:24:55 <nhnt11> Er, no
16:24:57 <nhnt11> It's not lazy
16:25:01 <nhnt11> Just a getter.
16:25:07 <flo-retina> s/lazy//
16:25:29 <aleth> flo-retina: I wonder whether the correct way to solve that issue of conversations with non-contacts is to fix the various bugs we have around that issue (presence etc) by having at least a dummy contact in that case (while the conv is open at least, and therefore providing a consistent place to get info from).
16:25:30 <flo-retina> I meant "if you are purposefully not keeping a reference to the value of this.contact"
16:26:06 <flo-retina> aleth: maybe. I don't see immediately what the implications would be.
16:26:45 <aleth> flo-retina: maybe. (Also might be too complicated a detour for nhnt11)
16:26:54 <aleth> i.e. take too long
16:27:12 <flo-retina> aleth: hmm, should we create an account buddy immediately whenever a private conversation is started and we don't have an account buddy already, but then create the buddy and contact only if the user adds the account buddy to the list?
16:27:27 <flo-retina> aleth: I don't see how that would work for libpurple accounts.
16:27:59 <nhnt11> Er, so what's the final name I should use for PossibleContact? :S
16:28:04 <flo-retina> aleth: as it looks like a change to the prpl <-> core API. (I suspect on libpurple prpls if you create an account buddy, it adds the buddy to the server stored blist)
16:28:08 <aleth> flo-retina: I don't really know what a workable solution for libpurple would look like.
16:28:09 * nhnt11 figured he would just ask directly
16:28:36 <flo-retina> aleth: maybe we could hack around it and make purplexpcom return a stub and not pass any data to libpurple.
16:29:20 <flo-retina> nhnt11: what's your preferred suggestion?
16:29:22 <aleth> flo-retina: That might work
16:29:55 <nhnt11> flo-retina: I don't really have one.
16:30:03 <nhnt11> I kinda like PossibleContactConversation though
16:30:36 <nhnt11> As opposed to PossibleConvFromContact. And considering it's a wrapper for an imIContact, PossibleConvIM doesn't seem right to me.
16:35:50 <flo-retina> nhnt11: it's not a "PossibleContact"
16:36:00 <flo-retina> and I don't think anybody suggested that name :-P
16:36:07 <nhnt11> they didn't
16:36:15 <nhnt11> I didn't mean /PossibleContact/Conversation
16:36:20 <nhnt11> I meant Possible/ContactConversation/
16:36:31 <flo-retina> heh
16:36:46 <nhnt11> At this point I really just want to use whatever /you/ prefer :P
16:37:45 * flo-retina has a headache and doesn't really care much which of PossibleConvFromContact or PossibleConvIM we go with.
16:38:13 <nhnt11> I'm going with PossibleConvFromContact then.
16:38:34 <flo-retina> great!
16:38:55 <flo-retina> I guess I'll wait for the next iteration of the patch before reviewing
16:39:20 <flo-retina> all these search and replace shouldn't take too long, and will hopefully make stuff way easier to understand :)
16:39:27 <nhnt11> It's done.
16:45:03 --> Mook_as has joined #instantbird
16:46:57 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:48:10 <-- Mook_as has quit (Quit: Mook_as)
16:48:19 <instantbot> New Core - General bug 2064 filed by atuljangra66@gmail.com.
16:48:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2064 nor, --, ---, nobody, NEW, file link backend for instantbird
16:48:31 --> Mook_as has joined #instantbird
16:49:11 <nhnt11> aleth: Do you think this comment is ok? http://pastebin.instantbird.com/255247
16:50:17 <nhnt11> While I'm asking, this one too: http://pastebin.instantbird.com/255249
16:51:01 <flo-retina> "The source of the conversation" conversation -> possible conversation? :-P
16:51:09 <nhnt11> Ah yes.
16:53:17 <-- dew has quit (Ping timeout)
16:53:18 <aleth> http://pastebin.instantbird.com/255249 Does the awesometab need to differentiate between "from an imIContact" and "from someone we previously had a conversation with"?
16:53:32 <aleth> http://pastebin.instantbird.com/255247 conversation has a typo
16:53:38 <-- nhnt11 has quit (Ping timeout)
16:53:49 <aleth> In both I'd indent the entries nicely in columns.
16:54:01 --> nhnt11 has joined #instantbird
16:54:27 * aleth wonders if nhnt11 misses messages due to his disconnects...
16:54:42 <nhnt11> aleth: I read logs when I realize I've been disconnected.
16:54:51 <nhnt11> The key words are "when I realize" though :P
16:54:54 <nhnt11> In this case, I did.
16:55:19 <aleth> Must be annoying though. Shame you can't auto-fetch from the logs ;)
16:55:28 <nhnt11> :P
16:56:02 <nhnt11> aleth: I think it /does/ need to differentiate, because only contacts will have tags.
16:56:49 <aleth> nhnt11: Just asking. (e.g. you could, when the tag list is empty, just hide the tag icon)
16:57:23 <nhnt11> Right now, the tag icon is only shown when it's a contact.
16:57:29 <nhnt11> As opposed to hiding
16:57:29 <aleth> But like the issue of the constructor, I guess you can leave that until you get to it.
16:57:53 <aleth> For now, they're always contacts ;)
16:58:03 <-- aleth has quit (Quit: Ciao)
16:58:14 <nhnt11> Cool.
17:14:51 <nhnt11> Hmm, I wanted to ask about "Is there enough duplication like this that it would be better to inherit the shared stuff from a JS PossibleConversation object?"
17:17:19 <clokep_> qheaden: Sorry, I ran away to lunch (a co-worker stopped by and asked me to go).
17:17:25 <clokep_> qheaden: Starting with YahooPacket is a good idea.
17:19:41 <qheaden> clokep_: I was away to lunch too. :P
17:26:13 <clokep_> qheaden: So do you know what's going on then?
17:26:54 <qheaden> clokep_: Yeah. I'm currently working on the YahooPacket tests.
17:27:45 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:29:03 <-- nhnt11 has quit (Ping timeout)
17:29:26 --> nhnt11 has joined #instantbird
17:36:27 <nhnt11> If I do Something.prototype = SomethingElse.prototype, and then do Something.prototype.__defineGetter__(val, fn), the getter will be defined for SomethingElse.prototype too right?
17:36:40 <nhnt11> So I should use Something.prototype = new SomethingElse() instead.
17:37:35 * clokep_ has no idea what __define_Getter__ does.
17:37:48 <nhnt11> clokep_: It's used to add getters to existing prototypes
17:38:03 <clokep_> There's also the __proto__ vs. prototype differences which I forget the difference of exactly.
17:38:12 <clokep_> nhnt11: OK, I could have figured that out, I meant I don't know the implications. :)
17:38:17 * clokep_ guesses Mook_as does.
17:39:17 <Mook_as> yes, nhnt11 pretty much as it right
17:39:29 <Mook_as> if you don't want to new SomethingElse, you might want to look at Object.create
17:39:54 <nhnt11> Mook_as: Thanks!
17:42:11 <Mook_as> you're welcome.
17:44:49 <-- Tonnes has quit (Connection reset by peer)
17:46:25 --> Tonnes has joined #instantbird
17:47:55 <nhnt11> I'm not sure I like how this looks: pastebin.instantbird.com/255337
17:48:39 <nhnt11> Clickable link: http://pastebin.instantbird.com/255337
17:49:03 <clokep_> nhnt11: I'm pretty sure you want to set prototype.__proto__ to the parent object.
17:49:41 * nhnt11 looks this up
17:50:15 <clokep_> nhnt11: http://pastebin.instantbird.com/255348
17:50:23 <clokep_> It's how we do everything in jsProtoHelper.
17:50:38 <clokep_> Actually http://pastebin.instantbird.com/255349 is better
17:51:05 <nhnt11> Much better, thanks clokep_!
17:51:18 <clokep_> Assuming it works. ;0
17:52:02 <-- Nirgali has quit (Ping timeout)
17:52:25 --> Nirgali has joined #instantbird
17:54:05 <-- Nirgali has quit (Ping timeout)
17:54:24 <nhnt11> clokep_: It does \o/
17:54:41 --> Nirgali has joined #instantbird
18:03:27 * clokep_ is curious how this code is going to look. :)
18:04:49 <nhnt11> clokep_: LMPBTFY
18:05:15 <nhnt11> http://pastebin.instantbird.com/255352
18:07:23 <clokep_> Not the part I'm interested in. :P
18:07:28 <clokep_> I meant the patch in it's entirety.
18:07:45 <-- nhnt11 has quit (Ping timeout)
18:07:58 <-- mconley has quit (Connection reset by peer)
18:08:08 --> nhnt11 has joined #instantbird
18:08:13 --> mconley has joined #instantbird
18:12:09 <nhnt11> clokep_: I thought you saw it? You left feedback.
18:13:28 <qheaden> clokep_: I'm going to post a new patch on BIO with that account fix just in case someone else wants to test it.
18:14:11 <clokep_> nhnt11: Sorry, I meant the LIST stuff.
18:14:17 <clokep_> I thought that's what you were working on.
18:14:42 <nhnt11> Oh that. I /am/ working on it, just wanted to address aleth's comments and get a new patch up first :)
18:14:43 <clokep_> qheaden: If you want, plus the extra tests.
18:15:23 <qheaden> clokep_: Okay. Did you see my new "extra tests" commit in BitBucket? Just want to make sure you approve of everything.
18:15:33 <clokep_> Florian will appreciate that I just transferred a 150 MB file over file transfer. ;)
18:15:39 <clokep_> qheaden: Yes.
18:15:42 <clokep_> I didn't have any comments.
18:15:50 <qheaden> clokep_: Okay great. :)
18:21:32 <clokep_> qheaden: OK. I'll take another look at it once you upload it, I guess.
18:21:48 <clokep_> I wrote a script to package it as an extension, so we people can try it before we check it in too. ;)
18:22:05 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
18:22:29 --> chrisccoulson_ has joined #instantbird
18:23:08 <qheaden> clokep_: Excellent! I think it needs more user testing than anything.
18:23:57 <instantbot> qheaden@phaseshiftsoftware.com cancelled review?(clokep@gmail.com) for attachment 2613 on bug 1982.
18:23:58 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2623 on bug 1982.
18:24:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
18:26:01 <-- nhnt11 has quit (Ping timeout)
18:26:24 --> nhnt11 has joined #instantbird
18:28:15 <-- chrisccoulson_ has quit (Quit: OSError: [Errno 130] Owner died)
18:37:58 --> atuljangra has joined #instantbird
18:42:48 <clokep_> qheaden: You didn't handle my comment in the bug
18:44:48 <qheaden> clokep_: Oops. You meant the one about yahoo-socket.jsm?
18:45:11 <atuljangra> mconley: ping :D
18:45:30 <mconley> atuljangra: PONG
18:45:55 <clokep_> qheaden: Yes, sir!
18:46:11 * clokep_ had a roommate that used to say that all the time.
18:46:16 <qheaden> :P
18:46:29 <qheaden> clokep_: Also, should we get rid of yahoo-utils.jsm? It's a pretty boring file.
18:46:59 <clokep_> qheaden: Is the function used in multiple places even? :P
18:47:02 <atuljangra> mconley: This is regarding a possible bug in filelink. When we attach multiple files with the same name( different path) then only a single file is uploaded on the server and thus toe corresponding link for all the attachments is same.
18:47:24 <qheaden> clokep_: Actually, yes. yahoo-session.jsm and yahoo.js uses it.
18:47:27 <clokep_> atuljangra: Did you look on BMO for this bug at all?
18:47:30 <clokep_> qheaden: Voila.
18:47:42 <qheaden> clokep_: Keep it then for caching reasons?
18:47:45 <atuljangra> clokep_: No. looking
18:48:21 <clokep_> qheaden: Keep it for now, I'm tempted to just make i tin both files though, it's what...four lines of code?
18:48:37 <mconley> atuljangra: hrm.
18:48:42 <mconley> atuljangra: that wouldn't surprise me, actually
18:48:54 <mconley> :/
18:48:55 <-- nhnt11 has quit (Ping timeout)
18:49:01 <mconley> atuljangra: I'd totally be willing to review patches for that bug...
18:49:04 <qheaden> clokep_: Actually three. We won't need the export, and we already import imXPCOMUtils.jsm.
18:49:18 --> nhnt11 has joined #instantbird
18:49:36 <clokep_> qheaden: Hm, I'd say just go ahead and put it in both them.
18:49:44 <qheaden> clokep_: I agree.
18:49:59 <atuljangra> mconley: Ok. :) What should be the behavior in this situation according to you.
18:50:08 <clokep_> atuljangra: Please definitely file a bug for it, but don't worry about that quite yet please.
18:50:26 <mconley> atuljangra: files that have the same name but different paths should definitely be regarded as distinct entities
18:50:34 <mconley> atuljangra: the path should be the discriminator there
18:50:39 <atuljangra> clokep_: Ok.
18:50:41 --> novabyte has joined #instantbird
18:50:49 <atuljangra> mconley: Yes, but currently it doesn't seem so.
18:50:59 <mconley> atuljangra: correct - we has bug
18:51:05 <mconley> :)
18:51:13 <atuljangra> mconley: Okay. :)
18:52:39 <qheaden> clokep_: I think we can split yahoo-session.jsm up a little bit. It is getting big, and I'm starting to get lost in it.
18:52:56 <qheaden> The whole plug-in is only two source files, so that should say something about size. ;)
18:53:20 <clokep_> qheaden: OK! How so?
18:53:38 <qheaden> clokep_: For example, YahooPacket should be in its own source file.
18:54:44 <nhnt11> clokep_: Sorry about that. Very little of my WIP is in those commits
18:54:54 <nhnt11> I should've warned not to look at it much.
18:55:26 <nhnt11> Something went wrong with my mq
18:55:31 * clokep_ cries.
18:55:38 <clokep_> qheaden: That would be reasonable, yes.
18:55:54 <clokep_> ymsg.jsm or yahoo-packet or yahoo-message or something, sure.
18:55:56 <qheaden> clokep_: How about moving YahooLoginHelper out as well? It is a pretty large class.
18:56:21 <clokep_> qheaden: Let's take out the message first and see how that goes
18:56:24 <qheaden> clokep_: Perhaps YahooLoginHelper, the lazy _ localization getter can be placed in yahoo-utils.jsm?
18:56:28 <qheaden> Okay.
18:56:50 * atuljangra is not able to find the bug number for this bug :s
18:56:57 <clokep_> qheaden: The "lazy _ localization getter"?
18:57:09 <clokep_> atuljangra: Do you mean it isn't filed already or what?
18:57:38 <qheaden> clokep_: The lazy getter that was defined in yahoo-utils.jsm? It is an underscore.
18:58:29 <atuljangra> m conley just mentioned "we has bug" so I guess it should already be there. I'll just file a new one, we can mark it as duplicate if we find another for the same problem
18:58:48 <clokep_> atuljangra: He just meant you found a bug.
18:58:56 <clokep_> As in "we have a bug in the code" not "we have a bug on file"
18:59:15 <atuljangra> clokep_: Okay, sorry for misunderstanding. I'll file a bug
18:59:19 <clokep_> qheaden: Right, Oh. I see what you're saying now.
18:59:30 <clokep_> qheaden: Under no circumstances should YahooLoginHelper be in yahoo-utils.
18:59:35 <clokep_> Maybe I could see YahooPacket in it.
18:59:38 <clokep_> Not YahooLoginHelper.
19:00:19 <qheaden> clokep_: I just won't use yahoo-utils.jsm. I really don't see YahooPacket as a "utility". Although it does help in creating packets, but it is a more fundamental class.
19:00:46 <-- Nirgali has quit (Ping timeout)
19:01:09 <clokep_> qheaden: I think you're beginning to understand why Florian hates "utils" files. ;)
19:01:17 <qheaden> :P
19:02:47 <qheaden> In any case, we definitely need smaller modules. I'm starting to get lost in the source now.
19:03:36 <clokep_> OK, start by moving the packet code out.
19:03:47 <clokep_> How long of files are they?
19:04:18 <qheaden> clokep_: yahoo-socket.jsm is 869 lines.
19:04:33 <qheaden> Its not so much the lines, but the fact that so many classes are stuffed under one source.
19:04:47 * clokep_ was just curious.
19:09:44 <clokep_> And nhnt11 Don't worry about that. i just saw it and figured I'd comment. :-D
19:10:18 * nhnt11 was embarrassed :]
19:18:36 <nhnt11> What's the right way to name lazy l10n getters when you have more than one?
19:18:52 <nhnt11> _get
19:18:58 <nhnt11> ^typo, sorry
19:20:49 <clokep_> nhnt11: Usually it's _<filename> if there are multiple.
19:21:00 <nhnt11> clokep_: Without the .properties extension?
19:21:25 <clokep_> Yes.
19:21:33 <clokep_> foo.properties would be _foo.
19:21:39 <nhnt11> ok
19:27:13 <atuljangra> clokep_: I'm uploading a patch, it is around 15K lines of code as it includes many new files.
19:27:30 <-- nhnt11 has quit (Ping timeout)
19:27:52 --> nhnt11 has joined #instantbird
19:27:53 <qheaden> 15K lines? :-O
19:28:27 <clokep_> qheaden: A lot of it is copy and pasted from Thunderbird.
19:28:31 <atuljangra> 14.5K actually. :s Most of it is copy pasted code from TB.
19:28:31 <clokep_> atuljangra: OK.
19:28:41 <qheaden> Ahh Okay. :)
19:28:45 <nhnt11> haha
19:29:05 <atuljangra> nhnt11: :)
19:29:16 * qheaden was about to suggest atuljangra submit a world record for fastest typer.
19:29:31 <atuljangra> haha
19:32:09 --> nhnt11-testing has joined #instantbird
19:32:12 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:33:34 <clokep_> atuljangra: Does that work with MUCs btw?
19:35:13 <nhnt11> I like this code shortening for some reason: http://pastebin.instantbird.com/255436 :)
19:35:16 <qheaden> clokep_: What do you think? http://pastebin.instantbird.com/255437
19:36:08 <qheaden> Oops. Forgot to hg add yahoo-packet.jsm. :P
19:36:45 <qheaden> clokep_: This is better http://pastebin.instantbird.com/255444
19:36:46 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:37:19 --> atuljangra has joined #instantbird
19:38:08 <instantbot> atuljangra66@gmail.com requested feedback from florian@instantbi rd.org for attachment 2624 on bug 2064.
19:38:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2064 nor, --, ---, atuljangra66, NEW, file link backend for instantbird
19:39:23 <-- nhnt11 has quit (Ping timeout)
19:39:44 --> nhnt11 has joined #instantbird
19:40:58 --> chrisccoulson has joined #instantbird
19:41:21 <clokep_> qheaden: Why the change from kPacketType to YahooPacketType? :-S
19:41:47 <clokep_> qheaden: Honestly I dislike the amount of stuff that has to be exported now.
19:42:27 <qheaden> clokep_: So should we just keep it the way it is?
19:43:25 * clokep_ isn't sure.
19:43:31 <clokep_> I think I like it the way it is now, unfortunately. :(
19:43:48 <qheaden> clokep_: No prob. That's why I pastebin'd it first.
19:44:01 <clokep_> qheaden: Keep it how it is for now. If you keep finding issues we'll split it out.
19:44:12 <qheaden> clokep_: Yes, sir! :P
19:48:11 <atuljangra> Who is maintaining the logs at http://log.bezut.info/? Just curious. 
19:48:29 <-- nhnt11 has quit (Ping timeout)
19:48:30 <qheaden> atuljangra: Morian I think.
19:48:31 <clokep_> instantbot
19:48:32 <instantbot> clokep_! dude!
19:48:44 <clokep_> Moria n runs instantbot, yes.
19:48:51 --> nhnt11 has joined #instantbird
19:48:52 * qheaden completely skipped the word "logs"
19:49:14 <atuljangra> Okay. :D
19:49:34 <clokep_> Why?
19:49:50 <atuljangra> As I said, just curious. :D
20:01:39 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2622 on bug 2055.
20:01:40 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2625 on bug 2055.
20:01:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
20:02:59 <-- novabyte has quit (Ping timeout)
20:06:59 <-- nhnt11 has quit (Ping timeout)
20:06:59 --> novabyte has joined #instantbird
20:07:22 --> nhnt11 has joined #instantbird
20:09:10 <clokep_> qheaden: So i have a script that is unfortunately on my hard drive....which will take an applied Yahoo patch and package it into an extension.
20:09:18 <clokep_> I'm going to try to make it compatible w/ Thunderbird too.
20:09:20 <clokep_> So we can get more testers.
20:09:41 <qheaden> clokep_: Okay great. I appreciate it. :)
20:10:51 <clokep_> qheaden: I'll probably let people know during the TB status call tomorrow.
20:11:00 * clokep_ is embarrassed of the script...
20:11:01 <qheaden> clokep_: Thanks! :)
20:11:06 <clokep_> But I can post it if someone is interested. ;)
20:14:33 <clokep_> aleth, Mic: Do you know if https://bugzilla.mozilla.org/show_bug.cgi?id=896652 is something that we've possible fixed and not synced yet?
20:17:57 <atuljangra> If aFile is from trash, then this fails: let url = Services.io.newFileURI(file); 
20:17:58 <atuljangra> I guess this is expected behavior :s
20:18:16 --> Nirgali has joined #instantbird
20:18:19 <-- Nirgali has quit (Quit: Nirgali)
20:19:13 <clokep_> atuljangra: Yes, that's probably expected.
20:19:19 <atuljangra> Ok :)
20:22:42 --> EionRobb has joined #instantbird
20:23:34 <nhnt11> clokep_: Do you have any idea what I would need to do for LIST with libpurple accounts?
20:23:41 <nhnt11> I really don't have much of an idea.
20:24:09 <clokep_> nhnt11: "LIST" is an IRC term, please stop using it as a generic term. :)
20:24:17 <nhnt11> Sorry :P
20:24:29 * nhnt11 finds it convenient
20:25:28 <nhnt11> Looks like I need to be working in purple
20:25:32 <nhnt11> Account.cpp *
20:25:42 <nhnt11> I may be completely wrong though
20:26:12 <clokep_> nhnt11: I find it confusing, looks like you'd have to implement http://lxr.instantbird.org/pidgin2.6.3/search?string=purple_roomlist_ stuff in purplexpcom.
20:27:26 <clokep_> http://lxr.instantbird.org/pidgin2.6.3/source/libpurple/roomlist.h is the API.
20:27:34 <clokep_> (This is on pidgin.im somewhere as an HTML page, btw.)
20:28:25 <nhnt11> Thanks!
20:28:46 <nhnt11> I think I'll get IRC working before looking at this ;)
20:29:05 <clokep_> nhnt11: Please do. :)
20:29:24 <clokep_> We probably will want you to get the rest of the statistics stuff working before doing that, in fact.
20:29:37 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:31:35 <nhnt11> Yeah, it looks complicated.
20:32:57 <-- novabyte has quit (Quit: bye bye)
20:40:15 --> Nirgali has joined #instantbird
20:40:16 <-- Nirgali has quit (Quit: Nirgali)
20:41:33 --> Nirgali has joined #instantbird
20:41:33 <-- Nirgali has quit (Quit: Nirgali)
20:42:17 --> rosonline has joined #instantbird
20:44:51 --> Nirgali has joined #instantbird
20:44:52 <-- Nirgali has quit (Quit: Nirgali)
20:48:47 --> unghost has joined #instantbird
20:49:24 <-- EionRobb has quit (Connection reset by peer)
20:58:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:58:19 --> nhnt11 has joined #instantbird
21:02:39 * qheaden is now known as qheaden_away
21:05:57 <atuljangra> instantbot: uuid
21:05:58 <instantbot> 43cb035e-5f10-4a61-b7fb-2a22ac410d14 (/msg instantbot cid for CID form)
21:13:36 <nhnt11> Can methods in IDL files take arrays as parameters?
21:13:41 <nhnt11> Mook_as: ^
21:17:21 --> clokep has joined #instantbird
21:17:21 * ChanServ sets mode +o clokep 
21:18:18 <Mook_as> yes, [array, size_is(a pruint32 parameter)]
21:18:58 <nhnt11> ok.
21:20:13 <nhnt11> So this would work? ([array, size_is(aCount)] in prplIChatRoom aRoom, unsigned long aCount)
21:20:31 <nhnt11> s/, unsigned/, in unsigned/
21:22:04 <-- skeledrew has quit (Ping timeout)
21:24:38 <clokep> Mobile users, everywhere!
21:24:55 <Mook_as> yeah, that should work, I think
21:25:36 <atuljangra> clokep: \m/
21:25:58 --> Nirgali has joined #instantbird
21:25:59 <-- Nirgali has quit (Quit: Nirgali)
21:26:08 * clokep suddenly realizes how many people he IMs on their phones. ;)
21:30:09 * nhnt11 is testing his LIST code
21:30:33 <nhnt11> Great, compile error :P
21:31:12 <clokep> :-D
21:31:20 <clokep> Did you add th efunction to purplexpcom?
21:31:22 <nhnt11> Minor though, fixed it.
21:31:41 <nhnt11> No. New compile error probably related to that.
21:31:57 <clokep> qheaden_away: Can you use a better name than "diff.patch" when you upload patches please.
21:32:09 <clokep> You have to modify purplexpcom to match your idl changes.
21:32:17 <nhnt11> I realized ;)
21:32:24 --> Nirgali has joined #instantbird
21:32:25 <nhnt11> Would you like to see a diff of my rough WIP?
21:32:26 <-- Nirgali has quit (Quit: Nirgali)
21:32:32 <nhnt11> Since you were curious :P
21:33:54 <clokep> Sure.
21:37:08 <nhnt11> http://pastebin.instantbird.com/255575
21:37:09 <nhnt11> clokep: ^
21:37:38 <nhnt11> Pretty simple-ish
21:37:43 <-- mconley has quit (Broken pipe)
21:37:54 * clokep still doesn't know what prplIRequestChatRoomsCallback does. ;)
21:38:10 <nhnt11> clokep: It's an interface that a callback object must implement
21:38:37 <nhnt11> The receiveChatRooms method is called on the callback when the list end is reached
21:38:43 <nhnt11> (for now)
21:39:35 <-- clokep has quit (Ping timeout)
21:40:13 --> clokep has joined #instantbird
21:40:13 * ChanServ sets mode +o clokep 
21:40:38 <clokep> nhnt11: Seems mostly reaosnable.
21:40:40 <clokep> Bah this didn't go through: nhnt11: Why can't we just use observers like everything else to do w/ the account?
21:41:14 <nhnt11> Hmm.
21:41:31 <nhnt11> I guess that makes sense.
21:42:38 <nhnt11> I suppose I should implement the flow here properly before I touch purplexpcom
21:46:05 --> EionRobb has joined #instantbird
21:46:28 --> skeledrew has joined #instantbird
21:47:39 <-- nhnt11 has quit (Ping timeout)
21:48:09 --> nhnt11 has joined #instantbird
21:51:29 <-- nhnt11 has quit (Ping timeout)
21:51:53 --> nhnt11 has joined #instantbird
22:04:56 --> mconley has joined #instantbird
22:06:04 <nhnt11> Good night.
22:07:45 <clokep> \m/
22:07:47 <clokep> As you kids like to say.
22:13:26 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:14:29 <clokep> XPI of qheaden_away's work: https://bugzilla.instantbird.org/attachment.cgi?id=2626
22:15:07 <-- mconley has quit (Input/output error)
22:15:21 <clokep> And the gross Makefile I used. :) http://pastebin.instantbird.com/255624
22:24:20 --> Mic has joined #instantbird
22:24:21 * ChanServ sets mode +h Mic 
22:25:10 <-- mpmc has quit (Connection reset by peer)
22:25:12 <Mic> clokep: I don't think that we have such a special character bug fixed (or even filed).
22:26:09 <clokep> Thanks.
22:26:15 <clokep> I didn't think so, but I know we've had similar things?
22:26:59 <Mic> Let me look through our XMPP bugs...
22:29:05 <Mic> Bug 1203 ?
22:29:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, 1.2, florian, RESO FIXED, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP
22:32:15 <atuljangra> clokep: \m/
22:32:52 <atuljangra> And Makefile isn't gross :D
22:33:07 <Mic> The fix from bug 1203 is included in comm-central by the way.
22:33:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1203 maj, --, 1.2, florian, RESO FIXED, No longer able to log into Facebook Chat via Instantbird since patches enabling JS XMPP
22:34:10 <Mic> http://mxr.mozilla.org/comm-central/source/chat/protocols/xmpp/xmpp-authmechs.jsm#36, https://bugzilla.instantbird.org/attachment.cgi?id=1080&action=diff#a/chat/protocols/xmpp/xmpp-authmechs.jsm_sec1
22:34:39 <atuljangra> I'll sleep now. Good Night :D
22:35:23 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
22:41:14 <Mic> Good night!
22:41:25 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:50:35 <-- nhnt11 has quit (Input/output error)
22:51:27 --> jb has joined #instantbird
22:54:39 --> dew has joined #instantbird
22:57:19 --> wnayes has joined #instantbird
23:07:05 * qheaden_away is now known as qheaden
23:07:14 <qheaden> clokep: Hey. Sorry about the diff.patch thing. :)
23:28:30 <-- clokep has quit (Ping timeout)
23:35:07 * qheaden is now known as qheaden_away
23:44:57 --> Nirgali has joined #instantbird
23:45:06 <-- Nirgali has quit (Quit: Nirgali)