#instantbird log on 07 20 2013

All times are UTC.

00:34:31 <atuljangra> flo-retina: clokep http://pastebin.instantbird.com/251595
00:42:59 <nhnt11> Is it possible to define an AUTF8String constant in idl files?
00:43:03 <nhnt11> atuljangra: Do you know? ^
00:44:35 <atuljangra> nhnt11: Yes it is possible.
00:44:45 <atuljangra> Wait lemme show you an example.
00:45:16 <atuljangra> nhnt11: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/public/purpleICoreService.idl#16
00:45:32 <atuljangra> flo-retina clokep discard that error.
00:45:38 <nhnt11> Er, that's not exactly what I wanted
00:45:44 <nhnt11> I need to define a literal in the idl
00:45:57 <nhnt11> Like, const AUTF8String constant = "this is a constant"
00:46:04 <atuljangra> oh.
00:46:08 <atuljangra> Yes you can do that.
00:46:17 <nhnt11> I tried, and it says syntax error :(
00:46:23 <atuljangra> (at least logically?)
00:46:34 <atuljangra> oh, lemme try it.
00:46:57 <Mook_as> no, consts can only be int32, I think
00:47:10 <nhnt11> Oh.
00:47:15 <nhnt11> Okay, thanks.
00:47:22 <atuljangra> Oh okay. Yes, there is no example of the same.
00:47:27 <atuljangra> Thanks Mook_as :D
00:57:10 <instant-buildbot> build #425 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/425
01:13:16 <-- Mook_as has quit (Quit: Mook_as)
01:23:14 <nhnt11> New conv tab looks nice with retina icons: http://puu.sh/3H2s9.png
01:23:59 <nhnt11> Nearly time for a patch, I think..
01:24:54 <atuljangra> nhnt11: Nice work :D
01:25:33 <nhnt11> atuljangra: Thanks. Slow work, though :P
01:25:43 <atuljangra> :D
01:35:59 <-- mpmc has quit (Connection reset by peer)
01:40:39 <atuljangra> flo-retina: I've produced the working example. I'll push it to the repo before you wake up :)
01:46:38 <-- FireFly_TB has quit (Ping timeout)
01:50:33 --> FireFly_TB has joined #instantbird
01:53:08 --> nhnt11-testing has joined #instantbird
01:53:36 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
01:54:59 --> nhnt11-testing has joined #instantbird
01:58:05 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:00:52 --> nhnt11-testing has joined #instantbird
02:01:03 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:02:53 --> nhnt11-testing has joined #instantbird
02:03:49 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:04:57 --> nhnt11-testing has joined #instantbird
02:05:01 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:07:31 <atuljangra> flo-retina: You can try the working proof. I've uploaded it on my repo: branch filelink.
02:08:43 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
02:13:23 --> nhnt11-testing has joined #instantbird
02:14:45 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:16:30 --> nhnt11-testing has joined #instantbird
02:16:51 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:20:55 --> nhnt11-testing has joined #instantbird
02:21:21 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:22:17 --> clokep has joined #instantbird
02:22:17 * ChanServ sets mode +o clokep 
02:23:37 <nhnt11> Yay it's clokep. Can you think of any reason a prplIConvChat instance wouldn't have a topic attribute even if the channel does have one?
02:24:04 <clokep> nhnt11: Doesn't have or isn't set?
02:24:10 <nhnt11> Isn't set. sorry
02:24:11 <clokep> Are you talking about IRC or some other protocol?
02:24:14 <nhnt11> IRC
02:24:21 <clokep> Not all channels have topics.
02:24:27 <nhnt11> I'm sure the channel has a topic
02:24:31 <nhnt11> It's #chatdev ;)
02:24:38 <nhnt11> It used to show up
02:24:49 <nhnt11> I can't figure out what I've done that would make it stop working.
02:25:12 <nhnt11> I've checked the imIConversation instance I'm using. The title is correct ("#chatdev") and it implements the necessary interfaces
02:25:35 <nhnt11> This isn't only for #chatdev, it's not working for /any/ channel
02:27:16 <nhnt11> Ok, now I'm getting errors at least. Weird though. Apparently the prpl conversation returned by Services.conversations.getUIConversation(aID) is null
02:28:30 <clokep> I agree that http://log.bezut.info/instantbird/130719/#m999 is the wrong behavior btw.
02:28:56 <nhnt11> clokep: I have that fixed
02:30:08 <clokep> nhnt11: getUIConversation doesn't return a prpl conversation?
02:30:25 <nhnt11> getUIConversation is supposed to return an imIConversation
02:30:46 <nhnt11> I have the id of such an imIConversation
02:31:09 <nhnt11> And I'm trying to get the instance using getUIConversation(getConversationById(id))
02:31:25 <clokep> OK.
02:31:28 <nhnt11> Oh, do prpl convs have different id's than ui convs?
02:31:56 * nhnt11 seems to be confused by all the id's everywhere.
02:33:52 <nhnt11> Hmm, I guess that wasn't the problem.. changed it and it still doesn't work
02:34:37 * clokep isn't sure...
02:34:53 <clokep> We seem to set it here: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#519
02:35:06 <nhnt11> This was all working when I was storing the imIConversation instance...
02:39:28 <clokep> :-/
02:39:31 <clokep> That's not good....
02:39:39 <clokep> Can you show me actual code of what you're doing?
02:40:07 <nhnt11> Ok
02:43:59 <clokep> It's too late for abstract talk. :P
02:44:11 <nhnt11> clokep: http://pastebin.instantbird.com/251716
02:44:14 <nhnt11> :P
02:44:29 <nhnt11> I've pasted code in the order of execution..
02:44:46 <clokep> Where am I looking?
02:45:26 <clokep> Line 43?
02:45:32 <nhnt11> Er, the part where it's fetching the imIConversation from the id is line 64
02:46:28 <nhnt11> But yes also line 43
02:46:29 <clokep> nhnt11: Should thist just store the uiConv in _uiConv and then return it?
02:47:01 <nhnt11> clokep: The idea was to not store those
02:47:08 <nhnt11> and instead store id's and fetch them when required
02:47:10 <clokep> Um, OK.
02:47:11 <nhnt11> But first things first
02:47:21 <nhnt11> In the PossibleUIConv constructor
02:47:21 <clokep> OK.
02:47:31 <nhnt11> Printing aUIConv.topic gives me "undefined"
02:48:05 <nhnt11> When clearly there /is/ a topic, and the buddy list shows it after listening to a similar notification (I also tried that one to no success)
02:48:07 <clokep> What class is aUIConv? It's a conversation binding, right?
02:48:17 <nhnt11> aUIConv is an imIConversation instance
02:48:59 <clokep> Um, really?
02:49:04 <clokep> That's not what we ever call a "uiConv".
02:49:05 <clokep> I don't think.
02:49:09 <nhnt11> Yeah, I checked.
02:49:10 <clokep> But this always confuses me...
02:49:15 <nhnt11> What? I'm pretty sure we do
02:49:19 <clokep> What does printing it give?
02:49:27 <nhnt11> undefined
02:49:30 <nhnt11> Oh the uiconv?
02:49:33 <clokep> Yes.
02:49:45 <nhnt11> A bunch of interfaces..
02:49:49 <nhnt11> wrapped object.
02:49:50 <clokep> Show me.
02:49:54 <nhnt11> ok
02:51:13 <nhnt11> clokep: [xpconnect wrapped (nsISupports, nsIClassInfo, imIConversation, prplConversation, nsIObserver, prplIConvChat) @ 0x13441c0e0 (native @ 0x1251f6d20)]
02:52:14 <nhnt11> clokep: Sorry, it's not undefined. it's null.
02:52:15 <clokep> nhnt11: Maybe QueryInterface(Ci.prplIConvChat)?
02:52:28 <nhnt11> undefined is when it's not a chat, but that's expected.
02:52:32 <nhnt11> (I'm talking about the topic)
02:52:52 <nhnt11> clokep: That's what isChat is for right? That's definitely returning true.
02:53:06 <clokep> nhnt11: isChat just tells you if it's a chat, it doesn't do a queryinterface for you.
02:53:41 <nhnt11> clokep: Ok. But why do I need to queryinterface? Doesn't the error I just printed confirm prplIConvChat?
02:54:26 <clokep> QueryInterface changes which interface you're using to look at the object, I believe.
02:54:38 <nhnt11> oh
02:54:46 <clokep> I don't know why you seem to sometimes need to do it and other times it auto-queries for you.
02:56:52 <clokep> Plus it'll at least explode on you if it isn't possible. :-D
02:57:07 <nhnt11> clokep: Still null
02:57:10 <nhnt11> :(
02:57:49 <clokep> nhnt11: Did you try .target.topic?
02:57:53 <nhnt11> Yes
03:01:31 --> jb has joined #instantbird
03:02:03 <-- jb has quit (Input/output error)
03:03:25 --> jb has joined #instantbird
03:04:36 <instant-buildbot> build #915 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/915
03:05:28 * nhnt11 wonders if something is wrong with his build
03:05:53 --> mconley has joined #instantbird
03:06:13 <clokep> What does .target show if you print it?
03:07:38 <nhnt11> [xpconnect wrapped (nsISupports, nsIClassInfo, prplIConversation, prplIConvChat) @ 0x124b03670 (native @ 0x10c3475f0)]
03:08:25 <clokep> :-/
03:08:29 <clokep> I don't know, sorry.
03:08:37 <clokep> Maybe we're not setting it, but I'm fairly certain we are...
03:08:54 <nhnt11> It should be fine on the prpl side.
03:09:04 <nhnt11> Because it works in the blist
03:09:09 <nhnt11> like I said.
03:09:20 <clokep> Can you access other fields?
03:09:32 <nhnt11> Only the title seems to work.
03:09:38 <nhnt11> and isChat
03:10:07 <clokep> Name?
03:10:19 <nhnt11> I haven't tried. Will do in a minute
03:10:21 <clokep> Hmmm...
03:10:39 <clokep> Try some of the other prplIConvChat ones? Like nick or left?
03:11:15 <nhnt11> I haven't dumped anything, but newtab shows the channel as offline
03:11:35 <nhnt11> which means it either found that account.connected was false, or uiConv.left was true
03:12:19 <clokep> Right.
03:12:26 <clokep> I'm not sure, sory.
03:12:30 <nhnt11> ok
03:12:35 <nhnt11> Thanks for your time
03:12:37 <-- jb has quit (Ping timeout)
03:13:00 * clokep is too tired to debug properly.
03:13:07 * nhnt11 has a feeling something is wrong with his build. Rebuilding..
03:16:00 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:22:03 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:39:18 <instant-buildbot> build #915 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/915
03:39:28 --> nhnt11 has joined #instantbird
03:39:52 <nhnt11> Turns out the notification I'm receiving is fired before the topic is set
03:40:16 <nhnt11> The buddy list listens to the same notifications, but in kind of a reverse order.
03:40:39 <nhnt11> It listens for when the conv gets hidden rather than shown (which was what my previous patch did, that's why it worked)
03:41:09 <nhnt11> So I need to also listen for the topic change notifications and update as necessary.
03:43:11 <nhnt11> bbl. sleep.
03:43:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
04:01:17 <-- mconley has quit (Input/output error)
04:36:57 --> Mook has joined #instantbird
05:10:05 <flo-retina> clokep: QueryInterface isn't needed if nsIClassInfo is implemented.
05:15:07 --> mconley has joined #instantbird
05:50:44 <instant-buildbot> build #1011 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1011
06:00:05 --> nhnt11 has joined #instantbird
06:21:42 <-- Mook has quit (Quit: Mook)
06:39:40 <-- mconley has quit (Input/output error)
07:32:40 <-- FireFly_TB has quit (Ping timeout)
08:20:54 --> atuljangra has joined #instantbird
08:22:49 <atuljangra> !seen clokep
08:22:50 <instantbot> clokep was last seen 5 hours, 9 minutes and 49 seconds ago, saying '* clokep is too tired to debug properly.' in #instantbird.
08:31:45 <-- IRCMonkey34752 has quit (Ping timeout)
08:45:38 <-- atuljangra has quit (Ping timeout)
08:46:49 --> aleth has joined #instantbird
08:46:49 * ChanServ sets mode +h aleth 
08:47:51 <-- Optimizer has quit (Ping timeout)
08:48:40 --> Optimizer has joined #instantbird
08:54:49 <-- aleth has quit (Quit: Ciao)
08:54:52 --> aleth has joined #instantbird
08:54:52 * ChanServ sets mode +h aleth 
09:33:11 --> FireFly_TB has joined #instantbird
09:54:47 <aleth> On read receipts http://arstechnica.com/staff/2013/07/why-i-hate-read-receipts/
09:58:16 --> Mic has joined #instantbird
09:58:16 * ChanServ sets mode +h Mic 
09:58:39 <Mic> Hello.
10:07:10 <-- Optimizer has quit (Ping timeout)
10:08:15 --> Optimizer has joined #instantbird
10:11:05 <Mic> aleth: about http://log.bezut.info/instantbird/130719/#m391
10:11:17 <Mic> Do you think this is better: " It will also include already ongoing conversations (Switch to conversation) and suggestions for multi user chats like IRC channels which exist on the servers that you're connected to and chatrooms for  XMPP and others."?
10:20:27 <aleth> Maybe make it two sentences? It's a bit long.
10:22:31 <aleth> or "It will also include already ongoing conversations (Switch to conversation) and suggestions for multi user chats such as IRC channels and XMPP chatrooms on the servers that you're connected to"?
10:32:02 <-- Optimizer has quit (Ping timeout)
10:36:49 --> Optimizer has joined #instantbird
10:49:50 <Mic> OK, thanks. I'll take that.
10:50:50 <aleth> Thanks for doing a blog post :) Always takes much longer than one thinks.
10:52:11 <Mic> Absolutely.
10:53:07 <aleth> You know when you have it ready you can schedule it to publish at a specific time? Convenient for Monday mornings etc ;)
10:54:19 <Mic> No, I didn't know that.
10:55:08 <aleth> It's on the right hand side somewhere in the Publish box
10:55:13 <Mic> Schedule for: Jul 22, 2013 @ 09:00
10:55:14 <Mic> :)
10:55:36 <-- nhnt11 has quit (Ping timeout)
10:58:34 --> mpmc has joined #instantbird
10:59:35 <Mic> OK, here's what will be published then: http://blog.instantbird.org/?p=571&preview=true
11:00:05 <aleth> You have to be an admin to see that if you're not the author ;)
11:00:43 <Mic> I thought you'd just need to be logged in :(
11:01:44 --> clokep has joined #instantbird
11:01:44 * ChanServ sets mode +o clokep 
11:16:23 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
11:16:30 <clokep> aleth: Interesting
11:26:21 <clokep> atuljangra: You can probably just ask your questions instead of asking when I was !seen.
11:37:01 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:15:42 --> rosonline has joined #instantbird
12:35:13 --> nhnt11 has joined #instantbird
12:47:02 --> jb has joined #instantbird
12:53:54 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:53:57 --> flo-retina has joined #instantbird
12:53:57 * ChanServ sets mode +qo flo-retina flo-retina 
13:06:48 <aleth> I wonder if Even could get access to the mozilla puppet infrastructure: "When a new machine is acquired, it needs an operating system. There is a kickstart config file that installs CentOS 6.2. At the end of the base OS flash/install, it configures Puppet to talk to a central Puppet master. ... Part of the puppetization of this machine involves installing the buildbot client."
13:06:49 <aleth> http://gregoryszorc.com/blog/2013/07/16/analysis-of-firefox%27s-build-automation/
13:07:24 --> Tonnes has joined #instantbird
13:07:45 <Even> Yeah, but it installs & configure it for Mozilla. This won't really match our process.
13:08:02 <Even> I would need to install my own puppet master & change a lot of the configuration files.
13:08:23 <Even> It would be nearly as quick to write my own puppet files from scratch (and much more interesting)
13:08:41 <aleth> Even: Wouldn't it at least get CentOS 6.2 configured as needed?
13:08:50 <Even> Dunno.
13:09:03 <Even> It depends on what is the network configuration it implies & so on.
13:09:19 <Even> It would be great if someone was interested enough to create a real puppet configuration for our services.
13:09:43 <aleth> Right... I just mentioned it because flo-retina said at one point you had used a CentOS5 image from mozilla (but this was before they used puppet I guess)
13:11:32 <aleth> (The kickstart file mentioned is https://hg.mozilla.org/build/puppet/file/6f7b4a33af2c/setup/centos6-kickstart.cfg.erb)
13:16:46 <flo-retina> I wonder if we could use the kickstart file without having the machine within the mozilla releng network
13:17:11 <aleth> Or just this part https://hg.mozilla.org/build/puppet/file/6f7b4a33af2c/setup/common/apt-setup-repos.erb
13:19:52 <flo-retina> that part looks ubuntu related ;)
13:21:27 <aleth> So it is :-/ I can't find centos-setup-repos.erb offhand...
13:23:22 * flo-retina wonders what aleth thinks of https://bugzilla.mozilla.org/show_bug.cgi?id=764242
13:25:56 <aleth> Isn't the correct fix to not add a selection listener when autocopy is disabled?
13:26:19 <flo-retina> isn't this what the patch does?
13:27:07 <flo-retina> i'm afraid it completely bitrots with bug 1940 :-/
13:27:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1940 nor, --, ---, aleth, RESO FIXED, Fix errors/warnings on detaching/reattaching conversations
13:27:12 <aleth> I hadn't actually looked at the patch as it is bitrotted.
13:27:25 <flo-retina> not for Tb I guess :-/
13:27:42 <aleth> We should fix it in IB and then eventually it will merge ;)
13:28:18 <aleth> "I'm not sure observing changes to this preference is really worth it" I agree
13:29:59 <aleth> Should we ask Mook to port his patch to IB or should I just do it? :P
13:31:35 <flo-retina> or ask him to port Ib's changes to the file (or to chat/) first? :-P
13:32:28 <aleth> Heh :D
13:46:41 <instantbot> New Instantbird (UI) bug 2062 filed by aleth@instantbird.org.
13:46:42 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2616 on bug 2062.
13:46:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2062 min, --, ---, nobody, NEW, Magic Copy should heed the clipboard.autocopy pref
13:46:50 * aleth decided to be nice
13:50:12 <flo-retina> aleth: what about setting this.autoCopyEnabled in enableMagicCopy and not having the field?
13:50:30 <flo-retina> for some reason it feels a bit wrong to me to have a field that's initialized by something that executes code
13:51:47 <aleth> flo-retina: Right. That's less lazy but I don't think we need to care :)
13:52:07 <flo-retina> aleth: I suspect the field value is computed when the file is parsed
13:53:08 <flo-retina> alright, I'm wrong on this
13:53:30 <flo-retina> Enn wrote on his blog "The field element defines a value on a element. The code for it is compiled when the field is first accessed, not when it is defined." at http://enndeakin.wordpress.com/2011/10/04/xbl-performance-tips/
13:53:50 <aleth> Yes, fields are automatic lazy getters.
13:54:18 <aleth> I still think your suggestion is good.
13:54:51 <flo-retina> I was going to say that your patch seems OK as is :-D
13:55:11 <aleth> I'm not particularly bothered either way :D
13:55:22 <flo-retina> yeah, doesn't matter
13:57:23 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2617 on bug 2062.
13:57:25 <aleth> I attached the patch anyway as I had changed it
13:57:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2062 min, --, ---, aleth, ASSI, Magic Copy should heed the clipboard.autocopy pref
13:57:30 <aleth> Take your pick ;)
14:18:42 <-- jb has quit (Ping timeout)
14:20:30 --> atuljangra has joined #instantbird
14:24:41 --> mconley has joined #instantbird
14:27:02 --> jb has joined #instantbird
14:40:16 <-- Tonnes has quit (Input/output error)
14:50:18 --> unghost has joined #instantbird
14:55:03 * atuljangra wonders if someone tried the filelink code from the repo.
14:58:03 <aleth> atuljangra: What, the one called "First working example, do not try this"? ;)
14:58:41 <atuljangra> Heh, apparently that one works on my laptop fine. So go ahead and try it :D
15:02:15 <-- mconley has quit (Input/output error)
15:05:50 <aleth> (Looking at the code)
15:06:01 <aleth> Looks like this is no longer ubuntuone-specific, right? :)
15:07:22 <aleth> |if (aProvider == undefined) {Components.utils.reportError("Provider is null, tranfer not possible");| That doesn't make sense :P I think you mean |if (!aProvider)| . Also it is probably better to check for this before calling the method.
15:08:20 <atuljangra> Yes this is not ubuntu one specific now.
15:08:25 <aleth> What happens if the upload fails or succeeds? Your comment says OnStopRequest is called, but what happens there? How is the user informed?
15:08:46 <-- gerard-majax_ has quit (Ping timeout)
15:10:18 <atuljangra> Yes, that would be fine. I will include that before providing. 
15:10:37 <aleth> Or do you plan to reuse more code for this from https://mxr.mozilla.org/comm-central/source/mail/components/compose/content/bigFileObserver.js ?
15:10:49 <atuljangra> aleth: OnStopRequest will be called and it reports everything via system message.
15:11:06 <aleth> Where is onStopRequest in the code?
15:11:28 <atuljangra> I can use it, yes. This was just a code to show the working filelink code.
15:11:53 <-- rosonline has quit (Ping timeout)
15:12:05 <aleth> I understand it's a WIP ;) and I'm glad it's working, that sounds like progress :)
15:12:34 <atuljangra> Thanks :-) I had this deadline you must be knowing.
15:13:26 <aleth> There does seem to be a /lot/ of polishing still to be done. Do you have an etherpad with a todo list?
15:13:47 <atuljangra> aleth: No, I'll make one today.
15:13:54 <atuljangra> :)
15:14:32 <atuljangra> I'll back after dinner. It's been a tiring day, after all the room shifting and stuff :(
15:14:43 * atuljangra is now known as atul_tired_dinner
15:15:14 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
15:15:16 --> nhnt11 has joined #instantbird
15:15:18 <aleth> I'm not sure you saw my comment, but I'm pretty sure we won't want that account selection modal dialog despite TB using it. Maybe a dropdown in a notification box or something would work.
15:22:53 <aleth> Ah, found onStopRequest. Thankyou bitbucket for making me waste five minutes :-/
15:23:27 <aleth> s/notification box/notification bar
15:25:15 <-- jb has quit (Connection reset by peer)
15:42:44 <-- FireFly_TB has quit (Ping timeout)
15:48:39 <-- dew has quit (Ping timeout)
15:50:17 --> dew has joined #instantbird
15:52:24 --> FireFly_TB has joined #instantbird
15:54:11 --> rosonline has joined #instantbird
16:01:20 <-- dew has quit (Ping timeout)
16:01:56 --> dew has joined #instantbird
16:17:18 <nhnt11> Hey
16:18:02 <nhnt11> flo-retina: I'm doing the UI conversations your way in the end. I thought keeping it the way it was would save time, but fetching them when filtering will save checking for topic changes, etc.
16:20:30 <aleth> And there aren't that many of them so it's not a performance issue anyway ;)
16:21:49 <nhnt11> Yeah
16:23:45 <aleth> Don't forget the open tabs ;)
16:27:04 <nhnt11> aleth: It's taken care of by getUIConversations :)
16:27:09 <aleth> :)
16:33:06 <-- aleth has quit (Quit: Ciao)
16:35:03 <-- dew has quit (Ping timeout)
16:35:27 --> dew has joined #instantbird
16:50:13 --> gerard-majax_ has joined #instantbird
16:56:44 <-- gerard-majax_ has quit (Ping timeout)
17:31:27 --> clokep has joined #instantbird
17:31:27 * ChanServ sets mode +o clokep 
17:40:10 <clokep> nhnt11: You good or did you have a question?
17:42:18 <nhnt11> clokep: All good.
17:51:55 <-- dew has quit (Ping timeout)
17:52:07 <clokep> :)
17:55:15 --> gerard-majax_ has joined #instantbird
17:55:45 --> dew has joined #instantbird
17:59:47 <-- clokep has quit (Ping timeout)
18:31:33 <-- FireFly_TB has quit (Ping timeout)
18:35:29 <-- gerard-majax_ has quit (Ping timeout)
18:38:06 <atul_tired_dinner> aleth I saw the comment in the mail, I tried to reply to it, but wasn't able to see the comment on the bitbucket
18:43:30 <atul_tired_dinner> aleth We can remove it. And something that fits the ib ui
18:43:52 --> Mook has joined #instantbird
18:52:24 <Mook> fwiw: no, XBL <field> values are computed on first access.
18:52:46 <Mook> <headdesk> okay, so I just need to read one more line. bleh.
18:56:28 * Mook tries to figure out where his copy patch is going and how soon it can land in tb :p
19:02:19 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:03:46 <-- atul_tired_dinner has quit (Quit: He didn't quit, he'll be back!)
19:06:39 --> FireFly_TB has joined #instantbird
19:16:59 --> mconley has joined #instantbird
19:17:50 <-- FireFly_TB has quit (Quit: FireFly_TB)
19:54:22 <-- mconley has quit (Input/output error)
19:56:00 <flo-retina> Mook: the ideal solution would be to land a patch in Ib, and then sync chat/ with Tb.
19:57:02 <flo-retina> Mook: problem is... c-c still seems significantly busted
20:01:40 <Mook> as in, doesn't build?
20:01:57 <flo-retina> Mook: https://tbpl.mozilla.org/?tree=Thunderbird-Trunk
20:02:02 * Mook seems to have a nightly update pending... so something, somewhere is building something
20:03:37 <flo-retina> it says "metered" instead of "closed", so maybe the situation has improved recently. But I'm not sure they accept patches that don't attempt to fix the current bustage... and I don't see requesting approval on a 50-changesets bug as the best thing to do to play nice :-D
20:03:56 <Mook> haha
20:04:13 <Mook> I guess there'll be no copying for me for a while yet, then. ah well.
20:20:31 <flo-retina> Mook: btw, I haven't understood why this patch is required for your workflow
20:21:21 <instantbot> florian@instantbird.org granted review for attachment 2617 on bug 2062.
20:21:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2062 min, --, ---, aleth, ASSI, Magic Copy should heed the clipboard.autocopy pref
20:21:52 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2616 on bug 2062.
20:26:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4cdcb5dfe7e0 - aleth - Bug 2062 - Magic Copy should heed the clipboard.autocopy pref, r=fqueze.
20:27:14 <-- nhnt11 has quit (Ping timeout)
20:27:36 --> nhnt11 has joined #instantbird
20:27:44 <Mook> flo-retina: mostly because tbird still doesn't have the unread marker line, so I still select things to mark where I'm at
20:27:53 <Mook> which doesn't play very nice with synergy...
20:28:04 <flo-retina> uh
20:28:11 <flo-retina> so this isn't the patch you really want at all :-S
20:28:22 <Mook> nope, but it will help! :p
20:28:35 <flo-retina> what's required to have the unread marker there?
20:28:39 <Mook> (and is easier for me to write)
20:28:45 <flo-retina> I thought the implementation was all in chat/ :-S
20:28:53 <Mook> I dunno; I think you mentioned at some point that it needs styling
20:31:15 <-- Mook has quit (Quit: Mook)
20:31:32 --> Mook has joined #instantbird
20:33:03 <Mook> hmm, perhaps just hacking it with stylish for now works.
20:33:19 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
20:36:14 <Mook> I guess I need to figure out how it's implemented in instantbird first...
20:38:55 <flo-retina> I thought we had default styling so that all message themes could benefit from it automatically
20:39:54 <Mook> I don't even know if tbird has message themes :p
20:41:52 <Mook> so, http://mxr.mozilla.org/comm-central/source/chat/themes/conv.css#33 has something that indicates it should exist
20:42:11 <instant-buildbot> build #421 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/421
20:44:47 <Mook> okay, so http://mxr.mozilla.org/comm-central/source/chat/content/convbrowser.xml?mark=264#258 pushes firstUnread in
20:44:58 <Mook> but http://mxr.mozilla.org/comm-central/source/mail/components/im/content/chat-messenger-overlay.js#818 only ever has one argument...
20:45:17 <Mook> oh, that's conv-loaded, I should look somewhere else
20:46:37 <flo-retina> Mook: "I don't even know if tbird has message themes :p" it does, but without selection UI
20:46:58 <Mook> okay, so it's probably http://mxr.mozilla.org/comm-central/source/mail/components/im/content/imconversation.xml#157 (2 args instead of 3)
20:55:37 --> FireFly_TB has joined #instantbird
21:00:16 --> Nirgali has joined #instantbird
21:02:26 <Mook> so.. what's a good, spammy channel? #ubuntu on freenode is rather quiet.
21:07:13 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:10:34 <flo-retina> Mook: #ubuntu is usually good
21:10:46 <flo-retina> #wikipedia on freenode isn't too bad either, but slightly less busy
21:11:14 <flo-retina> #bugs on moznet is often spammy too (but with less participants :-P), although on week-ends it may not be that good :-P
21:11:41 <Mook> yeah, I just gave up and joined my own channel :p
21:11:47 <flo-retina> uh
21:11:48 <Mook> I can spam myself!
21:11:57 <flo-retina> there's #test on freenode
21:12:02 <flo-retina> but not really spammy
21:16:43 <flo-retina> how come my android smartphone got ejected from gtalk _just_ when I was attempting to test a patch for bug 972? :(
21:16:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=972 nor, --, ---, nobody, NEW, Mark GTalk users on Android as "mobile"
21:18:36 <flo-retina> nhnt11: where is the patch for that retina screenshot you showed a while ago? :-P
21:18:56 <nhnt11> flo-retina: Er, it's coming :P
21:19:21 <nhnt11> flo-retina: Do you want a separate patch for retina tag icons and the switch to tab stuff?
21:19:33 <flo-retina> what does that mean?
21:20:00 <nhnt11> I meant, should I include the retina tag icons in the patch for bug 2055
21:20:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
21:20:15 <nhnt11> I guess not.
21:20:23 <flo-retina> I was thinking about the theming of the "+" icon.
21:20:29 <nhnt11> Ooh.
21:20:31 <flo-retina> You can include the retina tag icon in that patch too if you want.
21:20:35 <nhnt11> ok.
21:20:57 <flo-retina> I was considering looking into the retina theming of the tab corners and close icons tonight
21:21:04 <flo-retina> but wondered if I might bitrot with your patch
21:21:09 <flo-retina> that I still haven't seen
21:22:56 <nhnt11> I'll get you patches soon.
21:23:15 * nhnt11 didn't work on the windows theming yesterday
21:23:48 <flo-retina> nhnt11: you can file a bug per OS if that's easier
21:24:06 <flo-retina> do you need help for linux, or have you figured out this part?
21:24:16 <nhnt11> Ok, I can give you the mac patch right now.
21:24:26 <nhnt11> I'm going to copy-paste from Firefox
21:24:32 <flo-retina> I would think for both Windows and Linux you can find the Firefox rules on mxr, create a "best guess" patch, and ask someone here to test it for you
21:24:37 <nhnt11> I suppose that should work.
21:24:38 <nhnt11> yeah
21:25:16 <flo-retina> Mook: why do you need that #unread-ruler rule in chat/ that we don't have for Instantbird?
21:25:53 <flo-retina> Mook: where is the display: none coming from?
21:28:41 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2618 on bug 2045.
21:28:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, ---, nhnt11, ASSI, Update theming of the "+" buttons
21:31:57 <flo-retina> oh wait, could it be that GTalk on Android finally has a working Invisible status? :-S
21:32:24 <nhnt11> flo-retina: The Talk app has always hadd working Invisible status
21:32:29 <nhnt11> The new hangouts app.. I have no clue
21:32:35 <flo-retina> nhnt11: no it didn't
21:32:44 <flo-retina> nhnt11: the invisible status worked only if you had no visible resource.
21:32:49 <nhnt11> Oh
21:32:54 <nhnt11> It has always worked for me
21:32:54 <nhnt11> :S
21:33:04 <nhnt11> Oh wait I get your point now
21:33:15 <nhnt11> I've never been in a situation where it wouldn't work :P
21:33:19 <flo-retina> my android resource was visible if and only if my Instantbird resource was also online. When I signed off on Instantbird, I was actually invisible.
21:33:35 <flo-retina> now my android resource is actually not advertized at all, but messages are still delivered to it
21:36:34 <-- FireFly_TB has quit (Quit: FireFly_TB)
21:38:10 <Mook> flo-retina: the display:none comes from their stylesheets force in for mail composition
21:38:36 * flo-retina has no idea of how to find the status selector on Android Talk :-S
21:38:56 <flo-retina> nor of why it randomly attempted to start a video call with a coworker :-S
21:39:07 <flo-retina> Mook: link?
21:40:46 <nhnt11> Ah
21:40:59 <nhnt11> Just found the probable reason for a bug I was trying to solve
21:41:13 <flo-retina> :)
21:41:32 <nhnt11> I was inserting the uiConvs into the filteredConvs list before returning them
21:41:50 <nhnt11> but when there's no filter string I was setting filteredConvs = this._possibleConversations
21:41:57 <nhnt11> And so this._possibleConversations was being modified
21:42:06 <nhnt11> I guess I need to clone the array
21:44:38 --> nhnt11-testing has joined #instantbird
21:44:43 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:44:53 <nhnt11> flo-retina: I think a patch is coming for bug 2055 too :)
21:44:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
21:45:11 <Mook> well, now I feel stupid. new patch coming.
21:45:12 <Mook> http://mxr.mozilla.org/comm-central/source/mail/components/im/messages/main.css#97
21:45:14 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2619 on bug 972.
21:45:15 <flo-retina> separate from the service rework?
21:45:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=972 nor, --, ---, florian, NEW, Mark GTalk users on Android as "mobile"
21:45:30 <nhnt11> flo-retina: No, it's still the service stuff
21:45:39 <nhnt11> Was I supposed to make it separate? :S
21:45:41 <Mook> wait. huh. that doesn't even make sense.
21:45:43 * nhnt11 reads the comments on the bug again
21:46:00 <flo-retina> nhnt11: no. I just was under the impression that it was what you wanted to do.
21:46:08 * flo-retina prefers separate, but didn't want to force it
21:46:24 <flo-retina> err, scratch these last 2 lines :-P
21:46:42 <flo-retina> negations are hard :-/
21:47:03 <nhnt11> flo-retina: I can submit a patch with /only/ the service stuff without the open converesations stuff pretty easily, if you'd like
21:47:28 <nhnt11> But it's not that much of an addition so I'd prefer including it in one patch
21:48:41 <Mook> oh. flo-retina might know, from https://bugzilla.mozilla.org/show_bug.cgi?id=768919#c49
21:50:17 <flo-retina> nhnt11: nah, as I said, scratch what I said
21:50:21 <nhnt11> ok
21:50:37 <flo-retina> Mook: what's the question?
21:50:49 --> FireFly_TB has joined #instantbird
21:52:08 <Mook> flo-retina: why does main.css attempt to hide <hr>s that don't seem to actually exist?
21:52:20 <Mook> that rule is a little... broad.
21:53:03 <flo-retina> I've no idea of what that rule is doing
21:53:09 <Mook> you wrote it! :p
21:53:41 <flo-retina> :(
21:53:54 <flo-retina> ok, after reading the comment you linked to...
21:54:05 <flo-retina> this is because Tb uses a butchered Bubbles theme
21:54:16 <flo-retina> and still has the hr between each message and they are just never shown (WTF...)
21:55:51 <Mook> I guess it's from https://bugzilla.mozilla.org/show_bug.cgi?id=768919#c38 actually
21:56:39 <Mook> though I don't see those <hr>s in my DOM...
21:57:51 <Mook> ah, in between two system messages. just because.
21:58:14 <flo-retina> Mook: that bug is depressing
21:59:33 <nhnt11> flo-retina: Do you have any suggestions for alternative names for "PossibleUIConv"?
21:59:54 <nhnt11> I like the "Possible" in there only because it's clear that it's a PossibleConversation instance and is consistent with PossibleContact
22:00:02 <nhnt11> But it doesn't sound right.
22:03:28 <flo-retina> what is it?
22:03:35 <flo-retina> wasn't it ExistingConversation?
22:03:37 <flo-retina> or is it a different thing?
22:05:01 <nhnt11> Oh yeah, someone suggested ExistingUIConversation. I was trying to recall that.
22:05:17 <nhnt11> It's always been PossibleUIConv, but someone suggested ExistingUIConversation and I forgot it.
22:06:02 <flo-retina> nhnt11: why do you feel the need to stuff a "UI" there?
22:06:15 <nhnt11> flo-retina: It's called a UI conversation everywhere else
22:06:20 <flo-retina> and I'm usually called Florian, or "flo" here, not "someone" :-P
22:06:32 <nhnt11> flo-retina: It was you? oops :P
22:06:45 * nhnt11 had a feeling it was aleth.
22:07:18 --> nhnt11-testing has joined #instantbird
22:07:25 <-- nhnt11-testing has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:07:35 <nhnt11> Ok, I'll use "ExistingConversation"
22:10:29 * nhnt11 is going through his patch
22:12:15 <nhnt11> Hmm, I probably shouldn't include the fix for the mouse-hover-selection problems in this patch
22:12:17 * nhnt11 files a new bug
22:12:52 <flo-retina> the smaller the patches, the likelier to get a quick review ;)
22:15:42 <instantbot> New Instantbird (UI) bug 2063 filed by nhnt11@gmail.com.
22:15:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2063 min, --, ---, nobody, NEW, Mouseover selection of items in the new conversation tab is erratic
22:15:57 <flo-retina> Mook: if I really cared about that code, I would ask you to remove the now pointless {} in Footer.html
22:17:44 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2620 on bug 2063.
22:17:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2063 min, --, ---, nhnt11, ASSI, Mouseover selection of items in the new conversation tab is erratic
22:18:07 <nhnt11> One line fix :)
22:19:06 <flo-retina> Mook: alright, it's possible to simplify that ugly code more
22:22:53 <-- FireFly_TB has quit (Ping timeout)
22:23:24 <Mook> flo-retina: yeah, been playing with it... you know what? p.event:not(:first-of-type):not(:last-of-type) is easier!
22:23:32 <Mook> remove all that stupid JS, use a CSS rule
22:23:41 <flo-retina> nhnt11: you know you can attach a patch as the same time as you file a bug, right?
22:23:50 <nhnt11> flo-retina: I do, but then I don't know the bug number
22:23:58 <flo-retina> Mook: I was also thinking something like this
22:24:13 <flo-retina> Mook: but didn't want to force you to do a full rewrite for an unrelated bug ;)
22:24:29 <Mook> gimme a minute; I need to shut down a stupid VM that's making my system slow due to memory pressure
22:25:04 <flo-retina> seems Mook has plenty of stupid stuff today (CSS, JS, VMs, ...) :-P
22:25:28 <Mook> I _was_ thinking about getter a haircut. Don't think that's going to happen now :p
22:25:50 <flo-retina> Mook: can we also simplify the JS code in view-source:http://lxr.instantbird.org/instantbird/source/instantbird/themes/messages/bubbles/Footer.html#57 ?
22:26:04 <flo-retina> Mook: does that mean you have stupid hair too? :-P
22:26:14 <nhnt11> heh
22:26:34 <Mook> flo-retina: yes, by definition, on account of the fact that it's on my head
22:26:43 <flo-retina> :-D
22:27:06 <instantbot> florian@instantbird.org granted review for attachment 2620 on bug 2063.
22:27:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2063 min, --, ---, nhnt11, ASSI, Mouseover selection of items in the new conversation tab is erratic
22:28:14 <nhnt11> flo-retina: That's not getting checked in now is it? (I'll have to merge it into my other branch before submitting the other patch if it is)
22:29:41 <flo-retina> nhnt11: why do you need the :not(.tabbrowser-arrowscrollbox) in https://bugzilla.instantbird.org/attachment.cgi?id=2618 ?
22:30:05 <flo-retina> nhnt11: bug 2063 is already commited locally. With push just before going to bed
22:30:05 <nhnt11> flo-retina: So that I don't affect the theming when it's in the style of a tab
22:30:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2063 min, --, ---, nhnt11, ASSI, Mouseover selection of items in the new conversation tab is erratic
22:30:13 <flo-retina> (trying to decide if there's some more stuff I'm pushing tonight)
22:30:38 <flo-retina> any reason why Firefox doesn't seem to have the same thing?
22:32:41 <nhnt11> I don't know
22:33:29 <flo-retina> nhnt11: I guess what surprises me is you have ".tabbrowser-arrowscrollbox > .scrollbutton-up" in the same rule
22:33:36 <nhnt11> Yeah
22:33:48 <nhnt11> Because the scrollbutton-up is /in/ the arrowscrollbox
22:34:06 <nhnt11> Whereas the + button and alltabs menu aren't
22:35:19 <nhnt11> flo-retina: I guess an alternative is to have the overflow newtab button set to a different id, or something, and use that
22:35:28 <nhnt11> Would you like me to do something like that instead?
22:35:40 <flo-retina> ids in xbl? :-P
22:36:12 <nhnt11> Class then
22:36:20 <nhnt11> anonid works too
22:36:27 <nhnt11> You know what I meant :P
22:36:44 <nhnt11> Hmm, it already has an anonid, I'm blind as usual
22:36:54 <flo-retina> I guess it's not clear why you need it
22:37:05 <flo-retina> is the rule defining the background of regular tabs before or after in the file?
22:37:18 <nhnt11> let me check
22:37:18 <flo-retina> you don't want to use anonid for css
22:38:40 <nhnt11> flo-retina: it's above.
22:38:44 <nhnt11> I mean befoe
22:38:45 <nhnt11> before*
22:39:48 <nhnt11> flo-retina: I forgot to include the retina tag icons in that patch.
22:41:37 <flo-retina> nhnt11: if you are going to upload a new version, please also fix the indent on the skin/classic/instantbird/tabbrowser/newtab@2x.png line
22:41:41 <flo-retina> (in jar.mn)
22:42:16 <nhnt11> ok
22:43:26 <nhnt11> flo-retina: Considering there's going to be another image for the little tab icon next to "Switching to tab", should I create new newtab-*stripe folders?
22:43:55 <flo-retina> nhnt11: I just looked at DOMi
22:44:06 <flo-retina> :not(.tabbrowser-arrowscrollbox) > .tabs-newtab-button seems to make no sense
22:45:07 <nhnt11> :S
22:45:10 <nhnt11> It seemed to work :/
22:45:27 <flo-retina> http://i3.minus.com/ixtqsyygtCgvJ.png
22:45:47 <flo-retina> nhnt11: none of the new tab buttons is a direct child of .tabbrowser-arrowscrollbox
22:46:05 <flo-retina> so removing ":not(.tabbrowser-arrowscrollbox) > " in your rule should give the exact same result
22:47:16 <flo-retina> nhnt11: I think "padding: 2px 0 2px;" can be simplified to "padding: 2px 0;"
22:47:54 <nhnt11> ok
22:48:08 <flo-retina> is a new patch coming soon? :)
22:48:15 <flo-retina> (trying to decide if I go to bed or wait for it)
22:48:51 <nhnt11> Yeah I'm incorporating your suggestions
22:48:59 <flo-retina> "should I create new newtab-*stripe folders?" no.
22:49:07 <flo-retina> keep stuff in tabbrowser-* if it makes sense
22:49:26 <flo-retina> or use -mac.png -win.png, etc... if you put stuff in the common folder
22:49:45 <flo-retina> someday we will cleanup the paths in there and have shared/ osx/ windows/ linux/ like Firefox now has
22:49:56 <nhnt11> ok
22:52:00 <nhnt11> flo-retina: The not:(arrowscrollbox) > thing seems to work.
22:52:27 <flo-retina> you mean the not: "not:(arrowscrollbox) >"? ;)
22:52:27 <nhnt11> :S
22:52:49 <nhnt11> No
22:53:12 <nhnt11> I mean, if I remove the "not:(arrow...) >", the gradient gets applied on the tab button too
22:56:35 <flo-retina> Mook: is there some strange magic with the way the > CSS selector is handled for anonymous nodes?
22:57:17 <Mook> Umm... I'm not sure.
22:57:33 <Mook> It would seem to make sense, though, to both try with and without the anonymous nodes
22:58:47 <flo-retina> what confuses me in this case is that there are several levels of XBL bindings, so it's not clear what's anonymous or not
22:59:01 <flo-retina> (DOMi shows everything as anonymous, but I know the bindings aren't the same...)
22:59:28 <nhnt11> flo
22:59:30 <nhnt11> ooops
22:59:46 <nhnt11> flo-retina: http://puu.sh/3HGYn.png
23:00:04 <nhnt11> There are two xul:toolbarbuttons, one is the chid of an arrowscrollbox
23:00:07 <nhnt11> child*
23:00:40 <flo-retina> nhnt11: the line you selected isn't the one with the class .tabbrowser-arrowscrollbox
23:00:47 <flo-retina> (that class is 2 lines above)
23:00:49 <nhnt11> ignore the selected line
23:00:58 <nhnt11> I'm wondering
23:01:08 <nhnt11> If CSS sees the parent as teh arrowscrollbox and not the scrollbox
23:01:10 <nhnt11> because of the binding
23:01:26 <flo-retina> that's what I was asking Mook ;)
23:01:34 <nhnt11> Ah so I got there a bit slower
23:02:24 <nhnt11> flo-retina: another possibility is that the scrollbox inherits the class
23:02:27 * nhnt11 checks
23:03:05 <nhnt11> Hmm, no..
23:03:15 <Mook> hrm, what do I need in my <script> tags to get let and of?
23:04:41 <nhnt11> flo-retina: So do you want me to keep this as it is for now?
23:04:45 <nhnt11> (Since it works)
23:05:19 <flo-retina> Mook: js 1.8?
23:05:49 <Mook> 1.8 seems to get me let, but not of
23:06:14 <Mook> nevermind, tested wrong, I guess :(
23:07:24 <flo-retina> nhnt11: do you think .tabs-container > .tabs-newtab-button would work?
23:07:55 <nhnt11> That's probably better yeah
23:07:55 <nhnt11> ok
23:09:12 <flo-retina> ok, it seems to work for me (but please test it too).
23:09:15 <flo-retina> I prefer that.
23:10:17 <nhnt11> Testing that and the retina tag icons
23:10:23 <nhnt11> should have new patch in a minute
23:11:06 <nhnt11> flo-retina: It doesn't work here
23:11:22 <nhnt11> No gradient on the overflow newtab button
23:11:35 <nhnt11> oh, my bad i think
23:11:39 <instantbot> florian@instantbird.org denied review for attachment 2618 on bug 2045.
23:11:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, ---, nhnt11, ASSI, Update theming of the "+" buttons
23:11:59 <flo-retina> uh
23:12:17 <nhnt11> ok, works
23:17:34 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2621 on bug 2045.
23:17:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, ---, nhnt11, ASSI, Update theming of the "+" buttons
23:26:45 <Mook> argh, <input type="checkbox"> doesn't work, I can't get rid of the border even with -moz-appearance
23:27:08 <Mook> I guess it's a silly <p> then :(
23:27:12 <instantbot> florian@instantbird.org granted review for attachment 2621 on bug 2045.
23:27:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, ---, nhnt11, ASSI, Update theming of the "+" buttons
23:27:50 <flo-retina> nhnt11: do you have a WIP for Linux/Windows or is that not started at all?
23:28:21 <nhnt11> Not started at all for linux, Windows barely
23:29:14 <flo-retina> I can test on Linux tomorrow if that's useful
23:30:23 <nhnt11> :)
23:36:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b31b40482245 - Nihanth Subramanya - Bug 2063 - Mouseover selection of items in the new conversation tab is erratic, r=fqueze
23:36:40 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7e20bdd5c790 - Nihanth Subramanya - Bug 2045 - Update theming of the "+" buttons on Mac, r=fqueze.
23:37:58 <flo-retina> nhnt11: If you can put the changeset urls in the bugs and resolve them if needed, that would be appreciated
23:38:07 <nhnt11> Ok!
23:38:14 <flo-retina> don't forget the target milestone :)
23:38:15 <flo-retina> Good night
23:39:05 <nhnt11> Good night
23:39:27 <instantbot> nhnt11@gmail.com set the Resolution field on bug 2045 to FIXED.
23:39:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, 1.5, nhnt11, RESO FIXED, Update theming of the "+" buttons
23:40:07 <instantbot> nhnt11@gmail.com set the Resolution field on bug 2063 to FIXED.
23:40:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2063 min, --, 1.5, nhnt11, RESO FIXED, Mouseover selection of items in the new conversation tab is erratic
23:40:35 <flo-retina> is bug 2045 fixed?
23:40:45 <flo-retina> if so, rephrase the title for it to be mac only, and file new bugs :-P
23:40:51 <nhnt11> flo-retina: I'm going to file new bugs
23:40:52 <nhnt11> yeah ok
23:43:44 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:47:10 <instant-buildbot> build #422 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/422
23:51:20 <Mook> oh. flo-retina wanted me to fix Footer.html in _that_ bug?