#instantbird log on 07 19 2013

All times are UTC.

00:00:07 <flo-retina> wasn't this file before JS-XMPP landed?
00:00:20 <flo-retina> it was!
00:00:42 <clokep> They don't send the right stanza though, unless you want to munge resources.
00:00:55 * clokep is available for review if you want to fix it. ;)
00:01:09 <flo-retina> clokep: there are so many things I would like to fix ;)
00:01:28 <flo-retina> "They don't send the right stanza though" doesn't seem exactly right
00:02:04 <douglaswth> it doesn't look like the resource says Android any more
00:02:27 <flo-retina> clokep: google talk for android sends: <caps:c xmlns="http://jabber.org/protocol/caps" node="http://www.android.com/gtalk/client/caps" ext="pmuc-v1 voice-v1 video-v1 camera-v1" ver="1.1"/>
00:02:46 <clokep> flo-retina: I don't know what that means. :)
00:02:50 --> clokep_ has joined #instantbird
00:03:21 <flo-retina> and Hangout from android seems to send: <caps:c xmlns="http://jabber.org/protocol/caps" node="http://www.android.com/gtalk/client/caps" ver="1.1"/>
00:04:19 <flo-retina> douglaswth: the resource says Messaging for Hangout instead of android for Google Talk
00:04:35 <flo-retina> clokep: it's the way clients advertise their capabilities to others
00:04:52 <flo-retina> clokep: and that includes an identifier that we can use to detect a specific client
00:05:21 <douglaswth> ah, it must get truncated when it is displayed in the hover pupup
00:05:29 <flo-retina> s/specific client/specific set of capabilities typically associated with a specific client/
00:05:57 <flo-retina> clokep: so I think assuming that the "http://www.android.com/gtalk/client/caps" set of capabilities means it's an android client is pretty safe.
00:05:57 <clokep> I see.
00:06:05 <clokep> I think so. :)
00:06:46 <flo-retina> and a patch, although it wouldn't implement any XEP, seems pretty easy
00:06:46 <-- mpmc has quit (Connection reset by peer)
00:07:50 --> josefec has joined #instantbird
00:08:13 --> mpmc has joined #instantbird
00:08:51 * clokep_ pokes #instantbird from znc.
00:09:10 <-- josefec has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
00:11:22 <atuljangra> flo-retina clokep As we have now migrated cloudfile/ to chat/ we do need to change the jar.mn located in cloudfile/ right?
00:11:46 <clokep> atuljangra: How so?
00:12:28 <atuljangra> If I don't then I get errors like this: No chrome package registered for chrome://messenger/content/cloudfile/addAccountDialog.xul
00:12:29 <atuljangra> Jar file: http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/jar.mn
00:12:51 * clokep_ is now known as clokep_work
00:13:42 <clokep> atuljangra: Umm...that's a UI file, you'll need to edit it, yes.
00:13:53 * clokep_work is now known as IRCMonkey21310
00:14:49 <atuljangra> So, I should do change content/messenger/ to content/chat/ (as we now have the cloudfile/ code in chat/)
00:16:59 <atuljangra> sorry discard that.
00:17:15 <clokep> atuljangra: Didn't we say UI code goes into instantbird/ not chat/?
00:17:21 * IRCMonkey21310 is now known as clokep_work
00:17:57 <atuljangra> clokep: yes, but this is the code inside the cloudfile/ and I shouldn't be changing anything in cloudfile/ right?
00:19:01 <clokep> Um, I don't know how that works.
00:20:15 <atuljangra> Ok. Basically I'm trying to open a dialog for adding cloud provider accounts by using http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/cloudFileAccounts.js#195
00:20:38 <atuljangra> And it requires a packages, which does not exist in ib.
00:21:44 <clokep> atuljangra: Just change them for now.
00:21:54 <clokep> I'm not concerned about changing the build files a but (Makefiles or jar.mn)
00:22:01 <clokep> But I don't want you touching lots of other code.
00:22:12 <atuljangra> clokep: Ok.
00:26:20 --> josefec has joined #instantbird
00:28:44 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:32:29 <-- wnayes has quit (Ping timeout)
00:33:33 --> skeledrew1 has joined #instantbird
00:33:33 <-- skeledrew has quit (Connection reset by peer)
00:35:52 --> wnayes has joined #instantbird
00:37:17 <-- josefec has quit (Input/output error)
00:51:31 * atuljangra messed up his chrome manifests :( Building the whole thing again
00:51:49 <clokep> Why would you need to rebuild for tat?
00:54:07 <atuljangra> There were some unwanted entries in the chrome packages, and it doesn't seem that those entries are removed when we do make ib or make -C chat/
00:54:24 <clokep> tier_app?
00:57:31 <atuljangra> Oh yes. Will try this. But anyhow I've messed up many things. I was trying to import the attachments pane in the preferences of Ib, and that require quite a work, thus now I was trying to get the accounts dialog to work.
01:05:19 * atuljangra is messing up things here :-/
01:08:19 <atuljangra> clokep: What do you want me to accomplish now. Till now, I'm able to create a working example of filelink. This is what flo wanted me to complete as a priority. What should be the next task? Fallback Mechanism, or adding dialog for choosing cloud provider (and then completing the ui for filelink like adding things to preferences and properly getting the provider)
01:10:35 <clokep> atuljangra: I think you should get it so you can use multiple mecanisms, configure them, etc.
01:10:52 <clokep> We also need to add UI that shows upload/download.
01:10:59 <clokep> This UI would also be used by traditional FT mechanisms.
01:11:52 <atuljangra> multiple mechanism -> multiple providers OR first using file transfer and then Filelink?
01:12:14 <clokep> atuljangra: Sorry, I meant multiple providers.
01:12:18 <clokep> I.e. getting the configuration set up.
01:12:31 <clokep> We also do want to get it working as a fallback though.
01:13:36 <atuljangra> Okay. Yes, I was just concerned about the order of work. So today I'll work on getting multiple configurable providers.
01:13:57 <atuljangra> I'll upload the code on bitbucket and explain stuff in the daily mail.
01:15:36 <atuljangra> I'll take a lil break for now. Need some fresh air :)
01:16:54 <clokep> Hm. OK.
01:17:07 <clokep> I think Florian was hoping for configurable providers and usch btw.
01:18:02 <-- Mook_as has quit (Quit: Mook_as)
01:19:28 <-- FireFly_TB has quit (Ping timeout)
01:34:38 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
01:34:41 --> clokep has joined #instantbird
01:34:42 * ChanServ sets mode +o clokep 
01:37:38 <-- rosonline has quit (Ping timeout)
01:37:59 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
01:46:01 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 2609 on bug 1221.
01:46:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips
01:47:20 <clokep> wnayes: Any chance of a screenshot attached too?
01:52:55 <wnayes> clokep: Here's with an without an icon. http://i.imgur.com/yThGcyg.png
01:53:25 <wnayes> IRC / statusless tooltips should look the same
01:53:38 <clokep> wnayes: You're one of those people that arranges their buddies by the protocol they use?
01:53:40 <clokep> Lame. :P
01:55:39 <wnayes> I haven't used that AIM account in years... But I think that was my categorization even when using only AIM :)
01:56:02 <clokep> :) Funny.
01:56:05 <clokep> Well looks good thouh!
01:56:15 <clokep> (The tooltip, that is. :))
01:58:16 * wnayes will be glad when this one is review+ :)
01:58:49 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:00:14 <wnayes> Good night!
02:01:16 <-- wnayes has quit (Quit: wnayes)
02:09:07 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:42:34 --> Mook has joined #instantbird
03:03:56 <instant-buildbot> build #914 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/914
03:12:20 <-- Mook has quit (Ping timeout)
03:15:43 --> Mook has joined #instantbird
03:34:12 --> atuljangra has joined #instantbird
03:40:01 <instant-buildbot> build #914 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/914
03:42:34 <atuljangra> http://log.bezut.info/instantbird/130718/#m441 seems a good idea. :-)
04:18:24 <atuljangra> Configurable accounts added. Now whenever a file drops you can choose, which provider you want to use.
04:42:34 * qheaden_away is now known as qheaden
04:42:40 <qheaden> Hello everyone.
04:45:45 <Mook> arrrgh, I can't seem to get the autocopy pref to do anything
04:56:59 <atuljangra> make -C chat/ doesn;t seem to rebuild chrome manifests. :-/
04:58:28 <atuljangra> and similar is the case with make ib
04:59:55 <qheaden> atuljangra: Not sure if this will help, but did you try make tier_app?
05:00:08 <qheaden> atuljangra: Doing that solved an issue for me yesterday.
05:01:10 <atuljangra> Trying. :)
05:01:11 <atuljangra> Thanks
05:11:12 <-- EionRobb1 has quit (Quit: Leaving.)
05:15:29 <qheaden> atuljangra: Did it work?
05:23:35 <atuljangra> qheaden: I'm getting different error now, so I guess yes :P
05:23:43 <atuljangra> Anyway debugging :D
05:23:58 <qheaden> OKay. :P
05:24:48 <atuljangra> qheaden: Can I define two jar file in one jar manifest?
05:25:30 <qheaden> atuljangra: I'm not sure. I'm really not that familiar with manifests.
05:25:39 <atuljangra> no pbm :D
05:25:46 <qheaden> I think you can, but not sure how.
05:25:54 <atuljangra> OKay :)
05:26:13 * qheaden forgot how to work with manifests after using them in one of his past Firefox bugs.
05:27:38 <atuljangra> :)
05:32:54 --> jb has joined #instantbird
05:54:24 <instant-buildbot> build #1010 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1010
05:55:44 <-- jb has quit (Ping timeout)
05:58:12 <qheaden> Well, I'm tired and my eyes are burning. Time for bed. :)
05:58:44 <qheaden> clokep_work: Whenever you get this message, I was able to remove the switch statements from YahooLoginHelper. I hope you like the new implementation.
05:58:50 <qheaden> Bye all. :)
05:59:01 * qheaden is now known as qheaden_away
06:07:40 --> jb has joined #instantbird
06:24:57 <-- Optimizer has quit (Ping timeout)
06:35:39 <-- jb has quit (Ping timeout)
06:49:54 <atuljangra> Bye qheaden_away
06:50:52 <atuljangra> I've a question, in cloudfile/ there are many references to chrome packages corresponding to messenger/ . Till now, I've created some, but still there are many remaining. 
06:51:07 <atuljangra> So, I wanted to know if this is what we want?
06:51:58 <atuljangra> I mean, if we are moving cloudfile/ to chat/ why don't we move the corresponding messenger packages to chat too?
06:52:03 <atuljangra> I hope that makes sense.
06:52:32 <atuljangra> Anyway, for the sake of doing something, I'll try to make messenger packages from chat/
07:01:08 <-- Mook has quit (Ping timeout)
07:02:29 <atuljangra> clokep_work: ping
07:05:11 --> Mook has joined #instantbird
07:09:35 --> Optimizer1 has joined #instantbird
07:10:06 * Optimizer1 is now known as Optimizer
07:18:20 * atuljangra is frustrated. This is second time I'm reverting the changes. :-/
07:22:41 --> jb has joined #instantbird
07:24:51 <atuljangra> http://pastebin.instantbird.com/250722
07:30:07 <Mook> messenger/content/blist.xul?
07:30:29 <Mook> that sounds like you accidentally confused what the instantbird package should map to
07:49:26 --> nhnt11 has joined #instantbird
07:49:30 <nhnt11> Good day.
07:52:23 <atuljangra> Mook: yes. I reverted all my changes and now it
07:52:29 <atuljangra> it's working fine :-)
07:53:02 <nhnt11> clokep_work: I went through your drawing and I think I understand
07:53:25 <nhnt11> Maybe I should confirm with Florian about moving this code to chat/? It was he who told me to put it in instantbird/ iirc.
07:53:50 <atuljangra> is this code ib specific?
07:54:15 <nhnt11> I'm also unsure whether you want me to implement this new flow now, or get a new patch in and move the code before working on ranking.
07:54:32 <nhnt11> atuljangra: It's Ib specific right now, but Tbird may want to use it some day.
07:55:00 <nhnt11> Also the reason to move it into chat is so that I can use the interfaces I'm creating in the prpl interface(s) without affecting tbird.
07:55:47 <nhnt11> brb.
08:06:52 <-- nhnt11 has quit (Ping timeout)
08:11:23 --> nhnt11 has joined #instantbird
08:14:46 --> flo-retina has joined #instantbird
08:14:46 * ChanServ sets mode +qo flo-retina flo-retina 
08:15:01 <-- jb has quit (Ping timeout)
08:19:18 --> gerard-majax_ has joined #instantbird
08:20:11 --> jb has joined #instantbird
08:25:31 <-- gerard-majax_ has quit (Ping timeout)
08:30:37 <-- clokep_work has quit (Connection reset by peer)
08:33:14 <flo-retina> "I am using plaintext logs by the way." (bug 2054), uh :(
08:33:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Special treatment for today / yesterday should not hide logs
08:33:20 --> jb1 has joined #instantbird
08:33:57 <atuljangra> Hi flo-retina :-)
08:34:31 <-- jb has quit (Ping timeout)
08:34:50 --> clokep_wd has joined #instantbird
08:34:51 * clokep_wd is now known as clokep_work
08:35:51 * clokep_work is now known as IRCMonkey34752
08:37:33 * atuljangra hates chrome manifests :-( x-(
08:43:19 <atuljangra> If a chrome package is not find, then we get an message in the error console right? I'm not getting any such msg but still getting this error: http://pastebin.instantbird.com/250797
08:43:40 * atuljangra know this needs some more code. Can provide it
08:44:00 --> Mic has joined #instantbird
08:44:00 * ChanServ sets mode +h Mic 
08:44:38 <Mic> atuljangra: undefined entity means that one of the "&blabla.label;" entities used in a xul/xbl code couldn't be found.
08:45:22 <atuljangra> Okay. So for now I'll try to hardcode the label, I desperately want to run this thing.
08:45:39 <flo-retina> nhnt11: so what do you need/want to move to chat/ ?
08:46:28 <flo-retina> atuljangra: "If a chrome package is not find, then we get an message in the error console right?" no, I think you only get a message on the terminal output of debug builds.
08:47:24 <atuljangra> yes, but if I set debug level to 1 then also I get msg in error console. 
08:47:34 * atuljangra was getting the msgs for a long time now.
08:49:48 <Mic> Would someone take a nice screenshot of the new conversation tab for me? I've got one already but I'd prefer one that doesn't look as antiquated as my theme does ;)
09:05:40 <atuljangra> Where so we set global prefs?
09:06:07 <Mic> atuljangra: what do you mean?
09:06:08 <atuljangra> I mean I want to set "learn more" url for adding filelink accounts.
09:06:16 <atuljangra> Something like this : pref("mail.cloud_files.learn_more_url", "https://support.mozillamessaging.com/kb/filelink-large-attachments");
09:06:25 <Mic> all-instantbird.js ?
09:06:29 <Mic> I'm not sure...
09:06:48 <atuljangra> yes. I was looking for this only :D
09:07:49 <atuljangra> I'm setting the same url for now :)
09:13:42 <flo-retina> atuljangra: "yes, but if I set debug level to 1 then also I get msg in error console. " how is this related to what I was saying?
09:15:28 <nhnt11> flo-retina: The Possible* interfaces
09:15:34 <nhnt11> Mic: Do you still need that screenshot?
09:15:53 <flo-retina> nhnt11: did the patch for nicer icons end up anywhere visible?
09:15:59 <Mic> If you've got a nice one I'd still take it :)
09:16:39 <nhnt11> flo-retina: Do you mean the "+" icon?
09:16:52 <Mic> Does anyone want to proof-read my blog posting?
09:17:15 <nhnt11> flo-retina: Did you want anything in particular from that? I'm going to work on the windows icon now.
09:18:01 <Mic> http://blog.instantbird.org/?p=571&preview=true (You need to be logged in afaik)
09:18:17 <flo-retina> nhnt11: yes, the + icon
09:18:43 <flo-retina> nhnt11: I was just wondering how come I heard about it a few days ago, and then haven't seen anything during the last 2 days or so.
09:18:52 <flo-retina> nhnt11: are you feeling better today?
09:19:06 <nhnt11> flo-retina: I was working on it the day before yesterday. Yesterday I did more work on the stats service.
09:19:16 <nhnt11> Yes, much better, thanks :)
09:19:28 <flo-retina> :)
09:19:52 <nhnt11> Today I want to finish off the + icon patch first, then SS work.
09:21:56 <flo-retina> Mic: "just in case that you need to start a conversation with more than one of the contacts" is confusing (looks like you are starting a MUC). You likely want to say instead "just in case you need to start more than one conversation"
09:22:18 <nhnt11> Mic: I'm trying to figure out a way to show only my Instantbird contacts for the screenshot. I don't want to use IRC contacts because they dont have buddy icons..
09:22:45 <flo-retina> Mic: "include way to filter the list by tags" I think you wanted 'include *a* way'
09:23:31 <flo-retina> Mic: otherwise, looks great, thanks for writing this! :)
09:23:37 <Mic> Fixed :)
09:24:03 <flo-retina> and you do need a better screenshot :)
09:24:17 <nhnt11> Mic: Here's a screenshot, but it's only IRC contacts so no user pictures: veuwhmfdcvsxrmxc
09:24:20 <nhnt11> :O
09:24:27 <nhnt11> I dont know what I just pasted
09:24:41 <flo-retina> a password? :-P
09:24:43 <nhnt11> http://puu.sh/3GvrC.png is what I meant
09:24:50 <Mic> flo-retina: the grey border for the image sucks too :S
09:24:59 <flo-retina> nhnt11: that's not a good screenshot
09:25:03 <nhnt11> flo-retina: I agree
09:25:13 <flo-retina> nhnt11: you want buddy icons to be shiny, and you don't want all contacts to have the same tag
09:25:20 <nhnt11> Yeah
09:25:33 <flo-retina> what happened to the retina "tag"' icon btw?
09:25:41 <nhnt11> Would it be ok to have blurred names?
09:25:50 <flo-retina> Not really
09:26:17 <flo-retina> I wonder how difficult it would be to make Fake work with the awesometab :-S
09:26:18 <nhnt11> Yeah it turns out that was an application specific password. I revoked it now though
09:26:31 <nhnt11> flo-retina: If it's an account, it'll "just work"
09:26:41 <flo-retina> ah, so we could log into your gmail account for a few seconds? :-P
09:26:51 <nhnt11> :]
09:27:07 <flo-retina> nhnt11: it's not an account. It's a bunch of JS code used to generate the screenshots we show on the main website, using completely fake data.
09:27:08 <Mic> nhnt11: you can get my user icon on IRC too if you use my IRC Avatar extension by the way.
09:27:14 <flo-retina> (fake accounts, fake contacts, fake messages)
09:27:27 <Mic> Does fake work at all at the moment?
09:27:31 <nhnt11> flo-retina: Fake contacts would work.
09:27:31 <flo-retina> we did it this way so that we could have the exact same stuff displayed on the screenshot for all OSes
09:27:31 <Mic> I don't think so.
09:27:39 <flo-retina> Mic: really? :(
09:27:44 * flo-retina hasn't tried in a while
09:27:46 <Mic> clokep tried to fix it but failed iirc.
09:28:35 * flo-retina is trying fake
09:28:37 <-- Even has quit (Ping timeout)
09:29:06 <flo-retina> [Exception... "'[JavaScript Error: "account is null" {file: "file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebug.app/Contents/MacOS/components/imContacts.js" line: 1286}]' when calling method: [imIContactsService::accountBuddyAdded]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://fake/content/fake.js :: f_fakeIt :: line 245"  data: yes]
09:29:08 <flo-retina> bah :(
09:29:11 <Mic> Bug 1768, attachment 2289
09:29:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1768 enh, --, ---, nobody, NEW, Add user icon support on IRC
09:29:56 <nhnt11> Mic: Cool.
09:30:03 --> Even has joined #instantbird
09:30:04 * ChanServ sets mode +o Even 
09:30:17 <Mic> It doesn't do DCC yet, so you need to set a web-hosted image as source :(
09:30:28 --> gerard-majax_ has joined #instantbird
09:30:31 * nhnt11 wonders if he should setup another gmail that will have only Instantbird contacts, or something.
09:30:46 <nhnt11> May be useful if Fake doesn't work..
09:31:47 <nhnt11> Ah, so you need a separate blog account to view that link?
09:32:24 <Mic> If you can't view it, then yes.
09:55:22 <-- jb1 has quit (Ping timeout)
10:03:09 <atuljangra> I would take a break for sometime!
10:05:30 --> clokep has joined #instantbird
10:05:30 * ChanServ sets mode +o clokep 
10:09:09 <clokep> nhnt11: I don't understand why you think all of it must be in chat/ or all of it must be in instantbird/.
10:09:29 <clokep> nhnt11: My drawing was a suggestion of how I think it would be designed, it does not mean that's how you must d it.
10:17:31 <-- nhnt11 has quit (Ping timeout)
10:20:59 <atuljangra> clokep flo-retina http://log.bezut.info/instantbird/today#m133
10:22:38 --> novabyte has joined #instantbird
10:24:35 <-- Optimizer has quit (Ping timeout)
10:25:30 --> Optimizer has joined #instantbird
10:26:03 --> nhnt11 has joined #instantbird
10:26:21 <nhnt11> clokep: Not all of it, but if I go by what you say, then Possible* interfaces at least woud need to move
10:26:59 <clokep> nhnt11: Yes, I don't see the issue. :-S
10:27:15 <nhnt11> It's not an issue at all :)
10:27:27 <clokep> atuljangra: Some of those you probably need to include the files. It sounds like you hvaen't included the proper properties files.
10:27:34 <clokep> (Or maybe dtds)
10:27:37 <clokep> I.e. the locales.
10:27:37 <nhnt11> I'm merely stating that I'd have to do it, not that it's an issue to do so.
10:28:22 <nhnt11> I'd like to discuss this more later. Right now, a couple friends just randomly dropped by. bbl.
10:28:30 <atuljangra> clokep: I've finished that and uploaded the code to bitbucket. But the code is pretty dirty, so I wanted to know the ideal places for the packages.
10:30:34 * clokep doesn't understand.
10:32:19 <clokep> atuljangra: I'm confused at whether you're still havin gissues or not.
10:32:41 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:33:27 <atuljangra> clokep: No, I'm not having issues now. I finished provider selection and provider configuration as we discussed earlier. :)
10:33:27 <atuljangra> But
10:33:29 <atuljangra> Currently the cloudfile/ code takes everything from the chrome packages "messenger", contents and skins both. But in the situation where cloudfile/ has been moved to chat/ and is common to two different applications, is it ideally correct to continue using "messenger" packages.
10:34:08 <clokep> It would probably need to be renamed, yes. To either chat or it's own package.
10:34:40 <clokep> flo-retina: I know why plaintext log READING is still supported. ;) I didn't know we coulds till write them.
10:34:49 <atuljangra> clokep: Yes, so is that renaming a part of this project? Should I do it?
10:35:03 <flo-retina> clokep: if you can't write them, you can't have them for "today" ;)
10:35:14 <flo-retina> clokep: so I assume we left somewhere a pref to toggle to plain text
10:35:32 <clokep> atuljangra: It's a trivial part of the project. We're more concerned (currently) at showing that the behavior and UX we want can be done.
10:35:41 <clokep> atuljangra: Try not to get tied up by little details like this, please.
10:35:51 <clokep> flo-retina: :( It's anabout:config pref, yes.
10:37:52 <atuljangra> clokep: Okay :) So today I would refine the code that does the provider selection and provider configuration.
10:38:19 <atuljangra> I've not added anything to our preferences window yet, I am keeping it low priority currently.
10:39:01 <Mic> Would adding to the pref window be so complicated by the way?
10:39:38 <Mic> I'd expect it to be copying some files and adding a few lines to the preferences window itself so that the new tab appears there.
10:39:54 <Mic> Ignore me if I'm over-simplifying things of course ;)
10:40:39 <atuljangra> Mic: I tried doing it a couple of days back, there are many dependencies issues that need to be resolved. Somehow tb has integrated Applications and Attachments pane, so this would require rewriting attachments.xul and attachments.js 
10:40:49 <Mic> Ah, OK.
10:41:05 --> nhnt11 has joined #instantbird
10:41:05 <atuljangra> s/attachment/(some pretty name)
10:41:57 <clokep> Kind ofseems like we'd want similar preferences though.
10:42:01 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:42:29 <atuljangra> Mic: Yes, that would be a 2-day work. I'll complete it over next weekend.
10:42:35 <atuljangra> What would you guys want to get done after "provider selection and provider configuration"?
10:43:00 <Mic> I need to go.
10:43:11 <Mic> I might look at "fake" tonight!
10:43:13 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:43:32 <clokep> atuljangra: I think at that point it's time to look at having a it be a fallback mechanism again.
10:45:08 <atuljangra> Okay. I'll look into it. Though I won't be able to produce good code related to that today, since I'll be cleaning up what I've done so far.
10:55:40 <clokep> atuljangra: We're also going to need a patch and directions of how to configure things at some point...
10:56:02 <clokep> It's OK if the patch is still messy, as long as it works.
10:56:47 <flo-retina> atuljangra: I asked for a *working* proof of concept. That means we need to be able to try it (which working revision should we try? What do we need to setup in about:config? ...)
10:58:05 <atuljangra> flo-retina: Okay. I'll clean up the code and will provide the working proof by tomorrow afternoon.  
10:58:31 <atuljangra> Currently you just need to drop the file, it will open the dialog necessary to configure the accounts.
10:58:48 <atuljangra> I'll provide the revision to you guys. :D
10:59:19 <-- Tonnes has quit (Connection reset by peer)
11:09:10 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:13:29 <atuljangra> flo-retina: I'll be back in night :)
11:13:32 <atuljangra> Bbye
11:13:43 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
11:18:46 <-- Optimizer has quit (Ping timeout)
11:18:49 --> mpmc has joined #instantbird
11:26:55 <-- mpmc has quit (Connection reset by peer)
11:28:04 --> mpmc has joined #instantbird
11:30:39 <-- mpmc has quit (Connection reset by peer)
11:31:51 --> mpmc has joined #instantbird
11:32:47 <-- mpmc has quit (Connection reset by peer)
11:33:53 --> mpmc has joined #instantbird
11:36:31 <-- mpmc has quit (Connection reset by peer)
11:37:36 --> mpmc has joined #instantbird
11:39:33 <-- mpmc has quit (Connection reset by peer)
11:40:39 --> mpmc has joined #instantbird
11:45:51 --> Optimizer has joined #instantbird
11:52:45 <-- Optimizer has quit (Ping timeout)
11:53:00 --> Optimizer has joined #instantbird
11:54:29 --> clokep_ has joined #instantbird
12:06:16 <-- Optimizer has quit (Ping timeout)
12:07:26 --> Optimizer has joined #instantbird
12:17:32 <-- Optimizer has quit (Connection reset by peer)
12:18:47 --> Optimizer has joined #instantbird
12:23:03 <-- Optimizer has quit (Ping timeout)
12:26:45 --> nhnt11 has joined #instantbird
12:27:38 --> Optimizer has joined #instantbird
12:32:16 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:33:37 <-- Optimizer has quit (Connection reset by peer)
12:35:18 --> Optimizer has joined #instantbird
12:39:10 --> nhnt11 has joined #instantbird
12:39:16 <-- nhnt11 has quit (Quit: nhnt11)
12:39:45 <-- Optimizer has quit (Ping timeout)
12:42:51 --> Optimizer has joined #instantbird
12:50:43 <-- Optimizer has quit (Ping timeout)
12:51:30 --> Optimizer has joined #instantbird
12:56:39 <-- Optimizer has quit (Ping timeout)
13:00:43 --> Optimizer has joined #instantbird
13:08:03 <-- novabyte has quit (Quit: bye bye)
13:10:40 <-- Optimizer has quit (Connection reset by peer)
13:11:17 --> Optimizer has joined #instantbird
13:16:56 --> aleth has joined #instantbird
13:16:56 * ChanServ sets mode +h aleth 
13:29:06 <aleth> flo-retina: I didn't know it was still possible to use plaintext logs :-S
13:30:15 <-- Optimizer has quit (Ping timeout)
13:30:23 <clokep_> aleth: Hopefully that gives use STR though?
13:30:52 <aleth> clokep_: Yes, I understand why he has that problem know.
13:31:13 --> Optimizer has joined #instantbird
13:31:18 <aleth> But I thought I knew that code, and didn't think we had a pref to turn txt logs back on... I wonder if he hacked it?
13:31:31 <aleth> s/know/now
13:33:29 <clokep_> aleth: http://lxr.instantbird.org/instantbird/source/chat/chat-prefs.js#98 ?
13:33:33 <clokep_> That implies we do
13:33:42 <aleth> clokep_: Right, I just found that too.
13:33:49 <aleth> :(
13:34:09 <aleth> Thanks, though. When I added text logs legacy support I assumed there wouldn't be any new ones created.
13:34:15 <clokep_> aleth: http://lxr.instantbird.org/instantbird/source/chat/components/src/logger.js#161
13:34:24 <clokep_> Right. :-/
13:35:36 <aleth> Not hard to fix, but annoying to have to special-case that.
13:36:00 <flo-retina> can we just drop support for writing plain text logs? ;)
13:36:52 <aleth> We could ;) I guess the bug reporter might not like that particular fix :D
13:37:09 <aleth> I'll take a look at how complicated the fix would make the code first.
13:39:03 <clokep_> Is the logger actually pluggable btw?
13:39:26 <aleth> Pluggable?
13:40:08 <clokep_> Can it be replaced w/ an extension
13:41:15 <aleth> Mic would probably find some way, but that sounds like a worse solution.
13:41:51 <aleth> We certainly wouldn't want to support that I think
13:42:54 <clokep_> It was just a question. :-D
13:43:06 <clokep_> It was "Hey, can we remove this code and tell him to make it an extension if he wants?"
13:43:12 <clokep_> I'd be curious why he wants plaintext logging.
13:43:18 <clokep_> (Most likely so he can grep it.)
13:46:45 <clokep_> Mic: "It will also include already ongoing conversations (Switch to conversation) and allow to join multi user chats like IRC channels, chatrooms on XMPP and other networks." sounds really awkward around "allow".
13:48:53 <clokep_> Do we /really/ care about tags in the awesometab?
13:49:49 <aleth> I don't see why not. We have the feature, it's hard to predict all the ways people use it.
13:49:53 <-- Optimizer has quit (Ping timeout)
13:50:29 <aleth> What's broken at the moment is that the filtering doesn't act on tags.
13:50:56 <aleth> I can't type "inst" and get all Instantbird people...
13:51:04 --> Optimizer has joined #instantbird
13:51:06 <clokep_> OK.
13:51:10 <clokep_> Was just wondering. ;)
13:51:26 * clokep_ is curious to see how we're going to get joining MUCs to work. :P
13:51:32 <clokep_> Hopefully nhnt11 wakes up at some point
13:54:17 <flo-retina> clokep_: there's no reason to make the current log writer pluggable, because it's completely trivial to write an add-on that just observes the same notifications as the current log writer
13:54:26 <flo-retina> (ie one would just turn it off and put something else instead)
13:55:06 --> mconley has joined #instantbird
13:58:57 <-- aleth has quit (Quit: Ciao)
13:59:20 --> aleth has joined #instantbird
13:59:20 * ChanServ sets mode +h aleth 
14:01:08 --> nhnt11 has joined #instantbird
14:01:13 <nhnt11> clokep_: I'm not asleep :P
14:01:19 <nhnt11> I'll be online through the night
14:01:36 <nhnt11> couple of my friends wanted to see me before I leave, they won't have a chance after this weekend so...
14:01:45 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:05:13 <-- Optimizer has quit (Ping timeout)
14:06:20 --> Optimizer has joined #instantbird
14:28:46 <-- Optimizer has quit (Ping timeout)
14:30:03 --> Optimizer has joined #instantbird
14:44:29 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:59:47 <clokep_> aleth: So I was rethinking bug  1719 last night.
14:59:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1719 tri, --, ---, nobody, NEW, User message isn't RFC 1459 compliant
15:00:00 --> Mic|web has joined #instantbird
15:00:03 <Mic|web> Hi
15:00:03 <clokep_> And I realized we're really not following a policy of being strict in what we emit and liberal in what we accept.
15:00:11 <clokep_> Hello Mic|web!
15:00:58 <Mic|web> No idea what you're talking about but the latter seems harder than the other ;)
15:02:41 * qheaden_away is now known as qheaden
15:02:42 <aleth> clokep_: Do you mean "if we can satisfy both RFCs without causing problems, we should"?
15:02:46 <qheaden> Hello everyone!
15:03:06 <qheaden> clokep_: I
15:03:18 <qheaden> clokep_: I'm happy you like my approach to removing the switch statements.
15:09:47 <clokep_> aleth: http://en.wikipedia.org/wiki/Robustness_Principle Yes.
15:09:57 <clokep_> qheaden: It's what I had asked for, yes.
15:10:09 <clokep_> aleth: I guess my point is if some servers want the : there, should we always send it?
15:10:48 <aleth> What was the reason for not adding the : ? That it would require special-casing the user message?
15:11:22 <clokep_> We wrote code at some point that sends that only when it is necessary.
15:11:54 <aleth> So are you suggesting making a change for all messages or just for USER messages?
15:12:43 <clokep_> I'm suggesting all messages.
15:13:16 --> flo-retina has joined #instantbird
15:13:16 * ChanServ sets mode +qo flo-retina flo-retina 
15:13:48 <clokep_> Just curious of your thoughts, not saying I'm going to do it. :P
15:17:50 <qheaden> clokep_: I think I need to add some sort of indexOf method to ArrayBufferUtils.
15:18:08 <Mic|web> lol, I'm not sure how (or if I want) to interpret this: http://log.bezut.info/instantbird/130719/#m385
15:19:16 <Mic|web> I can't have a look at Fake (and therefore a new screenshot for the blog posting) tonight as I just got invited to BBQ by friends who I haven't seen in quite a while. Just to let you know...
15:19:36 <clokep_> qheaden: Um, to do what?
15:20:16 <clokep_> Mic|web: I left you a comment somewhere about that post.
15:20:26 <clokep_> Mic|web: We don't want to publish it on a Friday afternoon anyway. ;)
15:20:45 <-- flo-retina has quit (Ping timeout)
15:21:15 <qheaden> clokep_: Nevermind. I thought I was using indexOf on a dataString. I was using split instead.
15:21:53 <clokep_> :) OK.
15:22:02 <clokep_> qheaden: Btw that parsing method...it looks overly complicated.
15:22:06 <clokep_> Someone needs to take a look at it again.
15:22:16 <qheaden> clokep_: _extractPackets?
15:22:18 <clokep_> I can try to do it this afternoon / tomorrow.
15:22:19 <clokep_> Yes.
15:22:33 <clokep_> Bah, I'm going to dinner tonight, that won't work...
15:23:48 <aleth> Mic|web: I meant "I'm sure it's possible and you'd be the person to actually know how but I don't want to suggest it to the bug reporter" ;)
15:24:08 <Mic|web> Ah, OK. That's OK ;)
15:24:49 <clokep_> Mic|web: I think you were just called the Mook of Instantbird. :P
15:26:08 <Mic|web> ;)
15:27:06 <qheaden> clokep_: I'm not sure if Yahoo or Yahoo JAPAN is ever localized. Aren't corporation names usually preserved in other languages?
15:28:11 <clokep_> qheaden: Yes, it was just a question.
15:28:38 <qheaden> clokep_: So leave it for now? Or make a localized string just in case?
15:30:14 <aleth> clokep_: I don't have a strong opinion on the colon, though I suppose if the colon doesn't conflict with either RFC the more robust thing is to always send it. Are you using BNC now or what made you think of it again?
15:31:23 <clokep_> qheaden: Leave it.
15:31:34 <qheaden> OK.
15:42:59 <instantbot> florian@instantbird.org denied review for attachment 2609 on bug 1221.
15:43:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips
15:46:08 <-- Mook has quit (Quit: Mook)
15:49:43 <qheaden> clokep_: Okay, I just completely removed the need for the YahooSocket class and yahoo-socket.jsm file.
16:11:22 <Mic|web> atuljangra: why haven't are you tracking "orig" files in your repository? It's only two but they amount to over 500 lines in this already large changeset...
16:11:32 <Mic|web> *why are you
16:15:20 <instantbot> florian@instantbird.org requested review from the wind for attachment 2610 on bug 1808.
16:15:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1808 min, --, ---, nobody, NEW, Update fake
16:32:00 --> nhnt11 has joined #instantbird
16:44:21 --> Mook_as has joined #instantbird
16:48:45 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:59:53 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:01:25 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2611 on bug 2054.
17:01:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Special treatment for today / yesterday should not hide logs
17:04:28 --> nhnt11 has joined #instantbird
17:05:05 <clokep_> qheaden: OK. :) Btw if you disagree w/ our comments let us know.
17:05:41 <qheaden> Okay. I disagree with EVERYTHING! :P
17:05:56 <qheaden> clokep_: But really though, all of your suggestions are excellent.
17:06:07 * nhnt11 invites qheaden to start a rebellion
17:06:43 <clokep_> qheaden: Meaning it'll be a discussion, not that you get to just disagree. ;)
17:07:02 <instantbot> clokep@gmail.com granted review for attachment 2610 on bug 1808.
17:07:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1808 min, --, ---, nobody, NEW, Update fake
17:12:29 <clokep_> aleth: Btw a friend ran into the Linux not having any https? handlers defined yesterday. :(
17:12:34 <clokep_> Luckily the bug says how to manually add them. :)
17:12:52 <clokep_> This was on Linux Mint.
17:13:18 <aleth> clokep_: We know what's causing it, unfortunately the (trivial) fix depends on Even doing a lot of (nontrivial) work :(
17:13:47 <aleth> I hope he can eventually find an OK way to tackle it, because the problem is going to get more and more common as people update their distros.
17:14:39 <aleth> bug 1877
17:14:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1877 nor, --, ---, nobody, NEW, Enable gio after Linux buildslave distro is updated
17:15:58 <clokep_> aleth: :(
17:16:43 <clokep_> flo, Even: Btw I read somewhere that Firefox/Thunderbird are now using Ubuntu for their build slaves, not...whatever it is you guys use. :(
17:16:43 <-- gerard-majax_ has quit (Ping timeout)
17:18:28 <clokep_> aleth: That new code is kind of rgoss. :-/
17:20:23 <aleth> clokep_: For bug 2054? It's not super pretty, but doesn't really add anything either. The special-casing of today/yesterday is already there for JSON.
17:20:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Today/yesterday entries in log viewer don't work for text logs
17:20:51 <clokep_> aleth: Ah, I see. I didn't know that. :)
17:21:03 <aleth> i.e. I would have wontfixed the bug if I had had to add a hack ;)
17:23:49 <-- Optimizer has quit (Ping timeout)
17:26:10 <instantbot> aleth@instantbird.org denied review for attachment 2603 on bug 2054.
17:26:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Today/yesterday entries in log viewer don't work for text logs
17:35:24 --> rosonline has joined #instantbird
17:35:59 <-- rosonline has quit (Client exited)
17:39:13 --> Optimizer has joined #instantbird
17:41:00 <-- Optimizer has quit (Ping timeout)
17:43:18 <qheaden> clokep_: Based on the comment, I take it that onConnectionHeard is called only when dealing with bound and listening sockets?
17:43:29 --> Optimizer has joined #instantbird
17:45:46 <clokep_> Um it might deal with only sockets that are listening, yes.
17:45:57 <clokep_> In that case you shouldn't overwrite it though.
17:46:53 <qheaden> clokep_: Okay.
17:47:04 * qheaden goes back to socket.jsm to see which methods have a default implementation.
17:50:36 <qheaden> clokep_: Also, I still have to look into onBadCertificate. I don't think Yahoo! Messenger servers use any certs.
17:50:50 <clokep_> qheaden: Are you connecting via SSL or is it all in the open?
17:51:02 <qheaden> clokep_: All in the open.
17:51:18 * clokep_ reminds himself to make sure that password is totally different than everything else. ;)
17:51:27 <clokep_> qheaden: Then you need a comment saying why that isn't implemented. :)
17:52:16 * qheaden doesn't think Yahoo! Messenger provides a secure chat method. :(
17:54:04 <-- Optimizer has quit (Ping timeout)
17:54:28 --> Optimizer has joined #instantbird
17:56:06 <qheaden> clokep_: Also, do I really need the same comments above each one like is found in socket.jsm? The names are pretty self-explanatory. I'll just comment on why certain ones aren't implemented.
17:57:09 <clokep_> qheaden: No, I don't think I told you to add those. ;)
17:57:18 <qheaden> Okay. :)
17:59:56 <clokep_> nhnt11: So you're still making progress right? You're not tied up waiting for someone to make a decision?
18:03:50 --> gerard-majax_ has joined #instantbird
18:05:40 <nhnt11> clokep_: Yes, it's fine. I can always make changes later if needed, I don't think it's too difficult. I'm continuing what I started with having multiple implementations of PossibleConversation (not your proposed way) for now, but want to discuss this with flo as well.
18:08:52 <qheaden> clokep_: Perhaps I can group all of the empty socket methods at the bottom of YahooSession?
18:13:03 <clokep_> qheaden: Why are they empty? :-S
18:13:10 <clokep_> nhnt11: Remember he's going on vacation after this weekend. :)
18:13:20 <nhnt11> Yeah I do remember :)
18:13:44 <qheaden> clokep_: Oh, I forgot that you no longer throw not implemented errors in your socket.jsm code.
18:14:03 <clokep_> qheaden: If you think we should, file a bug.
18:14:17 <aleth> nhnt11: Sounds like a good plan to put up a new patch with the nits out of the way (if you are close to having one ready) and then discuss the outstanding architectural stuff based on that
18:14:24 <qheaden> clokep_: No, I think it is better that you not throw those errors.
18:14:27 <clokep_> Note that the methods you're not using should never get called.
18:14:33 <nhnt11> aleth: Right, that's what I thought too
18:15:04 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:21:24 --> aleth_dev has joined #instantbird
18:22:13 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:24:44 --> aleth_dev has joined #instantbird
18:26:23 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:26:35 --> aleth_dev has joined #instantbird
18:27:53 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:31:57 --> aleth_dev has joined #instantbird
18:33:08 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:34:36 --> aleth_dev has joined #instantbird
18:35:54 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:38:29 --> aleth_dev has joined #instantbird
18:40:53 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:57:21 --> clokep has joined #instantbird
18:57:21 * ChanServ sets mode +o clokep 
19:01:58 <clokep> Apparently they're shutting off SkypeKit functionality in < 12 months.
19:02:43 --> rosonline has joined #instantbird
19:02:46 <aleth> So much for Skype support then...
19:02:59 <clokep> :P
19:04:38 <clokep> Well good thing we didn't do GSoC for that. ;)
19:05:01 <aleth> Definitely ;)
19:06:11 --> aleth_dev has joined #instantbird
19:07:07 * aleth fixes bug, introduces new one
19:07:51 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:07:58 <clokep> Haha.
19:08:00 <clokep> What bug is this?
19:08:36 <aleth> I haven't even filed it yet, but section scroll is sometimes broken in the log viewer
19:17:01 --> aleth_dev has joined #instantbird
19:18:28 <-- aleth_dev has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:18:53 <qheaden> clokep: I've implemented a lot more stuff in my code. Should I post another patch when I am done for the day?
19:19:23 <clokep> qheaden: When you're ready for another round of feedback, you should.
19:19:27 <clokep> Did you take care of all the comments?
19:19:46 * aleth should write a Remove Dumps macro
19:21:22 <qheaden> clokep: Almost, I'm still working on a couple of things. Also, do we still want to change the dataString stuff?
19:21:37 <qheaden> It seems to work so well, and is easy to deal with as a data string.
19:22:21 <clokep> qheaden: I did not say to remove it, but I'd like you to comment on me saying something about it.
19:22:48 <qheaden> clokep: Comment in the code?
19:22:54 <clokep> No.
19:23:13 <qheaden> OK.
19:23:22 <clokep> In the bug.
19:27:54 <instantbot> New Instantbird (UI) bug 2061 filed by aleth@instantbird.org.
19:27:55 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2612 on bug 2061.
19:27:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2061 nor, --, ---, aleth, ASSI, Section scroll doesn't find all sessions
19:30:51 * clokep goes to attempt to fix everything that nhnt11 broke.
19:32:27 <-- gerard-majax_ has quit (Ping timeout)
19:33:48 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:34:03 --> clokep has joined #instantbird
19:34:03 * ChanServ sets mode +o clokep 
19:34:16 <nhnt11> clokep: Vertical tabs?
19:34:17 <nhnt11> :P
19:34:30 <clokep> Yes.
19:34:48 <clokep> I need to figure out what changed. :-/
19:34:59 <nhnt11> clokep: I can take a few minutes and help, if you'd like
19:35:26 --> gerard-majax__ has joined #instantbird
19:35:27 <clokep> nhnt11: I'll let you know if I see anything first, but thanks. :)
19:35:46 <aleth> If you're lucky, it's just getBrowser -> getTabBrowser ;)
19:35:51 <nhnt11> ;)
19:36:14 <clokep> I don't use getBrowser.
19:36:22 <clokep> I think I need to rename everything that deal w/ conversations.
19:37:07 <clokep> aleth: Ah, well that looks like part of it. :)
19:37:42 <clokep> aleth: Actually...that seems to have fixed it. :-D
19:37:50 <aleth> Lucky :D
19:37:52 <nhnt11> :D
19:39:27 <clokep> Did we break highlight again? :(
19:40:02 <clokep> http://hg.instantbird.org/addons/file/f5805847fa6f/highlight/content/highlight.js#l42 bleh :(
19:40:02 <aleth> Nobody ever fixed it :(
19:40:22 <clokep> Um. What? I fixed it a while ago.
19:40:27 <clokep> nhnt11 broke it again.
19:40:35 <aleth> Oh, that's what I was referring to
19:40:41 <nhnt11> What's wrong?
19:40:45 <nhnt11> Ah, getBrowser
19:40:47 <aleth> I think I got as far as filing a bug...
19:40:57 <clokep> http://hg.instantbird.org/addons/rev/7a85c03cbf2f was when I last fixed it.
19:41:01 <clokep> No, there's no bug open on it.
19:41:50 <aleth> bug 2017
19:41:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2017 nor, --, ---, nobody, NEW, Highlight broken by tabbrowser changes
19:42:49 <Mook_as> hrm. is https://bugzilla.mozilla.org/show_bug.cgi?id=764242 likely to be broken by those tabbrowser changes?
19:42:51 <clokep> Bah. :(
19:43:05 <clokep> Mook_as: These changes are Instantbird only.
19:43:19 <Mook_as> yes. I'm hoping to move that over at some point :)
19:43:35 <clokep> "that"?
19:44:44 * nhnt11 is curious where this discussion is leading
19:44:54 <Mook_as> well, at this point I'm assuming magic copy is equally broken on ib?
19:45:01 <Mook_as> maybe my assumption is wrong...
19:45:06 <nhnt11> Magic copy is broken?
19:46:54 <Mook_as> okay, so skimming the code, it's not affected
19:47:07 <Mook_as> but the bug does exist, the code is just so different that a different fix is needed
19:52:47 <qheaden> clokep: About my checking if the user exists in removeParticipant, I'm doing that in case the Yahoo Server sends a logoff packet twice by mistake or something. Something can be quirky with the network.
19:53:08 <clokep> OK. That shold be in a comment.
19:53:12 <qheaden> OK.
19:53:32 <clokep> :)
19:54:50 <qheaden> clokep: Also, the room numbering I got from libpurple. That's how they increment room numbers.
19:55:04 <qheaden> It ensures uniqueness.
19:55:42 <instantbot> aleth@instantbird.org granted review for attachment 2576 on bug 2015.
19:55:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, 1.5, nhnt11, RESO FIXED, Display buddy list in a tab.
19:56:46 <nhnt11> aleth: Weird, it shows you r+'d the attachment twice at the top
19:57:14 <aleth> Huh, strange. I was just looking through my request queue and saw it there.
19:57:49 <aleth> Maybe it's r++ ;)
19:57:58 <nhnt11> :P
20:03:36 <qheaden> clokep: In the YahooAccount.disconnect(), you want me to set the account status using reportDisconnecting and reportDisconnected?
20:06:14 <-- gerard-majax__ has quit (No route to host)
20:06:14 --> gerard-majax_ has joined #instantbird
20:09:08 <clokep> qheaden: Yes, OK.
20:09:32 <clokep> qheaden: You need to make sure it shows the proper state in the account manager.
20:13:54 <-- gerard-majax_ has quit (Ping timeout)
20:14:54 * clokep wonders why his DOMi isn't coming up. :(
20:16:29 --> gerard-majax_ has joined #instantbird
20:16:32 <clokep> nhnt11: Yeah, so that changeset didn't change the entire structure of tabbrowser as I feared.
20:16:47 <nhnt11> No, it didn't :)
20:18:54 <clokep> aleth: Can I throw an addon review your way?
20:19:05 <aleth> clokep: Sure
20:20:36 <clokep> aleth: https://addons.instantbird.org/en-US/developers/versions/244/?
20:22:11 <clokep> aleth, nhnt11: Is there a way to check for getBrowser or getTabBrowser? I.e. make it backwards compatible?
20:23:46 <nhnt11> clokep: Off the top of my head, I can only think of checking the node name of the returned element
20:24:15 <clokep> Hm. OK
20:24:20 <clokep> Does the function exist in the same scope?
20:24:31 <nhnt11> Yes.
20:25:09 <clokep> Bah...
20:25:13 * clokep wonders if that's worth trying.
20:25:19 <clokep> http://pastebin.instantbird.com/251367 works though.
20:25:25 <clokep> Anyone have opinions?
20:25:27 <qheaden> clokep: Okay. YahooAccount.disconnect() calls YahooSession.logout(), which handles setting the account state.
20:25:34 <clokep> qheaden: OK.
20:25:48 <nhnt11> clokep: You can probably do document.getElementById("conversations") as a foolproof way
20:25:57 <qheaden> Patch time! :)
20:26:14 <aleth> clokep: Does it matter? It simply won't autoupdate for those on 1.4, right?
20:27:03 <aleth> clokep: Highlight should also have minversion=1.5
20:27:07 <clokep> aleth: That was my question.
20:28:54 * clokep pushed a fix.
20:29:36 <aleth> I wouldn't worry about it I think. It's not like the older versions go away (though AIO is probably not smart enough to offer them automatically).
20:29:50 <clokep> It''s not. ;)
20:31:10 <clokep> aleth: https://code.google.com/p/vertical-tabs/source/detail?r=0c11a39e8f030bdd54d9f9528c43ef5db650243a is the changes I made.
20:32:02 <aleth> clokep: AIO actually has a convenient built in diff, but thanks ;)
20:32:09 <clokep> Oh, nice. :)
20:32:12 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2613 on bug 1982.
20:32:12 <clokep> shows how much I know. :-[
20:32:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
20:32:45 <aleth> You probably have to reupload Highlight manually too?
20:32:53 <clokep> aleth: I wasn't going to yet.
20:33:18 <aleth> I guess it should land in the repo first ;)
20:34:04 <clokep> aleth: What do you mean?
20:34:19 <clokep> Does http://hg.instantbird.org/addons/rev/732dba5374bc not count as landed? :P
20:34:38 <aleth> Oh, I didn't realize you could commit to that one :D
20:34:44 <clokep> I can.
20:36:30 <-- Optimizer has quit (Connection reset by peer)
20:37:01 --> Optimizer has joined #instantbird
20:37:05 <clokep> I see qheaden is trying to keep me busy.
20:37:19 <qheaden> \o/
20:37:40 <qheaden> clokep: I got your BitBucket comment right after I pushed the patch. :-/
20:37:47 * qheaden should have waited.
20:37:54 <clokep> It's OK. :)
20:37:59 <clokep> That's not a huge deal.
20:38:06 * clokep wonders how hard this would be to extensionize.
20:43:53 <clokep> qheaden: Have you ever written an extension btw?
20:44:09 <qheaden> clokep: No I haven't. I want to some day though.
20:44:31 * qheaden needs to make his Short URL Scanner Chome extension cross-browser.
20:45:39 <qheaden> clokep: How different is it from what I am doing now, except for manifests and such?
20:45:56 <clokep> qheaden: The set up is different and you have to inject things.
20:45:59 <clokep> Which I find annoying. :-D
20:46:03 <clokep> But besides that its the same...
20:46:08 <qheaden> :P OK
20:46:12 * clokep is writing a script to make an extension from the yahoo code.
20:47:32 --> flo-retina has joined #instantbird
20:47:32 * ChanServ sets mode +qo flo-retina flo-retina 
20:47:38 <qheaden> clokep: What's your extension for?
20:47:58 <flo-retina> bah, again in the state of accounts not automatically reconnecting :(
20:48:31 <flo-retina> clokep: http://log.bezut.info/instantbird/130719#m495 my understanding is that they use ubuntu for build*bot* *test* slaves, and that the build slaves are on CentOS6
20:48:37 <flo-retina> (we are on CentOS5)
20:49:08 <clokep> flo-retina: Ohhh, that's possible. :) Maybe I misunderstood what I hear.
20:49:17 <clokep> qheaden: Um...it's your code.
20:49:34 <flo-retina> btw, my patch for Fake makes it "work again" like it did before it got broken
20:49:39 <qheaden> clokep: Oh okay. You are trying to extensionize my code.
20:49:50 <clokep> qheaden: It isn't too hard, but yes.
20:49:58 <flo-retina> but for some reason I couldn't open the newtab on my debug build running Fake. *Nothing* happened when I clicked the + button.
20:50:10 <clokep> flo-retina: That's OK, it's nice to have Fake working at all again.
20:50:57 <flo-retina> not sure if I should poke some more at it, or let nhnt11 have a look
20:51:18 <nhnt11> flo-retina: I can take a look if you'd like
20:51:21 <nhnt11> How do I use fake?
20:52:07 <flo-retina> nhnt11: you user a debug build, create a new profile, or use a profil you don't care about completely messing up, then you start with FAKE=1 ./instantbird -P <profile name>
20:52:13 <flo-retina> *you use
20:52:28 <nhnt11> thanks.
20:52:49 <flo-retina> ah, I have a guess at what's going on!
20:52:55 <flo-retina> the "New Conversation" item is disabled
20:53:07 <flo-retina> I guess that's because I never dispatch the notification that's used to update the menus
20:53:30 <nhnt11> :)
20:53:52 * nhnt11 hardcodes the menu option to be on when he's debugging ;)
20:53:56 <flo-retina> nhnt11: will the + button be broken if the menu is disabled?
20:54:10 <nhnt11> Yeah
20:54:14 <flo-retina> :(
20:54:14 <nhnt11> The command is disabled so
20:54:16 <nhnt11> That's bad
20:54:20 <nhnt11> I didn't realize till now
20:54:21 <flo-retina> how difficult would it be to fix?
20:54:40 <flo-retina> yeah, it's bad to have a button that doesn't do anything (not even an error message) when clicked
20:54:54 <nhnt11> Do we want it to work when the menu item is disabled, or just be disabled?
20:55:21 <flo-retina> I'm as tempted by both answers :-P
20:55:29 <flo-retina> disabled would be consistent
20:55:42 * nhnt11 doesn't really get why newtab isn't wanted when no accounts are connected
20:55:52 <flo-retina> but I would like it to work for when we'll have the log viewer and conversation view merged
20:55:56 <nhnt11> I mean it makes sense, but I'd like to be able to open it anyway :P
20:56:32 <flo-retina> nhnt11: what would you like it to do?
20:56:44 <nhnt11> I want it to open a new tab
20:56:53 <nhnt11> And I want the menu item to always be enabled too :P
20:58:20 <qheaden> clokep: So what should be finished and when? Any deadlines you have other than the midterm eval?
20:59:06 <-- flo-retina has quit (Ping timeout)
21:00:21 --> flo-retina has joined #instantbird
21:00:21 * ChanServ sets mode +qo flo-retina flo-retina 
21:01:36 <nhnt11> flo-retina: So I've added a fake account and I don't see any of those fake contacts :(
21:02:08 <-- flo-retina has quit (Ping timeout)
21:02:30 <nhnt11> Er, wait, I'm doing something wrong
21:03:17 <clokep> aleth: If I wanted a module in an extension I'd register it as a chrome path, right?
21:04:29 <aleth> clokep: That should work, unless it's restartless, then you need tricks
21:04:42 <clokep> I don't care about restartless. :P
21:04:46 <clokep> You kids and your new fangled stuff!
21:05:05 <nhnt11> aleth, clokep: Do you know how to make the Fake contacts appear?
21:05:08 * nhnt11 feels noobish
21:05:27 <clokep> nhnt11: You have to call a method or something in the error console, I think.
21:05:33 --> flo-retina has joined #instantbird
21:05:34 * ChanServ sets mode +qo flo-retina flo-retina 
21:05:49 <nhnt11> Oh
21:06:00 <flo-retina> clokep: how do you feel about (getTabBrowser || getBrowser)() ?
21:06:08 <nhnt11> flo-retina: That won't work
21:06:11 <nhnt11> Oh wait
21:06:15 <nhnt11> Sorry
21:07:07 * nhnt11 still thinks doc.getElById("conversations") is good
21:07:15 <clokep> flo-retina: I'd feel OK about that.
21:07:25 <nhnt11> flo-retina: log.bezut.info/instantbird/130719#m753
21:08:19 <clokep> flo-retina: I shold have put an r=aleth, he gave me permission to do it that way!
21:09:10 <flo-retina> nhnt11: why aren't you following http://log.bezut.info/instantbird/130719#m717 ?
21:09:19 <nhnt11> I did that
21:09:31 <flo-retina> have you applied the patch in the bug?
21:09:39 <nhnt11> I thought the fake contacts were supposed to show up 
21:09:39 <nhnt11> yes
21:10:17 <flo-retina> nhnt11: I'm still puzzled by what "I've added a fake account" could mean btw
21:10:31 <nhnt11> Er, sorry
21:10:40 <nhnt11> I meant I created a js test account
21:10:43 <nhnt11> When nothing happened
21:10:50 <nhnt11> I thought that might be the fake account or something
21:11:22 <flo-retina> so why didn't you just follow my instructions?
21:11:33 <nhnt11> I did!
21:11:42 <flo-retina> (instead of making up something random that doesn't even contain the word "fake" in it :-P)
21:11:53 <nhnt11> I did that when your instructions didn't do anything
21:12:19 <flo-retina> show me the command line you used
21:13:31 <flo-retina> oh wait
21:13:40 <nhnt11> FAKE=1 ./instantbird-bin -P Fake
21:13:47 <nhnt11> Also tried export FAKE=1 before anything
21:13:52 <flo-retina> nhnt11: try removing this ifdef: http://lxr.instantbird.org/instantbird/source/instantbird/content/jar.mn#104
21:13:59 <nhnt11> and $open InstantbirdDebug.app --args -P Fake
21:14:01 <flo-retina> it's broken for me for some reason, so I just removed it locally
21:14:08 <nhnt11> oh
21:14:24 <flo-retina> (would be nice if someone had any clue of why it's broken btw)
21:15:31 <flo-retina> Mook_as: it's unfortunate that we haven't sync'ed chat/ in a long while :(
21:17:32 <aleth> What's the deadline for the next TB release?
21:18:26 <nhnt11> Fake still isn't working, I'm getting a ReferenceError: nbaccounts is not defined now
21:19:19 <qheaden> Okay, I have to log off now. Bye everyone. :)
21:19:34 <clokep> BYe.'
21:19:57 <nhnt11> Aha
21:20:00 <nhnt11> It worked :D
21:20:14 * qheaden is now known as qheaden_away
21:22:35 <flo-retina> aleth: we missed it already
21:22:43 <nhnt11> flo-retina: Is this a good screenshot? http://puu.sh/3GSQy.png
21:22:54 <nhnt11> I just think it's missing buddy icons..
21:23:04 <flo-retina> what was the problem causing the reference error?
21:23:26 <nhnt11> I had other accounts. I deleted the profile and made a new one, it worked.
21:23:32 <flo-retina> nhnt11: the "Florian" contact likely has an icon
21:23:45 <nhnt11> flo-retina: It does but there's only one contact starting from "F" ;)
21:23:50 <nhnt11> I could add more, of course..
21:24:13 <aleth> flo-retina: Oh well... (I just remembered you looked at the strings in time, and assumed we would do the rest via uplift to Aurora or something)
21:24:15 <flo-retina> nhnt11: well, Fake is designed so that you can easily tweak it to make the UI display whatever ou want for screenshots ;)
21:24:38 <flo-retina> aleth: I did look at the string in time. But then didn't have time to actually create the patch.
21:24:44 <flo-retina> *strings
21:25:55 * flo-retina wonders if the Fake code could be reused to start some UI unit tests.
21:27:32 * nhnt11 is going to include surnames in his screenshot
21:27:36 <flo-retina> aleth: what does "These variables" refer to in https://bugzilla.instantbird.org/attachment.cgi?id=2612 ?
21:29:02 <aleth> flo-retina: I reused the same comment that is already used in two places in the file for consistency, eg http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#323 . It refers to the fields following it.
21:31:06 <flo-retina> aleth: my point is: there's only *one* field following it
21:31:35 <-- mconley has quit (Input/output error)
21:32:23 <aleth> flo-retina: Yes, I intentionally didn't adjust that when copying. I can change it if you like
21:33:44 <flo-retina> I find it confusing
21:35:30 <flo-retina> aleth: I think I would just use "This is reset in onStateChange."
21:35:45 <aleth> OK
21:36:43 <flo-retina> I can do it on checkin if you prefer
21:37:01 <aleth> That would be neat, if it's otherwise good.
21:37:25 <flo-retina> aleth: can I checkin bug 2059 bug 2054 and bug 2061 without testing locally first?
21:37:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2059 nor, --, ---, aleth, ASSI, Failure to remove selection listener after switching logs in log viewer
21:37:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Today/yesterday entries in log viewer don't work for text logs
21:37:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2061 nor, --, ---, aleth, ASSI, Section scroll doesn't find all sessions
21:37:40 <flo-retina> I don't see anything wrong there
21:37:43 <aleth> Yes, they've all been tested.
21:38:02 <aleth> Took a while to debug, but the fixes are not tricky.
21:42:14 <nhnt11> flo-retina: http://puu.sh/3GTGB.png
21:43:32 <nhnt11> (I'll retake that with HIDPI off if you approve)
21:43:37 --> Hronom has joined #instantbird
21:45:37 <flo-retina> aleth: yeah, for once I have reviews in my queue that don't look difficult ;)
21:45:53 --> FireFly_TB has joined #instantbird
21:45:54 <flo-retina> nhnt11: how come you aren't listed? :-P
21:46:25 <nhnt11> Heh. My name doesn't start with "F"
21:46:41 <nhnt11> Otherwise I'd have to add my user picture and everything..
21:46:54 <flo-retina> that's the point :-P
21:47:08 <flo-retina> are you making a screenshot without filter too? :-P
21:47:16 <nhnt11> No, is that required?
21:47:34 <flo-retina> I don't know. Just see what Mic wants :)
21:47:39 <nhnt11> ok
21:48:47 <clokep> Bah, I just got into a login loop and locked my Yahoo account.
21:48:51 * clokep shakes his fist at qheaden_away!
21:49:00 * flo-retina wonders how nhnt11 likes Fake so far
21:49:15 <nhnt11> Mic: Here's a non-retina version of that screenshot above, let me know if you need anything else: http://puu.sh/3GTNW.png
21:49:16 <-- Hronom has quit (No route to host)
21:49:22 <nhnt11> flo-retina: It's cool! :)
21:50:19 <clokep> nhnt11: He'll want one that he can put into a page, that one has the funky shadow and background.
21:50:27 <flo-retina> nhnt11: whenever I dig it out, I always find it fun (when it finally works) to have plenty of Fake stuff displayed in a UI that I otherwise actually use.
21:50:50 <flo-retina> clokep: why would that prevent putting it in a page?
21:50:54 <-- rosonline has quit (Client exited)
21:51:01 <nhnt11> clokep: There's no background
21:51:01 <clokep> flo-retina: It'll look bad.
21:51:06 <nhnt11> There's a shadow, the bg is transparent
21:51:19 * flo-retina hates the way Firefox shows a white background for transparent images :(
21:52:05 <clokep> Oh.
21:52:06 <clokep> That's stupid.
21:52:48 * clokep doesn't have an old Instantbird around to test w/. :(
21:55:07 --> Hronom has joined #instantbird
21:55:41 <instantbot> florian@instantbird.org granted review for attachment 2607 on bug 2059.
21:55:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2059 nor, --, ---, aleth, ASSI, Failure to remove selection listener after switching logs in log viewer
21:56:16 <clokep> flo-retina: (getTabBrowser || getBrowser)(); doesn't work. :(
21:58:05 <flo-retina> why?
21:58:38 <-- aleth has quit (Quit: Ciao)
21:59:18 <instantbot> florian@instantbird.org granted review for attachment 2611 on bug 2054.
21:59:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Today/yesterday entries in log viewer don't work for text logs
21:59:49 <nhnt11> clokep: It works for me from the error console
22:00:20 <instantbot> florian@instantbird.org granted review for attachment 2612 on bug 2061.
22:00:20 <clokep> nhnt11: It doesn't work in 1.4.
22:00:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2061 nor, --, ---, aleth, ASSI, Section scroll doesn't find all sessions
22:00:29 <nhnt11> This is what I tested with (not exact but similar) http://pastebin.instantbird.com/251427
22:00:42 <flo-retina> clokep: ah, sorry, that wasn't correct
22:01:04 <flo-retina> clokep: what about (window.getTabBrowser || window.getBrowser)(); ?
22:01:21 <nhnt11> flo-retina: ++
22:01:30 <clokep> Ah, that'll probably work.
22:02:01 <clokep> Win! :)
22:02:05 * clokep goes to commit that.
22:03:17 <-- Hronom has quit (Client exited)
22:03:47 <clokep> Thanks flo-retina.
22:03:51 <flo-retina> np
22:03:57 <flo-retina> thanks for updating all this stuff
22:04:21 <clokep> Does that mean I can delete that fake patch from my mq? :p
22:04:34 <flo-retina> the fake patch that was already in the bug?
22:04:43 <nhnt11> Oh yeah. flo-retina, what do you think about moving the Possible* interfaces (or their renamed counterparts) to chat/?
22:04:43 <clokep> Yes.
22:04:45 <flo-retina> using Services.* there may still be a good idea
22:04:58 <flo-retina> but the patch attached to the bug comments out pleny of stuff
22:05:00 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b258142aa373 - aleth - Bug 2059 - Failure to remove selection listener after switching logs in log viewer, r=fqueze.
22:05:01 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/422af6e964ea - aleth - Bug 2054 - Today/yesterday entries in log viewer don't work for text logs, r=fqueze.
22:05:02 * clokep deletes his SkypeKit patches.
22:05:03 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/43c510f7260b - aleth - Bug 2061 - Section scroll doesn't find all sessions, r=fqueze.
22:05:04 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9c5746169cdc - Florian Qu├Ęze - Bug 1808 - Update fake, r=clokep.
22:05:13 <flo-retina> clokep: is it really that dead? :-o
22:05:25 <flo-retina> nhnt11: would need to see the code to have an opinion
22:05:27 <clokep> flo-retina: Read the log.
22:05:34 <flo-retina> I really don't see where Tb could use it
22:05:54 <flo-retina> clokep: I did, and noticed you saying it would stop in < 12 Months, but I missed the link
22:06:06 <clokep> flo-retina: You can't see it w/o logging in anyway, that's why I didn't post it.
22:06:15 <clokep> flo-retina: The issue is that things that a prpl has to return must be in chat, no?
22:06:36 <nhnt11> flo-retina: clokep was suggesting that instead of the stats service creating PossibleConversations from contacts/chats/ui convs returned from other sources, the other sources directly return PossibleConversations
22:06:51 <instantbot> clokep@gmail.com set the Resolution field on bug 2061 to FIXED.
22:06:53 <nhnt11> This would require me to put the PossibleConversation interface in chat/, since the "other sources" are in chat
22:06:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2061 nor, --, 1.5, aleth, RESO FIXED, Section scroll doesn't find all sessions
22:07:08 <nhnt11> I can't show you code unless I do that, and I'm asking /whether/ to do this so... :P
22:07:15 <flo-retina> clokep, nhnt11: aren't you mixing stuff from "support LIST and return the data in a useful way" and "return data ready to be consumed by the awesometab" ?
22:07:32 <instantbot> clokep@gmail.com set the Resolution field on bug 2054 to FIXED.
22:07:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, 1.5, aleth, RESO FIXED, Today/yesterday entries in log viewer don't work for text logs
22:07:53 <instantbot> clokep@gmail.com set the Resolution field on bug 2059 to FIXED.
22:07:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2059 nor, --, 1.5, aleth, RESO FIXED, Failure to remove selection listener after switching logs in log viewer
22:08:16 <nhnt11> flo-retina, clokep: I personally don't fully agree with clokep's suggestion to directly return possible conversations. Imo PossibleConv should be a stats-service thing which other components needn't be aware of.
22:08:20 <clokep> flo-retina: nhnt11 description of what I suggested isn't really accurate.
22:08:31 <nhnt11> yeah I think I keep misunderstanding clokep
22:08:31 <flo-retina> clokep: so is there a way to get the exact skypekit announcement? (pastebin or email maybe?)
22:08:56 <clokep> flo-retina: My point is that a prpl can't return a "potential" conversation right now, or at least not all the info that nhnt11 wants for his PossibleConversation.
22:08:59 <nhnt11> (Sorry clokep, I'm going to reread what you said yesterday now)
22:09:16 <flo-retina> nhnt11, clokep: you too typically approach the problem with very different angles. clokep worked for years on the prpl side, and you work mostly on the UI side.
22:09:18 <clokep> And that the interfaces around PossibleConversation are...silly, they're all super unique instead of merging the data into an actual interface.
22:09:39 <nhnt11> clokep: Why not? All I need is a chat name, a topic and an account, all three providable from a prpl
22:09:49 <nhnt11> and there is only one PossibleConversation interface as of now
22:09:50 <clokep> nhnt11: How? :)
22:09:53 <nhnt11> There are 3 implementations.
22:10:00 <clokep> OK, I haven't seen this updated code. Where is it?
22:10:07 <flo-retina> clokep: can you be a bit more specific than "not all the info"?
22:10:23 <nhnt11> clokep: They process LIST data (for e.g.) and return the channel name and topic. The account is obviously available
22:10:58 <clokep> nhnt11: flo-retina: The only potential interface I could see the prpl returning right now is an array of prplIChatRoomFields (I think that's what it's called), but that doesn't include a name or description, just the way to join a chat.
22:11:20 <clokep> nhnt11: You're totally missing the point, HOW do they return the "channel name and topic".
22:11:22 <nhnt11> clokep: I will push it soon, could you wait? I just need to connect it to the UI. Unfortunately it's not really something that should've taken this long, but I'm working longer hours tonight to compensate.
22:11:28 <clokep> Yes, that's fine.
22:11:29 <nhnt11> clokep: Strings?
22:11:31 * clokep is in no rush.
22:11:49 <flo-retina> clokep: it's pretty clear that we need to add an interface for the LIST results. The part that's not clear to me is that this interface is the same as the ibIPossibleConversation we were discussing before.
22:12:08 <clokep> flo-retina: That's reasonable, I think they'd be similar, but maybe not. :)
22:12:21 <nhnt11> flo-retina: I think I mentioned that yesterday. (a new interface for chats that will reside in chat/)
22:12:27 <flo-retina> clokep: really, I don't know until I see the code / interface proposals, so I don't want to say now if they are the same or not.
22:12:41 * clokep is just oging off what he previously saw.
22:13:26 <flo-retina> clokep: would that really want to inherit from imIStatusInfo? :-S
22:14:08 <nhnt11> PossibleConversations hold much more info than what a prpl would need to return to fully represent a chat room. Basically all the stuff in imIStatusInfo
22:14:12 <nhnt11> Er, what flo said ^
22:14:30 <clokep> flo-retina: I don't think so.
22:14:49 <clokep> I don't really get why their inherit from imIStatusInfo, that makes NO sense for a MUC.
22:15:00 <clokep> That's why my drawing suggested a mapping of fields.
22:15:16 <nhnt11> clokep: imIStatusInfo has some useful features that I can avoid duplicating, like createConversation for example.
22:16:15 <clokep> flo-retina: http://pastebin.instantbird.com/251473
22:16:22 <clokep> SkypeKit killing.
22:16:52 * clokep isn't sure if he should close bug 1808.
22:16:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1808 min, --, ---, florian, NEW, Update fake
22:17:03 <clokep> (And source btw: http://devforum.skype.com/t5/SkypeKit-API/Important-Information-about-SkypeKit/td-p/25850)
22:18:50 <clokep> (Also I'm leaving in ~10 minutes to get dinner.)
22:18:54 <flo-retina> clokep: thanks!
22:19:44 <flo-retina> my reading of this is "given that we are moving from a P2P model to a server based model, distributing a SDK bundling our P2P technology doesn't make sense any more so we are dropping it".
22:20:01 <flo-retina> any idea of what their "URIs APIs" is?
22:20:22 <nhnt11> flo-retina: Mic suggests to add the "prpl-init" observer in the constructor of the Service. Is this possible? I thought services were supposed to start doing their thing in profile-after-change (for this category at least)
22:20:28 <flo-retina> clokep: close it if you have no intention of attaching another patch there.
22:20:34 <flo-retina> otherwise, you can keep it open
22:20:47 <clokep> flo-retina: It's the same garbage all IM clients have, i.e. a skype: URI that opens Skype to a particular user, etc.
22:21:59 <flo-retina> nhnt11: hmm, that may be ok.
22:22:00 <flo-retina> nhnt11: doesn't guarantee that your service will always get started before prpl-init is dispatched though
22:22:06 <clokep> flo-retina: OK. I'll take a look at that later.
22:22:17 <flo-retina> clokep: why do they call it "API" then? :-S
22:23:02 <flo-retina> clokep: if you move your SkypeKit patches out of your queue, it would still be a good idea to keep a copy somewhere
22:23:15 <flo-retina> (but maybe your queue is versionned anyway?)
22:23:18 * flo-retina doesn't remember
22:23:20 <nhnt11> flo-retina: Right, he says to check for Services.core.initialized first.
22:23:33 <nhnt11> Basically I'm confused at why this change is needed/wanted.
22:23:36 <clokep> flo-retina: My queue is versioned on bitbucket. :)
22:23:37 <flo-retina> "first" = before what?
22:23:46 <nhnt11> Before adding prpl-init observer
22:23:51 <flo-retina> clokep: :)
22:24:08 <flo-retina> is this a comment in the bug or in bitbucket?
22:24:13 <nhnt11> Hmm, to make it more obvious that it's happening when the service is initialized. never mind.
22:24:21 <nhnt11> flo-retina: In the bug
22:29:17 <nhnt11> flo-retina: Also, you're sure you want to get UI convs only while filtering, and not maintain them in the list?
22:29:54 * clokep has to go.
22:29:55 <clokep> Tata!
22:30:18 <nhnt11> Bye clokep
22:30:53 <flo-retina> what's the benefit of keeping them in "the list"?
22:31:23 <nhnt11> It saves having to replace contacts with their ui convs every time we filter
22:31:27 <flo-retina> if you want to land the current patch putting them in a list just to move forward and trying using the switch to conv UI, that's OK with me
22:31:27 <nhnt11> But imo, both are cheap
22:31:32 <flo-retina> but I think you'll eventually not want that.
22:32:12 <nhnt11> Eventually - I agree! Likely the ranking stuff will change the way the list is maintained anyway.
22:32:28 <nhnt11> For now, I think it's fine the way it is.
22:32:35 <flo-retina> I would really like you to start focusing on designing the ranking system asap
22:33:03 <nhnt11> I seem to be lagging :(
22:33:10 <flo-retina> as I think that will be a key part of your work for the second half of the summer
22:33:30 <nhnt11> Agreed.
22:33:31 <flo-retina> well, if you've been sick this week, it's possible there's a good reason...
22:33:59 <nhnt11> I'm glad I got the tabbrowser stuff done in the bonding period :)
22:34:05 <flo-retina> but yeah, please sort out the service stuff and the MUC/existing conv display asap
22:34:18 <flo-retina> :)
22:34:22 <nhnt11> Okay!
22:34:47 <flo-retina> asap doesn't mean "spend all night on it instead of sleeping" though ;).
22:34:56 <flo-retina> even more so if you are still recovering!
22:35:27 <nhnt11> No I'm fine now. Also I find I tend to get stuff done in bursts.
22:37:54 <instant-buildbot> build #420 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/420
22:38:40 * flo-retina is a bit disappointed to not have seen more follow-ups get fixed ;)
22:39:40 <nhnt11> The + button theming, huh? :(
22:39:59 <flo-retina> that, and switch to an existing conv
22:40:58 <flo-retina> nhnt11: when I press Command+T, the item that's under my mouse pointer ends up selected (even though I haven't touched the mouse at all). Is this the "expected" behavior?
22:41:23 <nhnt11> I would expect that.
22:41:47 <flo-retina> why?
22:41:57 <nhnt11> it makes it obvious that the hovered item gets selected, for one thing
22:42:07 <flo-retina> if I'm using only the keyboard to interact, I typically don't know where my mouse is
22:42:36 <nhnt11> flo-retina: Hmm. This problem may actually go away when I fix the bug Mic found
22:42:46 <nhnt11> Where scrolling down with the arrow keys makes selection jump
22:43:20 <nhnt11> (My idea is to select the hovered item on mouse move instead of mouseover)
22:43:22 <flo-retina> seems similar indeed!
22:43:30 <flo-retina> ok :)
22:43:51 * nhnt11 wants to churn out some patches soon
22:45:03 <flo-retina> bah, these new tooltips are really not ready :(
22:54:54 <flo-retina> Good night
22:55:41 <nhnt11> Night
23:32:09 <-- clokep has quit (Ping timeout)
23:42:39 --> atuljangra has joined #instantbird
23:43:00 <atuljangra> Good Morning :D
23:56:56 <instant-buildbot> build #438 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/438