#instantbird log on 07 18 2013

All times are UTC.

00:39:02 <-- wnayes has quit (Ping timeout)
00:42:28 --> wnayes has joined #instantbird
00:49:49 <clokep> Mook_as: Did you say you didn't convert anything in Komodo to moz.build?
00:50:42 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:50:56 --> clokep has joined #instantbird
00:50:56 * ChanServ sets mode +o clokep 
00:51:07 <-- clokep has quit (Connection reset by peer)
00:51:18 --> clokep has joined #instantbird
00:51:18 * ChanServ sets mode +o clokep 
00:51:28 <Mook_as> clokep: correct; but we're also on 24
00:51:45 <clokep> Mook_as: That means I should be able to update to 22 w/o doing it. :P
00:51:46 <Mook_as> also, komodo pretty much only builds the main executable with the mozilla build system
00:51:57 <Mook_as> everything else is... well, a horror.
00:52:10 <clokep> black? :P
00:52:14 <Mook_as> cons
00:54:04 <instantbot> clokep@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 2592 on bug 1997.
00:54:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1997 nor, --, ---, clokep, ASSI, Update to Mozilla 22
00:54:23 <clokep> Any chance you want to rs my patches? :P
00:54:27 * clokep wonders if flo would accept that.
00:56:03 * clokep would really really like a few things checked in to clean out his mq. :(
01:05:04 * clokep has like 40 things in his patch queue.
01:07:11 <-- instant-buildbot has quit (Connection reset by peer)
01:07:16 <-- Mook_as has quit (Quit: Mook_as)
01:07:25 --> instant-buildbot has joined #instantbird
01:07:25 * ChanServ sets mode +v instant-buildbot 
01:10:45 <-- rosonline has quit (Ping timeout)
01:41:17 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
01:57:10 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
01:57:18 <-- wnayes has quit (Quit: wnayes)
02:07:53 <-- skeledrew has quit (Ping timeout)
02:15:10 <-- EionRobb has quit (Ping timeout)
02:15:38 --> EionRobb has joined #instantbird
02:26:28 --> Mook has joined #instantbird
02:36:38 --> EionRobb1 has joined #instantbird
02:37:03 <-- EionRobb has quit (Ping timeout)
03:05:10 <instant-buildbot> build #913 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/913
03:08:28 <Mook> what the heck... the copy stuff works okay here. thunderbird, nightly, 64 bit linux...
03:08:31 --> skeledrew has joined #instantbird
05:12:25 <-- EionRobb1 has quit (Ping timeout)
05:16:35 --> jb has joined #instantbird
05:20:59 <-- Suiseiseki has quit (Ping timeout)
05:24:07 --> dew has joined #instantbird
05:31:20 <-- jb has quit (Quit: jb)
05:42:06 --> jb has joined #instantbird
05:52:02 --> jb1 has joined #instantbird
05:52:11 <-- jb has quit (Ping timeout)
05:55:14 <instant-buildbot> build #1009 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1009
05:59:39 --> EionRobb has joined #instantbird
06:11:01 --> Suiseiseki has joined #instantbird
06:16:59 <-- skeledrew has quit (Ping timeout)
06:20:08 --> skeledrew has joined #instantbird
06:23:14 --> jb has joined #instantbird
06:23:22 <-- jb1 has quit (Connection reset by peer)
06:40:15 <-- jb has quit (Ping timeout)
07:01:15 <-- Mook has quit (Ping timeout)
07:48:03 --> jb has joined #instantbird
07:52:10 --> flo-retina has joined #instantbird
07:52:11 * ChanServ sets mode +qo flo-retina flo-retina 
08:04:15 <-- jb has quit (Connection reset by peer)
08:17:19 <-- micahg has quit (Ping timeout)
08:18:09 --> micahg has joined #instantbird
08:19:31 --> jb has joined #instantbird
08:22:14 <-- micahg has quit (Ping timeout)
08:23:09 --> micahg has joined #instantbird
08:39:59 <instant-buildbot> build #913 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/913
08:54:17 --> gerard-majax_ has joined #instantbird
08:54:32 <-- gerard-majax__ has quit (Quit: Ex-Chat)
09:02:25 --> nhnt11 has joined #instantbird
09:11:10 <flo-retina> nhnt11: hello. Could you give us a status update? The only thing I saw yesterday was you saying that my estimation of the time to get correct theming (ie. 2hours) was right. I didn't see the patch coming though :-S.
09:11:53 <nhnt11> flo-retina: I have the icon looking like how it is in Firefox, with retina support. I didn't submit a patch because I don't have windows/linux working.
09:12:08 <flo-retina> what do you mean by "working"?
09:12:16 <flo-retina> you don't need a build environment there to do icon stuff
09:12:41 <nhnt11> I plan to do that today. I also worked on the stats service but it's messy right now. I want to see if I can get a new patch ready for that today.
09:12:57 <nhnt11> flo-retina: Er, the windows icon has different problems than the Mac one from what I saw
09:13:06 <flo-retina> what does that mean?
09:13:14 <flo-retina> in both cases you need to copy/paste what Firefox does
09:13:26 <nhnt11> Ah so you /did/ want me to port Firefox's code
09:13:28 <flo-retina> didn't you have access to a windows VM to test on?
09:13:38 <nhnt11> Yes but I don't have a windows build.
09:13:45 <flo-retina> there are nightlies ;)
09:13:53 <nhnt11> Oh yeah, domi :S
09:13:54 <flo-retina> http://nightly.instantbird.im/
09:14:03 <flo-retina> then you can unzip the omni.ja file
09:14:10 <nhnt11> I have an Instantbird nightly on Windows :)
09:14:10 <flo-retina> and edit in place to test your changes
09:14:12 <nhnt11> Oh ok
09:14:32 <flo-retina> don't forget -purgecaches on the command line to ensure your changes are applied
09:14:38 <nhnt11> flo-retina: It was 2.30am when I finished the mac icon anyway so.. ;)
09:14:44 <nhnt11> ok
09:14:47 <nhnt11> I'll do that today.
09:14:55 <flo-retina> so how long did it take you to get that mac icon working?
09:15:04 <nhnt11> About an hour I guess.
09:15:14 <flo-retina> ok, that matches my estimate then :)
09:15:19 <nhnt11> :)
09:15:23 <flo-retina> so what happened during the rest of the day?
09:15:49 <-- micahg has quit (Ping timeout)
09:16:01 <nhnt11> Er, I just said. "I also worked on the stats service but it's messy right now. I want to see if i can get a new patch ready for that today"
09:16:18 <flo-retina> FYI, I'll be in vacations starting the evening of Wednesday 24th, so if you want to get stuff pushed with my review, it needs to happen before that ;)
09:16:27 <nhnt11> Ah. I'll keep that in mind.
09:16:31 --> micahg has joined #instantbird
09:16:35 <flo-retina> so why is it messy? anything we can help you with?
09:16:47 <nhnt11> no no, just that I was moving stuff around and it's incomplete
09:16:51 <nhnt11> I think your comments on the bug are pretty clear
09:17:05 <flo-retina> nhnt11: I'm not saying everything should land before that date. But if you need stuff to land soon to get unblocked for the rest of your project, try prioritizing them ;)
09:17:17 <flo-retina> they didn't seem clear to aleth ;)
09:17:18 <-- jb has quit (Quit: jb)
09:17:23 <nhnt11> I'm trying to do what aleth said and have different types of PossibleConversations
09:17:35 <flo-retina> that seemed a good suggestion :)
09:19:03 <nhnt11> Btw, I've been running a fever. It shouldn't affect my work (I'm taking meds) but I thought I'd mention it.
09:19:26 <flo-retina> ok, I hope you feel better soon.
09:19:47 <flo-retina> have you finally sorted out your passport stuff?
09:20:06 <-- nhnt11 has quit (Input/output error)
09:20:09 --> nhnt11 has joined #instantbird
09:20:47 <nhnt11> No :( They took my fingerprints and photograph and everything but my application is on hold because they wanted a bank statement for 1 year and mine had only 6 months
09:21:10 <flo-retina> sorry :(
09:21:23 <nhnt11> I'll need to go again, not sure when. I'll be going in the morning, so it won't clash with my working hours
09:21:24 * flo-retina doesn't understand why they want (not going to say "need") so much info :-S
09:21:34 * nhnt11 doesn't understand either :(
09:21:49 <-- micahg has quit (Ping timeout)
09:22:30 --> jb has joined #instantbird
09:22:31 --> micahg has joined #instantbird
09:22:42 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:22:46 --> nhnt11 has joined #instantbird
09:24:11 * flo-retina wonders if nhnt11 would want to be the reviewer if I started doing a patch to add retina icons for stuff (mostly thinking about tabs now).
09:24:31 * nhnt11 wouldn't mind.
09:24:33 <flo-retina> (ie. stuff we can just copy from Firefox :-D)
09:25:48 <-- gerard-majax_ has quit (Ping timeout)
09:26:18 <-- flo-retina has quit (Ping timeout)
09:26:49 --> flo-retina has joined #instantbird
09:26:49 * ChanServ sets mode +qo flo-retina flo-retina 
09:27:09 <-- nhnt11 has quit (Ping timeout)
09:27:15 * flo-retina 's Instantbird crashed :(
09:27:28 <flo-retina> that stupid Mac crash when opening the pref window when the blist window has been closed.
09:27:52 --> nhnt11 has joined #instantbird
09:30:02 --> aleth has joined #instantbird
09:30:02 * ChanServ sets mode +h aleth 
09:31:32 <-- nhnt11 has quit (Ping timeout)
09:31:47 --> nhnt11 has joined #instantbird
09:33:19 <-- nhnt11 has quit (Input/output error)
09:33:23 --> nhnt11 has joined #instantbird
09:35:03 <-- Optimizer has quit (Ping timeout)
09:36:25 --> Optimizer has joined #instantbird
09:36:46 <-- nhnt11 has quit (Ping timeout)
09:37:08 --> nhnt11 has joined #instantbird
09:37:52 <aleth> nhnt11: "Is the newtab button theming messed up on linux too when you have a lot of tabs open (overflow mode)?" I think so (if by that you mean "does it still look like a tab")
09:37:54 <-- micahg has quit (Ping timeout)
09:38:09 <nhnt11> It looks like a tab? Interesting
09:38:36 --> micahg has joined #instantbird
09:38:59 <-- Optimizer has quit (Ping timeout)
09:39:48 <nhnt11> btw, flo-retina, this is what I mean by "I have it fixed": http://puu.sh/3FLSu.png
09:39:53 <nhnt11> I hope that's what you expected?
09:40:14 <aleth> nhnt11: https://i.minus.com/jbu8MkgQ3WF3TG.png
09:40:56 <flo-retina> nhnt11: for the other overflow case, yes :)
09:41:07 <-- nhnt11 has quit (Input/output error)
09:41:10 --> nhnt11 has joined #instantbird
09:41:20 <flo-retina> having a retina icon there next to 2 non-retina ones makes me want to fix the others even more ;)
09:41:26 <nhnt11> :P
09:42:33 <nhnt11> flo-retina: "Other overflow case"?
09:42:40 <flo-retina> s/other//
09:42:48 <nhnt11> aleth: That looks gross :(
09:42:52 <flo-retina> the blue highlight on that search field still sucks
09:42:59 <aleth> Australis probably comes with retina icons
09:43:00 <aleth> Now nhnt11 owns the tabbrowser, maybe he will do the upgrade to Australis when it finally lands ;)
09:43:12 <aleth> nhnt11: Yeah, it's probably completely missing some CSS
09:43:16 <nhnt11> Mic was saying that too yesterday ;)
09:43:29 <flo-retina> aleth: that's no now. Current ETA is Fx26 at beast, 27 more likely. We are still on gecko 21 :-P
09:43:32 <nhnt11> flo-retina: I don't see anything wrong with the blue highlight :(
09:43:45 <flo-retina> nhnt11: alright, I'm not asking you to fix it
09:44:07 <flo-retina> aleth: could you also provide a screenshot of the same thing on Firefox to compare?
09:45:02 <nhnt11> aleth: Do all textboxes on your theme have a gray background?
09:45:10 <nhnt11> Or is it just the awesometab search bar
09:45:43 <aleth> nhnt11: They all do, but it's still an IB bug (or maybe due to the lack of 64bit builds)
09:45:57 <aleth> If you can fix it please do :)
09:46:04 <-- nhnt11 has quit (Input/output error)
09:46:07 --> nhnt11 has joined #instantbird
09:46:07 <flo-retina> aleth: so someone should check if it works correctly on a "real" Linux build before nhnt11 spends more time on it I guess
09:46:13 <aleth> (I mean "they all do" in IB)
09:46:38 <flo-retina> by "real build" I mean, 32bit nightly on a 32bit linux, or 64bit build on a 64bit linux.
09:47:02 * flo-retina can look at it on Saturday evening if someone remembers to ping him about it at the correct time
09:47:45 <aleth> nhnt11: As you can see, non-ugly on FX https://i.minus.com/jbrMqpxrA9Lxbd.png
09:48:34 <aleth> flo-retina: I think nhnt11 said he had ubuntu available
09:48:45 <-- nhnt11 has quit (Ping timeout)
09:49:08 <flo-retina> aleth: yeah. but I don't want him to spend plenty of time on theming details. I said he should look at it when he's stuck on "real" work because he's waiting for feedback.
09:49:09 --> nhnt11 has joined #instantbird
09:49:22 <aleth> flo-retina: Oh, definitely
09:49:26 <aleth> flo-retina: There's a lot of recent little improvements we don't have :( Tab opening animations for example
09:49:33 <flo-retina> aleth: s/non-ugly/less ugly/ ;)
09:49:47 <flo-retina> aleth: we will have that with Australis
09:50:02 <aleth> flo-retina: yeah, s/non-ugly/as non-ugly as it gets for Linux :P
09:50:40 <aleth> i.e. at least it doesn't look broken ;)
09:50:58 <-- nhnt11 has quit (Ping timeout)
09:51:52 --> nhnt11 has joined #instantbird
09:55:18 <-- nhnt11 has quit (Ping timeout)
09:55:39 --> nhnt11 has joined #instantbird
09:57:26 <-- nhnt11 has quit (Ping timeout)
09:57:45 --> nhnt11 has joined #instantbird
09:58:40 --> gerard-majax_ has joined #instantbird
10:00:17 <-- nhnt11 has quit (Ping timeout)
10:00:44 --> nhnt11 has joined #instantbird
10:02:47 <-- EionRobb has quit (Quit: Leaving.)
10:03:28 <-- nhnt11 has quit (Ping timeout)
10:03:51 --> nhnt11 has joined #instantbird
10:04:51 --> clokep has joined #instantbird
10:04:51 * ChanServ sets mode +o clokep 
10:06:35 <-- nhnt11 has quit (Ping timeout)
10:07:00 --> nhnt11 has joined #instantbird
10:09:37 <-- nhnt11 has quit (Ping timeout)
10:09:59 --> nhnt11 has joined #instantbird
10:11:48 <-- nhnt11 has quit (Ping timeout)
10:12:18 --> nhnt11 has joined #instantbird
10:14:03 <-- nhnt11 has quit (Ping timeout)
10:14:29 --> nhnt11 has joined #instantbird
10:17:10 <-- nhnt11 has quit (Ping timeout)
10:17:29 --> nhnt11 has joined #instantbird
10:20:01 <-- nhnt11 has quit (Ping timeout)
10:20:24 --> nhnt11 has joined #instantbird
10:22:58 <-- nhnt11 has quit (Ping timeout)
10:23:22 --> nhnt11 has joined #instantbird
10:26:53 <-- nhnt11 has quit (Ping timeout)
10:27:22 --> nhnt11 has joined #instantbird
10:30:27 --> panther7 has joined #instantbird
10:30:52 <-- nhnt11 has quit (Ping timeout)
10:31:06 <panther7> hi guys
10:31:16 --> nhnt11 has joined #instantbird
10:31:30 <panther7> some news to https://wiki.instantbird.org/Instantbird:Roadmap ?
10:33:00 <flo-retina> panther7: there's plenty of work going on right now, but nobody has looked at that old roadmap page recently ;).
10:33:44 <clokep> That page doesn't really mean anything. :-[
10:34:14 <panther7> :'(
10:34:38 <clokep> panther7: Maybe it's better if you ask what's actually on your mind?
10:34:38 <flo-retina> panther7: do you have more specific questions (that would likely be easier to answer for us) ? :)
10:35:29 <panther7> yes, what's new in 1.5? ;)
10:35:37 <-- nhnt11 has quit (Ping timeout)
10:35:40 <panther7> to planning
10:35:51 <flo-retina> panther7: that will be on the release notes once 1.5 is released :)
10:36:19 --> nhnt11 has joined #instantbird
10:36:24 <flo-retina> panther7: the top projects currently are the "new tab" project (there will likely be a blog post about it soon), implementing Yahoo in JS, and using FileLink to transfer file
10:36:30 <panther7> yes, but actually changelog must exist
10:36:33 <flo-retina> no guarantee that all of them will land for 1.5 of course :)
10:36:43 <panther7> ofcourse
10:36:46 <flo-retina> panther7: changelog happens after a release is released ;)
10:37:04 <flo-retina> you can look at hg if you want day to day change information: http://hg.instantbird.org/instantbird/shortlog
10:37:30 <clokep> panther7: Or the closed bugzilla bugs: https://bugzilla.instantbird.org/buglist.cgi?resolution=FIXED&target_milestone=1.5
10:37:39 <panther7> thanks
10:37:44 <panther7> this is great changelog ;)
10:38:41 --> mpmc has joined #instantbird
10:38:42 * flo-retina has a hard time know what's new since the latest release
10:38:53 <-- nhnt11 has quit (Ping timeout)
10:38:58 <flo-retina> I've already forgotten anything that landed in nightlies more than 2 days ago :-]
10:38:59 <panther7> btw, will do fast release new version (every 6 weeks) like firefox, chrome...? :)
10:39:13 <clokep> No.
10:39:45 <panther7> ok :)
10:39:49 <flo-retina> panther7: we try to release roughly every 3 months, but with no guarantee that the time between releases is actually 3 months.
10:39:49 --> nhnt11 has joined #instantbird
10:39:50 <panther7> thanks for answers ;)
10:40:08 <flo-retina> panther7: it's more like every 3 months we kinda feel "now would be time to release something", and then release as soon as we are ready to.
10:40:11 <clokep> Releases take a lot of developer effort so they're tough for a small team.
10:40:45 <clokep> flo-retina: Any chance of getting approving some of those build changes / maybe the Moz 22 update soon? :) My queue of patches is insane right now.
10:42:37 <flo-retina> clokep: well.
10:42:44 <clokep> Btw I fixed the Twitter issue, see https://bugzilla.mozilla.org/show_bug.cgi?id=894367
10:42:48 <flo-retina> I don't expect to have huge amount of review time before going in vacations
10:43:02 <flo-retina> I will have a 1 hour train ride Friday evening.
10:43:24 <panther7> btw, small suggest... i think, that instanbirg takes much RAM... over 100MB, it is "simple" client, i have only 1xicq, 1xgtalk, 2xirc ... max 5 tabs.. no addons
10:43:25 <-- nhnt11 has quit (Ping timeout)
10:43:33 <flo-retina> I kinda expected to look at aleth's new participant context menu patch during that time (or nhnt11's new patch if it's ready by then), but if you think the build system updates are higher priority, I can do that instead.
10:43:34 <clokep> Right and the update most likely needs Mac tweaks.
10:43:38 --> nhnt11 has joined #instantbird
10:43:49 <clokep> No, that's OK.
10:44:02 <clokep> I'll work on the BIO->BMO.
10:44:08 <flo-retina> clokep: I saw the patch there, thanks for fixing it! :)
10:44:40 <clokep> panther7: Idk what makes it "simple", but OK. That doesn't mean much unless you look at about:memory and see what's taking up memory.
10:45:08 <instantbot> New Instantbird (UI) bug 2058 filed by aleth@instantbird.org.
10:45:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2058 min, --, ---, nobody, NEW, Generic buddy icon absent from conversation top
10:45:25 <panther7> where i can write "about:memory"? :)
10:45:31 <flo-retina> panther7: would be nice if you could go to the error console, and execute this: openDialog("about:memory"); and then pastebin the output
10:45:45 <flo-retina> panther7: in current nightly you just type "/about memory" in any conversation tab
10:46:22 <panther7> thnkas
10:46:49 * clokep just tried to tab complete "memory" :P
10:47:05 <-- nhnt11 has quit (Ping timeout)
10:47:50 --> nhnt11 has joined #instantbird
10:49:49 <flo-retina> aleth: is bug 2058 really a regression? I don't remember nhnt11 touching that conversation code :-S
10:49:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2058 min, --, ---, nobody, NEW, Generic buddy icon absent from conversation top
10:50:31 <aleth> flo-retina: Hmm, am I imagining things? Did we in fact never use the silhouette icon there?
10:51:08 <clokep> aleth: We did not.
10:51:15 <clokep> I think the blank square looks broken though FWIW.
10:51:30 <-- nhnt11 has quit (Ping timeout)
10:51:50 --> nhnt11 has joined #instantbird
10:53:45 --> nhnt12 has joined #instantbird
10:54:57 * nhnt12 is now known as nhnt11-vm
10:55:18 <-- nhnt11 has quit (Ping timeout)
10:55:39 --> nhnt11 has joined #instantbird
10:55:51 <flo-retina> aleth: this is definitely a bug, and I also noticed it only after asking nhnt11 to fix something similar in the awesometab. But I'm not positive it's a regression.
10:56:14 <flo-retina> the fix is trivial anyway. The problem is purplexpcom returns null instead of "" when there's no icon, so we just need to add | || "" | to the code, like nhnt11 did.
10:56:49 <-- nhnt11-vm has quit (Ping timeout)
10:57:06 <nhnt11> running my vm in fullscreen in its own space works great :)
10:57:20 <flo-retina> cool
10:57:42 <nhnt11> Though I wish VirtualBox supported "proper" fullscreen where it automatically gets put in its own space
10:57:55 <clokep> "Put in its own space"?
10:58:40 <flo-retina> clokep: like a virtual desktop on linux
10:58:57 <flo-retina> clokep: osx calls "space" what linux destkop managers call "virtual desktop"
10:59:50 <-- jb has quit (Ping timeout)
10:59:51 <-- nhnt11 has quit (Input/output error)
10:59:55 --> nhnt11 has joined #instantbird
11:00:33 * clokep still doesn't /really/ know what that is. :)
11:00:35 --> jb has joined #instantbird
11:00:36 <clokep> But I get the gist, I think.
11:01:58 <nhnt11> clokep: Newer versions of Mac OS add support for more seamless fullscreen apps, where each fullscreen app is put in it's own desktop space
11:02:13 --> nhnt12 has joined #instantbird
11:02:19 <aleth> clokep: Virtual desktops is what you use if you don't have multiple monitors... like me :-/
11:02:33 <-- jb has quit (Ping timeout)
11:02:39 <nhnt11> Oh, flo already answered
11:02:44 * nhnt11 curses his internet today
11:03:05 * nhnt12 is now known as nhnt11-vm
11:03:56 <clokep> nhnt11: That still doesn't mean anything.
11:04:09 <clokep> aleth: I'm not sure how that helps, the reason I use two monitors is more screen space at once so I can reference between them.
11:04:12 <-- nhnt11 has quit (Input/output error)
11:04:22 --> nhnt11 has joined #instantbird
11:04:32 <nhnt11-vm> clokep: It helps because I can switch easily between windows and mac using a four-finger swipe ;)
11:04:47 <aleth> clokep: I can use the scrollwheel when hovering over a tiny free bit of desktop to switch screens. It's very rapid.
11:05:06 <aleth> nhnt11: Before flo-retina goes on holiday, you should have a conversation about his comments on the references kept by the service. This isn't trivial, and there seem to be some underlying assumptions about how the ranking will/should work and keep its data which have never been discussed afaik
11:05:56 <nhnt11> aleth: From what I understood, I should keep references to contacts, but not to existing conversations
11:05:59 <aleth> nhnt11: I'm not too keen on trading off snappiness against less memory use, so trying to find a way to achieve both may take some thinking.
11:06:21 <nhnt11> I personally think keeping references to everything is fine
11:06:36 <nhnt11> Since as flo said, there aren't going to be that many open conversations. So it shouldn't take that much more memory
11:06:42 <-- nhnt11-vm has quit (Input/output error)
11:06:45 <aleth> nhnt11: No, one of the issues is that each reference to an imContact costs an XPCOM wrapper overhead.
11:06:45 --> nhnt11-vm has joined #instantbird
11:07:55 <aleth> nhnt11: You should definitely discuss this to make sure you understand his concerns (and then hopefully you can agree on how to tackle it ;) )
11:08:24 <nhnt11> Hmm
11:08:29 <-- nhnt11 has quit (Input/output error)
11:08:32 --> nhnt11 has joined #instantbird
11:08:42 <aleth> s/XPConnect/XPCOM to be precise
11:09:01 <aleth> argh, the opposite :-/
11:09:23 <-- nhnt11-vm has quit (Ping timeout)
11:09:34 <nhnt11> I wonder if I should just store contact id's
11:09:47 <nhnt11> And use the contact service's getContactById
11:09:53 <aleth> That would certainly help :)
11:09:56 <nhnt11> When I need the actualy imIContact instance
11:09:59 --> nhnt11-vm has joined #instantbird
11:10:08 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:10:25 <aleth> nhnt11: https://developer.mozilla.org/en-US/docs/XPConnect_wrappers may be of interest
11:10:32 <nhnt11> aleth: This will all probably be more clear with the multiple extensions of PossibleConversation
11:10:44 <nhnt11> Thanks, I'll read that
11:10:53 <aleth> nhnt11: It's independent of it, so you can definitely do that first :)
11:11:15 <nhnt11> aleth: I said that it will be more clear because IDs are not unique
11:11:38 <nhnt11> I mean, if we have a ContactConversation (excuse the name), the id it stores is guaranteed to refer to a contact
11:11:38 <aleth> nhnt11: Oh, I see.
11:11:55 <aleth> Yes, I think that change should simplify a lot of things.
11:12:04 <nhnt11> Yeah. Thanks for the suggestion :)
11:13:04 <-- nhnt11-vm has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:20:38 <nhnt11> aleth, flo-retina: Do you want me to drop the "UI Conv" name then?
11:20:49 <nhnt11> It's used everywhere in the code, I thought it would be consistent
11:20:59 <aleth> nhnt11: That's the one instance where it actually refers to a conversation :D
11:21:12 <aleth> Of course you can keep that ;)
11:21:16 <nhnt11> cool
11:22:38 <nhnt11> I kinda like "ConversationTarget" (to replace PossibleConversation) but you said target is a bad name..
11:23:06 <aleth> I just meant that usually target is used in event handlers.
11:23:19 <nhnt11> Hm
11:23:57 <aleth> Or more generally, for something that is referred back to. But in this case the target doesn't exist yet?
11:24:10 <nhnt11> Why wouldn't it exist yet?
11:24:58 <aleth> Maybe I'm confused, but because the conversation doesn't exist yet?
11:26:26 <aleth> Anyway, you can keep PossibleConversation if you're just asking about the class names.
11:26:54 <nhnt11> aleth: I meant it to mean "A target to open a conversation with"
11:27:17 <nhnt11> Basically I thought of using "ConversationTarget", and extend that with "ContactTarget", "ChatTarget", and "UIConvTarget"
11:28:24 <aleth> Target just doesn't sound quite right to me in that context :-S Sorry.
11:28:28 <nhnt11> Hmm
11:28:55 <aleth> Maybe a "key"? :P
11:28:59 <nhnt11> NewTabContact, NewTabChat, etc?
11:29:02 <aleth> but that makes it sound like a password or something...
11:30:32 <nhnt11> aleth: How about "reference"
11:30:41 <nhnt11> i.e. ContactReference, ChatReference
11:30:43 <nhnt11> bah
11:30:49 <nhnt11> doesn't sound right
11:32:05 <nhnt11> How about PossibleConversation, extended by PossibleContact, PossibleChat, PossibleUIConv?
11:32:13 <nhnt11> And I'll make it clearer in the JS code
11:32:24 <aleth> That's the best so far for the classnames :)
11:37:03 <aleth> What is it really? It's all the data needed to start a conversation, together with all the data needed to find it when searching for it.
11:37:04 <nhnt11> ibIPossibleChat is pretty empty :(
11:37:35 <aleth> PossibleChat is for MUCs?
11:37:38 <nhnt11> Yes
11:39:43 <aleth> Well, just use those for now, and you can always search and replace later if inspiration strikes with something better ;)
11:39:49 <nhnt11> Yeah
11:40:03 <nhnt11> I can't figure out how to make ibIPossibleChat worth having
11:40:06 <nhnt11> it's completely empty
11:40:10 <nhnt11> Is that okay?
11:40:17 <aleth> It will have a topic etc?
11:40:24 <aleth> Or do you put that in the status?
11:40:25 <nhnt11> I'm using statusText for that
11:40:29 <nhnt11> yeah.
11:40:45 <aleth> It may have a password field
11:40:55 <aleth> (Though leave that for later)
11:41:03 <nhnt11> Hmm, good point, but yeah later I think.
11:41:08 <nhnt11> btw, here's what I have so far:
11:41:10 <nhnt11> http://pastebin.instantbird.com/249760
11:42:03 <nhnt11> (Er, not so far, just the interface part)
11:42:16 <aleth> Don't forget the constructor will take a parameter
11:43:50 <nhnt11> That doesn't need anything in the interface though, right?
11:45:14 <nhnt11> Btw, I changed the imIContact reference to an id.
11:48:37 --> jb has joined #instantbird
11:51:19 <-- jb has quit (Quit: jb)
11:53:17 <aleth> nhnt11: That seems to be right, though I am a bit surprised by it :-/
11:53:33 <nhnt11> I changed it back to an imIContact
11:53:44 <nhnt11> I'm returning an imIContact with a lazy getter
11:54:00 <nhnt11> i.e. get contact() Services.contacts.getContactById(this._id)
11:54:14 <flo-retina> "I should just store contact id's\nAnd use the contact service's getContactById\nWhen I need the actual imIContact instance" yes :)
11:54:27 <nhnt11> flo-retina: That's done :)
11:54:29 <aleth> A lazy getter will still keep the reference around.
11:54:48 <nhnt11> Really?
11:54:48 --> clokep_ has joined #instantbird
11:54:58 <nhnt11> Won't it do the Services.contacts.getContactById every time?
11:55:29 <aleth> Oh, I see. Your example code isn't a lazy getter , it's just a getter :P
11:55:37 <nhnt11> Er, yeah sorry :P
11:56:42 <aleth> flo-retina: Is it really correct that constructor parameters don't get listed in the interface?
11:57:14 <nhnt11> I have to go for a while
11:57:15 <nhnt11> bbl
11:57:18 <flo-retina> aleth: totally, yes :)
11:57:29 <flo-retina> aleth: you don't want parameters for the service constructor
11:57:41 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:57:50 <flo-retina> aleth: for the JS implementation of objects exposing  XPCOM interfaces, it's right though :)
12:00:26 * aleth found this surprising...
12:04:23 <clokep_> nhnt11: For what it's worth, I like "PossibleConversation" as a name...
12:06:56 <clokep_> aleth: Interfaces don't contain a constructor at all, just ways to access fields.
12:07:06 <clokep_> It doesn't tell you how to create the object, just how to uhh...interface with it.
12:08:04 <aleth> clokep_: Right, it's just odd because the constructor is a method of a sort...
12:10:14 * clokep_ shrugs.
12:10:23 <clokep_> Maybe I"ve just looked at them too long, I don't find it strange. :-D
12:11:47 <clokep_> Did nhnt11 say he was leaving? I have a lot of comments on that interface.
12:11:51 <clokep_> (I.e. I think it's totally wrong.)
12:15:32 <aleth> clokep_: He said bbl. Just leave your comments here I guess.
12:16:40 --> jb has joined #instantbird
12:17:33 * clokep_ mumbles.
12:18:22 <clokep_> nhnt11: Wouldn't it make more sense to have PossibleConversation have the fields you actually care about and then have the separate implementations care about providing the input into those fields instead of (I'm assuming) the service checking the type and then treating them 100% differently?
12:18:38 --> Optimizer has joined #instantbird
12:27:03 <-- skeledrew has quit (Ping timeout)
12:30:34 --> novabyte has joined #instantbird
12:31:09 --> skeledrew has joined #instantbird
12:42:17 <clokep_> qheaden_away: Have you been doing weekly updates? I miss the daily ones. :(
12:51:35 * aleth sees lots of daily/weekly logs from qheaden in his RSS
12:55:08 <clokep_> Bah, thsoe are so not in TB. :(
13:02:16 <-- aleth has quit (Quit: Ciao)
13:02:31 --> aleth has joined #instantbird
13:02:31 * ChanServ sets mode +h aleth 
13:16:32 <flo-retina> aleth: what's "my experience of file transfers via IM so far"?
13:17:02 <flo-retina> my experience was typically that it didn't work and the transfer never really started. Sometimes it was also going through extremely slow MSN proxies.
13:17:04 <aleth> When they even start they usually fail, and the longer the file the more likely the failure.
13:17:38 <aleth> It's only via IRC DCC that I can remember actually getting them to start actually.
13:17:52 <flo-retina> so maybe we shouldn't limit the size, but the estimated time, and if the estimated time is long, say "Hey, it looks like this transfer will take a long time to complete, would you like to send a link to the file instead?"
13:18:46 <aleth> Or have a timeout on transfers and show this message if they take too long?
13:19:30 <aleth> I'm not sure if we can estimate time reliably enough?
13:19:59 <aleth> Ah, I guess you mean estimated time for each transfer based on the speed of the current transfer. 
13:20:00 <flo-retina> aleth: I was more thinking "if after 2 minutes we sent less than 1% of the file"
13:20:03 <aleth> Sorry for being slow.
13:20:31 <aleth> Yes, that seems like the right way to go.
13:21:24 <-- Optimizer has quit (Ping timeout)
13:22:27 --> Optimizer has joined #instantbird
13:24:23 <clokep_> That seems reasonable. :)
13:25:29 <flo-retina> aleth: we could also suggest filelink whenever a transfer failed
13:25:51 <aleth> flo-retina: I thought that's what "fallback" meant ;)
13:25:56 <flo-retina> for example if the contact at the other end has a flaky connection. And http link will be easier to fetch than a file through a direct connection
13:26:15 <flo-retina> aleth: initially I was seeing "fallback" as for the case where a transfer fails to start
13:26:21 <flo-retina> not fails to complete
13:26:44 <aleth> I think it makes sense for both (but maybe depending on the reason for failure to complete)
13:27:41 <aleth> If the transfer fails because the target goes offline, offering FileLink does not help.
13:31:19 <clokep_> Right.
13:31:37 <clokep_> Maybe in that case we should upload it and then give a mailto link? :P
13:32:14 <aleth> Well, if this ever makes it into TB,... ;)
13:32:31 <clokep_> aleth: What does that have to do with TB? :-S
13:32:44 <clokep_> flo-retina: Btw I had a discussion in #build last night with jcranmer and gps about getting dynamic-prpls to work again, but I'm afraid I don't have the knowledge of WHY we build the libraries that way to figure out what to change it to.
13:32:50 <aleth> clokep_: It's an email client which might have an address book entry with the email of the contact
13:33:32 <flo-retina> aleth: I didn't say "goes offline" but "has a flaky connection". If he goes offline 10s every half hour, a transfer of a large file will never complete
13:33:52 <clokep_> aleth: You can probably provide a mailto link w/o an address :-D
13:33:55 <clokep_> (If we don't have one.)
13:34:22 <aleth> flo-retina: I was agreeing with you, in cases like that Filelink makes sense. I just gave an example for a failure mode where it doesn't imho
13:34:26 <flo-retina> clokep_: it's quite possible that you miss quite a bit of the context there. Do you have a pastebin of the log (in case anything said there was useful or something I should reply to)?
13:35:07 <flo-retina> aleth: yeah, it may not always be the best thing to do... but we can just "offer FileLink", the user doesn't have to accept
13:35:53 <aleth> flo-retina: Right, and worry about potential edge cases later.
13:37:00 <clokep_> flo-retina: Not on this machine.
13:38:53 --> mconley has joined #instantbird
13:39:33 --> Mic has joined #instantbird
13:39:33 * ChanServ sets mode +h Mic 
13:39:45 <clokep_> flo-retina: I'm seeing if Joshua can give me one.
13:43:36 <-- jb has quit (Ping timeout)
13:43:40 <flo-retina> clokep_: no rush
13:45:51 --> jb has joined #instantbird
13:47:47 * qheaden_away is now known as qheaden
13:48:05 <clokep_> flo-retina: http://pastebin.mozilla.org/2649578
13:48:16 <aleth> Section scroll in the log viewer is broken :(
13:48:34 <qheaden> Hello everyone.
13:48:53 <-- Optimizer has quit (Ping timeout)
13:50:30 --> Optimizer has joined #instantbird
13:50:58 <flo-retina> aleth: really?
13:51:06 <flo-retina> I thought we fixed it :-S
13:51:11 <flo-retina> or maybe we fixed only macgestures
13:53:10 * aleth finds unrelated bug :(
13:54:26 <clokep_> flo-retina: Btw if you want to fill me in on why it's set up that way we can then go into #build and discuss, maybe. Not sure how busy you are today. :)
13:54:28 * clokep_ runs to a meeting.
13:55:04 <instantbot> New Instantbird (UI) bug 2059 filed by aleth@instantbird.org.
13:55:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2059 nor, --, ---, nobody, NEW, Failure to remove selection listener after switching logs in log viewer
13:56:02 <clokep_> (Although I can't test things right now, so maybe not the best time to do it.)
13:57:29 <flo-retina> clokep_: so the build order is: 1. Libpurple's static prpls and libpurple's dependencies (libxml, glib) that need to get statically linked into libpurple. 2. Libpurple's file, and then we generate the libpurple libraries that's statically linked with all the stuff from 1. 3. purplexpcom.
13:57:30 <flo-retina> 4. Dynamic prpls (built from the makefile in libpurple's directory, but *after* purplexpcom is built, because these prpl need to link to purplexpcom. And purplexpcom needs to link with libpurple).
13:58:12 <flo-retina> using DIRS would make 4. happen roughly at the same time as 2., ie. before 3.
13:58:16 <flo-retina> clokep_: does this help?
13:58:30 <clokep_> Yes.
13:58:50 * clokep_ is unsure how that order can be controlled with moz.build.
13:59:58 <flo-retina> have you tried gps' suggestion of just doing CONFIGURE_SUBST_FILES += ['path/to/output/Makefile'] ?
14:01:44 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:04:42 <instantbot> New Instantbird (UI) bug 2060 filed by spiffytech@gmail.com.
14:04:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2060 nor, --, ---, nobody, UNCO, Can't view previous days' log entries for certain Jabber account
14:05:33 <flo-retina> :-S
14:08:09 <aleth> Just when I was thinking of looking at that patch Connor submitted :(
14:08:38 <flo-retina> doesn't seem exactly the same
14:08:49 <aleth> No... but that's why I was looking at the log viewer...
14:09:01 <flo-retina> but I would hope it's related, and we don't have half a dozen new log viewer bugs that appeared this month :-D
14:09:59 <aleth> I wish at least one of these bugs came with STR
14:10:02 * aleth grumbles
14:14:07 <-- jb has quit (Ping timeout)
14:20:39 <flo-retina> I also have a bug in the log viewer that I think needs debugging, but I unfortunately don't understand the steps to reproduce (it seems to only happen with one specific log file I have locally)
14:21:00 <flo-retina> I'd like to debug that next time I'm bored :)
14:21:15 <flo-retina> (related to magic copy, so definitely unrelated to the stuff you are looking at)
14:29:52 <-- Optimizer has quit (Ping timeout)
14:44:23 --> nhnt11 has joined #instantbird
14:47:02 <nhnt11> clokep: http://log.bezut.info/instantbird/130718#m430 I'm not sure exactly what you mean here
14:47:20 <-- aleth has quit (Quit: Ciao)
14:47:30 --> aleth has joined #instantbird
14:47:31 * ChanServ sets mode +h aleth 
14:50:06 --> Optimizer has joined #instantbird
14:54:22 --> jb has joined #instantbird
14:55:12 <aleth> flo-retina: Not a bug, but something where I would like to understand what is causing it: If I run IB with an unpacked omni.ja, I get error messages like "failed to create an instance of @instantbird.org/purple/protocol;1: TypeError: Cc[cid] is undefined" on startup unless initLibpurpleOverrides is commented out.
14:56:37 <-- Optimizer has quit (Ping timeout)
14:57:58 --> Optimizer has joined #instantbird
14:58:06 --> jb1 has joined #instantbird
14:58:36 <-- jb has quit (Ping timeout)
14:58:59 <flo-retina> aleth: is your libpurple messed up maybe?
14:59:01 <Mic> aleth: do you unpack IB frequently?
14:59:17 <Mic> Basically I'd like to know if you know that you'll need to merge chrome.manifest files?
14:59:54 <aleth> Mic: My chrome.manifest has two entries, one for components and one for chrome.
15:00:01 <aleth> Hmm, maybe the binary one is missing?
15:00:36 <-- Optimizer has quit (Ping timeout)
15:00:54 <Mic> There should have been one in components already which got overwritten during unpacking most likely?
15:01:11 <Mic> *components.manifest, sorry.
15:01:35 <Mic> http://pastebin.instantbird.com/249912
15:02:01 <Mic> Add these lines to components.manifest in the components directory.
15:02:05 <-- nhnt11 has quit (Ping timeout)
15:03:09 --> nhnt11 has joined #instantbird
15:04:12 <aleth> Mic: That fixed it, thanks!
15:04:24 <Mic> :)
15:04:32 <aleth> Did they change the way those were organized recently?
15:05:15 <Mic> Yes, something changed.
15:05:35 <aleth> Actually, it didn't fix it :( I had still commented out initLibpurpleOverrides
15:06:11 --> Optimizer has joined #instantbird
15:07:19 <-- panther7 has quit (Quit: bye)
15:09:36 <aleth> Mic: Shouldn't have copypasted without thinking :D Those lines are OS-specific...
15:09:54 <Mic> Yes, you'll need other file extensions at least.
15:10:46 <aleth> The diagnosis was correct though. (On Linux there are four binary libraries that need to be added)
15:11:03 <Mic> Oh really, what else is needed there?
15:12:15 <aleth> http://pastebin.instantbird.com/249923
15:12:16 <-- Optimizer has quit (Ping timeout)
15:12:58 --> Optimizer has joined #instantbird
15:14:09 <Mic> Does that mean that you have a usable Bonjour protocol by default on Linux?
15:14:40 <Mic> On Windows we need to download a Bonjour package from Apple :S
15:15:13 <-- nhnt11 has quit (Ping timeout)
15:16:10 <aleth> I've never tried.
15:17:32 <-- Mic has quit (Ping timeout)
15:32:03 <-- Optimizer has quit (Ping timeout)
15:39:08 <-- gerard-majax_ has quit (Ping timeout)
15:40:02 --> nhnt11 has joined #instantbird
15:43:22 --> clokep_ has joined #instantbird
15:44:52 <clokep_> Mic: Bonjour is not usable by default on Linux, you have to install libavahi.
15:45:03 <clokep_> nhnt11: I'm not sure what's not clear about that, can you be more specific?
15:46:20 <nhnt11> What are the "fields I actually care about"
15:46:42 <nhnt11> (Are there fields I don't care about?)
15:48:07 <clokep_> nhnt11: You don't actually care about the contact.
15:48:14 <clokep_> You want a "name" and some other information.
15:48:28 <clokep_> (A description maybe, i.e. topic or status text)
15:49:27 --> Optimizer has joined #instantbird
15:49:42 <clokep_> Does that make any more sense?
15:49:47 <clokep_> (Idk if aleth has thoughts on this)
15:49:55 <nhnt11> So what you're saying is that the interfaces (e.g. PossibleContact) should store the fields I want to display instead of imIContacts?
15:49:57 <clokep_> Have we seen atuljangra today?
15:50:10 <nhnt11> That's what they do already, btw. Just that the id of the imIContact is also stored.
15:50:15 <clokep_> No.
15:50:32 <clokep_> I'm saying the PossibleConversation should do that and that PossibleContact should be an implementation not an interface.
15:50:38 <clokep_> But maybe I'm over simplifying.
15:50:47 <clokep_> (Remember I haven't really looked at this code. :-D)
15:51:19 <nhnt11> Er, so basically have one interface, and multiple implementations of it?
15:51:32 <nhnt11> Rather than having an interface for each implementation
15:51:33 <aleth> nhnt11: clokep_ is asking whether there is any need for possibleContacts to have a different *interface* from other possible*
15:51:46 <clokep_> nhnt11: Yes, that's what I'm trying to say.
15:51:55 <clokep_> The interfaces you propose seem so specific that they're not interfaces.
15:51:58 <clokep_> They'rej ust the objects.
15:52:03 <nhnt11> Ah
15:52:15 <nhnt11> So keep the PossibleConversation interface then
15:52:16 <nhnt11> Hmm
15:52:18 <nhnt11> That seems good
15:52:26 <clokep_> Don't put words in my mouth.
15:52:34 <clokep_> I don't know what the PossibleConversation interface is exactly. ;)
15:52:40 <nhnt11> :P
15:53:03 <aleth> nhnt11: Whether it is good depends on your needs ;)
15:53:10 <clokep_> I think I'm also confused at why these interfaces are necessary, I'd kind of like to see a drawing of how things get from / to this service.
15:53:24 <clokep_> What uses these PossibleConversation interfaces?
15:54:10 <aleth> clokep_: "I'm also confused at why these interfaces are necessary". That was my thought also. This could be pure JS, since only the service ever uses the possibleconversations.
15:54:18 <nhnt11> clokep_: I created the interface because I need to return the list of filtered stuff.
15:54:27 <nhnt11> And in the interface for the service, I need a return type
15:54:40 <aleth> Hmm
15:54:42 <nhnt11> So for that I need a new interface (I think I asked about this before, and I can't return JS objects)
15:54:44 <clokep_> nhnt11: Yes, you do.
15:55:10 <clokep_> nhnt11: Could you make that drawing if it isn't too much work? I think it'd clear things up in your mind too.
15:55:12 <nhnt11> And I can't just reuse imIContact, because the list doesn't contain onl contacts
15:55:35 <nhnt11> clokep_: I don't really know what to draw :P
15:55:54 <nhnt11> consumer requests filtered list, service returns list of PossibleConversations
15:55:58 <clokep_> nhnt11: Boxes and arrows.
15:55:58 <aleth> nhnt11: You wouldn't want to return imIContacts anyway :P
15:56:30 <clokep_> nhnt11: I'll draw you a picture of what /I/ think it should be.
15:56:33 <clokep_> After lunch though. :)
15:56:53 <nhnt11> clokep_: No, I meant I don't get what boxes the drawing would contain. It's not that complicated from my POV
15:57:27 <clokep_> nhnt11: The conversaion, the service and prpls?
15:57:34 <clokep_> It's confusing to me, that's why I asked. :P
15:58:08 <nhnt11> Er, ok. Let me try.
15:58:09 <aleth> nhnt11: Just draw him a picture showing the data flow (what queries what, including Services.contacts and Conversations etc)
15:58:26 * nhnt11 searches for paper
16:06:38 * nhnt11 's drawing kinda sucks
16:07:59 <-- novabyte has quit (Quit: bye bye)
16:08:06 <qheaden> clokep_: Hey there. I don't think I'm going to be able to do much today. I have some things I have to take care of. If I could, I would like to come back and continue development tonight.
16:24:21 <nhnt11> clokep_: Ok here's a drawing.. I'm not sure if it conveys the information you wanted, let me know. http://puu.sh/3FXov.png
16:25:08 * nhnt11 notes that draw.io is nice for putting together quick flow charts
16:28:54 --> gerard-majax_ has joined #instantbird
16:33:31 <flo-retina> nhnt11: looks like this describes more the current architecture (in your patch) than the planned future architecture (ie. how does ranking happens?)
16:34:02 <nhnt11> Right, that's what I meant that drawing to show.
16:34:11 <nhnt11> I don't think ranking will affect that flow much
16:34:37 <qheaden> nhnt11: What will "ranking" do?
16:34:42 <flo-retina> why do you want to ask for the list of contacts at startup?
16:35:01 <nhnt11> qheaden: Make frequently contacted people show up first in the list
16:35:07 <nhnt11> flo-retina: To make it snappy later?
16:35:12 <qheaden> Ahh ok. Cool.
16:35:18 <flo-retina> "it" ?
16:35:26 <nhnt11> Loading of the newtab
16:35:45 <nhnt11> When do you want it to ask for the list instead?
16:35:56 <nhnt11> After ranking is incorporated this will be different.
16:36:18 <flo-retina> possibly lazily when the user types something in the filter box
16:36:20 <nhnt11> It will query its database for the first n entries that matches the filter string
16:36:36 <nhnt11> Hmm but there's no way to get a contact based on the string as of now.
16:36:46 <nhnt11> That will change when we have the ranking stuff
16:39:20 <-- gerard-majax_ has quit (Ping timeout)
16:39:27 <nhnt11> I'm going to have to sign off soon. Not able to concentrate properly, making mistakes. :(
16:40:17 <flo-retina> nhnt11: "That will change when we have the ranking stuff" I think this is my point, that started this conversation :-S.
16:40:44 <nhnt11> flo-retina: Yeah, I noticed we ended up at your first point :P
16:40:47 <nhnt11> Ugh
16:41:19 <flo-retina> so it seems I could lead you to reach my conclusion :-P.
16:46:52 <nhnt11> ok, I now have PossibleContact and PossibleUIConv that both implement PossibleConversation. Basically the same functionality as before, but there are two separate implementations now
16:47:48 <flo-retina> s/PossibleUIConv/ExistingUIConv/ ?
16:47:59 <nhnt11> Right
16:48:07 <nhnt11> That seems obvious now that you suggested it..
16:48:08 --> Mook_as has joined #instantbird
16:48:49 <clokep_> qheaden: Hm, OK.
16:49:00 <clokep_> qheaden: I'd like if you could get another version of the patch up soon.
16:49:45 <qheaden> clokep_: I'll try to do some work until 2:30, then I will do the rest tonight.
16:50:01 <clokep_> OK.
16:50:17 <clokep_> nhnt11: I was hoping for interface names and what objects are passed back and forth. That's what I was hoping to clairf.y
16:50:45 <clokep_> nhnt11: I guess my point is why is the Service making each of those into a possible conversation?
16:51:53 <nhnt11> The service needs to return a list, in which all items implement the same interface
16:52:05 <nhnt11> Because I need to specify that interface as the return type in the IDL
16:52:12 * nhnt11 thinks he's missing clokep_'s point
16:52:25 <clokep_> nhnt11: You are. Why don't the things that return lists TO the interface do it?
16:52:50 <nhnt11> Ahh
16:52:56 <clokep_> That's what I'm trying to get at.
16:53:08 <nhnt11> Well for one thing, the contacts service may have more consumers than just the stats service
16:53:14 <nhnt11> Same with the accounts
16:53:19 <clokep_> So what?
16:53:33 <clokep_> I need to drwa it out.
16:53:45 <nhnt11> So if they return PossibleConversations directly, won't that be redundant for consumers that just want contacts/chats directly?
16:53:54 <nhnt11> Ah but there's no interface for chats
16:53:57 <nhnt11> Hmm.
16:54:18 <-- dew has quit (Ping timeout)
16:55:10 <nhnt11> clokep_: Another problem I see here is that the contacts service and account interface code is in chat/
16:55:24 <nhnt11> And PossibleConversation is in instantbird/
16:55:29 <nhnt11> I'd have to move stuff around.
16:55:38 <nhnt11> Hmm
16:56:25 <clokep_> nhnt11: Are you not allowed to modify chat/ for some reason? :-S
16:56:27 <Mook_as> seems reasonable to think that thunderbird might want a similar feature in the future with different UI? :)
16:56:53 <-- jb1 has quit (Ping timeout)
16:57:01 <clokep_> (If you need to go sleep, please do. Don't stay up if you're sick. :))
16:57:14 <nhnt11> clokep_: I am and will have to. Like I said, I'll have to move stuff around.
16:57:56 <nhnt11> Yeah I'll go to bed soon. I'd rather not wake up and see obvious mistakes everywhere that I need to fix ;)
16:58:22 * nhnt11 wonders if he might've picked up a bug at the passport office - it's very crowded.
16:58:23 <aleth> Just read the scrollback and I'm not sure you two are talking about the same thing...
16:58:53 <clokep_> I'm not sure either. :(
17:00:30 <qheaden> clokep_: What worries you about dataString in YahooPacket.toArrayBuffer()?
17:02:43 <-- mpmc has quit (Ping timeout)
17:03:42 <flo-retina> nhnt11: I wonder if clokep was suggesting that you need to create the objects implementing the ibIPossibleConversation interface only when you are about to return them as part of a filtered list.
17:05:22 --> jb has joined #instantbird
17:05:44 <clokep_> qheaden: Encodings.
17:06:50 <qheaden> clokep_: Okay. I'll see what I can do with it.
17:08:07 <clokep_> qheaden: Not saying you need to DO anything.
17:08:09 <qheaden> clokep_: Hmm. But couldn't my using a string in this case be equivalent to using a C++ char*?
17:08:10 <clokep_> Just thinking aloud. :)
17:08:10 * instantbot mumbles something about c++ being evil
17:08:22 <clokep_> qheaden: JS strings aren't equivalent to C++ char*.
17:08:26 <clokep_> So no.
17:08:35 <clokep_> How do you start a conv w/ a contact? :-D
17:08:37 <clokep_> What's the method name?
17:08:43 <nhnt11> flo-retina: Erm, I'm not able to process this right now. I'll continue tomorrow.
17:08:49 <nhnt11> :(
17:08:50 <nhnt11> Good night.
17:09:46 <qheaden> clokep_: YahooAccount.createConverstation(), if you were asking that of me.
17:11:22 <-- nhnt11 has quit (Ping timeout)
17:11:52 <clokep_> qheaden: I wasn't. :) Thanks.
17:12:01 <qheaden> Okay. :P
17:13:47 * clokep_ realizes he has awful handwriting.
17:14:48 <clokep_> nhnt11: aleth flo-retina http://i.imgur.com/8QQ0fXY.jpg is what I was discussing.
17:14:58 <clokep_> (I hope the resolution is reasonable. :-/)
17:24:45 --> gerard-majax_ has joined #instantbird
17:26:15 <qheaden> clokep_: Are there any people who plan on testing the plug-in when it is landed?
17:34:35 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2607 on bug 2059.
17:34:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2059 nor, --, ---, aleth, ASSI, Failure to remove selection listener after switching logs in log viewer
17:37:42 <qheaden> clokep_: Something really irks me about having to define a confInvite function outside of YahooPacketHandler. Could we simply make handler 0x1b get the 0x18 method by using YahooPacketHandler.hasOwnProperty(0x1c)?
17:40:46 --> mpmc has joined #instantbird
17:41:49 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:44:20 <-- gerard-majax_ has quit (Ping timeout)
17:45:27 <qheaden> Okay, I think I found a better solution.
17:49:55 <clokep_> qheaden: You can just do YahooPacketHandler[0x1c], can't you?
17:50:02 <qheaden> clokep_: Yeah, just did that.
17:50:04 <clokep_> qheaden: And I plan on testing it, yes. ;)
17:51:47 <qheaden> clokep_: How's this look http://pastebin.instantbird.com/250063
17:53:45 <clokep_> qheaden: Cannot you not do: 0x1c: YahooPacketHandler[0x18]?
17:54:06 <qheaden> clokep_: Will the "this" context remain the same?
17:54:17 * qheaden still has trouble understanding JavaScript context changes.
17:55:14 <clokep_> Umm...it should.
17:55:15 <qheaden> Nevermind. It will. YahooPacketHandler[0x18] just returns the method as a value, which is then called in onBinaryDataReceived with the correct "this".
17:55:20 <clokep_> Yes.
17:55:30 <clokep_> You should test it thouhg. ;)
17:56:49 <qheaden> clokep_: I still have to use function(). If I don't, I get YahooPacketHandler is undefined.
17:56:56 <qheaden> It needs to be returned lazily.
17:57:21 <clokep_> I don't know if I agree with that.
17:58:04 <qheaden> Basically do "0x1c: function() YahooPacketHandler[0x18]"
17:58:19 <qheaden> You can't reference YahooPacketHandler during its creation.
17:58:31 <clokep_> I understand what you're saying.
17:59:46 <clokep_> In that case, you probably need the call.
18:00:22 <qheaden> clokep_: Yeah. Just tested it and it doesn't seem to work without the call. :-/
18:01:00 <qheaden> Let me try one more thing.
18:03:51 <qheaden> clokep_: Yeah, I have to do the call.
18:04:15 <qheaden> Its still a major simplification over the last code though.
18:04:22 <clokep_> Yes, it is.
18:06:05 <Mook_as> time to mourn sharp variables again? :p
18:07:39 <clokep_> aleth: So did that drawing make any sense to you then?
18:08:02 <aleth> clokep_: Yes
18:08:39 <aleth> It's one of the possibilities he should consider, but as I suggested this morning, I think he still has to have a conversation with flo about his comments before deciding
18:09:14 * qheaden wonders what Mook_as means by sharp variables. 
18:09:17 <clokep_> Pretty much I have a feeling we should be mapping these different sources into a single interface (I don't really care that much who does the mapping) not having some interface that just includes lots of disparate data.
18:10:24 <aleth> I think you're right about that. When I suggested he differentiate the objects I didn't intend to imply he also had to differentiate the interfaces...
18:11:05 <Mook_as> qheaden: it's extremely dead, but https://developer.mozilla.org/en-US/docs/Web/JavaScript/Sharp_variables_in_JavaScript would have done what you wanted
18:11:06 <clokep_> I think you meant what I mean, you have a single interface, and different objects which know how to grab the info they need to fill in the interface for tha tinstance.
18:11:23 <aleth> Yes
18:12:10 <qheaden> clokep_: Would it be okay if I wait on changing the switch statements in YahooLoginHelper after I push this patch. Messing with it will delay me a bit, and I don't want to delay putting up a patch this week.
18:12:33 <qheaden> Its mainly an aesthetic change anyway.
18:12:37 <aleth> Unless the way the new tab uses the interface requires it, idk, I have not looked at that part of the code  yet
18:13:09 <clokep_> Mook_as: WTF. That's cool, but weird.
18:13:17 <Mook_as> and dead. mostly just dead.
18:13:36 <clokep_> qheaden: Yes, that would be fine. But note it in the bug why you haven't done it.
18:13:59 <qheaden> clokep_: Will do.
18:15:50 <aleth> clokep_: But in your drawing you have the additional suggestion of moving the creation of the instances to the various data sources. I'm not sure if that's the way to go or not, but it's an interesting idea for him to consider.
18:16:53 <clokep_> aleth: It has to be done for potential MUCs (i.e. LIST results).
18:18:15 <aleth> clokep_: Well, that's one way of doing it. What has to be considered is how all this is updated.
18:18:32 <aleth> And how he is going to store ranking data later, and save it.
18:18:43 * clokep_ wasn't so interested in that part. ;)
18:26:28 <qheaden> clokep_: I have go soon log out, but here's what I would like to do. I've implemented at least 90% of your feedback, so perhaps I could upload the patch, and you can check to see if you find any more issues with the code, and I will comment on what I haven't worked on.
18:28:03 <clokep_> qheaden: Sounds like a plan.
18:31:16 <qheaden> clokep_: Should I r? you or f? you?
18:34:46 <clokep_> qheaden: r? is fine.
18:34:56 <clokep_> As long as you understand it'll be an r-. ;)
18:36:46 <qheaden> :P
18:36:48 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2608 on bug 1982.
18:36:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
18:37:38 <aleth> Not much of a ? then ;)
18:41:22 <clokep_> qheaden: I'm going to just read the files I haven't for thi snext review, I hope that's OK.
18:41:31 <qheaden> clokep_: That's fine.
18:41:40 <qheaden> clokep_: I'm going to sign off now. I'll be back on later tonight.
18:42:45 <qheaden> Bye all.
18:42:50 * qheaden is now known as qheaden_away
18:46:33 <-- aleth has quit (Quit: Ciao)
19:12:00 <instantbot> clokep@gmail.com denied review for attachment 2608 on bug 1982.
19:12:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
19:34:13 <-- jb has quit (Ping timeout)
19:47:21 --> jb has joined #instantbird
20:40:39 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:51:54 <-- jb has quit (Ping timeout)
21:05:43 --> EionRobb has joined #instantbird
21:10:24 --> jb has joined #instantbird
21:15:12 <-- jb has quit (Connection reset by peer)
21:15:16 --> jb has joined #instantbird
21:25:56 --> EionRobb1 has joined #instantbird
21:26:38 --> atuljangra has joined #instantbird
21:27:00 <-- EionRobb has quit (Ping timeout)
21:28:32 <-- mconley has quit (Input/output error)
21:32:44 <atuljangra> Good Morning :D
21:33:27 <atuljangra> Today I'll be working on importing ui for filelink and then adding the ability for it to work on any server :)
21:34:05 --> clokep has joined #instantbird
21:34:05 * ChanServ sets mode +o clokep 
21:35:13 <douglaswth> good afternoon
21:36:25 <clokep> Hello douglaswth.
21:36:44 <douglaswth> actually, I was responding to: "2:32:44 PM - atuljangra: Good Morning :D"
21:37:06 <atuljangra> douglaswth: Good Afternoon :D
21:37:09 <atuljangra> Hi clokep :)
21:37:15 <douglaswth> the wonders of talking to people living in different time zones
21:37:25 <atuljangra> douglaswth ++
21:37:42 * clokep hates timezones. :P
21:38:08 <atuljangra> ;)
21:38:19 <-- jb has quit (Quit: jb)
21:38:24 --> jb has joined #instantbird
22:16:12 --> rosonline has joined #instantbird
22:17:13 <-- jb has quit (Ping timeout)
22:19:26 --> flo-retina has joined #instantbird
22:19:26 * ChanServ sets mode +qo flo-retina flo-retina 
22:27:22 --> dew has joined #instantbird
22:30:56 --> FireFly_TB has joined #instantbird
22:36:13 --> wnayes has joined #instantbird
22:46:00 <-- FireFly_TB has quit (Quit: FireFly_TB)
22:46:45 <atuljangra> privacy
22:46:51 <atuljangra> sorry, wrong window.
22:51:07 --> FireFly_TB has joined #instantbird
22:51:39 * wnayes is unsure how to proceed on the tooltip patch :-S
22:51:43 <-- FireFly_TB has quit (Quit: FireFly_TB)
22:52:05 * clokep pokes  flo-retina for wnayes.
22:52:59 <flo-retina> wnayes: next step is to ask a specific question about what's puzzling you ;)
22:53:43 <wnayes> I'm not sure what was decided about how the UI reacts to no buddy icon.
22:54:20 <wnayes> Whether the status icon is left showing or not.
22:57:34 <flo-retina> the status icon is still left showing
22:58:40 <flo-retina> (and I haven't seen anybody disagreeing with this btw; the disagreement between Mic on me was about whether to show a placeholder icon instead of the buddy icon, or hide the buddy icon when we don't have one)
22:59:52 <wnayes> flo-retina: OK, I'll just try to duplicate the current behavior for now.
23:00:41 <flo-retina> isn't this exactly what I suggested?
23:01:57 <wnayes> Yes :) but after discussing having\not having the placeholder it wasn't as clear.
23:02:24 <wnayes> Whether more thought should be put into the header design for this patch or not.
23:05:11 <flo-retina> nah, there will be follow up :)
23:05:44 <flo-retina> let's land soon something good and improve it later, rather than landing something better 'someday' :)
23:11:29 --> FireFly_TB has joined #instantbird
23:13:15 <clokep> :-D
23:17:21 <wnayes> Would having two protocol icons for MUCs be excessive (one showing where the buddy icon would be and the other in the upper right)?
23:18:15 <flo-retina> yes
23:19:36 <wnayes> OK. I think I'll have the existing one I have in the upper right remain.
23:20:45 <wnayes> Currently conversations show both, though usually farther away from each other :)
23:22:55 <flo-retina> where?
23:23:21 * flo-retina wonders if you could be saying this because the MUC and the IRC icons are very similar
23:24:56 <wnayes> I see it with IRC conversations.
23:25:16 <wnayes> I guess I was assuming MUC and IRC were interchangeable?
23:32:26 * clokep still hates our IRC icon.
23:37:41 <flo-retina> wnayes: if there are 2 bubbles in the icon it means "IRC". If there are 3 it means "multi-user chat"
23:47:04 --> clokep_ has joined #instantbird
23:48:13 <wnayes> Is there a reason why the mobile image is not provided for .statusTypeIcon? http://lxr.instantbird.org/instantbird/source/instantbird/themes/status.css
23:48:22 <clokep> wnayes: It's an overlay I believe.
23:52:09 <wnayes> OK, I'll be able to work around it but there won't be a mobile image in the tooltips then.
23:53:04 <clokep> Why not? :(
23:55:35 <-- clokep_ has quit (Quit: ZNC - http://znc.in)
23:56:06 <wnayes> clokep: I thought you gave a reason why it shouldn't be :P
23:56:21 <clokep> wnayes: No. :-S
23:56:59 <flo-retina> Is it currently in tooltips?
23:57:06 * flo-retina never sees the mobile icon
23:57:14 <clokep> flo-retina: Yes.
23:57:18 * clokep always sees the mobile icon. ;)
23:57:30 <flo-retina> maybe we should put it on gtalk when the most available resource is an android one?
23:59:04 <clokep> flo-retina: bug 972
23:59:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=972 nor, --, ---, nobody, NEW, Mark GTalk users on Android as "mobile"