#instantbird log on 07 16 2013

All times are UTC.

00:29:56 <-- rosonline has quit (Ping timeout)
00:32:34 --> dew has joined #instantbird
00:36:46 <clokep> qheaden: Newest commits look good. :)
00:50:34 <-- Mook_as has quit (Quit: Mook_as)
00:53:52 <-- chrisccoulson_ has quit (Quit: OSError: [Errno 130] Owner died)
01:03:40 <qheaden> clokep: Awesome.
01:46:18 <qheaden> clokep: Well, I think all of the major bugs are sorted and features implemented. I will test things more tomorrow, and I think I should be able to land tomorrow as well.
01:46:39 <clokep> qheaden: that assumes I have time to go through a few thousand line patch. ;)
01:46:58 <clokep> (And flo does too)
01:46:59 * qheaden doesn't think it is even 1,000 lines yet. :P
01:47:08 <clokep> Really? That's impressive. :)
01:47:43 <clokep> What was the deal with the StringView btw?
01:48:04 <qheaden> clokep: I didn't really do anything with it. I couldn't even find any use of it in Firefox's code.
01:48:10 <qheaden> They are probably still working on it.
01:48:24 <clokep> It isn't checked into Firefox. That's why the code was on that page.
01:49:39 <qheaden> Oh okay. I think the unicode converter is good enough for us right now.
01:49:49 <clokep> OK. :)
01:50:54 <qheaden> Amazingly, I found a bug where the buddies weren't removed from the list when the account was deleted. :-S
01:51:07 <qheaden> I fixed it in my last commit though.
01:51:08 <clokep> :) Nice.
01:51:14 * clokep checks his email.
01:51:38 <qheaden> I was still using for..each..in the buddy Map when I should have been using for..of
01:52:08 <clokep> "buddy[1].removeLocal();"?
01:53:10 <qheaden> clokep: Are you confused about the buddy[1], or the removeLocal()?
01:53:18 <clokep> buddy[1]. :)
01:53:25 <clokep> buddy[0] is the key, buddy[1] is the value?
01:53:30 <qheaden> Yeah.
01:53:35 <qheaden> _buddies is a Map.
01:53:36 <clokep> OK.
01:53:41 <clokep> Yeah that's what I thought.
01:53:45 <clokep> I couldn't remember exactly though.
01:54:03 <qheaden> That's where the bug came from. It never changed the for loop type when I changed buddies to a map.
01:54:24 <clokep> Good catch.
01:54:40 * qheaden doesn't delete his accounts obviously. :P
01:54:49 <clokep> So things to think about: logging and tests.
01:55:02 <qheaden> Yeah.
01:55:12 <clokep> What's reasonable to test?
01:55:15 <clokep> What's ridiculous?
01:55:18 <clokep> Where can we add tests?
01:55:24 <clokep> And where should we log? :)
01:55:40 <qheaden> clokep: Is it hard to test conversations and conferences?
01:56:04 <clokep> I'm not sure what you mean qheaden.
01:56:37 <qheaden> clokep: I'm wondering if there is a way we can test if the chat window successfully is shown with the correct chat message when someone sends you one.
01:56:43 <clokep> There is...
01:56:47 <clokep> I don't know how to do it though.
01:56:50 <clokep> I think it involves mozmill.
01:56:55 <qheaden> Oh okay.
01:56:57 <clokep> We should ask Florian tomorrow? :)
01:57:01 <qheaden> Sounds good.
01:57:11 <clokep> I'm really only familiar with xpcshell tests.
01:57:19 <clokep> There's like 4 or 5 test frame works in Mozilla.
01:57:26 <qheaden> Same here. I know xpcshell and reftests.
01:57:59 <clokep> reftests won't be helpful, I don't think.
01:58:01 --> rosonline has joined #instantbird
01:58:05 <qheaden> No.
02:04:39 <-- rosonline has quit (Client exited)
02:15:45 <-- wnayes has quit (Quit: wnayes)
02:16:40 <qheaden> clokep: Okay, I was wrong. Ran a code counter on the source, and the whole plug-in, including Makefiles and manifests, is 1,357 lines.
02:16:59 * clokep wonders how much libpurples Yahoo is.
02:18:23 * qheaden goes to run code analysis on it.
02:19:22 <qheaden> Oh yeah, about that single-line braces comment on my last commit, wouldn't it be a little weird to have the if statement with no braces, but the else statement with them?
02:19:37 <qheaden> I did it like that because that's the style they use in Firefox IIRC.
02:22:35 <qheaden> Wow, libpurple's Yahoo is a bit over 12,000 lines.
02:22:51 --> mconley has joined #instantbird
02:23:49 <clokep> No.
02:24:01 <clokep> If it's a single line it gets no braces.
02:24:02 <clokep> Period.
02:24:23 * clokep doesn't like exceptions. ;)
02:24:38 <clokep> qheaden: They also support file transfer, whiteboarding and voice / video. ;)
02:24:44 <clokep> So don't be too impressed with yourself yet. :-D
02:27:00 <clokep> (You may view that as a challenge, if you like. :))
02:27:24 <clokep> My IRC code actually ended up being more than libpurple's, I think. But it supported more features (and less features). :-S
02:29:35 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:37:21 <-- mconley has quit (Input/output error)
03:05:28 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
03:18:50 <instantbot> New Instantbird (UI) bug 2054 filed by connor.behan@gmail.com.
03:18:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Special treatment for today / yesterday should not hide logs
03:39:51 <-- dew has quit (Ping timeout)
03:40:13 --> dew has joined #instantbird
03:45:42 <-- dew has quit (Ping timeout)
03:46:14 --> dew has joined #instantbird
03:49:15 * qheaden is now known as qheaden_away
04:19:35 <-- Optimizer has quit (Ping timeout)
04:21:48 --> Optimizer has joined #instantbird
04:33:22 --> Mook has joined #instantbird
04:45:46 <-- Optimizer has quit (Ping timeout)
04:49:26 --> Optimizer has joined #instantbird
04:50:41 --> FireFly_TB has joined #instantbird
05:07:24 --> jb has joined #instantbird
05:40:00 --> nhnt11_phone has joined #instantbird
05:40:46 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
05:43:14 <-- jb has quit (Ping timeout)
06:00:06 <-- skeledrew has quit (Connection reset by peer)
06:00:07 --> skeledrew has joined #instantbird
06:02:31 <-- Optimizer has quit (Ping timeout)
06:19:09 <-- dew has quit (Ping timeout)
06:19:47 <-- qheaden_away has quit (Ping timeout)
06:20:22 --> dew has joined #instantbird
06:21:15 --> Optimizer has joined #instantbird
06:24:17 <-- dew has quit (Ping timeout)
06:25:06 --> dew has joined #instantbird
06:39:48 --> nhnt11_phone has joined #instantbird
06:52:00 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
07:01:02 <Mook> huh, did m.d.chat get a few days of backlog on nntp? I thought the issues were unidirectional nntp/google -> mailman...
07:05:22 --> jb has joined #instantbird
07:35:27 <-- jb has quit (Ping timeout)
07:39:18 --> jb has joined #instantbird
07:49:13 <-- Mook has quit (Quit: Mook)
07:50:34 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2603 on bug 2054.
07:50:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2054 nor, --, ---, nobody, UNCO, Special treatment for today / yesterday should not hide logs
07:54:12 <-- jb has quit (Quit: jb)
07:55:45 --> jb has joined #instantbird
08:03:44 --> nhnt11_phone has joined #instantbird
08:07:53 --> nhnt11|phone has joined #instantbird
08:07:54 <-- nhnt11_phone has quit (Connection reset by peer)
08:09:01 <-- jb has quit (Ping timeout)
08:16:50 --> flo-retina has joined #instantbird
08:16:51 * ChanServ sets mode +qo flo-retina flo-retina 
08:17:15 <flo-retina> http://log.bezut.info/instantbird/130716#m45 Anything that involes "mozmill in Instantbird" can get a quick r- ;).
08:17:20 <flo-retina> *involves
08:26:43 <-- nhnt11|phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
08:29:29 --> nhnt11_phone has joined #instantbird
08:30:41 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
08:31:30 <-- flo-retina has quit (Ping timeout)
08:35:34 --> flo-retina has joined #instantbird
08:35:34 * ChanServ sets mode +qo flo-retina flo-retina 
08:52:11 --> jb has joined #instantbird
08:55:20 <-- jb has quit (Quit: jb)
08:59:06 --> jb has joined #instantbird
09:00:26 --> jb1 has joined #instantbird
09:00:28 <-- jb has quit (Connection reset by peer)
09:02:42 <-- jb1 has quit (Connection reset by peer)
09:09:13 --> jb has joined #instantbird
09:09:31 <-- jb has quit (Input/output error)
09:09:36 --> jb has joined #instantbird
09:18:29 <flo-retina> uh, why is buildbot down? :(
09:19:50 --> nhnt11 has joined #instantbird
09:27:21 --> instant-buildbot has joined #instantbird
09:27:22 * ChanServ sets mode +v instant-buildbot 
09:28:53 <-- gerard-majax__ has quit (Ping timeout)
09:34:16 <flo-retina> Even: can we just restart buildbot in a loop if it's no longer running? ;)
09:34:36 <flo-retina> or just check at least once a day around 2am :)
09:46:22 --> aleth has joined #instantbird
09:46:22 * ChanServ sets mode +h aleth 
09:52:13 <-- nhnt11 has quit (Ping timeout)
09:58:42 --> nhnt11 has joined #instantbird
10:03:11 <aleth> nhnt11: Do you think it would be a good idea to upload a patch for the service asap to get some feedback or would you prefer to wait until you have added some MUC support?
10:03:41 --> Atuljangra has joined #instantbird
10:03:45 <nhnt11> aleth: I wanted to add conversations on hold support and submit a patch with that today.
10:03:56 <aleth> nhnt11: OK cool
10:04:24 --> clokep has joined #instantbird
10:04:24 * ChanServ sets mode +o clokep 
10:04:35 <aleth> That seems like a good way to include MUC items without including all the LIST stuff in the same patch :)
10:05:05 <nhnt11> Yeah
10:05:21 <nhnt11> I figured it would also add more value to the patch than simply moving existing stuff
10:05:59 <aleth> Are you going to differentiate between "switch to tab" and "restore from hold"? I think it boils down to the same thing from a user pov
10:06:30 <nhnt11> Yeah I guess it does.
10:07:22 <-- dew has quit (Ping timeout)
10:07:43 <aleth> So the way they are displayed in the awesometab could be the same for both too
10:09:21 <nhnt11> Right
10:09:29 --> dew has joined #instantbird
10:09:31 <nhnt11> I'll need to come up with a good string to describe both
10:09:41 <nhnt11> "Resume conversation" might be ok
10:09:47 <aleth> or just "switch to conversation"
10:09:53 <nhnt11> That would work too
10:09:57 <aleth> Similar to FX
10:10:42 <aleth> Maybe you can reuse the little tab icon from FX too.
10:10:57 <nhnt11> :)
10:14:27 --> chrisccoulson has joined #instantbird
10:20:48 --> gerard-majax__ has joined #instantbird
10:21:15 <flo-retina> nhnt11: including existing tabs in addition to "conversations on hold" seems great to me.
10:21:44 <flo-retina> I just almost wanted to start a private IRC conversation from "new tab" today with someone I already had an ongoing conversation with (but who isn't in my contact list).
10:21:58 <nhnt11> aleth, flo-retina: I think it makes sense to show these at the beginning of the list?
10:23:54 <flo-retina> nhnt11: no. If you already have 12 ongoing conversations, you are still likely to want to start a new one
10:24:05 <flo-retina> I would say having an existing conv shouldn't affect the ranking
10:24:11 <nhnt11> Ok.
10:24:32 <nhnt11> I guess keeping it at the top only makes sense for convs on hold
10:24:38 <nhnt11> not for "switch to tab" one
10:24:53 <flo-retina> It doesn't for convs on hold either from my point of view
10:24:59 <flo-retina> so I'm curious why you think it would be useful
10:25:08 <flo-retina> I currently have 10 IRC channels on hold.
10:25:13 <clokep> I really don't think a conv on hold should be treated any differently than switching to an open tab.
10:25:19 <nhnt11> Ah
10:25:21 <flo-retina> new tab shows 8 items.
10:25:27 <clokep> I have like >20 probably.
10:25:37 * nhnt11 has like one
10:42:33 <-- Atuljangra has quit (Ping timeout)
10:43:32 <clokep> flo-retina: Did you ever see that pastebin of the errors when updating to Moz22?
10:43:35 --> mpmc has joined #instantbird
10:43:47 <flo-retina> vaguely
10:43:55 <flo-retina> IIRC it looked painful and Windows only
10:44:05 <clokep> Really?
10:44:11 <clokep> It did not look Windows only to me.
10:44:13 <flo-retina> wasn't it failing in the generation of the .def file?
10:44:17 <clokep> But I'll try on Linux later.
10:44:21 <flo-retina> the .def file is a crazy Windows thing
10:44:29 <clokep> No, it was trying to link def files that were never created.
10:44:34 <flo-retina> s/Windows/MSVC/
10:44:59 <flo-retina> if it's related to def files, it's Windows only ;)
10:45:05 <clokep> OK.
10:45:15 <clokep> Where are those created?
10:45:43 <flo-retina> clokep: http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#229
10:46:19 <flo-retina> and http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#238 ensures the .def file is created before linking happens.
10:48:20 <instant-buildbot> build #903 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/903
10:49:11 <flo-retina> clokep: if things turn out to be way too painful to have dependencies between the Makefile and the moz.build stuff, an alternative solution (that I don't like much but would be a way out) would be to execute these few lines of shell script as part of the libpurple update progress
10:49:36 <clokep> flo-retina: OK.
10:49:43 <flo-retina> a downside is we would need to remember to rerun that update script ourselves each time we patch libpurple in a way that changes a symbol :(
10:49:54 <flo-retina> and we would likely forget, like we usually do for package-manifest changes ;)
10:50:12 <flo-retina> so that solution feels like another few busted Windows nightlies ahead ;)
10:51:34 --> Atuljangra has joined #instantbird
10:52:20 <flo-retina> clokep: all the build system magic we have to statically link libpurple and all its dependencies may require some tinkering after the moz.build conversion
10:52:34 <clokep> Yes. I'm trying to figure that out. :-D
10:59:00 <clokep> flo-retina: It's not failing to create the .def files, it can't find .lib file.
10:59:15 <clokep> (Well I can't promise it's creating the .def files, but the file it can't find is jabber.lib)
11:01:02 <-- jb has quit (Ping timeout)
11:01:45 <flo-retina> clokep: ah
11:01:54 <flo-retina> let's get js-xmpp by default then :-P
11:02:09 <clokep> Yeah that won't help, but I'd still like that.
11:02:16 <flo-retina> clokep: jabber is the first prpl in the list of statically linked libpurple prpl
11:02:30 <clokep> Yes, I know.
11:03:12 <clokep> Maybe my moz.build file is wrong...
11:03:13 <clokep> hmmm...
11:03:20 <flo-retina> so likely something broken in the way http://lxr.instantbird.org/instantbird/source/purple/libpurple/Makefile.in#59 got converted
11:03:22 <-- clokep has quit (Connection reset by peer)
11:03:39 * flo-retina wonders if this is confusing enough that he should offer to just look himself and fix it :-S
11:04:34 <flo-retina> I have no experience with moz.build stuff yet, so I'm afraid I currently can't give useful advice (I do know (or have known at some point) how the current system works though, so that may still give me an advantage :))
11:07:02 <nhnt11> If I want to change the path to my objdir, is it enough to replace all instances in autoconf.mk?
11:07:35 <nhnt11> oh and the main Makefile
11:07:53 <nhnt11> Ah, it appears the paths are defined in all makefiles...
11:08:02 * nhnt11 wonders what "unallmakefiles" does
11:10:22 <nhnt11> if I remove all makefiles from the objdir, will they be remade without triggering a full build?
11:11:35 * nhnt11 is thinking of just doing a fresh build
11:13:20 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:21:40 --> Mic has joined #instantbird
11:21:40 * ChanServ sets mode +h Mic 
11:22:10 <Mic> Hi
11:22:18 <Mic> Who's going to implement typing notifications for IRC? :)
11:28:18 --> nhnt11 has joined #instantbird
11:28:27 <flo-retina> nhnt11: changing the path of an objdir requires a full rebuild
11:28:40 <nhnt11> flo-retina: ok, thanks
11:28:41 <flo-retina> (or some tinkering that will take longer than a rebuild on your new macbook ;))
11:28:49 <nhnt11> that's what I figured :P
11:33:19 <aleth> flo-retina: Is there a difference on OSX between the background color of a selected richlistbox item (account manager etc) depending on whether the list has focus?
11:33:45 <nhnt11> aleth: Yes
11:33:56 <nhnt11> Oh wait
11:34:11 <aleth> Also, do you remember why IB uses Highlight rather than -moz-cellhighlight as the bgr colour for selected richlistitems?
11:34:15 <nhnt11> I thought you meant "whether the window has focus"
11:35:14 <nhnt11> aleth: Btw, I meant to tell you. It turns out I can use the tab key to cycle through tabs by flicking an option in my System Preferences.
11:35:37 <Mic> aleth: I'd expect -moz-cellhighlight to be used on tables or spreadsheets judging by its name.
11:35:44 <aleth> nhnt11: So that wasn't quite OS-specific after all :)
11:35:52 <aleth> Mic: It's the default for richlistboxes
11:35:58 <aleth> (and listboxes)
11:36:12 <Mic> Oh really, sounds weird by the way. Why would one call items in a list "cells"?
11:36:17 <nhnt11> It kind of is, because the option isn't very discoverable (imo) and the default value lets you select only textboxes and lists using the tab key
11:36:20 <aleth> I agree it sounds weird
11:36:39 <Mic> Did you check the CSS color table?
11:36:47 <nhnt11> (http://puu.sh/3Ec6S.png)
11:36:55 <aleth> Mic: only https://developer.mozilla.org/en-US/docs/Web/CSS/color_value
11:37:08 <Mic> Exactly, that's the one I meant.
11:39:14 <nhnt11> Is there an easy way to override the mozconfig file with my own?
11:39:30 <nhnt11> I don't want to edit it because it's a tracked file..
11:40:31 <nhnt11> Maybe I'll untrack it locally..
11:40:35 <aleth> Mic: If you use DOMi, is there a difference on Windows between Highlight and -moz-cellhighlight?
11:42:31 <Mic> hmm, I'd say yes. Let me check that I didn't do anything wrong.
11:44:20 <Mic> aleth: -moz-cellhighlight is grey while Highlight is blue for me.
11:44:39 <aleth> Mic: Interesting, thanks! Does it match this? http://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/richlistbox.css
11:45:17 <aleth> (i.e. the background is grey when the listbox doesn't have focus)
11:45:42 <Mic> Yes.
11:45:47 <nhnt11> Btw, does scrolling in the new conversation tab lag for you all when going through offline contacts? (i.e. when there are elements with transparency)
11:46:11 <Mic> That's exactly what I see on the account manager when (not) focusing it.
11:46:13 <aleth> nhnt11: No. And opacity shouldn't cause any problems
11:46:22 * Atuljangra is now known as atuljangra_away
11:46:27 <nhnt11> Hmm. It's choppy for me.
11:46:39 <Mic> nhnt11: get a new computer? :P
11:46:39 <aleth> Mic: Well, it's the IB-specific changes I'm trying to understand ;) http://lxr.instantbird.org/instantbird/source/instantbird/themes/richlistbox.css
11:47:04 <nhnt11> I thought it may be opacity because I remember an issue I had on android once where scrolling was choppy with 32bit transparency when the hardware only supported 16bit natively.
11:47:07 <nhnt11> Mic: :P
11:47:16 <aleth> nhnt11: But are you sure it's the opacity  that's the issue and not just the adding of contacts?
11:47:22 <nhnt11> aleth: Yes.
11:47:42 <nhnt11> When I scroll back up, as soon as there are only online contacts visible it's buttery again
11:47:50 <aleth> Strange. Can't help you there... maybe find the right person on #developers to ask about that
11:47:58 <nhnt11> Hmm.
11:48:04 <nhnt11> I'll make a note on my to-do list.
11:48:35 <Mic> I'd expect opacity to be hardware accelerated...
11:48:54 <aleth> If it was a SVG filter I'd be less surprised
11:49:08 <Mic> And even if it isn't your computer should be beefy enough to cope with that ;)
11:49:32 <nhnt11> Mic: That's what's bothering me. It was happening on my old computer too, but hasn't changed the slightest on this one.
11:49:46 <nhnt11> Well, maybe not "the slightest" but it's still choppy.
11:50:10 --> jb has joined #instantbird
11:50:16 * nhnt11 wonders if it's a Mac thing. Wasn't there a patch a while back that messed with some hw acceleration stuff?
11:50:20 --> clokep has joined #instantbird
11:50:21 <Mic> nhnt11: maybe check about:support?
11:50:39 <Mic> (for hardware acceleration)
11:50:52 <nhnt11> http://puu.sh/3Ecuu.png
11:50:57 <nhnt11> I'm not sure how to interpret that though
11:51:46 <Mic> You've only got a conversation window opened, didn't you?
11:52:09 <nhnt11> Uh, yes.
11:52:18 <Mic> Looks good then.
11:53:20 <clokep> flo-retina: Maybe, I didn't convert that part over though, just the PARALLEL_DIRS line.
11:54:31 <-- Optimizer has quit (Ping timeout)
11:56:02 <-- jb has quit (Quit: jb)
11:57:25 --> jb has joined #instantbird
12:07:51 <aleth> Mic: What's the bgr colour you see for a (keyboard-selected) item in the awesometab?
12:16:07 <-- jb has quit (Ping timeout)
12:16:53 --> novabyte has joined #instantbird
12:28:52 * nhnt11 finished merging stuff to the statsservice branch
12:29:23 <nhnt11> ugh, I need to find a better way to merge changes into this.
12:32:47 <Mic> aleth: the color for both active and inactive windows are the same as on the account manager.
12:33:07 <Mic> *color on
12:33:30 <aleth> Mic: Thanks
12:33:44 <Mic> The hovered item is always blue but that's going away anyways.
12:34:48 <aleth> Aha! Is that a patch that landed but because there were no nightlies...
12:35:04 <Mic> https://hg.instantbird.org/instantbird/ ;)
12:35:41 <aleth> Mic: Well exactly, it can be confusing to look at that when the nightlies don't reflect it yet ;)
12:35:48 <Mic> Bug 2051
12:35:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, ---, nobody, NEW, Styling of new conversation listbox
12:35:52 <Mic> Bug 2041
12:35:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, 1.5, nhnt11, RESO FIXED, "Enter" always opens conversation with first contact in the filtered list
12:36:20 <Mic> Its the latter bug, the first one was a typo.
12:36:27 <aleth> Right, now it makes sense :)
12:37:10 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:37:13 --> nhnt11 has joined #instantbird
12:49:34 --> jb has joined #instantbird
12:49:44 <-- atuljangra_away has quit (Ping timeout)
12:55:23 <-- jb has quit (Quit: jb)
12:55:59 <clokep> nhnt11: Did you see what mp mc was saying yesterday?
12:56:55 --> jb has joined #instantbird
12:58:27 <flo-retina> clokep: the PARALLELS_DIR line seems very related to building static prpls.
12:58:59 <clokep> flo-retina: Yes, duh. I'm saying that I didn't touch any of the stuff that builds the .lib files.
12:59:31 <clokep> But I'm wondering if I messed up whte PARALLEL_DIRS line and we're not building any of them, but still trying to link them.
12:59:35 <flo-retina> clokep: do you have to do the moz.build conversion everywhere? (ie. would the build break if you left the libpurple Makefile mostly untouched?
12:59:54 <clokep> You have to do the build conversion for all of a variable at once.
13:00:00 <clokep> (E.g. DIRS or PARALLEL_DIRS.)
13:00:05 <flo-retina> clokep: it could be that the order of looking a moz.build vs the Makefile isn't what we would like.
13:00:09 * flo-retina really doesn't know how this works
13:00:20 <flo-retina> really? :(
13:00:24 <flo-retina> that sounds stupidly painful
13:01:03 <nhnt11> clokep: I did, what are you talking about specifically?
13:01:17 * nhnt11 wonders if he missed something
13:02:10 <clokep> nhnt11: Just that he liked it and noticed that it was there. ;)
13:02:18 <nhnt11> Ah :)
13:02:42 <clokep> flo-retina: Yes, I don't like it much either. I had wondered about the order too, apparently moz.build files are converted to Makefiles (I guess combined w/ Makefile.in?) but I couldn't fully verify that. :)
13:03:32 <flo-retina> clokep: do you think investigating this is worth of your time, or should we just ignore it until I can find time to debug it myself?
13:04:28 <clokep> flo-retina: I have a couple ideas now at least. So I'll spend a bit more time on it first.
13:09:31 <aleth> flo-retina: Do you happen to remember why the selected item background colour in the account manager was chosen as -moz-dialog for Linux (rather than Highlight)? (I know it's a long shot, but there must have been a reason at the time...)
13:10:07 <aleth> Was it to match the selected blist items? But there we use -moz-dialog for all OS, I believe
13:15:20 --> Atuljangra has joined #instantbird
13:17:03 <-- Atuljangra has quit (Ping timeout)
13:17:37 <flo-retina> aleth: I think I copied the CSS of the Firefox download manager for each of the OSes.
13:19:47 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:19:49 --> flo-retina has joined #instantbird
13:19:50 * ChanServ sets mode +qo flo-retina flo-retina 
13:20:28 --> Atuljangra has joined #instantbird
13:21:57 * flo-retina has just updated his nightly to test the new tab changes checked in yesterday.
13:22:00 <flo-retina> Looks much better :)
13:22:53 * nhnt11 has been working on conversations on hold.
13:22:57 <nhnt11> Shouldn't take too long I think.
13:23:35 <nhnt11> I have a buidlFromChat method in PossibleConversation (it works), but it's currently not used.
13:23:37 <nhnt11> Can I leave it in?
13:23:42 <nhnt11> Or should I remove it for the patch?
13:23:44 <flo-retina> nhnt11: scrolling through offline contacts is also less smooth than scrolling through online contacts for me.
13:23:51 <flo-retina> I hadn't noticed before you mentioned it though :)
13:24:03 <nhnt11> Yeah, I'm going to fiddle with the CSS there later.
13:24:19 <flo-retina> nhnt11: I suspect what you really want there is to throw the gecko profiler at it
13:24:29 <flo-retina> and I haven't fully fixed it yet, so maybe don't bother now :-S
13:24:48 --> mconley has joined #instantbird
13:25:41 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:25:44 --> mpmc has joined #instantbird
13:25:59 <Mic> nhnt11: why would you remove it (or not use it)?
13:26:41 <nhnt11> Mic: Well I'm implementing another method for building from UI conversations
13:26:50 <nhnt11> So the FromChat one isn't used yet
13:26:58 <nhnt11> It will be needed when I implement the LIST stuff
13:27:37 <aleth> nhnt11: Just stick a TODO in there then ;)
13:27:38 <nhnt11> buildFromChat currently accepts the name of the chat, the topic, and the account (not any interface implementation)
13:27:42 <nhnt11> aleth: Ok!
13:28:10 <nhnt11> It's not /exactly/ a TODO though, because it works and doesn't need too much tweaking I think.
13:28:50 <aleth> nhnt11: Well, it could be "TODO: Call this for ..." ;)
13:28:55 <nhnt11> Ok :)
13:28:57 <Mic> Ah, I see. I just looked it up on Bitbucket.
13:29:22 <flo-retina> nhnt11: can't you stick it in a different patch if it's useful, but not yet?
13:29:40 <nhnt11> Ok, I'll remove it then.
13:29:42 <nhnt11> For the patch
13:29:48 <nhnt11> Mic: That code may be a bit old :(
13:30:00 <nhnt11> But yeah you should be able to get some context..
13:30:11 * flo-retina would really like tooktips on new tab items
13:30:27 <Mic> Isn't the name misleading if it's not building from a chat but building an item from the necessary details to create a chat?
13:30:29 <nhnt11> flo-retina: That's on my todo list. I've wanted it too :)
13:30:46 <nhnt11> Mic: Hmm possibly yeah
13:31:23 <nhnt11> I don't know if there's an interface to hold chats... I'll look into it later.
13:31:30 <aleth> BuildChatroom?
13:31:53 <aleth> Whatever, it seems too early to bikeshed about that :D
13:31:59 <nhnt11> Yeah :)
13:32:19 <flo-retina> nhnt11: if that function doesn't seem finished, you want it even less in a patch that could get checked in soon ;)
13:32:28 <nhnt11> Yeah ok
13:35:30 <nhnt11> Hmm, is it just me or is the mac gesture to cycle through tabs broken in the latest nightly? (two finger swipe left/right)
13:36:34 <nhnt11> By broken I mean, it's switching back and forth between the current tab and the previous tab instead of cycling
13:36:40 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:36:45 --> nhnt11 has joined #instantbird
13:38:16 <flo-retina> that's the intended behavior
13:38:33 <flo-retina> tab cycling is another gesture (with only 2 fingers)
13:39:09 <flo-retina> err wait, switching back and forth between current and previous tab is *3* finger swipe.
13:39:29 <flo-retina> with 2 fingers it's horizontal scrolling (which hopefully isn't needed on Instantbird)
13:39:42 <nhnt11> Weird...
13:39:57 <nhnt11> I wonder if it's something I did in BetterTouchTool..
13:40:06 <flo-retina> nhnt11: it's the twist gesture (same as for rotating an image on preview) that you need to cycle through tabs
13:40:30 <flo-retina> and it works for me in today's nightly
13:40:35 <nhnt11> flo-retina: But I've used two finger scrolling to cycle through them before
13:40:37 <nhnt11> :/
13:40:40 <flo-retina> (I didn't remember we even had it though, as I think Firefox got rid of it :))
13:40:40 <nhnt11> er, swipe*
13:41:04 <flo-retina> nhnt11: switching back and forth between the 2 most recently used tab is by far the gesture I find the most useful
13:41:07 <flo-retina> I do it all the time
13:41:24 <flo-retina> eg when switching back and forth between a private and a public conversation with more or less the same people for different topics
13:41:35 <flo-retina> or when switching between "official work" channel and the Instantbird one
13:41:50 <nhnt11> Yeah I use it to
13:42:39 <nhnt11> too *
13:43:13 <nhnt11> I wonder why it's working for me with 2 fingers though
13:43:19 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:43:23 --> nhnt11 has joined #instantbird
13:50:11 <nhnt11> Ok, so prplConversations have a buddy instead of a contact
13:50:38 <nhnt11> So I'm renaming imContact in PossibleConversation to "target" or imTarget or something
13:52:19 <flo-retina> seems confused/confusing
13:52:54 <flo-retina> I don't think prplIConversations have anything looking like a buddy. Did you mean prplIConvIM? And it's likely a prplIAccountBuddy rather than a buddy.
13:54:30 <nhnt11> Yes it's a imIAccountBuddy
13:55:25 <nhnt11> And yeah I'm talking about prplIConvIM sorry
13:55:51 <nhnt11> I followed the trail from imIConversation (which I believe is called a "ui conv" in code)
13:57:37 <flo-retina> yeah, UI conv as opposed to prpl conv
13:57:57 <flo-retina> nhnt11: there are plenty of different conversation objects in our code, so when talking about them it's useful to be very specific.
13:58:39 <nhnt11> flo-retina: Wait, am I right about ui convs being imIConversations?
13:58:44 <nhnt11> I'm still searching for proof for that
13:58:48 <flo-retina> yes
13:58:52 <nhnt11> ok
13:58:58 <nhnt11> So imIConversation extends prplIConversation
13:58:59 <flo-retina> errr
13:59:01 <flo-retina> wait
13:59:07 <flo-retina> ui conv could also be conversation.xml binding instances
13:59:14 <nhnt11> How would that be
13:59:21 <nhnt11> They're used to store convs on hold
13:59:28 <flo-retina> depends if you are looking in imWindows.jsm or imConversations.js I guess
13:59:39 * nhnt11 is more confused now
13:59:53 <flo-retina> ignore what I said then :)
14:09:13 <nhnt11> Actually I'm thinking of removing imContact altogether now. Don't really see the need for it to be a publicly available thing
14:13:33 <nhnt11> But then I would need to add a method to get tags
14:13:48 <nhnt11> I think I prefer keeping an imTarget or something
14:14:14 * flo-retina is confused by all this and would need to look at the code to make sense of this
14:14:37 <nhnt11> Er, I'm a bit confused too, so maybe I should sort this out before saying more here :]
14:17:05 * nhnt11 wonders if buddies can have tags too.
14:17:34 <clokep> nhnt11: Or put up some code. :P
14:17:43 <nhnt11> Looks like they can't..
14:18:41 <nhnt11> Er, they can have a /tag/ as opposed to /tags/
14:18:44 <nhnt11> clokep: Heh ok
14:18:50 <nhnt11> In a bit.
14:18:56 <flo-retina> nhnt11: each account buddy has *one* tag. buddies don't (but inherit the tags of each of their account buddies), and contacts can have as many tags as they want, even if they aren't inherited from any buddy
14:19:28 * nhnt11 forgot to mention he's talking about account buddies
14:20:18 <nhnt11> Oh wait, imIConversations have a contact attribute. It may be null though.
14:21:03 <flo-retina> "imIConversations" -> not the word you wanted
14:21:18 <nhnt11> :S
14:21:34 <nhnt11> UI conversations are imIConversations
14:21:46 <flo-retina> ah. Let's stop here :).
14:21:55 <nhnt11> :P
14:22:08 <clokep> My head hurts. :(
14:23:39 <nhnt11> I think I'll add a getTags method to PossibleConversation
14:25:57 <flo-retina> clokep: because of all these conversations?
14:26:23 <aleth> nhnt11: Why do you need all this in the first place?
14:26:32 <nhnt11> aleth: For conversations on hold
14:26:42 <aleth> They don't need tags imho. 
14:26:59 <nhnt11> Ok, but there still needs to be a way for consumers to know what they're working with
14:26:59 <clokep> flo-retina: Yes. :)
14:27:05 <nhnt11> I think I've decided on what I'm going to do finally
14:27:19 <flo-retina> what about writing "Switch to conversation" at the place where you usually display the tags? :)
14:27:39 <nhnt11> I'll have a "type" attribute on PossibleConversation, and have constants for each type (contact, chat, ui conv)
14:27:46 <flo-retina> that lets you keep the status information (which is likely useful even for already started conversations)
14:28:19 <nhnt11> Uh, but ui convs can be chats or contacts, nvm
14:28:29 <nhnt11> I guess an isUiConv in addition to isChat then
14:28:34 <nhnt11> flo-retina: That's what I plan to do
14:28:52 <aleth> nhnt11: isAlreadyOpen ;)
14:29:03 <nhnt11> Heh, ok
14:31:50 <clokep> :)
14:32:06 <clokep> So is the "Service" patch also include support for open conversations theN?
14:32:21 <nhnt11> yes
14:33:51 <flo-retina> uh, why is that the same patch? :(
14:34:12 <flo-retina> how many times a week do we need to remind that the shortest patches are the fastest to review? ;)
14:34:39 <nhnt11> flo-retina: It's not that big...
14:34:40 <nhnt11> but ok
14:34:57 <flo-retina> nhnt11: ok, maybe. I haven't seen that code at all
14:35:03 <aleth> I /think/ it's the same patch because it is hopefully clarifying the choice of the data structures so they can accept MUCs and contacts and convs on hold...
14:35:21 <aleth> Because I suspect there were some implicit assumptions there so far due to contacts-only
14:37:06 <nhnt11> Btw, would you like me to start attaching patches to bug 1583 now, or create new bugs for new features/additions and have 1583 as a kind of tracking bug?
14:37:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1583 enh, --, ---, nhnt11, ASSI, Awesometab (GSoC 2013)
14:40:07 <-- Mic has quit (Ping timeout)
14:44:48 <clokep> aleth: flo-retina ^
14:45:23 <nhnt11> I should've pinged myself, sorry.
14:45:55 <aleth> Use a new bug for this milestone and resolve bug 1583 at the end of gsoc?
14:45:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1583 enh, --, ---, nhnt11, ASSI, Awesometab (GSoC 2013)
14:46:06 <aleth> (or when you think the core functionality is complete)
14:46:08 <flo-retina> I think bug 1583 is kind of a tracking bug. But I would like if you could get it resolved at some point, so there needs to be what you consider a set of the minimal features for the tab to be awesome, and when you reach it you resolve that tracking bug as fixed :)
14:46:29 <nhnt11> ok :)
14:46:39 <nhnt11> I think we can decide that milestone when it arrives? :P
14:48:11 <flo-retina> nhnt11: I think that milestone is when you'll have effective ranking
14:48:15 <nhnt11> YEah
14:59:53 <nhnt11> Hmm I suppose I can rename all the "imContact"s to just "contact" now
15:10:30 <aleth> nhnt11: I don't think anyone is going to understand that until you upload a patch ;)
15:10:40 <nhnt11> Yes yes :P
15:10:45 <nhnt11> I've changed my mind
15:10:57 <nhnt11> Moving it to a service and adding conv-on-hold support should be separate patches :P
15:12:33 --> qheaden has joined #instantbird
15:12:50 <qheaden> Hello everyone.
15:12:51 <nhnt11> Aaaah. I forgot to commit my merge :'(
15:12:55 <nhnt11> Hi qheaden
15:14:40 <qheaden> clokep, flo-retina: I'm 100% sure I can land a patch for review today.
15:14:58 <aleth> qheaden: :)
15:15:08 * aleth expects it will be huge...
15:15:13 <flo-retina> "land" is usually when it's reviewed and checked in ;)
15:15:26 <flo-retina> qheaden: "put on bugzilla for review" is 'attach' ;)
15:15:28 <aleth> It will land in your inbox :P
15:15:57 <qheaden> No, you will land this now!!! :)
15:16:00 <flo-retina> aleth: only the review request will land in my email box, and not even the inbox ;)
15:16:25 <flo-retina> qheaden: we can have a /dev/null repository to land stuff immediately if you think that would save time ;)
15:16:37 <qheaden> Ha ha
15:17:08 <nhnt11> :P
15:17:57 <aleth> to be fair, I guess it's mostly already been reviewed once by clokep ;)
15:19:57 <clokep> A few times in fact.
15:20:04 <clokep> But I need to review it wholesale.
15:20:09 <clokep> And would like others to take a look as well.
15:20:18 <nhnt11> UIConversations have ids!
15:20:21 <nhnt11> excellent :D
15:24:06 <-- jb has quit (Ping timeout)
15:25:30 --> jb has joined #instantbird
15:25:47 <-- jb has quit (Input/output error)
15:25:55 --> jb has joined #instantbird
15:26:14 <nhnt11> flo-retina: I'm asking as a shortcut, do you know if conversations and contacts are guaranteed to have different IDs?
15:26:27 <nhnt11> I mean, can a contact and a prplIConversation have the same ID?
15:26:39 <flo-retina> nhnt11: they can
15:26:45 <nhnt11> Thanks.
15:26:50 <flo-retina> both are numbered starting at id 1, and incremented for each new instance
15:26:53 <nhnt11> ok
15:27:06 <aleth> qheaden: |for (let buddy of this._buddies) buddy[1].setStatus(...);| why do you need the [1]?
15:31:46 <aleth> Adding a contact is so cumbersome without the context menu, now I got used to it
15:31:53 <qheaden> aleth: Its because in a for..of loop with a Map, the [0] value is the key and the [1] value is the actual value.
15:32:07 <aleth> qheaden: this._buddies is a Map, but is buddy a Map?
15:32:36 <aleth> for...of iterates over values, not keys
15:33:20 <qheaden> aleth: Well, it iterates over both when using a Map. this._buddies is as Map, and buddy is a two element array.
15:33:36 <qheaden> That is given by the for..of loop.
15:33:51 <aleth> Oh, buddy is itself an array? OK then :)
15:33:52 --> jb1 has joined #instantbird
15:33:59 <qheaden> Don't know why it is that way, but it is. Maybe flo-retina or clokep can give more insight.
15:34:41 <flo-retina> I don't know which code you are talking about
15:35:14 <-- jb has quit (Ping timeout)
15:35:22 <flo-retina> aleth: what's blocking that context menu patch? Is it just a review from me, or did I r- the latest version?
15:35:30 <-- jb1 has quit (Ping timeout)
15:36:01 --> jb has joined #instantbird
15:36:02 <clokep> qheaden: What? Didn't you write that code?
15:36:05 <aleth> flo-retina: It's waiting for review, & it may need another cycle depending on what you think
15:36:07 <-- gerard-majax__ has quit (Ping timeout)
15:36:15 <clokep> I don't know why buddy is a two element array, that's custom code to each prpl.
15:36:58 <qheaden> clokep: I don't know why either. The stored buddy objects are normal, and modified. It has to do with Map iteration apparently.
15:37:29 <flo-retina> aleth: ok.
15:37:30 <qheaden> *and unmodified
15:37:45 <clokep> qheaden: Yes, I think it's how iterating over a Map works.
15:37:47 <clokep> aleth: ^
15:38:16 * nhnt11 has reached a stage where he can test his code
15:38:22 <flo-retina> cool
15:38:26 <-- jb has quit (Ping timeout)
15:40:08 <clokep> qheaden: I did ask for a comment though, I think.
15:42:29 <aleth> qheaden: Oh, I see. Personally I think that's a bug in the Map implementation :-S
15:42:52 <aleth> I should check the specs though
15:42:54 --> Optimizer has joined #instantbird
15:42:55 <clokep> aleth: qheaden It might be worth checking the spec / asking one of the JS guys.
15:45:18 --> nhnt11-test has joined #instantbird
15:45:53 <-- nhnt11-test has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
15:50:17 <aleth> clokep, qheaden: It indeed appears to be in the spec: "Object.defineProperty(Map.prototype, "iterator", {configurable: true, writable: true, value: Map.prototype.items});"
15:50:54 <aleth> Where items yields two-element arrays.
15:51:31 <aleth> My guess is this is because for...in is property enumeration, which is not the same as key enumeration for Sets and Maps.
15:52:07 <aleth> So for...of includes the keys.
15:54:32 <aleth> The odd thing is that for...in actually returns nothing for a standard Set or Map.
15:54:35 <nhnt11> It works \o/
15:54:35 <aleth> Learn something new every day ;)
15:54:44 <nhnt11> (IRC channels on hold)
15:55:09 --> nhnt11-test has joined #instantbird
15:55:39 <nhnt11> http://puu.sh/3EjSs.png
15:56:12 <-- nhnt11-test has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
15:56:45 <aleth> nhnt11: Looks like progress :)
15:57:51 <nhnt11> brb
16:00:54 --> jb has joined #instantbird
16:06:10 <nhnt11> re
16:06:35 <nhnt11> aleth, flo-retina: Does it make sense to set the "status" for MUCs to the same as the status for the account?
16:06:57 <aleth> nhnt11: No
16:07:30 <nhnt11> aleth: I don't mean in general. I mean to decide whether or not to gray it out
16:07:45 <aleth> Just hide the whole icon, it doesn't make sense for MUCs
16:07:57 <nhnt11> Not just the indicator dot.
16:08:05 <nhnt11> (For that, I can use the MUC icon if needed)
16:08:16 <aleth> We are talking about the big icon on the left?
16:08:22 <nhnt11> No
16:08:31 <nhnt11> In the newtab, offline contacts are greyed out
16:08:50 <nhnt11> So I'm wondering how to decide how to do this for MUCs
16:09:04 <nhnt11> I think the status of the account would work.
16:09:16 <aleth> You mean for MUCs on hold when the account is offline?
16:09:17 <nhnt11> Hmm but can a chat be on hold after leaving it?
16:09:20 <nhnt11> Yes.
16:09:40 <nhnt11> ah it can
16:09:52 <aleth> You could do what we do in the buddy list and add a small status indicator to the MUC icon on the right
16:09:53 <nhnt11> Then I need to find out how conv.xml does that. cool.
16:11:02 <flo-retina> nhnt11: grey it out for MUC if the "left" attribute is "true"
16:11:11 <nhnt11> flo-retina: Just saw that :)
16:11:53 <aleth> nhnt11: http://lxr.instantbird.org/instantbird/source/instantbird/content/conv.xml#93
16:12:07 <nhnt11> aleth: I'm there already, thanks :)
16:12:42 <aleth> nhnt11: But flo is right, it makes sense to add the offline opacity too, as you do for contacts.
16:13:01 <nhnt11> I do want to do that, yes.
16:13:02 <aleth> In fact then you can save yourself the little status dot I guess.
16:13:09 <nhnt11> Yeah
16:13:29 * aleth likes it when things get simpler when you think about them more ;)
16:14:51 <nhnt11> :)
16:28:25 * qheaden is about to take the plunge.
16:28:41 <instantbot> qheaden@phaseshiftsoftware.com requested review from clokep@gmail.com for attachment 2604 on bug 1982.
16:28:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
16:43:20 <-- Atuljangra has quit (Ping timeout)
16:43:46 * clokep takes a look at qheaden's patch.
16:44:08 * qheaden starts to to feel nervous and sweats.
16:44:21 --> Mook_as has joined #instantbird
16:47:32 <clokep> flo-retina: aleth Do we do function() { or function()\n{?
16:47:53 <flo-retina> clokep: that may not be fully consistent across our code base
16:49:00 * nhnt11 has seen both
16:50:19 <clokep> Hmm....I didn't include the ArrayBufferUtils test in instantbird/test/xpcshell.ini, what does that mean flo-retina ? :-S
16:50:54 <flo-retina> I would say "that it's not called"
16:51:07 <flo-retina> but I saw them being called when I tested on my debug build yesterday
16:51:18 <flo-retina> isn't the xpcshell.ini file deprecated and no longer used anyway?
16:51:35 <flo-retina> or do we only need to list there the folders where we have tests?
16:52:02 <nhnt11> aleth, flo-retina: What should I do for the buddy icon for MUCs?
16:52:30 <flo-retina> a large version of the MUC icon would be nice
16:52:34 <flo-retina> but I don't think we have one around
16:52:44 <flo-retina> I likely have the SVG file somewhere though
16:52:48 <nhnt11> Shall I just leave it as the normal user icon for now then?
16:53:01 <clokep> flo-retina: Should we have all these SVGs in the repo?
16:53:06 <nhnt11> clokep: ++
16:53:13 <flo-retina> clokep: no.
16:53:24 <flo-retina> clokep: but the plan was to create a separate hg repo for all the artwork
16:53:37 <flo-retina> I'm afraid it never actually happened :(
16:53:44 <nhnt11> flo-retina: Do all the images have SVG versions?
16:53:45 <aleth> nhnt11, flo-retina: I think it would be better to have no icon at all.
16:53:54 <flo-retina> nhnt11: not all. but most do.
16:54:02 <aleth> This is a better way to differentiate visually from contacts.
16:54:05 <nhnt11> aleth: That's interesting.
16:54:06 <flo-retina> aleth: what would you do for the aligment?
16:54:19 <flo-retina> keeping an empty area would just look broken
16:54:21 <nhnt11> Yeah it would look... interesting
16:54:22 <aleth> flo-retina: That's the point, align with the left border.
16:54:35 <nhnt11> Especially since it's not guaranteed that all MUCs will be grouped
16:54:36 <flo-retina> no :)
16:54:54 <aleth> I think it's worth trying out to see how it looks.
16:54:58 <flo-retina> vertical alignment of the text the user needs to read is important.
16:56:55 <nhnt11> flo-retina: If you can find that SVG, I guess I could make a new icon. Another option would be to take the current user icon, and add more silhouettes behind it (I'd say two more)
16:57:25 <aleth> I think having an icon there just to fill the space is bad.
16:57:42 <clokep> I agree, but I also think aligning the text is important.
16:57:44 <clokep> It's jarring otherwise.
16:59:55 <aleth> "take the current user icon, and add more silhouettes behind it (I'd say two more)" is not a good idea as we already have a MUC icon, so it would be confusing
17:00:20 <nhnt11> ok
17:00:42 <clokep> qheaden: So what is cleanUsername again?
17:00:53 <qheaden> clokep: It strips @yahoo.com from the username.
17:00:54 <clokep> Is it just with @yahoo.com stripped?
17:00:57 <clokep> OK.
17:00:58 <qheaden> Yeah.
17:01:04 <-- novabyte has quit (Quit: bye bye)
17:01:05 <clokep> We do use both that and the normal username in the code, right?
17:01:14 <qheaden> Yeah.
17:01:35 <-- mconley has quit (Connection reset by peer)
17:01:37 <qheaden> OH!! I just thought of something. I'm sure I need to also check for and strip @yahoo.co.jp
17:01:52 --> mconley has joined #instantbird
17:03:09 <clokep> You should check that. :)
17:03:37 <qheaden> clokep: How is the patch looking so far?
17:07:54 <-- jb has quit (Ping timeout)
17:08:32 <aleth> It's a shame we don't have network icons yet or we could use those at least...
17:09:03 <-- dew has quit (Ping timeout)
17:09:23 <clokep> qheaden: A bunch of comments. :)
17:09:43 <clokep> aleth: I don't even have like a concept of how to do htat. :9
17:09:44 <qheaden> :P
17:11:51 <aleth> clokep: Nor do I, but it's something I wanted to think about at one point :-S
17:18:09 <qheaden> I'll be back in a bit.
17:18:12 * qheaden is now known as qheaden_away
17:21:41 <clokep> aleth: I'd be willing to brainstorm it at some point. ;)
17:21:48 <clokep> qheaden_away: I might have to do this review in bits and pieces.
17:22:50 <clokep> Hmm...we should probably include the new Http.jsm instead of the old http.jsm and patch our chat/ code to use that...
17:27:35 * nhnt11 wonders if either aleth or flo-retina is available to quickly look through this code so that he can address obvious nits and stuff before he has to go.
17:27:56 <flo-retina> I'll likely go offline very soon
17:38:03 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:42:59 <aleth> nhnt11: I can take a brief look now
17:43:40 <nhnt11> aleth: Yay. I'm fixing a small bug, after that I'll pastebin this for you :)
17:44:44 <aleth> I won't have time for a thorough review...
17:44:54 <nhnt11> No problem.
17:51:35 <nhnt11> Er, this is taking longer than I expected, sorry
17:52:21 * clokep would like aleth to take a look at the Yahoo stuff as his leiusre.
17:54:18 <nhnt11> ah,found it. what a pesky bug.
17:54:57 <nhnt11> (I forgot to add |delete this._uiConvsById[aId];| )
17:56:02 --> nhnt12 has joined #instantbird
17:56:43 <-- nhnt11 has quit (Ping timeout)
17:59:56 * nhnt12 is now known as nhnt11
18:00:09 --> nhnt11-test has joined #instantbird
18:00:17 <instantbot> clokep@gmail.com denied review for attachment 2604 on bug 1982.
18:00:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
18:00:45 <-- nhnt11-test has left #instantbird ()
18:01:02 <clokep> qheaden_away: I skipped a few files.
18:01:05 <aleth> clokep: Sure, but probably not tonight :-/
18:01:16 --> jb has joined #instantbird
18:01:34 <clokep> aleth: No rush. :)
18:01:52 <aleth> A CC license on tests, is that standard?
18:02:59 <clokep> We usually do public domain, i think.
18:03:17 <aleth> Why not, I guess.
18:03:24 <nhnt11> aleth: http://pastebin.instantbird.com/247977
18:03:26 <clokep> Yes, that's standard.
18:03:30 <nhnt11> I underestimated the size of that, sorry
18:03:37 <nhnt11> If you don't have time now, I understand.
18:04:09 <clokep> nhnt11: So does this include MUCs or no? :P
18:04:15 <nhnt11> clokep: If you could look at that for nits, that would be cool too :)
18:04:20 <nhnt11> clokep: It supports any type of conversation on hold
18:04:43 <nhnt11> (Though it doesn't support existing tabs which /aren't/ on hold... didn't think of that)
18:05:18 <aleth> ^^ this morning is a long time ago ;)
18:05:21 * nhnt11 thinks clokep could look at that for more than nits, since it doesn't touch too much UI :P
18:05:44 <aleth> The indentation in the makefile changes seems wrong
18:05:49 <clokep> I agree.
18:05:57 <clokep> nhnt11: I can most likely look, but I'd prefer it attached to a bug.
18:06:01 <nhnt11> The XPIDLSRCS? I just saw that, oops!
18:06:07 <nhnt11> Ok! I'll request feedback.
18:06:13 <clokep> Also, what's the MODULE definition?
18:06:45 <aleth> nhnt11: If you support convs on hold, you should support tabs too, as we discussed this morning, before landing
18:06:46 <nhnt11> I'll tell you in a second
18:06:49 <nhnt11> I don't remember exactly
18:06:57 <nhnt11> aleth: Yeah, that's why I said request feedback :P
18:07:16 <aleth> Right :D
18:07:43 <aleth> All those vars at the top of the prototype need comments.
18:07:58 <nhnt11> Yes, I plan to add in comments before requesting review :)
18:08:01 <nhnt11> Maybe I should just do that now though
18:08:25 <aleth> contactConvsById isn't a great name
18:08:52 <nhnt11> I can't find why that MODULE is required.I remember that it was needed for something though. likely something to do with packaging.
18:08:57 <aleth> Does that mean conversations with contacts, as opposed to MUCs?
18:09:31 <nhnt11> aleth: It refers to PossibleConversations built from imIContacts
18:09:59 <nhnt11> So yeah, I guess you could say "as opposed to MUCs"
18:10:21 <nhnt11> But non-MUCs built from imIConversation instances aren't in that either.
18:10:27 <aleth> It would be nice to remove the number of *conv*'s if possible
18:10:34 <nhnt11> Hmm
18:11:28 <aleth> We have so many conversation objects already...
18:11:29 <nhnt11> aleth: I'm going to request feedback on an attachment in a second, if you'd like to comment there.
18:11:29 <aleth> Maybe if instead of PossibleConversation you call it something more generic?
18:11:44 <nhnt11> Hmm. i think flo suggested that name.
18:13:12 <aleth> nhnt11: Not certain about this, but I'm thinking along the lines of _addContact instead of _addContactConv etc.
18:13:45 <nhnt11> aleth: It was originally called that, but I added the "Conv" at the end to make it consistent. I don't know which is better though.
18:14:00 <aleth> I guess I should look at the whole thing first.
18:15:05 <aleth> It's just that it would be nice if when conv occurs it referred to the existing conversation objects and the awesometab used something else for its listitems for differentiation.
18:15:44 <instantbot> New Instantbird (UI) bug 2055 filed by nhnt11@gmail.com.
18:15:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nobody, NEW, New conversation tab needs to display open conversations and those on hold.
18:15:53 <nhnt11> aleth: I agree
18:15:54 <aleth> Maybe something like "entries" for the awesometab?
18:15:57 <nhnt11> I guess it needs more discussion
18:16:01 <nhnt11> Hmm, interesting
18:16:03 <aleth> Or items?
18:16:54 <aleth> They are obviously possible conversations, but they aren't in general conversations, yet.
18:18:04 <nhnt11> Yeah
18:18:06 <nhnt11> True
18:18:07 <instantbot> nhnt11@gmail.com requested feedback from clokep@gmail.com for attachment 2605 on bug 2055.
18:18:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
18:18:15 <nhnt11> Targets maybe?
18:18:20 <nhnt11> ConvTarget?
18:18:28 <nhnt11> ConversationTarget?
18:18:36 * nhnt11 can't seem to get rid of "conv"
18:18:49 <aleth> No, targets are generally something else.
18:19:11 <nhnt11> aleth, flo-retina, Mic: I've requested feedback from you all too on that attachment ^
18:19:13 <nhnt11> Hmm
18:21:11 <nhnt11> Btw, I need to change all the "filteredContacts" in newtab.xml to "filteredConvs" (as per the current naming convention)
18:21:33 <aleth> Is Services.contacts.getContacts() fast enough to not need to return its data in chunks?
18:22:22 <nhnt11> Yeah it's fast
18:22:53 <nhnt11> (it was near instant on my old laptop with ~1k contacts)
18:23:59 <nhnt11> Hmm, I need to get rid of _firstInitConditionDone, it's no longer used.
18:24:43 * nhnt11 thinks he made decent progress today
18:32:35 <nhnt11> I need to go to bed now. See you all tomorrow.
18:32:36 <nhnt11> Good night
18:33:14 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:34:19 <-- mconley has quit (Connection reset by peer)
18:34:53 * qheaden_away is now known as qheaden
18:34:58 <qheaden> clokep: I see your review.
18:45:49 --> unghost has joined #instantbird
18:45:55 <qheaden> clokep: What did you mean when you said we don't need yahoo.jsm anymore because both protocols are in yahoo.js? yahoo.jsm is where all of the logic takes place.
18:54:41 <instantbot> aleth@instantbird.org granted feedback for attachment 2605 on bug 2055.
18:54:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
18:58:47 <clokep> qheaden: It doesn't need to be a separate file..
18:59:40 <qheaden> clokep: Okay, so should I move the content of yahoo.jsm on the top of what is already in yahoo.js, or on the bottom?
19:00:20 <clokep> qheaden: Above.
19:00:27 <qheaden> OK.
19:00:40 <clokep> The way it was before we split it.
19:01:53 <-- aleth has quit (Quit: Ciao)
19:15:28 <-- jb has quit (Quit: jb)
19:17:51 <instantbot> clokep@gmail.com granted feedback for attachment 2605 on bug 2055.
19:17:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
19:20:12 --> Mic has joined #instantbird
19:20:12 * ChanServ sets mode +h Mic 
19:30:39 <clokep> Mic: feel free to look at the Yahoo stuff too.
19:32:03 <Mic> OK, you mean now that I've had a look at array buffers and these things already I could put this new knowledge to use? ;)
19:32:55 <clokep> And that you understand sockets. :P
19:37:00 * clokep really just wants lots of eyes on the code. :)
19:38:46 <Mook_as> print it out, wrap it around cans of beer, and give it out on the street? :p
19:39:12 <clokep> I don't know what you Canadians are allowed to do, but I don't think that would go over well here.
19:40:34 <Mic> Maybe wrap it around Club-Mate bottles? That might increase the amount of programmer eyes on it? (At least in Germany/Europe maybe?;)
20:11:45 <-- FireFly_TB has quit (Ping timeout)
20:16:04 --> FireFly_TB has joined #instantbird
20:22:22 <qheaden> clokep: I'm not going to be able to stay on as long as I wanted today. I'm going to have to leave now, but I was examining the feedback you gave me on the patch.
20:22:33 <qheaden> Hopefully I'll be able to do some work on it more tonight.
20:23:00 <clokep> qheaden: That'd be great, I'd love to get this in by the end of the week.
20:23:20 <qheaden> clokep: I think we can manage that. :)
20:24:15 <qheaden> I have to go now. Bye everyone.
20:24:16 <clokep> I'll try to review the rest today
20:24:26 <qheaden> clokep: Thanks for the help and reviews. :)
20:25:02 * qheaden is now known as qheaden_away
20:49:41 --> flo-retina has joined #instantbird
20:49:41 * ChanServ sets mode +qo flo-retina flo-retina 
20:50:15 <flo-retina> Good evening :)
20:52:50 * flo-retina isn't sure what "network icons" meant in http://log.bezut.info/instantbird/today#m670
20:53:00 <flo-retina> uh, http://log.bezut.info/instantbird/130716#m670
20:53:12 <flo-retina> Mic: apparently Not Today dislikes /me messages
20:54:19 <Mic> flo-retina: thanks for letting me know.
20:56:05 --> nhnt11 has joined #instantbird
20:56:17 <nhnt11> New conversation tab seems a bit broken on windows :(
20:56:27 <nhnt11> Highlight on hover doesn't seem to be working at all
20:56:40 <clokep> flo-retina: E.g. What you asked about the other day, using the Mozilla dinosaur icon for moznet.
21:00:46 <flo-retina> ah, http://log.bezut.info/instantbird/130716#m796 Mook is never out of useful suggestions! :)
21:01:40 <nhnt11> Mic: You don't use aero right? does highlight on hover work for you?
21:02:51 <Mic> nhnt11: highlighting on hover works.
21:03:16 <Mic> I don't know about the new select on mouseover as there was no nightly build today.
21:03:29 <nhnt11> I'm on the latest nightly and it's not working here
21:03:34 <nhnt11> clokep: Does it work for you?
21:04:55 <nhnt11> The margins and the font size for display names looks wrong too 
21:05:09 <flo-retina> clokep: aaaaah! Mozilla icons :)
21:05:51 <flo-retina> nhnt11: the latest nightly only exists on Mac. Buildbot was down this night, and only the mac builder was still online when we restarted buildbot.
21:06:06 <nhnt11> flo-retina: I meant the latest windows nightly ;)
21:06:08 <clokep> nhnt11: Not on a nightly right now.
21:06:13 <nhnt11> (I'm on windows right now)
21:06:22 <clokep> flo-retina: Yes, that would be exciting, right? :)
21:06:29 <flo-retina> nhnt11: the latest windows nightly doesn't have you recent improvements that landed yesterday
21:06:38 <flo-retina> clokep: kinda :)
21:06:41 <nhnt11> But highlight on hover should still be working.
21:07:03 <flo-retina> if nhnt11 is bored at some point, I would like if the theming of the "+" button could be fixed relatively soon.
21:07:18 <nhnt11> Tomorrow :(
21:07:20 <flo-retina> this seems like a perfect thing to spend time one while waiting for feedback on other patches
21:07:38 * nhnt11 needs to reboot to Mac
21:07:40 <flo-retina> nhnt11: I didn't mean to imply you should work on it now.
21:07:54 <flo-retina> "relatively soon" meant more like "this week" ;)
21:08:09 <nhnt11> Heh, it shouldn't take that long
21:08:28 <flo-retina> I don't expect it to take more than an hour or two.
21:09:04 * nhnt11 expected it to take 10 minutes maybe
21:09:06 <nhnt11> :O
21:09:35 <nhnt11> Ah but considering windows and linux need to be fixed as well..
21:10:04 <nhnt11> Windows seems more broken than OS X (the + button)
21:10:44 <flo-retina> nhnt11: you need Windows, Windows Aero, Linux, OS X, OS X retina, and you have the "+" button for non-overflow and for over-flow cases, with the normal, hover, and active states.
21:11:00 <flo-retina> nhnt11: I guess that's way more cases than you would expect at first ;)
21:11:25 <nhnt11> But a simple line of css should fix nearly all of the Mac cases
21:11:34 <flo-retina> nhnt11: and I know how much work changing *one* icon on Firefox was for me today (and it's not even finished!)
21:11:47 <nhnt11> (Except retina, do we need that right now? I think we should add all the retina icons at once)
21:11:51 <flo-retina> (well, actually 3 icons for Mac retina only, but it then turned out we wanted to improve them for all OSes)
21:11:59 <nhnt11> Hmm
21:12:35 <flo-retina> nhnt11: we don't have "all the retina icons", so that will never happen. I think we should just start adding the icons we can, when it's easy. If you are looking up the current Firefox rules, you can as well copy paste both the retina and non retina lines.
21:12:45 <nhnt11> Ok!
21:12:54 * nhnt11 needs to go now
21:12:59 <nhnt11> Good night (again)
21:13:01 <flo-retina> nhnt11: Good night!
21:13:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:34:33 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:45:06 --> rosonline has joined #instantbird
21:46:03 <-- rosonline has quit (Client exited)
21:46:08 --> rosonline has joined #instantbird
21:57:24 <-- Mic has quit (Ping timeout)
21:59:22 <-- clokep has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:24:55 --> EionRobb has joined #instantbird
22:33:59 <instantbot> florian@instantbird.org denied feedback for attachment 2605 on bug 2055.
22:34:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2055 enh, --, ---, nhnt11, ASSI, New conversation tab needs to display open conversations and those on hold.
22:36:33 --> wnayes has joined #instantbird
22:46:43 --> clokep has joined #instantbird
22:46:43 * ChanServ sets mode +o clokep 
23:03:16 <-- flo-retina has quit (Ping timeout)
23:10:37 --> flo-retina has joined #instantbird
23:10:37 * ChanServ sets mode +qo flo-retina flo-retina 
23:10:55 <-- FireFly_TB has quit (Quit: FireFly_TB)
23:14:31 <-- EionRobb has quit (Quit: Leaving.)
23:31:53 --> EionRobb has joined #instantbird
23:33:33 <-- rosonline has quit (Client exited)
23:59:53 <-- EionRobb has quit (Connection reset by peer)