#instantbird log on 07 14 2013

All times are UTC.

00:02:18 <wnayes> flo, Mic: http://i.imgur.com/FnAJAt3.png
00:03:12 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
00:03:16 <wnayes> I maybe didn't mention that it only looks odd with status messages as there is usually a user icon pushing everything over.
00:04:29 <wnayes> For some reason it runs right into the table when there's a user icon, but wrapping a irc channel topic with no user icon has no issue.
00:05:12 <wnayes> And then there's the issue of having the status duplicated in the bottom table when it is also in the header.
00:31:35 --> nhnt11 has joined #instantbird
00:36:24 <-- nhnt11 has quit (Ping timeout)
00:44:02 --> mconley has joined #instantbird
00:44:40 <-- mpmc has quit (Connection reset by peer)
01:19:56 <-- atuljangra has quit (Ping timeout)
01:45:35 <-- rosonline has quit (Ping timeout)
02:13:29 <-- mconley has quit (Input/output error)
02:42:17 --> clokep has joined #instantbird
02:42:18 * ChanServ sets mode +o clokep 
03:02:41 <instant-buildbot> build #909 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/909
03:28:49 <instant-buildbot> build #901 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/901
03:46:31 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
05:50:42 <instant-buildbot> build #1005 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1005
06:18:05 <-- wnayes has quit (Quit: wnayes)
08:30:42 --> Mic has joined #instantbird
08:30:43 * ChanServ sets mode +h Mic 
09:31:23 --> mpmc has joined #instantbird
10:19:08 <-- chrisccoulson has quit (Ping timeout)
11:20:42 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:40:30 <-- Optimizer has quit (Ping timeout)
11:42:39 --> Optimizer has joined #instantbird
11:48:30 --> chrisccoulson has joined #instantbird
11:48:39 <-- chrisccoulson has quit (Client exited)
12:31:20 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
12:32:39 --> Mic has joined #instantbird
12:32:39 * ChanServ sets mode +h Mic 
13:09:38 --> clokep has joined #instantbird
13:09:38 * ChanServ sets mode +o clokep 
13:22:04 <clokep> Good morning.
13:26:31 <Mic> Good morning, clokep
13:40:02 --> mpmc has joined #instantbird
13:46:42 * clokep wonders what he should work on, if anything...
13:46:57 <clokep> Can I review ping you on that binary socket patch? :P
13:51:58 <Mic> Sure
13:52:21 <Mic> I'll only look at the parts that I commented earlier on already, though.
13:52:41 <clokep> :(
13:52:43 <Mic> I've no idea about socket stuff in general...
13:52:53 <clokep> There's always time to learn. ;)
13:53:12 <clokep> But that's cool, I'll r? flo after i get an r+ from you.
13:53:23 <Mic> OK, that would be nice.
13:57:28 <Mic> Is there anything that you always wanted to do but never had time for? What about that then if you don't know what to do ;)
13:58:58 <instantbot> clokep@gmail.com granted review for attachment 2459 on bug 1978.
13:59:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1978 nor, --, ---, nhnt11, NEW, Single xpcshell-tests (check-one) don't work
13:59:27 <clokep> There's lots of things. :P
13:59:30 <clokep> The question is getting started...
14:01:09 <instantbot> clokep@gmail.com set the Resolution field on bug 1978 to WORKSFORME.
14:01:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1978 nor, --, ---, nhnt11, RESO WORKSFORME, Single xpcshell-tests (check-one) don't work
14:10:49 --> flo-retina has joined #instantbird
14:10:49 * ChanServ sets mode +qo flo-retina flo-retina 
14:11:16 <flo-retina> I wonder why it takes a few seconds to auto-join all my IRC channels on reconnect
14:11:38 <flo-retina> well, what takes a few seconds is having all the tabs displayed
14:12:00 <flo-retina> but I'm not sure if it's related to the prpl, or just the UI being slow (for example wasting time displaying large participants list)
14:12:41 <flo-retina> Mic: any opinion on http://i.imgur.com/FnAJAt3.png ?
14:13:02 <flo-retina> Mic: should we try and fix this layout issue, or just review the current patch to land it asap?
14:14:29 <Mic> I thought that wnayes removed the status message from the second line and only displayed the status there?
14:14:42 <Mic> Is that the latest patch? I think he uploaded one yesterday evening.
14:15:45 <flo-retina> that's a screenshot of the patch he didn't attach because of the issue on the screenshot
14:18:54 <flo-retina> the "Status" line that's visible on the screenshot comes from JS-XMPP
14:19:17 <flo-retina> it's http://lxr.instantbird.org/instantbird/source/chat/locales/en-US/xmpp.properties#50
14:19:35 <Mic> I don't think I'd run into this problem with any of my current contacts. They have either short or no status messages.
14:20:05 <Mic> If it's not a common problem for you either, I'd say we should just take it and fix it in a follow-up.
14:20:19 <flo-retina> the screenshot seems to be from AIM, so I guess the Oscar prpl does something similar
14:21:23 <flo-retina> what do you mean by "take it"? Look at the currently attached patch, or request the patch that was used for this screenshot?
14:21:53 <Mic> The patch for this screenshot.
14:22:18 <Mic> That's what your question was about, wasn't it?
14:23:10 <flo-retina> I guess my question was "should we just go ahead and review the current patch, or request from wnayes that he attaches the other patch ;)
14:23:11 <flo-retina> "
14:23:11 <Mic> Ah, sorry. I just re-read your statement.
14:24:07 <flo-retina> either way seems fine to me, so that's why I'm confused / asking :)
14:24:34 <flo-retina> (I would like to land this relatively soon though, as I would like to ask nhnt11 to show tooltips on the awesometab and I don't want bitrot)
14:24:41 <Mic> I'd say we could land it as soon as possible (i.e. reviewing the current patch) and fix the second line later.
14:24:52 <clokep> We could 1. take the current patch and ask for the status to be moved in a followup and take care of that wrapping or something as well.
14:25:18 <Mic> That is wanyes could do a followup for showing the status message properly in the second line (or more?) of the header.
14:25:43 <Mic> Sounds like we agree on this then.
14:25:58 <flo-retina> ok, let's review the current patch then
14:29:06 * clokep goes to sit on his balcony and read.
14:29:40 <flo-retina> clokep: sounds like a great plan :)
14:33:58 * Mic 's going to play a round of Kubb (a swedish game of skill) soon :)
14:34:03 <flo-retina> arg, that tooltip patch is r- :(
14:35:39 <-- Optimizer has quit (Ping timeout)
14:36:03 <clokep> Sorry I attached that patch w/ the wrong mimetype. :( Thanks for fixing it M ic.
14:36:20 * clokep sometimes wants  to be able to tab complete names and add a space...
14:36:55 <-- dew has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
14:36:55 --> Optimizer has joined #instantbird
14:40:20 <flo-retina> clokep: there could be a keyboard shortcut for that :-D. Space+Tab = complete the nick in a way that doesn't match any of the current participants ;)
14:40:25 <flo-retina> seems like an add-on :)
14:43:12 <clokep> flo-retina: I also thought space tab, but not sure if that would interfere w/ normal typing.
14:43:35 <-- Optimizer has quit (Ping timeout)
14:44:08 <Mic> clokep: is "0x21 41 61" a pattern for hex data that I should know? I only know it without spaces.
14:44:13 <flo-retina> clokep: it seems like both tab and space are handled on keydown, so it's not possible to use them at once for a shortcut :(
14:44:41 --> Optimizer has joined #instantbird
14:44:51 <flo-retina> Mic: do you mean "is it usual to put a space every 2 hex characters?"
14:45:13 <clokep> Mic: I find it more convenient for reading.
14:45:13 <Mic> Yes, you could say it like that.
14:45:19 <clokep> hexdump does a space every 8 chars.
14:45:30 <clokep> But if you don't put spaces you get lost after the first 100 chars are so. ;)
14:46:07 <flo-retina> Mic: it makes some sense because 2 hex characters is a byte
14:46:29 <Mic> OK, we only do that it display it in the error console, don't we?
14:46:49 <Mic> No problem, then.
14:46:57 <flo-retina> does the error console display hex characters this way? :-S
14:47:18 <clokep> Mic: It's for debugging only, yes.
14:47:28 <clokep> flo-retina: The error console doesn't display hex in ANY way.
14:47:35 <clokep> It just displays the characters you print. ;)
14:48:48 <-- Optimizer has quit (Connection reset by peer)
14:52:00 --> Optimizer has joined #instantbird
15:00:11 <-- mpmc has quit (Connection reset by peer)
15:11:53 --> dew has joined #instantbird
15:21:17 <instantbot> florian@instantbird.org denied review for attachment 2593 on bug 1221.
15:21:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips
15:24:07 * clokep wonders how that looks for MUCs.
15:30:38 <flo-retina> likely (almost) unchanged compared to what we have now
15:30:57 <flo-retina> hmm, except the "Topic" word was dropped
15:33:53 --> nhnt11 has joined #instantbird
15:34:05 <nhnt11> Hi
15:37:19 <clokep>  Good day.
15:39:43 <-- nhnt11 has quit (Ping timeout)
15:42:05 --> nhnt11 has joined #instantbird
15:47:02 <-- nhnt11 has quit (Ping timeout)
15:48:31 <-- Tonnes has quit (Connection reset by peer)
15:50:21 --> mconley has joined #instantbird
15:55:04 --> nhnt11 has joined #instantbird
15:56:36 <nhnt11> flo-retina: I don't think you need to worry /too/ much about bitrot with the new conversation tooltips. Since they currently use imIContacts, I can probably reuse the build from contact code.
15:57:50 <clokep> nhnt11: Btw, ignore that bug I filed for now.
15:58:07 <nhnt11> Happily :P
15:58:39 <-- mconley has quit (Input/output error)
15:58:59 * nhnt11 wants to get a patch up for bugs 2041 and 2047 but isn't sure if his internet will hold up
16:00:19 <clokep> Are you unsure it'll handle the upload or do you still need to make patches?
16:00:23 <clokep> instantbot: bug 2041 bug 2047
16:00:27 <instantbot> 2 bugs found
16:00:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list
16:00:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, nhnt11, ASSI, Escape key should close awesometab
16:00:50 <nhnt11> clokep: The code is done but I need to export and upload
16:00:58 <clokep> Good luck. :)
16:01:02 <nhnt11> I'm on a 3kB/s EDGE connection right now
16:01:17 <clokep> Ah, if it's easier to email or something I can upload them.
16:01:25 <clokep> But obviously you still need to transfer the data. :)
16:01:45 <nhnt11> clokep: Thanks! But I think it should be fine
16:07:23 <-- nhnt11 has quit (Ping timeout)
16:29:07 --> mconley has joined #instantbird
16:35:17 <-- mconley has quit (Ping timeout)
16:51:46 --> wnayes has joined #instantbird
16:54:07 <-- skeledrew has quit (Ping timeout)
16:59:55 --> skeledrew has joined #instantbird
17:05:58 <Mic> clokep: here's a few lines of code and a question about the tests for ArrayBufferUtils: http://pastebin.instantbird.com/245619
17:06:35 <clokep> Mic: That's fine...I really wanted a &&=, but apparently that doesn't exist. ;)
17:06:45 <clokep> Well it's fine, but I'm dropping the ( ).
17:06:58 * clokep originally had do_check_eq in the loop.
17:07:06 <clokep> But it printed out a lot more garbage in the console.
17:07:19 <Mic> OK, I'll just put it into the comment.
17:09:47 <wnayes> flo-retina: I hide the parent of the usericon because I figured it would be odd to have the status icon without a picture. Were you thinking a placeholder could be there instead (like in the buddy list)?
17:12:30 <clokep> wnayes: That's  not good to do though, lots of people don't have buddy icons.
17:12:35 <clokep> We do it on conversation top code already.
17:14:50 <Mic> The new conversation tab is using the placeholder icon too for people with no user icon.
17:15:17 <Mic> If you don't run a current nightly I suggest you try it by the way. It's great already :)
17:16:04 <wnayes> I've seen it when working on the patch, looks great so far! :)
17:18:08 <wnayes> Hmm, and then if there was a placeholder it still would need to be removed for MUCs
17:18:56 <clokep> The other option to me btw, is to do something like http://i.imgur.com/Jl8sGtO.png everywhere
17:19:43 <clokep> I wouldn't worry too much about MUCs to start with. :) We already have gross tooltips for those.
17:19:46 * clokep goes outside.
17:25:01 --> goofy has joined #instantbird
17:26:00 <Mic> clokep: is it important to test different features in different functions of a test?
17:26:28 <Mic> I'm looking at StringToBytes and ArrayBufferToString at the moment which are tested in the same function.
17:26:32 <Mic> Does that matter or not?
17:26:51 <Mic> We could easily split that into two methods
17:26:58 <Mic> e.g. like this: http://pastebin.instantbird.com/245632
17:27:04 <goofy> (for the record) I hit one error trying to download http://ftp.instantbird.com/instantbird/nightly/latest-trunk/instantbird-1.5a1pre.en-US.linux-i686.tar.bz2
17:28:00 <Mic> Hello goofy
17:29:57 <Mic> What error is that, goofy?
17:41:53 <instantbot> benediktp@ymail.com denied review for attachment 2575 on bug 1981.
17:41:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
17:42:02 <Mic> Don't worry, it's not bad!
18:17:47 <-- qheaden_away has quit (Ping timeout)
18:23:03 <-- clokep has quit (Ping timeout)
18:25:16 --> qheaden has joined #instantbird
18:28:36 <-- goofy has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
18:32:21 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
18:34:49 --> Mic has joined #instantbird
18:34:49 * ChanServ sets mode +h Mic 
18:40:20 <flo-retina> wnayes: I thought it would look like this when there's no buddy icon: http://i2.minus.com/iDRekwGYGirui.png
18:44:14 <wnayes> OK, I think how I set up the margins are set up will need to be changed then.
18:46:37 <wnayes> When I used collapsed it never hid the icon reliably for some reason. It would show a space blank on first hover over, but reshowing the same tooltip again would then collapse it. Display doesn't have that issue.
18:48:22 <-- wnayes has quit (Ping timeout)
18:49:09 --> chrisccoulson has joined #instantbird
18:49:35 --> wnayes has joined #instantbird
19:01:08 <Mic> I always thought that this looks broken: http://i2.minus.com/iDRekwGYGirui.png
19:01:29 <Mic> Exactly the kind of "here should be an image which is missing"-broken.
19:02:59 <Mic> Let's not make tooltips look like that too, please :(
19:05:31 --> mpmc has joined #instantbird
19:14:36 --> atuljangra has joined #instantbird
19:17:31 --> atuljang1 has joined #instantbird
19:17:47 * atuljang1 is now known as atuljangra_ib
19:38:05 <instantbot> New Instantbird (UI) bug 2051 filed by benediktp@ymail.com.
19:38:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2051 min, --, ---, nobody, NEW, Styling of new conversation listbox
19:56:35 --> mconley has joined #instantbird
20:12:43 <flo-retina> Mic: a placeholder icon looks even more broken IMHO, especially if there's nothing the user can do to replace it with a real icon.
20:14:49 <Mic> I totally disagree. A placeholder icon is obviously intentional for a missing icon while the other thing just looks like something went awry in our code.
20:17:24 <Mic> bbl
20:20:47 --> rosonline has joined #instantbird
20:33:10 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:40:03 <-- dew has quit (Ping timeout)
20:40:07 --> dew has joined #instantbird
20:48:46 <-- wnayes has quit (Ping timeout)
20:50:45 <atuljangra_ib> 120
20:50:47 <atuljangra_ib> .3
20:50:57 <atuljangra_ib> sorry.
20:52:05 --> wnayes has joined #instantbird
20:52:33 --> clokep has joined #instantbird
20:52:33 * ChanServ sets mode +o clokep 
21:03:05 <clokep> Thank you for the review Mic. :)
21:03:12 <Mic> Hi
21:03:16 <clokep> Hello.
21:06:37 --> EionRobb has joined #instantbird
21:07:25 <Mic> Oops, it seems some MICs made it into my review comment ;)
21:07:38 * clokep was wondering what the deal is with that.
21:10:22 <clokep> Mic: You care how this is formatted? http://pastebin.instantbird.com/245835 I'm planning to just leave it all on one line.
21:11:37 <Mic> It's OK.
21:22:21 <instantbot> clokep@gmail.com requested review from benediktp@ymail.com  for attachment 2595 on bug 1981.
21:22:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
21:29:11 <-- mconley has quit (Input/output error)
21:34:01 <instantbot> benediktp@ymail.com granted review for attachment 2595 on bug 1981.
21:34:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
21:34:18 <clokep> Mic: Do you want me to r? flo or are you good w/ that?
21:35:45 <Mic> I wouldn't take offense if you ask flo for review too;)
21:37:08 <clokep> He'll look over it before check-in anyway. :)
21:37:09 <Mic> On the other hand: "r? (flo)" and "[checkin-needed]" might be almost the same :P
21:38:17 <Mic> You mid-aired me by the way ;)
21:38:25 <clokep> :)
21:38:32 <clokep> W/ the same change?
21:38:43 <Mic> Exactly the same, yes :)
21:39:56 <clokep> :)
21:40:05 <clokep> qheaden will be happy when htat's checked in most likely. :)
21:47:49 <-- dew has quit (Ping timeout)
21:48:19 --> dew has joined #instantbird
21:51:12 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:57:45 <-- dew has quit (Ping timeout)
22:00:28 <Mic> atuljangra, atuljangra_ib: you're currently unblocked?
22:03:28 <atuljangra_ib> Mic: yes. Thank you :)
22:03:34 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:03:45 * atuljangra_ib is now known as atuljangra
22:04:24 --> dew has joined #instantbird
22:04:46 <atuljangra> I'm working on the guidelines provided by flo. But since I'm at home for this sunday. I won't be able to produce much useful code today.
22:07:56 <Mic> Has he responded by email then? Let me check.
22:09:33 <atuljangra> yes. To the md chat list :)
22:10:10 <Mic> I see. I hope the comments helped to define what needs to be done next?
22:13:19 <atuljangra> Yes. They are pretty clear. Actually in the mail that I worte I wanted to explain things working like that only, but I wasn't able to. Anyway working on this for now :) 
22:18:11 <Mic> Have you tried adding FileLink to the Instantbird source?
22:25:56 <atuljangra> yes. there were some issues with moz.buil. 
22:26:29 <atuljangra> SO I am first looking at how to configure filelink for a file transfer.
22:35:54 <Mic> How can you do that if you can't build IB with FileLink as it seems?
22:38:11 <Mic> *How do
22:48:45 <-- wnayes has quit (Ping timeout)
22:52:02 --> wnayes has joined #instantbird
23:02:33 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:03:01 --> flo-retina has joined #instantbird
23:03:01 * ChanServ sets mode +qo flo-retina flo-retina 
23:10:22 --> mconley has joined #instantbird
23:16:29 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)