#instantbird log on 07 12 2013

All times are UTC.

00:00:02 <clokep> We should. :)
00:00:45 <atuljangra> flo-retina: I am not able to capture the "cancelled" event. Making a cancelled function in aSubject should do the task right?
00:01:18 <flo-retina> no
00:01:38 <flo-retina> you asked me if it's called automatically, I replied by showing you where it's called manually.
00:02:04 <flo-retina> and I really don't see how prplIRequest relates to file transfer offers
00:03:26 <atuljangra> oh okay. 
00:04:37 <-- myk has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:04:45 <-- bwalker has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
00:06:06 <atuljangra> flo-retina: In the first iteration, I'm keeping two buttons accept and reject. I want to get the working ui with backend pathced up first. Can I look into handling the "cancel" later?
00:06:43 <instant-buildbot> build #417 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/417
00:08:37 <clokep> Mozilla 22 is the start of moz.build. :(
00:11:56 <atuljangra> clokep: In the initial request, when we send the si initiator request, A send B two options for supported methods. But when user does not want to receive the file, xep-0096 doesn't say anything. So should I send a stanza with no option? Or what else?
00:12:22 <atuljangra> One work around is to do this when IBB initiation request is received. 
00:12:53 <atuljangra> Thinking of it, this seems to be more viable option. ( and I guess this is what specs want us to do)
00:13:00 <flo-retina> clokep: sounds painful :(
00:13:18 <flo-retina> clokep: is porting stuff to moz.build required?
00:13:23 <clokep> atuljangra: So...I don't really know anything about XMPP. ;)
00:13:30 <atuljangra> okay flo-retina^^ :P
00:13:36 <flo-retina> clokep: or can we wait another cycle or two, and do a larger conversion at once?
00:13:46 <clokep> flo-retina: I have nothing else to do and just opened a bottle of wine, it'll be fine. :)
00:14:03 <flo-retina> clokep: I'm thinking about the review :-P
00:14:13 <clokep> (If only it was as good as the wine in France....)
00:14:19 * clokep will r? Mic :P
00:14:24 <flo-retina> :-D
00:14:45 <clokep> Well I guess, I'll rs? Mic.
00:15:18 <instant-buildbot> build #436 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/436
00:16:36 <flo-retina> atuljangra: cancel shouldn't be difficult, but it doesn't matter if you want an "ignore" button
00:16:40 <flo-retina> (for now)
00:16:49 <atuljangra> flo-retina: cool.
00:17:26 <Mook_as> our code hasn't needed moz.build yet; it's just the executable binary, though...
00:17:44 <Mook_as> (that's on 24)
00:18:11 <atuljangra> flo-retina: And regarding rejection? http://log.bezut.info/instantbird/today#m11
00:20:32 <flo-retina> atuljangra: example 5 in http://xmpp.org/extensions/xep-0047.html "Responder does not wish to proceed"
00:21:06 <atuljangra> flo-retina: yes, so I should wait till Ibb initialization.
00:22:36 <flo-retina> I haven't read these full XEPs yet :-/
00:23:03 <atuljangra> I have, this seems the most viable option to me. And makes much sense.
00:23:18 <atuljangra> si and ibb should be kept separated this way.
00:30:53 <atuljangra> flo-retina: As sender in the notification, does     normalizeJID seems ok? 
00:31:04 <-- wnayes has quit (Ping timeout)
00:32:19 <flo-retina> yes
00:32:31 <flo-retina> although you likely won't want to show that in the UI.
00:32:33 <flo-retina> good night
00:32:47 * flo-retina gives up on the idea of assembling more IKEA furniture tonight.
00:33:05 <atuljangra> okay. So I should just show filename and filesize?
00:33:22 <atuljangra> ah, sorry. Good night :)
00:34:27 --> wnayes has joined #instantbird
00:38:11 <-- Mook_as has quit (Quit: Mook_as)
00:42:04 <atuljangra> UI seems to work fine. Now addressing clokep after a quick clean up.
00:42:11 <clokep> OK.
00:43:13 <atuljangra> *'s :S
01:02:07 <atuljangra> clokep: Regarding "The abstract class seems to
01:02:07 <atuljangra> have _conv and _targetFile defined, you should be using those (also I dislike
01:02:07 <atuljangra> those names...)." You dislike {conv, file} or {_conv, _targetFile}?
01:02:31 <clokep> _targetFile mostly.
01:02:45 <clokep> Why can't it just be "file"?
01:03:41 <clokep> (Or _file)
01:03:56 <atuljangra> Okay. I've inherited it from nsIDownload. I am also tempted to use file. So should I define one nsIFile in the file transfer interface
01:05:18 <clokep> I don't really know what that means.
01:05:25 <clokep> Does nsIDownload call it target file?
01:05:34 <atuljangra> yes.
01:07:48 <clokep> Ah, OK, Never mind then.
01:08:04 <clokep> Why don't you use it in XMPPFileTransfer though?
01:09:04 <atuljangra> cos I hate _targetFile too. I wanted to use file. targetFile makes sense in case of download, but incase of upload we actually don't have any "target" file
01:13:14 <atuljangra> So should I go with file or _targetFile?
01:13:26 * atuljangra votes for _targetFile :D
01:13:29 <atuljangra> oops
01:13:29 <atuljangra> sorry
01:13:42 * atuljangra votes for file :D
01:13:49 <clokep> My main point was you should NOT have both.
01:16:04 --> nhnt11 has joined #instantbird
01:16:35 <-- nhnt11 has left #instantbird ()
01:17:05 <atuljangra> I cannot remote targetFile, thus I should I should go with targetFile? IT doesn't make much sense though. But I can remove the targetFile from GenericFileTransferPrototype and just keep a file local to IBBFileTransfer?
01:17:32 <clokep> Just use targetFile, please.
01:18:16 <atuljangra> Ok.
01:18:52 <atuljangra> Regarding " I thought we decided that this should print an error in the conversation?" You mean a system message right?
01:18:59 <clokep> Yes.
01:19:05 <clokep> There's a flag for errors.
01:19:13 <-- wnayes has quit (Ping timeout)
01:19:14 <clokep> Florian decided that's not really important right now though.
01:20:45 <atuljangra> Okay. this.ERROR()?
01:21:01 <clokep> I'm not sure what you're trying to do.
01:21:09 <atuljangra> Sorry.
01:21:58 <atuljangra>  Regarding, I'm a little bit confused at what we're decoding. This has to do with the encoding. I'm planning to tackle it tomorrow. So next patch won't contain a fix for this. :)
01:22:26 <clokep> OK.
01:22:44 <atuljangra> And file.write needs ArrayBufferView thus I need to use Uint8Array.
01:22:51 --> wnayes has joined #instantbird
01:22:56 <instant-buildbot> build #423 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/423
01:23:26 <clokep> You already said that.
01:24:22 <atuljangra> Oh sorry. I just wanted to clear out the patch. :D
01:26:41 <clokep> OK.
01:27:10 <clokep> EionRobb: Btw qheaden_away checked in Pidgin and he said he could also get the chatroom listing, but couldn't join any of them.
01:28:18 <EionRobb> weird :)
01:28:40 <clokep> Not really if they really did shut down the chatsrooms.
01:29:58 <-- mconley has quit (Input/output error)
01:36:38 <atuljangra> clokep: Regarding "let mime = 'text/plain';", looking from xep, this seems to be the only option. I'll add a TODO here and will ask this in xmpp muc and then fix it.
01:37:05 <clokep> atuljangra: You removed the TODO or the comment you had w/o explaining why, that's all that I was asking about.
01:37:21 <atuljangra> Oh okay :) I'll add the TODO
01:52:02 <instantbot> New Core - General bug 2039 filed by atuljangra66@gmail.com.
01:52:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2039 nor, --, ---, nobody, UNCO, File Transfer Backend
02:05:34 <clokep> atuljangra: Make that block bug 9.
02:05:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=9 enh, P5, ---, nobody, NEW, Support of file transfers
02:05:54 <atuljangra> clokep: OK :)
02:06:05 <clokep> And assign it to yourself.
02:06:14 * clokep is going to bed.
02:07:07 <atuljangra> Okay. Do I have the privileges to assign bug? 
02:11:00 <clokep> I don't know, do you?
02:11:23 <atuljangra> No
02:11:51 <clokep> Refresh.
02:13:15 <atuljangra> Now I can :D
02:17:07 --> Mook has joined #instantbird
02:19:48 * clokep wonders if Mook has any idea what could cause this: http://pastebin.instantbird.com/243483
02:20:01 <clokep> I had similar errors that were caused by me not creating moz.build files, but this one is app.mozbuild.
02:20:06 <clokep> Which I created and such.
02:21:22 <Mook> oh boy
02:21:35 <Mook> I bet that's "you should be a subdirectory of mozilla/"
02:21:52 <Mook> might want to go hunt down jcranmer in #build/#maildev and ask him about it
02:22:14 <clokep> Yeah, I figured him or gps...
02:22:28 * clokep doesn't have the energy to ask this question now.
02:23:39 <clokep> atuljangra: You didn't actually change the state to ASSIGNED, but that doesn't matter that much.
02:23:59 <atuljangra> will do :)
02:26:17 <instantbot> atuljangra66@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 2572 on bug 2037.
02:26:18 <instantbot> atuljangra66@gmail.com requested feedback from florian@instantbi rd.org for attachment 2577 on bug 2037.
02:26:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
02:31:18 --> mconley has joined #instantbird
02:31:46 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:37:41 <instantbot> atuljangra66@gmail.com requested feedback from benediktp@ymail.c om for attachment 2578 on bug 2039.
02:37:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2039 nor, --, ---, atuljangra66, UNCO, File Transfer Backend
02:39:48 <atuljangra> I'll be late tomorrow. Thus I'll do some more work on the encoding thing now.
02:40:01 <-- wnayes has quit (Quit: wnayes)
03:01:34 <-- mconley has quit (Input/output error)
03:02:58 --> Nirgali has joined #instantbird
03:04:37 <instant-buildbot> build #907 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/907
03:14:21 <-- atuljangra has quit (Ping timeout)
03:15:10 --> atuljangra has joined #instantbird
03:15:35 <atuljangra> Nothing much yet. :( Not able to find a way to read binary data from OS.File
03:18:00 <Mook> huh, OS.File.read() is text mode?
03:19:17 <atuljangra> No, is shouldn't be. Just finding a way to read binary from it and encode the binary string as base64
03:22:20 <atuljangra> I guess it's done. Confirming.
03:23:35 <atuljangra> Done. I can transfer images now.
03:26:20 <instant-buildbot> build #899 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/899
03:27:23 <atuljangra> Zipped files are also transferred successfully. But obviously their size is large than original.
03:27:48 <Mook> I guess you're writing this to a spec that demands base64 encoding?
03:28:01 <atuljangra> Mook: yes.
03:28:03 <Mook> ah, I guess you're transporting it over xmpp, which is xml, which probably does want that... ugh
03:28:27 <atuljangra> hmmm :)
03:33:47 <-- atuljangra has quit (Ping timeout)
03:33:48 <-- Nirgali has quit (Ping timeout)
03:36:13 --> atuljangra has joined #instantbird
03:38:47 <-- atuljangra has quit (Connection reset by peer)
03:43:36 --> atuljangra has joined #instantbird
03:45:19 <-- atuljangra has quit (Ping timeout)
03:45:42 --> atuljangra has joined #instantbird
03:53:49 <-- atuljangra has quit (Connection reset by peer)
04:03:15 --> gerard-majax__ has joined #instantbird
04:07:40 <-- gerard-majax__ has quit (Ping timeout)
04:09:45 --> atuljangra has joined #instantbird
04:12:19 <atuljangra> Finally tested it. Text, images, zip files are getting transferred properly. But there seem to have some problem while sending 3-4 images zipped in one file. 
04:12:35 <atuljangra> Also, .docx files are not properly identified.
04:13:05 <atuljangra> I'll go to sleep now. Will discuss this with others and finalize it later.
04:13:20 <atuljangra> Good night :)
04:13:22 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
05:34:13 <Mook> .docx is just a zip file, isn't it?
05:43:17 <-- Mook has quit (Quit: Mook)
05:53:39 <instant-buildbot> build #1003 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1003
06:03:27 --> Mic has joined #instantbird
06:03:27 * ChanServ sets mode +h Mic 
06:03:44 <Mic> \o/
06:03:45 <Mic> Bug 2015
06:03:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, 1.5, nhnt11, RESO FIXED, Display buddy list in a tab.
06:03:53 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
06:04:23 --> Mic has joined #instantbird
06:04:23 * ChanServ sets mode +h Mic 
06:16:39 --> jb has joined #instantbird
06:17:36 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
06:17:50 --> Mic has joined #instantbird
06:17:50 * ChanServ sets mode +h Mic 
06:22:06 <-- EionRobb has quit (Quit: Leaving.)
06:23:15 <instantbot> New Instantbird (UI) bug 2040 filed by benediktp@ymail.com.
06:23:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2040 nor, --, ---, nobody, NEW, New conversation tab has generic placeholder icon (a.k.a. the Firefox "New Tab" icon)
07:01:25 <-- jb has quit (Ping timeout)
07:16:20 --> gerard-majax__ has joined #instantbird
07:16:42 --> gerard-majax_ has joined #instantbird
07:18:03 <-- gerard-majax__ has quit (Ping timeout)
07:24:24 --> nhnt11_phone has joined #instantbird
07:24:48 <nhnt11_phone> Mic: I wonder why the new conversation icon isnt working
07:24:51 <nhnt11_phone> O.o
07:31:18 * flo-retina updates his nightly
07:31:19 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
07:31:23 --> flo-retina has joined #instantbird
07:31:23 * ChanServ sets mode +qo flo-retina flo-retina 
07:33:22 <flo-retina> indeed the new conversation icon isn't shown. And the bug was already there on my debug build, I just didn't notice :-S
07:34:36 * nhnt11_phone cries
07:38:58 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
07:56:44 --> jb has joined #instantbird
08:19:15 --> nhnt11_phone has joined #instantbird
08:20:57 <nhnt11_phone> flo-retina: I tried a debug build but it failed. I did export DEBUG=1 and disabled valgrind, was there something else I needed to do?
08:22:13 <nhnt11_phone> Im asking in case there was a prerequisite I missed. Otherwise I'll investigate later.
08:28:29 --> mpmc has joined #instantbird
08:32:01 <flo-retina> nhnt11_phone: it would be helpful to see what error message you got
08:40:43 <-- nhnt11_phone has quit (Ping timeout)
08:50:58 <-- jb has quit (Quit: jb)
08:58:27 --> nhnt11_phone has joined #instantbird
08:58:49 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:59:25 <nhnt11_phone> flo-retina, Mic: I've fixed the selection issues and the tab icon :)
09:00:01 * nhnt11_phone needs to read yesterday's logs and see what else needed immediate attention.
09:00:47 <-- gerard-majax_ has quit (Ping timeout)
09:03:28 --> Mic has joined #instantbird
09:03:28 * ChanServ sets mode +h Mic 
09:03:43 --> gerard-majax_ has joined #instantbird
09:10:27 --> jb has joined #instantbird
09:22:49 <-- gerard-majax_ has quit (Ping timeout)
09:23:47 --> gerard-majax_ has joined #instantbird
09:25:37 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
09:26:47 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:30:16 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:30:35 --> mpmc has joined #instantbird
09:41:45 --> aleth has joined #instantbird
09:41:45 * ChanServ sets mode +h aleth 
09:47:57 <instantbot> New Instantbird (UI) bug 2041 filed by benediktp@ymail.com.
09:47:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nobody, NEW, "Enter" always opens conversation with first contact in the filtered list
09:49:13 <aleth> ^^ I mentioned this in a review comment a while ago :-/
09:49:27 <aleth> But on the other hand, that must mean 2015 landed :)
09:49:30 <aleth> Time to update :D
09:49:43 <Mic> Absolutely :)
09:54:21 --> flo-retina has joined #instantbird
09:54:21 * ChanServ sets mode +qo flo-retina flo-retina 
09:56:44 <Mic> The next one is better ;)
09:57:32 <flo-retina> the next what?
09:58:10 <instantbot> New Instantbird (UI) bug 2042 filed by benediktp@ymail.com.
09:58:12 <flo-retina> aleth: what's the expected behavior for the enter key?
09:58:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nobody, NEW, Starting conversations on unrelated keyboard- or mouse-events
09:59:06 <-- aleth has quit (Quit: Ciao)
09:59:09 <Mic> The next bug = the one just announced by our bot.
09:59:16 --> aleth has joined #instantbird
09:59:16 * ChanServ sets mode +h aleth 
10:00:37 <flo-retina> that's... interesting :-S
10:01:04 <Mic> aleth, flo-retina: I think the expected behaviour for the enter key is to start a conversation with the contact that is currently highlighted.
10:01:17 <flo-retina> Mic: that was my first thought too
10:01:23 <aleth> flo-retina: I agree with Mic. If something is selected, Enter should open a conv with it
10:02:15 <flo-retina> Mic: here's a problematic edge case though: My mouse is in the middle of the window (but I haven't noticed it). I press Command+T, start typing, and when the first item pleases me, press enter. Oh surprise, a conversation starts with a random contact that was in the middle of the list :-S.
10:02:18 <aleth> Update failed :-S
10:02:27 <flo-retina> aleth: bad luck :-/
10:03:02 <aleth> flo-retina: Can't we differentiate between hover and select?
10:03:12 --> clokep has joined #instantbird
10:03:12 * ChanServ sets mode +o clokep 
10:03:15 <Mic> flo-retina: we shouldn't select the contact unless the mouse was moved then?
10:03:16 <flo-retina> Mic: so I think typing anything in the filter box should clear the current highlight.
10:03:27 <flo-retina> and re-highlight when the mouse is moved
10:03:28 <flo-retina> Mic: yeah
10:03:49 <aleth> flo-retina: Why should highlight on hover have anything to do with the Enter key?
10:03:51 <-- aleth has quit (Quit: Ciao)
10:03:59 --> aleth has joined #instantbird
10:03:59 * ChanServ sets mode +h aleth 
10:04:15 <flo-retina> it's what the awesomebar does: when I type another character the highlight is cleared, and I need to move the mouse slightly for it to reappear
10:04:34 <Mic> There.is.no.hover.there.is.only.select. ;)
10:04:40 <flo-retina> aleth: enter key should start a conv with the visibly highlighted item, or the first item if nothing is highlighted
10:05:06 <Mic> Or we could always highlight the first one.
10:05:16 <aleth> flo-retina: I guess I should look at the code to see if there is a distinction between highlight and selection
10:05:38 <Mic> aleth try moving the mouse and pressing the Up/Down keys.
10:05:40 <flo-retina> but I tend to think that we shouldn't highlight on hover, and just select on mouseover
10:05:57 <Mic> You'll get both a highlight and a moving selection.
10:06:04 <-- clokep has quit (Connection reset by peer)
10:06:10 <aleth> Mic: Right, that's what's confusing me.
10:06:14 <flo-retina> aleth: there is a messy one, that currently makes it possible to have both a highlight and a selection. I think nhnt11 already has a patch to fix that.
10:06:35 <aleth> flo-retina: Can't we use a lighter color shade for highlight on hover than for a selection?
10:06:58 <flo-retina> aleth: these 2 concepts shouldn't be different
10:07:01 <Mic> aleth: I think flo-retina is right that we should just select onmouseover.
10:07:04 <flo-retina> and I think we should match the awesomebar behavior
10:07:08 <aleth> Mic: What happened to your new conversation icon? I'm not seeing it
10:07:15 <flo-retina> aleth: a bug was filed for it
10:07:23 <aleth> OK :)
10:07:35 <Mic> aleth: it's got stagefright.
10:08:36 <aleth> The new tab does work very well though :)
10:08:44 <flo-retina> Mic: :-D
10:09:00 <flo-retina> aleth: indeed!
10:09:18 <flo-retina> aleth: I started a conversation with Even this morning by just typing: Command+T, "q", <enter>
10:09:27 <flo-retina> (to tell him that he really should update his nightly today ;))
10:09:33 <aleth> Yes :)
10:09:43 <aleth> I'm missing MUCs there already :D
10:09:52 <flo-retina> aleth: me too
10:10:04 <aleth> There are some minor styling issues on Linux, I guess I should look into that
10:10:14 <flo-retina> and I think putting in there the MUCs I currently have on hold would be an easy first step that would cover most of my use cases
10:10:26 <flo-retina> aleth: there are minor styling issues on mac too.
10:10:31 <flo-retina> especially around the "+" button
10:10:34 <aleth> Oh, maybe they are OS-independent
10:10:49 <flo-retina> aleth: a linux screenshot would be welcome
10:11:02 <aleth> Hmm no, the items look better on OSX
10:12:23 <flo-retina> I suspect nhnt11 will get plenty of bugmail today :-P
10:12:51 <flo-retina> I also missed the tooltips on contacts in the awesometab.
10:13:10 <aleth> Yes, tooltips would be nice.
10:13:39 <flo-retina> we should probably review and checkin wnayes' patch before asking nhnt11 to mess with tooltips though
10:14:59 <flo-retina> I would also like to have in the awesometab IRC nicks I've had conversations with previously, even though they aren't in my contact list
10:15:17 <flo-retina> but maybe it's just that we should auto-add them to the contact list. (Or that I should add them myself :-S)
10:16:04 * flo-retina dislikes adding nicks to his contacts list for some reason :-S
10:18:27 * flo-retina wonders how clokep would feel about adding a MozNet prpl that would default to SSL and have https://developer.cdn.mozilla.net/media/img/favicon.ico as prpl icon.
10:19:22 <flo-retina> not sur "MozNet" is the right name though; doesn't seem user friendly :-S
10:22:30 --> clokep has joined #instantbird
10:22:30 * ChanServ sets mode +o clokep 
10:26:29 <clokep> flo-retina: We've discussed ways to add "networks" before but never really come up with a good solution :( re http://log.bezut.info/instantbird/130712/#m294
10:27:59 <flo-retina> I was thinking about this while looking at the current irc tooltip, thinking about displaying the account is pointless, but that if we remove it we would need to display the network instead
10:28:39 <Mic> Bye!
10:28:48 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:28:57 <clokep> Has a bug been filed on this: http://i.imgur.com/QVmbCbq.png ;)
10:29:18 <clokep> flo-retina: You can still have multiple nicks on the same network though.
10:29:47 <flo-retina> :(
10:30:17 <flo-retina> clokep: that's several account buddies for the same buddy, and they would be displayed as one on the blist, right?
10:30:37 <clokep> flo-retina: Yes.
10:30:45 <flo-retina> I'm always afraid when I see a windows screenshot :(
10:31:04 <clokep> But all the icons are weird sizes...
10:31:40 <flo-retina> hm, maybe we missed a line in jar.mn for windows aero?
10:32:06 <clokep> This one is better: http://i.imgur.com/my12OYL.png :)
10:32:48 <flo-retina> exactly, we forgot the aero newtab.css line in jar.mn
10:33:05 * clokep files a bug.
10:33:12 <aleth> Not quite as bad on Linux, just font sizes and spacing https://i.minus.com/jblJ3z1gGRAWh3.png
10:33:31 <clokep> These go in...conversation window?
10:35:04 <instantbot> New Instantbird (UI) bug 2043 filed by clokep@gmail.com.
10:35:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, ---, nobody, NEW, Icon sizes are totally wrong on Windows Aero in awesometab
10:35:38 * clokep wonders if he can straight up assign that to nhnt11.
10:36:55 <instantbot> New Instantbird (UI) bug 2044 filed by aleth@instantbird.org.
10:36:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2044 nor, --, ---, nobody, NEW, New tab item styling not optimal on Linux
10:37:13 <aleth> clokep: Why not, as the fix doesn't require being on Windows ;)
10:37:28 <clokep> He's being paid, right? :P
10:38:22 * clokep just tried to open a conv on hold from the awesometab. :(
10:39:11 <flo-retina> clokep: that works, but not for MUCs.
10:39:41 <flo-retina> aleth: wow "minor" styling issues.
10:40:14 <flo-retina> :(
10:40:15 <aleth> flo-retina: well, all the elements are present :P
10:40:21 <flo-retina> yeah
10:40:24 <clokep> flo-retina: Well it was #maildev. :P
10:40:40 <flo-retina> clokep: you don't need to open it, people are pinging you :-P
10:40:53 <clokep> Yes, that was convenient. :)
10:41:27 <flo-retina> uh, so nobody tried running these mozmill tests? :-S
10:42:00 <clokep> Yes
10:42:23 <flo-retina> bah, busting a busted tree isn't terrible ;)
10:43:28 * clokep isn't sure he likes the auto-loading of extra elements.
10:43:39 <clokep> I just loaded everything by mistake.
10:44:25 <flo-retina> you kept the down arrow pressed while doing something in another room??
10:44:44 <aleth> What's the problem with loading everything by mistake?
10:45:43 <clokep> aleth: The scrollbar becomes really useless.
10:45:58 <clokep> flo-retina: No, I took the little scrollbar thing and pulled it to the bottom and in <1 sec everything was loaded.
10:46:02 <clokep> Which was great for performance. :)
10:49:11 <aleth> I don't care if everything loads as conversely, filtering allows me to reduce it instantly
10:49:11 <flo-retina> ah, I can reproduce that
10:49:54 <flo-retina> we probably need to keep scrolling with the scrollbar that existed before inserting new elements, but show the new one
10:50:33 <aleth> clokep, flo-retina: Isn't the solution to that to somehow make the scrollbar correspond to the real length of the list even though it is only partially loaded
10:52:53 * aleth wonders if the awesometab should auto-close if you switch away from it
10:53:11 <flo-retina> aleth: I also wondered the same thing
10:53:21 <aleth> I keep having orphan awesometabs open
10:53:22 <flo-retina> aleth: maybe only if you haven't typed anything?
10:53:30 <aleth> ^^ good idea!
10:53:52 <flo-retina> maybe it should also reuse the existing tab when you press Command+T?
10:54:34 <clokep> flo-retina, aleth: I think we should hold off on that behavior.
10:54:40 <clokep> Until we're using it instead of just playing w/ it.
10:55:49 <flo-retina> clokep: yeah, I was just thinking out loud, I didn't mean "let's implement this now!"
10:55:57 <aleth> clokep: yeah
10:56:02 <flo-retina> we'll soon know what really annoys us
10:56:02 <aleth> Just something to keep in mind.
10:56:09 <clokep> :)
10:56:13 <clokep> The enter key was filed, right?
10:56:13 <flo-retina> I suspect opening MUCs (especially the ones that are on hold) will be high on the list of annoyances
10:56:39 --> novabyte has joined #instantbird
10:57:02 * flo-retina wonders how the checkin-needed queue will look like in a few hours
10:58:28 <instantbot> New Instantbird (UI) bug 2045 filed by clokep@gmail.com.
10:58:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2045 nor, --, ---, nobody, NEW, New tab button broken when tabs start scrolling
10:59:11 <clokep> That's a fun one too. ;)
10:59:20 <clokep> Can you guys check on Linux/Mac and see if it's an issue?
10:59:39 <flo-retina> clokep: this is all on purpose
10:59:53 <flo-retina> clokep: the only problem is the theming. The background should be blue, like for the ">" arrow.
11:00:04 <flo-retina> clokep: this button has theming issues on Mac too
11:00:16 <aleth> Linux too I think.
11:00:23 <clokep> OK!
11:00:29 <aleth> At least it looks different in FX
11:00:31 <flo-retina> clokep: mainly because these buttons have the theming that was 'right' for Firefox 3.6 tabs, and we have updated our tab styling since that... but not for these buttons that were hidden
11:00:40 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:01:48 --> mpmc has joined #instantbird
11:02:08 <clokep> Well, it needs to be fixed. :)
11:02:45 <flo-retina> yeah, the theming of that button needs to be updated on all OSes I guess
11:05:17 * clokep leaves.
11:05:44 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:07:36 <flo-retina> so I guess we will soon need to start discussing the priorities of the various bugs we filed vs continuing the work on the service back-end.
11:08:39 <flo-retina> my suggestion would be to handle follow-ups today, and then start focusing again on the real back-end on Monday, with the goal of landing it by the end of next week.
11:09:07 <aleth> flo-retina: nhnt11 said he had a patch for the service backend ready. So we can give feedback on that while he fixes the little followups
11:09:41 <flo-retina> aleth: I was suspecting that it would take a few iterations to get it reviewed
11:09:45 <aleth> flo-retina: ditto
11:10:25 <aleth> But the first review often takes longest (for us)
11:10:47 <flo-retina> aleth: if he's already got the patch he would definitely upload it to bugzilla soon
11:11:11 <flo-retina> aleth: anyway fixing theming and selection behaviors won't bitrot with back-end stuff :)
11:11:18 <aleth> flo-retina: He said he would do it yesterday, so I'm guessing maybe today ;)
11:11:49 <flo-retina> maybe today he'll want to make a retina-friendly theming for the + button ;)
11:11:59 <aleth> Ah yes, the new laptop :P
11:12:30 <flo-retina> shouldn't be difficult as Firefox already has it
11:12:34 <flo-retina> should be just copy/paste
11:13:41 <flo-retina> http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css#2775
11:20:43 <instantbot> New Instantbird (UI) bug 2046 filed by aleth@instantbird.org.
11:20:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2046 enh, --, ---, nobody, NEW, Highlight search string in awesometab items
11:30:27 <aleth> Has anyone filed a bug on the Escape key doing nothing in awesometabs?
11:32:47 * aleth dislikes the fact that when IB does not have focus, clicking inside an awesometab still opens a conversation
11:33:12 <aleth> If the window is mostly hidden, it's impossible to see what one is doing.
11:34:54 <-- novabyte has quit (Ping timeout)
11:35:50 --> novabyte has joined #instantbird
11:47:31 --> clokep has joined #instantbird
11:47:31 * ChanServ sets mode +o clokep 
11:51:18 <clokep> We also need to give atuljangra feedback.
11:51:32 <clokep> And figure out interactions w/ FileLink.
11:51:51 <aleth> I'll try to look at his UI patch later
11:58:37 <instantbot> clokep@gmail.com requested feedback from aleth@instantbird.org for attachment 2578 on bug 2039.
11:58:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2039 nor, --, ---, atuljangra66, ASSI, File Transfer Backend
11:59:08 <aleth> Yup, that one ;)
12:15:19 <clokep> Does anyone know if atul's latest patches have the "working" binary stuff?
12:18:11 <instantbot> clokep@gmail.com granted feedback for attachment 2577 on bug 2037.
12:18:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
12:20:15 --> nhnt11 has joined #instantbird
12:21:03 <nhnt11> Hi
12:21:45 <clokep> nhnt11: Hello. :)
12:21:47 <nhnt11> Erm, Mic, aleth: I think most of those new bugs are fixed now :)
12:21:48 <nhnt11> locally
12:21:49 <clokep> I think a few bugs were filed. ;)
12:21:53 <nhnt11> Hi clokep
12:22:21 <aleth> nhnt11: :)
12:22:30 <nhnt11> Yeah, I got a chance to spend some time on Ib today after lunch and fixed most of the selection/keypress bugs from yesterday.
12:22:32 <aleth> nhnt11: Great to have the awesometab in the nightlies! :)
12:22:38 <nhnt11> :)
12:23:01 * nhnt11 should upload a patch
12:23:39 <aleth> Probably a good idea to update your todo list with all the feedback from logs/bugs so nothing gets forgotten/duplicated
12:24:42 <-- nhnt11 has quit (Ping timeout)
12:26:55 --> nhnt11 has joined #instantbird
12:27:42 * nhnt11 saw the screenshots from windows and linux
12:27:44 <nhnt11> Gross! :(
12:28:24 <nhnt11> 17:53:59 - nhnt11: flo-retina: Tooltips are planned! :)
12:28:27 <nhnt11> 17:54:03 - nhnt11: Yeah.
12:28:27 <nhnt11> 17:54:17 - nhnt11: I'm not at home right now, will update when I get the chance (just kinda passing by right now)
12:30:53 <flo-retina> nhnt11: do you have an online todo list, like for example an etherpad?
12:31:03 <flo-retina> (so that we don't suggest again things that you are already working on :))
12:31:17 <clokep> https://etherpad.mozilla.org/instantbird-gsoc-2013-awesometab ?
12:31:33 <nhnt11> flo-retina: Yes, I was maintaining a to-do list on https://etherpad.mozilla.org/instantbird-gsoc-2013-awesometab
12:31:34 <nhnt11> It's a bit out of date right now though..
12:31:36 <clokep> Probably needs to be updated a bit.
12:31:53 <flo-retina> ok, thanks
12:35:35 * flo-retina wonders how much work it would be to create an add-on to have etherpad in tabs
12:36:07 <clokep> flo-retina: I've wanted to do that a bunch of times.
12:36:11 <flo-retina> it seemed difficult last time we discussed it. But then nhnt11 changed lots of things in tabbrowser :)
12:36:15 <clokep> It's on my todo list. ;)
12:36:45 <aleth> With the colours matching IB nick colours :)
12:37:10 * clokep wanted the etherpad to be in a tab and the chat portion of it to be a separate MUC that would open.
12:37:33 <aleth> Could do without the chat portion to start with.
12:37:57 <flo-retina> aleth: well, Ib is a bit about chatting ;)
12:38:05 <flo-retina> aleth: but maybe we could do an etherpad prpl
12:38:11 <clokep> flo-retina: That was my thought.
12:38:13 <aleth> flo-retina: But Ib can already do chatting ;)
12:38:43 <flo-retina> aleth: so basically we would need to split the conv area in 2 parts, one for the pad, one for the chat
12:38:44 <clokep> The "server" you put in would be the server to automatically load into Instantbird (i.e. etherpad.mozilla.org vs. etherpad.org or whatever)
12:38:59 <flo-retina> aleth: could be done in a similar way that we will do the webrtc video ;)
12:39:20 <flo-retina> clokep: I wonder how that would handle private pads :-S
12:39:29 <flo-retina> (where a Persona login is required)
12:39:32 <clokep> Prompt you for a password? :P
12:39:33 <aleth> flo-retina: That sounds good.
12:39:45 <clokep> flo-retina: That's for version 2? :-D
12:39:47 <aleth> flo-retina: Would that be similar to oauth (also ugly)?
12:40:02 <aleth> Maybe we could move that to a tab now...
12:41:00 <flo-retina> aleth: yeah, Persona is like oauth, but with less users :-P
12:41:09 <clokep> And only works half the time.
12:41:17 <flo-retina> aleth: oh yes, that oauth dialog would move to a tab :)
12:42:44 <clokep> File a bug? ;)
12:45:03 <flo-retina> for etherpad?
12:45:12 <flo-retina> ah, no, the oauth dialog in a tab
12:45:25 <flo-retina> that's a boring bug to work on :-/
12:45:47 * nhnt11 wonders which bug he needs to submit a patch on
12:46:00 <clokep> nhnt11: All of them? :P
12:46:05 <clokep> Smaller patches are better...
12:46:06 <aleth> Fix all the bugs!
12:46:12 <aleth> :D
12:46:29 <clokep> flo-retina: Yes, but we should file the bug anyway so if someone gets bored on a plane or a train or an automobile they can fix it?
12:47:28 <-- nhnt11 has quit (Ping timeout)
12:47:35 <flo-retina> aleth: "This is probably a more general CSS error actually as similar textboxes in the error console also have this problem." could this be that you just have a messed up GTK theme?
12:48:10 <flo-retina> clokep: I usually don't find enough space in planes to open my laptop :(
12:48:19 <aleth> flo-retina: No, but it could be that it's the lack of 64bit builds
12:48:25 <flo-retina> and my train rides are all taken by review queues
12:48:42 --> nhnt11 has joined #instantbird
12:50:09 <clokep> Yeah, I find planes uncomfortable to work on.
12:50:16 <clokep> And I'm usually driving in cars. ;)
12:50:57 <clokep> The new findbar on Nightly is really nice. :) I hope that was a toolkit change.
12:51:11 <nhnt11> clokep: Heh, I don't think I've fixed all of them :P
12:52:37 <clokep> https://bug776708.bugzilla.mozilla.org/attachment.cgi?id=741327
12:53:19 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:53:34 --> nhnt11 has joined #instantbird
12:56:19 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:57:11 --> nhnt11 has joined #instantbird
13:03:25 <nhnt11> flo-retina: I'm going to go ahead and r? you on all these bugs
13:03:53 * flo-retina isn't sure if he should feel lucky or hide ;)
13:05:07 <clokep> People can always steal them. :)
13:05:10 <-- nhnt11 has quit (Ping timeout)
13:05:30 <flo-retina> yeah, feel free to steal all my reviews :)
13:06:29 --> nhnt11 has joined #instantbird
13:07:17 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2582 on bug 2040.
13:07:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2040 nor, --, ---, nhnt11, ASSI, New conversation tab has generic placeholder icon (a.k.a. the Firefox "New Tab" icon)
13:08:02 * nhnt11 finds bug 2042.. weird.
13:08:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2042 nor, --, ---, nobody, NEW, Starting conversations on unrelated keyboard- or mouse-events
13:08:47 <nhnt11> flo-retina: I'm going to go ahead and fix the selection issues in bug 2041.
13:08:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nobody, NEW, "Enter" always opens conversation with first contact in the filtered list
13:09:12 <nhnt11> Maybe a new bug is required... hmm
13:09:19 <nhnt11> It fixes the problem in 2042 though
13:09:40 <instantbot> clokep@gmail.com granted review for attachment 2582 on bug 2040.
13:09:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2040 nor, --, ---, nhnt11, ASSI, New conversation tab has generic placeholder icon (a.k.a. the Firefox "New Tab" icon)
13:09:54 <clokep> nhnt11: Use that bug, it's fine.
13:18:42 <nhnt11> clokep: You want r? on this? :)
13:18:59 <instantbot> aleth@instantbird.org granted feedback for attachment 2578 on bug 2039.
13:19:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2039 nor, --, ---, atuljangra66, ASSI, File Transfer Backend
13:20:41 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2583 on bug 2041.
13:20:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list
13:24:25 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2584 on bug 2043.
13:24:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, ---, nhnt11, ASSI, Icon sizes are totally wrong on Windows Aero in awesometab
13:24:52 <nhnt11> That's all I've got for now :)
13:26:26 <aleth> Initial reviews always take longer than expected :-/
13:26:44 <nhnt11> aleth: I'm afraid I can't really help much on the linux styling :(
13:26:45 <clokep> nhnt11: Does that file exist?
13:26:54 <nhnt11> Maybe if I get ubuntu to run on my old laptop...
13:27:19 <flo-retina> nhnt11: I would do it on the new laptop ;)
13:27:22 <flo-retina> with a VM
13:27:49 <nhnt11> flo-retina: Yay I forgot that is feasible on this machine :D
13:28:08 <nhnt11> clokep: What do you mean?
13:28:14 <nhnt11> newtab.css exists...
13:28:25 <clokep> That was my question.
13:28:30 <nhnt11> That's what applies all the styling to the newtab :)
13:28:38 * flo-retina should have r+'ed that patch :-P
13:28:43 <instantbot> clokep@gmail.com granted review for attachment 2584 on bug 2043.
13:28:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2043 nor, --, ---, nhnt11, ASSI, Icon sizes are totally wrong on Windows Aero in awesometab
13:29:25 <clokep> I'm leaving 2041 to you.
13:29:48 * nhnt11 goes home
13:29:52 <nhnt11> Bye for now
13:30:08 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:33:30 <flo-retina> with the patch in bug 2041,will the first item look highlighted by default?
13:33:37 <flo-retina> nhnt11: ^^^
13:33:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list
13:34:29 <aleth> clokep: "This is usually only used when we want to return the value" I thought current JS practice was to always return a value?
13:44:23 * qheaden_away is now known as qheaden
13:45:20 <qheaden> Hello everyone.
13:47:25 <-- jb has quit (Quit: jb)
13:48:30 --> jb has joined #instantbird
13:49:50 <-- jb has quit (Quit: jb)
13:50:52 <clokep> aleth: What does "current JS practice" mean?
13:50:55 <clokep> qheaden: Hello.
13:51:08 <aleth> clokep: "what we do in new JS code"
13:51:26 --> jb has joined #instantbird
13:52:19 <aleth> I don't know how strict we want to be about that. Usually it seems clear from the context
13:52:46 <aleth> But writing a callback so a potential return value is passed through seems good to me
13:54:14 <aleth> In fact, in that particular case, I should have suggested |callback: aSubject.reject|
13:54:30 <aleth> Or does that seem wrong to you?
13:55:22 <clokep> That seems fine to me.
13:55:47 <clokep> aleth: So I don't like returning unused values. :)
13:55:55 <clokep> That's why I didn't comment on it in the first place.
13:56:01 <clokep> I find it confusing.
13:56:39 <aleth> Yeah, that's what I meant by context. But in this case we're just passing stuff along and it doesn't hurt to be agnostic.
13:59:37 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
14:05:27 --> mconley has joined #instantbird
14:24:27 --> flo-retina has joined #instantbird
14:24:27 * ChanServ sets mode +qo flo-retina flo-retina 
14:30:54 <-- flo-retina has quit (Ping timeout)
14:33:13 --> flo-retina has joined #instantbird
14:33:13 * ChanServ sets mode +qo flo-retina flo-retina 
14:36:12 --> nhnt11 has joined #instantbird
14:46:04 <nhnt11> flo-retina: http://log.bezut.info/instantbird/today/#m530 - Yes. It was the best solution I could think of to make it obvious which conversation is going to be opened.
14:46:06 <nhnt11> I hope you agree
14:46:55 <flo-retina> I agree with "best solution[...] to make it obvious which conversation is going to be opened.". That doesn't mean it doesn't have drawbacks
14:47:25 <flo-retina> nhnt11: btw it's helpful when attaching a patch that changes the behavior if you include a 1 or 2 lines comment in the bug that explains what the new expected behavior is.
14:48:20 <nhnt11> flo-retina: I plan a follow-up to complete the current name being typed in the textbox (like the awesomebar) that will probably help make this better. (We won't need to select the first item anymore)
14:48:23 <flo-retina> nhnt11: I wonder if it wouldn't be confusing to have an highlighted item and the focus in the filter box at the same time.
14:48:31 <nhnt11> flo-retina: Okay, I'll keep that in mind.
14:48:33 <nhnt11> Hmm.
14:49:35 <aleth> "I wonder if it wouldn't be confusing to have an highlighted item and the focus in the filter box at the same time." So do I
14:50:09 <aleth> Also it'll be weird when the mouse leaves the window and the selection jumps to the top
14:50:24 <nhnt11> aleth: That won't happen
14:50:27 <flo-retina> aleth: I don't think it would jump at the top
14:50:30 <flo-retina> I see no reason why
14:50:34 <nhnt11> It only jumps to top when the user types
14:51:14 <aleth> Oh OK.
14:54:00 <clokep> qheaden: So you're reorganizing some code again, right? :)
14:58:11 <-- novabyte has quit (Ping timeout)
15:02:23 --> novabyte has joined #instantbird
15:02:25 <instantbot> New Instantbird (UI) bug 2047 filed by aleth@instantbird.org.
15:02:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nobody, NEW, Escape key should close awesometab
15:03:09 <nhnt11> aleth: Does it sound right to close the tab if the search bar is empty, but clear the search bar otherwise?
15:03:47 <aleth> nhnt11: Yes
15:05:30 <nhnt11> I guess for consistency, this should be onkeydown and not keyup
15:06:29 <aleth> I can't remember what it is for conversations.
15:06:33 <-- jb has quit (Quit: jb)
15:06:40 <instantbot> New Instantbird (UI) bug 2048 filed by aleth@instantbird.org.
15:06:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2048 nor, --, ---, nobody, NEW, Click on awesometab when window is unfocused should not open conversation
15:07:02 <nhnt11> aleth: it's keydown
15:07:19 * flo-retina would have expected keypress :-D
15:07:47 <nhnt11> Patch coming up
15:08:45 <-- novabyte has quit (Ping timeout)
15:08:53 * nhnt11 should properly set dependencies in this bugs to make sure they're applied in the right order (to avoid conflicts)
15:09:00 <nhnt11> on these*
15:09:45 <nhnt11> Does this need a comment like "Close tab if filterbox is empty"?
15:09:50 <nhnt11> I think it's pretty self-explanatory
15:10:27 <aleth> You don't need comments if they take as long to read as the corresponding code ;)
15:11:05 <qheaden> clokep: Yeah. I'm doing some reorganization.
15:11:27 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2585 on bug 2047.
15:11:30 <aleth> nhnt11: We generally don't set "depends on" to denote checkin order. It's only used when the code itself actually depends on something that landed earlier
15:11:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab
15:11:37 <qheaden> I'll be back shortly
15:11:47 <nhnt11> Hmm okay
15:11:58 <nhnt11> That patch seems to have broken while uploading
15:12:01 <nhnt11> Sorry, uploading again
15:12:47 --> novabyte has joined #instantbird
15:13:29 <nhnt11> Ah, I apparently didn't mark it as a patch. Fixed now.
15:13:42 <nhnt11> Oh no, a nit :(
15:15:03 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2585 on bug 2047.
15:15:04 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2586 on bug 2047.
15:15:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab
15:17:42 <nhnt11> I may not be able to do more than followups tonight, I need to sleep :(
15:21:36 <aleth> That might be a good idea if you are tired ;)
15:21:46 <aleth> There comes a point where too many mistakes creep in...
15:24:46 --> jb has joined #instantbird
15:24:50 <-- jb has quit (Input/output error)
15:25:42 <instantbot> aleth@instantbird.org denied review for attachment 2586 on bug 2047.
15:25:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab
15:26:50 --> jb has joined #instantbird
15:27:08 <nhnt11> aleth: Using a <key> would mean we won't have the escape-once-to-clear-filterbox functionality right?
15:27:22 <nhnt11> Never mind, we can check from there...
15:27:43 <aleth> No, I don't mean use the <key>!
15:27:58 <aleth> Just put it in the existing keyboard event handlers.
15:28:05 <nhnt11> Keyup?
15:28:22 <nhnt11> aleth: But using the <key> would mean escape works to close any arbitrary tab
15:28:25 <nhnt11> About panels for example
15:29:22 <nhnt11> Be back after dinner.
15:29:27 <aleth> If you want to do it that way, you'll have to distinguish between conversations and non-conversations
15:29:45 <aleth> And change the name from key_putOnHold
15:30:32 <aleth> Might be a good idea actually, for the reason you gave.
15:31:02 <-- nhnt11 has quit (Ping timeout)
15:31:42 <aleth> Whether you need to worry about the clear-filterbox thing depends on the order in which the two key event handlers are processed (find out)
15:32:59 <-- jb has quit (Ping timeout)
15:34:08 --> jb has joined #instantbird
15:36:21 <-- gerard-majax_ has quit (Ping timeout)
15:41:33 --> nhnt11 has joined #instantbird
15:42:30 <nhnt11> aleth: I could add another tabpanel method that would be invoked by the command
15:42:47 <nhnt11> That way the conversation tabs can put themselves on hold, and other tabs could do whatever behavior they wanted.
15:42:59 <nhnt11> Without having to differentiate in the command itself
15:43:50 <aleth> I don't think that's needed for now, as we already differentiate here http://lxr.instantbird.org/instantbird/source/instantbird/content/instantbird.xul#59
15:44:24 <aleth> If you change that to |if (tabbrowser.selectedConversation) tabbrowser.selectedConversation.hide();| that should work, right?
15:44:38 <nhnt11> Yes.
15:44:57 <aleth> If later on we find that some third type of tabs wants more, we can still add extra methods.
15:45:11 <nhnt11> Then I would have to check if it's an awesometab, and close it only if filterbox.value is ""
15:45:37 <aleth> Not if the escape key gets handled by the awesometab key handler first (this needs checking)
15:45:46 <aleth> Then you can handle that case there.
15:46:00 <nhnt11> Hmm..
15:46:31 <nhnt11> How would I check for that from the command?
15:46:44 <nhnt11> I would have thought of preventDefault in the newtab handler..
15:47:12 <aleth> Why would you have to? If you handle it in newtab, call preventDefault or stopPropagation or whatever, if not...
15:47:46 <nhnt11> Cool. But last time I tried that in a handler, it didn't work properly... I'll experiment now.
15:48:09 <aleth> If you find yourself having to "check if it's an awesometab, and close it only if filterbox.value is """ in instantbird.xul, that's an argument for a new tabpanel method I think.
15:48:20 <nhnt11> Yeah.
15:49:37 <aleth> preventDefault etc seems to work here http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#512, but I'm not sure about when <keys> are handled
15:50:18 <nhnt11> Hm
15:50:30 * nhnt11 is making good use of queues for these followups :)
15:50:49 <-- novabyte has quit (Quit: bye bye)
15:51:04 <qheaden> Back.
15:52:15 <nhnt11> aleth: It works :)
15:52:27 <aleth> Great :)
15:52:37 <nhnt11> I still want to put it in keydown though :-/
15:52:54 <aleth> Why?
15:53:04 <nhnt11> that's the way it works for conversation tabs..
15:53:12 <nhnt11> So you can hold escape and close all tabs
15:53:16 <nhnt11> (I think someone wanted this?)
15:53:26 <nhnt11> But that would probably be keypress...
15:53:30 <aleth> For conversation tabs, it's the <key>, not keydown
15:53:49 <nhnt11> Yeah, but the command is executed on keydown for me
15:54:14 <aleth> What if you use keypress not keydown?
15:54:39 <nhnt11> "hold escape and close all tabs" already works with keydown btw
15:54:57 <aleth> I'm sure it does. But does it make it too easy to close two tabs by mistake?
15:55:05 <nhnt11> No.
15:55:09 <nhnt11> Not at all.
15:55:15 <aleth> OK then.
15:55:37 <aleth> "the command is executed on keydown for me" just surprised me
15:55:47 <nhnt11> At least on Mac with my input settings, there's quite a sufficient pause before closing
15:55:51 <nhnt11> aleth: Is it different for you?
15:56:19 <aleth> I haven't checked with dump()s 
15:56:34 <aleth> I would have expected keypress.
15:56:46 <nhnt11> ah
15:57:02 <nhnt11> That's what you were saying. Well I'm not sure if it's keydown or keypress
15:57:13 <nhnt11> But the tab is closed as soon as I "down" the key.
15:57:55 <aleth> I'm not sure whether finding out by looking at dxr for a bit is a waste of time or not ;)
15:58:12 <nhnt11> Probably is.
15:58:15 <nhnt11> I'll just use keypress
15:58:19 <nhnt11> Seems more logical.
15:58:34 <aleth> Actually you already use keydown, right?
15:58:37 <aleth> In the newtab?
15:58:44 <qheaden> clokep, flo-retina: Does this need to be modified if I put two different protocol components in a single JS file? "const NSGetFactory = XPCOMUtils.generateNSGetFactory([YahooProtocol]);"
15:58:45 <aleth> http://lxr.instantbird.org/instantbird/search?string=keydown
15:58:46 <nhnt11> No, I use keyup for the enter key
15:59:02 <nhnt11> :O
15:59:05 * nhnt11 forgot about that
15:59:09 <nhnt11> I'm blind
15:59:32 <aleth> Maybe find out the exact difference between keypress and keydown and then consistently use one or the other for both ;)
15:59:49 <nhnt11> aleth: They seem to be identical for me
15:59:56 <nhnt11> Tried both, could see no difference
16:00:02 <nhnt11> But I haven't looked at any documentation/code
16:00:18 <nhnt11> Afaik keypress is a keydown+keyup.
16:00:25 <aleth> Looking at documentation/code was what I meant by "finding out" ;)
16:00:29 <nhnt11> :P
16:01:39 <nhnt11> aleth: OH
16:01:42 <nhnt11> Yay
16:01:50 <nhnt11> It turns out the filterbox automatically stops propagation
16:01:57 <nhnt11> So I don't need a handler in newtab at all.
16:01:59 <nhnt11> It just... works.
16:02:00 <nhnt11> :)
16:02:07 <aleth> Even better :)
16:02:48 <aleth> sorry, gtg
16:02:53 <nhnt11> Okay, bye!
16:03:01 <nhnt11> I'll ask flo for an r? If you don't mind
16:03:09 <aleth> sure
16:03:14 <-- aleth has quit (Quit: Ciao)
16:07:10 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2587 on bug 2047.
16:07:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2047 min, --, ---, nhnt11, ASSI, Escape key should close awesometab
16:09:20 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:23:56 <qheaden> Okay, I created two more Yahoo! JAPAN accounts.
16:36:50 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:37:12 --> nhnt11 has joined #instantbird
16:40:03 <qheaden> How can I convert strings to/from unicode? Any helper objects that do that?
16:41:24 <qheaden> Nevermind, I found something.
16:41:57 <-- flo-retina has quit (Ping timeout)
16:43:03 --> flo-retina has joined #instantbird
16:43:03 * ChanServ sets mode +qo flo-retina flo-retina 
16:47:53 --> Mook_as has joined #instantbird
16:48:20 <-- Optimizer has quit (Ping timeout)
16:48:25 --> Optimizer has joined #instantbird
16:50:54 <-- flo-retina has quit (Ping timeout)
16:51:12 --> flo-retina has joined #instantbird
16:51:12 * ChanServ sets mode +qo flo-retina flo-retina 
17:00:02 <-- jb has quit (Ping timeout)
17:02:34 <clokep> qheaden: Yes, it's an array. List both of them.
17:03:31 <qheaden> clokep: I'm modifying the send/receive message functions. I'm adding in encoding support. I tried to send and receive a message with Japanese characters, and the characters were gabled.
17:03:34 <qheaden> *garbled.
17:03:46 <qheaden> I think I fixed it though.
17:04:00 <clokep> qheaden: IRC has sutff for that...
17:05:14 <qheaden> clokep: Yeah, I saw.
17:08:38 * nhnt11 is tired
17:08:40 <nhnt11> Good night
17:08:45 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:29:54 <qheaden> clokep: So I would inherit YahooProtocol like this: "YahooJapanProtocol.prototype.__proto__ = YahooProtocol"?
17:30:07 <clokep> qheaden: Yes.
17:30:12 <qheaden> Okay.
17:30:24 <clokep> qheaden: But do it in the prototype object.
17:30:33 <clokep> Just like you do with GenericProtocol
17:30:40 <qheaden> OK.
17:34:19 <qheaden> clokep: Hmm, the YahooJapanProtocol constructor is throwing an error saying there is no such function this.registerCommands(). I think it is looking at YahooProtocol instead of GenericProtocolPrototype.
17:35:48 <Mook_as> might want to use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create ?
17:36:08 <Mook_as> hmm. maybe I have no idea what I'm talking about ;)
17:49:20 <clokep> qheaden: I need to see code.
17:50:02 <qheaden> clokep: http://pastebin.instantbird.com/243957
17:52:01 <Mook_as> qheaden: YahooJapanPrototocol.prototype.__proto__ = YahooProtocol.prototype;
17:52:08 <Mook_as> (or = new YahooProtocol(); )
17:52:27 <Mook_as> (depends on which one works, of course)
17:52:35 <qheaden> Ahh okay. 
17:52:50 * qheaden still struggles to understand JS inheritance sometimes.
17:54:05 <clokep> Ah, sorry. Yes you have to set the prototypes.
17:54:10 <clokep> That's because it doesn't make any sense. ;)
17:55:21 <qheaden> Okay. __proto__ = YahooProtocol.prototype worked. :)
17:56:13 <qheaden> clokep: Also, is this how you and flo-retina wanted the manifest file? http://pastebin.instantbird.com/243958
17:58:10 <clokep> qheaden: Yes.
17:58:19 <qheaden> OK.
17:59:34 <clokep> qheaden: Btw the second ID should be  prpl-yahoojp
17:59:38 <clokep> Not yahoojapan.
17:59:46 <clokep> (See https://wiki.instantbird.org/Protocol_Identifiers)
17:59:50 <qheaden> clokep: OK.
18:11:39 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:22:21 <qheaden> I keep getting this error when I changed from prpl-yahoojapantest to prpl-yahoojptest. http://pastebin.instantbird.com/243980
18:22:33 <qheaden> I tried running Ib using the -purgecaches flag.
18:22:50 --> atuljangra has joined #instantbird
18:23:13 <atuljangra> Hi!
18:23:24 <atuljangra> clokep: No, I didn't include the binary stuff. 
18:23:45 <atuljangra> Some case were not getting properly implemented thus wanted to discuss this.
18:23:54 <clokep> qheaden: Did you also change it in the component definition?
18:24:00 <clokep> You'll need to create a new account / hack about:config btw.
18:24:16 <clokep> atuljangra: OK, I'd rather see that as a diff against this anyway.
18:24:59 <atuljangra> clokep: sending 3-4 images zipped in one file is not "identified" properly on the receiver side.
18:25:08 <qheaden> clokep: If you mean the definition in the manifest, yes I changed all of that.
18:25:14 <clokep> I don't know what "idenitifed"
18:25:22 <clokep> qheaden: No. Inside of yahoo.js.
18:25:28 <clokep> It gives the prpl ID, I think.
18:26:09 <clokep> qheaden: http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#703
18:26:18 <clokep> Because your names are "wrong" the ID is wrong.
18:26:31 <clokep> Well not wrong.
18:26:37 <clokep> But hard code the ID to be yahoojp in that case.
18:26:45 <clokep> And the other one should be yahoo.
18:26:53 <clokep> (Ummm, prefix those w/ prpl-)
18:27:19 <qheaden> clokep: Oh okay. I don't even have an ID set on the normal Yahoo protocol. I'll set those now.
18:28:42 <atuljangra> clokep: I mean, the  data is being transferred and is received on the receiver side, but when I try to open the zipped file, it is not opened correctly.
18:28:46 <qheaden> clokep: That worked. Thanks. :)
18:28:51 --> mikk_s has joined #instantbird
18:29:25 <clokep> atuljangra: Did you look at what's different? I'd still look to see code
18:29:27 <clokep> qheaden: Rgr.
18:30:11 <atuljangra> clokep: Okay. Pushing the code to my bitbucket would help? That way you can see the diff in more presentable way.
18:30:47 <clokep> No.
18:31:00 <clokep> A diff from the previous patch would be ideal.
18:31:33 <atuljangra> Okay. Will pastebin it.
18:31:52 * clokep isn't sure what atuljangra's focus should be though.
18:31:59 <clokep> Have you met all the review comments you've received so far?
18:32:49 <atuljangra> Yes, I was going through them only. First xmpp one, and then non xmpp one.
18:33:36 <atuljangra> What do you guys want me to do next? File link or another xmpp ft implementation, so that we can have a working ft in xmpp.
18:33:37 <-- mikk_s has left #instantbird ()
18:34:36 <clokep> I thought I stated pretty clearly that we will not have you work on another XMPP file transfer implementation right now.
18:34:42 <clokep> And that we want you to do FileLink next.
18:35:01 <clokep> And that you should start a dialogue about the design of this while working on review comments.
18:35:17 <atuljangra> Awesome. Yes. I was just confirming.
18:37:49 <atuljangra> So, I wanted to discuss the filelink implementation, and how should I start it. Should we discuss this now, or should we wait for flo, Mic and aleth. Anything is fine with me.
18:38:53 <clokep> I've said repeatedly that you should discuss it with Florian, but it would be best if you've shown you've put some thought into it instead of just asking "What should I do?" Do you have any initial thoughts, etc.
18:39:13 <clokep> You can write to that m.d.chat list if people don't seem to be around when you need them.
18:39:19 <clokep> (Hence why starting dialogue early is good.)
18:41:21 <atuljangra> Okay. Sorry.
18:44:14 <atuljangra> I was thinking that first I can implement the file link feature with any one server. This part will involve defining the interface for the storage-providers. This would be helpful in using multiple storage providers.
18:44:40 <clokep> atuljangra: No, all that was done already by mconley, we're going to use their intrefaces.
18:45:19 <atuljangra> We can then, test this alone, i.e. without considering it as a fallback for normal ft.
18:45:19 <atuljangra> And then implement the fallback mechanism which will choose which method for ft should be used.
18:45:50 <atuljangra> clokep: Yes. That's why this can be tackled first. 
18:46:02 <atuljangra> (these are my thoughts)
18:46:17 <clokep> Can you write them up in an email and send it to the mozilla.dev.chat mailing list? I need to go.
18:47:22 <atuljangra> Ok.
18:57:45 <atuljangra> I'll switch to proxy internet and work on patches + filelink
18:59:27 <-- atuljangra has quit (Ping timeout)
19:05:26 --> atuljangra has joined #instantbird
19:07:11 <atuljangra> back :)
19:12:44 <-- clokep has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:21:44 --> Mic has joined #instantbird
19:21:45 * ChanServ sets mode +h Mic 
19:22:03 <Mic> Good evening
19:24:55 <atuljangra> Good evening :)
19:34:55 <Mic> What the thing with tabs needing to be closed on escape. That's as non-standard as the escape should minimize that we had before (even though I like the latter better;) :S
19:35:14 <Mic> Why is Ctrl(Accel?)+W not good enough for that?
19:35:46 <Mic> You can also keep that pressed to close a lot of tabs at once and you won't press it by accident as likely as the escape key.
19:36:14 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
19:36:28 <Mic> If the goal is really to close all tabs of a window, we should assign that a key (e.g. Ctrl+Shift+W as in Firefox).
19:46:49 <Mic> atuljangra: did the UI part work eventually?
19:51:38 --> atuljangra has joined #instantbird
19:52:48 <atuljangra> mic Yes. I've attached a patch for the same. I'll address aleth's comment and update a new patch soon.
19:53:31 <Mic> OK, nice. Please ping me in case that instantbot doesn't announce the upload.
19:54:17 <atuljangra> Sure. I'm working on xmpp patch currently. Will upload the ui patch in about 30 mins.
20:14:13 --> clokep has joined #instantbird
20:14:13 * ChanServ sets mode +o clokep 
20:21:27 <atuljangra> Mic: |dataTransfer = aEvent.dataTransfer;| Can dataTransfer be undefined. If yes how can I check it, i mean if(!dataTransfer) or something like that. This is in conversation.xml
20:22:46 <Mic> Please show me a bit of the surrounding code.
20:23:02 <atuljangra> Mic: OKay.
20:23:32 <atuljangra> Mic: http://pastebin.instantbird.com/244026
20:26:29 <qheaden> clokep: I'm getting a little confused with the message encoding stuff.
20:26:41 <qheaden> When a send a message to a buddy, should I automatically convert it to unicode?
20:27:37 <clokep> qheaden: Umm...so I get super confused to. :(
20:27:47 <clokep> Is the protocol UTF-8?
20:27:54 <clokep> (You might hvae to check what libpurple does...)
20:28:00 <qheaden> clokep: Yes it is UTF-8.
20:28:12 <qheaden> Key/value 97 on a message is 1 if the message being sent is UTF-8.
20:28:36 <clokep> So you should be able to just send everything in UTF-8 and I'm sure what your question is. ;)
20:29:00 <Mic> atuljangra: I would think that dataTransfer will always be there for drag and drop event.
20:29:21 <qheaden> clokep: Does does the ConvertToUnicode() method convert to UTF-8, or UTF-16?
20:29:25 * qheaden hates encoding stuff.
20:29:41 <atuljangra> Mic: I had the same thought. Thanks :)
20:30:59 <clokep> qheaden: I do too. I don't know what it's doing honestly, we need to ask Florian.
20:31:15 <clokep> qheaden: Let me start a c-c build then maybe I can look.
20:32:02 <qheaden> clokep: I converted an incoming message to unicode, and it printed correctly in the chat window. But when I sent an unencoded Japanese message to Pidgin from my plug-in, it turned up as garbled text in Pidgin's chat window.
20:32:49 <clokep> qheaden: Where is the convertounicde function?
20:33:22 <qheaden> clokep: Here is the page on it: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIScriptableUnicodeConverter
20:33:32 <Mic> atuljangra: it seems that dataTransfer is the only attribute that drag events can have ;)
20:33:57 <atuljangra> Mic yes and thus it is always defined :D
20:34:10 <clokep> qheaden: So I think it converts it to whatever JS uses. Mook_as?
20:34:17 <Mic> (beside what they seem to inherit from mouse events)
20:34:35 <atuljangra> yes, of course. :)
20:35:00 <qheaden> clokep: I think this is the implementation: http://mxr.mozilla.org/mozilla-central/source/intl/uconv/src/nsScriptableUConv.cpp
20:35:20 <Mook_as> 16-bit random crap that is some sort unicode?
20:35:56 <Mook_as> are you talking about this convertToUnicode? http://mxr.mozilla.org/mozilla-central/source/intl/uconv/idl/nsIScriptableUConv.idl#39
20:36:49 <qheaden> Mook_as: Yes, that one.
20:37:00 <Mook_as> UTF16-native-endian, I think
20:37:22 <Mook_as> either way, I think you want to convert it to utf8 to go back to yahoo, right?
20:37:24 * clokep wonders what endian Yahoo is anyway...
20:37:49 <Mook_as> (utf8 has no endianness, considering that both ends are the same byte...)
20:38:14 <clokep> There might be other fields which are multi-byte. :-D
20:38:49 * qheaden sighs
20:44:05 <qheaden> I'm going to convert all outgoing messages to Unicode and see how the other clients respond to it.
20:44:37 <Mic> Is BigFile == FileLink == cloud_files?
20:44:38 * clokep has a feeling you want to ConvertFromUnicode? I always get confused though.
20:44:41 <Mic> :S
20:44:50 <clokep> Mic: == ...something else too.
20:45:02 <atuljangra> I guess so :s
20:45:02 <clokep> m conley might remember other names
20:45:04 <Mic> I propose calling it *Persona* too.
20:45:16 <Mic> Just because anything can have that name.
20:45:26 <atuljangra> haha :P We can have a fancy name ;)
20:46:13 <qheaden> Lets just have nhnt11 create awesometranslatetab and leave encoding alone. :P
20:46:40 <Mook_as> you *might* need convertToByteArray, depends on what the rest of your pipeline looks like
20:47:02 <Mook_as> (or convertToInputStream, or...)
20:47:33 <Mic> atuljangra: you don't want to /implement/ FileLink, you rather want to use the existing implementation in Instantbird, right?
20:48:30 <atuljangra> Mic: I guess that's the plan. If it's already implemented, then we can use it.
20:48:41 * atuljangra doesn't have any strong opinion though
20:48:47 <Mic> clokep: wasn't there talk about moving the FileLink stuff somewhere else, so IB could more easily use it?
20:48:55 <Mic> Somewhere into /chat/ iirc?
20:49:17 <atuljangra> Mic: Yes, it was in one of the meetings.
20:49:36 --> jb has joined #instantbird
20:50:00 <atuljangra> clokep volunteered me to do that, so this is also on the list.
20:50:24 <clokep> Mic: We're going to copy and paste it in for now.
20:50:32 <clokep> atuljangra: I have a VERY strong opinion about that.
20:50:37 <clokep> You WILL NOT be reimplementing it.
20:50:41 <clokep> The point is to leverage existing code.
20:51:05 <atuljangra> clokep: Okay :D
20:52:15 <atuljangra> brb 5 mins
20:53:28 * clokep keeps trying to rejoin MUCs from the awesometab. :(
20:58:47 <qheaden> clokep: What do you make of this function? http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/util.c#130
20:59:11 <qheaden> clokep: It looks like it takes the UTF-8 string and converts it to the local character set found in the options.
20:59:48 <clokep> qheaden: Or does it do the opposite, did you look up g_convert_with_fallback?
21:00:05 <qheaden> clokep: Here it is used when sending a packet http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/yahoo/libymsg.c#4611
21:00:48 <Mook_as> I'd hope to_codeset is the destination encoding
21:00:49 <qheaden> clokep: Here is the definition http://lxr.instantbird.org/instantbird/source/purple/libraries/glib/gconvert.c#798
21:01:06 <qheaden> In the sendIm function, it seems to be converting from UTF-8 to the local charset before sending.
21:01:13 * Mook_as notes the suspicious if (yd->jp) check on line 136
21:01:32 <qheaden> Hence the to_codeset variable.
21:01:48 <clokep> qheaden: Yea, looks like they have you specify an encoding like we do for IRC.
21:01:49 * clokep pouts.
21:02:29 <qheaden> As Mook_as saw, it seems to return early when we are using Yahoo Japan. :-S
21:02:45 <atuljangra> back
21:03:55 <atuljangra> So copy pasting the code in chat/ is a temporary thing right? We would be making permanent changes right?
21:04:32 <clokep> atuljangra: I don't understand the question.
21:06:12 <atuljangra> clokep: The migration of code that Mic was referring to is just copy pasting? :)
21:06:19 <clokep> Yes.
21:06:28 <clokep> Copy & paste the entire cloudfile folder into Instantbird.
21:07:15 <atuljangra> Oh okay.
21:09:55 <clokep> Umm....I don't know if it shld go under  instantbird/ or chat/ :-/
21:10:04 <atuljangra> clokep: Thoughts http://pastebin.instantbird.com/244040
21:10:15 * atuljangra thinks chat/ :s
21:11:30 <clokep> One second, talking to someone in #maildev.
21:11:49 <atuljangra> No pbm :)
21:11:59 <clokep> atuljangra: What is "fileReceived"?
21:13:14 <clokep> What does that method do?
21:13:20 <atuljangra> This is the method that I'm using to send notifications to the ui. I need to rename this to a better name.
21:13:29 <qheaden> clokep: I'm looking at yahoo_string_decode, and it seems that, if the protocol is Yahoo JAPAN, it is hardcoded to convert from SHIFT_JIS to UTF-8. It it is normal Yahoo, it converts from the codeset specified in the options into UTF-8.
21:13:43 <Mic> I think you'd need to inline that somwhere.
21:14:16 <clokep> atuljangra: So that's the method that gets called when someone proposes a FT to us?
21:14:24 <clokep> That NEEDS to be in the interface, that's VERY important!
21:14:34 <atuljangra> Mic: Yes, I think that would be the best idea. Name: fileTransferOfferNotif?
21:14:35 <clokep> qheaden: Not surprising.
21:15:14 <atuljangra> clokep: Okay so a inline method in the interface? Name: fileTransferOfferNotif?
21:15:14 * Mic doesn't like the abbreviation "notif" :S
21:15:29 <qheaden> clokep: So I guess with regular Yahoo, we can hard code the local_carset option to SHIFT_JIS?
21:15:29 <atuljangra> okay fileTransferOffer ?
21:15:34 <clokep> Idk what an "inline method" means in this context.
21:15:49 <clokep> qheaden: Do you mean with Yahoo JAPAN?
21:16:02 <qheaden> clokep: Yeah, Yahoo JAPAN. :P
21:16:11 <clokep> qheaden: Yes, something like that seems reasonable. ;)
21:16:13 <Mic> atuljangra: ignore the inline thing.
21:16:23 <qheaden> clokep: Okay, I'll try it.
21:16:25 <atuljangra> Mic: Ok.
21:16:39 <clokep> :)
21:16:47 <clokep> qheaden: Encodings scare me, sorry I'm not helpful.
21:16:53 <qheaden> clokep: Same here. :)
21:18:15 * qheaden is not a fan of i18n, although he knows it has to be done.
21:18:37 <clokep> qheaden: Us stupid Americans, eh?
21:18:43 <qheaden> :P
21:19:05 * clokep notes that he sounded Canadian there. ;)
21:21:39 * clokep has a Moz 22 build going!!!
21:22:21 <Mic> Good luck!
21:22:22 <Mic> :)
21:22:26 <clokep> Mic: If you open too many tabs...and then click the little down arrow to pick a tab....
21:22:32 <clokep> Does the "scrollbar" look awful to you?
21:22:38 <Mic> Yes.
21:22:44 <Mic> That's because it's not one.
21:22:55 <Mic> It's "border-right"s on the menu items afaik.
21:23:09 <clokep> What's it trying to show? :-S
21:23:18 <Mic> The visible items in the tabstrip.
21:23:23 <clokep> It looks...bad. :(
21:23:46 <Mic> Not worse than in Firefox ;)
21:24:27 <Mic> It's looking bad, yes.
21:25:40 <clokep> OK! :)
21:25:44 <clokep> As long as it's as bad as Fx. ;)
21:34:32 <qheaden> clokep: Well, I'm going to have to sign off now. I'm going to continue to look at this through the weekend.
21:34:42 <clokep> qheaden: Goodnight!
21:34:48 <clokep> Enjoy the (hopefully) nice weather!
21:34:52 <qheaden> clokep: Thanks so very much for your help. :)
21:34:53 <clokep> (It's nice here at least. ;))
21:35:34 <qheaden> clokep: I'll see if I can learn Japanese over the weekend, and then we can solve this issue. ;)
21:35:41 <clokep> :-D
21:36:05 <qheaden> Bye everyone.
21:36:10 * qheaden is now known as qheaden_away
21:38:20 <-- mconley has quit (Input/output error)
21:39:14 <atuljangra> Bye!
21:41:46 <clokep> Mic: Do you subscribe to m.d.chat?
21:41:56 --> josefec has joined #instantbird
21:42:22 <Mic> clokep: not that I knew but I received Atul's email anyway ;)
21:42:32 <clokep> Then you're subscribed. :P
21:42:46 <atuljangra> hehe :P
21:42:49 <Mic> It's the only email I ever received from there if I remember correctly.
21:43:00 <-- josefec has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
21:46:39 <atuljangra> Mic: http://pastebin.instantbird.com/244060
21:47:54 <Mic> Sounds like it.
21:48:08 <atuljangra> Ok.
21:51:04 --> mpmc has joined #instantbird
21:52:28 --> rosonline has joined #instantbird
22:01:51 --> flo-retina has joined #instantbird
22:01:51 * ChanServ sets mode +qo flo-retina flo-retina 
22:02:18 <flo-retina> Good evening :)
22:03:13 <clokep> Hello flo-retina!!!
22:03:49 * flo-retina has plenty of log to catch up with
22:06:25 --> mconley has joined #instantbird
22:08:50 <atuljangra> clokep: Regarding the fileReceived/ fileTransferOffer request, which should be the parameter be in .idl file. I can't pass the new defined interface ibFileTransferOffer.
22:08:56 <atuljangra> clokep: lmp the file for you.
22:09:22 * clokep isn't sure of the context here.
22:10:01 <atuljangra> clokep: http://log.bezut.info/instantbird/130712/#m927
22:10:28 <-- mconley has quit (Input/output error)
22:10:31 <clokep> Shouldn't it be a method, not a parameter?
22:10:40 <clokep> What does " I can't pass the new defined interface ibFileTransferOffer" mean?
22:10:48 <clokep> (And shuldn't that be imFileTransferOffer?)
22:11:25 <atuljangra> Someone suggested me that this is ib only, I guess m ic, thus I used ibFileTransferOffer. 
22:11:46 <clokep> Hmm...I don't know about that. Mic?
22:12:03 <atuljangra> FileTransferOffer is a method only? I don't understand.
22:12:42 <clokep> Ah http://log.bezut.info/instantbird/130712/#m927 I ask why fileReceived is not part of the interface, it's a method.
22:14:19 <Mic> atuljangra: do you want to use ibFileTransferOffer define as type of a parameter of a method in the idl but it didn't work?
22:15:19 <atuljangra> Mic: Yes. I want the parameter of fileTransferRequest to be ibFileTransferOffer, so that we can use it to interact when we received a ft offer.
22:15:20 <Mic> atuljangra: do you want to define a parameter of a method to be of type ibFileTransferOffer in the idl but it didn't work?
22:15:45 <atuljangra> And yes. it didn't work.
22:16:29 <Mic> Wild guess: maybe you'll need to declare it at top of the file to be able to use it where you wanted to.
22:16:29 <atuljangra> void fileTransferOffer(in ibFileTransferOffer aOffer); doesn't work. ( it shouldn't but what is a workaround)
22:17:29 <atuljangra> yes that would work, but is it okay to do so in our code. Just wanted to cross check.
22:18:16 <clokep> Btw if this is in chat/ it has to be im, not ib.
22:18:51 <Mic> clokep: I was told file transfers would be an Instantbird-only thing, that's why I said it should have the ib-prefix.
22:19:21 <clokep> By who?
22:19:24 <clokep> That's not true at all.
22:19:31 --> wnayes has joined #instantbird
22:19:32 <clokep> It's in the backend.
22:19:38 <clokep> The UI might only exist on IB though.
22:19:56 <atuljangra> Oh okay. So I'll change it to im
22:19:58 <Mic> "im" then.
22:20:08 <flo-retina> http://log.bezut.info/instantbird/130712#m857 Pidgin may not be the best reference.
22:20:21 <flo-retina> encoding can be messed up in libpurple too sometimes ;)
22:20:38 <clokep> Regardless...if it's in chat/ it MUST be im. ;)
22:21:05 <flo-retina> i'm pretty sure it doesn't (or didn't) handle accentuated characters in XMPP passwords for the DIGEST-MD5 authentication method correctly ;).
22:21:12 <flo-retina> We do! :-P
22:21:24 * flo-retina fixed that by mistake a while ago
22:22:15 <Mic> clokep: I asked atul whether it's going to be only in IB or not.
22:23:11 <atuljangra> I'm sorry for the mistake. :(
22:23:50 <clokep> Don't apologize, it's not a big deal.
22:24:09 <atuljangra> Ok :)
22:24:23 <-- jb has quit (Ping timeout)
22:25:37 <atuljangra> How do I add stuff to instantbirdBundle? Like I want something like "Accept" label, "Accept" accesskey and the notification message.
22:26:03 <atuljangra> sorry got it
22:26:07 <Mic> atuljangra: lxr for instantbirdBundle
22:26:26 <Mic> You'll get a chrome url that points to a properties file. Add it there.
22:27:04 <flo-retina> Mic: if I include 2 links to the log in the same message, only the first "today" gets converted :-S
22:27:25 <atuljangra> Mic: Thanks :)
22:27:59 <Mic> :o
22:36:30 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:36:49 --> Mic has joined #instantbird
22:36:49 * ChanServ sets mode +h Mic 
22:42:25 <Mic> Good night!
22:42:54 <clokep> 'night.
22:43:30 <atuljangra> Good night :D
22:43:39 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:13:44 <atuljangra> clokep: Diff of two patches as you asked: http://pastebin.instantbird.com/244093
23:14:00 <atuljangra> Also, I've pushed everything on bitbucket
23:14:11 <atuljangra> This diff only contains xmpp part.
23:14:31 <clokep> That patch is reversed. :P
23:14:34 <clokep> Not a big deal though.
23:15:09 <atuljangra> hehe oh yes. :P
23:15:37 <clokep> atuljangra: I'm pretty sure that "textDecoder.decode(array)" is still your issue.
23:15:40 <clokep> What is that actually doing
23:15:50 <clokep> And don't say "decoding the text" or I'm kicking you.
23:17:03 <atuljangra> I've removed that :S
23:17:16 * clokep sighs.
23:17:46 <clokep> atuljangra: When we say things like that, it does NOT mean that we're right and you're right, it means that we think that that /might/ be the issue and want you to play around with that, try it different ways and let us know what the deal is.
23:18:16 <clokep> Bleh I need to update vertical tabs...
23:18:42 <clokep> atuljangra: Does that make sense?
23:18:55 <atuljangra> Yes. Sorry :)
23:18:59 <clokep> I'm not saying "remove it", I'm saying "that looks fishy, I'd check if it is really needed or if it's doing something weird".
23:19:09 <atuljangra> patch is reversed. Wait I'll send you the appropriate diff.
23:19:45 <Mook_as> are you saying that you're _not_ a perfect oracle? :p
23:20:21 <clokep> I'm saying Oracle isn't perfect, they're a death wish for any company they acquire. ;)
23:22:26 <atuljangra> "I'm not saying "remove it", I'm saying "that looks fishy, I'd check if it is really needed or if it's doing something weird"." What I mean to say is that was causing problem and hence I removed it last night. So how can that be an issue right now? :s
23:22:50 <clokep> Oh, because the diff is reversed. :)
23:23:05 * clokep sighs.
23:23:09 <clokep> Maybe I do need a non-reversed diff.
23:23:10 <atuljangra> yes. :( Sorry
23:23:17 <atuljangra> Yes one sec
23:26:41 <atuljangra> two mins. I messed up something.
23:27:44 <atuljangra> clokep: http://pastebin.instantbird.com/244094
23:28:35 <flo-retina> http://pastebin.instantbird.com/244093 looks like someone needs to install interdiff
23:29:45 <clokep> atuljangra: Can you give a summary of what these changes are?
23:30:55 <atuljangra> clokep: Yes. I'll add comments on the pastebin?
23:31:01 <clokep> No.
23:31:54 <clokep> That doesn't sound right.
23:31:54 <atuljangra> Oh okay. Main changes are in lines after 344
23:32:01 <clokep> ++          // Encode the read data as base 64.
23:32:01 <clokep> ++          // To encode we need a string, but we have read the data as
23:32:02 <clokep> ++          // ArrayBufferView, thus doing proper conversion.
23:32:03 <clokep> ++          let end = btoa(ArrayBufferToString(array.buffer));
23:32:23 <clokep> If you go through a string ever then nulls, etc. will probably be stripped out.
23:32:37 <clokep> I thought you had fancy functions that converted arraybuffers directly to base64?
23:32:58 <atuljangra> Oh okay. I had fancy functions for other way around.
23:33:06 <atuljangra> I've used them while decoding
23:33:29 <atuljangra> #374
23:34:16 <clokep> Yes, shouldn't we do the opposite when sending?
23:34:40 <atuljangra> btoa operates on string. Yes I tried that, but then images and zipped files are all messed up.
23:35:07 <clokep> I understand that btoa operates on strings, but I don't think you want a string here.
23:35:18 <atuljangra> Yes I don't.
23:36:35 <atuljangra> Lemme see if I can encode arraybuffer to base64
23:37:41 <clokep> Mook_as: Btw thanks for suggesting talking to jcranmer, he pointed out a revision I hadn't ported. :)
23:38:07 <clokep> atuljangra: Well my opinion on this is that we don't care if it works perfectly, it's good enough for testing and you should think about libpurple or FileLink.
23:39:15 <atuljangra> clokep: Okay :) Can you just give me a quick answer to what all do we want to do in libpurple section of the project? :)
23:41:37 <flo-retina> atuljangra: I'm shocked by this question and a few others I read in the log. It looks like you don't know what your project is about. I suspect just reading your own proposal would give you answers...
23:43:24 <Mook_as> clokep: ha. I guess that worked out well even if I had no idea about it! :D
23:43:26 <atuljangra> flo-retina: No. I just wanted to know what all we want to finish first. Sorry if it sounded that way.
23:43:59 <flo-retina> Mook_as: :)
23:44:40 <clokep> Well it's gotten farther than my c-c build. :)
23:46:22 <flo-retina> atuljangra: I still don't understand what you are asking then.
23:46:37 --> wnayes1 has joined #instantbird
23:46:40 <flo-retina> atuljangra: if you are asking what you should be done and when... I was under the impression your proposal contained a schedule :-S.
23:47:40 <-- wnayes has quit (Ping timeout)
23:48:07 <atuljangra> flo-retina: Sorry. I want to get started with Filelink now. I've mailed a proposed plan of implementation to md chat list. I will start working on it as soon as we finalize things.
23:53:14 <flo-retina> atuljangra: "I'm sure you guys will come up with something clever." my understanding is that you are the one being paid to come up with something clever. And my reading of the "plan of implementation" is 'get others to find something clever for me'.
23:54:47 <flo-retina> what are the awesometab followups that are ready to push? I have bug 2040 and 2043 already ready
23:54:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2040 nor, --, ---, nhnt11, ASSI, New conversation tab has generic placeholder icon (a.k.a. the Firefox "New Tab" icon)
23:58:25 <atuljangra> Ok. I was just asking for suggestions. :) I thought discussion and asking questions would be a good idea. Sorry. I'll implement the feature. So what do you guys want me to do in the next couple of days? Implement the backup mechanism? Or anything other. It would be helpful to know.
23:59:22 <flo-retina> do we want to try the patch in bug 2041 on nightlies?
23:59:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2041 nor, --, ---, nhnt11, ASSI, "Enter" always opens conversation with first contact in the filtered list
23:59:37 <flo-retina> the code is reasonable, but I'm not convinced this new behavior is wanted