#instantbird log on 07 11 2013

All times are UTC.

00:02:17 <flo-retina> the "+" icon is pretty ugly :-S
00:03:42 <atuljangra> Clearly I cannot do |document.getElementById("accountsNotificationBox");| in xmpp.jsm. So where do I do this? I want a notification when the receiver receives the initiation stanza.
00:03:46 <atuljangra> flo-retina: clokep ^
00:03:59 * atuljangra misses Mic :)
00:04:05 <clokep> atuljangra: You have to set up observers or something.
00:05:02 <atuljangra> clokep: Okay. I'll see what I can do. :)
00:09:39 <instant-buildbot> build #415 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/415
00:13:26 * clokep wonders if there's a way to check endianess of the platform.
00:13:39 <Mook_as> from where?
00:14:28 <clokep> From JS. :P
00:14:48 <instant-buildbot> build #434 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/434
00:15:04 <flo-retina> atuljangra: you need to send a notification to the conversation. conversation.xml already observes all notifications from the conversation it displays.
00:15:32 <flo-retina> atuljangra: You will likely need to define a new interface for the object you'll put in the aSubject parameter of the notification
00:16:10 --> dew has joined #instantbird
00:16:24 <Mook_as> b = ArrayBuffer(2); Uint16Array(b).set([1]); isLittleEndian = !!Uint8Array(b)[0];
00:16:46 <atuljangra> flo-retina: oh okay. Trying :)
00:17:23 <clokep> Mook_as: Thanks, but if I'm going to do that I'm just going to use DataViews. :)
00:17:30 <Mook_as> whatever :p
00:18:09 * atuljangra is sleepy, so he should finish this asap. It's 5:50 am here :D
00:19:13 * clokep wonders what == for ArrayBuffers does.
00:30:19 <-- wnayes has quit (Ping timeout)
00:32:26 <clokep> Mook_as: Is there a way to check if arrays are equal?
00:32:32 <clokep> (In xpcshell actually, but yeah...)
00:33:40 --> wnayes has joined #instantbird
00:36:32 <Mook_as> nothing useful.
00:38:14 <Mook_as> I mean, it's easy to write a helper to do it... ((a, b) => a.every((c, i)=>c === b[i]))
00:40:11 <clokep> :P
00:40:57 <Mook_as> (halfway through I realized that it looks about as confused as perl, just doesn't have random dollar signs all over)
00:41:22 <instantbot> florian@instantbird.org denied review for attachment 2566 on bug 2015.
00:41:24 <Mook_as> also, it's wrong (need to check that all items in b are in a, too...)
00:41:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
00:41:32 * flo-retina hopes nhnt11 won't be too disappointed
00:42:17 <flo-retina> Mook_as: "it looks about as confused as perl" or maybe it looks as confused as Mook_as' code samples :-P.
00:42:29 <Mook_as> ... well, yeah :p
00:44:11 <clokep> Mook_as: Yeah, thanks. :P I'll do it a clearer way so I don't get an r-.
00:44:35 <-- jb has quit (Ping timeout)
00:45:48 <Mook_as> hah. yes, I might r- that too :D
00:45:49 <flo-retina> clokep: should I land bug 1979, or wait for a confirmation tomorrow that somene actually tested it?
00:45:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1979 nor, --, ---, florian, NEW, "Typing" indicator is never cleared.
00:46:53 <clokep> flo-retina: :( I don't know, how confident are you on the code?
00:47:11 <flo-retina> someday I would like to take the time to debug the "LEAKED 1 !!!" I see at shutdown on my debug build.
00:47:19 <flo-retina> clokep: I don't remember that patch. Too long ago.
00:47:34 * clokep is writing tests. :(
00:47:48 <clokep> flo-retina: I'd be OK w/ the check-in, but was it tested at all?
00:47:53 <clokep> We haven't had a broken nightly in a while though so... ;)
00:48:04 <flo-retina> ahah
00:48:11 <atuljangra> hehe :P
00:48:19 <atuljangra> let's break the nightly ;)
00:48:24 <flo-retina> if you mean "can we still exchange messages if the patch is applied", I can test that quickly
00:48:39 <clokep> I already have that ubilt, one second.
00:49:03 <flo-retina> clokep: the patch is still applied on my debug build
00:50:23 * clokep thinks we should go w/ it. :)
00:51:57 <flo-retina> clokep: the shutdown leak is only when I connect my florian@moznet IRC account
00:52:27 <clokep> flo-retina: Right, you've mentioned this before, I have no idea what it's from.
00:53:00 <flo-retina> random guess: a timer in the way we handle NickServ that isn't cleared when disconnecting the account?
00:54:09 <atuljangra> I seem to be lost with the observers, can you guys point me to some good example. I was looking at blist.js and some account observers. 
00:54:28 <flo-retina> atuljangra: look in conversation.xml
00:54:44 <flo-retina> like I told you to do 40 minutes ago.
00:54:57 --> florian has joined #instantbird
00:55:28 <clokep> flo-retina: That's very reasonable.
00:55:29 <clokep> File a bug?
00:55:30 <atuljangra> yes. I did that too. http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#63 seems to be the point which I should use?
00:55:32 <-- MMN-o has quit (Ping timeout)
00:56:26 <flo-retina> clokep: is there really a timer that isn't cleared there?
00:57:17 --> MMN-o has joined #instantbird
00:58:12 <clokep> There's a timer.
00:58:38 <clokep> We do clearTimeout, but not if the account is closed.
00:58:40 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:58:44 <clokep> So I don't see why it would happen every time.
01:00:59 <flo-retina> am I the only one thinking that there are too many getBrowser() calls in there: https://bugzilla.instantbird.org/attachment.cgi?id=2570 ?
01:01:24 * clokep is slightly upset that &&= is not an operator...
01:01:43 <flo-retina> it's cheap though
01:01:57 <flo-retina> I guess I'll pretend I haven't seen the duplication, to get this bug fixed today :)
01:05:29 <instantbot> florian@instantbird.org granted review for attachment 2570 on bug 2036.
01:05:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2036 nor, --, ---, nhnt11, ASSI, Section scrolling with swipe gesture broken in the log viewer
01:06:49 <-- Mook_as has quit (Quit: Mook_as)
01:09:34 <flo-retina> clokep: I just looked at ircServices.jsm, and the way we clear that timeout seems indeed broken :-/
01:11:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/907ad31c5899 - Nihanth Subramanya - Bug 2036 - Section scrolling with swipe gesture broken in the log viewer, r=fqueze
01:11:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d3ef4210bb73 - Florian Quèze - Bug 1979 - 'Typing' indicator is never cleared / Hangout users are shown typing when they aren't, r=clokep.
01:16:24 <flo-retina> bah, 3am already :(
01:16:27 <flo-retina> Good night
01:16:28 <instantbot> New Core - IRC bug 2038 filed by florian@instantbird.org.
01:16:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2038 min, --, ---, nobody, NEW, Shutdown leak after connecting an IRC account where NickServ expects a password but the user hasn't 
01:17:03 <atuljangra> flo-retina: Good Night :)
01:18:09 <clokep> Thanks flo-retina.
01:20:01 <instantbot> clokep@gmail.com set the Resolution field on bug 1979 to FIXED.
01:20:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1979 nor, --, 1.5, florian, RESO FIXED, "Typing" indicator is never cleared.
01:20:31 <instantbot> clokep@gmail.com set the Resolution field on bug 2036 to FIXED.
01:20:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2036 nor, --, 1.5, nhnt11, RESO FIXED, Section scrolling with swipe gesture broken in the log viewer
01:21:48 <instant-buildbot> build #416 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/416
01:24:30 <instant-buildbot> build #435 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/435
01:28:55 <clokep> "Error: Invalid arguments"....worst error ever. :(
01:29:14 <atuljangra> :(
01:33:51 <-- wnayes has quit (Quit: wnayes)
01:45:32 <atuljangra> clokep: regarding displaying the notification, which box should I be using? I'm trying |convNotificationBox| for a while now, but it is always null.
01:45:51 <atuljangra> Which box should I use for this notification?
01:46:06 <clokep> atuljangra: I don't know what convNotificationBox is and I don't know what you mean by "which box should I be using" as far as I know there's only one notification box on the conversation.
01:46:53 <atuljangra> clokep: I meant this. http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#25 I'm trying to use this.
01:47:07 <clokep> OK.
01:47:08 <clokep> How?
01:47:44 <atuljangra> But, when I do let box = document.getAnonymousElementByAttribute(this, "anonid", "convNotificationBox"); box is always null.
01:48:38 <atuljangra> Code is scattered over multiple files.
01:48:43 <clokep> atuljangra: First of all, you can probably use http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1629
01:49:13 <atuljangra> yes. agreed.
01:49:18 <clokep> But it does seem like what you're doing should work.
01:49:58 <atuljangra> hmm. :S
01:50:14 <clokep> Where are you running that in?
01:50:42 <atuljangra> I'm in conversation.xml only.
01:51:38 <atuljangra> just a sample function http://pastebin.instantbird.com/242572 places below http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1601
01:54:22 <clokep> I don't know, I'm sorry.
01:54:29 <clokep> I don't know the conversation bindings very well.
01:55:40 <atuljangra> Okay. Till now, I've created an observer which changes the status of chat when file transfer is started and when file transfer is cleared.
01:56:18 <atuljangra> Somehow I want to put up a notification, which contain a button which can be used to send the ft code a accept/reject thing.
01:56:34 <clokep> Right.
01:57:07 <atuljangra> It's 7:30 am here. I guess I should call it a night(or day) :P
01:57:19 <atuljangra> I'll write my daily report and mail it to you guys.
01:58:06 <clokep> Thanks.
01:58:19 <atuljangra> I am sorry, I planned to complete the ui today, but I need to learn more about observers.
01:58:33 <clokep> Hopefully tomorrow.
01:59:15 <atuljangra> Yes. Also should we be deciding on filelink tomorrow? Or do we give 1-2 days to land the xmpp patch properly?
01:59:57 <clokep> "deciding on filelink"? What?
02:00:31 <atuljangra> I mean, how should fallback to filelink be implemented and start implementing that.
02:01:12 <clokep> We can start to discuss it tomorrow, but please discuss it with flo-retina.
02:01:52 <atuljangra> clokep: Okay :)
02:01:54 <atuljangra> Thanks :)
02:09:35 * atuljangra goes to sleep.
02:09:40 <atuljangra> Good Night :)
02:10:10 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
02:19:33 <instantbot> clokep@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 2569 on bug 2037.
02:19:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
02:27:43 --> Mook has joined #instantbird
02:55:31 <instantbot> clokep@gmail.com granted feedback for attachment 2571 on bug 2037.
02:55:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
02:57:17 <instant-buildbot> build #906 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/906
03:08:51 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
03:15:39 <instant-buildbot> build #1001 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/1001
03:27:32 <instant-buildbot> build #898 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/898
03:55:39 --> gerard-majax__ has joined #instantbird
04:01:48 <-- gerard-majax__ has quit (Ping timeout)
04:16:20 --> FireFly_TB has joined #instantbird
04:38:19 <instant-buildbot> build #421 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/421
05:17:45 --> Nirgali has joined #instantbird
05:25:22 <-- FireFly_TB has quit (Ping timeout)
05:25:33 <-- EionRobb has quit (Ping timeout)
05:30:40 <-- Optimizer has quit (Ping timeout)
05:34:31 --> Optimizer has joined #instantbird
06:02:06 <-- Nirgali has quit (Ping timeout)
06:53:14 --> mconley has joined #instantbird
06:53:20 <-- mconley has quit (Quit: Leaving...)
06:57:39 --> FireFly_TB has joined #instantbird
07:01:16 <-- Mook has quit (Ping timeout)
07:04:49 --> Mook has joined #instantbird
07:22:04 <-- Mook has quit (Quit: Mook)
07:22:16 <-- FireFly_TB has quit (Quit: FireFly_TB)
07:24:45 --> gerard-majax__ has joined #instantbird
07:30:43 <instant-buildbot> build #422 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/422
07:59:14 --> Mic has joined #instantbird
07:59:14 * ChanServ sets mode +h Mic 
07:59:34 <Mic> Hello
08:18:33 <flo-retina> Mic: hello :)
08:23:18 --> FireFly_TB has joined #instantbird
08:35:54 <-- qheaden_away has quit (Quit: ZNC - http://znc.in)
08:41:32 --> qheaden has joined #instantbird
08:42:57 <-- qheaden has left #instantbird ()
08:46:02 --> mpmc has joined #instantbird
09:16:36 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:21:53 --> aleth has joined #instantbird
09:21:53 * ChanServ sets mode +h aleth 
10:02:06 --> flo-retina has joined #instantbird
10:02:06 * ChanServ sets mode +qo flo-retina flo-retina 
10:04:46 --> clokep has joined #instantbird
10:04:46 * ChanServ sets mode +o clokep 
10:06:25 <flo-retina> clokep: good morning :)
10:23:29 <clokep> Hello flo-retina.
10:28:36 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:28:46 --> clokep has joined #instantbird
10:28:46 * ChanServ sets mode +o clokep 
10:37:34 <clokep> Thanks Mic.
10:37:58 <Mic> "You're welcome."? ;)
10:38:26 <Mic> I'm not quite sure why I deserved that thanks..
10:39:34 <flo-retina> for being here and taking part in the review of this code? :)
10:40:19 <clokep> I meant the comments, yes. :)
10:40:57 <Mic> Ah, you've seen that already. OK :)
10:42:19 <flo-retina> bitbucket's emails are as annoying as github's ;)
10:43:13 <clokep> I was hoping they'd at least meter them and not send it for every comment such that if you do 3 comments in a minute then stop for 5 minutes they'd end up as one email.
10:43:33 <flo-retina> nah, one email per comment :-P
10:44:08 --> novabyte has joined #instantbird
10:44:27 <aleth> Sounds like a great way to increase bugspam by orders of magnitude :P
10:44:52 <flo-retina> aleth: yeah
10:45:15 <flo-retina> it also encourage drive by superficial comments, as opposed to thorough reviews
10:45:28 <flo-retina> you can't know when someone is done reviewing
10:45:30 <-- FireFly_TB has quit (Ping timeout)
10:45:30 <aleth> Definitely.
10:45:41 * clokep got too tired last night while reviewing.
10:45:42 <aleth> And you can only comment on individual commits, not on a whole bunch of them together
10:45:46 <aleth> Easy to miss things.
10:45:46 <clokep> I think my comments trailed off at the end.
10:46:03 <flo-retina> and as a reviewer, you can't decide in which order your comments will be seen. When I send a review, I typically want the patch author to read first my overall appreciation of his work, which is the thing I tend to type last.
10:46:22 <aleth> There is no place to put general review comments at all.
10:46:36 <clokep> aleth: You can do it at the top of the commit.
10:46:53 <Mic> Did I just generate dozens of bugspam mails via Bitbucket? :D
10:46:54 <aleth> clokep: But only per-commit...
10:46:57 <flo-retina> aleth: on github you can comment either on individual commits or on a pull request. Which makes it super confusing, because if you reply the reply is visible only if you are looking at the commit, or only if you are looking at the pull request
10:47:16 <aleth> It's really hard to look for specific older comments that way.
10:47:21 <flo-retina> Mic: enough to make me create a filter ;)
10:47:43 <aleth> Don't get me started on github pull requests :(
10:48:10 <flo-retina> hmm, github rants are better in #chatdev ;)
10:48:18 <Mic> I'm finished for now.
10:48:37 <Mic> Now I should do that on nhnt11's service too...
10:48:44 <flo-retina> heh ;)
10:49:10 * flo-retina hasn't subscribed to nhnt11's repository (as he attaches enough patches on bugzilla to keep me busy :-P)
10:49:45 <clokep> Mic: Yes, but I already had them filtered. :-D
10:52:01 * aleth doesn't know where to comment on nhnt11's service commits and always would prefer to comment on the current source.
10:52:20 <aleth> So I'll wait for the patch ;)
10:52:40 <clokep> How close is that to landing? Just nits left?
10:52:52 <flo-retina> what?
10:52:58 <flo-retina> the "new tab" patch, or the service?
10:53:06 <aleth> clokep: The service hasn't ever been reviewed by anyone
10:53:21 <clokep> Sorry, the tab, not the service.
10:53:35 <aleth> That should really land today.
10:53:43 <flo-retina> I think so, yes
10:53:58 <flo-retina> I would be curious to know if others agree with my comment about the mouse interactions
10:54:18 --> atuljangra has joined #instantbird
10:54:41 <atuljangra> Good afternoon!
10:54:50 <flo-retina> hello :)
10:54:54 <aleth> flo-retina: nhnt11 may not like it as he wanted to be able to select multiple entries. I'm not sure that's that important
10:54:55 * atuljangra checks logs
10:54:57 <clokep> atuljangra: Some of my comments need a reply, not just "OK I'll change that", e.g. "okay I'll make them without the "jabber". I intentionally didn't change that." I think I said to ask flo-retina what to do here.
10:55:07 <aleth> hi atuljangra
10:55:33 <atuljangra> clokep: Yes, I was going to do so right now. In fact I was typing the same :)
10:55:38 <atuljangra> aleth: Hi :) How are you?
10:56:19 <aleth> Going to look at your patch :) or maybe I'll wait until you've addressed all the existing comments first...
10:56:19 <atuljangra> flo-retina: Please suggest me names for https://bugzilla.instantbird.org/attachment.cgi?id=2571&action=diff#a/chat/protocols/xmpp/xmpp-xml.jsm_sec1
10:56:41 <atuljangra> aleth: It's your wish :D
10:57:20 <flo-retina> atuljangra: just drop the jabber_ prefix, and for the X one, 'x_data' will do.
10:57:31 <flo-retina> IBB can be lowercase
10:58:22 <flo-retina> atuljangra: I still don't understand what the purpose of that item_not_found line is. Is it different from http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp-xml.jsm#55 ?
10:58:41 <atuljangra> I'm sorry I used my judgment on some comments. I'll revert the bad changes which I did. Like I have a whole new commit to change { } in case of one member. :-(
10:59:15 <atuljangra> flo-retina: checking
10:59:28 <clokep> We use pretty much the same style guidelines as Mozilla FYI.
11:00:03 <aleth> https://wiki.instantbird.org/Instantbird:Coding_Guidelines
11:00:55 <Mic> aleth: that doesn't say much on brackets (where to place them and how to use spaces around them) unfortunately.
11:01:07 <atuljangra> clokep: OK. That's why my first patch was good with the '{' '}' :)
11:02:09 <atuljangra> clokep: Regarding your last comment, what should I do in case of muc? Totally remove it, or report an error?
11:02:15 <aleth> Mic: I think mozilla is actually inconsistent about bracketing, different files seem to have slightly different styles
11:02:24 <atuljangra> aleth: ++
11:02:46 <aleth> atuljangra: We're pretty consistent though ;)
11:02:46 <flo-retina> atuljangra: about "okay I'll make them without the "jabber". I intentionally didn't change that.". In the future, please skip all the replies meaning "OK change applied" and please do reply to comments you don't understand or haven't addressed for some reason (explain why).
11:03:23 <atuljangra> I would suggest we can keep it and throw an error in console. We would want to add muc support also I guess. flo-retina views?
11:03:31 <clokep> atuljangra: THROW an error, but I think that's what in the prototype.
11:04:01 <flo-retina> atuljangra: yeah. I'm not really concerned about the MUC situation yet. We will have more clarity on the behavior there once we have filelink.
11:04:08 <atuljangra> flo-retina: okay, :)
11:04:48 <atuljangra> clokep: okay, so basically removing the sendFile from there, it will automatically throw NS_ERROR_NOT_IMPLEMENTED. :s
11:04:49 <aleth> atuljangra: You're just getting all the coding style nits at once now, because you didn't have a bug to fix in the bonding period ;)
11:05:13 * clokep is surprised aleth didn't freak out when I suggested you could DCC to a channel. ;)
11:05:25 <flo-retina> aleth: s/didn't have a bug to fix/didn't fix a bug/
11:05:33 <atuljangra> aleth: Yes. :( I tried alternateNicks but that is still remaining.
11:05:39 <atuljangra> flo-retina: ++
11:05:44 <flo-retina> clokep: we already know you are crazy with obscure IRC features ;).
11:06:08 <aleth> clokep: Well, I hadn't actually seen that yet ;)
11:07:07 <clokep> Also, can we split that patch up into instantbird/ + purple/ and chat/ ?
11:07:29 <clokep> Or everything but xmpp and xmpp.
11:07:57 <flo-retina> clokep: the xmpp/!xmpp split makes more sense.
11:07:58 <aleth> Maybe file a new bug for the UI part.\
11:08:11 <atuljangra> OK. So next patch will only be about xmpp.
11:08:13 <flo-retina> clokep: I think we want basic UI, idl changes, jsProtoHelper, and purplexpcom changes in the same bug.
11:08:32 <flo-retina> aleth: I think we suggested yesterday to use bug 9 for the basic UI and back-end support
11:08:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=9 enh, P5, ---, nobody, NEW, Support of file transfers
11:08:42 <aleth> flo-retina: That sounds good
11:09:00 <aleth> flo-retina: I would suggest filing new bugs that block bug 9
11:09:22 <flo-retina> aleth: fine with me too
11:09:30 <clokep> I would not, it sounds exactly like what that bug is for.
11:09:31 <atuljangra> flo-retina: aleth ++ We can keep bug 9 for tracking everything regarding ft
11:09:41 * clokep dislikes metabugs.
11:10:18 <atuljangra> clokep: May I ask why? They are quite helpful in tracking progress. :)
11:10:32 <clokep> Because they never get closed.
11:11:03 * clokep is super late for work.
11:11:09 <atuljangra> yes :P
11:11:19 <atuljangra> clokep: Go go go!
11:11:39 <flo-retina> I dislike meta bugs without a clear definition of what's needed to resolve them.
11:11:56 <aleth> clokep: "Because they never get closed" is why I'd prefer separate bugs like what nhnt11 is doing. We should close bug 9 at some point during gsoc.
11:12:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=9 enh, P5, ---, nobody, NEW, Support of file transfers
11:12:31 <flo-retina> I think bug 9 should be closed once we have basic support in chat/, basic UI, and at least one prpl with working ft.
11:12:54 * flo-retina wonders if there are libpurple prpls where ft actually works
11:13:18 <aleth> Sounds good, though I'm not sure if Filelink shouldn't block it. And a separate bug for that makes sense.
11:13:22 <clokep> flo-retina: Someone is working on it for GTalk. ;)
11:13:33 <clokep> I'm fairly certain it works in OSCAR.
11:13:34 <atuljangra> Ok. So I'll work on the next patch now.
11:14:20 <-- clokep has quit (Connection reset by peer)
11:19:50 <aleth> atuljangra: Are you still assuming the transferred file is a text file?
11:21:31 <atuljangra> aleth: yes. I think the problem is with encoding.
11:21:58 <aleth> I thought you found some code on MDN to read directly into an arraybuffer?
11:22:26 <aleth> Does that help?
11:22:31 <atuljangra> yes, but clokep asked me first to address these comments and then use that.
11:22:55 <atuljangra> I didn't try. Trying to submit a new patch first.
11:23:01 <aleth> OK
11:23:46 <atuljangra> :)
11:25:03 <atuljangra> Be back in a bit.
11:29:06 <aleth> atuljangra: Do you still have questions about conversation.xml?
11:29:24 <aleth> clokep: Where did you discuss DCC? I can't seem to find it in the logs.
11:29:52 <Mic> aleth: wasn't there something about "sending a file to a channel"
11:31:14 <aleth> Mic: Oh, was the discussion about that in general? I don't see a problem then at all, FileLink covers it.\
11:31:31 <Mic> FileLink covers that, yes.
11:31:33 <aleth> (if DCC should not be available :P )
11:31:49 * Mic wants DCC to be available.
11:32:38 <aleth> I'm sure it's on the todo list... somewhere... ;)
11:33:33 --> rosonline has joined #instantbird
11:33:50 <Mic> clokep has something in his Bitbucket repo afaik.
11:34:48 <Mic> Just a stub for the module where the actual file transfers stuff would need to be filled in.
11:34:56 <Mic> Looked useful iirc.
11:36:52 <aleth> Cool, we should take a look once atul's interfaces land
11:45:52 <Mic> Have a nice day!
11:46:02 --> FireFly_TB has joined #instantbird
11:47:06 --> nhnt11 has joined #instantbird
11:47:16 <Mic> atuljangra: after fixing the document/this-problem that flo already mentioned, the code in your pastebin from last night should show a notification bar inside the conversation.
11:48:09 <Mic> Call it from the conversation's observe method when you receive the notification that you're sending with Services.obs.notifyObservers from your file transfer code.
11:48:15 <Mic> Bye!
11:48:42 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
11:49:25 <aleth> atuljangra: Mic is referring to http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1755
11:49:59 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
11:50:25 <aleth> atuljangra: "Don't know why, but _targetResource should not be null to successfully send an iq stanza" What did the guys in the XMPP MUCs say about this?
11:51:59 <nhnt11> flo-retina: "Command+T" does nothing" - I'm really surprised by this. I open all my tabs using Command+T. Let me see if I broke it somehow in the latest patch.
11:52:20 <aleth> nhnt11: check his comments on the bug
11:52:24 <nhnt11> "The + icon is ugly" Just saw this, thanks. Let me look at ti.
11:52:36 <nhnt11> aleth: I read them in the email, opening bugzilla now.
11:52:39 --> atuljangra has joined #instantbird
11:53:05 <atuljangra> sorry, was shifting to proxy-less internet for testing ib.
11:53:28 <aleth> No mibbit? :)
11:53:38 <aleth> Check the logs for missed messages though
11:53:42 <nhnt11> Oh, only when no accounts are connected. It's supposed to be disabled when there are no connected accounts... ugh.
11:53:49 <atuljangra> yes doind the same.
11:53:59 <nhnt11> I noticed something similar to the problem with AIM contacts when I was testing MUCs. Fix is ready.
11:54:49 <nhnt11> The mouse interactions - if you'd like it that way, sure.
11:54:58 --> atuljang1 has joined #instantbird
11:55:06 <nhnt11> The performance issues are gone with the service, yes :)
11:55:11 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
11:55:22 <nhnt11> The focus rings are because of multi-selection, but if I change the mouse interactions to your way that will be gone.
11:55:23 <aleth> nhnt11: The mouse interactions, I think the only way to find out is to try it in nightlies ;)
11:55:32 * atuljang1 is now known as atuljangra
11:55:44 <nhnt11> aleth: flo-retina wants that to be changed before landing it.
11:55:58 <aleth> nhnt11: Yes, so we can try it in the nightlies :P
11:56:03 <nhnt11> Ok :)
11:56:46 <atuljangra> Thanks Mic, aleth :)  Will do that asap :)
11:56:48 <aleth> It makes sense as ultimately if you compare it to the FX new tab for example, no double clicks are needed there either
11:56:53 <nhnt11> I have an appointment later tonight, so I will probably have to go after fixing this up. Will be back later in the night though :)
11:57:24 <aleth> nhnt11: If you can, get a patch ready for review (by flo) so hopefully it can land tonight
11:57:42 <atuljangra> aleth: I didn't ask in xmpp mucs though. I'll do it today. But that seem to be happening. I don't know the reason.
11:57:44 <nhnt11> aleth: Yes I understood that, but I thought the way it is now was fine for a richlistbox. I'll change it though
11:57:55 <nhnt11> "get a patch ready" - of course!:)
11:58:36 <aleth> nhnt11: It's certainly standard for a richlistbox, the question is if it would feel right for a new tab
11:58:54 <nhnt11> I dunno, it felt intuitive to me. Like you said, let's try it out in the nightlies :)
11:59:18 <aleth> atuljangra: no problem, just wondering whether you had been able to discover the correct specs for that
12:00:23 <aleth> nhnt11: It would feel intuitive to me too, as I know its a richlistbox... But if you later add a different view for when nothing is filtered, it will be odd if the behaviour changes. I think that was the reasoning behind flo's suggestion.
12:00:44 <atuljangra> aleth: I guess so. I'll debug it after completing the patch.
12:02:07 --> clokep_ has joined #instantbird
12:02:25 <clokep_> aleth: In my review comments, not in the logs.
12:05:10 <aleth> clokep_: I actually successfully transferred a file via DCC once, a long time ago, using xchat
12:06:13 <aleth> It only worked that one time though :P
12:06:17 <atuljangra> clokep_: Regarding displaying the types of aConv. Should I display the types in brackets?
12:07:23 <clokep_> aleth: It usually doesn't work at all if you're behind a NAT without port forwarding, etc. :)
12:07:32 <clokep_> atuljangra: I have no idea what that means.
12:07:56 <-- rosonline has quit (Client exited)
12:08:06 <aleth> atuljangra: I /think/ you just replace e.g. "conversation" with "prplIConversation" or whatever in the comment. Be specific.
12:09:02 <atuljangra> I am just asking which one would you prefer http://pastebin.instantbird.com/242985
12:09:12 <atuljangra> aleth: Thanks :)
12:11:31 <clokep_> atuljangra: The last one.
12:11:36 <atuljangra> clokep_: ok
12:13:41 <atuljangra> clokep_: What do you think about http://pastebin.instantbird.com/242986
12:14:10 <clokep_> atuljangra: I don't understand the problem well enough, ask flo-retina .
12:14:31 <atuljangra> flo-retina: ^^
12:15:02 <aleth> atuljangra: That's something that should disappear before landing due to you finding out what the answer to the targetresource question is ;)
12:16:25 <atuljangra> Yes. :D I guess I can keep it in current patch though. With a FIXME above it? Seems reasonable?
12:17:12 <aleth> Yes
12:24:39 <-- Optimizer has quit (Ping timeout)
12:27:18 * clokep_ wonders if flo-retina has any ideas for bug 2016 that we can discuss so I can take a look at this this weekend.
12:27:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2016 enh, --, ---, nobody, NEW, Allow switching between a JS and libpurple prpl via a pref
12:28:10 <-- FireFly_TB has quit (Ping timeout)
12:30:53 <atuljangra> clokep_: FTInstance or fTInstance or fileTransfer or fileTransferInstance?
12:32:44 <clokep_> atuljangra: I'd be fine with "fileTransfer" personally, I don't really like the "instance" being in there.
12:32:53 <atuljangra> clokep_: awesome :)
12:33:07 <clokep_> atuljangra: Should that be called IBBFileTransfer or something instead of XMPPFileTransfer?
12:34:23 <atuljangra> clokep_: umm, XMPPFileTransfer make much more sense to me. But we can keep it fileTransfer only.
12:35:51 <clokep_> atuljangra: You're misunderstanding, I'm talking about the class name, not the instance name.
12:36:30 <atuljangra> clokep_: oh okay. IBBFileTransfer looks good.
12:36:48 <atuljangra> clokep_: Should I change XMPPFileTransfer to IBBFileTransfer?
12:37:15 <aleth> atuljangra: Isn't IBB only one of the XMPP file transfer methods?
12:37:17 <clokep_> atuljangra: Well there are multiple methods right? I think it probably makes sense.
12:38:26 <atuljangra> aleth: Yes. I was thinking of incorporating many methods into this class only. So that we can have a single class that deals with file transfer. But yes, having separate makes more sense.
12:38:35 <atuljangra> I'll do the change.
12:40:34 <clokep_> Having separate ones makes more sense, if there are shared elements we'd make an XMPPFileTransferPrototype that inherits from GenericFileTransferPrototype that you can then inherit from.
12:40:40 <clokep_> But don't over abstract. ;)
12:41:37 --> jb has joined #instantbird
12:41:47 <atuljangra> clokep_: Hehe sure :)
12:44:19 * clokep_ wonders how many we'll need for DCC. :P
12:44:49 <nhnt11> Aren't menu items supposed to get disabled automatically when the corresponding command gets disabled?
12:46:00 <aleth> I think so.
12:46:35 <nhnt11> The new conversation menu item stays enabled, though its command is definitely getting disabled (when no accounts are connected)
12:46:44 <-- novabyte has quit (Quit: bye bye)
12:46:47 <nhnt11> I need to check if the other menu items are manually disabled. 
12:46:50 * nhnt11 opens lxr
12:47:16 <atuljangra> :P
12:47:49 <nhnt11> Ah, I think I got it.
12:51:00 <-- jb has quit (Ping timeout)
12:53:15 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:53:21 --> nhnt11 has joined #instantbird
12:53:42 <flo-retina> aleth: btw, I think multiple selections are still possible with the mouse interactions I suggested. We just need to not start the conversation onclick if a modifier key was pressed during the click.
12:55:38 <nhnt11> flo-retina: So that would mean highlight on hover, select on click?
12:56:04 <flo-retina> nhnt11: start a conversation on click. add to selection on modifier+click
12:56:07 <atuljangra> clokep_: ping
12:56:13 <nhnt11> Hmm
12:56:19 <flo-retina> atuljangra: ask your question
12:56:26 <atuljangra> clokep_: Regarding the constructor thing you said, is this ok? : http://pastebin.instantbird.com/243008
12:56:27 <nhnt11> That would be weird when clicking to open more than one conversation though
12:56:41 <atuljangra> flo-retina: :)
12:56:52 <aleth> nhnt11: select-on-hover sounds wrong to me.
12:57:25 <clokep_> atuljangra: Not at all.
12:57:30 <flo-retina> atuljangra: I think the first parameter of .call() should be 'this'
12:57:54 <clokep_> atuljangra: http://pastebin.instantbird.com/243009
12:58:05 <aleth> atuljangra: I don't understand that at all
12:58:11 <flo-retina> clokep_: oh yes :)
12:58:18 <aleth> clokep_: Oh, I see what he meant now :)
12:58:21 <atuljangra> aleth: sorry :(
12:58:22 <nhnt11> I have to go for a while till after dinner-ish.
12:58:28 <nhnt11> Will be back to finish up this patch tonight.
12:58:32 <nhnt11> Bye.
12:58:37 <atuljangra> clokep_: Thanks :)
12:58:42 <atuljangra> bye nhnt11
12:59:29 <flo-retina> I hope nhnt11 will have time to finish the next version of the patch before I have time to look at reviews again :).
13:00:29 <atuljangra> clokep_: I can now completely remove the _init which I declared earlier. 
13:02:40 <clokep_> atuljangra: That was the point. ;)
13:02:50 <atuljangra> heh yes. :)
13:08:56 --> jb has joined #instantbird
13:10:52 <-- jb has quit (Quit: jb)
13:11:05 <clokep_> nhnt11: Usually if you multi-select and then click without the modifier it just selects the single thing you've now clicked.
13:13:51 <flo-retina> clokep_: I was thinking that to validate a multi-selection the user could press enter
13:14:08 <flo-retina> clokep_: I don't mind if it's not very discoverable as I think starting multiple conversations at once is really a rare edge case
13:14:30 <flo-retina> (and people selecting multiple contacts are likely to expect a MUC to start with all these contacts in it)
13:16:28 <clokep_> flo-retina: That was my thought too.
13:16:49 <clokep_> flo-retina: What's our behavior when selecting multiple participants and pressing enter? it should be the same
13:17:06 <flo-retina> clokep_: a conv with each of them
13:19:51 <clokep_> OK!
13:27:35 <clokep_> Anyone seen any issues / fixes with that XMPP check-in last night?
13:28:11 <atuljangra> Many times doing make -C instantbird/ does not reflect my changes. Why would that happen?
13:28:45 <clokep_> atuljangra: Are you making changes in chat/? Do you files locked?
13:28:56 <clokep_> Did the build complete successfully?
13:29:05 --> mconley has joined #instantbird
13:29:26 <atuljangra> No. 
13:29:26 <atuljangra> locked? No. 
13:29:26 <atuljangra> And yes
13:30:08 <atuljangra> generally saying make -C chat/. Happens very rare.
13:30:20 <aleth> What do you mean by "reflect my changes"?
13:31:38 <aleth> Are they packaged? In that case the -purgecaches command line option when starting IB may help
13:32:11 <atuljangra> The changes  which I generally do.
13:32:31 <atuljangra> no they ae not packaged.
13:33:08 <clokep_> I think you should always run with -purgecaches.
13:33:14 <clokep_> It doesn't have to do with packaging IIRC.
13:33:39 <atuljangra> oh okay.
13:33:49 <atuljangra> so make -C chat/ -purgecaches
13:34:16 <aleth> "It doesn't have to do with packaging IIRC." I didn't mean to suggest it did, just that he should check the build output isn't actually correct
13:34:34 <aleth> atuljangra: no, -purgecaches is a command line parameter for instantbird
13:34:45 <atuljangra> oh okay.
13:35:39 <flo-retina> |make ib| is shorter to type and rebuilds everything you may need ;)
13:37:33 --> jb has joined #instantbird
13:43:50 <-- jb has quit (Ping timeout)
13:46:41 <-- mconley has quit (Input/output error)
14:02:12 --> qheaden has joined #instantbird
14:02:19 <qheaden> Hello everyone.
14:04:39 <atuljangra> Hey qheaden
14:04:46 <flo-retina> qheaden: good morning :)
14:06:31 --> jb has joined #instantbird
14:14:28 * clokep_ has a bone to pick with qheaden...
14:14:58 * clokep_ wonders if qheaden has seen http://log.bezut.info/instantbird/yesterday/#m1055
14:17:08 <-- jb has quit (Quit: jb)
14:18:02 --> jb has joined #instantbird
14:20:03 --> mconley has joined #instantbird
14:26:34 * qheaden sighs
14:26:41 <qheaden> clokep_: So they still work huh?
14:27:33 <clokep_> qheaden: I wonder if they wer ejust killed in the client, not server side.
14:27:37 * clokep_ thinks you need to look into this a bit.
14:27:39 <clokep_> But please not right now.
14:27:42 <clokep_> That's not a priority.
14:27:50 <qheaden> clokep_: Okay, I will.
14:28:05 <qheaden> I'll add it to the BitBucket tracker.
14:31:39 <clokep_> qheaden: Roger.
14:31:43 <clokep_> What's on tap for today?
14:31:48 <qheaden> clokep_: My hope is that the plug-in will be in a landable state by the end of this week or early next week.
14:32:08 <clokep_> Cool. :)
14:32:08 <qheaden> clokep_: I plan on fixing the conference bugs I have stored in the tracker, and work more on options.
14:32:57 <clokep_> qheaden: So what we'll probably want to do is put up a patch for review soon then (once all the required things are finished).
14:33:09 <clokep_> And then as you're waiting for review you can continue working on extra features.
14:33:19 <clokep_> Remember we have to support Yahoo JAPAN too. :)
14:33:20 <qheaden> clokep_: Sounds like a plan.
14:33:39 <qheaden> Tell Yahoo JAPAN to make their own plug-in! :P
14:34:50 <qheaden> I don't know why I get the funny gut feeling that Yahoo! is going to eventually drop messenger, or overhaul it heavily, including the protocol. They have been making tons of changes lately.
14:35:41 <clokep_> Guess you'll have a ton to do at some point then. ;)
14:36:02 <qheaden> :P
14:36:25 <qheaden> I've got the same feeling about GTalk's XMPP support too. ;)
14:36:54 <clokep_> qheaden: You do know that adding Yahoo JAPAN support should be like 100 lines of code, right? :(
14:37:01 <clokep_> It's just changing the servers and a few other things, hopefully.
14:37:12 <qheaden> clokep_: Yeah, I know.
14:37:28 <-- jb has quit (Input/output error)
14:39:40 <instantbot> atuljangra66@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 2571 on bug 2037.
14:39:41 <instantbot> atuljangra66@gmail.com requested feedback from florian@instantbi rd.org for attachment 2572 on bug 2037.
14:39:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
14:40:01 <atuljangra> :( spelling mistake in the comment :(
14:40:29 --> jb has joined #instantbird
14:41:22 <atuljangra> I'm going for dinner outside. So I'll be back after dinner.
14:41:33 <atuljangra> Will complete today's target after that.
14:43:05 <atuljangra> Going now :)
14:43:07 <atuljangra> Bbye.
14:44:44 <-- atuljangra has quit (Quit: He didn't quit, he'll be back!)
14:47:34 * clokep_ is now known as clokep
14:47:44 <flo-retina> qheaden: why do people think Google is dropping xmpp?
14:59:07 <qheaden> flo-retina: They have a tendency to drop things after a transistion. Google Latitude, Google Reader, etc. They are moving toward Google Hangouts.
15:01:11 <flo-retina> I may be wrong, but I don't see that happening soon
15:01:24 <flo-retina> I wouldn't be surprised if yahoo killed a few services though.
15:01:41 <clokep> Umm...did atuljangra attach a new XMPP patch but not the FT patch? :-S
15:04:11 <flo-retina> fun: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5a0afa466c2 :-P
15:06:30 * qheaden is still trying to understand Promise. He wonders if JS lies to people.
15:08:05 <flo-retina> qheaden: no, only students and tilers do that :-P.
15:08:22 <qheaden> :P
15:08:47 <flo-retina> my tiler did a quite thorough job at it :-P.
15:10:56 <instantbot> clokep@gmail.com granted feedback for attachment 2572 on bug 2037.
15:10:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2037 nor, --, ---, atuljangra66, ASSI, Support for File transfer for XMPP
15:12:18 <clokep> flo-retina: That's gross...
15:12:36 * clokep throws attachment 2572 over the wall to flo.
15:12:37 * flo-retina isn't sure "Only one blank line between functions, everywhere, always." is really a strong rule.
15:12:50 <flo-retina> clokep: where "that" is? :)
15:13:17 <clokep> flo-retina: That m-i change.
15:15:02 <flo-retina> ah :)
15:15:16 <aleth> clokep: Shouldn't stuff like "Cu.reportError("Method not supported " + methodText);" really be account.LOG(...) ? Not all of them should be system messages.
15:16:04 <clokep> aleth: I don't think I said that one should be a system message, did I? ;)
15:16:09 <flo-retina> I'm not sure we want to checkin that XMPP patch soon.
15:16:27 <clokep> What I said was that the user doesn't care if the other client doesn't support FT at all or doesn't support any of our supported methods.
15:16:40 <clokep> It all just =s "The file transfer can't succeed."
15:16:49 <flo-retina> adding support for IBB without supporting direct connection seems wrong. And I don't want Atul to spend another 2 weeks preparing a patch for the direct connection XEP at this point.
15:16:56 <aleth> clokep: Oh, OK then
15:17:15 <flo-retina> I think the point of the current XMPP patch is mostly to have _something_ to test the FT UI with.
15:17:30 <aleth> flo-retina: It certainly couldn't land with the current restriction to text files (which puzzles me).
15:18:04 <flo-retina> clokep: "It all just =s "The file transfer can't succeed."" well, it's all just "offer FileLink"
15:18:34 <flo-retina> aleth: the other concern is that it's restricted to very small files ;)
15:18:42 <flo-retina> aleth: everything go through the servers, with a lot of overhead
15:19:12 <flo-retina> that doesn't make sense for files that weight more than a few kB
15:19:17 <aleth> flo-retina: Right, but that's inherent in that particular method ;)
15:19:26 <flo-retina> aleth: which is meant as a *fallback*
15:19:28 --> Optimizer has joined #instantbird
15:19:43 <clokep> flo-retina: Yes, well that's all the same thing to me. It's all "the prpl failed!!!!"
15:19:57 <flo-retina> clokep: except the user doesn't want to know what a prpl is :-P
15:19:58 <aleth> flo-retina, clokep: I don't think a core FT method should worry about what happens when it says it can't succeed
15:20:13 <flo-retina> clokep: at that point the user is just thinking about driving around with a usb stick ;)
15:20:37 <clokep> flo-retina: I agree 100% with you, I'm not sure what point you're trying to make. :-S
15:20:44 <aleth> We could put that in a system message? ;)
15:20:50 <flo-retina> clokep: no real point.
15:20:52 <clokep> aleth: "core FT method"? :P
15:21:05 <flo-retina> clokep: but I think it's too early to be concerned about the wording of error messages
15:21:18 <clokep> Someone needs to discuss with atul about how things will know if we should start using filelink.
15:21:30 <clokep> flo-retina: I didn't care about the wording, I just wanted it in a system message, which is a trivial change.
15:21:45 <clokep> (But that was also with the assumption we'd want it to land.)
15:21:48 <flo-retina> I know
15:21:51 <aleth> clokep: file transfer protocol implementation in the core as opposed to the ui :P
15:22:07 <flo-retina> (well, I don't remember reading "system message" in the bug comment)
15:23:07 <flo-retina> clokep: I would like to land the idl and UI changes asap. I don't see any pressure to land XMPP-specific stuff. (as long as the patch is trivially accessible to do some testing, that's enough for now I think)
15:23:35 <clokep> flo-retina: WFM.
15:23:43 <clokep> Then one of us can start on DCC. :P
15:24:40 <flo-retina> I also suspect I won't have time for a thorough review of the XMPP stuff before at least 3 weeks.
15:24:51 <nhnt11> re
15:25:26 <flo-retina> during the next 2 weeks, I would like to give priority to things that will unblock our students for the rest of the summer :)
15:25:40 <flo-retina> (and yes, I need to figure out how we can land a prpl pref'ed off -_-')
15:26:06 <clokep> You read my mind. :-D
15:26:14 <clokep> nhnt11: I think I left you a message somewhere...
15:26:27 <nhnt11> clokep: Will read scrollback in a minute.
15:26:41 <clokep> (Also, maybe I did last night?)
15:30:29 <flo-retina> I didn't know https://developer.mozilla.org/en-US/docs/Web/API/window.self :-S
15:41:52 <qheaden> clokep: Do you happen to have the URL to that main Yahoo protocol documentation site we've been referencing? The one that contains all of the buddy status codes, etc.?
15:42:23 <qheaden> I forgot I have it bookmarked in Linux not Windows, and I don't have sync setup. I can't seem to find it online.
15:44:26 <-- aleth has quit (Quit: Ciao)
15:50:56 <-- gerard-majax__ has quit (Ping timeout)
16:16:22 --> mib_mlx0kl has joined #instantbird
16:16:43 --> nhnt11-retina has joined #instantbird
16:17:12 * flo-retina is now known as flo
16:17:24 <mib_mlx0kl> clokep pleASElook at http://mibpaste.com/L7HK77 
16:19:42 <mib_mlx0kl> flo  pleASElook at http://mibpaste.com/L7HK77
16:20:37 <qheaden> mib_mlx0kl: Could be an issue with permissions.
16:20:41 <qheaden> I'm not sure though.
16:20:57 <mib_mlx0kl> ok
16:21:31 <-- mib_mlx0kl has quit (Quit: http://www.mibbit.com ajax IRC Client)
16:21:45 * flo wonders if that guy was on debian
16:22:47 <flo> someone sent me the same error log 2 weeks ago, asking for help; and then 10 minutes later he emailed me the solution
16:22:58 <qheaden> :P
16:25:34 <flo> if he ever comes back, his problem is discussed at: http://stackoverflow.com/questions/15608236/eclipse-and-google-app-engine-importerror-no-module-named-sysconfigdata-nd-u
16:26:09 <flo> and apparently the solution is:
16:26:09 <flo> sudo apt-get install python-pip ; sudo pip install --upgrade virtualenv
16:26:31 <qheaden> Ahh okay.
16:30:21 <-- nhnt11-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:32:42 --> gerard-majax__ has joined #instantbird
16:35:00 --> atul_eating has joined #instantbird
16:36:18 <-- gerard-majax__ has quit (Ping timeout)
16:36:34 <atul_eating> Clokep thanks for the reviews. I'm currently in a restaurant. So wont be able to address them right now.
16:37:34 <qheaden> atul_eating: Buy me a meal. :)
16:37:47 <atul_eating> Also regarding the other changes , do you mean changes in other files?
16:37:49 <qheaden> I'll pay shipping. ;)
16:38:12 <atul_eating> Hehe :P gimme you address ;)
16:38:19 <flo> qheaden: offtopic
16:38:58 <qheaden> :P
16:39:30 --> Mook_as has joined #instantbird
16:43:40 <atul_eating> Regarding the missing . in comment, i checked all the comments before posting, i guess one comment escaped :(
16:46:04 <qheaden> I'll return in a bit.
16:46:07 * qheaden is now known as qheaden_away
16:47:58 --> FireFly_TB has joined #instantbird
16:58:49 <clokep> qheaden_away: I don't, but I can find it.
17:02:27 <clokep> qheaden_away: You sohuld set up Firefox sync. ;)
17:12:44 <-- jb has quit (Ping timeout)
17:17:08 <nhnt11> clokep++. Firefox Sync is awesome.
17:23:17 * qheaden_away is now known as qheaden
17:23:18 <qheaden> Back
17:23:39 <qheaden> clokep: I have FF sync setup on my Windows side, but not my Linux side. :-/
17:24:10 * qheaden wonders if Ib will be ported to Firefox OS.
17:25:40 <flo> qheaden: seems difficult. Firefox OS apps don't have XPCOM access :-/.
17:25:53 <qheaden> flo: Ouch.
17:27:00 <flo> so I guess we would need to see if webidl can replace idl for what we do
17:27:42 <-- flo has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:27:52 <-- atul_eating has quit (Ping timeout)
17:32:46 <qheaden> clokep: Check the first subheading: http://www.ymessengerblog.com/blog/2012/11/30/updates-to-yahoo-messenger-features/
17:49:10 --> nhnt11-retina has joined #instantbird
17:49:36 <qheaden> clokep: Check this page, it contains information about the state of Yahoo! Chat and interoperabilty with Windows Live Messenger. http://en.wikipedia.org/wiki/Yahoo!_Messenger#Interoperability
17:49:41 <qheaden> Of course with references.
17:50:03 <nhnt11-retina> clokep: http://log.bezut.info/instantbird/130711/#m433 That's the current behavior in my patch.
17:51:20 <clokep> qheaden: What's your point?
17:51:29 <clokep> It looks like they closed their public chatrooms and that MSN shut down?
17:51:37 <qheaden> Yeah.
17:51:49 <qheaden> Still trying to figure out why rooms are still showing in Pidgin.
17:52:02 <qheaden> And even so, should we support them.
17:52:04 <clokep> I don't see how that translates into "They're going to get rid of Yahoo Messenger or change it dramatically" :P
17:52:48 <qheaden> clokep: Ha ha. I wasn't trying to make that point. :P
17:52:58 <qheaden> Looking at the official site, I've changed my mind on that issue.
17:55:34 <qheaden> clokep: So should we remove public conferences from the Etherpad?
17:55:50 <clokep> qheaden: Why? Why do you keep wanting to ignore that?
17:56:48 <qheaden> clokep: I'm downloading Pidgin now to see if those conferences work.
17:57:35 <clokep> qheaden: Leave it on there. I want that to list every possible feature.
17:57:56 <qheaden> I'm just hoping we don't have to implement it. It sounds like something that would be hard to test.
17:58:25 <clokep> We're not going to worry about it right now, I'm more interested in you getting Yahoo! JAPAN to work.
17:58:54 <qheaden> clokep: I'm sure you see from the commit message, I got custom conference invite messages and multiple invites working.
18:01:48 <clokep> qheaden: Yes, I commented earlier. ;)
18:02:59 <qheaden> clokep: Okay, I downloaded Pidgin and tried to connect to a few chat rooms. Using WireShark I see a connect message being sent to the server, but the server returns with a System Busy disconnect message. The chats are non-functional.
18:03:41 <clokep> qheaden: OK. I wonder if EionRobb had a cache or something crazy.
18:04:04 <qheaden> clokep: No, the chatroom list came up the same on my PC as did his. But you can't join anything.
18:04:23 <qheaden> Even that Role Playing Game room that claims to have 1 user in it.
18:05:01 <clokep> Oooo, OK.
18:05:03 <clokep> Weird.
18:06:07 <qheaden> clokep: I think it has something to do with this list: http://insider.msg.yahoo.com/ycontent/?filter=timef&imv=timei&system=timesy&sms=timesm&chatcat=timec&ab2=timea&intl=us&os=win
18:07:04 <clokep> ...?
18:07:36 <qheaden> clokep: That XML list contains some chat room categories. Not sure how the rest of the chat room query goes.
18:08:17 <clokep> qheaden: Well don't worry about this anymore for now.
18:08:53 <qheaden> clokep: Alright. I'm going to sign up for a Yahoo! JAPAN account now. :)
18:11:33 <clokep> Cool.
18:11:36 <clokep> So that and options now. :)
18:12:09 <clokep> You're probably going to have to refactor a few things btw...
18:12:33 <qheaden> clokep: So will the Yahoo Japan account class inherit YahooAccount?
18:12:47 <clokep> No, it will be YahooAccount.
18:12:49 <clokep> They're the same.
18:13:08 <clokep> The only thing you need to make a YahooJapanProtocol object.
18:13:16 <qheaden> Ahh okay.
18:13:33 <clokep> Hopefully at least.
18:13:38 <clokep> That's what we're going to start w/.
18:13:58 <clokep> But you'll probably need to move everything out of yahoo.js except the YahooProtocol and put it into a module?
18:14:04 <qheaden> Looks like I'm going to have to move some of the connection URLs to YahooProtocol since they are different for YahooJapan.
18:14:40 <qheaden> Maybe move YahooAccount and the others into yahoo-base.jsm?
18:15:36 * qheaden is bewildered by the Yahoo JAPAN front page.
18:15:51 <clokep> qheaden: Why not just yahoo.jsm? ;)
18:16:06 <clokep> And some of the connection URLs are different, yes. You need to do something w/ that.
18:16:19 <qheaden> Okay, yahoo.jsm will work.
18:16:32 <clokep> (Either pass them into the account object or have a flag somewhere or something...)
18:17:43 <qheaden> Can the protocol be accessed from the account object?
18:18:00 <qheaden> *protocol object
18:18:06 <clokep> I'm not sure.
18:18:08 <clokep> Check the interface.
18:18:15 <clokep> (I don't think so though.)
18:18:41 <clokep> My guess is you're going to want to pass in an object to the account that has the URLs to connect to.
18:18:41 * qheaden needs to pass the JAPAN site through a translator.
18:18:58 * clokep thinks Mook_as might speak Japanese? Or was it Chinese?
18:20:02 <qheaden> Okay, I'll probably store the protocol in the account object, and place the correct URLs on the protocol object. I can then access the protocol object, via the account object, from the login helper, and access the connection URLs.
18:20:30 * qheaden finds the registration page.
18:21:00 <clokep> That would probably work fine, yes.
18:21:15 <qheaden> Ahh great, Firefox has a translate addon. I'm good.
18:21:27 <clokep> qheaden: You also could override the account and put them on there?
18:21:37 <clokep> Where are they stored now anyway? :-S
18:21:46 <qheaden> clokep: As a constant in yahoo-session.jsm.
18:21:51 <qheaden> *constants
18:22:00 <clokep> Ah, OK.
18:23:00 <clokep> qheaden: It looks like there are other differences too, like the client version?
18:23:21 <qheaden> Yeah. The differences I think are listed on that IMFreedom website.
18:25:23 <clokep> qheaden: Also http://pastebin.instantbird.com/243179 might be useful.
18:26:03 <qheaden> clokep: Thanks.
18:26:10 <Mook_as> clokep: sorry, chinese.
18:26:57 <Mook_as> I usually use google translate or http://www.excite.co.jp/world/english/web/ for japanese - for the select list thing, use the second option for ja->en
18:30:48 <qheaden> Mook_as: Yeah, I'm using Google Translate now.
18:36:30 * qheaden wonders why the Y! JP sign up page has a field for a connection mail address, and another for a Y! JP ID. Shouldn't they be the same? :-S
18:42:26 <qheaden> Finally got an account.
18:45:34 <Mook_as> perhaps you're more likely to have an email account for your phone? (mapped to SMS, or something like that)
18:46:38 <qheaden> Mook_as: I don't know, but it is a required field.
18:46:52 <qheaden> And it can't be a Yahoo mail address.
18:47:21 --> gerard-majax__ has joined #instantbird
18:47:24 <Mook_as> ah, a fallback address for lost passwords and the like, probably, then?
18:48:22 <qheaden> I don't know. I guess that's it.
18:48:29 --> Mic has joined #instantbird
18:48:29 * ChanServ sets mode +h Mic 
18:49:38 <Mic> Hello
18:49:47 <nhnt11-retina> Hi
18:49:48 <qheaden> Hi Mic.
18:50:56 <qheaden> clokep: You sure yahoo.jsm won't be a little confusing with yahoo.js at first glance?
18:51:14 --> bwalker has joined #instantbird
18:51:42 <bwalker> Q: is there a way to suppress "so-and-so has entered/left the room" messages in Instantbird ? I looked and could not find a way
18:51:42 --> myk has joined #instantbird
18:52:02 --> atuljangra has joined #instantbird
18:52:03 <nhnt11-retina> bwalker: I think there's an addon for that. Not sure.
18:52:32 <atuljangra> clokep: By "print an error in the conversation" means using system message?
18:53:17 --> rosonline has joined #instantbird
18:53:47 <-- rosonline has quit (Client exited)
18:53:53 --> rosonline has joined #instantbird
18:53:58 <atuljangra> flo-retina do we need to handle the case of binary files(images etc) in the first landing? iirc we decided to do that later, and first make it land for plain text files.
18:54:35 <atuljangra> clokep: file.writes takes an ArrayBufferView and not ArrayBuffer, thus I'm using Uint8Array there.
18:55:13 <bwalker> nhnt11-retina: thanks, i haven't found anything yet, but i'll keep looking
18:58:44 <atuljangra> aleth: http://log.bezut.info/instantbird/today#m538 I'll remove this one when we are somewhere. Also, we cannot send larger files through ibb, I guess we can wait till FileLink is there. :)
18:59:41 <atuljangra> clokep: ++ for http://log.bezut.info/instantbird/today#m555
19:02:41 <atuljangra> I seem to have some time before we can have a discussion, so I guess I can look up the encoding thing as fast as possible.
19:02:47 <Mic> nhnt11, nhnt11-retina: has the confusion about the click behaviour on the richlist  been solved later? I've reached the point in the logs where the talk is about single/multiple selection with modifier keys.
19:03:12 <Mic> Should we just have "Middle click opens in new tab in background" and Ctrl-Enter for the same to work around that?
19:03:27 <nhnt11-retina> Yeah
19:03:34 <nhnt11-retina> I'm leaning towards just removing multi-select
19:03:37 <Mic> We do not want to select multiple contacts/possible conversations. We want to open them.
19:03:42 <nhnt11-retina> right
19:03:55 <Mic> Opening in background seems to be a good solution in my opinion.
19:04:05 <nhnt11-retina> So I'm going to remove multiselect, make it select on hover, middle click to open in background
19:04:08 <Mic> (i.e. keeping the tab opened after that).
19:04:09 <nhnt11-retina> slash control enter
19:04:14 <Mic> :)
19:04:29 <Mic> + Alt-Enter from the filter box? :P
19:04:49 <nhnt11-retina> ?
19:05:13 <nhnt11-retina> Why? why not Control enter from the filter box too?
19:05:16 <Mic> Alt-Enter opens in a new tab from Fx' awesomebar.
19:06:08 <nhnt11-retina> Doesn't do anything here :-/
19:06:57 <Mic> On Windows it does that...
19:15:48 --> unghost has joined #instantbird
19:21:29 <-- bwalker has quit (Ping timeout)
19:26:16 <atuljangra> Mic: is here, so I'll complete the ui first.
19:26:48 * atuljangra notifications seems to work, needs to add callback function.
19:30:07 <nhnt11-retina> Hmm
19:30:22 <nhnt11-retina> Setting the opacity lower on offline contacts makes scrolling choppy :-/
19:31:26 * nhnt11-retina doesn't think the blue focus ring around the filterbox is ugly :-/
19:34:05 <nhnt11-retina> Mic: Is this fine or should I put the file name in a separate variable? |this.setAttribute("buddyIcon", buddy.buddyIconFilename || "");|
19:35:37 <qheaden> Is it possible to get an "import loop" with JSM files? LIke if A imports B, but B has stuff that it needs to import A.
19:35:57 * qheaden is thinking about what happens with C++ header files.
19:37:04 <Mic> That's OK.
19:42:03 <clokep> qheaden: No, we do that with xmpp.js and xmpp.jsm.
19:42:19 <qheaden> clokep: Yeah, I just noticed that.
19:42:30 <atuljangra> Mic: the if(n) condition there is just to prevent several similar notifications? https://developer.mozilla.org/en-US/docs/Code_snippets/Alerts_and_Notifications#Using_notification_box
19:42:31 <qheaden> clokep: I'm about to push a patch that separates everything out.
19:43:31 <clokep> qheaden: I don't think you can do an import loop, I think it throws an error, but you shouldn't have that issue at all.
19:43:48 <Mic> atuljangra: yes, I think so. I don't think we want that. If we have different file transfers incoming, they should be stacked (imo) and not replace each other.
19:44:30 <atuljangra> Yes. I figured that out. And how does callback exactly work. I suppose, they will be called when we press button?
19:45:38 <clokep> atuljangra: You should start discussion about what to do with FileLink and how it gets initiated, but do not wait for US to start that conversation. It is YOUR responsibility to start that conversation w/ us.
19:46:46 <atuljangra> clokep: I was planning to finish up the ui and proper encoding, so that we can have something working properly. And then we can start with Filelink. What are your opinions?
19:47:11 --> mpmc1 has joined #instantbird
19:47:17 <atuljangra> Mic: I tried a callback function, added it to the button, but it seems, they are called without doing anything, not even pressing the button.
19:47:24 --> flo-retina has joined #instantbird
19:47:25 * ChanServ sets mode +qo flo-retina flo-retina 
19:47:31 <qheaden> Mook_as: Is there a way to convert line endings from Windows to Unix in Komodo Edit?
19:47:36 <clokep> atuljangra: My point is you might want to start the discussion before you run out of things to do.
19:47:53 <clokep> qheaden: There's a clean line endings thing, yes. And you can specify the line ending too.
19:48:16 <clokep> qheaden: Edit > Current File Settings & Code > Clean Line Endings
19:48:21 <-- mpmc has quit (Ping timeout)
19:48:30 <clokep> atuljangra: I don't have an "opinion" on this, I was hoping flo-retina would have a clever idea.
19:48:43 <qheaden> clokep: Thanks a mil. :)
19:48:44 <atuljangra> clokep: Yes. I'll keep a track of that. Currently for today I've ui and encoding and finally updated patch to create. I'll start the discussion after that? I hope that it's okay.
19:48:52 <atuljangra> clokep: Okay :)
19:51:06 <clokep> Btw there isn't any way to not show the join/quit messages, but Bubbles collapses them.
19:51:23 <nhnt11-retina> So does paper sheets :)
19:55:00 <qheaden> From IMFreedom wiki: "it is not possible for a user on the Yahoo JAPAN network to chat with a user on the "normal" Yahoo network (or vice versa)". That makes things a LOT easier.
19:56:17 <clokep> qheaden: Oh, did you not realize that?
19:56:24 <clokep> They're essentially two instances of the same network.
19:56:39 <clokep> You can think of it as two IRC networks or unfedereated XMPP networks (e.g. Google and Facebook)
19:57:03 <qheaden> clokep: I read it before, but completely forgot. That makes sense.
19:57:40 <qheaden> I'm going to have to create a couple more accounts then.
19:58:15 <clokep> Yes. ;)
19:58:19 <clokep> But now you know how to!
19:58:28 <clokep> I'll create one too at some point for you.
20:00:40 * qheaden hands clokep Learn Japanese in 24 hours.
20:00:50 <clokep> I'm awful at learning languages. :-/
20:01:06 * nhnt11-retina assumes clokep means human languages and not computer ones :P
20:01:06 <qheaden> Me too, except programming languages. ;)
20:01:56 <nhnt11-retina> flo-retina: Looks like we're getting rid of richlistbox.css on the blist tab then
20:02:50 <flo-retina> nhnt11-retina: not sure why you say this
20:03:05 <qheaden> clokep: Is this better? http://pastebin.instantbird.com/243241
20:03:31 <nhnt11-retina> flo-retina: To implement "select" on hover, I've just used the hover selector on CSS. This requires me to duplicate most of richlistbox.css but with :hover instead of [selected="true"]
20:03:34 <clokep> qheaden: I don't know if we normally use tabs or what in those files. but the spacing seems wrong.
20:03:51 <clokep> nhnt11-retina: flo-retina Whoa, whoa, select on hover sounds like an awful UX.
20:03:56 <nhnt11-retina> Well I guess we should still keep it for the other stuff.
20:03:56 <flo-retina> clokep: I still think the request to hide join/part messages isn't what people actually want. They are just frustrated that things are currently useless in very busy channels, and suboptimal in very quiet channels :-/.
20:04:07 <qheaden> clokep: Oh yeah, I think Makefiles require tabs.
20:04:10 <flo-retina> I'd like to significantly improve Bubbles for both of these cases
20:04:16 <clokep> flo-retina: I'm sure. :)
20:04:24 <nhnt11-retina> clokep: Um, I think you're misunderstanding "select on hover"
20:04:27 <clokep> qheaden: They don't require it, I don't think. But it's what we use.
20:04:30 <-- rosonline has quit (Client exited)
20:04:37 <clokep> nhnt11-retina: Then please explain, cause it sounds bad.
20:04:41 <nhnt11-retina> Basically the item on which the mouse is hovered gets the selection highlight
20:04:51 <nhnt11-retina> Pretty much identical to awesomebar
20:05:15 <clokep> Oh, OK. So you're not actually selecting it.
20:05:17 <nhnt11-retina> I can screengrab for you if you'd like.
20:05:18 <nhnt11-retina> Yeah.
20:05:26 <nhnt11-retina> That's why "select" in quotes.
20:05:44 <flo-retina> clokep: makefiles require a tab at the beginning of each executable commands
20:05:54 <flo-retina> clokep: so we usually do the rest of the indentation in makefiles with tabs too
20:06:19 <flo-retina> clokep: yeah, he meant "highlight", not "selection".
20:08:01 <clokep> I'm OK with highlighting. :)
20:08:07 <clokep> flo-retina: Oh OK.
20:09:05 <qheaden> clokep: Okay, I tabified everything and the spacing looks the same, but it uses the same number of tabs as that in the IRC Makefile.in.
20:10:13 * nhnt11-retina is starting to get the hang of CSS selector specificity (he thinks)
20:12:22 <clokep> qheaden: OK.
20:12:32 * clokep usually uses tabs == two spaces.
20:12:49 <Mic> nhnt11-retina: just read http://www.w3.org/TR/selectors/#specificity
20:12:59 <nhnt11-retina> :)
20:13:23 <nhnt11-retina> Is there an easy way to just disable item selection in a listbox?
20:13:29 <nhnt11-retina> There's no seltype="none" :/
20:13:43 <clokep> Why do you want to?
20:14:07 <flo-retina> clokep: tabs are usually 8 spaces for me
20:14:17 <qheaden> Mine are set to two spaces.
20:14:38 <nhnt11-retina> clokep: If you select an item, by default it gets a border and stuff.
20:14:47 <qheaden> Nevermind, looks like 4 spaces. :P
20:14:58 <clokep> nhnt11-retina: And that's not wanted?
20:15:21 <nhnt11-retina> clokep: Yeah, because if you click an item and then hover on another item, the first item will still be selected
20:15:35 <flo-retina> nhnt11-retina: are you talking about the focus ring?
20:16:02 <nhnt11-retina> flo-retina: Not sure. I'd have to enable multiple select again to be sure.
20:16:17 <flo-retina> the dotted 1px border around the active element?
20:16:33 <Mic> It's not a border, it's an outline :P
20:16:38 <nhnt11-retina> Ah, yes it's a focus ring
20:16:45 <nhnt11-retina> And no, not that
20:16:52 <nhnt11-retina> This one is solid yellow :S
20:16:55 <Mic> atuljangra: you're unblocked at the moment?
20:17:28 <nhnt11-retina> The easiest way to get rid of this problem is to just disable selection
20:17:36 <atuljangra> Mic: Yes. I was preparing a question for you regarding the callbacks of aSubject.accept and deny. lmptfy :)
20:17:37 <Mic> I just saw your comment about the callbacks, that's why I wonder...
20:17:43 <-- gerard-majax__ has quit (Ping timeout)
20:17:46 <nhnt11-retina> A hack would be to unselect selected items in onselect
20:18:15 <qheaden> clokep: So should I create a separate yahoo-jp folder under the protocols folder?
20:18:36 <Mic> nhnt: another hack would be to try "richlistbox.addItemToSelection = function () {};" ;)
20:18:43 <nhnt11-retina> Haha
20:18:49 <clokep> qheaden: No.
20:19:18 <clokep> qheaden: Just put another file yahoojp.js under the yahoo folder.
20:19:25 <clokep> At least that's my opinion on it, I hope that won't break things. :)
20:19:32 <qheaden> clokep: Sounds good.
20:19:50 * clokep forgets how icons get handled and if it's done automatically or what.
20:23:01 <atuljangra> Mic: http://pastebin.instantbird.com/243252
20:23:04 <nhnt11-retina> Mic: is the hack you suggested acceptable?
20:23:12 <Mic> I don't think so.
20:23:36 <Mic> I don't understand the problem exactly by the way.
20:23:44 <Mic> Why is having a selection a problem?
20:23:58 <nhnt11-retina> Never mind about it actually
20:24:06 <qheaden> instantbot: uuid
20:24:06 <nhnt11-retina> Once I implement the click stuff it will go away on its own I think
20:24:07 <instantbot> 5f6dc733-ec0d-4de8-8adc-e4967064ed38 (/msg instantbot cid for CID form)
20:26:14 <Mic> atuljangra: you want to send an object with the notification that contains information about the file transfer and a way to accept or reject it.
20:26:14 <flo-retina> atuljangra: do you really need a "deny" button?
20:27:11 <atuljangra> flo-retina: no, I will remove it. 
20:27:13 <Mic> flo-retina: it might be an obvious way to get rid of the notification if someone doesn't want to accept the transfer.
20:27:32 <atuljangra> kept it just for ux
20:27:33 <flo-retina> atuljangra: the question in that pastebin is "how do I create a new idl?" ?
20:28:01 <flo-retina> Mic: there's an (X) at the end of notification bars
20:28:11 <atuljangra> No, what do I need to allow this whole operation. I'm sorry if it meant that.
20:28:23 * clokep wonders if there is a difference between ignoring a transfer and denying one...
20:28:45 <atuljangra> clokep: I guess not. :)
20:29:39 --> bwalker has joined #instantbird
20:31:04 <atuljangra> Mic: okay. So I guess conv, file, and a boolean function would do?
20:31:35 <Mic> atuljangra: what do you mean?
20:32:26 <atuljangra> Mic: The object that I need to send, should be containing the conversation,  the file, and some function which returns a boolean value
20:34:24 <Mic> In my opinion the object (fileTransferRequest?) would need to contain the conversation it belongs to, the file name and a method to accept and reject it. 
20:34:49 * clokep wonders if flo-retina wants to ask b walker what his real issue is. ;)
20:35:27 <flo-retina> Mic: why is the conversation relevant? Aren't there protocols where sending a file without starting a conversation is possible?
20:36:08 <atuljangra> Mic: Okay seems good.
20:37:24 <flo-retina> atuljangra, Mic:  it should contain all the information we have about the file that we may want to present to the user to help make a decision: file name, size, type; and info about the sender
20:37:57 <atuljangra> flo-retina: fileTransferRequest can extend prplIFileTransfer right?
20:37:57 <Mic> "info about the sender" is what I meant when I asked to attach it to a conversation.
20:37:58 * qheaden gets his American test Yahoo account locked.
20:39:30 <flo-retina> atuljangra: why?
20:39:37 * Mic is now known as Mic|OtherManager
20:39:46 * Mic|OtherManager is now known as Mic
20:40:24 <atuljangra> It can have all such information inherited then. I don't know much about this here, so just guessing.
20:41:16 <Mic> Do we need a new tab label color for conversations with incoming file transfers?
20:41:21 <nhnt11-retina> flo-retina: Okay, so I'm getting rid of multiple selection. This is okay? Asking you to confirm one last time.
20:41:43 <Mic> nhnt11-retina: I think you were the only one who wanted that ;)
20:41:56 <nhnt11-retina> Mic: Meh, middle click means I don't anymore :)
20:42:16 <qheaden> clokep: Good news. I was able to log into my Yahoo JP account from my plug-in.
20:42:28 <flo-retina> nhnt11-retina: :)
20:42:29 <Mic> qheaden++
20:42:35 <flo-retina> qheaden: :)
20:42:59 <clokep> qheaden: Excellent! Doesn't seem like it was too much work then. ;)
20:43:05 <qheaden> Only had to change 3 login parameters. :P
20:43:24 <qheaden> 4 rather. Pager request url, login token urls, and the build id.
20:44:05 <-- bwalker has quit (Ping timeout)
20:45:55 <atuljangra> flo-retina: Should I create a new idl file for prplIFileObserver? Or include it in prplIFileTransfer
20:46:18 <clokep> Put it in the same one.
20:46:43 <flo-retina> atuljangra: what's prplIFileObserver?
20:47:01 <atuljangra> clokep: OKay extending nsISupports?
20:47:12 <Mic> That's mandatory.
20:47:13 * flo-retina wonders why we need an observer there
20:47:27 <atuljangra> flo-retina: Sorry sorry, I meant fileTransferRequest
20:47:59 <flo-retina> s/Request/Offer/
20:48:28 <atuljangra> fileTransferOffer it is
20:48:35 <atuljangra> Mic: okay :)
20:49:08 <atuljangra> instantbot: uui
20:49:11 <instantbot> atuljangra: Sorry, I've no idea what 'uui' might be.
20:49:14 <atuljangra> crap
20:49:19 <atuljangra> instantbot: uuid
20:49:20 <instantbot> 99a7ecce-8972-482f-8841-c9741830dac9 (/msg instantbot cid for CID form)
20:53:56 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt11-retina))
20:53:59 --> nhnt11 has joined #instantbird
20:54:19 <-- nhnt11 has quit (NickServ (GHOST command used by nhnt11-retina))
20:54:21 * nhnt11-retina is now known as nhnt11
20:54:23 --> nhnt12 has joined #instantbird
20:56:54 * nhnt11 is now known as nhnt11-retina
20:57:18 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
20:58:11 --> EionRobb has joined #instantbird
21:01:55 <clokep> Do we usually do this: https://bitbucket.org/qheaden/instantbird-gsoc-2013/commits/1d2c6cef62ec8b4c5ea9b725a91b4289df641d10#Lchat/protocols/yahoo/yahoo.manifestF1T1 or not interleave the different components?
21:02:28 <nhnt11-retina> Mic: I'm going to push a commit soon. I wonder if you could test it out before I submit a patch. I've made a few changes which I think are nice :)
21:02:30 <flo-retina> I think we usually group the lines that are for the same component
21:02:42 <flo-retina> and maybe with an empty line between them
21:02:44 <nhnt11-retina> It resembles awesomebar more now (the name of the first contact is auto-completed in the filterbox itself)
21:03:50 <flo-retina> clokep: do we really need a yahoo.jsm file?
21:04:15 <clokep> flo-retina: We could probably put both definitions in the same file.
21:04:18 <flo-retina> clokep: if both components where in the same file, couldn't we just have a YahooJapan object taking the standard Yahoo object as prototype?
21:04:19 * clokep didn't want the file to get huge.
21:04:40 <clokep> Yes, I didn't think we'd want to do that.
21:04:44 <flo-retina> qheaden: the option labels should use getters
21:05:08 <qheaden> flo-retina: Okay.
21:05:20 <flo-retina> clokep: if it's as trivial as changing 3 urls, it probably wouldn't add much to the file
21:05:46 <qheaden> flo-retina: I was thinking of the prototype method as well.
21:06:01 <flo-retina> bah, irc.js doesn't use getters either :(
21:06:17 <flo-retina> I don't remember if I filed a bug for that or not at the time I was dumping all strings of the JS heap
21:06:19 <clokep> qheaden: Then why didn't you say something? :P
21:06:47 <clokep> qheaden: You can change it to be that (it'd just be copy & pasting stuff now, pretty much)
21:06:48 <flo-retina> clokep: because you are a scary mentor terrifying his student :-P.
21:06:48 <qheaden> clokep: I thought I did. Guess I was thinking out to loud. :P
21:06:53 * clokep doesn't have an opinion other way.
21:08:01 <flo-retina> qheaden: in case that wasn't clear, here is an example of what I meant by "use getters": http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.js#30
21:08:55 <qheaden> flo-retina: Okay thanks. Does using getters allow the lazy string getter to do its job and only get the string when needed?
21:08:56 <flo-retina> hmm, bug 1943
21:08:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1943 tri, --, 1.4, florian, RESO FIXED, irc.js should use lazy getters for localized strings
21:09:03 <-- EionRobb has quit (Ping timeout)
21:09:47 <flo-retina> bah, the irc.js file I looked at (completed by my not-so-awesome-bar) was the one from comm-central :(
21:10:17 --> EionRobb has joined #instantbird
21:10:35 <nhnt11-retina> Bah, this may be a bit more complicated than I thought, it'll have to be a follow up :(
21:10:42 <flo-retina> qheaden: yes. With the getters we will touch the .properties file only the first time these strings are displayed. With your current code the file is read during startup
21:10:55 <qheaden> Understood.
21:11:00 <flo-retina> nhnt11-retina: I think we asked you several times to keep this patch as simple as possible so that it can land ;).
21:11:19 <nhnt11-retina> But.. but.. it's cool :P
21:12:02 <-- EionRobb has quit (Ping timeout)
21:12:10 <flo-retina> nhnt11-retina: cool follow ups are cool too. And then you can have one cool feature landing everyday, and people loving you for it everyday, instead of just once ;)
21:12:16 <nhnt11-retina> :D
21:12:34 <nhnt11-retina> okay. The new mouse interaction is ready I think
21:12:37 <flo-retina> qheaden: nit: "port : {label:" no space before ':'
21:12:44 <flo-retina> nhnt11-retina: do you like it?
21:12:50 <nhnt11-retina> Yes.
21:12:59 <flo-retina> :)
21:13:07 <qheaden> flo-retina: Okay.
21:13:50 <nhnt11-retina> flo-retina: Do I need to add mousethrough="always" to boxes too?
21:14:08 <nhnt11-retina> And if I do add it to a box, will it apply to children?
21:14:12 <nhnt11-retina> Bah why am I asking, I should google
21:14:16 <qheaden> Well, I'm going to have to sign off now. I have some other things to take care of. :-/
21:14:37 <flo-retina> nhnt11-retina: you should google or just try. I don't know the answer
21:14:47 <-- mpmc1 has quit (Ping timeout)
21:14:49 <Mic> nhnt11-retina: I can try
21:14:56 <nhnt11-retina> Googled. Setting mousethrough="always" applies to children
21:14:59 --> EionRobb has joined #instantbird
21:15:05 --> mpmc has joined #instantbird
21:15:33 <flo-retina> nhnt11-retina: out of curiosity, why do you need it? :)
21:15:54 <nhnt11-retina> To make sure click events always have the target set to a newtab-contact
21:16:11 <nhnt11-retina> Maybe I could just add the handler to the newtab-contact binding though. Hmm
21:16:26 <Mook_as> event.currentTarget?
21:17:04 <nhnt11-retina> Mook_as: I've been using getBindingParent on originalTarget, and sometimes it says that the property I'm trying to access is undefined
21:17:16 <nhnt11-retina> I haven't tried current target though
21:17:34 <Mook_as> where are you adding the event listener?
21:17:50 <nhnt11-retina> In a handler on the panel binding
21:17:58 <qheaden> clokep: Since there isn't that much difference between the two protocols, I'll just use the inheritance method.
21:18:09 <clokep> qheaden: OK. :) I'm glad that's all the differences.
21:18:23 <Mook_as> the differences are just a few static strings?
21:18:24 <clokep> Sorry to hvae you move code around a bunch of times.
21:18:43 <qheaden> clokep: No, that's fine! I thought there were going to be more differences as well, but I was surprised.
21:19:24 <qheaden> clokep: In fact, I think it is best if I do some testing with the code as-is, and ensure that there are no further differences than the login URLs and the options.
21:25:56 <nhnt11-retina> Maybe I should not use a handler and add a listener to each list item instead
21:25:58 <nhnt11-retina> Hmm
21:27:21 <flo-retina> why?
21:27:47 <nhnt11-retina> I'm probably just doing something wrong
21:28:17 <flo-retina> have you tried putting the handler in the binding of the item, rather than the binding of the panel?
21:28:24 <nhnt11-retina> That's what I just tried
21:28:33 <nhnt11-retina> But now the item doesn't get deselected
21:28:36 <nhnt11-retina> I can't figure out why
21:29:14 <flo-retina> I would try returning true or false (I can never remember which value does what) at the end of the handler.
21:29:42 --> rosonline has joined #instantbird
21:29:52 <nhnt11-retina> What? Why? Does returning a value prevent further stuff from happening or something?
21:30:02 <nhnt11-retina> I tried event.stopPropagation, that didn't work
21:30:09 <nhnt11-retina> (and preventDefault)
21:30:38 <qheaden> Bye all. :)
21:30:42 * qheaden is now known as qheaden_away
21:30:44 <nhnt11-retina> Bye qheaden_away
21:32:08 <nhnt11-retina> I may be wrong, perhaps it's not getting selected
21:32:24 <nhnt11-retina> but the highlight on hover no longer happens to the clicked element
21:35:33 <Mic> nhnt11-retina: could you pastebin the relevant code?
21:35:57 <nhnt11-retina> Mic: http://pastebin.instantbird.com/243294
21:36:47 <nhnt11-retina> Mic: That code doesn't work, it needs to be originalTarget
21:36:56 <flo-retina> nhnt11-retina: some return values are equivalent to calling preventDefault. And I suspect the behavior you dislike ("item doesn't get deselected") may be that the default action is not executed.
21:37:05 <flo-retina> Just a random guess though, could be completely wrong.
21:38:11 <nhnt11-retina> Aha
21:38:29 <nhnt11-retina> The undefined problem is happening when clicking within the 4px padding
21:40:31 <nhnt11-retina> I've got a workaround
21:40:31 <-- FireFly_TB has quit (Ping timeout)
21:41:01 <nhnt11-retina> Since the item is selected on click and then we deselect it, I'm going to use the currently selected item to create the conversation
21:41:07 <nhnt11-retina> Patch time!
21:41:29 --> bwalker has joined #instantbird
21:42:11 <nhnt11-retina> flo-retina: I'm currently starting a conversation with the first contact in the list even if the user has hovered on another one, on pressing Enter
21:42:23 <nhnt11-retina> I think this is fine since if someone is moving the mouse around, they'll be clicking anyway
21:42:30 <nhnt11-retina> as opposed to hovering on a contact and pressing enter
21:42:41 <nhnt11-retina> Mic ^
21:42:54 <-- EionRobb has quit (Ping timeout)
21:43:12 <clokep> Which patch is this anyway? :-S
21:43:21 <nhnt11-retina> clokep: bug 2015
21:43:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
21:43:33 <atuljangra> Mic: I have another quick question http://pastebin.instantbird.com/243315
21:45:29 <Mic> I expect that select on hover thingie will need testing?
21:45:51 <nhnt11-retina> Mic: Pushing a commit in a minute, if you'd like to test :) Just going through the diff once
21:47:03 <-- clokep has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:48:06 <nhnt11-retina> Mic, flo-retina: Do we want the highlighting to work even when the window isn't focused?
21:48:26 <Mic> I don't even know what it looks like, yet ;)
21:48:33 <nhnt11-retina> Okay :)
21:49:16 <nhnt11-retina> Mic: Just pushed, if you'd like to test :) Pull from awesometab-experimental
21:49:29 <Mic> atuljangra: file transfers will be an IB-only thing, won't they?
21:49:42 <atuljangra> Mic: Yes.
21:50:03 <nhnt11-retina> Won't filelink serve as a fallback for Ib to non-Ib transfers?
21:50:29 <Mic> nhnt11-retina: that's not what I meant.
21:50:43 <Mic> Please add "ib" as prefix to the interface name then.
21:50:55 <nhnt11-retina> Oooh
21:51:00 <atuljangra> Mic: Okay. Done.
21:51:12 <Mic> Flo is right that we don't need the conversation on this object.
21:51:12 * nhnt11-retina was wondering :P
21:51:27 <Mic> The sender would be good to know though.
21:51:34 * nhnt11-retina has to go to bed soon, he has to get up early tomorrow and it's 3.20am :(
21:51:55 <atuljangra> Mic: Okay. So just a string with the sender name would be helpful.
21:52:19 <Mic> Do we have more than just the senders name?
21:52:25 <Mic> A contact or buddy or so?
21:52:34 <Mic> We should attach that then imo.
21:52:56 <flo-retina> nhnt11-retina: I'm surprised that addressing the comments I put on that patch yesterday took all day :-S
21:53:03 <atuljangra> Okay. Will do so.
21:53:16 <nhnt11-retina> flo-retina: Um, I was setting up my laptop and had to go out for a couple hours to get it. Sorry.
21:53:17 <atuljangra> Mic: I'll change the interface accordingly.
21:53:21 <flo-retina> well, I guess unpacking the macbook also took an hour or two :)
21:53:46 <Mic> Don't use spaces in the notification name by the way.
21:54:27 <atuljangra> Mic: notif_file_received?
21:55:00 <Mic> No, "file-transfer-offer-received" or something like that.
21:55:36 <Mic> In context of offers, I'd say that they can be "accept"ed or "reject"ed.
21:55:46 <atuljangra> Mic: Okay :)
21:56:20 <Mic> (requests would be granted though;)
21:56:47 <flo-retina> atuljangra: what's the code calling fileReceived?
21:56:54 <atuljangra> okay will change it to accept and reject.
21:56:57 <flo-retina> are you sure that function is called with the correct parameter?
21:57:25 <atuljangra> flo-retina: I've attached it at the bottom. It;s when we receive the filetransfer initiation.
21:58:47 <Mic> The notification should contain the sender's name and the name of the file at least by the way.
21:59:09 <flo-retina> atuljangra: show us a diff of conversation.xml
21:59:19 <atuljangra> Mic: Yes I'll change that. I was just testing. :)
21:59:21 <flo-retina> a real diff, not a small pastebin or a method from it
21:59:26 <atuljangra> flo-retina: lmptfy
22:02:25 <atuljangra> flo-retina, Mic: http://pastebin.instantbird.com/243317
22:03:03 <flo-retina> |case "file received":| -> no space in notification names please
22:03:31 <atuljangra> Mic just told me that, I was just testing things. Will change this.
22:04:00 <nhnt11-retina> Mic: Are you going to test my commit soon? Sorry for nagging but I need to go soon :(
22:04:00 <atuljangra> Btw strangely enough, I'm not getting that error. But still I want Mic and flo-retina to look at the code.
22:04:10 <Mic> nhnt11-retina: not soon enough, sorry.
22:04:23 <nhnt11-retina> Okay. I'll upload a patch then.
22:04:40 <flo-retina> nhnt11-retina: do you want me to try and test the patch asap?
22:05:00 <nhnt11-retina> flo-retina: If you could do it in the next 10 minutes or so, that would be awesome.
22:05:18 <nhnt11-retina> That would let me fix anything small you find before bed.. thereby increasing the chances of landing this tonigh ;)
22:06:10 <flo-retina> ping me once it's attached then
22:06:15 <atuljangra> flo-retina, Mic: How should I stall the ft for waiting for accept/reject? While loop on "accepted" changes seems bad. (context in xmpp.js pastebin line #35
22:07:01 <Mic> Which pastebin is that?
22:07:09 <Mic> And no, we don't want to wait for anything.
22:08:09 <atuljangra> Mic: The earlier one http://pastebin.instantbird.com/243315
22:08:20 <Mic> nhnt11-retina: we'll need to review it before landing, which hopefully will be quick but would need to be done anyways.
22:08:32 <Mic> -anyways
22:08:39 <nhnt11-retina> Understood
22:09:15 <atuljangra> Mic: But we do need to wait for the receiver to press one of the button to process on the ft right? We just need a better method of doing that.
22:09:23 <Mic> atuljangra: can you pastebin more context for the xmpp code?
22:10:00 <atuljangra> Mic: Whole diff is quite big, should I paste this entire function?
22:10:01 <Mic> You send the notification and that's it.
22:10:06 <Mic> Sure
22:11:48 <atuljangra> Mic: http://pastebin.instantbird.com/243318
22:12:04 <Mic> That's not large :P
22:12:06 --> EionRobb has joined #instantbird
22:12:30 <atuljangra> Mic: that's only the function. I said whole diff is large
22:12:31 <atuljangra> :P
22:12:39 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2566 on bug 2015.
22:12:40 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2574 on bug 2015.
22:12:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
22:12:49 <nhnt11-retina> flo-retina: ping
22:13:16 <flo-retina> pong
22:13:34 <nhnt11-retina> Patch attached.
22:14:29 <Mic> flo-retina, atuljangra: store a list of pending file transfers and the button will notify the account which one was accepted or reject?
22:15:13 <Mic> That is when receiving one, you put it into this list and send out the notification.
22:15:28 <Mic> *button callback
22:15:50 <atuljangra> Nice. Makes sense to me. This is very similar to the way we handle auth requests right?
22:16:05 <Mic> No idea how we handle auth requests ;)
22:17:00 <atuljangra> Hehe okay. So this seems reasonable. I guess this may take 1-2 huors for implementation?
22:17:53 <flo-retina> nhnt11-retina: trying now
22:18:03 <nhnt11-retina> Thanks!
22:18:41 <flo-retina> is a follow up to handle Command+N planned?
22:18:47 <nhnt11-retina> Yes.
22:18:53 <flo-retina> cool
22:19:00 <nhnt11-retina> Should be simple.
22:19:07 <atuljangra> Mic: I'll just go and have some coffee and then will leap to implement this today. :D Brb 15 mins
22:19:08 <flo-retina> I still dislike the "Start typing a contact name" string :-S
22:19:24 <nhnt11-retina> flo-retina: "Search contacts" ?
22:19:26 <Mic> I'll go to bed soon
22:19:42 <flo-retina> I think what I dislike is that it doesn't tell me what I'll get if I type something. What about "Start typing to filter"?
22:20:07 <nhnt11-retina> Sure
22:20:13 <atuljangra> Mic: Oh okay. No pbm. I'll try to implement it though. Good night :D
22:20:24 <flo-retina> nhnt11-retina: do you like it?
22:20:36 <nhnt11-retina> I don't really have a strong opinion on it.
22:20:43 <nhnt11-retina> As long as it makes sense
22:21:36 <flo-retina> I got in a situation where pressing Command+T on the blist didn't do anything
22:21:39 <flo-retina> but I can't reproduce
22:22:10 <nhnt11-retina> Hmm
22:22:35 <flo-retina> nhnt11-retina: I really dislike that the view becomes completely blank if no contact matches what I typed
22:22:54 <flo-retina> but that doesn't prevent landing
22:23:12 <flo-retina> the escape key should do something (possibly just get rid of the tab)
22:23:15 <nhnt11-retina> Okay. I'll keep that in mind.
22:23:23 <nhnt11-retina> The escape key clears the search box, no?
22:23:33 <flo-retina> it does
22:23:44 <flo-retina> but on conversation tabs it puts the conversation on hold
22:23:50 <nhnt11-retina> Hm
22:23:57 <flo-retina> and if you keep pressing escape, you get rid of the window, as all tabs go on hold
22:24:07 <nhnt11-retina> Ah
22:24:22 <nhnt11-retina> I don't use escape
22:24:26 <Mic> Shouldn't we have Ctrl+Shift+W for that?
22:24:30 <nhnt11-retina> Okay. Again, i'll keep this in mind
22:24:33 <nhnt11-retina> Mic: ++
22:24:39 <nhnt11-retina> I was just thinking the same..
22:24:47 <flo-retina> Mic: for what?
22:24:52 <Mic> Closing a window.
22:25:02 <flo-retina> maybe
22:25:11 <Mic> That's the Fx shortcut at least.
22:25:15 <flo-retina> but escape is "get rid of the current tab"
22:26:26 <flo-retina> Mic: is there anything you would like to get fixed on the newtab patch before it lands?
22:26:59 <flo-retina> I mean anything you are already aware off (I know you haven't tested it in its latest iteration)
22:27:25 <Mic> I've looked at the interdiff of the latest patch and the tabtype one (that's the latest that I had a closer look at) already.
22:27:58 <flo-retina> hmm, do I need to go to bitbucket to see the interdiffs?
22:28:03 <Mic> I don't really like the click handler.
22:28:19 <Mic> Give me a moment, please.
22:29:04 <Mic> I'm using http://benjamin.smedbergs.us/interdiff/ and the urls of the patchs on BIO.
22:29:19 <flo-retina> oh ok
22:29:24 <flo-retina> I can do it locally then
22:29:58 <flo-retina> nhnt11-retina: here's a way to break your shiny new mouse behavior: mouse down somewhere on an item, move the mouse, mouse up somewhere else.
22:30:35 <flo-retina> That "selects" the item and then it doesn't get any highlight any more, but doesn't start a conversation (because if you move the mouse between mousedown and mouseup, there's no click event)
22:30:49 <flo-retina> nhnt11-retina: I think you would want to start the conversation on the mousedown event
22:30:56 <nhnt11-retina> flo-retina: I'll change click to mouseup?
22:31:03 <nhnt11-retina> flo-retina: I think mouseup is better
22:31:03 <flo-retina> mousedown!
22:31:07 <flo-retina> it's snappier
22:31:14 <flo-retina> and it's the behavior we have everywhere else
22:31:21 <flo-retina> (you can test on a tab)
22:31:37 <nhnt11-retina> Yeah, but mouseup => you can fix a mistaken click
22:31:40 <flo-retina> we switch the selected tab on mousedown
22:31:44 <nhnt11-retina> flo-retina: Not on closing a tab ;)
22:32:01 <flo-retina> "you can fix a mistaken click" uh? How so?
22:32:19 <nhnt11-retina> You mousedown, realize you got the wrong contact, move your mouse to the right one, mouseup again
22:32:37 <nhnt11-retina> Or mouseup outside of the listbox to cancel it completely
22:32:52 <Mic> "Mouseup" is the awesomebar behavior by the way.
22:33:34 <nhnt11-retina> Btw, I realize I need to check if the target exists, btw
22:33:35 <flo-retina> alright. Mouseup is fine, but then you need to keep the highlight while the mouse button is held pressed.
22:33:40 <nhnt11-retina> Pretend I said btw once
22:33:56 <flo-retina> the part that feels unsnappy is that the highlight disappears first, and then the conversation is started
22:33:59 <nhnt11-retina> flo-retina: Um I'm not sure what that means
22:34:10 <flo-retina> if you kept the highlight until you start the conv, it would feel much faster
22:34:16 <nhnt11-retina> I will
22:34:33 <nhnt11-retina> I'll change the hover selector to cover mousedown too
22:34:52 <nhnt11-retina> Basically, identical to how the awesomebar works for this
22:35:04 <flo-retina> nhnt11-retina: another way to break it: Start a conv. Put it on hold (escape key for example). Open the "new tab" again, and start a conv with the same contact. The "new tab" just disappears and nothing else happens. :(
22:35:15 <-- rosonline has quit (Client exited)
22:35:27 <flo-retina> nhnt11-retina: is this :active ?
22:35:31 <nhnt11-retina> flo-retina: Ahh. I guess this can't be a followup
22:35:51 <flo-retina> the conv on hold stuff? It could be a follow up
22:36:01 <flo-retina> but one you would handle asap ;)
22:36:13 <nhnt11-retina> Phew
22:36:14 <nhnt11-retina> :P
22:36:26 <nhnt11-retina> Um, I think so. (for :active)
22:36:42 <Mic> flo-retina: do you have an opinion on atuls stuff by the way?
22:37:11 <flo-retina> Mic: I haven't read the recent conversation you had with him
22:38:12 --> wnayes has joined #instantbird
22:38:38 <flo-retina> nhnt11-retina: the behavior when the window isn't focused is strange. There's no highlight, but a click starts the conversation. I would expect a click to just focus the window, and make the highlight appear
22:38:55 <nhnt11-retina> Okay. This is what I was asking about
22:39:24 <flo-retina> the alternative is to make the highlight work when the window isn't focused
22:39:27 <nhnt11-retina> I wanted to know whether to highlight when the window isnt focused, or not start a conversation like you said
22:39:29 <flo-retina> not sure how what would feel
22:40:23 --> clokep has joined #instantbird
22:40:24 * ChanServ sets mode +o clokep 
22:41:35 <Mic> flo-retina: Summary: I suggested putting incoming requests into a list and sending a notification with information about the offered file transfer. The callbacks of the buttons would notify the account which transfer was accepted or rejected.
22:41:44 <nhnt11-retina> Mic: Is there a way other than this to select items that are either hovered or active? .newtab-contact:hover, .newtab-active:active
22:42:03 <Mic> The account would then either drop the offer or accept the transfer.
22:42:32 <Mic> :-moz-any() afaik
22:42:46 <flo-retina> nhnt11-retina: there's :-moz-any() but I'm not sure it works for pseudo classes
22:43:05 <flo-retina> Mic: I'm not sure I understand this part "The callbacks of the buttons would notify the account which transfer was accepted or rejected"
22:43:10 <nhnt11-retina> Thanks, I'll try
22:44:10 <flo-retina> nhnt11-retina: well, you are creating a new patch, so you can likely just fix the conv-on-hold issue if I give you the line you need to change, right?
22:44:25 <nhnt11-retina> flo-retina: I know what I need to change
22:44:34 <flo-retina> you have target.contact.createConversation()
22:44:41 <flo-retina> you need a Conversations.focusConversation call
22:44:48 <flo-retina> like at http://lxr.instantbird.org/instantbird/source/instantbird/content/contact.xml#356
22:45:04 <nhnt11-retina> flo-retina: Er, what about middle clicking
22:45:16 <nhnt11-retina> I would have to refocus the newtab then
22:45:22 <nhnt11-retina> I guess that's fine though
22:45:31 <nhnt11-retina> Yeah I've seen that line
22:45:54 * clokep is stiill seeing the Google Hangouts bug. :(
22:46:26 <flo-retina> clokep: there was no windows nightly today
22:46:42 <Mic> flo-retina: "The callbacks of the buttons on the notification (in the notification bar) would notify the account if the transfer in question (the one that the notification in the conversation is shown for) was accepted or rejected." is that better?
22:46:56 <flo-retina> clokep: the nightly that was built was actually the one from yesterday, that failed and was automatically retriggered by buildbot before my commits.
22:47:01 <Mic> Or were you wondering about the "notify the account" part in particular?
22:47:27 <flo-retina> Mic: yes, that part.
22:47:42 <flo-retina> I was wondering if it's with an accept() or start() method of a interface like we described before
22:47:43 <clokep> flo-retina: Oh, OK. :(
22:47:54 <flo-retina> or with a method of the account with an id of the transfer
22:48:10 <atuljangra> back
22:48:11 <flo-retina> Mic: btw, we also need to take care of offers for convs on hold, etc...
22:48:13 <Mic> I haven't specified that because I don't know.
22:49:36 <nhnt11-retina> flo-retina: Okay, I have conversations on hold working.
22:49:47 <flo-retina> cool :)
22:51:06 <nhnt11-retina> flo-retina: For now, I'm going to keep the highlighting for inactive windows. It's the easier solution (we can have a followup if we don't like it?)
22:51:46 <flo-retina> ok, new patch coming that I can try with all these changes?
22:51:54 <flo-retina> (you have fixed the string, right?)
22:52:22 <nhnt11-retina> Yes
22:52:45 <atuljangra> flo-retina: So do I handle the offers for conv on hold? As in, in the next patch?
22:53:26 <flo-retina> atuljangra: do you know how to handle it?
22:53:53 <nhnt11-retina> :-moz-any doesn't seem to work :(
22:54:33 <flo-retina> I'm not surprised
22:54:46 <flo-retina> I didn't expect it to work for :hover and :active
22:54:49 <atuljangra> flo-retina: Currently no. But If it needs to be up in next patch, I can spend some time figuring out. OR if not, then I can update a new patch before sleeping today, containing the ui part and addressing clokep's comment.
22:55:09 <flo-retina> nhnt11-retina: is there any way we could avoid this line?      this.numberOfElementsToDisplay = (listbox.clientHeight / listbox.firstChild.clientHeight) + this.kNumElementsIncrement;
22:55:26 <clokep> atuljangra: What happened to all the interfaces and such in your last patch?
22:55:36 <nhnt11-retina> flo-retina: How else do we compute it?
22:55:44 * nhnt11-retina doesn't see a way.
22:55:57 <flo-retina> atuljangra: don't bother with convs on hold today
22:56:08 <atuljangra> clokep: You guys asked me to submit only xmpp stuff so I submitted that part only.
22:56:32 <atuljangra> clokep: http://log.bezut.info/instantbird/today#m262
22:56:36 <atuljangra> flo-retina: okay :)
22:57:05 <clokep> atuljangra: Yeah, but we wanted the other part somewhere else. :P
22:57:12 <flo-retina> nhnt11-retina: the problem is that it forces the rendering engine to computer the layout immediately and synchronously, which is slow, and causes us to end up displaying a frame with only one buddy icon border and nothing else in the list.
22:57:43 <flo-retina> nhnt11-retina: if we could execute it after displaying 8-10 elements, nobody would notice it.
22:57:57 <atuljangra> clokep: I'll put up a new bug today and put up the patch there. :) But I don't know what that bug should be called :s
22:57:59 <nhnt11-retina> flo-retina: Er, followup? :)
22:58:03 <flo-retina> nhnt11-retina: sure
22:58:09 <clokep> atuljangra: Just call it "File transfer backend" or something.
22:58:12 <flo-retina> nhnt11-retina: I'm just sharing my thoughts
22:58:17 <nhnt11-retina> :)
22:58:21 <clokep> Don't worry too much about bug titles. :)
22:58:27 <atuljangra> clokep: okay. :)
23:00:01 <flo-retina> atuljangra: also, it sucks that on that frame we don't have a scrollbar yet, as that makes the scrollbar flash
23:00:18 <atuljangra> flo-retina: :-o
23:00:18 <flo-retina> oops, that was for nhnt11-retina
23:00:23 <atuljangra> hehe :P
23:02:08 <flo-retina> nhnt11-retina: we should also animate the opening of the new tab. That animation buys us time to populate the list in the background
23:02:24 <nhnt11-retina> cool
23:02:41 <flo-retina> perceived performance is all about tiny details ;)
23:03:15 <flo-retina> is the new patch coming?
23:03:18 <nhnt11-retina> flo-retina: So the inactive window thing, convs on hold, and the placeholder
23:03:22 <nhnt11-retina> Is there something I missed?
23:03:28 <nhnt11-retina> If not, patch coming
23:03:42 <flo-retina> "the placeholder"?
23:03:48 <nhnt11-retina> Search to fiter
23:03:50 <nhnt11-retina> filter*
23:03:51 <nhnt11-retina> Start typing*
23:03:52 <flo-retina> is that the highlight when the mosue is down?
23:04:07 <nhnt11-retina> No, the default string in the search bar
23:04:23 <flo-retina> so, have you fixed that? (I assume yes as you were tinkering with :active)
23:04:28 <nhnt11-retina> Yes
23:05:13 <flo-retina> have you also identified while have canceling a click I couldn't highlight the row any more (likely because it was selected)?
23:05:58 <nhnt11-retina> Just saw that
23:06:03 <nhnt11-retina> Argh
23:06:27 <Mic> Good night!
23:07:06 <atuljangra> Mic: Good Night! :-)
23:07:38 <clokep> Goodnight Mic!
23:07:52 <nhnt11-retina> Good night Mic
23:08:40 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:09:06 --> FireFly_TB has joined #instantbird
23:10:47 <nhnt11-retina> flo-retina: Done!
23:10:47 <-- FireFly_TB has quit (Ping timeout)
23:10:52 <nhnt11-retina> I think everything is working
23:12:34 <nhnt11-retina> flo-retina: Do I need to add a comment for unselecting items immediately
23:12:35 <nhnt11-retina> ?
23:12:39 <nhnt11-retina> er, deselecting*
23:13:01 <nhnt11-retina> This is what I'm doing: "<handler event="mousedown">this.listbox.selectedIndex = -1;</handler>"
23:13:35 <flo-retina> if it's confusing, a comment will be welcome I guess
23:15:38 <nhnt11-retina> flo-retina: // Prevent elements from getting selected. This is to ensure clicked elements won't stay highlighted.
23:15:39 <nhnt11-retina> Is that fine?
23:16:02 <flo-retina> nhnt11-retina: I wonder if you just wanted event.preventDefault()
23:16:04 <atuljangra> flo-retina: When an account disconnect, I should be clearing up the fileOffers right? Do we want something carrying forward? :s
23:16:07 <instantbot> clokep@gmail.com requested review from benediktp@ymail.com  for attachment 2575 on bug 1981.
23:16:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
23:16:17 <nhnt11-retina> flo-retina: That didn't work last time. I'll give it a try
23:16:38 <flo-retina> atuljangra: when an account is disconnected you should get rid of the notification bars, yes
23:16:39 <nhnt11-retina> flo-retina: Btw, I need to reset the selection in the mouseup handler too
23:16:44 <nhnt11-retina> (Didn't work without that)
23:17:01 <atuljangra> flo-retina: Cool :)
23:18:05 <nhnt11-retina> flo-retina: preventDefault() not working. Sorry for pinging you repeatedly 
23:18:22 <nhnt11-retina> Patch coming
23:18:47 <atuljangra> flo-retina clokep Sorry for being so nosy, but what name would you like for the list _pendingFileTransfers or _pendingFileOffers
23:19:40 <instantbot> nhnt11@gmail.com cancelled review?(aleth@instantbird.o rg) for attachment 2574 on bug 2015.
23:19:41 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2576 on bug 2015.
23:19:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
23:19:43 <nhnt11-retina> Oh no. I forgot to add the committer and stuff
23:19:54 <clokep> nhnt11-retina: Don't worry about it, flo can do that.
23:20:07 <flo-retina> nhnt11-retina: I don't think you actually expect reviews from Mic/aleth at this point ;)
23:20:17 <nhnt11-retina> flo-retina: I'm being courteous? I dunno.
23:20:35 <flo-retina> nhnt11-retina: aleth already r+'ed a previous iteration
23:21:05 <nhnt11-retina> Okay but considering all the changes... whatever. I won't for any future patches on this bug then. All yours ;)
23:21:49 <nhnt11-retina> I really need to go now
23:21:59 <nhnt11-retina> Good night. I'll be back tomorrow evening.
23:22:15 <clokep> Bye!
23:25:28 <atuljangra> Okay. Using _pendingFileTransfers for now :)
23:25:47 <clokep> Seems fine to me.
23:25:59 <atuljangra> :)
23:28:06 <-- mpmc has quit (Connection reset by peer)
23:30:18 <atuljangra> flo-retina: Is the cancelled function here http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIRequest.idl#19 used as "cancel" instead of "cancelled" and is automatically called when I cancel a notification? It seems so to me
23:30:30 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:30:39 --> nhnt11 has joined #instantbird
23:30:44 <-- nhnt11 has left #instantbird ()
23:31:25 <flo-retina> atuljangra: it's called at http://lxr.instantbird.org/instantbird/source/chat/content/browserRequest.js#121
23:31:43 --> nhnt11-xps has joined #instantbird
23:31:59 <-- nhnt11-xps has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:32:56 <atuljangra> Okay. So do I specify what to call when the notification is cancelled. I mean should I include any such function which listens to cancel event?
23:33:07 <atuljangra> oh sorry.
23:33:27 <-- nhnt11-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:33:50 <atuljangra> flo-retina: It is automatically called, so I need to make a "cancelled" function in my aSubject? 
23:33:57 --> nhnt11 has joined #instantbird
23:34:02 * flo-retina has found another bug in nhnt11's patch :-/
23:34:07 <nhnt11> flo-retina: What?
23:34:11 <flo-retina> nhnt11: uh, I thought you were asleep
23:34:22 <clokep> Hahaha.
23:34:26 <nhnt11> I was waiting for an update that was nearly done
23:34:41 <flo-retina> nhnt11: highlight one element by mousing over, and then play with the up/down arrow
23:34:48 <flo-retina> nhnt11: you end up with 2 highlighted items.
23:35:07 <nhnt11> flo-retina: Ah. I think it's a simple fix
23:35:58 <flo-retina> nhnt11: with this new version of the patch, the selected item has a gray background when the window is inactive
23:36:00 <clokep> Do we have any screenshots of nhnt's stuff around?
23:36:38 <flo-retina> which looks strange, given that I can now highlight a row even while the window is inactive.
23:36:46 <flo-retina> clokep: you can't wait for the next nightly? :-P
23:37:31 <nhnt11> flo-retina: Okay never mind, probably not a simple fix. Can't do it now.
23:37:35 <flo-retina> clokep: http://i2.minus.com/iyNQoqjqFjZvq.png
23:37:46 <flo-retina> nhnt11: follow up?
23:38:13 <clokep> So many pixels! :)
23:38:15 <nhnt11> flo-retina: That works! Thanks for being lenient :P
23:38:17 <flo-retina> nhnt11: tomorrow your first task will be to file all the follow ups we have discussed ;)
23:38:26 <flo-retina> and mark them blocking the current bug
23:38:27 <nhnt11> Yes :)
23:38:44 <nhnt11> clokep: That screenshot actualy takes up nearly my whole screen too :-/
23:38:56 <nhnt11> Probably because I'm back to "best for retina display"
23:39:20 <flo-retina> nhnt11: it does for me too
23:39:20 <clokep> nhnt11: Also to file all the bugs we find tomorrow. :p
23:39:29 <flo-retina> nhnt11: it's just that something sucks with screenshots and the dpi setting
23:39:36 <nhnt11> Hmm nope. It's still huge. Probably because firefox is scaling it 2x..
23:39:38 <nhnt11> Yeah
23:39:46 <flo-retina> or maybe it's just Firefox that doesn't handles that setting correctly
23:39:49 * nhnt11 feels pressured :P
23:40:06 <flo-retina> it's buildbot that will feel pressured
23:40:15 <flo-retina> if it fails stupidly tomorrow, we will all be upset at it :-D
23:40:16 <nhnt11> :D
23:40:35 <nhnt11> flo-retina: My update is done. Did you find anything needed to be done now and not a followup?
23:41:17 <flo-retina> nhnt11: go to bed. It's too late to tinker more with code; even for me ;).
23:41:34 <nhnt11> Okay!
23:41:48 <flo-retina> it can't be perfect the first time anyway :)
23:41:54 * nhnt11 may end up not sleeping at all... no way he can wake up for his appointment otherwise :(
23:42:18 <nhnt11> Anyway... good night.
23:42:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:42:28 <flo-retina> uh, sorry :-/
23:48:49 <instantbot> florian@instantbird.org granted review for attachment 2576 on bug 2015.
23:48:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
23:48:56 <clokep> :)
23:52:42 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/e0a2d039654e - Nihanth Subramanya - Bug 2015 - Display buddy list in a tab, r=Mic,aleth,fqueze.
23:53:24 * clokep thinks there's a bug in the check-in queue btw.
23:54:02 <instantbot> clokep@gmail.com set the Resolution field on bug 2015 to FIXED.
23:54:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, 1.5, nhnt11, RESO FIXED, Display buddy list in a tab.
23:55:05 <flo-retina> clokep: it was checked in yesterday: http://hg.instantbird.org/instantbird/rev/3aae8b5d40c9
23:55:41 <clokep> Oh, must hav emissed it...hmm...
23:55:53 * clokep has one job and messed it up. :(
23:56:15 <instantbot> clokep@gmail.com set the Resolution field on bug 2035 to FIXED.
23:56:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2035 enh, --, 1.5, nhnt11, RESO FIXED, Tabbrowser tab needs an attribute that tells CSS what kind of tab it is.
23:56:31 <flo-retina> clokep: we should teach our students to resolve their own bugs when they are checked in ;)