All times are UTC.
00:22:04 --> mconley has joined #instantbird 00:24:34 <-- mconley has quit (Input/output error) 00:29:04 <-- flo-retina has quit (Ping timeout) 00:29:19 <-- flo2 has quit (Ping timeout) 00:30:04 --> flo2 has joined #instantbird 00:31:45 --> flo-retina has joined #instantbird 00:31:45 * ChanServ sets mode +qo flo-retina flo-retina 00:34:40 <-- qlum has quit (Connection reset by peer) 00:38:35 <-- wnayes has quit (Ping timeout) 00:39:55 <-- unghost has quit (Ping timeout) 00:42:03 --> wnayes has joined #instantbird 00:57:22 <instant-buildbot> build #416 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/416 01:04:19 <-- flo2 has quit (Ping timeout) 01:04:21 --> flo2 has joined #instantbird 01:04:22 <-- nhnt11 has left #instantbird () 01:04:32 --> nhnt11 has joined #instantbird 01:05:30 <-- nhnt11 has left #instantbird () 01:05:35 --> nhnt11 has joined #instantbird 01:06:13 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:06:34 --> nhnt11 has joined #instantbird 01:10:07 <-- Mook_as has quit (Quit: Mook_as) 01:10:08 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:10:48 --> nhnt11 has joined #instantbird 01:12:04 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:12:36 --> mconley has joined #instantbird 01:12:55 --> nhnt11 has joined #instantbird 01:13:36 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:13:52 <-- mconley has quit (Input/output error) 01:14:00 --> mconley has joined #instantbird 01:14:07 --> nhnt11 has joined #instantbird 01:15:47 <-- nhnt11 has quit (Input/output error) 01:16:33 --> nhnt11 has joined #instantbird 01:17:37 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:25:35 --> nhnt11 has joined #instantbird 01:27:37 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:27:58 --> nhnt11 has joined #instantbird 01:28:42 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:30:27 --> nhnt11 has joined #instantbird 01:31:55 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:36:23 --> nhnt11 has joined #instantbird 01:37:21 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:38:21 --> nhnt11 has joined #instantbird 01:39:29 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:57:35 <-- mconley has quit (Input/output error) 02:07:36 <-- Nirgali has quit (Ping timeout) 02:23:44 --> FireFly_TB has joined #instantbird 02:27:32 <-- FireFly_TB has quit (Ping timeout) 02:36:35 --> atuljangra has joined #instantbird 02:36:47 <atuljangra> Good Morning :-) 02:37:25 <atuljangra> clokep: I thought that having all the logs at one place would be a nice idea, thus pointed to a new one. Hope that's fine :-) 02:37:42 <atuljangra> nhnt11 Thanks for saving me ;) 02:38:12 <-- wnayes has quit (Ping timeout) 02:41:56 --> wnayes has joined #instantbird 02:51:19 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 02:59:09 --> Mook has joined #instantbird 02:59:16 --> atuljangra has joined #instantbird 03:02:27 <instant-buildbot> build #894 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/894 03:02:27 <atuljangra> wnayes: Hey I heard you are doing intern at Epic Systems! Congrats :) 03:21:09 <-- mpmc has quit (Connection reset by peer) 03:35:08 <instant-buildbot> build #886 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/886 04:12:33 --> mconley has joined #instantbird 04:34:49 <-- mconley has quit (Ping timeout) 04:39:18 <wnayes> atuljangra: Thanks :) Exactly halfway through as of today. 04:40:50 --> mconley has joined #instantbird 04:41:34 <-- mconley has quit (Input/output error) 04:49:19 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 04:52:09 --> atuljangra has joined #instantbird 04:52:21 <atuljangra> wnayes: Awesome :-) 05:16:04 <-- wnayes has quit (Quit: wnayes) 05:21:26 --> mpmc has joined #instantbird 05:40:47 --> eson57 has joined #instantbird 05:42:23 <-- flo-retina has quit (Ping timeout) 05:42:23 <-- flo2 has quit (Ping timeout) 05:42:38 --> flo2 has joined #instantbird 05:44:16 --> flo-retina has joined #instantbird 05:44:16 * ChanServ sets mode +qo flo-retina flo-retina 05:49:18 <-- eson57 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:52:09 <instant-buildbot> build #989 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/989 06:02:57 <instantbot> mook.moz+bugs.instantbird@gmail.com set the Resolution field on bug 2022 to FIXED. 06:03:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2022 tri, --, ---, mook.moz+bugs.instantbird, RESO FIXED, Support mIRC-style italics formatting 07:01:08 <-- Mook has quit (Ping timeout) 07:05:08 --> Mook has joined #instantbird 07:22:09 --> aleth has joined #instantbird 07:22:09 * ChanServ sets mode +h aleth 07:32:39 <-- Mook has quit (Quit: Mook) 07:36:01 <-- aleth has quit (Quit: Ciao) 07:36:06 --> aleth has joined #instantbird 07:36:06 * ChanServ sets mode +h aleth 07:36:17 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 07:36:26 --> mpmc has joined #instantbird 07:41:16 <aleth> atuljangra: What's the link to your current blog? 07:42:03 <aleth> Oh, ignore that, I found it. 07:51:45 --> EionRobb has joined #instantbird 07:58:31 --> nhnt11 has joined #instantbird 08:09:51 <atuljangra> aleth: :) 08:18:07 * nhnt11 yawns 08:18:24 <nhnt11> I have guests, I'll probably be back in the evening. 08:18:33 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:28:13 <instantbot> aleth@instantbird.org denied review for attachment 2528 on bug 2006. 08:28:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2006 enh, --, ---, clokep, ASSI, The /invite command should support taking more than one nick as parameter 08:37:06 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 09:46:31 --> qlum has joined #instantbird 09:50:16 --> atuljangra has joined #instantbird 10:18:02 * atuljangra thinks he should shift to Komodo instead of vim. 10:18:21 * atuljangra is feelin lazy to customize his vimrc for js :s 10:29:09 * atuljangra installed Komodo as Mic suggested :D 10:33:44 <aleth> clokep has some useful macros for it you might like afaik. 10:34:09 <atuljangra> sure :D 10:40:21 --> FireFly_TB has joined #instantbird 11:15:22 --> nhnt11 has joined #instantbird 11:16:55 <nhnt11> Interesting 11:17:02 <nhnt11> Apparently one of my contacts has no preferredBuddy 11:17:15 <nhnt11> Awesometab doesn't like that 11:17:25 <nhnt11> "TypeError: this.preferredBuddy is null" 11:17:34 <nhnt11> And nothing loads and everything gets messed up 11:17:59 <nhnt11> Skipping contacts with no preferredBuddy fixes this, but I'm not sure that such contacts should exist in the first place 11:27:24 <-- EionRobb has quit (Quit: Leaving.) 11:27:31 <aleth> What's the status of that contact? 11:29:43 <nhnt11> aleth: No status, because there's no preferred buddy :S 11:29:50 <nhnt11> I don't even know who it refers to 11:29:51 <nhnt11> It only has an id. 11:29:55 <aleth> You probably want to dig into what is going on there to avoid unwarranted assumptions. If it turns out it can be null, we should add an explanatory comment to http://lxr.instantbird.org/instantbird/source/chat/components/public/imIContactsService.idl#71 11:30:03 <nhnt11> Appears to be a total dummy, but I'm not sure. 11:30:33 <aleth> Dump that contact and find out what it contains ;) 11:30:40 <nhnt11> aleth: I don't think such a contact is supposed to exist. I'll do some investigating later, but I think there's something wrong with my profile. 11:30:43 <nhnt11> Alrighty. 11:30:48 <aleth> If there's a bug there, we'll want to fix it 11:31:27 <nhnt11> Of course. 11:32:04 <aleth> Sorry I don't know either offhand whether null is possible there (if e.g. all the accountbuddies have status UNKNOWN or something) 11:44:44 <nhnt11> aleth: No, even if they have status unknown, they shouldn't be null... 11:45:00 <nhnt11> And it appears there's only one such contact 11:45:06 <nhnt11> I mean in my case. 11:45:21 <nhnt11> Let me quickly check though. 11:45:29 <aleth> Can you find out its name etc? To figure out where it came from 11:45:44 <nhnt11> That's the problem 11:45:52 <nhnt11> It only has an ID. 11:46:02 <nhnt11> I'll print its properties 11:46:14 <nhnt11> brb. 11:46:16 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:46:36 --> rosonline has joined #instantbird 11:47:13 --> nhnt12 has joined #instantbird 11:47:30 <nhnt12> I need to test this on my main profile, so here I am from my testing one. 11:48:42 --> nhnt11 has joined #instantbird 11:50:18 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:50:42 --> nhnt11 has joined #instantbird 11:51:35 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:51:52 --> nhnt11 has joined #instantbird 11:53:35 <nhnt12> Okay, I printed it once and the id was 17, and preferredBuddy was null. There were no other properties from which I could identify it. 11:54:30 <nhnt12> I modified it to print all contacts instead of just the preferredBuddy-is-null one. Now, the very first contact it encounters has id 3, and no preferredBuddy at all. 11:54:47 <nhnt12> (i.e. the key doesn't exist, let alone the value being null) 11:55:04 <aleth> Probably the property hasn't been accessed yet. It's set by a getter 11:55:23 <nhnt12> Oh, I see. 11:55:32 <aleth> Just to check, if you create a fresh profile, there is no such empty contact? 11:55:48 <nhnt12> Nope 11:55:55 <nhnt12> In my testing profile there's no such contact. 11:56:07 <nhnt12> If you'd like, I'll create a new one and check. 11:56:21 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:56:32 <aleth> If you remove a buddy, you don't generate such a contact? (that would be a bug of course) 11:56:47 <aleth> Just trying to figure out how you ended up with a strange contact like that... 11:57:13 --> nhnt11 has joined #instantbird 11:57:21 <nhnt12> Hmm. I'll try some things. 11:57:33 <nhnt12> Also interesting is that it has a positive id - implying it has more than one buddy attached. 11:57:49 <aleth> Has or had? 11:57:52 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:58:20 <nhnt12> I'm not sure what that means. It's still there, so I'm going with "has". 11:58:42 --> nhnt11 has joined #instantbird 11:58:50 <aleth> If it does, then you should be able to identify where the contact came from by the buddy properties? 11:59:01 <nhnt12> Ah 11:59:06 <nhnt12> Right, I should be able to getBuddies 11:59:50 --> clokep has joined #instantbird 11:59:51 * ChanServ sets mode +o clokep 11:59:56 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:00:11 <aleth> The question is if this is a legitimate contact and preferredBuddy has some sort of bug or if it's not (in which case the question is where it came from) 12:00:20 <atuljangra> Good Morning clokep :) 12:00:29 <clokep> Hello atuljangra. 12:00:35 <nhnt12> Right. 12:01:07 <nhnt12> Also, the buddy list doesn't seem to have any problems, so I'm starting to suspect that ContactsById in the contacts service isn't what I expect it to be. 12:01:13 --> nhnt11 has joined #instantbird 12:01:30 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:01:49 <aleth> You don't know that the buddy list doesn't have a problem until you figure out if that contact is actually displayed there in some form (or not) 12:02:09 <nhnt12> aleth: It doesn't throw any errors, though. And I don't see any checks in the code there. 12:02:18 --> nhnt11 has joined #instantbird 12:03:13 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:03:38 --> nhnt11 has joined #instantbird 12:03:58 <nhnt12> Weird 12:04:03 <-- clokep has quit (Ping timeout) 12:04:16 <nhnt12> getBuddies() seems to return an empty array 12:04:51 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:04:53 <nhnt12> brb 12:06:00 --> gerard-majax_ has joined #instantbird 12:12:02 <-- mpmc has quit (Connection reset by peer) 12:13:17 --> nhnt11 has joined #instantbird 12:14:13 --> mpmc has joined #instantbird 12:14:19 <-- nhnt11 has quit (Input/output error) 12:14:39 --> nhnt11 has joined #instantbird 12:14:43 <nhnt12> Okay, I really can't seem to find any way to identify this contact other than the Id. 12:16:06 <aleth> Can you figure out why the blist has no problems with it? 12:16:11 <nhnt12> Trying. 12:17:25 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:17:42 <nhnt12> I should disable auto-join in my main profile while I test this. 12:17:48 --> nhnt11 has joined #instantbird 12:17:56 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:19:11 --> clokep has joined #instantbird 12:19:12 * ChanServ sets mode +o clokep 12:19:40 <nhnt12> aleth: The problem doesn't happen if I iterate through Services.tags.getTags() and so on. 12:19:52 <aleth> Sure, because you never find that contact. 12:20:11 <nhnt12> Ah right. because it doesn't have any tags.. 12:20:14 <nhnt12> Ugh. 12:20:21 <nhnt12> This is why the buddy list has no problems. 12:20:30 <nhnt12> Kinda obvious now.. 12:20:42 <aleth> Ah. So you have found a hidden bug, congrats :D 12:21:02 <nhnt12> Anyway, I think I've made some wrong assumptions about ContactsById in the contacts service. 12:21:04 <nhnt12> Heh :P 12:21:24 <nhnt12> I'm going to look at the ways ContactsById is modified in imContacts 12:21:25 <instantbot> clokep@gmail.com granted review for attachment 2536 on bug 2025. 12:21:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2025 nor, --, ---, nobody, NEW, Add Retina Display support to Instantbird 12:21:56 <instantbot> clokep@gmail.com set the Resolution field on bug 2025 to FIXED. 12:22:26 <instantbot> clokep@gmail.com set the Resolution field on bug 2023 to FIXED. 12:22:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2023 nor, --, 1.5, aleth, RESO FIXED, Services.cmd.unregisterCommand is broken 12:23:28 <instantbot> clokep@gmail.com set the Resolution field on bug 1940 to FIXED. 12:23:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1940 nor, --, ---, aleth, RESO FIXED, Fix errors/warnings on detaching/reattaching conversations 12:24:28 <aleth> clokep: Do you think a 'private' in "Start private conversation with %S" for participants in MUCs is required or could be left out? 12:26:06 <nhnt12> aleth: imIContact has a _empty() method, which returns true if there are no buddies attached to it. 12:26:09 <clokep> aleth: No. 12:26:30 <nhnt12> This means that it is possible for a contact to have no buddies attached. 12:26:33 <clokep> atuljangra: That's fine, I just missed it. :) 12:27:13 <clokep> Doh, Mook had already closed a bug for me. :( 12:27:14 <aleth> nhnt12: Interesting. Is that how it's used? Don't we remove empty contacts? 12:27:34 <nhnt12> I'm not sure. Still investigating. 12:27:39 <aleth> clokep: No it is required or no it is overkill? ;) 12:29:30 <clokep> aleth: No, it is not required. 12:29:35 <aleth> nhnt12: We should probably ask flo why they are not removed, but http://lxr.instantbird.org/instantbird/source/chat/components/src/imContacts.js#183 suggests filtering them out is the correct thing to do 12:29:59 <nhnt12> Ah! Thanks! I missed that. 12:30:03 <aleth> clokep: I agree. 12:30:15 <nhnt12> Cool. If that's what tags do, that's what I'm going to do as well :) 12:30:39 <nhnt12> aleth: I think it makes sense to do the filtering in ContactsService.getContacts. 12:30:53 <aleth> nhnt12: Definitely! 12:32:31 <clokep> nhnt12: Can you use better commit messages than "stuff" :P 12:32:40 <nhnt12> clokep: Haha. 12:32:49 <nhnt12> I only do that in my addons repo 12:33:00 <nhnt12> Because I can't remember what my last changes were (I don't commit often) 12:33:04 <aleth> Your future self hates you. 12:33:25 <nhnt12> Right, I'll make sure I commit as soon as I finish something from now on 12:33:28 <nhnt12> Sorry :P 12:33:57 <aleth> No need to apologize to us for your addons repo :D 12:34:02 <nhnt12> :P 12:35:50 <atuljangra> clokep: while creating a stanza how do I create <open/> element qualified by the 'http://jabber.org/protocol/ibb' namespace. I mean, I need something like Stanza.NS.IBB, where do I define that. 12:36:23 <clokep> atuljangra: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp-xml.jsm#9 12:36:40 <atuljangra> Nice Thanks :-) 12:37:35 <nhnt12> aleth, clokep: Can I upload a new patch on bug 2021, or file a new bug? 12:37:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2021 min, --, 1.5, nhnt11, RESO FIXED, Add method to get all contacts from ContactsService 12:38:02 <aleth> nhnt12: New bug. It's a bug in a landed patch. 12:38:14 <nhnt12> Alright. 12:39:56 <instantbot> New Core - General bug 2026 filed by nhnt11@gmail.com. 12:39:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2026 nor, --, ---, nobody, NEW, Filter out empty contacts in Services.contacts.getContacts() 12:40:41 <aleth> nhnt12: We generally add followups to the same bug if the patch broke nightlies on landing. 12:41:12 <nhnt12> Cool, good to know. 12:41:26 * nhnt12 quickly tests his patch before uploading... though it should be fine. 12:43:20 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2538 on bug 2026. 12:43:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2026 nor, --, ---, nhnt11, ASSI, Filter out empty contacts in Services.contacts.getContacts() 12:46:43 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2538 on bug 2026. 12:46:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2026 nor, --, ---, nhnt11, ASSI, Filter out empty contacts in Services.contacts.getContacts() 12:47:41 <atuljangra> Will be back in an hour. Got some weird work to do. ( which I absolutely hate to do >.<) 12:48:18 <-- atuljangra has quit (Quit: I hate laundry :() 12:48:50 <nhnt12> Hahahaha laundry is a chore. 12:50:46 <-- FireFly_TB has quit (Ping timeout) 12:57:45 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:03:46 <-- nhnt12 has quit (Ping timeout) 13:05:52 --> dionisos has joined #instantbird 13:10:53 --> Mic has joined #instantbird 13:10:53 * ChanServ sets mode +h Mic 13:20:02 <-- dionisos has quit (Ping timeout) 13:22:20 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:22:48 --> clokep has joined #instantbird 13:22:48 * ChanServ sets mode +o clokep 14:01:58 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 14:02:20 * flo-retina wonders how we get empty contacts :-S 14:03:02 <flo-retina> I really don't remember writing that _empty thing in that code :-S 14:03:20 --> clokep has joined #instantbird 14:03:21 * ChanServ sets mode +o clokep 14:10:14 <aleth> flo-retina: It's very strange especially considering http://lxr.instantbird.org/instantbird/source/chat/components/public/imIContactsService.idl#160 14:13:29 <flo-retina> aleth: My guess is that we don't remove contacts that have buddies on the Unknown protocol plugin 14:13:42 <flo-retina> and the Unknown protocol plugin's current implementation doesn't support buddies 14:13:51 <flo-retina> (would be easier to fix now that we have jsProtoHelper btw) 14:15:04 <aleth> nhnt11 stumbled over this because he had a contact with no buddies attached in his profile. 14:15:22 <flo-retina> yeah, I've now finished reading the scrollback 15:10:11 --> Tonnes has joined #instantbird 15:12:59 <-- rosonline has quit (Ping timeout) 15:13:51 --> wnayes has joined #instantbird 15:15:07 --> rosonline has joined #instantbird 15:16:50 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 15:16:58 --> rosonline has joined #instantbird 15:26:59 --> nhnt12 has joined #instantbird 15:32:19 <instantbot> benediktp@ymail.com granted feedback for attachment 2527 on bug 1981. 15:32:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly 15:33:50 <-- rosonline has quit (Ping timeout) 15:37:22 <flo-retina> Mic: the f? was that I wasn't convinced at a first glance that your comment had been fully addressed ;) 15:37:58 <Mic> Well, it seems that it worked ;) 15:38:26 <clokep> Thanks Mic. 15:39:00 <clokep> Although you're making more work for me. ;) 15:39:03 --> rosonline has joined #instantbird 15:41:01 <Mic> Looking at nhnt\d{2}'s patch now :) 15:41:15 * clokep wonders how badly he should add tests to ArrayBufferUtils... 15:45:02 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2539 on bug 2006. 15:45:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2006 enh, --, ---, clokep, ASSI, The /invite command should support taking more than one nick as parameter 15:48:04 <instantbot> aleth@instantbird.org granted review for attachment 2539 on bug 2006. 15:48:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2006 enh, --, ---, clokep, ASSI, The /invite command should support taking more than one nick as parameter 15:51:30 <clokep> Mic: Would I get an f+ for something like: return "0x" + [("0" + b.toString(16)).slice(-2) for (b of uint8)].join(" "); 15:51:40 <clokep> Thank you aleth. 15:52:35 <nhnt12> Hello 15:52:37 <Mic> Yes, I guess you're asking because of naming the variable just "b"? 15:52:37 * nhnt12 is back 15:52:47 <clokep> Mic: Yes. :) 15:52:51 <clokep> b is short for byte. 15:52:55 <clokep> And that fits in 80 chars. ;) 15:53:36 <Mic> Yes, that's fine with me. I don't think it hurts readability as it's really just used locally here. 15:55:45 <clokep> Thanks. :) 15:55:57 <clokep> How badly would anyone want tests for these functions? 15:56:00 * clokep thinks they should have them. 15:58:49 <nhnt12> Mic: | let contacts = [ContactsById[id] for (id in ContactsById) if 15:58:51 <nhnt12> (!ContactsById[id]._empty)]; | - What is the syntax used to build the array here called? 15:59:26 <nhnt12> I've only used that syntax in Python (didn't know JavaScript had it till a couple days ago) and never learned what it's called... 15:59:51 <Mic> Array comprehension. 16:00:00 <Mic> https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/1.7#Array_comprehensions_%28Merge_into_Array_comprehensions%29 16:00:05 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 16:00:30 <nhnt12> Ah thanks. 16:00:39 --> Mic has joined #instantbird 16:00:39 * ChanServ sets mode +h Mic 16:03:51 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2538 on bug 2026. 16:03:52 <instantbot> nhnt11@gmail.com requested review from florian@instantbird .org for attachment 2540 on bug 2026. 16:03:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2026 nor, --, ---, nhnt11, ASSI, Filter out empty contacts in Services.contacts.getContacts() 16:06:18 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:08:03 --> nhnt11 has joined #instantbird 16:11:29 <aleth> How does one get decent error reporting from within modules? 16:11:58 --> Kaishi has joined #instantbird 16:26:40 <-- chrisccoulson has quit (Ping timeout) 16:50:47 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 16:52:28 <-- aleth has quit (Quit: Ciao) 16:55:55 <clokep> aleth: I think you have to sacrifice a goat. 17:06:20 <nhnt11> clokep: :P 17:09:39 <-- wnayes has quit (Ping timeout) 17:10:52 --> aleth has joined #instantbird 17:10:52 * ChanServ sets mode +h aleth 17:11:05 <-- flo2 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:11:05 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:11:59 <aleth> |delete this.goat;| 17:13:02 --> wnayes has joined #instantbird 17:13:32 <-- clokep has quit (Ping timeout) 17:16:38 --> chrisccoulson has joined #instantbird 17:17:01 <-- chrisccoulson has quit (Client exited) 17:18:38 <-- Suiseiseki has quit (Quit: Leaving) 17:21:36 --> wnayes1 has joined #instantbird 17:23:03 <-- wnayes has quit (Ping timeout) 17:23:20 <-- wnayes1 has quit (Ping timeout) 17:42:58 <instantbot> New Core - General bug 2027 filed by aleth@instantbird.org. 17:43:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2027 nor, --, ---, nobody, NEW, Delete a tag when it has no contacts associated with it 17:50:39 * nhnt11 didn't realize there's no way to remove a tag 17:53:17 <aleth> bug 1072 17:53:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1072 enh, --, ---, nobody, NEW, Tags should be editable and/or removable 17:55:59 --> Suiseiseki has joined #instantbird 18:29:55 <-- aleth has quit (Quit: Ciao) 18:36:19 <-- rosonline has quit (Client exited) 18:44:17 <-- gerard-majax_ has quit (Ping timeout) 19:03:33 --> gerard-majax_ has joined #instantbird 19:42:55 --> mpmc has joined #instantbird 19:51:28 --> chrisccoulson has joined #instantbird 20:00:30 <-- qlum has quit (Ping timeout) 20:00:47 --> qlum has joined #instantbird 20:12:25 --> clokep has joined #instantbird 20:12:25 * ChanServ sets mode +o clokep 20:15:05 <-- clokep has quit (Ping timeout) 20:48:53 --> Mook has joined #instantbird 20:50:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:51:00 --> flo2 has joined #instantbird 20:52:40 --> flo-retina has joined #instantbird 20:52:40 * ChanServ sets mode +qo flo-retina flo-retina 20:54:20 <flo-retina> aleth: I don't think making tags just vanish is a fantastic idea. 20:54:55 <flo-retina> imagine I'm reordering my contacts, I move all my "friends" to "old friends", and then I want to move a new friend to "friends". Oh surprise, "friends" doesn't exist any more. 20:55:12 <flo-retina> so maybe we should clean up after some time, or maybe after a restart :-S. 21:42:58 --> Mic has joined #instantbird 21:42:58 * ChanServ sets mode +h Mic 21:49:54 <-- flo2 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:49:55 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:53:47 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/cd5947be952a - Patrick Cloke - Bug 2006 - The /invite command should support taking more than one nick as parameter, r=aleth. 22:07:49 <instant-buildbot> build #411 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/411 22:13:51 <-- mpmc has quit (Connection reset by peer) 22:17:33 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:31:09 <-- gerard-majax_ has quit (Ping timeout) 22:56:58 --> wnayes has joined #instantbird 23:09:29 <-- wnayes has quit (Ping timeout) 23:12:41 --> wnayes has joined #instantbird 23:24:06 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 2541 on bug 1221. 23:24:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, wnayes, ASSI, Redesign buddy tooltips 23:31:19 --> Nirgali has joined #instantbird 23:59:03 <instant-buildbot> build #430 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/430