#instantbird log on 06 28 2013

All times are UTC.

00:07:02 <clokep> Bleh i have conflicts. :(
00:12:28 <-- jb has quit (Ping timeout)
00:13:22 <nhnt11> Ugh, Fx can't find the server at google.com -_-
00:14:41 <clokep> DNS issues?
00:14:54 <nhnt11> No, I can't connect to anything
00:15:07 <nhnt11> Apparently Ib is still connected because the socket is still open...
00:15:10 <nhnt11> sigh
00:15:36 <nhnt11> Actually DNS issues would make sense, what am I saying.
00:16:16 <nhnt11> Ah yay
00:16:25 <nhnt11> Switching to google dns fixed it :)
00:16:32 <clokep> Gross.
00:17:01 <nhnt11> Yeah but at least I have internet
00:17:52 * clokep does'nt know what happened to this code in instantbird.js. :(
00:23:02 * clokep wonders if Mook_as knows the answer to https://bugzilla.instantbird.org/show_bug.cgi?id=1981#c4
00:23:09 <instantbot> Bug 1981 nor, --, ---, nobody, NEW, Make socket.jsm more binary friendly
00:26:22 <Mook_as> for..of should preserve order, yes
00:26:30 <clokep> I agree, thanks. :)
00:26:38 <clokep> Do you put a let somewhere in that? :-S
00:26:57 <nhnt11> Is firefox
00:27:05 <nhnt11> Is firefox's tag icon somewhere in mozilla/ ?
00:27:12 <nhnt11> Or is it a firefox thing?
00:27:13 <Mook_as> if you like syntax errors? :p
00:27:14 <clokep> "tag icon"?
00:27:31 <clokep> Mook_as: OK, it just seems weird that you don't declare the variable anywhere, but I guess it doesn't really exist anywhere so...
00:27:38 <nhnt11> The tag icon in awesomebar hits.
00:28:45 <clokep> nhnt11: Still not sure what you mean. :-/
00:28:55 <nhnt11> I just found it
00:28:56 <nhnt11> clokep: http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/places/tag.png
00:29:09 <nhnt11> It appears to be OS specific, here's the linux one: http://mxr.mozilla.org/mozilla-central/source/browser/themes/linux/places/tag.png
00:29:14 * clokep has never seen that before.
00:29:26 <nhnt11> Windows: http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/places/tag.png
00:29:38 <nhnt11> I don't know why on earth they would make this OS specific :-/
00:29:57 <nhnt11> clokep: If you set a tag on a bookmark and search for it in the awesomebar, you will see this icon
00:30:41 <nhnt11> clokep: Do you know which one of those you like best? I'm debating between the OS X and Linux ones, didn't like the windows one much.
00:30:52 <clokep> nhnt11: Why not have it specific to each OS? :p
00:30:58 <nhnt11> clokep: Gross.
00:31:03 <clokep> nhnt11: Seriously? :-S
00:31:16 <clokep> Also, browser/ is unfortunately not packaged so Idk if you could get around that.
00:31:27 <clokep> You might be able to do some crazy referencing using ../mozilla
00:31:41 <nhnt11> Or I could just copy the images into instantbird/themes ;)
00:32:09 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2527 on bug 1981.
00:32:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
00:32:22 <clokep> Copying resources from somewhere else is gross.
00:32:58 <nhnt11> Hm.
00:33:32 <nhnt11> Aha. There's a tag-aero.png which looks way better.
00:33:46 <nhnt11> Okay I'll see if I can use these without copying...
00:33:59 <nhnt11> But if browser isn't packaged... well.
00:34:35 * nhnt11 doesn't know how to do this.
00:35:05 <nhnt11> clokep: Do you know how patches work when there are new images added?
00:35:16 <clokep> nhnt11: You do it by copying until flo-retina gives you a better idea. ;)
00:35:30 <clokep> nhnt11: You don't have to do anything special, they're base64 encoded into the patch.
00:35:57 <nhnt11> Hmm. I have to make sure the binary file is included in the diff though.
00:36:12 <nhnt11> I'll copy and use one of the tag images for now.
00:41:17 <-- EionRobb has quit (Ping timeout)
00:41:40 <clokep> nhnt11: I think if you have it set to git patches it will.
00:41:50 <nhnt11> Okay. I'll try it out.
00:42:18 <nhnt11> Argh
00:42:22 * nhnt11 forgot jar.mn yet again
00:42:43 --> EionRobb has joined #instantbird
00:42:50 <nhnt11> 6am.. wow.
00:48:11 <-- Mook_as has quit (Quit: Mook_as)
00:53:07 --> atuljangra has joined #instantbird
00:53:25 <atuljangra> clokep: Ping :)
00:53:52 <clokep> atuljangra: Hello.
00:53:54 <nhnt11> clokep: Looks like binary files aren't included by default for me
00:54:12 <clokep> nhnt11: Do you have git style patches set to true?
00:54:13 <atuljangra> clokep: How should I associate an account with the FileTransfer. One way is to have a readonly attribute in prplIFileTransfer.idl
00:54:24 <nhnt11> I remember setting that, yes.
00:54:29 <-- wnayes has quit (Ping timeout)
00:54:30 <clokep> atuljangra: Umm...I'm not sure, maybe?
00:54:47 <nhnt11> clokep: Note that I'm not using export, I'm using hg diff -r default -r awesometab-experimental
00:55:17 <clokep> nhnt11: Did you add it?
00:55:20 * clokep always forgets to do that.
00:55:28 <nhnt11> Ahh
00:55:54 <atuljangra> clokep: OKay. Just wanted to confirm. By following this, whenever, in account, I'm instantiating the fileTransfer, I can set the attribute to the this.account. 
00:56:29 <clokep> atuljangra: That sounds reasonable yes, but I won't know for sure how you're using it. :)
00:56:37 <clokep> atuljangra: Have you made any progress? I'd like to see some code.
00:57:27 <atuljangra> clokep: yes, it's mostly wip code. Give me some hours. Will push it to the butbucket.
00:57:55 --> wnayes has joined #instantbird
00:58:50 <clokep> atuljangra: OK. :)
00:58:51 <atuljangra> clokep: Also, how should a file be associated. I saw the downloads implementation, they've build nsIDownloadManager.idl, which handles everything.
00:58:56 <clokep> WIP is fine, I just like to read code. ;)
00:59:09 <clokep> atuljangra: Can we use / extend that?
00:59:24 <atuljangra> Just give me some more time :s ;)
00:59:31 <atuljangra> clokep: I'm not sure of that.
01:00:08 <atuljangra> I guess we can, but then extending it just for one or two things won;t make sense.
01:00:26 <clokep> ?
01:00:35 <atuljangra> clokep: What would you suggest?
01:00:52 <clokep> atuljangra: I don't understand "extending it just for one or two things won't make sense"?
01:01:02 <-- Suiseiseki has quit (Ping timeout)
01:01:18 <instant-buildbot> build #415 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/415
01:01:34 <atuljangra> I meant, nsIDownloadManager is the main download manager of Fx, this handles everything, multiple downloads, opening the OS file manager and other things.
01:01:57 <atuljangra> We just need the association of file, I guess we can handle it the same way as accounts?
01:02:16 <atuljangra> There is already a readonly attribute in nsDownload.idl, which we are extending.
01:02:47 <-- mpmc has quit (Connection reset by peer)
01:04:27 * atuljangra hopes that makes sense :s
01:05:21 <-- mconley has quit (Input/output error)
01:06:26 <clokep> atuljangra: Shouldn't you just use the attribute in nsIDownload.idl then?
01:07:16 <atuljangra> yes, just wanted to confirm. Cos fx does it the other way. :)
01:08:04 <clokep> Hm. OK.
01:08:42 <nhnt11> Here's a patch for the buddy list tab if anyone would like to try it out! :) http://pastebin.instantbird.com/233336
01:09:00 <atuljangra> clokep:  Also, I should be having |readonly attribute imIAccountBuddy buddy;| also in prplIFileTransfer.idl,  right? (for getting the buddy with which filetransfer should be done) 
01:09:08 <atuljangra> nhnt11: \m/
01:09:30 <nhnt11> I can't test the keyboard shortcuts etc. for Windows/Linux but it should work for sure from the buddy list context menu. (I would appreciate any feedback on this)
01:10:10 <clokep> atuljangra: Um, if you need it.
01:10:31 <atuljangra> clokep: is there anyother way with which it can be done?
01:10:45 <clokep> atuljangra: I'm not sure exactly what "it" is in this question.
01:11:00 <clokep> Getting the buddy...I mean.
01:11:04 <clokep> I don't know how your implementing ANYTHING.
01:11:15 <clokep> I'll be able to give a lot better responses if I've seen some of your current code.
01:12:05 <nhnt11> I lied about that patch, here's the real one (sorry): http://pastebin.instantbird.com/233337
01:12:29 <atuljangra> clokep: oh okay. I'll post it in few hours then. Sorry, I'm embarrassed. I just want my code to be in a working condition. Just give me some more time. 
01:12:33 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2528 on bug 2006.
01:12:35 --> SCIF has joined #instantbird
01:12:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2006 enh, --, ---, clokep, ASSI, The /invite command should support taking more than one nick as parameter
01:12:43 <atuljangra> By the time, you'll wake up, I'll have it ready.
01:12:52 <clokep> atuljangra: Please do NOT be embarrassed, there's nothing to be embarrassed about.
01:12:56 <clokep> OK.
01:13:04 <atuljangra> clokep: Thanks.
01:13:44 * atuljangra is going for breakfast. Will be back in some time :-)
01:13:51 * nhnt11 too
01:14:01 <atuljangra> nhnt11: hi5
01:15:12 <-- atuljangra has quit (Connection reset by peer)
01:17:45 <clokep> nhnt11: Does this require other patches? :-S
01:18:05 <clokep> Bah, it helps if I apply it.
01:19:49 --> nhnt11_phone has joined #instantbird
01:19:57 <nhnt11_phone> clokep: no
01:20:36 <nhnt11_phone> Appliable on unmodified default branch
01:20:44 <clokep> nhnt11_phone: So, after typing, when I press "down" it goes to the second entry, not the first.
01:21:21 <nhnt11_phone> Thats because the first element is already selected, i guess
01:21:29 <nhnt11_phone> Hmm
01:21:33 <clokep> But it isn't highlighted, just saying. :)
01:21:44 <clokep> The way more things are loaded is strange.
01:21:52 <nhnt11_phone> Why? 
01:22:14 <clokep> Because the scroll bar shows a certain amount and then all of a sudden shrinks.
01:22:30 <clokep> Ctrl + n should open a new window with an awesometab. :-D
01:23:05 <nhnt11_phone> clokep: IMO the scrollbar thing is fine 
01:23:21 <nhnt11_phone> Yeah I intend to adf that
01:23:24 <clokep> nhnt11_phone: Just my opinion, I'm saying it feels really weird.
01:24:09 <nhnt11_phone> clokep: What would you expect? 
01:24:46 <clokep> nhnt11_phone: The scrolllist to bethe proper "size" on load.
01:25:23 <nhnt11_phone> I don't know if it's possible to do that without a nasty hack
01:25:39 <clokep> Just something to think about.
01:25:41 <clokep> It is.
01:25:49 <nhnt11_phone> The point of this is to not add dom elements until necessary..
01:26:06 <nhnt11_phone> Hmm. I'll investigate, then
01:26:29 <clokep> I understand taht, yes.
01:26:31 * nhnt11_phone thinks the scrollbar thing is kinda cool.
01:30:15 <nhnt11_phone> clokep: Please let me know if you see any errors in the console :)
01:36:43 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com ))
01:45:44 <-- SCIF has quit (Ping timeout)
01:46:31 --> SCIF has joined #instantbird
01:46:58 <-- Nirgali has quit (Ping timeout)
01:49:02 <nhnt11> Time for my blog post and bed
01:49:22 <nhnt11> Looks like the blist-tab patch will have to wait for tomorrow.
01:51:14 <-- SCIF has quit (Ping timeout)
01:54:46 --> SCIF has joined #instantbird
01:56:06 --> Suiseiseki has joined #instantbird
02:05:55 <-- wnayes has quit (Quit: wnayes)
02:11:45 <nhnt11> Bye
02:11:47 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:13:44 --> Mook has joined #instantbird
02:16:34 <-- Suiseiseki has quit (Ping timeout)
02:28:21 <-- clokep has quit (Connection reset by peer)
02:30:36 --> atuljangra has joined #instantbird
02:31:23 <-- flo-retina has quit (Ping timeout)
02:54:50 --> Suiseiseki has joined #instantbird
03:07:20 --> mconley has joined #instantbird
03:11:41 <instant-buildbot> build #893 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/893
03:32:58 <instantbot> New Core - IRC bug 2022 filed by mook.moz+bugs.instantbird@gmail.com.
03:33:00 <instantbot> mook.moz+bugs.instantbird@gmail.com requested review from clokep@gmail.com for attachment 2529 on bug 2022.
03:33:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2022 tri, --, ---, nobody, NEW, Support mIRC-style italics formatting
03:34:28 <-- rosonline has quit (Client exited)
03:34:36 <instant-buildbot> build #885 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/885
03:37:41 <Mook> arrgh, I'm an idiot, but I don't feel like spamming even more in that bug.
03:38:57 * atuljangra wonders how does Even keep track whether someone has pinged him or not :P
03:41:23 <Mook> ... oops? sorry XD
03:41:43 <Mook> (obviously, that wasn't supposed to be a name...)
03:42:07 <atuljangra> no no, just that he gets tagged every now and then. 
03:42:09 <atuljangra> haha ;)
03:43:11 <Mook> yeah, it's just that the sentence was constructed in a way that having the word be referring to the name could actually work
03:44:01 <atuljangra> heh :P
03:53:12 <-- mconley has quit (Input/output error)
04:11:18 --> flo-retina has joined #instantbird
04:11:19 * ChanServ sets mode +qo flo-retina flo-retina 
04:18:52 --> Optimizer has joined #instantbird
05:04:55 <-- flo-retina has quit (Ping timeout)
05:13:17 --> gerard-majax_ has joined #instantbird
05:15:08 <-- gerard-majax_ has quit (Ping timeout)
05:29:32 --> gerard-majax_ has joined #instantbird
05:35:58 <-- gerard-majax_ has quit (Ping timeout)
05:47:38 --> Mic has joined #instantbird
05:47:39 * ChanServ sets mode +h Mic 
05:47:40 <-- SCIF has quit (Connection reset by peer)
05:49:55 --> SCIF has joined #instantbird
05:53:01 <instant-buildbot> build #988 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/988
06:02:36 <atuljangra> Mic: I'm declaring a function, called sendfile in prplIconversation.idl. But getting some error |cannot allocate an object of abstract type 'purpleConvChat'. I'm not sure how to define function in purpleConvChat.cpp
06:06:08 <atuljangra> I basically want a function sendFile in a conversation
06:06:46 <atuljangra> Till now, I was doing it through account. But wanted to change to this, as this is more cleaner way
06:06:59 <Mic> OK, let me say beforehand that I've absolutely no experience with this code ;)
06:07:58 <atuljangra> no pbm :P but anything would be helpful.
06:08:09 <Mic> Can you paste an excerpt of the code in question (the idl, purpleConvChat.h and .cpp)?
06:08:34 <-- SCIF has quit (Connection reset by peer)
06:09:45 <atuljangra> Just |void sendFile(in nsIURI aFileUri)| after http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#45
06:10:18 <atuljangra> implementation in purpleConversation.cpp is exaclty same as this: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleConversation.cpp#148
06:10:33 <atuljangra> I'm sorry, I;m on different machine.
06:10:35 --> SCIF has joined #instantbird
06:12:29 <Mook> your implementation just returns "not implemented"?
06:12:56 <atuljangra> Mook: yes, I've implemented the same in xmpp code.
06:13:07 <Mook> ah, you just want to get the declaration right?
06:13:16 <Mook> go read the generated prplIConversation.h :)
06:13:52 <atuljangra> yes
06:13:56 <atuljangra> okay. :-)
06:15:20 <-- SCIF has quit (Connection reset by peer)
06:16:32 --> SCIF has joined #instantbird
06:21:09 <-- SCIF has quit (Connection reset by peer)
06:23:01 --> SCIF has joined #instantbird
06:27:45 <-- SCIF has quit (Connection reset by peer)
06:31:03 <Mic> atuljangra: any success?
06:31:15 <atuljangra> no :s
06:31:40 <atuljangra> the function, sendMsg, and sendFile both are not there in generated prplIConversation.h
06:31:53 --> SCIF has joined #instantbird
06:33:22 <atuljangra> no no
06:33:24 <atuljangra> sorry
06:33:32 <atuljangra> yes the file does have declararion
06:34:15 <atuljangra> problem is that prplIConvIM and prplIConvchat,
06:34:25 <atuljangra> both extends prpoIconversation
06:34:44 <atuljangra> And I don't have any function declaration in both of the,
06:35:01 <Mic> I was about to say that after reading something on this error on StackOverflow :)
06:35:21 <atuljangra> Like this: http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleConvIM.cpp#66
06:35:48 <atuljangra> oh okay :)
06:36:30 <-- SCIF has quit (Connection reset by peer)
06:37:39 * atuljangra don't know how to define this in purpleConvIM,cpp and purpleConvChat.cpp
06:38:55 <Mic> "Not implemented"?
06:39:11 --> SCIF has joined #instantbird
06:40:04 <atuljangra> umm, yes, neither declared.
06:40:07 <Mic> I think it just needs to be defined there, nothing else.
06:40:30 <-- EionRobb has quit (Ping timeout)
06:40:41 <atuljangra> Don;t we need to define it here like sendMsg? http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleConvIM.cpp#66
06:41:27 <Mic> Yes, eventually. I'd just return not implemented for now and see if that fixes your problem.
06:41:51 <atuljangra> umm. okay. That should I guess.
06:45:04 <atuljangra> not defined error :-/
06:45:30 <Mic> So you've got a different error now?
06:46:04 --> EionRobb has joined #instantbird
06:46:05 <atuljangra> yes. this can be resolved. working on it
06:47:44 <Mic> :)
06:47:58 <-- EionRobb has quit (Ping timeout)
06:48:39 <atuljangra> Mic can you explain how does calling flow of |sendMsg(aMsg)| work? 
06:56:59 <-- Optimizer has quit (Ping timeout)
06:57:50 <-- SCIF has quit (Connection reset by peer)
06:58:06 --> SCIF has joined #instantbird
07:00:57 <-- Mook has quit (Ping timeout)
07:01:51 <atuljangra> |Instantbird encountered a serious error and cannot start| I must have done something horrible :(
07:04:01 <atuljangra> clokep I've changed manything in the flow that I was going, and now I'm stuck at this. I am trying to figure this out currently.
07:05:18 --> Mook has joined #instantbird
07:17:33 --> gerard-majax_ has joined #instantbird
07:24:16 * atuljangra :( still stuck.
07:24:19 <Mic> atuljangra: there should be more to this error message
07:24:25 * atuljangra goes for lunch.
07:25:51 <atuljangra> Mic: yes: a dialogue appears when I try to run IB. pastebin.instantbird.com/233546
07:28:02 <atuljangra> Mic: Can I somehow get more details, on what is going wrong
07:32:00 <Mic> Would you pastebin a diff of your changes? That would help to trace what could go wrong there. Without extra information (or eyes) it will be impossible to tell where you should look for the problem..
07:32:15 <atuljangra> Mic Sure
07:32:25 <atuljangra> it's wip so :s
07:32:39 <atuljangra> pasting
07:33:09 <Mook> hehe, syntax error.
07:33:25 <Mook> psst, komodo 8.5 b1 was pushed yesterday. syntax checking! :p
07:33:36 <Mic> You may rest assured that it's not the first WIP that I'm seeing ;)
07:33:48 <atuljangra> heh :P
07:34:11 <atuljangra> Mic: you use komodo? 
07:34:21 <Mic> What's our stance regarding advertisement in this channel? /me looks at Mook :P
07:34:35 <atuljangra> I use vim :-/
07:35:31 <Mook> you can at least shell out to `js -c`, though? (to run a syntax check on the file)
07:35:31 <Mic> Komodo and Notepad2, depending on how large the thing is that I need to check or do.
07:35:44 <Mook> of course, that requires having a js binary...
07:36:06 <atuljangra> oh okay. will do it.
07:36:10 <Mook> (you can probably abuse node.js into the role too, if you file doesn't have things v8 doesn't support)
07:36:20 <atuljangra> mic http://pastebin.instantbird.com/233557
07:36:26 <Mic> Thanks!
07:38:32 <Mook> atuljangra: line 177, end of line should be a comma, not a semicolon
07:38:48 * atuljangra hates himself :@
07:38:52 <Mook> actually, I guess it should be a close brace and a command
07:38:57 <Mook> s/nd//
07:39:24 <atuljangra> Mook: yes
07:39:30 <atuljangra> wrote that in hurry
07:39:33 <atuljangra> Thanks :-)
07:40:03 <Mic> Mook has beaten me :(
07:40:24 <Mook> lol @ 283
07:40:41 <Mook> also: I didn't even apply the patch! (so a syntax checker wouldn't have worked)
07:41:21 <atuljangra> heh :P
07:41:40 <atuljangra> I warned you about it's WIP-iness :P
07:42:26 <Mic> I haven't seen any other problem by the way.
07:42:52 <atuljangra> Mic: Thanks :)
07:43:27 <Mic> I started from the end of the file for some reason (and I assume Moo k started from top) so we should have everything covered ;)
07:43:56 <atuljangra> Mic: heh, that' nice. That worked. :-)
07:44:20 <Mic> You're unblocked now? :)
07:44:33 <atuljangra> yes, hoping so.
07:44:49 * atuljangra Going for Lunch :-)
07:46:57 <-- Mook has quit (Quit: Mook)
08:40:43 --> aleth has joined #instantbird
08:40:43 * ChanServ sets mode +h aleth 
09:06:53 <aleth> Mic: What's missing from bug 1511? I thought that had landed for some reason...
09:06:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
09:08:38 * aleth just tried to add a duplicate account for mozilla.org by accident
09:08:57 <Mic> aleth: I'd need to check. I think the code for GTalk (or XMPP in general?) doesn't work correctly.
09:09:18 <aleth> As long as it's not just a missing review ;)
09:09:44 <SCIF> aleth: Hey. You are so late today :)
09:10:27 <SCIF> I used xmpp for gtalk and it works ok. Do you want try to debug gtalk plugin more?
09:10:43 <aleth> SCIF: Thanks, that's good to know.
09:11:05 <aleth> Actually what would really help would be if you would file a bug for the issue
09:11:32 <aleth> With an anonymised version of the stanzas you PMd me yesterday
09:11:34 <SCIF> Not today, i must go away now. It's 20:11 here.
09:11:49 <SCIF> Ok. I will do it soon
09:12:06 <aleth> SCIF: No problem. The benefit if you file it is that we can get back to you if there are questions/you will get cc'd when it's fixed
09:12:36 <SCIF> aleth: cc'd? What is it?
09:12:46 <aleth> emailed
09:13:22 <aleth> Sadly our JS XMPP MUC support (used for gtalk) is not complete yet (that's part of the reason we still use the libpurple XMPP for generic XMPP)
09:14:34 <aleth> Well, actually the reason is the lacking DNS SRV support (if we had that we'd probably have fixed MUCs by now)
09:14:40 * Mic wonders where nhnt11's patch from tonight applies.
09:16:41 <SCIF> aleth: I'll try to add srv records to my domain and try again to connect.
09:17:01 <aleth> SCIF: It wouldn't help with your bug.
09:17:07 <SCIF> Why??
09:17:31 <aleth> Because you said you could connect to the server, just not to a chatroom?
09:17:33 <SCIF> It doesn't check them atall?
09:18:12 <SCIF> Hmmm. Seems so... Sorry, i'm tired today :)
09:18:27 <aleth> No, I guess I wasn't clear. We have two implementations of XMPP: the libpurple one (that supports DNS SRV) and our own JS one. gtalk uses the latter.
09:18:50 --> qlum has joined #instantbird
09:18:56 <-- qlum has quit (Quit: qlum)
09:18:59 <aleth> We would like to switch to the JS one completely in the future but what is blocking that is the lacking DNS SRV support in that implementation.
09:19:00 --> qlum has joined #instantbird
09:21:06 <aleth> And as we haven't switched completely, there are fewer people using it, and so more bugs that have gone unreported so far (like yours)
09:23:39 <SCIF> Thanks. Good bye!
09:23:50 <-- SCIF has quit (Quit: Good bye)
09:24:10 <qlum> Okay lets hope I won't get any disconnects after build 20130628041902. Testing it may take some time though as ever since I opened upnp (somehow forgot to do that before) the first disconnect on the router takes a lot longer. 
09:24:51 <aleth> qlum: Thanks! Let us know how it works out, and thanks for reporting the problem in the first place. Took a while to track that bug down.
09:29:16 --> flo-retina has joined #instantbird
09:29:16 * ChanServ sets mode +qo flo-retina flo-retina 
09:43:57 <aleth> atuljangra: If it makes you feel better, here's something I did recently http://hg.instantbird.org/instantbird/rev/d9a8debfce78 ;)
09:44:01 <flo-retina> aleth: either way is fine (re bug 1940)
09:44:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1940 nor, --, ---, aleth, ASSI, Fix errors/warnings on detaching/reattaching conversations
09:49:29 * flo-retina just got his debug Instantbird to start in highdpi
09:55:04 <-- aleth has quit (Quit: Ciao)
09:55:08 --> aleth has joined #instantbird
09:55:08 * ChanServ sets mode +h aleth 
09:55:27 <flo-retina> clokep: the reason for my question about using onStartRequest is http://pastebin.instantbird.com/233598 I wonder if by the time we receive "onStartRequest" necko already knows the connection will die because of the SSL issue. (and this is the SSL error message I get from gravel these days)
09:55:27 <aleth> flo-retina: I'll look at bug 451 instead then.
09:55:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 nor, --, ---, aleth, NEW, Participants Need Context Menu
09:55:39 <flo-retina> aleth: cool
09:55:54 <aleth> Thanks for the quick review there btw!
09:57:32 <flo-retina> maybe mark it checkin needed so that it doesn't get lost? :)
09:59:12 <aleth> (by quick review I meant bug 451 of course, wasn't being sarcastic)
09:59:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=451 nor, --, ---, aleth, NEW, Participants Need Context Menu
10:04:10 --> clokep has joined #instantbird
10:04:10 * ChanServ sets mode +o clokep 
10:17:21 --> nhnt12 has joined #instantbird
10:17:56 --> FireFly_TB has joined #instantbird
10:19:17 <nhnt12> Hello!
10:19:43 * nhnt12 just read that atuljangra uses vim :O
10:19:55 <aleth> nhnt11++ :P
10:20:05 * nhnt12 just saw his nick is nhnt12
10:20:23 --> nhnt11 has joined #instantbird
10:20:26 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:20:46 * aleth is looking forward to trying out the newtab
10:20:51 <nhnt11> aleth: Did you like infinite scroll? (If you tried it?)
10:20:54 <nhnt11> Ah
10:21:02 <aleth> For the scrollbar, these properties may be useful https://developer.mozilla.org/en-US/docs/XUL/scrollbar
10:21:16 <nhnt11> But.. but.. I like the scrollbar as it is now... :(
10:21:43 <aleth> I haven't tried it, but it seems it doesn't reflect the number of search results at the moment?
10:22:03 <nhnt11> It reflects the number of items, so you can "see" that more items are being added as you scroll.
10:22:21 <nhnt11> I guess the sign of a good UX is that the user doesn't realize stuff is happening though.
10:22:39 <aleth> I'd prefer to see if it is worth scrolling (i.e. have I restricted my search enough yet)
10:22:54 <aleth> I totally get why it is fun to see that when developing though :)
10:23:49 <aleth> It's like *visibly* working code :D
10:24:03 <nhnt11> aleth: The initial number of items is always greater than the available space (i.e. a scrollbar is always present in the beginning) so I'm not sure if that's an issue... you can definitely see if you have too many items and need to filter more
10:24:24 <nhnt11> (Assuming that there are enough filtered items, of course)
10:24:31 <nhnt11> But no matter, I'll do the scrollbar stuff.
10:24:45 <aleth> On most OS the size of the scrollbar indicates the percentage of items displayed
10:25:19 <nhnt11> Yeah.
10:25:36 * clokep wonders how Mook even found that...
10:25:39 <Mic> nhnt11: I haven't tried your code yet because I don't know where it applies :(
10:25:43 <aleth> Oh, another feature request :P : Highlight the search string match in the contact items (in bold maybe?)
10:25:54 <nhnt11> Mic: what do you mean? 
10:26:21 <Mic> It doesn't apply neither on Default nor Awesometab(-experimental) for me.
10:26:21 <nhnt11> The patch can be applied on an untouched default branch after hg pull/update.
10:26:50 <nhnt11> Mic: The diff is between awesometab-experimental and default. I tried applying it on my default branch and building before posting it
10:26:58 <nhnt11> Alternatively you could pull from my repo... it's up to date.
10:27:59 <flo-retina> "(in bold maybe?)" what about doing like in the Firefox awesomebar?
10:28:05 <nhnt11> flo-retina: ++
10:28:15 <aleth> Even better :)
10:28:17 * flo-retina is now known as flo-retina1
10:28:22 <flo-retina1> nhnt11: :-P
10:28:33 <aleth> Though that's also in bold for me ;)
10:28:57 <flo-retina1> aleth: bold + a slightly visible blue background with rounded corners for me.
10:29:00 <nhnt11> Right now though, I don't think it makes a big difference, because the filtering is done using startsWith
10:29:04 * flo-retina1 is now known as flo-retina
10:29:05 <Mic> nhnt11: solved.
10:29:13 <nhnt11> flo-retina1: That "1" was because of my ++?
10:29:25 <nhnt11> Mic: Great.
10:29:28 <flo-retina> yeah :-P
10:29:38 <nhnt11> Heh
10:29:46 <aleth> nhnt11: Yeah, that's true. It only makes sense when you match anywhere
10:30:05 <nhnt11> Do we want smarter filtering in the blist-tab?
10:30:15 <Mic> nhnt11: I often do not filter for the beginning of things (think of typeaheadfind here) because it's easier to find a unique part elsewhere.
10:30:19 <aleth> We want it eventually... the order is up to you
10:30:51 <flo-retina> nhnt11: I think filtering on the beginning of each word would make sense.
10:30:58 <flo-retina> nhnt11: and that's not too difficult to implement :)
10:31:05 <nhnt11> Alright.
10:31:28 <nhnt11> Should we match by tags, prpl name, and so on?
10:31:43 * nhnt11 needs to know where to draw the line.
10:31:59 <clokep> flo-retina: Do you have an alternative suggestion then?
10:32:35 <aleth> Match everywhere, then worry about how to weight the hits later in the gsoc project?
10:32:36 <flo-retina> clokep: about what?
10:33:10 <Mic> What's the use case for filtering on protocols?
10:33:16 <flo-retina> Mic: non
10:33:16 <flo-retina> e
10:33:32 <nhnt11> Right, we want to be protocol transparent. Cool.
10:33:33 <Mic> :)
10:33:36 <aleth> Tags are useful though.
10:33:42 <flo-retina> "Should we match by tags, prpl name, and so on?" no. By tags may be useful in the future, but I think we would want a special prefix for the search string (like Firefox does).
10:33:57 <flo-retina> filtering by username may be useful though
10:34:03 <nhnt11> That makes sense.
10:34:05 <flo-retina> for people who type random junk / quotes as their display name.
10:34:11 <aleth> flo-retina: Shouldn't we match, but weight the hit less than a match in the username?
10:34:16 <Mic> The awesomebar *does* search tags by the way.
10:34:24 <Mic> No special prefix needed.
10:34:27 <aleth> Mic: exactly :)
10:34:39 <flo-retina> Mic: ok ok :)
10:34:45 <flo-retina> I still think that can be handled later
10:35:07 <nhnt11> My worry about filtering parameters other than display name, is that the both could match, and then you want to give display name priority. But this would require more code, which I think may be overkill for this milestone.
10:35:09 * flo-retina is trying to debug docshell swapping failures.
10:35:09 <aleth> It can definitely be handled later - it's up to nhnt11 I think in which order he does all this stuff
10:35:24 <Mic> gtg
10:35:53 <flo-retina> nhnt11: for this milestone, matching only the display name is OK. I would like to match any word of the display name though (that would let you search by last name for example)
10:35:56 <nhnt11> I don't want to give priority to filtering now, because I will be spending a lot of time on this later anyway. Don't see the point in writing half baked code that I may need to replace.
10:35:59 <nhnt11> Bye Mic:)
10:36:02 <clokep> flo-retina: socket onStartRequest.
10:36:06 <nhnt11> flo-retina: That sounds good.
10:36:20 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:36:35 <flo-retina> clokep: well, onStartRequest: function() { this.onConnection(); }
10:36:41 <-- FireFly_TB has quit (Ping timeout)
10:36:44 * aleth still thinks about:memory in a tab is pretty cool :)
10:36:55 * clokep is confused. :-S
10:37:03 <flo-retina> aleth: I miss completion on the about page names :-P
10:37:46 * aleth misses completion on channel names
10:37:58 <nhnt11> aleth: Wait a couple months? ;)
10:38:07 <aleth> Yup, maybe I won't miss it soon :)
10:38:36 <flo-retina> aleth: I'm sure you'll quickly find something else to miss ;)
10:41:09 <nhnt11> flo-retina: I like the idea of filtering by tags if the "keyword" is specified and I think I'll implement it. It's useful to search by tags.
10:41:33 <flo-retina> what about doing that in another bug?
10:41:53 <nhnt11> Why?
10:41:55 * flo-retina would like something to land sooner rather than later, so that we can start getting a feel for how it works in real use cases
10:42:09 <nhnt11> Okay. It wouldn't take much time to implement.
10:42:37 <flo-retina> I don't even know what |filtering by tags if the "keyword" is specified| means btw ;)
10:42:50 <aleth> nhnt11: If it's so quick nobody will notice you might as well just do it and see if anyone complains :P
10:43:08 <nhnt11> flo-retina: Filter by tags if the user types "tag <tagname>"
10:43:18 <nhnt11> If names start with tag though..
10:44:00 <nhnt11> Okay, separate bug it is.
10:45:03 <flo-retina> what's 'tag' in that example?
10:45:11 <flo-retina> is it a localizable string?
10:45:38 <atuljangra> clokep: ping :)
10:45:54 <aleth> That's why it's a bad idea to have a special keyword if it's not needed ;)
10:46:01 <flo-retina> atuljangra: Good 'morning' ;)
10:46:29 <clokep> Hello atuljangra.
10:46:31 <atuljangra> flo-retina: heh ;) It's evening here :P
10:46:37 <flo-retina> aleth: not sure where that idea of a keyword is coming from.
10:47:05 <atuljangra> clokep:  can you explain how does calling flow of |sendMsg(aMsg)| work? I'm not sure of it's working with purple/ code.
10:47:42 <atuljangra> clokep: decided to move the file transfer initialization to a conversation, rather than account.
10:47:58 <flo-retina> nhnt11: I was more thinking of using a single punctuation character as a prefix, like http://kb.mozillazine.org/Location_Bar_search#Location_Bar_search_.28internal_-_Auto_Complete.29
10:48:12 <flo-retina> for example +foo would filter to only contacts that have the tag 'foo'
10:48:20 <nhnt11> That sounds good.
10:48:29 <nhnt11> That would work much better too.
10:49:15 <aleth> They act as a restriction. If you leave it out, tags will still be matched (just not exclusively)
10:49:51 <nhnt11> aleth: Won't work for our case I think. We want either no tags, or just tags.
10:50:01 <nhnt11> (For now, at least)
10:50:47 <nhnt11> Should we strip regex special characters from the filter string?
10:51:11 <clokep> atuljangra: I don't know what you mean, we call sendMsg, the function gets called and we send stuff to servers. What is your "real" question?
10:51:13 <flo-retina> nhnt11: why?
10:51:16 <clokep> What are you actually trying to do?
10:51:17 <nhnt11> Never mind.
10:51:25 <clokep> atuljangra: I have to go to work, flo-retina should be able to help you.
10:51:33 <clokep> Are you still stuck trying to create a function for purplexpcom?
10:52:01 <atuljangra> clokep: okay thanks :-) more or less yes.
10:52:03 <nhnt11> I need to create a regexp object out of the filter string, while making sure all the regex chars in the filter string are escaped.
10:52:21 <flo-retina> atuljangra: if you ask specific questions I should be able to help
10:52:29 <atuljangra> flo-retina: yes
10:52:31 <flo-retina> (but I'm debugging something too ;))
10:52:32 <aleth> nhnt11: We have that already somewhere in the code
10:52:41 <clokep> atuljangra: You need to check the header file for the function definition like Mook said, if it's unimplement just put it in the purpleConversation, since both ConvIM and ConvChat inherit from it.
10:52:45 * nhnt11 searches lxr
10:52:55 <flo-retina> nhnt11: well, you can keep startsWith matching for now
10:53:16 <nhnt11> flo-retina: You want me to split the string by spaces and match each word like that?
10:53:28 <atuljangra> clokep: I did the same, but no success. It still says function not implemented when I drag something on conversation.
10:53:43 <clokep> atuljangra: What conversation are you using?
10:54:00 <clokep> And that's thet ype of information we need to know btw, I assumed you had a compile error, please be very specific.
10:54:07 <flo-retina> just .split(/\s+/).some(function(s) s.startsWith(string)) should be reasonable for now
10:54:11 <atuljangra> gtalk, 
10:54:21 <nhnt11> Cool.
10:54:37 <clokep> atuljangra: We NEED to see your code to help you.
10:54:42 * clokep is out.
10:54:42 <flo-retina> atuljangra: pastebin the code you are talking about
10:54:48 <atuljangra> clokep: no, it wasn't a compile error. I got it when I was dropping a file.
10:54:52 <aleth> nhnt11: For future reference http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#522
10:54:52 <flo-retina> heh, clokep had the same thought :)
10:55:01 <nhnt11> aleth: Thanks!
10:55:04 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:55:07 * atuljangra did it earlier today.
10:55:20 <atuljangra> flo-retina: it's WIP. pasting it again
10:56:32 <flo-retina> atuljangra: if it wasn't WIP it would be an attachment on bugzilla with an r? flag rather than a pastebin ;)
10:57:14 <aleth> nhnt11: another feature suggestion : when pasting to pastebin with your add-on, check if the first line starts with diff, and set the content type accordingly ;)
10:57:40 <flo-retina> aleth: cool idea :)
10:57:44 <nhnt11> aleth: I have a mental note to work on that.
10:58:05 <nhnt11> If it starts with diff, diff syntax, else javascript should be good enough for most of our use cases
10:58:06 <aleth> Thanks :)
10:58:50 <nhnt11> I could add a "default language" option too ;)
10:58:54 <atuljangra> flo-retina: http://pastebin.instantbird.com/233632
10:59:09 <atuljangra> flo-retina: ;)
10:59:13 * nhnt11 will do that after he is done with a patch for blist-tab, while waiting for review.
10:59:43 <flo-retina> atuljangra: I suggest reading what aleth just suggested ;)
10:59:56 <flo-retina> (even though you don't do it in an add-on :-P)
11:00:20 <atuljangra> heh, got it. Just a sec
11:00:25 <flo-retina> nhnt11: you would also check for a first line that looks roughly like XML
11:00:31 <flo-retina> *could
11:00:39 <atuljangra> flo-retina: http://pastebin.instantbird.com/233634
11:00:48 <nhnt11> flo-retina: Most of our XML is XBL though, which I would rather have javascript syntax for.
11:00:56 <flo-retina> nhnt11: fair enough :)
11:01:04 <flo-retina> atuljangra: ok, so now, what's the problem? :)
11:01:16 <nhnt11> filtering by last name works great, btw :)
11:02:19 <flo-retina> nhnt11: cool :)
11:03:01 <-- nhnt11 has quit (Ping timeout)
11:03:18 <atuljangra> flo-retina: I want to know a way, of initializing XMPPFileTransferPrototype when I use |sendFile| method. Also, I want to know, how should be the implementation of the same |sendFile| in purpleConvIM and purpleConvChat. 
11:03:58 <flo-retina> you mean you want the same function to be called in both cases?
11:04:20 <atuljangra> yes
11:04:40 <flo-retina> see http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleConvIM.h#27
11:05:21 <atuljangra> yes I tried to do that, will change it.
11:05:44 <flo-retina> for now I assume you just want it to return NS_ERROR_NOT_IMPLEMENTED in both cases
11:06:38 <atuljangra> yes, but I do want to initialize XMPPFileTransferPrototype, with the aFileURI/aFile somewhere.
11:06:53 <flo-retina> not in C++, right?
11:07:17 <atuljangra> yes, in js
11:08:09 <flo-retina> is the _init method there a placeholder for something you'll need in the future?
11:08:20 --> nhnt11 has joined #instantbird
11:08:31 <atuljangra> _inti method will be used to start the file transfer
11:10:13 <flo-retina> atuljangra: http://pastebin.instantbird.com/233636
11:10:38 <flo-retina> bah, tab complete is consistently completing "aleth" when I want to talk to Atul, and Atul's nick when I want to talk to aleth.
11:10:48 <flo-retina> I guess it's not been design to talk at once to 2 people with a nick starting with the same letter
11:11:00 <flo-retina> or maybe I'm just too used to type the first character and then tab :-S
11:11:59 <atuljangra> flo-retina: okay :) Trying :-)
11:13:47 * nhnt11 is having trouble fixing this: http://log.bezut.info/instantbird/today/#m128
11:14:00 <nhnt11> Okay, I'm installing not today.
11:15:08 <nhnt11> http://log.bezut.info/instantbird/130628/#m128
11:15:12 <nhnt11> Cool :)
11:16:53 <flo-retina> iirc wnayes had a similar issue to deal with in the first tab of the account wizard
11:17:44 <nhnt11> flo-retina: A hack to fix it quickly would be to add a dummy element at the beginning of the list ;)
11:18:18 <flo-retina> nhnt11: bug 1521
11:18:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1521 min, --, 1.3, wnayes, RESO FIXED, Keyboard behaviour in list of popular networks
11:18:44 <flo-retina> you seem to like dummy elements ;)
11:19:44 <nhnt11> Yeah :P
11:19:50 <nhnt11> wnayes' hack is better though.
11:21:39 <nhnt11> I didn't know about that negative currentIndex behavior :S
11:22:30 <nhnt11> It didn't fix it for me... :(
11:25:39 <nhnt11> Let me try something..
11:26:27 <flo-retina> nhnt11: http://lxr.instantbird.org/instantbird/source/instantbird/content/accountWizard.js#33 have you seen this line too?
11:26:42 <nhnt11> I tried that.
11:26:45 <nhnt11> It didn't work.
11:32:44 <nhnt11> Fixed it
11:33:04 <nhnt11> I simply made it select the first item if selectedIndex < 0
11:35:58 --> mpmc has joined #instantbird
11:48:22 <qlum> so far I am seeing improvement after the fix even if I got one disconnect on one of my 7 nets, now this may just be an odd case but at least when I get a disconnect there is no 6 minutes where people can write stuff I can't read so that is an improvement. I will check if this is just an odd case and will add a post to the bug at the end of the day
11:49:08 <aleth> qlum: That's good news :) If you find changing the timeouts helps even more, let us know
11:49:29 <aleth> s/timeouts/timeout value
11:49:57 <qlum> right now it is just one disconnect and I doubt changing the timeout would help
11:50:05 <qlum> as all the other pings are completed within a second
11:50:17 <qlum> and it is just one net and only once for now
11:50:26 <aleth> OK
11:50:31 <qlum> so I will see end of the day
11:50:33 --> clokep_ has joined #instantbird
11:53:51 <clokep_> qlum: That's good news. :)
11:53:56 <nhnt11> bbl
11:54:55 <clokep_> aleth: qlum I'd prefer if we leave the timeout for now and run with this for a few days at least first. :)
11:55:14 <aleth> ^^ ?
11:55:23 <aleth> oh, you're on mibbit :(
11:55:41 <clokep_> aleth: http://log.bezut.info/instantbird/today/#m567
11:55:48 <clokep_> aleth: Oh, yes.
11:56:01 <aleth> clokep_: Yes, I was pointing at the completion fail
11:56:12 <clokep_> Mibbit-fail. :(
12:00:44 <clokep_> aleth: Thoughts on https://bugzilla.mozilla.org/show_bug.cgi?id=888166?
12:06:17 <aleth> clokep_: Maybe the alternate nick patch will help?
12:07:03 <aleth> The workaround is for that user to register the fallback nick as a grouped nick.
12:07:18 <aleth> Certainly doesn't seem a bug on our end.
12:07:25 --> jb has joined #instantbird
12:07:40 <aleth> INVALID I'd say
12:09:19 <clokep_> aleth: Yeah, I don't really think there's much we can do in that case, it's kind of shitty, but meh...
12:09:32 <clokep_> I'll let them try to convince me otherwise before closing it though. :)
12:09:45 <aleth> Maybe cc the guy to the alternate nick patch as a sign of work being done ;)
12:10:02 <clokep_> If anything, I'd just point him to it.
12:27:19 <nhnt11> Back
12:29:04 <nhnt11> aleth: Did you get a chance to look at the new DOM code?
12:29:18 <aleth> nhnt11: no, where?
12:29:18 <nhnt11> I mean DOM element handling *
12:29:38 <nhnt11> Just a second.
12:30:36 <nhnt11> aleth: http://pastebin.instantbird.com/233679
12:30:55 <nhnt11> The interesting bit is from line 30, I think.
12:31:15 <aleth> Oh, that's clever - you just reuse existing elements?
12:31:37 <nhnt11> Yeah. Inspired by Mook.
12:31:59 <flo-retina> clokep_: do we know the nick has been modified before we try to identify?
12:32:34 <flo-retina> clokep_: if yes, I think the solution is to have the alternate nick feature implemented first, and then to identify only if the nick is one of the nicks the user listed
12:35:26 <nhnt11> aleth: Pushing | let lang = text.startsWith("diff") ? "diff" : "javascript"; | to my pastebin addon now.
12:35:31 <aleth> nhnt11: |filteredContacts.shift().id| you don't really need the performance overhead of modifying the array here. Just use an index and increment.
12:35:52 <nhnt11> aleth: Probably a good idea, thanks.
12:36:35 <instantbot> clokep@gmail.com granted review for attachment 2529 on bug 2022.
12:36:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2022 tri, --, ---, nobody, NEW, Support mIRC-style italics formatting
12:36:44 <clokep_> flo-retina: Yes, I think that's reasonable.
12:36:49 <clokep_> But still an assumption. :)
12:36:58 <aleth> nhnt11: Thanks! Is it on AIO yet so it autoupdates or should we reinstall?
12:37:26 <nhnt11> I think I put it on AIO, let me check. If not, I'll upload it there now.
12:39:21 <clokep_> Is atuljangra still blocked or is he all good?
12:41:07 <nhnt11> aleth: It's on AIO.
12:41:10 <nhnt11> Updating it now.
12:41:27 <aleth> Cool.
12:41:38 <aleth> clokep_: I think he went away for a bit?
12:41:50 <clokep_> OK.
12:42:28 <aleth> nhnt11: You have to nominate for public for autoupdates to work.
12:42:39 <nhnt11> Will do.
12:42:47 <nhnt11> Don't I need a screenshot for that?
12:44:06 <aleth> Annoyingly, yes. Doesn't really make sense in this case. Some 1px png file or pastebin icon will do I guess ;)
12:44:55 <-- jb has quit (Ping timeout)
12:48:27 <nhnt11> I added an option for default language. Let me just test this quickly before uploading.
12:49:17 <atuljangra> clokep_: good, trying to complete the actual implementation now.
12:50:25 <clokep_> atuljangra: OK.
12:50:32 * aleth really wants to switch to JS XMPP when it has working filetransfers :)
12:50:46 <atuljangra> aleth: :)
12:50:55 --> jb has joined #instantbird
12:50:59 <nhnt11> Wow. I'm getting a FAILURE on httpReq.send() :-/
12:51:15 <nhnt11> I don't know why /that/ would start happening all of a sudden..
12:51:49 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:52:09 --> nhnt11 has joined #instantbird
12:52:32 <nhnt11> Hmm. Working fine from my main profile
12:52:53 <clokep_> aleth: We should really write the patch to allow toggling. :(
12:53:41 <aleth> qheaden is going to make us do it ;)
12:55:05 <nhnt11> Services.cmd.unregisterCommand doesn't seem to be working...
12:55:05 <-- ivan has quit (Ping timeout)
12:56:07 * clokep_ wonders if anyone ever tests that. :P
12:57:03 * flo-retina wonders who clokep_ will volunteer to write a test
12:57:38 --> ivan has joined #instantbird
12:58:25 <aleth> nhnt11: If there's really a bug, file it ;)
12:58:44 <nhnt11> I'm not quite sure if it's a core bug or a bug with my addon...
12:58:50 <nhnt11> The key listener is definitely removed though.
12:59:25 * nhnt11 is trying to find the URL for the pastebin icon.
12:59:38 <clokep_> flo-retina: I'll volunteer to have someone write tests, sure. :)
13:00:39 <nhnt11> Found it
13:02:14 <nhnt11> Who reads the public nomination messages?
13:03:01 <aleth> Mic or I, usually (though annoyingly we aren't emailed about them)
13:03:11 <nhnt11> I just nominated mine.
13:03:46 <aleth> Did you fix the unregisterCommand issue?
13:04:06 <nhnt11> No :/
13:04:21 <aleth> I'll wait until you figure out if that is a core bug or not then
13:04:37 <aleth> No hurry ;)
13:04:39 <nhnt11> aleth: I think it's a core bug, not totally sure.
13:04:50 <nhnt11> This should work, right? Services.cmd.unregisterCommand(kPasteCommand);
13:06:12 <aleth> nhnt11: Find out here http://lxr.instantbird.org/instantbird/source/chat/components/src/imCommands.js#130
13:06:16 <nhnt11> Yeah it should. It isn't working
13:06:20 <nhnt11> Yeah I'm looking at that now.
13:06:38 <nhnt11> Let me quickly test to be sure.
13:11:24 <nhnt11> It's working in a test addon :-/
13:11:47 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:11:54 --> nhnt11 has joined #instantbird
13:12:36 <nhnt11> Weird
13:12:39 <nhnt11> It isn't working for my paste command
13:12:45 <nhnt11> Working for a test addon, but not for this.
13:12:47 <nhnt11> No clue why
13:13:07 <clokep_> What's the code for it?
13:13:25 <nhnt11> Services.cmd.unregisterCommand("name of command");
13:14:43 <aleth> Add some dump statements, find out what exactly has been registered?
13:15:16 <nhnt11> The name of the command is definitely registered as "paste"
13:15:25 <nhnt11> Just a second, I found out my test wasn't working at all.
13:15:34 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:15:41 --> nhnt11 has joined #instantbird
13:16:17 <nhnt11> :S
13:17:03 <nhnt11> Okay
13:17:05 <nhnt11> It's a core bug
13:17:15 <nhnt11> Here's my test addon's bootstrap.js
13:17:40 <nhnt11> http://pastebin.instantbird.com/233747
13:18:42 --> mconley has joined #instantbird
13:18:59 <atuljangra> flo-retina: Regarding, xep-0047, how should I send the requests. Generally they are done by using | jabber_iq_send|, but we want to use JS instead of libpurple. (if that makes sense :s) I hope you get what I want to say,
13:19:17 <nhnt11> aleth: I guess you can approve my public nomination then :)
13:19:28 <nhnt11> I'll file a bug about unregisterCommand..
13:19:43 <aleth> nhnt11: Can you fix the core bug? (is it obvious what is going wrong?)
13:19:48 <nhnt11> No.
13:19:51 <nhnt11> No clue.
13:19:59 <nhnt11> The command is deleted.
13:20:04 <nhnt11> (According to the code)
13:20:34 <nhnt11> brb
13:20:34 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
13:20:42 --> nhnt11 has joined #instantbird
13:21:19 <clokep_> atuljangra: Did you look at the JS-XMPP code?
13:21:37 <clokep_> "we want to use JS instead of libpurple", yes you shouldn't be looking at the libpurple XMPP code at all.
13:21:57 <atuljangra> clokep_: yes.
13:22:38 <flo-retina> clokep_: to be fair, I looked at libpurple's implementation a few times, for things that were really difficult to figure out (especially the old auth model, that isn't in the specs any more ;)).
13:22:53 <clokep_> atuljangra: For example: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#384
13:23:15 <clokep_> The API is kind of clunky.
13:23:28 <atuljangra> clokep_: So for sending ibb requests, I should use this. OK
13:24:34 <atuljangra> also, as ibb doesn't have any server backend, so the file receiving totally depends, whether client supports it or not. 
13:24:50 <atuljangra> wondering if web gmail chat, supports ibb or not.
13:25:24 <instantbot> New Core - General bug 2023 filed by nhnt11@gmail.com.
13:25:25 <clokep_> I doubt it supports it.
13:25:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2023 nor, --, ---, nobody, NEW, Services.cmd.unregisterCommand is broken
13:25:48 <flo-retina> atuljangra: wouldn't you get a reply to the first stanza with a failure if it's not supported?
13:26:33 <-- jb has quit (Quit: jb)
13:26:41 <atuljangra> flo-retina: yes, I was just curious to know how to test this. I just need some other client that already supports it, so that I can test the sending part.
13:30:01 --> jb has joined #instantbird
13:31:43 * qheaden_away is now known as qheaden
13:31:54 <qheaden> Hello World.
13:32:40 <atuljangra> clokep_, flo-retina I would take a break for a couple of hours. Will be back late in the night :)
13:32:44 <atuljangra> Bye :-)
13:32:45 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
13:33:11 <clokep_> atuljangra: You'll have to find another client which supports it, Google for it? :)
13:35:27 <nhnt11> aleth: You have to type "javascript" not "js"
13:36:29 <aleth> nhnt11: good to know
13:36:49 <nhnt11> I'll update it to have a dropdown.
13:36:53 <nhnt11> (Later)
13:37:06 <aleth> Yeah, I don't know how much work that is
13:38:35 <nhnt11> http://log.bezut.info/instantbird/130628/#m266: That's not in the release notes here - http://community.activestate.com/node/9983...
13:39:26 <qheaden> clokep_: I'm going to work on error handling with the key/values as we discussed yesterday.
13:42:25 <clokep_> qheaden: OK. :) Check out the IRC code for it, it does some nice things.
13:42:48 <clokep_> nhnt11: Komodo has always had syntax checking...
13:43:03 <nhnt11> clokep_: Yeah, I was a bit confused.
13:51:26 <qheaden> clokep_: Wow, I just struck out some things under Conversations on our Etherpad, and we are making some great progress.
13:56:38 <clokep_> qheaden: What'd you strike out?
13:57:02 <aleth> Time to land soon? :)
13:57:37 <qheaden> clokep_: Under Conversations, creating, receving, sending messages, receiving messages, and typing notifications.
13:58:37 <qheaden> Well, let me unstrike receiving messages. Support is there for it, but there are some issues when chatting with the official Yahoo client.
13:59:08 --> atuljangra has joined #instantbird
13:59:40 <clokep_> qheaden: Typing notifications work inbound and outbound?
13:59:45 <qheaden> clokep_: Yes.
13:59:56 * atuljangra is back
14:00:28 <clokep_> :)
14:00:29 <clokep_> Cool.
14:01:06 <clokep_> qheaden: Looks like you've made good progress on conversations, what's the next step?
14:02:23 <qheaden> clokep_: Well, first I need to work on correct error handling within YahooPacket. Secondly, I need to attempt to iron out the duplicate message bug when chatting with the official YMSG client, and the formatted font bug when chatting with the web client.
14:06:52 <clokep_> qheaden: OK. :)
14:07:03 <clokep_> atuljangra: Did you see my message?
14:07:20 <atuljangra> clokep_: Yes :-)
14:07:24 <atuljangra> I saw the logs.
14:07:40 <qheaden> If I can't get things working, I'll just visit the Yahoo! office in CA and demand they give me the official protocol docs. :P
14:08:33 * atuljangra wonders if the patch for alternate nicks needed urgently?
14:09:33 <clokep_> atuljangra: No, GSoC is more important.
14:09:54 <atuljangra> clokep_: Awesome :-)
14:10:06 <clokep_> qheaden: I have a feeling we need to ack.
14:10:42 * nhnt11 can't get the scrollbar thing to work
14:11:51 <qheaden> clokep_: I saw that libpurple sends some packet with an unknown service number back after each message. I'll have to check the code.
14:12:31 <-- jb has quit (Ping timeout)
14:13:34 --> jb has joined #instantbird
14:13:52 <clokep_> qheaden: Excellent. :)
14:20:18 <qheaden> I'll be back in a bit.
14:20:51 <nhnt11> I can't figure this out
14:21:33 <nhnt11> I think the best way to do this is to ensure the size of the listbox is that many pixels (even if it doesn't contain that many elements - it should just have empty space) and also make sure it scrolls.
14:21:51 <nhnt11> Or hacking the scrollbar itself..
14:21:54 <nhnt11> But I'm not sure how to do that
14:22:09 <nhnt11> How do I obtain the scrollbar of a richlistbox? blist.scrollbox?
14:22:52 * qheaden is now known as qheaden_away
14:24:04 <aleth> Maybe this? https://developer.mozilla.org/en-US/docs/XUL/Property/scrollBoxObject
14:24:30 <aleth> You may run into trouble if the richlistbox uses the scrollbar position internally for something.
14:24:32 --> rosonline has joined #instantbird
14:24:44 <clokep_> nhnt11: Mook has ideas for it, flo-retina might too.
14:24:52 <clokep_> nhnt11: I thought we were trying to land something of what you have now first though? :-S
14:25:06 <nhnt11> Oh, the scrollbar thing is okay then?
14:25:08 <aleth> nhnt11: Simple hack: dummy element at the bottom with a massive height.
14:25:14 <nhnt11> aleth: Haha I thought of that
14:25:27 <aleth> nhnt11: Don't let it block the rest of this patch though
14:26:17 <aleth> That's the kind of thing that can be un-hacked or beautified in followups
14:26:30 <nhnt11> Okay
14:30:06 <nhnt11> I'm going to drop the scrollbar stuff for the patch then
14:30:23 <nhnt11> I don't like the dummy element hack, it would require me to ensure that it's not selectable, etc.
14:30:29 <aleth> Possibly easier/safer than the scrollboxobject stuff is using CSS to set the size of the scroller by hand.
14:30:40 <clokep_> Btw do we have some way to land this preffed off?
14:30:41 <nhnt11> Hmm.
14:30:47 <clokep_> Or are we just going to land it?
14:30:52 <nhnt11> clokep_: Why would we want it preffed off?
14:31:02 <nhnt11> I thought we wanted people to test it so that we could fix bugs
14:31:06 <aleth> I think we wouldn't land it if it wasn't ready to land preffed off?
14:32:39 <clokep_> aleth: nhnt11 We'd land it with a pref so if it isn't ready for next release we can flip the pref and disable it.
14:33:33 <aleth> Oh, I see what you mean. I just meant it should be default-on in nightlies ;)
14:35:32 <clokep_> Yeah, poor wording, sorry.
14:38:38 <nhnt11> HEy
14:38:40 <nhnt11> Hey*
14:38:54 <nhnt11> What about adding padding after the last element
14:38:54 <nhnt11> ?
14:39:00 * nhnt11 investigates.
14:44:25 <aleth> Mook's probably the person to ask about which CSS property might work on richtlistbox > scrollbox
14:44:41 <nhnt11> Got it working
14:44:41 <nhnt11> :)
14:44:53 <aleth> Great :D
14:45:00 <nhnt11> Hmm it appears to have broken the adding-more-elements part though
14:45:33 <nhnt11> Oh wow
14:45:38 <nhnt11> Now the size of the last element is huge
14:45:41 <nhnt11> Ugh.
14:45:47 <clokep_> :P
14:45:59 <nhnt11> I thought padding was supposed to be added /between/ elements?
14:47:44 * qheaden_away is now known as qheaden
14:47:51 <clokep_> nhnt11: http://www.w3.org/TR/CSS2/box.html#box-dimensions
14:48:05 <nhnt11> Yeah just realized
14:48:05 <clokep_> You know it'll be a good time when I link to specs. ;)
14:48:10 <nhnt11> I'm looking for margin.
14:48:13 <nhnt11> :P
14:48:48 <nhnt11> Or, I should set padding bottom on the listbox
14:48:51 <nhnt11> rather than the last element
14:51:06 <nhnt11> padding on the list box doesn't work.
14:51:17 <aleth> Try something along the lines of |therichlistbox scrollbox scrollbar[orient="vertical"] slider {height: 5px !important;}|
14:52:08 <nhnt11> Hmm
14:52:43 <aleth> I don't know how the scrollbar of the richlistbox appears in the DOM though
14:53:22 <nhnt11> I don't know if it's a good idea to hack the scrollbar
14:53:30 <nhnt11> I still think adding space at the bottom is the way to go.
14:53:48 <aleth> Certainly easier.
14:55:06 <aleth> For now, maybe just add a dummy, empty, disabled item at the bottom with a custom height
14:55:44 <nhnt11> Right..
14:55:46 <nhnt11> Okay.
14:56:07 <aleth> Or leave it as-is until someone can give you a better way :)
14:56:16 * atuljangra goes for dinner
14:56:26 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
14:57:58 * qheaden is fascinated by timezones. :P 
14:59:06 <nhnt11> :P
15:14:45 <nhnt11> Right so after experimenting a bit with a dummy element
15:14:48 <nhnt11> I've decided to drop this
15:14:54 <nhnt11> It just doesn't work as well as it should
15:15:06 <nhnt11> So I'll wait until we find a better solution
15:19:56 * flo-retina isn't sure what the problem is
15:20:40 <nhnt11> flo-retina: The scrollbar on the listbox reflects the current number of elements, and not the total elements possible for the current filter string
15:21:06 <flo-retina> do you expect to know the total number of elements possible?
15:21:17 <nhnt11> Yes. I don't expect it, I do know it.
15:21:28 <flo-retina> and again, why do we have a scrollbar at all? :-P
15:21:51 <flo-retina> nhnt11: currently you do, because you are only taking stuff from the contact list that has a fixed lenght
15:22:08 <nhnt11> Yeah. I do mean only for what we currently have.
15:22:11 <flo-retina> nhnt11: but maybe in the future you'll get additional data during the query
15:22:41 <aleth> flo-retina: Actually I think he'll almost always have the data
15:23:02 <flo-retina> aleth: are you sure we'll always get the data synchronously?
15:23:07 <nhnt11> flo-retina: "additional data during the query" did you have a specific case in mind?
15:23:21 <flo-retina> nhnt11: well, I have the awesomebar in mind
15:23:33 <nhnt11> flo-retina: Even if the data arrives async, the filter method is setup with executeSoon
15:23:37 <flo-retina> nhnt11: where the result comes from an asynchronous SQL query, that keeps returning results
15:24:02 <flo-retina> I'm still not sure what the use case for scrolling is
15:24:12 <nhnt11> flo-retina: It's only a use case in the blist-tab
15:24:13 <aleth> flo-retina: I don't know what you had in mind for the backend (SQL etc) but we certainly don't want to be doing things like /list on-demand, that should be async
15:24:58 <aleth> I thought the use case for scrolling was mainly long lists of matching MUCs...
15:25:12 <flo-retina> aleth: what about filtering that long list then?
15:25:30 <nhnt11> Btw, I don't like the idea of displaying conversations on hold in the blist-tb
15:25:30 <nhnt11> tab*
15:25:56 <aleth> flo-retina: Isn't that a different issue though?
15:26:21 <flo-retina> nhnt11: why?
15:26:32 <nhnt11> flo-retina: I just realized it's needed for MUCs
15:26:33 <nhnt11> Never mind.
15:26:55 <nhnt11> flo-retina: I think what I actually meant was, I don't like the idea of showing them separately :/
15:26:58 <nhnt11> Like in the buddy list
15:26:58 <aleth> flo-retina: Oh, I see what you mean. But I don't know what the best solution to that is.
15:27:07 <nhnt11> With a "Conversations on hold:" label and everything.
15:27:41 <clokep_> nhnt11: SHouldn't it be like Firefox's "switch to tab" thing?
15:27:43 * flo-retina has no idea of what we are discussing
15:27:57 <aleth> flo-retina: I think postponing scrolling details to the point where we actually want it is a good idea
15:28:16 <flo-retina> aleth: I guess I really need to try the patches soon
15:28:42 <nhnt11> clokep_: Yeah, but what about the unfiltered view?
15:28:54 <flo-retina> nhnt11: it's nicely displayed in your contact list window
15:29:09 <aleth> nhnt11: I thought the unfiltered view/grid thing was to be left for much later in gsoc
15:29:31 <nhnt11> Okay let me clear this up
15:29:42 <nhnt11> I'm talking about including conversations on hold in the blist-tab, i.e. the current milestone
15:30:01 <aleth> I'd say don't bother ;)
15:30:06 <nhnt11> Exactly
15:30:07 <aleth> That's part of MUCs.
15:30:08 <flo-retina> nhnt11: I think you should be talking about attaching the current milestone in a patch on bugzilla instead ;)
15:30:15 <nhnt11> Brilliant
15:30:18 <aleth> :)
15:30:22 <nhnt11> Okay then I'll feature-freeze this patch
15:30:30 <nhnt11> And work on adding comments and getting it ready for review.
15:30:55 <flo-retina> nhnt11: it will be much easier to add more stuff later if the main code is already there by default
15:31:50 <nhnt11> flo-retina: Do you mean add code to provision for adding convs-on-hold later?
15:32:03 <nhnt11> That's not too difficult, just that I don't feel like making more UX decisions for it.
15:32:07 <flo-retina> no
15:32:29 <instantbot> aleth@instantbird.org requested review from nhnt11@gmail.com for attachment 2531 on bug 2023.
15:32:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2023 nor, --, ---, aleth, ASSI, Services.cmd.unregisterCommand is broken
15:32:49 <flo-retina> nhnt11: you should be trying to get the *minimal* patch that makes sense to include in a nightly, and get it checked in asap. ;)
15:32:57 <nhnt11> Cool.
15:33:05 <nhnt11> I aim to have a patch uploaded tonight then
15:34:31 <flo-retina> we will all have much clearer ideas about what's wanted or not once we have used a basic version for a few days.
15:34:37 <nhnt11> aleth: Good catch on that patch! :)
15:34:43 <nhnt11> I didn't even notice..
15:34:52 <nhnt11> flo-retina: That sounds reasonable.
15:35:06 <nhnt11> In the meantime I'll start working on the backend for the real awesometab.
15:35:11 <aleth> nhnt11: Took me about half an hour of debugging to notice too :P
15:35:40 <nhnt11> :)
15:36:16 <nhnt11> Let me test it real quick.
15:36:18 <flo-retina> aleth: can we have a test for it? :)
15:36:44 <nhnt11> flo-retina: Not that kind of bug :P
15:36:50 <nhnt11> Is it?
15:37:05 <nhnt11> (not sure if you're commenting after seeing the patch, or based on what we've been saying on IRC)
15:37:15 <instantbot> florian@instantbird.org granted review for attachment 2531 on bug 2023.
15:37:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2023 nor, --, ---, aleth, ASSI, Services.cmd.unregisterCommand is broken
15:37:45 <nhnt11> Pretend I never said anything, then.
15:38:22 <aleth> I have tested it, but I didn't test it with nhnt11's addons ;)
15:39:11 <-- gerard-majax_ has quit (Ping timeout)
15:41:26 --> Optimizer has joined #instantbird
16:01:46 <-- Kaishi has quit (Quit: Kaishi)
16:01:59 --> Nirgali has joined #instantbird
16:04:18 <nhnt11> flo-retina: So I'll include the awesometab command in menus.xul, and in instantbird.xul ifndef os x
16:04:32 <flo-retina> ok
16:09:30 <nhnt11> How about adding a Ctrl+N command in menus.xul for opening a new window with an awesometab, and a Ctrl+T command in instantbird.xul for opening a new tab in the current window?
16:12:06 <qheaden> clokep_: So if a certain required key is not found, you want to send out a warning?
16:16:25 <flo-retina> nhnt11: why wouldn't Ctrl+T from the blist open a new tab in the most recent conv window?
16:16:40 <nhnt11> That's what it does currently.
16:17:14 <nhnt11> I'm trying to figure out the best way to incorporate cloke_p's suggestion (if I do incorporate it) about Ctrl+N opening a new window with an awesometab.
16:18:02 <flo-retina> nhnt11: so why wouldn't both Ctrl+N and Ctrl+N work everywhere?
16:18:13 <nhnt11> flo-retina: Okay.
16:18:43 <nhnt11> I wanted to avoid having two menu items for Awesometab..
16:18:44 <flo-retina> "I'm trying to figure out the best way to incorporate cloke_p's suggestion" the best way is to file a bug, once your minimal patch has landed :-P
16:19:00 <flo-retina> ah
16:19:14 <flo-retina> maybe Ctrl+N doesn't have to be discoverable?
16:20:02 <aleth> No new menu items please
16:20:21 <aleth> Ultimately we will just replace "Join chat"...
16:20:38 <nhnt11> So I'll leave it undiscoverable for now?
16:20:51 <aleth> Seems OK to me at least.
16:21:14 <aleth> The '+' tab should be discoverable enough anyway ;)
16:21:25 <nhnt11> I meant the Ctrl+N stuff ;)
16:22:14 <nhnt11> Ugh. I want to just leave it as it is with Ctrl+T for now and doing Ctrl+N as a separate bug like flo suggested.
16:22:22 <nhnt11> s/doing/do
16:22:50 <aleth> Great :)
16:25:31 <nhnt11> Should I ifdef the newAwesometab function in instantbird.js too?
16:25:40 <nhnt11> Or is it enough to disable the command in Mac?
16:25:52 <nhnt11> (Actually it works even without an ifdef?
16:25:52 <nhnt11> )
16:26:50 <nhnt11> I need to find a centralized place to put the newAwesometab function. The same thing exists in both menus.js and instantbird.js now. Not sure where to put it.
16:27:58 <nhnt11> Perhaps in imWindows
16:28:34 <nhnt11> Yeah, I'm going to put it in imWindows.jsm unless you guys see any problems with that or have a better suggestions.
16:28:41 <flo-retina> aleth: I think we will want "new convesation" in the menu to replace "join chat"
16:29:04 <flo-retina> aleth: and I see nothing wrong with adding that now and removing "join chat" later
16:29:29 <aleth> Oh, that's true, we'd want to rename it anyway of course.
16:35:01 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
16:40:11 <-- mpmc has quit (Connection reset by peer)
16:47:32 --> Mook_as has joined #instantbird
16:53:08 <clokep_> qheaden: Isn't that an error? :-S
17:00:22 --> FireFly_TB has joined #instantbird
17:00:36 <clokep_> qheaden: I wouldn't expect us to be able to do anything else in that function if a required field is missing.
17:00:49 <clokep_> Mook_as: How'd you even realize you weren't seeing italics? :)
17:02:14 <Mook_as> clokep_: some guy was complaining in #chatzilla (about chatzilla, obviously), and I got curious if ib did it
17:02:29 <Mook_as> also, my reference was wrong; it's item #51 in 7.0
17:02:58 <-- aleth has quit (Quit: Ciao)
17:05:20 <clokep_> Mook_as: It's fine. ;)
17:05:23 <clokep_> I found it.
17:06:54 <Mook_as> right. I just plan on making a comment *in the bug* to that effect once I get home, so hg blame can be somewhat useful... (this assumes I also fix up the patch to include the bug number in the checkin comment of course)
17:09:58 <clokep_> flo would ensure that before check-in. :)
17:10:19 <clokep_> It did make me wonder whether we're doing "reverse" properly now. :-S
17:11:57 <Mook_as> I don't think you really want "reverse" on a not-a-tty
17:12:23 <Mook_as> I mean, I guess you might, if you were actually playing a MUD over IRC...
17:12:50 <clokep_> Hah, right.
17:12:55 <clokep_> It's italics now, I think. :)
17:13:08 * clokep_ wonders if there was a difference between reverse and inverse.
17:13:25 * Mook_as thinks there isn't in this case
17:15:41 <clokep_> I don't think we handle both of them anyway.
17:19:24 <-- rosonline has quit (Client exited)
17:26:48 <qheaden> clokep_: The ERROR() method is on the account object, so should I store the error method from a parameter passed to YahooPacket?
17:27:05 <qheaden> In other words, how will the packet throw the error? Should I just directly call throw?
17:30:31 <-- jb has quit (Ping timeout)
17:30:38 <clokep_> qheaden: You want to call throw.
17:30:46 <clokep_> And then catch it somewhere and call error on the account.
17:31:21 <clokep_> qheaden: Does that make sense?
17:32:18 --> jb has joined #instantbird
17:32:22 <clokep_> I.e. like http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#51 and http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#686
17:36:46 <qheaden> clokep_: Yes, that makes sense. Thanks for the links.
17:40:28 <clokep_> Great! :)
17:40:35 * clokep_ didn't think his description made much sense. ;)
17:42:39 <qheaden> clokep_: My error message is: Required key [key number] wasn't found.
17:42:41 <qheaden> Is that good enough?
17:44:01 <clokep_> qheaden: Yes, that's fine for now.
17:44:33 <clokep_> We might eventually want the caller or some more of the stack or something...but that's OK.
17:45:21 <qheaden> Okay.
17:45:44 <qheaden> clokep_: Perhaps I should add packet service numbers in there too?
17:49:24 <-- jb has quit (Ping timeout)
17:49:25 <clokep_> Sure.
17:49:38 <clokep_> qheaden: I have a feeling you'll figure out what's useful to have while testing. :)
17:49:49 <qheaden> :)
17:51:03 <nhnt11> I'm back
17:51:11 <nhnt11> (with some coffee :P )
17:55:30 <nhnt11> How do I search for quotes in lxr?
17:55:32 <nhnt11> :/
17:56:01 * nhnt11 tries &quot;
17:56:30 * qheaden wants nhnt11 to ship some coffee to him.
17:56:39 <clokep_> nhnt11: I don't think it works.
17:56:41 <clokep_> grep?
17:56:47 <nhnt11> Yeah it didn't work.
17:56:56 <nhnt11> I got what I needed though. Never mind.
18:04:11 --> jb has joined #instantbird
18:06:53 <-- FireFly_TB has quit (Quit: FireFly_TB)
18:11:00 <nhnt11> Oh no... I see errors in the console
18:11:14 <nhnt11> Failure while removing the observer... huh.
18:22:12 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:36:58 --> unghost has joined #instantbird
18:40:20 --> Mnyromyr has joined #instantbird
18:42:37 <qheaden> Are try/catch blocks required to have braces, even for single lines?
18:47:09 <nhnt11> I think so.
18:49:31 <qheaden> They are. I just looked it up.
19:46:02 * qheaden finally fixed the duplicate message issue.
19:57:21 --> clokep has joined #instantbird
19:57:21 * ChanServ sets mode +o clokep 
20:02:39 --> flo-retina has joined #instantbird
20:02:39 * ChanServ sets mode +qo flo-retina flo-retina 
20:03:03 <-- jb has quit (Ping timeout)
20:04:00 --> jb has joined #instantbird
20:07:48 <qheaden> clokep: I'm sure you saw my BitBucket commit. I got rid of that duplicate message issue.
20:07:53 <qheaden> We did have to send an ACK.
20:09:15 <clokep> qheaden: I saw, :)
20:10:37 <qheaden> clokep: The libpurple comment said that if you don't send an ack, the message is resent as an offline message.
20:10:44 <clokep> I read. ;)
20:11:20 * qheaden is waiting for clokep to say "I heard" to complete the chain.
20:11:38 <clokep> I tasted.
20:11:43 <clokep> :P
20:11:46 <qheaden> :P
20:14:32 <-- Nirgali has quit (Ping timeout)
20:17:49 --> Nirgali has joined #instantbird
20:23:04 --> Hronom has joined #instantbird
20:29:41 <-- Optimizer has quit (Ping timeout)
20:35:03 * flo-retina was saying somewhere else that http://pastebin.instantbird.com/234010 is all we need to have the fonts displayed correctly on Mac retina screens
20:37:16 <-- jb has quit (Ping timeout)
20:40:27 * clokep was saying somewhere else that he'd rs that!
20:41:26 <clokep> Anyone else need reviews? :P
20:41:33 * clokep isn't sure what patches he's working on. :-/
20:43:16 <flo-retina> hmm, would also be nice to checkin the fix for the mac oncommit failure
20:43:50 * flo-retina suspects clokep wants to rs that too :-P
20:48:34 <-- flo-retina has quit (Ping timeout)
20:55:35 <clokep> flo-retina: Probably. :P
20:55:42 <clokep> qheaden: Do you have any more questions? I have a friend coming over soon.
20:58:33 --> flo2 has joined #instantbird
20:58:53 <flo2> apparently gravel doesn't want to let my other account reconnect :-S
20:58:59 <clokep> :(
20:59:01 --> flo-retina has joined #instantbird
20:59:01 * ChanServ sets mode +qo flo-retina flo-retina 
20:59:23 <flo-retina> of course, just when I say I can't reconnect, I'm back! :)
20:59:32 * clokep pokes gravel.
21:00:46 <instantbot> clokep@gmail.com requested feedback from florian@instantbi rd.org for attachment 2532 on bug 1587.
21:00:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync build scripts with comm-central
21:04:53 <clokep> FYI I'd like to finish that ^ before doing Moz22.
21:09:20 <nhnt11> flo-retina: Considering it does no harm to have the awesometab command both in menus.xul and instantbird.xul, is the ifndef XP_MACOSX really required? (/me thinks it's ugly)
21:10:08 <nhnt11> Btw, am I required to keep fields for my this.* variables?
21:10:32 <flo-retina> if it does no harm then you likely don't need it :)
21:10:32 <nhnt11> I initialize this.contacts, and a few other arrays in the constructor, is this enough or should I add a <field> for them?
21:10:44 <nhnt11> Cool.
21:10:54 <flo-retina> should be enough
21:11:00 <nhnt11> About the fields, I mean for Instantbird coding practices.
21:11:02 <nhnt11> Okay then.
21:11:48 --> jb has joined #instantbird
21:11:55 <-- Hronom has quit (Client exited)
21:18:13 <-- jb has quit (Ping timeout)
21:19:52 --> jb has joined #instantbird
21:23:23 <nhnt11> Btw, flo-retina, do you have any idea of how to use icons in browser/ ?
21:24:20 <flo-retina> cp browser/... instantbird/theme/
21:25:00 <nhnt11> Cool then. cloke_p was saying it was gross to copy stuff, so I asked.
21:25:24 <Mook_as> gross doesn't always mean there are better answers :p
21:25:40 <nhnt11> Also, Fx has three tag icons (one for each OS), and I'm kinda against having OS specific tag icons. Can I just pick one and use it?
21:25:54 <nhnt11> Mook_as: Heh. He suggested I ask flo if it's possible.
21:25:56 <clokep> Mook_as++
21:26:06 <clokep> nhnt11: I'm very for having OS specific icons.
21:26:12 <clokep> I refuse to use applications that don't like OS native.
21:26:41 <nhnt11> clokep: Yes, if it's actually something to do with the OS.
21:26:50 <nhnt11> Do those tag icons appear elsewhere in Windows?
21:26:55 <nhnt11> that tag icon*
21:27:02 * clokep doesn't want to get into this conversation right now.
21:27:05 <Mook_as> nhnt11: can you imagine using metro-looking apps in OSX?
21:27:12 <Mook_as> (as in, Tiger-era)
21:27:14 <nhnt11> Oh no.
21:27:23 <nhnt11> I did not mean that.
21:27:54 <nhnt11> I meant, I don't understand the point of creating different tag icons for each OS.
21:28:05 <nhnt11> They aren't that out of place in any of them
21:28:06 <nhnt11> Fine fine
21:28:08 <nhnt11> Never mind.
21:28:40 * clokep wonders if flo-retina has ideas about http://bugs.activestate.com/show_bug.cgi?id=99524 ...
21:29:40 * nhnt11 tries to figure out how to do this OS specific stuff.
21:29:43 <flo-retina> "Can I just pick one and use it?" no.
21:32:17 <nhnt11> flo-retina: So where do I keep these three icons now? Creating awesometab-___stripe seems a bit overkill for one icon..
21:32:49 <clokep> Why can't they just go in each of the OS folders thatexist already? :-S
21:33:07 <flo-retina> clokep: are you sure we really have OS folders?
21:33:14 <clokep> No. :)
21:33:24 <nhnt11> clokep, flo-retina: We have preferences-___stripe and tabbrowser-___stripe
21:33:28 <nhnt11> Nothing generic.
21:33:34 <nhnt11> Unless I'm missing something
21:34:15 <clokep> And then we have -aero icons just floating around.
21:34:45 <nhnt11> Ah
21:34:56 <nhnt11> So -aero stuff automatically gets compiled if aero is available?
21:35:00 <clokep> No.
21:35:02 <nhnt11> s/compiled/applied
21:36:41 <clokep> nhnt11: See http://lxr.instantbird.org/instantbird/search?string=-aero
21:37:36 <nhnt11> Oh. jar.mn. Should've realized.
21:38:05 <clokep> :)
21:38:23 <nhnt11> flo-retina, clokep: Is it okay to have tag-*stripe.png's and include them accordingly in jar.mn?
21:38:40 <flo-retina> nhnt11: what about explicit names?
21:38:47 * clokep is OK with that.
21:38:49 <flo-retina> tag-mac.png, tag-linux.png, etc...
21:39:01 <nhnt11> Okay. Fine by me.
21:44:43 <-- Tonnes has quit (Connection reset by peer)
21:44:50 <-- jb has quit (Ping timeout)
21:46:07 <qlum> I reported about the changes to the disconnects I got 4 in total over the day, on 3 different nets which does seem pretty acceptable in around 13 hours of time when being connected to 7 nets especially now that the time I may miss stuff is also a lot shorter
21:48:50 <clokep> qlum: That seems better. :)
21:49:02 <clokep> I'm not surprised if you drop a few connections during a full day, personally.
21:49:44 <qlum> well even more interestingly the last drop was at 15:19 and its 23:49 now
21:49:56 <clokep> :)
21:50:05 <clokep> So I can go ahead and close that bug as FIXED then for now?
21:50:24 <qlum> well technically the problem still presists in a very minor form
21:50:34 <qlum> so it would depend on how you interpret fixed
21:51:02 <qlum> fixed as in not really a problem, yes fixed as in completely solved, no
21:51:48 <clokep> Hmm...
21:51:59 <clokep> I wonder if changing the ping time to 30 seconds now would solve it.
21:52:32 --> jb has joined #instantbird
21:52:44 <qlum> at what rate does mozilla irc ping us?
21:52:51 <qlum> as that rate seems to be working there
21:53:00 <qlum> never had a single disconnect like that there
21:53:44 <qlum> then again I did not get a disconnect on quakenet, mibbit, and freenode today either
21:54:33 <clokep> qlum: Frequently.
21:54:41 <qheaden> How is the status on a conversation set?
21:54:49 <qheaden> Conversation window rather.
21:55:10 <-- jb has quit (Ping timeout)
21:55:59 <clokep> qheaden: Via the accountbuddy, IIRC.
21:56:22 <qlum> now that I think about it tweakers, stormbit, and ps3sanctuary are all smaller irc's operated by sites and in the case of stormbit just a small private irc network so it may just be them doing something wrong now that they sometimes disconnect
21:57:21 <qlum> so I guess it may be better to wait a few days
21:58:26 <qheaden> clokep: Thanks.
21:58:39 --> Optimizer has joined #instantbird
21:59:12 <qlum> I know I am just guessing here and don't know enough but can't it be that for some reason some lag causes a smaller network not to respond to a ping which would result in a disconnect, could it be that retrying a ping could also solve the issue?
21:59:55 <clokep> qlum: Wouldn't surprise me if smaller networks have more issues...
22:00:03 <clokep> qlum: Wait as long as you want. :)
22:00:31 <qlum> also I looked at the disconnects there and all of them where during peek times on those smaller networks
22:00:46 * flo-retina wonders if dew has made some progress on his prpl
22:00:56 <qlum> so it may just be a bug that causes them to not send back a pong
22:02:04 <qlum> So if anything I would say try to ping twice before disconnecting
22:02:20 <clokep> qlum: Let's wait a few days.
22:02:26 <clokep> And then we can look at logs if it's still happening, OK?
22:03:13 * clokep needs to find Florian's proper accented name somewhere...
22:04:00 <nhnt11> Quéze?
22:04:21 * nhnt11 can type that easily on Mac ;)
22:05:15 <nhnt11> Oh wait it's a backward accent
22:05:20 <clokep> Yes.
22:05:26 * nhnt11 doesn't know much about these things, sorry
22:05:45 <-- Optimizer has quit (Ping timeout)
22:06:11 <qlum> sure
22:06:19 <clokep> And I'm sure I could type it...but Americans don't do that often. ;)
22:06:36 <clokep> http://clokep.blogspot.com/2013/06/mentoring-google-summer-of-code-2013.html
22:06:41 <qlum> Quèze
22:06:48 <qlum> easy to do on us international
22:07:38 <clokep> qheaden: You don't use Twitter, right?
22:08:12 <qheaden> clokep: No.
22:08:53 <clokep> OK. :)
22:09:15 <clokep> atuljangra: Make sure you do weekly blog posts, please.
22:11:05 <qheaden> clokep: For some reason I didn't realize I was your only student. :P
22:11:21 <clokep> qheaden: I have two interns at work. ;)
22:11:28 <nhnt11> clokep: He did one a few hours ago, fyi.
22:11:33 <qheaden> :P
22:11:42 <clokep> nhnt11: Where, it's not on his blog.
22:11:48 <nhnt11> http://gsoc-mozilla.tumblr.com/
22:12:10 <qheaden> clokep: "Florian goes by something starting with "flo". lol
22:12:35 <qheaden> You never know which handle is next. :P
22:12:38 <instantbot> New Core - Twitter bug 2024 filed by clokep@gmail.com.
22:12:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2024 min, --, ---, nobody, NEW, Following a new user on twitter does not add them as a participant
22:12:41 <clokep> nhnt11: That's not the URL he gave everyone. :(
22:12:51 <nhnt11> He posted the url on his blog :/
22:13:03 <nhnt11> (Blog in a blog?)
22:15:11 <clokep> nhnt11: Bah, you have to click the title of that blog post to get there. That's confusing.
22:15:15 * clokep probably just doesn't understand tumblr.
22:17:14 <flo-retina> uh, I hoped I could look quickly at bug 1587, but the diffs seem huge :-/
22:17:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1587 min, --, 1.5, clokep, REOP, Re-sync build scripts with comm-central
22:17:23 <clokep> Yes, they are. :)
22:17:28 <clokep> Best looked at with a glass of whiskey, I think.
22:17:39 <flo-retina> clokep: can I just checkin https://bugzilla.instantbird.org/show_bug.cgi?id=1587#c5 with rs=you and paste the checkin link in that bug?
22:17:53 * flo-retina usually doesn't drink alcohol
22:18:08 <clokep> flo-retina: I need to test it again before we do that, tomorrow?
22:18:21 <flo-retina> clokep: I meant http://hg.mozilla.org/comm-central/rev/d394e3684954
22:18:34 <flo-retina> (my link pointed to *comment 5*)
22:19:21 * nhnt11 needs to format this better: http://pastebin.instantbird.com/234087
22:21:12 --> Optimizer has joined #instantbird
22:23:37 --> mpmc has joined #instantbird
22:26:25 <nhnt11> flo-retina: Would it be okay to leave that as it is? ^
22:26:50 <qheaden> clokep: So it turns out that an ACK is only needed with the official desktop client, and only the official desktop client sends the message ID in key 429. The web client doesn't.
22:27:01 <qheaden> So we only need to send an ACK when key 429 is defined.
22:27:13 <clokep> qheaden: Cool.
22:27:25 <clokep> flo-retina: That's fine, rs=me.
22:28:04 <flo-retina> cool
22:28:20 <qheaden> I can tell the protocol is extremely messy because of a lot of legacy support.
22:29:05 <flo-retina> nhnt11: that's pretty unreadable
22:29:11 <nhnt11> flo-retina: Yeah :(
22:29:23 <nhnt11> I'll separate it into a variable.
22:30:01 <qheaden> Now I keep getting this error when I send a message. Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [mozITXTToHTMLConv.scanTXT]
22:31:04 <flo-retina> nhnt11: what about http://pastebin.instantbird.com/234099 ?
22:31:26 <flo-retina> or http://pastebin.instantbird.com/234100
22:31:54 <nhnt11> I just wrote this: http://pastebin.instantbird.com/234101
22:31:57 <nhnt11> Looking at yours..
22:33:08 <flo-retina> that works I guess
22:33:20 <nhnt11> I like mine, I'll keep it.
22:34:08 * nhnt11 is trying to save whoever reviews this some time..
22:34:30 <nhnt11> Though I probably should just upload a patch since there will be something I missed anyway.
22:35:34 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:37:55 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:38:41 * qheaden wonders why sending messages suddenly causes illegal value errors. :-S
22:39:58 <flo-retina> qheaden: I would dump the value given to scanTXT with a .toSource() or JSON.stringify, so that special characters are visible
22:40:27 --> wnayes has joined #instantbird
22:44:02 <qheaden> Hmm, the value seems to be null.
22:54:37 <qheaden> Okay, found the issue.
22:55:24 <qheaden> For some reason the user name of the sender was coming up null when using it in sendMsg.
22:55:37 <qheaden> Still have to figure out why that is.
23:00:00 <qheaden> Okay, its all fixed now.
23:00:21 <instantbot> New Instantbird (UI) bug 2025 filed by florian@instantbird.org.
23:00:22 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2536 on bug 2025.
23:00:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2025 nor, --, ---, nobody, NEW, Add Retina Display support to Instantbird
23:01:57 <flo-retina> Good night :)
23:02:11 <qheaden> Night.
23:02:18 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/aedcb7fee974 - Florian Quèze - Bug 2025 - Add Retina Display support to Instantbird, rs=clokep.
23:02:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/318b01b2edfb - aleth - Bug 2023 - Services.cmd.unregisterCommand is broken, r=fqueze.
23:02:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b032f238be66 - aleth - Bug 1940 - Fix errors/warnings on detaching/reattaching conversations, r=fqueze.
23:02:21 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7be18e1919f7 - Florian Quèze - Bug 1587 - Re-sync build scripts with comm-central - port 'Bug 797452 Intermittent build/macosx/universal/unify failure: "copyIfIdentical: files differ" - sort manifest
23:02:21 <nhnt11> Night.
23:02:22 <instantbot> files for comparison when comparing them.', rs=clokep.
23:02:23 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4ef98ddd9842 - Mook - Bug 2022 - Support mIRC-style italics formatting, r=clokep.
23:04:54 <instantbot> florian@instantbird.org requested feedback from benediktp@ymail.c om for attachment 2527 on bug 1981.
23:04:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1981 nor, --, ---, clokep, ASSI, Make socket.jsm more binary friendly
23:08:16 <-- qheaden has left #instantbird ()
23:08:42 --> qheaden has joined #instantbird
23:18:12 <qheaden> Well I'm heading in. Goodnight!
23:18:31 <nhnt11> Night.
23:18:47 * qheaden is now known as qheaden_away
23:20:42 <instant-buildbot> build #410 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/410
23:29:52 <nhnt11> I'm going to request review from all of them... bleh
23:32:46 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2537 on bug 2015.
23:32:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2015 enh, --, ---, nhnt11, NEW, Display buddy list in a tab.
23:34:50 <nhnt11> Another big patch...
23:39:33 <-- mconley has quit (Input/output error)
23:56:43 <instant-buildbot> build #429 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/429