All times are UTC.
00:18:30 <-- mconley has quit (Input/output error) 00:27:33 --> Optimizer has joined #instantbird 00:30:32 <-- Optimizer has quit (Ping timeout) 00:38:50 <-- wnayes has quit (Ping timeout) 00:42:19 --> wnayes has joined #instantbird 00:43:11 <-- qlum has quit (Quit: Getting the <censored> out.) 00:48:44 --> Optimizer has joined #instantbird 00:48:58 --> mconley has joined #instantbird 00:52:42 <instant-buildbot> build #411 of win32-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/411 blamelist: aleth <aleth@instantbird.org> 00:54:17 <-- mconley has quit (Ping timeout) 00:59:01 <-- Optimizer has quit (Connection reset by peer) 01:02:53 --> Optimizer has joined #instantbird 01:05:53 <-- Optimizer has quit (Ping timeout) 01:12:11 --> clokep has joined #instantbird 01:12:12 * ChanServ sets mode +o clokep 01:19:13 --> mconley has joined #instantbird 01:19:47 <clokep> qheaden: Congrats. :) I'm looking over the stuff onw. 01:19:52 <clokep> Will finish in a few minutes. 01:38:31 <-- mconley has quit (Ping timeout) 01:48:58 --> mconley has joined #instantbird 01:55:23 <-- mconley has quit (Ping timeout) 01:56:10 --> mconley has joined #instantbird 01:57:17 <clokep> Mook: Does accessing a property that may or may not exist through warnings? E.g. aObject.foo || ""? 01:57:40 <Mook> I... umm, can't remember, sorry 01:57:47 <Mook> which possibly means "half the time" :p 01:57:47 <clokep> No problem. :) 01:59:21 <-- wnayes has quit (Quit: wnayes) 02:01:42 <-- mconley has quit (Ping timeout) 02:32:20 <clokep> Mook: Do you know if it's possible to run Mozilla xpcshell tests after building comm-central? 02:32:32 <clokep> (I'm not sure if it's set up in a a similar way to Komodo so...) 02:37:15 <instant-buildbot> build #881 of macosx-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/881 02:47:37 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 02:52:09 <instant-buildbot> build #889 of linux-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/889 03:20:12 --> nhnt11 has joined #instantbird 03:21:49 * nhnt11 wonders how these nits creep in even when you're extra careful to follow all the rules 03:35:19 <nhnt11> By the way, do we use American or British spelling in comments? i.e. behavior vs. behaviour. 03:36:11 * nhnt11 has used American so far, but just realized the lead developer being French might warrant use of British ;) 03:40:23 <nhnt11> Btw, thanks to everyone who took the time to look through that patch. :) 03:43:53 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2508 on bug 426. 03:43:54 <instantbot> nhnt11@gmail.com cancelled feedback?(aleth@instantbird .org) for attachment 2508 on bug 426. 03:43:56 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2510 on bug 426. 03:43:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 03:44:19 <Mook> sorry, was distracted; and no, I know nothing about xpcshell tests. 03:44:50 <Mook> presumably once the build-c-c-as-a-subdir-of-m-c lands that'll all work out of the box, though...? (purely guessing here) 03:48:07 * nhnt11 wishes Bugzilla wouldn't send me two emails when a review is denied/granted (one because I uploaded the patch, one because I'm on the CC list) 03:49:14 <nhnt11> Ugh, I seem to have switched from third person to first midway. 03:49:43 * nhnt11 looks through Bugzilla prefs 04:13:14 --> Optimizer has joined #instantbird 04:51:26 --> FireFly_TB has joined #instantbird 04:58:36 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:58:44 --> nhnt11 has joined #instantbird 04:59:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:59:34 --> nhnt11 has joined #instantbird 04:59:43 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:01:08 --> nhnt11 has joined #instantbird 05:02:30 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:03:14 --> nhnt11 has joined #instantbird 05:33:34 <-- nhnt11 has quit (Ping timeout) 05:37:35 --> nhnt11 has joined #instantbird 05:41:50 <instant-buildbot> build #984 of win32-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/984 05:45:03 <-- EionRobb has quit (Ping timeout) 05:45:56 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:49:56 --> nhnt11 has joined #instantbird 06:09:05 --> jb has joined #instantbird 06:20:50 <-- FireFly_TB has quit (Ping timeout) 06:33:45 <-- jb has quit (Ping timeout) 07:00:19 <-- Mook has quit (Quit: Mook) 07:11:36 --> chrisccoulson has joined #instantbird 07:55:07 <-- Optimizer has quit (Ping timeout) 07:56:27 <flo-retina> clokep: |aObject.foo || ""| Using the value of a property that doesn't exist causes a warning. Just checking of the property has a value doesn't. So if my understanding is correct, |aObject.foo ||""| or |if (aObject.foo)| don't cause a warning, but |if (aObject.foo + 1)| would. 07:56:48 <flo-retina> clokep: I think c-c runs the platform xpcshell tests. 07:57:12 <flo-retina> nhnt11: American English usually. 07:57:53 <nhnt11> Okay, good to know 07:58:17 <flo-retina> nhnt11: I actually like having 2 emails in that case. I read the email from the bug just as information, and keep the "granted/denied" email as a reminder, and keep it unread until I've done the next step (new patch, checkin, approval request, whatever...) 07:58:39 --> Optimizer has joined #instantbird 07:59:03 <nhnt11> You probably have more bugs to keep track of then me ;) 08:00:00 * flo-retina has 31 unread emails from bugzilla :-S 08:00:43 <nhnt11> Wow :P 08:00:56 * nhnt11 wonders if his tabbrowser patch will get r+'d today 08:01:28 <flo-retina> not sure uncc'ing yourself is the best move there, as if someone does a drive by review you won't receive email 08:01:52 <flo-retina> I guess that mostly depends on Mic's schedule 08:02:36 <flo-retina> ah, no, you are still the assignee, right? :) 08:02:54 <nhnt11> flo-retina: Yes, that's why I un-cc'd 08:03:08 <nhnt11> I checked the email settings, looks like being an assignee results in emails for all updates 08:22:39 --> gerard-majax__ has joined #instantbird 08:28:34 --> jb has joined #instantbird 08:41:31 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 08:44:40 <-- Optimizer has quit (Ping timeout) 08:47:59 --> Optimizer has joined #instantbird 08:54:26 --> Mic has joined #instantbird 08:54:26 * ChanServ sets mode +h Mic 08:54:51 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 08:59:23 --> aleth has joined #instantbird 08:59:23 * ChanServ sets mode +h aleth 09:05:05 * aleth wonders if he broke nightlies :-S 09:05:56 <aleth> Oh no, a typo :( 09:06:19 --> gerard-majax_ has joined #instantbird 09:06:48 <-- gerard-majax__ has quit (Ping timeout) 09:16:01 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2511 on bug 1973. 09:16:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, 1.5, aleth, RESO FIXED, Concatenated logs don't work for buddies and contacts 09:17:33 --> flo-retina has joined #instantbird 09:17:33 * ChanServ sets mode +qo flo-retina flo-retina 09:18:48 <flo-retina> ah, too bad I haven't looked at the log / my bugmail before trying to update my nightly 09:19:01 * flo-retina has just done the same thing as https://bugzilla.instantbird.org/attachment.cgi?id=2511 09:19:45 <instantbot> florian@instantbird.org granted review for attachment 2511 on bug 1973. 09:19:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, 1.5, aleth, RESO FIXED, Concatenated logs don't work for buddies and contacts 09:22:47 * flo-retina wonders if aleth is going to look at bug 426 again today 09:22:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 09:23:06 <aleth> flo-retina: Yes, I'll look at it in a minute 09:23:11 * nhnt11 wonders if he should've asked aleth for review 09:23:20 * nhnt11 thinks he forgot to ask aleth for feedback 09:23:22 <aleth> Though I suspect most of my comments have been dealt with in previous iterations 09:24:06 * nhnt11 wishes he could edit sent emails :( 09:25:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d9a8debfce78 - Florian Quèze - Bug 1973 - Fix bustage (add missing commas in imILogger.idl). 09:25:40 --> atuljangra has joined #instantbird 09:26:03 <nhnt11> flo-retina: Should I worry about the menu hooks for awesometab on windows? 09:26:25 --> Mic has joined #instantbird 09:26:25 * ChanServ sets mode +h Mic 09:26:32 <nhnt11> I don't have access to a Windows machine. The only Windows machine in the house is currently not in booting condition iirc. 09:27:28 <aleth> nhnt11: Ask Mic, he's on Windows ;) 09:31:16 <Mic> nhnt11: what do you use to test your tabbrowser changes? 09:31:16 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:31:24 --> nhnt11 has joined #instantbird 09:31:34 <nhnt11> :) 09:31:39 <nhnt11> I'll be back after lunch 09:31:59 * aleth hopes clokep can review the /about patch so it can land with the main one 09:32:07 <Mic> nhnt11: wait 09:32:19 <Mic> nhnt11: what do you use to test your tabbrowser changes? 09:32:33 <nhnt11> aleth: I need to upload a new patch for that. Small change needed to make it focus the tab after opening 09:32:51 <aleth> nhnt11: You forgot the focus method? :D 09:32:51 <nhnt11> Mic: What do you mean? I'm on Mac and I use the about pages to test. I also sometimes add panels from error console. 09:33:15 <aleth> nhnt11: That should have thrown some errors in the error console, right? 09:33:15 <nhnt11> aleth: tabbrowser.selectedTab = panel.tab ;) 09:33:28 <Mic> OK. 09:33:37 <-- gerard-majax_ has quit (Connection reset by peer) 09:33:38 <nhnt11> aleth: What should've thrown errors? 09:33:40 --> gerard-majax__ has joined #instantbird 09:33:46 <aleth> nhnt11: Forgetting the focus method. 09:33:59 <nhnt11> aleth: Nope. It just opens a new tab but you have to switch to it manually. 09:34:01 <aleth> But I see you selected the tab "by hand" so it's not relevant 09:34:08 <nhnt11> Yeah 09:34:33 <nhnt11> Mic: Was there a specific reason you asked what I used to test? 09:34:47 <aleth> I wonder if abstracting that would be useful (a method that selects a tab (i.e. switches to it, calls focus and onSelect) 09:35:05 <nhnt11> Fwiw, I haven't seen any errors from what I've tested with the current code. 09:35:08 <Mic> nhnt11: no 09:35:19 <Mic> Not an important one at least. 09:35:43 <aleth> I ask because it sounds like you are duplicating code from imWindows 09:36:14 <nhnt11> aleth: No, I haven't used anything from imWindows. 09:36:24 * nhnt11 checks imWindows quickly to see what aleth is talking about 09:36:49 --> qlum has joined #instantbird 09:36:56 <nhnt11> aleth: If you mean the method in focusConversation, no. 09:36:59 <aleth> The line you quoted sounded like http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#78, and what's missing is what follows that line 09:37:18 <nhnt11> Ah right. I don't think those lines are required, honestly. 09:37:25 <aleth> OK 09:37:28 <nhnt11> I left them there because I didn't want to change functionality 09:38:03 <nhnt11> Hmm I need to investigate this further 09:38:23 <nhnt11> I thought it was taken care of in the DOMAttrModified event for the tab ("selected" attribute) 09:38:36 <nhnt11> Looks like it's not. Only when the attribute is removed, switchingAway is called. 09:38:43 <aleth> I guess I'll see from your patch what the difference is ;) 09:39:45 <nhnt11> Setting selectedTab has worked for me so far, though. 09:40:03 <aleth> Btw in case you were wondering, the purpose of this line http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#80 is to focus the *window* (ie bring it to the front if it isn't already) 09:40:47 <nhnt11> Yep, thanks. 09:42:19 <nhnt11> aleth: When a tab is selected, its linked panel is automatically focused. This means taking onSelect() out of conversation's focus method could be problematic 09:42:39 <aleth> I don't understand 09:43:10 <aleth> You are saying the focus method gets called automatically? 09:43:13 <nhnt11> Yes. 09:43:30 * nhnt11 is confusing himself now 09:43:32 <aleth> That can't be true when scrolling through the tabs with the keyboard 09:43:48 <flo-retina> nhnt11: I don't understand this question "Should I worry about the menu hooks for awesometab on windows?" 09:44:05 <nhnt11> flo-retina: I meant, should I worry about getting them to work on Windows, since I can't test. 09:44:46 * nhnt11 will be back with some lunch 09:49:14 <flo-retina> I guess I still don't understand that question 09:49:58 <aleth> flo-retina: Anything in particular you wanted me to look at in that patch? 09:50:00 <flo-retina> I don't see anything OS specific about the awesomebar; Windows and Linux would work the same there; and Mac too for almost everything 09:50:39 <flo-retina> aleth: not really, I had just noticed that there was a f? on you on the patch I r-'ed yesterday, so I figured nhnt11 was still expecting some input from you; I didn't know what though 09:50:54 <flo-retina> aleth: so *I* guess I just want to know if you are happy with it 09:51:32 <instant-buildbot> build #406 of macosx-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/406 blamelist: Florian Qu?ze <florian@instantbird.org> 09:51:55 <aleth> another typo?! 09:52:36 <flo-retina> aleth: just the usual Mac onCommit failure 09:52:40 * flo-retina would like us to fix that 09:52:46 <aleth> oh OK :( 09:52:59 <flo-retina> it's a one liner 09:53:14 <aleth> You discovered the cause? 09:53:55 <flo-retina> aleth: sure, https://bugzilla.instantbird.org/show_bug.cgi?id=1587#c5 09:54:00 <instantbot> Bug 1587 min, --, 1.5, clokep, REOP, Re-sync build scripts with comm-central 09:54:45 <Mic> nhnt11: the error "Not a valid about page." should repeat the name of the page that the user tried to access in my opinion. 09:58:47 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 09:59:27 --> atuljangra1 has joined #instantbird 09:59:38 * atuljangra1 is now known as atuljangra 10:03:20 <nhnt11> Mic: Noted. 10:03:40 <atuljangra> flo-retina: did you have a look at the prplIFileTransfer.idl? :-) 10:03:56 <flo-retina> did you have a look at my comments in the pastebin? :) 10:04:14 <atuljangra> nope :s 10:04:15 <atuljangra> looking 10:04:53 --> clokep has joined #instantbird 10:04:53 * ChanServ sets mode +o clokep 10:05:23 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:05:38 --> Mic has joined #instantbird 10:05:38 * ChanServ sets mode +h Mic 10:06:32 <atuljangra> flo-retina: pastebin is gone :s it was one day only. I'll create a new, one. 10:06:42 <atuljangra> I should create an etherpad instead 10:07:02 <flo-retina> the pad with the comments isn't gone though ;) 10:07:05 <flo-retina> and I assume you still have the file 10:07:15 <atuljangra> yes. Looking :) 10:07:25 <flo-retina> atuljangra: when creating pads, please give them names so that they are easy to find with the awesomebar ;) 10:08:40 <atuljangra> okay :) 10:10:40 <instantbot> benediktp@ymail.com granted review for attachment 2510 on bug 426. 10:10:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 10:10:50 <nhnt11> r+, yay! 10:11:20 <flo-retina> oooh! :) 10:11:40 <Mic> nhnt11: I thought you wanted to have lunch? :P 10:11:46 <nhnt11> Mic: I'm eating 10:11:48 <flo-retina> the likelihood of this landing today increases ;) 10:11:54 <nhnt11> Just finished, rather. 10:12:13 * nhnt11 is still hungry though... nhnt11 goes to look in the fridge. 10:13:35 <atuljangra> flo-retina: so basically I should be explaining the interface more. I'd create an etherpad with the possible calling conventions I had in mind, and then you and clokep can improve it? :s 10:14:40 <flo-retina> atuljangra: so basically, I'm not convinced this interface will let you do what you need; and I'm proposing a process to reach agreement on something usable 10:15:16 <flo-retina> what I asked you to explain is basically the stuff I would draft on paper if I worked alone on creating this interface. 10:15:52 <atuljangra> agreed. So I guess we need to spend some more time on the interface. 10:16:27 <flo-retina> We do. 10:16:59 <flo-retina> whether it needs to be done now, or at the time we review the first file transfer implementation (I guess the XMPP stuff you are starting with) is mostly up to you. 10:16:59 <atuljangra> Ok :) 10:17:14 <flo-retina> I personally prefer spending time designing the interface, and having it right (or mostly right) the first time. 10:17:33 <flo-retina> If you prefer coding something and iterating a few times to reach something usable; that's acceptable too. It's just a different workflow. 10:18:39 <atuljangra> It's a team effort, thus I'd like to go with what you and clokep find most useful. 10:20:28 <atuljangra> Regarding FILE_TRANSFER_* being redundant, I just wanted to have naming conventions correct for file transfer type. If we use the DOWNLOAD_*, then I suspect some inconsistency issues :s 10:20:50 <flo-retina> If I could just find a block of 3 hours of spare time to focus on it and think carefully about it, I would just design an interface myself and propose it, so that you can start coding implementations very soon. But realistically, given my current review queue, the amount of work I have to do in my house and the amount of work I have to do for my day job, I can't promise it will happen soon. 10:21:18 <clokep> flo-retina: So I'm trying to run xpcshell tests under just toolkit/modules/test/xpcshell tests and I can't seem to find the right incantation. 10:22:01 <atuljangra> flo-retina: I understand your situation. It's perfectly fine. I'd just create interface and keep proposing. You just review it :) 10:22:03 <flo-retina> atuljangra: even if you redefine them so that the names are consistent and all start with FILE_TRANSFER_ in your code, I think it would be useful to make them similar (have the same name after the prefix if what we need is the same, and have the same integer value). 10:22:37 <atuljangra> flo-retina: oh okay, will do so. 10:23:40 <flo-retina> atuljangra: ok 10:25:40 * atuljangra will be back in 20 mins. Going for lunch. 10:25:50 <atuljangra> only if they have some left :-/ 10:25:55 <-- atuljangra has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 10:26:01 <nhnt11> And I thought I had my lunch late... 10:26:02 --> atuljangra has joined #instantbird 10:26:04 <-- atuljangra has quit (Quit: atuljangra) 10:29:41 <flo-retina> it really looks like we are all on the same timezone ;) 10:29:49 * flo-retina is thinking about lunch too :-P 10:30:31 * clokep is thinking about breakfast. :P 10:33:04 <aleth> What's the link to atuljangra's etherpad again? I can't find it in my awesomebar :-/ 10:33:35 <nhnt11> aleth: https://etherpad.mozilla.org/e3uXWiSXhL I think 10:37:51 <-- flo-retina has quit (Ping timeout) 10:38:03 <-- jb has quit (Quit: jb) 10:38:07 --> jb has joined #instantbird 10:38:12 --> flo-retina has joined #instantbird 10:38:12 * ChanServ sets mode +qo flo-retina flo-retina 10:39:55 <aleth> Looks like we're all asking for the same thing there... 10:43:10 <Mic> bye 10:43:27 <nhnt11> flo-retina: Oh about that question that you didn't understand. I was talking about the menu item that spawns an awesometab. 10:43:28 <nhnt11> Bye Mic 10:44:12 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:48:40 <nhnt11> aleth: Tabbrowser has a selectTabAtIndex method as well, which only sets the selectedTab property and leaves it at that 10:49:08 <nhnt11> I'm not sure if your suggestion should be done in a new ubg 10:49:09 <nhnt11> bug* 10:49:11 <aleth> nhnt11: I would only suggest adding the new method if it is clearly useful (eg for the about panel) 10:49:43 <aleth> It would do more than selectTabAtIndex (as it ensures the window and tab are focused). 10:50:16 <aleth> It's possible it should be part of the about panel bug if it fits better there 10:50:25 <nhnt11> Yes, I understand what it should do. I was trying to point out something else which I now realize is kind of irrelevant. 10:50:37 <nhnt11> Hmm. I'm not sure it fits there either. 10:51:01 <aleth> It would make sense in bug 426 if you agree it is a good idea. 10:51:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 10:51:12 <aleth> It's existing code after all (just generalized) 10:51:15 <nhnt11> Right 10:54:38 <clokep> aleth, nhnt11: I'll try to do that review today, es. 10:54:45 <clokep> aleth: Although you can steal it if you really want. 10:54:57 * aleth doesn't want ;) 10:56:23 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 11:05:31 --> atuljangra has joined #instantbird 11:05:48 * atuljangra back 11:11:24 <aleth> atuljangra: Maybe a quick hand-drawn sketch would be useful to show how you imagine the various parts of the code interacting? 11:11:58 <atuljangra> aleth: yes, working on that. :) 11:14:12 * nhnt11 needs coffee 11:17:08 --> mpmc has joined #instantbird 11:22:59 <atuljangra> aleth: you are in which timezone? :) 11:23:21 <aleth> atuljangra: Same as flo and Mic 11:23:36 <atuljangra> French? 11:23:43 <aleth> Italy 11:23:58 * atuljangra so wants to see Italy. 11:24:40 * nhnt11 thought aleth was from England? 11:24:52 * aleth wouldn't mind seeing India either ;) 11:25:28 <atuljangra> haha :P come to India. I've traveled a lot here. I'll be your guide ;) 11:25:30 <aleth> nhnt11: England is GMT (one hour difference) 11:25:49 <aleth> I guess this is #chatdev stuff... 11:55:57 --> clokep_work has joined #instantbird 11:55:57 * ChanServ sets mode +o clokep_work 12:04:05 <atuljangra> flo-retina: my draft of the interface: https://etherpad.mozilla.org/FileTransferInterface Currently making changes to it, to allow for listeners/observers 12:04:41 <atuljangra> flo-retina: Also, start, ackReceive and requestRestart will work as follows. 12:04:56 <atuljangra> We'll have a start function in the imIAccounts.idl 12:05:07 <atuljangra> (which will be called by drag and drop event) 12:05:16 * clokep_work is unsure what all the acking is about. :-/ 12:06:24 <atuljangra> which inturn will call a similar function in prplIAccounts.idl and which will finally get the transfer started by using the prplIFileTransfer functions. 12:06:43 <flo-retina> atuljangra: so why does that interface needs a start method? Isn't the transfer starting automatically when the start method of prplIAccount creates an instance of prplIFileTransfer? 12:07:23 <atuljangra> clokep_work: in xep-0047, receiver has to send an acknowledgement to the sender, that he is ready to receive before the actual transfer takes place 12:07:31 <atuljangra> and thus acking is requied. 12:08:36 <atuljangra> flo-retina: I'm not sure. Establishing the connection will be done in start method of prplIFileTransfer 12:10:38 <aleth> atuljangra: flo means you can use the constructor as a start method 12:11:26 <atuljangra> aleth: oh okay. Yes, we can eliminate start method, but restart and others would still be needed? 12:12:35 <aleth> When would you call 'restart'? 12:12:44 <aleth> Is that 'resume'? 12:13:48 <aleth> Is this just for if the user pauses a file transfer? Do we actually want to add UI for that (isn't 'cancel' enough)? 12:14:36 <atuljangra> if something happened and the sender got disconnected, then when he reconnects we should notify him about the remaining file transfer and he should be able to *restart* it. Resume won't work here, as connected is destroyed by this time. 12:15:17 <atuljangra> pause() and resume() are inherited from nsIDownload 12:15:59 <aleth> OK, thanks. Then what I'm asking is whether this should be automatic (should we just automaically restart on reconnect if it didn't complete successfully) 12:16:55 <atuljangra> Ok :) I guess a notification should be there, and if he wants to restart he can or he can just cancel 12:18:17 <clokep_work> atuljangra: What? :-S 12:18:21 <clokep_work> That doesn't make any sense. 12:18:28 <clokep_work> We shouldn't annoy the user with things he doesn't care about. 12:18:43 <flo-retina> clokep_work: like kitten picture transfer? ;) 12:18:53 <clokep_work> Yes, those should go to /dev/null automatically. :P 12:19:10 <atuljangra> oh okay. So no restart() required? 12:19:29 <nhnt11> Lol, cats. 12:19:32 <clokep_work> atuljangra: Yes. 12:19:40 <atuljangra> clokep_work flo-retina and what about requestrestart()? 12:19:41 <clokep_work> Besides which, some protocols actually will let you resume on different socks. 12:19:50 <clokep_work> sockets, not socks. 12:22:00 <atuljangra> clokep_work: oh okay. 12:22:00 <clokep_work> nhnt11: Ping 12:22:14 <nhnt11> clokep_work: pong 12:22:23 <clokep_work> nhnt11: Bug 2002, can you describe to me What's happening the last ~ 40 lines of the patch. 12:22:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 12:22:35 <clokep_work> (Starting at |let win = Services.wm.getMostRecentWindow("Messenger:convs");|) 12:22:47 <clokep_work> I think I see what is happening, but I want to make sure. :) 12:23:01 <aleth> atuljangra: Where will the "generic" part of file transfer live? i.e. if a protocol has no specific implementation, or the transfer fails, or we are in a MUC, how does it fall back to filelink? 12:23:10 <clokep_work> aleth: We *DO* send IRC pings. 12:23:34 <aleth> clokep_work: That's what I thought! But can you see them his logs? 12:24:00 <nhnt11> clokep_work: It tries to add the tab to the most recent conversation window. if (!win || !showPage()) - First it checks that win exists, then tries to add the tab. Adding the tab can fail if the tabbed conversations pref is disabled. If the window didn't exist or adding failed, it opens a new window and adds the tab to that. 12:24:41 <clokep_work> aleth: Something is going wrong there, I don't know what it is. 12:25:23 <atuljangra> aleth: me and clokep_work was thinking of using the getCurrentStatus() method. If download has failed then we try to send the same file over filelink, but as clokep_work said, flo-retina has something better in mind. 12:25:46 * clokep_work still doesn't think polling the status is a good idea. 12:27:03 <atuljangra> clokep_work: oh okay. We can do something else then. Do you have any specific thing in mind? 12:27:28 <instantbot> clokep@gmail.com denied review for attachment 2509 on bug 2002. 12:27:29 <clokep_work> Listeners, as I suggested previously. 12:27:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 12:29:33 <atuljangra> clokep_work: okay. I'm still figuring out how to implement listeners in prplIFileTransfer.idl 12:29:48 * atuljangra will keep the MoPad posted 12:29:50 <nhnt11> clokep_work, flo-retina: I don't know if we should create the string bundle when the script is loaded. 12:30:10 <nhnt11> I'll do whatever you think is better. 12:30:39 <nhnt11> (That's in response to "I find it strange that we create this bundle three times...", btw) 12:30:58 <clokep_work> Yes, you ignored that comment in my previous reviews. :( 12:31:06 <nhnt11> clokep_work: Not exactly. 12:31:23 <nhnt11> I just didn't know what to do, and kept it low priority 12:31:58 <flo-retina> nhnt11: neither addressing it nor asking a question is ignoring ;). 12:32:16 <nhnt11> -_-' 12:32:17 <aleth> Ignoring is pretty low priority I guess ;) 12:32:24 <flo-retina> :-D 12:32:54 <atuljangra> flo-retina clokep_work aleth feel free to modify the MoPad. That would only help me :s ;) 12:33:16 <clokep_work> atuljangra: http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#61 12:33:34 <clokep_work> atuljangra: It will be better if you ask questions about what you don't understand, what seems confusing , etc. 12:33:48 <atuljangra> clokep_work: cool :) 12:35:40 <nhnt11> clokep_work, flo-retina: Okay so should I create a variable or just let it create the bundle at three different places? 12:36:05 <clokep_work> nhnt11: I'd prefer a variable, but I think flo-retina had some reason for not wanting that. 12:36:15 <nhnt11> clokep_work: The lazy getter? 12:36:40 <clokep_work> nhnt11: That's unrelated IMO. 12:36:55 <clokep_work> atuljangra: So I think if you start working on the XMPP file transfer it will allow you to iterate on the interface more. 12:37:00 <nhnt11> clokep_work: flo-retina didn't want me to keep the final string in a variable, not the bundle. 12:37:01 <aleth> atuljangra: What are proposing to add to the account IDL? 12:37:43 <clokep_work> nhnt11: OK? 12:38:00 <flo-retina> nhnt11: iirc I didn't want the bundle to be opened at startup if none of the strings in it are going to be used 12:38:23 <atuljangra> clokep_work: flo-retina suggested me to work on interface more so that I've the interface almost completed before implementing anything 12:38:30 <clokep_work> flo-retina: Can't we do something like http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircUtils.jsm#12 12:39:12 <atuljangra> aleth: basically a method that will initiate the fileTransfer from the drag and drop event 12:39:44 <flo-retina> atuljangra: I think I suggested that you can do the opposite: ie start implementing stuff in XMPP, and see where the interface doesn't work for you. 12:40:10 <flo-retina> clokep_work: that would be fine, yes 12:40:34 <atuljangra> oh okay. I misunderstood. sorry. I should start implementing. 12:40:36 <aleth> atuljangra: So basically the idea is you pass it a file enumerator, and it then creates the prplFileTransfer instance(s)? 12:40:42 <-- jb has quit (Ping timeout) 12:40:51 <atuljangra> aleth: yes. 12:41:26 <aleth> OK :) 12:43:19 <flo-retina> clokep_work: actually, I'm not even sure it makes sense to cache the result of l10nHelper 12:44:11 <clokep_work> flo-retina: OK. 12:44:16 <clokep_work> nhnt11: I guess that's fine then. 12:44:30 <clokep_work> But yes, please either fix what we give in review comments or reply at least why you're not. :) 12:44:50 <nhnt11> clokep_work: Sorry. I did intend to ask you about that soon. 12:45:09 <nhnt11> I wanted to get the feature fully functional and then address the review comments. 12:45:16 * nhnt11 shouldn't have asked for review. 12:45:22 <clokep_work> nhnt11: No problem! 12:46:09 <nhnt11> Okay, so I'm leaving the string bundle stuff as it is now. 12:46:34 <clokep_work> Sounds good. :) 12:46:38 <clokep_work> Looks like just nits then! 12:46:50 <nhnt11> clokep_work: Also it needs to focus the newly opened tab ;) 12:46:50 <-- Optimizer has quit (Ping timeout) 12:47:37 <flo-retina> clokep_work: here is how I would handle it: http://pastebin.instantbird.com/230666 12:48:16 <clokep_work> nhnt11: ^ 12:48:19 <flo-retina> I was starting to type explanations about it, and figured a diff would make much more sense 12:48:37 <nhnt11> flo-retina: Cool, I'll do that. 12:49:01 <flo-retina> clokep_work: does that diff address your concerns? 12:49:05 <nhnt11> flo-retina, clokep_work: I wouldn't call it bundle though. There are other properties files that ibCore uses. 12:49:09 <clokep_work> flo-retina: Yes. 12:49:29 <nhnt11> clokep_work, flo-retina: Would coreBundle be acceptable? 12:49:31 <flo-retina> nhnt11: you can to all it coreBundle? 12:49:36 <nhnt11> Cool. 12:49:50 <flo-retina> nhnt11: I think we usually use just "bundle" for the bundle whose name matches the name of the current code file 12:49:58 <flo-retina> so either bundle or coreBundle would be fine with me. 12:50:00 <nhnt11> Ah okay. 12:50:06 <clokep_work> I agree. 12:50:19 <flo-retina> clokep_work: cool (even though I don't know what you agree with) 12:50:36 <nhnt11> I'm currently addressing Mic's comment about including the page URL in the invalid page error message. Should I put a space at the end of the localized string or append a space in code? 12:51:00 <aleth> nhnt11: You put %S in the localised string ;) 12:51:02 <flo-retina> both sound wrong 12:51:04 <flo-retina> you want a formatted string 12:51:07 <nhnt11> ("Not a valid about page:<space>about:page") 12:51:07 <flo-retina> (as aleth just said) 12:51:27 <clokep_work> flo-retina: "bundle or coreBundle would be fine with me" :) 12:51:30 <nhnt11> Right, so in the localised string. 12:51:33 <flo-retina> clokep_work: :) 12:52:02 <clokep_work> nhnt11, aleth: How about "%S is not a valid about page."? 12:52:03 <nhnt11> My only qualm with putting it in the localised string isthat if someone forgets the space while translating it will look like "Not a valid page:about:page" which looks bad. 12:52:06 --> jb has joined #instantbird 12:52:08 <-- jb has quit (Excess Flood) 12:52:11 <nhnt11> Oh. like that. 12:52:18 --> jb has joined #instantbird 12:52:24 * nhnt11 misunderstood what %S does, he thinks 12:52:39 * clokep_work likes full sentences. 12:52:45 <clokep_work> And generally people overuse colons. 12:53:26 <nhnt11> I like full sentences too, but usually invalid URLs are reported like that from what I've seen. (URL not found: <url>) 12:53:35 * aleth thinks the overuse of colons come from "blablabla"+variable printf habits 12:54:00 <nhnt11> May 12:54:02 <nhnt11> Maybe* 12:54:05 <atuljangra> Can I create a dummy conversation somehow? for testing purposes? 12:54:40 <clokep_work> atuljangra: The null prpl if you have a debug build. 12:54:59 <clokep_work> nhnt11: In that case the string would be "Not a valid about page: %S." 12:55:09 <nhnt11> clokep_work: Got it. 12:55:16 <clokep_work> You can't just append the URL in code, it has to be done with the %S. 12:55:32 <clokep_work> Because in language foobar that might be "Foo %S baz foo bar." 12:55:37 <atuljangra> I've a debug build. 12:55:56 <nhnt11> clokep_work: Got it. 12:56:07 <flo-retina> clokep_work: shouldn't we put quotes around the string the user entered? 12:56:08 <clokep_work> atuljangra: You should be able to create an account with the null prpl, add someone to your buddy list and open new conversations. 12:56:16 <clokep_work> flo-retina: Probably. :) 12:56:50 <nhnt11> clokep_work, flo-retina: | aboutCommand.invalidPageMessage="%S" is not a valid about page. | 12:57:04 <flo-retina> clokep_work: the null prpl is debug-builds-only 12:57:10 <flo-retina> nhnt11: yes 12:57:55 <clokep_work> flo-retina: atuljangra just said he has a debug build. 12:58:08 * flo-retina hides 13:01:11 <clokep_work> :) 13:02:24 <aleth> atuljangra: It might also be useful to look at how the FX nsIDownload instances communicate with the download panel 13:02:47 <atuljangra> aleth: yes, actually I was studying that only 13:03:06 <atuljangra> That will help me to see the communication pattern and use it here 13:03:46 <aleth> And if we can reuse some of that panel in the UI later, so much the better ;) 13:03:50 <nhnt11> clokep_work, flo-retina: Do these comments look good? http://pastebin.instantbird.com/230678 13:03:55 <atuljangra> aleth: hehe :P 13:03:56 <aleth> It seemed to take them (mconley?) a long time to get it right... 13:04:05 <atuljangra> yes mconley 13:04:08 * clokep_work wonders when qheaden will get up. 13:04:31 <flo-retina> clokep_work: tomorrow? :-P 13:04:58 <clokep_work> nhnt11: LOoks good to me, yes. :) 13:04:59 * nhnt11 's sleep schedule is actually back to human, he's been getting up by 8am consistently ^^ 13:05:24 <flo-retina> line 10 won't work 13:05:37 <flo-retina> but I assume you are going to rewrite that after applying the diff I pastebined 13:06:06 <nhnt11> flo-retina: I am, but why won't it work? 13:06:18 <flo-retina> you forgot the parameter giving the length of the array 13:06:31 <aleth> flo-retina: Is line 32-34 safe? 13:06:39 <flo-retina> the getFormattedString API sucks ;) 13:06:59 <nhnt11> flo-retina: https://developer.mozilla.org/en-US/docs/XUL/Method/getFormattedString 13:07:04 <nhnt11> Doesn't look like I need any more parameters. 13:07:05 <clokep_work> That's why we have l10nHelper. :) 13:07:28 <flo-retina> nhnt11: alright, I didn't notice that mistake :-P 13:07:52 <flo-retina> you wrote instead getFormattedString of formatStringFromName 13:08:06 <flo-retina> (assume the word "instead" is at the correct place in that sentence please) 13:08:13 <flo-retina> aleth: what's your concern? 13:08:25 * nhnt11 is confused. 13:08:47 <aleth> flo-retina: That the load event listener will be added after the load event is fired 13:08:58 <flo-retina> nhnt11: the documentation you linked to is for the XUL <bundle> DOM element. You are not using that. 13:09:14 <nhnt11> flo-retina: I just opened nsIStringBundle and did a facepalm. 13:09:21 <nhnt11> The documentation for it I mean. 13:09:25 <flo-retina> aleth: the load is async, so that's not possible. 13:09:39 <flo-retina> nhnt11: see why we have l10nHelper? ;) 13:09:39 <aleth> flo-retina: great, just checking :) 13:09:43 <nhnt11> Yeah. 13:10:17 <flo-retina> nhnt11: "This fails if tabbed conversations are disabled" isn't really correct 13:10:28 <flo-retina> it would throw if it failed 13:10:53 <nhnt11> flo-retina: s/fails/doesn't work? 13:10:59 <flo-retina> returning false here means that the window can't accept the panel for some reason (could be that the window is limited to some conversations like MUCs, that it's full, whatever...) 13:11:24 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:11:35 <nhnt11> flo-retina: How about "Return false if tabbed conversations are disabled." 13:11:43 <flo-retina> still wrong 13:12:05 <nhnt11> flo-retina: It has nothing to do with MUCs and being full. 13:12:10 <flo-retina> "// Return false if the window can't accept this panel." 13:12:18 <nhnt11> It's solely due to the "tabbed conversations" pref is disabled. 13:12:32 <nhnt11> flo-retina: That sounds too generic. There's only one case. 13:12:44 <flo-retina> nhnt11: http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#405 13:12:51 <nhnt11> flo-retina: You're forgetting my patch. 13:13:13 <nhnt11> addPanel doesn't care about MUCs. addConversation does. 13:13:21 <flo-retina> do you mean you broke this generic mechanism while making stuff more generic? :-o 13:13:32 <flo-retina> doesn't addPanel just call addConversation? 13:13:40 <flo-retina> ah, no it's the other way around :-S 13:13:41 <nhnt11> flo-retina: addConversation calls addPanel. 13:13:58 <nhnt11> addConversation checks the MUC thing. addPanel checks tabbed conversations. 13:14:08 <nhnt11> I think this makes sense, but if you don't, I can change it. 13:14:26 <flo-retina> nhnt11: I still think add-ons could disable opening more panels in an existing window 13:14:57 <nhnt11> So? 13:15:03 <nhnt11> Ah 13:15:07 <nhnt11> So you're saying there could be another reason 13:15:09 <flo-retina> I still prefer "// Return false if the window can't accept this panel." :-P 13:15:52 <nhnt11> How about "// Return false if the window can't accept the panel (e.g. if tabbed conversations are disabled)" 13:15:52 <nhnt11> :P 13:16:03 <nhnt11> If I read that code, I would wonder why it couldn't accept. 13:18:00 <flo-retina> yes, that's better 13:19:59 <nhnt11> flo-retina: I like this better: Try to add the panel, and return false if the window couldn't accept it (e.g. tabbed conversations are disabled). 13:20:10 <flo-retina> ok 13:20:22 <atuljangra> libpurple is not threadsafe right? (just wondering) 13:23:55 <flo-retina> atuljangra: that's right 13:24:06 <flo-retina> atuljangra: and pidgin developers pretend it's not threaded at all. 13:24:08 <nhnt11> flo-retina: How would I use bundle(...) from the command? this.bundle wouldn't work. Should I create a variable before registering the command and use that? 13:24:23 <flo-retina> atuljangra: (although I learned the hard way that this is very clearly not true on Windows ;)) 13:24:44 <atuljangra> flo-retina: what was the hard way? :P 13:24:47 <flo-retina> nhnt11: why would 'this' not work? 13:24:54 <nhnt11> It's from a different object? 13:25:03 <nhnt11> And it's in the run callback 13:25:28 <flo-retina> atuljangra: spending a lot of time to figure out that if DNS SRV resolutions failed on Windows only, it was because the code expected a timer of 0ms to execute its callback always on the UI thread. 13:25:47 <flo-retina> atuljangra: and Mozilla timers by default execute the callback on the same thread that created the timer. 13:26:02 <atuljangra> oh okay. 13:26:11 --> Optimizer has joined #instantbird 13:26:27 <atuljangra> so all the timers were on the same thread. 13:26:42 <-- qlum has quit (Quit: Getting the <censored> out.) 13:26:43 --> qlum has joined #instantbird 13:28:20 <nhnt11> flo-retina: Ping. Do you have any suggestions for that this.bundle problem? 13:28:42 * nhnt11 wonders if he should bind() the run command, but it's still in a different object. 13:29:11 <flo-retina> nhnt11: pastebin please 13:29:13 <aleth> nhnt11: Find out what "this" is in run() 13:29:16 <clokep_work> nhnt11: You can do let t = this outside of the function and then use t instead the function. 13:29:27 <nhnt11> clokep_work: Right, that's what I was asking. 13:31:39 <clokep_work> bind works too. :) 13:32:09 <nhnt11> flo-retina: http://pastebin.instantbird.com/230699 13:32:14 <flo-retina> if "t" is a shortened version of "this", I prefer "self" ;) 13:32:29 <nhnt11> flo-retina: Isn't the convention to use "that"? 13:34:39 <clokep_work> nhnt11: No, that means something totally different. 13:34:52 <clokep_work> self works for me too. :) 13:34:54 <nhnt11> clokep_work: Okay. Self it is then. 13:35:01 * clokep_work thinks he's going to get an r- on some code he wrote last night from flo. ;) 13:35:47 --> mconley has joined #instantbird 13:36:09 <clokep_work> Ah mconley...just the man I was waiting for. ;) 13:36:43 <mconley> clokep_work: :D 13:36:45 <mconley> clokep_work: what's up? 13:36:49 <mconley> clokep_work: I saw I have a http.jsm review queued 13:36:54 <clokep_work> mconley: So I had attempted to write a couple of tests for http.jsm, but theyd on't seem to be running properly https://bitbucket.org/clokep/mozilla-central-patches/src/1fb33f849f0c9de948eaa534ca5ec4552be76ca7/http-module.diff?at=default#cl-536 13:36:57 <atuljangra> I thought you were waiting for qheaden ;) 13:37:03 <clokep_work> mconley: Ignore it for now, mossop asked me to change the API. 13:37:16 <clokep_work> mconley: It doesn't look like the server is still "active" when the tests run. 13:37:21 <clokep_work> I get an "offline" response. 13:37:33 <clokep_work> atuljangra: I'm waiting for him too. :P 13:37:37 * clokep_work waits for lots of people. 13:37:42 <atuljangra> :P 13:37:47 <mconley> clokep_work: hm 13:37:56 <aleth> clokep_work needs buddy pounce :P 13:38:10 <clokep_work> aleth: Would be useful on occasion. :) 13:38:18 * clokep_work would also like psychic mode. ;) 13:39:29 <mconley> clokep_work: so, if you block (not run tests) after server.start, can you connect to localhost:8080 with a browser? 13:41:14 --> DGMurdockIII has joined #instantbird 13:41:15 * nhnt11 has no idea what aleth and clokep_work are talking about. 13:41:56 <nhnt11> Pidgin features apparently. Hm. 13:42:24 <nhnt11> Plugins* 13:44:58 <-- mconley has quit (Connection reset by peer) 13:45:13 --> mconley has joined #instantbird 13:46:09 <mconley> clokep_work: sorry, switched APs 13:48:16 <clokep_work> mconley: I didn't try that. :( Sorry. 13:49:01 <flo-retina> uh, aleth just asked Even to update the Linux VM :). You won't be friend (or maybe he will make you create the new linux VM during the summit :-P). 13:52:21 <clokep_work> aleth what for? 13:52:26 <aleth> It seemed wrong for Even not to be cc'd on that bug now it's actually causing trouble ;) 13:53:01 <aleth> But yeah, though I don't know the details of the setup it's likely to be tons of work :( 13:53:15 <aleth> clokep_work: bug 1877 13:53:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1877 nor, --, ---, nobody, NEW, Enable gio after Linux buildslave distro is updated 13:54:23 <flo-retina> aleth: the problem with our linux story is that we try to have a build machine as outdated as possible, so that we don't introduce run time dependencies libraries found only in recent distros. 13:54:51 <flo-retina> aleth: and that also means that *everything* is outdated. So anything we need to update on there forces lots of other updates, that sometimes aren't even in the package manager 13:55:43 <aleth> flo-retina: Right, that's usually the problem with system libs, you basically have to update the whole distro :-/ 13:56:30 <aleth> flo-retina: Would it help to use whatever tweaked setup mozilla uses for their build machines? 13:57:08 <flo-retina> aleth: that's what we did 13:57:20 <flo-retina> we are using the CentOS5 build machine as described on Mozilla's wiki pages. 13:57:38 <flo-retina> aleth: the problem is, Mozilla moved to CentOS6 and nothing is documented about that new setup 13:57:51 <aleth> :( 13:57:55 <flo-retina> it seems they don't have a reference image any more, and instead deploy everything through puppet 13:57:58 <aleth> That makes it hard to copy :-/ 13:58:18 <flo-retina> aleth: we already use a mozilla-tweaked compiler btw 13:58:50 <flo-retina> I got it from a SeaMonkey developer ;). 13:59:58 <aleth> flo-retina: What do the tweaks do? 14:00:23 <flo-retina> backport a new feature to an older gcc release, so that the build doesn't fail 14:03:34 * atuljangra debug build takes much longer time than release one :-/ 14:09:57 <clokep_work> nhnt11: Yes, fun Pidgin features. ;) 14:10:32 <aleth> Though they wouldn't help much as qheaden is always already here ;) 14:17:56 <nhnt11> Someone should make clones of those for Ib :) 14:18:26 <flo-retina> nhnt11: that's in our add-on wish list 14:18:27 <clokep_work> Someone tried psychic at one point...I think we don't have the right notifications in core :( 14:18:54 <flo-retina> clokep_work: it wouldn't work for Ib users 14:19:08 <flo-retina> clokep_work: I think we purposefully don't send typing notifications if the user hasn't sent anything yet 14:20:26 <-- Optimizer has quit (Ping timeout) 14:21:40 <clokep_work> Ah, I see. :) 14:22:20 * nhnt11 has been slacking and should get back to work. 14:23:45 * clokep_work would have expected another r? by now. ;) 14:24:28 --> Optimizer has joined #instantbird 14:25:15 <nhnt11> clokep_work: I had it all ready except for one tiny thing and then got distracted, now I can't remember what that tiny thing was :] 14:26:28 <-- Optimizer has quit (Ping timeout) 14:27:00 --> Optimizer has joined #instantbird 14:27:59 <clokep_work> nhnt11: Excellent. :) 14:28:21 <atuljangra> getting |collect2: ld returned 1 exit status| while doing a debug build :-/ 14:28:29 <atuljangra> any idea anyone? 14:28:36 * nhnt11 is not sure if clokep_work is being extremely sarcastic or overly lenient. 14:29:20 <clokep_work> nhnt11: Neither. Just saying I look forward to using that patch. 14:29:25 <nhnt11> Cool. 14:29:35 <clokep_work> atuljangra: This is on Linux? Can you pastebin more of the eror? 14:30:21 <atuljangra> clokep_work: yes linux. Pastebin-ing last few lines. 14:30:46 <clokep_work> Do the last like twenty lines. :P Wherever the actual error is. 14:35:33 <atuljangra> clokep_work: http://pastebin.instantbird.com/230719 14:35:41 <atuljangra> contains insane amount of noise :P 14:36:01 <atuljangra> --------------------------------------- -> 1K lines of same INPUT(---) 14:36:17 <-- Optimizer has quit (Ping timeout) 14:38:09 <atuljangra> clokep_work: my mozconfig: http://pastebin.instantbird.com/230720 14:38:32 <flo-retina> are we building webrtc by default these days? 14:38:51 <clokep_work> I don't think so. 14:39:34 <atuljangra> can this be a source of error? 14:39:45 <atuljangra> Problem is basically while linking, right? 14:39:56 --> Optimizer has joined #instantbird 14:40:24 <-- dionisos has quit (Ping timeout) 14:42:47 * nhnt11 seems to have done something that breaks things so badly that the error console won't open 14:45:47 <aleth> did you put it in a tab? :P 14:45:52 <nhnt11> aleth: No :P 14:46:39 <-- Kaishi has quit (Quit: Kaishi) 14:47:25 <nhnt11> Is there a way to show the error console from command line? 14:47:38 <flo-retina> nhnt11: -jsconsole 14:47:43 <nhnt11> Thanks 14:47:52 <mconley> clokep_work: hey - sorry, on a work week, so I'm gonna be in and out - but did browsing to localhost:8080 work? 14:48:23 <nhnt11> Aha. The problem was a missing closing bracket. 14:48:27 <nhnt11> -_-' 14:49:25 <-- flo-retina has quit (Ping timeout) 14:49:31 --> flo-retina has joined #instantbird 14:49:31 * ChanServ sets mode +qo flo-retina flo-retina 14:51:02 <-- mconley has quit (Ping timeout) 14:51:35 <nhnt11> clokep_work: When middle clicking in an about page to open the about link in a new tab, should the new tab be focused? 14:51:40 <nhnt11> Or opened in the background? 14:53:11 --> mconley has joined #instantbird 14:54:05 <nhnt11> I think I'll make it open in the background for now. 14:59:45 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2512 on bug 2002. 14:59:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 15:02:04 * atuljangra will try to increase his swap space to resolve the issue :-/ 15:03:39 <atuljangra> flo-retina: if webrtc is not building by default, then why am I getting this? 15:04:01 <flo-retina> I was just surprised 15:04:19 <atuljangra> have you looked at my mozconfig? 15:04:45 <atuljangra> everytime error is on INPUT("../../media/webrtc/signaling/signaling_sipcc/src/sipcc/cpr/linux/cpr_linux_timers_using_select.o") 15:05:23 <flo-retina> atuljangra: yes 15:05:26 <flo-retina> I didn't see anything wrong 15:05:42 <flo-retina> but if I was annoyed by that error, I would just add --disable-webrtc and rebuild 15:05:47 <atuljangra> okay, what possibly could I've done to get to this error :-/ 15:05:49 <atuljangra> okay 15:06:00 --> mconley_ has joined #instantbird 15:07:06 * mconley_ is now known as mconley__ 15:07:08 <atuljangra> flo-retina: As for project, currently I'm implementing the xep-0047 in the xmpp/ 15:07:09 <-- mconley has quit (Ping timeout) 15:07:16 <flo-retina> ok 15:07:58 * aleth thinks |aWindow.getTabBrowser().selectedTab = panel.tab;panel.focus();| is evidence in favour of his proposal in bug 426 15:08:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 15:08:33 <atuljangra> flo-retina: hoping to complete it this week. 15:08:45 <nhnt11> aleth: I think we could just add panel.focus() to the setter for the selectedTab property 15:10:39 <-- Optimizer has quit (Ping timeout) 15:10:41 <aleth> nhnt11: That might mess up keyboard-selecting a tab (I see you can't test this unfortunately) 15:10:54 <aleth> The focus would leave the tab bar. 15:11:25 <nhnt11> aleth: Would this do? http://pastebin.instantbird.com/230756 15:11:59 <aleth> Did you actually read my comment? :-/ 15:12:31 * nhnt11 thought he did. 15:12:34 * nhnt11 double checks. 15:13:03 <nhnt11> aleth: Looks like I addressed your comment. 15:13:04 <aleth> There's code in imWindows for focusing the window too, and doing something with the dock on Mac which I don't understand but probably applies too 15:13:19 <nhnt11> aleth: That has nothing to do with tabbrowser and I don't think it belongs there. 15:13:28 <nhnt11> I don't want to add window management to tabbrowser code. 15:13:49 <aleth> OK, that makes sense. 15:14:00 <aleth> What's the dock stuff for btw? 15:14:25 <nhnt11> The rest of it is addressed in that method, and I feel that focus() and onSelect() are the main two things that may be duplicated later anyway. 15:14:26 <nhnt11> I'm not sure. 15:14:48 <aleth> Other than that I think your pastebin is fine :) 15:14:48 <clokep_work> mconley__: I'm not on that machine, I can't check any of that right now. :( 15:14:53 <nhnt11> Cool. 15:15:12 <nhnt11> aleth: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIMacDockSupport#activateApplication%28%29 15:15:23 --> Optimizer has joined #instantbird 15:15:42 <aleth> nhnt11: Ah, so window.focus is not enough on OSX 15:15:54 <nhnt11> Yeah. 15:16:01 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 15:17:12 <nhnt11> aleth: I'm going to do selectPanel(aPanel) instead. Most things will have access to the panel directly, not the tab. 15:17:25 <aleth> Sounds good. 15:17:28 * clokep_work wants interdiffs. :( 15:18:27 --> chrisccoulson has joined #instantbird 15:18:54 <nhnt11> clokep_work: Mic posted a link that works pretty well 15:19:23 <flo-retina> clokep_work: motivation for the BMO merge ;) 15:19:27 <nhnt11> aleth: I'm going to file a new bug for the selectPanel method. 15:19:27 <aleth> clokep_work: Doesn't BMO have them working? :) 15:19:54 <aleth> nhnt11: If you prefer... but it seems your about panel patch will depend on it? 15:20:02 <nhnt11> aleth: Hmm. 15:20:08 <-- Optimizer has quit (Ping timeout) 15:20:34 <-- chrisccoulson has quit (Ping timeout) 15:20:35 <nhnt11> I could just make bug 426 block the selectPanel bug, and the selectPanel bug block bug 2002 15:20:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 15:20:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 15:20:43 <clokep_work> flo-retina, aleth: Yes, I'm trying to finish that other bug first though. :( 15:20:50 <aleth> nhnt11: That would work 15:20:55 <flo-retina> the http.jsm stuff? 15:21:15 <clokep_work> Yes. 15:21:34 <aleth> nhnt11: Though it's not really a new feature, it's just that we never needed a method like that when it only ever happened for conversations ;) 15:21:41 <nhnt11> Right. 15:21:50 <nhnt11> So put it in bug 426? 15:21:57 <nhnt11> I suppose it's not too big a deal to review it. 15:21:57 <instantbot> clokep@gmail.com granted review for attachment 2512 on bug 2002. 15:22:12 <aleth> nhnt11: Yeah, I'd say put it there and make the change to imWindows and r? me on that part 15:22:46 <nhnt11> Alright. So two patches? 15:22:58 <aleth> No, just put it in the main one. 15:23:16 <nhnt11> Okay. I asked since you said r? me on that. 15:23:16 <aleth> If anyone else wants to look at the new methods they can :) 15:23:18 <nhnt11> Cool. 15:23:43 * flo-retina would like to ask questions on why that large patch needs to grow again 15:23:48 <flo-retina> but I have a meeting starting soon :-/ 15:24:06 <nhnt11> I added a check to see if the passed panel is a child of the panel container, btw. 15:24:14 <nhnt11> flo-retina: I don't want to grow it :( 15:24:31 <nhnt11> aleth: Looks like flo-retina may want to put it in a new bug too ;) 15:24:34 <aleth> nhnt11: Use a second patch in the same bug if you are worried about review cycles ;) 15:24:41 <aleth> Or a new bug... 15:25:07 <nhnt11> aleth: Since the about page bug already does it's thing without the selectPanel method and got r+'d by clokep_work just now, how about a new bug? :P 15:25:17 <nhnt11> s/it's/its 15:25:18 <aleth> nhnt11: Whatever seems easiest 15:25:22 <nhnt11> Cool. 15:25:30 <aleth> It should all land together anyway :P 15:25:50 <clokep_work> nhnt11: New bug. 15:25:58 <flo-retina> aleth: if it depends on the other 2 patches, it will land later ;) 15:25:59 <clokep_work> It doesn' tneed to all land together. 15:26:24 <aleth> clokep_work: Well, the about panels will be useful for testing ;) 15:26:48 <clokep_work> Yes, but they don't HAVE to land at once. 15:26:57 <aleth> True. 15:27:03 --> Optimizer has joined #instantbird 15:27:11 --> chrisccoulson has joined #instantbird 15:27:17 <aleth> This discussion suggests to me stuff is ready to land :D 15:27:48 <clokep_work> Is nhnt11's other bug r+ed by anyone yet? 15:27:57 <nhnt11> clokep_work: Mic r+'d it. 15:28:03 <flo-retina> clokep_work: Mic I think. And I'll look again quickly tonight 15:28:10 <flo-retina> aleth: we expected stuff to land tonight, yes 15:28:35 <aleth> nhnt11: Oh sorry, I didn't see it already had a r+. In that case definitely a new bug of course. 15:28:47 <nhnt11> Yeah, that's why I was asking. 15:31:38 <nhnt11> Instead of checking if aPanel is a child of mPanelContainer, is it fine to check that mPanelContainer is aPanel's parentNode? 15:31:40 <nhnt11> Yeah it should be. 15:31:54 * nhnt11 wonders why he would be doubtful of that. 15:32:49 * mconley__ is now known as mconley 15:35:18 <instantbot> New Instantbird (UI) bug 2012 filed by nhnt11@gmail.com. 15:35:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2012 min, --, ---, nobody, NEW, Add method to select and focus a panel in tabbrowser 15:35:32 <-- flo-retina has quit (Ping timeout) 15:35:44 --> flo-retina has joined #instantbird 15:35:44 * ChanServ sets mode +qo flo-retina flo-retina 15:38:31 <instantbot> nhnt11@gmail.com requested review from aleth@instantbird.o rg for attachment 2513 on bug 2012. 15:38:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2012 min, --, ---, nhnt11, ASSI, Add method to select and focus a panel in tabbrowser 15:39:12 <aleth> nhnt11: So this should land before or after the about panels? 15:39:16 <nhnt11> after. 15:39:17 <atuljangra> I've added --disable-webrtc in my mozconfig, but it's still building webrtc :-/ 15:39:27 <nhnt11> I just set it to depend on bugs 426 and 2002 :) 15:39:32 <aleth> nhnt11: Thanks! 15:40:09 <atuljangra> flo-retina: clokep_work any idea? 15:41:05 <instantbot> aleth@instantbird.org granted review for attachment 2513 on bug 2012. 15:41:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2012 min, --, ---, nhnt11, ASSI, Add method to select and focus a panel in tabbrowser 15:41:31 <nhnt11> :) 15:41:57 <-- gerard-majax__ has quit (Ping timeout) 15:42:17 <-- Optimizer has quit (Ping timeout) 15:42:49 * atuljangra is still stuck with --disable-webrtc 15:43:09 --> Optimizer has joined #instantbird 15:44:00 <nhnt11> atuljangra: :( 15:44:31 * atuljangra is switching to disabling debug :( 15:44:39 <clokep_work> atuljangra: Did you reconfigure? 15:44:42 <nhnt11> aleth: If aPanel.parentNode doesn't exist, will an error be thrown if we try to compare it? 15:44:56 <clokep_work> atuljangra: You're going to need to test with an XMPP account anyway. 15:45:09 <clokep_work> But you'll want to test with a non-libpurple one... 15:45:33 <atuljangra> clokep_work: yes, so should I continue with debug or not? :s 15:46:27 <aleth> nhnt11: Probably, but if aPanel isn't even a DOM element then something has really gone wrong ;) 15:47:08 <nhnt11> aleth: I was thinking about the case when aPanel hasn't been added to the DOM yet. 15:48:10 <aleth> nhnt11: If you create a DOM element it is in the DOM (belongs to a document) 15:48:27 <aleth> It may not be attached to the tree, in which case parentnode will return null 15:48:29 <nhnt11> aleth: But before it's added, it won't have a parentNode right? 15:48:33 <nhnt11> Okay. 15:48:53 <nhnt11> So parentNode always exists. cool. 15:51:31 <clokep_work> atuljangra: If you think it will be useful, but please don't waste time trying to get it to work if there's no real benefit currently. 15:51:53 --> Nirgali has joined #instantbird 15:53:01 <aleth> nhnt11: Btw that is also relevant to the awesometab - only create DOM elements when you really need them 15:53:38 <nhnt11> Okay. 15:54:05 <aleth> JS is faster and less expensive and doesn't have issues with binding attachment/detachment ;) 15:54:19 <atuljangra> clokep_work: okay :) 15:54:57 <nhnt11> Right :) 15:55:09 * aleth hates binding attachment bugs 15:55:16 * nhnt11 too. 15:55:34 <nhnt11> Bah, it's already 9.30pm. 15:56:24 <atuljangra> nhnt11: same feeling :-/ 15:59:57 <-- Nirgali has quit (Ping timeout) 16:02:46 <-- jb has quit (Ping timeout) 16:03:32 <-- aleth has quit (Quit: Ciao) 16:08:06 --> jb has joined #instantbird 16:08:07 <-- jb has quit (Excess Flood) 16:08:13 --> jb has joined #instantbird 16:09:09 --> Nirgali has joined #instantbird 16:12:25 <-- jb has quit (Ping timeout) 16:12:35 * atuljangra going for dinner and some fresh air afterwards :s 16:12:38 <atuljangra> bbye :) 16:20:54 <flo-retina> does this test |if (aPanel.parentNode != this.mPanelContainer)| work in a non-debug build? 16:21:09 <flo-retina> aleth, nhnt11: ^ ^ 16:28:19 <nhnt11> flo-retina: What do you mean, does it work? 16:28:55 <flo-retina> nhnt11: I wonder if you need !== instead of != 16:29:33 <nhnt11> flo-retina: I doubt it. Type casting or prevention of type casting doesn't really have much to do with the nature of the check. 16:30:21 <nhnt11> flo-retina: What did you have in mind? 16:30:28 <flo-retina> nhnt11: I'm just wondering if DOM nodes are compared by using the toString serialization of them 16:30:36 <nhnt11> Ah 16:30:53 <flo-retina> nhnt11: the toString serialization on a debug build includes the hex value of the pointer to the node. It doesn't on non-debug builds. 16:30:54 <nhnt11> flo-retina: They're compared using == elsewhere in that code. 16:32:14 <nhnt11> flo-retina: https://developer.mozilla.org/en-US/docs/Web/API/Node.isSameNode?redirectlocale=en-US&redirectslug=DOM%2FNode.isSameNode 16:32:24 <nhnt11> According to that, both === and == work. 16:32:30 <-- Optimizer has quit (Ping timeout) 16:33:39 <flo-retina> why do they have https://developer.mozilla.org/en-US/docs/Web/API/Node.isEqualNode ? :-S 16:34:56 <nhnt11> flo-retina: http://www.w3schools.com/jsref/met_node_isequalnode.asp 16:35:18 --> Mook_as has joined #instantbird 16:35:56 <nhnt11> flo-retina: Two identical nodes would be equal but not same. 16:36:03 <flo-retina> ok 16:37:46 --> jb has joined #instantbird 16:44:34 --> Optimizer has joined #instantbird 16:51:49 <flo-retina> clokep_work, aleth: are there strings in the stuff we need to sync with c-c in chat/? 16:52:11 <-- Nirgali has quit (Ping timeout) 16:53:30 <clokep_work> flo-retina: I'd like to say "no", but that's probably wrong. :) 16:54:12 <flo-retina> clokep_work: alright, I take that as a "who cares?" answer ;) 16:54:26 <clokep_work> flo-retina: http://hg.instantbird.org/instantbird/log/d9a8debfce78/chat/locales/en-US/irc.properties says yes. 16:55:41 --> Nirgali has joined #instantbird 16:56:03 <flo-retina> when was the last sync? 16:56:38 <clokep_work> > 9 days ago. :) 16:56:44 <clokep_work> I'm not sure. :-/ 16:57:03 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=842183 16:57:04 * clokep_work is looking... 16:57:09 <flo-retina> february 16:57:10 <flo-retina> ouch 16:57:12 <clokep_work> You beat me. :) 16:57:21 <clokep_work> Yes...there's gonna be a lot of changes. 16:57:29 <clokep_work> And I think both aleth and I landed ones that need UI changes. 16:57:39 <flo-retina> we've got 4 changesets touching chat/ strings in that time frame 16:58:08 <flo-retina> one was from c-c though 16:58:12 --> Nirgali1 has joined #instantbird 16:58:18 <-- Nirgali has quit (Ping timeout) 16:58:22 <flo-retina> we've got bug 851 bug 1732 bug 1554 16:58:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=851 enh, --, 1.4, clokep, RESO FIXED, Twitter commands 16:58:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1732 enh, --, 1.4, aleth, RESO FIXED, Port the log tree and concatenated daily logs from TB 16:58:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, 1.5, aleth, RESO FIXED, IRC should notify the user when messages couldn't be sent 16:58:50 <clokep_work> What's the concern about string changes? 16:59:36 <flo-retina> clokep_work: Tb24 will be string frozen in a few hours 16:59:49 <flo-retina> our string changes are http://pastebin.instantbird.com/230839 17:00:25 <clokep_work> Not too dramatic. :) 17:00:41 <flo-retina> 24 is the next real and esr release ;) 17:01:42 <clokep_work> Yeah... 17:01:49 <clokep_work> That's why I wanted the http.jsm stuff in it. 17:02:59 <clokep_work> I think bug 1732, and bug 1100 need matching changes in mail/? 17:03:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1732 enh, --, 1.4, aleth, RESO FIXED, Port the log tree and concatenated daily logs from TB 17:03:08 --> Kaishi has joined #instantbird 17:03:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1100 cri, --, 1.4, clokep, RESO FIXED, Use Firefox untrusted cert dialog for "SSL Handshake failed" errors 17:04:58 <-- Kaishi has quit (Ping timeout) 17:06:38 <-- jb has quit (Ping timeout) 17:08:22 --> Kaishi has joined #instantbird 17:16:34 --> mpmc has joined #instantbird 17:18:21 * nhnt11 has to go 17:18:24 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:27:31 <flo-retina> are there strings for bug 1100? 17:27:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1100 cri, --, 1.4, clokep, RESO FIXED, Use Firefox untrusted cert dialog for "SSL Handshake failed" errors 17:28:23 * clokep_work sighs. 17:28:31 <clokep_work> it just modifies account.xml, account.js, account.css. 17:28:34 <clokep_work> From instantbird/ 17:31:31 <-- Nirgali1 has quit (Connection reset by peer) 17:33:05 <atuljangra> clokep_work: I do need to make a generic filetranfer object in jsProtoHelper.jsm? 17:33:28 <clokep_work> atuljangra: Most likely, yes. 17:33:42 <clokep_work> We could always abstract stuff later, I 'pose. 17:34:24 <atuljangra> clokep_work: okay. Will work with jsProtoHelper.jsm then :) 17:35:50 --> Nirgali has joined #instantbird 17:37:41 <-- Kaishi has quit (Quit: Kaishi) 17:38:44 --> PS1 has joined #instantbird 17:40:26 <-- PS1 has quit (Client exited) 17:44:26 --> unghost has joined #instantbird 17:47:04 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:47:29 <clokep_work> atuljangra: Sounds like a plan. 17:47:44 <clokep_work> atuljangra: Btw please file a bug at some point for adding this support to XMPP. 17:47:51 <clokep_work> So you can put up a patch (soon hopefully!) 17:49:02 <atuljangra> clokep_work: will do so, when the patch is almost ready. 17:49:27 <atuljangra> clokep_work: I'm hoping to have it completed this week. 17:51:14 <atuljangra> clokep_work: while compiling, it shows: No rule to make target `_xpidlgen/prplIFileTransfer.h'. Stop. Do I need to do something else somewhere? 17:52:37 <clokep_work> atuljangra: Did you add it to the makefile? 17:52:42 <atuljangra> yes 17:52:58 <clokep_work> atuljangra: How are you building? 17:53:06 * clokep_work tries to remember if there's something special to do when adding interfaces... 17:53:10 <atuljangra> make -f client.mk build 17:53:20 <clokep_work> First of all, you don't need to rebuild Mozilla every time. 17:53:24 <atuljangra> no no 17:53:26 <clokep_work> make -C objdir tier_app 17:53:31 <atuljangra> yes, 17:53:42 <clokep_work> Can I see the file? 17:54:01 <atuljangra> but I thought that I'm adding a new interface, that may need the re-building 17:54:08 <atuljangra> which one? .idl? 17:54:22 <clokep_work> Just show the whole diff 17:54:33 <atuljangra> oh okay 17:54:48 <clokep_work> If you're not touching things in Mozilla you don't need to do a full rebuild. 17:55:09 <clokep_work> (Generally speaking.) 17:55:29 <atuljangra> cool. 17:55:43 * atuljangra was just being cautious 17:55:54 <clokep_work> Yes, but that wastes hours of time. :) 17:56:07 <clokep_work> let me know when you pastebin a diff 17:57:17 <atuljangra> http://pastebin.instantbird.com/230860 17:57:25 <atuljangra> this is not completed so :s 17:58:27 <atuljangra> clokep_work: sorry 17:58:31 <atuljangra> made a lil mistake 17:58:38 <clokep_work> atuljangra: ? 17:58:40 <atuljangra> so sorry. Fixing it. 17:59:04 <atuljangra> the name of idl file, I wrote the name in hurry so missed 'r' 17:59:06 <atuljangra> :( 17:59:19 * atuljangra rants :@ 17:59:26 <clokep_work> :( 17:59:30 <clokep_work> Hopefully that's the issue then. 17:59:36 <atuljangra> hoping so :) 17:59:52 <clokep_work> Also, please choose the file type as diff when you pastebin diffs. ;) 17:59:57 <clokep_work> http://pastebin.instantbird.com/230861 is much easier to read. 18:00:29 <clokep_work> atuljangra: Also, a nit, but please use two space tabbing. 18:01:07 <atuljangra> oh I am used to two space tabbing, but somewhere in the code, I saw four space. Thus changed it :s 18:01:28 <atuljangra> two space it is then :) 18:01:34 * atuljangra back to normal 18:01:49 <Mook_as> compromise, use 3 space! (... don't actually do that) 18:02:11 <atuljangra> hehe :P 18:04:25 <clokep_work> atuljangra: Please feel free to ask when you aren't sure, I think it'll make everything go a lot smoother. 18:04:41 <clokep_work> We do use tabs in some places (Makefiles, maybe?) 18:05:38 <atuljangra> clokep_work: yes :) I'm not used to asking stuff. So sometimes I hesitate. :s 18:05:47 * atuljangra needs to change his habit 18:25:05 <atuljangra> clokep_work: is jabber account good for testing this? :s 18:27:59 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:28:24 <atuljangra> But I guess it's a libpurple one. So :( 18:28:31 <atuljangra> clokep_work: Please suggest one :) 18:32:50 --> Nirgali has joined #instantbird 18:39:43 <-- Tonnes has quit (Connection reset by peer) 18:51:01 --> Tonnes has joined #instantbird 18:55:40 --> gerard-majax__ has joined #instantbird 19:23:46 <atuljangra> What is "_targetResource" for? 19:30:51 <atuljangra> clokep_work: I should be going now. Please answer above questions in the log, I would like to continue with it tomorrow morning :-) 19:36:07 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:48:26 <clokep_work> atuljangra: I don't know what _targetResource you're referring to. 19:48:32 <clokep_work> And you can use a GTalk account, most likely? 19:48:36 <clokep_work> Or an XMPP that isn't libpurple. 19:58:47 --> jb has joined #instantbird 20:00:47 <-- jb has quit (Connection reset by peer) 20:12:38 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 20:13:06 --> chrisccoulson_ has joined #instantbird 20:18:17 <-- chrisccoulson_ has quit (Ping timeout) 20:18:35 <-- gerard-majax__ has quit (Ping timeout) 20:20:30 <-- Optimizer has quit (Ping timeout) 20:29:12 --> Optimizer has joined #instantbird 20:31:03 --> flo-retina has joined #instantbird 20:31:03 * ChanServ sets mode +qo flo-retina flo-retina 20:31:08 <-- Optimizer has quit (Ping timeout) 20:32:34 --> EionRobb has joined #instantbird 20:37:20 --> jb has joined #instantbird 20:41:38 <flo-retina> atuljangra, clokep_work: I would just apply the patch in bug 1589 and stop wondering which XMPP account is ok for testing 20:41:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1589 enh, --, ---, nobody, NEW, Replace libpurple XMPP with JS-XMPP 20:42:00 <clokep_work> flo-retina: I didn't know we had a patch already. :) 20:42:07 <clokep_work> But that was pretty much my original suggestion. 20:44:08 --> chrisccoulson has joined #instantbird 20:56:14 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 20:59:54 --> Kaishi has joined #instantbird 21:01:59 <-- chrisccoulson has quit (Ping timeout) 21:17:14 --> chrisccoulson has joined #instantbird 21:17:57 <-- mconley has quit (Connection reset by peer) 21:18:07 <-- chrisccoulson has quit (Client exited) 21:18:18 --> mconley has joined #instantbird 21:21:02 <-- jb has quit (Ping timeout) 21:34:55 --> chrisccoulson has joined #instantbird 21:58:52 <-- Kaishi has quit (Quit: Kaishi) 22:10:11 <-- chrisccoulson has quit (Ping timeout) 22:23:42 <-- qlum has quit (Quit: Getting the <censored> out.) 22:38:32 --> wnayes has joined #instantbird 22:49:53 <-- Nirgali has quit (Ping timeout) 22:53:08 --> Nirgali has joined #instantbird 23:05:01 <-- clokep_work has quit (Ping timeout) 23:05:11 <flo-retina> clokep_work: I don't see a reason for the use of "hasOwnProperty" in the m-c patch of https://bugzilla.mozilla.org/show_bug.cgi?id=884319 23:30:30 --> florian has joined #instantbird 23:36:34 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)