All times are UTC.
00:00:34 <-- qlum1 has quit (Client exited) 00:06:08 <-- Mic has quit (Ping timeout) 00:11:06 * qheaden is now known as qheaden_away 00:39:10 <instantbot> benediktp@ymail.com denied review for attachment 2498 on bug 426. 00:39:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 00:47:42 <-- mpmc has quit (Connection reset by peer) 00:49:39 <-- chrisccoulson has quit (Ping timeout) 00:50:44 <-- wnayes has quit (Ping timeout) 00:53:57 --> wnayes has joined #instantbird 00:59:29 <-- Mook_as has quit (Quit: Mook_as) 01:09:42 <-- wnayes has quit (Quit: wnayes) 01:28:36 --> rosonline has joined #instantbird 01:35:12 --> nhnt11 has joined #instantbird 01:38:07 <nhnt11> Good morning (if anyone's around) 01:40:39 <nhnt11> Mic, flo: I notice a lot of review comments touch code that I moved and didn't modify for the sake of keeping it as untouched as possible, but you guys would rather I changed it. Perhaps I should've taken a bit more aggressive approach when making these changes. Oh well. 02:01:31 <-- rosonline has quit (Ping timeout) 02:42:41 --> rosonline has joined #instantbird 03:02:46 --> DGMurdockIII has joined #instantbird 03:07:07 <instant-buildbot> build #887 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/887 03:13:46 <-- dionisos has quit (Ping timeout) 03:30:55 <instant-buildbot> build #879 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/879 03:54:36 --> clokep has joined #instantbird 03:54:36 * ChanServ sets mode +o clokep 03:56:28 <clokep> nhnt11: I'm around. :p 03:56:41 <nhnt11> Hi :) 03:59:50 <clokep> So much to catch up on.... 04:02:20 <nhnt11> clokep: Isn't it late where you are? 04:02:25 <nhnt11> Friday night though :) 04:02:30 <clokep> nhnt11: It's midnight. 04:13:07 <nhnt11> clokep: Would you guys prefer a switch instead of if (blabla == val1) {} else if (blabla == val2) {} ? 04:13:15 <nhnt11> (I'm only checking two different values) 04:14:03 <clokep> nhnt11: It depends on the code. 04:14:14 <clokep> I generally prefer if statements unless it's like one liners inside the switch. 04:14:43 <clokep> Although in that case...I still pref if statements. :) 04:14:44 <clokep> prefer 04:14:46 * clokep is extremely tired. 04:14:56 <nhnt11> clokep: http://pastebin.instantbird.com/228962 04:15:17 <nhnt11> clokep: Okay, I'll try not to bother you then :) 04:17:19 <clokep> nhnt11: That's not what I meant at all. :-/ 04:17:24 <clokep> More of just I might not make sense. 04:17:31 <clokep> If I didn't want to be talked to, I'd sign offline. :P 04:17:58 <clokep> nhnt11: Is there anything else in this function? 04:18:02 <nhnt11> clokep: Okay. 04:18:04 <nhnt11> clokep: Yes. 04:18:12 <nhnt11> That return is redundant btw, I just removed it 04:18:29 <clokep> Looks reasonable. 04:18:36 <nhnt11> Cool. 04:19:26 <nhnt11> Would you rather I used just "if" and not "else if"? Considering the two conditions can't be simultaneously true anyway. 04:19:34 <nhnt11> (That's how it seems to be done elsewhere) 04:20:29 * nhnt11 should probably stop worrying too much about nits 04:20:33 <clokep> No, that's less efficient. 04:20:47 <clokep> By using the else we don't have to check the second conditional. 04:20:54 <nhnt11> Cool. 04:20:54 <clokep> We do that when we return early. 04:34:23 <-- rosonline has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 04:35:42 --> mconley has joined #instantbird 04:42:04 <clokep> Goodnight. 04:43:33 <nhnt11> Night. 04:44:50 <-- wuwei has left #instantbird (Leaving) 04:44:56 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 04:45:31 <nhnt11> Mic: Do you like this comment better? http://pastebin.instantbird.com/228993 05:09:19 <-- DGMurdockIII has quit (Ping timeout) 05:13:04 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 05:18:10 <-- mconley has quit (Input/output error) 05:25:09 --> nhnt11 has joined #instantbird 05:29:04 --> DGMurdockIII has joined #instantbird 05:53:29 <instant-buildbot> build #982 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/982 06:22:28 --> chrisccoulson has joined #instantbird 06:39:03 --> Kaishi has joined #instantbird 06:54:57 <-- Optimizer has quit (Ping timeout) 07:35:32 --> Mic has joined #instantbird 07:35:32 * ChanServ sets mode +h Mic 07:35:49 <Mic> Good morning 07:40:14 <Mic> nhnt11: absolutely! :) 07:40:25 <nhnt11> Morning Mic :) 07:43:20 <nhnt11> Mic: I'm about to upload a new patch, so if you were going to test the current one, you should probably wait. 07:43:30 <Mic> You could even move the comment about focus above the list of optional methods. "Panels have to implement ..." so that nobody could ever miss it. 07:43:38 <nhnt11> Okay. 07:43:38 <Mic> OK, I'll wait then. 07:44:12 <nhnt11> Mic: I'll quickly share an interdiff with you here so you can point out any glaring nits fast, is that alright? 07:44:26 <Mic> Yes 07:46:17 <nhnt11> http://pastebin.instantbird.com/229091 07:47:12 <Mic> One more thing about the comment: I forgot to say that someone new to the code might wonder what he could pass as "aPanel". Maybe clarify that too. 07:47:51 <nhnt11> Mic: Are you sure that's not obvious? It is to me. 07:48:03 <nhnt11> Considering the name of the method is "addNewPanel" ;) 07:48:07 <nhnt11> addPanel * 07:48:42 <Mic> Ah, and that's why you can pass a "conversation" element to it? :P 07:49:31 <nhnt11> :P 07:49:33 <Mic> I meant that you said something like "pass a node containing the content of the panel as aPanel" 07:49:47 <nhnt11> Okay I'll add a comment. 07:51:10 <Mic> I thought I should scan the interdiff but I didn't have time to look at the tooltip code yet so I need to look closer. 07:51:52 <Mic> I'm supposed to join others for breakfast at the moment though .. (I'd rather like keep breakfasts short:P) so I need to do that later. 07:52:07 <Mic> *I thought I could 07:52:18 <Mic> Sorry, I hope that's OK for you. 07:52:42 <nhnt11> No problem 08:42:18 --> gerard-majax has joined #instantbird 08:49:49 <-- gerard-majax has quit (Ping timeout) 08:50:50 --> Hronom has joined #instantbird 08:51:22 --> Optimizer has joined #instantbird 09:04:09 <-- Hronom has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 09:05:00 --> Hronom has joined #instantbird 09:05:09 <nhnt11> flo: Hah, I had indeed used instanceof for that check. 09:05:15 <nhnt11> Thanks for the tip. 09:12:08 <-- Hronom has quit (Client exited) 09:13:03 <Mic> nhnt11: looks good! :) 09:16:24 --> Hronom has joined #instantbird 09:17:47 --> aleth has joined #instantbird 09:17:47 * ChanServ sets mode +h aleth 09:20:49 <nhnt11> Mic: Cool 09:25:49 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died) 09:29:59 <Mic> atuljangra, qheaden_away: if one of you needs an icon for something, let me know (e.g. an upload/download version of Firefox' download icon and stuff like that) as I'm always happy to do graphics work (as long as it doesn't involve too much CSS :P). 09:30:39 * aleth always thought of Mic as the CSS expert :P 09:32:02 <Mic> haha, it's OK but it can get annoying pretty easily, that's what I meant ;) 09:32:05 <aleth> Mic: Btw, did you know about this https://developer.mozilla.org/en-US/docs/Web/API/element.dataset ? flo discovered it yesterday and it seems like it might be useful at some point 09:32:34 <Mic> THat's for accessinf data-properties? 09:32:42 <Mic> -typos 09:32:45 <aleth> Yes, but you can also write them that way 09:32:52 <Mic> *attributes 09:33:50 <aleth> I guess that's not too surprising as it wouldn't be very useful otherwise ;) 09:40:37 <Mic> Thanks for the link by the way! 09:41:05 <nhnt11> It's past lunchtime and I still haven't gotten to the about: page patch. 09:41:09 * nhnt11 gets to work. 09:42:00 <-- Optimizer has quit (Ping timeout) 09:43:51 <nhnt11> Umm scratch that 09:43:55 * nhnt11 will get to work in 15 minutes 09:44:01 <instantbot> nhnt11@gmail.com cancelled review?(florian@instantbird .org) for attachment 2498 on bug 426. 09:44:02 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2503 on bug 426. 09:44:03 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2503 on bug 426. 09:44:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 09:55:12 * nhnt11 gets to work 09:57:55 --> EionRobb has joined #instantbird 10:01:07 --> Optimizer has joined #instantbird 10:01:15 <nhnt11> Mic: Do you think addPanel should handle the "Enable tabbed conversations" preference? 10:01:30 <nhnt11> i.e. Should it check that preference, and open a new window if necessary? 10:01:50 <nhnt11> Or do we want whatever is trying to add a tab to handle that 10:02:37 <nhnt11> I wonder if aleth has any comments on this too ^ 10:03:09 <aleth> Are you asking whether "enable tabbed convs" should be changed to "enable tabs"? 10:03:20 <nhnt11> Sort of. 10:04:07 <nhnt11> I'm asking - if that change is done, then should addPanel handle it or not? 10:11:56 <-- Optimizer has quit (Ping timeout) 10:12:08 --> Optimizer has joined #instantbird 10:14:38 <-- Optimizer has quit (Input/output error) 10:17:21 --> Optimizer has joined #instantbird 10:17:46 <nhnt11> I'm going to go ahead and make a small modification that takes care of it. 10:24:21 <Mic> nhnt11: I don't have an opinion on this yet. 10:26:02 <nhnt11> Mic: I backtrack on that "go ahead and make a small modification" thing I said 10:26:06 --> dionisos has joined #instantbird 10:26:29 <nhnt11> I'm looking at this code a bit more and I think the function should try and add a tab, and if the preference doesn't allow it, return null 10:26:52 <nhnt11> Then, whatever tried to add a tab can check for null and create a new window if required 10:27:19 <nhnt11> That's how conversations are handled currently and I think we should keep it that way 10:27:41 <nhnt11> If the addPanel method does the window creating, we'll end up with one window's tab browser managing panels in another, which is gross. 10:28:49 <-- Optimizer has quit (Connection reset by peer) 10:34:51 --> Optimizer has joined #instantbird 10:37:23 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2503 on bug 426. 10:37:24 <instantbot> nhnt11@gmail.com cancelled feedback?(aleth@instantbird .org) for attachment 2503 on bug 426. 10:37:25 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2504 on bug 426. 10:37:26 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2504 on bug 426. 10:37:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 10:38:35 <-- Optimizer has quit (Ping timeout) 10:44:59 <nhnt11> Let's say I have a window "win" and I do panel = win.document.createElementNS(...); This panel isn't tied to the window's document right? If I wanted to add it to a different window "win2", I wouldn't have to do panel = win2.document.createElementNS(...) all over again, right? 10:47:28 <Mic> I don't know and I can't investigate now as I have to leave. 10:47:58 <aleth> The code for detaching/reattaching tabs should answer your question. 10:48:30 <nhnt11> aleth: It seems fine over there. 10:48:40 <nhnt11> Actually no. 10:48:46 <nhnt11> It creates a new element 10:48:52 <nhnt11> Hmm. 10:48:59 <aleth> It has to - different document. 10:49:05 <nhnt11> Right okay. 10:50:10 <nhnt11> This looks ugly: http://pastebin.instantbird.com/229200 10:50:32 <Mic> Bye! 10:50:40 <nhnt11> Bye Mic 10:50:47 <aleth> nhnt11: You could look at document.importNode 10:51:10 <nhnt11> looking. 10:51:13 <aleth> or document.adoptNode 10:51:15 <Mic> I'll be back tonight and do the review, so with a bit of luck we'll really make it by monday :) 10:51:24 <nhnt11> Mic: Awesome :) 10:51:37 <Mic> Strongly depends on flo's opinion though ;) 10:51:54 <nhnt11> aleth: Cool. That looks good 10:52:00 <nhnt11> Mic: Hah. We'll see :) 10:53:02 --> qlum has joined #instantbird 10:53:08 <nhnt11> aleth: We could probably use importNode in the tabbrowser code for importing into a new wind-*shuts up abruptly* 10:53:09 <nhnt11> :P 10:53:49 <aleth> nhnt11: It may not be problem-free for more complicated XBL elements though 10:54:08 <nhnt11> Yeah. That's why I shut up abruptly :P 10:54:41 * nhnt11 doesn't want to play with moving XBL bindings around between windows 10:55:40 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:58:47 <aleth> I've never actually looked at what adoptNode does, internally. 10:58:49 <-- EionRobb has quit (Ping timeout) 10:59:10 <nhnt11> It changes the ownerDocument, for one thing 10:59:25 <nhnt11> "Adopts a node from an external document. The node and its subtree is removed from the document it's in (if any), and its ownerDocument is changed to the current document. The node can then be inserted into the current document." -MDN, but I'm sure you've seen this :) 10:59:25 --> EionRobb has joined #instantbird 11:03:09 --> Optimizer has joined #instantbird 11:09:58 <nhnt11> Oh no 11:10:03 <nhnt11> QueryInterface is failing 11:10:13 <aleth> Why do you need it? 11:10:15 <nhnt11> Should've tested before uploading a patch... >_< 11:10:28 <nhnt11> aleth: To check if the aConv parameter to addPanel is actually a conversation 11:10:45 <nhnt11> aConv.QueryInterface(Components.interfaces.imIConversation); fails with this: 11:10:47 <aleth> Personally I wouldn't have thought that necessary. 11:10:54 <nhnt11> Error: NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 0 [nsISupports.QueryInterface] 11:11:31 <nhnt11> Yeah, I'm going to remove it. Seems unnecessary to me too. 11:12:10 <nhnt11> Oh no. I seem to have done Components.utils instead of Components.interfaces. 11:12:14 * nhnt11 facepalms 11:12:45 <aleth> It will also throw if aConv does not have a QueryInterface method ;) 11:22:24 --> gerard-majax has joined #instantbird 11:43:51 --> mpmc has joined #instantbird 11:48:10 <-- EionRobb has quit (Quit: Leaving.) 11:52:09 <-- dionisos has quit (Ping timeout) 12:27:58 <nhnt11> After Services.ww.openWindow, do I need to wait for it to load or something before I can be sure it has loaded its scripts? 12:28:32 <-- qlum has quit (Client exited) 12:29:52 <nhnt11> After let win = Services.ww.openWindow(null, "chrome://instantbird/content/instantbird.xul", "_blank", "chrome,toolbar,resizable", null); I'm getting win.getTabBrowser is not a function 12:29:57 <aleth> Almost certainly. Put stuff you want to happen on load in an onLoad event handler ;) 12:30:05 <nhnt11> Okay 12:30:12 <aleth> Even if it works on your OS you can't rely on others... 12:30:28 <nhnt11> Cool. 12:30:55 <nhnt11> Ugh. This is complicated 12:30:58 <nhnt11> :( 12:31:01 <aleth> Of course the error message you posted may have nothing to do with this problem :P 12:31:32 <aleth> What are you trying to do? 12:38:47 <nhnt11> I'm trying to load the about page in a new tab if the preference allows it, or else open a new window and open it in that 12:40:23 <aleth> isn't there code like this that exist (for conversations)? 12:41:14 <nhnt11> Yes, in the window manager 12:41:18 <nhnt11> I'm looking at it now 12:41:35 <nhnt11> Maybe it should be modified to work for generic panels. 12:41:51 <aleth> Possibly. 12:42:16 <aleth> I suppose as the first to add generic panels, you are finding out ;) 12:47:12 --> clokep has joined #instantbird 12:47:12 * ChanServ sets mode +o clokep 12:52:08 <clokep> Mic: What if the rest of us want an icon? :P 12:57:41 <aleth> What times is atuljangra here? 12:57:57 <nhnt11> aleth: I don't think that question has a constant answer 12:57:57 <nhnt11> :P 12:59:04 <clokep> atuljangra, nhnt11, qheaden_away: Don't forget to do your weekly logs, by the way, as I think they're required during the coding period? 12:59:48 <nhnt11> clokep: I plan on doing one today 13:00:05 <clokep> Just a friendly reminder. ;) 13:02:06 * nhnt11 is bored of tabbrowser 13:03:54 <aleth> You can always leave the interpretation of the "tabbed conversations" flag for other panels for a followup ;) 13:04:16 <nhnt11> aleth: I need to do it for the aboutPanel :( 13:04:56 <aleth> The aboutPanel itself seems independent of that? 13:05:33 <nhnt11> aleth: No. When the user clicks on a link to another about: page from an aboutPanel, it needs to open a new aboutPanel 13:06:30 <nhnt11> Okay, I'm not going to experiment further with the window manager 13:06:36 <nhnt11> I'll just do this manually for n ow 13:06:38 <nhnt11> now * 13:08:05 --> flo-retina has joined #instantbird 13:08:05 * ChanServ sets mode +qo flo-retina flo-retina 13:09:06 <-- Optimizer has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:10:30 <nhnt11> I have to go for a while 13:10:37 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:15:09 * clokep can't get c-c to compile at all. :( 13:19:43 <clokep> aleth: Any ideas on bug 1942? 13:20:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1942 nor, --, ---, nobody, UNCO, Irc Networks disconnect then imminently reconnect again. 13:24:35 <aleth> clokep: I was suspecting network issues once he said it also happened on freenode? 13:24:50 <clokep> OK. 13:25:01 * clokep wonders if we should more aggressively close sockets without data being sent. 13:25:05 <aleth> Do you see anything in the logs? 13:25:36 <aleth> The problem with network issues is that he claims it does not happen for all servers he is connected to at the same time 13:26:22 <clokep> Right. :-/ THat's what confuses me. 13:27:44 <flo-retina> hasn't it start happening just after changing the router or ISP? 13:34:35 <clokep> Yes, I think he said that. 13:34:48 <clokep> flo-retina: Does JS-XMPP deal with setting our user icon at all or just handling incoming icons? 13:35:40 <aleth> clokep: The only thing I can see in the logs so far is that we stop receiving PINGs for some reason. 13:35:55 <flo-retina> clokep: http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#687 13:36:17 <clokep> Ah, the sendVCard! Thank you flo-retina! 13:36:59 <flo-retina> np 13:51:11 --> Optimizer has joined #instantbird 13:56:41 --> gerard-majax_ has joined #instantbird 13:57:09 <-- gerard-majax has quit (Ping timeout) 13:59:45 <-- gerard-majax_ has quit (Ping timeout) 14:02:33 --> gerard-majax_ has joined #instantbird 14:05:19 --> qlum has joined #instantbird 14:07:44 <-- gerard-majax_ has quit (Ping timeout) 14:14:18 --> gerard-majax_ has joined #instantbird 14:16:06 <-- gerard-majax_ has quit (Ping timeout) 14:25:07 * flo-retina is writing a test for https://bugzilla.mozilla.org/show_bug.cgi?id=861454 14:25:18 <clokep> Fun, fun. :P 14:26:03 <-- Hronom has quit (Client exited) 14:36:06 <-- qlum has quit (Ping timeout) 14:36:37 <aleth> ^^ there goes bug 1942, I suspect 14:36:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1942 nor, --, ---, nobody, UNCO, Irc Networks disconnect then imminently reconnect again. 14:39:28 <clokep> ? 14:39:47 <aleth> "04:36:07 PM - qlum has left the room (Quit: Ping timeout)." 14:40:08 <clokep> Ah. 14:46:06 --> qlum has joined #instantbird 14:51:47 --> wnayes has joined #instantbird 14:52:28 <-- skeledrew has quit (Ping timeout) 14:52:46 --> skeledrew has joined #instantbird 14:56:55 --> q1t has joined #instantbird 14:57:49 --> qlum_ has joined #instantbird 15:01:48 <-- qlum_ has quit (Quit: Leaving) 15:06:05 <flo-retina> bah, my patch touches purple/ :-S 15:06:49 --> Hronom has joined #instantbird 15:07:01 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:07:13 <-- skeledrew has quit (Ping timeout) 15:07:13 --> skeledrew1 has joined #instantbird 15:07:25 <-- MMN-o has quit (Ping timeout) 15:07:31 <-- Hronom has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- q1t has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- qlum has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- Optimizer has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- flo-retina has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- clokep has quit (sand.mozilla.org gravel.mozilla.org) 15:07:32 <-- aleth has quit (sand.mozilla.org gravel.mozilla.org) 15:07:41 --> clokep has joined #instantbird 15:07:41 * ChanServ sets mode +o clokep 15:09:43 --> q1t has joined #instantbird 15:10:19 --> flo-retina has joined #instantbird 15:10:20 * ChanServ sets mode +qo flo-retina flo-retina 15:10:38 --> qlum has joined #instantbird 15:10:42 --> MMN-o has joined #instantbird 15:10:54 --> aleth has joined #instantbird 15:10:54 * ChanServ sets mode +h aleth 15:10:56 <flo-retina> clokep: http://pastebin.instantbird.com/229315 15:10:57 --> Optimizer has joined #instantbird 15:11:14 <aleth> gravel misbehaving again? 15:11:23 <flo-retina> aleth: I got disconnected at least 15:15:42 <clokep> flo-retina: Looks OK. 15:17:20 <flo-retina> :) 15:17:30 <flo-retina> I think I'll push it to comm-try 15:19:47 --> gerard-majax_ has joined #instantbird 15:25:40 --> Hronom has joined #instantbird 15:32:37 <-- aleth has quit (Quit: Ciao) 15:44:01 <flo-retina> uh, Makefile.in files are gone in comm-central :-S 15:51:15 <clokep> I can't get c-c to build at all on my machine btw. :( 15:53:30 <flo-retina> apparently mail/test/xpcshell.ini is gone 15:53:48 <flo-retina> I don't know what it's been replaced by, (or is it now fully automatic?) 15:55:33 <clokep> Fully automatic. 15:56:05 <flo-retina> alright 15:56:30 <clokep> flo-retina: https://bugzilla.mozilla.org/show_bug.cgi?id=869635 15:56:38 <clokep> I think. :-/ 15:57:56 <flo-retina> ah, mozilla24 15:58:00 <flo-retina> it's cool anyway 16:03:09 --> nhnt11 has joined #instantbird 16:04:16 <nhnt11> Hello 16:04:27 <clokep> Howdy! 16:06:29 <flo-retina> https://tbpl.mozilla.org/?tree=Thunderbird-Trunk :( 16:06:44 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:09:03 * nhnt11 just had an idea 16:09:51 <nhnt11> If tabbed conversations are disabled, why not open about pages in generic windows? i.e. Services.ww.openWindow(..., "chrome://instantbird/content/aboutPanel.xml",...); 16:10:09 <nhnt11> That would avoid waiting for the window to load before calling getTabBrowser(), and etc.. 16:11:25 <nhnt11> No, I would still need to call the showAboutPage method on the panel... sigh 16:15:18 <flo-retina> all the moz.build changesets touching chat/ sounds like they will make the c-c sync painful :-/ 16:15:52 <flo-retina> nhnt11: you could check the pref directly and openDialog(url) 16:16:21 <nhnt11> flo-retina: The problem is setting the correct about page after opening the window. 16:16:38 <nhnt11> So I /must/ add a "load" listener and do it via that 16:16:40 <flo-retina> nhnt11: you just run openDialog(url), you don't care about the window 16:16:54 <nhnt11> flo-retina: Oh 16:16:55 <nhnt11> O 16:16:55 <nhnt11> h* 16:17:58 <nhnt11> flo-retina: But that wouldn't use the code I added to make sure about: links are opened internally and others externally. 16:18:39 <nhnt11> Also after opening, if the user changed the tabbed conversations pref, it won't notice.. 16:19:00 <nhnt11> I'd rather use aboutPanel and a "load" listener. I have it working and it's not too bad, uploading a patch now. 16:20:34 <flo-retina> I'm not sure which code this is about 16:20:55 <nhnt11> flo-retina: Bug 2002 16:20:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 16:21:27 <flo-retina> nhnt11: I know which bug you are working on; I just haven't read the code recently enough to know exactly what you are looking at ;) 16:22:47 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2505 on bug 2002. 16:28:11 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2505 on bug 2002. 16:28:12 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2506 on bug 2002. 16:28:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 16:32:18 <flo-retina> nhnt11: in the run method, I see a "return" without value 16:34:05 <flo-retina> nhnt11: I think you want to call http://lxr.instantbird.org/instantbird/source/instantbird/content/instantbird.js#56 instead of hardcoding "chrome://instantbird/content/instantbird.xul" 16:35:40 <flo-retina> nhnt11: your code executed if Services.wm.getMostRecentWindow returns null doesn't use a load observer. That seems broken. 16:36:24 <flo-retina> and the Services.ww.openWindow call is duplicated. 16:37:21 <nhnt11> flo-retina: getConvWindowURL isn't available if the command is called from outside a conv window. 16:37:55 <flo-retina> fair enough :) 16:37:59 <nhnt11> Yeah I should fix that load observer. 16:38:34 <flo-retina> get rid of the code duplication 16:39:00 <flo-retina> you can just set win to null if !win.getTabBrowser().addPanel(... 16:40:04 <-- q1t has quit (Quit: Leaving) 16:40:20 <-- qlum has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 16:40:36 <nhnt11> flo-retina: "you can just set win to null if !win.getTabBrowser().addPanel(..." I don't quite understand what you mean by this 16:40:55 <nhnt11> "get rid of the code duplication" - This I do understand and am trying to do :) 16:41:46 <-- wnayes has quit (Ping timeout) 16:41:57 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2504 on bug 426. 16:41:58 <instantbot> nhnt11@gmail.com cancelled feedback?(aleth@instantbird .org) for attachment 2504 on bug 426. 16:41:59 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2507 on bug 426. 16:42:00 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2507 on bug 426. 16:42:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 16:42:48 <nhnt11> Why does it think my patch attachment is a binary file? :S 16:43:44 <flo-retina> ah, I had an idea but that duplicates the document.createElementNS call :-/ 16:44:26 <nhnt11> flo-retina: I think I have an idea 16:44:32 <nhnt11> Just a second, I want to fix this patch on bug 426 16:44:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 16:45:16 --> wnayes has joined #instantbird 16:45:31 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2507 on bug 426. 16:45:32 <instantbot> nhnt11@gmail.com cancelled feedback?(aleth@instantbird .org) for attachment 2507 on bug 426. 16:45:33 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2508 on bug 426. 16:45:34 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2508 on bug 426. 16:47:40 <nhnt11> flo-retina: Does this look good? http://pastebin.instantbird.com/229368 16:47:53 <nhnt11> There's a semicolon missing on line 14, I'll fix it. 16:48:05 <nhnt11> Ah the panel can't be created if win doesn't exist 16:48:06 <nhnt11> Hmm. 16:50:41 <nhnt11> flo-retina: If we put the createElementNS in the addPanel (and not store it in the panel variable) our problems would be gone 16:50:50 <nhnt11> Ugh, actually maybe not. 16:51:03 <flo-retina> nhnt11: it's what I had in mind, but yes, it breaks if win is null 16:51:57 <flo-retina> nhnt11: win.getTabBrowser().addPanel(panel) and panel.showAboutPage(aMsg) are duplicated, so maybe you can put that in a separate function, and the createElementNS too? 16:52:12 <nhnt11> That's what I'm trying to do right now. 16:52:49 <nhnt11> Making a function that creates the element, adds the panel, and shows the page, and use that in the listener if required or else just call it directly 16:57:07 <nhnt11> flo-retina: http://pastebin.instantbird.com/229370 16:58:03 <flo-retina> shouldn't that showPage function take a win parameter? 16:58:46 <nhnt11> Hmm right 16:58:50 <flo-retina> (I know it would work without, but that seems more confusing to read) 16:59:00 <nhnt11> Yeah 16:59:21 * qheaden_away is now known as qheaden 16:59:26 <flo-retina> also, the indent on line 13 of that pastebin looks wrong 16:59:35 <nhnt11> flo-retina: What about when it's used as a listener? It will receive the event parameter first 16:59:38 <flo-retina> the parameters should be aligned with the parameters on the previous line 16:59:42 <qheaden> Hello everyone. 16:59:58 <nhnt11> Okay. 16:59:59 <nhnt11> Hi qheaden 17:00:06 <flo-retina> ah :-/ 17:01:04 <nhnt11> flo-retina: I could make it assume that its "this" is win and do showPage.bind(win) but that would be even more confusing. 17:01:07 <nhnt11> I'd rather leave it as it is. 17:01:37 <flo-retina> or .bind(null, win) 17:01:49 <nhnt11> That wouldn't get rid of aEvent.. 17:02:06 <nhnt11> win would be passed after aEvent right? 17:02:07 <flo-retina> you wouldn't care about it any more (it would be the second parameter) 17:02:18 <nhnt11> Oh. 17:02:38 <nhnt11> That would work then. Cool. 17:04:26 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:06:30 <nhnt11> flo: I think this should be good to go: http://pastebin.instantbird.com/229373 17:08:28 <nhnt11> Ugh. IRC server problems again. 17:15:24 --> qlum has joined #instantbird 17:16:01 <-- qlum has quit (Client exited) 17:17:04 --> qlum has joined #instantbird 17:19:43 <instantbot> nhnt11@gmail.com cancelled review?(clokep@gmail.com) for attachment 2506 on bug 2002. 17:19:44 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2509 on bug 2002. 17:19:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nhnt11, NEW, Add an /about command to open the about:* pages 17:21:26 <nhnt11> I'm signing off for the night. I may be back later, but good night! 17:21:32 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:38:46 --> atuljangra has joined #instantbird 18:02:10 <-- dew has quit (Ping timeout) 18:07:51 <-- Hronom has quit (Client exited) 18:12:34 <atuljangra> instantbot: uuid 18:12:35 <instantbot> 075aeba5-9773-4f23-abcb-eea60710a06d (/msg instantbot cid for CID form) 18:12:50 <atuljangra> instantbot: Thanks :-) 18:12:51 <instantbot> np 18:30:19 <-- Optimizer has quit (Ping timeout) 18:33:53 --> Optimizer has joined #instantbird 18:34:42 <atuljangra> clokep flo-retina: see the etherpad. 18:35:06 <atuljangra> Not sure about the (Send a file) -> star thing. 18:39:32 --> nhnt11 has joined #instantbird 18:41:42 <-- wnayes has quit (Ping timeout) 18:45:11 --> wnayes has joined #instantbird 19:00:53 * nhnt11 goes to bed 19:00:55 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:01:26 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:01:41 --> clokep has joined #instantbird 19:01:41 * ChanServ sets mode +o clokep 19:04:35 --> dew has joined #instantbird 19:06:36 --> atuljangra has joined #instantbird 19:09:12 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 19:11:36 --> clokep has joined #instantbird 19:11:36 * ChanServ sets mode +o clokep 19:12:46 <clokep> qheaden: Sorry I was MIA a lot yesterday. 19:13:43 <qheaden> clokep: I didn't think you were MIA. You were fine. :) 19:15:34 <clokep> Were you able to figure out your issue yet? 19:15:37 <clokep> I can take a look. 19:16:03 <qheaden> clokep: I'm getting closer, but I did find two issues while searching. I mentioned it in yesterday's daily log. 19:16:50 <clokep> I saw them, any luck figuring them out? 19:17:27 <qheaden> Yeah, I made a couple of fixes, but I'm not committing yet because it is somewhat of a compound issue. 19:19:04 <qheaden> I'm taking care of some personal matters right now, but a little later this evening, I'm going to go back to investigating the cause of the bug. 19:20:00 <clokep> Cool. :) 19:20:02 <clokep> Good luck! 19:22:58 <qheaden> I really would like to have this sorted out before Monday, so we can start making progress again. 19:27:22 <clokep> OK. :) 19:27:27 <clokep> Please let me know if you need anything form me. 19:27:45 <qheaden> Okay. Thanks so much for the help you have given me so far. You are a great mentor. :) 19:29:32 <clokep> Thanks. :) 19:35:28 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:41:55 <qheaden> clokep: Is the IRC prpl affected by status changes in Ib? 19:44:50 <clokep> qheaden: Yes. 19:46:04 <-- dew has quit (Ping timeout) 19:46:25 <clokep> Why? 19:48:27 --> atuljangra has joined #instantbird 19:48:41 <atuljangra> clokep: Hi :-) 19:49:06 <clokep> hello atuljangra. 19:49:22 <clokep> atuljangra: Can you link me to that etherpad again? I don't have it open on this machine. 19:49:45 <atuljangra> clokep: https://etherpad.mozilla.org/e3uXWiSXhL 19:49:53 <clokep> Thanks. :) 19:50:40 <atuljangra> I've almost created the interface. Had some problem with few things, thus wanted to discuss. 19:50:54 <clokep> atuljangra: I have no idea who changed that to "start". 19:50:56 <clokep> "star" 19:51:04 <clokep> It looks like my color, but I don't think that was me. 19:51:21 * atuljangra wants to finish this by Monday, so that some progress can be made. 19:51:24 <atuljangra> clokep: oh okay. 19:51:37 <clokep> atuljangra: Ah, someone deleted a character, it''s supposed to be "Start" 19:51:50 <atuljangra> oh okay :-/ 19:52:50 <atuljangra> SO there should be a method in prplIFileTransfer.idl that would start the file transfer. 19:53:19 <atuljangra> And this method would be called from accounts? (currently if it's xmpp) 19:53:52 <clokep> atuljangra: It depends how you set it up. But that's a possibility yes. 19:53:58 <atuljangra> clokep: will be back in 1 mins, changing to 3g. 19:55:44 <-- atuljangra has quit (Ping timeout) 19:57:51 --> atuljangra has joined #instantbird 19:58:03 <atuljangra> clokep: back :) 19:58:36 <atuljangra> I've created an interface, should I show it to you? 19:58:54 <clokep> atuljangra: Sure. 20:00:20 <atuljangra> clokep: http://pastebin.mozilla.org/2553055 20:01:06 <clokep> atuljangra: prplITooltipInfo? :-S 20:01:23 <atuljangra> oh sorry. 20:01:30 <atuljangra> wait 20:02:04 <atuljangra> http://pastebin.mozilla.org/2553058 20:02:38 <clokep> transferType is a poor name, if you use something like "isDownload" it will be clear that true is a download and false is an upload. 20:02:47 * atuljangra wonders how did prplITooltipInfo came here? :-/ 20:02:52 <atuljangra> clokep: sure. Noted 20:03:51 * clokep needs to look at nsIDownload again. 20:03:53 <clokep> One second. 20:04:24 <clokep> atuljangra: So that seems fairly reasonable to start w/. 20:04:29 <clokep> I'm sure it'll need tweaking as you implement things. 20:04:44 <atuljangra> Yes, things will change as we progress. 20:05:18 <atuljangra> Please have a look at nsIDownload and see if it contains *almost* everything needed. 20:05:27 * atuljangra wants to start with implementation. 20:08:23 <clokep> atuljangra: So I can't immediately see anything else needed. 20:08:27 <clokep> At least nothing obvious. :) 20:08:56 <atuljangra> clokep: that'd be okay I guess. And we can change things later. :) 20:09:05 <atuljangra> So interface is pretty much designed for now. 20:09:27 <atuljangra> I should continue with implementing xep-0047 for xmpp now? 20:09:30 <clokep> I think you want to start doing the XMPP implementation and see what's "missing". 20:09:47 <clokep> (One thing, that might be necessary is notifying observers of changes in stat) 20:09:53 <clokep> atuljangra: That seems reasonable, yes 20:10:43 <atuljangra> notifying observers of changes in stat : I'll look into it. And will paste the link of updated interface on the etherpad. Sounds good? 20:11:02 --> chrisccoulson has joined #instantbird 20:11:07 <clokep> atuljangra: It might not be necessary for a first revision FYI. 20:11:13 <clokep> Just things to think about. 20:11:43 <atuljangra> Oh okay. Noted. 20:12:05 <atuljangra> Also, I should make the send function in imIAccount or prplAccount interface? 20:12:12 * atuljangra thinks imIAccount :s 20:14:10 <clokep> atuljangra: prplAccount is what prpls implement, imIAccount is what the UI touches. 20:14:16 <clokep> So prplAccount, since prpls need to implement things. 20:14:26 <clokep> But imIAccount might wrap that in some way. 20:14:59 <atuljangra> oh okay. Wrapping will be needed I guess, so that I can call that function while I'm dropping a file in conversation.xml ? 20:15:21 <clokep> Yes. 20:15:44 <clokep> That might also be where we take care of using FileLink? Not sure exactly how that'll go down. 20:16:42 <atuljangra> Hmm. I guess by seeing the status of the direct transfer(xep -0047), if that fails then we try to transfer it by using filelink? 20:17:32 <clokep> That's what I'm thinking, but Florian probably has a better idea of what to do with that. 20:17:58 <atuljangra> Oh okay. We'll see what Florain says. :-) 20:18:20 <atuljangra> Current goal should be to get direct transfer working, right? 20:18:21 <atuljangra> :- 20:18:50 <clokep> Yes 20:19:17 <atuljangra> Cool. :) 20:19:26 <atuljangra> Thanks for being a helpful mentor :) 20:19:57 * clokep is trying. :-/ 20:20:55 <atuljangra> I guess I would be sleeping now. Complete today's personal target. Will continue working tomorrow :-) 20:21:05 <atuljangra> clokep: you won't be available tomorrow I guess? 20:21:11 <clokep> atuljangra: I'm unsure. 20:21:31 <atuljangra> oh okay. Enjoy your Sunday 20:21:32 <atuljangra> :) 20:21:48 <atuljangra> I'll try to implement the file transfer. 20:22:27 <atuljangra> clokep: Where will you be for Summit2013? 20:22:48 <clokep> atuljangra: Toronto. 20:22:58 <atuljangra> ok :-( 20:24:39 <atuljangra> clokep: I should be sleeping now. :) Good night :) 20:24:40 <atuljangra> Thanks :) 20:26:56 <clokep> Goodnight. 20:27:13 <-- atuljangra has quit (Quit: Need some break from Moz-awesomeness! :-)) 21:13:28 --> mpmc has joined #instantbird 21:19:03 --> flo-retina has joined #instantbird 21:19:03 * ChanServ sets mode +qo flo-retina flo-retina 21:21:18 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:34:15 --> flo-retina has joined #instantbird 21:34:16 * ChanServ sets mode +qo flo-retina flo-retina 21:39:04 --> mconley has joined #instantbird 21:40:33 <qlum> So are there any advancements on the problem i am having with disconnects or anything I can do to help? 21:40:46 <clokep> qlum: I don't think so. :-/ 21:40:50 <clokep> How flaky is your internet? 21:40:55 <qlum> its great 21:41:12 <qlum> but yea it originated from switching isp and router 21:41:20 <qlum> and is the only problem I am having 21:41:42 <qlum> is there something mozilla irc does differently from most other nets as that could be clue 21:41:57 <qlum> mozilla being the one that never disconnects 21:42:57 <flo-retina> clokep: have you seen the new attachment in https://bugzilla.mozilla.org/show_bug.cgi?id=861454 ? 21:43:01 <flo-retina> the tests passed on try 21:43:40 * clokep doesn't seem to have gotten emails about that. :-S 21:43:49 <qlum> I don't know how different instantbird handles things from for example xchat as xchat also has no problems 21:45:15 <clokep> I haven't looked at your new logs yet. 21:45:21 <clokep> It looks like the esrver just stops pinging us. 21:45:26 <clokep> But we should be pinging in that situation. 21:45:30 <clokep> And if the socket dies we should know that... 21:47:03 <-- wnayes has quit (Ping timeout) 21:47:25 * flo-retina isn't sure if he can push with a tree that looks so busted :-S 21:50:43 --> wnayes has joined #instantbird 22:01:27 <-- Optimizer has quit (Ping timeout) 22:01:50 --> Optimizer has joined #instantbird 22:03:28 --> FireFly_TB has joined #instantbird 22:04:08 <-- wnayes has quit (Ping timeout) 22:09:46 --> wnayes has joined #instantbird 22:25:50 <qlum> I searched the web about possible similar problems with the same router but nothing there. I even looked again at the firewall on my router but it said it blocked nothing. This doesn't look very nice: http://puu.sh/3lUJY.png but that should not give any client specific problems right? 22:26:19 --> dew has joined #instantbird 22:26:29 <clokep> Your ISP could be throttling some traffic too FYI. 22:26:56 <qlum> Not very likely 22:27:20 <-- FireFly_TB has quit (Ping timeout) 22:27:38 <clokep> I'm mostly out of ideas so....grasping at straws here. :-/ 22:28:29 <qlum> its a small isp and laws prevent throttling of specific types of trafic nor would it be likely for an isp who has being usenet provider as its core business. 22:29:01 <qlum> even if it would it would not explain issues that are in instantbird but not in xchat or the mibbit client 22:29:35 <qlum> and yes my isp is mostly virual but if that where a problem its a virtual provider on the network of my previous provider 22:30:58 <qlum> I assume there is no way to get a more in depth log file that may tell why nothing happens in the 6 minutes before I hear I got booted 22:32:01 <qlum> or anything in the mozilla irc that prevents me from getting this error 22:35:51 <clokep> qlum: Don't consider mibbit to be part of this conversation, it's done as a totally different mechanism, all you do is have an http connection to it. 22:36:04 <qlum> oh true 22:36:10 <clokep> qlum: You can increase the log file length if you're on nightlies. 22:36:12 <clokep> One second. 22:36:39 <qlum> length wouldn't help? it would be more about detail 22:40:04 <clokep> qlum: What more detail could you want? :_S 22:40:11 * clokep thinks it's toodetailed already. 22:41:02 <qlum> well I don't know much about it but 6 minutes of nothing when it goes wrong doesn't sound detailed? 22:42:06 <clokep> qlum: There's nothign to log if there's nothing in the log. We log pretty much everything about the socket. 22:42:46 <qlum> wouldn't that tell you the problem lays elsewhere? 22:43:31 <clokep> I'm not sure what you mean. 22:43:42 <qlum> neither do I 22:43:59 * clokep needs to go watch a hockey game. 22:47:14 <-- qlum has quit (Ping timeout) 22:50:05 * clokep finds that Google Hangouts bug EXTREMELY annoying. 22:50:42 <flo-retina> clokep: it shouldn't be difficult to fix ;) 22:50:57 <clokep> flo-retina: I posted a log for your enjoyment. :P 22:51:09 --> qlum has joined #instantbird 22:51:14 <flo-retina> I didn't have more than 2 minutes to look at it :( 22:52:03 <flo-retina> I worked on that account manager test during boring conferences today 22:52:24 <flo-retina> that kind of bug is totally something I could fix in such conferences 22:52:31 <flo-retina> but they were only today :-P 22:52:36 <clokep> :) 22:54:55 * flo-retina decides that the oranges on the Thunderbird tree aren't a good enough reason to not push to c-c 22:58:34 <wnayes> I think I'm going to have a go at bug 1221 if nobody else has started on it. 22:58:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1221 enh, --, ---, nobody, NEW, Redesign buddy tooltips 22:59:27 <clokep> wnayes: No one has started on it besides thinking it should be more similar to other UI elements we have. :) 23:01:16 <flo-retina> wnayes: :) 23:01:20 <flo-retina> it's all yours! 23:01:33 <flo-retina> or rather, it will be once you attach a patch to it ;) 23:01:46 <wnayes> Cool :) I should be good to go, got the latest builds going today. 23:03:15 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7b2e8be9f258 - Florian Quèze - Bug 861454 - Fix handling of accounts with the unknown protocol plugin, r=clokep. 23:05:38 <flo-retina> clokep: you were faster than me; with the exact same set of changes on the bug! 23:05:54 * clokep > flo-retina 23:06:05 <flo-retina> it sucks that these 2 changesets are so different :( 23:06:27 <clokep> Shhhh. ;) 23:06:33 <clokep> No ones going to open the second one. 23:07:16 <flo-retina> nobody on the tb side cares anyway 23:07:20 --> Mook has joined #instantbird 23:13:58 <flo-retina> btw, I left some feedback at the end of https://etherpad.mozilla.org/e3uXWiSXhL 23:20:04 <instant-buildbot> build #404 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/404 23:23:15 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 23:33:49 <-- Optimizer has quit (Ping timeout) 23:37:12 --> Optimizer has joined #instantbird 23:51:07 <-- qlum has quit (Connection reset by peer)