All times are UTC.
00:03:12 <-- Even has quit (Ping timeout) 00:03:22 <-- chrisccoulson has quit (Ping timeout) 00:03:53 --> chrisccoulson has joined #instantbird 00:03:53 --> Even has joined #instantbird 00:03:54 * ChanServ sets mode +o Even 00:11:45 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 00:13:20 --> wuwei has joined #instantbird 00:14:20 <-- qlum has quit (Connection reset by peer) 00:40:11 <-- mconley has quit (Input/output error) 00:59:01 <instant-buildbot> build #409 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/409 01:01:03 <-- Mook_as has quit (Quit: Mook_as) 02:06:41 <-- wnayes has quit (Quit: wnayes) 02:08:11 --> Mook has joined #instantbird 02:35:58 <-- clokep has quit (Connection reset by peer) 03:01:40 <-- spiffytech has quit (Ping timeout) 03:07:27 <instant-buildbot> build #886 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/886 03:17:52 --> spiffytech has joined #instantbird 03:38:33 <instant-buildbot> build #878 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/878 03:43:40 <-- dionisos has quit (Ping timeout) 03:44:34 --> dionisos has joined #instantbird 04:15:35 --> Optimizer has joined #instantbird 04:53:33 <-- Nirgali has quit (Ping timeout) 05:05:34 <-- Even has quit (Ping timeout) 05:05:45 <-- GeekShadow has quit (Ping timeout) 05:05:49 <-- instant-buildbot has quit (Ping timeout) 05:05:49 <-- Morian has quit (Ping timeout) 05:06:07 --> Even has joined #instantbird 05:06:07 * ChanServ sets mode +o Even 05:06:21 --> instant-buildbot has joined #instantbird 05:06:21 * ChanServ sets mode +v instant-buildbot 05:07:15 --> Morian has joined #instantbird 05:07:16 --> GeekShadow has joined #instantbird 05:07:16 * ChanServ sets mode +h Morian 05:32:25 <-- EionRobb has quit (Ping timeout) 05:55:54 <instant-buildbot> build #981 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/981 05:57:42 <-- skeledrew has quit (Ping timeout) 05:58:00 --> skeledrew has joined #instantbird 05:58:17 <-- micahg has quit (Ping timeout) 05:58:38 --> jb has joined #instantbird 05:59:47 <-- Mook has quit (Quit: Mook) 06:01:26 --> micahg has joined #instantbird 06:15:17 --> Mic has joined #instantbird 06:15:18 * ChanServ sets mode +h Mic 06:26:37 <-- micahg has quit (Ping timeout) 06:27:21 --> micahg has joined #instantbird 06:41:30 <-- jb has quit (Ping timeout) 06:48:55 <-- dionisos has quit (Ping timeout) 07:06:01 --> nhnt11 has joined #instantbird 07:07:59 <nhnt11> Hi 07:28:18 <Mic> nhnt11: what's your opinion about the visible timer on tabbrowser-tab by the way? 07:28:27 <nhnt11> Mic: I agree with you 07:28:40 <nhnt11> I'm going to move it to the conversation binding. 07:29:45 <Mic> hah, nice :) 07:29:53 <Mic> (I was prepared to argue about this;) 07:30:32 <nhnt11> :) 07:31:17 <Mic> Does that mean that the switching(to|From)Tab calls are forwarded to the tabs then? 07:31:42 <nhnt11> You mean to the panels? 07:32:11 <Mic> Yes, to the panels. 07:32:20 <nhnt11> Yep. 07:32:32 <nhnt11> I don't see why the tab itself should care. The panel can do something if it wants. 07:32:47 <nhnt11> We could probably remove the methods from tabbrowser-tab completely 07:33:26 <nhnt11> Is it okay to pass an argument to a function that may be undefined? The function performs a check. 07:35:40 <Mic> We're checking for undefined arguments at other places too, so I guess it will be OK. What's the context here? 07:36:30 <nhnt11> Mic: I've added aConv (the prpl conv) as a parameter to add(Tab)Panel 07:36:43 <nhnt11> If the parameter exists, it does some conversation specific stuff 07:36:55 <nhnt11> This was an effort to remove the code duplication in addConversation. 07:37:33 <nhnt11> When importing a panel to a window, I want to pass linkedTabPanel.conv as an argument to add(Tab)Panel, even though it may not exist 07:38:04 * nhnt11 finally got rid of all the errors he was having yesterday. 07:38:25 <nhnt11> Also the dummy tab is no longer a conversation, and will likely be simple to convert to an awesometab when we need to. 07:40:02 <Mic> Just having to perform a check for null/undefined to get rid of _addConversation sounds like a good deal ;) 07:40:21 <Mic> *undefined 07:40:36 <nhnt11> Cool. 07:42:01 <Mic> I don't think we have a choices regarding the resolution of contact images by the way @ http://log.bezut.info/instantbird/130620/#m33 07:42:30 <nhnt11> Mic: I didn't know that. Let me do some research. 07:42:58 <nhnt11> Oh you "don't" think. 07:44:10 --> nhnt13 has joined #instantbird 07:44:25 <-- nhnt13 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 07:45:07 <Mic> We're receiving a vcard from the Facebook servers and there's in what they put in there... :( 07:46:04 <Mic> Maybe there'd be a way to get better images when using the Facebook API instead of only their XMPP service. 07:46:27 <nhnt11> There's definitely a way to get full resolution images using the API 07:46:34 <Mic> I know absolutely nothing about their APIs though. Maybe clokep does? 07:47:22 <nhnt11> Mic: I know a bit about it. From what little I know, it uses HTTP get requests along with an auth token and returns results as JSON objects. 07:48:06 <nhnt11> If you request a contact, their profile picture URL is in the object returned. 07:48:20 <nhnt11> I don't remember much else though. 07:48:22 --> jb has joined #instantbird 07:51:03 <Mic> Having nice contact icons on the awesome tab would be great but I think we should skip that for now ;) 07:52:43 <Mic> with "that = improving the Facebook prpl". 07:53:02 <nhnt11> Makes perfect sense :) 07:55:12 <Mic> The awesometab-contact binding will need a label property at some point by the way. 07:56:03 <nhnt11> Mic: What do you mean? 07:56:13 <Mic> I'll get to that in a second... 07:56:32 <nhnt11> Mic: By the way, is it fine to just use the Firefox tag icon? Do we need to mention somewhere where it's from? 07:56:40 * nhnt11 isn't sure about the licensing 07:56:58 <Mic> It's used by accessibility tools and should contain a decent textual representation of the richlistitem for screenreaders that can be outputted to the user. 07:57:09 <nhnt11> Mic: Ah okay. No problem. 07:57:14 <Mic> http://lxr.instantbird.org/instantbird/source/instantbird/content/contact.xml#125 07:57:24 <Mic> We have that on the contact list for example. 07:57:35 <nhnt11> Then what about setting the display name label text from the label attribute? 07:57:35 <Mic> (rather the contacts in there) 07:57:53 <nhnt11> i.e. xbl:inherits="value=label" or something. 07:58:01 <nhnt11> That would kill two birds with one stone :) 07:59:50 <Mic> Sorry, I don't understand :S 08:00:15 <nhnt11> Well, the label attribute would be identical to the display name, don't you think? 08:00:23 <nhnt11> Or do we want more info in it like status, etc? 08:01:00 <nhnt11> If they are identical, we can get rid of the displayName attribute and just use label instead. 08:01:06 * nhnt11 checks his code 08:01:20 <Mic> Yes, we do! Check the implementation in contact.xml. There's two of them, one for normal and one for expanded contacts. 08:01:57 <Mic> As I said, it's got to be a representation that of the richlistitem that can be read out loud by a screenreader. It's how a blind user will "see" your list item. 08:02:13 <Mic> -that 08:02:32 <nhnt11> Ah okay. More descriptive. 08:02:35 <nhnt11> Sorry for misunderstanding 08:03:37 <nhnt11> Btw, I'm nearly done with a new patch for bug 426. Just going through the review comments again to see if I missed anything. 08:03:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 08:04:44 <Mic> Do you have an estimate when you'll upload it? I might have time for a review before lunch (and will be away in the afternoon, early evening) as usual. 08:05:08 <Mic> The closing bracket is apparently wrong ;) 08:05:43 <nhnt11> Mic: Cool, then I'll try to upload as soon as possible. I just need to change all the *TabPanels to *Panels, I think 08:06:01 <nhnt11> Maybe around 15 minutes, I want to do a bit more testing. 08:06:14 * nhnt11 realizes such ETAs can change drastically... :S 08:06:57 <Mic> You don't need to hurry too much, I'll be away for ~30 minutes (most likely) anyways. 08:07:20 <nhnt11> Okay. 08:09:54 <nhnt11> Mic: About the visible timer, does it make sense to start it in the focus() method? 08:10:03 <nhnt11> No, probably not. never mind. 08:10:45 <nhnt11> I'll probably make a new method switchingToPanel in the tab panel binding. 08:11:00 <nhnt11> I wanted to use onSelect but that seems to have a couple other purposes, so can't be used for this. 08:20:55 <Mic> Maybe call it "onSwitchToPanel" or similar to by the way? 08:21:54 <nhnt11> Mic: How would we name the switching away from case? onSwitchAwayFromPanel? 08:22:11 <nhnt11> How about just switchToPanel and switchAwayFromPanel? 08:22:25 <nhnt11> Or switchFromPanel 08:23:05 <nhnt11> onLeavePanel or something like that? 08:23:09 <nhnt11> Leaving* 08:24:30 <Mic> hmm, they're not event handlers, so maybe we really shouldn't call them on* 08:24:40 <nhnt11> Yeah... 08:25:13 <nhnt11> I think switchToPanel and switchAwayFromPanel are fine. 08:25:33 <nhnt11> Though a bit long, I think they're the most accurate descriptions of what they do. 08:25:50 <nhnt11> Or switching* 08:27:45 <Mic> Yes, use them for now. 08:28:00 <Mic> I'll be away for hopefully no longer than half an hour now. 08:28:03 <Mic> bbl 08:28:05 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 08:28:14 --> Mic has joined #instantbird 08:28:15 * ChanServ sets mode +h Mic 08:28:53 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 08:51:30 <-- jb has quit (Ping timeout) 08:55:13 --> flo-retina has joined #instantbird 08:55:14 * ChanServ sets mode +qo flo-retina flo-retina 08:58:17 <-- Optimizer has quit (Ping timeout) 09:00:08 --> aleth has joined #instantbird 09:00:08 * ChanServ sets mode +h aleth 09:04:07 --> nhnt13 has joined #instantbird 09:04:37 <nhnt13> test 09:04:42 <nhnt13> Sorry, wrong window. 09:04:59 --> EionRobb has joined #instantbird 09:05:14 <-- nhnt13 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 09:11:48 --> Mic has joined #instantbird 09:11:48 * ChanServ sets mode +h Mic 09:13:14 --> qlum has joined #instantbird 09:13:23 --> jb has joined #instantbird 09:14:25 * aleth thinks nhnt11 is going to breathe a sigh of relief when the tabbrowser patch lands ;) 09:14:48 <nhnt11> aleth: :P 09:14:51 <aleth> tough start to a gsoc project... 09:15:23 <Mic> aleth: yes, I also thought after a while that anything coming after it could only be easier ;) 09:16:18 <flo-retina> I've already got "Adding a chat buddy Standard8 twice?!" twice in my error console :( 09:16:37 <aleth> :( 09:16:53 <flo-retina> anybody remembers what ":gravel.mozilla.org 333 flo-retina #talkilla Standard8 1366281349" means? 09:17:05 <flo-retina> I would guess "channel creator" 09:18:17 <aleth> flo-retina: the number is actually the last time the topic was set 09:18:27 <flo-retina> ah 09:18:31 <aleth> (and it was set by Standard8) 09:18:53 <nhnt11> Mic, flo-retina, aleth: Does this comment look good before addPanel? http://pastebin.instantbird.com/228501 09:19:24 <flo-retina> what does ~ mean before a nick? 09:19:48 <flo-retina> in ":gravel.mozilla.org 353 flo-retina = #talkilla :flo-retina ~Standard8 Boriss mixedpuppy NiKo` jonathan @dmose alexis tOkeshu logbot abr fredy gavin mreavy firebot " 09:20:07 <flo-retina> is it the equivalent of +q ? 09:20:12 <aleth> flo-retina: owner 09:20:13 <flo-retina> like @ is +o 09:20:19 <aleth> (+q) 09:21:45 <aleth> flo-retina: You didn't try to add Standard8 as a buddy on two different irc accounts? We still have a bug open on that 09:21:58 <flo-retina> I don't have him as a buddy 09:22:48 <flo-retina> I think I know what's going on 09:23:03 <flo-retina> '~Standard8' is in the list of nick we receive even if he's not in the room. 09:23:15 <aleth> Oh. 09:23:16 <flo-retina> so when he actually joins, things go wrong. 09:23:28 <aleth> That sounds plausible 09:23:31 <aleth> Good catch! 09:23:33 <flo-retina> that's what it looks like on my debug log at least 09:23:43 <nhnt11> flo-retina: Also would you like me to change the _tabPanels cache to _panels or something? 09:25:23 <aleth> nhnt11: nit: I don't like the commenting style with the leading hyphens, it makes it harder to read for some reason 09:25:54 <nhnt11> aleth: I saw that somewhere else, so I did it that way. I'll remove them if you want. 09:26:53 <aleth> Add a comment explaining what aConv is (as we have different things we call conversation at various places in the code) - I guess a conversation panel? 09:27:38 <nhnt11> It's not a panel. It accepts aPanel and aConv - aConv is the prpl conversation. I'll mention that. 09:28:17 <flo-retina> "the prpl conversation" I would be surprised 09:28:31 <nhnt11> flo-retina: Why? 09:28:38 <aleth> yeah 09:30:43 --> instantbot has joined #instantbird 09:30:43 topic changed by concrete.mozilla.org to "Ask about Instantbird (http://instantbird.com) here!|Current version is Instantbird 1.4! :) |News: http://blog.instantbird.org/ |Nightlies: http://nightly.instantbird.im/ (for testing only) |IRC logs: http://log.bezut.info/ |Pastebin: http://pastebin.instantbird.org/ | Bugs: http://bugzilla.instantbird.org" 09:30:43 * ChanServ sets mode +v instantbot 09:30:54 --> chrisccoulson has joined #instantbird 09:31:03 --> jb has joined #instantbird 09:31:11 --> Mic|web has joined #instantbird 09:31:16 --> instant-buildbot has joined #instantbird 09:31:16 * ChanServ sets mode +v instant-buildbot 09:31:28 --> Mic has joined #instantbird 09:31:28 * ChanServ sets mode +h Mic 09:31:28 --> flo-retina has joined #instantbird 09:31:29 * ChanServ sets mode +qo flo-retina flo-retina 09:31:52 <flo-retina> nhnt11: because the UI has no reason to touch that 09:31:53 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 09:31:54 --> qlum has joined #instantbird 09:32:11 <flo-retina> what's going on with the IRC servers these days :( 09:33:05 <flo-retina> and now I've got "Cannot remove a buddy that was not in the room: Standard8" 09:33:05 <nhnt11> flo-retina: Okay. I thought you meant it was confusing in my changes, I guess it may have been a bit confusing before too. 09:33:32 <flo-retina> nhnt11: "prpl" means implemented by the protocol plugin 09:33:37 <nhnt11> I knwo 09:33:41 --> Morian has joined #instantbird 09:33:41 * ChanServ sets mode +h Morian 09:33:45 <flo-retina> nhnt11: the UI usually touches the imI* interfaces 09:34:11 <nhnt11> flo-retina: I remember you guys referring to the passed aConv as a prpl conversation, so I called it that. 09:34:30 <flo-retina> maybe it was in a different context? 09:34:35 <nhnt11> Conversation binding also calls it "prplConversation 09:34:36 <nhnt11> " 09:34:40 <flo-retina> as aleth said, we have plenty of conversation objects 09:34:42 <nhnt11> I'm talking about linkedConversation.conv btw. 09:34:56 --> aleth has joined #instantbird 09:34:57 * ChanServ sets mode +h aleth 09:35:09 <aleth> What's up with irc.mozilla.org :-S 09:35:20 <nhnt11> flo-retina: http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1823 09:35:31 <flo-retina> I had found it already 09:35:38 <flo-retina> nhnt11: yeah, that's... unfortunate :-/ 09:35:59 <aleth> flo-retina: Can you file a bug for the owner nick issue? Thanks 09:36:02 <flo-retina> nhnt11: I suspect that comment was written before imIConversation even existed 09:36:04 <Mic> aleth: I've heard they're moving the IRC services "into the cloud" (hosting on Amazon or so) maybe that's not going as well as they're hoping? 09:36:08 * nhnt11 doesn't know what to say to that. 09:36:15 --> Optimizer1 has joined #instantbird 09:36:20 <flo-retina> aleth: bug 2010 09:36:24 * aleth grumbles about clouds 09:36:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2010 nor, --, ---, nobody, NEW, Some JS errors when joining some IRC channels 09:36:39 <flo-retina> I'm not sure it's actually true though, it's just a guess of a possible explanation at this time 09:36:54 <aleth> It seems plausible though 09:37:40 <Mic> aleth: maybe Mozilla doesn't have to implement an eavesdropping interface for the NSA this way and could use some Amazon infrastructure for that? :P 09:37:41 <flo-retina> I'm don't understand why that would cause the "cannot remove a buddy that was not in the room" though 09:37:56 <flo-retina> Mic: #chatdev? ;) 09:38:06 <Mic> Definitely. 09:38:35 <flo-retina> the moznet IRC servers seem to now suffer from an issue we saw frequently on freenode 09:38:41 --> GeekShadow has joined #instantbird 09:38:51 <flo-retina> when I get disconnected, I can't reconnect before a minute or two 09:38:59 <aleth> Same here. 09:39:04 <flo-retina> I get "Connection closed by server." errors for a while, then an SSL error 09:39:08 <nhnt11> Same 09:39:24 <aleth> flo-retina: Adding the nick to the error messages was definitely a good idea :) 09:39:47 <flo-retina> aleth: thanks 09:40:03 <flo-retina> I'm also not sure yet that Standard8 is the only nick affected 09:40:13 <nhnt11> flo-retina: So what should I call aConv other than prplConversation? 09:40:16 <flo-retina> as he's currently the only one dancing in and out of #talkilla (he's in a train) 09:40:23 <aleth> flo-retina: But he's the nick that's mentioned for you? 09:40:34 <flo-retina> nhnt11: "imIConversation instance" is more likely to be right 09:40:38 <flo-retina> aleth: yeah 09:40:49 <nhnt11> Okay. 09:40:52 <-- GeekShadow has quit (sand.mozilla.org gravel.mozilla.org) 09:40:52 <-- Optimizer1 has quit (sand.mozilla.org gravel.mozilla.org) 09:41:05 <flo-retina> aleth: I also wonder if the try/catch I added yesterday significantly change the behavior 09:41:25 <aleth> Hmm 09:42:10 <aleth> So is jb an owner too? 09:42:22 <aleth> oops, didn't mean to ping him 09:42:51 <flo-retina> aleth: for #talkilla, no 09:43:09 <flo-retina> aleth: before the try/catch, a nick failing (and Standard8 is almost the first) would cause issues for all the other nicks 09:43:31 <aleth> Yes, the try/catch should only improve things as far as I can see 09:43:40 --> GeekShadow has joined #instantbird 09:43:41 <flo-retina> hmm, oh wait, we have all the nicks in the same enumerator, so throwing still breaks all the other nicks 09:43:47 <flo-retina> never mind, I'm saying rubbish here :-| 09:44:44 <flo-retina> it's also not clear to me why the errors are reported twice now. One from line 417 and one from line 419 in jsProtoHelper (line 419 is the this.ERROR call I added; but why is it still reported at line 417 in spite of the try/catch? :-S) 09:44:57 <aleth> nhnt11: "The following methods are called at various scenarios if they are implemented in the panel's binding" drop the "called at various scenarios" and just say "used" 09:45:09 <nhnt11> aleth: Okay. 09:45:19 <Mic> nhnt11: the writing style of the comments in the pastebin is a bit inconsistent by the way, maybe rephrase that to make the descriptions of the methods more similar? 09:45:25 <aleth> flo-retina: This can be reproduced by joining #talkilla? I'll update later and see if I can fix 09:45:49 <flo-retina> aleth: I don't have reliable steps to reproduce 09:46:16 <flo-retina> aleth: if my current understanding is correct, you need to join #talkilla when Standard8 isn't in here, and the problem occurs (or starts) when he actually joins. 09:46:29 <aleth> flo-retina: Right, makes sense 09:46:49 <aleth> It's possible that it's just that once that happens it breaks all kinds of things from then on 09:46:56 <flo-retina> aleth: also, I wonder if this is a weird behavior that started with all the moznet changes we have seen recently 09:47:04 <flo-retina> maybe it's just server brokenness :-S 09:47:15 <aleth> flo-retina: Also possible, like the auth issue yesterday :-S 09:47:22 <nhnt11> Mic: I know it's inconsistent, but I couldn't find a good way to phrase things descriptively and consistently at the same time. 09:47:35 <aleth> If you have a debug log, please attach it. 09:47:43 <flo-retina> debug log for what? 09:47:58 <aleth> Joining #talkilla and/or Standard8 joining 09:48:38 <flo-retina> even though I don't think anything was private, I'm not very comfortable attaching that much info in a place where it will stay permanently 09:48:49 <aleth> flo-retina: OK, never mind then 09:48:58 <flo-retina> I can email it to you if you want 09:49:17 <aleth> I'll see how far I can get just by looking at the code first 09:49:24 <aleth> nhnt11: "Use to reinitialize after importing to a new window" is not very clear. 09:49:46 <nhnt11> aleth: Isn't it? It makes sense to me. 09:50:10 <aleth> Maybe it's just the word 'reinitialize' 09:50:20 <flo-retina> debug logs are still very far from behavior how I would like them to :( 09:51:08 <nhnt11> aleth: I can't think of a better way to phrase it. 09:51:10 <aleth> i.e. 'reinitialize what?'. Is "Called after reattaching the tab" correct? 09:51:35 <nhnt11> Yes I suppose. Let me think a bit more. 09:52:03 <aleth> "It is assumed that a panel focuses a child element in its focus method. If it doesn't, a previous tab's focused element may be left focused, and hence may continue to receive input." This really means we should focus something specific (eg just the tab itself) IF that method does not exist. 09:52:55 <flo-retina> aleth: "reinitialize" makes more sense to me than "after reattaching the tab" 09:53:03 <nhnt11> aleth: How about "Called when reattaching to a new window. Use to initialize from the instance in the previous window." 09:53:07 <aleth> Add a comment on the difference between the switchingToPanel method and onSelect 09:53:14 <flo-retina> aleth: and these 2 sentences explain very different things. One says when it's called, the other says what's the expected behavior 09:53:27 <nhnt11> aleth: I mention to look in updateCurrentTab for more info. It's made clear there. 09:53:42 <aleth> flo-retina: which two sentences? I wasn't making a suggestion there, I just thought it wasn't clear 09:53:58 <aleth> nhnt11: I like "Called when reattaching to a new window. Use to initialize from the instance in the previous window." much better 09:54:12 <flo-retina> aleth: alright, just assume I was confused then 09:54:17 <nhnt11> Cool, I'll keep that unless we come up with something better. 09:54:57 <aleth> nhnt11: Maybe it should be "called after reattaching to a new window" (lets be specific here about when exactly it is called). Is it also called after reattaching to the same window? 09:55:24 <-- gerard-majax has quit (Ping timeout) 09:55:27 <nhnt11> aleth: No. Only for a new window. 09:55:40 <nhnt11> If it's in the existing window, the position of the tab is changed. The panel isn't touched. 09:55:47 <aleth> OK :) 09:56:28 <nhnt11> aleth: Just to be clear, when it's moved to a new window, a brand new instance is created and is expected to initialize itself from the one in the previous window, using finishImport. 09:56:35 <-- GeekShadow has quit (sand.mozilla.org gravel.mozilla.org) 09:57:19 <aleth> nhnt11: Yes, I know this, I was just thinking some of that specificity should be in the comment ;) 09:57:50 <aleth> The rest looks fine to me. 09:58:13 <nhnt11> aleth: I just realized you said "after" instead of "when", so I misunderstood what you were trying to say. Oops. 09:59:59 * nhnt11 is about to attach a new patch 10:00:17 <Mic> nhnt11: one moment. 10:00:29 <Mic> I'm typing suggestions for the comment at the moment. 10:00:35 <nhnt11> Mic: Cool. 10:01:37 --> GeekShadow has joined #instantbird 10:02:01 <Mic> Maybe in this style: http://pastebin.instantbird.com/228503 ? 10:03:04 <Mic> It might be a lot lengthier than yours though.. 10:03:15 <nhnt11> Mic: I kinda like mine better. 10:03:36 <nhnt11> Yours is definitely more consistent though.. 10:03:37 <nhnt11> Hmm 10:03:56 --> Tonnes has joined #instantbird 10:04:44 <Mic> I'm a bit concerned about the focus behavior described there. 10:05:36 <Mic> Can't we e.g. focus the panel element itself when it doesn't have a focus method? 10:05:56 <nhnt11> Mic: We do that, but it doesn't work :/ 10:06:29 <nhnt11> i.e. When I tried it, input was still being sent to the previous tab's inputbox 10:09:29 <-- jb has quit (Ping timeout) 10:12:26 <nhnt11> Mic: I just tried again and confirmed with this in the error console: http://pastebin.instantbird.com/228504 10:14:09 <Mic> Maybe throw an error when that happens to force add-on creators to implement the focus call? 10:14:25 <Mic> *method 10:14:30 <nhnt11> Mic: The problem is that the focus method always exists.. 10:14:54 <Mic> hmm.. 10:15:04 <nhnt11> Mic: And even if they implement it, we have to make sure that they actually focused something, too. What if they just add in an empty method? 10:21:35 <aleth> I think the problem is that we pass generic keypresses to the tab when the tab is focused 10:21:41 <nhnt11> Mic: I tried some things but I can't make this work. Do you have any other ideas? 10:21:49 <aleth> Obviously this won't work if the tab panel can't handle them 10:21:55 <nhnt11> aleth: No. I just tested to see if this was happening in tabkeypress, but it's not. 10:22:02 <aleth> Huh. 10:22:38 <aleth> What do you mean by "this happens"? 10:23:09 <nhnt11> aleth: I checked it tabkeypress was passing keyevents to the panel. It's not. 10:23:23 <nhnt11> The previous tab's inputbox definitely seems to remain focused. 10:23:40 <nhnt11> s/it/if 10:24:11 <aleth> Do you see a focus ring around the tab label? 10:24:17 <nhnt11> No. 10:24:29 <aleth> So the tab isn't focused. 10:24:40 <nhnt11> Right, that's what I'm saying. 10:25:00 <nhnt11> I checked because I'm not sure a focus ring is shown in Mac. I've never seen one. 10:25:04 <aleth> So that's what should be fixed (in onSelect?) 10:25:21 <aleth> nhnt11: If you tab to the tab bar and switch between tabs using the keyboard, you should see it? 10:25:42 <nhnt11> aleth: I can't tab to the tab bar on Mac. 10:25:51 <aleth> :-S 10:26:06 --> clokep has joined #instantbird 10:26:06 * ChanServ sets mode +o clokep 10:26:08 <aleth> You can't switch tabs using the keyboard on Mac? 10:26:18 <aleth> I didn't realize there were OS-specific issues here. 10:26:29 <nhnt11> The tab cycle goes inputbox->messages browser->participants label->participants list->inputbox for me. 10:26:31 <nhnt11> Nor did I. 10:26:40 <nhnt11> I can switch tabs using Cmd+Shift+Right/Left 10:27:08 <clokep> FINALLY I was able to connect. 10:27:11 <aleth> Well, now we know :P Now I understand why you say focusing the tab doesn't work ;) 10:27:25 <nhnt11> Yeah. 10:27:45 <aleth> nhnt11: In that case it seems there is nothing we can do if custom tabpanels don't contain focusable elements. 10:27:56 <nhnt11> clokep: Yeah, it's annoying when I'm trying to test stuff. I've switched to freenode for testing for now. 10:28:24 <nhnt11> aleth: Yeah, other than blur the previous one. But you say that's bad, so nothing doing. 10:28:45 <Mic> I have to go, have a nice day! 10:28:54 <aleth> nhnt11: So it seems your approach is correct that all we can do is document it. 10:28:54 <nhnt11> aleth: I think it's enough if the panel contains even one element 10:28:55 <nhnt11> Bye Mic 10:29:30 <aleth> Do you really need a separate focus method? Can't that be part of onSelect or swithcingtotab? 10:29:48 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 10:30:01 <aleth> Oh, I see. You need it for tabkeypress, right? 10:30:51 <nhnt11> aleth: Right now tabkeypress only deals with conversations. 10:31:03 <nhnt11> it does this.selectedConversation.editor.focus(); 10:31:25 <aleth> So if tabpanels have a focus method, it can use that generically. 10:31:33 <aleth> Or am I missing something? 10:32:04 <nhnt11> aleth: I did that, but one of you pointed out that conversation binding's focus method does some other things too which should not be done for tabkeypress 10:32:48 <aleth> nhnt11: It calls onSelect. 10:32:53 <nhnt11> Yeah. 10:32:56 <aleth> Do we always want to do this? 10:33:06 <nhnt11> Apparently not. 10:34:33 * nhnt11 sighs 10:34:40 <aleth> I'm confused now :-/ 10:35:05 <nhnt11> aleth: I think documenting it and leaving it is a decent solution. 10:35:08 <aleth> When I select a tab with the mouse (existing code), what calls the focus method? 10:35:17 <nhnt11> aleth: updateCurrentTab 10:35:32 <nhnt11> Sorry, updateCurrentBrowser 10:36:06 <aleth> Called by onselect in the tabbox? 10:36:20 --> gerard-majax has joined #instantbird 10:36:30 <nhnt11> Yes. 10:37:41 <aleth> OK. So I think it is clear that generically when this happens we should call onSelect (because that's what just happened). i.e. in updateCurrentTab you call focus and then onSelect, and drop the onSelect call from focus in conversation.xml 10:38:30 <nhnt11> aleth: That's what I was thinking, but I'm afraid of breaking stuff without realizing :( 10:38:32 <aleth> Then you can make tabkeypress use focus. 10:38:54 <aleth> It seems the right thing to do, let's try it ;) 10:39:07 <nhnt11> Okay. 10:41:10 <nhnt11> Testing... 10:41:26 <aleth> It's possible you may need to change http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#79 10:44:09 <nhnt11> Seems to be working fine 10:44:54 <flo-retina> nhnt11: this is how Instantbird looks on the retina screen at the "optimal" resolution: http://i2.minus.com/i6Y64EE8wr3cE.png 10:45:28 <nhnt11> flo-retina: As I expected, gross. 10:45:32 <flo-retina> yeah 10:45:40 <flo-retina> I wonder if I would need a restart for the fonts to look OK 10:45:46 <flo-retina> or if we aren't on a Gecko that supports it yet 10:46:04 <nhnt11> flo-retina: I suspect gecko, look at the window buttons 10:46:08 <flo-retina> that would be surprising though, as my current Firefox looks OK 10:46:09 <nhnt11> (I mean the traffic lights) 10:46:48 <flo-retina> not sure why it's not looking good 10:47:12 <nhnt11> flo-retina: Pixel doubling, that's why :P 10:47:32 <flo-retina> nhnt11: but why is it doing that? 10:48:04 <nhnt11> flo-retina: Mac detects that the app isn't retina aware, so renders it at non-retina resolution and scales it 2x 10:48:15 <flo-retina> "the app isn't retina aware" why? 10:48:26 <flo-retina> if Gecko is, I don't see why Instantbird wouldn't 10:48:34 <nhnt11> I have no idea. 10:48:58 <flo-retina> We should find what Tb did, and copy :-P 10:49:34 <nhnt11> Yeah. 10:49:54 <nhnt11> flo-retina: The images will still need updating though. They look gross on Tb, too 10:50:09 <flo-retina> nhnt11: we updated most of them on Tb 10:50:21 * nhnt11 might be willing to help with that after GSoC if he gets a retina display. 10:50:33 <nhnt11> flo-retina: Really? The images I see in chat/ aren't very retina-looking 10:51:05 <flo-retina> chat still misses some 10:51:08 <flo-retina> especially the protocol icon 10:51:12 <flo-retina> there's a patch in my review queue for that 10:51:18 <nhnt11> Yeah. I didn't mean the Tb specific ones. 10:51:22 <flo-retina> not very satisfying though :-/ 10:51:45 <nhnt11> flo-retina: I suspect that I'll run my display at full resolution (if I get one) though, so.. :P 10:51:56 <flo-retina> nhnt11: yeah, like I always do 10:52:12 <flo-retina> nhnt11: I only switched today because I'm working on a WebGL demo that sucks when I have that many pixels 10:52:26 <nhnt11> :) 10:54:03 * nhnt11 is once again, about to export a patch for uploading. 11:00:28 <-- aleth has quit (Quit: Ciao) 11:00:28 <clokep> I hope this is almost done. :) 11:00:31 --> aleth has joined #instantbird 11:00:31 * ChanServ sets mode +h aleth 11:03:45 <nhnt11> clokep: So do I :P 11:04:35 * clokep has big plans for arbitrary tabs. ;) 11:06:19 <-- clokep has quit (Ping timeout) 11:11:45 <instantbot> firstname.lastname@example.org requested review from email@example.com for attachment 2497 on bug 426. 11:11:46 <instantbot> firstname.lastname@example.org requested feedback from aleth@instantbird .org for attachment 2497 on bug 426. 11:11:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 11:11:51 * nhnt11 wonders if he should've requested review from aleth as well :s 11:12:21 --> novabyte has joined #instantbird 11:12:43 <aleth> nhnt11: It doesn't matter, ultimately flo will do the final r? on this one anyway I think ;) 11:12:50 <nhnt11> Cool. 11:13:06 <nhnt11> I requested review from flo and Mic. 11:13:45 * nhnt11 just realized his patch is ~70kB 11:13:47 --> qlum-test has joined #instantbird 11:14:18 <-- qlum has quit (Ping timeout) 11:14:44 <aleth> nhnt11: you forgot to define aConv ;) 11:14:58 <nhnt11> aleth: What? Where? 11:15:00 <aleth> (in the addpanel comment) 11:15:15 <nhnt11> aleth: I added a comment above the <parameter> 11:15:18 <aleth> Oh, wait, you did it lower down. 11:15:20 <nhnt11> I thought that would suffice 11:15:26 --> jb has joined #instantbird 11:15:32 <nhnt11> Yea 11:15:34 <nhnt11> h 11:15:43 <-- qlum-test has quit (Ping timeout) 11:16:26 <aleth> So switchingToPanel is called even when onSelect is not called ("when the user is scrolling past it")? 11:16:37 <nhnt11> Yes. 11:17:29 <aleth> Maybe we should make that clearer in the comment. Moving the switchingto* methods above onSelect should help 11:17:35 <aleth> (in the comment) 11:17:42 <nhnt11> Hmm. Perhaps. 11:17:44 <nhnt11> Afk for a bit. 11:18:04 --> qlum has joined #instantbird 11:20:21 <-- qlum has quit (Ping timeout) 11:24:24 <aleth> nhnt11: in updateCurrentTab, the this.selectedPanel.focus(); call at the end was this.mCurrentConversation.focus(); before, so don't we want an additional this.selectedPanel.onSelect() here now? 11:26:57 <-- gerard-majax has quit (Ping timeout) 11:27:24 --> qlum has joined #instantbird 11:28:38 <-- novabyte has quit (Quit: bye bye) 11:32:25 <-- qlum has quit (Ping timeout) 11:33:34 <aleth> nhnt11: |this.addPanel(newPanel, aOtherTab.linkedTabPanel.conv);| Don't you need aOtherTab.linkedTabPanel.conv || null ? 11:33:51 <-- jb has quit (Ping timeout) 11:37:39 --> qlum has joined #instantbird 11:40:29 <nhnt11> aleth: There's a timer that's set for onSelect in updateCurrentTab. And I was asking about passing a possibly undefined parameter, maybe I misunderstood the answer. 11:40:43 <-- qlum has quit (Ping timeout) 11:40:47 <nhnt11> aleth: Could you put these in a comment on the bug? I'll address them all at once 11:41:20 <aleth> nhnt11: OK 11:43:59 <nhnt11> aleth: Never mind about the timer thing, you're right. 11:44:16 --> qlum has joined #instantbird 11:45:10 <instantbot> email@example.com granted feedback for attachment 2497 on bug 426. 11:45:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 11:45:16 <-- qlum has quit (Client exited) 11:45:37 * aleth wishes we had interdiffs on bugzilla for situations like this :-/ 11:46:14 <nhnt11> aleth: Would you like one? 11:46:39 <nhnt11> You could diff from my repo if you'd like. 11:46:46 <nhnt11> All changes are uploaded there. 11:47:00 <aleth> Right, good idea. 11:47:09 <nhnt11> The uploaded patch is a diff between the awesometab branch and default. 11:47:28 <aleth> I think we should get interdiffs once we move to BMO ;) 11:48:59 <nhnt11> aleth: Yay, those are all your comments :) 11:49:40 <nhnt11> Btw, aleth, the methods in the addPanel comment are in alphabetical order. 11:50:18 <nhnt11> Well they're supposed to be - I seem to have messed up the order between the switching* methods. 11:50:19 <aleth> If you leave the order as is, make it clearer in the text what the difference is. 11:50:24 <nhnt11> Right. 11:50:37 <aleth> That's probably safer anyway ;) 11:51:34 <nhnt11> aleth: How about removing onSelect altogether and handling it in the _visibleTimer itself? 11:51:50 --> clokep_work has joined #instantbird 11:51:50 * ChanServ sets mode +o clokep_work 11:52:15 <nhnt11> Right now we have a 400ms timer that marks a conversation as read, whereas we wait for 1000ms before deciding it was visible. 11:52:16 <aleth> nhnt11: I'd rather not in this patch. It may cause behaviour changes. 11:52:20 <nhnt11> That doesn't make sense to me. 11:52:58 <aleth> It's possible that could be optimized, but let's do that in a followup if it seems a good idea. 11:53:05 <nhnt11> Okay. 11:53:47 <aleth> We want this to land and everything to keep working just as it is, so that if we spot any changes it's breakage ;) 11:54:06 <-- EionRobb has quit (Quit: Leaving.) 11:54:16 <nhnt11> Okay :) 11:54:20 --> EionRobb has joined #instantbird 11:54:40 <aleth> As you said, it's a big patch and touches a lot of things... 11:55:11 <nhnt11> aleth: This looks like it should work right? http://pastebin.instantbird.com/228525 11:56:52 <-- EionRobb has quit (Ping timeout) 11:57:25 <aleth> Yes 11:57:39 <nhnt11> New patch coming up :P 12:00:35 <aleth> I'm glad we've got that focus thing straightened out, screen reader users will thank us ;) 12:01:15 --> qlum has joined #instantbird 12:02:42 --> qlum1 has joined #instantbird 12:02:49 <clokep_work> nhnt11: Sorry this has been so painful btw. :( 12:02:58 <clokep_work> I don't think any of us realized how much work it'd be to get that stuff into shape. 12:04:15 <nhnt11> It's quite alright :) 12:04:27 --> gerard-majax has joined #instantbird 12:04:28 <-- qlum has quit (Ping timeout) 12:04:55 <instantbot> firstname.lastname@example.org cancelled review?(email@example.com ) for attachment 2497 on bug 426. 12:04:56 <instantbot> firstname.lastname@example.org requested review from email@example.com for attachment 2498 on bug 426. 12:04:57 <instantbot> firstname.lastname@example.org requested feedback from aleth@instantbird .org for attachment 2498 on bug 426. 12:04:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 12:07:53 --> qlum has joined #instantbird 12:07:59 <instantbot> email@example.com granted feedback for attachment 2498 on bug 426. 12:08:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 12:08:32 <aleth> clokep_work: What's the RFC for IRC user prefixes? 12:08:49 --> nhnt11_phone has joined #instantbird 12:08:53 <clokep_work> aleth: Which one? ;) 12:09:20 <aleth> That kind of complication is exactly why I'm asking ;) 12:09:38 <clokep_work> aleth: https://www.alien.net.au/irc/chanmembers.html is good. 12:09:44 <clokep_work> Most of them are just from the RFC. 12:09:54 <aleth> Let me rephrase: Why is ~ and & not currently in the list of user prefixes? 12:10:04 <-- qlum has quit (Ping timeout) 12:10:05 <clokep_work> aleth: Because they're not in the RFC. 12:10:22 <aleth> ~ (+q) and & (+a) are nonstandard then? 12:10:25 <clokep_work> Yes. 12:10:33 <clokep_work> +a? What is that? 12:10:42 <aleth> That explains why I couldn't find documentation for them :-S 12:10:51 <aleth> clokep_work: "admin" apparently 12:11:06 <clokep_work> aleth: ISUPPORT is supposed to give us a list: http://www.irc.org/tech_docs/005.html 12:11:23 <clokep_work> aleth: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircISUPPORT.jsm#160 12:12:07 <clokep_work> aleth: "admin" as in "ircop"? 12:12:27 <aleth> clokep_work: I don't know, I don't trust the page I found that listed on. 12:13:18 * nhnt11_phone will be back in an hour or two. 12:13:20 <clokep_work> aleth: Looks like https://www.alien.net.au/irc/usermodes.html can be a lot of things. :) 12:13:23 <clokep_work> What page? 12:13:26 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 12:13:36 <aleth> clokep_work: Right, thanks for reminding me about ISUPPORT :) 12:14:10 <clokep_work> aleth: Ah, I lied: you want to look here: https://www.alien.net.au/irc/chanmodes.html 12:14:24 <clokep_work> "a CHANNEL_PROTECTION Unreal Nickname Gives the given nickname 'protection'; Cannot be kicked/deopped " maybe? 12:14:24 <aleth> clokep_work: http://www.geekshed.net/2009/10/nick-prefixes-explained/ but your link is more like what I wanted 12:15:01 --> qlum has joined #instantbird 12:15:08 <aleth> clokep_work: No, I think it's "a" on the usermode page. "Admin status. Shown as an admin in WHOIS, able to load and unload modules, and see IP's in STATS c" 12:15:59 <-- qlum1 has quit (Ping timeout) 12:16:15 <clokep_work> aleth: Maybe...but that doesn't make sense, You only ever received another user's mode in a channel, you can't get their actual "user mode". 12:16:23 --> qlum_ has joined #instantbird 12:16:52 <aleth> But we do receive it, with the nick, if there is a prefix assigned to that usermode. 12:17:06 * clokep_work shrugs. 12:17:14 <clokep_work> I think you're misunderstanding me. 12:17:21 <aleth> We'll get "&clokep_work" ;) 12:18:21 <aleth> But I probably am misunderstanding you, as I'm still confused. 12:20:37 <aleth> It should be a channel mode, but then it's not "admin"... 12:20:49 <clokep_work> Right, which makes me think that link is wrong. :P: 12:21:05 <aleth> My instinct not to trust it was right :D 12:22:55 <clokep_work> Hmm.... http://wiki.inspircd.org/Comparison_Of_Modes_Available is interesting, but not useful at the moment. 12:23:13 <clokep_work> moznet is unreal, right? 12:23:30 <aleth> I think so. 12:28:20 --> dionisos has joined #instantbird 12:28:43 <clokep_work> aleth: I guess it means operator, yeah. 12:28:50 <clokep_work> s/operator/administrator/ 12:28:59 <clokep_work> Weird though that they would use a, as that's how you set yourself away. :-S 12:29:39 <clokep_work> It would be cool if we started receiving ~ though. :) 12:30:21 <aleth> We do, unreal uses it and it is listed in the mozilla.org PREFIX response. 12:30:27 <aleth> As is &. 12:30:35 <aleth> flo-retina: I just joined #talkilla with Standard8 absent and he was not included in the 353 participant list. 12:31:07 <aleth> flo-retina: So I guess it was the current server issues causing the behaviour you saw. 12:32:24 <clokep_work> Not for me. :-S 12:32:38 <clokep_work> (~ isn't listed.) 12:32:46 <aleth> More server issues? :-S 12:33:02 <clokep_work> aleth: I think they have different servers on different versions right now. 12:33:08 <clokep_work> I'm going to udpate though, one second. :) 12:33:12 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 12:33:28 --> clokep_work has joined #instantbird 12:33:28 * ChanServ sets mode +o clokep_work 12:34:12 <clokep_work> Raw message: :concrete.mozilla.org 005 clokep_work MAXTARGETS=20 WALLCHOPS WATCH=128 WATCHOPTS=A SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(ohv)@%+ CHANMODES=beIqa,kfL,lj,psmntirRcOAQKVCuzNSMTG NETWORK=Mozilla CASEMAPPING=ascii EXTBAN=~,cqnr ELIST=MNUCT :are supported by this server 12:36:03 --> mpmc has joined #instantbird 12:36:49 <clokep_work> aleth: ^ 12:36:50 <aleth> :gravel.mozilla.org 005 aleth_dev MAXTARGETS=20 WALLCHOPS WATCH=128 WATCHOPTS=A SILENCE=15 MODES=12 CHANTYPES=# PREFIX=(qaohv)~&@%+ CHANMODES=beI,kfL,lj,psmntirRcOAQKVCuzNSMTG NETWORK=Mozilla CASEMAPPING=ascii EXTBAN=~,cqnr ELIST=MNUCT :are supported by this server 12:37:04 <clokep_work> Weird. :-S 12:37:09 <clokep_work> I'm glad they're doing that, but still strang. 12:44:36 <clokep_work> That'll get rid of that weird "bug" where if you join before flo-retina he gets owner status and if you join after he gets op status. 12:45:17 <aleth> Yes :) 12:53:44 <clokep_work> qheaden_away: I added some stuff to the pad. 13:01:34 <flo-retina> clokep_work: "I don't think any of us realized how much work it'd be to get that stuff into shape." honestly, I'm not surprised it required that much effort (I touched tabbrowser before ;)); more surprised that it's already almost finished ;) 13:03:14 <clokep_work> flo-retina: :P Well...you just pushed him into the lion's den, I guess. 13:03:19 * clokep_work takes no responsibility. 13:04:01 * aleth suspects qheaden is glad he didn't have to make JS protos possible first ;) 13:05:04 <flo-retina> clokep_work: I didn't push. Mic gave instructions about how to start :-P. 13:05:36 <flo-retina> aleth: he probably haven't even noticed how much work that involved ;) 13:06:46 <flo-retina> aleth, clokep_work: so is the current understanding of the situation that gravel started doing stuff that concrete doesn't? 13:07:03 <clokep_work> flo-retina, aleth: Yes. 13:07:14 <clokep_work> Somewhere when you log in it says the version number of the software btw... 13:08:08 <aleth> "Your host is gravel.mozilla.org, running version Unreal3.2.8" 13:08:23 <clokep_work> Where's that pop up? :) 13:08:26 <clokep_work> Server tab? 13:08:43 <aleth> Possibly - I looked at the debug log (002) 13:09:11 <aleth> Funkily, it also says "This server was created Mon Jun 17 2013 at 21:44:44" 13:09:30 <aleth> Never noticed that before, I guess it's new ;) 13:09:31 <clokep_work> aleth: I find the debug log useless for IRC log ins. 13:09:40 <clokep_work> It all scrolls out too fast. 13:09:56 <clokep_work> Did we ever make it a pref about how much to store? 13:10:06 <aleth> I added a pref and upped the value for just that reason. 13:10:39 <aleth> I probably should have picked an even larger default value - it seemed generous at the time... 13:11:25 <flo-retina> clokep_work: yes 13:11:26 <clokep_work> What's the pref? :) 13:12:01 <aleth> messenger.accounts.maxDebugMessages 13:12:20 * flo-retina wonders why it's set to 600 for him 13:12:34 * flo-retina sets to 2000 13:12:43 * clokep_work sets it to 500. 13:14:15 * clokep_work reconnects. 13:14:18 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:14:33 --> clokep_work has joined #instantbird 13:14:33 * ChanServ sets mode +o clokep_work 13:15:12 <clokep_work> aleth: Your host is concrete.mozilla.org, running version Unreal3.2.8 13:15:23 <clokep_work> This server was created Tue Mar 24 2009 at 19:56:50 PDT 13:15:37 <aleth> Same version, different config :-/ I hope that's intentional 13:16:05 * clokep_work wonders who runs irc.mozilla.org 13:16:13 * clokep_work wishes we could handle LIST well 13:21:09 <flo-retina> clokep_work: "15:16:04 * clokep_work wonders who runs irc.mozilla.org" I think Usul would know. 13:22:59 <-- qlum has quit (Ping timeout) 13:23:52 <-- qlum_ has quit (Ping timeout) 13:26:18 <clokep_work> aleth, flo-retina: FYI gravel is having stability issues. 13:27:05 <flo-retina> oh really? :-P 13:28:36 <clokep_work> According to #it, yes. :) 13:33:35 --> qlum has joined #instantbird 13:43:27 * clokep_work finds it weird they haven't taken it out of the round robin if it's having issues. 13:48:45 --> mconley has joined #instantbird 13:51:39 * qheaden_away is now known as qheaden 13:51:54 <qheaden> Hello. 13:55:46 <clokep_work> Good morning! 13:56:43 <aleth> qheaden: You were asking why use Set and Map. One advantage is that lookup is fast because they automatically take care of keeping the keys sorted for you. 13:57:04 * clokep_work isn't sure that's true compared to object notation. 13:57:10 <clokep_work> Probably for sets though. :) 13:57:34 <aleth> clokep_work: I think I looked at the implementation code at the time, so I'm fairly sure that's correct 13:57:36 <qheaden> Hmm okay. Cool. 13:57:43 <clokep_work> aleth: Oh cool. :) 13:57:45 <-- gerard-majax has quit (Ping timeout) 13:58:20 <qheaden> clokep_work: I tried to work on some more code after I came home last night. Didn't have the toothpicks to me my eyelids open though. :P 13:58:26 <qheaden> I plan on working all day today. 13:58:35 <clokep_work> qheaden: Me too. ;) 13:58:45 <aleth> clokep_work: Though of course the correct check would be to profile it ;) 14:00:36 <clokep_work> True. :) 14:00:44 <clokep_work> qheaden: I added a bit to the etherpad, take a look. 14:00:54 <qheaden> Okay. 14:01:51 <clokep_work> Unless you want your cheerios first. :) 14:02:00 <qheaden> clokep_work: Looks good. 14:02:23 * qheaden eats his cheerios after being on the computer for a bit. :) 14:11:23 --> jb has joined #instantbird 14:20:33 --> gerard-majax has joined #instantbird 14:34:43 <clokep_work> qheaden: So what's your plan for what's "next"? 14:36:52 <qheaden> clokep_work: First, I need to handle split TCP messages (that must be completed today), and work on buddy tagging. 14:37:20 <clokep_work> Excellent, that was my suggestion too. :) 14:37:26 <clokep_work> Write tests for the split messages, please. 14:37:38 <qheaden> I've had some real trouble with the split TCP messages. For some reason, the sum of my Yahoo packet sizes aren't matching up with the size of the ArrayBuffer data, although there are no half messages in the stream. 14:37:52 <qheaden> I'll do some more investigating today. 14:38:01 <clokep_work> Please ask if you want someone else to take a look at the code. 14:38:14 <qheaden> Okay. 14:38:45 <qheaden> I'll be back in a bit. 14:38:52 * qheaden is now known as qheaden_away 14:46:24 --> Nirgali has joined #instantbird 15:02:53 <-- aleth has quit (Quit: Ciao) 15:16:52 <-- jb has quit (Ping timeout) 15:40:16 --> jb has joined #instantbird 15:45:29 * qheaden_away is now known as qheaden 15:47:29 --> Optimizer has joined #instantbird 15:49:11 <-- Optimizer has quit (Ping timeout) 15:58:57 <-- jb has quit (Ping timeout) 15:59:58 --> Optimizer has joined #instantbird 16:11:38 <-- Optimizer has quit (Ping timeout) 16:13:00 --> Mook_as has joined #instantbird 16:15:26 --> Optimizer has joined #instantbird 16:50:00 <-- Optimizer has quit (sand.mozilla.org gravel.mozilla.org) 16:50:00 <-- qlum has quit (sand.mozilla.org gravel.mozilla.org) 16:50:00 <-- mpmc has quit (sand.mozilla.org gravel.mozilla.org) 16:50:00 <-- dionisos has quit (sand.mozilla.org gravel.mozilla.org) 16:53:26 <-- gerard-majax has quit (Ping timeout) 16:54:14 --> Optimizer has joined #instantbird 16:54:14 --> qlum has joined #instantbird 16:54:14 --> mpmc has joined #instantbird 16:54:14 --> qlum1 has joined #instantbird 16:54:41 --> dionisos has joined #instantbird 16:54:59 <-- qlum has quit (Ping timeout) 17:02:25 <-- Nirgali has quit (Ping timeout) 17:10:53 * clokep_work wonders where all our GSoC students... 17:11:41 <Mook_as> they were delicious. 17:11:45 <clokep_work> =-o 17:11:55 <clokep_work> Nom. Nom. 17:31:15 <clokep_work> qheaden: Ping. 17:36:29 <-- dionisos has quit (Ping timeout) 17:38:03 <-- dew has quit (Ping timeout) 17:43:28 --> dew has joined #instantbird 18:06:34 <-- Optimizer has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:06:40 --> Optimizer has joined #instantbird 18:07:49 <qheaden> clokep_work: Could you take a look at these two methods? One from YahooSession and the other from YahooPacket. http://pastebin.instantbird.com/228668 18:08:16 <qheaden> I'm trying to figure out why the two lengths aren't the same when I print them with Cu.reportError in _onBinaryDataReceived. 18:12:43 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 18:19:44 <qheaden> I think something fishy is going on with my _extractPackets method. 18:32:40 --> atuljangra has joined #instantbird 18:34:00 <clokep_work> qheaden: OK. 18:34:16 <clokep_work> qheaden: Did you start writing tests for it? That might help. 18:34:54 <clokep_work> qheaden: You should add a .length attribute to the packet which is the header + datalength. 18:35:02 * clokep_work dislikes that random + 20. ;) 18:35:03 <qheaden> Not yet. But I did some hex dumps of the data to the console, and for some reason, my decoded packet contains some extra junk at the end compared to the real data packet. 18:35:21 <qheaden> Okay. 18:35:34 <clokep_work> :-S 18:36:22 <clokep_work> qheaden: Is the packet header 10 or 20? 18:36:29 <qheaden> 20. 18:36:39 <clokep_work> qheaden: I'm actually really confused about what that function is doing in general. 18:36:46 <clokep_work> .substring(20)? 18:36:48 <clokep_work> Where is that from? 18:37:31 * clokep_work is slightly scared about turning that data into a string. :-/ 18:37:54 <clokep_work> qheaden: Is one of those header fields the length? 18:37:59 <clokep_work> You need to decode that and check it's right. 18:38:00 <clokep_work> Start w/ that. 18:38:56 <qheaden> clokep_work: I forgot to replace the .substring(20) with .substring(kPacketHeaderSize). Basically, it is ensuring that only the packet key/values, not the header, is included in the dataString variable. 18:39:47 <-- atuljangra has quit (Ping timeout) 18:44:56 --> atul_dinner has joined #instantbird 18:54:24 <clokep_work> qheaden: Yes, OK. 18:55:42 --> Nirgali has joined #instantbird 19:06:46 --> Mic has joined #instantbird 19:06:46 * ChanServ sets mode +h Mic 19:09:49 <clokep_work> qheaden: Any luck? 19:13:44 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 19:14:09 --> Mic has joined #instantbird 19:14:09 * ChanServ sets mode +h Mic 19:16:36 <qheaden> clokep_work: I can verify that the length field of the header is being decoded correctly. Now I'm just trying to compare and match it with the actual length of aData. 19:18:36 <qheaden> clokep_work: For example, the packets that are given after login (list, status, etc.) make the buffer 1116 according to aBuffer.byteLength. But when I add up the lengths of my packets (including the header size), I get only 992 bytes. 19:24:43 <clokep_work> qheaden: Hm. OK. I think I'll need to look at the data? 19:24:53 <clokep_work> It might auto-converting some stuff to Unicode, but that would be surprising... 19:33:43 <atul_dinner> clokep_work: I've named the interface as prplIFileTransfer.idl. Will that be good. I'll keep posting the updates in the etherpad 19:35:45 * atul_dinner is now known as atuljangra 19:38:53 <nhnt11> Hello 19:39:11 * nhnt11 reads scrollback 19:42:13 <clokep_work> atuljangra: Seems oK for now. 19:43:14 <atuljangra> Thanks :) Creating one in /instantbird/chat/components/public 19:43:48 <clokep_work> OK. 19:43:50 <Mic> nhnt11: does the tooltip of non-conversation tabs have an immensely large label for you as well? 19:44:04 <clokep_work> atuljangra: And you're going to attempt starting to implement it with XMPP, correct? 19:44:34 <atuljangra> clokep_work: yes :) 19:44:41 <nhnt11> Mic: It's not "immensly large" but it's a large bold font yes. 19:45:08 <Mic> It's far larger than tooltips normally are for me. 19:45:09 <nhnt11> Would you like me to change that? It didn't bother me so I left it as it is. 19:45:34 <nhnt11> Mic: It's the same size as, for example, the title of a conversation. 19:45:37 <Mic> Yes, please make it look like the tab tooltip in Firefox. 19:48:06 <nhnt11> Mic: Okay. I think we'll have to stop using buddytooltip and use the tooltip attribute for generic tabs then. 19:49:26 <Mic> I don't know the details here but it sounds like a good idea to not use the buddytooltip binding for this. 19:57:34 <qheaden> clokep_work: Okay, I'm getting closer. 19:58:04 <qheaden> clokep_work: After analyzing the dumps, it seems that the length field of my decoded packet is different from the one in the original data buffer. 19:58:20 <qheaden> I think something is up with my encoding and/or decoding code. 19:58:28 <qheaden> But I did write tests for it. 19:58:37 * qheaden is confused. :-S 19:59:19 <nhnt11> Mic: How about letting panels set the tooltips themselves 20:00:11 * qheaden is now known as qheaden_eating 20:01:09 --> Mnyromyr has joined #instantbird 20:03:47 <nhnt11> brb 20:05:27 <Mic> I don't expect many tabs to customize their tooltips, so taking the tab label and showing it in the tooltip is a good way to make it easier to write a custom tab and to avoid having no tooltip on it at all. 20:07:36 <Mic> (And we want to have a tooltip since it's the way to read the tab label if it is too long to be displayed completely on the tab.) 20:07:39 <clokep_work> qheaden_eating: So casting things to string is probably messing it up, are their weird characters in it that weren't in your sample messages? 20:22:31 * qheaden_eating is now known as qheaden 20:22:45 <qheaden> clokep_work: I don't notice any weird characters. 20:22:52 --> dionisos has joined #instantbird 20:23:33 * qheaden challenges himself to have this issue fixed before the day is out. 20:32:16 <-- atuljangra has quit (Ping timeout) 20:34:20 <nhnt11> I'm back 20:34:52 <nhnt11> Mic: Okay. We need to make sure though, that if the panel wants to set its own tooltip, the default one we set doesn't get in the way. 20:35:30 --> atuljangra has joined #instantbird 20:37:35 <nhnt11> Mic: Is it possible to link the tooltip to the tab label? i.e. The tooltiptext always equals the label attribute 20:38:19 <Mic> xbl:inherits="tooltiptext=label" or something? 20:38:57 <-- dew has quit (Ping timeout) 20:39:01 <nhnt11> Mic: Hmm. That should work I guess. Let me try. 20:42:08 <nhnt11> Mic: It doesn't work, and I think it's because buddytooltip is set as the tooltip for all tabs. 20:43:05 <Mic> Yeah, I thought this might not play nicely together. 20:43:40 --> dew has joined #instantbird 20:49:11 <Mic> aleth, maybe this helps: http://benjamin.smedbergs.us/interdiff/ ? 20:49:24 <qheaden> clokep_work: Okay, I found the issue. 20:50:19 <qheaden> clokep_work: The very first YMSG packet in a multi-packet TCP message is getting thrown out. This is obviously coming from _extractPackets. 20:51:57 <nhnt11> Mic: I'm trying to think of a clean way to do this. One way is to remove buddytooltip from tabbrowser and set it in the conversation binding. That way individual tabs can have whatever tooltip they want 20:52:58 <Mic> That is the tooltip is moved from the tabstrip to the conversation-tab? 20:53:10 <nhnt11> Right. 20:53:55 <nhnt11> Wait this is interesting. The new tab button's tooltip works fine. Maybe if I can find out how it's doing it... But I think moving buddyTooltip to the conversation binding still makes sense 20:54:28 <Mic> I'd need to see what changes to buddytooltip this entails... 20:54:31 <-- atuljangra has quit (Connection reset by peer) 20:55:06 <nhnt11> Mic: I don't think it requires any changes in buddyTooltip 20:56:33 <Mic> I'll rather look at your patch than this now by the way. 20:56:39 <nhnt11> Cool. 21:06:23 --> atuljangra has joined #instantbird 21:09:11 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:10:01 <clokep_work> qheaden: Cool! :) 21:12:03 <nhnt11> Mic: I got the tooltips working 21:12:11 <nhnt11> Let me get you a diff of my changes to examine at your leisure :) 21:13:07 <nhnt11> http://pastebin.instantbird.com/228766 21:13:10 <nhnt11> Mic^ 21:13:52 <Mic> Could you make your add-on work with pings by the way? 21:14:26 <nhnt11> I should. 21:32:41 <nhnt11> Mic: I'm going to bed, I'll try to have a patch ready for the about: pages by lunchtime tomorrow. 21:32:42 <nhnt11> Good night 21:32:45 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:32:56 <Mic> Good night! 21:34:18 <-- mconley has quit (Input/output error) 21:48:57 <-- atuljangra has quit (Ping timeout) 21:54:11 <-- Nirgali has quit (Ping timeout) 21:54:21 --> atuljangra has joined #instantbird 21:59:20 --> flo-retina has joined #instantbird 21:59:20 * ChanServ sets mode +qo flo-retina flo-retina 21:59:23 <Mic> We have a /time command on IRC but don't handle the response? :( 22:02:57 <instantbot> New Core - IRC bug 2011 filed by firstname.lastname@example.org. 22:03:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2011 min, --, ---, nobody, NEW, Unhandled IRC message: 391 22:07:56 <flo-retina> Mic: what's the point of the /time command? Why would we care about the local time at the IRC server's location? 22:08:29 <Mook_as> that's CTCP time, isn't it? (i.e. time of the other user) 22:08:41 <Mook_as> (useful for finding out people's time zones) 22:08:57 <Mic> hmm, the help for the command says that. 22:09:14 <Mic> How I actually tried to use it: "/time clokep_wor k". 22:09:43 <Mook_as> oh, I guess I assumed the sensible thing. bad Mook_as. 22:11:04 <Mic> Shouldn't we remove the command then if we 1st don't care and 2nd only 'show' the result in the error console? 22:12:43 <flo-retina> Mic: finding the local time of a user could be useful 22:12:58 <flo-retina> if there's no way to change it for that, then we should likely just get rid of it 22:14:02 <Mic> If we can get it, should we maybe display it on the tooltip then? 22:14:11 <flo-retina> Mic: have you replied to http://log.bezut.info/instantbird/130621#m91 (I can't find an answer in the log, but mine is "yes it's fine") 22:14:48 <Mic> I haven't answered that. 22:14:56 <Mic> nhnt11: ^ 22:15:00 <flo-retina> Mic: querying the server while displaying the tooltip is OK; sending something to the remote user isn't IMHO 22:20:20 <qlum1> clokep_work if you are still here I pasted some more logs and I may add here that for me the only odd thing I could see in the logs is a blank of 6 minutes or so before every disconnect 22:27:19 <clokep_work> qlum1: I'm at work still. 22:28:12 <qlum1> at this hour, on a Saturday, wow. 22:30:14 <qheaden> clokep_work: Its Friday in our timezone. :) 22:30:20 <clokep_work> qheaden: Umm...Friday? 22:30:24 <clokep_work> Booo. 22:30:27 <clokep_work> Tab complete fail. 22:31:18 <qheaden> Aw man, tab complete fail indeed. That was directed to qlum1. :P 22:31:36 <-- atuljangra has quit (Ping timeout) 22:31:54 <clokep_work> And then mine got directed to you. :( 22:32:07 <qheaden> lol 22:33:06 <clokep_work> qlum1: Can you attach them instead of pastebining them? 22:33:44 <flo-retina> Mic: what's the status with the tabbrowser patch? 22:33:55 <flo-retina> are you actively reviewing it? Should I have a look at it or wait? 22:34:03 <Mic> flo-retina: I'm still reviewing it. 22:34:43 <clokep_work> qlum1: And yes, at this time on a Friday. ;) 22:34:50 <flo-retina> does it look like it will be r+ with trivial change, or take at least another iteration? 22:35:19 <qlum1> yea I just got a bit confused with flo and you having the same color and flo saying he had the same time zone as me yesterday 22:36:00 <clokep_work> Mic: /ctcp clokep_work TIME 22:36:07 <Mic> pah. 22:36:37 <Mic> flo-retina: I've only seen trivial code changes and some nits on comments and formatting so far. 22:37:23 <Mic> "I've only had to make comments on ..." 22:37:35 --> mconley has joined #instantbird 22:37:48 <qlum1> /ctcp clokep_work TIME 22:38:03 <qlum1> fail 22:38:10 <qlum1> not even wanted to to do that 22:38:14 <flo-retina> atuljangra: next time you create a pad with a content like https://etherpad.mozilla.org/e3uXWiSXhL, please give it a name easy to find in the awesome bar, thanks :) 22:38:29 --> FireFly_TB has joined #instantbird 22:38:42 <flo-retina> Mic: ok, thanks. 22:38:48 <qlum1> anyway any particular format to attach it in, if not I will just do txt 22:38:59 <clokep_work> Mic: We should change that command to that ^ 22:39:30 <flo-retina> I'm trying to decide if polishing the slides for the webrtc presentation I'll be giving tomorrow at 2pm or looking at the tabbrowser patch is a better plan for the ~30min I intend to spend online before going to bed. 22:41:16 <Mook_as> clokep_work: /time with an argument = ctcp time, /time with no arguments = server time? :p 22:41:51 <Mook_as> (the other possibly useful option is /time with no arguments = ctcp time myself.... XD ) 22:42:29 <clokep_work> Mook_as: Reasonable. 22:43:38 <flo-retina> Mook_as, clokep_work: I guess anybody should feel free to morph Mic's bug then ;) 22:43:44 <-- mconley has quit (Ping timeout) 22:44:04 <Mic> flo-retina: I wanted to WONTFIX it and file a new one to change the command. 22:44:47 --> mconley has joined #instantbird 22:44:49 <clokep_work> Mic: Just morph it. 22:44:57 <clokep_work> I'll review it on my phone later. 22:45:16 <flo-retina> clokep_work: how do you feel about Mossop's comments about logging? 22:48:44 <clokep_work> I haven't seen it. 22:49:21 <Mic> Do event handlers need to specify a parameter for the event if they're not going to use it? 22:53:20 --> wnayes has joined #instantbird 22:58:02 <flo-retina> Mic: no 22:58:21 <Mic> flo-retina: thanks 23:03:48 <-- FireFly_TB has quit (Quit: FireFly_TB) 23:08:20 --> jb has joined #instantbird 23:11:29 <clokep_work> flo-retina: Should we just rip it out? 23:11:42 <clokep_work> flo-retina: What do you think about passing in an object, by the way? 23:14:38 <flo-retina> how much changes does it require on our side? 23:15:09 <flo-retina> bah, it looks like we have a single call at http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#502 23:16:04 <-- jb has quit (Ping timeout) 23:16:06 <flo-retina> can we do some tinkering before that call to make the logger object looks like what he expects (ie a console object) 23:16:10 <qheaden> clokep_work: This looks like a problem involving packet encoding/decoding. I'm going to have to continue looking at it over the weekend. 23:16:25 <flo-retina> I also wonder if it would be a good idea to investigate console objects to see if we could use them 23:16:38 <qheaden> It is a blocking problem too. I don't want to make anymore progress until it is fixed. 23:16:50 <flo-retina> there's both a global console (that fully replaces the error console in Fx 24) and a per-tab console, so maybe we could have a per-account console? 23:21:29 <-- mconley has quit (Ping timeout) 23:27:39 <clokep_work> flo-retina: Fancy. :) 23:27:41 --> mconley has joined #instantbird 23:27:46 <clokep_work> We could probably pull it out now and then add it back in. 23:27:56 <clokep_work> flo-retina: Yes, we only have one caller. So...do you have any opinon? 23:29:13 <flo-retina> I would need to have a closer look at the console stuff to have a real opinion 23:32:28 <flo-retina> I would probably be annoyed to not have any logging if I wanted to hack on twitter 23:32:32 <flo-retina> but is that really going to happen? 23:38:54 <-- mconley has quit (Input/output error) 23:39:36 <flo-retina> Good night 23:39:37 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 23:51:41 <clokep_work> Goodnight. 23:51:44 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)