#instantbird log on 06 18 2013

All times are UTC.

00:11:58 <flo-retina> clokep: would it be easier for you to get an sql dump of our current install, and to install a bugzilla running on your local server?
00:12:14 <flo-retina> s/easier/faster/
00:12:46 <clokep> flo-retina: It'd probably be faster yes. I was hoping to do this once I get my server up and running.
00:14:31 <flo-retina> Good night
00:14:32 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
00:14:39 <clokep> Goodnight. :)
00:23:36 * clokep thought flo was going to push that patch. :(
00:52:41 <-- mpmc has quit (Connection reset by peer)
00:53:33 <-- wnayes has quit (Ping timeout)
00:53:42 <-- Mook_as has quit (Quit: Mook_as)
00:57:52 --> wnayes has joined #instantbird
01:14:46 <-- wnayes has quit (Quit: wnayes)
01:27:26 <-- wuwei|lab|afk has left #instantbird (Leaving)
02:06:59 --> Mook has joined #instantbird
02:19:19 <-- clokep has quit (Ping timeout)
02:35:47 --> Kaishi has joined #instantbird
02:35:50 <-- Kaishi has quit (Connection reset by peer)
02:36:08 --> Kaishi has joined #instantbird
02:57:55 <-- EionRobb has quit (Ping timeout)
03:11:01 <instant-buildbot> build #875 of macosx-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/875
03:11:34 <instant-buildbot> build #883 of linux-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/883
03:18:28 --> EionRobb has joined #instantbird
04:22:15 --> jb has joined #instantbird
04:25:01 <-- jb has quit (Ping timeout)
05:17:05 --> Optimizer has joined #instantbird
05:46:54 <-- Optimizer has quit (Ping timeout)
05:49:03 --> Optimizer has joined #instantbird
05:50:08 --> FireFly_TB has joined #instantbird
05:55:38 <instant-buildbot> build #978 of win32-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/978
05:56:22 <-- Optimizer has quit (Ping timeout)
05:58:03 <-- EionRobb has quit (Ping timeout)
06:07:38 <-- FireFly_TB has quit (Quit: FireFly_TB)
06:12:56 <-- Mook has quit (Quit: Mook)
06:27:23 --> jb has joined #instantbird
06:35:40 --> EionRobb has joined #instantbird
06:55:10 <-- jb has quit (Ping timeout)
07:11:04 --> jb has joined #instantbird
07:19:39 --> Mic has joined #instantbird
07:19:39 * ChanServ sets mode +h Mic 
07:20:42 <Mic> Hello.
07:26:39 <Mic> nhnt11: the buddy list tab is very nice already!  I almost could't stop playing with it ;)
07:38:54 --> Optimizer1 has joined #instantbird
07:40:37 <-- Optimizer1 has quit (Ping timeout)
07:45:39 <-- jb has quit (Ping timeout)
07:47:52 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
07:48:05 --> Mic has joined #instantbird
07:48:05 * ChanServ sets mode +h Mic 
07:53:29 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
07:53:42 --> Mic has joined #instantbird
07:53:42 * ChanServ sets mode +h Mic 
07:55:53 <-- Mic has quit (Connection reset by peer)
07:55:58 --> Mic has joined #instantbird
07:55:58 * ChanServ sets mode +h Mic 
08:03:20 --> qlum has joined #instantbird
08:08:14 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:16:32 --> jb has joined #instantbird
08:17:38 --> Mic has joined #instantbird
08:17:38 * ChanServ sets mode +h Mic 
08:20:52 <Mic> Imgur is sucking again :(
08:26:27 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:28:50 <-- jb has quit (Ping timeout)
08:32:47 --> nhnt11 has joined #instantbird
08:33:14 <nhnt11> Good morning!
08:33:20 * nhnt11 slept for 11 hours
08:33:26 <nhnt11> Thanks Mic!
08:36:57 * qlum knows something is wrong with his life when he is proud about waking up before 10 in the morning
08:37:53 <-- gerard-majax has quit (Ping timeout)
08:43:11 * nhnt11 wonders if Awesometab could maintain a cache of contacts in the background so that loading them is instant.
08:55:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f6fee45a1dd1 - Patrick Cloke - Bug 488 - Missing Commonly Used Emoticon, r=Mic.
08:55:12 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/83ddae231f8f - Patrick Cloke - Bug 1554 - IRC should notify the user when messages couldn't be sent: fix test bustage, r=bustage-fix.
08:56:42 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:56:51 --> nhnt11 has joined #instantbird
09:00:26 <nhnt11> Oh no
09:00:44 <nhnt11> I should've seen bug 488, I would've suggested to add :/ and :\ as well
09:00:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=488 nor, --, ---, nobody, NEW, Missing Commonly Used Emoticon
09:05:26 <instant-buildbot> build #402 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/402
09:06:29 --> flo-retina has joined #instantbird
09:06:30 * ChanServ sets mode +qo flo-retina flo-retina 
09:33:06 --> gerard-majax has joined #instantbird
09:38:22 --> jb has joined #instantbird
09:55:30 --> Mic has joined #instantbird
09:55:30 * ChanServ sets mode +h Mic 
09:56:09 <-- Mic has quit (Connection reset by peer)
09:56:49 --> Mic has joined #instantbird
09:56:50 * ChanServ sets mode +h Mic 
10:00:05 <Mic> flo-retina, nhnt11: regarding the icon of the new conversation tab, I'd create a dotted (placeholder) version of the "Start conversation" bubble if you like.
10:02:20 <flo-retina> Mic: fine wiht me
10:02:21 <flo-retina> *with
10:02:30 --> clokep has joined #instantbird
10:02:30 * ChanServ sets mode +o clokep 
10:02:43 --> mpmc has joined #instantbird
10:10:39 <nhnt11> Mic: Sounds great!
10:12:06 <nhnt11> Weird. For some reason my scroll wheel isn't working in the conversation window
10:12:21 <nhnt11> Works in the participant list too, but not in the messages box
10:12:37 <nhnt11> Putting the conversation on hold and reopening fixed it.
10:14:49 <nhnt11> Happened again. This has something to do with awesometab.
10:14:57 <nhnt11> Opening and closing an awesometab fixed it
10:15:12 * nhnt11 investigates
10:15:58 <clokep> Mic: Did imgur ever not suck? :)
10:16:27 <nhnt11> Interesting, I've got two "Image corrupt or truncated: smile://:)" errors in my console
10:17:06 * nhnt11 can't reproduce :/
10:17:10 <nhnt11> That sounded wrong.
10:17:14 <nhnt11> I meant the error.
10:17:23 <instantbot> clokep@gmail.com set the Resolution field on bug 488 to FIXED.
10:17:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=488 nor, --, 1.5, clokep, RESO FIXED, Missing Commonly Used Emoticon
10:19:25 <instantbot> New Instantbird (UI) bug 2008 filed by clokep@gmail.com.
10:19:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2008 min, --, ---, nobody, NEW, Missing some emoticon
10:19:42 <nhnt11> Does setting an array to null automatically set all elements of the array to null?
10:19:44 * nhnt11 thinks it should.
10:19:47 <flo-retina> clokep: yes, it used to be usable (like a year ago or so)
10:21:36 * clokep was being facetious. :)
10:21:51 * clokep thinks it would be nice if we had filelink providers for images btw. :)
10:22:16 <clokep> nhnt11: File a new bug if you want to add more emoticon text codes...
10:22:32 <nhnt11> clokep: That would be cool! Drag and drop images to send via filelink
10:22:35 <nhnt11> Okay.
10:25:38 * nhnt11 wonders if :/ and :\ aren't supported due to them getting mixed in file paths like C:\ and http:// etc
10:29:30 <nhnt11> Mic: If you're using an awesometab build right now, could you see if you can reproduce this bug with the scrolling?
10:30:45 --> nhnt12 has joined #instantbird
10:32:35 --> dionisos has joined #instantbird
10:33:46 <clokep> nhnt11: Links shouldn't be an issue.
10:33:57 <clokep> We don't smilify things in links.
10:34:13 <nhnt11> Ah cool.
10:34:28 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:35:17 <flo-retina> nhnt11: we don't want :/ and :\ (or other text codes that could have too many false positives)
10:36:28 <flo-retina> I just tried "Instruments" (a more recent Mac profiler than "Shark" I was using before). It's really nice.
10:38:03 <clokep> :)
10:40:55 <nhnt11> I think my goal for today is to fix up these performance issues I'm having
10:41:49 <clokep> Is your code at a place someone should look at it?
10:42:08 <nhnt11> clokep: Possibly, yes. I have a patch exported too that I was going to attach soon
10:44:06 <Mic> Sorry, no time to read backlog, gtg
10:44:09 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:54:05 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:02:09 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:14:44 --> nhnt11 has joined #instantbird
11:18:26 <nhnt11> flo-retina: Do you know what kind of userbase Instantbird has right now?
11:18:36 <nhnt11> By userbase I mean number of users
11:23:33 <qlum> I can tell you at least 25 people
11:23:51 <nhnt11> qlum: :)
11:25:53 <-- Tonnes has quit (Connection reset by peer)
11:44:41 <flo-retina> nhnt11: http://ftp.instantbird.com/instantbird/stats/
11:45:28 <flo-retina> we are counting update pings, not users. The daily userbase is likely 2-3 times the update pings we get (lots of people don't keep their IM client open 24hours a day), and the total userbase is likely more than the daily userbase.
11:45:44 <nhnt11> That's cool
11:45:49 <flo-retina> so around 10,000 people seems a 'possible' estimate
11:45:53 <nhnt11> So easily >10k people?
11:45:55 <nhnt11> Cool.
11:46:05 <flo-retina> nhnt11: I'm sure we could have many more if we didn't suck so much at marketing
11:46:27 <nhnt11> flo-retina: I was about to suggest getting people to do some marketing :P
11:46:37 <nhnt11> I know a few people who are good at making people use software :P
11:48:58 --> clokep_work has joined #instantbird
11:48:59 * ChanServ sets mode +o clokep_work 
11:58:30 --> Tonnes has joined #instantbird
12:09:55 <clokep_work> nhnt11: "making" is not exactly the same as "marketing" ;)
12:10:24 <clokep_work> But yeah, "getting people to do some marketing" isn't an easy task, OSS generally attracts people interested in improving the software and not so much in the marketing.
12:24:52 * qheaden_away is now known as qheaden
12:24:58 <qheaden> Hi all!
12:28:00 <clokep_work> Good morning.
12:28:58 <qheaden> I should be pushing a patch later today. Just have to iron out a few things.
12:32:20 <clokep_work> Awesome. :)
12:35:02 <flo-retina> nhnt11: if you have ideas for ways to do marketing, don't hesitate to talk to us about them ;)
12:35:32 <flo-retina> as long as it doesn't require much work from us and respects our values, we are likely to be interested
12:36:05 <qheaden> clokep_work: What is the purpose of the getNormalizedUsername() method on buddies?
12:36:19 <clokep_work> Hahaha.
12:36:22 * clokep_work sighs.
12:36:36 <clokep_work> qheaden: The purpose is to make me hit my head against a wall repeatedly. :)
12:36:51 <qheaden> :)
12:36:53 <clokep_work> qheaden: For Yahoo, I believe it should just be .toLowerCase().
12:37:01 <qheaden> Okay. :P
12:37:03 <clokep_work> The Idl has a comment in it though.
12:38:12 <clokep_work> qheaden: http://lxr.instantbird.org/instantbird/source/chat/components/public/prplIConversation.idl#96
12:38:19 <clokep_work> (I assume that's what you mean...)
12:38:28 <qheaden> Yes. Thanks.
12:38:34 <clokep_work> Otherwise, I'm not sure what you're talking about. :-/
12:38:47 <clokep_work> That's part of a chat room though, so what are you working on? :-S
12:38:54 <qheaden> I got the method name wrong. :)
12:39:14 <flo-retina> bah, someone emailing me questions about debugging talkilla at flo AT ib.org :-S
12:39:43 <qheaden> clokep_work: I just wanted to know if it was designed to return the username plus the @yahoo.com suffix. I wasn't sure.
12:39:58 <clokep_work> qheaden: It's designed to do whatever you do it as. ;)
12:40:13 <clokep_work> Internally you probably need to decide how to keep usernames.
12:40:17 <qheaden> I'm trying to figure out if the add buddy packet needs that suffix. I'm going to Wireshark the current implementation to find out.
12:40:22 <clokep_work> Do they have the email suffix? If so, do they have the @yahoo.com suffix?
12:40:43 <clokep_work> Cool.
12:53:06 <clokep_work> flo-retina: Is the "id" field in a <message> over XMPP something I need to anonymize?
12:53:48 <flo-retina> I don't think so
12:57:26 <instantbot> clokep@gmail.com set the Resolution field on bug 2000 to DUPLICATE of bug 1979.
12:57:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2000 nor, --, ---, nobody, RESO DUPLICATE, New Google hangout users are shown to be typing when in fact they are not
12:57:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1979 nor, --, ---, nobody, NEW, "Typing" indicator is never cleared.
12:58:53 * clokep_work just added an XMPP log to bug 1979
13:01:04 <qheaden> clokep_work: How can I tell when a user added a new contact in Instantbird other than the addBuddy() method?
13:03:18 <clokep_work> qheaden: What do you mean? :-S
13:03:34 <clokep_work> The addBuddy method should always be called, are you seeing it not called?
13:08:33 <flo-retina> we really need to have a log viewer :(
13:09:14 <qheaden> clokep_work: It is being called, but it is also called for each buddy in the list sent on login. I just want to know when the user adds a new contact to their list (not coming form the server) so I can send an add-contact packet to the YahooServers.
13:10:16 <clokep_work> qheaden: Oh, I see.
13:10:42 <clokep_work> flo-retina: ^ Any idea of the method?
13:11:04 <clokep_work> qheaden: IT looks like there's supposed to be an "addBuddy" and a "loadBuddy" http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#71
13:12:26 <nhnt11> I could probably benefit from that too
13:12:34 <nhnt11> Awesometab needs to listen for newly added buddies
13:12:36 <qheaden> clokep_work: Ahh I see my problem. I have both methods, but I am calling addBuddy from YahooSession on a buddy list packet. I need to call loadBuddy.
13:12:41 * nhnt11 reads a bit more scrollback
13:13:25 <clokep_work> qheaden: OK.
13:13:35 <flo-retina> qheaden: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#71
13:13:42 <flo-retina> the comment says addBuddy is for when the user adds it
13:14:01 <clokep_work> qheaden: I think loadBuddy is what we're storing locally, not when you read from the server.
13:14:17 <flo-retina> qheaden: for dealing with the list received from the server, you need these methods: http://lxr.instantbird.org/instantbird/source/chat/components/public/imIContactsService.idl#27
13:15:12 <qheaden> Okay I see. I'm using these methods, but just in the wrong spots. Thanks for the clarification.
13:15:34 <flo-retina> np :)
13:16:21 <clokep_work> flo-retina: Lightning just started using http.jsm...
13:16:34 <flo-retina> link? :)
13:16:38 <flo-retina> or :(
13:16:42 <clokep_work> flo-retina: https://bugzilla.mozilla.org/show_bug.cgi?id=853236
13:16:46 * clokep_work can't view that.
13:16:47 <clokep_work> :(
13:16:52 <clokep_work> http://hg.mozilla.org/comm-central/rev/723ed450d2e7 is the changeset
13:17:13 <flo-retina> in a bugt marked security sensitive?
13:17:44 <flo-retina> the whiteboard says "private for non-security reasons." :-S
13:19:01 <clokep_work> flo-retina: There's an API key in plaintext in it apparently.
13:19:06 * clokep_work is talking to Fallen in #calendar
13:19:25 <flo-retina> and they added an OAuth2.jsm :-S
13:22:34 <clokep_work> flo-retina: http://pastebin.instantbird.com/225930 backlog
13:30:24 <flo-retina> thanks
13:37:32 <clokep_work> np
13:37:52 * clokep_work thinks we need to get IB into c-c to stop dealing with this stuff. :(
13:38:23 <-- nhnt11 has quit (Ping timeout)
13:43:38 <flo-retina> clokep_work: It's not clear to me if forking this oauth file was really needed, but thinking about oauth makes my head hurt, so it's OK with me if they do whatever they want as long as it's in calendar/
13:43:58 <flo-retina> clokep_work: in that backlog you said we planed to move it to chat/, didn't you mean to toolkit/
13:45:48 <clokep_work> flo-retina: No.
13:46:36 <clokep_work> We discussed this a few weeks ago that since the FileLink project was accepted we could move FileLink to be under chat and then the http.jsm that is in mail could go away.
13:47:30 <flo-retina> really?
13:47:43 <flo-retina> has Mark seen that/agreed to that?
13:48:18 <clokep_work> mconley agreed to it. ;)
13:48:47 <clokep_work> We can still do it the other way if you want. We just need to file a bug and create a (trivial) patch.
13:49:30 <flo-retina> I don't mind, just surprised ;)
13:50:21 <clokep_work> I think Mark wasn't at that meeting. :)
13:50:31 <flo-retina> and apparently Mark hasn't heard about it either
13:50:42 <flo-retina> (he's sitting in front of me, we are in a work week)
13:51:51 <clokep_work> I think it was in the status update.
13:51:55 <flo-retina> ok
13:52:01 <flo-retina> he missed lots of these meetings
13:52:04 <flo-retina> and so did I ;)
13:52:11 <clokep_work> :P
13:52:54 <clokep_work> flo-retina: https://wiki.mozilla.org/Thunderbird/StatusMeetings/2013-05-28
13:54:04 <flo-retina> wait, a meeting with actual notes? really? :)
13:55:36 <clokep_work> Yes. ;)
13:55:44 <clokep_work> I think I actually put those on the wiki too.
13:55:47 * clokep_work was conned into it.
13:56:00 * clokep_work is getting really frustratred by Google Hangouts.
13:56:48 <-- Kaishi has quit (Quit: Kaishi)
14:01:05 --> mconley has joined #instantbird
14:01:14 * qheaden got buddy adds on the server working.
14:07:51 <-- mconley has quit (Connection reset by peer)
14:07:56 --> mconley_ has joined #instantbird
14:15:47 <qheaden> clokep_work: I notice that imIAccount.idl shows an addBuddy() method, but no remove buddy method. How might I know if a buddy has been removed?
14:16:33 <clokep_work> qheaden: No idea. :) I had thought about that too.
14:17:02 <qheaden> :P
14:17:15 * qheaden wonders how he will remove buddies from the Yahoo servers.
14:19:16 * clokep_work wonders if the accountbuddy does it.
14:23:26 <flo-retina> qheaden: if the user removes a buddy, http://mxr.mozilla.org/comm-central/source/chat/components/public/imIContactsService.idl#230 is called
14:24:38 <qheaden> flo-retina: Ahh okay.
14:47:22 * mconley_ is now known as mconley
14:55:15 <qheaden> clokep_work, flo-retina: Okay guys. I got buddy adding/removing working thanks to the help from both of you. :) 
14:58:36 <clokep_work> qheaden: Sure thing. :)
14:58:46 <clokep_work> qheaden: Are you making commits through out this?
14:58:51 <clokep_work> (You should be, in case you break something.)
14:59:07 <clokep_work> It's also a lot easier for me to review small commits than one huge commit.
14:59:49 <qheaden> clokep_work: I haven't made many commits. I'm going to just use the hg record extension to break things up.
15:00:16 <clokep_work> OK.
15:00:43 <clokep_work> So you're not planning to make any more commits? :-S
15:01:00 <qheaden> Nope! LOL. Just kidding.
15:01:08 <qheaden> I mean when I push later on today.
15:01:20 <clokep_work> OK
15:01:31 <qheaden> I got caught up in trying to integrate the whole buddy system until I forgot to make smaller commits. So I have to use hg record to make them before I push.
15:02:07 <clokep_work> OK
15:02:09 <-- EionRobb has quit (Quit: Leaving.)
15:02:26 --> EionRobb has joined #instantbird
15:02:33 <clokep_work> It's probably not worth your time to go back and make them smaller?
15:03:11 <qheaden> Well, the commit shouldn't be that big. And all of the code relates to the buddy system. So it might be easier to review one larger commit in this case.
15:03:19 <qheaden> Since the code is very much linked,
15:04:07 <clokep_work> That's fine. :)
15:04:13 <clokep_work> Don't waste time reorganizing your commits.
15:04:14 <qheaden> :)
15:04:15 <-- EionRobb has quit (Ping timeout)
15:04:20 <clokep_work> So what's "next" then?
15:04:38 <qheaden> Accepting buddy requests from others.
15:05:04 --> nhnt11 has joined #instantbird
15:05:16 <nhnt11> Hello
15:05:28 <qheaden> Hey.
15:05:39 <nhnt11> I had to go for a while :(. I'm going to upload a patch on bug 1583 now.
15:05:41 <clokep_work> qheaden: Excellent. :) Does changing groups/tags work already?
15:05:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1583 enh, --, ---, nhnt11, ASSI, Awesometab (GSoC 2013)
15:05:59 <-- jb has quit (Ping timeout)
15:06:42 <qheaden> clokep_work: Not yet. I have to work on that also. Although it should be fairly simple to implement.
15:07:13 <qheaden> Our YahooPacket class makes communication very simple.
15:07:53 <clokep_work> Sure.
15:08:05 * clokep_work wondres if Yahoo allows a contact to be in multiple groups.
15:08:29 <qheaden> I don't think so. Well, I've never seen it, but I will investigate.
15:10:01 <clokep_work> If not we'll figure it out. :)
15:10:07 <qheaden> :)
15:11:53 * nhnt11 wonders if he can add a previous commit to a new mercurial queue.
15:12:10 <nhnt11> qimport -r should probably work.
15:13:35 --> Optimizer has joined #instantbird
15:17:12 <clokep_work> nhnt11: Excellent. :) Are you being blocked by reviews?
15:17:39 <nhnt11> clokep_work: Just a bit :)
15:17:53 <nhnt11> I didn't maintain my queue's properly
15:18:02 <clokep_work> OK. :) I know flo is busy this week, but hopefully he can get to ti soon...
15:18:05 <nhnt11> So it may be easier for me to upload a patch if the tabbrowser changes are checked in.
15:18:52 <nhnt11> Actually I think I did all the new stuff in a different branch so maybe I can diff between two branches...
15:18:54 * nhnt11 tries
15:19:52 <nhnt11> It works. Phew.
15:20:28 <nhnt11> I like working with branches, but I think I should start making better use of queues.
15:22:10 * clokep_work has a feeling you're trying to use Hg branches like git branches...
15:22:27 <nhnt11> clokep_work: No, git branches are way more confusing
15:22:46 * nhnt11 remembers having a hard time with $git rebase
15:24:33 * qheaden wonders what instantbot thinks of git.
15:28:44 <nhnt11> instantbot seems to not like git
15:28:47 <nhnt11> instantbot: git
15:28:48 <instantbot> nhnt11: Sorry, I've no idea what 'seems to not like git' might be.
15:28:49 <instantbot> nhnt11: git is making my head hurt :(
15:29:07 <nhnt11> A few minutes ago it said "I've no idea what 'git' might be." ;)
15:31:20 --> atuljangra has joined #instantbird
15:31:44 <atuljangra> Hello Everybody :)
15:32:09 <nhnt11> Hey atuljangra
15:32:19 <qheaden> Hey there atuljangra. :)
15:32:40 <qheaden> atuljangra: You're working on file transfers right?
15:32:48 <atuljangra> Hi nhnt11:)
15:32:51 <atuljangra> qheaden: yes :)
15:33:09 * qheaden cannot wait until file transfers are complete. He wants them. :)
15:33:20 * atuljangra \o/
15:39:13 <qheaden> clokep_work: Please note that this next patch doesn't work on the feedback you gave on the last one. It is exclusively buddy code. My next patch will work on your last feedback.
15:39:48 <clokep_work> OK.
15:42:22 * qheaden pushes commits and waits nervously for code review. :P
15:43:13 <atuljangra> qheaden: are you also using bitbucket?
15:43:41 <qheaden> atuljangra: Yes. https://bitbucket.org/qheaden/instantbird-gsoc-2013
15:43:52 <atuljangra> Thanks :-)
15:44:18 <clokep_work> I don't read them until I get the email. ;)
15:44:22 <clokep_work> Let's me keep track of what I've done.
15:44:49 * qheaden hopes BitBucket's mail servers are slow today. :P
15:55:47 <clokep_work> qheaden: Well the first two commits look good. ;)
15:56:07 <qheaden> clokep_work: Feel free to skip the third one. :)
15:56:42 <-- atuljangra has quit (Ping timeout)
15:57:20 <clokep_work> Actually...I'm not sure about that.
16:03:17 <qheaden> clokep_work: I'm not sure if partial packets are possible, since the messages are very short.
16:07:29 <clokep_work> qheaden: It's possible.
16:08:29 <qheaden> clokep_work: Perhaps I can add a byteLength value to YahooPacket, and simply count up the lengths of each packet returned by _extractPackets. Whatever is left can be replayed.
16:09:04 <clokep_work> qheaden: Or just have _extractPackets return the number of bytes that were handled or something, yes.
16:09:15 * clokep_work wonders if extraPackets is really needed. :p
16:10:29 <qheaden> clokep_work: It makes for a cleaner onBinaryDataReceived.
16:12:14 <clokep_work> qheaden: Also I still thikn "onTcpResponse" or whatever is an awful name.
16:12:22 <clokep_work> How is that different than _onBinaryDataReceived?
16:12:45 <qheaden> clokep_work: Yeah, you mentioned that in your last feedback. I'll fix it in my next patch. :)
16:13:42 <clokep_work> OK. :)
16:16:51 <clokep_work> qheaden: Each packet includes the length it is supposed to be?
16:17:27 --> atuljangra has joined #instantbird
16:18:41 <qheaden> clokep_work: No, but I'm thinking about adding that.
16:31:28 <nhnt11> atuljangra: Not sure if it comes directly under your project, but perhaps we could get Facebook image attachments to work? :)
16:31:45 <nhnt11> To display inline or something I mean.
16:32:56 <atuljangra> nhnt11: Sure, if fb provides that API.
16:33:16 <nhnt11> I have no clue, it was just a suggestion to look into it :)
16:34:36 <atuljangra> nhnt11: Yes, Thanks :)
16:36:37 <-- gerard-majax has quit (Ping timeout)
16:41:38 <qheaden> Going to have some lunch.
16:41:41 * qheaden is now known as qheaden_away
16:44:36 --> Mook_as has joined #instantbird
16:48:19 <-- Optimizer has quit (Connection reset by peer)
16:55:33 --> Optimizer has joined #instantbird
16:58:22 <-- mpmc has quit (Connection reset by peer)
17:01:22 <-- qlum has quit (Quit: Getting the <censored> out.)
17:02:53 --> qlum has joined #instantbird
17:22:15 <nhnt11> Around how much memory does Ib usually use for you guys?
17:23:56 <Mook_as> my copy is currently ~100M (started just over 24 hours ago)
17:25:32 <nhnt11> Okay. Mine's at 240M, started 5 hours ago maybe.
17:25:36 <-- atuljangra has quit (Client exited)
17:26:16 <Mook_as> (it currently only has blist open; I don't use that as an IRC client)
17:27:17 <Mook_as> thunderbird, which I do use for IRC (and nothing else...), is at 250, started an hour ago. (tbird daily, linux)
17:27:30 <nhnt11> Cool.
17:28:29 <qlum> 74.3mb and I last rebooted my computer and instantbird 30 minutes ago
17:29:11 <qlum> now its on 75.0
17:29:16 <nhnt11> I was checking if awesometab had any memory problems with the dynamic buddy list
17:29:52 <nhnt11> I should do a non-awesometab build and check, to see how much memory it takes usually on Mac
17:30:00 <nhnt11> (That could be a factor, I think)
17:30:21 <qlum> I don't know much about mac's but isn't 64 vs 32 bit also a factor
17:30:33 <qlum> I run on windows 8 64bit btw
17:30:42 <nhnt11> Mac is 64 bit.
17:31:09 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:31:09 <nhnt11> I'm running a fresh instance of instantbird, it's using 175M and climbing
17:31:21 <nhnt11> (No awesometab launched yet)
17:31:28 <nhnt11> So I guess Awesometab is fine :)
17:31:52 --> nhnt13 has joined #instantbird
17:33:34 <clokep_work> qheaden_away: That's how you'd tell if you got a full packet or not, You definitely should be checking that.
17:33:56 <clokep_work> nhnt11: atuljangra is mostly supposed to work on getting the framework in place and then FileLinks for IM, not really just adding random file transfer providers.
17:34:39 <nhnt11> Okay, I'm able to reproduce the scrolling bug now. If I switch away from a conversation window, and switch back to it, scrolling is extremely laggy, so much so that I thought it completely stopped working at first. However, if I switch to a different tab, everything is back to normal.
17:34:52 <nhnt11> clokep_work: Sure, it was just a thought really.
17:35:07 <clokep_work> nhnt11: I filed a bug on it. :-D
17:35:23 <nhnt11> clokep_work: Facebook? or the scrolling thing??
17:36:00 <-- nhnt13 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:36:16 <clokep_work> Facebook.
17:36:22 <nhnt11> :(
17:36:30 * nhnt11 hoped for a second that the scrolling thing was not his fault
17:37:29 <nhnt11> Hmm. It seems tabbrowser related, because it happens even without ever spawning an awesometab
17:41:17 <nhnt11> I just tried a non-awesometab build with only tabbrowser stuff, it's definitely something with the tabbrowser :(
17:41:55 <clokep_work> qheaden_away: I'm done looking over that stuff.
17:43:32 --> atuljangra has joined #instantbird
17:43:45 <-- atuljangra has quit (Quit: )
17:45:26 --> atuljangra has joined #instantbird
17:45:40 --> jb has joined #instantbird
17:45:45 * atuljangra ib doesn't connect me to IRC :-/
17:45:50 <-- jb has quit (Connection reset by peer)
17:47:10 <atuljangra> Error : http://pastebin.instantbird.com/226106
17:47:23 <instantbot> clokep@gmail.com set the Resolution field on bug 1247 to WONTFIX.
17:47:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1247 nor, --, ---, nobody, RESO WONTFIX, Shutdown crash [@ js::mjit::ic::BasePolyIC::releasePools() ]
17:48:22 <clokep_work> atuljangra: That's unrelated.
17:48:37 <clokep_work> It happens if you don't have Bonjour/Avahi installed.
17:49:19 <atuljangra> Only this error is coming up when I'm trying to connect a newly created IRC account.
17:49:48 <clokep_work> That doesn't make any sense.
17:50:05 <clokep_work> Even: Is crash-stats.instantbird.com not set up for 1.4 / 1.5a1pre? :-S
17:50:09 <clokep_work> I don't see the versions listed.
17:50:40 <atuljangra> hmmm. :-/
17:50:56 <clokep_work> atuljangra: I have no idea, sorry. :(
17:51:05 <clokep_work> Can you connect other accounts?
17:51:11 <nhnt11> I just looked through my entire tabbrowser patch and couldn't find anything that might cause this scrolling bug :/
17:52:04 <atuljangra> yes, I guess I know what's causing the problem. Trying to fix.
17:54:50 <nhnt11> Funny... autoscrolling works, as does dragging the scrollbar manually. It's just the mouse wheel that's broken
17:55:15 <nhnt11> Looks like up/down/pageup/pagedown are broken too
17:55:33 * qheaden_away is now known as qheaden
17:56:39 * atuljangra just not able to connect to gravel.mozilla.org, everything else working :-/
17:56:52 <nhnt11> atuljangra: Try irc.mozilla.org?
17:57:01 <atuljangra> trying
17:57:26 <atuljangra> ah gravel. connect now, :-/ What kind of sorcery is this :-
17:57:28 <atuljangra> :-/
17:57:30 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
17:57:55 --> atuljang1 has joined #instantbird
17:58:19 * atuljang1 is now known as atuljangra
17:59:32 <atuljangra> clokep_work, flo-retina: you can review the drag and drop code at https://bitbucket.org/atuljangra/instantbird-gsoc-2013.
18:00:01 <nhnt11> Haha, qheaden, atuljangra copied your description too ;)
18:00:09 <atuljangra> :P
18:00:27 <atuljangra> that's the general one. Will update it later ;)
18:02:55 <atuljangra> clokep_work: no no
18:03:08 <atuljangra> don't review it yet, I missed to commit :-/
18:03:10 <atuljangra> Sorry
18:03:20 <atuljangra> Letme push the commit
18:03:38 --> DGMurdockIII has joined #instantbird
18:03:58 --> jb has joined #instantbird
18:04:29 <-- jb has quit (Write error: Connection reset by peer)
18:04:42 <qheaden> Is it possible, or even recommended, for a JS function to give multiple output via reference variables?
18:04:46 <atuljangra> oh wait, I've done it. clokep_work 3457d69 is the final changeset.
18:05:02 * qheaden is bringing up C++ habits.
18:05:05 <clokep_work> atuljangra: Yes, I realized that. :)
18:05:20 <atuljangra> sorry for the trouble.
18:05:20 <clokep_work> qheaden: Not very reference, but you can return multiple values.
18:05:29 * atuljangra likes C++
18:05:43 <clokep_work> qheaden: let [packets, lengthHandled] = function(foo) { return [1, 2]; }
18:06:03 <qheaden> Ahh okay. Reminds me of Python tuples.
18:06:17 * nhnt11 likes that kind of flexibility
18:06:39 <nhnt11> Makes JS and Python so easy to use
18:07:45 --> unghost has joined #instantbird
18:08:07 <clokep_work> atuljangra: I "reviewed" both of them.
18:08:16 <clokep_work> That looks pretty good so far, now to start working on the backend? :)
18:08:28 <atuljangra> thanks: :)
18:08:32 <atuljangra> yes :)
18:08:34 <clokep_work> The nits don't matter so much (in terms of fixing them), but keep them in mind for the future.
18:08:41 <clokep_work> As I'm guessing some of that code isn't permanent.
18:08:59 <atuljangra> ok :) yes, just for testing.
18:09:06 * nhnt11 is sure not to ask clokep_work to review his code :P
18:11:08 <clokep_work> nhnt11: Don't worry, I have no interest in reviewing XUL or XBL. :)
18:11:16 --> jb has joined #instantbird
18:11:24 <clokep_work> (Besides, aleth and Mic will give you enough nits to worry about.)
18:11:29 <nhnt11> That's why I said I'm sure not to ask :P
18:11:48 <nhnt11> I think I've caught on to the nits you guys have :)
18:11:57 <nhnt11> YAY
18:12:01 * nhnt11 fixed the scrolling bug!
18:12:04 <nhnt11> :)
18:13:03 <nhnt11> I wonder how that crept in in the first place... I seem to have added the culprit line to the stuff that's done when switching away from a tab, but I have no idea why.
18:17:37 * atuljangra jumps back to his xep implementation
18:19:17 --> nhnt12 has joined #instantbird
18:20:44 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
18:23:01 <nhnt11> brb on a fixed build
18:23:03 <-- nhnt11 has quit (Input/output error)
18:23:29 --> nhnt11 has joined #instantbird
18:28:09 <nhnt11> Can Instantbird easily be cross compiled? i.e. Would it be easy for me to build for Windows on my Mac machine?
18:28:22 * nhnt11 has an older laptop running windows XP on which he'd like to test some stuff
18:30:42 <nhnt11> I'm reading this: https://developer.mozilla.org/en/docs/Cross_Compile_Mozilla_for_Mingw32, but it seems a little too complicated.
18:32:36 <clokep_work> nhnt11: No one has tried it to my knowledge.
18:32:36 * nhnt11 gives up
18:32:39 <clokep_work> Why do you want to do that?
18:32:48 <nhnt11> clokep_work: Partly just for kicks :P
18:35:06 * clokep_work suggests not worrying about that.
18:35:14 <clokep_work> If you're concerned about how the UI will look, we'll help you with that.
18:35:41 <nhnt11> I wanted to see how slow the buddy list loading was on an older machine
18:39:01 <nhnt11> clokep_work: I do want to see what it looks like on Windows though, yes. I wish Mic had posted a screenshot (not a problem, of course).
18:40:25 <nhnt11> Btw, I decided to hold off on submitting a patch till i iron out some glaring bugs I've found.
18:48:49 <qheaden> Cross compiling will make you go bald. Either from stress or just pulling your hair out. :P
18:49:52 <nhnt11> :P
18:59:44 --> mpmc has joined #instantbird
19:02:26 <nhnt11> If two stylesheets are included, and they both apply conflicting stuff to the same selector, which one is effectively applied? Is it in the order of applying?
19:02:31 * nhnt11 does some experimenting.
19:10:34 <clokep_work> I think the more specific one. Otherwise the !important one.
19:10:37 <clokep_work> Otherwise I have no idea. :)
19:11:22 <Mook_as> qheaden: fwiw, you can also let { foo, bar } = function(){ return { foo: 1, bar: 2 }; }()
19:13:22 <nhnt11> Hmm
19:14:36 <nhnt11> My problem is that when contacts get filtered, they're still childNodes of the list so richlistite:not([selected="true"]):nth-child(odd) still applies. So sometimes I have two adjacent contacts which have the same background.
19:15:46 <nhnt11> I'm trying to replace that with richlistitem:not([filtered="true"]):nth-of-type(odd)
19:16:23 <nhnt11> Apparently that isn't working either though so I need to figure this out before worrying about the stylesheets
19:27:41 <nhnt11> It appears nth-of-type uses only the exact type and not the whole selector previous to it :(
19:49:33 <qheaden> In JS, can values from an enum be used as keys when directly defining an object?
19:49:56 <qheaden> For example, let myObj = {theEnum,value1: "value1", theEnum.value2: "value2"}; ?
19:50:10 <qheaden> *theEnum.value1
19:50:16 <Mook_as> pretty sure you can't :|
19:50:33 <qheaden> Okay. I guess you have to set it using bracket notation.
19:52:56 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 22.0/20130612084701])
19:53:21 <qheaden> clokep_work: I'm going to fill _packetHandlers the same way to prevent having to redefine the values found in the kPacketType enum.
20:01:50 <-- mpmc has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
20:09:18 <clokep_work> qheaden: OK. I'm not sure I like that being done in the constructor btw, isn't it  constnat?
20:13:04 <qheaden> clokep_work: Yes, it should be constant. Did I need to move it out of the constructor?
20:16:28 <clokep_work> qheaden: It seems kind of weird to rebuild it every time.
20:23:26 --> flo-retina has joined #instantbird
20:23:26 * ChanServ sets mode +qo flo-retina flo-retina 
20:23:41 <nhnt11> Is Array.filter fast?
20:26:52 <flo-retina> Good evening :)
20:29:21 <flo-retina> clokep_work: http://log.bezut.info/instantbird/130618#m6 so did I. I actually hg push'ed it. But that command failed with an error because I forgot to hg pull before commiting in the local copy I was pushing from, and I failed to notice the error message
20:29:57 <flo-retina> I was very disappointed to see this morning that the build failed with the same error
20:31:11 <flo-retina> nhnt11: http://log.bezut.info/instantbird/130618#m67 I think you should keep around as many contacts as you need to fill the visible area of the tab.
20:31:51 <nhnt11> flo-retina: That number is small enough to not be required.
20:32:36 <nhnt11> My problem is that since it uses an unsorted array to build the list (injecting them into the correct sorted position), contacts appear in the middle of the visible region a second after you open the tab
20:32:50 <nhnt11> Or did you mean, keep those first few
20:32:58 <nhnt11> Hmm. Maybe the first 50.
20:34:40 --> FireFly_TB has joined #instantbird
20:35:01 <nhnt11> flo-retina: I was thinking of caching the whole sorted list of contacts (the contact objects, not the list elements) so that new awesometabs could load from that cache instead of using Services.tags.getTags() and proceeding from there
20:36:11 <-- jb has quit (Connection reset by peer)
20:36:14 --> jb has joined #instantbird
20:36:22 <-- jb has quit (Connection reset by peer)
20:39:36 <nhnt11> Actually, caching the whole element would probably be more useful.
20:41:43 <flo-retina> nhnt11: I suggested not using getTags, and instead adding a getAllContacts method to the contacts service, did you not like it?
20:42:27 <nhnt11> flo-retina: Either I missed that suggestion or I forgot about it :S
20:43:05 <flo-retina> ok
20:43:34 <nhnt11> flo-retina: That's an interesting idea, do you think it should keep them sorted?
20:43:46 <nhnt11> (I don't think it will speed things up much unless it's sorted)
20:44:07 <flo-retina> sorted by what?
20:44:43 <nhnt11> That's another question :/
20:44:53 <nhnt11> Different things will want to sort them in different ways
20:45:24 <flo-retina> they will likely be sorted by id
20:45:32 <flo-retina> which is of no interest to you :-P
20:45:40 <nhnt11> Exactly...
20:45:59 <flo-retina> that still saves you the duplicate checks though :)
20:47:00 <nhnt11> That isn't nearly as much a bottleneck as sorting though, imho
20:48:01 <flo-retina> I don't want to discuss optimizations of code I haven't looked at. Premature optimizations aren't useful :-P
20:49:19 <flo-retina> bah, I need to create a bitbucket account to comment on Atul's code :-/
20:50:58 <flo-retina> hmm, no, I already have an account
20:52:02 <nhnt11> flo-retina: Also even if it's fast, sorting while inserting results in inserting elements results in contacts being inserted after a second at the beginning of the list
20:52:24 <nhnt11> That's why I want to eliminate the sorting in particular, so that we can append instead of inserting.
20:52:42 <flo-retina> nhnt11: are you really trying to insert more DOM nodes than will be displayed?
20:53:01 <qheaden> I have to go now. Most likely I will be back on later.
20:53:06 <qheaden> Bye everyone.
20:53:08 <nhnt11> flo-retina: What?
20:53:13 <nhnt11> qheaden: Bye!
20:53:19 * qheaden is now known as qheaden_away
20:54:04 <nhnt11> flo-retina: I'm inserting DOM nodes into a scrollable list, so if you mean am I inserting stuff at the end before the user scrolls there, then yes.
20:54:26 <flo-retina> nhnt11: so in my mind the way this work is: 1. You compute what the N top interesting possible conversations are. 2. You insert a richlistitem for each of these N possible conversations. 3. The tab becomes visible.
20:55:04 <nhnt11> :/
20:55:20 <nhnt11> How would I compute those N without sorting/
20:55:38 <nhnt11> Other than caching the first N sorted items
20:56:00 <flo-retina> nhnt11: sorting is likely very cheap compared to "figuring out how many messages were exchanged previously with this contact"
20:56:13 <flo-retina> so you'll likely have some kind of caching to remember the result of these computations
20:56:27 <nhnt11> flo-retina: I'm currently only talking about the buddy list milestone!
20:56:35 <nhnt11> I thought we wanted to land that first?
20:56:47 <flo-retina> isn't that already ready?
20:56:58 <nhnt11> flo-retina: It has a few quirks that I'm ironing out.
20:57:09 * flo-retina is a bit confused about what the current state of your code is
20:57:20 <flo-retina> btw, what was the line causing that scrolling bug?
20:57:26 <nhnt11> Including the thing I'm talking about with the inserting stuff at the beginning
20:57:41 <nhnt11> flo-retina: browser.docShell.isActive = false
20:58:07 <nhnt11> in conversation binding's handleSwitchingAwayFromTab
20:58:52 <nhnt11> flo-retina: About the current state of my code. I'm still at the buddy list milestone - I took the day to polish it a bit since we were going to land it.
20:59:02 <flo-retina> wasn't that already there before?
20:59:07 <nhnt11> flo-retina: No.
20:59:20 <nhnt11> I don't know why I added it, but I removed it now so all is well.
20:59:25 <flo-retina> http://lxr.instantbird.org/instantbird/search?string=isactive
20:59:47 <flo-retina> does that mean there's a new version of your tabbrowser patch to review?
21:00:20 <nhnt11> flo-retina: I was going to wait for any other comments you had (since you didn't finish reviewing) before uploading a new patch with all the changes
21:01:00 <nhnt11> flo-retina: handleSwitchingAwayFromTab is called only from one place, and that place did not have a docShell.isActive = false.
21:01:33 <nhnt11> flo-retina: http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#2099 in this method
21:01:51 <-- FireFly_TB has quit (Ping timeout)
21:02:43 <flo-retina> alright
21:03:07 <flo-retina> I just don't want us to break the isActive feature, as it's useful to optimize some stuff in Bubbles (get rid of timers in inactive tabs ;))
21:03:30 --> FireFly_TB has joined #instantbird
21:03:56 <nhnt11> flo-retina: The problem was that isActive would be set to false when switching away from the window, but when the window was refocused it wasn't being reset
21:04:43 <flo-retina> ok, I believe you :)
21:05:13 <nhnt11> I felt like I had to explain my discovery to someone since it took me so long to find it :P
21:08:23 <flo-retina> that's why I asked what the faulty line was ;)
21:08:41 <flo-retina> if some knowledge was expensive to get, we would better share it :)
21:10:34 --> EionRobb has joined #instantbird
21:11:51 <-- flo-retina has quit (Ping timeout)
21:12:57 * nhnt11 can't get this stripe stuff to work -_-'
21:13:29 --> flo-retina has joined #instantbird
21:13:29 * ChanServ sets mode +qo flo-retina flo-retina 
21:17:17 <flo-retina> nhnt11: btw, I'm quite interested in figuring out how much memory Instantbird uses and why.
21:18:04 <nhnt11> flo-retina: It appears to use a lot more memory on Mac.
21:18:56 <flo-retina> how do you know how much memory it uses?
21:18:57 <flo-retina> are you looking at "real" or "private" memory?
21:19:07 <nhnt11> Real memory. Activity Monitor.
21:19:40 <flo-retina> real isn't very interesting, because that includes all the shared libraries, that are twice the size on Mac as it's a universal 32/64bit build
21:19:49 <flo-retina> private memory is more related to how much memory we actually spend
21:20:29 <nhnt11> Oh okay
21:21:35 <nhnt11> flo-retina: Since I can't get the odd-even alternating background to work properly when stuff is filtered, how about adding a small one or two pixel separator between items to indicate stuff has been filtered there?
21:21:38 <flo-retina> for me currently: real 275MB, private 152MB
21:21:52 <nhnt11> Mine is real 160, private 114
21:22:10 <flo-retina> nhnt11: if it's for the awesome tab, remove the dom nodes that have been filtered out
21:22:24 <nhnt11> flo-retina: That would make it super slow to add stuff back in
21:22:34 <nhnt11> i.e. if the user presses backspace
21:23:17 <flo-retina> how many items do you display at once?
21:23:18 <nhnt11> Everything has to be re-done - building the contact element, sorting
21:23:25 <nhnt11> flo-retina: All of them.
21:23:27 <flo-retina> how come it's "super slow" to recreate that number of items?
21:23:32 <nhnt11> But they're loaded 50 at a time.
21:23:46 <nhnt11> flo-retina: It's not as snappy as just hiding them with CSS
21:23:50 <flo-retina> your screen is larger than my retina screen if you can display 50 contacts there :-P
21:24:12 <nhnt11> I can't, but 50 seemed snappy to me.
21:24:31 <nhnt11> flo-retina: Maybe you should look at my code.
21:24:37 <flo-retina> yeah
21:24:40 <nhnt11> (To gain a bit more context on what it's doing)
21:24:46 <flo-retina> I hoped I would look at the tabbrowser stuff though
21:25:00 <nhnt11> You should probably look at that then, first
21:28:41 <nhnt11> Oh no. The complete left side of my screen seems to have acquired a pink tint.
21:29:15 <nhnt11> Toggling the display on/off seems to have helped but the whole side is still visibly dimmer :(
21:32:02 <flo-retina> my old macbook used to sometimes have the whole screen turn blueish when coming out of sleep. Starting and exiting the screen saver 'fixed' it. I guess it was an OS X 10.5 bug
21:35:02 <nhnt11> I just thought of a hack to get stripes to work
21:35:11 --> jb has joined #instantbird
21:36:59 <nhnt11> Well it doesn't quite work but the idea is interesting I think. Add a hidden DOM element to unfiltered contacts and then use that and nth-of-type to change the background.
21:40:27 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
21:40:33 --> chrisccoulson has joined #instantbird
21:44:58 <-- mconley has quit (Input/output error)
21:57:18 <clokep_work> nhnt11, flo-retina: I also suggested adding a method to the contacts service.
21:58:16 <nhnt11> clokep_work: Once the ranking stuff is done, I think contacts could be stored by rank in the contacts service in addition to id.
21:58:33 <-- jb has quit (Ping timeout)
21:59:59 <clokep_work> nhnt11: It doesn't matter how they're stored, you can sort them after.
22:00:13 <clokep_work> flo-retina: and my point is just that you shouldn't be iterating tags, then iterating contacts and  checking for duplicates.
22:00:16 <nhnt11> Yeah okay.
22:00:17 <clokep_work> That's something the service should do.
22:01:13 * clokep_work should have gone home ~2 hours ago
22:01:37 --> mpmc has joined #instantbird
22:02:01 <nhnt11> clokep_work, flo-retina: What do you feel about showing a separator wherever there's a series of filtered items?
22:02:31 <nhnt11> As an indicator that contacts are missing there, and a way of covering up the stripes issue on Mac.
22:02:51 <clokep_work> nhnt11: I have on idea what issue you're talking about...and why are there "missing" contacts.
22:03:03 <nhnt11> They're filtered out.
22:03:03 * clokep_work isn't sure what you're trying to optimize.
22:03:07 <nhnt11> So not visible.
22:03:16 <clokep_work> No, that's not useful information.
22:03:16 <nhnt11> clokep_work: I'm not optimizing anything, I'm making sure it doesn't look ugly
22:03:18 <clokep_work> It's visual noise.
22:03:25 <clokep_work> You're trying to optimize the UI. ;)
22:03:30 <nhnt11> Okay fair enough
22:03:46 <nhnt11> clokep_work: It's noiser to see two list items the same color in a row
22:03:48 <nhnt11> noisier*
22:03:54 <clokep_work> nhnt11: My advice to you, at this point, would be to get the current state of stuff into good shape so we can land things. And we can always tweak it later. :)
22:04:06 <clokep_work> I agree.
22:04:13 <clokep_work> Means there's a bug somewhere in the implementation. :)
22:04:16 * clokep_work has to go.
22:04:18 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
22:04:29 <flo-retina> nhnt11: what about making all rows of the same color for now?
22:04:54 <nhnt11> flo-retina: But... but... it looks so good!
22:04:56 * nhnt11 pouts
22:04:56 <nhnt11> :P
22:20:19 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:27:00 <-- FireFly_TB has quit (Ping timeout)
22:27:52 --> FireFly_TB has joined #instantbird
22:29:52 <instantbot> florian@instantbird.org denied review for attachment 2489 on bug 426.
22:29:53 <instantbot> florian@instantbird.org granted feedback for attachment 2489 on bug 426.
22:29:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window
22:30:28 <flo-retina> alright, I'm not reviewing this version of the patch. And as usual, it took much more time than I expected.
22:30:58 <flo-retina> err, I meant "I'm done reviewing"
22:31:44 <nhnt11> flo-retina: Thanks! I'll look at your comments now but I'll probably address them tomorrow
22:33:18 <flo-retina> you are welcome
22:33:25 <flo-retina> sorry for the delay :-|
22:33:47 <nhnt11> flo-retina: That's funny, I was sure I removed all the getBrowserFromTab calls
22:34:04 <nhnt11> Oops misread. never mind.
22:35:12 <nhnt11> flo-retina: Cool, it looks like minor stuff. Shouldn't take too long to have a new patch up :)
22:36:12 <flo-retina> right, nothing too terrible (hence the f+ ;))
22:43:50 --> wnayes has joined #instantbird
22:44:30 <nhnt11> flo-retina: How dirty do you think the following hack is to get stripes to work? Since hiding an element changes the odd/even order, add a new dummy element after it to preserve order when hiding it, and remove it when un-hiding it.
22:44:37 * nhnt11 hopes that made sense
22:45:29 <flo-retina> if you intend to get rid of this hack soon, it's OKish
22:45:59 <flo-retina> (I think that made sense only because I already had the same idea and almost suggested it ;))
22:46:28 <nhnt11> flo-retina: I don't know if we can get rid of it. From what I've researched it's extremely hard to select visible odd elements from pure CSS
22:47:02 <nhnt11> flo-retina: Haha, I was avoiding suggesting it till I was sure there was no other easy way
22:47:52 <flo-retina> nhnt11: as I said, you shouldn't keep in the DOM elements you don't want, and you shouldn't get the whole contact list as DOM elements for the real awesome tab
22:48:23 <nhnt11> flo-retina: Are you suggesting adding elements on the fly while scrolling?
22:50:32 <nhnt11> Okay I'm going to try removing elements instead of hiding them. I was worried about how to add them back later but I had an idea now.
23:03:04 * qheaden_away is now known as qheaden
23:04:09 <nhnt11> No, this isn't working. I prefer the hack :-/
23:05:52 <nhnt11> Though, even the hack isn't currently working... :'(
23:09:59 <-- qlum has quit (Quit: Getting the <censored> out.)
23:16:10 <qheaden> When is the next Instantbird release? You guys have a schedule, or just release when it is ready?
23:20:28 <flo-retina> qheaden: we try to release roughly every 3 months, but there's no real schedule, until we are close to a release (we plan 2-3 weeks before releasing)
23:21:17 <flo-retina> so I guess that answer is in the middle between your 2 suggestions ;)
23:21:39 <-- mpmc has quit (Connection reset by peer)
23:22:13 <nhnt11> Oh. My. God.
23:22:15 <nhnt11> No. Way.
23:22:17 <flo-retina> nhnt11: I said "for the real awesome tab". For the 'blist in tab' milestone I don't mind.
23:22:24 <nhnt11> All this time I've been editing the wrong file
23:22:30 <nhnt11> (A backup of it I had on my desktop)
23:22:35 <nhnt11> So my builds weren't getting updated
23:22:42 <nhnt11> I am so annoyed right now.
23:22:46 <nhnt11> flo-retina: Ah okay
23:23:04 <flo-retina> so yeah, the hack is ok for the blist in tab stuff
23:23:13 <nhnt11> flo-retina: That's cool then.
23:23:27 <flo-retina> and I'm curious to try it, so I guess that's motivation for getting the reviews done ;)
23:23:35 <nhnt11> :D
23:23:48 <nhnt11> flo-retina: You can pull and try it now if you want, it works great :)
23:24:11 <flo-retina> sleeping sounds like a better plan at this point
23:24:46 <nhnt11> Heh, by now I meant, without waiting for reviews :)
23:26:22 <nhnt11> The hack works!
23:29:07 <flo-retina> are you saying I shouldn't wait for myself? :-P
23:29:28 <nhnt11> I suppose so, yes :P
23:30:16 <flo-retina> Good night
23:30:19 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:30:19 <nhnt11> Night
23:49:35 --> clokep has joined #instantbird
23:49:36 * ChanServ sets mode +o clokep 
23:52:56 <clokep> qheaden: Personally, I'd shoot for releasing on Moz 24. :)
23:53:47 <nhnt11> Good night
23:53:48 <-- nhnt11 has quit (Input/output error)