All times are UTC.
00:21:24 <-- dew has quit (Ping timeout) 00:22:04 --> dew has joined #instantbird 00:25:00 <-- wuwei|offline has quit (Connection reset by peer) 00:25:33 <dew> I forgot the about memory command for instantbird again :( 00:25:36 --> wuwei|offline has joined #instantbird 00:26:17 <clokep> dew: openDialog("about:memory") in the error console 00:35:38 <-- wuwei|offline has quit (Connection reset by peer) 00:36:09 --> wuwei|offline has joined #instantbird 00:38:35 <-- Mook_as has quit (Quit: Mook_as) 00:58:54 <qheaden> clokep: Sorry, I just saw your message. Did you see my last test commit? 00:59:09 <clokep> qheaden: Yes. 00:59:34 <qheaden> clokep: Is the approach okay? I assume it is, since there are no comments. ;-) 01:00:02 <clokep> I didn't notice anything crazy. 01:00:27 <qheaden> Great. 01:00:47 <qheaden> I just took the direct call approach to simulate server responses. 01:01:43 <clokep> That's fine. 01:04:25 <qheaden> I'm happy we have made this much progress so early. That will give us time for any roadblocks and still be on schedule. 01:04:36 --> rosonline has joined #instantbird 01:05:37 <clokep> Yup! :) I'm sure there will be some. 01:07:59 <qheaden> One might possibly be decoding the buddy list. :-/ 01:08:21 <qheaden> I'm going to have to look at libpurple's source. 01:08:59 <-- wuwei|offline has quit (Connection reset by peer) 01:09:01 <clokep> If you can dump the information, I can look at it too. :) 01:09:33 <qheaden> Oh yeah, and I plan on using WireShark like I told you yesterday. 01:09:39 --> wuwei|offline has joined #instantbird 01:10:11 <clokep> OK. 01:17:28 <-- wnayes has quit (Ping timeout) 01:20:54 --> wnayes has joined #instantbird 01:27:40 <-- wuwei|offline has quit (Connection reset by peer) 01:28:13 --> wuwei|offline has joined #instantbird 01:37:12 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 01:42:08 <-- wuwei|offline has quit (Connection reset by peer) 01:42:38 --> wuwei|offline has joined #instantbird 01:51:40 <-- wuwei|offline has quit (Connection reset by peer) 01:52:16 --> wuwei|offline has joined #instantbird 01:55:14 <-- Nirgali has quit (Ping timeout) 01:57:13 --> Mook has joined #instantbird 02:00:42 * qheaden is now known as qheaden_away 02:01:20 <-- wnayes has quit (Quit: wnayes) 02:05:13 --> nhnt11_phone has joined #instantbird 02:05:42 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 02:38:06 --> mconley has joined #instantbird 02:52:51 <-- wuwei|offline has quit (Connection reset by peer) 02:53:22 --> wuwei|offline has joined #instantbird 02:59:25 <dew> clokep: thanks I put it in my documentation 03:00:58 <dew> if clokep or florian read the logs, here is my about:memory output http://pastebin.mozilla.org/2517886 03:09:37 <instant-buildbot> build #879 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/879 03:12:34 <-- rosonline has quit (Client exited) 03:13:07 <Mook> fwiw, pastebin.mozilla.org expires after 24 hours, so if you want things a little more permanent you want to put it somewhere else. 03:13:49 * Mook wonders how many chat windows are open in that memory log 03:19:08 --> nhnt11 has joined #instantbird 03:22:19 * nhnt11 always sets his pastebin expiry to forever ;) 03:22:45 <Mook> nope, pastebin.mozilla.org lies and expires everything after 24 hours :p 03:22:51 <Mook> pastebin.instantbird.org might be better, though 03:23:33 <nhnt11> pastebin.instantbird.com * :P 03:23:36 <nhnt11> And yes it works for me there 03:23:57 <nhnt11> (At least, I think it does?) 03:24:11 <-- mconley has quit (Input/output error) 03:24:12 <nhnt11> Maybe I've just assumed it does all these days. I think I've tested it though 03:25:20 <nhnt11> Mook: Yes it works. Just opened a paste from last Saturday ;) 03:46:19 * nhnt11 just used "Stuff" as a commit message 03:47:48 <-- wuwei|offline has quit (Connection reset by peer) 03:48:27 --> wuwei|offline has joined #instantbird 03:53:37 <instant-buildbot> build #871 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/871 03:54:40 --> mconley has joined #instantbird 04:00:09 <-- mconley has quit (Ping timeout) 04:51:56 <-- wuwei|offline has quit (Connection reset by peer) 04:52:35 --> wuwei|offline has joined #instantbird 04:59:18 --> nhnt12 has joined #instantbird 04:59:43 <-- nhnt12 has quit (Input/output error) 05:04:01 <-- dionisos has quit (Ping timeout) 05:15:56 <-- wuwei|offline has quit (Connection reset by peer) 05:16:36 --> wuwei|offline has joined #instantbird 05:18:43 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2479 on bug 426. 05:18:44 <instantbot> nhnt11@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 2479 on bug 426. 05:18:46 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2480 on bug 426. 05:18:47 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2480 on bug 426. 05:18:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 05:26:10 <instantbot> nhnt11@gmail.com cancelled review?(benediktp@ymail.com ) for attachment 2480 on bug 426. 05:26:11 <instantbot> nhnt11@gmail.com cancelled feedback?(aleth@instantbird .org) for attachment 2480 on bug 426. 05:26:13 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com for attachment 2481 on bug 426. 05:26:14 <instantbot> nhnt11@gmail.com requested feedback from aleth@instantbird .org for attachment 2481 on bug 426. 05:26:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 05:44:32 <-- EionRobb has quit (Ping timeout) 05:57:00 <instant-buildbot> build #974 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/974 06:08:53 <-- Mook has quit (Quit: Mook) 07:12:46 --> EionRobb has joined #instantbird 07:16:27 --> sabret00the has joined #instantbird 07:17:03 <-- sabret00the_ has quit (Ping timeout) 07:28:00 <-- EionRobb has quit (Connection reset by peer) 07:31:06 --> EionRobb has joined #instantbird 07:43:14 --> jb has joined #instantbird 08:18:42 <-- instant-buildbot has quit (Quit: buildmaster reconfigured: bot disconnecting) 08:19:42 <-- dew has quit (Connection reset by peer) 09:05:32 <-- wuwei|offline has quit (Connection reset by peer) 09:06:02 --> wuwei|offline has joined #instantbird 09:10:05 --> aleth has joined #instantbird 09:10:05 * ChanServ sets mode +h aleth 09:10:22 --> flo-retina has joined #instantbird 09:10:23 * ChanServ sets mode +qo flo-retina flo-retina 09:19:12 * aleth grins at the obligatory off-topic OTR question in comment 7 of that trillian protocol post 09:21:03 <aleth> nhnt11: I don't know if this has been suggested before, but a very useful add-on that will be possible after your patch lands would be one that opens the various about:* pages in tabs :) 09:22:01 <flo-retina> aleth: does it really need to be an add-on? 09:22:15 <flo-retina> aleth: wouldn't an /about command be useful by default? 09:22:19 <aleth> flo-retina: I guess not :) 09:22:47 <EionRobb> aleth: most of those comments in the blogpost are off topic 09:23:04 <aleth> That would definitely be useful, as then we could ask people on #instantbird for it (about:crashes in particular) 09:24:08 <flo-retina> aleth: I woud also like "/about memory" instead of "Command+shift+J openDialog('about:memory')<return>" ;) 09:24:25 <aleth> flo-retina: That's the one I'm most interested in too ;) 09:24:44 <aleth> I've never actually tried about:support on IB 09:24:58 --> Mic has joined #instantbird 09:24:58 * ChanServ sets mode +h Mic 09:25:03 * aleth files a bug 09:26:03 <Mic> Hi 09:26:40 * Mic feels like has has terribly neglected his duties the last few days :S 09:27:00 <instantbot> New Instantbird (UI) bug 2002 filed by aleth@instantbird.org. 09:27:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nobody, NEW, Add an /about command to open the about:* pages 09:27:48 <-- jb has quit (Ping timeout) 09:27:55 <flo-retina> aleth: I guess that could even be done now and changed later to open in tabs rather than in new windows if we really wanted 09:28:36 <aleth> flo-retina: Right, but I hope that patch will be ready to land soon, and then it saves changing it again. 09:28:47 <Mic> clokep: it's saved when it changes of course. I suspected that it might be changed to offline while shutting down but looking at the Instantbird code doesn't suggest it is (I've only had a quick look yet though)@ http://log.bezut.info/instantbird/130612/#m535 09:28:59 <aleth> flo-retina: Also makes a good test case to discover any regressions/bugs ;) 09:29:19 <flo-retina> aleth: sure :) 09:30:50 --> jb has joined #instantbird 09:32:32 <-- jb has quit (Ping timeout) 09:33:37 --> jb has joined #instantbird 09:34:38 <-- gerard-majax has quit (Ping timeout) 09:40:34 <-- wuwei|offline has quit (Connection reset by peer) 09:41:05 --> wuwei|offline has joined #instantbird 09:44:25 --> clokep has joined #instantbird 09:44:25 * ChanServ sets mode +o clokep 09:49:02 <clokep> Btw we pretty much forward everything from .com to .org orfrom .org to .com to whatever the correct one is. :) 09:49:07 <clokep> I have no idea which one pastebin is on (I'd guess .org) 09:49:23 --> dionisos has joined #instantbird 09:50:19 <flo-retina> clokep: .com 09:50:48 <flo-retina> but really, it's on "pa<enter>" in the awesomebar 10:00:03 <clokep> Right. :) 10:00:04 <-- wuwei|offline has quit (Connection reset by peer) 10:00:20 <Mic> nhnt11: with what do you test at the moment? 10:00:37 --> wuwei|offline has joined #instantbird 10:00:50 <Mic> i.e. what do you use as custom tab to load? 10:01:13 * nhnt11 suddenly wakes up and realizes he fell asleep :( 10:01:19 <nhnt11> Hello Mic 10:01:24 <nhnt11> Lmpbtfy 10:01:54 <nhnt11> Mic: http://pastebin.instantbird.com/221505 10:03:02 <Mic> That + TabTest-addon? 10:03:04 * aleth thinks those properties should be documented in tabbrowser-panel (if they aren't already) 10:03:19 <nhnt11> Yes. 10:03:33 <nhnt11> aleth: The tab property? 10:03:49 <aleth> Yes, whatever is there that is needed for any tab 10:04:03 <nhnt11> aleth: In tabtest.xml, that's almost a hack. 10:04:09 <aleth> Oh OK 10:04:17 <nhnt11> It overrides the setter so that it can add a label attribute to the tab. 10:04:34 <aleth> But every tab should have a label, so that should be documented 10:04:54 <nhnt11> aleth: True enough 10:05:01 <nhnt11> I'll add a linkedTabPanel property as well then 10:05:33 <aleth> (I mean it's obvious a title is needed, but maybe not so obvious that the tabtitle goes into label rather than value or something) 10:05:55 <nhnt11> aleth: That documentation is in MDN 10:06:00 <nhnt11> It's standard XUL. 10:06:22 <aleth> OK :) I guess you can forget I asked then ;) 10:07:55 <aleth> We only need to document differences/additions to what's in standard XUL 10:08:03 <nhnt11> Yeah, okay. 10:08:36 <nhnt11> I think it may good to document that a "tab" property will be set for the panel though. 10:08:52 <nhnt11> And actually, to go by the naming conventions in tabbrowser.xml, it should be renamed to linkedTab 10:09:17 * nhnt11 hadn't thought of that before 10:09:18 <nhnt11> brb. 10:13:12 --> gerard-majax has joined #instantbird 10:13:33 <clokep> We should have our own about:mozilla. ;) 10:15:44 <nhnt11> Mic: My next short term goal (that I want to get done today) is to replace the dummy tab with an Awesometab, and get all the keyboard shortcuts, etc. working. 10:15:52 <nhnt11> (To launch an awesometab) 10:16:09 <nhnt11> The awesometab itself will just be a blank panel with a tab that states its name for now 10:16:42 <Mic> "get all the keyboard shortcuts working", to open an awesometab or are existing ones not working at the moment? 10:16:57 <nhnt11> To open an awesometab, i.e. Ctrl+T. 10:17:07 <nhnt11> I meant get all the Awesometab launching hooks working 10:17:22 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 10:17:38 <Mic> OK, you can also enable the [+] button then. 10:18:02 <Mic> I did that ages ago with a userChrome-rule and never removed it, so I'm used to the look already ;) 10:18:04 <nhnt11> Yes. And unhide the new tab button in the context menu :) 10:33:05 <aleth> nhnt11: I wonder if you'd like to look at bug 2002 too, it could be landed together with the main patch and then we could all test it in nightlies ;) 10:33:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nobody, NEW, Add an /about command to open the about:* pages 10:33:19 <nhnt11> aleth: I did want to look at that, yes 10:33:23 <nhnt11> It should be simple enough :) 10:33:39 <aleth> nhnt11: Yup, you already have all the pieces I think :) 10:34:35 <nhnt11> aleth, flo-retina, Mic: I think this is where it would be useful to keep the tabbrowser-panel binding - simple tabs like the about:xxx stuff won't have to implement empty methods 10:46:26 <Mic> nhnt11: I've not looked through the code thoroughly yet but I have done testing already. It works very nicely most of the time and I've uncovered a few situations where we need to investigate what's going wrong and how to fix it. I'll post the results in the bug. 10:46:44 <nhnt11> Okay! 10:47:48 <nhnt11> I tested moving around tabs/windows, resizing, menu items, and keyboard shortcuts. 10:50:40 --> dew has joined #instantbird 10:51:02 <nhnt11> Can I set the src of a browser or iframe to an XUL file in chrome:// ? 10:52:53 <Mic> Yes. 10:53:19 <Mic> That's what I did to load the extension manager into a tab. I added a browser there and set its source attribute accordingly. 10:53:59 <nhnt11> That's cool :) It'll work well with the way I'm doing the aboutPanel (is that a good name for it?) 10:55:22 <nhnt11> Mic: Where should I put the moz-binding flag? In instantbird.css? 10:55:52 <Mic> I don't like the name. Using "About"-only as name makes me think about the "About Instantbird"-dialog that can be opened from the help menu. 10:56:39 <nhnt11> I didn't know what to call the individual about thingies. 10:57:00 <Mic> nhnt11: seems to be OK, we have the conversation binding there already. 10:57:13 <Mic> I've posted on the bug btw. 10:58:03 <nhnt11> Mic: The latest patch fixes the first error 10:58:31 <Mic> I've hg pull -u-ed before trying... 10:58:42 <Mic> Is it pushed to bitbucket already? 10:58:43 <nhnt11> That's weird. 10:58:45 <nhnt11> Just a second. 10:58:54 <Mic> brb 10:59:12 <nhnt11> (The solution, btw, is to use var conv and not let conv - I'm not sure why and meant to ask) 11:00:35 --> novabyte has joined #instantbird 11:00:37 <nhnt11> Mic: What do you feel about aboutPagePanel? 11:02:50 <aleth> nhnt11: Is there any difference between opening about:xxx and opening any other URL? 11:03:03 <aleth> If there isn't maybe it should be called a browserPanel or something 11:04:02 <nhnt11> aleth: I'm not sure if we want to have a browser panel that could open arbitrary URLs 11:04:36 <nhnt11> If that's wanted, then perhaps we could, but right now I'm writing this code as if all it does is display the different about: pages 11:04:46 <nhnt11> (Direct from their xul files) 11:04:56 <aleth> nhnt11: Sure, I was just wondering if there was actually a difference 11:05:11 <nhnt11> I don't think so, no 11:05:13 --> mpmc has joined #instantbird 11:05:19 <nhnt11> The browser type would have to be dynamically set though 11:05:31 <nhnt11> By default it's set to chrome, when it's in chrome. 11:05:42 <nhnt11> It would have to be set to content to display a webpage for example 11:07:49 <nhnt11> aleth: conv is set before the items. | let conv = this; | 11:08:00 --> clokep_work has joined #instantbird 11:08:00 * ChanServ sets mode +o clokep_work 11:08:52 <aleth> nhnt11: Sure, but when the handler is called, is that the same scope? 11:08:52 <nhnt11> Mic: Opening a tab in a new window by that preference isn't handled by tabbrowser at all. The code that adds the tab should take care of that, or tabbrowser needs to be made aware of the preference 11:09:07 <nhnt11> aleth: It works for me :P 11:09:26 <nhnt11> let conv = this; Assigns the conversation to conv 11:09:33 <nhnt11> The this no longer matters after that 11:09:49 <nhnt11> (That's a funny sentence) 11:10:21 <aleth> nhnt11: OK, just checking 11:10:44 <nhnt11> Mic: I fixed that first bug in this commit: https://bitbucket.org/nhnt11/instantbird-gsoc-2013/commits/c637c6189e606ae7ad02ab08ff085b07a713db4a 11:11:27 <nhnt11> Also, I know what the problem is with mTabs. It's a NodeList and yet again I forgot that and tried to map() it. 11:12:02 * clokep_work thinks it would be nice if .map worked with NodeLists. :P 11:12:26 * aleth thinks it would be nice if .map worked on anything iterable :P 11:12:56 <nhnt11> Would it be too hackish to do Array.prototype.map.call() on it? :P 11:13:10 <aleth> Array.map() should be enough 11:13:29 <aleth> ie. Array.map(this.mTabs, ...) 11:13:49 <nhnt11> Okay. 11:14:07 <nhnt11> (That's kind of obvious, silly me) 11:17:01 <instantbot> aleth@instantbird.org granted feedback for attachment 2481 on bug 426. 11:17:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 11:18:52 <nhnt11> Weird, it was working for me 11:19:10 <nhnt11> Maybe I didn't test properly/broke something in a later change 11:19:48 <nhnt11> Mic: I'm not able to reproduce that Enter key bug 11:20:02 <nhnt11> Working fine for me. 11:20:25 <Mic> Maybe I did something wrong when opening the tabs. 11:21:35 <nhnt11> Ctrl+PageUp/Down also working fine 11:21:53 <nhnt11> (I have a tabtest tab sandwiched between two conversation tabs for testing purposes) 11:22:41 <nhnt11> Ctrl+0-9 is also working 11:22:45 <nhnt11> Maybe this is Mac related? 11:23:00 <aleth> My guess would be that it may depend on what has focus 11:23:40 <nhnt11> aleth: No. It just works. 11:23:47 <Mic> Maybe Mac related, yes. 11:23:58 <Mic> The menu and shortcut stuff is done pretty differently there. 11:24:04 <nhnt11> Mic: Are you sure you have the latest code, btw? 11:24:19 <Mic> As said, I pulled and updated before trying. 11:24:39 <Mic> I've got to go for today again :( 11:24:41 <nhnt11> :/ 11:25:07 <nhnt11> aleth: Did you test the patch? 11:25:09 <nhnt11> Mic: okay 11:25:11 <aleth> nhnt11: No 11:25:20 <nhnt11> aleth: Could you? Whenever you've got some spare time 11:26:28 <aleth> I will, but probably not today :-/ 11:26:35 <nhnt11> Okay :) 11:26:53 <nhnt11> I'm unable to reproduce any of Mic's errors... 11:27:25 <clokep_work> Maybe he had his tabs set up slightly differently? 11:27:37 <aleth> Maybe if you fix onTabKeyPress they will go away? ;) 11:27:48 <nhnt11> aleth: It's fixed 11:28:01 <nhnt11> (That's my point - if it's not a conversation it just returns) 11:28:10 <nhnt11> I still say Mic doesn't have the latest code, judging from the first error 11:28:37 <nhnt11> "let conv = getTabBrowser().selectedConversation;" <- This statement doesn't exist anymore. 11:29:58 <aleth> nhnt11: So it is. I wonder what version I was looking at... 11:33:14 <clokep_work> Are you sure you exported the patch properly to contain all revisions / didn't upload an old version, etc. 11:34:30 <Mic> I didn't apply the patch by the way! 11:34:39 <Mic> I pulled directly from bitbucket this morning. 11:34:53 <Mic> I really gtg now. 11:34:56 <Mic> Have a nice day. 11:34:59 <nhnt11> Bye! 11:35:02 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 11:35:09 <nhnt11> clokep_work: The patch is fine. 11:35:49 <clokep_work> OK. 11:40:26 --> sabret00the_ has joined #instantbird 11:40:56 <-- sabret00the has quit (Ping timeout) 11:49:57 --> atuljangra has joined #instantbird 11:50:21 * atuljangra had to use mibbit again, cos of proxy issues. :( 11:50:27 * aleth hopes atuljangra is feeling better ;) 11:50:40 * atuljangra point to self: recharge3G. 11:50:56 <atuljangra> aleth: yes, I can atleast work now. :) 11:52:03 <-- Optimizer has quit (Ping timeout) 11:52:09 <clokep_work> Excellent. :) 11:52:22 * atuljangra starts with UI 11:52:52 <-- novabyte has quit (Ping timeout) 11:53:03 <atuljangra> clokep_work: So I should be making changes to conversation.xml, instantbird.xml, and then show them to you for UI review? 11:53:20 <aleth> atuljangra: Are you going to design the whole UI first or are you adding a minimal UI to be able to test some backend things as you go? 11:53:48 * aleth thinks it would be a good idea to discuss the UX before implementing it 11:53:54 <atuljangra> aleth: Minimal UI first, so that backend can be easily tested. 11:54:02 <aleth> atuljangra: ah OK :) 11:54:12 * atuljangra thinks exactly the same :) 11:55:59 --> Optimizer has joined #instantbird 11:57:34 <-- clokep_work has quit (Ping timeout) 11:57:37 <atuljangra> While in a conversation, there can be an icon justified rightwards in the same row as the name. 11:57:49 <atuljangra> *name of the contact. 11:58:22 <aleth> atuljangra: Would drag and drop make a decent minimal UI? 11:58:56 <aleth> Or is that more work than adding an icon? 11:58:56 <atuljangra> aleth: Yes ( and a cool one too) 11:59:13 <aleth> I ask because drag and drop could land in the core immediately, an icon could not. 11:59:47 <atuljangra> It may be more work, but I guess all of us will prefer drag and drop to icon. 12:00:22 <aleth> The hard part of the UX is what happens afterwards anyway ;) 12:00:38 <atuljangra> yes ;) 12:01:33 <aleth> But yeah, I'd say just go ahead and file a new bug with your changes. 12:01:54 <aleth> flo-retina: ^^ do you agree? 12:02:24 <atuljangra> aleth: Okay that sounds good. :) 12:03:39 <-- wuwei|offline has quit (Connection reset by peer) 12:04:18 --> wuwei|offline has joined #instantbird 12:04:47 <atuljangra> aleth: so for now, should I just add an icon for testing and change it to drag and drop later? 12:05:31 <flo-retina> aleth: agree with what? 12:06:13 <aleth> flo-retina: That drag and drop support as a minimal UI to trigger file transfers could land fairly self-contained and soon. 12:06:20 <aleth> While an icon could not. 12:06:31 <aleth> atuljangra: I suspect we might not take an icon into the nightlies unless it could be pref'd off. 12:06:39 <flo-retina> yes. 12:07:01 <atuljangra> aleth: okay, drag and drop it is. 12:07:15 <flo-retina> although we probably wouldn't want to land it without also landing minimal core changes 12:07:45 <atuljangra> :) 12:08:23 <-- jb has quit (Ping timeout) 12:13:28 <aleth> atuljangra: How's the filelink interface looking? Will it require many changes? 12:13:49 <aleth> Or are you concentrating on libpurple first? 12:14:01 <nhnt11> Hi atuljangra :) 12:14:13 <atuljangra> atuljangra: It shouldn't require much changes, few in conversation.xml, instantbird.xml. 12:14:25 <atuljangra> aleth: ^ 12:14:48 <atuljangra> aleth: Also, in the beginning I'm trying to work on both simultaneously. 12:14:48 <aleth> atuljangra: I meant the changes to TB filelink needed to use it in IB 12:14:58 <-- EionRobb has quit (Quit: Leaving.) 12:15:08 --> EionRobb has joined #instantbird 12:15:20 <atuljangra> oh okay. It shouldn't require much. 12:15:25 <atuljangra> Hi nhnt11 :) 12:15:30 <aleth> atuljangra: Sounds like a great idea. I suspect filelink is a bit of an exception in terms of UX anyway 12:15:35 <nhnt11> Mic's error: 12:15:35 <nhnt11> (Not reliably reproducable) When switching from a conversation tab to a 12:15:36 <nhnt11> non-conversation tab using Ctrl+PageUp/PageDown: 12:15:36 <nhnt11> > Timestamp: 13.06.2013 12:27:56 12:15:36 <nhnt11> > Error: [Exception... "'JavaScript component does not have a method named: "supportsCommand"' when calling method: [nsIController::supportsCommand]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: chrome://global/content/globalOverlay.js :: goUpdateCommand :: line 71" data: no] 12:15:36 <nhnt11> > Source File: chrome://global/content/globalOverlay.js 12:15:36 <nhnt11> > Line: 71 12:15:36 <nhnt11> Doesn't this look like a bug you filed some time ago? 12:15:45 <nhnt11> Oh no! Why did my pastebin addon break :( 12:15:53 <atuljangra> aleth: Yes :) 12:16:39 --> jb has joined #instantbird 12:16:44 <nhnt11> Sorry about that... but anyway, aleth: http://pastebin.instantbird.com/221599 12:16:51 <-- EionRobb has quit (Ping timeout) 12:17:05 * nhnt11 will make sure to paste in a separate conversation with himself from next time 12:17:27 <aleth> nhnt11: Unless Mic was detaching/reattaching tabs, probably not 12:17:41 <nhnt11> aleth: I think he was, as part of testing. 12:17:56 <aleth> If he was, the patch fixing it is awaiting review... 12:17:59 <flo-retina> that also reminds me errors we had when debugging tab detaching 12:18:05 <flo-retina> aleth: oh sorry :( 12:18:20 <-- Optimizer has quit (Ping timeout) 12:18:33 <nhnt11> aleth: I actually wasted a lot of time trying to find out what I changed that was causing that, before discovering that bug :D 12:19:04 <aleth> nhnt11: Sorry, I forgot of course he would have been detaching tabs, to test ...Import() etc 12:19:09 * nhnt11 wonders why his pastebin addon suddenly broke 12:19:48 <nhnt11> aleth: No problem. 12:19:49 <nhnt11> . 12:20:12 <nhnt11> Interesting. It's refusing to work in this conversation in particular (I set it to a two line limit to test) 12:20:39 <aleth> Check the error console? 12:20:59 <nhnt11> It's clear :( 12:21:30 <nhnt11> Wait, does that supportsCommand error have anything to do with these commands? 12:21:55 <nhnt11> Interesting... 12:22:16 <nhnt11> Well, no new errors are fired, at least. 12:22:19 <aleth> It might, yes 12:22:28 <nhnt11> Ah, I found the reason 12:22:34 <aleth> All sorts of things are currently broken on reattached tabs. 12:22:40 <nhnt11> It stops working after detaching a tab. 12:22:42 <aleth> But only if you do it twice ;) 12:22:52 <nhnt11> aleth: My addon breaks after detaching once :P 12:23:27 <aleth> I can't remember whether that would be expected or not :-P 12:23:39 <aleth> Lets wait and see for now. 12:24:13 <nhnt11> aleth: The listener is added when a conversation-loaded notification is observed 12:24:26 <nhnt11> I think I should use a different notification 12:24:28 <aleth> Oh wait, that's unrelated to the bug we were discussing earlier 12:24:51 <aleth> The notification is the right one. Are you using a recent nightly though? 12:25:02 <nhnt11> No. I'm using 1.4 stable 12:25:08 <aleth> That explains it 12:25:16 <nhnt11> I'll update then! 12:25:28 <aleth> nhnt11: http://hg.instantbird.org/instantbird/rev/c25d057274df 12:25:54 <nhnt11> aleth: Cool :) 12:25:59 <nhnt11> I should subscribe to checknis. 12:26:29 <aleth> It's a good idea to use nightlies anyway (dogfooding) 12:26:49 <-- wuwei|offline has quit (Connection reset by peer) 12:26:53 <nhnt11> aleth: I have a very poor internet connection :P 12:27:13 <nhnt11> I'll set up a script that does a pull and a build on the default branch and copies it to my Applications folder 12:27:17 <nhnt11> Every day, that is 12:27:21 --> wuwei|offline has joined #instantbird 12:28:01 <aleth> nhnt11: Your nightly should update itself automatically. Is your connection too bad for that? :( 12:28:15 <nhnt11> aleth: Does that do differential updates? 12:28:20 <aleth> nhnt11: Sure 12:28:44 <nhnt11> Then great. As long as I don't have to download ~40MB every time. :) 12:29:38 <nhnt11> I'll have a 100mbps connection when I get back to campus though :D 12:30:23 * atuljangra again a HTTP Error 414: Request-URI Too Long error :-/ 12:30:26 <nhnt11> brb 12:32:40 <-- jb has quit (Connection reset by peer) 12:33:49 --> jb has joined #instantbird 12:35:47 <atuljangra> I've hg 2.6.1 and latest is 2.6.2. Can this be a source of HTTP Error 414: Request-URI Too Long error? 12:37:06 <atuljangra> flo-retina: What should I cover in UX first? :) 12:37:40 --> clokep_work has joined #instantbird 12:37:40 * ChanServ sets mode +o clokep_work 12:37:56 <clokep_work> atuljangra: Sorry, I was at my mechanic's, let me read what you said. 12:38:05 <atuljangra> Sure :) 12:38:54 <-- jb has quit (Connection reset by peer) 12:39:04 <clokep_work> atuljangra: I would suggest adding an icon like you said, we can land everything and just hide it with CSS. 12:39:34 <clokep_work> We'll definitely want drag 'n' drop later, but that's UI. We certainly only need ONE way to do this for testing. 12:39:46 <clokep_work> Drag 'n' drop is probably more difficult to get working than adding a button. 12:39:56 --> jb has joined #instantbird 12:40:10 <clokep_work> Oh, but flo seems to have suggested drag 'n' drop as good, so go with that. :) 12:40:15 <aleth> clokep_work: I'm not so sure, the button will also need to pop up a modal dialog or something... 12:40:22 <-- jb has quit (Connection reset by peer) 12:40:28 --> jb has joined #instantbird 12:40:33 <clokep_work> aleth: No it doesn't, the file chooser is toolkit. 12:41:13 <aleth> clokep_work: Oh good. 12:41:22 --> atuljang1 has joined #instantbird 12:41:51 * atuljang1 yay, back to 3G 12:42:05 <aleth> Anyway, I suggested it because this doesn't look too bad: https://developer.mozilla.org/en-US/docs/DragDrop/Recommended_Drag_Types#file 12:42:22 <atuljang1> clokep_work: Sorry, got disconnected for few seconds. 12:42:34 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:42:49 <clokep_work> aleth, atuljang1: If drag 'n' drop is easy, go with it. :) 12:43:06 <atuljang1> clokep_work: Okay point noted. :) 12:43:20 <aleth> Not that we won't need the file chooser thing as an alternative eventually anyway ;) 12:43:52 <atuljang1> Yes, we'll need both. So by the end, I should be implementing both of 'em. 12:45:45 <clokep_work> Did you get your hg problem fixed? What URL are you pulling from? 12:46:21 <atuljang1> problem is with hg pull -R ./mozilla http://hg.mozilla.org/releases/mozilla-release/ 12:47:14 <atuljang1> Trying to fix it, I had it once before also, but that time, it was due to old version of hg 12:47:25 <clokep_work> atuljang1: First of all, why not using |python client.py checkout|? 12:47:39 <clokep_work> And that version of hg should be OK, AFAIK. :-/ 12:47:56 <atuljang1> clokep_work: using that only, I was just telling you the problem causing url 12:47:59 <clokep_work> You could download an hg bundle and unpack it though if that's easier. 12:48:10 * clokep_work finds it to be faster 12:48:25 <atuljang1> oh okay. Doing so. 12:49:34 <clokep_work> mkdir mozilla && cd mozilla && wget http://ftp.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-release.hg && hg init && hg unbundle mozilla-release.hg && cd .. 12:50:23 --> jb1 has joined #instantbird 12:50:35 <flo-retina> clokep_work: drag&drop is easier than a button: you don't need a file picker, etc... 12:50:50 <-- jb has quit (Ping timeout) 12:50:53 <atuljang1> clokep_work: doing it. 12:51:19 <atuljang1> flo-retina: Okay, so my first work should be making drag and drop work in conversation window? 12:52:59 <-- atuljang1 has quit (Ping timeout) 12:53:19 <flo-retina> atuljang1: how would "drag a file from the OS's file viewer, drop it on a conversation, and that should display a system message 'Sending <filename>â¦' in the conversation" sound as a very simple first step? 12:53:36 <clokep_work> ++flo 12:53:45 * clokep_work almost typed += flo 12:53:51 <clokep_work> That would have looked weird. ;) 12:55:50 * nhnt11 wonders if his conversation.xml changes may conflict with some of atuljangra's stuff. 12:56:01 <nhnt11> clokep_work: Haha. 12:56:38 <clokep_work> nhnt11: Don't worry about that, we can always resolve them later. :) 12:57:02 <nhnt11> clokep_work: I was just thinking, if it involves /anything/ with tabbrowser, there may be a lot of stuff to resolve. 12:57:11 <clokep_work> (But probably. ;)) 12:57:16 <clokep_work> It shouldn't. 12:57:25 <nhnt11> Not so much with the conversation binding I guess, but I was just wondering aloud :) 12:57:34 <aleth> nhnt11: I don't think it will clash 12:57:40 --> jb has joined #instantbird 12:57:47 <flo-retina> as others just said, don't worry about it :) 12:57:49 <aleth> Beyond possibly standard bitrot issues, that is 12:58:04 <nhnt11> Heh. I'm not worrying, just wondering :) 12:58:08 <nhnt11> brb, updating to nightly 12:58:10 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 12:58:20 <-- jb1 has quit (Ping timeout) 12:58:52 --> nhnt11 has joined #instantbird 12:59:24 <nhnt11> Brilliant, Ib was already in the dock, and the icon didn't get updated to the black one. I hope this survives a reboot :P 13:00:06 <nhnt11> aleth: My pastebin addon isn't broken anymore, thanks :) 13:03:28 * qheaden_away is now known as qheaden 13:03:39 <qheaden> Hi all. :) 13:03:44 <clokep_work> Good morning. 13:03:47 --> atuljangra has joined #instantbird 13:04:38 <atuljangra> nhnt11: You are in Pilani, right? 13:04:47 <nhnt11> atuljangra: Goa campus. 13:04:53 <atuljangra> Oh okay :) 13:05:43 * atuljangra Strange thins happen. Was connected as atuljang1 and IB shows that connection still connected but I was disconnected from the server. 13:05:45 <atuljangra> :s 13:06:09 <atuljangra> Copy Pasting, what I *thought* I said :-/ 13:06:17 <atuljangra> 06:20:53 PM - atuljang1: clokep_work: doing it. 13:06:17 <atuljangra> 06:21:18 PM - atuljang1: flo-retina: Okay, so my first work should be making drag and drop work in conversation window? 13:06:17 <atuljangra> 06:25:55 PM - atuljang1: flo-retina: Also, in the end, ww'll be needing both right, icon + drag and drop? 13:06:18 <atuljangra> 06:29:09 PM - atuljang1: aleth: Did you read about the links problem that I was getting? It is still here. [â¦] 13:07:07 <clokep_work> atuljangra: First step is what flo-retina suggested. 13:07:13 <aleth> atuljangra: Any icon and where to put it will be part of the discussion of the whole UX around it 13:07:18 <clokep_work> And yes, it happens when the server thinks the socket is closed and we don't. 13:07:31 <aleth> atuljangra: Did you see the bug open on that? 13:07:35 <flo-retina> atuljangra: yes, we will need an icon at some point. Finding a place for it may not be completely trivial though (adding a whole toolbar for just one icon would be an awful plan ;)). 13:08:03 <atuljangra> aleth: Yes agreed. 13:08:25 <atuljangra> flo-retina: Indeed a toolbar is not an good idea, we can hack on it later. Forst things first. 13:08:45 <atuljangra> aleth: Bug open on? me getting disconnected? 13:08:47 <flo-retina> atuljangra: you could also add a "send a file" context menu item 13:09:00 <atuljangra> Yes, that could be it, 13:09:02 <nhnt11> atuljangra: A /sendfile command would be nice ;) 13:09:10 <aleth> atuljangra: "the links problem" 13:09:11 --> novabyte has joined #instantbird 13:09:45 <atuljangra> aleth: No, I saw a conversation earlier, which clokep_workpointed me too, But that time the problem was that the handlers table was empty. 13:09:46 <aleth> atuljangra: Just get enough up and running so you can test your backend changes ;) 13:10:00 <atuljangra> aleth: Yes. 13:10:04 --> atuljangra1 has joined #instantbird 13:10:18 <-- atuljangra1 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com) 13:10:43 <aleth> atuljangra: Bug 1995 13:10:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1995 nor, --, ---, nobody, NEW, IB does not open links, as http/https handlers not populated 13:10:57 <nhnt11> atuljangra: Btw, I find that "/msg instantbot ping" is a great way of finding out if you're still online 13:11:20 <atuljangra> flo-retina: So I guess making a context menu item for now, could be sufficient for testing purposes? What do you think? 13:11:33 <atuljangra> aleth: But handlers are populated properly in my case. 13:11:42 <atuljangra> nhnt11Yes:-) Thanks :) 13:11:43 <aleth> nhnt11: My patch in bug 1554 may also help ;) 13:11:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, aleth, ASSI, IRC should notify the user when messages couldn't be sent 13:11:57 <flo-retina> atuljangra: drag&drop seems better to me for testing, as you wouldn't have to deal with a file picker each time you want to test sending a file 13:12:21 <aleth> atuljangra: There is a completely independent way I have found to reproduce the issue: Run two instances of IB at the same time. The second instance will have the problem 13:13:09 <aleth> I don't know what's causing that :-/ 13:13:20 <nhnt11> flo-retina, aleth: Why not write a command to send a particular file for testing purposes? 13:13:28 <nhnt11> I meant to mention atuljangra in that ^ 13:13:33 <flo-retina> isn't that slower to use? 13:13:41 <atuljangra> Okay, so my first task would be to implement drag and drop in conversation? 13:13:42 <flo-retina> unless you copy paste 13:13:43 <nhnt11> flo-retina: If the file is hardcoded, no. 13:13:47 <flo-retina> and typing a file name/path without completion is awful 13:14:07 <aleth> nhnt11: That sounds awful 13:14:13 <flo-retina> atuljangra: have you seen http://log.bezut.info/instantbird/130613#m439 ? 13:14:32 <nhnt11> aleth: I meant only for testing backend stuff, perhaps as an addon. It's what I would do anyway. No matter. 13:14:39 * flo-retina is going to be in a meeting for the next hour or so 13:14:44 * nhnt11 gets back to the about: page panel 13:14:59 <clokep_work> flo-retina: http://log.bezut.info/instantbird/130613/#m439 13:15:03 <clokep_work> Bah. 13:15:08 <clokep_work> atuljangra: http://log.bezut.info/instantbird/130613/#m439 should be your first task. 13:15:12 <atuljangra> no, something happened and I was disconnected. 13:15:28 <atuljangra> okay. 13:15:31 <atuljangra> :) 13:15:33 <aleth> nhnt11 has a handy add-on for that ;) 13:15:39 <clokep_work> Yes, it's usually good to check the logs. :) 13:15:48 <atuljangra> Thanks :) 13:16:22 <-- jb has quit (Connection reset by peer) 13:16:31 <atuljangra> aleth: Regarding the link bug, I think my situation is completely different. Handlers table is properly filled. 13:16:48 <atuljangra> And only Firefox does not work, Google-chrome is working. 13:16:51 <atuljangra> :-s 13:17:09 <aleth> atuljangra: But is it this? "03:12:16 PM - aleth: [â¦] There is a completely independent way I have found to reproduce the issue: Run two instances of IB at the same time. The second instance will have the problem 03:13:03 PM - aleth: I don't know what's causing that :-/" 13:17:36 <atuljangra> trying 13:17:39 <aleth> atuljangra: Anyway, file a bug please ;) 13:17:51 <atuljangra> sure :P 13:17:55 --> jb has joined #instantbird 13:18:17 --> nhnt13 has joined #instantbird 13:18:38 <nhnt11> aleth: I just tried running two instances and clicking a link. It works for me. 13:19:05 <aleth> nhnt11: You are not on Linux :P 13:19:14 <aleth> But thanks! 13:19:21 <nhnt11> Cool, just thought I'd mention it in case it was a separate bug. 13:19:30 <aleth> Yes, good to know. 13:19:38 <-- nhnt13 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 13:19:57 <aleth> I guess I should file that variant of the bug too. 13:20:37 <atuljangra> I had two instances, and links were not working that way also. 13:21:38 <instantbot> New Instantbird (UI) bug 2003 filed by aleth@instantbird.org. 13:21:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2003 nor, --, ---, nobody, NEW, Opening links fails on a second instance of Instantbird 13:22:22 * atuljangra doesn't want to use Google-chrome, just for the sake of working IB's links 13:23:08 <aleth> atuljangra: If it fails for you on the first instance already, we *really* need to fix that 13:23:29 <atuljangra> Yes yes yes, that was exactly what I was meaning, 13:23:34 <atuljangra> This is a bad bad bug. 13:23:55 <atuljangra> aleth: What could be causing the problem? 13:24:16 <aleth> atuljangra: I don't know. 13:24:23 <nhnt11> I have a question: http://pastebin.instantbird.com/221641 13:24:49 <aleth> If the handlers are set correctly and it works in TB... I'd compare IB and TB 13:25:15 <aleth> But as I can't reproduce it's not easy 13:25:22 <atuljangra> What exactly should we be comparing? 13:25:33 <aleth> atuljangra: What happens on clicking a link 13:25:56 <aleth> What prefs are set and their default values 13:26:03 <-- jb has quit (Ping timeout) 13:26:15 <atuljangra> Okay. FYI Error in error log is : Timestamp: 06/13/2013 06:51:50 PM 13:26:15 <atuljangra> Error: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIExternalProtocolService.loadUrl] 13:26:15 <atuljangra> Source File: chrome://chat/content/convbrowser.xml 13:26:15 <atuljangra> Line: 1168 13:26:24 <aleth> atuljangra: Also, file a bug with specific details of your linux config 13:26:36 <atuljangra> Okay.Doing. 13:26:49 <aleth> atuljangra: That's just telling us there was a problem opening the link, which is the same for all these bugs. 13:27:03 <atuljangra> oh okay. 13:28:24 <nhnt11> aleth: That's the same code my ShowLogs addon uses, which means the addon should be broken too. 13:28:55 <aleth> nhnt11: Sure, it's not that there is a bug in that line code. 13:29:12 <nhnt11> aleth: I know, I actually meant to ask: Do you use my addon/does it work? 13:30:02 <aleth> It won't work whenever clicking links won't work. 13:30:28 <clokep_work> nhnt11: I think hg shelve is analogous to git stash. 13:30:42 <-- atuljangra has quit (Ping timeout) 13:31:15 --> qlum has joined #instantbird 13:32:25 <aleth> It's annoying the error code isn't more... helpful. 13:32:37 <clokep_work> nhnt11: You could also keep it as an extension? :) 13:32:57 <nhnt11> aleth: Actually no my addon uses loadURI, not loadUrl. Never mind. 13:33:15 <aleth> nhnt11: Still... 13:33:38 <nhnt11> aleth: Yes, sorry for rambing :] 13:34:05 <nhnt11> clokep_work: Keep what as an extension? 13:34:50 <nhnt11> clokep_work: Oh the tabtest UI 13:35:06 * nhnt11 wonders why he didn't think of that earlier, it's kind of obvious 13:35:15 <nhnt11> Thanks clokep_work! 13:35:30 <clokep_work> nhnt11: That's what they pay me for. :) 13:36:27 <nhnt11> I'm amazed at myself. I even have an extension for spawning the tab 13:36:28 <-- wuwei|offline has quit (Connection reset by peer) 13:36:59 --> wuwei|offline has joined #instantbird 13:36:59 --> mconley has joined #instantbird 13:37:09 --> jb has joined #instantbird 13:37:53 --> atuljangra has joined #instantbird 13:38:08 * atuljangra stupid 3G :( x-( 13:38:11 <instantbot> New Instantbird (UI) bug 2004 filed by atuljangra66@gmail.com. 13:38:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2004 maj, --, ---, nobody, UNCO, Opening links fails when Firefox is used as handler. 13:39:44 <atuljangra> aleth: Should I mark the bug as confirmed/. 13:40:08 --> FireFly_TB has joined #instantbird 13:40:21 <aleth> atuljangra: I'll do it 13:40:29 <atuljangra> Awesome :) 13:40:33 <-- Kaishi has quit (Quit: Kaishi) 13:46:55 <nhnt11> developer.mozilla.org seems to be down? 13:47:25 <nhnt11> Never mind, it's working now 13:47:27 <-- atuljangra has quit (Ping timeout) 13:48:05 <-- jb has quit (Ping timeout) 13:49:28 <nhnt11> How do I createElementNS() without a -moz-binding? 13:49:52 <nhnt11> Would createElementNS(XUL_NS, "chrome://tabtest/tabtest.xml#tabtest") work? 13:51:09 <aleth> Does createElementNS(XUL_NS, "tabtest") work? 13:51:21 <nhnt11> aleth: Without specifying the binding in a css file, no. 13:52:10 <aleth> I don't know then. Experiment? ;) 13:52:15 <nhnt11> aleth: Doing that now. 13:55:46 * clokep_work sometimes wishes old stuff would become context automatically after a while. 13:55:57 <clokep_work> I sometimes put conversations on hold and restore them just to have stuff become "context" 13:59:27 <nhnt11> clokep_work: Do you mean greyed out? 14:01:56 * aleth should find time to look at adding messages dynamically :-/ 14:02:11 <clokep_work> nhnt11: Yes. 14:02:17 <clokep_work> We call them "context messages". 14:02:31 <nhnt11> Right, I was just making sure I understood correctly. 14:04:46 <clokep_work> RIght. :) 14:05:05 --> jb has joined #instantbird 14:08:40 <nhnt11> I'm not having much luck creating a new element from my tabtest binding. 14:09:01 <nhnt11> If I overlay a CSS file, will it work with bootstrap? 14:09:30 <nhnt11> Make that, is it possible to overlay CSS with a bootstrapped addon/ 14:09:43 * clokep_work has no idea. 14:09:56 <aleth> Not easily. Maybe you can find a workaround on Google... 14:09:58 <clokep_work> nhnt11: https://developer.mozilla.org/en/Extensions/Bootstrapped_extensions#Adding_user_interface_with_a_chrome.manifest 14:10:09 <flo-retina> if bug 2003 is "links don't work when I start with --no-remote", that's likely either wontfix or invalid. 14:10:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2003 nor, --, ---, nobody, NEW, Opening links fails on a second instance of Instantbird 14:10:14 <clokep_work> Ah, awesometab gave me an old link: https://developer.mozilla.org/en-US/docs/Extensions/Bootstrapped_extensions#chrome.manifest_in_bootstrapped_add-ons 14:10:27 <aleth> But first, it might be an XBL issue. Ask on #developers 14:10:30 <nhnt11> clokep_work: awesomebar* :P 14:10:53 --> atuljangra has joined #instantbird 14:10:55 <nhnt11> aleth: I don't think so. I'll ask on #developers anyway. 14:11:06 <aleth> flo-retina: Right, I've known about it for ages without filing it for that reason. I only filed it because some potentially related bugs seem to have been cropping it. 14:11:14 <aleth> s/it/up 14:11:45 <clokep_work> nhnt11: https://developer.mozilla.org/en-US/docs/Chrome_Registration#Instructions_supported_in_bootstrapped_add_ons says style does not work in bootstrap. 14:11:57 <nhnt11> Yeah. :( 14:12:56 <-- wuwei|offline has quit (Connection reset by peer) 14:13:33 --> wuwei|offline has joined #instantbird 14:13:34 <-- atuljangra has quit (Ping timeout) 14:17:08 --> atuljangra has joined #instantbird 14:17:33 * atuljangra another 3G brokedown :( 14:18:18 <atuljangra> aleth: one other person seems to have this problem :-/ 14:18:48 <aleth> atuljangra: One is one too many if we can figure it out and fix it ;) 14:19:09 <clokep_work> Haha: http://james-ross.co.uk/mozilla/misc/nserror?0x80004005 "This is the most general of all the errors and occurs for all errors for which a more specific error code does not apply."...very helpful 14:19:15 <atuljangra> :P 14:19:35 <atuljangra> clokep_work: Haha, :P 14:24:29 <qheaden> clokep_work: Yeah, it turns out that I was having trouble because the docs online don't describe version 16 of the YMSG protocol. They describe older versions. :-/ 14:24:43 <qheaden> libpurple's code cleared things up. 14:25:15 <clokep_work> qheaden: Excellent. :) Please include TONS of documentation in the code! 14:25:27 <qheaden> Yeah. It will be needed. 14:25:36 <clokep_work> (And even on our wiki / imfreedom's wiki if you feel so inclined.) 14:25:46 <clokep_work> I personally just like adding big comment blocks above functions describing what they do. :P 14:26:44 <aleth> qheaden: At least hopefully all the servers will be running the same version ;) 14:27:21 <qheaden> aleth: When sending an authentication request packet, you can actually request for a certain version. 14:27:33 <qheaden> libpurple requested for 16, so I followed suit. 14:28:37 <nhnt11> qheaden: So if Yahoo! decides to drop support for older versions, we're screwed ;) 14:29:03 <qheaden> :P 14:29:24 <qheaden> Not on my watch! 14:29:35 <nhnt11> :) 14:29:36 * qheaden starts to promote his new protocol plugin. 14:30:00 <qheaden> nhnt11: So is the awesomeness of awesometab growing? :) 14:30:23 <nhnt11> qheaden: There isn't an awesometab yet, because I'm wasting time trying to get this addon working :P 14:30:52 <nhnt11> I should stop being so obsessive, a non-bootstrapped addon would suffice. 14:30:53 <aleth> If this is the about pages thing, just do it as a patch, we want it in IB anyway :P 14:31:17 <nhnt11> aleth: No, this is to load my test tab from a command :P 14:31:25 <nhnt11> I'm going to stop wasting time on it now. 14:31:41 <aleth> nhnt11: XBL plus add-ons is often a cause of headaches :-/ 14:32:15 <aleth> At least for bootstrapped ones. 14:48:13 * qheaden was able to print his friends to the error console. 14:51:12 <aleth> great :) 14:53:20 <-- FireFly_TB has quit (Ping timeout) 14:53:37 <clokep_work> qheaden: Sounds good. :) Yeah I'd expect stuff to break if they set the minimum version too high... 14:59:41 --> Optimizer has joined #instantbird 15:07:00 <-- sabret00the_ has quit (Quit: Leaving) 15:08:24 <-- mpmc has quit (Ping timeout) 15:09:25 <qheaden> Going to get something to eat. Be back. 15:09:34 * qheaden hasn't eaten breakfast yet. 15:10:19 --> mpmc has joined #instantbird 15:11:34 * clokep_work thinks that's talk for #chatdev. 15:12:21 --> mpmc1 has joined #instantbird 15:12:25 <aleth> or maybe #breakfastdev... 15:12:42 <-- mpmc has quit (Ping timeout) 15:17:39 <-- aleth has quit (Quit: Ciao) 15:18:05 <-- mpmc1 has quit (Ping timeout) 15:19:15 --> mpmc has joined #instantbird 15:28:02 --> mpmc1 has joined #instantbird 15:28:25 <-- mpmc has quit (Ping timeout) 15:28:50 --> Nirgali has joined #instantbird 15:31:45 <-- mpmc1 has quit (Ping timeout) 15:31:45 --> mpmc has joined #instantbird 15:32:24 <-- jb has quit (Connection reset by peer) 15:32:49 --> jb has joined #instantbird 15:33:06 <-- jb has quit (Client exited) 15:33:07 --> jb1 has joined #instantbird 15:33:12 <-- Nirgali has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 15:37:35 <qheaden> clokep_work: What's the process for adding a buddy programatically? 15:40:43 --> mpmc1 has joined #instantbird 15:41:23 <-- mpmc has quit (Ping timeout) 15:44:20 <nhnt11> I'm back 15:44:25 <-- mpmc1 has quit (Ping timeout) 15:44:33 * nhnt11 doesn't think he said he was going to be away. Oops. 15:46:00 <flo-retina> nhnt11: you don't have to announce when you are away or back. As long as you get some work done, we don't care at which hour of the day you do it, nor how many breaks you take ;). 15:46:24 <nhnt11> I said oops because I said I was back without stating I would be away :P 15:46:25 <flo-retina> unless maybe when someone is actively interacting with you. 15:46:43 * qheaden decides to start work again next month after listening to flo-retina. 15:47:02 <qheaden> :P 15:47:32 <flo-retina> qheaden: I said "don't care at which hour of the day", how does that translate to "next month"? :-S 15:47:41 <nhnt11> I just sat and pondered why about:config wasn't loading for 5 minutes before realizing I forgot jar.mn again :] 15:47:41 <qheaden> lol 15:48:03 <flo-retina> nhnt11: that happens. 15:48:31 <flo-retina> nhnt11: someday you'll also forget to update package-manifest.in ;) 15:48:41 <nhnt11> :P 15:48:57 --> mpmc has joined #instantbird 15:55:18 <nhnt11> http://pastebin.instantbird.com/221737 15:55:23 <nhnt11> I'm getting that error^ 15:55:28 <nhnt11> Not quite sure what it means yet 15:56:21 <nhnt11> I suppose setting disableHistory would fix it, but I don't think we want to do that. 15:56:26 <flo-retina> nhnt11: that means you forgot a disablehistory="true" attribute on a <browser> XUL tag 15:56:39 <-- mpmc has quit (Connection reset by peer) 15:56:41 <nhnt11> flo-retina: Why do we have to disable it? 15:56:58 <flo-retina> I think we don't compile the history component at all 15:57:07 <nhnt11> Ah okay 15:57:44 <flo-retina> and even if we did, the links you would like you have in the history are the links you visit, not the URLs you display in <browser>s 15:58:23 <flo-retina> hmm, history is probably compiled in, it seems the compile time switch to disable it no longer exists. 15:58:29 <nhnt11> flo-retina: I was thinking, if this became a full browser for about: pages, we might want history 15:58:33 <nhnt11> It's not important though 15:58:45 <flo-retina> you don't want this to be a full browser for about pages 15:58:59 <flo-retina> if there's a link in there, clicking it should open it in the user's default browser 15:59:09 <flo-retina> (would be especially useful for crash reports) 15:59:15 <nhnt11> flo-retina: Okay. I want to include a drop-down menu with about: pages that the user can select 15:59:29 <flo-retina> that's an add-on, right? 15:59:32 <nhnt11> And dynamically set them through that. 15:59:34 <nhnt11> No 15:59:40 <nhnt11> I thought we wanted this in core 15:59:50 <flo-retina> nah, we want an /about command 16:00:00 <flo-retina> discovering the list of existing about: pages isn't useful 16:00:09 <nhnt11> Okay fine 16:00:18 <flo-retina> they are useful only when we point someone at them for troubleshooting, and *we* already know them 16:00:21 <nhnt11> By the way, http://puu.sh/3ePSS.png :) 16:00:28 <nhnt11> Also http://puu.sh/3ePSS.png 16:00:33 <nhnt11> Sorry, I mean http://puu.sh/3ePTp.png 16:00:38 <flo-retina> having plenty of confused users looking at a broken about:support isn't attractive to me ;) 16:01:30 <qheaden> Are there plans (or fixes) to make Ib play nice with Ubuntu unity? 16:01:31 <flo-retina> nhnt11: looks like you are making great progress :) 16:01:40 <flo-retina> nhnt11: still need to display the document title in the tab ;) 16:01:46 <nhnt11> Not a single error in the console! 16:01:48 <nhnt11> :) 16:01:52 <flo-retina> qheaden: do you have plans for that? 16:01:55 <nhnt11> flo-retina: I've already added code for that, but it's not called yet 16:02:05 <flo-retina> there may be some add-ons to improve the interactions with unity 16:02:07 --> Nirgali has joined #instantbird 16:02:14 <qheaden> flo-retina: No. Maybe after my project is over I might. 16:02:38 <flo-retina> qheaden: ok, I guess a few ubuntu users may really like that ;) 16:02:41 * nhnt11 is extremely satisfied seeing the about:config tab 16:02:43 <qheaden> It's quite annoying when you hit X, and the window becomes inaccessable. 16:02:51 <flo-retina> unfortunately I don't use ubuntu enough to actually care :-/. 16:03:16 <flo-retina> nhnt11: yeah, it's nice when there's finally something visibly working! :) 16:04:41 <-- jb1 has quit (Ping timeout) 16:05:13 --> jb has joined #instantbird 16:05:13 <-- jb has quit (Excess Flood) 16:05:39 <nhnt11> flo-retina: Do we want any other about: pages other than config? 16:05:43 --> jb has joined #instantbird 16:06:03 <flo-retina> nhnt11: aleth filed a bug today where we listed the pages that could be interesting 16:06:08 <nhnt11> Ah okay 16:06:11 <nhnt11> I'll take a look 16:06:35 <flo-retina> nhnt11: but it seems like we just want "/about whatever" to open about:whatever if that page exists 16:06:42 <nhnt11> flo-retina: Where's the best place to add the /about command? 16:06:58 <nhnt11> Right. I'll make a table of existing about pages with their URIs and load if it exists. 16:08:23 <flo-retina> hmm, you need that to be done in some UI file (so in instantbird/) 16:10:05 <flo-retina> http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#64 and http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#99 are the 2 possible places that come to mind 16:10:32 <flo-retina> "make a table of existing about pages with their URIs" you may not really need that 16:11:32 * flo-retina just discovered about:about 16:11:37 <nhnt11> flo-retina: You're saying try to load the URI, and leave the default error message if it doesn't work/ 16:11:38 <nhnt11> ?* 16:11:44 <flo-retina> no 16:12:09 <flo-retina> I'm saying that there's probably a programmatic way to check if the url the user entered exists / can be mapped to something 16:13:18 <nhnt11> Okay. So "/about <pagename>" should load "chrome://global/content/<pagename>.xul", if it exists. 16:14:21 <flo-retina> no 16:14:50 <flo-retina> the about: protocol handler doesn't map everything to chrome://global/ 16:15:02 <flo-retina> I think about:credits is even an online page 16:15:38 <nhnt11> Hmm 16:15:49 <nhnt11> Would just setting the src to "about:<pagename>" work? 16:16:14 <flo-retina> nhnt11: http://mxr.mozilla.org/mozilla-central/source/docshell/base/nsAboutRedirector.cpp#31 16:16:17 <flo-retina> nhnt11: yes 16:16:27 <nhnt11> That's cool. :) 16:16:30 <flo-retina> but you you "set the src", you have already opened a tab 16:17:00 <flo-retina> I would like you to just display an system message in the current conversation with an error when there's a typo, rather than opening a broken tab 16:17:21 <flo-retina> (but you can ignore this part for now and just assume users that don't typo :)) 16:17:35 <nhnt11> flo-retina: That's not a problem. Check if the URI exists, if so open tab and set uri. Else display system message. 16:19:32 <flo-retina> looks like http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/about/nsAboutProtocolHandler.cpp?force=1#162 could be useful 16:20:06 <nhnt11> flo-retina: I don't quite understand why you gave me those ibCore.jsm/imWindows.jsm links. They don't register any other commands. Are you saying listen for "conversation-loaded" and register the command in the observer? 16:20:57 <flo-retina> nhnt11: no. The commands are global. All the other existing global commands are in chat/ (and shared with Thunderbird). (if you want to see them they are in http://lxr.instantbird.org/instantbird/source/chat/components/src/imCommands.js#18) 16:21:20 <nhnt11> Why don't we do it there then? 16:21:21 <flo-retina> so you need to register your command in a place in instantbird/ that will only be called once during startup 16:21:35 <flo-retina> do what? 16:21:43 <nhnt11> register the command in imCommands.js 16:21:49 <nhnt11> Oh, shared with Tb 16:21:54 <flo-retina> because we don't want the /about command in Tb 16:22:00 <nhnt11> Right right. 16:22:50 <nhnt11> I'm going to do it in ibCore.jsm. 16:24:01 <flo-retina> nhnt11: imWindows.jsm may be an interesting place, as it's where you have the list of all the existing chat windows. 16:24:18 <clokep_work> qheaden: I'm not sure what that question really means...but let me read the scrollback. 16:26:55 <nhnt11> flo-retina: I didn't want to put it there because this isn't exactly related to windows. 16:27:15 <nhnt11> If I was looking for the code that registered the command, I would look in ibCore before imWindows 16:27:20 <flo-retina> opening a tab in a chat window seems related to chat windows to me 16:27:32 <-- gerard-majax has quit (Ping timeout) 16:27:34 <nhnt11> Hmm 16:27:41 <nhnt11> You're the boss :P 16:27:44 <flo-retina> nhnt11: if I was looking for the code registering commands, I would lxr registerCommand 16:28:15 <nhnt11> flo-retina: Assume a universe where lxr doesn't exist, whenever I talk about searching for stuff :P 16:28:23 <flo-retina> nhnt11: both places are fine with me. So if you prefer ibCore, go for it, and it shouldn't be difficult to switch later if you notice you need access to something you can't get from there 16:28:41 <flo-retina> nhnt11: then I'll need to recreate/setup lxr 16:28:53 <nhnt11> Lol :) 16:29:36 <clokep_work> There's always grep. 16:29:47 <nhnt11> Does this sound okay for the description? "about <page>: display about:<page> in a new tab." 16:30:24 * nhnt11 wonders why there is a semicolon after <page>, it's not in the text he copied. 16:30:28 <clokep_work> What's with the semi-colon? 16:30:38 <clokep_work> Seems like HTML escaping issue? 16:30:42 <nhnt11> clokep_work: Yes. 16:30:58 <nhnt11> Put that line in quotes, it adds a semi-colon there. No quotes, no semicolon 16:31:40 <nhnt11> Semi-colon aside, does it seem fine? 16:33:02 <-- jb has quit (Ping timeout) 16:33:27 <clokep_work> Yes. 16:37:12 <qheaden> clokep_work: I just wanted to know how I can add buddies to the Ib UI when I receive the buddy list from the YMSG server. 16:37:37 <flo-retina> qheaden: I would look for examples in the IRC code 16:37:39 * nhnt11 is trying to figure out how localization works for this. 16:38:00 <nhnt11> Got it I think 16:38:07 <qheaden> flo-retina: Does IRC have buddies? 16:39:04 <flo-retina> not coming from the server 16:39:11 <clokep_work> qheaden: But it still creates them. 16:39:19 --> jb has joined #instantbird 16:39:22 <-- jb has quit (Excess Flood) 16:39:24 <qheaden> Okay. 16:39:26 <clokep_work> nhnt11: Did you look at the examples in imCommands.jsm. 16:39:30 --> jb has joined #instantbird 16:39:32 <clokep_work> qheaden: We also do it for XMPP? 16:39:35 <clokep_work> That might make more sense? 16:39:35 <nhnt11> clokep_work: That's what I'm doing 16:40:05 <qheaden> clokep_work: Okay, I'll take a look at how XMPP handles it. 16:40:21 <clokep_work> That means you get to ask flo-retina questions and not me. ;) 16:40:45 <qheaden> :) 16:41:05 <flo-retina> clokep_work: uh 16:41:06 * flo-retina hides 16:41:42 * nhnt11 uses lxr to find him 16:41:46 <qheaden> flo-retina: Question 1 of 100 - what is XMPP? 16:41:53 <qheaden> :P 16:42:30 <clokep_work> No one really "owns" XMPP. :( 16:42:44 <clokep_work> Well "owns" the XMPP code. 16:43:14 <qheaden> Speaking of XMPP, was there any more investigation of the Google Hangouts "typing" bug? 16:48:23 <nhnt11> flo-retina: Where do I put the localization string for this 16:48:31 <nhnt11> It can't go with the other commands because those are in chat/ 16:49:12 * nhnt11 finds l10n painful, he was done with the rest of this in 5 minutes. 16:49:40 * mconley is now known as mconley|lunch 16:49:56 <nhnt11> flo-retina: Shall I just stick it in instantbird.properties? 16:50:16 <nhnt11> Ah, there's a core.properties. I assume that's for ibCore.jsm anyway. 16:54:03 <clokep_work> qheaden: No, we'd want a debug log. Hopefuly deOmega will provide it (he's usally good for things like that) 16:54:20 <clokep_work> nhnt11: At the top of the file it probably says what properties file it uses. ;) 16:54:26 <nhnt11> http://pastebin.instantbird.com/221763 16:54:46 <clokep_work> (If at all) 16:54:57 <nhnt11> I don't think clokep_work will like the way that code gets the helpmsg ;) 16:55:13 <nhnt11> clokep_work: Yes it's core.properties. 16:55:35 <clokep_work> nhnt11: http://lxr.instantbird.org/instantbird/source/instantbird/modules/ibCore.jsm#228 16:55:54 <nhnt11> clokep_work: Yes I saw that! :) 16:56:34 <nhnt11> I'm sorry, I just think aloud a lot. 16:57:24 <nhnt11> Oops that code uses quitDialog. I must've forgotten to change it after pasting :] 16:59:33 <clokep_work> nhnt11: That command patch should be r? me. 16:59:44 <nhnt11> Okay 16:59:57 * nhnt11 prepares for r-'s :P 17:00:33 <-- flo-retina has quit (Ping timeout) 17:03:21 --> flo-retina has joined #instantbird 17:03:21 * ChanServ sets mode +qo flo-retina flo-retina 17:04:34 <-- MMN-o has quit (Connection reset by peer) 17:04:35 <clokep_work> Do I have the reputation of being a hard reviewer? ;) 17:04:36 --> MMN-o has joined #instantbird 17:04:46 <clokep_work> I shouldn't be right now, I've been exhausted. :( 17:06:29 <nhnt11> :( 17:06:36 <-- novabyte has quit (Quit: bye bye) 17:06:43 <nhnt11> clokep_work: I just need to test this patch, and it should be up. 17:07:27 * mconley|lunch is now known as mconley 17:07:35 <nhnt11> clokep_work: I've named the about page displayer binding aboutPanel. Would you rather I named it something else? 17:07:41 <-- MMN-o has quit (Ping timeout) 17:07:43 <nhnt11> I don't really know what to call it 17:07:56 <clokep_work> nhnt11: That's OK for now. 17:08:00 <clokep_work> If I think of a better one I'll let you know 17:08:54 <-- flo-retina has quit (Ping timeout) 17:10:55 --> MMN-o has joined #instantbird 17:11:29 --> flo-retina has joined #instantbird 17:11:30 * ChanServ sets mode +qo flo-retina flo-retina 17:11:39 <clokep_work> Yay http://kewisch.wordpress.com/2013/06/13/the-thunderbird-remote-debugger-is-alive/ 17:13:02 --> aleth_mob has joined #instantbird 17:13:54 <clokep_work> flo-retina: Do we have any plans of syncing chat before TB 24? That's in like 5 days. 17:16:20 <clokep_work> Is aleth_mob aleth? :-S 17:16:45 <clokep_work> (If not...welcome? :)) 17:17:49 <flo-retina> "That's in like 5 days." really? :( 17:19:34 <clokep_work> I think mconley said it was in 8 days at the meeting on Tuesday? 17:19:35 <nhnt11> It appears my tabbrowser changes still don't deal with dynamic content well. If a tab is opened in a new window, it will display the panel in its original state. I want to make it just work without the "finishImport" stuff to set the state. 17:20:00 <mconley> clokep_work: 24th, me thinks 17:20:54 <clokep_work> https://wiki.mozilla.org/RapidRelease/Calendar says the 6-24, yes. 17:21:46 <clokep_work> It'd be nice to get a few days of testing on Daily before aurora. (Whatever you TB people call Aurora. :)) 17:21:58 <clokep_work> But 24 is the next ESR so...it's a "big deal". :) 17:21:58 <aleth_mob> clokep: yes, it's me- if this works that is 17:22:12 <clokep_work> aleth_mob: What phone do you have that it runs J2ME? :P 17:25:02 <aleth_mob> This one is an old Samsung. not so great for this... but I was intrigued it was possible at all 17:26:56 <aleth_mob> awesome to get from bug to patch on the same day for the about command! 17:26:58 <flo-retina> clokep_work: so yeah, we really need to sync with c-c before that 17:27:25 <-- aleth_mob has left #instantbird () 17:27:44 <flo-retina> I'll be in a talkilla work week all of next week, that may make finding time for that kind of stuff difficult :( 17:28:30 * qheaden is now known as qheaden_away 17:30:56 <clokep_work> flo-retina: I might be able to do it...but I'm unsure exactly what hg convert magic you did :) 17:32:43 <nhnt11> This has been a good exercise! I discovered something - when a tab is opened in a new window, it needs to sort of clone itself in finishImport. Static tabs won't have any problem but any tab that sets stuff dynamically needs to do some work to restore its state. 17:33:02 <nhnt11> This should be fixed somehow later on, but for now I'm going to add a comment and make a few modifications that makes it clear. 17:33:26 <clokep_work> Can you expand on what "sets stuff dynamically" means? :) 17:36:22 <nhnt11> clokep_work: Stuff that isn't hard coded in <content> 17:36:40 <nhnt11> Like the current text in a conversation's input box, or the about page that has been loaded in an aboutPanel 17:37:17 <clokep_work> Ah, I see. 17:41:29 <-- Optimizer has quit (Ping timeout) 17:42:55 <nhnt11> Okay, I have this working. 17:44:21 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 17:45:03 --> Optimizer has joined #instantbird 17:48:07 <nhnt11> http://puu.sh/3eTSe.png :) 17:49:01 <clokep_work> nhnt11: Do the links work properly? 17:49:27 <nhnt11> They work, but I haven't added code to update the tab title. 17:49:33 <clokep_work> (Crash reports should open external to Instantbird, about pages should open in Instantbird.) 17:49:51 <nhnt11> crash reports aren't opening at all 17:50:06 <clokep_work> :( 17:50:19 <nhnt11> about pages are working though 17:51:06 <clokep_work> Cool. :) 17:52:31 <nhnt11> clokep_work: I think this is all the work I want to do on this. I hope that's fine 17:52:39 <nhnt11> (Maybe someone else can takeover and improve it?) 17:52:47 <clokep_work> nhnt11: It might need something like http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#1135 17:53:10 <clokep_work> nhnt11: Attach it to the bug. Hopefully you've learned a bit from it that will help you. :) 17:53:16 <nhnt11> clokep_work: If I can just duplicate that code, I'll do it. 17:53:30 <nhnt11> Yeah. it solved an important bug that would've crept up later. 17:53:39 <-- MMN-o has quit (Ping timeout) 17:53:39 <-- jb has quit (Ping timeout) 17:54:07 <clokep_work> I think you can just duplicate it, yes. 17:54:24 <nhnt11> Okay, so now I need to figure out how to attach a handler that's in the aboutPanel binding to its browser. 17:55:26 <clokep_work> Putting it in the handlers section doesn't make it just work for all of tha? 17:55:32 <clokep_work> *all of that binding 17:56:05 <nhnt11> I don't know. Trying that now. 17:56:54 --> MMN-o has joined #instantbird 17:58:00 <clokep_work> Then you can start on real awesometab stuff! :) 18:00:17 <nhnt11> :) 18:04:05 <clokep_work> atuljangra: Have you made any progress today? :) 18:05:20 <nhnt11> clokep_work: I adapted the code and it works great! :) 18:05:39 <nhnt11> I'll upload a patch now :) 18:06:01 * clokep_work prepares his red pen. 18:07:26 <nhnt11> clokep_work: Is if (url = elem.href) okay or should I do if ((url = elem.href)) ? 18:08:00 <nhnt11> Never mind, I'll just do url = elem.href; if (url). More readable. 18:08:57 <nhnt11> clokep_work: Do you think the http/https check is required here too? 18:09:09 <nhnt11> (http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#1157) 18:10:43 <clokep_work> nhnt11: A check is absolutely needed, we want about: links to open in Instantbird still. 18:10:58 <nhnt11> clokep_work: Those are handled before that in my code 18:11:10 <nhnt11> http://pastebin.instantbird.com/221807 18:12:09 <clokep_work> nhnt11: You don't need the https? check anymore then, yes. 18:12:19 <nhnt11> Cool. 18:12:59 <clokep_work> nhnt11: It'll probably be more readable to put a return after calling showAboutPage instead of having an else statement. 18:13:05 <nhnt11> okay. 18:15:44 <nhnt11> clokep_work: http://pastebin.instantbird.com/221808 18:16:08 * nhnt11 likes one liners 18:16:40 <clokep_work> nhnt11: I prefer the first one because it matches the other code. 18:16:46 <clokep_work> I also generally don't like doing assignments in if statements. 18:16:50 <nhnt11> Okay. 18:16:55 <clokep_work> But I wouldn't be opposed to changing both of the 18:17:57 <nhnt11> that's alright :P 18:18:42 <nhnt11> clokep_work: I'm adding code to open about pages in a new tab if they're middle-clicked. 18:19:48 <clokep_work> :) Excellent. 18:22:07 <clokep_work> nhnt11: Put it up for review soon and I can take a few minutes to review it. 18:22:30 <clokep_work> Remember that each time you make it more complex, the more likely I am to r- it. :P Sometimes it's better to leave things for follow ups! 18:22:30 <nhnt11> clokep_work: Sure. This is the last thing I'm doing for this. 18:22:54 <nhnt11> Middle click working well on first try :D 18:25:53 * qheaden_away is now known as qheaden 18:28:06 <nhnt11> clokep_work: That semicolon thing happens with the help message too 18:29:51 <-- Optimizer has quit (Ping timeout) 18:33:51 --> Optimizer has joined #instantbird 18:34:16 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2482 on bug 2002. 18:34:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nobody, NEW, Add an /about command to open the about:* pages 18:36:08 <nhnt11> brb 18:41:07 <nhnt11> re 18:42:56 <-- Optimizer has quit (Ping timeout) 18:44:45 <nhnt11> clokep_work: Btw if you intend to test that code, you need some changes to the patch in bug 426 that I haven't uploaded yet. 18:44:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 18:49:54 <-- Nirgali has quit (Ping timeout) 19:17:41 --> nhnt11_phone has joined #instantbird 19:22:24 <-- nhnt11_phone has quit (Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )) 19:22:52 --> jb has joined #instantbird 19:28:37 <-- jb has quit (Ping timeout) 19:36:22 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:43:31 --> Optimizer has joined #instantbird 19:45:19 <-- Optimizer has quit (Ping timeout) 19:46:08 --> Optimizer has joined #instantbird 19:51:37 <-- wuwei|offline has quit (Connection reset by peer) 19:52:09 --> wuwei|offline has joined #instantbird 19:57:28 <qheaden> I'm still a bit fuzzy on how XMPP adds buddies to the UI. Any insight? 20:13:19 <clokep_work> qheaden: Did you look at http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#306 20:15:15 <qheaden> Is Services.contacts.accountBuddyAdded(buddy) what does the trick? 20:17:07 * nhnt11 just discovered the hg color extension 20:17:22 <qheaden> nhnt11: One of the best ones IMO. 20:17:51 <nhnt11> Yes! I'd been meaning to google coloured diffs for a while, and just did it :) 20:19:35 <instantbot> clokep@gmail.com denied review for attachment 2482 on bug 2002. 20:19:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2002 enh, --, ---, nobody, NEW, Add an /about command to open the about:* pages 20:19:50 * nhnt11 was waiting for that 20:19:54 <clokep_work> qheaden: I think that's what did it, yes. 20:20:23 <clokep_work> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#1010 is where the core tells the IRC code that someone has a buddy on their buddy list. 20:20:27 <clokep_work> I think... 20:20:53 <clokep_work> qheaden: I lied, see http://lxr.instantbird.org/instantbird/source/chat/components/public/imIAccount.idl#71 20:21:20 <qheaden> clokep_work: Perfect! Thanks. 20:21:33 <nhnt11> clokep_work: No nits, yay :) 20:21:49 <qheaden> clokep_work: Also, would you happen to know what the tag field is for? To make contacts unique? 20:22:38 <clokep_work> qheaden: It's the tag the buddy is in ("group", but they're tags, not groups.) 20:23:16 <nhnt11> clokep_work: I purposely made it prefix the about: to ensure only about: pages can be displayed 20:23:35 <clokep_work> nhnt11: OK, that's fine. :) 20:23:51 * clokep_work is leaving in 5 minutes so comments might be better in the bug. 20:24:19 <qheaden> clokep_work: Okay, Thanks. 20:24:27 <nhnt11> I don't think I have anything else to say 20:25:09 <clokep_work> OK! :) 20:25:22 <clokep_work> I did ask a question about where things open. ;) 20:25:43 <nhnt11> I think aboutPage could be replaced with browser.src, yes. 20:26:02 <nhnt11> clokep_work: The multiple windows thing? 20:26:12 <clokep_work> Yes 20:26:21 <nhnt11> That works. It opens the tab in the window from which it was called. 20:26:32 <nhnt11> It is unaware of the "open conversations in new windows" pref 20:26:47 <clokep_work> Hm. OK. 20:26:58 <clokep_work> But if you have two windows it opens in the one the command was run in? 20:27:04 <nhnt11> Yes. 20:27:08 <clokep_work> Cool. :) 20:27:16 <clokep_work> I don't think I have further comments then. 20:28:46 <nhnt11> Cool :) 20:32:22 <clokep_work> flo: Btw I told ecaron I'd bug you about updating WordPress. :) 20:33:25 <-- Optimizer has quit (Ping timeout) 20:37:09 --> Optimizer has joined #instantbird 20:37:13 * clokep_work goes home. 20:37:22 <nhnt11> Bye clokep_work! 20:37:31 <nhnt11> I may go to bed soon, I'm kinda tired. 20:39:30 <clokep_work> Sleep is for the weak. 20:40:25 <nhnt11> clokep_work: Cool. 20:41:11 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 20:45:49 --> Nirgali has joined #instantbird 20:48:52 --> Mic has joined #instantbird 20:48:53 * ChanServ sets mode +h Mic 20:51:05 --> Mook_as has joined #instantbird 20:52:36 <-- Optimizer has quit (Ping timeout) 20:53:06 --> Optimizer has joined #instantbird 20:55:08 <-- Optimizer has quit (Ping timeout) 20:55:46 --> Optimizer has joined #instantbird 20:56:49 <-- Optimizer has quit (Connection reset by peer) 20:58:54 --> EionRobb has joined #instantbird 21:01:11 <-- mconley has quit (Input/output error) 21:03:42 --> mconley has joined #instantbird 21:07:35 <-- ivan has quit (Ping timeout) 21:07:50 <nhnt11> Mic: I'm about to upload a new patch to bug 426 21:07:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Add support for tabs with arbitrary content in the conversation window 21:08:00 <Mic> OK 21:08:07 --> ivan has joined #instantbird 21:08:08 <nhnt11> The commits are in my BB repo too, if you want to pull 21:13:40 <Mic> My tip is now awesometab-experimental/"Merge awesometab" 21:14:04 --> flo-retina has joined #instantbird 21:14:04 * ChanServ sets mode +qo flo-retina flo-retina 21:14:24 <nhnt11> Mic: Use the awesometab branch 21:14:30 <Mic> ok 21:14:43 <nhnt11> Right now they're the same, but for most things I use awesometab 21:15:15 <nhnt11> If I think something may break or want to work on something parallelly, I use the experimental one 21:17:34 <nhnt11> flo-retina: I wonder if you could test the macgestures changes in my patch when you're not busy. 21:17:51 <nhnt11> (The only thing that works on my hackintosh is two finger scrolling) 21:18:24 <flo-retina> nhnt11: I guess I also need to test the whole patch, right? ;) 21:18:35 <nhnt11> flo-retina: Well, that too :P 21:19:00 * nhnt11 is going through his patch again before uploading 21:19:29 <nhnt11> Mic, flo-retina: What do you feel about replacing document.getBindingParent() to window.getTabBrowser() ? 21:20:22 <flo-retina> nhnt11: sounds like a regression 21:20:45 <flo-retina> or rather "feels", as you asked for feelings :) 21:21:20 <nhnt11> Why? 21:22:00 <flo-retina> getBindingParent should work wherever the binding is used; getTabBrowser is specific to instantbird.xul/js 21:22:53 <nhnt11> flo-retina: It's not used anywhere else :/ 21:22:58 <nhnt11> But okay. I was just wondering. 21:23:54 <flo-retina> nhnt11: lots of things used in 2+ places used to be in only one ;). 21:24:09 <nhnt11> Okay. 21:26:31 * qheaden sees that WireShark is invaluable to his development. 21:26:56 <nhnt11> Mic: Since the dummy tab is going to be removed, the first conversation can no longer populate it. So I'm going to get rid of addConversation, rename _addConversation to addConversation, and make it use addTabPanel to create the conversation, after which it will set the conversation related properties. 21:27:11 <nhnt11> Does that make sense? 21:30:53 <Mic> Rather addTabPanelByBindingName than addTabPanel? 21:31:01 <nhnt11> Right. 21:31:07 <nhnt11> I changed that to FromBindingName btw. 21:31:24 <nhnt11> I think it makes more sense. 21:31:38 <flo-retina> why not addPanel and actually give a xul element as parameter? 21:31:40 <Mic> Still sounds awful :P 21:32:28 <Mic> flo-retina: there's addTabPanel already. 21:33:10 <nhnt11> Mic: How about createAndAddTabPanel? :P 21:33:22 <flo-retina> Mic: alright, I guess I really need to find time to review that patch :-/ 21:33:28 <nhnt11> Or just directly create it in addTabPanel 21:33:47 <nhnt11> I originally made them separate to make it convenient when I was testing 21:33:55 <nhnt11> I'm going to combine them. 21:35:38 <nhnt11> Mic, flo-retina: How about "addNewPanel" instead? 21:35:55 <nhnt11> (I'm just coming up with different names, not saying one is better than the other) 21:36:54 <flo-retina> nhnt11: I don't think tabbrowser should create the xul element 21:37:25 <nhnt11> flo-retina: That's how conversations work right now. 21:38:10 <flo-retina> and rewriting this code is a great opportunity to fix it ;) 21:38:20 <nhnt11> flo-retina: But.. but... :P 21:38:39 <nhnt11> Just kidding. That would break the window manager I think 21:39:02 <flo-retina> nhnt11: the problem is that some binding need more than just the tag name to initialize properly 21:39:21 <nhnt11> flo-retina: That's why I had two methods. 21:39:38 <flo-retina> if you mean this line http://lxr.instantbird.org/instantbird/source/instantbird/modules/imWindows.jsm#142 21:40:08 <nhnt11> That and the _pendingConversations stuff below it 21:40:13 <flo-retina> simplifying it to win.addConversation(aConv) sounds like an improvement to me; and you can have the function creating the conversation binding in instantbird.js 21:40:16 <nhnt11> It has a queue system of some sort. 21:40:49 <flo-retina> nhnt11: I don't see how that relates to the queue 21:41:05 <flo-retina> nhnt11: the queue is there to wait for a window to actually load, when we open a new one. 21:41:22 <nhnt11> Hmm. I'm reading the code right now. 21:41:58 <flo-retina> imWindows.jsm can be a bit confusing ;) 21:42:22 <nhnt11> flo-retina: I like the working code I have right now :P 21:43:11 <flo-retina> have you handled the tab titles now? :) 21:43:30 <nhnt11> flo-retina: Tab titles are handled by the tab panel 21:43:37 <nhnt11> If you mean for the about: page stuff, yes. 21:43:40 <nhnt11> :) 21:43:42 <flo-retina> cool 21:44:17 <nhnt11> It's pretty simple, it just sets the label attribute on this.tab when it shows the page. 21:47:29 --> clokep has joined #instantbird 21:47:29 * ChanServ sets mode +o clokep 21:50:40 <flo-retina> Good night 21:50:41 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com) 21:57:21 <nhnt11> Mic: http://pastebin.instantbird.com/221949 22:02:18 <nhnt11> Mic: I actually want to keep things the way they were, with two addConversations and addTabPanel+FromBindingName 22:02:35 <Mic> What about moving the creation of the element also into addConversation? 22:02:46 <instantbot> clokep@gmail.com set the Resolution field on bug 2001 to FIXED. 22:02:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=2001 blo, --, ---, nobody, RESO FIXED, SSL handshake failed (-8172) 22:02:50 <clokep> BAH. 22:02:55 <clokep> I totally just did the wrong thing... 22:03:05 <Mic> And pass it to addTabPanel as flo suggested? 22:03:17 <instantbot> clokep@gmail.com changed the Resolution on bug 2001 from FIXED to WORKSFORME. 22:04:01 <nhnt11> Mic: It would cause problems with importTabPanel 22:04:28 <nhnt11> I can't find a clean way to merge them all into two functions. 22:04:38 <nhnt11> Stuff breaks without a clean/easy fix. 22:05:08 <nhnt11> We could perhaps get rid of addTabPanelFromBindingName, but I think it could be useful. 22:05:24 <nhnt11> (As a convenience method, at least) 22:13:13 <Mic> I think I see the problem with importTabPanel... 22:13:57 <Mic> On the other hand I don't see how addTabPanelFromBindingName helps. 22:14:04 <Mic> It's just hiding it elsewhere. 22:14:18 <-- mconley has quit (Input/output error) 22:20:31 <nhnt11> k9 22:20:35 <nhnt11> typo sorry 22:21:00 <nhnt11> Mic: It's just hiding it elsewhere <- What do you mean? That the createElementNS is hiding? :P 22:21:08 <Mic> Exactly. 22:22:00 <nhnt11> Yeah right now it's mainly a convenience method 22:22:07 <nhnt11> Do you suggest we get rid of it then? 22:37:20 <Mic> No, not yet. 22:38:14 <Mic> We don't need to do that before we exactly know what to do instead. flo might have some ideas when I'll have looked at the patch. 22:38:15 <nhnt11> Okay. I think we should get the current patch through, before tinkering anymore 22:38:33 <nhnt11> Everything I've tested currently works. 22:38:39 <nhnt11> Cool. 22:39:15 <nhnt11> I should upload that new patch, I forgot. 22:39:17 <Mic> *he'll 22:39:19 <clokep> Mic: Review ping. :) 22:39:26 <Mic> clokep: ? 22:39:30 <Mic> Oh, no. 22:39:34 <clokep> bug 488 22:39:36 <Mic> The rest parameters? 22:39:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=488 nor, --, ---, nobody, NEW, Missing Commonly Used Emoticon 22:39:44 <Mic> Ah, this one too. 22:39:59 * clokep thinks it's trivial. 22:41:34 <Mic> I'll do that tomorrow, it's not going to be checked in tonight anyways. 22:41:37 <Mic> Good night. 22:41:59 <clokep> Yeah, just being annoying. :-D 22:42:07 <Mic> We still have the default parameters (not rest parameters) patch sitting around too! 22:42:44 <Mic> I'll see what happens when a method called to get a default parameter throws. 22:42:55 <clokep> Yeah. :-/ 22:43:04 <Mic> That was one of flo's concerns there. 22:43:31 <Mic> Good night now. 22:44:17 <nhnt11> Good night 22:44:36 <Mic> (It's too late already - I was wondering why you aren't at work at the moment;) 22:44:51 <clokep> :P 22:45:01 <clokep> When my _work goes away, it means everyone is supposed to leave.) 22:46:49 <Mic> I subtracted 5h from my local time and the result was ~15:00-16:00. That was supposed to show that I'm pretty tired at the moment ;) 22:56:57 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com) 22:58:07 --> wnayes has joined #instantbird 22:59:37 <-- nhnt11 has quit (Ping timeout) 23:00:08 --> nhnt11 has joined #instantbird 23:26:20 <-- qlum has quit (Quit: Getting the <censored> out.) 23:34:40 <-- dionisos has quit (Ping timeout) 23:51:12 <-- clokep has quit (Ping timeout)