#instantbird log on 06 10 2013

All times are UTC.

00:03:29 <-- rosonline has quit (Client exited)
00:11:44 <-- mconley has quit (Input/output error)
00:18:31 <-- wnayes has quit (Ping timeout)
00:21:55 --> wnayes has joined #instantbird
00:54:29 <-- gerard-majax has quit (Ping timeout)
01:09:32 <-- wuwei|offline has quit (Connection reset by peer)
01:10:12 --> wuwei|offline has joined #instantbird
01:38:23 --> clokep has joined #instantbird
01:38:24 * ChanServ sets mode +o clokep 
01:54:51 --> mconley has joined #instantbird
02:06:03 <-- mconley has quit (Input/output error)
02:18:29 <-- wnayes has quit (Ping timeout)
02:21:46 --> wnayes has joined #instantbird
02:33:23 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:51:57 --> mconley has joined #instantbird
02:54:57 <-- mconley has quit (Input/output error)
03:26:23 <-- wnayes has quit (Quit: wnayes)
03:47:49 <-- DGMurdockIII has quit (Ping timeout)
03:52:54 <-- skeledrew has quit (Connection reset by peer)
04:35:31 --> gerard-majax has joined #instantbird
05:08:28 <-- wuwei|offline has quit (Connection reset by peer)
05:09:08 --> wuwei|offline has joined #instantbird
05:12:20 <-- gerard-majax has quit (Ping timeout)
05:20:29 --> skeledrew has joined #instantbird
05:20:40 <-- EionRobb has quit (Connection reset by peer)
05:31:08 <-- Optimizer has quit (Ping timeout)
05:35:45 --> Optimizer has joined #instantbird
05:50:02 <-- wuwei|offline has quit (Connection reset by peer)
05:50:34 --> wuwei|offline has joined #instantbird
06:04:36 --> jb has joined #instantbird
06:29:00 <-- jb has quit (Ping timeout)
07:10:13 --> mpmc has joined #instantbird
07:11:45 --> qheaden_away has joined #instantbird
07:11:46 --> Mic has joined #instantbird
07:11:46 * ChanServ sets mode +h Mic 
07:13:01 --> gerard-majax has joined #instantbird
07:48:19 --> jb has joined #instantbird
07:52:17 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
08:37:24 --> nhnt11 has joined #instantbird
08:37:40 <nhnt11> Hello
08:56:34 --> nhnt13 has joined #instantbird
08:56:53 <-- nhnt13 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
09:04:07 <-- gerard-majax has quit (Ping timeout)
09:15:36 --> novabyte has joined #instantbird
09:16:56 --> aleth has joined #instantbird
09:16:57 * ChanServ sets mode +h aleth 
09:17:37 --> flo-retina has joined #instantbird
09:17:37 * ChanServ sets mode +qo flo-retina flo-retina 
09:20:54 <-- sabret00the has quit (Ping timeout)
09:24:17 <-- nhnt11 has quit (Ping timeout)
09:24:45 --> sabret00the has joined #instantbird
09:32:16 --> gerard-majax has joined #instantbird
09:42:55 --> qlum has joined #instantbird
09:46:53 --> nhnt11 has joined #instantbird
09:48:42 <-- nhnt11 has quit (Ping timeout)
09:49:26 --> nhnt11 has joined #instantbird
09:50:51 --> nhnt12 has joined #instantbird
09:51:06 <-- nhnt11 has quit (Ping timeout)
09:51:07 * nhnt12 is now known as nhnt11
09:53:22 <-- nhnt11 has quit (Input/output error)
09:53:24 --> nhnt11 has joined #instantbird
09:57:08 <-- nhnt11 has quit (Ping timeout)
10:00:01 <-- wuwei|offline has quit (Connection reset by peer)
10:00:35 --> wuwei|offline has joined #instantbird
10:01:47 --> nhnt11 has joined #instantbird
10:04:03 --> clokep has joined #instantbird
10:04:03 * ChanServ sets mode +o clokep 
10:04:17 <-- nhnt11 has quit (Input/output error)
10:04:23 --> nhnt11 has joined #instantbird
10:06:53 <-- nhnt11 has quit (Input/output error)
10:06:57 --> nhnt11 has joined #instantbird
10:08:51 <-- nhnt11 has quit (Ping timeout)
10:09:05 --> nhnt11 has joined #instantbird
10:10:52 <-- nhnt11 has quit (Ping timeout)
10:11:15 --> nhnt11 has joined #instantbird
10:13:03 <-- nhnt11 has quit (Ping timeout)
10:13:24 --> nhnt11 has joined #instantbird
10:15:07 <-- nhnt11 has quit (Ping timeout)
10:17:16 --> nhnt11 has joined #instantbird
10:36:58 <nhnt11> I just tried to update my moz sources to moz21
10:37:18 <nhnt11> I'm getting abort: crosses branches (merge branches or use --clean to discard changes)
10:37:24 <nhnt11> What is this asking me to merge?
10:37:29 <nhnt11> My awesometab branch?
10:37:29 <clokep> Mozilla
10:37:33 <clokep> No.
10:37:36 <clokep> Do what it says.
10:37:42 <clokep> python client.py checkout --skip-instantbird --clean
10:38:10 <nhnt11> --skip-instantbird seems to already be called.
10:38:10 <nhnt11> Okay
10:38:45 <nhnt11> Ah it worked. Thanks clokep
10:38:59 <clokep> --skip-instantbird makes it not pull and update the instantrbid sources., it doesn't make it call anything extra.
10:39:43 <nhnt11> That's pretty self-explanatory ;)
10:40:33 <clokep> I have no idea what you mean by "--skip-instantbird seems to already be called." then.
10:40:53 <nhnt11> I meant the flag is passed by default
10:40:53 <clokep> That makes no sense.
10:41:00 <clokep> No it isn't.
10:41:03 <clokep> It definitely is not.
10:41:11 <clokep> It wouldn't update Instantbird by default then.
10:41:37 <nhnt11> clokep: This is what it said:
10:41:37 <nhnt11> Executing command: ['/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python', 'client.py', '--skip-instantbird', 'checkout']
10:41:55 <nhnt11> I most certainly did not specify that flag myself.
10:42:25 <clokep> Then you hvae something wrong with your setup.
10:42:35 <clokep> Ah, no.
10:42:35 <nhnt11> O.o
10:42:46 <clokep> It first updates Instantbird hten calls itself and tells it to skip updating Instantbird.
10:43:10 <nhnt11> Ah okay.
10:43:46 <clokep> http://pastebin.instantbird.com/218460
10:43:49 * nhnt11 scrolled up
10:44:00 <nhnt11> clokep: Yeah I just saw that.
10:44:05 <clokep> The second from lines 2 - 10 doesn't execute if you run --skip-instantbird.
10:45:48 --> dionisos has joined #instantbird
10:47:56 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
10:50:10 <-- nhnt11 has quit (Ping timeout)
10:53:49 --> nhnt11 has joined #instantbird
10:55:36 <-- nhnt11 has quit (Ping timeout)
10:56:00 --> nhnt11 has joined #instantbird
10:57:44 <-- nhnt11 has quit (Ping timeout)
10:58:04 --> nhnt11 has joined #instantbird
10:59:55 <-- nhnt11 has quit (Ping timeout)
11:00:09 --> nhnt11 has joined #instantbird
11:02:40 <-- nhnt11 has quit (Input/output error)
11:02:43 --> nhnt11 has joined #instantbird
11:06:37 <-- nhnt11 has quit (Ping timeout)
11:09:44 --> nhnt11 has joined #instantbird
11:11:28 <-- nhnt11 has quit (Ping timeout)
11:11:48 --> nhnt11 has joined #instantbird
11:13:32 <-- nhnt11 has quit (Ping timeout)
11:13:51 --> nhnt11 has joined #instantbird
11:15:36 <-- nhnt11 has quit (Ping timeout)
11:15:55 --> nhnt11 has joined #instantbird
11:17:38 <-- nhnt11 has quit (Ping timeout)
11:17:59 --> nhnt11 has joined #instantbird
11:19:42 <-- nhnt11 has quit (Ping timeout)
11:20:08 --> nhnt11 has joined #instantbird
11:22:00 <-- nhnt11 has quit (Ping timeout)
11:22:14 --> nhnt11 has joined #instantbird
11:24:02 <-- nhnt11 has quit (Ping timeout)
11:24:17 --> nhnt11 has joined #instantbird
11:25:56 <instantbot> aleth@instantbird.org granted feedback for attachment 2477 on bug 426.
11:25:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=426 enh, --, ---, nhnt11, NEW, Make it easier to add tabs with arbitrary content to the "conversation window"
11:26:48 <-- nhnt11 has quit (Input/output error)
11:26:50 --> nhnt11 has joined #instantbird
11:28:36 <-- nhnt11 has quit (Ping timeout)
11:28:54 --> nhnt11 has joined #instantbird
11:30:36 <-- nhnt11 has quit (Ping timeout)
11:30:58 --> nhnt11 has joined #instantbird
11:31:04 <nhnt11> bbl
11:31:05 <-- nhnt11 has quit (Quit: nhnt11)
11:53:19 --> nhnt11 has joined #instantbird
11:53:36 <nhnt11> re
11:55:49 <-- nhnt11 has quit (Input/output error)
11:55:52 --> nhnt11 has joined #instantbird
11:59:43 <-- nhnt11 has quit (Ping timeout)
12:00:31 --> clokep_ has joined #instantbird
12:02:48 --> nhnt11 has joined #instantbird
12:02:57 <nhnt11> aleth, flo-retina: Can I respond to your comments here? It would be easier to have a discussion.
12:03:13 <flo-retina> fine with me
12:03:13 <clokep_> aleth: Sometimes we use mxxx to refer to private variables too. :)
12:03:32 <aleth> clokep_: yeah :(
12:03:38 <aleth> nhnt11: sure :)
12:04:41 <-- nhnt11 has quit (Ping timeout)
12:04:51 --> nhnt11 has joined #instantbird
12:06:00 <nhnt11> Brb, switching to 3G (hooray for horrible ISPs)
12:07:50 <-- nhnt11 has quit (Ping timeout)
12:08:20 --> nhnt11 has joined #instantbird
12:10:40 <nhnt11> flo-retina: aConversation.conv = null is there because the old code had "aOtherTab.linkedConversation.conv = null" in tabbrowser's importConversation method
12:11:08 <flo-retina> clokep_: I think that's almost only in tabbrowser.xml
12:11:25 <clokep_> My favorite commit message "Misc changes" :(
12:11:35 <clokep_> flo-retina: Yeah, maybe some other code we copied from Firefox.
12:11:37 <nhnt11> I moved the conversation-specific code to the conversation binding and made tabbrowser use the finishImport callback to allow any tab to do stuff when it gets imported
12:11:45 <flo-retina> clokep_: I hope these changes are to a file named utils.js :-P
12:12:03 <aleth> clokep_: I think I would prefer it if all the mxxx were changed to _xxx, but that is probably a seperate bug ;)
12:12:19 <clokep_> aleth: That was my point. :)
12:12:25 <clokep_> flo-retina: No. :(
12:12:34 <nhnt11> flo-retina: Also about the tabPanel binding. I don't like it either. When I created it I thought it would have more than empty methods. I'm trying to figure out the best way of removing it.
12:12:46 <flo-retina> nhnt11: ok, that makes sense. I'll need to look at it again to be sure that it isn't changing the order things are called in a way that could cause issues
12:13:18 <nhnt11> flo-retina: I've tried to make sure to keep the order correct whenever I've made such changes.
12:13:52 <aleth> nhnt11: I think you've gone about this the right way. Now it's just empty methods we can just comment it out and use it for documentation purposes.
12:14:19 <nhnt11> aleth: I do think flo-retina is right that it could be moved to the tabbrowser binding instead of having a new file (if it's kept)
12:14:33 <aleth> nhnt11: It should definitely be in tabbtowser.xml now
12:15:01 <nhnt11> aleth: If we comment it out I suppose that's obvious, yes :)
12:15:05 <aleth> What I meant with extra comments was that where it's not obvious, the methods should state when they are called and what they can return
12:15:28 <nhnt11> Cool.
12:15:29 <aleth> That makes it "documentation" ;)
12:15:36 <nhnt11> Right.
12:16:18 <nhnt11> http://pastebin.instantbird.com/218511
12:16:35 <nhnt11> aleth: ^ By that comment, do you mean I should add a check in the getter for selectedConversation?
12:16:45 <nhnt11> i.e. return this.mCurrentTab.linkedConversation || null
12:17:07 <aleth> Yes.
12:17:42 <aleth> Then subsequent code like "let conv = this.selectedConversation" won't cause any problems.
12:18:17 <nhnt11> Right.
12:18:20 <aleth> Btw afaik there were a number of places in the patch with similar getters/issues.
12:18:50 <aleth> I asked about the pref as I'm surprised you didn't encounter those warnings in testing. We like to get rid of them because they often do reveal underlying bugs.
12:18:53 <nhnt11> aleth: I don't understand why you made the comment about _xxx being for private variables. Those variables are meant to be private and that's why the have a _ prefix.
12:19:40 <aleth> nhnt11: I was just explaining the convention as you used (_)tabPanels and it seemed like you were unsure which it should be ;)
12:19:50 <aleth> I probably misunderstood.
12:20:02 <flo-retina> nhnt11: "I've tried to make sure to keep the order correct" that's great. Doesn't mean it shouldn't be carefully reviewed by a set of fresh eyes though ;).
12:20:10 <nhnt11> flo-retina: Of course.
12:20:11 <aleth> It would be nice to get rid of the mxxx ones though as clokep pointed out ;)
12:20:19 <nhnt11> aleth: They're gone
12:20:25 <aleth> :)
12:20:25 <nhnt11> Except mCurrentTab.
12:20:45 <flo-retina> aleth: I don't think changing mStuff -> _stuff should be a goal for this patch
12:20:46 <nhnt11> Do you want me to change mCurrentTab to something else?
12:20:51 <flo-retina> aleth: and I'm not even sure it should be done at all
12:21:02 <aleth> flo-retina: Yes, it would be a separate bug.
12:21:11 <flo-retina> if the code is the exact same as the one in Firefox's tabbrowser, it's useful to be able to find how stuff is used in Firefox. If we change the name that makes it difficult
12:21:12 <nhnt11> flo-retina: I didn't change them - I removed them ;)
12:21:27 <flo-retina> nhnt11: :) (note that I was replying to aleth)
12:21:37 <nhnt11> Right but I thought I'd mention that anyway
12:21:44 <flo-retina> :)
12:22:06 <nhnt11> I hope you agree that mCurrentConversation, etc were really a waste. They had to be set every time without being missed where they could easily be gotten from mCurrentTab.
12:22:13 <nhnt11> s/where/when
12:22:31 <aleth> Yes, that is a good change.
12:22:53 <nhnt11> Also, I haven't changed where things are marked read, etc on purpose anywhere.
12:23:03 <nhnt11> I'll change that to selectedConversation.editor.focus() :)
12:23:25 <aleth> Thanks :)
12:24:09 <nhnt11> http://pastebin.instantbird.com/218522
12:24:54 <nhnt11> aleth: That change^ was made before linkedConversation was made to reflect that the tab was a conversation-tab
12:25:10 <nhnt11> I'll change it to aOtherTab.linkedConversation, thanks for catching it.
12:25:24 <aleth> OK :) I thought it might be because linkedConversation was only set later or something.
12:25:40 <nhnt11> Nope. linkedConversation is set when the tab is created.
12:26:22 <nhnt11> Also I prefer the getPanelSpecificMenuItems() way. It used to be addPanelSpecificMenuItems(), but I decided to let tabbrowser have some control in order to maintain uniformity.
12:26:38 <nhnt11> (So that tab specific menu items are always found in the same place in the context menu)
12:26:39 * clokep_ thinks this will need to land early in a nightly period...
12:27:04 <aleth> clokep_: I think it should land soon ;)
12:27:30 <nhnt11> I agree that onSelect and handleSwitchingAwayFromTab should be forwarded. Same goes for a lot of those tabpanel methods.
12:28:12 <aleth> nhnt11: Can't we do both by passing addPanelSpecificMenuItems() a node before which to insert its items? 
12:28:50 <nhnt11> aleth: Why though? I don't understand the advantage of having the tab panel add the items instead of tabbrowser
12:29:55 <aleth> nhnt11: Because it may be easier to follow, if a panel decides to generate some of those entries dynamically
12:30:18 <aleth> But I won't insist on it.
12:30:20 <nhnt11> aleth: I still disagree. It could generate them and return them for tabbrowser to add.
12:30:57 <nhnt11> I just don't think the tab panel should be made to do work like that ;)
12:31:00 <nhnt11> It's the tabbrowser
12:31:07 <nhnt11> It's the tabbrowser's job, let it do it *
12:31:23 <aleth> Couldn't you drop the cloneNode stuff from tabbrowser then though?
12:31:47 <nhnt11> aleth: Then the nodes would need to be cloned in the tab panel before returning them
12:32:13 <nhnt11> They get destroyed when they're removed and cloning them was the workaround I found. I'm open to suggestions though.
12:32:57 <nhnt11> aleth: Otherwise, they would need to be dynamically generated in the getPanelSpecificMenuItems method
12:33:05 <nhnt11> (Is that what you're saying?)
12:33:26 <flo-retina> nhnt11: have you considered using DOM events to handle communication between tabbrowser and panels?
12:33:28 <nhnt11> I like the current approach better though.
12:33:32 <nhnt11> flo-retina: Yes.
12:33:45 <aleth> My point is it's a workaround that is specific to conversation.xml deciding to get those items from its <content>, and other panels may choose to dynamically generate the whole thing instead.
12:34:03 <flo-retina> I suspect there's an event for when a context menu is showing, and it could make sense to just let panels add custom stuff to the context menu by listening to that event
12:34:05 <nhnt11> flo-retina: I want to look at doing that after the current code is ironed out.
12:34:41 <nhnt11> aleth: Ah okay so if other panels dynamically generate them, cloning is a complete waste.
12:34:45 * nhnt11 gets it now
12:35:00 <flo-retina> (we may need to forward the event to the panel, as opening a context menu on the tab likely won't cause events to reach the panel)
12:35:07 <aleth> flo-retina: The event is onpopupshowing() and the handler for it is in tabbrowser.xml
12:35:34 <aleth> A potential issue with passing on the event is that one may not be able to control the sequence in which the handlers are called.
12:35:48 <nhnt11> ^That's a good point
12:36:12 <flo-retina> aleth: how so?
12:37:10 <nhnt11> flo-retina: Looking at these methods, most of them are called from more places than just that specific event
12:37:24 <flo-retina> :(
12:37:30 <nhnt11> onSelect for example. It's called at times other than when the tab is selected
12:37:46 <flo-retina> nhnt11: I was thinking that each of them should be considered separately ;)
12:37:55 <flo-retina> I was specifically talking about the context menu stuff
12:38:11 <nhnt11> And handleSwitchingTo/AwayFrom/Tab has some stuff with timers
12:38:18 <nhnt11> flo-retina: Yes separate events of course.
12:38:20 <flo-retina> nhnt11: isn't that because we abused it(onSelect) a few times?
12:38:37 <nhnt11> Yeah :(
12:38:48 <nhnt11> (There's a lot of abuse IMHO in this code ;) )
12:39:05 <nhnt11> (The timer stuff while switching tabs for example seems very hackish to me)
12:39:14 <flo-retina> do you have a better suggestion?
12:39:19 <nhnt11> No, just saying :)
12:39:39 <flo-retina> (hmm, does it even work right now?)
12:40:09 <nhnt11> I suppose it does but I've never actually tested it.
12:41:06 <aleth> flo-retina: Re onpopupshowing, I think one might be able to make it work with event handlers if one made the change I suggested earlier
12:41:09 <nhnt11> flo-retina: It's apparently used so that the unread ruler isn't removed when quickly flicking through tabs
12:41:30 <aleth> nhnt11: The unread ruler timer isn't a hack though, it's a UX decision
12:41:53 <aleth> It does work, though suggestions for improvement are welcome.
12:42:41 <nhnt11> How about removing the unread ruler when the user starts typing? That way we're totally sure he read the new messages
12:43:39 <aleth> I disagree. Most of the time you read and don't respond ;)
12:44:22 <clokep_> nhnt11: The current patch shouldn't change ANY behavior.
12:44:25 <clokep_> Period.
12:45:05 <clokep_> It's possible some of the behavior can be made better, but it should be done in separate bugs.
12:45:24 <clokep_> I think you should concentrate on getting the tab code complete before looking at making other changes. :)
12:45:57 <aleth> clokep_: I think that's what he's doing actually ;) Nothing wrong with storing up ideas for the future...
12:46:25 <aleth> The behaviour changes we noticed on review so far were unintentional.
12:48:02 <clokep_> I agree there's nothing wrong with ideas for future changes and I don't mean that as criticism at all, just good to focus on one thing at a time, especially when there are lots of people giving advice and it's a new codebase.
12:54:12 <-- flo-retina has quit (Input/output error)
12:55:48 <aleth> "Input/output error" :(
12:55:49 --> flo-retina has joined #instantbird
12:55:49 * ChanServ sets mode +qo flo-retina flo-retina 
13:03:42 <nhnt11> I'm back, sorry for disappearing
13:10:40 <clokep_> https://bugzilla.mozilla.org/show_bug.cgi?id=876636 will be useful for IB. :)
13:13:48 <aleth> :)
13:37:50 <nhnt11> I'm moving the tabPanel binding to tabbrowser. Do you think I should rename it to tabbrowser-panel? I'm thinking of keeping it as it is since it'll be commented-out anyway
13:39:15 <aleth> I don't think you have to literally comment it out (flo-retina may disagree), it just won't be currently used, so I'd rename it.
13:41:37 --> mconley has joined #instantbird
13:44:52 <nhnt11> aleth: Fair enough
13:45:47 --> mconley_ has joined #instantbird
13:46:01 <-- mconley has quit (Ping timeout)
13:48:48 <nhnt11> I don't think I answered the question about the tooltip icon being collapsed
13:49:10 <nhnt11> It's to clear the previous icon
13:49:34 <nhnt11> Clearing the icon and keeping it's node is possible, but leaves an awkward gap before the title of the tooltip
13:49:37 <nhnt11> So I collapsed it.
13:49:46 <nhnt11> I hope that's okay. If there's a better way, please let me know.
13:50:13 <aleth> What's the difference between collapsed and hidden again?
13:50:35 <aleth> hidden is display:none, collapsed is...?
13:51:10 <nhnt11> aleth: Not sure of the difference. I collapsed it because the buddy icon is similarly collapsed elsewhere in the tooltip code
13:51:16 <nhnt11> => Consistency
13:52:16 <aleth> Mic probably knows the difference ;)
13:54:57 <flo-retina> nhnt11: if it's similarly collapsed elsewhere, why did you have to add an anonid for it?
13:55:00 * flo-retina is confused
13:55:26 <nhnt11> flo-retina: I added an anonid to the protocol icon, not the buddy icon
13:55:41 <nhnt11> The code I changed was for the protocol icon.
14:31:25 <-- qlum has quit (Quit: Getting the <censored> out.)
14:33:35 <nhnt11> I have a "tabtest" binding that I created to test adding generic tabs. Shall I put it in debug?
14:34:42 <nhnt11> (It's basically a tab panel that has a label saying "Test" and sets the tab's title)
14:35:48 <flo-retina> I'm afraid I still don't understand why we need a specific binding for something that goes into a tab. Isn't having a title the only required info that we need from the XUL element that will be displayed in the tab?
14:37:39 <nhnt11> flo-retina: I made it a binding, but yes it just needs to be an XUL element
14:39:33 <nhnt11> flo-retina: It sets the tab title from the tab property via a setter though. That was done because the conversation binding sets the title for its tab (from a setter for its conv) and I didn't want to change too much there.
14:42:06 <-- flo-retina has quit (Ping timeout)
14:42:29 --> flo-retina has joined #instantbird
14:42:30 * ChanServ sets mode +qo flo-retina flo-retina 
14:50:23 * clokep_ wonders what time qheaden actually gets up. :P
14:50:48 <flo-retina> clokep_: later
14:51:02 <flo-retina> maybe when Atul goes to bed? :-P
14:52:11 <aleth>  /me wonders what atul is up to with filelink
14:52:20 <nhnt11> clokep_: Heh, sleep schedules
14:52:36 <nhnt11> I sleep at 4am and wake up after 12pm a lot these days
14:57:22 <clokep_> nhnt11: Yes, you seem to be on the same schedule as me and flo...and we shouldn't even be on the same schedule. ;)
14:57:44 <nhnt11> I like working at night. It's quiet :)
15:01:47 <flo-retina> that reminds me of... when I worked on Instantbird (0.1)
15:02:37 <flo-retina> I typically slept until 11am or sometimes even 1pm, didn't do much during the afternoon (mostly reading docs, pondering about things I did the previous day, ...) and did the actual coding between 10pm and 4am.
15:02:54 <nhnt11> flo-retina: That sounds nearly exactly like my schedule now
15:03:28 <nhnt11> Okay I just did $make -C objdir and I'm getting:
15:03:36 <nhnt11> STOP!  configure has changed and needs to be run in this build directory.
15:03:37 <nhnt11> Please rerun configure.
15:03:39 <nhnt11> To ignore this message, touch 'config.status' in the build directory.
15:03:39 <nhnt11> make: *** [config.status] Error 1
15:03:41 <nhnt11> Oops that was supposed to get pasted, sorry
15:03:55 <nhnt11> config.status already exists :/
15:04:02 <nhnt11> Should I just delete it?
15:04:14 <flo-retina> nhnt11: you updated mozilla recently, right?
15:04:17 <nhnt11> Yeah
15:04:22 <nhnt11> Should I do a full build?
15:04:22 <flo-retina> nhnt11: run make -f client.mk configure
15:04:35 <nhnt11> Okay
15:04:48 <flo-retina> hmm, or maybe even without the "configure", it should rebuild (I hope it would at least)
15:05:19 <nhnt11> Hmm. errors.
15:07:25 <nhnt11> http://pastebin.instantbird.com/218677
15:07:27 <clokep_> flo-retina: You don't need configure.
15:07:45 <clokep_> nhnt11: Follow what it says. ;)
15:07:45 <nhnt11> Should I do the ignore suggestion in that or just delete the objdir and start a full build?
15:07:57 * nhnt11 wants to test something and doesn't want to wait for a full build
15:08:05 <clokep_> I would delete the objdir and start a full build.
15:08:12 <nhnt11> Okay :(
15:08:16 <clokep_> You could also just rebuild the directory?
15:08:21 <clokep_> You don't need to rebuild Mozilla every time.
15:08:26 <clokep_> Just ubild tier_app or whatever.
15:08:30 <flo-retina> if you were on moz20 before updating, yes, delete the objdir
15:08:38 <nhnt11> build tier_app is failing
15:09:14 <clokep_> Then clobber build, yes.
15:09:47 <nhnt11> Hmm. tier_app is doing something else now
15:09:51 <nhnt11> Not failing
15:09:56 <nhnt11> (after that configure)
15:10:23 <nhnt11> I'm going to clobber this
15:16:01 <nhnt11> Ampersands need to be escaped in stuff like onpopuphiding?
15:16:05 <nhnt11> (http://lxr.instantbird.org/instantbird/source/instantbird/content/instantbird.xul#121)
15:17:43 <aleth> Yes, it's an XML file
15:17:47 <-- qheaden_away has left #instantbird ()
15:17:53 <aleth> (unless it's within CDATA blocks)
15:18:05 <nhnt11> Ah okay.
15:18:45 <-- aleth has quit (Quit: Ciao)
15:21:02 --> qheaden_away has joined #instantbird
15:21:09 * qheaden_away is now known as qheaden
15:21:17 <qheaden> Hi everyone!
15:21:40 <nhnt11> Hi qheaden
15:22:22 --> Nirgali has joined #instantbird
15:24:36 <qheaden> clokep_: Should I start working on the buddy list, or make improvements to the login helper?
15:26:04 <clokep_> qheaden: Can you be more specific about the improvements? :)
15:26:10 <clokep_> qheaden: There's a couple things I'd love to see this week.
15:27:35 <qheaden> clokep_: First off, what did you think about my change to the state-machine style of logging in on my last commit?
15:28:17 <clokep_> qheaden: The commit was really messy, let me look at the file. Which file is it in?
15:28:22 <clokep_> (Bonus points for a direct link. :))
15:29:01 --> iLobster has joined #instantbird
15:29:13 <nhnt11> My build failed :(
15:29:21 <qheaden> clokep_: https://bitbucket.org/qheaden/instantbird-gsoc-2013/src/b62715ed90faa3e276f7f7e0a1c8351327a4d77e/chat/protocols/yahoo/yahoo-session.jsm?at=yahoo-prpl
15:31:25 <nhnt11> http://pastebin.instantbird.com/218698
15:31:37 <clokep_> qheaden: Is it cool if I leave some comments on the file itself? (Is that possibel...?)
15:31:50 <clokep_> qheaden: Bah, it's not.
15:31:58 <clokep_> Give me a few minutes and I'll pastebin you.
15:32:41 <qheaden> clokep_: Okay.
15:35:55 <nhnt11> Any pointers on my build fail? I tried a fresh pull etc., no luck
15:36:26 <qheaden> nhnt11: I assume you purged your obj directory right?
15:36:45 <nhnt11> Yeah
15:36:52 <clokep_> nhnt11: hg purge your Mozilla directory.
15:37:15 <clokep_> (Or find mozilla -name *.pyc | xargs rm
15:37:17 <clokep_> )
15:37:29 <nhnt11> Thanks
15:39:34 <clokep_> qheaden: Do you find it nicer to separate all your function out, even if they're only used once?
15:40:07 <-- Optimizer has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
15:40:15 --> Optimizer has joined #instantbird
15:40:23 <nhnt11> I'll be back after this build (which may take a while :( )
15:40:31 <nhnt11> Bye!
15:40:35 <-- nhnt11 has left #instantbird ()
15:41:01 <clokep_> I.e. _getPagerAddress, _getChallengeString, _getLoginToken.
15:41:47 <qheaden> clokep_: Well it depends. In this case, I separated things out since it better demonstrates the login process.
15:43:39 <qheaden> clokep_: I can place most of the methods inline somewhere if that's better.
16:01:19 <qheaden> clokep_: I just got a thought. Since I moved to a state-machine like system, and since all of those methods can be placed inline in network callback functions, do you think we can just get rid of YahooLoginHelper and merge that code directly into YahooSession?
16:01:35 <clokep_> qheaden: Sorry, my boss came into my office. One second.
16:02:00 <qheaden> oh no problem. :)
16:02:06 <flo-retina> bosses are so annoying ;)
16:03:09 <clokep_> qheaden: http://pastebin.instantbird.com/218699
16:03:23 <clokep_> qheaden: I don't want you to spend all your time refactoring. :P
16:03:41 <clokep_> qheaden: Leaving it separate is OK right now, and you don't need to handle those comments now, but I'dl ike to see them eventually.
16:03:48 * clokep_ wonders where your schedule is.
16:04:51 <qheaden> clokep_: If you are talking about the schedule from the proposal, I have that handy.
16:05:48 <clokep_> qheaden: Was the buddy list next? Starting working on that would be good, buddies are poorly handled in jsProtoHelper now (IRC and Twitter don't really have them...) so that could be a good next step! :)
16:05:55 <clokep_> qheaden: I'd also like to see some tests written this week.
16:06:00 <clokep_> For the login helper, I think.
16:06:27 <qheaden> clokep_: Yeah, buddies are next, so I will work on that. And I will also start work on tests, probably tomorrow or Wednesday.
16:07:38 <qheaden> clokep_: Thanks for the review.
16:09:05 <clokep_> qheaden: No problem.
16:09:20 <clokep_> qheaden: Btw tests for some of this is uncharted territory for us, so be prepared to do some research! :)
16:09:39 <clokep_> (I'm sure it won't be a problem, everything you've done so far is great...just won't necessarily be able to give great advice.)
16:10:15 <qheaden> clokep_: Well, I have a little experience writing mochitests for Firefox. So that should help a little.
16:11:51 <clokep_> These will be xpcshell tests, but sure. :)
16:12:12 <clokep_> So buddies first, then conversations, then chats?
16:12:24 <qheaden> clokep_: Yep! :)
16:14:28 <clokep_> Then file transfer? ;)
16:14:35 <clokep_> Then oscar? :P
16:14:53 * qheaden acts like he isn't reading the IRC at this moment.
16:14:56 <qheaden> :)
16:15:01 * clokep_ is excited someone is going to actually implement buddies in JS though!
16:16:58 --> nhnt11 has joined #instantbird
16:17:48 <nhnt11> Another error!
16:17:55 <nhnt11> http://pastebin.instantbird.com/218710
16:18:07 <qheaden> clokep_: After GSoC is over, I do plan on continuing work with the plug-in to improve it.
16:18:41 <clokep_> qheaden: Excellent. :) Hopefully we can get it mostly working in GSoC though!
16:19:02 <qheaden> Yep. :)
16:19:29 <clokep_> nhnt11: That looks similar to the other one. :-/
16:19:40 * clokep_ feels like flo-retina had to update Python or something on Mac...
16:19:42 <clokep_> Maybe he has an idea.
16:20:12 <flo-retina> clokep_: that's an error about the .pyc file
16:20:13 <flo-retina> s
16:20:22 <nhnt11> Btw, I'll be back later only after WWDC :)
16:21:03 <flo-retina> I think the solution was to rm -r mozilla/xpcom in the srcdir, and run python client.py checkout --skip-instantbird --clean again
16:21:06 <nhnt11> clokep_, flo-retina: I did the hg purge, I really don't know what else to do
16:21:08 <nhnt11> Hmm
16:21:26 <nhnt11> I'll tyr that now
16:21:30 <nhnt11> s/tyr/try
16:25:48 <-- deltafalcon has quit (Connection reset by peer)
16:39:35 --> Mook_as has joined #instantbird
16:48:11 <-- gerard-majax has quit (Ping timeout)
16:48:33 <qheaden> I have to go for a little while. .
16:49:35 * qheaden is now known as qheaden_away
16:49:53 --> qlum has joined #instantbird
16:53:47 <nhnt11> Is there an always on top extension for mac?
16:54:15 <clokep_> nhnt11: I don't think so.
16:54:27 * nhnt11 will try writing one later
16:54:52 <-- novabyte has quit (Quit: bye bye)
17:04:50 --> ehoogeveen has joined #instantbird
17:33:30 <-- jb has quit (Ping timeout)
17:33:35 --> gerard-majax has joined #instantbird
17:47:09 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:59:18 * mconley_ is now known as mconley
18:22:53 * qheaden_away is now known as qheaden
18:47:07 --> atuljangra has joined #instantbird
18:47:22 <clokep_> atuljangra: ping
18:47:31 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
18:48:01 --> atuljangra has joined #instantbird
18:48:32 <atuljangra> clokep_: pong :)
18:51:06 <clokep_> atuljangra: Have you looked at anything of your project yet?
18:51:49 <atuljangra> clokep_: Yes, I was looking at libpurpl code and Mike's implementation of Filelink.
18:52:02 <clokep_> atuljangra: "Mike's implementation of Filelink"?
18:52:19 <clokep_> atuljangra: We'd like it if you could hang out on IRC a bit while doing things so we know you're making some progress.
18:52:51 <atuljangra> clokep_: Actually I met with a small accident this Tuesday, it will take 2 more days before I can dive into the project completely.
18:53:15 <clokep_> atuljangra: OK, can you keep us up to date about what's going on?
18:53:23 <atuljangra> I know, I am feeling horrible for this. Just 2 more days.
18:53:36 <clokep_> OK. I look forward you to starting.
18:53:56 <nhnt11> atuljangra: I hope you're well?
18:54:01 <atuljangra> clokep_: Thanks :)
18:54:17 <atuljangra> nhnt11: Car accident, typical Delhi traffic :(
18:54:56 <nhnt11> :(
18:55:18 * nhnt11 has actually been avoiding getting a driver's licence
18:55:24 <atuljangra> clokep_: Currently I'm reading the code under http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/
18:55:39 <atuljangra> nhnt11: I know, :(
18:57:35 * qheaden is extremely confused by Yahoo protocol buddy list data structure.
18:58:54 <atuljangra> qheaden: yes it's weird. I actually participated in a Yahoo! HackU and was trying to do stuff with this. :/
18:59:52 <-- mconley has quit (Connection reset by peer)
19:00:13 --> mconley has joined #instantbird
19:02:29 <qheaden> There isn't that much documentation past the login system either.
19:04:10 <clokep_> qheaden: Looks like you might need to look at libpurple or libyahoo's code.
19:04:32 <clokep_> atuljangra: OK. Please ask us if you have questions (seriously), or want to bounce design ideas or something.
19:05:34 <qheaden> clokep_: Yeah. Looks like I have too.
19:06:31 <atuljangra> clokep_: Yes. I will. Just give me 2 more days. It's hard to work with this much of pain. :(
19:07:01 <clokep_> atuljangra: I understand. I didn't mean now! :)
19:07:17 <clokep_> I hope you feel better soon.
19:07:32 <atuljangra> clokep_: Thanks :)
19:07:46 <atuljangra> thanks :)
19:10:56 <-- atuljangra has quit (Ping timeout)
19:12:07 --> atuljangra has joined #instantbird
19:14:14 <-- Optimizer has quit (Ping timeout)
19:14:37 <-- atuljangra has quit (Client exited)
19:17:04 --> atuljangra has joined #instantbird
19:17:31 <clokep_> qheaden: http://libyahoo2.sourceforge.net/yab.txt?
19:18:37 <qheaden> clokep_: Oh wow. I've used the docs on that site, but never saw that page.
19:18:58 <clokep_> http://jymsg9.sourceforge.net/doc.txt might be helpful too.
19:19:32 --> Optimizer has joined #instantbird
19:19:41 <qheaden> clokep_: Wow thanks!!
19:20:01 * qheaden sees he needs to create another enumeration. :P
19:29:35 <clokep_> I just thought it'd be useful.
19:29:56 <clokep_> Please include good documentation headers and such though. :) Especially if current documentation is lacking...
19:30:20 <qheaden> Yeah.
19:33:59 <clokep_> qheaden: nhnt11 atuljangra Btw, please let us know if we need to do something "better" or aren't supporting you enough, etc.
19:34:36 <nhnt11> clokep_: No problems here. You guys are very helpful :)
19:35:09 <qheaden> clokep_: Yeah, you are all very helpful! :)
19:37:05 <atuljangra> ^^Agreed  :)
19:38:17 <qheaden> clokep_: Is there a way the Socket class can split incoming data by pattern?
19:38:56 <qheaden> It looks like in one binary message, I am getting multiple Yahoo protocol messages (as is signified by the packet identifier being included three times).
19:39:02 <clokep_> qheaden: Not for binary data, no.
19:39:09 <qheaden> Okay.
19:39:15 <clokep_> qheaden: That's up to the protocol to handle.
19:39:21 <qheaden> I can just split it when I receive the data.
19:39:40 <clokep_> You're expected to get multiple messages at once.
19:40:46 <clokep_> qheaden: You can probably find just the first one and then splice and recurse.
19:41:05 <-- mconley has quit (Connection reset by peer)
19:41:23 --> mconley has joined #instantbird
19:45:19 <-- gerard-majax has quit (Ping timeout)
19:46:44 --> jb has joined #instantbird
19:47:00 <-- chrisccoulson has quit (Quit: OSError: [Errno 130] Owner died)
19:47:33 <-- nhnt11 has quit (Ping timeout)
19:48:20 --> chrisccoulson has joined #instantbird
19:49:50 <-- atuljangra has quit (Ping timeout)
19:51:14 <-- jb has quit (Ping timeout)
19:51:50 --> nhnt11 has joined #instantbird
19:52:50 --> atuljangra has joined #instantbird
19:59:17 <-- nhnt11 has quit (Ping timeout)
19:59:54 <-- atuljangra has quit (Ping timeout)
20:00:27 --> mikk_s has joined #instantbird
20:01:08 --> atuljangra has joined #instantbird
20:02:52 --> nhnt11 has joined #instantbird
20:08:40 <-- atuljangra has quit (Ping timeout)
20:08:53 <qheaden> clokep_: I have to log off now, but I will work on this throughout tonight.
20:10:49 --> atuljangra has joined #instantbird
20:12:02 <-- mikk_s has quit (Client exited)
20:13:01 <clokep_> qheaden: Goodnight.
20:13:04 --> jb has joined #instantbird
20:14:19 --> mikk_s has joined #instantbird
20:15:52 <-- jb has quit (Ping timeout)
20:16:08 * qheaden is now known as qheaden_away
20:16:14 <-- atuljangra has quit (Ping timeout)
20:33:31 <-- mpmc has quit (Connection reset by peer)
20:35:32 <-- clokep_ has quit (Quit: http://www.mibbit.com ajax IRC Client)
20:53:53 <instantbot> New Instantbird (UI) bug 1998 filed by michal.stanke@mikk.cz.
20:53:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1998 enh, --, ---, nobody, UNCO, Conversation log cannot be searched all at once
20:57:21 <-- mikk_s has left #instantbird ()
20:57:57 --> EionRobb has joined #instantbird
21:05:56 <-- iLobster has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:08:00 --> flo-retina has joined #instantbird
21:08:01 * ChanServ sets mode +qo flo-retina flo-retina 
21:10:59 <-- nhnt11 has quit (Ping timeout)
21:12:47 --> Mic has joined #instantbird
21:12:47 * ChanServ sets mode +h Mic 
21:14:35 --> nhnt11 has joined #instantbird
21:16:23 <-- nhnt11 has quit (Ping timeout)
21:16:41 --> nhnt11 has joined #instantbird
21:18:03 --> Kaishi has joined #instantbird
21:19:11 <-- nhnt11 has quit (Input/output error)
21:19:14 --> nhnt11 has joined #instantbird
21:21:04 <-- nhnt11 has quit (Ping timeout)
21:21:17 --> nhnt11 has joined #instantbird
21:23:02 <-- nhnt11 has quit (Ping timeout)
21:23:20 --> nhnt11 has joined #instantbird
21:23:46 <nhnt11> Mic: Hi there
21:25:09 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
21:25:15 --> nhnt11 has joined #instantbird
21:25:37 <nhnt11> flo-retina: Could you look at bug 1996?
21:25:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1996 tri, --, ---, nobody, NEW, Fix indentation in buddytooltip.xml
21:27:45 <-- nhnt11 has quit (Input/output error)
21:27:50 --> nhnt11 has joined #instantbird
21:28:23 --> clokep has joined #instantbird
21:28:23 * ChanServ sets mode +o clokep 
21:29:39 <-- nhnt11 has quit (Ping timeout)
21:29:54 --> nhnt11 has joined #instantbird
21:31:40 <-- nhnt11 has quit (Ping timeout)
21:31:59 --> nhnt11 has joined #instantbird
21:32:42 --> nhnt12 has joined #instantbird
21:33:46 <-- nhnt11 has quit (Ping timeout)
21:33:55 * nhnt12 is now known as nhnt11
21:49:46 <flo-retina> nhnt11: I'm not sure I see anything in the indentation of that file that needs fixing
21:50:05 <nhnt11> flo-retina: Most  of the code in the implementation is indented only one space
21:50:19 <flo-retina> are there exceptions?
21:50:23 <nhnt11> And the handlers
21:50:27 <nhnt11> No sorry.
21:50:32 <nhnt11> All the code in the implementation
21:50:32 <flo-retina> If it's consistent across the whole file, it's probably fine
21:50:37 <nhnt11> And all the code in the handlers
21:50:47 <nhnt11> Elsewhere, it's two spaces
21:51:18 <flo-retina> is this actually making the code difficult to read?
21:51:30 <nhnt11> For e.g., <method> is indented only one space, but everything in it is two spaces
21:51:36 <nhnt11> flo-retina: No but I thought we wanted consistency?
21:51:43 <flo-retina> increasing the indent means more pain to keep lines at 80 columns length
21:52:06 <nhnt11> flo-retina: There is a /lot/ of code in tabbrowser.xml and conversation.xml that exceeds 80 chars
21:52:24 <nhnt11> All the content stuff
21:52:32 <nhnt11> Maybe I not a /lot/, sorry
21:52:38 <-- Kaishi has quit (Ping timeout)
21:52:53 <flo-retina> if I wanted to start poking at broken indent in xml files, I would complain on buddy.xml's observe method that is 2 spaces indented when every other method in the same file is only 1-space indented :-D
21:53:03 <nhnt11> flo-retina: Hah okay. your call.
21:53:35 <flo-retina> nhnt11: reindenting the whole file makes finding regressions with hg blame more difficult.
21:53:54 <nhnt11> Alright. Fine by me.
21:54:13 <flo-retina> so unless it's completely inconsistent, I would prefer not to do it.
21:54:14 <-- mconley has quit (Input/output error)
21:55:16 <instantbot> clokep@gmail.com set the Resolution field on bug 1998 to DUPLICATE of bug 1584.
21:55:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1998 enh, --, ---, nobody, RESO DUPLICATE, Conversation log cannot be searched all at once
21:55:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1584 enh, --, ---, nobody, NEW, Indexed logs & efficient search
21:55:44 --> Kaishi has joined #instantbird
21:57:02 <nhnt11> Mic, flo-retina: I'm changing all the parentNode.parentNode..... in tabbrowser to getTabBrowser(), is this okay?
21:57:11 <flo-retina> no
21:57:34 <nhnt11> flo-retina: Do you not want to change it, or is there another reason?
21:57:59 <flo-retina> you can't use getElementsById for a binding, as you can't assume there will be only one instance of it
21:58:37 <nhnt11> flo-retina: The getTabBrowser() is defined in instantbird.js
21:58:38 <flo-retina> nhnt11: you may have some luck with getBindingParent (example: http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#2000)
21:58:49 <nhnt11> flo-retina: I tried getBindingParent, but I got "no such method"
21:58:52 <flo-retina> nhnt11: tabbrowser.xml shouldn't require instantbird.js
21:59:17 <nhnt11> flo-retina: It doesn't, but since it's part of instantbird.xul and instantbird.xul contains that script, tabbrowser has access to getTabBrowser() too
21:59:56 <nhnt11> Are you saying there may be a case when tabbrowser is independant of instantbird.xul, and we need to cover that?
22:00:08 <flo-retina> yes
22:00:26 <flo-retina> there may also for some reason be 2 tabbrowsers in the same window
22:01:00 <nhnt11> flo-retina: Then instantbird.xul is going to be completely botched too. As are all the other things that use getTabBrowser() right now
22:01:28 <flo-retina> instantbird.xul is specific to the conversation window
22:01:29 <nhnt11> (I've renamed getBrowser() to getTabBrowser() like Mic said)
22:01:41 <flo-retina> so it's ok for instantbird.xul to depend on stuff in instantbird.js
22:01:54 <nhnt11> Do we use tabbrowser anywhere other than the conversation window?
22:02:15 <flo-retina> did you try the getBindingParent method correctly?
22:02:17 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2478 on bug 1980.
22:02:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1980 nor, --, ---, clokep, ASSI, In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols
22:02:32 <flo-retina> it's document.getBindingParent(this), not this.getBindingParent
22:02:59 <nhnt11> Yes.. let me try again though, I was having a load of errors caused by a mistake, perhaps this was caused by that too.
22:04:05 <nhnt11> flo-retina: What about in the conversation binding?
22:04:32 <flo-retina> what about it? :)
22:04:35 * nhnt11 wonders if this will work for dynamically generated tabs
22:04:52 <nhnt11> It should work, I'll try it
22:06:39 <nhnt11> http://pastebin.instantbird.com/218976
22:06:44 <nhnt11> flo-retina: What about in that handler^
22:06:55 <nhnt11> That used to be ("getBrowser" in window)
22:06:59 <nhnt11> Is that alright?
22:08:10 <flo-retina> in which binding is that?
22:08:28 <nhnt11> tabbrowser-tab
22:09:29 <flo-retina> that's ugly, but if it was "getBrowser" before, it was already as ugly before, so I won't r- for it
22:09:41 <nhnt11> Cool
22:09:56 <flo-retina> (shouldn't there be a check that the tab is selected before updating the title bar?)
22:11:02 <nhnt11> updateTitleBar uses the current tab's label to update
22:11:20 <nhnt11> So no harm done, though it may be better to check, yes.
22:11:40 * nhnt11 seems to know tabbrowser pretty well by now ;)
22:11:47 <flo-retina> :)
22:12:11 <flo-retina> nhnt11: I didn't expect it to do any harm, but it seems wasteful, so at first I thought I misunderstood what the code was doing.
22:12:23 <nhnt11> Right.
22:13:09 <nhnt11> http://pastebin.instantbird.com/218987
22:13:15 <nhnt11> flo-retina: Have a look at that^
22:13:16 <nhnt11> :P
22:13:48 <nhnt11> I actually chuckled at that :)
22:14:11 <instantbot> florian@instantbird.org granted review for attachment 2478 on bug 1980.
22:14:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1980 nor, --, ---, clokep, ASSI, In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols
22:14:36 <flo-retina> is this existing code?
22:14:50 <nhnt11> Yep
22:15:49 <flo-retina> clokep: thanks for putting some trivial review my way; it helps me pretend I actually look at patches in my review queue in a decent time :-D
22:23:25 <clokep> flo-retina: You're welcome. :)
22:25:43 <clokep> Now you can review a tough one. :P
22:26:09 <flo-retina> or check it in ;)
22:26:18 <clokep> :)
22:26:57 <flo-retina> I think I would feel bad checking in the account manager trivial fix without at least having attempted to write an xpcshell test for it
22:27:01 <flo-retina> so I could also do that
22:34:47 <Mic> Good night!
22:36:06 <flo-retina> Mic: good night :)
22:36:29 <nhnt11> Good night Mic
22:41:16 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
22:53:09 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/b9a7cb74952e - Patrick Cloke - Bug 1980 - In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols, r=fqueze.
22:54:19 <EionRobb> I thought channel names were ascii-only?
22:54:44 <instantbot> clokep@gmail.com set the Resolution field on bug 1980 to FIXED.
22:54:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1980 nor, --, 1.5, clokep, RESO FIXED, In IRC account properties, Auto-Joined Channels doesn't support non-ASCII symbols
22:54:57 <clokep> EionRobb: It depends on the server.
22:55:20 <clokep> EionRobb: I think in the specs they are though.
22:55:24 <clokep> But some people do crazy things. :(
22:55:40 <clokep> (The bigger issue btw, is that the autojoin field, when we store it, should be Unicode, not ASCII)
22:55:51 <EionRobb> "the only restriction on a channel name is that it may not contain any spaces (' '), a control G  (^G or ASCII 7), or a comma"
22:57:26 <EionRobb> that'd be tricky if you allow utf8 to make sure that it doesn't contain \7, right?
22:58:36 --> nhnt12 has joined #instantbird
22:59:19 <-- nhnt12 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:03:29 <nhnt11> Somehow my document.getBindingParent() changes are causing a TypeError: parent.getAttribute is not a function in gre/modules/WindowDraggingUtils.jsm, whenever I mouseover the close tab button
23:03:33 <nhnt11> -_-
23:16:36 <flo-retina> nhnt11: thanks!
23:16:50 <flo-retina> I've been wondering for a while what the steps to reproduce that error could be
23:17:12 <flo-retina> it's been flooding my error console since we updated to Mozilla 21.
23:17:27 <flo-retina> (so no, it's not related to your getBindingParent changes!)
23:17:31 <nhnt11> flo-retina: This doesn't have anything to do with my bindingparent changes?
23:17:33 <nhnt11> OMgs
23:17:34 <nhnt11> OMG*
23:17:45 <nhnt11> I spent nearly 30 minutes reverting small changes trying to figure this out
23:17:57 * nhnt11 shakes his head vigorously
23:18:02 <nhnt11> Thank you flo-retina
23:18:23 <flo-retina> maybe file a bug? :)
23:18:51 <nhnt11> On it.
23:19:46 <nhnt11> flo-retina: It happens sometimes when clicking a tab too
23:19:49 <nhnt11> I'm not sure exactly when though
23:20:22 <flo-retina> well, having steps to reproduce will make it way easier to understand ;)
23:20:53 <nhnt11> flo-retina: Is this mac-only?
23:21:00 * nhnt11 pokes clokep
23:21:39 <clokep> nhnt11: I don't know what I'm trying to reproduce.
23:21:57 <nhnt11> clokep: Do you get any errors when you mouseover the close button on a tab?
23:22:04 <clokep> No
23:22:19 <nhnt11> flo-retina: Looks like Mac only then
23:22:28 <flo-retina> yeah
23:22:42 <flo-retina> if aleth could reproduce there would already be a bug on it ;)
23:23:02 <flo-retina> he tends to look frequently at his error console and file bugs for noisy things
23:23:12 <nhnt11> :)
23:25:17 <clokep> Hah.
23:25:22 <clokep> Now we just need someone to fix them ll.
23:25:38 <instantbot> New Instantbird (UI) bug 1999 filed by nhnt11@gmail.com.
23:25:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1999 nor, --, ---, nobody, NEW, TypeError on moving the mouse over the close button on a tab on OS X
23:25:46 <nhnt11> Bug 2000 is next..
23:29:07 <flo-retina> thanks
23:33:12 <nhnt11> flo-retina, clokep: What's the correct way to split this line into two lines? http://pastebin.instantbird.com/219053
23:34:04 <clokep> nhnt11: http://pastebin.instantbird.com/219054
23:34:27 <nhnt11> clokep: One indent only? Okay thanks.
23:34:30 <flo-retina> http://pastebin.instantbird.com/219055 if it's enough to be < 80 chars
23:35:46 <nhnt11> flo-retina: Not even close ;)
23:36:10 <nhnt11> So this is correct? http://pastebin.instantbird.com/219056
23:36:44 <clokep> That's gross. :(
23:36:57 <nhnt11> Haha
23:37:08 <nhnt11> clokep: How would you do it
23:37:09 <nhnt11> ?
23:37:26 <clokep> nhnt11: I mostly meant how much code is in that string, not the formatting.
23:37:26 <flo-retina> would addEventListener("command", ... work ?
23:38:05 <nhnt11> flo-retina: It should, I'll do that.
23:39:07 <nhnt11> Thanks.
23:39:49 <nhnt11> flo-retina: Would document.getBindingParent() work from an anonymous function?
23:40:50 <flo-retina> why not?
23:40:51 <flo-retina> good night
23:40:54 <nhnt11> document.getBindingParent(aEvent.target) should probably work
23:41:01 <nhnt11> Good night!
23:52:20 <nhnt11> clokep: Sorry about the repeated formatting questions, but here's another one: http://pastebin.instantbird.com/219067
23:53:28 <nhnt11> (I was thinking this: http://pastebin.instantbird.com/219068)
23:56:13 <clokep> nhnt11: Yes.
23:56:23 <nhnt11> Thanks.
23:56:30 <clokep> Unless http://pastebin.instantbird.com/219079 works.
23:57:17 <nhnt11> No, that exceeds it by at least 10 chars
23:57:36 <clokep> Oh OK