#instantbird log on 06 05 2013

All times are UTC.

00:29:58 --> Kaishi has joined #instantbird
00:34:07 <-- Mook_as has quit (Quit: Mook_as)
00:44:19 <-- wnayes has quit (Quit: wnayes)
00:46:04 <-- Nirgali has quit (Ping timeout)
00:53:27 --> clokep has joined #instantbird
00:53:27 * ChanServ sets mode +o clokep 
00:55:21 --> mconley has joined #instantbird
01:00:51 --> Nirgali has joined #instantbird
01:12:51 <-- Kaishi has quit (Ping timeout)
01:17:48 --> Kaishi has joined #instantbird
01:21:59 <-- dionisos has quit (Ping timeout)
01:28:59 <-- Kaishi has quit (Ping timeout)
01:31:58 --> Kaishi has joined #instantbird
01:50:32 <clokep> nhnt11: You should upload your addons to AIO.
01:56:25 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
02:02:40 <-- Nirgali has quit (Ping timeout)
02:08:58 --> Mook has joined #instantbird
02:10:34 --> Nirgali has joined #instantbird
03:05:56 <instant-buildbot> build #875 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/875
03:29:27 <instant-buildbot> build #867 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/867
03:40:04 <-- Nirgali has quit (Ping timeout)
04:09:29 <-- mconley has quit (Input/output error)
04:12:57 --> Nirgali has joined #instantbird
05:14:17 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 21.0/20130511120803])
05:40:59 <-- Kaishi has quit (Ping timeout)
05:45:22 --> Kaishi has joined #instantbird
05:47:51 <-- Mook has quit (Quit: Mook)
05:59:10 <instant-buildbot> build #970 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/970
06:01:28 --> jb has joined #instantbird
06:28:41 <-- jb has quit (Ping timeout)
06:54:24 <-- EionRobb has quit (Ping timeout)
06:56:20 --> FireFly_TB has joined #instantbird
06:58:52 <-- Nirgali has quit (Ping timeout)
07:07:55 --> EionRobb has joined #instantbird
07:09:54 --> EionRobb1 has joined #instantbird
07:09:55 <-- EionRobb has quit (Ping timeout)
07:18:56 --> Mic has joined #instantbird
07:18:57 * ChanServ sets mode +h Mic 
07:41:22 --> mpmc has joined #instantbird
07:43:28 <-- mpmc has quit (Client exited)
07:43:34 --> mpmc has joined #instantbird
08:09:49 --> dionisos has joined #instantbird
08:10:33 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
08:14:03 <-- Even has quit (Input/output error)
08:15:47 --> jb has joined #instantbird
08:16:52 --> Even has joined #instantbird
08:16:53 * ChanServ sets mode +o Even 
08:20:03 <instantbot> benediktp@ymail.com requested review from the wind for attachment 2277 on bug 1893.
08:20:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1893 enh, --, ---, clokep, ASSI, Use Javascript default parameters where applicable
08:31:52 --> flo-retina has joined #instantbird
08:31:52 * ChanServ sets mode +qo flo-retina flo-retina 
08:53:36 <-- gerard-majax has quit (Ping timeout)
09:16:44 --> qlum has joined #instantbird
09:16:54 <-- qlum has quit (Quit: Getting the <censored> out.)
09:16:57 --> qlum has joined #instantbird
09:18:19 <-- skeledrew has quit (Ping timeout)
09:18:20 --> skeledrew has joined #instantbird
09:26:35 <-- dionisos has quit (Ping timeout)
09:30:19 --> gerard-majax has joined #instantbird
09:31:12 --> nhnt11 has joined #instantbird
09:31:13 --> dionisos has joined #instantbird
09:33:56 <-- nhnt11 has quit (Ping timeout)
09:34:52 --> nhnt11 has joined #instantbird
09:39:21 <-- FireFly_TB has quit (Ping timeout)
09:40:30 <-- nhnt11 has quit (Ping timeout)
09:45:16 --> nhnt11 has joined #instantbird
09:47:50 <-- nhnt11 has quit (Ping timeout)
09:47:51 --> nhnt12 has joined #instantbird
10:04:05 --> clokep has joined #instantbird
10:04:05 * ChanServ sets mode +o clokep 
10:14:31 <-- wuwei has quit (Ping timeout)
10:29:47 --> aleth has joined #instantbird
10:29:47 * ChanServ sets mode +h aleth 
10:31:38 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
10:33:48 --> wuwei has joined #instantbird
10:38:18 <aleth> nhnt11: Pastebinner now breaks sending *any* messages after installing until one has filled in all the new preferences fields
10:38:43 <aleth> Ah, I see from the logs you are missing default values.
10:39:20 <aleth> See e.g. the Mathjax add-on if you want an example for how to handle that along the lines that Mic suggested
10:41:47 <-- nhnt12 has quit (Ping timeout)
10:45:25 <aleth> https://bitbucket.org/aleth/mathjax-addon/src/e7ddef33088541b2df553c7dd18bc606384595fd/bootstrap.js?at=master#cl-122
10:45:39 --> nhnt11 has joined #instantbird
10:46:06 <aleth> Heh, reading further in the logs I see you've already been pointed at lots of examples :P
10:49:34 <aleth> qheaden: "Added YahooLoginHelper._md5Hash(), which is a verbatim copy of md5() found in chat/protocols/xmpp/xmpp-authmechs.jsm." I wonder if there isn't a better way than duplicating this code (i.e. moving it to a module)
10:53:01 <clokep> aleth: I had talked to flo about that a long time ago, about having a crypto module. I think he disliked it if it had only one use case. :)
10:53:24 <aleth> clokep: And one day we may have blowfish there too ;)
10:53:48 <flo-retina> didn't wnayes have some use cases?
10:53:57 <aleth> I think it's somewhere in his megapatch
10:54:23 <flo-retina> so it's somewhere in my megareview queue? ;)
10:55:14 <clokep> I don't think wnayes used md5, just blowfish.
10:55:18 <clokep> Which he made a module.
10:56:08 <flo-retina> aleth: what's the status for the chat buddy context menu?
10:56:17 <flo-retina> is it still blocked by something in my queue? :-S
10:56:36 <aleth> flo-retina: Yes, blocked by bug 1973
10:56:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, ---, aleth, ASSI, Concatenated logs don't work for buddies and contacts
10:57:25 <flo-retina> ah, I at least did a first review pass there :-)
10:57:37 <aleth> Yes, it should not take up much more time
10:58:33 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:31:30 <-- EionRobb1 has quit (Quit: Leaving.)
11:37:04 --> mikk_s has joined #instantbird
11:45:26 --> deltafalcon has joined #instantbird
11:52:42 --> clokep_work has joined #instantbird
11:52:42 * ChanServ sets mode +o clokep_work 
11:53:34 <clokep_work> Is there anything awesome/important in https://etherpad.mozilla.org/instantbird-gsoc-2013-awesometab?
11:53:55 --> novabyte has joined #instantbird
11:54:36 <nhnt11> clokep_work: I don't think so.
11:55:13 <nhnt11> aleth: I tried some of the default prefs stuff, but for some reason, though the prefs get set (I can see them in about:config) they don't reflect in the prefs UI for the add-on.
11:55:27 <nhnt11> (I'm getting some weird errors I need to debug)
11:56:01 <aleth> nhnt11: Check you have the right pref branch set. For an example see https://bitbucket.org/aleth/mathjax-addon/src/e7ddef33088541b2df553c7dd18bc606384595fd/options.xul?at=master
11:56:07 <nhnt11> Also my internet has been failing me and I've had other things to do so I haven't been able to get much done.. Going out again now to possibly get a 3G card.
11:58:44 <nhnt11> aleth: http://pastebin.instantbird.com/214249
11:59:56 <nhnt11> aleth: I see you've not used the default branch stuff in mathjax.
12:00:13 <nhnt11> I like your way, let me try it. :)
12:00:28 <aleth> Right, it seemed unnecessary for that add-on.
12:03:01 <clokep_work> Well let me know if there are questions on that etherpad which I seem relevant too. :)
12:03:18 <nhnt11> clokep_work: Sure.
12:03:32 <nhnt11> (Though I kinda dislike etherpad for lack of notifications)
12:04:02 <aleth> nhnt11: Time for the.... etherTab :D
12:04:10 <nhnt11> aleth: :D
12:05:30 <clokep_work> nhnt11: Well once your thing is checked in, I might look at making it a prpl.
12:05:41 <nhnt11> aleth, clokep_work: flo-retina, Mic: What if I created a new BB repo that you guys could follow, where I push code that I want review? Then you could add comments there, and everybody would get notifications.
12:05:53 <nhnt11> s/review/reviewed
12:06:13 <aleth> nhnt11: I think code ready for review should generally be in a BIO bug.
12:06:26 <aleth> Multiple passes in a BIO bug are expected.
12:06:37 <clokep_work> nhnt11: Why can't you just push to your current bit bucket repo and I'll get emails? :P
12:07:02 <nhnt11> aleth: I meant more generally, for anything I want help with. It's not a very "clean" way though...
12:07:34 <aleth> nhnt11: If you're just after feedback, the repo will be fine... but I suspect pinging people works better than relying on default emails etc
12:07:36 <nhnt11> clokep_work: I want to keep my main repo "clean"... i.e. that any commit pushed there should have only working code.
12:07:47 <nhnt11> aleth: Yeah I guess.
12:08:08 <aleth> But you can link to any of your repos of course, so do it however you think best :)
12:08:37 <-- mikk_s has quit (Client exited)
12:08:39 <clokep_work> nhnt11: Branches?
12:08:50 <nhnt11> clokep_work: Good point.
12:09:12 <nhnt11> Oops :P
12:09:29 <aleth> Only ever committing working code generally leads to too few commits imho
12:09:57 <aleth> So yeah... brances
12:11:05 * flo-retina dislikes seeing non working commits after fixed code exists
12:11:38 <aleth> flo-retina: I agree with that
12:12:23 <nhnt11> aleth: Your way of doing default prefs works great. Thanks!
12:30:08 <nhnt11> Hmm. Komodo doesn't seem to save my Per Language Indentation Settings.
12:32:22 --> sabret00the has joined #instantbird
19:35:23 <instantbot> nhnt11@gmail.com requested review from benediktp@ymail.com  for attachment 2474 on bug 426.
19:35:25 --> instantbot has joined #instantbird
19:35:25 topic changed by gravel.mozilla.org to "Ask about Instantbird (http://instantbird.com) here!|Current version is Instantbird 1.4! :) |News: http://blog.instantbird.org/ |Nightlies: http://nightly.instantbird.im/ (for testing only) |IRC logs: http://log.bezut.info/ |Pastebin: http://pastebin.instantbird.org/ | Bugs: http://bugzilla.instantbird.org"
19:35:25 * ChanServ sets mode +v instantbot 
19:35:53 <nhnt11> Welcome back instantbot
19:35:54 <instantbot> hi nhnt11
19:36:48 <clokep_work> qheaden: If you want me to review something, sure. :)
19:38:23 <qheaden> clokep_work: Did you want me to email a unified diff to you?
19:39:42 --> mconley_ has joined #instantbird
19:40:35 * nhnt11 will be back after a snack
19:42:54 <clokep_work> qheaden: No.
19:43:02 <clokep_work> qheaden: If we're doing reviews it should be done on BIO.
19:43:22 <qheaden> Okay. I'll post the patch on there.
19:43:51 <clokep_work> If something isn't ready to land...might not be fully useful though.
19:44:45 <qheaden> clokep_work: I can just request feedback on it. Just so you can see everything so far.
19:45:05 <clokep_work> qheaden: OK.
19:54:02 <instantbot> qheaden@phaseshiftsoftware.com requested feedback from clokep@gmail.com for attachment 2475 on bug 1982.
19:54:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1982 nor, --, ---, qheaden, ASSI, Create Yahoo! Messenger Protocol Plug-In
19:56:03 <qheaden> clokep_work: Also, so things can be clearer, I suggest you refer to the protocol documentation on IM Freedom while you look over the patch.
19:56:29 <clokep_work> qheaden: OK, I've read some of it.
19:56:59 <qheaden> Yahoo has a really complicated authentication & login system. :-S
19:57:12 <-- Nirgali has quit (Ping timeout)
19:59:20 <clokep_work> Not compared to oscar. ;)
20:00:29 * qheaden gets a headache thinking of a protocol more complicated than Yahoo!
20:01:41 <-- nhnt11 has quit (Ping timeout)
20:01:49 <clokep_work> qheaden: I'm going to guess you're not putting enough comments though. :)
20:01:59 * clokep_work shouldn't really need to look at other documentation.
20:03:13 --> nhnt11 has joined #instantbird
20:03:45 <qheaden> clokep_work: I tried to make the code as self-documenting as possible. But I'm sure I could probably add more comments. I'll see what your feedback says. ;)
20:03:56 <nhnt11> Mic: How long will you be around?
20:04:25 --> Nirgali has joined #instantbird
20:08:43 <-- nhnt11 has quit (Ping timeout)
20:09:37 <-- jb has quit (Ping timeout)
20:12:28 --> nhnt11 has joined #instantbird
20:13:35 <flo-retina> nhnt11: I looked quickly at the patch you just attached. It's not immediately obvious to me what the purpose of the tabPanel binding is. Do you intend to write mode code in tabpanel.xml (ie this is a placeholder)? Or is this almost some kind of documentation, showing authors of new tabs what methods need to be implemented?
20:14:01 <nhnt11> flo-retina: It's kind of documentation, yes.
20:14:25 <flo-retina> in that case, a comment about the method developers need to call to add a tab sounds more appropriate
20:14:29 <Mic> nhnt11: I expect about one hour and a half.
20:14:33 <nhnt11> It also ensures that if something extends it and doesn't implement a required method, errors don't pop up everywhere :P
20:15:19 <nhnt11> (not only that but lessens code in said extensions.. I expect there to be more methods in tabPanel)
20:16:18 <flo-retina> it looks to me like all the current methods in there could be optional
20:16:41 <flo-retina> can't the calling code just null check these methods before calling them?
20:17:01 <nhnt11> flo-retina: Hmm. I thought having it this way would be "clean"
20:17:06 --> jb has joined #instantbird
20:17:13 <nhnt11> It would be a very good reference to devs as you said...
20:17:23 <flo-retina> nhnt11: to be honest, I disliked the tabpanel binding as soon as I saw "<binding id="conversation" extends="chrome://instantbird/content/tabpanel.xml#tabPanel">"
20:17:48 <flo-retina> as the conversation binding is supposed to be independent from the concept of tab.
20:18:28 <nhnt11> Hmm.
20:18:42 <nhnt11> When I initially created the tabPanel binding I expected it to have more than just empty methods
20:18:49 <nhnt11> (Which is why I created it..
20:18:51 <nhnt11> )
20:19:30 <flo-retina> .tab was even supposed to be optional there (we have some tests for if (this.tab) like on http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1666)... unfortunately lots of methods in that binding assume a tab always exists
20:20:14 <nhnt11> flo-retina: Doesn't a tab always exist?
20:20:32 <nhnt11> My understanding is that when tabbed-view is disabled, the tab strip is simply hidden
20:20:41 <flo-retina> nhnt11: alright, so if I understand you correctly, the tabpanel binding is an artifact of the thinking process. :)
20:21:01 <nhnt11> flo-retina: That's a good way to put it.
20:21:21 <nhnt11> flo-retina: How about I keep it for now, then when all changes are done, if it still seems redundant, it can be scrapped.
20:21:22 <flo-retina> nhnt11: in the current code yes. In various add-on attempts of merging the conversation window and the contacts window, tabs didn't really exist in the same form
20:22:04 <flo-retina> nhnt11: we aren't going to land things that aren't useful but may either become useful or cleaned up later.
20:22:17 <flo-retina> but maybe you meant to request feedback rather than review on the patch? :)
20:22:56 <nhnt11> flo-retina: I didn't want to end up with a mega-patch later.
20:23:16 <flo-retina> (generally, "review?" means "is this ready to land, or is that something I need to improve/change?" and feedback? means "am I going in the right direction?")
20:23:33 <clokep_work> qheaden: You need to wait till I get home, sorry.
20:23:36 <nhnt11> flo-retina: I thought it could land.
20:23:38 <clokep_work> (And hopefully I don't just crash...)
20:24:05 <qheaden> clokep_work: Oh, its no rush!
20:24:35 <nhnt11> flo-retina: The patch does what it says without breaking anything. If you'd like, I could scrap tabPanel, attach a new patch to be checked-in, and if required tabPanel could be brought back later.
20:24:46 <qheaden> clokep_work: In fact, I'm going to have to sign off now, as I have a few things I must take care of.
20:25:15 <flo-retina> nhnt11: well, maybe wait for Mic's review comments? :)
20:25:18 * nhnt11 wonders what Mic thinks about tabPanel
20:25:28 --> EionRobb has joined #instantbird
20:25:37 <nhnt11> Heh yes :)
20:27:59 <qheaden> clokep_work: I'll probably talk to you tomorrow. I might be back on here late tonight, but I'm not sure.
20:28:10 <flo-retina> I'll certainly have review comments on the API, but I'll need to think about it a bit more, so that I don't suggest something, and then the opposite an hour later :-D
20:28:31 <-- jb has quit (Ping timeout)
20:31:24 --> DGMurdockIII has joined #instantbird
20:36:56 * qheaden is now known as qheaden_away
20:39:58 <-- nhnt11 has quit (Ping timeout)
20:44:18 --> nhnt11 has joined #instantbird
20:46:52 <-- nhnt11 has quit (Ping timeout)
20:46:59 --> nhnt11 has joined #instantbird
20:49:31 --> nhnt12 has joined #instantbird
20:49:41 <-- nhnt11 has quit (Ping timeout)
20:51:29 <-- qheaden_away has quit (Quit: Leaving)
20:52:06 --> nhnt11 has joined #instantbird
20:52:19 <-- nhnt12 has quit (Ping timeout)
20:54:37 * nhnt11 wonders if it's a good idea to first check in a patch that eliminates errors when a non-conversation tab is added, and then continue work on the "proper" patch
20:56:13 <Mic> You already uploaded it over an hour ago? :S
20:56:26 <Mic> Why didn't instantbot announce that? :(
20:56:50 <nhnt11> instantbot was down I think
20:56:53 <instantbot> nhnt11: Sorry, I've no idea what 'was down I think' might be.
20:57:00 <nhnt11> But it showed it in the logs so I thought I had a connection problem
20:57:08 <nhnt11> Also I figured you'd get an email anyway :(
20:57:28 <nhnt11> Mic: http://log.bezut.info/instantbird/today#m140
20:57:59 <Mic> I got one but I only saw it now.
20:58:36 --> qheaden has joined #instantbird
21:01:04 <-- nhnt11 has quit (Ping timeout)
21:04:41 --> nhnt11 has joined #instantbird
21:07:54 --> zen_monkey has joined #instantbird
21:08:02 <-- EionRobb has quit (Ping timeout)
21:08:40 <-- qheaden has quit (Ping timeout)
21:14:31 * flo-retina would like to have https://bugzilla.mozilla.org/show_bug.cgi?id=878419 fixed for moz22 ^^
21:15:31 <-- nhnt11 has quit (Ping timeout)
21:18:07 <Mic> Accidently put the conversation on hold when I only wanted to close the findbar.
21:18:18 <Mic> I really don't like this keyboard shortcut :S
21:18:45 <Mic> (or maybe it is rather convs on hold that I don't like?;)
21:18:55 --> qheaden has joined #instantbird
21:19:01 --> nhnt11 has joined #instantbird
21:24:31 <-- nhnt11 has quit (Ping timeout)
21:28:07 --> nhnt11 has joined #instantbird
21:28:26 <-- mconley_ has quit (Input/output error)
21:28:54 --> jb has joined #instantbird
21:33:44 <-- nhnt11 has quit (Ping timeout)
21:34:00 <Mic> Good night
21:34:09 <qheaden> Night.
21:34:12 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:34:32 --> nhnt11 has joined #instantbird
21:34:35 <nhnt11> Mic: Which keyboard shortcut?
21:34:59 <nhnt11> Ah, just too late.
21:41:56 <flo-retina> nhnt11: the escape key.
21:42:16 <nhnt11> Ah
21:48:23 --> EionRobb has joined #instantbird
22:13:50 --> mconley has joined #instantbird
22:20:54 <-- jb has quit (Ping timeout)
22:23:26 <-- nhnt11 has quit (Ping timeout)
22:25:01 * qheaden is now known as qheaden_away
22:27:04 --> nhnt11 has joined #instantbird
22:39:48 <-- nhnt11 has quit (Ping timeout)
22:40:24 <-- mconley has quit (Input/output error)
22:43:23 --> nhnt11 has joined #instantbird
22:45:17 <-- nhnt11 has quit (Connection reset by peer)
22:45:27 <-- qlum has quit (Quit: Getting the <censored> out.)
22:45:56 --> nhnt11 has joined #instantbird
22:47:41 <-- nhnt11 has quit (Ping timeout)
22:48:32 --> nhnt11 has joined #instantbird
22:49:42 <-- gerard-majax has quit (Ping timeout)
22:50:13 <-- nhnt11 has quit (Ping timeout)
22:51:05 --> nhnt11 has joined #instantbird
22:54:49 <-- nhnt11 has quit (Ping timeout)
22:55:05 --> Kaishi has joined #instantbird
22:57:42 <-- zen_monkey has quit (Quit: Saliendo)
22:58:31 --> nhnt11 has joined #instantbird
22:59:47 --> clokep has joined #instantbird
22:59:48 * ChanServ sets mode +o clokep 
22:59:54 <-- Nirgali has quit (Ping timeout)
23:06:24 <clokep> Good evening.
23:06:41 --> Nirgali has joined #instantbird
23:06:51 <nhnt11> Good evening clokep :P
23:07:16 <clokep> Why :P?
23:07:35 <nhnt11> It's 4.30am here :P
23:08:18 <flo-retina> Good night :)
23:08:38 <nhnt11> Good night flo-retina ^^
23:10:58 --> mconley has joined #instantbird
23:11:18 <-- nhnt11 has quit (Ping timeout)
23:12:30 --> wnayes has joined #instantbird
23:12:36 <Morian> instantbot: ping
23:12:37 <instantbot> Morian: pong
23:16:00 --> nhnt11 has joined #instantbird
23:16:18 <-- mconley has quit (Ping timeout)
23:19:04 <nhnt11> flo-retina: If we get rid of the tabPanel binding, we have to add null checks everywhere. I thought we wanted to avoid that
23:19:29 <flo-retina> how many places is "everywhere"?
23:19:55 <nhnt11> flo-retina: A lot of places.
23:20:05 <flo-retina> for only 3 methods?
23:20:16 <nhnt11> flo-retina: No there are methods I haven't added in yet
23:20:39 <flo-retina> methods actually doing something?
23:21:04 <nhnt11> Yes.
23:21:11 <nhnt11> focus() is called from a lot of places.
23:21:25 <nhnt11> There's a way to avoid the null checks everywhere though I think
23:22:03 <nhnt11> A helper function could be called instead, which takes a tab panel and a function name, performs the null check and then calls the function if it's not null.
23:24:08 <nhnt11> Or, we could simply not do null checks at all, and let devs include functions when they see errors (I don't like this at all though)
23:27:13 <flo-retina> nhnt11: isn't focus something that exists on all xul elements by default?
23:27:33 <nhnt11> flo-retina: conversation binding overrides it
23:27:52 <flo-retina> because it wants to do a special handling of it
23:27:56 <nhnt11> To force focus to go to the editor. Also does some stuff to remove unread marker etc.
23:28:05 <clokep> But why do you need to special case focus calls then?
23:28:10 <nhnt11> Right right
23:28:15 <nhnt11> focus needn't be checked for.
23:29:17 <nhnt11> flo-retina: I need to go over this code a couple more times. I'll decide after that.
23:29:36 <nhnt11> It may take a while though
23:31:17 <flo-retina> I suspect this is still way too complicated, and we can significantly simplify it with a few review iterations
23:31:59 <flo-retina> "this" refers to this code, not your changes specifically.
23:32:26 <nhnt11> flo-retina: Yeah it's complicated. So much of this code assumes conversations that I'm afraid of breaking things if I change too much.
23:35:20 <flo-retina> well, I'm not afraid of breaking it :-P.
23:35:31 <flo-retina> so let's design something that won't be confusing for the next person looking at it :)
23:37:36 <nhnt11> flo-retina: I have to make sure I can start working on awesometab sooner than later :P
23:39:02 <flo-retina> yeah, that's also a point I wanted to make
23:39:11 <flo-retina> the new code can assume the awesometab always exists
23:39:17 <flo-retina> so the first tab is always the awesometab
23:40:11 <flo-retina> which means the code with mFirstTabIsDummy can likely be removed. :)
23:40:45 <nhnt11> flo-retina: "The first tab is always awesometab" - I assume you mean the first tab opened in a window and not the first tab currently in the list :P
23:41:19 <clokep> nhnt11: He means any new tab, I think (including if a new window is opened w/o a conversation in it).
23:41:30 <-- Nirgali has quit (Ping timeout)
23:41:32 --> Nirgali has joined #instantbird
23:41:39 <flo-retina> mFirstTabIsDummy is true only if there's no tab panel at all. ie only when opening the window.
23:43:01 <flo-retina> nhnt11: also, I don't see the meaning of "Generic" in "addGenericTab", and I don't see why it takes a string as parameter. Wouldn't you want to give as parameter a DOM element to use as a panel for the new tab?
23:43:17 <clokep> And why isn't it just calle d"addTab"? :)
23:43:30 <nhnt11> flo-retina: It's not at all a final method to be used
23:43:36 <nhnt11> I shouldn't have included it in the patch
23:43:48 <nhnt11> It's currently a clone of addConversation with some changes
23:44:07 <nhnt11> addConversation creates a conversation using createElementNS
23:44:15 <flo-retina> clokep: that's what I meant by "I don't see the meaning of "Generic" in "addGenericTab"" ;)
23:44:21 <clokep> This is a great tweet: "@devops_jesus: The idea that #git can be used offline is an illusion - you still need connectivity for googling which arguments to pass to what command."
23:44:22 <nhnt11> so addGenericTab also does that. I replaced "conversation" with a parameter is all.
23:44:29 <nhnt11> clokep: Haha
23:44:47 <flo-retina> clokep: excellent!
23:45:21 <nhnt11> In the final code, _addConversation will create a conversation and pass it to addTab. addTab will accept a DOM element as you said.
23:45:34 <flo-retina> clokep: and that reminds me that I wanted to suggest that when we start typing a command in Instantbird, the syntax/help message should be displayed in gray text in the input box until we start typing the first argument
23:45:44 <flo-retina> nhnt11: cool.
23:45:57 <flo-retina> nhnt11: so that code is really not ready for review, and you were just requesting feedback :)
23:46:00 <clokep> flo-retina: That's a cool idea. :)
23:46:31 <flo-retina> clokep: and we could also do it for completions
23:46:52 <flo-retina> as soon as we are confident we can complete a nick/word/command/whatever, we could display the likely completion in grey
23:47:19 * nhnt11 should go cancel review on that patch before it gets r-'d ;)
23:47:29 <clokep> flo-retina: I was just thinking that! :)
23:47:38 <flo-retina> nhnt11: I already r-'ed it twice on irc ;)
23:47:42 <clokep> flo-retina: We should also allow commands to register a tab completion list?
23:47:57 <flo-retina> clokep: maybe we should just make commands awesome ;)
23:48:02 <nhnt11> Heh. okay.
23:48:08 <nhnt11> flo-retina: Awesomecommands
23:48:33 * clokep sees nhnt11's GSoC 2014 application in the making...
23:48:40 <flo-retina> nhnt11: more seriously, the only important thing is that by attaching the patch you got enough feedback to know in which direction to move next.
23:48:51 <nhnt11> clokep: Hardly a gsoc project I think :P
23:48:53 <nhnt11> flo-retina: Right.
23:49:00 <flo-retina> if you haven't enough yet, keep the request
23:49:13 <nhnt11> I think more feedback could be gained.
23:49:15 <flo-retina> I don't remember seeing Mic's comments (but it's possible I just haven't read all the messages here)
23:49:35 <nhnt11> I'm a little unhappy about my progress rate though.
23:50:37 <flo-retina> I remember being very frustrated at the time I refactored all this code to adapt it for Instantbird. So I'm not surprised you aren't progressing as fast as you would like.
23:50:44 <clokep> nhnt11: What can we do to help you with that?
23:51:39 <nhnt11> clokep: I'm not sure there's anything :P
23:53:13 <flo-retina> clokep: possibly suggest API changes that will simplify things? :)
23:53:22 <flo-retina> that's the only thing I see to make it less frustrating in the long run
23:53:34 <flo-retina> (although it could be frustrating short term to have more changes to do :-P)
23:54:07 * clokep doesn't know that code AT ALL.
23:54:11 <clokep> I guess I need to start reading.
23:54:17 * clokep will review qheaden's patch first though.
23:54:31 <flo-retina> I thought you wanted to stay away from UI code :-P
23:54:43 <clokep> Yes, I hate UI code.
23:54:53 <flo-retina> as much as git? :)
23:55:02 <clokep> No. :)
23:55:06 <flo-retina> heh :)
23:55:07 <clokep> git totally screwed me over today at work.
23:55:18 <clokep> It decided git add -p didn't want to work.
23:55:45 <flo-retina> "git totally screwed me over" sounds like it was working fine :-P
23:55:51 <nhnt11> Haha
23:55:53 <nhnt11> :D
23:56:24 <nhnt11> Okay I created that offtopic channel. #instantbirders
23:56:31 * nhnt11 wonders if it will actually be used though
23:56:34 <flo-retina> clokep: I think I'm going to take the approach of *not* reading
23:56:42 <clokep> nhnt11: If that was a link, I would have clicked it...
23:56:42 <flo-retina> nhnt11: we already have #chatdev
23:56:59 <clokep> flo-retina: Not reading what?
23:57:06 <nhnt11> I thought that wasn't for off-top?
23:57:10 <flo-retina> tabbrowser.xml
23:57:23 <clokep> nhnt11: It's a random channel I registered, we can use it for off topic.
23:57:24 <flo-retina> instead of reading the existing code, I'll try to think about how things should work there.
23:57:32 <clokep> Ah, good idea.
23:57:36 <clokep> What /should/ it handle.
23:57:44 <flo-retina> clokep: nhnt11 is already taking the opposite approach of starting from (reading) the existing code.
23:57:52 <flo-retina> so hopefully at some point we will converge :)
23:58:06 * nhnt11 cries a bit
23:58:12 <nhnt11> (kidding)
23:58:41 * clokep needs to do some chores.
23:58:51 * flo-retina is really going to bed
23:59:01 <flo-retina> good evening/night/whatever
23:59:04 <flo-retina> nhnt11: good morning :-P
23:59:10 * nhnt11 drinks some coffee and gets back to tabbrowser.xml
23:59:15 <nhnt11> flo-retina: Heh. Good night :)
23:59:23 <clokep> Good night flo.
23:59:46 <clokep> Ah, good. The checkin-needed queue is empty. :)