#instantbird log on 05 30 2013

All times are UTC.

09:36:35 <instantbot> New Core - General bug 1983 filed by aleth@instantbird.org.
09:36:37 --> instantbot has joined #instantbird
09:36:37 topic changed by gravel.mozilla.org to "Ask about Instantbird (http://instantbird.com) here!|Current version is Instantbird 1.4! :) |News: http://blog.instantbird.org/ |Nightlies: http://nightly.instantbird.im/ (for testing only) |IRC logs: http://log.bezut.info/ |Pastebin: http://pastebin.instantbird.org/ | Bugs: http://bugzilla.instantbird.org"
09:36:37 * ChanServ sets mode +v instantbot 
09:36:44 <flo-retina> instantbot: good morning :)
09:36:45 <instantbot> flo-retina
09:36:48 <aleth> hi there instantbot :D
09:36:54 <-- Tonnes has quit (Input/output error)
09:37:31 --> Tonnes has joined #instantbird
09:39:35 <Mic> flo-retina: thanks, that must be the problem. Even though it shows the new tab, it is throwing errors later.
09:39:56 <aleth> Mic: what's the bug?
09:40:26 <Mic> The bug is that the tabbrowser wants every tab to have a conversation linked to it.
09:40:35 <Mic> ;)
09:40:47 <aleth> As far as I recall that assumption is implicit in lots of the code around tabs, yes...
09:42:29 <aleth> Could get really messy if you have to add an if clause every time :-/ But I hope not.
09:45:27 <Mic> Rather nhnt11 than me but yes ;)
09:47:14 <aleth> At least awesometab seems like something that can land in useful stages ;)
09:48:04 <flo-retina> aleth: I hope we can cleanup the abstraction there, instead of adding another layer of specific cases.
09:48:19 <aleth> flo-retina: Yes, that would be much better.
09:48:49 --> chrisccoulson has joined #instantbird
09:50:11 <aleth> It may be worth looking at how FX solved this problem, though their browser.xml differs quite a lot from the version tabbrowser.xml was based on
09:52:00 --> mikk_s has joined #instantbird
09:53:46 <flo-retina> aleth: we can also look at Tb's solution
09:53:56 <flo-retina> iirc Fx and Tb are very different in the way they handle tabs
09:54:05 --> EionRobb has joined #instantbird
09:54:58 <aleth> flo-retina: And maybe digging out the bug which put the add-on manager in a tab for FX (afaik that was the first non-browser tab)
09:55:26 <aleth> Sometimes looking at a changeset is helpful.
09:57:33 * aleth ran into bug 1554 yesterday
09:57:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, nobody, NEW, IRC should notify the user when messages couldn't be sent
09:58:08 <-- mikk_s has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
09:59:03 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2226 on bug 1554.
10:00:24 * flo-retina wonders if aleth loves or hates normalize* stuff
10:01:28 --> clokep has joined #instantbird
10:01:28 * ChanServ sets mode +o clokep 
10:01:56 <aleth> Heh, I never looked at normalizedNames properly before reviewing clokep's patch for bug 1454. It would be nice to get to a point where one doesn't have to think about it as much anymore ;)
10:01:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
10:02:54 <flo-retina> aleth: I can assure you I don't think about it everyday
10:02:57 <flo-retina> :-P
10:03:03 <clokep> aleth: bug 1554 is annoying, yes.
10:03:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, nobody, NEW, IRC should notify the user when messages couldn't be sent
10:03:12 <aleth> flo-retina: Recently I was frustrated because there is no way to get the normalizedName version of a name for a (buddy/conversation/...) without creating the (...)
10:03:14 <clokep> I don't suppose there were logs before instantbot rejoined? :)
10:03:23 <aleth> Maybe (hopefully) I am wrong about this?
10:03:47 <aleth> So, it's just been a recent spate of normalize* rearing its head :P
10:04:16 <flo-retina> clokep: I can pastebin
10:05:33 <flo-retina> clokep: http://pastebin.instantbird.com/209191
10:06:12 <flo-retina> uh, that would be much more readable without the system messages
10:06:45 <flo-retina> real messages are just lines 29-31 and 39 in that pastebin
10:19:51 <clokep> Mic: That should clear it as long as you return true.
10:20:01 <clokep> As flo said, throwing will cause issues. ;)
10:22:22 <flo-retina> maybe we should try catch in imCommands, and display a warning in the conversation if we caught an exception?
10:22:53 <aleth> clokep: Here's the missing lines http://pastebin.instantbird.com/209192
10:23:25 <flo-retina> ah, so you were talking just when I was offline? :-D
10:24:00 <clokep> Bah, line 2 shouldn't be copied into that IMO.
10:24:43 <aleth> flo-retina: I thought the idea behind that behaviour was that the command would display an error message that would help you fix the syntax error in what you had typed.
10:24:46 <flo-retina> aleth: feel free to ping me when I look not too busy if you are blocked by some reviews
10:25:56 <aleth> clokep: yeah... known bug ;)
10:26:22 <clokep> aleth: Is it filed?
10:26:27 <flo-retina> aleth: wouldn't it be surprising if that wasn't copied?
10:26:40 <flo-retina> It seems to suck either way :-/
10:26:52 <aleth> flo-retina, clokep: imho the fix is to not show alternatives as a system message and find a better way
10:27:01 <flo-retina> ah ok
10:27:12 <flo-retina> I thought you wanted magic copy to skip messages with the noLog flag
10:27:38 <aleth> That would be surprising, eys
10:28:13 <aleth> flo-retina: bug 1973 was the one blocking me, but it's not urgent or anything
10:28:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, ---, aleth, ASSI, Concatenated logs don't work for buddies and contacts
10:29:06 <clokep> Btw the logs from last night (before I quit and after instantbot left) are http://pastebin.instantbird.com/209203
10:29:40 <clokep> I made some progress on BIO->BMO last night! And put some of my code on bitbucket.
10:29:45 <aleth> :)
10:31:29 <clokep> aleth: Btw I wonder if the patch in 1554 still applies.
10:31:41 <aleth> clokep: idk
10:31:55 <aleth> I should check.
10:32:35 <instantbot> New Instantbird (UI) bug 1984 filed by aleth@instantbird.org.
10:32:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1984 enh, --, ---, nobody, NEW, Find a better way to display alternative completions
10:33:04 <clokep> When I first re-read 1554 I thought it was the issue of sending to offline contacts. :( That's much more exciting...
10:33:35 <aleth> That would be much more interesting :D
10:35:16 <clokep> aleth: What happens if ping is (or if aMessage.params[1] isn't a conversation name)?
10:35:39 <clokep> Isn't aMessage not even of the same type as conversationErrorMessage expects?
10:35:46 <clokep> Isn't it just a string?
10:35:51 <clokep> Not an incoming IRC message.
10:36:41 <aleth> clokep: I'm not sure I understand. These are outgoing messages
10:37:06 <clokep> aleth: Yes, conversationErrorMessage expects an incoming message as a parameter, no?
10:37:18 <clokep> I.e. I don't see how that patch can work at all.
10:37:50 <aleth> Hmm
10:38:05 <aleth> It's a long time since I did that, let me reapply and check
10:39:24 <clokep> (It's also psosible I'm not awake yet, FWIW.)
10:40:20 <clokep> Also, I still think a dropdown (a la a  code editor) would be nice for auto-complete. :P
10:40:32 <aleth> Something like that...
10:42:40 <-- dionisos has quit (Ping timeout)
10:43:03 <aleth> clokep: You're absolutely right about aMessage. I also see from the comments in the bug the patch was never tested, so...
10:44:09 <instantbot> clokep@gmail.com denied review for attachment 2226 on bug 1554.
10:44:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, nobody, NEW, IRC should notify the user when messages couldn't be sent
10:44:36 <clokep> aleth: It's possible you can be sneaky and make a fake object to pass it.
10:45:00 <clokep> You'd probably also want to check the message type being sent...
10:45:29 <-- EionRobb has quit (Quit: Leaving.)
10:45:31 <aleth> Yeah...
10:51:14 <clokep> (I.e. if a ping throws, we don't want to display that message.)
10:54:21 <-- clokep has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
11:00:08 --> nhnt11 has joined #instantbird
11:05:12 <nhnt11> Mic: here's my tabbrowser.xml: http://pastebin.instantbird.com/209225
11:06:54 <nhnt11> My tabtest.css:
11:06:55 <nhnt11> | tabtest { -moz-binding: url("chrome://instantbird/content/tabtest.xml#tabtest"); } |
11:07:41 <nhnt11> tabtest.xml: http://pastebin.instantbird.com/209227
11:08:00 * nhnt11 will be back soon
11:08:07 <aleth> nhnt11: I think you need a bitbucket ;)
11:08:34 <nhnt11> aleth: I created one yesterday, I should start using it :P
11:08:47 <aleth> You can then just link to the changeset ;)
11:09:34 <aleth> Your blog looks great btw :D
11:09:57 <aleth> Though the links to the pastebins will die well before the end of gsoc...
11:10:33 <aleth> Not that it necessarily matters.
11:10:55 <Mic> aleth: I usually post my pastebins to expire never. Not sure if that's a big problem for the server. It's only a few kB each...
11:11:13 <aleth> His are set to expire though.
11:11:36 <aleth> (I think)
11:12:10 <Mic> The only way to find out is to wait, isn't it? ;)
11:13:23 <aleth> I didn't notice at first the radiobox at the bottom applied to new pastes...
11:16:25 <nhnt11> aleth: No, I repasted all of them to last forever
11:16:48 * nhnt11 thinks ahead ^^
11:17:07 <aleth> some pastes are forever :)
11:18:52 <nhnt11> Is there a greasemonkey script or something lying around that increases font size on pastebin? :S
11:19:26 <aleth> Use Ctrl-+ in FX? ;)
11:19:38 <aleth> I'd be more interested in one that hides the left hand column :P
11:19:50 <nhnt11> aleth: Yeah that would be nice too :P
11:20:03 <Mic> nhnt11, aleth: create some userContent.css rules for these problems.
11:20:04 <nhnt11> Ctrl-+ breaks some layout stuff usually
11:20:20 <nhnt11> (read: the column looks ugly)
11:20:31 <nhnt11> Mic: Yeah should do that.
11:20:45 <Mic> brb
11:20:49 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
11:21:12 --> Mic has joined #instantbird
11:21:13 * ChanServ sets mode +h Mic 
11:22:36 <nhnt11> It looks so much cleaner without the menu :)
11:23:10 <aleth> Maybe it should be removed server-side then?
11:23:45 <aleth> nhnt11: Do you read the logs for when you are not online? Just asking for future reference
11:23:55 <nhnt11> aleth: I do.
11:26:00 <Mic> hmm, the code you pasted looks like it should work :(
11:26:21 <nhnt11> Mic: This makes me think it's some Mac-related error :/
11:26:27 <nhnt11> s/error/bug
11:27:08 <Mic> Getting a new tab for every click on the contact list was annoying by the way ;)
11:27:51 <nhnt11> Mic: Heh, I was going to think of a better way to do that but since the trigger-code was already there I decided to be lazy :P
11:27:52 <Mic> Here's add-on code that will open a new tab when you enter the command "/newtab" in conversations: http://pastebin.instantbird.com/209231
11:31:26 <nhnt11> Mic: Thanks! That is remarkably simpler than I expected it to be.
11:33:05 --> dionisos has joined #instantbird
11:33:08 <Mic> You should thank the one who wrote the command handling code then:) Most likely flo (or clokep?)
11:33:46 <nhnt11> :)
11:34:01 <aleth> hg annotate should tell you ;)
11:41:29 --> jb has joined #instantbird
11:42:16 <Mic> nhnt11: http://pastebin.instantbird.com/209240 here's a diff of what is working for me.
11:42:27 --> clokep_work has joined #instantbird
11:42:27 * ChanServ sets mode +o clokep_work 
11:42:37 <-- nhnt11 has quit (Ping timeout)
11:43:18 <clokep_work> I didn't write the command handling code.
11:43:30 <clokep_work> I /did/ write the code that will let you run that with just /ne though. ;)
11:47:46 <clokep_work> FYI This is my BIO->BMO script https://bitbucket.org/clokep/bio-bmo-merge/src/tip/bugzilla-merge.js
11:48:24 <Mic> "Acces denied."
11:49:02 * wuwei`lab is now known as wuwei
11:49:55 --> nhnt11 has joined #instantbird
11:51:03 <clokep_work> Mic: Yeah, that happens when I set things to private. :)
11:51:39 <clokep_work> Mic: reload
11:51:41 <nhnt11> Mic: The extensions UI is working with that?
11:51:56 <Mic> ?
11:52:27 <nhnt11> Mic: In your tabtest.xml you've added a browser with src extensions.xul
11:52:48 <Mic> Yes, that works too :)
11:53:10 <Mic> I couldn't help experimenting yesterday evening after I got your first tab loaded ;)
11:53:17 <nhnt11> Mic: I can haz screenshot? :P
11:53:34 <Mic> Sure
11:53:35 <Mic> http://i.imgur.com/e3CNFH3.png
11:53:50 <nhnt11> Mic: Brilliant :)
11:53:54 * aleth wonders if the add-on & account manager should be a tab (whenever a conv window exists)
11:54:04 <aleth> ha! :D
11:54:15 <Mic> "Tab-ify all the things!"
11:54:17 <aleth> That was quick ;)
11:54:53 <clokep_work> aleth: Certainly if you have a big unified single window.
11:55:05 <aleth> Mic: You can have localized add-on names?
11:55:14 <Mic> You see I have an incredible number of add-ons.
11:55:24 <Mic> Yes.
11:56:04 <Mic> You best check out "Always on Tops" install.rdf if you're interested.
11:56:36 <aleth> I've never looked at add-on l10n, but I may "have" to soon-ish
11:56:42 <aleth> MathJax itself is now localized...
11:58:08 <nhnt11> flo-retina: Can you please try the non-conversation tab stuff when you have some time? I want to see if this is Mac only.
11:59:22 <Mic> brb
11:59:24 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
12:01:09 <nhnt11> clokep_work: What was that command to build only Instantbird? make -C objdir tier_app, correct?
12:01:17 <clokep_work> nhnt11: Yes.
12:02:58 <clokep_work> Mic: Ping me.
12:05:07 * nhnt11 will be back later
12:05:08 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
12:09:25 --> Mic has joined #instantbird
12:09:25 * ChanServ sets mode +h Mic 
12:10:09 <Mic> nhnt11: I applied your changes from pastebin/the logs and it works for me.
12:11:09 <clokep_work> Mic: Have a second to discuss bug 1681?
12:11:10 <Mic> Have you added the new files to be packaged by the way?
12:11:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1681 min, --, ---, clokep, ASSI, Split experiments repository into two clean repositories
12:11:22 <clokep_work> I was thinking of just pushing them to bitbucket and then transferring the Sync one to you.
12:11:37 <clokep_work> I know it's not really useful to have that code anymore, but I think we should push it somewhere since I already have the script that cleans it up.
12:11:52 <Mic> OK, fine with me.
12:12:12 <Mic> Thanks for taking care of this.
12:15:26 * clokep_work is tired of that bug being open.
12:16:49 <flo-retina> Do we know if nhnt11 added his tabtest.xml and tabtest.css files to the jar.mn file?
12:17:04 <flo-retina> otherwise it's not surprising that the code in them has no effect
12:17:07 <Mic> flo-retina: that's why I asked about packaging :)
12:18:37 <-- Optimizer has quit (Ping timeout)
12:18:41 <aleth> clokep_work: I'm curious, how will you run that bio-bmo code?
12:19:01 <Mic> node.js ;)
12:19:14 <clokep_work> aleth: node.js.
12:19:21 <aleth> ah! :)
12:19:34 <clokep_work> aleth: It uses two node modules, async and bz.
12:19:39 <clokep_work> Clearly you don't follow my Twitter. ;)
12:19:59 <clokep_work> Mic: You just need to accept it.
12:20:01 * flo-retina hasn't looked at twitter since we updated to moz17
12:20:07 <aleth> No... I was wondering where you were pulling those modules from ;)
12:21:25 <Mic> clokep_work: done
12:21:42 <clokep_work> aleth: npm :)
12:21:56 <clokep_work> Mic: Congrats, you now have a repo https://bitbucket.org/BenediktP/profile/repositories
12:22:05 <Mic> \o/
12:23:51 <instantbot> clokep@gmail.com set the Resolution field on bug 1681 to FIXED.
12:23:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1681 min, --, ---, clokep, RESO FIXED, Split experiments repository into two clean repositories
12:24:29 --> Optimizer has joined #instantbird
12:28:42 <flo-retina> clokep_work: should we just remove that experiments repo if nobody intends to use it any more?
12:29:17 <clokep_work> flo-retina: There's a lot of links to it. :-/
12:29:28 <flo-retina> ok
12:29:31 <clokep_work> (I.e. in blog posts.)
12:29:41 <flo-retina> I won't touch it
12:29:54 --> nhnt11 has joined #instantbird
12:30:04 <clokep_work> But I don't particularly care either way. I don't htink it really hurts to have it there.
12:34:05 <Mic> nhnt11: have you seen the question about packaging the files?
12:34:41 <nhnt11> Mic: Reading the logs now.
12:35:26 <clokep_work> flo-retina: Also, I don't know what is next for bug 1956. :-/ "Get it building on Mac"? Idk how far we are from that.
12:35:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1956 nor, --, ---, clokep, ASSI, Update to Mozilla 21
12:35:52 <flo-retina> clokep_work: after thinking about it a bit, I've more or less decided that the next step is to build Tb21
12:36:13 <flo-retina> and if that's successful "out of the box", then compare the command lines used for the files that fail when building Ib
12:36:31 <nhnt11> Mic: Did I need to add stuff to a makefile?
12:36:32 <flo-retina> I'm surprised that I've already had to apply 2 patches that are from moz23
12:36:43 <flo-retina> nhnt11: to instantbird/content/jar.mn
12:36:47 <Mic> To the file jar.mn in the instantbird/content folder.
12:36:56 <nhnt11> I didn't know that.
12:37:04 <nhnt11> :S
12:37:17 <clokep_work> nhnt11: That's why we're helping you! :)
12:37:47 * nhnt11 thought files would be added using a * (like content/instantbird/*)
12:37:52 <-- Optimizer has quit (Ping timeout)
12:38:03 <nhnt11> clokep_work: Heh, right :)
12:38:57 <nhnt11> What does the asterisk at the beginning of some lines in jar.mn signify?
12:39:04 <nhnt11> It seems to be only for xul files?
12:39:14 <nhnt11> Never mind, it's not
12:39:32 <flo-retina> nhnt11: no, for each file we need to specify if it needs to be preprocessed or not.
12:39:32 <aleth> It's for files that need preprocessing afaik
12:40:09 * nhnt11 is not sure when exactly preprocessing is required.
12:40:26 <aleth> When you use #ifdefs for example
12:40:33 <flo-retina> nhnt11: if your files contains #ifdef XP_MACOSX lines ;)
12:40:49 <nhnt11> Oh preprocessing. I get it :P
12:41:06 * flo-retina wonders if nhnt11 needs preprocessing
12:41:12 <nhnt11> flo-retina: I don't.
12:41:12 <flo-retina> :-P
12:41:27 * nhnt11 is suddenly unsure what exactly flo-retina meant by that
12:42:16 <flo-retina> not much :)
12:42:46 <nhnt11> okay :P
12:43:43 <nhnt11> Yay. http://grab.by/n2JA
12:44:57 <aleth> nhnt11: nit: could you just link directly to the image please?
12:45:00 <flo-retina> :)
12:45:27 <nhnt11> aleth: My screenshot program automatically does that -_-
12:45:37 * nhnt11 used to have a different better one but his uni blocked it.
12:46:36 * aleth dislikes image sharing sites that make it difficult to get direct links to images
12:47:20 <flo-retina> this one isn't too annoying though :)
12:47:39 <aleth> flo-retina: Try the context menu on the image...
12:47:59 <-- jb has quit (Ping timeout)
12:48:20 <flo-retina> aleth: http://new.tinygrab.com/8d8890fb03dd6a6e8a4cfbe64860206ff656559b16.png
12:49:02 <flo-retina> (I admit it took a few more clicks than I would like)
12:49:02 <Mic> nhnt11: great! :)
12:49:08 <aleth> flo-retina: Good job you wrote Page Info ;)
12:49:16 <flo-retina> heh ;)
12:49:34 <flo-retina> the Media tab there was in part designed to work around that kind of annoyance ;)
12:49:46 <flo-retina> IMHO it doesn't do a perfect job of it though
12:50:05 <flo-retina> but sorting images by size usually gives you the interesting image first
12:50:57 * nhnt11 hopes aleth likes this better: http://puu.sh/34oSQ.png
12:52:18 <aleth> nhnt11: Heh, thanks :D (Btw, I mentioned it also because it is useful when looking at the logs to see from the extension if a link goes to a screenshot etc...)
12:56:00 * clokep_work stil wishes we could inline those... ;)
12:57:57 * qheaden_away is now known as qheaden
12:58:03 <qheaden> Hello everyone.
12:58:38 <nhnt11> hello qheaden
13:00:03 --> Optimizer has joined #instantbird
13:00:26 <Mic> nhnt11: you've seen that flo suggested to see how Thunderbird handles its tabs?
13:00:34 <nhnt11> Mic: Yes.
13:00:39 <Mic> Good.
13:02:52 <clokep_work> Good morning qheaden.
13:03:23 <qheaden> clokep_work: Good morning! Did you get a chance to peek at yesterday's daily log?
13:04:31 <-- dionisos has quit (Ping timeout)
13:04:36 <clokep_work> qheaden: Yes. I don't remember them though. :P
13:04:54 <qheaden> :P
13:06:01 <qheaden> clokep_work: I was thinking, would it be better to change YahooSocket to YahooSession? The name would seem more appropriate.
13:06:16 <clokep_work> qheaden: Why is it more appropriate?
13:06:27 <clokep_work> (Full disclosure, I greatly dislike the name "YahooSession".)
13:07:33 <qheaden> clokep_work: Well, I'm thinking about letting the YahooSocket class handle all of the background communication instead of just handing incoming messages to any registered listeners.
13:09:16 <qheaden> For example, instead of the Account object handling the connection logic, it can just call connect() on the YahooSocket instance with the necessary credentials and wait for the "connected" signal.
13:09:25 <flo-retina> selenium tells me "7 of 6 tests failed"
13:09:51 <clokep_work> qheaden: OK, so you're going to need a "YahooSocket" object no matter what, it's going to need to know how to decode the messages, etc.
13:09:53 * nhnt11 is wasting time trying to get the buddy list to load in a tab ^^
13:10:11 <clokep_work> You might want a YahooSession which contains 1 or more YahooSockets + http connections.
13:10:44 <clokep_work> That might be over abstracting though (i.e. if only one thing ever calls YahooSession, why does it exist?)
13:11:02 <aleth> nhnt11: That won't be completely trivial as the blist code assumes it lives in its own window.
13:11:05 <clokep_work> qheaden: It might help to draw things out in a flow chart and see what calls what, etc.
13:11:15 <nhnt11> aleth: I realized :P
13:11:31 <aleth> qheaden: Also consider what happens if there is an error at some stage
13:12:21 <qheaden> Right.
13:12:52 <clokep_work> If there's an error it has to bubble back to the account.
13:12:54 <qheaden> My goal is to have the YahooSocket handle as much background logic as possible, and pass any listeners to final result.
13:13:09 <qheaden> And if course bubble back upon error.
13:13:13 <qheaden> *of course
13:13:25 <clokep_work> qheaden: I guess my point is that you HAVE to (by design) inherit from Socket and make your own, so no matter what you'll have a YahooSocket.
13:13:39 <flo-retina> anybody understands what's going on with show nick here? http://i2.minus.com/iQNQyzwLpMw1F.png
13:13:42 <clokep_work> I think it'd make more sense if that did not include the logic for "connect", etc. but was fairly "low level".
13:14:02 <flo-retina> NiKo` usually fails to be highlighted because of the `, but it was highlighted once here :-S.
13:14:17 <clokep_work> (o_O)
13:14:25 <clokep_work> Is that because of the s at the end?
13:14:31 <flo-retina> possibly
13:14:46 <flo-retina> I guess the s starts a new word, so it matches the "word boundary" thing
13:14:50 <flo-retina> still sucks
13:14:51 <qheaden> clokep_work: That makes sense.
13:14:54 <flo-retina> I would really like to get that bug fixed
13:14:58 <aleth> flo-retina: That sounsd plausible
13:15:11 <flo-retina> it annoys me all day long
13:15:25 <flo-retina> (and I don't want to ask NiKo to change his nick because my IRC can't handle it :-])
13:15:35 <flo-retina> (that seems like the wrong "fix")
13:16:52 * aleth wonders if it is feasible to do both ;)
13:17:01 <-- Optimizer has quit (Ping timeout)
13:17:07 <flo-retina> aleth: both would be?
13:17:24 <aleth> Fix the bug and get Niko to drop the ` ;)
13:17:43 <flo-retina> well, the ` is only a problem because of that bug
13:17:44 <aleth> But of course his nick is up to him.
13:17:59 <flo-retina> what could we use instead of http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1387 ?
13:18:03 <aleth> If we didn't have tab complete, it might be annoying...
13:18:27 <flo-retina> yeah, and someone will use hasOwnProperty` as his nick just to annoy me ;)
13:18:40 <aleth> (I just thought "NiKo`'s " looked wrong somehow)
13:18:44 <flo-retina> btw, do we know if ChatZilla has fixed its issues with "special" nicks? :)
13:19:01 * nhnt11 is now known as hasOwnProperty`
13:19:06 <hasOwnProperty`> flo-retina: :P
13:19:06 <flo-retina> aleth: flo-retina seems very annoying for people who haven't discovered tab complete ;)
13:19:12 <-- flo-retina has kicked hasOwnProperty` from #instantbird
13:19:16 --> mpmc has joined #instantbird
13:19:23 --> nhnt11 has joined #instantbird
13:20:13 <qheaden> Can I use xpcshell with Instantbird?
13:20:31 <clokep_work> flo-retina: I don't know, they booted me out of the bug when they made it security.
13:20:39 <flo-retina> qheaden: yes :)
13:20:48 <clokep_work> flo-retina: We could possible match \s?
13:20:49 <flo-retina> clokep_work: bug number? :)
13:21:05 <clokep_work> flo-retina: \s(niko`|clokep)[\s$]
13:21:10 <flo-retina> were you the bug reporter?
13:21:31 <clokep_work> flo-retina: It's not in my awesomebar. :( No, you were.
13:21:34 <clokep_work> I think...
13:21:47 <flo-retina> I haven't filed any chatzilla bug :-P
13:21:53 <flo-retina> and I don't frequent that channel
13:22:24 * nhnt11 should've done [.$] on that ctcp bug instead of (.|$)
13:22:29 <flo-retina> clokep_work: \s is "a single white space character"
13:22:54 <flo-retina> nhnt11: isn't $ just the dollar character when used inside []?
13:23:11 <nhnt11> flo-retina: Maybe, i'm confused :P forget it..
13:23:29 * nhnt11 doesn't want to think about regex right now
13:23:45 <flo-retina> clokep_work: maybe \W ? ("any character that is not a word character from the basic Latin alphabet")
13:23:49 <clokep_work> flo-retina: We should make tests. :)
13:23:59 <clokep_work> Does \W include `?
13:24:09 <flo-retina> yes
13:24:15 <flo-retina> I think so at least
13:24:20 <flo-retina> but why is it important?
13:24:45 <clokep_work> flo-retina: (^|\W)(niko`|clokep)(\W|$) seems to work well...
13:24:49 <flo-retina> bah, that would suck for messages in non-latin alphabets :(
13:24:55 <flo-retina> we would match nicks inside words :(
13:25:17 * clokep_work wonders if we sholdn't be trying to use a regexp here. :-/
13:25:26 <clokep_work> (Or should be post processing after we use one.)
13:27:21 <flo-retina> clokep_work: so you mean we could match more aggressively, and filter out some results?
13:27:23 <aleth> clokep_work: You mean looking for substrings and then checking for word boundaries ourselves would be more efficient
13:27:31 <clokep_work> flo-retina: Yes.
13:27:41 <flo-retina> I have no idea of how that would work
13:27:42 <clokep_work> aleth: I didn't say more efficient, I said better. :)
13:27:47 <flo-retina> (ie I have no idea of what I would write in the filter)
13:27:55 * clokep_work shrugs.
13:27:56 <clokep_work> Just an idea.
13:28:56 --> mconley has joined #instantbird
13:30:52 <flo-retina> I think I would still take a patch for the (^|\W)( ... )(\W|$) 'solution'. (even though that may screw up a few cases for Russian people)
13:31:49 <aleth> flo-retina: Why not use [\s.,!] etc (i.e. check for punctuation characters explicitly)?
13:32:14 <-- Kaishi has quit (Quit: Kaishi)
13:32:23 <flo-retina> "etc" is difficult to match in that regexp :-P
13:32:36 * clokep_work is now known as clokep[]__
13:32:45 <clokep[]__> aleth: Match me, using that technique.
13:32:49 <flo-retina> but if you feel like building a full list of possible punctuation characters (including their unicode variants that I suspect some people may like to use on twitter), go for it :)
13:33:04 <flo-retina> clokep[]__: what's the problem?
13:33:21 <clokep[]__> Do we not throw errors when changing our nick fails? :-S
13:33:26 <flo-retina> clokep[]__: we only need to care about the characters that are before/after, not inside
13:34:00 * clokep[]__ is now known as clokep[]
13:34:03 <clokep[]> :P
13:35:54 <aleth> flo-retina: I was hoping one would already exist. Then we could generously search for nicks first and check for word boundaries ourselves on the matches. (If I understand correctly, Niko` is not matched because the regex takes ` as part of the word boundary)
13:36:05 <instantbot> New Core - IRC bug 1985 filed by clokep@gmail.com.
13:36:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1985 min, --, ---, nobody, NEW, Notify user if trying to use illegal characters in nick
13:36:53 <flo-retina> aleth: to have a word boundary, you need to have a "letter" on one side of the boundary. ` isn't a letter, so there's a word boundary only if the first character after the nick is a letter.
13:37:51 <flo-retina> clokep[]: what were the illegal characters in your nick?
13:37:59 <clokep[]> flo-retina: . is illegal, apparently.
13:38:15 * clokep[] is now known as clokep_work
13:39:04 --> dionisos has joined #instantbird
13:39:15 <qheaden> clokep_work: For YahooSocket, would it be okay to have one addListener/removeListener method set and simply call the event methods that the listener implements?
13:39:21 <aleth> flo-retina: Right, so if we just matched nicks irrespective of where they are and then checked that they are surrounded by word boundaries ourselves in a second step, there would be no problem
13:39:33 <flo-retina> btw, this was bug 1757
13:39:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, nobody, NEW, Some nicks aren't detected by Show Nick
13:40:03 <flo-retina> aleth: so should NiKo`s be matched? :-)
13:40:12 <aleth> No.
13:40:35 <flo-retina> why? From a developer perspective that would make sense, but from a user perspective, it wouldn't
13:40:40 <aleth> Niko`'s should be matched
13:40:57 <clokep_work> qheaden: I'm not sure what tha tmeans.
13:41:04 <clokep_work> (Also I have a meeting at 10)
13:42:22 <qheaden> clokep_work: Basically, I have one addListener method. Whenever a Socket event fires, it calls the same method on the listeners. But instead of storing listeners for each kind of event, just check if they have that event method defined, if not, don't call it. Is that clearer?
13:44:32 <clokep_work> qheaden: Not really.
13:44:48 <clokep_work> "if they have that event method defined"? What?
13:44:57 <clokep_work> Wouldn't it need to store the listeners anyway.
13:45:16 <qheaden> Maybe this will help: http://pastebin.mozilla.org/2461950
13:46:40 --> jb has joined #instantbird
13:48:40 <clokep_work> qheaden: Wouldn't it make more sense to add them with an event name and then keep them in a map of some sort?
13:48:46 <clokep_work> Instead of iterating over the array constantly.
13:49:52 <qheaden> clokep_work: You mean like the normal JavaScript addEventListener style?
13:50:23 <clokep_work> Possibly. I'm curious why you didn't do that to start with.
13:50:44 * clokep_work will be back soon.
13:51:00 <qheaden> Okay.
13:51:43 --> novabyte has joined #instantbird
13:52:53 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2464 on bug 1554.
13:52:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1554 nor, --, ---, aleth, ASSI, IRC should notify the user when messages couldn't be sent
13:57:12 <-- novabyte has quit (Ping timeout)
14:09:25 <nhnt11> Mic: I wonder if it's a good idea to simply add a check for linkedConversation at all places where conv is used.
14:10:24 <nhnt11> (I've been looking at thunderbird's tabbrowser and am not sure if it would be an easy task to clone it)
14:10:36 <nhnt11> s/clone/use
14:12:06 <nhnt11> This is going to take a lot of work either way...
14:12:34 <aleth> nhnt11: You could consider moving some of that code to the tabs (i.e. give tabs in general new methods)
14:12:34 <flo-retina> I didn't suggest cloning Tb's implementation
14:12:44 <flo-retina> I think thought it could be a source of inspiration
14:13:18 <nhnt11> flo-retina: I didn't mean a direct clone, I meant copy the way it's done there..
14:13:24 <nhnt11> aleth: hmm
14:14:27 <aleth> I don't know if it's the best way to go, but adding some abstraction might help make things more readable than lots of if clauses
14:16:21 <nhnt11> I think it's a good idea to move some of the code to the conversation code.
14:16:36 <nhnt11> (Basically what you said, nvm)
14:17:11 <aleth> What do you mean by "conversation code"? The conversation binding is what is inside a conversation tab, but that's distinct from the tab itself
14:17:19 <flo-retina> aleth: bug 1760 and bug 1313 look very similar ;)
14:17:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1760 nor, --, ---, nobody, NEW, Show Nick should not match nicks in URLs etc
14:17:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1313 min, --, ---, nobody, NEW, Show Nick: don't match nicknames contained in links and join-messages
14:17:27 --> novabyte has joined #instantbird
14:17:49 <aleth> flo-retina: Looks like it gets filed periodically :D
14:18:47 <flo-retina> aleth: looks like you file it every eight months. Next time should be in July, get ready for it! :-P
14:19:13 <aleth> I could automate it :P
14:19:18 <flo-retina> sure
14:19:31 <flo-retina> as long as you automate duping it, that's fine with me :)
14:20:13 <Mic> nhnt11: I'm not sure yet what might be the best way to go
14:21:15 <nhnt11> Mic: A lot of this code can be modified easily to be generic.
14:21:41 <nhnt11> e.g. Instead of aOtherTab.linkedConversation.conv, aOtherTab.linkedContent.content
14:21:48 <nhnt11> (or something like that)
14:21:52 <-- novabyte has quit (Quit: bye bye)
14:22:55 <Mic> I'm not sure I understand...
14:24:17 <nhnt11> Well for example in importConversation
14:24:34 <nhnt11> It imports a conversation from a different window right? For drag and drop.
14:25:12 <Mic> Yes, it moves conversations between windows.
14:25:26 <nhnt11> it passes aOtherTab.linkedConversation.conv to _addConversation to do this
14:25:57 <nhnt11> So instead of looking for a conv, if we can link each tab with generic content instead..
14:26:05 <nhnt11> Does that make sense?
14:29:22 <qheaden> You guys have any JavaScript debugging tools?
14:30:42 <Mic> hmm..
14:32:25 <aleth> qheaden: The most common way to do it is still to add dump() statements and/or write to the error console.
14:32:58 <flo-retina> qheaden: that's a summer of code project.
14:33:00 <aleth> There is a new-ish debugger for Firefox, but it hasn't been ported to IB yet (I haven't tried it).
14:33:24 <flo-retina> qheaden: a student was accepted this year with a project of making Firefox's debug tools work with Tb (and then porting to Ib should be trivial)
14:33:29 <aleth> venkman is dead, in case you were wondering.
14:40:58 --> novabyte has joined #instantbird
14:50:38 <-- jb has quit (Ping timeout)
14:51:15 * aleth asked on #l10n if there is already code for this somewhere http://www.unicode.org/reports/tr29/#Word_Boundaries
14:52:59 <Mic> nhnt11: I'm still reading tabbrowser code, in case you wonder why I haven't answered yet.
14:57:30 <qheaden> flo-retina: Sorry, I was afk. I had tried that new FF debugger, and it is pretty awesome.
14:57:34 <qheaden> I hope it does get ported to Ib.
15:13:08 <-- MMN-o_ has quit (Ping timeout)
15:25:24 * clokep_work is back.
15:25:36 <clokep_work> aleth: Any thoughts of bug 1971? Do we know if Pidgin can dump debug logs?
15:25:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1971 nor, --, ---, nobody, UNCO, Unable to authenticate with IRC server using LDAP authentication
15:27:29 <flo-retina> clokep_work: it can do debug logs, but probably not as detailed as we do.
15:28:02 <clokep_work> flo-retina: Can it show me what's sent over the wire?
15:28:07 <aleth> Anything would be better than nothing!
15:28:11 <clokep_work> qheaden: Any more thoughts on organizing this stuff?
15:28:17 <aleth> We should see at least the IRC commands sent
15:28:38 <qheaden> clokep_work: No, your method is the best way.
15:29:18 <aleth> clokep_work: https://developer.pidgin.im/wiki/TipsForBugReports#Debug_Log
15:29:20 <qheaden> clokep_work: If I understood you correctly, I should create a map of different event types, and with each type, maintain a list of listeners.
15:29:22 <clokep_work> qheaden: Sorry to take away the excitement. :(
15:29:24 <qheaden> Is that correct?
15:29:44 <clokep_work> qheaden: I think so...if events even need to have multiple "listeners".
15:30:04 * qheaden hopes clokep_work won't get annoyed by his C++ background. :P
15:30:45 <aleth> qheaden: instantbot will be more annoyed ;)
15:30:54 <qheaden> lol
15:31:06 <qheaden> instantbot: C++
15:31:09 <instantbot> qheaden: Sorry, I've no idea what 'C++' might be.
15:31:11 <instantbot> qheaden: firebot knew: everyone knows that! c++ is a programming language that is used in most applications throughout the industry. C++ in itself is platform independent, but to display windows, widgets and t... (rest /msged)
15:31:51 <aleth> Maybe he's not letting himself be baited today...
15:31:55 <qheaden> I like that he asks firebot when he needs help.
15:32:17 <clokep_work> qheaden: I won't get annoyed, just not everyone learns things the same way or using the same terminology in computer science. (I also don't have a real background in CS, so I'm not always familiar with terms...)
15:33:06 <aleth> qheaden: don't use JS-ctypes and you'll be fine ;)
15:34:21 --> Optimizer has joined #instantbird
15:34:24 --> MMN-o has joined #instantbird
15:35:23 <qheaden> How strange. I have a function stored in a list, and can verify its there. But it turns up as null in the variable when using a for..in loop.
15:36:57 <-- Optimizer has quit (Connection reset by peer)
15:37:05 <clokep_work> Can you pastebin the code?
15:39:09 --> Optimizer has joined #instantbird
15:40:54 <-- Optimizer has quit (Ping timeout)
15:41:07 <qheaden> clokep_work: http://pastebin.com/iW3iLk7E
15:41:29 <qheaden> The code simply prints the listener function to the error console so I can verify its been added.
15:41:36 --> Optimizer has joined #instantbird
15:42:07 <qheaden> Also, ignore the ending curly brace in the first code snippet. Copied that by mistake.
15:42:55 <flo-retina> qheaden: is it null or 0?
15:42:58 <clokep_work> qheaden: Isn't for..in give property names not variables back?
15:43:10 <clokep_work> for each in gives values back, I thought.
15:43:19 <clokep_work> (But that's deprecated and we should try not to add more of that...)
15:43:21 <qheaden> flo-retina: Actually its 0.
15:43:23 <flo-retina> I would expect listener to contain the index of the item in this code
15:43:26 <aleth> clokep_work: You need for each... in or for .. of
15:43:36 <clokep_work> aleth: Don't tell me, tell qheaden.
15:43:56 <clokep_work> qheaden: Also, you could use this._eventListeners["connection"].forEach, potentially.
15:43:58 <aleth> oops, that was my intention ;)
15:43:59 <flo-retina> clokep_work: nah, aleth wants to mentor you ;)
15:44:31 <qheaden> aleth: Ahh okay.
15:48:09 <clokep_work> qheaden: I'm is "connection" just an example, by the way?
15:48:13 <Mic> flo-retina: why is forwarding the browser properties necessary? (I'm trying to take a shortcut by asking you, I haven't really looked for the reason myself. Sorry for that...): http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#1246
15:48:38 <-- Optimizer has quit (Connection reset by peer)
15:48:40 <nhnt11> qheaden: I believe you need to do for(let listener....)
15:48:50 <nhnt11> not just for (listener...)
15:49:01 <flo-retina> Mic: I think it's because we have getBrowser() returning the tabbrowser
15:49:11 <qheaden> clokep_work: "connection" is one of the event type keys.
15:49:24 <qheaden> Matching Socket.onConnection.
15:49:48 * nhnt11 doesn't know why he bothered replying to that so late.
15:49:51 <clokep_work> nhnt11: That's not true, JavaScript will automatically create variables.
15:49:56 <clokep_work> It's just bad form. :-D
15:50:18 <clokep_work> qheaden: Does that mean you're going to add an "event type key" for every single message that Yahoo can send us?
15:50:22 <flo-retina> clokep_work: it will automatically create variables that don't do what you expect
15:50:37 <nhnt11> clokep_work: Oh. I've only ever seen for (let blabla in blabla). :P
15:50:53 <clokep_work> nhnt11: Yes, because that's what you should do.
15:50:57 <clokep_work> flo-retina: Yes, but it isn't a syntax error. :)
15:51:05 * clokep_work is trying not to give out nits this early.
15:51:12 <clokep_work> nhnt11: I assigned your GSoC bug to you, hope that's OK.
15:51:18 <nhnt11> clokep_work: Of course.
15:51:49 <qheaden> clokep_work: Keys are created on demand in my addEventListener method - http://pastebin.com/xBTgwS2s
15:52:32 <nhnt11> clokep_work: I renamed it, hope that's OK. :P
15:53:02 <clokep_work> qheaden: That's not what I'm talking about though, how does an incoming Yahoo packet know to call the "new message" command or whatever?
15:54:16 <qheaden> clokep_work: Well, as you mentioned, YahooSocket should be low-level. I plan on creating some higher-level code that will interpret the message.
15:54:43 <qheaden> YahooSocket is there just so objects can listen for incoming messages.
15:54:49 <clokep_work> :-/
15:55:11 <clokep_work> I'd like to see an overall design in pseudo-code / flow diagrams, if you don't mind.
15:55:42 <qheaden> Okay. I'll work on one.
15:55:43 <-- dionisos has quit (Ping timeout)
15:55:46 <-- mpmc has quit (Connection reset by peer)
15:56:01 <clokep_work> Doesn't need to be super nice looking. :)
15:56:14 <clokep_work> It'd just be nice to not redesign everything half way through if we find it to be too tedious. :)
15:56:38 <qheaden> clokep_work: So I understand correctly, what again should be the purpose of the YahooSocket object?
15:59:14 <clokep_work> qheaden: Don't worry about how I'm thinking of it right now and show me how you're thinking of it.
16:00:14 <clokep_work> qheaden: I don't just want to tell you, I want it to be your design...I just want to make sure it makes sense and will be maintainable. :)
16:00:31 <qheaden> Okay. :)
16:00:42 * qheaden looks for a flowchart creator online.
16:02:03 <clokep_work> There's a couple good ones, I usually do them on my whiteboard...but you're not in an office. ;)
16:02:20 <clokep_work> (Just make sure it's in a size that I can print it out. :))
16:04:04 <clokep_work> nhnt11: Yeah, so I was really hoping to just alias it "awesometab" but got distracted. :-/
16:04:20 <clokep_work> (And I don't think we have aliasing set up on our Bugzilla.)
16:04:45 --> Optimizer has joined #instantbird
16:06:01 <nhnt11> clokep_work: Can I file a bug/submit a patch to remove the requirement of a nose in the " :-\ " smiley pretty please?
16:06:34 <-- Optimizer has quit (Ping timeout)
16:06:43 <clokep_work> nhnt11: You can always file a bug/submit a patch. ;)
16:07:07 <nhnt11> clokep_work: Right so I meant would you and flo-retina check it in.
16:07:10 --> Optimizer has joined #instantbird
16:07:10 <clokep_work> I don't know who's "in charge" of our emoticon sets.
16:07:13 <nhnt11> s/and/or
16:07:16 * clokep_work nominates Mic and aleth.
16:07:30 <clokep_work> It's fine w/ me, although it might have more false positives.
16:07:58 <nhnt11> clokep_work: None of the other ones require noses. It irks me since I use ":/" a lot.
16:10:46 <Mic> nhnt11: just file a bug and attach a patch if you like. The selection of emoticons is completely based on the taste and on what the author of the theme frequently uses.
16:11:34 <nhnt11> Mic: I was talking about the default set..
16:11:41 * clokep_work still wishes we had a O:-) emoticon.
16:11:45 <clokep_work> And >:o
16:12:09 <Mic> clokep_work: ask flo if he could get the source images for the emoticons from idechix?
16:12:24 <Mic> nhnt11: it's not that different there.
16:12:49 <-- Optimizer has quit (Ping timeout)
16:13:35 <clokep_work> Mic: I had filed a bug a while ago, I'd still need to modify the images. :)
16:14:09 <Mic> I wouldn't mind doing that.. I always liked drawing and editing graphics :)
16:17:19 <clokep_work> I don't have an artistic bone in my body. ;)
16:17:47 <clokep_work> You can fix the seventh (?) bug I ever filed then. :P
16:17:50 <clokep_work> bug 488
16:17:51 --> Optimizer has joined #instantbird
16:17:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=488 nor, --, ---, nobody, NEW, Missing Commonly Used Emoticon
16:18:08 <Mic> I almost chose an advanced course in arts in school ;)
16:18:23 <Mic> Together with physics that would have been quite a combination ;)
16:18:35 <clokep_work> I lied, the 16th.
16:18:38 <qheaden> I'll be back in about 30 min.
16:18:39 <flo-retina> Mic: why not? :)
16:18:47 <clokep_work> :) You gotta do what you enjoy!
16:18:52 * flo-retina studied sociology.
16:19:24 * nhnt11 has to study Electronics.
16:19:39 <Mic> nhnt11: you'd rather like to do CS, don't you?
16:19:50 <nhnt11> Mic: Yes ^^
16:20:11 <-- gerard-majax_ has quit (Ping timeout)
16:20:54 <instantbot> New Websites - hg.instantbird.org (Mercurial/hgweb) bug 1986 filed by clokep@gmail.com.
16:20:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1986 nor, --, ---, nobody, NEW, hg.instantbird.org needs new styling
16:20:56 <flo-retina> clokep_work: "I'm not sure if there's a vetting process for adding new emoticons." The process is "answer no by default, until someone manages to convince us that it doesn't hurt (ie no unreasonably frequent false positives) and is actually very commonly used" 
16:21:16 * clokep_work should have done CS...
16:21:21 <clokep_work> flo-retina: Sounds reasonable. :)
16:21:45 <flo-retina> clokep_work: I don't think I would need much convincing for O:-) btw
16:22:00 <flo-retina> a good icon would likely be enough
16:22:36 <flo-retina> Wouldn't take much convincing to get me to r+ a patch removing ) : for :(
16:23:32 <flo-retina> bug 1986 is a regression; I don't know when it happened
16:23:40 <Mic> I think we should distinguish the cases where getBrowser() is used to get the tabbrowser and where it is used to get at the actual browser in a tab.
16:23:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1986 nor, --, ---, nobody, NEW, hg.instantbird.org needs new styling
16:23:46 <clokep_work> I use :-X a lot too.
16:24:30 <clokep_work> Oh, we have an angry icon? x-(
16:24:34 <clokep_work> Weird...
16:24:37 <clokep_work> Never seen that before.
16:24:43 <Mic> We could then forward the browser-getBrowser() call to the actual browser and get rid of the forwarded browser properties on tabbrowser. Does that make sense?
16:24:54 <flo-retina> yeah, you just wanted to add the >-( text code to it if I understood the bug correctly
16:25:28 <flo-retina> Mic: that makes some sense.
16:25:44 <flo-retina> Mic: the only *real* reason why we have all this forwarding is that Firefox does it, so we did it too.
16:26:17 <Mic> The cases where it is not the tabbrowser seem to be only a few from what I've seen on lxr.
16:26:26 <flo-retina> Mic: but I suspect we don't care much at this point about having code similar to Firefox so that tab add-ons could be easily ported (Firefox's code has changed enough that easily porting a tab add-on seems unlikely anyway)
16:28:34 <-- novabyte has quit (Quit: bye bye)
16:28:43 <flo-retina> Mic: the cases in macgestures. I would expect some zoom stuff to use it too. And possibly the findbar.
16:29:19 <Mic> The macgestures are what I meant with "few cases".
16:30:23 <-- Optimizer has quit (Ping timeout)
16:30:25 <flo-retina> Mic: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/viewZoomOverlay.js#9
16:31:07 <Mic> :)
16:31:11 <Mic> Good to know.
16:31:46 <aleth> Mic: also tooltips
16:32:12 <flo-retina> looks like you could just change http://lxr.instantbird.org/instantbird/source/instantbird/content/convZoom.js#91 to call setZoomForBrowser
16:32:30 <flo-retina> and http://lxr.instantbird.org/instantbird/source/instantbird/content/convZoom.js#73 to getZoomForBrowser
16:32:58 <flo-retina> for the findbar, we likely already have a hack, as we have one findbar per conversation
16:33:16 <qheaden> clokep_work: I am going to first concentrate on the login process, so I will work on as flowchart just for that right now and we can discuss it before I make charts for other processes.
16:33:47 --> Optimizer has joined #instantbird
16:34:08 <clokep_work> qheaden: Well it's possible to think about it at multiple levels, there's a flow chart for the actual login process...and then there's the design overview which shows how the objects interact (there's some CS term for that I'm forgetting...).
16:34:33 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2465 on bug 1757.
16:34:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, nobody, NEW, Some nicks aren't detected by Show Nick
16:37:09 <flo-retina> aleth: I'm a bit confused by the "- 2" in there
16:38:01 <aleth> flo-retina: I hoped it was clear from the comment :( The -2 cancels the added spaces.
16:41:10 <flo-retina> aleth: that I could guess. But it's not clear to me why you need to cancel the 2 of them, rather than just the first or last one
16:41:35 * qheaden is now known as qheaden_backsoon
16:41:46 <aleth> The problem is that the regex match indices don't refer to the index of the captured string, but to the index of the complete match
16:41:50 <flo-retina> and it's not immediately obvious to me if this compensation still work for the second nick in the line
16:41:59 <flo-retina> but it's possible that I just don't remember that code at all :-/
16:42:48 <flo-retina> anyway, thanks for looking at this annoying bug :)
16:42:49 * clokep_work finds his comment relevant. ;)
16:43:15 <flo-retina> clokep_work: yeah, it is
16:43:38 <flo-retina> clokep_work: I think it's the same issue as for tab completion: it should be moved to a jsm file first
16:43:47 <flo-retina> I could be wrong though :)
16:44:34 --> Mook_as has joined #instantbird
16:44:51 --> dionisos has joined #instantbird
16:44:57 <clokep_work> Ah, my new server shipped! :)
16:45:03 <flo-retina> :)
16:45:08 <aleth> While I don't disagree, that is kind of a separate bug (I'd suggest moving the nick-matching part to a JSM, as we can then reuse it for pings)
16:45:09 <flo-retina> is that a work or personal server?
16:45:24 <clokep_work> flo-retina: Personal.
16:45:33 <flo-retina> even better :)
16:45:50 <clokep_work> Yup! :) Much more powerful than my old (currently in pieces one).
16:46:25 <aleth> Btw I'm not particularly happy with that fix, but it's an improvement and better to do it now when we've just been discussing it than when it has been forgotten again...
16:47:06 <flo-retina> aleth: sure; thanks :)
16:47:32 <-- MMN-o has quit (Ping timeout)
16:47:56 <clokep_work> aleth: I agree! :)
16:48:01 <clokep_work> Check it in! :P
16:48:18 * flo-retina would like to understand that -2
16:48:28 <flo-retina> I guess I'll need to reread the whole loop
16:48:49 <aleth> The confusing thing is you use capturing parentheses but never use the captured matches.
16:49:05 <flo-retina> fix that too? :)
16:49:08 <flo-retina> (if it confuses you
16:49:08 <flo-retina> )
16:49:36 <aleth> I looked, but I can't see anything that would be obviously better
16:50:02 <aleth> (I hoped to drop them as it would speed things up I guess)
16:51:47 --> MMN-o has joined #instantbird
16:56:55 <Mic> clokep_work, Mook_as: is there a way to not copy collapsed code when copying a selection in Komodo Edit?
16:57:22 <Mook_as> Hmm. I have no idea; #komodo (in particular, toddw or ericp) might
16:59:56 <-- Optimizer has quit (Ping timeout)
17:05:19 <aleth> flo-retina: Sorry, I see why I confused you. When I said "flo-retina: I hoped it was clear from the comment :( The -2 cancels the added spaces" I meant s/spaces/"\W" (the \W are not zero-length like \b)
17:05:40 <flo-retina> oh
17:07:02 <aleth> That's why we were talking past each other...
17:09:04 --> Optimizer has joined #instantbird
17:10:55 <-- Optimizer has quit (Ping timeout)
17:11:40 --> Optimizer has joined #instantbird
17:11:50 <clokep_work> lookaheads and lookbehinds!
17:12:42 <aleth> Hmm, that might work
17:12:59 --> gerard-majax__ has joined #instantbird
17:13:31 <douglaswth> lookarounds!
17:13:42 <clokep_work> aleth: JS doesn't support one of those. :(
17:14:00 <aleth> oh, right :(
17:14:10 <-- Optimizer has quit (Input/output error)
17:14:38 <nhnt11> clokep_work: lookbehinds aren't supported IIRC
17:15:19 --> Optimizer has joined #instantbird
17:15:36 <clokep_work> https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/RegExp would know...
17:15:54 <clokep_work> Yeah, lookbehinds are not.
17:17:03 <-- Optimizer has quit (Ping timeout)
17:17:17 <flo-retina> aleth: "I meant s/spaces/"\W" (the \W are not zero-length like \b)" maybe the comment in the code should say so?
17:17:53 <aleth> OK, I'll add it to the first comment.
17:18:10 <aleth> But I think it'll be better to add a comment near the -2
17:19:51 <flo-retina> sure, add a comment just before the -2 :)
17:20:01 <flo-retina> and make the () non capturing if you think it's an improvement
17:22:39 <-- dionisos has quit (Ping timeout)
17:28:29 --> Optimizer has joined #instantbird
17:30:18 <-- Optimizer has quit (Ping timeout)
17:30:28 * qheaden_backsoon is now known as qheaden
17:30:36 <-- flo-retina has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
17:30:37 <qheaden> I'm back.
17:30:53 --> Optimizer has joined #instantbird
17:34:38 <-- Optimizer has quit (Ping timeout)
17:37:26 <-- deltafalcon has quit (Connection reset by peer)
17:38:23 --> Optimizer has joined #instantbird
17:48:55 <-- Optimizer has quit (Ping timeout)
17:56:19 <nhnt11> I'm back too
17:58:04 <qheaden> nhnt11: How's your project coming along?
17:58:42 <nhnt11> qheaden: Well the add-on window (and pretty much anything else) can now be opened in a tab, but it's pretty broken
17:58:55 <nhnt11> I'm going to get my bitbucket repo properly set up and try tackling these errors
17:59:06 <qheaden> Okay.
17:59:29 * nhnt11 wonders where atuljangra is
18:00:03 <nhnt11> qheaden: How are you managing your BitBucket repo? Do you have a separate source tree set up for it?
18:00:27 <nhnt11> (On your hard drive I mean)
18:01:58 <clokep_work> nhnt11: You can push/pull from multiple locations. wnayes might have more info on this.
18:03:20 <nhnt11> clokep_work: Hmm. Mainly I wonder if I can push to my BitBucket repo from my clone of the main Ib repo, or whether I'll have to work in one repo, and copy changes to and push from another one.
18:03:23 <Mic> clokep_work: I wondered if it's possible to pull from hg.instantbird.org and to push to an own repo on BitBucket. Sounds like it is :)
18:03:49 <nhnt11> Pretty much what Mic just said :P
18:04:51 <Mook_as> it should work, as long as you don't hit repo size limits if any exist. (the instantbird repo should be fine; a mozilla tree might be less so)
18:05:38 <qheaden> nhnt11: In my repo, I simply cloned the Ib tree, but created a separate branch for development.
18:05:42 <clokep_work> nhnt11: It is, that's what I was just trying to say.
18:05:59 <qheaden> Whenever new changes are made to the central Ib tree, I'll just pull them and merge them into my branch.
18:06:16 <clokep_work> (hg clone https://hg.instantbird.org/instantbird && hg push https://bitbucket/nhnt11/instantbird) or whatever.
18:06:27 <nhnt11> Ah okay.
18:06:29 <qheaden> Mook_as: I've pushed the entire Mozilla tree to BitBucket before.
18:06:41 <clokep_work> You can even set up different branch names, so you can say "hg pull instantbird && hg merge default && hg push bitbucket"
18:06:44 <Mook_as> alright, I guess they have no (relevant) limits then :)
18:06:52 <nhnt11> I imported the repo from the main Ib server using BitBucket's interface
18:06:53 <qheaden> I think that's how GitHub forks work anyway.
18:07:16 <nhnt11> Guess that was a bad idea.
18:07:27 <clokep_work> nhnt11: That should work fine.
18:07:33 <clokep_work> You can still hg pull from hg.instantbird.org
18:07:38 <Mook_as> github forks likely (I have no way of knowing for sure) share the commit objects somehow
18:07:51 * clokep_work hates the way github forks work.
18:08:00 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2465 on bug 1757.
18:08:01 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2466 on bug 1757.
18:08:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, aleth, ASSI, Some nicks aren't detected by Show Nick
18:08:29 <qheaden> I think GitHub works by making developers fork projects they want to work with, and any improvement patches are sent back to the primary project. Or something similar.
18:11:35 <qheaden> clokep_work: I emailed you a couple of documents for the design overview.
18:12:36 <clokep_work> Yeah, I just find it very confusing.
18:12:42 <clokep_work> qheaden: I'll take a look in a few minutes
18:13:16 <clokep_work> aleth: Does getting rid of the global flag affect anything
18:13:41 <aleth> clokep_work: It should speed things up I hope, I don't know how much ;)
18:14:08 <clokep_work> aleth: But what if we need to match multiple nicks? Or is that done via the loop?
18:14:45 <aleth> clokep_work: It's done via the loop. Once a nick is matched, aNode gets "shortened"
18:15:21 --> Optimizer has joined #instantbird
18:15:36 --> dionisos has joined #instantbird
18:15:54 <-- skeledrew has quit (Ping timeout)
18:18:01 <clokep_work> aleth: Got it.
18:19:37 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
18:19:57 --> Mic has joined #instantbird
18:19:58 * ChanServ sets mode +h Mic 
18:21:00 <-- dionisos has left #instantbird ()
18:21:23 * nhnt11 has a feeling these daily logs are going to be really useful in the future.
18:22:54 <-- Optimizer has quit (Ping timeout)
18:26:34 <clokep_work> qheaden: That sounds reasonable. Personally I think keeping the code as stateless as possible is a good thing, but it can't always be done (and depends a lot on the protocol)
18:27:15 <qheaden> clokep_work: Yes. I think keeping state would only be required during the login period.
18:27:17 <clokep_work> qheaden: I'm not sold that you'll need to pass a callback to YahooSession.login, but OK.
18:27:20 <-- Mic has left #instantbird ()
18:27:32 <qheaden> Since there is a lot of acknowledgement going on.
18:27:41 <clokep_work> Yes.
18:28:02 <qheaden> clokep_work: Perhaps I can create a third YahooLogin helper class, and leave YahooSession stateless?
18:28:17 <clokep_work> qheaden: So what I don't understand though...is why does there need be a "reigstered listener" for connection? Why can't the socket just call YahooSession.onConnection?
18:28:28 <clokep_work> qheaden: Don't worry too much about it for now.
18:28:40 --> Mic has joined #instantbird
18:28:40 * ChanServ sets mode +h Mic 
18:28:54 <clokep_work> There might be other state variables (e.g. OSCAR keeps track of the message #s sent and received)
18:29:32 <qheaden> clokep_work: I used the registered listener approach because there might be more than one YahooSession for some future feature, or more than just the YahooSession might want to receive the notification.
18:30:00 <qheaden> Because YahooSession is instance based, not static.
18:31:21 * qheaden just got the prpl to communicate with YMSG pager request server.
18:31:40 <Mic> We're just missing a CSS rule to get visible tabs shown differently in the alltabs menu :(
18:31:45 <Mic> Bug 1481
18:31:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1481 enh, --, ---, nobody, NEW, Style visible tabs in all-tabs menu like Firefox does
18:32:51 <clokep_work> qheaden: Didn't you say originally that YahooSession is handling all communication though? Doesn't that imply there is only one of it per account?
18:33:01 <clokep_work> I don't want to needlessly complicate code.
18:33:31 <qheaden> Hmm, I guess you are right.
18:33:45 <qheaden> But are there going to be any situations where other objects around the Ib code need to listen for such events?
18:34:14 <clokep_work> There should not be, the prpl code is supposed to be entirely self contained and other things aren't allowed to "touch" it except via known interfaces.
18:34:29 <nhnt11> Mic: Do we already label tabs as visible or not?
18:34:36 <Mic> Yes :(
18:35:11 <aleth> qheaden: The idea is that the prpl code sends out notifications for events that the UI needs to know about, but those are protocol-independent
18:35:23 <qheaden> clokep_work: In that case, it would be best to ditch the listener code.
18:35:23 <aleth> See https://wiki.instantbird.org/Instantbird:Notifications:trunk
18:35:27 <Mic> We had a similiar situation with shortcuts to jump to the n-th tab. The tab selection code was there, just not the keybindings.
18:36:48 <qheaden> clokep_work: So basically, in its constructor, we can pass YahooSocket a YahooSession object to notify.
18:37:46 <clokep_work> qheaden: Yes.
18:38:25 <qheaden> Sounds good.
18:38:27 --> Optimizer has joined #instantbird
18:39:39 --> dionisos has joined #instantbird
18:41:34 <Mic> aleth: is the bug with the notification for detached conversations fixed already?
18:42:08 <aleth> Mic: no, it's waiting for feedback from flo, as my patch depends on interpreting the meaning of conversation-loaded a particular way
18:42:12 <-- Optimizer has quit (Ping timeout)
18:42:26 <Mic> OK-
18:42:53 <Mic> OK - I wanted to know if I could ask douglaswt h to update Input History to remember the history even in these cases...
18:43:23 * clokep_work should blog on his own blog about GSoC...
18:43:50 <qheaden> clokep_work: How about I simply make YahooSession a child of Socket? It didn't have any inheritance in the first place, and will remove the need for another class.
18:44:01 --> Optimizer has joined #instantbird
18:44:03 <-- Optimizer has quit (Input/output error)
18:44:05 --> Optimizer has joined #instantbird
18:45:38 <aleth> Mic: That's almost an argument for a separate (new) conversation-imported notification
18:45:55 <aleth> Which would be the other possible solution
18:47:38 <Mic> How would you transfer data between the conversations in different windows?
18:50:41 <aleth> Either you store the data on the conv (not the binding) or the add-on would store the data indexed by conv and separately a conv to current binding map (which it would then update)
18:51:24 <Mic> I think I'd use a shared module for this.
18:51:53 <aleth> An add-on is kind of like a shared module, isn't it?
18:52:07 <clokep_work> aleth: It depends on how it's implemented.
18:52:12 <aleth> Depending on how you write it.
18:52:17 <Mic> As javascript module, jsm.
18:52:22 <clokep_work> qheaden: Maybe, but I thought you wanted it to also contain the HTTP calls?
18:52:23 <aleth> clokep_work: Sure
18:52:40 <Mic> The code on the conversation binding would just fetch the data from there. This way it should even survive the conversation being put on hold.
18:53:03 <aleth> Yes, that's what I meant
18:53:22 <qheaden> clokep_work: It can do all of that internally. It just seems unnecessary to create YahooSocket if all it is going to do is send callbacks to YahooSession. YahooSession can handle that itself.
18:54:10 <clokep_work> qheaden: It sounds kind of messy, but either way would work OK.
18:54:41 <-- Optimizer has quit (Ping timeout)
18:55:15 <aleth> qheaden: If it simplifies the code, it might be worth it just for that (as a logical unit)
18:55:37 <qheaden> clokep_work: What I will probably do is just work on YahooSession for now, and any functionality that can be spun off into its own object/module I can break off.
18:55:53 * clokep_work wonders if he's the only one that sends memoserv to himself. ;)
18:55:56 <qheaden> Because I also don't want YahooSession to become too bloated.
18:56:00 <clokep_work> qheaden: That's fine.
18:56:12 <qheaden> We will refine as we go along.
18:56:14 <Mic> clokep_work: no, I also do that;)
18:57:17 * qheaden wonders what memoserv is.
18:57:20 <nhnt11> Phew, finally got the repo set up (I think)
18:58:07 <clokep_work> qheaden: It's a message service on IRC.
18:58:12 <clokep_work> (Well depends on the network.)
18:58:21 <qheaden> Ahh okay. :)
18:58:36 <clokep_work> I'm sure you'll get one from me eventually. ;)
18:58:43 --> Optimizer has joined #instantbird
18:59:00 * nhnt11 wishes version control was simpler.
18:59:53 <clokep_work> nhnt11: What's confusing you about it?
19:00:00 <clokep_work> It should be fairly simple to get your setup working.
19:00:07 <nhnt11> It's not confusing exactly
19:00:12 <clokep_work> Maybe your brain has just been rotted by git. :P
19:00:19 <nhnt11> Just a bit more tedious than it should be (imo).
19:00:42 <nhnt11> clokep_work: Maybe. I still don't know why you guys hate git over mercurial.
19:01:31 <clokep_work> If you want to get into it, we can talk about it in a side channel. Mostly we just like to rant about it though.
19:01:46 <qheaden> What does instantbot think of Git?
19:01:46 <nhnt11> Ha. Maybe later.
19:02:29 <-- Optimizer has quit (Ping timeout)
19:05:53 --> Optimizer has joined #instantbird
19:09:44 <instantbot> aleth@instantbird.org cancelled review?(aleth@instantbird.o rg) for attachment 2456 on bug 1454.
19:09:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
19:12:24 <-- Optimizer has quit (Ping timeout)
19:12:26 <qheaden> clokep_work: Non-blocking requests are going to make this complex, just to let you know. :P
19:13:02 <-- Mic has quit (Ping timeout)
19:13:47 <-- Even has quit (Ping timeout)
19:14:23 --> Even has joined #instantbird
19:14:23 * ChanServ sets mode +o Even 
19:16:10 --> Optimizer has joined #instantbird
19:16:18 <-- nhnt11 has left #instantbird ()
19:16:29 --> nhnt11 has joined #instantbird
19:17:54 <-- Optimizer has quit (Ping timeout)
19:21:43 --> jb has joined #instantbird
19:24:09 --> flo-retina has joined #instantbird
19:24:09 * ChanServ sets mode +qo flo-retina flo-retina 
19:26:30 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2467 on bug 1757.
19:26:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, aleth, ASSI, Some nicks aren't detected by Show Nick
19:27:39 --> Optimizer has joined #instantbird
19:29:02 <-- nhnt11 has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
19:29:34 --> nhnt11 has joined #instantbird
19:30:45 <clokep_work> qheaden: Trust me, I know.
19:31:11 <clokep_work> Although the pain of it fully depends on how the messages are set up.
19:31:37 <qheaden> clokep_work: I've come up with a new idea. Perhaps we can change YahooSession.onDataReceived on the fly based on what message is expected next.
19:32:06 <clokep_work> I think that's what the XMPP code vaguely does.
19:32:08 <qheaden> Once login is complete, we can set onDataReceived back to a generic message handler.
19:32:35 <qheaden> Doing it that will will also remove the need for a state machine.
19:33:31 * nhnt11 is totally unable to concentrate today.
19:34:39 <nhnt11> I botched my tree completely (I really have no clue what I did, it was a series of mistaken commands) and I'm doing a full re-clone because I really don't have the patience to try and fix it.
19:35:11 <nhnt11> Sorry for the slow progress today :(
19:35:12 <nhnt11> I'm going to get a good night's sleep and start afresh tomorrow. 
19:35:12 <qheaden> nhnt11: If you need any help with Mercurial/BitBucket, let me know.
19:35:28 <nhnt11> qheaden: It should've been simple. I really don't know what I did.
19:35:49 <qheaden> Version control can be messed up very quickly.
19:37:52 <nhnt11> qheaden: The following is correct right?
19:37:53 <flo-retina> nhnt11: sleep is important! If you don't feel like working any more today, don't hesitate to go get some rest :)
19:37:54 <nhnt11> hg branch awesometab
19:37:54 <nhnt11> (make changes)
19:37:54 <nhnt11> hg commit
19:37:54 <nhnt11> hg push
19:38:18 <qheaden> nhnt11: Looks right to me.
19:39:07 <nhnt11> qheaden: So somehow, I commited changes to the default branch, tried to revert them, and ended up without a clue where I was in the history.
19:39:17 <nhnt11> flo-retina: I'm going to start a clone and sleep :)
19:39:37 <qheaden> Of course you are forced to use the --new-branch flag on hg push to create a new branch on BitBucket.
19:40:14 <nhnt11> qheaden: Hmm.
19:40:56 <nhnt11> flo-retina, clokep_work, aleth: There wouldn't be any harm in keeping my objdir right?
19:41:07 <qheaden> nhnt11: Perhaps the branch wasn't created on BitBucket for some reason, and it sent the changes to default, but the changes were made to awesometab on your local machine.
19:41:08 <nhnt11> (since I'm re-cloning)
19:41:29 <nhnt11> qheaden: They were made to default on both bitbucket and my local machine.
19:41:45 <qheaden> Strange.
19:42:12 <qheaden> nhnt11:  Next time, before you commit, run hg branch without any arguments to make sure you are on the awesometab branch.
19:42:26 <nhnt11> qheaden: I did something wrong I'm sure. I'll look at my bash history tomorrow.
19:42:31 <nhnt11> qheaden: Good idea.
19:43:00 <nhnt11> brb
19:43:01 <-- nhnt11 has quit (Input/output error)
19:43:30 --> nhnt11 has joined #instantbird
19:46:21 <nhnt11> Good night!
19:46:23 <-- nhnt11 has quit (Quit: Instantbird 1.4 -- http://www.instantbird.com)
19:51:55 <qheaden> Is there a config that allows Ib to start with the Error Console open?
19:52:09 <flo-retina> qheaden: -jsconsole on the command line
19:52:19 <qheaden> flo-retina: Thanks.
19:54:03 <aleth> flo-retina: Were you planning to do any reviews in the next hour or so? (As otherwise I would head off now, but I'll be away tomorrow)
19:54:28 --> Mic has joined #instantbird
19:54:28 * ChanServ sets mode +h Mic 
19:54:36 <flo-retina> aleth: I'm likely going to look at the checkin-needed queue
19:54:51 <flo-retina> r+ that NiKo` fix (I already looked and liked much better the new version)
19:54:59 <flo-retina> and if possible, try again to build moz21
19:56:08 <aleth> flo-retina: Great, thanks! You probably don't need me for those then.
19:56:39 <flo-retina> aleth: is there something you would like r+'ed tonight?
19:57:31 <aleth> The f? on bug 1973 would be useful (but it doesn't have to be tonight)
19:57:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, ---, aleth, ASSI, Concatenated logs don't work for buddies and contacts
19:58:08 <flo-retina> ok
19:58:13 <aleth> I was just asking because there were some questions on bug 1940
19:58:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1940 nor, --, ---, aleth, ASSI, Fix errors/warnings on detaching/reattaching conversations
19:58:36 <aleth> but that's not blockign anything.
19:58:47 <aleth> Good luck with moz21 :)
19:58:53 <-- aleth has quit (Quit: Ciao)
20:02:59 <-- Optimizer has quit (Ping timeout)
20:03:06 <-- jb has quit (Ping timeout)
20:05:08 <-- gerard-majax__ has quit (Ping timeout)
20:14:18 <qheaden> clokep_work: What do you think of this - http://pastebin.mozilla.org/2463012
20:14:41 <qheaden> I think the cleanest method is the change our callbacks as needed. Also, please note the comment I made in the logout method.
20:14:47 <Mic> flo-retina, clokep_work: what's your opinion on creating different bindings for generic tabs and tabs with conversations (the latter extending the earlier maybe)? The context menu for tabs, their alltabs-menu items (, ...?) would then be created by the tabbrowser by querying the tab (or every tab in question) for necessary information?
20:15:17 <clokep_work> Mic: It sounds like a reasonable start, you definitely want somethings to be abstracted.
20:17:04 <clokep_work> qheaden: Are you using the socket to do HTTP requests?
20:17:11 * clokep_work is realizing why we might have been talking past each other now.
20:17:29 <qheaden> clokep_work: Yeah. Wrong way?
20:17:37 <clokep_work> qheaden: http://lxr.instantbird.org/instantbird/source/chat/modules/http.jsm
20:17:52 <clokep_work> qheaden: Yes, there's no reason to do raw HTTP requests yourself.
20:17:59 <qheaden> Aha!
20:18:48 <qheaden> clokep_work: Well, the whole login isn't all HTTP. It does involve some binary request in later steps.
20:20:01 <flo-retina> Mic: the idea seems OK.
20:20:15 --> Optimizer has joined #instantbird
20:20:34 <clokep_work> qheaden: Yes, I know that. But the hTTP requests should be done with the HTTP request object, which take a callback. So you won't need to do crazy things.
20:20:57 <qheaden> clokep_work: Yes, that makes sense.
20:21:15 <qheaden> clokep_work: But do you agree with changing the callbacks as needed? It seems to simplify the login code.
20:21:41 <clokep_work> qheaden: I'd like to see if it's needed after you switch to using the doXHRRequest.
20:21:52 <qheaden> Okay.
20:22:31 <clokep_work> I suspect it won't be necessary.
20:55:46 <qheaden> clokep_work: doXHRequest works great, and reduces code.
20:56:01 <clokep_work> qheaden: Excellent. :)
20:56:16 <clokep_work> I still hate the name of it though. ;)
20:56:42 <qheaden> clokep_work: But I'm starting to think it will be best if dedicate an object to logging in. It is so complex, and would make YahooSession very bloated.
21:03:42 <flo-retina> I wonder if http://pastebin.instantbird.com/209595 could explain the mac failure
21:04:18 <clokep_work> flo-retina: Quite possible, obviously all the changes to build stuff was just a guess. :-/
21:04:24 <clokep_work> (And I'm always wrong in those.)
21:04:26 <clokep_work> qheaden: OK.
21:04:51 <flo-retina> clokep_work: well, that's likely just stuff that needs porting ;)
21:05:47 <flo-retina> clokep_work: I'm especially looking at http://hg.mozilla.org/comm-central/rev/bd22a204044b
21:06:20 <clokep_work> Ah, interesting. :)
21:06:32 <clokep_work> (Also nice to see that it isn't like moz23.)
21:06:46 <flo-retina> moz19
21:06:48 <flo-retina> which is confusing too ;)
21:07:24 <clokep_work> But more plausible. :)
21:07:29 <clokep_work> Probably worth a try.
21:07:39 <flo-retina> trying to build tb 21 isn't very successful :-S
21:07:48 * clokep_work is leaving.
21:07:49 <clokep_work> Ciao.
21:08:02 <flo-retina> http://pastebin.instantbird.com/209596
21:08:10 <flo-retina> clokep_work: good evening :)
21:08:36 <flo-retina> bah, I'm just stupid tonight :(
21:08:54 <flo-retina> forgot to run client.py after updating comm-release
21:09:57 <clokep_work> :(
21:10:04 <-- clokep_work has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
21:11:32 --> EionRobb has joined #instantbird
21:33:14 <-- chrisccoulson has quit (Quit: Ex-Chat)
21:34:31 <-- Optimizer has quit (Ping timeout)
21:38:02 --> Optimizer has joined #instantbird
21:38:19 --> skeledrew has joined #instantbird
21:38:48 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:39:04 --> Mic has joined #instantbird
21:39:05 * ChanServ sets mode +h Mic 
21:39:58 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
21:40:22 --> Mic has joined #instantbird
21:40:22 * ChanServ sets mode +h Mic 
21:41:47 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2468 on bug 1481.
21:41:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1481 enh, --, ---, benediktp, ASSI, Style visible tabs in all-tabs menu like Firefox does
21:44:53 --> chrisccoulson has joined #instantbird
21:47:02 <flo-retina> adding  -std=gnu++0x on the clang command line fixes the build for the file that refused to build
21:47:18 <flo-retina> now I need to track down in the build system what caused that flag to not be set for us
21:48:00 <-- Optimizer has quit (Ping timeout)
21:51:18 --> Optimizer has joined #instantbird
21:58:39 <-- mconley has quit (Input/output error)
22:02:55 --> Kaishi has joined #instantbird
22:09:32 <flo-retina> Mic: is the tabIsVisible attribute correctly set on the 'alltabs-item's ?
22:10:02 <flo-retina> I would expect the attribute name to have to be listed in http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#1818 for things to work
22:10:03 <Mic> Yes, it is.
22:11:15 <flo-retina> ok. I have no idea of how that code works then :-S
22:11:57 <Mic> http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#1875
22:12:31 <-- skeledrew has quit (Ping timeout)
22:12:51 <flo-retina> ah, that's only for the popup, ok
22:14:00 <flo-retina> can I steal the review and just check-in the patch? :)
22:14:10 <Mic> Sure :)
22:15:58 <instantbot> florian@instantbird.org granted review for attachment 2468 on bug 1481.
22:15:58 --> unghost has joined #instantbird
22:16:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1481 enh, --, ---, benediktp, ASSI, Style visible tabs in all-tabs menu like Firefox does
22:16:03 <-- Optimizer has quit (Ping timeout)
22:16:10 <flo-retina> ok, time to start looking at checkins, and reviews
22:16:18 --> skeledrew has joined #instantbird
22:16:24 <flo-retina> (my mac build is building, and I hope it will continue to do so for a while)
22:19:11 <flo-retina> Mic: I have no idea of the implications of the patch in bug 1175 on add-ons, so I don't feel confident reviewing it. My assumption is that taking it isn't significantly worse than the current state, and likely helps in some cases; is this right?
22:19:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1175 nor, --, ---, aleth, ASSI, Add-ons need a notification when a conversation is detached and moved to a new window
22:21:03 <Mic> aleth suspects that it might be problematic when an add-on has already added something to the conversation content and might do that again (or would need to check if it shouldn't).
22:22:39 <Mic> Maybe that's about his MathJax add-on? It's injecting code into the browser content...
22:23:29 --> FireFly_TB has joined #instantbird
22:23:51 <Mic> It would help for some add-ons though. Basically every add-on that is listening to conversation-loaded and didn't work on detached conversations should start working.
22:24:55 <instantbot> florian@instantbird.org requested review from the wind for attachment 2469 on bug 1956.
22:24:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1956 nor, --, ---, clokep, ASSI, Update to Mozilla 21
22:25:37 <flo-retina> anybody should feel free to rs that patch I guess.
22:25:54 <flo-retina> probably not a big deal if it waits for clokep though
22:26:09 <flo-retina> as I don't think it's a good idea to checkin the moz21 update the same day as the checkin-needed queue
22:27:06 --> mconley has joined #instantbird
22:27:50 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2461 on bug 1175.
22:27:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1175 nor, --, ---, aleth, ASSI, Add-ons need a notification when a conversation is detached and moved to a new window
22:28:42 <-- skeledrew has quit (Ping timeout)
22:29:06 <qheaden> I have to go right now. I might be back later on.
22:29:10 <qheaden> Bye everyone!
22:29:14 <flo-retina> qheaden: good evening :)
22:29:24 <Mic> Would the data-object of the notification be appropriate to add information that the conversation isn't loading for the first time?
22:29:29 <Mic> qheaden: bye
22:29:37 * qheaden is now known as qheaden_away
22:29:56 <flo-retina> Mic: that would be OK if it's useful
22:30:21 <flo-retina> Mic: honestly, each time I see that notification I wish I never introduced it
22:30:43 <flo-retina> it was a mistake, what I really wanted was a non bubbling event, to have the communication between the convbrowser and the conversation binding.
22:38:02 <instantbot> florian@instantbird.org granted review for attachment 2466 on bug 1757.
22:38:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, aleth, ASSI, Some nicks aren't detected by Show Nick
22:38:32 <instantbot> florian@instantbird.org granted review for attachment 2467 on bug 1757.
22:41:47 --> skeledrew has joined #instantbird
22:46:42 <-- dionisos has quit (Ping timeout)
22:49:49 <-- skeledrew has quit (Ping timeout)
22:51:35 <flo-retina> I'm too tired to understand the code in bug 1940 :(
22:51:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1940 nor, --, ---, aleth, ASSI, Fix errors/warnings on detaching/reattaching conversations
22:53:49 --> skeledrew has joined #instantbird
22:59:54 <Mic> Good night
23:01:10 <-- Mic has quit (Quit: Instantbird -- http://www.instantbird.com)
23:03:36 <instantbot> florian@instantbird.org denied review for attachment 2454 on bug 1973.
23:03:37 <instantbot> florian@instantbird.org cancelled feedback?(florian@instantbi rd.org) for attachment 2454 on bug 1973.
23:03:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1973 nor, --, ---, aleth, ASSI, Concatenated logs don't work for buddies and contacts
23:08:16 --> florian has joined #instantbird
23:08:30 <florian> hello from a moz21 mac debug universal build \o/
23:08:42 <-- florian has quit (Quit: Instantbird 1.5a1pre -- http://www.instantbird.com)
23:10:36 <Mook_as> so moz21 builds have horrible uptime? :p
23:10:54 <flo-retina> Mook_as: it didn't crash ;)
23:16:04 --> wnayes has joined #instantbird
23:17:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7b711ec1a864 - Nihanth Subramanya - Bug 1962 - Backslash is stripped from incoming action messages, r=aleth,clokep.
23:17:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/82748672d4a2 - aleth - Bug 1974 - Log window is not focused if it already exists, r=Mic.
23:17:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3748f7c417fd - aleth - Bug 1757 - Nicks starting or ending by a non-alphanumeric character aren't detected correctly for pings, r=fqueze.
23:17:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c25d057274df - aleth - Bug 1175 - Add-ons need a notification when a conversation is detached and moved to a new window, r=Mic.
23:17:34 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2235e9d8d387 - Benedikt Pfeifer - Bug 1481 - Style visible tabs in all-tabs menu like Firefox does, r=fqueze.
23:17:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/43559dca3293 - Bug 1757 - Nicks starting or ending by a non-alphanumeric character aren't highlighted by the Show Nick feature, r=fqueze.
23:19:29 <douglaswth> yay!
23:27:12 <instant-buildbot> build #397 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/397  blamelist: Benedikt Pfeifer <benediktp@ymail.com>, aleth <aleth@instantbird.org>, aleth <aleth@instantbird.org, Nihanth Subramanya <nhnt11@gmail.com>
23:48:11 <flo-retina> Good night
23:56:19 --> rosonline has joined #instantbird
23:59:49 <instant-buildbot> build #416 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/416