All times are UTC.
00:01:39 <clokep> Mook_as: T9? ;) 00:01:43 <clokep> nhnt11: That should work IIRC. 00:01:48 * clokep is now known as clokep___ 00:01:53 * clokep___ is now known as clokep 00:02:11 <clokep> nhnt11: In nightlies, at least. 00:02:17 <nhnt11> It didn't re-identify for me on 1.3 00:02:19 <nhnt11> Oh okay 00:02:31 * nhnt11 wills his build to go faster 00:03:03 <nhnt11> clokep, Mook_as: interestingly, I know several people here who use T9 on their smartphones, because it's "faster" for them 00:03:54 <clokep> nhnt11: bug 1766 00:04:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, 1.4, aleth, RESO FIXED, Automatically authenticate when changing the nick to the account nickname 00:06:53 <-- qlum has quit (Ping timeout) 00:07:28 <nhnt11> Looking through patches is always nice ^^ 00:12:45 <Mook_as> right. but I don't think that's better than twitter :p 00:13:08 <clokep> SMS does have like 20 more characters IIRC. ;) 00:15:06 <EionRobb1> depends on the sms provider 00:15:13 <nhnt11> Woohoo build successful 00:15:20 * EionRobb1 is now known as EionRobb 00:15:26 <-- nhnt11 has quit (Input/output error) 00:20:31 --> nhnt11 has joined #instantbird 00:20:54 <-- jb has quit (Ping timeout) 00:23:38 <dew> woo hoo 00:23:59 <dew> clokep: I have the opportunity to take some sessions on web development, should I? 00:24:16 <clokep> dew: If you're interested in it, why not! 00:24:51 <dew> well I'm kind of interested in it, not as much as I was before but it's a prereq for a JavaScript course 00:25:04 <dew> which is what I'm more interested in if I want to help out here 00:25:31 <clokep> Then sounds like you're interested in it. ;) 00:25:45 <clokep> I mean more training / skills / whatever is always good. 00:25:49 <clokep> Keeps you on your toes. 00:25:50 <dew> I just have to convince my company to pay for it 00:26:00 <clokep> Of course. :) 00:28:04 <dew> Ahh I'm psyched. I really want to help out! I went through the omegle source code the other day and while I understood most if it, JavaScript is still a bit different to me. 00:28:20 <clokep> Well if you have questions, feel free to ask. 00:28:46 <nhnt11> dew: what language are you migrating from? 00:29:05 <dew> I'm used to C++ and I used PHP recently 00:29:06 * instantbot frowns at dew 00:29:13 <nhnt11> hahaha instantbot <3 00:30:21 <nhnt11> clokep: I notice that these tests directly call functions from other source files 00:30:30 <nhnt11> but for the backslash bug, I only need part of a function 00:30:43 <clokep> nhnt11: What do you mean "only part of a function"? 00:30:43 <nhnt11> Shall I just write a function to reproduce only the high level dequote code? 00:31:00 <clokep> nhnt11: Absolutely not. 00:31:09 <nhnt11> Yeah I thought so 00:31:13 <clokep> nhnt11: You're going to test the whole function, that's the suggestion. 00:31:17 <nhnt11> Okay 00:31:42 <clokep> Isn't the function only like 8 lines anyway? :P 00:31:52 <nhnt11> Yeah but I have to figure out what the arguments are now 00:32:07 <nhnt11> aMessage is obvious but aRawCTCPMessage is not very (at least not yet) 00:32:08 <clokep> It's an ircMessage object, I think. 00:32:25 <clokep> Mhmm, just look at where it's called from. 00:32:31 <nhnt11> Yep doing that 00:32:42 <clokep> OK. :) 00:32:50 <clokep> CTCP is a PITA btw. 00:33:00 <nhnt11> I need to get a basic IDE that highlights usages :/ 00:33:04 <nhnt11> I agree 00:34:02 <nhnt11> I find it amazing that a protocol as old as IRC is still being used today 00:35:53 <nhnt11> clokep: how do I use dump 00:36:03 <nhnt11> Does it print to the error console? 00:36:22 <nhnt11> Okay scratch all that, I'll lookup how to print to error console 00:37:36 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 00:38:29 <clokep> nhnt11: I usually use Components.utils.reportError. 00:38:37 <clokep> Also, Mook_as can probably suggest a good IDE. ;) 00:38:44 <clokep> (He works for ActiveState.) 00:38:48 <clokep> Komodo Edit is a good time. 00:39:25 <nhnt11> I've always used NetBeans, but then I've always used Java 00:39:47 <clokep> Mmhmm. 00:40:08 --> wuwei`lab has joined #instantbird 00:47:48 <nhnt11> Looks like I only need to worry about the second argument, |aRawCTCPMessage| 00:48:15 <clokep> aMessage can probably just be {}. 00:48:21 <nhnt11> Yeah 00:49:23 <nhnt11> aRawCTCPMessage is just something like |ACTION \\m/| 00:49:29 <nhnt11> And so on 00:49:47 <clokep> Yes. 00:49:47 <nhnt11> So I'll make a list of test strings and feed all of them to the function? 00:49:54 <clokep> Yup. 00:50:02 <clokep> The spec probably has some good test strings. 00:51:00 <clokep> But really you just need to do one without a parameter, one with a parameter and then the characters we're attemping to escape, etc. 00:52:19 <nhnt11> Yeah 00:52:20 --> EionRobb1 has joined #instantbird 00:52:45 <-- EionRobb has quit (Ping timeout) 00:54:07 <instant-buildbot> build #392 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/392 00:54:47 <clokep> win32-oncommit? :P 00:55:34 <nhnt11> I'm thinking this would be fine? http://pastebin.instantbird.com/181237 00:55:53 <nhnt11> Maybe I should add some with more words 00:56:19 <clokep> I don't really think other commands are necessary. 00:56:31 <clokep> But yeah, that's probably fine. 00:56:54 --> wnayes has joined #instantbird 00:59:49 * clokep pokes wnayes. 01:01:23 <nhnt11> clokep: this test uses input.map() to get the output for each element as a list 01:01:34 <nhnt11> Any easy way to do that for a function with 2 arguments? 01:02:05 <clokep> nhnt11: input.map(function(aStr) foo({}, aStr)) 01:02:08 <nhnt11> Other than storing the input as an array of ["", "[string to test]"] elements 01:02:26 <clokep> Isn't the first parameter always the same? Just hard code it. 01:02:40 <nhnt11> ah 01:02:48 <nhnt11> I was thinking of hardcoding it in the input array 01:02:54 <nhnt11> Didn't think of wrapper function 01:04:01 <clokep> Mmhmm. 01:04:10 <clokep> If you do something crazy, we'll tell you in review. :) 01:04:18 <nhnt11> Okay :) 01:04:31 <wnayes> clokep: Hey! :) 01:04:52 * wnayes is trying out Thunderbird's IRC 01:05:19 <clokep> wnayes: Nice. :) Instead of Instantbird's? :P 01:05:34 <clokep> wnayes: Hope your semester went well! We're gearing up for GSoC this year again. 01:05:54 <-- Mook_as has quit (Quit: Mook_as) 01:06:41 <wnayes> I always have Thunderbird open, so it seemed like a good option to keep open windows to a minimum. 01:06:55 <clokep> Makes sense. 01:08:30 <wnayes> Looks like some neat projects on the list this year! 01:09:54 <wnayes> I won't be applying this year, but hopefully I can help out some over the summer. 01:10:08 <clokep> Yeah, you said you have an internship. :) We'd love that for sure! 01:10:17 <clokep> And hopefully florian can find some time to review your patch. :-[ 01:19:10 <nhnt11> urgh 01:19:16 <nhnt11> CTCP -_- 01:19:38 <clokep> :) 01:19:41 <nhnt11> Trying to ensure correct expectedOutput values 01:20:00 <nhnt11> All these \x5C's are a little blurry at 7am :( 01:20:04 * nhnt11 needs some coffee 01:20:49 <nhnt11> clokep: does the raw ctcp message have a terminating character 01:21:09 <clokep> nhnt11: I think it has to, yes. 01:21:11 <nhnt11> For example, if the user types a backslash as the last character of the message, can that ever be the last character of the raw ctcp 01:21:42 <clokep> nhnt11: Looks like it's only the part between \x01: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircCTCP.jsm#76 01:22:07 <clokep> I'd have to re-read the spec for that situation. 01:23:38 <clokep> (Which isn't going to happen tonight.) 01:23:41 <clokep> Just note about it. 01:24:14 <nhnt11> I'll add a test for it anyway. The expected output will contain the backslash 01:24:42 <clokep> OK. 01:24:47 <clokep> At least we'll know what the behavior is then. 01:25:49 <nhnt11> Okay 01:33:07 <nhnt11> clokep: Where is do_check_eq defined? 01:33:24 <nhnt11> It's used in an other CTCP test but not in any imported files 01:33:30 <nhnt11> nor in the same file 01:33:36 <clokep> nhnt11: It's part of the testing framework. 01:33:48 <nhnt11> So exists by default? 01:33:49 <nhnt11> Okay 01:34:01 <clokep> nhnt11: https://developer.mozilla.org/en-US/docs/Writing_xpcshell-based_unit_tests#XPCShell_test_utility_functions 01:34:04 <clokep> Yes. 01:35:11 <nhnt11> Okay now where do I post this file 01:35:21 <nhnt11> Here's a paste of it: http://pastebin.instantbird.com/181262 01:35:49 <clokep> nhnt11: What do you mean by post? 01:36:00 <clokep> You need to add it into the tree and attach a patch to the bug. 01:36:05 <nhnt11> submit for review or whatever 01:36:55 <clokep> You need to create a patch and attach it to the bug. 01:37:00 <clokep> (If that's not clear, ask more questions. ;)) 01:37:08 <nhnt11> It's clear 01:37:15 <nhnt11> But not the part about adding it to the tree 01:37:32 <clokep> "adding it to the tree" means putting it under the irc/test directory and doing "hg add" 01:38:08 <nhnt11> So you mean in my local repository 01:38:35 <clokep> Yes. 01:40:35 <nhnt11> I would obviously have to do that in order to get my patch ;) 01:45:43 <clokep> Right. 01:47:23 <nhnt11> Attaching patch :) 01:49:41 <clokep> OK. 01:49:44 <clokep> Request review from me. 01:53:01 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2405 on bug 1935. 01:53:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 02:01:00 <-- dew has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 02:01:36 <nhnt11> I'm going to grab some breakfast 02:01:46 * nhnt11 is now known as nhnt11|away 02:01:57 --> dew has joined #instantbird 02:09:45 <instantbot> clokep@gmail.com denied review for attachment 2405 on bug 1935. 02:09:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 02:12:10 <clokep> nhnt11|away: Did you actually run those tests? 02:46:38 --> flo-retina has joined #instantbird 02:46:38 * ChanServ sets mode +qo flo-retina flo-retina 02:46:58 <flo-retina> hello :) 02:50:04 * clokep hates when flo-retina is in a TZ behind him. 02:50:21 <clokep> It blows my whole sense of time out of whack. :P 02:53:23 --> jb has joined #instantbird 02:54:06 * flo-retina is glad to see wnayes around :) 02:54:16 <flo-retina> and I'm sorry for the delay on that review :( 02:54:26 <flo-retina> clokep: heh 02:54:43 <flo-retina> how do you think my "sense of time" is these days? ;) 02:54:49 <-- jb has quit (Quit: jb) 02:56:01 <flo-retina> so many things in my inbox :( 02:56:12 <flo-retina> I guess I need to filter more aggressively 02:57:15 <flo-retina> clokep: did you really intend to resolve bug 1187 as FIXED? 02:57:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1187 cri, --, 1.2, florian, RESO FIXED, Severe pauses/hang when dealing with large conversation backlogs 02:58:03 <clokep> flo-retina: Yes. 02:58:58 <clokep> I couldn't resolve it as a DUP or INCOMPLETE or whatever since we have a check-in on it. ;) 02:59:26 <flo-retina> I guess I need to reread then 03:00:25 <instant-buildbot> build #850 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/850 03:00:48 --> jb has joined #instantbird 03:01:03 <flo-retina> "There isn't anything we can do about this." I don't think I agree with that line. 03:01:32 <flo-retina> we already discussed having libpurple prpls in separate processes 03:01:34 <clokep> It's pretty much what you said a few comments above that. 03:01:46 <clokep> We're not discussing libpurple prpls though. 03:01:46 <flo-retina> I don't see a solid reason why JS-prpls couldn't go in workers 03:01:58 <clokep> Workers can't have XPCOM IIRC. 03:02:15 * clokep needs to go to bed though. 03:02:20 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 03:02:45 <flo-retina> "We don't store logs in HTML" isn't a really solid point either. 03:05:02 <flo-retina> his idea of using "Gecko's async loading support for HTML" makes sense. We could generate a fake request and put messages formatted as HTML on the stream (like a real HTTP server would do). That may be especially interesting for the log viewer. We currently freeze the main thread while we are parsing the JSON of conversations. 03:13:26 <flo-retina> clokep: "Workers can't have XPCOM IIRC." it's unfortunate. But most of our code "may" be able to work without XPCOM. WebIDL may be useful there though (the only part of xpcom I would really miss is the clear interface/implementation separation we have with idl) 03:22:00 <nhnt11|away> flo-retina: I need some help with tests 03:22:04 * nhnt11|away is now known as nhnt11 03:22:23 <nhnt11> I've written a test, and added to the ini file. What's the correct procedure to run it? 03:23:37 <flo-retina> make xpcshell-tests 03:23:37 --> deOmega1 has joined #instantbird 03:23:39 <-- deOmega1 has quit (Connection reset by peer) 03:24:04 --> deOmega1 has joined #instantbird 03:24:06 <-- deOmega1 has quit (Connection reset by peer) 03:24:30 --> deOmega1 has joined #instantbird 03:26:34 <deOmega1> AWESOME work on the conversation history guys. Just awesome! 03:29:36 <deOmega1> i would only now ask to have the additional ones open in tabs.. so if i am looking at say logs for flo, and then i decide to look at logs from clokep.. clokep history would open in a new tab, that way I can actually toggle and compare without losing my spot. 03:33:41 <nhnt11> flo-retina: Should I worry about a test failing before submitting a patch 03:34:18 <flo-retina> deOmega1: I'm glad you'll like 1.4 :) 03:34:37 <flo-retina> nhnt11: we fixed a broken test this morning, so it's possible you just need to hg pull && hg update 03:34:55 <nhnt11> No, the test I'm writing now is broken 03:35:05 <deOmega1> thank you. (you are up late) 03:35:19 <flo-retina> deOmega1: I'm in Mountain View 03:35:45 <deOmega1> ah.. ok :) I hope you are having a blast 03:36:03 --> Mook has joined #instantbird 03:36:03 <flo-retina> lots of meetings today; quite tired (and a bit jet lagged of course) 03:36:11 <instant-buildbot> build #846 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/846 03:36:55 <deOmega1> jet lag i can imagine.. was actually gonna ask you how long you been there for That reason, but question answered. be safe 03:39:15 <flo-retina> deOmega1: I arrived yesterday evening 03:39:35 <deOmega1> ouch 03:43:44 --> mconley has joined #instantbird 03:44:20 <-- jb has quit (Ping timeout) 03:44:44 <deOmega1> night 03:45:51 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 03:46:59 --> deOmega1 has joined #instantbird 03:47:04 <-- deOmega1 has quit (Connection reset by peer) 03:47:10 --> deOmega1 has joined #instantbird 03:47:23 <-- deOmega1 has quit (Connection reset by peer) 03:47:39 --> deOmega1 has joined #instantbird 03:47:55 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 03:50:56 --> deOmega1 has joined #instantbird 03:51:48 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 03:51:56 --> deOmega1 has joined #instantbird 03:52:12 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 03:55:18 --> Kaishi has joined #instantbird 04:00:27 <nhnt11> I got the test to pass :) 04:01:08 <nhnt11> flo-retina: Should I include the bug fix and the unit test in the same patch? Or diff them separately? 04:01:29 <flo-retina> in the same patch 04:01:37 <nhnt11> Okay :) 04:17:20 <-- mconley has quit (Input/output error) 04:27:03 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 04:28:10 --> nhnt11 has joined #instantbird 04:28:52 <-- nhnt11 has quit (Input/output error) 04:31:06 --> nhnt11 has joined #instantbird 04:32:26 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 04:32:57 --> nhnt11 has joined #instantbird 04:33:25 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 04:34:17 --> nhnt11 has joined #instantbird 04:34:28 <nhnt11> flo-retina: How do I rebuild the .app file in mac? 04:34:50 <nhnt11> After doing make -C chat/protocols/irc, I don't think the app package is updated 04:35:08 <flo-retina> make -C objdir/instantbird/app 04:35:38 <nhnt11> Thanks a lot 04:35:47 <-- nhnt11 has quit (Input/output error) 04:36:10 --> nhnt11 has joined #instantbird 04:37:31 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 04:38:38 <instantbot> florian@instantbird.org set the Resolution field on bug 1943 to FIXED. 04:38:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1943 tri, --, 1.4, florian, RESO FIXED, irc.js should use lazy getters for localized strings 04:39:05 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0edc579572c0 - Florian Quèze - Bug 1943 - irc.js should use lazy getters for localized strings, r=clokep. 04:39:46 <-- wnayes has quit (Quit: wnayes) 04:44:49 <EionRobb1> that's an easy looking fix :) 04:48:31 <Mook> Hmm, those aren't quite lazy getters 04:48:40 <Mook> that is, they get things every time, right? 04:49:44 <Mook> (compared to, say, http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/XPCOMUtils.jsm#161 ) 04:50:26 <flo-retina> Mook: that's right 04:50:36 <flo-retina> that bug title/commit message is poorly phrased 04:51:01 <Mook> s/lazy//g :p 04:51:25 <flo-retina> Mook: it's the irc.properties file that we are accessing lazyly ;) 04:51:58 <Mook> well, it's not memoizing, so it's not lazy enough 04:52:11 <Mook> unless you mean "too lazy to implement memoizing getters" :p 04:52:30 * Mook sighs at his non-working laptop 04:52:38 <EionRobb1> smash it with a hammer! 04:52:40 <flo-retina> Mook: I mean, I'm pretty sure once we have accessed it once, it's in disk cache :-P 04:53:55 <flo-retina> Mook: scratch that, it's indeed lazy: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircUtils.jsm#12 04:54:30 <flo-retina> hmm, I'm not completely sure of the interaction between defineLazyGetter and EXPORTED_SYMBOLS :-S 04:55:18 <flo-retina> Good night :) 04:57:16 <EionRobb1> so at the moment irc.js can display colours... does it convert inputted colours to the mirc codes too? 04:59:03 <Mook> I believe it does no conversion 04:59:21 <Mook> also, I think that says getting _ is lazy, but getting the result of _ isn't 05:00:31 <instant-buildbot> build #407 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/407 05:03:22 <instant-buildbot> build #386 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/386 05:14:12 <-- EionRobb1 has quit (Quit: Leaving.) 05:31:46 <-- Mook has quit (Quit: Mook) 05:47:47 <instant-buildbot> build #943 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/943 06:07:26 <-- Optimizer has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 06:07:42 --> Optimizer has joined #instantbird 06:59:21 <-- Optimizer has quit (Ping timeout) 07:02:41 --> Optimizer1 has joined #instantbird 07:05:27 <instant-buildbot> build #393 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/393 07:17:48 --> gerard-majax__ has joined #instantbird 08:15:45 <-- dew has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 08:24:33 --> FeuerFliege has joined #instantbird 08:30:51 <-- gerard-majax__ has quit (Ping timeout) 08:58:40 <-- FeuerFliege has quit (Ping timeout) 09:15:13 --> dew has joined #instantbird 09:37:24 --> gerard-majax__ has joined #instantbird 10:03:09 --> rosonline has joined #instantbird 10:03:30 --> clokep has joined #instantbird 10:03:30 * ChanServ sets mode +o clokep 10:19:31 <clokep> EionRobb: We only handle incoming colors. 10:37:45 <-- UCC has quit (Ping timeout) 10:43:18 --> FeuerFliege has joined #instantbird 10:51:02 <-- FeuerFliege has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 11:00:01 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 11:02:50 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 11:18:04 --> mpmc has joined #instantbird 11:21:05 --> UCC has joined #instantbird 11:21:30 --> jb has joined #instantbird 11:49:24 --> clokep_work has joined #instantbird 11:49:24 * ChanServ sets mode +o clokep_work 12:00:19 --> deOmega1 has joined #instantbird 12:02:04 --> nhnt11 has joined #instantbird 12:02:25 <nhnt11> clokep_work: Sorry about that patch. Major derp. 12:02:50 <nhnt11> I fixed it up in the morning but I couldn't stay up long enough to upload it 12:03:09 <nhnt11> I'll do it now. 12:09:14 <clokep_work> nhnt11: No problem. 12:09:22 <clokep_work> I can't be angry when people volunteer to fix things. ;) 12:09:47 <nhnt11> Haha. But I don't think it helps my reputation much. 12:10:35 <nhnt11> Anyway, I found a problem with changing the regex to /\x5C[^\x5C]/ 12:11:11 <nhnt11> That doesn't match pairs of backslashes at all, but instead, matches the second backslash and the character following it, which we don't want 12:11:46 <nhnt11> For example in |\\test|, |"\t"| would be matched 12:14:45 <clokep_work> OK, did you fix it? 12:16:19 <nhnt11> Yes 12:16:41 <-- jb has quit (Quit: jb) 12:17:19 <nhnt11> I changed it to | function(aStr) (aStr[1] == "a") ? "\x01" : (aStr[1] == "\x5C") ? "\x5C\x5C" : aStr[1]); | but I don't like it much. 12:18:04 <nhnt11> I tried changing the regex to /[^\x5C]\x5C[^\x5C]/ but that requires a character before the backslash, and created some other complications which I can't recall now 12:19:31 <nhnt11> Oh I remember, it fails when you have three backslashes in a row - it should match the first pair and then the third one with whatever follows it. i.e. in \\\test, "\\" and "\t" should both match. 12:21:34 <clokep_work> OK I'll look at it when it's uploaded. 12:22:54 --> jb has joined #instantbird 12:23:01 <clokep_work> This is why we should have tests. ;) 12:24:02 <nhnt11> clokep_work: Yes, I realized that :) 12:24:15 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2406 on bug 1935. 12:24:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 12:27:46 <clokep_work> nhnt11: Just an FYI, usually when you upload a new patch that replaces one you've already uploaded we mark the old one as obsolete. 12:28:00 <nhnt11> Didn't I? 12:28:13 <nhnt11> I think I forgot to do that the second time 12:28:24 <nhnt11> My internet disconnected when i submitted the first time 12:28:31 <nhnt11> Had to fill it out twice :( 12:30:29 <deOmega1> the popup notifications are very clean looking in 1.4. btw, trying to figure out how to stop my antivirus from seeing IB as a threat. 12:31:21 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 12:32:10 <-- nhnt11 has quit (Input/output error) 12:32:21 --> nhnt11 has joined #instantbird 12:36:02 --> qlum has joined #instantbird 12:41:47 --> deOmega1 has joined #instantbird 12:43:10 <-- nhnt11 has quit (Input/output error) 12:43:21 <-- mpmc has quit (Ping timeout) 12:43:48 --> nhnt11 has joined #instantbird 12:43:54 <clokep_work> deOmega1: Which AV sfotware? 12:44:04 <instantbot> clokep@gmail.com denied review for attachment 2406 on bug 1935. 12:44:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 12:44:15 --> rosonline has joined #instantbird 12:45:22 <nhnt11> clokep_work: I used test_ctcpFormatting as a template I think :/ 12:46:04 <clokep_work> nhnt11: I don't understand why that is :-/? 12:46:16 <clokep_work> Different tests get done in different ways. 12:46:23 <nhnt11> Okay 12:46:42 <nhnt11> Fixing 12:47:21 <deOmega1> clokep_work: Avast 12:48:12 <nhnt11> So by having a script loader in Services, we eliminate the need to export stuff from other files, and only Services.jsm needs to be imported? nice. 12:49:04 <deOmega1> Thanks for asking 12:49:41 <-- jb has quit (Ping timeout) 12:50:08 <nhnt11> clokep_work: about those extra tests. The first one would have an expected out put \x5C\x5C\x01, not \x5C\x01 12:50:49 <nhnt11> And the second one will be unchanged 12:51:31 <-- nhnt11 has quit (Input/output error) 12:51:55 --> nhnt11 has joined #instantbird 12:51:55 * nhnt11 fires up Google to read more about CTCP quoting/dequoteing 12:52:09 <clokep_work> nhnt11: As I said it /does not/ include *string* quoting. 12:52:16 <clokep_work> I mean the literal character \x5C. 12:52:20 <nhnt11> I understand 12:52:20 <clokep_work> s/quoting/escaping/ 12:53:01 <-- UCC has quit (Ping timeout) 12:53:17 <nhnt11> In code, "\\\\\\a" -> "\\\\\x01" 12:53:24 <clokep_work> deOmega1: I don't use Avast, sorry. 12:53:56 <deOmega1> no problem 12:53:57 <nhnt11> Without backslash escaping, "\\\a" -> "\\\x01" 12:54:07 <clokep_work> nhnt11: Yes. 12:54:13 <deOmega1> any timetable for tehrelease of 1.4? 12:54:29 <clokep_work> nhnt11: I'm suggesting we test situations where the two escaped characters are next to each other. 12:54:31 <clokep_work> deOmega1: The 28th. 12:54:37 <nhnt11> Okay 12:54:54 <deOmega1> clokep_work: Awesome... that should get rid of it .. thanks 12:54:56 --> jb has joined #instantbird 12:58:39 <nhnt11> clokep_work: To ammend current patch, I do qnew refresh? 12:58:52 <nhnt11> sorry qrefresh 13:00:53 <clokep_work> nhnt11: qrefresh, yes. 13:00:56 <clokep_work> (qref ;)) 13:03:03 <-- nhnt11 has quit (Input/output error) 13:03:14 --> nhnt11 has joined #instantbird 13:04:11 <nhnt11> clokep_work: About the 80 character limit. I knew you would point that out ;) 13:04:18 <nhnt11> But, I couldn't figure out the right way to split it 13:04:39 <nhnt11> Putting function(aStr) above will exceed the previous line 13:05:49 <clokep_work> nhnt11: If it really can't be made to look pretty....how far over 80 characters is it the way you have it now? 13:06:21 <nhnt11> It's at 93 13:06:31 <clokep_work> That's pretty long... 13:06:42 <clokep_work> Try your best to make it look pretty. 13:06:57 <clokep_work> (Maybe getting rid of parenthesis if they're not necessary or putting more line breaks in. 13:06:59 <clokep_work> ) 13:07:19 <nhnt11> I was thinking this. http://pastebin.instantbird.com/181550 13:07:39 <nhnt11> Should the second line be indented or not/ 13:08:16 --> UCC has joined #instantbird 13:08:56 <clokep_work> nhnt11: The way it is now looks "correct". 13:09:02 <clokep_work> Are those extra parenthesis necessary btw? 13:10:02 * clokep_work is wondering if http://pastebin.instantbird.com/181551 is more readbale 13:10:38 <nhnt11> I don't think they're necessary, but they made it more readable when it was all in one line 13:11:42 <nhnt11> Okay I'll go with what you just pasted 13:12:37 * nhnt11 has 15MB of free RAM left :O 13:13:14 <clokep_work> I don't like them around the boolean statement, they might be nice around the second ternary operator though. 13:13:47 <-- rosonline has quit (Ping timeout) 13:14:11 <nhnt11> The original file had them around the boolean statement so I preserved that. 13:14:52 <clokep_work> Yes. 13:14:59 <clokep_work> I decided I don't like it. :-D 13:15:35 <nhnt11> Okay :D 13:15:52 <-- nhnt11 has quit (Input/output error) 13:15:59 --> nhnt11 has joined #instantbird 13:21:30 <-- spiffytech has quit (Client exited) 13:21:43 <-- nhnt11 has quit (Input/output error) 13:21:50 --> nhnt11 has joined #instantbird 13:22:35 --> mpmc has joined #instantbird 13:28:40 --> rosonline has joined #instantbird 13:30:00 <-- jb has quit (Ping timeout) 13:30:01 <-- Kaishi has quit (Quit: Kaishi) 13:31:10 <-- nhnt11 has quit (Input/output error) 13:31:17 --> nhnt11 has joined #instantbird 13:31:54 --> mconley has joined #instantbird 13:32:46 --> Huvik has joined #instantbird 13:37:11 --> spiffytech has joined #instantbird 13:38:14 <Huvik> /msg NickServ confirm 00HxFTlcY 13:38:51 <nhnt11> clokep_work: such messages should really be trimmed, should they not? 13:39:28 <Huvik> yea my fault sorry 13:40:10 <clokep_work> nhnt11: I don't know what you mean by "trimmed"? 13:40:16 <nhnt11> Whitespace removed 13:40:18 <clokep_work> Nor do I know what you mean by "such messages". 13:40:27 <clokep_work> Hello Huvik. 13:40:30 <nhnt11> clokep_work: See Huvik's message above 13:40:38 <nhnt11> He accidentally added a space 13:40:38 <clokep_work> nhnt11: Why would we do that? 13:40:45 <clokep_work> A space before means you don't want to do a command. 13:40:47 <nhnt11> It could've compromised his password 13:40:56 <nhnt11> Hmm. 13:41:33 <Huvik> its hashed or? 13:41:52 <nhnt11> No I meant, when you did the /msg NickServ register (or whatever the command is) 13:42:15 <Huvik> yea but i typed this first one this one is copied so 13:42:42 <nhnt11> I believe that requires you to type your password in the command. If someone does the same mistake there, their password will be displayed for all 13:42:42 <Huvik> btw Hello there :) 13:42:46 <nhnt11> Hi :D 13:43:40 <Huvik> clokep_work ty for your answer 13:43:50 <clokep_work> Huvik: You're welcome. :) Let me know if you have any more questions. 13:44:07 <flo-retina> nhnt11: sending one's password in a public channel compromises it, yes. That's not the fault of the client software though ;) 13:44:12 <Huvik> okey :) can i ask here ? 13:44:18 <-- nhnt11 has quit (Input/output error) 13:44:24 --> nhnt11 has joined #instantbird 13:44:35 <nhnt11> flo-retina: Yeah but we could still add some sort of protection 13:45:16 <nhnt11> flo-retina: How was your day at Mountain View? 13:45:23 <nhnt11> I used to live near there a long time ago :) 13:45:28 <flo-retina> it's 6:45am ;) 13:45:37 <nhnt11> aahh timezones xD 13:46:15 <clokep_work> Huvik: please, yes. 13:48:48 * nhnt11 goes back to fixing that patch 13:50:33 <-- nhnt11 has quit (Input/output error) 13:50:37 --> nhnt11 has joined #instantbird 13:54:09 <-- nhnt11 has quit (Input/output error) 13:54:19 --> nhnt11 has joined #instantbird 13:54:46 <-- mpmc has quit (Ping timeout) 13:56:57 --> mpmc has joined #instantbird 13:57:11 <-- nhnt11 has quit (Input/output error) 13:57:19 --> nhnt11 has joined #instantbird 13:59:59 <clokep_work> (Btw hello UCC, I saw you come in here after my email too. ;)) 14:00:16 <-- nhnt11 has quit (Input/output error) 14:00:22 --> nhnt11 has joined #instantbird 14:01:42 --> jb has joined #instantbird 14:04:13 <UCC> Hi clokep_work, I've been lurking around here since you send me the reply :D, I read trough what you sent me, compiled instantbird, and I'll try to find something to do later. I didn't manage to get the skypeKit though :( 14:04:38 <-- nhnt11 has quit (Input/output error) 14:04:41 <clokep_work> UCC: Can you elaborate? 14:04:44 --> nhnt11 has joined #instantbird 14:05:32 <UCC> Hi clokep_work, I've been lurking around here since you send me the reply :D, I read trough what you sent me, compiled instantbird, and I'll try to find something to do later. I didn't manage to get the skypeKit though :( 14:05:34 <clokep_work> UCC: I thought I said in my email that you wouldn't be able to get SkypeKit without paying, but I can give you access if you're accepted. 14:05:45 <UCC> sorry about the double message :D 14:06:02 <UCC> I know, but I wanted to make sure :D 14:07:12 <clokep_work> You should be able to see some of the documentation and such though. 14:07:13 <nhnt11> UCC: Hi! :) 14:07:57 <nhnt11> clokep_work: Patch delayed... some interesting campus politics going on here :S 14:08:42 <-- nhnt11 has quit (Input/output error) 14:08:49 --> nhnt11 has joined #instantbird 14:15:10 <-- jb has quit (Ping timeout) 14:16:53 <UCC> nhnt11: Hi! :D 14:18:52 <UCC> clokep_work, that's what I'm currently doing, if I don't understand something I'all ask you 14:20:41 <clokep_work> UCC: Excellent. :) 14:20:56 <-- nhnt11 has quit (Input/output error) 14:21:02 --> nhnt11 has joined #instantbird 14:21:19 <-- mpmc has quit (Ping timeout) 14:21:28 <nhnt11> clokep_work: I'm trying to load ircCTCP.jsm from Services.scriptloader. I'm getting |uncaught exception: Error opening input stream (invalid filename?)| when running the test though 14:22:02 <nhnt11> Is this wrong? Services.scriptloader.loadSubScript("resource:///components/ircCTCP.jsm", ircCTCP); 14:25:47 <clokep_work> nhnt11: Yes. 14:25:51 <clokep_work> It's in modules, not components. 14:29:12 <-- nhnt11 has quit (Input/output error) 14:29:16 --> nhnt11 has joined #instantbird 14:30:07 --> mpmc has joined #instantbird 14:39:05 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 14:44:07 <-- Huvik has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 14:44:12 --> Huvik has joined #instantbird 14:44:39 --> jb has joined #instantbird 14:47:47 <-- nhnt11 has quit (Ping timeout) 14:51:30 --> nhnt11 has joined #instantbird 14:52:52 <-- Huvik has quit (Ping timeout) 14:54:11 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2407 on bug 1935. 14:54:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 14:54:16 <nhnt11> finally got that in 14:55:45 <-- wuwei`lab has quit (Quit: Leaving) 14:56:33 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 14:56:37 --> Huvik has joined #instantbird 14:58:21 <-- Huvik has quit (Ping timeout) 15:02:00 * nhnt11 is now known as nhnt11|dinner 15:02:54 <-- jb has quit (Connection reset by peer) 15:03:34 <-- UCC has quit (Input/output error) 15:16:24 --> jb has joined #instantbird 15:16:52 --> flo-retina has joined #instantbird 15:16:52 * ChanServ sets mode +qo flo-retina flo-retina 15:17:16 --> Huvik has joined #instantbird 15:18:21 <clokep_work> flo-retina: ping 15:19:01 <-- Huvik has quit (Ping timeout) 15:31:42 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 15:32:27 * Optimizer1 is now known as Optimizer 15:32:37 <-- jb has quit (Ping timeout) 15:34:31 --> jb has joined #instantbird 15:34:51 --> flo-retina has joined #instantbird 15:34:51 * ChanServ sets mode +qo flo-retina flo-retina 15:37:46 --> Huvik has joined #instantbird 15:42:10 --> UCC has joined #instantbird 15:45:37 <-- Huvik has quit (Ping timeout) 15:48:55 <-- nhnt11|dinner has quit (Input/output error) 15:49:20 --> nhnt11|dinner has joined #instantbird 16:01:48 <-- nhnt11|dinner has quit (Input/output error) 16:01:50 --> nhnt11|dinner has joined #instantbird 16:09:54 --> qheaden has joined #instantbird 16:10:22 <qheaden> clokep_work: ping 16:12:04 <qheaden> Did the GSoC Skype project merge into "Additional JavaScript Protocol Plug-ins"? 16:16:43 * nhnt11|dinner is now known as nhnt11 16:16:52 <-- nhnt11 has quit (Input/output error) 16:18:15 --> nhnt11 has joined #instantbird 16:21:50 <-- nhnt11 has quit (Input/output error) 16:21:57 --> nhnt11 has joined #instantbird 16:26:10 <-- nhnt11 has quit (Input/output error) 16:26:13 --> nhnt11 has joined #instantbird 16:27:09 <-- clokep_work has quit (Ping timeout) 16:29:54 --> aleth has joined #instantbird 16:29:54 * ChanServ sets mode +h aleth 16:30:51 <-- nhnt11 has quit (Input/output error) 16:30:59 --> nhnt11 has joined #instantbird 16:34:53 <-- nhnt11 has quit (Input/output error) 16:34:58 --> nhnt11 has joined #instantbird 16:35:00 <deOmega1> clokep_work: what antivirus do you use? 16:38:54 <-- nhnt11 has quit (Input/output error) 16:39:10 --> nhnt11 has joined #instantbird 16:40:25 --> Mook_as has joined #instantbird 16:41:43 <aleth> clokep: splitting long IRC messages was in 1.3 16:42:09 <aleth> bug 1712 16:42:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1712 enh, --, 1.3, clokep, RESO FIXED, Send long IRC messages in several parts 16:42:56 <-- nhnt11 has quit (Input/output error) 16:43:01 --> nhnt11 has joined #instantbird 16:46:58 <-- nhnt11 has quit (Input/output error) 16:47:07 --> nhnt11 has joined #instantbird 16:49:46 <-- jb has quit (Ping timeout) 16:51:00 <-- nhnt11 has quit (Input/output error) 16:51:07 --> nhnt11 has joined #instantbird 16:51:39 --> clokep_work has joined #instantbird 16:51:39 * ChanServ sets mode +o clokep_work 16:53:17 --> jb has joined #instantbird 16:53:26 <-- qlum has quit (Quit: Getting the <censored> out.) 16:53:30 --> qlum has joined #instantbird 16:55:02 <-- nhnt11 has quit (Input/output error) 16:55:09 --> nhnt11 has joined #instantbird 16:55:10 <clokep_work> deOmega1: Windows Defender or whatever it is called. 16:55:26 <clokep_work> aleth: Yeah, i saw. Thanks. 16:55:26 <deOmega1> mse? 16:55:36 <clokep_work> I don't know what "mse" is. 16:55:42 <qheaden> Microsoft Security Essentials. 16:56:01 <clokep_work> http://en.wikipedia.org/wiki/Windows_Defender 16:57:01 <deOmega1> yeah that is it, that s MSE 16:57:31 <qheaden> clokep_work: Did the Skype GSoC project merge into the project to add new protocols? 16:58:38 * Mook_as is pretty sure Windows Defender != MSSE 16:58:54 <-- jb has quit (Ping timeout) 16:59:04 <-- nhnt11 has quit (Input/output error) 16:59:08 --> nhnt11 has joined #instantbird 16:59:49 <qheaden> Mook_as: It depends. From what I understand, Windows Defender took over for MSE starting with Windows 8. Before that, they are two different things. 17:01:12 <Mook_as> Huh, interesting. 17:01:17 <nhnt11> clokep_work: Did you take a look at the new patch? It should be good :) 17:01:31 <nhnt11> I'm going back to look at the handling of third person messages in notifications 17:01:35 <aleth> yay, patches :) 17:02:10 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 17:02:19 * nhnt11 likes the mercurial queue system so far 17:03:06 <-- nhnt11 has quit (Input/output error) 17:03:10 --> nhnt11 has joined #instantbird 17:05:12 <nhnt11> So now I need to find out how to work on two patches at once, separately 17:05:15 <nhnt11> Google :D 17:06:03 <aleth> nhnt11: that's what the queues are for? 17:06:23 <nhnt11> Yeah. But I still need to find out exactly how to use them 17:06:30 <UCC> yeah, you use mercurial queues 17:06:44 <nhnt11> When I tried blundering around in git, i ended up with a lot of rubbish 17:06:47 <UCC> https://developer.mozilla.org/en-US/docs/Mercurial_Queues 17:06:53 <UCC> this is a pretty neat explanation 17:06:54 <nhnt11> UCC I'm already there 17:07:08 <-- nhnt11 has quit (Input/output error) 17:07:12 --> nhnt11 has joined #instantbird 17:07:38 <qheaden> nhnt11: Basically, you just push/pop patches as needed to get to the one you want to work on. 17:07:42 <qheaden> Or just call hg qgoto 17:08:48 <nhnt11> If I'm currently working on patch1 and i want to rebase to patch2, 17:09:00 <nhnt11> $hg qpop && hg qpush patch2 17:09:03 <nhnt11> should suffice? 17:09:42 <qheaden> Is patch2 on top of patch 1? 17:09:52 <nhnt11> No they're independant 17:10:20 <qheaden> Yes, that should work. 17:11:10 <-- nhnt11 has quit (Input/output error) 17:11:15 --> nhnt11 has joined #instantbird 17:15:12 <-- nhnt11 has quit (Input/output error) 17:15:17 --> nhnt11 has joined #instantbird 17:19:14 <-- nhnt11 has quit (Input/output error) 17:19:19 --> nhnt11 has joined #instantbird 17:20:39 <-- gerard-majax__ has quit (Ping timeout) 17:22:54 --> jb has joined #instantbird 17:22:54 <-- jb has quit (Excess Flood) 17:22:59 --> jb has joined #instantbird 17:23:16 <-- nhnt11 has quit (Input/output error) 17:23:25 --> nhnt11 has joined #instantbird 17:27:18 <-- nhnt11 has quit (Input/output error) 17:27:21 --> Ain3 has joined #instantbird 17:27:28 --> nhnt11 has joined #instantbird 17:31:20 <-- nhnt11 has quit (Input/output error) 17:31:26 --> nhnt11 has joined #instantbird 17:32:53 --> mali has joined #instantbird 17:33:03 <-- mpmc has quit (Ping timeout) 17:35:22 <-- nhnt11 has quit (Input/output error) 17:36:00 --> nhnt11 has joined #instantbird 17:37:10 --> mpmc has joined #instantbird 17:38:59 --> Huvik has joined #instantbird 17:39:24 <-- nhnt11 has quit (Input/output error) 17:39:28 --> nhnt11 has joined #instantbird 17:39:42 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 17:40:11 <-- jb has quit (Ping timeout) 17:40:40 --> jb has joined #instantbird 17:42:37 <aleth> clokep_work: ReferenceError: reference to undefined property this._account.maxMessageLength Source file:.../twitter.js Line: 167 17:43:44 <-- aleth has quit (Quit: Ciao) 17:43:48 --> aleth has joined #instantbird 17:43:48 * ChanServ sets mode +h aleth 17:51:06 <clokep_work> aleth: File a bug. Looks like we missed a reference to it. 17:51:40 <clokep_work> nhnt11: You'll know when I look at your patch, I'll finish the review or ask a question. 17:51:43 <clokep_work> I'm _work right now. ;) 17:51:55 <aleth> Yeah, nothing major there. 17:52:08 <clokep_work> aleth: Even better if you give a patch. :) 17:54:16 <instantbot> New Core - Twitter bug 1948 filed by aleth@instantbird.org. 17:54:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1948 min, --, ---, nobody, NEW, Reference to undefined property this._account.maxMessageLength 17:57:24 <-- deOmega1 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 18:00:41 <clokep_work> qheaden: I'll get back to you in a few minutes, very busy right now. 18:00:58 <-- jb has quit (Ping timeout) 18:04:07 <-- mpmc has quit (Connection reset by peer) 18:05:32 <-- Huvik has quit (Connection reset by peer) 18:05:33 --> Huvik has joined #instantbird 18:06:32 <aleth> Huvik: You know that if you tell Instantbird your Nickserv password, it will identify for you? 18:06:51 <Huvik> . 18:07:24 <-- dew has quit (Ping timeout) 18:09:21 <Huvik> aleth: i tought i did it 18:09:53 <instantbot> clokep@gmail.com denied review for attachment 2407 on bug 1935. 18:09:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 18:09:56 <aleth> Huvik: Maybe you did, I just saw your manual login in the logs ;) 18:10:32 <aleth> (the IRC channel log, in case that wasn't clear) 18:12:04 --> nhnt11 has joined #instantbird 18:12:21 <Huvik> hmmm i have it set in my options 18:13:15 <aleth> Huvik: If you've put the password into the account options and you didn't get any Nickserv messages, it worked :) 18:13:24 --> jb has joined #instantbird 18:13:33 <Huvik> i didnt 18:13:47 <aleth> Great :) 18:14:12 <nhnt11> clokep_work: Oh no, the ++i :( 18:14:43 <-- nhnt11 has quit (Input/output error) 18:14:50 --> nhnt11 has joined #instantbird 18:14:56 <nhnt11> By the way, it's i++ in the other tests 18:15:12 <Ain3> i have a problem with my twitter connection on thunderbird and were told to ask here for a solution. is this the right place to ask ? 18:15:14 <nhnt11> Well apparently, SOME of the other tests 18:15:32 <aleth> Ain3: Yes 18:16:45 <-- jb has quit (Ping timeout) 18:17:17 <aleth> Ain3: You do have to tell us what the problem is though ;) 18:17:21 <Ain3> great. well my problem is that not every tweets in my imeline is displayed, some are just missing 18:17:28 <clokep_work> nhnt11: Than whoever reviewed those missed it, that doesn't mean we should continue doing it. 18:17:50 --> dew has joined #instantbird 18:17:53 <nhnt11> Okay. Shall I fix those as well in the same patch? 18:18:02 <aleth> Ain3: Are they missing or are they just older? 18:18:43 <Ain3> they are missing 18:18:45 <-- nhnt11 has quit (Input/output error) 18:19:06 <aleth> Ain3: So when you look at your timeline on twitter.com you see them? 18:19:19 <clokep_work> nhnt11: No. 18:19:19 <Ain3> yes 18:19:30 <aleth> Strange. 18:19:43 <aleth> Anything in the error console that looks twitter-related? 18:20:38 <aleth> Do the missing tweets have anything in common? 18:23:10 --> nhnt11 has joined #instantbird 18:25:36 <Ain3> i the error console i found this but i am not sure if thats the problem "live.mozillamessaging.com : server does not support RFC 5746, see CVE-2009-3555" 18:26:26 <Ain3> i didn't notice a connection betweet those tweets 18:26:55 <-- mconley has quit (Connection reset by peer) 18:27:00 <-- nhnt11 has quit (Input/output error) 18:27:40 --> nhnt11 has joined #instantbird 18:33:03 <-- nhnt11 has quit (Input/output error) 18:34:08 <aleth> No, that's not realted. 18:34:15 <aleth> *related 18:38:51 <Ain3> i guess this one is also net the right one "Zeitstempel: 24.04.2013 19:36:05 Fehler: formatURL: Couldn't find value for key: TIME_SESSION_RESTORED Quelldatei: resource:///components/nsURLFormatter.js Zeile: 134" 18:40:22 <aleth> No... 18:41:23 <aleth> The missing tweets, are they from people you follow? 18:42:30 <Ain3> yes and one was directed with @ at me 18:42:49 --> nhnt11 has joined #instantbird 18:43:07 <aleth> Ain3: This is the first case of that happening that we have been told about. 18:43:08 <aleth> Would you mind connecting to twitter with an Instantbird nightly to see if the problem occurs there too? We have new tools to help diagnose problems there that are not in FB yet. 18:43:53 <aleth> http://ftp.instantbird.com/instantbird/nightly/latest-trunk/ 18:44:45 <aleth> s/FB/Thunderbird 18:46:08 <Ain3> its worth a try but i didn't had this problem on a diffenernt plattform to view my tweets 18:46:22 --> flo-retina has joined #instantbird 18:46:23 * ChanServ sets mode +qo flo-retina flo-retina 18:46:32 <aleth> Ain3: When you say "platform" do you mean a different app? 18:46:52 <aleth> or a different OS? 18:47:10 <-- nhnt11 has quit (Input/output error) 18:47:34 <flo-retina> dmose just installed Instantbird. (Colloguy kept crashing ;)). 18:47:43 --> mconley has joined #instantbird 18:47:48 <flo-retina> something strange happened during his first IRC connection 18:48:11 * aleth types "yay" then deletes "yay" ;) 18:49:09 <Ain3> i am registered on a website and there i can also use my twitter account 18:49:40 <flo-retina> it seems he somehow clicked on "disconnect" in the account manager, and disconnecting the account popped up a nickserv tab 18:49:56 <aleth> Ain3: The problem is that so far we don't have much to go on to diagnose your problem. Generally we display everything we get from twitter. 18:50:01 <flo-retina> it's likely his password was actually wrong 18:50:13 <flo-retina> but he assumed the account was marked as "disconnected" because of the wrong password 18:50:35 <flo-retina> he then tried /nickserv identify password, and was surprised to have an error message saying the account wasn't connected :-S 18:50:40 <aleth> Ain3: The latest IB version allows you to give us a "debug log" where we may see something (in particular, everything we receive) 18:50:58 --> nhnt11 has joined #instantbird 18:51:39 <aleth> flo-retina: This sounds like the issue of messages still being in the "pipeline" while we are disconnecting? 18:51:50 <flo-retina> aleth: right 18:52:01 <flo-retina> it looks like we should clear the queue of pending messages when disconnecting 18:52:25 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 18:53:20 <aleth> flo-retina: A similar issue can also cause (rarely) tabs to pop up again after one has closed them. 18:53:29 --> Mic has joined #instantbird 18:53:29 * ChanServ sets mode +h Mic 18:53:42 <aleth> As if there are still messages coming in for a closed conversation, the conv gets reopened 18:56:16 <Ain3> i installed instabird and found one of the missing tweets there 18:56:42 <aleth> Ain3: Thanks 18:58:10 <aleth> If it should happen again and you notice something missing, open the account manager and select "copy debug log" from the account context menu. You can then show it to us (check first if it contains private info) 18:58:57 <-- mali has left #instantbird () 19:00:13 <Ain3> ok i ll do that, but what should i do if its only happening on thunderbird and not on instantbird? 19:00:42 --> mpmc has joined #instantbird 19:00:50 <aleth> Ain3: The fact that it doesn't happen in Instantbird would already be useful info. The code in TB is usually slightly behind. 19:01:14 <aleth> Ain3: What TB version are you on? 19:01:51 <Ain3> 17.0.5 19:02:46 <aleth> Ain3: OK, there's been a lot of bugfixes since then. (Nothing obviously related to missing messages though) 19:02:59 <flo-retina> btw, Dan was using 1.3 19:03:14 --> jb has joined #instantbird 19:03:23 <aleth> flo-retina: I don't think we have fixed anything related to that though 19:03:41 <flo-retina> aleth: I don't think either, but I may misremember :) 19:05:09 <Ain3> tb tells me i ve got the up to date version 19:05:28 <aleth> Ain3: It is the latest TB version, yes 19:06:46 <aleth> (unless you were using TB nightlies, but those are also behind IB, just not quite as much) 19:08:13 <Ain3> i guess i am using the normal tb never heard of tb nightlies before 19:08:36 <aleth> Ain3: That's fine, was just asking ;) 19:10:41 <Ain3> well i'll keep an eye on my timeline and will come again if i notice something 19:10:59 <aleth> Ain3: I think TB 24 will be the next TB release 19:11:04 <aleth> Ain3: Thanks! 19:11:17 <aleth> Hoepfully we can figure out the problem (or verify it's been fixed somehow) 19:11:59 --> wnayes has joined #instantbird 19:12:26 <Ain3> thanks and bye 19:15:08 <-- Ain3 has left #instantbird () 19:15:16 <flo-retina> bah, https://addons.instantbird.org/en-US/instantbird/addon/306 isn't compatible with current versions :( 19:28:27 <Mic> Do we have a way to get in touch with the author? 19:28:29 <-- UCC has quit (Ping timeout) 19:28:59 <Mic> I think I had seem someone with that nick in here before but that's been long ago... 19:29:53 <Mic> We don't need to to bump the compatibility but I'd like to ask him if he'd add an option to play sounds for every message in MUCs. This would obsolete one of my add-ons :) 19:29:58 <flo-retina> what's the author the guy who started working for RIM and contributing open source stuff even in his free time was forbidden by his employment contract? 19:30:22 <flo-retina> s/what's/was/ 19:32:17 <-- mpmc has quit (Client exited) 19:32:55 <-- jb has quit (Ping timeout) 19:41:50 <flo-retina> both dmose and Standard8 just mentioned they would really like if bug 837 was fixed ;). 19:41:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=837 nor, --, ---, nobody, NEW, Give new tabs opened via IRC commands focus 19:42:48 <-- mconley has quit (Connection reset by peer) 19:43:01 <clokep_work> Mic: He works for BlackBerry now and can't do open source work. 19:43:24 --> mconley has joined #instantbird 19:43:25 <clokep_work> flo-retina: Tell them that patches are accepted and to r? me. ;) 19:43:52 <aleth> flo-retina: There's even an almost complete WIP there as far as I recall ;) 19:44:05 <flo-retina> I don't think that would work 19:44:11 <flo-retina> people are really busy with talkilla ;) 19:44:17 --> mpmc has joined #instantbird 19:44:21 <clokep_work> flo-retina: Do they use Instantbird? 19:45:32 <flo-retina> clokep_work: kinda. I got dmose to install Instantbird about an hour ago because Colloguy was crashing and throwing modal "dialog". Standard8 uses Instantbird as IRC client on his Windows machine (that he hates), which he's using because his macbook is dead. 19:47:11 <clokep_work> Ah, I see. :) 19:47:16 <clokep_work> I'd like it fixed too though. 19:47:46 <-- Optimizer has quit (Ping timeout) 19:47:56 <-- Mic has quit (Quit: No time to waste, let's go!) 19:48:21 <aleth> Yes, it would be nice to fix that one. 19:48:37 --> Optimizer has joined #instantbird 19:48:38 --> Mic has joined #instantbird 19:48:39 * ChanServ sets mode +h Mic 19:49:02 <clokep_work> Maybe one of those GSoC students want to fix it? :P 19:49:36 <flo-retina> :-P 19:49:59 --> unghost has joined #instantbird 19:53:30 <flo-retina> btw, it's super confusing to hear Instantbird notification sounds, but that they are coming from other computers on the same table ;) 19:53:51 <clokep_work> Everytime I hear those I still cringe. :( 19:55:00 <Mic> The sounds are taken from Pidgin, aren't they? 19:55:09 <flo-retina> There are 3 computers on this table with Ib, 1 with Pidgin (boo) + terminal irc client/bouncer and 1 with likely Adium + IRC client 19:55:12 <flo-retina> Mic: yeah 19:55:35 <clokep_work> Pidgin + terminal IRC? That's really lame. :P 19:55:42 <flo-retina> Mic: dmose suggested that some people at https://ccrma.stanford.edu/ may be helpful to get correct sounds designed 19:56:01 <flo-retina> clokep_work: possibly why I didn't even comment ;) 19:57:41 <clokep_work> That WIP on bug 847 is...gross. 19:57:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=847 enh, --, ---, nobody, NEW, Suggesting displayname based on name of logged in user 19:57:51 <clokep_work> Uhhh...bug 837? 19:57:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=837 nor, --, ---, nobody, NEW, Give new tabs opened via IRC commands focus 19:59:11 <aleth> clokep_work: That's why it went nowhere ;) 20:00:15 <aleth> It's clearly not the right approach 20:00:48 <aleth> It's just unclear what is. 20:01:08 <clokep_work> The prpl shouldn't have the "right" to decide what tabs are focused. 20:01:51 <aleth> clokep_work: That's the basic issue. The whole thing should be done in the UI I think 20:02:28 <aleth> But that's not easy. 20:08:35 <clokep_work> Right. :( 20:11:09 --> mali has joined #instantbird 20:12:59 <-- qheaden has quit (Quit: Leaving) 20:14:01 <-- mali has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 20:26:16 <-- clokep_work has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 20:34:02 <Mook_as> something vaguely like how the window.open() blocker in firefox works? 20:37:03 <Mic> Very well from what I've seen! :P 20:37:30 <Mic> Opps, I completely misunderstoof that and tried to be funny. #fail ;) 20:37:38 <Mic> *stood 20:59:26 --> nhnt11 has joined #instantbird 21:08:42 --> UCC has joined #instantbird 21:09:02 <flo-retina> these sounds are really annoying, we should improve them :) 21:09:15 * flo-retina is hearing Mark's computer 21:11:38 <nhnt11> flo-retina: We need more notifications customisability 21:11:54 <flo-retina> no :-P 21:12:07 <flo-retina> well, I mean, not by default 21:12:09 <aleth> nhnt11: write an add-on :) 21:12:13 <nhnt11> Why not!? 21:12:21 <nhnt11> Some basic customisability 21:12:29 <nhnt11> Like, play sounds only if window not in focus :/ 21:12:58 <nhnt11> As a user, I wouldn't want to have to install an addon for something as obvious as that 21:16:26 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2408 on bug 1948. 21:16:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1948 min, --, ---, nobody, NEW, Reference to undefined property this._account.maxMessageLength 21:19:18 <aleth> nhnt11: It's true that our sound support is a bit underdeveloped (there aren't even many add-ons). Add-ons are just a good place to add lots of finegrained options before figuring out what is the best default 21:19:44 <aleth> Sometimes it turns out there are hooks missing in the core to even write the add-on, then that is a potential bug too. 21:20:19 <nhnt11> Okay. I need to learn how to write add-ons. Finding it a bit difficult to manage my workload right now.. semester finals next week :( 21:21:07 <nhnt11> Making sticky notes of to-do stuff :D 21:21:37 <aleth> nhnt11: If you really think something is so obviously wrong that it is a core bug, file the bug please :) 21:21:53 <nhnt11> Okay :) 21:22:05 <aleth> Our general philosophy is to prefer finding sane defaults to adding a million options in Preferences though. 21:22:15 <nhnt11> That's a good philosophy 21:22:24 <aleth> But our defaults may be wrong, or too minimal... 21:22:29 <nhnt11> But I find it incredibly annoying having a sound play every time I send/receive a message :P 21:22:39 <aleth> I have sounds turned off :P 21:22:54 <nhnt11> I did that a few minutes ago :P 21:23:08 <aleth> So I'm not the best judge of what sounds should be like... 21:25:30 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2409 on bug 1935. 21:25:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1935 min, --, ---, nhnt11, ASSI, Blackslash not handled correctly in CTCP messages. 21:26:09 <-- UCC has quit (Ping timeout) 21:26:22 <-- mconley has quit (Input/output error) 21:26:29 * nhnt11 hates when he misses out teeny things like trailing new lines/indentation/etc and has to submit another patch just for that 21:28:05 <aleth> It's more annoying if you notice yourself, about 10 seconds after submitting ;) 21:28:32 <-- aleth has quit (Quit: Ciao) 21:29:02 <nhnt11> Yeah :D 21:29:33 <nhnt11> is there no way to upload patch to bugzilla without opening a browser? 21:30:26 <Mook_as> https://wiki.mozilla.org/Bugzilla:REST_API ? (bugzilla.m.o only, pretty much) 21:31:28 <nhnt11> I should stop thinking aloud on IRC... bad habit :/ 21:31:54 <nhnt11> Mook_as: Thanks, reading.. 21:34:54 <-- Huvik has quit (Ping timeout) 21:35:21 <nhnt11> This seems nice! http://www.liquidx.net/pybugz/ 21:35:26 <nhnt11> Python client 21:46:15 <-- nhnt11 has quit (Input/output error) 21:47:02 --> nhnt11 has joined #instantbird 21:47:24 <-- unghost has quit (Ping timeout) 21:50:51 --> Kaishi has joined #instantbird 21:52:09 <-- Kaishi has quit (Quit: Kaishi) 21:53:49 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 21:54:26 --> nhnt11 has joined #instantbird 21:56:03 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 21:56:41 --> nhnt11 has joined #instantbird 21:59:32 <-- nhnt11 has quit (Input/output error) 22:00:12 --> nhnt11 has joined #instantbird 22:09:18 <-- Mic has quit (Quit: No time to waste, let's go!) 22:15:32 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 22:16:06 --> nhnt11 has joined #instantbird 22:17:50 --> jb has joined #instantbird 22:18:31 <-- qlum has quit (Quit: Getting the <censored> out.) 22:19:24 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 22:19:44 --> nhnt11 has joined #instantbird 22:29:12 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2410 on bug 1845. 22:29:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1845 min, --, ---, nobody, NEW, Message notifications do not take /me into account 22:34:35 <instantbot> nhnt11@gmail.com requested review from clokep@gmail.com for attachment 2411 on bug 1845. 22:34:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1845 min, --, ---, nobody, NEW, Message notifications do not take /me into account 22:43:44 --> clokep has joined #instantbird 22:43:44 * ChanServ sets mode +o clokep 22:46:51 * clokep laughs at his screenshot in https://bugzilla.instantbird.org/attachment.cgi?id=2150 22:48:01 --> Kaishi has joined #instantbird 22:48:05 <Mook_as> hmm, geany? 22:48:06 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 22:49:08 <instantbot> clokep@gmail.com granted review for attachment 2408 on bug 1948. 22:49:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1948 min, --, ---, nobody, NEW, Reference to undefined property this._account.maxMessageLength 22:53:34 * clokep needs to go. 22:53:46 <clokep> aleth: Feel free to steal bug 1845. 22:53:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1845 min, --, ---, nobody, NEW, Message notifications do not take /me into account 22:54:02 --> nhnt11 has joined #instantbird 22:55:12 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 22:55:41 --> nhnt11 has joined #instantbird 22:58:03 <-- clokep has quit (Ping timeout) 23:42:15 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)