#instantbird log on 04 18 2013

All times are UTC.

00:01:24 <-- nhnt11 has quit (Input/output error)
00:02:12 --> nhnt11 has joined #instantbird
00:03:06 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
00:07:28 --> clokep_work has joined #instantbird
00:07:28 * ChanServ sets mode +o clokep_work 
00:09:01 <clokep_work> Mook_as: Hey so if I get Instantbird to go into the debugger...how can I get a JS Stack? https://developer.mozilla.org/en-US/docs/Debugging_Mozilla_on_Windows_FAQ#Debugging_JavaScript says something about a "QuickWatch" window
00:09:11 <clokep_work> But needing to be in a js_interpret stackframe?
00:09:13 <clokep_work> :-S
00:11:26 <clokep_work> Apparently right clicking gives me the option.
00:11:30 <Mook_as> you're in a C++ debugger?
00:11:32 * instantbot mumbles something about c++ being evil
00:13:38 <clokep_work> Mook_as: Yes.
00:13:54 <clokep_work> Mook_as: Pretty much I want to get everything possible out of this and post it in the bug for florian.
00:13:57 <clokep_work> Can you give any insight?
00:14:13 <clokep_work> I think I just got a JS stack? But I'm usnure it's the right one...I see lots of js::interprets in thecall stack
00:14:46 <clokep_work> Should I use the top most one?
00:14:56 <Mook_as> you want to use {,,xul}DumpJSStack()
00:15:49 <clokep_work> does http://pastebin.instantbird.com/177267 look like the right thing?
00:16:17 <Mook_as> yep, that looks reasonable
00:16:57 <clokep_work> OK
00:17:18 <clokep_work> Is there a way to export the C++ stack or is that not useful?
00:17:33 <Mook_as> select everything with your mouse, hit Ctrl+C
00:17:53 <Mook_as> (it tends to be not useful if you have JS at the top, of course; if there's C++ crashing or whatever, it can be useful)
00:18:14 <clokep_work> It's crashing in C++ called from JS.
00:18:24 <Mook_as> then it might be useful :)
00:18:48 <clokep_work> OK.
00:19:00 <clokep_work> Anything else reasonable?
00:19:06 <clokep_work> Is there a way to get the content of the JS obejcts.
00:19:18 <Mook_as> I've never figured out a useful way to do so, unfortunately
00:21:02 <clokep_work> I also find it weird that the last line of that stack seems to cutoff, any idea what's w/ that?
00:21:33 <Mook_as> huh, no idea
00:26:20 --> clokep has joined #instantbird
00:26:20 * ChanServ sets mode +o clokep 
00:26:25 <-- clokep_work has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
00:26:59 <clokep> Mook_as: Thanks for the help. :)
00:27:04 <clokep> Hopefully flo-retina will have some ideas.
00:52:27 <-- linuxis has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
00:54:19 <instant-buildbot> build #388 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/388
01:01:44 --> harlock has joined #instantbird
01:12:55 <-- Mook_as has quit (Quit: Mook_as)
01:19:27 --> qheaden has joined #instantbird
01:20:31 <qheaden> clokep: I got your email. I have a question about the purple interface.
01:21:30 <qheaden> clokep: Are you suggesting that I can inherit and override the functionality provided by the C++ implementation of the prpll interface definitions?
01:21:56 <clokep> qheaden: Not at all.
01:22:04 <clokep> prpl != purple
01:22:18 <clokep> purple* means it's for libpurple, e.g. Pidgin's protocol implementation.
01:22:29 <clokep> prpl is "protocol plug-in" and our interfaces that all protocols implement.
01:22:43 <clokep> qheaden: So, you need to implement the prplI interfaces in C++, yes.
01:22:44 <qheaden> Ahh okay.
01:22:49 <qheaden> I got ya.
01:23:38 <qheaden> clokep: It seems that the prplI interfaces match up pretty well with the SkypeKit objects.
01:24:42 <clokep> qheaden: Yes, they do, IIRC.
01:25:44 <qheaden> clokep: So once a plugin implements the prpl interfaces, what must it do to register as a usable protocol in Instantbird?
01:26:48 <-- harlock has left #instantbird (QUIT :Baibai)
01:27:14 <clokep> qheaden: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.manifest
01:27:27 <clokep> Register into the im-protocol-plugin category.
01:27:59 <qheaden> Oh okay. Very nice. I've dealt with manifest files while adding features to Firefox.
01:29:06 <qheaden> clokep: Final question. SkypeKit isn't open source. So will we have to link it in any special way to comply with the open source license?
01:29:34 <clokep> qheaden: It will be an extension.
01:29:43 <qheaden> Ok/
01:30:08 <clokep> And our code will be MPL licensed, which can exist with non-open source code.
01:30:32 <qheaden> Okay. That sounds great.
01:32:00 <clokep> Sure thing.
01:32:29 <clokep> Anything else?
01:33:07 <dew> it's happening!
01:36:36 <-- mali has quit (Ping timeout)
01:37:26 <EionRobb> well, except that the skypekit license says it can't be used with any open-source software ;)
01:44:51 <qheaden> clokep: Nothing else. Thanks
01:57:22 <-- qheaden has quit (Quit: Leaving)
02:23:26 <clokep> EionRobb: But in other places it says it can.
02:23:40 <EionRobb> oh?  which places does it say it can?
02:23:44 <clokep> And there /are/ projects using it.
02:23:56 <EionRobb> which projects are using it?
02:24:06 <clokep> There are a bunch of projects on github using it.
02:24:09 <clokep> I don't know what exactly.
02:24:57 <clokep> EionRobb: It says "you shall not use any such Open Source Software in any way, which may cause the SkypeKit, or any part thereof to be subject to any applicable Open Source Software licenses" which to me means "you can't use GPL".
02:25:13 <EionRobb> they define what 'open source software' means earlier on
02:32:34 <clokep> Yes.
02:32:36 <clokep> I know.
02:32:52 <clokep> EionRobb: "Open Source Software: any software distributed under an "open source" license (including but not limited to software that is distributed under the GNU General Public License, GNU Lesser/Library General Public License, or other open source licenses identified on www.opensource.org);"
02:32:57 <clokep> I don't see how that changes anything though.
02:53:52 <EionRobb> 10.1.5. No portion of the SkypeKit Product contains or shall contain any Open Source Software or any other software that could interfere with or compromise Skype's Intellectual Property Rights in the SkypeKit or which may require you or Skype to disclose any source code included in the SkypeKit.
02:55:06 <clokep> Yes, that directly contradicts the part of the license I quoted.
02:55:14 * clokep is having deja vu.
02:57:02 <EionRobb> so when thunderbird is running with a skypekit plugin loaded, it can't be opensource... but it is opensource so it isn't allowed to load the skypekit plugin
02:57:59 <clokep> That's not how I read it.
02:58:15 <EionRobb> how do you read it?
02:59:18 <clokep> That they're concerned someone is going to link it to a GPL binary and somehow that will force them to give up the SkypeKit source code.
03:00:13 <instant-buildbot> build #844 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/844
03:00:20 <EionRobb> its not just GPL though, it includes MPL2 and Apache2 (among others)
03:01:10 <EionRobb> IMO the only way to be completely respecting the licenses of everyone is to reverse-engineer the TCP protocol used between the skypekit sdk client and the skypekit runtime
03:03:47 <clokep> But MPL2 isn't a problem, it wouldn't force anyone's intellectual property to be given up because it's a file level license.
03:04:02 <clokep> The goal of their license is clearly to avoid GPL and GPL-like licenses.
03:04:09 <clokep> That reuqire the "larger work" be GPL-ified.
03:04:15 <clokep> (Which is why the GPL is an awful license, by the way.)
03:04:20 <clokep> It greatly stifles what you can do.
03:05:08 * clokep needs to go to bed.
03:06:28 <EionRobb> whether or not MPL2 does or doesn't isn't the point.  they say any license on opensource.org which is apache, bsd 2/3 caluse, gpl, lgpl, mit, mpl2, cddl, eclipse ... the intent of the license might be one thing but the legal terms are another :)
03:08:39 <clokep> But the part I quote clearly says you can use "Open Source Software" as long as you comply with the terms and using it doesn't subject any part of SkypeKit to the Open Source Software license, i.e. MPL2 is OK.
03:10:37 <EionRobb> the two clauses aren't exclusive, one says you can't use it to make skypekit open source, the other says you can't use it in an open source product
03:22:01 <-- clokep has quit (Ping timeout)
03:30:45 --> Mook has joined #instantbird
03:31:27 <-- MMN-o has quit (Ping timeout)
03:35:55 --> MMN-o has joined #instantbird
03:41:23 <instant-buildbot> build #840 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/840
03:55:17 <-- nhnt11 has quit (Ping timeout)
03:58:45 --> nhnt11 has joined #instantbird
04:17:48 --> Optimizer has joined #instantbird
04:25:02 <-- Optimizer has quit (Ping timeout)
04:28:26 --> Optimizer has joined #instantbird
04:53:03 <-- Optimizer has quit (Ping timeout)
04:56:36 --> Optimizer has joined #instantbird
05:33:16 <instant-buildbot> build #937 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/937
05:33:17 <-- nhnt11 has left #instantbird ()
05:41:32 --> mpmc has joined #instantbird
05:54:51 --> nhnt11 has joined #instantbird
06:05:19 <-- mconley has quit (Connection reset by peer)
06:05:44 --> mconley has joined #instantbird
06:10:27 <-- EionRobb has quit (Quit: Leaving.)
06:15:01 --> atuljangra has joined #instantbird
06:15:20 <atuljangra> !seen clokep_work
06:15:21 <instantbot> clokep_work was last seen 5 hours, 54 minutes and 18 seconds ago, saying 'I also find it weird that the last line of that stack seems to cutoff, any idea what's w/ that?' in #instantbird.
06:16:22 <-- atuljangra has quit (Quit: http://www.mibbit.com ajax IRC Client)
06:20:37 <-- Optimizer has quit (Ping timeout)
06:22:03 --> Optimizer has joined #instantbird
06:27:57 --> deltafalcon has joined #instantbird
06:45:32 <-- deltafalcon has quit (Connection reset by peer)
07:08:18 --> EionRobb has joined #instantbird
07:14:33 <-- EionRobb has quit (Ping timeout)
07:16:19 <-- Optimizer has quit (Ping timeout)
07:16:33 --> EionRobb has joined #instantbird
07:17:55 --> Optimizer has joined #instantbird
07:20:09 <-- EionRobb has quit (Ping timeout)
07:25:51 --> EionRobb has joined #instantbird
07:26:52 <-- flo-retina has quit (Ping timeout)
07:27:10 <-- Mook has quit (Quit: Mook)
07:27:13 <-- nhnt11 has quit (Input/output error)
07:27:19 --> nhnt11 has joined #instantbird
07:27:37 --> flo-retina has joined #instantbird
07:27:37 * ChanServ sets mode +qo flo-retina flo-retina 
07:28:30 <-- EionRobb has quit (Ping timeout)
07:29:43 --> jb has joined #instantbird
07:29:45 --> EionRobb has joined #instantbird
07:32:28 <-- EionRobb has quit (Ping timeout)
07:33:10 --> EionRobb has joined #instantbird
07:36:46 --> Mic has joined #instantbird
07:36:46 * ChanServ sets mode +h Mic 
07:37:23 <Mic> Hi
07:38:07 <Mic> clokep: maybe get some help to figure out the license situation with SkypeKit?
07:38:52 <-- EionRobb has quit (Ping timeout)
07:39:57 --> EionRobb has joined #instantbird
07:40:56 --> deltafalcon has joined #instantbird
07:44:33 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
07:45:27 <Mic> Hasn't Gerv to do with licensing things? Maybe he could help?
07:49:03 <-- EionRobb has quit (Ping timeout)
07:51:45 <nhnt11> Mic, clokep: Adium has a page regarding Skype support: https://trac.adium.im/wiki/SkypeInAdium
07:52:18 --> EionRobb has joined #instantbird
07:52:20 <nhnt11> They seem to have arrived at the same conclusion
07:52:35 <nhnt11> "The SkypeKit SDK is not licensed to be used in any open-source software"
07:53:06 <Mic> Do I have to log in to see the Skypekit license? :(
07:53:54 <nhnt11> Mic: not a clue
07:54:55 <flo-retina> Mic: likely
07:57:38 <flo-retina> so I think the problem is this sentence "No portion of the SkypeKit Product contains or shall contain any Open Source Software" quoted by EionRobb. Do we have the definition of "the SkypeKit Product"? Is it their stuff that they distribute, or is it what people build with it?
07:58:31 <-- EionRobb has quit (Ping timeout)
07:59:10 <nhnt11> flo-retina: Why not send Skype an e-mail? We would get a certain answer eventually.
07:59:50 <flo-retina> nhnt11: If we need external help, I would prefer emailing Mozilla's licensing team ;)
07:59:51 --> EionRobb has joined #instantbird
08:00:09 <nhnt11> :D
08:05:00 <-- EionRobb has quit (Ping timeout)
08:06:29 --> EionRobb has joined #instantbird
08:06:34 <-- nhnt11 has quit (Input/output error)
08:06:56 --> nhnt11 has joined #instantbird
08:07:06 <EionRobb> did you want to see a copy of the license so you can see all the definitions?
08:10:35 <-- Optimizer has quit (Ping timeout)
08:11:34 <-- nhnt11 has quit (Input/output error)
08:11:39 --> nhnt11 has joined #instantbird
08:15:40 <flo-retina> EionRobb: I think I had one at some point. 
08:16:15 <-- nhnt11 has quit (Input/output error)
08:16:43 --> nhnt11 has joined #instantbird
08:21:34 <-- nhnt11 has quit (Input/output error)
08:22:02 --> nhnt11 has joined #instantbird
08:24:52 <-- nhnt11 has quit (Input/output error)
08:24:55 --> nhnt11 has joined #instantbird
08:31:25 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
08:31:31 <-- nhnt11 has quit (Input/output error)
08:31:36 --> nhnt11 has joined #instantbird
08:32:01 <EionRobb> just in case: http://eion.robbmob.com/SkypeKit%20License%20Agreement.htm 
08:35:44 <-- EionRobb has quit (Ping timeout)
08:38:59 --> EionRobb has joined #instantbird
08:43:45 <-- EionRobb has quit (Ping timeout)
08:45:29 --> EionRobb has joined #instantbird
08:48:48 <-- nhnt11 has quit (Input/output error)
08:48:53 --> nhnt11 has joined #instantbird
08:51:46 <Mic> flo: "SkypeKit Product: any Product developed by or for you which incorporates, embeds or uses the SkypeKit [...]"
08:53:55 <-- nhnt11 has quit (Input/output error)
08:54:08 --> nhnt11 has joined #instantbird
08:58:29 <-- nhnt11 has quit (Input/output error)
08:58:33 --> nhnt11 has joined #instantbird
08:59:00 <Mic> EionRobb: thanks!
09:02:35 <-- nhnt11 has quit (Input/output error)
09:02:40 --> nhnt11 has joined #instantbird
09:10:53 <-- nhnt11 has quit (Input/output error)
09:10:56 --> nhnt11 has joined #instantbird
09:12:17 --> flo-retina has joined #instantbird
09:12:17 * ChanServ sets mode +qo flo-retina flo-retina 
09:15:53 <-- nhnt11 has quit (Input/output error)
09:16:20 --> nhnt11 has joined #instantbird
09:20:54 <-- nhnt11 has quit (Input/output error)
09:21:10 --> nhnt11 has joined #instantbird
09:21:39 --> gerard-majax_ has joined #instantbird
09:21:46 <flo-retina> EionRobb: so it says:
09:21:47 <flo-retina> "5.3. If your SkypeKit Product includes any Open Source Software, you shall comply with all terms applicable to the use of such Open Source Software and you shall not use any such Open Source Software in any way, which may cause the SkypeKit, or any part thereof to be subject to any applicable Open Source Software licenses."
09:21:47 <flo-retina> and
09:21:47 <flo-retina> "10.1.5. No portion of the SkypeKit Product contains or shall contain any Open Source Software or any other software that could interfere with or compromise Skype's Intellectual Property Rights in the SkypeKit or which may require you or Skype to disclose any source code included in the SkypeKit."
09:22:01 --> Optimizer has joined #instantbird
09:23:15 <flo-retina> I think 5.3 is clear enough that 10.1.5 can only reasonably be read as "(any Open Source Software or any other software) that could interfere" and not as "any Open Source Software or (any other software that could interfere)"
09:23:49 <flo-retina> may still be nice to have a lawyer's opinion on it :-S.
09:24:52 <EionRobb> yeah :)
09:25:07 <EionRobb> we can argue about it until the cows come home, but none of us are lawyers :)
09:27:13 <flo-retina> arguing about it until the code compiles seems more reasonable ;)
09:27:52 <flo-retina> btw, clokep, thanks for the additional info about that crasher. Seems very useful! :)
09:28:14 <flo-retina> I wouldn't have suspected that a crash in libpurple could be caused by JS-XMPP :).
09:28:40 --> aleth has joined #instantbird
09:28:40 * ChanServ sets mode +h aleth 
09:28:44 <EionRobb> wow, weird :)
09:29:08 <flo-retina> I looked briefly this morning before breakfast. Seems there are at least 2 things that are wrong. One in either JS-XMPP or imAccounts.js, and one in imContacts.js
09:32:59 <-- nhnt11 has quit (Input/output error)
09:33:04 --> nhnt11 has joined #instantbird
09:42:06 <-- jb has quit (Quit: jb)
09:43:04 <-- nhnt11 has quit (Input/output error)
09:43:09 --> nhnt11 has joined #instantbird
09:47:22 <-- Tonnes has quit (Quit: ChatZilla 0.9.90 [Firefox 20.0.1/20130409194949])
09:49:42 --> jb has joined #instantbird
09:54:10 <aleth> https://bugzilla.mozilla.org/show_bug.cgi?id=845546#c38 is odd, I would have thought for b2g having to fetch UI from a server would be even worse.
09:54:59 <flo-retina> I'm not sure about that part. B2G is all about web apps. If they fetch it as a webapp, it will be fetched only once and cached.
09:56:26 <aleth> Isn't that only if you choose to install a webapp? But it sounds plausible.
09:56:47 <flo-retina> not sure. I'm always confused by web apps :)
09:56:56 <flo-retina> I tend to still see them kinda like a bookmark with a nice icon
09:57:06 <aleth> Me too ;)
09:57:07 <flo-retina> but it seems some of them are closer to add-ons
09:57:24 <-- Optimizer has quit (Ping timeout)
09:57:59 <aleth> If they are given privileges beyond content by the user, that's what would happen.
09:58:39 <-- nhnt11 has quit (Input/output error)
09:58:45 --> nhnt11 has joined #instantbird
09:59:11 <flo-retina> they have additional permissions, and can be cached for offline use
10:00:48 --> Optimizer has joined #instantbird
10:08:33 <-- Optimizer has quit (Ping timeout)
10:11:48 --> Optimizer has joined #instantbird
10:16:04 <-- nhnt11 has quit (Input/output error)
10:16:43 --> nhnt11 has joined #instantbird
10:17:29 --> clokep has joined #instantbird
10:17:29 * ChanServ sets mode +o clokep 
10:20:18 <clokep> flo-retina: The stack trace confused me a lot! I wasn't sure how a purplexpcom crash could be caused by a JS account, I thought I had done something wrong. :(
10:20:50 <flo-retina> clokep: I'm pretty sure the stack is right
10:21:04 <flo-retina> it's just strange that the bottom of the stack is cut
10:23:01 <clokep> I know. :-/
10:23:09 <clokep> I tried the command a bunch of times too.
10:23:13 <clokep> Always the same.
10:23:17 <flo-retina> thinking about it again, I still don't know how that crashes
10:24:24 <flo-retina> My assumption was that the test at http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccountBuddy.cpp#276 wouldn't save us because the purpleAccountBuddy had already been freed and mPurpleBuddy contained a random value.
10:25:06 <flo-retina> but the bug seems to be that JS code keeps a reference to that purpleAccountBuddy longer than it should. If a reference is kept, it's not possible that mPurpleBuddy is random though :-S.
10:25:33 <flo-retina> so there may be a bug in purplexpcom too :)
10:25:41 <clokep> The fields on the purpleAccountBuddy were totally empty IIRC.
10:25:57 <flo-retina> have you looked at the value of mPurpleBuddy ?
10:26:19 <clokep> I think it would let me?
10:26:23 <flo-retina> if it was null we wouldn't have called purple_buddy_get_alias
10:26:26 <clokep> wouldn't
10:26:57 <flo-retina> if you go to the purple_buddy_get_alias stack frame and look at the value of the parameter, that should work
10:28:25 <clokep> Let me open this in my debug build...
10:28:36 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
10:29:57 --> clokep has joined #instantbird
10:29:57 * ChanServ sets mode +o clokep 
10:30:23 --> clokep_js has joined #instantbird
10:31:51 <clokep> Here's to hoping I crash?
10:32:04 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
10:32:47 <clokep_js> flo-retina: That stack frame doesn't exist.
10:33:04 <clokep_js> >	purplexpcom.dll!purpleAccountBuddy::GetDisplayName(nsACString & aDisplayName)  Line 278 + 0x13 bytes	C++ is the highest one in purplexpcom
10:33:05 <instantbot> c++ is e-- ah, nevermind.
10:33:32 <flo-retina> ah
10:33:41 <clokep_js> mPurpleBuddy has a pointer, but all it's values are "bad pointer"
10:33:43 <flo-retina> so we crash after returning from that function
10:35:02 <flo-retina> ok, so we can likely assume that mPurpleBuddy hasn't been cleared when the buddy has been free'd
10:35:36 <flo-retina> which means http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleAccountBuddy.cpp#62 has never been called
10:36:34 <flo-retina> http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleInitContacts.cpp#89 should be calling it though
10:37:00 --> mali has joined #instantbird
10:39:54 <-- Mic has quit (Quit: No time to waste, let's go!)
10:41:09 <clokep_js> OK
10:41:19 <clokep_js> Is there more information I can get from here? :)
10:44:02 <flo-retina> not sure
10:44:12 <flo-retina> is this a bug you can reproduce with a test profile?
10:45:07 <-- EionRobb has quit (Quit: Leaving.)
10:45:18 <clokep_js> flo-retina: No. :(
10:45:33 <clokep_js> Luckily it doesn't seem to destroy my profile either. ;)
10:45:42 <flo-retina> :)
10:46:02 <flo-retina> it involves a JS-XMPP buddy and a libpurple buddy grouped in the same contact
10:50:16 <clokep_js> Ah-ha.
10:51:22 <flo-retina> disconnecting by hand either of the accounts before shutdown is likely to avoid the crash
10:52:14 <flo-retina> I think the next step it to create a clean profile and to add lots of debug logging to shutdown to check that things are happening in the order we expect
10:52:21 <flo-retina> I'll likely do that tonight if you don't beat me to it
10:58:22 <-- nhnt11 has quit (Input/output error)
10:58:28 --> nhnt11 has joined #instantbird
11:04:46 <-- clokep_js has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
11:46:05 --> clokep_work has joined #instantbird
11:46:05 * ChanServ sets mode +o clokep_work 
11:47:06 <clokep_work> flo-retina: Btw I agree with http://log.bezut.info/instantbird/130418/#m215 and that's how I always read it.
11:47:12 <-- aleth has quit (Quit: Ciao)
11:47:14 --> aleth has joined #instantbird
11:47:14 * ChanServ sets mode +h aleth 
11:51:25 <clokep_work> aleth: Btw thanks for the feedback on bug 1370. I ran out of time last night to put up a new version though. :(
11:51:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1370 tri, --, ---, clokep, ASSI, Avoid flashing the wrong case when double clicking on a participant with JS-IRC
11:51:35 <clokep_work> I went through and tried to find everywhere we should use "normalizeName" though.
11:52:03 <aleth> clokep_work: Not much left to do there :) It will be good to have the normalize* bugs gone.
11:52:29 <aleth> Well, one of them at least ;)
11:54:59 <clokep_work> I'll enjoy closing a bug that's been assigned to me for like a year. :P
11:55:17 <clokep_work> Who is the unnamed on https://etherpad.mozilla.org/ib-1-4-release-notes?
11:56:00 <aleth> Actually I suspect bug 1454 should be doable now too :)
11:56:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1454 nor, --, ---, clokep, ASSI, normalizedName for JS-IRC is wrong
11:56:54 <aleth> Did we really change IRC auth for 1.4?
11:58:28 <clokep_work> aleth: IIRC it was right after 1.3.
11:58:52 <clokep_work> aleth: bug 1811, at least
11:58:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1811 nor, --, 1.4, clokep, RESO FIXED, IRC password does not work with ZNC server password auth
11:59:05 <aleth> Ah, for bouncers.
12:01:52 <clokep_work> Yes
12:16:34 <clokep_work> aleth: Also bug 1766.
12:16:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, 1.4, aleth, RESO FIXED, Automatically authenticate when changing the nick to the account nickname
12:18:50 --> chomovva has joined #instantbird
12:19:05 <-- chomovva has left #instantbird ()
12:31:03 <-- Optimizer has quit (Ping timeout)
12:31:28 --> Optimizer has joined #instantbird
12:37:57 <-- Optimizer has quit (Ping timeout)
12:41:13 --> Optimizer has joined #instantbird
12:42:36 <instantbot> New Instantbird (UI) bug 1936 filed by aleth@instantbird.org.
12:42:37 <instantbot> aleth@instantbird.org requested feedback from clokep@gmail.com for attachment 2382 on bug 1936.
12:42:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1936 enh, --, ---, nobody, NEW, Use logical weeks for "this/last week" groups in log viewer
12:44:32 <-- jb has quit (Quit: jb)
12:45:28 <-- nhnt11 has quit (Input/output error)
12:45:34 --> nhnt11 has joined #instantbird
12:47:52 <clokep_work> aleth: You realize that gets into l10n issues, right?
12:47:58 --> jb has joined #instantbird
12:47:58 <clokep_work> Whether weeks start on Mondays or Sundays. :)
12:48:42 <aleth> clokep_work: That's why I asked for feedback... I wonder if "weeks" in general are l10n specific (ie whether some l10ns will want to translate with "7 days")
12:49:05 <aleth> I have no idea how/if this is handled anywhere
12:51:47 <flo-retina> aleth: http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/global/datetimepicker.dtd#7
12:54:28 <aleth> flo-retina: Thanks :)
12:54:34 <flo-retina> np
12:54:36 <aleth> And https://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/datetimepicker.xml seems to consider "weeks" a universal.
12:56:11 <flo-retina> aleth: http://en.wikipedia.org/wiki/Week#.22Weeks.22_in_other_calendars
12:57:10 <aleth> flo-retina: Right, what I meant was that "mozilla doesn't seem to take account of that" ;)
12:57:55 <aleth> Though a Rrevolutionary France l10n might be fun ;)
12:58:54 <-- mconley has quit (Input/output error)
12:59:55 <flo-retina> there were interesting ideas in that calendar :-D
13:00:25 <aleth> Completely decimal, right?
13:00:32 <flo-retina> likely
13:00:49 <flo-retina> I don't know the details (haven't read the full wikipedia article :-P)
13:01:22 <aleth> I'm glad we don't have to implement 'The Pawukon is a 210-day calendar consisting of 10 different concurrent weeks of 1, 2, 3, 4, 5, 6, 7, 8, 9, and 10 days'. :D
13:01:45 <flo-retina> it seems there were 12 months :-S
13:03:30 <aleth> That's a bit disappointing. Though I suppose it's just 365 divided by 30.
13:04:00 <aleth> Should have changed the planetary orbit too ;)
13:04:08 <-- mali has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
13:04:36 <flo-retina> aleth: well, at least the metric system was kept ;)
13:04:40 --> mali has joined #instantbird
13:05:03 <aleth> flo-retina: Thankfully :)
13:22:44 <-- Optimizer has quit (Ping timeout)
13:24:17 <-- nhnt11 has quit (Input/output error)
13:24:22 --> nhnt11 has joined #instantbird
13:26:08 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
13:33:51 --> mconley has joined #instantbird
13:37:54 <-- nhnt11 has quit (Input/output error)
13:38:05 --> nhnt11 has joined #instantbird
13:42:11 <instantbot> aleth@instantbird.org cancelled feedback?(clokep@gmail.com) for attachment 2382 on bug 1936.
13:42:12 <instantbot> aleth@instantbird.org requested feedback from clokep@gmail.com for attachment 2383 on bug 1936.
13:42:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1936 enh, --, ---, aleth, ASSI, Use logical weeks for "this/last week" groups in log viewer
13:44:43 <-- nhnt11 has quit (Input/output error)
13:44:49 --> nhnt11 has joined #instantbird
13:48:54 <-- nhnt11 has quit (Input/output error)
13:48:58 --> nhnt11 has joined #instantbird
13:53:43 <-- nhnt11 has quit (Input/output error)
13:54:04 --> nhnt11 has joined #instantbird
13:57:44 <-- nhnt11 has quit (Input/output error)
13:57:49 --> flo-retina has joined #instantbird
13:57:49 * ChanServ sets mode +qo flo-retina flo-retina 
14:00:22 <-- flo-retina has quit (Ping timeout)
14:00:29 --> nhnt11 has joined #instantbird
14:03:47 <-- nhnt11 has quit (Input/output error)
14:04:15 --> nhnt11 has joined #instantbird
14:04:31 * clokep_work wishes Windows supported symlinks.
14:06:06 <aleth> Doesn't it have something similar?
14:06:36 * aleth seems to remember a makelink command or something like that?
14:06:45 <clokep_work> It supports hardlinks, I think.
14:06:59 --> Optimizer has joined #instantbird
14:07:50 <aleth> clokep_work: Ah, this is what I remembered http://www.howtogeek.com/howto/windows-vista/using-symlinks-in-windows-vista/
14:08:26 <aleth> Not quite the same thing I guess.
14:08:29 <-- nhnt11 has quit (Input/output error)
14:08:54 --> nhnt11 has joined #instantbird
14:14:13 <-- nhnt11 has quit (Input/output error)
14:14:49 --> nhnt11 has joined #instantbird
14:19:02 <-- nhnt11 has quit (Input/output error)
14:19:28 --> nhnt11 has joined #instantbird
14:21:24 <-- nhnt11 has left #instantbird ()
14:22:25 <-- Optimizer has quit (Ping timeout)
14:25:39 --> Optimizer has joined #instantbird
14:29:19 <aleth> Something is wrong here :-S https://i.minus.com/jTDlJY3n8I3MT.png
14:31:06 <clokep_work> Weird.
14:31:18 <aleth> Is this a moz20 thing?
14:31:26 <aleth> Can you reproduce?
14:31:42 <clokep_work> aleth: Yes. Only in a pm
14:31:55 <clokep_work> aleth: Only in IRC.
14:31:57 <aleth> I don't get the bug in moz19.
14:32:06 <aleth> clokep_work: I do get it for libpurple XMPP
14:32:16 <clokep_work> aleth: Only for the message you sent me.
14:32:19 <clokep_work> I can't reproduce anymore.
14:32:39 <aleth> How strange
14:32:59 <aleth> I can reproduce everywhere now (even in this MUC)
14:33:38 <aleth> And... now I can't. Something has reset the context menu?
14:34:26 <clokep_work> aleth: I can reproduce after clicking a link.
14:35:57 <aleth> clokep_work: Bah, now I'm getting the "Select All" context menu on links :(
14:36:16 <aleth> (well, everywhere)
14:37:25 * aleth wonders if that is a regression from http://hg.instantbird.org/instantbird/rev/2a5fcd49ace0
14:37:46 <aleth> Shouldn't really be related though.
14:37:58 <clokep_work> aleth: Try a nightly before that?
14:39:12 <aleth> It's not that.
14:39:40 <aleth> Even better: https://i.minus.com/jbnd8d6hcS9Tun.png
14:39:51 <-- aleth has quit (Quit: Ciao)
14:40:01 --> aleth has joined #instantbird
14:40:01 * ChanServ sets mode +h aleth 
14:44:06 <-- aleth has quit (Quit: Ciao)
14:44:25 --> aleth has joined #instantbird
14:44:25 * ChanServ sets mode +h aleth 
14:48:14 --> flo-retina has joined #instantbird
14:48:14 * ChanServ sets mode +qo flo-retina flo-retina 
14:50:20 <instantbot> New Instantbird (UI) bug 1937 filed by aleth@instantbird.org.
14:50:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1937 nor, --, ---, nobody, NEW, Context menus broken
14:58:12 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=750421
14:58:32 <flo-retina> but I guess our implementations no longer just return true since bug 1100 is fixed :)
14:58:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1100 cri, --, 1.4, clokep, RESO FIXED, Use Firefox untrusted cert dialog for "SSL Handshake failed" errors
15:01:58 <clokep_work> https://bugzilla.mozilla.org/show_bug.cgi?id=844351 would effect us
15:07:31 * flo-retina dislikes bugs like that, that don't explain what they are trying to fix at all
15:09:08 * clokep_work debated about commenting...
15:16:36 <clokep_work> (And then decided he had nothing good to say. ;))
15:16:50 <aleth> "please explain the motivation"?
15:20:25 <clokep_work> I'm guessing their motivation is "remove an interface that replicates functionality now provided by a more generic interface"
15:22:38 <-- jb has quit (Quit: jb)
15:23:49 --> jb has joined #instantbird
15:24:20 <-- gerard-majax_ has quit (Ping timeout)
15:27:43 --> gerard-majax_ has joined #instantbird
15:32:27 <-- aleth has quit (Quit: Ciao)
15:39:59 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
15:43:25 --> flo-retina has joined #instantbird
15:43:26 * ChanServ sets mode +qo flo-retina flo-retina 
15:47:51 <-- deltafalcon has quit (Connection reset by peer)
15:57:02 --> chomovva has joined #instantbird
15:57:22 <-- chomovva has left #instantbird ()
16:08:00 --> nhnt11 has joined #instantbird
16:09:41 --> mpmc has joined #instantbird
16:12:48 <-- nhnt11 has quit (Input/output error)
16:12:53 --> nhnt11 has joined #instantbird
16:16:50 <-- nhnt11 has quit (Input/output error)
16:17:00 --> nhnt11 has joined #instantbird
16:19:24 <-- nhnt11 has left #instantbird ()
16:21:01 --> nhnt11 has joined #instantbird
16:21:19 <-- nhnt11 has left #instantbird ()
16:30:03 <-- Optimizer has quit (Ping timeout)
16:34:08 --> Optimizer has joined #instantbird
16:42:03 <-- gerard-majax_ has quit (Ping timeout)
17:05:42 <-- Optimizer has quit (Ping timeout)
17:05:52 --> Optimizer has joined #instantbird
17:34:30 --> gerard-majax_ has joined #instantbird
17:34:32 <-- Optimizer has quit (Ping timeout)
17:38:16 --> Optimizer has joined #instantbird
17:39:30 <-- jb has quit (Ping timeout)
17:40:41 <-- mpmc has quit (Ping timeout)
17:47:32 <clokep_work> We need to email localizer, Re: string freee
17:47:35 <clokep_work> freeze
17:49:38 <flo-retina> we could also free all the strings! :)
17:50:32 <clokep_work> String thaw?
17:51:47 <-- Optimizer has quit (Ping timeout)
17:53:19 --> mpmc has joined #instantbird
17:55:10 --> Optimizer has joined #instantbird
17:55:56 <-- mpmc has quit (Ping timeout)
17:56:08 --> mpmc has joined #instantbird
18:02:46 --> mpmc1 has joined #instantbird
18:03:03 <-- mpmc has quit (Ping timeout)
18:05:00 <-- Optimizer has quit (Ping timeout)
18:06:08 --> Mnyromyr has joined #instantbird
18:08:21 --> Optimizer has joined #instantbird
18:10:52 <-- mpmc1 has quit (Ping timeout)
18:12:16 --> mpmc has joined #instantbird
18:16:27 <-- Optimizer has quit (Ping timeout)
19:02:08 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
19:13:29 --> jb has joined #instantbird
19:18:12 --> mpmc has joined #instantbird
19:18:44 <-- jb has quit (Ping timeout)
19:18:46 --> nhnt11 has joined #instantbird
19:18:56 <-- nhnt11 has left #instantbird ()
19:23:32 --> nhnt11 has joined #instantbird
19:25:38 <-- nhnt11 has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
19:32:13 --> qlum has joined #instantbird
19:48:45 --> Mic has joined #instantbird
19:48:45 * ChanServ sets mode +h Mic 
19:55:17 --> atuljangra has joined #instantbird
19:55:37 <atuljangra> clokep_work: flo-retina Hi, Good Evening :-)
19:56:16 <flo-retina> hello :)
19:57:00 <atuljangra> flo-retina: you must be getting tons of GSoC mails ;)
19:57:33 <flo-retina> not that many actually. I got a lot more during last week-end
19:57:42 <flo-retina> I guess students have more time to write emails during week-ends :)
19:57:49 * clokep_work wonders if &&= is an operator.
19:57:57 <clokep_work> atuljangra: I've had a lot. :P
19:58:09 <Mic> clokep_work: which language?
19:58:13 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
19:58:28 <atuljangra> clokep_work: I know, Skype project ;)
19:58:54 <clokep_work> Mic: C ATM.
19:59:30 * atuljangra wonders how can there be so many applicants to skype project, given how much complicated it is/can be.
19:59:47 <atuljangra> general trend is to go for easier projects. :-/
20:00:28 <clokep_work> (It is not in C. :))
20:00:41 <clokep_work> atuljangra: I have a feeling a lot of people think it's easy.
20:00:44 <clokep_work> We'll see how the applications look.
20:01:10 <atuljangra> clokep_work: but it isn't \that\ easy
20:01:33 <clokep_work> atuljangra: I don't think it's easy /at all/, personally. :)
20:01:58 <atuljangra> agreed.
20:03:13 <atuljangra> Also, regarding the application, what kind of insight should one give? I mean do I need to mention, how *exactly* we are going to do things, or giving an overview of things would be enough?
20:04:49 <clokep_work> atuljangra: My suggestion about that is prove to us that you've thought through a design and *why* you think your design will work. If you read something and go "Oh wait, this won't work because this interface needs a foobar!" Tell us that, show us you've put thought into it.
20:05:00 <clokep_work> atuljangra: If you want feedback, email it to us, but I'm away this weekend.
20:05:49 <atuljangra> clokep_work: okay. I'll do so. Thanks :-)
20:07:44 --> Mook_as has joined #instantbird
20:08:51 <atuljangra> clokep_work: regarding alternate nicks, I'll upload the patch with the test as soon as possible. I'll be traveling to my home tomorrow, so won't be able to work today and tomorrow. I hope that'll be okay.
20:10:29 <clokep_work> atuljangra: I'm traveling tomorrow and won't be able to review it. ;)
20:10:36 <clokep_work> (Reviewing a patch that large on my phone is painful.)
20:10:48 <atuljangra> clokep_work: perfectly fine :P
20:11:05 <atuljangra> clokep_work: In the meantime I should start with the application, right?
20:13:39 <clokep_work> atuljangra: That sounds like a good plan. :)
20:14:01 <clokep_work> Good rules of thumb in general are: be clear, concise and thorough.
20:14:29 <atuljangra> atuljangra: okay :-)
20:14:42 * atuljangra getting nervous like previous time :-/ :(
20:16:08 <atuljangra> clokep_work: I'll prepare one and show it to you by Tuesday.
20:16:25 <clokep_work> atuljangra: Sounds like a plan!
20:16:35 <atuljangra> clokep_work: how many applications are expecting for Skype project?
20:17:53 <clokep_work> atuljangra: I've had a "bunch" of people contact me.
20:18:26 <atuljangra> clokep_work: I'll take that as 20 :P
20:18:56 <clokep_work> atuljangra: http://xkcd.com/1070/
20:19:34 <atuljangra> bunch is not in that set :P
20:19:45 * atuljangra likes the couple one ;)
20:19:46 --> harlock has joined #instantbird
20:19:46 <clokep_work> The humor can be applied. ;)
20:20:32 <atuljangra> hehe okay :P
20:20:53 <atuljangra> So are you going on a vacation or something? for the weekend? :-)
20:21:35 <clokep_work> I'm going to a wedding, will be interesting.
20:22:04 <atuljangra> great, take some photographs :-) I'd love to see them.
20:22:16 * clokep_work hides himself well. ;)
20:22:24 * atuljangra likes different cultures and their ceremonies 
20:22:27 <clokep_work> Although I've video chatted with flo, so that doesn't work well.
20:22:38 <atuljangra> clokep_work: heh :P
20:24:34 <Mic> clokep_work: if you'd like to get some advice regarding hiding, ask aleth, maybe? ;)
20:24:42 <flo-retina> clokep_work: we've done that only once
20:25:15 <clokep_work> I never said we do it all the time! :P
20:25:27 <clokep_work> Anyway, time to go run around outside.
20:25:46 <flo-retina> Mic: just offer him a tshirt ;). Anne-Marie managed to get his real name (well, I don't know if it was real, but real-enough for a tshirt to be successfully delivered :))
20:28:16 <atuljangra> guys I'll just go now. Have a train to catch in the morning :-)
20:28:38 <Mic> atuljangra: bye
20:28:44 <atuljangra> :)
20:28:47 <-- atuljangra has left #instantbird ()
20:28:50 <-- clokep_work has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
20:58:32 * flo-retina expected to spend some time debugging bug 1928, but doesn't have any idea of where to start
20:58:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1928 maj, --, ---, nobody, NEW, purplexpcom shutdown crash on Windows [@ msvcr100.dll@0x28ec ]
20:58:38 <flo-retina> it seemed so obvious this morning :-S
21:04:53 <flo-retina> bah, our shutdown isn't clean at all
21:06:29 <flo-retina> http://pastebin.instantbird.com/177795 This is what I get in my terminal for the shutdown of a current debug build with a new profile that contains only a connected gtalk account
21:12:19 <flo-retina> uh, I missed the most interesting line!
21:12:27 <flo-retina> 14: "Connecting" !!
21:12:39 <flo-retina> for some reason the auto-reconnect timer fires immediately during shutdown :-S
21:19:37 --> harlock1 has joined #instantbird
21:20:35 <-- harlock has quit (Ping timeout)
21:20:39 <Mic> :(
21:21:43 <flo-retina> there's even 3 reconnection attempts during shutdown!
21:21:52 <flo-retina> not through timers though
21:21:57 <flo-retina> (they wouldn't have time to fire)
21:22:13 <flo-retina> it's from http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#279
21:25:45 --> EionRobb has joined #instantbird
21:26:02 <flo-retina> looks to me like a regression from bug 1846
21:26:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1846 min, --, 1.4, aleth, RESO FIXED, Changing the status to available while an IRC account is in the disconnecting state doesn't reconnec
21:26:59 <flo-retina> and bug 1856 is troubling
21:27:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1856 nor, --, ---, nobody, RESO DUPLICATE, Crash when disconnecting from MSN/GTalk
21:27:07 <flo-retina> looks like clokep's bug is a duplicate
21:27:11 <flo-retina> even though that bug was "fixed"
21:32:50 <Mic> At least it looks like it is a fruitful debugging session...
21:33:07 <flo-retina> I'll have a fix soon
21:33:15 <flo-retina> I'm just not sure how many fixes we want to be satisfied
21:33:34 <flo-retina> what happened looked like it required several layers of wrong behaviors
21:34:29 <flo-retina> hmm, but maybe the libpurple accounts were suffering from the same stupid behaviors, and also attempting to reconnect :-S
21:34:47 <flo-retina> I'm just surprised that it hasn't been crashy for everybody in that case :-S
21:52:34 <-- harlock1 has quit (Quit: Baibai)
21:53:57 <instantbot> New Core - General bug 1938 filed by florian@instantbird.org.
21:53:58 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2386 on bug 1938.
21:53:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1938 nor, --, ---, nobody, NEW, Accounts are reconnected during shutdown
22:07:59 <Mic> Good night
22:08:15 <flo-retina> I guess that means you don't feel like drive by r+'ing that patch ;)
22:08:17 <flo-retina> Good night :)
22:09:12 <Mic> I was wondering if I should offer to do that ;)
22:10:16 <-- Mic has quit (Quit: No time to waste, let's go!)
22:23:03 <-- mconley has quit (Input/output error)
22:32:58 <flo-retina> Warning: ReferenceError: reference to undefined property this._encoding
22:32:58 <flo-retina> Source File: components/irc.js Line: 1081
22:33:34 <flo-retina> is it possible that countBytes is sometimes called with a "this" value that isn't what's expected?
22:42:52 <Mook_as> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#171
22:44:24 <flo-retina> Mook_as: arg, thanks!
22:54:51 --> clokep has joined #instantbird
22:54:51 * ChanServ sets mode +o clokep 
22:56:17 <instantbot> New Core - IRC bug 1939 filed by florian@instantbird.org.
22:56:18 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2387 on bug 1939.
22:56:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1939 nor, --, ---, nobody, NEW, Warning: ReferenceError: reference to undefined property this._encoding
22:57:21 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
22:58:59 <instantbot> clokep@gmail.com granted review for attachment 2387 on bug 1939.
22:59:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1939 nor, --, ---, nobody, NEW, Warning: ReferenceError: reference to undefined property this._encoding
22:59:16 <-- EionRobb has quit (Ping timeout)
22:59:26 --> EionRobb has joined #instantbird
23:00:02 <clokep> Yay, bugs.
23:00:09 <flo-retina> and fixes ;)
23:00:51 <clokep> :)
23:00:59 * clokep will be back soon
23:01:54 <flo-retina> without crashing? :)
23:05:34 <-- Suiseiseki has quit (Connection reset by peer)
23:11:19 <clokep> Hopefully.
23:13:59 * flo-retina has a potential fix for bug 1888
23:14:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1888 maj, --, ---, nobody, NEW, New messages not displayed after detaching and reattaching a conversation tab
23:14:21 <clokep> :)
23:23:39 <flo-retina> would be so much easier if I could reliably reproduce :(
23:24:15 <flo-retina> I can reproduce like 2 out of 3 times
23:32:03 <dew> poor flo :(
23:32:53 * flo-retina now has correct steps to reproduce
23:33:38 <dew> \o/
23:34:44 <flo-retina> clokep: have you looked at bug 1938?
23:34:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1938 nor, --, ---, nobody, NEW, Accounts are reconnected during shutdown
23:40:08 <clokep> flo-retina: Briefly.
23:40:27 * flo-retina takes that as a 'no'
23:40:39 <flo-retina> I was mostly wondering if it fixes your shutdown crasher
23:41:04 <clokep> flo-retina: Why would we uninit without disconnecting first?
23:42:02 <flo-retina> uninit calls disconnect automatically inside the account's implementations, but without firing notifications about accountbuddies becoming STATUS_UNKNOWN
23:43:24 <clokep> Ah, I see.
23:43:35 <clokep> So your forcing the observer to be freed first.
23:43:50 <clokep> (That was poorly worded.)
23:43:52 * clokep head hurts a lot.
23:44:17 <flo-retina> I wanted any of the lines in http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#271 to evaluate to false
23:44:48 <flo-retina> the first one seemed the easier to target as it was something I could actually uninitialize
23:45:28 <flo-retina> I could also have changed this.statusInfo.statusType to OFFLINE or UNKNOWN, but that could potentially fire lots of notifications and I wouldn't want to risk that so close to a release
23:45:44 <clokep> Do you want me to try it first?
23:46:05 <flo-retina> do you mean "before landing"?
23:46:27 <clokep> To see if it fixes my crash.
23:46:42 <flo-retina> I'm confident that the change is good (it fixes all the errors I have on shutdown on my debug build; and makes sense). What I'm curious to know is if we need to continue looking into the crash or can forget it
23:47:05 <clokep> OK. :)
23:47:16 * clokep is rebuilding.
23:47:26 <instantbot> clokep@gmail.com granted review for attachment 2386 on bug 1938.
23:47:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1938 nor, --, ---, nobody, NEW, Accounts are reconnected during shutdown
23:48:04 * flo-retina isn't sure how much things need to be fixed in bug 1888
23:48:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1888 maj, --, ---, nobody, NEW, New messages not displayed after detaching and reattaching a conversation tab
23:58:48 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
23:59:52 --> clokep has joined #instantbird
23:59:53 * ChanServ sets mode +o clokep