#instantbird log on 04 04 2013

All times are UTC.

00:16:37 <-- flo-retina has quit (Input/output error)
00:33:51 <-- dew has quit (Ping timeout)
00:38:41 --> dew has joined #instantbird
00:38:53 <dew> just hung my IB :/
00:39:39 <clokep> dew: What'd you do? :P
00:40:01 <dew> left it open for a few weeks and tried to do a control + f in the firefox channel
00:41:00 <clokep> Bad idea. :)
00:41:14 <clokep> We have a bug open about that already btw.
00:41:25 <dew> I heard scriptish was being discontinued and I freaked out
00:41:47 <dew> I couldn't find a source on the internet except for the dude on mozillazine that said it
01:00:27 <clokep> dew: I haven't heard that, but the author works for MOzilla now so...
01:00:27 * clokep shrugs.
01:00:33 <clokep> I think there's a #scriptish room here.
01:05:48 --> Fernandos has joined #instantbird
01:11:12 --> mconley has joined #instantbird
01:12:21 <-- Fernandos has left #instantbird (PRIVMSG #rust :hi)
01:19:34 <dew> yep I'm in that room
01:19:55 <dew> I asked but there's one dude named ivan in there who's also in here
02:44:42 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
02:52:27 <instant-buildbot> build #830 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/830
03:31:55 <instant-buildbot> build #826 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/826
03:32:03 <-- mconley has quit (Input/output error)
03:44:50 <-- EionRobb has quit (Quit: Leaving.)
05:14:12 <instant-buildbot> build #923 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/923
05:20:47 --> gerard-majax__ has joined #instantbird
05:22:54 <-- gerard-majax__ has quit (Ping timeout)
05:25:54 --> jhk has joined #instantbird
06:38:16 --> flo-retina has joined #instantbird
06:38:16 * ChanServ sets mode +qo flo-retina flo-retina 
06:54:58 --> jb has joined #instantbird
07:01:02 <-- FireFly_TB has quit (Ping timeout)
07:13:00 --> FireFly_TB has joined #instantbird
07:33:29 --> Mic has joined #instantbird
07:33:29 * ChanServ sets mode +h Mic 
07:53:32 --> gerard-majax__ has joined #instantbird
07:55:28 <-- gerard-majax__ has quit (Ping timeout)
08:10:36 --> gerard-majax__ has joined #instantbird
08:12:51 <-- gerard-majax__ has quit (Ping timeout)
08:24:38 <-- FireFly_TB has quit (Ping timeout)
08:30:58 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
08:31:01 --> flo-retina has joined #instantbird
08:31:01 * ChanServ sets mode +qo flo-retina flo-retina 
08:47:13 <-- chrisccoulson has quit (Quit: Ex-Chat)
08:47:49 --> chrisccoulson has joined #instantbird
09:06:48 <-- Mic has quit (Quit: No time to waste, let's go!)
09:08:01 --> Mic has joined #instantbird
09:08:01 * ChanServ sets mode +h Mic 
09:08:43 <-- Mic has quit (Quit: No time to waste, let's go!)
09:12:29 --> gerard-majax__ has joined #instantbird
09:13:01 --> Mic has joined #instantbird
09:13:02 * ChanServ sets mode +h Mic 
09:30:53 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
09:36:28 <-- Mic has quit (Quit: No time to waste, let's go!)
09:36:36 --> Mic has joined #instantbird
09:36:37 * ChanServ sets mode +h Mic 
09:37:26 <-- Mic has quit (Quit: No time to waste, let's go!)
09:37:42 --> Mic has joined #instantbird
09:37:43 * ChanServ sets mode +h Mic 
09:39:58 <-- Mic has quit (Quit: No time to waste, let's go!)
09:41:11 --> Mic has joined #instantbird
09:41:11 * ChanServ sets mode +h Mic 
09:42:27 <-- Mic has left #instantbird ()
09:45:47 --> gerard-majax_ has joined #instantbird
09:46:28 <-- gerard-majax__ has quit (Ping timeout)
09:47:26 <-- gerard-majax_ has quit (Ping timeout)
09:49:05 --> Mic has joined #instantbird
09:49:05 * ChanServ sets mode +h Mic 
09:50:13 <-- Mic has quit (Quit: No time to waste, let's go!)
09:53:45 --> gerard-majax has joined #instantbird
09:55:19 --> mpmc has joined #instantbird
09:58:58 --> flo-retina has joined #instantbird
09:58:58 * ChanServ sets mode +qo flo-retina flo-retina 
09:59:25 <gerv> clokep: pong.
10:02:30 <flo-retina> clokep: http://log.bezut.info/instantbird/130404#m10 doesn't that shrugging means you think people working for Mozilla no longer maintain their own projects? :-S
10:09:26 --> Mic has joined #instantbird
10:09:26 * ChanServ sets mode +h Mic 
10:13:33 <-- Mic has quit (Quit: No time to waste, let's go!)
10:17:45 --> clokep has joined #instantbird
10:17:45 * ChanServ sets mode +o clokep 
10:20:34 --> Mic has joined #instantbird
10:20:34 * ChanServ sets mode +h Mic 
10:21:46 <clokep> flo-retina: That shrugging means..."I don't really care, I don't really use scriptish that much, this is offtopic for this room." :)
10:22:04 <clokep> gerv: So you had offered to set up a BzAPI for bugzilla.instantbird.org, is it too late to take you up on that? :)
10:22:19 <clokep> (No rush on when it would be set up, btw.)
10:22:22 <gerv> clokep: Not at all.
10:23:00 <instantbot> New Core - IRC bug 1918 filed by benediktp@ymail.com.
10:23:01 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2319 on bug 1918.
10:23:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1918 min, --, ---, nobody, NEW, Sort channel list in IRC tooltips
10:23:23 <clokep> Just what I wanted when I've been up for 10 minutes. ;)
10:23:38 <gerv> clokep: What timezone is that Bugzilla server in?
10:23:57 <Mic> It's exactly the right size for breakfast ;)
10:24:06 <clokep> gerv: I don't know, Even or flo-retina would know. :-/
10:24:19 <gerv> flo-retina: ?
10:24:27 <flo-retina> gerv: Either local French time, or UTC.
10:24:29 <clokep> gerv: https://bmo.etherpad.mozilla.org/bugzilla-instantbird-merge says CET
10:24:36 <gerv> OK, thanks.
10:24:51 <clokep> Mic: Well you pre-empted my comment of "take the prefix off first". :)
10:25:22 <flo-retina> Mic: in case you are curious about how my Ib-in-SocialAPI experiment looked: http://i6.minus.com/iujV2eYjkmANd.png
10:25:43 <flo-retina> and if anybody want to play with it, I kept a copy of the try server builds: http://queze.net/goinfre/webrtc-demo/firefox-xmpp/
10:25:44 <clokep> Mic: Doesn't that need to set channels to use that function? :-S
10:25:51 <gerv> What is the Olsen timezone database string for Paris time?
10:26:33 <gerv> Found it.
10:26:57 <flo-retina> gerv: can this be found easily on the admin web UI, or by looking in a configuration file on the server's disk?
10:27:06 <gerv> flo-retina: I think it's in the admin settings.
10:27:09 <flo-retina> (I have ssh access to the server hosting BIO, if that helps)
10:28:50 <gerv> It's CET. All the timestamps are marked CET.
10:30:31 <gerv> clokep: https://api-dev.bugzilla.mozilla.org/instantbird/bug/1912 :-)
10:30:46 <clokep> gerv: That was fast! Thank you. :)
10:30:56 <gerv> It's only got two worker threads, so if you access it a lot in parallel, you might get errors or slow performance.
10:31:15 <gerv> But each thread is a permanently-running Perl process and the machine has limited memory.
10:31:22 <gerv> So I can't give you a load.
10:31:46 <gerv> Oh, hang on...
10:31:48 <clokep> gerv: That's fine. that bug seems to point to a BMO bug though... not https://bugzilla.instantbird.org/show_bug.cgi?id=1912
10:31:49 <gerv> That doesn't look right.
10:31:52 <gerv> !
10:31:52 <instantbot> Bug 1912 nor, --, ---, nobody, UNCO, "Extract Conversation With..." feature
10:32:30 <gerv> Copy-paste error.
10:33:52 <gerv> clokep: https://api-dev.bugzilla.mozilla.org/instantbird/bug/1912 :-)
10:33:54 <gerv> Try again now.
10:34:05 <flo-retina> Mic: I don't see the sortChannels function being used anywhere in https://bugzilla.instantbird.org/attachment.cgi?id=2319
10:34:47 <clokep> Yeah, I already pointed that out.
10:34:53 <clokep> gerv: Thanks! :)
10:36:31 <instantbot> clokep@gmail.com denied review for attachment 2319 on bug 1918.
10:36:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1918 min, --, ---, nobody, NEW, Sort channel list in IRC tooltips
10:36:42 <dew> clokep never sleeps!
10:36:59 <clokep> dew: I just slept for the past 6 or 7 hours. :P
10:37:10 <clokep> (You can probably fairly easily figure out my sleep schedule from the Instantbird logs...)
10:53:27 <Mic> Yes, I forgot moving the change in kFields :(
10:56:13 <clokep> That makes me concerned you didn't test it. ;)
10:58:02 <Mic> I tested it with various prefixes but I still have to copy things back and forth between a runnable version of IB and the repository :(
10:58:18 <clokep> Ahhh. I see.
10:58:27 <clokep> Can't you just copy the whole file though? Would that be easier?
10:58:39 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
10:59:00 <Mic> Should be easier here, true.
11:00:12 <-- gerard-majax has quit (Ping timeout)
11:23:53 <-- jb has quit (Ping timeout)
11:33:35 <jhk> flo-retina: ping
11:36:25 <flo-retina> jhk: pong
11:36:39 <jhk> flo-retina: I went through the file module and understood how it is used in tb and also list down the points here. http://pastebin.mozilla.org/2272875
11:37:19 <jhk> *Filelinks module
11:40:11 <flo-retina> :)
11:40:18 <flo-retina> jhk: there's also a dropbox provider somewhere
11:40:39 <flo-retina> it's been removed from the comm-central tree, but it's likely still around as an add-on (and if not we can find the code in the hg history)
11:40:56 * jhk brb in 5 min
11:46:56 * jhk back
11:48:21 <jhk> flo-retina: yeah its there as extension. https://addons.mozilla.org/en-US/thunderbird/addon/dropbox-for-filelink/
11:48:28 --> clokep_work has joined #instantbird
11:48:28 * ChanServ sets mode +o clokep_work 
11:49:37 <clokep_work> jhk: https://github.com/mikeconley/thunderbird-filelink-dropbox is the code for it.
11:53:25 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
11:54:25 * flo-retina is trying to decide if he has anything useful to add to this thread: https://github.com/mozilla/talkilla/pull/20/files#r3650123
11:57:28 <jhk> clokep_work, flo-retina: I am wondering If I can try out and test the module independent of the Tb? by uploading single file.  
11:58:20 <flo-retina> by "independent of the Tb", do you mean by putting it in an instantbird build or an instantbird source tree?
11:58:34 <jhk> yes
11:58:42 <jhk> is the possible?
11:59:00 <flo-retina> I'm not sure. How long would it take you to try?
12:00:11 <jhk> flo-retina: not sure. so what should be the next step from here.
12:00:28 <flo-retina> mconley (he often comes here, but it's a bit too early right now for his timezone) can certainly answer all your filelink questions :)
12:02:11 <jhk> ok so lets mconley come and then we will discuss.
12:03:05 <clokep_work> He should be awake soon. ;)
12:03:28 <flo-retina> clokep_work: I think he tends to arrive in the office at 9am
12:03:38 <flo-retina> he's likely already awake, just not online
12:06:09 <clokep_work> flo-retina: I like your code way better than the jQuery. :)
12:06:39 <flo-retina> clokep_work: it sucks too, but it's at least straight forward to understand
12:06:55 * flo-retina wants (an) XBL (equivalent)
12:08:20 <clokep_work> Btw I'd suspect getting FileLink into Instantbird is as simple as moving over http://mxr.mozilla.org/comm-central/source/mail/components/cloudfile/ and figuring out the build script.
12:08:29 <clokep_work> (And of course changing the UI. :))
12:12:06 <jhk> clokep_work: yup that is the plan. also we will have to discuss the Ui as well. :)
12:34:53 --> mikk_s has joined #instantbird
12:43:40 --> gerard-majax has joined #instantbird
12:46:56 <-- mikk_s has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
12:50:32 --> jb has joined #instantbird
12:54:43 <-- Tonnes has quit (Connection reset by peer)
13:04:44 --> Tonnes has joined #instantbird
13:12:47 <-- flo-retina has quit (Ping timeout)
13:14:00 --> flo-retina has joined #instantbird
13:14:01 * ChanServ sets mode +qo flo-retina flo-retina 
13:45:33 --> mconley has joined #instantbird
13:55:30 <-- deltafalcon has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
14:04:29 <-- flo-retina has quit (Ping timeout)
14:06:48 --> flo-retina has joined #instantbird
14:06:49 * ChanServ sets mode +qo flo-retina flo-retina 
14:10:58 <jhk> Hi mconley. I wanted to know if Is it possible to use Filelinks independent of Tb to make it work with instantbird.
14:11:11 <mconley> hey jhk
14:12:05 <mconley> jhk: there are a few possible approaches, but none of them are very pretty:
14:12:41 <mconley> 1) A full-on port, copying the code from TB over to IB. A pretty hefty maintenance burden.
14:13:01 <mconley> 2) Move Filelinks completely into InstantBird, and have Thunderbird bring it in via chat/
14:14:02 <Mic> *Instantbird
14:14:04 <Mic> scnr ;)
14:14:07 <mconley> er, right
14:14:10 <clokep_work> Haha, Mic beat me to it.
14:14:31 <clokep_work> mconley: #2 doesn't really make sense, unfortunately. :(
14:14:40 <mconley> yep
14:14:41 <clokep_work> (There is a #3: Base Instantbird off of c-c. ;))
14:15:19 <mconley> hm
14:15:30 <mconley> clokep_work: has that been suggested before? If so, what was the objection?
14:16:11 <jhk> #3? 
14:16:27 <mconley> yes, for #3
14:16:54 <clokep_work> mconley: We've discussed it before, I don't know if there is an objection, we'd have to change a bunch of stuff around (e.g. make libpurple an add-on) first, I believe.
14:17:59 <mconley> I think flo-retina already did that, no?
14:18:02 <clokep_work> jhk: mconley: Regardless, that would be outside of the scope of GSoC.
14:18:08 <mconley> absolutely
14:18:10 <clokep_work> mconley: But Instantbird doesn't do that.
14:18:18 <mconley> ah
14:18:20 <flo-retina> mconley: I got the green light during the last mozcamp /Tb summit to merge Ib into c-c. We were waiting for the BIO->BMO merge to happen to actually do it.
14:18:23 <clokep_work> It's a manual process, we don't automatically pull it in and build it.
14:18:33 <clokep_work> flo-retina: Luckily, I started that code last night!
14:18:52 <mconley> flo-retina: cool
14:19:09 <flo-retina> mconley: it's possible that this green light was long enough ago that I would need to 'ask again' to refresh people's memory though ;)
14:19:36 <mconley> it's easier to ask forgiveness than permission. :)
14:20:24 <mconley> jhk: maybe the best approach in the scope for GSoC would be to do a port as an Instantbird (lowercase b!) add-on
14:21:06 * clokep_work would be OK with including the filelink code directly too...
14:21:13 <mconley> are you sure?
14:21:23 <mconley> maintenance burden...
14:21:38 <mconley> although, admittedly, Filelink code hasn't seen much churn in months
14:21:41 <mconley> you might be able to get away with it
14:22:49 <flo-retina> mconley: can't we move the filelink code to chat/?
14:22:57 <flo-retina> mconley: that would also get rid of the http.jsm problem, wouldn't it?
14:22:58 <clokep_work> That was suggestion #2.
14:22:59 <mconley> flo-retina: that was my suggestion #2
14:23:23 <flo-retina> mconley: I saw you suggested it, but I didn't see why it wasn't considered any more
14:23:48 <mconley> basically, it hands the IB community the responsibility to maintain a TB feature. :)
14:24:12 <mconley> which, I mean, you're all super awesome and capable people
14:24:17 <mconley> but that doesn't seem fair to you
14:24:31 <flo-retina> btw, maintaining the sync of just chat/ or of 2 folders doesn't change much the maintenance burden. We need an hg convert call already to extract the changes from one repo to the other.
14:25:06 <flo-retina> mconley: oh, were you thinking that in terms of module ownership?
14:25:14 <mconley> yes
14:25:27 <-- gerard-majax has quit (Ping timeout)
14:25:33 <flo-retina> we could likely make an exception
14:25:47 <mconley> We could maybe put Filelink under a "common" folder under c-c, which IB could bring in
14:25:55 <flo-retina> filelink is a submodule of mail/ I think, it could be a submodule of chat/ with the same owner and peers as currently
14:26:26 <flo-retina> the definition of the current "chat/" folder is almost "parts that are shared between Ib and Tb" ;)
14:26:32 <mconley> I see
14:26:40 <mconley> flo-retina: what is the timeline to get IB into c-c?
14:26:48 <mconley> assuming permission still is green
14:26:58 <flo-retina> not sure
14:27:24 <jhk> what gives us advantage putting in chat/common over add-on?
14:27:26 <flo-retina> we were hoping to get our bugs merged into BMO first, so that we can rewrite the hg history to include bug numbers that are valid BMO bugs.
14:27:43 <mconley> jhk: prevents doubling
14:28:07 <mconley> jhk: if we put Filelink into chat/, we only have to fix things in one place when things break
14:28:45 <jhk> I see
14:28:49 <flo-retina> for a GSoC project, I would say that just copying the files to a folder in the Ib source tree is good enough. We will be responsible for figuring out the plan to make that sustainable.
14:29:22 <flo-retina> mconley: does the current filelink code make assumptions about things that are specific to email?
14:29:30 <mconley> the link insertion stuff, yes
14:29:37 <mconley> well
14:29:42 <mconley> it assumes you're typing in an editor
14:29:49 <mconley> it makes assumptions that you're in the compose window, anyhow
14:30:01 <flo-retina> is that easy to separate into a different folder?
14:30:10 <clokep_work> flo-retina: "for a GSoC project..." I agree with that statement.
14:31:58 <mconley> flo-retina: the front-end code makes a lot of assumptions about being involved with email
14:32:05 <mconley> flo-retina: I don't think it'll be easy to de-couple it
14:33:03 <mconley> probably the easiest stuff to bring over is the account manager module
14:33:18 <mconley> and the built-in implementations of the nsICloudFileProvider interface
14:33:31 <mconley> (YouSendIt, UbuntuOne, Box)
14:33:52 <mconley> although, contract-wise, you might have to talk to jb about what happens to our auth keys for those services
14:34:05 <mconley> I mean, they're out in the open anyway, but mumble mumble contract something
14:34:26 <mconley> these are the hard things to de-couple:
14:34:26 <mconley> http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/bigFileObserver.js
14:34:34 <mconley> http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/cloudAttachmentLinkManager.js
14:35:21 <clokep_work> jhk: ^
14:35:24 <flo-retina> wouldn't these 2 files just need to be forked?
14:35:35 <mconley> yeah, that's how I'd do it
14:35:45 <mconley> or just re-implement for your purposes, since these are email specialized
14:36:07 <flo-retina> yeah, I was just thinking that there may not be much in common
14:36:15 <mconley> like I said, that front-end stuff for link insertion and starting uploads is really composer-centric
14:36:24 <flo-retina> makes sense
14:37:22 <flo-retina> for the oauth keys, wouldn't it be easy to just register new keys for Ib (that wouldn't bring any money to MoCo)?
14:37:45 <jhk> we can pass a link via chat message. In that case we can reimplement those stuff. 
14:39:34 <mconley> flo-retina: yeah, that makes sense
14:44:33 <clokep_work> flo-retina: Where is that hard coded 50 messages that we keep for debug?
14:44:36 * clokep_work needs more like 1000 right now.
14:44:51 <flo-retina> clokep_work: I would r+ immediately a patch to increase that const
14:44:57 <flo-retina> maybe not to 1000 though
14:45:02 <flo-retina> we have a bug on file to make that a pref
14:45:23 <flo-retina> I was frustrated less than an hour ago that the log was cut just after the information I needed :-/
14:45:46 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#288
14:46:02 <clokep_work> Thank you. :)
14:46:05 <clokep_work> I couldn't find it.
14:53:30 <flo-retina> np
14:57:24 * clokep_work thinks something like http://pastebin.instantbird.com/168460 will connect through hTTP proxies.
15:01:32 <flo-retina> clokep_work: do we really have to do that CONNECT line ourselves?
15:01:52 <flo-retina> I would assume it's handled by the platform
15:02:44 <clokep_work> flo-retina: I don't know. :(
15:03:00 <clokep_work> (I alos thought I had a proxy to test it on, but it's spewing garbage back that that host is blocked. :-D)
15:04:43 <jhk> flo-retina: common is the place to move Filelinks. right?
15:13:59 <clokep_work> jhk: Can you be more specific.
15:15:27 <jhk> I mean what is the file approach we will use #1.
15:15:36 <jhk> *final
15:16:49 <jhk> clokep_work: to move Filelinks in common/
15:16:51 * clokep_work isn't sure. :)
15:17:01 <clokep_work> jhk: Hopefully flo-retina will answer in a second.
15:17:05 * clokep_work is about to get a burrito anyway. ;)
15:17:15 <jhk> sure :)
15:17:24 <flo-retina> I don't understand the question
15:17:29 <flo-retina> "common" doesn't exist currently
15:18:13 <jhk> flo-retina: in chat/ ?
15:21:03 * clokep_work wonders if anyone here knows Perl...
15:21:14 <jhk> flo-retina: what is the best approach do you think?
15:21:38 <flo-retina> clokep_work: g erv likely does
15:21:56 <flo-retina> jhk: but for now, if you move the files from mail/ that you need to somewhere in instantbird/ that should be good enough
15:26:20 <-- jb has quit (Quit: jb)
15:28:28 <jhk> that seems to be a good idea for now.
15:29:04 <jhk> Thank you :)
15:29:12 <flo-retina> you are welcome :)
15:29:13 --> jb has joined #instantbird
15:31:13 --> zen_monkey has joined #instantbird
15:31:18 <-- zen_monkey has left #instantbird (Saliendo)
15:44:29 <-- flo-retina has quit (Ping timeout)
15:44:50 --> flo-retina has joined #instantbird
15:44:50 * ChanServ sets mode +qo flo-retina flo-retina 
15:50:32 <-- jhk has quit (Ping timeout)
15:57:49 <-- gerv has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
16:00:48 <-- Optimizer has quit (Ping timeout)
16:04:15 --> Optimizer has joined #instantbird
16:11:20 <-- Optimizer has quit (Connection reset by peer)
16:37:23 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
16:46:56 <-- jb has quit (Ping timeout)
16:49:33 --> jhk has joined #instantbird
16:53:47 --> Optimizer has joined #instantbird
16:54:32 --> jb has joined #instantbird
17:05:49 --> mpmc has joined #instantbird
17:13:58 --> flo-retina has joined #instantbird
17:13:59 * ChanServ sets mode +qo flo-retina flo-retina 
17:17:13 <Mic> Interesting, I didn't know this was OK, syntax-wise:
17:17:19 <Mic> var obj = {value: 1234}; var readValue = function () { return this.value; }.bind(obj); readValue()
17:19:14 <clokep_work> Mic: What's surprising abou that? :-S
17:19:19 <Mic> I'm talking about the bind() call in there
17:19:30 <Mic> That's trailing after the closing block bracket.
17:20:15 <Mic> I was certain that it would work with brackets like this: (function() {}).bind(...), but I'm surprised that you don't need them.
17:20:34 <clokep_work> Ohhhh, I see.
17:20:36 <clokep_work> Yeah that's a little weird.
17:31:36 <-- Mic has quit (Quit: No time to waste, let's go!)
17:33:15 --> Mic has joined #instantbird
17:33:16 * ChanServ sets mode +h Mic 
17:34:18 <Mic> clokep_work: is it guaranteed that the string with the channel names for the tooltip contains exactly one space between two channel names?
17:36:34 <clokep_work> Mic: It's a string back from the server, right? :)
17:37:43 <clokep_work> (That means "nothing can be guaranteed")
17:43:20 <clokep_work> (Mic btw overall that patch did look good and I'm glad you made it, one of those little annoyances every time I see a tooltip...)
17:43:45 <Mic> I'm just about to upload a new one.
17:44:17 <Mic> Do you like the order: http://i.imgur.com/0XlmnDn.png ?
17:44:57 <Mic> It looked more ordered when I hadn't ignored the prefixes yet ;)
17:45:04 <clokep_work> Mic: My one question is whether it's case insensitive or not?
17:45:19 <clokep_work> (I doubt it is.)
17:45:25 <Mic> Ah, thanks for reminding me!
17:45:54 <Mic> I'm using the normalize()-method from ircAccount for comparing the channel names. Is that even suitable for it?
17:46:17 <clokep_work> I think it should be...
17:47:03 <-- jb has quit (Ping timeout)
17:47:27 <Mic> It's really case insensitive by the way.
17:51:22 <Mic> clokep_work: would lines 27 and 30 be acceptable for you in http://pastebin.instantbird.com/168513 ?
17:51:35 <Mic> I used bind() after a function definition there...
17:52:12 <clokep_work> Mic: Why not just define the comparator outside of the one function?
17:52:22 <clokep_work> Also, did you see my comment about trimming and not filtering?
17:53:34 <Mic> trim() only removes whitespace from the beginning and end of a string, doesn't it?
17:53:44 <clokep_work> Yes.
17:53:49 <Mic> That's why I asked about the whitespace between the channel names inside the string above.
17:53:52 <clokep_work> But it probably means you'l lnever get an empty string.
17:54:36 <clokep_work> Mic: Why not just aChannelStr.trim().split(/\s/).sort(sortWithoutPrefix).join(" "); ?
17:54:42 <clokep_work> I think that will work.
17:55:50 <Mic> I don't think so.
17:56:17 <clokep_work> Why not?
17:56:25 <Mic> I'd expect it to produce empty array entries for every space which would then be joined with " ", producing successive spaces in the result string
17:56:27 <clokep_work> Oh, I'm imssing a + in there.
17:56:36 <clokep_work> split(/\s+/)
17:58:01 <Mic> This works, good idea! It's most likely much cheaper than filtering the array :)
17:58:32 <Mic> .trim() is unnecessary then,t oo.
17:58:52 <clokep_work> No it's not.
17:58:54 <Mic> hmm, is it?
17:58:59 <clokep_work> Not if there's a space at the beginning or end.
17:59:15 <clokep_work> " foo     bar".split(/\s+/) == ["", "foo", "bar"]
17:59:29 <Mic> :(
18:00:15 <flo-retina> ah, we now have a utils.js file in talkilla :)
18:00:35 <clokep_work> Everyone loves a utils file!
18:02:54 <flo-retina> the font on http://i.imgur.com/0XlmnDn.png looks horrible. Is anti-aliasing disabled on purpose?
18:04:56 <flo-retina> clokep_work: yeah, I really love these files.
18:04:57 <flo-retina> I love to hate them at least :)
18:05:26 <clokep_work> For all the bad practices we have at work...we don't have a utils files. ;)
18:12:12 <-- Mic has quit (Quit: No time to waste, let's go!)
18:13:01 --> Mic has joined #instantbird
18:13:01 * ChanServ sets mode +h Mic 
18:19:35 --> unghost has joined #instantbird
18:22:18 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2321 on bug 1918.
18:22:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1918 min, --, ---, benediktp, NEW, Sort channel list in IRC tooltips
18:24:29 <Mic> Totally OT but I'd really like to have a pool like this: http://i.imgur.com/N3us3c1.jpg ;)
18:26:13 <flo-retina> :)
18:27:27 <flo-retina> Mic, clokep_work: do we know if the unsorted order of channels has a meaning?
18:28:13 <flo-retina> are they returned in the order the channels have been joined (doesn't seem like it)? In the order the channels had been created on the (local) server?
18:28:22 <Mic> No, I don't know.
18:28:39 <-- Mic has quit (Quit: No time to waste, let's go!)
18:28:56 --> gerard-majax has joined #instantbird
18:29:20 --> Mic has joined #instantbird
18:29:20 * ChanServ sets mode +h Mic 
18:33:16 <clokep_work> Mic: And that sorts based on letters, not case, right?
18:33:39 <clokep_work> (E.g. you'd end up with #a @%B #c)
18:35:00 <Mic> I've only tried with no user mode, op and half-op but it worked for these, yes.
18:35:14 <Mic> I couldn't find any channel with a prefix different from "#"
18:36:14 <clokep_work> Mic: moznet only allows #.
18:36:17 <clokep_work> That wasn'y my question though.
18:36:26 <clokep_work> My question was about the casing of the channel names. :)
18:36:53 <Mic> Yes, it did.
18:38:06 <instantbot> clokep@gmail.com granted review for attachment 2321 on bug 1918.
18:38:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1918 min, --, ---, benediktp, NEW, Sort channel list in IRC tooltips
18:42:35 <flo-retina> looks like I need to go through the checkin-needed list tonight :)
18:46:36 --> DGMurdockIII has joined #instantbird
18:47:12 <DGMurdockIII> hey guy
18:47:18 <DGMurdockIII> guys*
18:47:56 <DGMurdockIII> Timestamp: 4/4/2013 2:21:00 PM
18:47:56 <DGMurdockIII> Warning: Use of Mutation Events is deprecated. Use MutationObserver instead.
18:47:56 <DGMurdockIII> Source File: chrome://instantbird/content/blist.js
18:47:56 <DGMurdockIII> Line: 776
18:48:33 <clokep_work> DGMurdockIII: Yes, we've had that for a long time. There's a bug filed abou tit.
18:48:36 <clokep_work> flo-retina: Please do! :)
18:51:47 <-- jhk has quit (Ping timeout)
18:58:01 <-- Mic has quit (Quit: No time to waste, let's go!)
18:58:40 --> Mic has joined #instantbird
18:58:40 * ChanServ sets mode +h Mic 
19:17:28 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2322 on bug 1387.
19:17:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1387 nor, --, ---, benediktp, ASSI, The 'Copy Link to Tweet' action should be in the context menu even when the twitter account is disco
19:17:37 <clokep_work> DGMurdockIII: bug 1750 if you want to CC yourself.
19:17:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1750 min, --, ---, nobody, NEW, Warning: Use of Mutation Events is deprecated. Use MutationObserver instead.
19:17:50 <Mic> Something for dinner now? ;)
19:17:55 <DGMurdockIII> hi
19:18:12 <DGMurdockIII> y
19:19:06 * clokep_work wonders if mic is just fixing old bugs.
19:19:09 <clokep_work> And if he takes requests. ;)
19:19:22 <Mic> I'm fixing easy bugs ;)
19:19:44 <DGMurdockIII> Warning: Use of Mutation Events is deprecated. Use MutationObserver instead.
19:19:44 <DGMurdockIII> Source File: chrome://instantbird/content/instantbird.xul
19:19:45 <DGMurdockIII> Line: 306
19:20:00 <DGMurdockIII> can see any chat guys
19:20:20 <Mic> What do you mean with "can see any chat guys"?
19:20:25 <DGMurdockIII> some one pm tell me how to fix this im on the instantbird irc
19:21:37 <Mic> The warning is annoying but harmless at the moment.
19:21:54 <Mic> We'll fix it before it becomes a problem, DGMurdockIII :)
19:22:11 <DGMurdockIII> can see any chat
19:22:28 <flo-retina> "can see any chat" seems to be a new way of trolling ;)
19:22:49 <Mic> Do you mean "Can *not* see any chat", DGMurdockIII ?
19:22:54 <DGMurdockIII> cant
19:23:02 <DGMurdockIII> i can see it now
19:23:22 <DGMurdockIII> what i did move the irc chat window to it own tab
19:23:29 <DGMurdockIII> and i got no message
19:23:49 <Mic> Ah, I think we also know this bug. Let me look it up!
19:24:04 <DGMurdockIII> ok thank
19:24:41 <Mic> DGMurdockIII: it sounds like bug 1888 to me.
19:24:43 <DGMurdockIII> is there a way to sort the user list so the people with admin are at top
19:24:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1888 maj, --, ---, nobody, NEW, New messages not displayed after detaching and reattaching a conversation tab
19:25:13 <Mic> DGMurdockIII: no, not yet. Try our bugzilla search for the bug in question.
19:25:50 <DGMurdockIII> that the one very annoying think about using instantbird irc chat
19:26:14 <DGMurdockIII> yeah that the bug but it happing to irc not IM
19:27:10 <Mic> I'd expect that the bug could happen with any conversation tab.
19:27:11 <DGMurdockIII> and i did not get that error message that he got
19:27:47 <Mic> DGMurdockIII: we don't know the problem yet, so that might be quite possible that the error message in this bug is completely unrelated.
19:27:53 <Mic> *it
19:28:29 <Mic> clokep_work: which old bug would you like to see fixed by the way?
19:29:07 <Mic> (I couldn't motivate myself to look at the retweet problem in bug 1728, so I picked easy ones instead;)
19:29:10 <clokep_work> Mic: That patch doesn't seem to set "aCount" anywhere in it.
19:29:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1728 enh, --, ---, benediktp, NEW, Show mentions of tracked keywords in own conversations
19:29:58 <Mic> http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#75
19:31:52 <clokep_work> Ah, it's just off the diff.
19:31:53 <clokep_work> Good call.
19:32:37 <clokep_work> Hmmm....
19:32:45 <clokep_work> I have a feeling that aleth's patch messes up that friend check. :-/
19:34:49 <Mic> Which bug is this patch in?
19:34:52 <Mic> bbl
19:35:05 <clokep_work> Mic: bug 1887
19:35:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1887 nor, --, ---, aleth, ASSI, Friends don't get added as participants when reopening a closed timeline
20:13:20 --> FireFly_TB has joined #instantbird
20:15:11 --> jb has joined #instantbird
20:21:01 <-- gerard-majax has quit (Ping timeout)
20:23:46 <-- mpmc has quit (Ping timeout)
20:29:24 --> mpmc has joined #instantbird
20:30:18 --> EionRobb has joined #instantbird
20:33:40 --> jb1 has joined #instantbird
20:33:41 <-- jb has quit (Connection reset by peer)
20:38:56 --> harlock has joined #instantbird
20:40:07 --> zen_monkey has joined #instantbird
20:48:37 <-- FireFly_TB has quit (Ping timeout)
20:53:21 --> rosonline has joined #instantbird
20:58:20 <-- jb1 has quit (Ping timeout)
21:00:20 --> jb has joined #instantbird
21:12:00 <-- jb has quit (Ping timeout)
21:13:52 <Mic> clokep_work: here's a diff with whitespace changes ignored: http://sdrv.ms/13VgAWC
21:15:12 <Mic> hm, maybe I should have just pastebined that :(
21:15:34 <Mic> http://pastebin.instantbird.com/168599
21:20:50 <-- zen_monkey has left #instantbird (Saliendo)
21:22:28 <-- harlock has quit (Quit: Baibai)
21:27:11 --> jb has joined #instantbird
21:36:49 <-- chrisccoulson has quit (Quit: Ex-Chat)
21:46:51 --> chrisccoulson has joined #instantbird
21:55:07 <flo-retina> hmm, so with that bug about marking visited links as visited, are we stuck? Or is it ok to land it in chat/ because Tb has Places pref'ed off?
21:55:30 <flo-retina> I don't remember if we reached a decision :-S
21:59:49 <flo-retina> clokep_work, Mic: should I check-in bug 1887 or wait for you all to decide what this 'null friend' story is?
21:59:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1887 nor, --, ---, aleth, ASSI, Friends don't get added as participants when reopening a closed timeline
22:01:57 <-- rosonline has quit (Ping timeout)
22:03:08 <Mic> Let clokep_work and/or aleth decide that. I don't know what the changes in bug 1887 do exactly.
22:03:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1887 nor, --, ---, aleth, ASSI, Friends don't get added as participants when reopening a closed timeline
22:03:17 --> rosonline has joined #instantbird
22:03:25 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:03:34 <Mic> Good night
22:04:10 <flo-retina> ok, I'll just check-in the other 2 patches then
22:04:27 <flo-retina> done
22:04:31 <flo-retina> Good night :)
22:05:23 <-- mconley has quit (Input/output error)
22:05:26 <-- Mic has quit (Quit: No time to waste, let's go!)
22:11:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/507cd5b9b510 - Benedikt Pfeifer - Bug 1918 - Sort channel list in IRC tooltips, r=clokep.
22:11:56 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/d460a4aafe68 - Benedikt Pfeifer - Bug 260 - Pasting in the conversation input box doesn't send typing notifications, r=aleth
22:16:50 <-- jb has quit (Connection reset by peer)
22:16:53 --> jb1 has joined #instantbird
22:19:14 <instant-buildbot> build #368 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/368  blamelist: Benedikt Pfeifer <benediktp@ymail.com>
22:26:02 <-- jb1 has quit (Ping timeout)
22:46:48 <dew> where's my clokep?!
22:59:39 --> clokep has joined #instantbird
22:59:39 * ChanServ sets mode +o clokep 
23:03:12 <clokep> flo-retina: You can check i tin, I believe.
23:03:21 <clokep> Friends is just never null now because we ALWAYS have the info.
23:03:45 <clokep> dew: I was playing Ultimate. :P
23:03:54 <clokep> Mic: Thanks for the diff.
23:04:43 <instantbot> clokep@gmail.com set the Resolution field on bug 260 to FIXED.
23:04:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=260 min, --, 1.4, benediktp, RESO FIXED, Pasting in the conversation input box doesn't send typing notifications
23:05:44 <instantbot> clokep@gmail.com set the Resolution field on bug 1918 to FIXED.
23:05:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1918 min, --, 1.4, benediktp, RESO FIXED, Sort channel list in IRC tooltips
23:05:55 <dew> ultimate?
23:06:04 <dew> no Bioshock Infinite <3
23:06:21 <clokep> Ultimate Frisbee.
23:06:36 <dew> oh
23:06:48 <dew> I'm not really into sports
23:10:15 <clokep> More into Bioshock? ;)
23:10:28 <clokep> Yeah I usually play Frisbee a few times a week when it's nice out.
23:16:11 <-- flo-retina has quit (Ping timeout)
23:40:20 <dew> yeah I'm kind of competitive
23:40:47 <dew> it is nice out today; a good day for a hike
23:51:31 <instant-buildbot> build #391 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/391
23:54:19 <-- Optimizer has quit (Ping timeout)