#instantbird log on 03 24 2013

All times are UTC.

00:04:35 <-- unghost has quit (Ping timeout)
00:08:50 <-- Mic has quit (Quit: No time to waste, let's go!)
00:18:34 --> unghost has joined #instantbird
01:01:09 <-- unghost has quit (Ping timeout)
01:08:16 --> unghost has joined #instantbird
01:36:37 <-- unghost has quit (Ping timeout)
01:42:01 --> unghost has joined #instantbird
01:54:16 <-- unghost has quit (Ping timeout)
02:04:31 --> mconley has joined #instantbird
02:08:52 --> unghost has joined #instantbird
02:20:05 <-- rosonline has quit (Client exited)
02:22:33 <-- unghost has quit (Ping timeout)
02:25:45 --> unghost has joined #instantbird
03:07:24 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
03:25:03 <-- mconley has quit (Ping timeout)
03:53:10 <instant-buildbot> build #819 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/819
04:43:05 <instant-buildbot> build #815 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/815
06:02:21 <instant-buildbot> build #911 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/911
06:47:56 --> harlock has joined #instantbird
07:12:08 --> beelze has joined #instantbird
07:40:49 --> harlock1 has joined #instantbird
07:41:02 <-- harlock has quit (Ping timeout)
08:07:48 --> deltafalcon has joined #instantbird
08:12:01 --> mpmc has joined #instantbird
08:21:51 <beelze> flo-retina: what is a *proper* description for IB (short, a few words)? Ebuild need this to put in description field
08:22:28 <-- harlock1 has quit (Quit: Baibai)
09:27:17 --> gerard-majax__ has joined #instantbird
09:27:23 <-- gerard-majax_ has quit (Connection reset by peer)
09:52:30 <-- mpmc has quit (Connection reset by peer)
10:15:06 <flo-retina> beelze: possible suggestions:
10:15:07 <flo-retina> "Instantbird is a customizable instant messaging client with support for AOL, Yahoo, MSN, Google Talk, Twitter, Facebook, XMPP, IRC and ICQ. It's powered by Mozilla so it has support for customization using themes and extensions built-in."
10:15:07 <flo-retina> "Instantbird is a multi-protocol instant messaging client. Using it, you can connect to all your different IM accounts. It uses the Mozilla rendering engine to display messages, and uses the Pidgin libpurple to connect to the different networks."
10:15:38 <beelze> too long :)
10:16:49 <beelze> and about libpurple — it was removed as said before
10:17:03 <flo-retina> never said that
10:17:32 <flo-retina> it's the option to use the libpurple found in the system that never worked
10:18:11 <beelze> oh, yes — my mistake :) 
10:21:15 <flo-retina> by the way, is xulrunner still available on gentoo? Is the Firefox ebuild using it?
10:21:36 <beelze> xulrunner was removed form the official tree
10:25:06 <beelze> Never used Firefox, but «xul» is not mentioned in FF ebuild — so I assume it use built-in implementation
10:28:11 <-- Tonnes has quit (Quit: ChatZilla 0.9.90 [Firefox 19.0.2/20130307023931])
10:33:26 --> Simone has joined #instantbird
10:34:08 <-- Simone has left #instantbird ()
10:36:18 <flo-retina> I think firefox still uses xulrunner on debian, but I could be wrong :)
10:38:39 --> Tonnes has joined #instantbird
10:42:28 <beelze> by the way, «2 #ifdefs to gfx/thebes/gfxPlatform.cpp» patch from https://bugzilla.mozilla.org/show_bug.cgi?id=722975 solved «cairo_null_surface_create» error. At least for cairo-1.10
10:43:19 <flo-retina> :)
11:18:03 --> mpmc has joined #instantbird
11:39:54 --> rosonline has joined #instantbird
11:41:33 <-- jb has quit (Ping timeout)
11:45:20 --> jb has joined #instantbird
11:45:24 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
11:49:18 <-- jb has quit (Ping timeout)
11:51:12 --> jb has joined #instantbird
11:55:19 --> jb1 has joined #instantbird
11:55:34 <-- jb has quit (Ping timeout)
11:59:45 <-- jb1 has quit (Ping timeout)
12:07:03 --> jb has joined #instantbird
12:11:17 <-- jb has quit (Ping timeout)
12:13:21 --> jb has joined #instantbird
12:13:27 <-- jb has quit (Excess Flood)
12:13:32 --> jb has joined #instantbird
12:19:08 --> jb1 has joined #instantbird
12:19:55 <-- jb has quit (Ping timeout)
12:19:57 --> jb has joined #instantbird
12:22:28 <-- jb1 has quit (Max SendQ exceeded)
12:34:12 --> clokep has joined #instantbird
12:34:12 * ChanServ sets mode +o clokep 
12:35:39 <-- deltafalcon has quit (Connection reset by peer)
12:36:53 --> unghost has joined #instantbird
13:08:50 <clokep> instantbot: uuid
13:08:51 <instantbot> bc540cab-a6e9-4c2c-abff-e95d0d1370a1 (/msg instantbot cid for CID form)
13:20:09 --> Mic has joined #instantbird
13:20:09 * ChanServ sets mode +h Mic 
13:21:42 <-- unghost has quit (Ping timeout)
13:22:46 --> unghost has joined #instantbird
13:26:34 <-- jb has quit (Ping timeout)
13:31:46 <Mic> Maybe the placeholder text could change depending on the situation, e.g. telling you that your conversational partner is writing a message at the moment?
13:31:55 <Mic> http://i.imgur.com/JDyCeom.png
13:32:15 --> jb has joined #instantbird
13:32:22 --> jb1 has joined #instantbird
13:32:32 <-- jb1 has quit (Excess Flood)
13:32:38 --> jb1 has joined #instantbird
13:36:36 <-- jb has quit (Ping timeout)
13:38:17 <-- jb1 has quit (Ping timeout)
13:38:19 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2299 on bug 1050.
13:38:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1050 nor, --, ---, clokep, ASSI, Take account of URL shortening in twitter character count
13:38:42 * clokep guesses Mic and aleth might want to see that patch...
13:38:45 <clokep> About the sendTyping changes.
13:39:15 --> jb has joined #instantbird
13:42:21 <clokep> flo-retina: Did you come up w/ a good way to test bug 1906?
13:42:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1906 nor, --, ---, florian, NEW, Keep the 50 debug log messages just before a disconnection with an error, even after the account is 
13:42:26 <-- jb has quit (Connection reset by peer)
13:44:05 --> jb has joined #instantbird
13:47:55 --> jb1 has joined #instantbird
13:48:51 <Mic> clokep: how fast do you expect this to land?
13:48:57 <-- jb has quit (Ping timeout)
13:49:02 <clokep> Mic: Soon?
13:49:24 <Mic> My patch in bug 260 is touching the same code (typing notifications) in conversation.xml.
13:49:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=260 min, --, ---, benediktp, ASSI, Pasting in the conversation input box doesn't send typing notifications
13:49:52 <clokep> Mic: Yes, I know.
13:49:54 <Mic> One would bitrot the other, so if your's is going to land soon, I wait with mine
13:50:18 <Mic> *yours
13:50:26 <clokep> Mic: We'll see which gets an r+ first. Don't worry about it yet.
13:50:36 <clokep> Mic: Looks like yours just copies and pastes a bock of code anyway?
13:51:50 <Mic> Yes
13:52:02 <clokep> Then I'm not too concerned about it. :)
13:52:04 <clokep> But thanks for the heads up.
13:52:30 <clokep> Was the setTimeout / executeSoon / etc. decided on?
13:53:50 <flo-retina> I think we decided to go with an additional boolean
13:53:57 <Mic> Yes, we did
13:54:14 <clokep> But that won't affect my patch, right?
13:54:18 <flo-retina> clokep: so typing /quote quit is actually a good way to test the debug log patch
13:54:21 <clokep> Just when sendTyping gets called?
13:54:35 <flo-retina> clokep: for some reason moznet doesn't want me to reconnect after that if I don't use SSL. With SSL it reconnects fine.
13:54:36 <clokep> flo-retina: OK, thanks. And what exact behavior am I expecting?
13:55:22 <clokep> Weird.
13:55:57 <flo-retina> you are expecting to have "(<number of messages omitted since the connection attempt started> messages omitted)" then 50 debug messages including the last one before the unexpected (by the prpl) disconnection. Then "(<number of omitted messages> since the beginning of the reconnection attempt)", then the 50 most recent debug messages
13:56:07 <flo-retina> well, that's the behavior I implemented
13:56:14 <clokep> OK.
13:56:19 <flo-retina> if you expect something else, please explain in the bug what you expect :)
13:56:22 <clokep> I'll take a look soonish.
13:56:30 <flo-retina> I had a hard time defining what I thought was a decent expected behavior
13:56:56 <flo-retina> clokep: btw, I'm surprised that after cleanly disconnecting an IRC account there are 2 messages in the log. Apparently IRC accounts log messages after calling reportDisconnected() :(
13:57:11 <clokep> flo-retina: I saw you think we should add a return. I think you're right.
13:57:48 <flo-retina> Mic: I think changing the text of the placeholder is a good idea, but using it for typing notification doesn't seem exactly right as it's some information that's useful even if the input box isn't mepty.
13:58:11 <flo-retina> clokep: that's unrelated. Just something I noticed while trying to understand where these 2 messages where coming from.
13:58:20 <flo-retina> *were
13:58:45 <flo-retina> Mic: I would like to integrate Status Reminder by default, and I think it would be nice to change the placeholder to explain what the current color means.
13:59:01 <-- jb1 has quit (Ping timeout)
13:59:14 <flo-retina> Mic: the reason I'm reluctant to include Status Reminder as-is is that the colors could be confusing if there's no obvious way to discover what the mean
13:59:22 <clokep> flo-retina: Maybe we should file a bug on it then? :)
13:59:41 <flo-retina> is "it" the missing return, or the 2 messages?
14:00:16 <flo-retina> the only way I saw to fix the 2 messages being after the reportDisconnected call is an executeSoon call :(
14:00:28 <Mic> flo-retina: yes, a message might help then :)
14:01:39 --> jb has joined #instantbird
14:01:45 <clokep> flo-retina: Oh, I misunderstood what you said earlier.
14:02:15 <clokep> What messages are logged after disconnecting?
14:02:32 <clokep> Is it really "wrong" that they'r elogged?
14:02:43 <-- jb has quit (Excess Flood)
14:04:02 <flo-retina> clokep: http://pastebin.instantbird.com/162401
14:05:01 <flo-retina> clokep: well, it's not awfully wrong, but it's "unexpected". I don't expect prpls to execute any code after the account is in the "disconnected" state.
14:05:31 <clokep> So maybe the point we're marking it as "disconnected" is wrong.
14:05:46 --> jb has joined #instantbird
14:06:25 <flo-retina> hmm, possibly yes
14:08:16 --> Kaishi has joined #instantbird
14:09:59 <-- jb has quit (Ping timeout)
14:11:44 --> jb has joined #instantbird
14:13:59 <clokep> flo-retina: My only comment is it's really hard to separate the sessions.
14:14:34 <flo-retina> clokep: is that about the debug log?
14:14:41 <clokep> flo-retina: Yes.
14:14:42 <-- jb has quit (Excess Flood)
14:14:44 <flo-retina> clokep: I think it was as hard before the patch
14:15:10 <flo-retina> it may even be a little bit improved: just type Ctrl-F "omitted"
14:15:49 <flo-retina> I think what we really need though is to export the log in a JSON format, and to have an HTML page it to show it with colors, and clickable links..
14:15:53 <clokep> flo-retina: Ah, I see now. OK.
14:16:04 <clokep> Yeah, I think you're right. That would help a lot.
14:18:12 <flo-retina> so, there are still lots of things that need to be improved with debug logs
14:18:43 <flo-retina> the issue I'm trying to fix here is: "if my account got disconnected for an unknown reason, and immediately reconnected successfully, I've no way to see what happened"
14:18:54 * flo-retina is going to be away for an hour or two.
14:19:27 <clokep> Yeah.
14:19:53 <clokep> I need to look at the code, but I think it's OK.
14:23:56 --> jb has joined #instantbird
14:33:04 <instantbot> clokep@gmail.com granted review for attachment 2297 on bug 1906.
14:33:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1906 nor, --, ---, florian, NEW, Keep the 50 debug log messages just before a disconnection with an error, even after the account is 
14:34:45 --> aleth has joined #instantbird
14:34:45 * ChanServ sets mode +h aleth 
14:39:32 <clokep> Mic: You said you were looking at making the message count a "panel" was this over the input box or the conversaiton?
14:40:35 <Mic> No, I said that I'm slowly getting annoyed enough ;)
14:43:17 <clokep> Ahhhh. I see. :)
14:46:47 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
14:50:08 --> clokep has joined #instantbird
14:50:08 * ChanServ sets mode +o clokep 
14:51:39 <clokep> You know I probably should have backed up my profile before running it in my debug build...
14:53:53 <clokep> aleth: If you didn't see in the logs, I put up a patch for the Twitter URL shortening stuff, that affects M ic's bug 260 that you guys were discusisng yesterday.
14:53:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=260 min, --, ---, benediktp, ASSI, Pasting in the conversation input box doesn't send typing notifications
14:55:19 <-- jb has quit (Ping timeout)
14:56:23 <instantbot> aleth@instantbird.org denied review for attachment 2295 on bug 260.
14:56:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=260 min, --, ---, benediktp, ASSI, Pasting in the conversation input box doesn't send typing notifications
14:57:25 <aleth> clokep: Thanks. Whatever gets r+ first lands first I guess ;) I can't see any serious conflicts there as Mic's patch isn't touching the logic that calls sendTyping.
14:58:01 <clokep> aleth: Yes, I agree.
14:58:25 <aleth> clokep: It'll be great to have that bug fixed btw
14:59:27 <-- rosonline has quit (Ping timeout)
14:59:42 <aleth> I had it on my todo list as well as I got some complaints about "your twitter character counter doesnt work right"
15:00:10 <clokep> Oh? From friends?
15:00:16 <aleth> Yup.
15:00:31 <clokep> Tell them it's getting fixed? :P
15:00:37 <Mic> There's no serious conflicts there, I just don't want to update and test the patch twice, so I'll rather wait until cloke p's is finished (so he doesn't have to do it either).
15:00:39 <aleth> If you often send links you will notice, apparently ;)
15:00:55 --> jb has joined #instantbird
15:00:56 <aleth> clokep: I told them to cc to the bug but they didn't :P
15:01:21 <clokep> Why would they do that when they can just bug you? :P
15:01:33 <aleth> Pretty much :D
15:01:37 <clokep> I frequently run into the issue when posting links to bugs on Twitter, so I figured I should actually buckle down and fix it.
15:01:42 <clokep> Feel free to review it btw.
15:03:08 <clokep> (Or look it over or whatever.)
15:03:16 <clokep> In particular the IRC parts.
15:03:34 <aleth> OK
15:05:51 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
15:06:20 --> clokep has joined #instantbird
15:06:20 * ChanServ sets mode +o clokep 
15:06:46 --> rosonline has joined #instantbird
15:10:03 <-- clokep has quit (Ping timeout)
15:14:47 --> clokep has joined #instantbird
15:14:48 * ChanServ sets mode +o clokep 
15:15:21 <-- clokep has quit (Connection reset by peer)
15:15:39 --> clokep has joined #instantbird
15:15:39 * ChanServ sets mode +o clokep 
15:20:46 <aleth> Managed to patch MathJax into a version that crashed IB. Guess that didn't fix the bug then :-/
15:22:44 <clokep> You might have fixed the bug and caused another! :)
15:25:45 <aleth> Hard to tell at this point ;)
15:33:29 <-- jb has quit (Ping timeout)
15:47:33 --> jb has joined #instantbird
15:49:45 <-- jb has quit (Ping timeout)
15:50:01 --> jb has joined #instantbird
15:52:31 <-- jb has quit (Ping timeout)
15:57:21 --> jb has joined #instantbird
16:02:38 <-- jb has quit (Ping timeout)
16:14:21 --> mconley has joined #instantbird
16:27:48 <aleth> clokep: Since we automatically add linebreaks for IRC where necessary, do we even need to expose a counter to the user?
16:28:07 <clokep> aleth: Absolutely.
16:28:11 <clokep> (Well maybe not.)
16:28:21 <clokep> We added it before we handled linebreaks.
16:28:22 <clokep> And splitting of messags.
16:28:29 <clokep> Which is the part that would allow us to not expose the counter.
16:28:32 <clokep> The line breaks don't matter.
16:28:35 <aleth> Yes, I'm wondering if we shouldn't just remove it.
16:28:53 <aleth> I meant s/line breaks/message splitting 
16:29:47 <aleth> Since we just take care of long messages automatically now ;)
16:30:54 * flo-retina likes to know in advance if his message will be sent as one or split
16:31:07 <flo-retina> if it's long I prefer inserting the linebreaks myself between the sentences
16:31:29 <aleth> In that case the behaviour in clokep's patch is the right one.
16:32:04 <aleth> As you don't care about multiple split messages, you care about the first split only.
16:34:12 <flo-retina> aleth: I thought we agreed to split the messages at line breaks and to return the value for the longest of them
16:35:31 <clokep> I wanted to get the rest of the patch up for review.
16:35:34 <aleth> Is that intuitive?
16:35:58 <clokep> I don't think so...another reason I didn't implement i tbtw.
16:36:07 <flo-retina> clokep: Math.max.apply(null, aString.split("\n").map(this._account.countBytes))
16:37:22 <-- mconley has quit (Input/output error)
16:41:07 <flo-retina> clokep: so if taking the max is confusing, the only other possible behaviors that would make sense that I can think of is counting only the chars before the first line break
16:42:10 <clokep> flo-retina: I'm not sure if it is confusing or not, just saying it might be. :)
16:48:16 <flo-retina> I think I'll like the behavior with Max()
16:49:11 <flo-retina> but if that's a follow up it's OK with me (just seemed a bit sad that the "// XXX Figure out what to do when there are line breaks." line is as long as the code needed to handle it ;))
16:49:36 <aleth> I have no strong opinion on this (would need to try it out). "counting only the chars before the first line break" I'm not sure makes sense, I would have thought "after the last linebreak"
16:56:00 <flo-retina> clokep: do you have a diff of that twitter-text.jsm file against the original file provided by twitter?
16:56:09 <instantbot> aleth@instantbird.org granted feedback for attachment 2299 on bug 1050.
16:56:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1050 nor, --, ---, clokep, ASSI, Take account of URL shortening in twitter character count
16:56:12 <clokep> flo-retina: I can provide one.
16:56:24 <clokep> I commented out like 4 lines and added the license.
16:56:50 <aleth> Right, worth keeping that for future updates :)
16:57:27 <aleth> (I see that file was last updated 13 days ago...)
16:58:36 <flo-retina> so, do we really have to have the full license there? (isn't there a small boiler plate for the Apache license somewhere?)
16:58:54 <flo-retina> and what was the reason for commenting these lines?
16:59:17 <clokep> Bah...wget doesn't work with github...
16:59:55 <clokep> flo-retina: One second.
16:59:58 <clokep> Getting you a diff.
17:00:00 <flo-retina> github... :)
17:00:17 <clokep> (I've run into their invalid certs before btw...)
17:00:31 <aleth> oh yes, that's fun too.
17:00:43 <clokep> flo-retina, aleth: http://pastebin.instantbird.com/162479
17:00:57 <clokep> The anonymizing function stuff didn't seem to work inside a jsm, but I didn't debug it.
17:01:58 <flo-retina> wget has an option to skip cert checking
17:02:11 <aleth> What is the point of such an anonymizing function?
17:03:41 <aleth> (genuine question - is that to mimic a jsm without a jsm?)
17:04:58 <clokep> aleth: I believe it's more of like an #ifdef in .h files: http://lxr.instantbird.org/instantbird/source/purple/libpurple/connection.h#27
17:05:07 <clokep> Making sure something is only defined once in a context.
17:06:06 <aleth> clokep: Thanks
17:06:48 <-- beelze has quit (Ping timeout)
17:06:48 <clokep> Yeah. :-/ I dislike code like that btw.
17:07:18 <flo-retina> clokep: where does the window object come from for code?
17:07:19 <aleth> It's all over Mathjax too :-/
17:07:29 --> beelze has joined #instantbird
17:07:35 <flo-retina> (lines 213 and later of your pastebin)
17:08:01 <flo-retina> *for that code
17:08:15 <clokep> flo-retina: That should be commented out / removed too, I'd guess.
17:11:48 <flo-retina> could we keep the twitter code untouched, and just add a var window = null; before it? and a var twttr = window.twttr; after it?
17:12:06 <clokep> Hmm....we could probably do that.
17:12:14 <flo-retina> and then wrap the code from twitter in comments saying clearly that this code shouldn't be edited, and a link to where we can download an updated copy?
17:12:20 <clokep> Is there a Apache 2.0 license header btw? I'll need to check.
17:12:52 <clokep> http://mxr.mozilla.org/mozilla-central/source/b2g/app/BootAnimation.cpp#1 maybe
17:14:02 <flo-retina> fine with me :)
17:15:13 <aleth> clokep: Apache also requires modified files to be clearly marked as such
17:15:25 <aleth> So maybe add a comment up top.
17:15:58 <clokep> aleth: Thanks.
17:17:10 <flo-retina> aleth: what does "modified files" mean? It's still Apache-licensed
17:18:01 <aleth> flo-retina: "You must cause any modified files to carry prominent notices stating that You changed the files;"
17:18:13 <flo-retina> uh,ok
17:19:06 <aleth> clokep: https://www.apache.org/licenses/LICENSE-2.0.html section 4 might also be worth a look before removing too many comments 
17:19:27 <flo-retina> clokep: so to get tshirts printed, we need to: 1. Find someone to design them, and agree on the design. 2. Decide on which side of the ocean we want to get them printed (if not both).
17:19:52 <flo-retina> clokep: also, see if we want to try to sell them (a few enthusiastic users may want some) or keep them just for frequent contributors
17:20:00 <clokep> flo-retina: I'd guess that "both" makes the most sense, international shipping is awfully expensive IIRC.
17:21:05 --> gerard-majax_ has joined #instantbird
17:21:06 <flo-retina> I think it's awfully expensive if we wanted to ship just one t-shirt. But if we want to print a lot, and send dozens in a single package, the price of shipping may be canceled by volume discounts
17:21:16 <flo-retina> I really don't know if we are talking about printing 5 or 100
17:21:28 <-- gerard-majax__ has quit (Ping timeout)
17:21:44 <flo-retina> if it's 5, we could just upload some design to a website that prints them on-demand when someone orders one (I think that was done for Pidgin at some point)
17:22:07 <aleth> Wearing a TB shirt certainly makes for interesting conversations :)
17:22:18 --> mconley has joined #instantbird
17:22:22 <flo-retina> aleth: :)
17:22:47 <flo-retina> aleth, clokep: maybe we should write something on it that engages conversations more than the logo
17:23:15 <Mic> "Oh, cool! Do you like birds?"
17:23:18 * flo-retina wonders if there could be interesting quotes from http://www.instantbird.org/en/
17:23:31 <flo-retina> Mic: sure, I do :-P
17:24:23 <flo-retina> or maybe "Instant messaging has never been easier!" from ib.com
17:24:39 <aleth> "just add water" :P
17:24:44 <flo-retina> or "IM's never been easier!"
17:25:04 <flo-retina> (if the char limit is worse than on twitter)
17:25:11 <clokep> flo-retina: The TB t-shirt I have is decent, it has just the logo on the front, mozilla.com on the sleeve and some quote on the back
17:25:46 <clokep> aleth: apache.org/licenses seems to be down for me.
17:26:51 <aleth> clokep: wfm, but http://pastebin.instantbird.com/162490
17:27:03 <clokep> aleth: Oh, just the license? OK.
17:27:19 <-- Mic has quit (Quit: No time to waste, let's go!)
17:27:24 <-- mconley has quit (Connection reset by peer)
17:27:33 <clokep> aleth: So "You must cause any modified files to carry prominent notices stating that You changed the files"?
17:27:43 --> mconley has joined #instantbird
17:28:03 <aleth> Right.
17:33:32 <clokep> aleth: Thanks for the comments in bug 1050 btw.
17:33:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1050 nor, --, ---, clokep, ASSI, Take account of URL shortening in twitter character count
17:34:10 <clokep> flo-retina, aleth: In terms of a design, I just assumed we'd pretty much choose a color and throw the Instantbird logo on it. ;) But I have no taste for design so...we'd probably want to find someone to do it for us, unless one of you are willing to?
17:34:57 <flo-retina> the one I have is pretty basic: http://blog.queze.net/nocomm281.html
17:36:29 <aleth> Just picking a different base colour than white would improve it, e.g. unbleached cotton
17:37:12 <clokep> I personally like the big logo on the front https://skydrive.live.com/?cid=1b9f013d2e038824&id=1B9F013D2E038824!142&sff=1&authkey=!AMsqd_eATnjLexo
17:39:10 <aleth> You could have Instantbird on the sleeve (though that might be expensive?)
17:42:45 <clokep> flo-retina, aleth: http://pastebin.instantbird.com/162496 is my current twitter-text.jsm
17:43:34 <flo-retina> "// End the imported code" missing an "of" there, right?
17:43:51 <clokep> Oops, yes.
17:44:03 <flo-retina> seems good to go (I haven't reviewed the code from twitter)
17:44:22 <clokep> OK! :)
17:44:22 <aleth> Looks good
17:44:30 <clokep> Should the twttr at the end be const instead of var?
17:44:50 <aleth> Do you need to add a var module = ... up top as well just to be on the safe side?
17:44:53 <flo-retina> possibly, but it's not important at all
17:45:00 <beelze> (building IB) can these warnings be ignored: http://pastebin.com/Zb6SSwJe ?
17:45:07 <clokep> aleth: What?
17:45:18 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4f0d30a29387 - Florian Quèze - Bug 1906 - Keep the 50 debug log messages just before a disconnection with an error, even after the account is reconnected, r=clokep.
17:45:19 <aleth> (re line 1338) Not that it matters.
17:45:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/9461ba5e15ca - aleth - Bug 1902 - Change behaviour around unhandled CTCP messages - follow-up to fix the target the ERRMSG is sent to, r=clokep.
17:45:24 <clokep> beelze: I usually ignore any warning in libpurple. ;)
17:46:14 <clokep> aleth: No, we don't want module defined so that code won't run.
17:46:18 <flo-retina> aleth: ignore :)
17:46:54 * clokep wonders if that was supposed to be pointed to bee lze.
17:47:01 <aleth> Probably.
17:47:09 <instantbot> clokep@gmail.com set the Resolution field on bug 1906 to FIXED.
17:47:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1906 nor, --, 1.4, florian, RESO FIXED, Keep the 50 debug log messages just before a disconnection with an error, even after the account is 
17:49:00 <beelze> clokep: I'm writing an ebuild for official Gentoo tree so I trying to be careful
17:50:05 <flo-retina> clokep: oh yes it was
17:50:28 <flo-retina> clokep: a leth and b eelze's colors are close enough that I didn't notice someone else started talking :)
17:54:45 <instant-buildbot> build #366 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/366  blamelist: aleth <aleth@instantbird.org>, Florian Qu?ze <florian@instantbird.org>
17:57:54 <beelze> maybe I missed answer about warnings? http://pastebin.com/Zb6SSwJe :)
17:58:28 <flo-retina> ignore them :)
18:01:11 <beelze> ok, thanks
18:02:01 <clokep> aleth: Ah, you seem to be right about that math.min, thanks.
18:04:18 <-- rosonline has quit (Client exited)
18:08:41 <-- aleth has quit (Connection reset by peer)
18:08:55 --> aleth has joined #instantbird
18:08:56 * ChanServ sets mode +h aleth 
18:11:36 * flo-retina is trying to use osfile.jsm
18:12:05 <flo-retina> it would be nice if TextEncoder() was documented
18:12:21 <flo-retina> it may be a good way to replace the awful APIs we currently use to convert things to/from UTF8
18:15:53 * clokep wants to be able to pipe hg diff directly to pastebin.instantbird.org.
18:16:40 <clokep> aleth: I couldn't figure out how to use Math.min still, does http://pastebin.instantbird.com/162512 seem reasonable?
18:16:51 <flo-retina> Standard8 has a script to do that to diff.pastebin.mozilla.org
18:17:10 <clokep> Oh? I might need to ask him for it
18:18:35 <aleth> clokep: My comment was actually meant to suggest that you don't use it and replace it with an extra boolean in the if clause, so yes :)
18:24:31 <-- gerard-majax_ has quit (Ping timeout)
18:24:35 --> gerard-majax_ has joined #instantbird
18:29:15 * aleth likes it when different pages of documentation contradict each other
18:32:55 <flo-retina> "ERROR resource://gre/modules/osfile/osfile_async_front.jsm:106
18:32:56 <flo-retina>                      Error: Queue is empty" is all I can seem to get from OS.File.DirectoryIterator :(
18:34:01 <clokep> :( What are you trying to use osfile for?
18:35:28 <-- beelze has quit (Ping timeout)
18:35:37 <flo-retina> avoiding main thread I/O for some of the logic related to logs
18:37:01 * aleth hopes to get some feedback on bug 1732 before any major changes to logger.js
18:37:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1732 enh, --, ---, aleth, ASSI, Port the log tree and concatenated daily logs from TB
18:37:48 <flo-retina> heh
18:40:17 <flo-retina> aleth: looking now
18:42:01 <aleth> thanks :)
18:42:32 <flo-retina> seems like messing with div#insert in convbrowser isn't useful
18:42:45 <flo-retina> this._lastMessage = null; should be enough to get the insert node ignored
18:43:30 <aleth> Oh, right. That's duplication.
18:43:32 <flo-retina> ruler.id = "sessionstart-ruler"; that's meant to be a classname, right?
18:43:45 <aleth> flo-retina: Yes
18:45:10 --> Mnyromyr has joined #instantbird
18:49:45 <clokep> aleth: Is a comment like "// Twitter's current configuration, received in response to an API call." good enough above "config" for twitter?
18:51:15 <aleth> clokep: I don't think "Twitter's current configuration" is clear
18:51:28 <flo-retina> aleth: why have you removed the "return;", added a "else" and indented the whole end of the onselect function?
18:51:44 <clokep> aleth: I'm unsure what else to call it...
18:51:55 <flo-retina> clokep: that's clear for me
18:52:20 <flo-retina> clokep: so if it still isn't clear for others, your best bet is probably a link to the twitter API doc of config
18:52:28 <aleth> clokep:  "Twitter's current internal configuration" maybe? as opposed to something we set?
18:53:25 <aleth> flo-retina: To make the code clearer to read.
18:53:52 <aleth> I guess ymmv on that ;)
18:54:04 <flo-retina> that's not clearer
18:54:27 <aleth> It's not an early return, it's an either-or.
18:54:27 <flo-retina> if you want to make clearer, you should add a comment saying "If we are here, we are dealing with a legacy plain text log."
18:55:28 <flo-retina> all right
18:55:42 <flo-retina> well, add a comment anyway :-P
18:55:44 <aleth> Doing that instead is fine by me if you prefer.
18:55:59 <clokep> aleth: "  // Twitter's current internal configuration, received in response to an API call, see https://dev.twitter.com/docs/api/1.1/get/help/configuration."?
18:56:10 <aleth> clokep: great :)
18:56:47 <aleth> flo-retina: Ignore the styling of the new ruler btw, unless you have some good ideas :)
18:57:13 <flo-retina> aleth: well, you can keep the current change if you want
18:57:14 <aleth> That's for followups...
18:57:45 <flo-retina> aleth: but if you thought it was confusing, do add a comment (whether you change the indentation or not)
18:57:54 <aleth> The screenshots I was asking about were about where to put the text, so feedback on that would be welcome
18:58:05 <aleth> flo-retina: OK
19:02:26 <flo-retina> aleth: why is this code doing |let stream = inputStream.stream; stream.readLine| when before inputStream.readLine was enough?
19:02:40 <flo-retina> nit: the indentation is wrong after |let sessionMsg = {|
19:03:25 <aleth> flo-retina: inputStream is now an object that also contains the filename.
19:03:38 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 2299 on bug 1050.
19:03:39 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2300 on bug 1050.
19:03:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1050 nor, --, ---, clokep, ASSI, Take account of URL shortening in twitter character count
19:04:06 <flo-retina> "let dateForID = new Date(logDate), dayID;" is strange
19:04:12 <flo-retina> aleth: ok
19:05:54 <flo-retina> dayID = dateForID.toISOString() + "txt"; is strange. Is this something that will be visible to the user?
19:06:26 <aleth> flo-retina: No, it's not user visible
19:08:05 <flo-retina> declare dayID on a separate line, it will be less confusing
19:08:23 <aleth> OK
19:10:31 <flo-retina> aleth: showing the time inside the ruler seems to make more sense. For Bubbles at least
19:10:59 <aleth> flo-retina: It's a Bubbles-specific question, yes.
19:11:32 <flo-retina> well, inside the ruler is the time between the sessions
19:11:40 <flo-retina> above the ruler is the time between the last message and the end of the session
19:11:44 <aleth> The problem is we don't know the time between sessions.
19:11:47 <flo-retina> or do we not have the "end of session" information?
19:11:50 <aleth> We don't save the session end time.
19:12:01 <flo-retina> that sucks
19:12:05 <aleth> Yes.
19:12:09 <aleth> But it's a separate bug imho.
19:12:23 <flo-retina> well, sessions don't fully make sense anyway
19:12:39 <flo-retina> I think we should stop the log file when there was 20 minutes without anything said for private conversations
19:12:48 <flo-retina> anyway. I think I prefer "inside the ruler"
19:13:43 <aleth> There's a couple of things that could be improved about "sessions"
19:13:55 <aleth> Date changes are not handled well either, I think we have a bug for that
19:13:58 <flo-retina> http://log.bezut.info/instantbird/130324#m375 (to get a correct link from M ic's add-on)
19:14:22 <flo-retina> aleth: we do
19:14:23 <instantbot> florian@instantbird.org granted feedback for attachment 2209 on bug 1732.
19:14:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1732 enh, --, ---, aleth, ASSI, Port the log tree and concatenated daily logs from TB
19:14:52 <aleth> Thanks!
19:15:08 <aleth> Oh, what's the right file for the error string for logger.js and how do I include it?
19:15:25 <flo-retina> what does that string need to say?
19:15:30 <-- gerard-majax_ has quit (Quit: Ex-Chat)
19:15:35 --> gerard-majax__ has joined #instantbird
19:15:50 <flo-retina> "Empty or corrupt log file: " + inputStream.filename; ?
19:15:59 <aleth> flo-retina: Yes
19:16:27 <flo-retina> is there an existing string bundle that seem attractive to you?
19:17:07 <aleth> The other log-related strings are in instantbird.properties, but that's not in chat
19:17:23 <flo-retina> conversations.properties seems "possible"
19:17:27 <flo-retina> otherwise just create a new one
19:17:43 <aleth> A new one seems a bit excessive for a single string.
19:17:45 <flo-retina> logger.properties or whatever seems good to you
19:17:58 <flo-retina> won't there be more later? ;)
19:18:05 <flo-retina> anyway, away for diner
19:18:38 <aleth> Who knows ;)
19:19:45 <clokep> aleth: I think making a new one is fine.
19:21:18 <-- aleth has quit (Quit: Ciao)
19:21:25 --> aleth has joined #instantbird
19:21:26 * ChanServ sets mode +h aleth 
19:24:08 --> Mic has joined #instantbird
19:24:09 * ChanServ sets mode +h Mic 
19:33:31 --> EionRobb has joined #instantbird
19:38:05 <Mic> clokep: your Thunderbird shirt is much like I imagined an IB one :)
19:38:58 <Mic> No text on the front, just a larger logo. The product name/Instantbird on the back, with the correct IB font.
19:39:47 <Mic> A tan background might look good (like on the webpage) but that might depend strongly on ones taste ;)
19:40:23 <clokep> My TB one is off-white actually.
19:41:48 <Mic> clokep: thanks for the "Execute Javascript" macro, it works well!
19:42:22 <Mic> The reported line numbers are off by one, though ;)
19:42:23 <clokep> Mic: You're welcome. :) Btw it specifically doesn't allow access to Components, but sometimes I feel like I should enable that.
19:42:45 <clokep> I don't know if you've looked through the code, but there's a few things available in the API (print, props, at least.)
19:43:02 <clokep> Ah, clear too.
19:43:08 <Mic> I've used clear/print already.
19:43:17 <Mic> props sounds very useful, too.
19:43:50 <aleth> clokep: off-white is just unbleached cotton usually.
19:43:52 <clokep> I always forget it exists and do print(JSON.stringify(obj))
19:44:08 <clokep> Mic: Also, if you highlight a section of JS it'll execute only the highlighted code.
19:46:04 <-- mconley has quit (Input/output error)
19:48:00 <aleth> (I mentioned that because it may be cheaper than custom colours)
19:48:05 <-- aleth has quit (Quit: Ciao)
19:49:12 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
19:55:09 --> FireFly_TB has joined #instantbird
20:07:08 <-- FireFly_TB has quit (Quit: FireFly_TB)
20:08:20 --> FireFly_TB has joined #instantbird
20:27:09 --> mconley has joined #instantbird
21:08:58 --> jb has joined #instantbird
21:14:45 <-- gerard-majax__ has quit (Ping timeout)
21:19:59 <-- jb has quit (Ping timeout)
21:32:51 --> jb has joined #instantbird
21:32:54 <-- jb has quit (Input/output error)
21:33:00 --> jb has joined #instantbird
21:41:02 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:51:55 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:55:04 --> jb1 has joined #instantbird
21:55:16 <-- jb has quit (Connection reset by peer)
21:55:52 <-- FireFly_TB has quit (Ping timeout)
21:57:38 <-- jb1 has quit (Ping timeout)
22:05:58 <-- Mic has quit (Quit: No time to waste, let's go!)
22:06:48 --> jb has joined #instantbird
22:17:51 <-- jb has quit (Ping timeout)
22:18:03 --> jb has joined #instantbird
22:18:22 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
22:19:48 <-- mconley has quit (Input/output error)
22:20:44 <-- jb has quit (Ping timeout)
22:33:41 --> jb has joined #instantbird
22:38:47 --> jb1 has joined #instantbird
22:40:03 <-- jb has quit (Ping timeout)
22:42:39 <-- jb1 has quit (Ping timeout)
22:45:02 --> Mic has joined #instantbird
22:45:02 * ChanServ sets mode +h Mic 
22:45:21 <-- Mic has quit (Quit: No time to waste, let's go!)
22:48:50 --> jb has joined #instantbird
22:59:24 <-- jb has quit (Ping timeout)
23:09:16 --> jb has joined #instantbird
23:12:26 <-- Kaishi has quit (Quit: Kaishi)
23:21:11 <-- jb has quit (Ping timeout)
23:21:21 --> mconley has joined #instantbird
23:27:14 --> jb has joined #instantbird
23:27:29 <-- mconley has quit (Ping timeout)
23:35:05 <-- jb has quit (Connection reset by peer)
23:52:23 --> jb1 has joined #instantbird
23:53:55 <-- Optimizer has quit (Ping timeout)
23:54:11 --> jb has joined #instantbird
23:55:14 <-- jb1 has quit (Ping timeout)