All times are UTC.
00:02:33 <clokep> flo-retina: I'm reviewing it now. 00:02:39 <clokep> Are those exact copies of the browser/ files? 00:03:00 <clokep> Ah, except for the include. 00:03:05 <flo-retina> not "exact", but close 00:03:06 <flo-retina> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/softwareUpdateOverlay.xul 00:03:12 <flo-retina> I changed line 6 and 14 00:03:53 <instantbot> clokep@gmail.com granted review for attachment 2278 on bug 1898. 00:03:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1898 tri, --, ---, florian, NEW, Missing menus on the Error Console and Software Update windows 00:04:13 <instantbot> clokep@gmail.com requested review from the wind for attachment 2279 on bug 1563. 00:04:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1563 min, --, ---, nobody, NEW, Remove WINCE support 00:13:33 <flo-retina> seems ok-ish 00:13:45 <flo-retina> do you have other patches coming in that bug or is that 'it'? 00:16:14 <clokep> I have other ones coming. 00:28:10 <flo-retina> clokep: http://pastebin.instantbird.com/157354 This looks like the list of changesets that were created directly or indirectly to add support for WinCE. 00:28:23 <clokep> flo-retina: Cool. Thanks. 00:28:42 <flo-retina> a significant portion of them should likely be reverted (to reduce the differences we have against the official libpurple and glib) 00:29:04 <clokep> Since you're still here... 00:29:20 <clokep> ifneq (,$(filter WINNT WINCE,$(OS_ARCH))) .... endif; that would run for WINNT or WINCE, right? 00:29:28 <clokep> (I'm always confused by filter and filter-out. :( 00:29:49 <flo-retina> and ifneq vs ifeq ;) 00:30:17 <flo-retina> yes, that would run on NT or CE 00:30:25 <clokep> OK. 00:30:38 <clokep> But if it was ifeq (,$(filter-out WINNT WINCE,....)) 00:30:40 <clokep> That would be the same hting? 00:30:47 <clokep> Well similar, not exactly the same. 00:30:52 <flo-retina> yes 00:31:20 <clokep> Weird. 00:32:27 <Mook_as> the first one is better in that it won't run if OS_ARCH is empty :D 00:36:01 <clokep> Ah, at least there's a reason for it. :) 00:37:02 <flo-retina> I attached the list of changesets to the bug to be sure I won't have to look in that hg log again if the pastebin expires 00:37:20 <flo-retina> I'm already sad enough when seeing all that wasted energy 00:38:41 <clokep> :) You should go to bed. ;) 00:40:34 <flo-retina> heh, linux and windows nightlies have already started! 00:40:53 <instant-buildbot> build #385 of linux-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/385 blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com> 00:40:57 <instant-buildbot> build #371 of win32-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/371 blamelist: Florian Qu?ze <florian@instantbird.org>, Patrick Cloke <clokep@gmail.com> 00:41:35 <flo-retina> I should have cancelled them before they started 00:41:45 <flo-retina> we will have 2 nightlies in a very short interval 00:43:05 <flo-retina> anyway, good night! 01:01:11 <-- Mook_as has quit (Quit: Mook_as) 02:03:26 <instant-buildbot> build #807 of linux-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/807 02:28:04 --> Kaishi has joined #instantbird 03:02:52 --> mconley has joined #instantbird 03:06:03 <-- Kaishi has quit (Ping timeout) 03:10:51 --> Kaishi has joined #instantbird 03:29:32 <instant-buildbot> build #898 of win32-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/898 03:32:52 <-- clokep has quit (Ping timeout) 03:39:38 <instant-buildbot> build #808 of linux-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/808 03:44:08 --> Mook has joined #instantbird 03:55:06 <-- FireFly_TB has quit (Input/output error) 03:56:12 <instant-buildbot> build #805 of macosx-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/805 04:10:00 <-- mconley has quit (Input/output error) 04:16:43 --> FireFly_TB has joined #instantbird 04:23:06 <-- douglaswth has quit (Ping timeout) 04:24:39 --> douglaswth has joined #instantbird 04:40:38 <-- FireFly_TB has quit (Input/output error) 05:00:05 <-- Mook has quit (Quit: Mook) 05:07:32 <-- douglaswth has quit (Ping timeout) 05:08:32 --> douglaswth has joined #instantbird 05:25:43 --> mconley has joined #instantbird 06:20:33 <instant-buildbot> build #899 of win32-nightly-default is complete: Failure [failed shell_3] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/899 06:34:19 <-- mconley has quit (Input/output error) 08:29:41 --> Mic has joined #instantbird 08:29:42 * ChanServ sets mode +h Mic 08:32:54 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/1e565c643d07 - Florian Quèze - Bug 1828 - Update to Mozilla 19, fix buildsymbols bustage. 08:41:30 --> gerard-majax__ has joined #instantbird 08:45:23 <-- chrisccoulson has quit (Quit: PM: Preparing frontal lobe for mem sleep) 08:45:25 --> chrisccoulson has joined #instantbird 08:54:08 <instant-buildbot> build #361 of macosx-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/361 blamelist: Florian Qu?ze <florian@instantbird.org> 08:58:09 --> EionRobb has joined #instantbird 09:04:02 --> aleth has joined #instantbird 09:04:03 * ChanServ sets mode +h aleth 09:06:09 <instantbot> aleth@instantbird.org granted review for attachment 2276 on bug 677. 09:06:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=677 nor, --, ---, clokep, ASSI, Reopen Twitter stream when "track" preference changes 09:12:11 <aleth> I doubt packaging will help if http/https entries don't appear in the Applications tab on Linux (never seen that myself), but I may be wrong... 09:18:26 * aleth wonders why Mic uses userChrome to hide the participant counter and not his toggle participant list add-on ;) 09:18:46 <aleth> Less overhead I guess :P 09:20:43 <Mic> Toggle participant list won't hide the number if I'm not mistaken 09:23:10 <aleth> That's true. It just moves it... 09:44:26 <Mic> I noticed that I've never really used it. 09:45:03 <Mic> Sometimes it would be nice to have that number but I'd be fine to look it up somewhere else then (e.g. if it were in the tooltip of a channel (where it isn't at the moment)). 09:51:48 <-- mpmc has quit (Connection reset by peer) 09:52:23 --> rosonline has joined #instantbird 10:01:17 <flo-retina> the mac nightly is uploading :) 10:02:31 <aleth> one down, two to go :D 10:02:44 <flo-retina> the other 2 builders are offline 10:03:33 --> clokep has joined #instantbird 10:03:33 * ChanServ sets mode +o clokep 10:08:43 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 10:14:17 <instant-buildbot> build #806 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/806 10:23:05 <clokep> Did I hear that right that the Linux/Windows builders went offline before finishing? 10:23:35 <clokep> Ah the buildsymbols patch... 10:25:13 <-- aleth has quit (Quit: Au revoir) 10:25:24 --> aleth has joined #instantbird 10:25:24 * ChanServ sets mode +h aleth 10:38:17 <clokep> flo: I don't know if you remember, but are the things commented out in http://lxr.instantbird.org/instantbird/source/purple/libpurple/win32/win32dep.h#52 disabled because WINCE couldn't support them or because we don't want them at all? 10:43:27 --> flo-retina has joined #instantbird 10:43:27 * ChanServ sets mode +qo flo-retina flo-retina 10:50:26 <flo-retina> clokep: the win/linux builders went offline during their *third* nightly of the night ;) 10:50:39 <clokep> flo-retina: Ah! Well tomorrow. :) 10:50:55 <flo-retina> today if someone pings E ven 10:51:15 <flo-retina> for your question about win32dep.h, I don't know 10:51:59 <flo-retina> libpurple shouldn't go touch files on the file system outside the user's profile folder 10:52:13 <flo-retina> so the commented out stuff at lines 63-67 seems OK 10:52:19 <flo-retina> (to keep commented out) 10:52:45 <flo-retina> I don't see any obvious reason for denying read access to the registry 10:54:01 <flo-retina> but it looks like the only calls of these registry-related functions are in win32dep, and ifdef'ed out because they touch the file system 10:54:51 <clokep> Hm. OK! 10:55:18 <flo-retina> ok, so I guess 'keep things as they currently are' is my recommendation :) 10:56:31 <flo-retina> I'm not sure if things like http://hg.instantbird.org/instantbird/rev/8da5d3368c87 should be reverted or not 10:56:48 <flo-retina> that code isn't really useful, but on the other hand it's possible that random stuff started depending on it 10:57:19 <clokep> Right. I was going to go with the "try changing everything back and see if things break" method? 10:57:28 <clokep> But I'm trying to just finish a build first. ;) 10:57:39 <flo-retina> heh :) 10:57:48 <flo-retina> whatever seems to make sense to you is probably fine :) 11:14:44 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 11:51:36 <-- rosonline has quit (Ping timeout) 11:55:51 --> rosonline has joined #instantbird 11:57:10 --> clokep_work has joined #instantbird 11:57:10 * ChanServ sets mode +o clokep_work 12:09:23 --> unghost has joined #instantbird 12:11:56 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 12:24:48 --> deltafalcon has joined #instantbird 12:25:46 <Mic> clokep_work: what effect does the aIsNotice parameter on sendCTCPMessage have? 12:27:25 <Mic> If I don't want the reply to be shown as message and handle it myself, I can set it to whatever I like? 12:28:00 <Mic> (well, either of true or false, I meant) 12:31:03 <clokep_work> Mic: CTCP replies are sent as a NOTICE instead of a PRIVMSG. 12:31:41 <clokep_work> Mic: Clients are not supposed to automatically respond to a NOTICE (in order to avoid infinite loops of automatic replies). We break that convention. 12:31:45 * clokep_work wonders what Mic is doing. 12:39:19 <Mic> Experimenting with IRC extensions ;) 12:43:06 <flo-retina> clokep_work: E ven restarted the slaves ;) 12:44:20 <clokep_work> Mic: I figured that, but /what/ extension. :P 12:44:30 <clokep_work> flo-retina: Excellent. :) Thanks E ven! 12:44:59 <Mic> clokep_work: I knew ;) 12:45:17 <Mic> "AVATAR", then. Only with urls for now. 12:45:52 <Mic> Sources restricted to Facebook CDN and the like... 12:45:54 <Mic> gtg 12:46:13 <-- Mic has quit (Quit: No time to waste, let's go!) 12:46:59 <clokep_work> Ah, cool. 12:50:54 * clokep_work wonders if he was able to find someone w/ an avatar. :P 12:59:57 <flo-retina> Apparently our SSL certificate needs to be renewed in 30 days. How does http://www.startssl.com/?lang=en sound? (our current certificate is from godaddy) 13:00:51 <instant-buildbot> build #810 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/810 13:01:46 <clokep_work> Do they have good "reviews"? 13:02:12 <flo-retina> godaddy sucks. 13:02:25 <flo-retina> it was the cheapest I could find a few years ago 13:02:37 <flo-retina> startssl seems even cheaper 13:10:50 <clokep_work> Then that sounds fine w/ me. :) 13:14:23 <aleth> cacert.org is also free (and that's about all I know about it) 13:17:02 <flo-retina> aleth: except if that changed very recently, cacert's certs are as useful as self-signed certs ;) 13:18:32 <aleth> Ah, I see their root cert is not shipped by mozilla. 13:22:00 <clokep_work> I think I've mostly decided I hate JIRA. Almost as much as I hate Trac. 13:22:54 <-- gerard-majax__ has quit (Ping timeout) 13:26:24 <flo-retina> :) 13:44:26 <-- EionRobb has quit (Quit: Leaving.) 13:52:34 <clokep_work> (Seriously though, I spent like 10 minutes yesterday trying to figure out how to CC myself to a bug on Adium's trac...and I gave up.) 13:53:38 <flo-retina> "and I gave up" is the best part of it ;) 13:53:53 <flo-retina> just trying to login on Pidgin's trac is already extremely difficult 13:54:01 --> YH has joined #instantbird 13:54:10 <flo-retina> it keeps losing the user accounts, so if you can't login it may not even be your fault :) 13:54:28 <flo-retina> (maybe that got fixed, but disappearing accounts definitely happened) 13:55:34 <clokep_work> Bugzilla doesn't look nice, but I find it fairly straightforward to use. 13:55:58 <flo-retina> it's straight forward only if you aren't afraid of having things everywhere 13:56:58 --> mconley has joined #instantbird 14:04:08 --> gerard-majax__ has joined #instantbird 14:12:27 <-- gerard-majax__ has quit (Ping timeout) 14:26:12 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 14:26:20 <-- aleth has left #instantbird () 14:41:15 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 или ÑÑаÑÑе)) 14:53:10 <-- Kaishi has quit (Quit: Kaishi) 14:53:29 --> flo-retina has joined #instantbird 14:53:29 * ChanServ sets mode +qo flo-retina flo-retina 15:05:07 --> aleth has joined #instantbird 15:05:07 * ChanServ sets mode +h aleth 15:06:41 --> FireFly_TB has joined #instantbird 15:18:44 <instant-buildbot> build #901 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/901 15:19:23 <flo-retina> :) 15:19:55 <-- aleth has quit (Quit: %S) 15:20:00 <clokep_work> I always want to recommend to people to use Instantbird in #thunderbird. :-S 15:27:23 <flo-retina> is that forbidden? :-o 15:27:29 <clokep_work> I don't know. 16:02:20 --> gerard-majax__ has joined #instantbird 16:49:37 --> Mook_as has joined #instantbird 17:07:42 <clokep_work> Update time! 17:07:44 <-- clokep_work has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 17:07:55 --> clokep_work has joined #instantbird 17:07:55 * ChanServ sets mode +o clokep_work 17:08:41 <flo-retina> clokep_work: happy moz19! :) 17:08:53 <dew> in the nightly builds? 17:09:00 * flo-retina actually doesn't have any idea of what's exciting in moz19 17:09:02 <flo-retina> dew: yes 17:09:10 <dew> congrats! 17:09:55 <clokep_work> flo-retina: https://developer.mozilla.org/en-US/docs/Firefox_19_for_developers 17:10:08 <clokep_work> Honestly, not really much. 17:10:42 <Mook_as> a slightly larger version number! woooo! 17:11:19 <clokep_work> :) 17:15:54 <clokep_work> Hopefully we'll have update libpurple soon too. :) 17:16:03 <clokep_work> And kill WINCE with a big scissor. 17:17:45 <flo-retina> killing wince simplifies futures libpurple updates, so if we are serious about doing it, we should do it first 17:20:55 <clokep_work> I think it's after the libpurple update in my mq. 17:21:13 <flo-retina> which libpurple update? ;) 17:21:20 <flo-retina> by the time we are done there may be another one 17:21:34 <clokep_work> The one that's been in your review queue a while. ;) 17:21:44 * flo-retina hides 17:24:22 * clokep_work won't bring up adding SIPE. ;) 17:27:37 <flo-retina> I know I know... 17:29:06 <clokep_work> :) 17:29:20 <clokep_work> Maybe I should just stop doing huge patches hahah. 17:30:48 <clokep_work> (I mean that in a "one liners are easier to review" type of way. :) 17:30:48 <flo-retina> that message (in French) on contact@ makes no sense 17:32:34 <flo-retina> clokep_work: or just push a little harder to get a review 17:33:07 <flo-retina> most things in the SIPE bug could likely be reviewed in small parts 17:33:20 <flo-retina> and are already in a few separate patches anyway 17:34:42 <flo-retina> clokep_work: so the efficient way to get SIPE reviewed could be to arrange to have ~ one hour of both my and your time to spend on it, and just look through the various points that need attention 17:35:11 <flo-retina> so that the feedback loop is extremely short (instead of spending time to write long review comments, and waiting for the next patch to be uploaded to get feedback again) 17:36:04 <-- gerard-majax__ has quit (Ping timeout) 17:36:51 <-- FireFly_TB has quit (Ping timeout) 17:39:14 --> FireFly_TB has joined #instantbird 17:58:08 <clokep_work> flo-retina: That could be arranged. 17:58:35 <flo-retina> I don't really remember the state of it 17:59:13 <flo-retina> I remember you needed help for a makefile, but I don't remember if that was just for coding style reasons or because it really didn't work 18:22:33 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com) 18:22:34 <-- FireFly_TB has quit (Quit: FireFly_TB) 18:26:31 --> mpmc has joined #instantbird 19:02:52 <-- Even has quit (Input/output error) 19:14:40 <clokep_work> I think it was just coding style + maybe Mac fixes. 19:36:57 --> Mic has joined #instantbird 19:36:57 * ChanServ sets mode +h Mic 19:42:37 <-- YH has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com) 19:43:34 --> Mnyromyr has joined #instantbird 19:48:16 <dew> I thought you guys were removing libpurple 19:55:05 <clokep_work> dew: No. 19:55:13 <clokep_work> Where did you get that idea? 19:57:25 <clokep_work> I mean, we'd like to at least make it an extension, maybe drop it one day. But that won't be for a very long time 20:10:30 <-- clokep_work has quit (Input/output error) 20:27:04 <dew> oh I thought your goal was to rewrite libpurple 20:27:13 <dew> I guess I'm confused as to what libpurple actually does 20:59:48 --> clokep has joined #instantbird 20:59:48 * ChanServ sets mode +o clokep 21:01:07 --> flo-retina has joined #instantbird 21:01:07 <clokep> dew: Well what do you think it does? :) 21:01:08 * ChanServ sets mode +qo flo-retina flo-retina 21:01:23 <clokep> P.S. Can we please fix that bug about auto-completing an already complete name and adding the ": "? :P 21:01:28 <clokep> I run into it like all the time! 21:01:43 <-- clokep has quit (Connection reset by peer) 21:02:04 --> clokep has joined #instantbird 21:02:04 * ChanServ sets mode +o clokep 21:02:20 <flo-retina> clokep: oh, so you are now the third person annoyed by it? :) 21:02:34 <clokep> I think so. :) 21:02:51 * flo-retina was wondering what useful thing he could do in 1-2 hours tonight (first thing is taking care of the checkin-needed queue) 21:03:05 <flo-retina> I guess reviewing that patch will be next :) 21:03:10 <clokep> :) 21:05:33 <flo-retina> clokep: I can checkin bug 677 without testing the patch at all, right? 21:05:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=677 nor, --, ---, clokep, ASSI, Reopen Twitter stream when "track" preference changes 21:06:11 <clokep> flo-retina: It worked in every case I tried (being connected, being disconnected, connecting then disconnecting, etc.) 21:06:17 <clokep> I'm fairly confident in it. 21:06:20 <flo-retina> it doesn't apply, problem solved :-/ 21:06:27 <clokep> But there's always a chance I'll disappear and never fix it... 21:06:42 <clokep> flo-retina: It probably wants the Twitter API v1.1 patch first. :( 21:06:49 <flo-retina> clokep: I'm not concerned about you disappearing and not fixing it. 21:06:55 <clokep> I can rearrange them in my queue and reuploading? 21:07:07 <flo-retina> clokep: I'm more concerned about us never actually testing it after it lands, and discovering a day after the next release that it needs a fix ;) 21:07:15 <flo-retina> what's the state of that other patch? 21:07:33 <clokep> The 1.1 one? It's waiting for a review from you / mconley about the changes to http.jsm. 21:07:40 <clokep> (But shhhh, we never told mconley about it. ;)) 21:07:51 <mconley> whaaaa 21:07:52 <clokep> It will need another version to clean it up if the change is correct. 21:08:04 <dew> I'm not sure. Is it the backend that handles all the connections and all that like gecko? 21:08:14 <clokep> bug 1890 for reference. 21:08:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1890 nor, --, ---, clokep, ASSI, Update Twitter to API v1.1 21:08:35 <clokep> dew: It's what some of the protocols use as a backend. 21:08:38 <flo-retina> it looks like it's waiting for aleth and you to decide on what to do with percentEncode 21:08:41 <clokep> dew: But Instantbird runs via Gecko. 21:08:53 <clokep> flo-retina: No, it's waiting for you to tell me that that change is OK. 21:09:09 <flo-retina> clokep: ahah 21:09:23 <flo-retina> clokep: so I ignored the r? there because the patch was already r-'ed by aleth 21:09:23 <flo-retina> :( 21:09:38 <clokep> flo-retina: I was concerned we're embedding an oauthism into the http.jsm file. 21:10:07 <clokep> So I didn't bother cleaning up the other usages of percentEncode if it was the wrong thing to do. 21:10:40 <dew> so the new protocols do they depend on libpurple? I thought you guys wrote them to not use them right? 21:11:03 <clokep> dew: "New protocols"? You mean our JavaScript implementations? No they don't use libpurple at all. 21:11:53 <dew> yes that's what I mean. IRC and Twitter and XMPP right? 21:12:11 <flo-retina> clokep: so, is the next step to find the HTTP RFC to check what we are supposed to do? 21:12:42 <clokep> dew: Yup. 21:13:09 <clokep> flo-retina: I think aleth pointed to some links but then decided that there "is no good RFC" about that? I didn't really follow up on the stuff he found, sorry. :( 21:13:42 <flo-retina> ah! so "it's waiting for aleth and you to decide on what to do with percentEncode" was quite right, wasn't it? ;) 21:17:37 <clokep> flo-retina: No, it's waiting for aleth to decide on what to do with percentEncode. ;) 21:18:30 <flo-retina> clokep: isn't that mconley? :-P 21:18:39 <flo-retina> clokep: our only use case is twitter. 21:18:39 <clokep> Maybe. :) 21:18:46 <flo-retina> clokep: if it breaks something, it will be file link :-P 21:20:05 <flo-retina> http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.1 21:20:31 <flo-retina> "Space characters are replaced by `+', and then reserved characters are escaped as described in [RFC1738], section 2.2: Non-alphanumeric characters are replaced by `%HH', a percent sign and two hexadecimal digits representing the ASCII code of the character." 21:21:12 <clokep> OK... 21:22:50 <flo-retina> http://www.ietf.org/rfc/rfc1738.txt defiles the reserved characters as: 21:22:51 <flo-retina> reserved = ";" | "/" | "?" | ":" | "@" | "&" | "=" 21:23:42 <clokep> And how are they escaped in that document? ;) 21:26:23 <flo-retina> what do you mean? 21:26:53 <clokep> "then reserved characters are escaped as described in [RFC1738]" 21:28:06 <flo-retina> 22:22:49 - flo-retina: http://www.ietf.org/rfc/rfc1738.txt defiles the reserved characters as: 21:28:06 <flo-retina> 22:22:49 - flo-retina: reserved = ";" | "/" | "?" | ":" | "@" | "&" | "=" 21:28:15 <flo-retina> s/defiles/defines/ 21:28:41 <clokep> Yeah...but that doesn't say how they are escaped. Just what they are. 21:29:26 <flo-retina> "replaced by `%HH', a percent sign and two hexadecimal digits representing the ASCII code of the character." seemed clear to me 21:29:52 <clokep> Ah, I didn't know that that applied to those as well. 21:30:11 <clokep> I thought they were described in a different way. 21:30:21 <clokep> OK, so the change seems OK to me then. 21:30:31 <flo-retina> really? 21:30:57 <flo-retina> the change is about !*'() 21:31:48 <clokep> Oh. 21:31:58 <clokep> I didn't see the characters being different. :-/ Sorry. 21:32:29 <flo-retina> Ok, so here's a suggestion: ignore the specs that are all confusing, and instead send through Firefox in a POST form the same data to a web page. 21:32:35 <flo-retina> Look with wireshark how it's encoded. 21:32:41 <flo-retina> and do the same for http.jsm 21:33:01 <flo-retina> if that doesn't make twitter work, then we need twitter specific hacks in twitter.js 21:33:03 <clokep> OK. 21:33:30 <flo-retina> does that seem reasonable? 21:34:08 <flo-retina> clokep: so, going back to a question from half an hour ago (!), "I can rearrange them in my queue and reuploading?" if you want that other patch checked in tonight, that would be good, yes :) 21:34:30 <flo-retina> unless it's trivial and I can just figure it out myself 21:35:04 <flo-retina> alright, don't bother, it's trivial 21:36:45 <clokep> flo-retina: OK. :) 21:37:10 <flo-retina> the cause for the 'bitrot' is http://pastebin.instantbird.com/157789 21:37:12 * clokep is going to be busy for a bit. 21:37:43 <flo-retina> (that's a diff between your patch and mine after applying by hand the hunk that didn't apply) 21:39:48 <-- chrisccoulson has quit (Quit: PM: Preparing frontal lobe for mem sleep) 21:40:30 <clokep> OK 21:41:23 * flo-retina thought you were busy 21:44:28 <instantbot> florian@instantbird.org granted review for attachment 2274 on bug 851. 21:44:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=851 enh, --, ---, clokep, ASSI, Twitter commands 21:45:00 --> chrisccoulson has joined #instantbird 21:53:36 <instantbot> florian@instantbird.org denied review for attachment 2259 on bug 1890. 21:53:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1890 nor, --, ---, clokep, ASSI, Update Twitter to API v1.1 22:19:14 <clokep> flo-retina: Using Firebug, I sent '!()*+ on a form, it says it's sent as: %27%21%28%29*%2B 22:34:01 <flo-retina> how much do you trust Firebug? :) 22:39:35 <clokep> I trust it decently. 22:45:53 <flo-retina> I have bug 1898 bug 677 and bug 851 ready to push 22:45:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1898 tri, --, ---, florian, NEW, Missing menus on the Error Console and Software Update windows 22:45:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=677 nor, --, ---, clokep, ASSI, Reopen Twitter stream when "track" preference changes 22:45:59 <flo-retina> are there others that are already reviewed? 22:45:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=851 enh, --, ---, clokep, ASSI, Twitter commands 22:50:10 <-- Mic has quit (Quit: No time to waste, let's go!) 22:50:49 --> Mic has joined #instantbird 22:50:49 * ChanServ sets mode +h Mic 22:51:54 --> florian has joined #instantbird 22:52:05 <florian> so, let's see how that completion behaves :) 23:00:26 <flo-retina> that completion code really deserves unit tests :( 23:08:54 <-- Mic has quit (Quit: No time to waste, let's go!) 23:13:33 <-- mconley has quit (Input/output error) 23:25:16 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 23:27:04 <clokep> flo-retina: Btw the firebug thing shows both the raw request and the parameters separaetly, so I think it's showing the "right" thing. 23:27:12 <clokep> Yes, tab completion reall yneeds unit tests. :( 23:27:30 <flo-retina> ok 23:28:47 <clokep> Ah, I didn't see you found another edge case. :( 23:30:58 <clokep> Add contact is "Ctrl + B"? (o_O) 23:31:07 * clokep has a feeling that used to say "Add buddy" 23:35:48 <dew> I keep recruiting for Instantbird but a lot of people want OTR ala pidgin 23:37:43 <clokep> I still don't understand the obsession w/ OTR. :( 23:37:48 <clokep> dew: Tell them toa dd it? :P 23:37:53 <dew> haha 23:38:05 <dew> the guys I'm talking to are REALLY into encryption 23:38:09 <clokep> (I'm really not joking...) 23:38:12 <dew> and are kind of paranoid 23:38:43 <clokep> My understanding is that OTR isn't really encryption...only kind of. 23:38:45 * clokep shrugs. 23:39:07 <clokep> Besides if you're trying to protect yourself from the server...there's nothing out of band about OTR. 23:48:55 <dew> I'm not sure 23:49:12 <dew> I honestly didn't understand PGP in my networking class :S 23:53:29 <clokep> PGP in a /networking/ class? Weird. 23:53:40 <clokep> Yes, encryption is confusing. :) 23:53:58 <clokep> Part of the issue with OTR btw is that libotr is GPL...and you're never supposed to write your own encryption code. ;) 23:55:15 * clokep thinks his patch queue is too long: http://pastebin.instantbird.com/157828 23:58:02 <clokep> Anyway, people are coming over to play Catan so goodnight! :) 23:58:06 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)