#instantbird log on 03 02 2013

All times are UTC.

00:00:01 <clokep> :( That's frustrating.
00:00:15 <flo-retina> that's why I was trying to edit the xpi file directly ;)
00:01:52 <flo-retina> maybe I should just fully unpack it, drop compatibility with completely obsolete mozilla versions, remove the junk (contents.rdf files anyone? ;)), and repack it with current standards (no .jar file, etc...)
00:03:29 <clokep> Are you making any functional changes?
00:03:33 <clokep> Then makes sense to do that.
00:03:49 <clokep> Older Fx versions can always use the older extension versions.
00:05:54 <flo-retina> it's more the Mozilla Suite that these changes would drop ;)
00:06:39 <flo-retina> clokep: I found a way to fix it without breaking compatibility with old Fx versions (well, at least without breaking compatibility with version 1 of the hg history of mozilla-central)
00:07:15 <flo-retina> the bug that's breaking it is https://bugzilla.mozilla.org/show_bug.cgi?id=695399
00:07:25 <Mook_as> Hasn't the suite people moved to seamonkey?
00:07:30 <flo-retina> but fortunately the async API I need to use instead has been there forever
00:07:37 <flo-retina> Mook_as: we can hope so!
00:07:46 <flo-retina> Mook_as: and if they haven't, they are unlikely to update their addons
00:08:12 <flo-retina> Mook_as: and seamonkey uses the toolkit add-on manager, so the old contents.rdf and install.js junk can be dropped
00:09:06 <Mook_as> right, they have way too few people to think about maintaining the old stuff
00:09:49 <flo-retina> alright, I think I'll just clean it up tomorrow
00:11:00 <clokep> flo-retina: For bug 1882, do you think we could show the amount of time next to the ... in the bubble?
00:11:01 <flo-retina> it's surprising that the min version for Firefox is 1.0
00:11:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1882 min, --, ---, nobody, NEW, Time Bubbles could be optimized to display the time since the last message in a conversation
00:11:16 <flo-retina> was there a reason for that add-on not working on Fx 0.8? :)
00:11:18 <Mook_as> aviary branch ftw!
00:11:38 <flo-retina> Mook_as: or I suspect 1.0 is just whatever was "current" at the time I developed it
00:12:08 <flo-retina> clokep: you can try that, or centered
00:12:51 <clokep> flo-retina: I need to finish some more patches first. :)
00:14:54 <clokep> Connecting Twitter accounts in a debug build brings it to it's knees...
00:17:42 <flo-retina> that's strange :-S
00:18:40 <flo-retina> clokep: at some point I wanted to use that empty ... line to display the number of system messages that were hidden there
00:18:58 <clokep> flo-retina: That also seems reasonable.
00:19:08 <clokep> It is certainly dead space right now.
00:19:14 <flo-retina> clokep: I gave up on it because it would have required a localizable string inside the message theme; which is really a PITA
00:19:48 <flo-retina> but if it's the defaut message theme, we can cheat and put the string inside the UI rather than in the theme itself
00:20:01 <flo-retina> but time bubbles was initially developed as an add-on.
00:20:08 <clokep> Right. :)
00:20:38 <flo-retina> clokep: we could maybe display both
00:20:52 <clokep> flo-retina: "xxx messages over xxx minutes"?
00:20:56 <clokep> Or something like that.
00:20:57 <flo-retina> yeah
00:21:44 <flo-retina> I would have put "N more" instead of "xxx messages" to avoid the localized plural
00:22:08 <clokep> That works too. :)
00:24:11 <flo-retina> Good night / good luck with your patches :)
00:25:28 <clokep> Goodnight!
00:42:24 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2252 on bug 1038.
00:42:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1038 enh, --, ---, clokep, ASSI, Add followed people to the participants timeline
00:44:03 <-- clokep has quit (Ping timeout)
01:02:44 <-- qlum has quit (Quit: Getting the <censored> out.)
01:55:14 <-- Mook_as has quit (Ping timeout)
01:56:48 --> Mook_as has joined #instantbird
02:04:30 <-- Mook_as has quit (Quit: Mook_as)
03:40:53 <instant-buildbot> build #795 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/795
04:31:01 <instant-buildbot> build #792 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/792
05:27:05 <-- Optimizer has quit (Ping timeout)
05:42:24 <instant-buildbot> build #886 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/886
06:46:54 --> jb has joined #instantbird
06:52:56 <-- jb has quit (Ping timeout)
07:09:15 --> Optimizer has joined #instantbird
07:55:12 --> jb has joined #instantbird
08:15:47 <-- jb has quit (Ping timeout)
08:19:34 --> jb has joined #instantbird
08:23:41 --> Kaishi has joined #instantbird
08:47:36 <-- jb has quit (Connection reset by peer)
09:02:20 --> jb has joined #instantbird
09:04:59 <-- jb has quit (Ping timeout)
09:05:18 --> jb has joined #instantbird
09:12:40 <-- jb has quit (Ping timeout)
10:04:06 --> jb has joined #instantbird
10:07:12 --> Mic has joined #instantbird
10:07:12 * ChanServ sets mode +h Mic 
10:16:00 * flo-retina has possibly done half of aleth's reviewing work in bug 1038
10:16:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1038 enh, --, ---, clokep, ASSI, Add followed people to the participants timeline
10:26:05 <Mic> Hi!
10:28:36 --> rosonline has joined #instantbird
11:18:37 <Mic> flo-retina: the thing with Map is that it is not stable yet: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Map
11:19:03 <Mic> Here's a performance check: http://pastebin.instantbird.com/151343
11:20:48 <Mic> clokep, clokep_work: sorry, forgot to ping you here ;)
11:23:48 <Mic> I'm not publishing my raw numbers lest someone notices how achingly slow my computer is ;)
11:33:53 --> aleth has joined #instantbird
11:33:54 * ChanServ sets mode +h aleth 
11:37:58 <Mic> The same for "Set": http://pastebin.instantbird.com/151348
11:51:59 --> mpmc has joined #instantbird
11:52:02 <aleth> Interesting that there is a speed improvement.
11:53:12 <aleth> Do you know which part the savings come from? map.has or map.set or both?
11:53:55 <Mic> No, I haven't tested this separately. I wanted to get an overall impression that's why I combined the set with has-hits and -misses.
11:54:46 <Mic> Feel free to move the Date.now()s around ;)
11:54:58 <Mic> I'd be interested in the results, though!
11:56:49 --> qlum has joined #instantbird
12:00:48 <-- jb has quit (Connection reset by peer)
12:00:50 --> jb1 has joined #instantbird
12:04:44 <-- aleth has quit (Quit: Au revoir)
12:05:25 --> aleth has joined #instantbird
12:05:25 * ChanServ sets mode +h aleth 
12:06:51 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
12:14:47 <-- jb1 has quit (Ping timeout)
12:16:39 --> gerard-majax_ has joined #instantbird
12:20:16 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
12:41:52 <-- Mic has quit (Ping timeout)
12:46:33 <aleth> Tried to run that in Scratchpad, no idea how to get at the result.
13:00:09 <-- flo-retina has quit (Ping timeout)
13:00:18 --> flo-retina has joined #instantbird
13:00:18 * ChanServ sets mode +qo flo-retina flo-retina 
13:08:59 <-- skeledrew has quit (Connection reset by peer)
13:09:01 --> skeledrew has joined #instantbird
13:19:28 --> Mic has joined #instantbird
13:19:28 * ChanServ sets mode +h Mic 
13:21:24 --> jb has joined #instantbird
13:24:50 <Mic> aleth: the snippets work for me both in scratchpad and the error console
13:25:12 <aleth> Mic: they run, but how do you get the result displayed?
13:25:13 <Mic> Running it on the error console is much faster though?
13:25:40 <Mic> Try running with Ctrl+L iirc
13:26:49 <Mic> Yes, this will print the result of "endTime-startTime" (you've splitted the different test from my pastebined code after these lines, didn't you)?
13:27:19 <-- gerard-majax_ has quit (Ping timeout)
13:28:14 <aleth> Oh, I see. Ctrl+L also runs it, so the selection must be present.
13:28:32 --> mpmc has joined #instantbird
13:28:44 --> gerard-majax_ has joined #instantbird
13:29:11 <aleth> I couldn't reproduce your result in the error console though. For me (FF21) Map takes almost double the time.
13:31:14 <Mic> I've tried on the error console of our nightly tbh, so what I said was  a "Moz 18"-result...
13:31:16 <aleth> More than double sometimes.
13:32:09 <aleth> Let me test in IB
13:32:21 --> DGMurdockIII has joined #instantbird
13:32:32 <Mic> You can directly c/p to the error console. It will strip the line breaks from the code automatically.
13:33:00 <aleth> Huh, that's strange. I get the same results as you in the IB error console. 
13:33:41 <aleth> What's changed is the performance of the Object code in FF- it's almost four times faster in FF21
13:33:51 <aleth> (than in IB18)
13:34:38 <aleth> I wonder what changed. That's quite a win if correct... 
13:35:29 <aleth> (ie if not a fluke of some sort)
13:37:15 <Mic> Running the same code in FX' scratchpad is 3x slower for me than running it in FX' error console.
13:37:25 <aleth> Same here.
13:37:27 <Mic> Firefox 18 here...
13:37:36 <aleth> For the comparison I compared the error console times.
13:37:44 --> clokep has joined #instantbird
13:37:44 * ChanServ sets mode +o clokep 
13:38:14 <Mic> So the object code is much faster than the Map/Set version in Firefox for you?
13:38:32 <aleth> Yes for Map (didn't test Set)
13:38:42 <-- jb has quit (Ping timeout)
13:40:23 <Mic> Ah, I ran the Set tests!
13:44:03 * clokep doesn' tknow if Map is really necessary there.
13:44:09 <clokep> I'm actually not using the values at all, which is bad.
13:44:27 <clokep> So it should probably be a "set". I was figuring it might be useful to have a map though...
13:51:23 <Mic> bye!
13:53:13 <-- Mic has quit (Quit: No time to waste, let's go!)
14:05:27 --> rosonline has joined #instantbird
14:44:12 <-- gerard-majax_ has quit (Connection reset by peer)
14:44:19 --> gerard-majax__ has joined #instantbird
16:10:59 --> jb has joined #instantbird
16:12:26 <-- gerard-majax__ has quit (Ping timeout)
16:19:05 --> mikk_s has joined #instantbird
16:22:37 --> Mic has joined #instantbird
16:22:37 * ChanServ sets mode +h Mic 
16:25:43 <instantbot> aleth@instantbird.org denied review for attachment 2252 on bug 1038.
16:25:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1038 enh, --, ---, clokep, ASSI, Add followed people to the participants timeline
16:27:50 <clokep> aleth: Half those comments don't have to do with my changes. :-S
16:28:19 <aleth> clokep: I did say so in the comment ;)
16:29:43 <-- jb has quit (Connection reset by peer)
16:30:40 <aleth> I'm sorry if I expressed myself poorly.
16:33:09 <Mic> Hello again
16:34:27 <aleth> clokep: Btw if it wasn't clear, the comment was meant to indicate that I actually think it's a good place to use Map and Set in principle.
16:49:26 <-- mpmc has quit (Connection reset by peer)
16:50:03 --> jb has joined #instantbird
16:52:44 <-- jb has quit (Ping timeout)
16:57:07 <-- mikk_s has left #instantbird ()
17:09:58 --> mconley has joined #instantbird
17:12:57 --> gerard-majax__ has joined #instantbird
17:20:45 <-- Kaishi has quit (Quit: Kaishi)
17:24:01 <clokep> aleth: OK. Btw the chnages between 18 and 19 were mostly expanding the API.
17:25:00 <aleth> clokep: I just ran into size being a property in 19 (not sure why it's size and not length, but that's by the by)
17:25:54 <clokep> aleth: As I said anyway, there's not really any reason to use a Map there, we're not using any of the stored information.
17:26:09 <clokep> I really just need a list of IDs of people who exist in the room already.
17:27:17 <-- Mic has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
17:27:33 --> Mic has joined #instantbird
17:27:33 * ChanServ sets mode +h Mic 
17:28:03 --> jb has joined #instantbird
17:28:42 <-- Mic has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
17:28:52 <aleth> clokep: My main point there is just that I don't understand why you need a new var and can't use a map-ified this._userInfo for this
17:29:07 <clokep> aleth: What?
17:29:13 <aleth> Is it because of the different key?
17:29:13 <clokep> _userInfo is indexed by name, not by ID.
17:29:39 <aleth> OK
17:30:40 <-- Optimizer has quit (Ping timeout)
17:30:54 <-- jb has quit (Ping timeout)
17:31:50 <clokep> aleth: We could iterate over _userInfo and see if the ID is in it, but that seemed...inefficient.
17:33:05 <aleth> clokep: Right.
17:34:35 <aleth> So it seems there are situations where we have the nick and no ID, so there's no real way of making that more elegant.
17:35:30 --> jb has joined #instantbird
17:36:30 <aleth> I still think _userInfo should eventually be a Map and _friends a Set, but that really is a separate "bug" :) We probably have similar situations in other protocols anyway.
17:37:01 <aleth> I wouldn't even have thought about it if you hadn't used a map there ;)
17:38:27 <-- jb has quit (Ping timeout)
17:53:45 <-- Tonnes has quit (Connection reset by peer)
18:04:43 <-- gerard-majax__ has quit (Ping timeout)
18:11:45 --> gerard-majax__ has joined #instantbird
18:14:19 <-- gerard-majax__ has quit (Ping timeout)
18:18:49 --> Tonnes has joined #instantbird
18:21:57 --> gerard-majax__ has joined #instantbird
18:23:02 <-- aleth has left #instantbird ()
18:28:36 --> gerard-majax_ has joined #instantbird
18:28:47 <-- gerard-majax__ has quit (Quit: Ex-Chat)
18:41:27 --> Optimizer has joined #instantbird
18:59:50 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
19:07:07 <-- rosonline has quit (Ping timeout)
19:08:10 --> rosonline has joined #instantbird
19:27:11 --> Mic has joined #instantbird
19:27:12 * ChanServ sets mode +h Mic 
19:38:18 <-- Mic has quit (Quit: No time to waste, let's go!)
19:38:39 --> Mic has joined #instantbird
19:38:40 * ChanServ sets mode +h Mic 
19:43:04 <-- Mic has quit (Quit: No time to waste, let's go!)
19:46:32 --> Mic has joined #instantbird
19:46:32 * ChanServ sets mode +h Mic 
19:46:48 <-- Mic has quit (Quit: No time to waste, let's go!)
20:06:03 --> Mic has joined #instantbird
20:06:03 * ChanServ sets mode +h Mic 
20:07:06 --> FireFly_TB has joined #instantbird
20:07:07 <Mic> clokep: you remember the idea with the 'most recent messages' on the tooltip?
20:13:42 <-- Mic has quit (Quit: No time to waste, let's go!)
20:13:48 --> Mic has joined #instantbird
20:13:48 * ChanServ sets mode +h Mic 
20:13:56 <-- Mic has quit (Input/output error)
20:19:07 --> jb has joined #instantbird
20:24:53 <-- clokep has quit (Ping timeout)
20:34:50 <-- FireFly_TB has quit (Quit: FireFly_TB)
21:13:01 --> Kaishi has joined #instantbird
21:29:39 <-- Suiseiseki has quit (Ping timeout)
21:47:02 --> Suiseiseki has joined #instantbird
22:24:13 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 19.0.1/20130226172142])
22:40:21 <-- mconley has quit (Input/output error)
23:44:38 <-- Kaishi has quit (Quit: Kaishi)
23:49:05 <-- rosonline has quit (Ping timeout)
23:54:14 --> rosonline has joined #instantbird