#instantbird log on 02 18 2013

All times are UTC.

00:05:19 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2ab307d5880b - Sebastian Hengst - Bug 795152 - Switch to Services.jsm: What's left: chat. r=florian
00:05:20 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/4fb10d2f5b31 - Sebastian Hengst - Bug 830456 - Code cleanup in /chat/: Use new String methods like startsWith, endsWith, contains, remaining Services.jsm switches and querySelector use instead of
00:05:21 <instantbot> NodeList calls. r=florian
00:05:22 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/3cfc081fb133 - Patrick Cloke - Bug 842024 - Thunderbird Chat can't connect to EuIRC, r=fqueze.
00:05:23 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/f2cb45f93b30 - Sebastian Hengst - Bug 823449 - Chat: Services.appshell should be Services.appShell. r=florian
00:09:13 <instant-buildbot> build #352 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/352  blamelist: Sebastian Hengst <archaeopteryx@coole-files.de>, Patrick Cloke <clokep@gmail.com>
00:36:31 <-- mconley has quit (Input/output error)
00:36:59 --> mconley has joined #instantbird
00:38:41 <-- mconley has quit (Connection reset by peer)
00:38:49 --> mconley has joined #instantbird
00:44:04 <instant-buildbot> build #379 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/379
00:45:50 --> mpmc has joined #instantbird
00:48:12 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
00:51:04 <-- mconley has quit (Input/output error)
00:51:32 --> mconley has joined #instantbird
00:53:22 <-- mconley has quit (Ping timeout)
01:14:36 <-- qlum has quit (Connection reset by peer)
01:30:58 <instant-buildbot> build #365 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/365
01:48:39 <-- Tonnes has quit (Connection reset by peer)
02:01:22 --> Tonnes has joined #instantbird
02:23:03 <-- jb has quit (Input/output error)
02:23:06 --> jb has joined #instantbird
02:29:43 <-- mali has quit (Ping timeout)
02:34:20 <-- mpmc has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
02:39:19 --> DGMurdockIII has joined #instantbird
03:18:24 <-- EionRobb has quit (Ping timeout)
03:22:24 --> EionRobb has joined #instantbird
03:31:30 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.90 [Firefox 18.0.2/20130201065344])
03:40:09 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
03:40:56 <instant-buildbot> build #784 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/784
03:51:51 --> mconley has joined #instantbird
04:43:20 <-- mconley has quit (Input/output error)
04:43:49 --> mconley has joined #instantbird
04:43:54 <instant-buildbot> build #780 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/780
04:45:43 <-- mconley has quit (Ping timeout)
04:53:57 <-- EionRobb has quit (Quit: Leaving.)
05:45:21 <instant-buildbot> build #874 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/874
07:46:38 --> Even has joined #instantbird
07:46:38 * ChanServ sets mode +o Even 
07:56:43 <-- chrisccoulson has quit (Ping timeout)
08:17:53 <-- jb has quit (Ping timeout)
08:18:37 <-- Even has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
08:26:19 --> Mic has joined #instantbird
08:26:19 * ChanServ sets mode +h Mic 
08:46:33 <-- Mic has quit (Quit: Output/input error)
09:07:14 --> jb has joined #instantbird
09:15:28 <-- Mook has quit (Quit: Mook)
09:20:23 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
09:27:47 --> chrisccoulson has joined #instantbird
09:28:48 <-- gerard-majax__ has quit (Ping timeout)
09:47:11 --> flo-retina has joined #instantbird
09:47:11 * ChanServ sets mode +qo flo-retina flo-retina 
09:47:25 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
09:47:28 --> flo-retina has joined #instantbird
09:47:28 * ChanServ sets mode +qo flo-retina flo-retina 
10:03:47 --> mpmc has joined #instantbird
10:04:35 * flo-retina could really use some efficient log search :(
10:14:59 --> gerard-majax__ has joined #instantbird
10:28:37 <-- chrisccoulson has quit (Quit: PM: Preparing frontal lobe for mem sleep)
10:32:40 <flo-retina> and online logs are really hard to search :(
10:38:53 --> chrisccoulson has joined #instantbird
10:50:59 <-- mpmc has quit (Ping timeout)
11:02:42 --> aleth has joined #instantbird
11:02:43 * ChanServ sets mode +h aleth 
11:03:08 --> clokep has joined #instantbird
11:03:08 * ChanServ sets mode +o clokep 
11:29:10 <clokep> Hello.
11:32:48 <flo-retina> Good morning :)
11:35:36 <aleth> Hi :)
11:37:51 --> rosonline has joined #instantbird
11:39:36 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
11:39:43 --> clokep has joined #instantbird
11:39:43 * ChanServ sets mode +o clokep 
11:40:05 <clokep> No IRC issues this morning, right? :)
11:40:05 <-- aleth has quit (Quit: Au revoir)
11:40:07 --> aleth has joined #instantbird
11:40:07 * ChanServ sets mode +h aleth 
11:40:21 <flo-retina> I haven't noticed anything
11:40:32 <flo-retina> tb's tree is still busted :-/
11:43:11 <clokep> :( Hopefully they'll fix it today?
11:44:03 <flo-retina> the new bug is https://bugzilla.mozilla.org/show_bug.cgi?id=842254
11:44:10 <flo-retina> yes, hopefully they'll fix today :)
11:45:28 --> mpmc has joined #instantbird
11:53:00 <clokep> Ah, I see.
11:53:08 <clokep> Well merge is tomorrow so...some time before that still. :-d
11:54:34 --> qlum has joined #instantbird
11:56:31 <-- rosonline has quit (Client exited)
11:56:36 --> rosonline has joined #instantbird
11:58:59 <clokep> Haha, well that was fast. ;)
11:59:12 <aleth> Fixed already?
11:59:22 <flo-retina> r+'ed at least
12:07:05 <-- clokep has quit (Ping timeout)
12:13:08 <aleth> flo-retina: Why does document.querySelector("body") work? Body is not a CSS selector, is it?
12:14:11 <aleth> Doh. Ignore that...
12:14:43 <aleth> That's what comes from training oneself not to select by tag ;)
12:18:49 <instantbot> aleth@instantbird.org cancelled review?(florian@instantbird .org) for attachment 2219 on bug 1870.
12:18:50 <instantbot> aleth@instantbird.org requested review from florian@instantbird .org for attachment 2236 on bug 1870.
12:18:51 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1870 nor, --, ---, aleth, ASSI, Leading whitespace is lost from messages
12:25:01 --> mali has joined #instantbird
12:38:55 <-- mali has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
12:38:58 --> mali has joined #instantbird
13:07:35 --> clokep_work has joined #instantbird
13:07:35 * ChanServ sets mode +o clokep_work 
13:30:34 <-- flo-retina has quit (Input/output error)
13:31:54 --> flo-retina has joined #instantbird
13:31:54 * ChanServ sets mode +qo flo-retina flo-retina 
13:32:21 <-- mpmc has quit (Connection reset by peer)
13:33:24 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
14:15:42 <-- gerard-majax__ has quit (Ping timeout)
14:25:56 --> gerard-majax__ has joined #instantbird
14:56:38 <-- jb has quit (Quit: jb)
15:00:26 --> jb has joined #instantbird
15:07:03 * flo-retina really dislikes https://bugzilla.mozilla.org/show_bug.cgi?id=779052#c10
15:10:42 <flo-retina> remaining diff between c-c/ib repositories for the chat/ folder: http://pastebin.instantbird.com/144231
15:12:26 <-- SM0TVI has quit (Ping timeout)
15:13:43 <aleth> oh dear...
15:14:12 <aleth> critical too!
15:17:10 <aleth> Why couldn't we take the nsIFile change?
15:18:44 --> SM0TVI has joined #instantbird
15:20:06 <flo-retina> aleth: I haven't said we couldn't take it
15:20:18 <flo-retina> aleth: the pastebin is just a diff after all the recent landings
15:20:23 <aleth> Ah OK.
15:20:48 <flo-retina> so I'll need to figure out at which point (for which mozilla release) it changed for Tb, and then decide if we should take it now or wait a bit more
15:20:51 <aleth> I don't really understand the implications, other than that nsILocalFile is going away at some point...
15:22:30 <flo-retina> well, http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsILocalFile.idl
15:22:59 --> rosonline has joined #instantbird
15:23:04 <aleth> heh
15:23:25 <flo-retina> so apparently nsILocalFile became pointless for Mozilla 14 (!)
15:28:03 --> mconley has joined #instantbird
15:47:00 <-- mconley has quit (Input/output error)
15:47:27 --> mconley has joined #instantbird
15:49:13 <-- mconley has quit (Ping timeout)
16:08:12 <-- aleth has quit (Input/output error)
16:13:42 <clokep_work> flo-retina: We can take the nsIFile changes now.
16:13:48 <clokep_work> Ah, as you just found out.
16:13:55 <clokep_work> Is there a list of what keywords mean somewhere?
16:15:48 <flo-retina> clokep_work: https://bugzilla.mozilla.org/describekeywords.cgi
16:19:16 <clokep_work> Is there one about different fields? Like "Importance"?
16:19:19 <clokep_work> (Thanks.)
16:21:33 <flo-retina> https://bugzilla.mozilla.org/page.cgi?id=fields.html#bug_severity ?
16:22:12 <clokep_work> Now my real question is how do you find these? :P
16:22:43 <flo-retina> just click on the field names ;)
16:23:03 <flo-retina> the #bug_severity hash was wrong in the link though, I had to go look at the source to find the correct one
16:23:09 <clokep_work> Bah, the styling doesn't make them look clickable.
16:23:36 <flo-retina> they are underlined when hovered, and the cursor is a question mark
16:24:02 <clokep_work> Yes, I see that now. :p
16:24:06 <clokep_work> I just didn't think to even try that.
16:24:24 <clokep_work> I replied to your favoriate comment there though. ;)
16:31:17 <-- jb has quit (Ping timeout)
16:33:19 <flo-retina> clokep_work: I'm not sure if he has valid points with poor communication / social skills, or if he's trolling us.
16:33:37 <flo-retina> I'm more included to think the former though :).
16:33:55 <flo-retina> *inclined
16:41:53 --> jb has joined #instantbird
17:08:10 <clokep_work> flo-retina: I don't think it's a security issue.
17:12:07 <flo-retina> it certainly isn't a security issue
17:12:18 <flo-retina> but from his perspective the privacy issue may be real
17:12:32 <flo-retina> I don't know in which country he lives
17:14:19 <clokep_work> Maybe.
17:14:27 <clokep_work> I just get annoyed when people whine in bugs about people not fixing things.
17:14:59 <flo-retina> I'm also annoyed when they suggest "easy" solutions that are more difficult to implement than a real clean solution ;)
17:23:10 <-- rosonline has quit (Client exited)
17:24:41 --> rosonline has joined #instantbird
17:24:45 <-- rosonline has quit (Client exited)
17:24:48 --> rosonline has joined #instantbird
17:33:10 <dew> I also get annoyed by that clokep_work
17:33:57 <dew> I want to contribute but I think that would make me upset
17:34:34 <-- gerard-majax__ has quit (Ping timeout)
17:35:11 <flo-retina> dew: generally people don't like to be told what they should spend their time on for volunteer work ;).
17:39:10 <clokep_work> dew: If you want to contribute we can certainly set that up.
17:39:39 <dew> I'm not on your guy's level I'm afraid
17:39:57 <flo-retina> dew: that's even better! It means you have things to learn from us :)
17:41:42 <clokep_work> dew: Our level, what's that mean? Do youw ant to see the first thing I fixed? :P http://hg.instantbird.org/instantbird/rev/859eafe43f67c37444906c3a6f543838f3523a7e
17:41:54 <clokep_work> (Also that's only ~2.5 years ago.)
17:42:43 <dew> how much xml parsing is done in instantbird?
17:43:18 <flo-retina> can you be more specific?
17:43:38 <flo-retina> clokep_work: was that really your first patch?
17:43:53 <clokep_work> flo-retina: Yes, I had been working on JS-IRC for the entire summer before that, I think.
17:44:04 <clokep_work> (And had made vertical tabs + a couple other extensions.)
17:45:37 <dew> I mean is there any sort of parsing problems I could work on?
17:45:42 <flo-retina> right, so you started as an add-on developer. That's another kind of contribution :)
17:45:52 <flo-retina> dew: we don't have our own XML parser
17:46:06 <dew> is all that in gecko?
17:46:10 <flo-retina> yes
17:46:21 <flo-retina> https://bugzilla.mozilla.org/show_bug.cgi?id=775977 could be fixed by a fix in gecko's XML parser
17:46:27 <-- SM0TVI has quit (Ping timeout)
17:46:30 <flo-retina> but I'm afraid we wouldn't be able to help you with that
17:46:49 <flo-retina> (as if we understood that code, we would already have fixed it ;))
17:47:37 --> SM0TVI has joined #instantbird
17:49:33 <-- SM0TVI has quit (Ping timeout)
17:50:48 --> SM0TVI has joined #instantbird
17:51:47 <clokep_work> dew: I'd suggest, personally, if you have some bit that you find annoying then fix it. :P It's much more satisfying to fix something you want.
17:51:57 <clokep_work> But if there isn't, there are probably some minor bugs we could point out.
17:53:43 * clokep_work isn't sure whether to reply to that OTR bug again or not.
17:55:06 <dew> should I reply to it for you? :P
17:55:20 <clokep_work> Haha, no.
17:55:26 <clokep_work> I'll just eat first so I'm not in a bad mood. :P
17:56:52 <flo-retina> clokep_work: bon appétit! :)
17:58:49 --> Mook_as has joined #instantbird
18:04:29 <clokep_work> flo-retina: I ate already. :P
18:04:43 <clokep_work> (Well mostly...)
18:04:45 <clokep_work> But thanks!
18:13:37 --> gerard-majax__ has joined #instantbird
18:23:26 --> DGMurdockIII has joined #instantbird
18:25:52 <-- jb has quit (Quit: jb)
18:26:15 --> jb has joined #instantbird
18:42:42 --> mpmc has joined #instantbird
18:48:39 * clokep_work wonders if aleth's add-on would work in TB too.
18:49:47 <-- jb has quit (Ping timeout)
18:50:03 --> Mnyromyr has joined #instantbird
18:50:57 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
18:56:58 --> unghost has joined #instantbird
19:10:54 <-- mpmc has quit (Connection reset by peer)
19:15:34 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
19:19:34 --> harlock has joined #instantbird
19:32:54 <-- chrisccoulson has quit (Ping timeout)
19:36:17 --> flo-retina has joined #instantbird
19:36:19 * ChanServ sets mode +qo flo-retina flo-retina 
19:37:34 <-- micahg has quit (Ping timeout)
19:43:36 --> micahg has joined #instantbird
20:03:48 --> EionRobb has joined #instantbird
20:15:33 <-- harlock has quit (Connection reset by peer)
20:19:48 --> harlock has joined #instantbird
20:31:26 <-- harlock has quit (Quit: Baibai)
21:30:25 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
21:38:22 <-- clokep_work has quit (Ping timeout)
22:11:45 --> Mic has joined #instantbird
22:11:46 * ChanServ sets mode +h Mic 
22:17:43 --> clokep has joined #instantbird
22:17:43 * ChanServ sets mode +o clokep 
22:47:07 * flo-retina is trying to build a current debug build of Instantbird to be able to test the patches in his review queue
22:47:19 <-- DGMurdockIII has quit (Connection reset by peer)
22:48:03 <clokep> :)
22:48:05 <clokep> Trying? :(
22:50:22 <flo-retina> first 2 attempts failed
22:50:40 <flo-retina> I've now rm -rf'ed my existing debug objdir and I'm retrying from scratch
22:50:56 <flo-retina> clokep: I commented in bug 1612 while I was waiting for my build
22:51:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1612 enh, --, ---, clokep, ASSI, Update libpurple up to 2.10.7
22:51:21 <clokep> OK. :)
22:51:25 <clokep> I'm sure there's some "wrong" stuff w/ it.
22:53:03 <flo-retina> did you have to edit anything?
22:53:27 <clokep> I think a couple of hunks failed because they were already applied, that was all.
22:53:38 <clokep> And I had to hand edit one or two things.
22:54:04 <flo-retina> is there any decent way to review that changeset?
22:54:32 <flo-retina> maybe create the diff between current and the official libpurple, then apply the patch, and create the diff again, and diff the 2 diffs?
22:54:43 <flo-retina> that should shows what you had to hand edit, right?
22:55:19 <clokep> "current" being what's in the repo?
22:55:30 <clokep> Isn't that created as part of the upgrade script?
22:56:15 <clokep> I have a diff-current-to-2.10.4.patch, a diff-update-to-2.10.7.patch in my directory.
22:56:28 <flo-retina> the patch in bug 1869 adds trailing whitespace to 8 empty lines. That's sad for a patch supposed to fix whitespace :(
22:56:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1869 tri, --, ---, clokep, ASSI, Fix spacing in account.xml and accounts.xul
22:56:46 <clokep> :-/ Can I blame Komodo?
22:56:48 <flo-retina> yes, that's created as part of the update script
22:56:58 <flo-retina> blame Mook_as then
22:57:08 <flo-retina> but it's still sad!
22:57:15 <clokep> I can put up a new patch if you want. :P
22:58:06 <flo-retina> is that better than me opening the file in emacs and running the kill trailing whitespace command?
22:58:32 <clokep> So pretty much you want me to diff what I have with that patch applied w/ 2.10.7 official,  then diff that with my diff-current-to-2.10.4.patch?
22:58:33 <clokep> No.
22:59:03 <flo-retina> done
22:59:03 <Mook_as> clokep: komodo has an option to trim whitespace at EOL these days... is it not doing the right thing? :(
22:59:28 <flo-retina> Mook_as: adding more whitespace doesn't sound like the good thing :-P
22:59:51 <flo-retina> Mook_as: more generally, the good thing is to trim white space of lines that the user edited, and to leave everything else untouched ;)
23:00:02 <Mook_as> yep, that's what the option is _supposed_ to do
23:00:03 <clokep> Mook_as: It was throwing errors for me in the nightly, I haven't re-enabled it for 8 yet.
23:00:08 <Mook_as> ah, okay
23:00:33 <clokep> It's supposed to be fixed...but you guys don't like...generate new nightlies oftne.
23:00:48 <flo-retina> clokep: so if you can do |diff -u diff-current-to-2.10.4.patch diff-current-to-2.10.7.patch| in your terminal and pastebin (or attach to the bug) the result, that may help for the review
23:00:57 <Mook_as> yeah :( I'll go prod todd more
23:01:10 <clokep> I don't care now. :P I'm on 8b1 now!
23:01:58 <-- Mic has quit (Quit: Output/input error)
23:02:06 <instantbot> florian@instantbird.org granted review for attachment 2214 on bug 1869.
23:02:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1869 tri, --, ---, clokep, ASSI, Fix spacing in account.xml and accounts.xul
23:02:37 <flo-retina> ok, it's done sucking CPU
23:02:43 <flo-retina> 13m6.560s, that's getting slow :-/
23:05:09 <-- Mnyromyr has quit (Ping timeout)
23:07:15 <clokep> flo-retina: http://pastebin.instantbird.com/144478 is what I ended up with . :-S
23:11:13 <instantbot> florian@instantbird.org granted review for attachment 2220 on bug 898.
23:11:17 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=898 maj, --, ---, nobody, NEW, Copying text from conversations removes leading indent
23:11:52 * clokep guesses flo doesn't agree w/ his comment about that bug. ;)
23:11:53 <instantbot> florian@instantbird.org granted review for attachment 2236 on bug 1870.
23:11:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1870 nor, --, ---, aleth, ASSI, Leading whitespace is lost from messages
23:12:06 <flo-retina> clokep: about div vs span?
23:12:09 <clokep> Oh wait, yeah.
23:12:14 <clokep> Different bug! :-D
23:12:17 <flo-retina> I don't see how that makes a difference
23:12:42 <clokep> It's a semantic thing, inline elements aren't supposed to have block level elements in it.
23:12:54 <clokep> But it doesn't really matter.
23:12:58 <flo-retina> a message is an inline thing, isn't it?
23:13:19 <clokep> Is it?
23:13:23 <clokep> Do we know what HTML is in it?
23:13:48 <flo-retina> we wrap them in <span class="ib-msg-txt"> to display them, so it seems right to me to also use a span when parsing.
23:14:24 <flo-retina> clokep: is there any HTML tag that we let go through our filter that isn't inline?
23:14:31 <flo-retina> or is your point that it isn't filtered yet?
23:14:33 <clokep> Ah, do we? OK.
23:14:42 <clokep> My point is that it isn't filtered yet.
23:15:32 <flo-retina> if something really shouldn't be inside a span, then we can hope the HTML parser will fix it, and it will be cleaned up and ready for us to include it in our span for display :)
23:15:37 <flo-retina> but anyway, I don't think it matters
23:15:48 <-- qlum has quit (Quit: Getting the <censored> out.)
23:15:53 <clokep> Fine w/ me. :)
23:15:56 <flo-retina> and I lack words to express how happy I am that these 2 bugs are finally getting fixed. aleth++ :)
23:16:31 <flo-retina> I was ashamed that we were losing data when people were copy/pasting code around
23:16:33 <clokep> Mook_as will be happy too.
23:16:51 <flo-retina> so will all developers who use Instantbird to talk about what they are coding
23:17:04 <flo-retina> that's much more useful to me than equations ;)
23:17:55 <clokep> We must do different things for our day jobs. ;)
23:18:44 <flo-retina> clokep: http://pastebin.instantbird.com/144478 seems completely wrong
23:18:54 <clokep> flo-retina: I agree.
23:19:00 <flo-retina> could it be that it's diffing the while file because of line ending issues?
23:19:28 <clokep> No, you would see it added back w/ the different line ending.
23:19:40 <flo-retina> clokep: no, pastebin cropped it ;)
23:20:12 <clokep> flo-retina: No, it iddn't.
23:21:51 <flo-retina> try regenerating diff-current-to-2.10.7.patch
23:21:58 <flo-retina> I suspect you created it before applying our patches
23:21:59 <clokep> I ran:
23:21:59 <clokep> Patrick@WHISTLER ~/instantbird/purple
23:22:00 <clokep> $ diff -ru extract/pidgin-2.10.7/libpurple libpurple > ./diff-current-to-2.10.7.patch
23:22:00 <clokep> $ diff -u diff-current-to-2.10.4.patch diff-current-to-2.10.7.patch > ../diffs-
23:22:00 <clokep> of-diffs.diff
23:22:19 <clokep> I just created it now, it isn't created "before".
23:22:54 <flo-retina> uh
23:23:10 <flo-retina> why did you do "diff -ru extract/pidgin-2.10.7/libpurple libpurple > ./diff-current-to-2.10.7.patch" ?
23:23:31 <flo-retina> extract/pidgin-2.10.7/libpurple is the patched libpurple if you've just done an update
23:24:13 --> Mic has joined #instantbird
23:24:13 * ChanServ sets mode +h Mic 
23:24:20 <flo-retina> just run |DIFFCURRENTONLY=1 bash upgrade-libpurple.sh| in purple/ to generate that file correctly
23:24:53 <flo-retina> it will rm -rf extract/pidgin-2.10.7/libpurple but that shouldn't matter as you've already got a patch from your work there
23:25:19 <clokep> flo-retina: I did that because I don't reall yknow what you want.
23:25:51 <clokep> Do you really want "diff-*update*-to-2.10.7.patch"?
23:26:19 <flo-retina> no
23:26:42 <clokep> That file was *NOT* generated when I updated everything.
23:26:58 <clokep> I had diff-current-to-2.10.4 and diff-update-to-2.10.7
23:26:59 <flo-retina> I just gave you the command to generate it
23:27:42 <clokep> I just did it.
23:27:43 <flo-retina> clokep: :( I misread this line "I have a diff-current-to-2.10.4.patch, a diff-update-to-2.10.7.patch in my directory."
23:27:45 <clokep> http://pastebin.instantbird.com/144480
23:28:01 <clokep> flo-retina: That looks more reasonable ^
23:28:10 <flo-retina> it looks almost reasonable
23:28:20 <flo-retina> too bad these diffs weren't created with the option to avoid timestamps :(
23:28:33 <clokep> :-/
23:28:39 <clokep> Maybe we should add tha toption? :P
23:28:46 <flo-retina> we should probably add that to the script
23:29:33 <flo-retina> you can fix it with sed
23:30:29 <flo-retina> s@pidgin-2.10.4@pidgin@;s@2012-05-06 23:37:.. -0400@@
23:30:33 <flo-retina> and similar for the other log file
23:32:44 <flo-retina> bah, Mic is right of course; too bad that patch is already commited :(
23:33:23 <Mic> :(
23:33:41 <Mic> Good night
23:34:12 <-- Mic has quit (Quit: Output/input error)
23:35:43 <flo-retina> I'm afraid we may regress bug 157 with these 2 patches
23:35:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=157 nor, --, ---, nobody, RESO INCOMPLETE, Remove the "from" account from adjacent individual messages
23:35:48 <flo-retina> but there's no clear test case there :(
23:38:17 <clokep> flo-retina: http://pastebin.instantbird.com/144491 might be better.
23:39:04 <clokep> flo-retina: Actually should have all the times removed now. http://pastebin.instantbird.com/144492
23:39:20 <flo-retina> thanks :)
23:39:27 <clokep> Sorry that took so long.
23:39:35 <clokep> Some were -4, some were -5 timezones, etc. :(
23:39:37 <clokep> Took a little w/ the regex.
23:41:42 <flo-retina> I wonder what NSS_SetDomesticPolicy() does
23:41:57 <clokep> Hmm...diff doesn't seem to have a flag to not have dates. :(
23:42:40 <flo-retina> bah, it was already there before
23:42:58 <flo-retina> hg diff has one at least
23:43:04 <flo-retina> although I can never remember what iti s
23:43:33 <clokep> Yeah....but that's not helpful. :P
23:43:50 <flo-retina> btw, that update looks like it has no string change
23:44:08 <flo-retina> but it's possible some translations were updated
23:47:27 <clokep> OK. I'll see if I can get that to work.
23:47:35 <clokep> For some reason I think I'm missing a function though...
23:49:09 * clokep isn't concerned about bug 157...
23:49:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=157 nor, --, ---, nobody, RESO INCOMPLETE, Remove the "from" account from adjacent individual messages
23:51:27 <flo-retina> "I'll see if I can get that to work" get what?
23:51:48 <flo-retina> if you want to ignore the libpurple translation files for this update, that's fine with me
23:52:23 <flo-retina> and if you do, it will be a separate patch againt http://hg.instantbird.org/l10n/libpurple/
23:52:43 <flo-retina> (as the en-US files will be unchanged, as there's no new localizable string)
23:53:07 <clokep> I meant the localization stuff, yeah.
23:54:15 <clokep> Hmm....teling me there's no pidgin.pot
23:59:34 <flo-retina> you need to run that make-pot-file.sh script then
23:59:45 <flo-retina> for some reason I thought that was done automatically :-S