#instantbird log on 01 12 2013

All times are UTC.

00:11:45 <-- flo-retina has quit (Ping timeout)
01:06:45 <-- qlum has quit (Quit: Getting the <censored> out.)
01:22:51 <-- dew has quit (Ping timeout)
01:27:49 --> dew has joined #instantbird
01:28:21 <instant-buildbot> build #357 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/357
01:55:19 <-- Mook_as has quit (Quit: Mook_as)
02:30:09 --> skeledrew has joined #instantbird
03:05:07 <-- skeledrew has quit (Ping timeout)
03:07:16 --> Mook has joined #instantbird
03:11:12 --> skeledrew has joined #instantbird
03:37:40 <instant-buildbot> build #744 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/744
03:38:36 <-- Optimizer has quit (Ping timeout)
03:43:33 <-- praefectus has quit (Quit: praefectus)
03:50:00 --> Optimizer has joined #instantbird
04:14:22 <-- Optimizer has quit (Ping timeout)
04:21:05 <-- EionRobb has quit (Ping timeout)
04:26:15 --> EionRobb has joined #instantbird
04:27:07 <instant-buildbot> build #742 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/742
04:35:57 --> Optimizer has joined #instantbird
05:31:26 <instant-buildbot> build #831 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/831
06:22:54 --> deltafalcon has joined #instantbird
07:31:32 <-- Mook has quit (Quit: Mook)
07:36:15 --> jb1 has joined #instantbird
07:36:38 <-- jb has quit (Ping timeout)
07:53:56 --> Kaishi has joined #instantbird
07:56:38 --> flo-retina has joined #instantbird
07:56:38 * ChanServ sets mode +qo flo-retina flo-retina 
08:20:09 <-- jb1 has quit (Ping timeout)
08:37:57 --> jb has joined #instantbird
08:39:45 <-- jb has quit (Ping timeout)
09:01:51 <-- Optimizer has quit (Ping timeout)
09:07:20 --> Optimizer has joined #instantbird
09:23:29 --> jb has joined #instantbird
09:42:55 <-- jb has quit (Ping timeout)
09:46:50 --> jb has joined #instantbird
10:16:21 --> rosonline has joined #instantbird
10:26:52 --> Mic has joined #instantbird
10:26:53 * ChanServ sets mode +h Mic 
10:27:27 <-- Mic has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
10:38:08 <-- flo-retina has quit (Connection reset by peer)
10:38:10 --> flo-retina has joined #instantbird
10:38:10 * ChanServ sets mode +qo flo-retina flo-retina 
11:14:48 <-- Optimizer has quit (Ping timeout)
11:18:08 <-- flo-retina has quit (Connection reset by peer)
11:18:10 --> flo-retina has joined #instantbird
11:18:10 * ChanServ sets mode +qo flo-retina flo-retina 
11:18:15 --> Optimizer has joined #instantbird
11:21:45 --> gerard-majax has joined #instantbird
11:26:52 --> qlum has joined #instantbird
11:30:21 <-- flo-retina has quit (Connection reset by peer)
11:30:22 --> flo-retina has joined #instantbird
11:30:22 * ChanServ sets mode +qo flo-retina flo-retina 
11:32:52 <-- flo-retina has quit (Input/output error)
11:32:53 --> flo-retina has joined #instantbird
11:32:54 * ChanServ sets mode +qo flo-retina flo-retina 
11:35:23 <-- flo-retina has quit (Input/output error)
11:35:26 --> flo-retina has joined #instantbird
11:35:26 * ChanServ sets mode +qo flo-retina flo-retina 
11:37:56 <-- flo-retina has quit (Input/output error)
11:37:57 --> flo-retina has joined #instantbird
11:37:57 * ChanServ sets mode +qo flo-retina flo-retina 
11:40:27 <-- flo-retina has quit (Input/output error)
11:40:29 --> flo-retina has joined #instantbird
11:40:29 * ChanServ sets mode +qo flo-retina flo-retina 
11:42:59 <-- flo-retina has quit (Input/output error)
11:43:03 --> flo-retina has joined #instantbird
11:43:03 * ChanServ sets mode +qo flo-retina flo-retina 
11:45:32 --> flo-retina1 has joined #instantbird
11:45:34 <-- flo-retina has quit (Input/output error)
11:48:04 --> flo-retina has joined #instantbird
11:48:04 * ChanServ sets mode +qo flo-retina flo-retina 
11:49:28 <-- flo-retina1 has quit (Input/output error)
11:50:35 <-- flo-retina has quit (Connection reset by peer)
11:50:36 --> flo-retina has joined #instantbird
11:50:36 * ChanServ sets mode +qo flo-retina flo-retina 
11:53:07 --> flo-retina1 has joined #instantbird
11:53:07 <-- flo-retina has quit (Client exited)
11:55:39 <-- flo-retina1 has quit (Connection reset by peer)
11:55:40 --> flo-retina has joined #instantbird
11:55:40 * ChanServ sets mode +qo flo-retina flo-retina 
11:58:11 <-- flo-retina has quit (Connection reset by peer)
11:58:11 --> flo-retina1 has joined #instantbird
11:59:20 <-- jb has quit (Ping timeout)
12:00:42 --> flo-retina has joined #instantbird
12:00:42 * ChanServ sets mode +qo flo-retina flo-retina 
12:02:16 <-- flo-retina1 has quit (Input/output error)
12:04:07 --> jb has joined #instantbird
12:06:45 <-- jb has quit (Ping timeout)
12:07:16 --> jb has joined #instantbird
12:12:37 <-- jb has quit (Ping timeout)
12:20:57 <-- Kaishi has quit (Quit: Kaishi)
12:25:29 <-- flo-retina has quit (Connection reset by peer)
12:25:32 --> flo-retina has joined #instantbird
12:25:32 * ChanServ sets mode +qo flo-retina flo-retina 
12:27:47 <-- qlum has quit (Client exited)
12:54:57 <-- rosonline has quit (Ping timeout)
12:57:17 --> mpmc has joined #instantbird
12:57:45 --> rosonline has joined #instantbird
13:32:42 --> clokep has joined #instantbird
13:32:42 * ChanServ sets mode +o clokep 
13:41:00 --> qlum has joined #instantbird
13:52:27 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
13:52:34 --> clokep has joined #instantbird
13:52:34 * ChanServ sets mode +o clokep 
13:55:37 --> Kaishi has joined #instantbird
14:03:54 <-- Kaishi has quit (Ping timeout)
14:07:39 --> Kaishi has joined #instantbird
14:08:46 <-- Tonnes has quit (Quit: ChatZilla 0.9.89 [Firefox 18.0/20130104151925])
14:26:53 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 2185 on bug 1661.
14:26:54 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2186 on bug 1661.
14:26:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1661 nor, --, ---, clokep, ASSI, Reconnecting with IRC causes nicks in ISON messages to duplicate
14:28:49 <flo-retina> looking
14:34:45 <flo-retina> clokep: it's a little bit confusing that the original trackBuddy implementation from the account takes a nick as parameter and the the overloaded implementations from ircWatchMonitor take an array as parameter
14:35:58 <clokep> flo-retina: Yes, I noticed that's a little weird too.
14:36:08 <clokep> I can change that if you want.
14:36:17 <clokep> Either as part of this bug or as something else.
14:36:27 <flo-retina> I don't see an obvious easy way to change it
14:36:47 <clokep> flo-retina: You just iterate over the array and call trackbuddy for each nick.
14:36:52 <clokep> Oh wait.
14:36:54 <clokep> You can't do that.
14:36:56 <clokep> Never mind.
14:37:30 --> Tonnes has joined #instantbird
14:38:00 <flo-retina> that would be a nice way to get some I/O error ;)
14:39:16 <-- flo-retina has quit (Connection reset by peer)
14:39:17 --> flo-retina has joined #instantbird
14:39:18 * ChanServ sets mode +qo flo-retina flo-retina 
14:45:36 <flo-retina> clokep: ok, if you didn't notice anything you wanted to change since you attached it, let's take it as is :)
14:45:36 <clokep> flo-retina: I could change the ISON one to take an array too if you want. :P
14:45:54 <clokep> I didn't notice anything that I think should change right now.
14:45:54 <flo-retina> would there be any use case for it?
14:46:03 <clokep> Nope. Just unifying APIs.
14:47:18 <flo-retina> if (Array.isArray(aNicks))
14:47:19 <flo-retina>   aNicks.forEach(this.trackQueue.unshift);
14:47:19 <flo-retina> else
14:47:19 <flo-retina>   this.trackQueue.unshift(aNicks);
14:47:19 <flo-retina> ?
14:47:42 <flo-retina> adding more dead code doesn't seem a real improvement ^^
14:48:22 <instantbot> florian@instantbird.org granted review for attachment 2186 on bug 1661.
14:48:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1661 nor, --, ---, clokep, ASSI, Reconnecting with IRC causes nicks in ISON messages to duplicate
14:48:47 <clokep> I agree. :-D
14:48:53 <clokep> It was mostly a fake suggestions.
14:49:28 <flo-retina> I think a comment would be useful somewhere (as it seems we were both confused when reading the code), but I don't know where exactly, so let's add it the next time we are confused with this code :)
14:49:45 <flo-retina> pushed! :)
14:53:11 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/eab4becb3c7f - Patrick Cloke - Bug 1661 - Reconnecting with IRC causes nicks in ISON messages to duplicate, r=fqueze.
15:03:59 <instant-buildbot> build #344 of macosx-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/344  blamelist: Patrick Cloke <clokep@gmail.com>
15:19:20 <clokep> Haha. sweet.
15:20:46 <flo-retina> pff
15:20:55 <flo-retina> (won't happen with a clobber, don't worry)
15:21:58 <clokep> I wasn't too concerned. :-D
15:32:34 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
16:20:23 <clokep> flo: Do you know if we would still need http://lxr.instantbird.org/instantbird/source/tools/patches/use-clang-for-osx.patch for Moz 18?
16:26:30 <clokep> Hmm....seems the file was renamed.
16:41:53 <-- rosonline has quit (Ping timeout)
16:42:48 --> rosonline has joined #instantbird
16:44:39 --> mconley has joined #instantbird
17:12:48 --> Optimizer1 has joined #instantbird
17:13:00 <-- Optimizer1 has quit (Quit: bye :))
17:25:27 <-- rosonline has quit (Ping timeout)
17:30:19 --> rosonline has joined #instantbird
17:37:26 <-- Optimizer has quit (Ping timeout)
17:39:26 <-- mconley has quit (Input/output error)
17:40:36 --> Optimizer has joined #instantbird
17:51:54 <-- rosonline has quit (Ping timeout)
17:57:14 --> rosonline has joined #instantbird
18:21:27 <-- EionRobb has quit (Quit: Leaving.)
19:12:26 --> mconley has joined #instantbird
19:19:44 <-- clokep has quit (Ping timeout)
19:41:27 --> gerard-majax_ has joined #instantbird
19:41:36 <-- gerard-majax has quit (Connection reset by peer)
19:46:19 <-- rosonline has quit (Ping timeout)
19:47:25 --> rosonline has joined #instantbird
19:47:27 <-- qlum has quit (Ping timeout)
19:48:15 --> qlum has joined #instantbird
20:02:19 <-- mconley has quit (Ping timeout)
20:21:54 <-- gerard-majax_ has quit (Ping timeout)
20:39:55 <-- qlum has quit (Ping timeout)
20:43:20 --> qlum has joined #instantbird
20:45:06 <-- qlum has quit (Ping timeout)
20:45:09 --> qlum has joined #instantbird
20:45:23 --> gerard-majax_ has joined #instantbird
22:34:59 <-- mpmc has quit (Connection reset by peer)
22:55:29 <-- Even has quit (Ping timeout)
22:58:56 --> Even has joined #instantbird
22:58:56 * ChanServ sets mode +o Even 
23:12:53 <-- Even has quit (Ping timeout)
23:46:05 --> EionRobb has joined #instantbird