#instantbird log on 12 27 2012

All times are UTC.

00:04:16 <-- meh has quit (Quit: If you ever feel like dying to help the universe, just let me know.)
00:27:46 <-- skeledrew has quit (Connection reset by peer)
00:28:11 --> skeledrew has joined #instantbird
00:37:42 <instant-buildbot> build #369 of linux-onCommit is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/369  blamelist: Florian Qu?ze <florian@instantbird.org>
00:48:39 --> clokep has joined #instantbird
00:48:39 * ChanServ sets mode +o clokep 
00:54:35 <instant-buildbot> build #722 of linux-nightly-default is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/722
01:11:39 <-- rosonline has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
01:16:03 <-- clokep has quit (Ping timeout)
01:32:14 <instant-buildbot> build #355 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/355
01:40:47 <-- DGMurdockIII has quit (Connection reset by peer)
01:41:10 --> DGMurdockIII has joined #instantbird
01:41:43 <-- EionRobb has quit (Ping timeout)
01:46:08 --> EionRobb has joined #instantbird
02:20:06 --> clokep has joined #instantbird
02:20:06 * ChanServ sets mode +o clokep 
02:21:00 <-- EionRobb has quit (Connection reset by peer)
02:22:20 --> EionRobb has joined #instantbird
02:38:54 <-- Optimizer has quit (Ping timeout)
03:01:03 <clokep> Can we modify things (i.e. add HTML) without it going through the content filters? I think Mic ran into this before and it isn't possible?
03:23:13 <-- clokep has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
03:27:03 <instant-buildbot> build #723 of linux-nightly-default is complete: Failure [failed compile]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/723
04:17:04 <instant-buildbot> build #726 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/726
04:20:15 --> Optimizer has joined #instantbird
05:13:55 --> mpmc has joined #instantbird
05:44:20 <instant-buildbot> build #815 of win32-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/815
05:47:38 <mpmc> :(
05:52:57 <-- Kaishi has quit (Quit: Kaishi)
05:54:24 <-- Optimizer has quit (Ping timeout)
05:57:41 --> Optimizer has joined #instantbird
06:05:29 <-- Optimizer has quit (Ping timeout)
06:08:50 --> Optimizer has joined #instantbird
07:17:26 <-- ivan has quit (Ping timeout)
07:18:00 --> ivan has joined #instantbird
07:50:02 <-- Optimizer has quit (Ping timeout)
07:53:47 --> Optimizer has joined #instantbird
07:55:17 --> jb has joined #instantbird
08:16:47 <-- jb has quit (Quit: jb)
08:18:21 --> jb has joined #instantbird
08:19:35 <-- Optimizer has quit (Ping timeout)
08:26:30 --> Optimizer1 has joined #instantbird
08:55:58 <-- Optimizer1 has quit (Ping timeout)
09:14:07 <-- jb has quit (Ping timeout)
09:20:06 <-- EionRobb has quit (Ping timeout)
09:49:56 --> jb has joined #instantbird
09:50:27 <flo-retina> clokep: "Can we modify things (i.e. add HTML) without it going through the content filters?" define "we". prpls shouldn't be able to do that. Add-ons certainly can.
09:51:28 --> rosonline has joined #instantbird
09:51:52 --> rosonlin1 has joined #instantbird
09:52:45 <-- jb has quit (Broken pipe)
09:54:38 --> jb has joined #instantbird
09:58:06 <-- jb has quit (Quit: jb)
09:58:27 --> jb has joined #instantbird
11:03:42 <-- mpmc has quit (Connection reset by peer)
12:27:58 <-- spiffytech has quit (Ping timeout)
12:31:51 --> meh has joined #instantbird
12:31:53 --> spiffytech has joined #instantbird
12:50:41 --> Kaishi has joined #instantbird
13:05:19 <-- rosonlin1 has quit (Quit: rosonlin1)
13:09:32 --> clokep has joined #instantbird
13:09:33 * ChanServ sets mode +o clokep 
13:26:09 <clokep> flo-retina: I meant in an add-on, not a prpl.
13:39:50 <-- meh has quit (Quit: If you ever feel like dying to help the universe, just let me know.)
13:57:27 --> gaston has joined #instantbird
13:57:28 <gaston> hi
13:57:53 <gaston> how do i setup popup notifications in tb when new messages are received in the chat tab ?
13:58:11 <gaston> so far the only notification you get in thunderbird is the 'chat' in bold in the button bar..
13:58:52 <clokep> I don't think there's a way to do that, I'm fairly certain bugs are filed though...
14:01:04 <gaston> https://bugzilla.mozilla.org/show_bug.cgi?id=742746 looks like a candidate
14:14:52 <clokep> Yes, that seems like it.
14:15:17 <-- DGMurdockIII has quit (Ping timeout)
14:15:40 --> DGMurdockIII has joined #instantbird
14:26:28 <flo-retina> clokep: hello :)
14:27:45 <flo-retina> Have you seen that timer patch yet? (I can provide more explanations if they can help with the review :)). Do we have any plan to get Linux nightlies again?
14:28:09 <clokep> flo-retina: I saw that you posted it, but haven't read it yet. I was too tired last night.
14:28:24 <clokep> We should get Linux nightlies again, yes...unfrotunately it doesn't really bother me. :-[
14:29:19 <flo-retina> that's ok, there's no rush :). (I'm just curious to try that on nightlies to see if it reduces the CPU usage when idle :))
14:29:41 <flo-retina> and for the linux nightlies... it hasn't really bothered me either :(
14:30:05 <flo-retina> but we shouldn't let that situation continue much longer
14:31:52 <clokep> Yes. :-/
14:33:09 <flo-retina> and I'm not completely sure of the plan to get im/ in c-c, but I have a feeling that nowish would be the right time to push on that
14:33:35 <clokep> I think so too.
14:33:51 <clokep> Do we know the cause of the Linux issue and just need to create a patch?
14:34:00 <flo-retina> no
14:34:50 <flo-retina> it could be either a build config issue (but I didn't see anything obvious when comparing the compiler flags of the regular code and unit tests), or a bug of the compiler installed on the build slave
14:35:01 <flo-retina> I was wondering if we should just turn off the unit tests
14:35:25 <flo-retina> hmm http://lxr.instantbird.org/instantbird/source/tools/buildbot-configs/macosx/mozconfig#28
14:35:31 <flo-retina> why are tests disabled on Mac?
14:35:40 <flo-retina> is that something we should have reverted when dropping PPC?
14:36:11 <flo-retina> I'm not too worried about disabling tests on one of our OSes *temporarily*, but I don't want them to be disabled everywhere!
14:36:56 <flo-retina> http://hg.instantbird.org/instantbird/rev/ce19d6a4e4dc the commit message seems to indicate that we want to revert that
14:37:23 <gaston> wait, what's this talk of dropping ppc ? what's os-dependant in instantbird ?
14:37:35 <gaston> or rather arch-dependant
14:38:36 <flo-retina> gaston: We no longer support Mac OS X 10.5 which  was the latest mac os version supporting the PPC architecture.
14:38:59 <gaston> ah, that - as long as you dont unsupport other oses on ppc..
14:39:33 <flo-retina> gaston: we've never supported any other OSes on PPC (but there's no reason for Instantbird to not build on linux ppc; we just don't 'support' that)
14:39:44 <gaston> ok support as in 'tier1
14:40:17 <flo-retina> support as in "provide official builds for that OS/platform ourselves"
14:40:48 <gaston> i'm on the "packager for obscure os/arch" side :)
14:41:02 <flo-retina> are you packaging Instantbird?
14:41:39 <gaston> not instantbird directly, but in thunderbird yes
14:42:00 <gaston> although i 'could' add instantbird to my nightly buildbot since it already does ffx/tb
14:43:22 <flo-retina> nothing related to Instantbird builds discussed here is relevant to Thunderbird (issues related to Tb builds are discussed in #maildev)
14:43:33 <clokep> flo-retina: Yes, sounds like we should start running tests on Mac again.
14:43:36 <flo-retina> we aren't building on Mozilla's build infrastructure, we (have to) maintain our own set of build servers
14:43:52 <gaston> oh i just popped up here to see if visual popup integration was in the plans, and i found it in 742746
14:44:23 <flo-retina> I'm not aware of anybody actively working on Thunderbird's Chat UI currently.
14:45:08 <gaston> hm, you mean that the integration in TB was a code drop at some point, and will not be really maintained on the long term (now that tb is .. dormant) ?
14:45:47 <flo-retina> I mean that adding IM to Tb used to be my full time job, and that I've been moved to other projects after Tb 17 was released.
14:45:58 <gaston> ah.
14:46:39 <flo-retina> so future improvements to IM in Tb will likely happen, but there's no "plan" for it. It will just happen whenever someone submits a patch for it.
14:46:52 <gaston> yeah i already got that part :)
14:47:10 <flo-retina> :)
14:47:26 <clokep> flo-retina: You revert that already or do you want a patch?
14:47:29 <gaston> so you work for mozilla on other unrelated things, and keep working on instantbird as a personal project ?
14:47:56 <flo-retina> gaston: my work on Instantbird has never been paid by Mozilla; it's always been a persona project.
14:48:24 <flo-retina> clokep: I can revert that without a bug/patch (I'll just backout the changeset)
14:48:48 <flo-retina> clokep: should I disable tests on Linux, or are we hoping to find a better solution?
14:48:48 <clokep> flo-retina: That was going to be my suggestion. :)
14:49:25 <flo-retina> it would be nice to only disable C++ unit tests (we don't care about them anyway...) without disabling our own xpcshell tests
14:49:26 * instantbot mumbles something about c++ being evil
14:49:43 <flo-retina> I don't think we ever run these C++ tests anyway
14:53:03 <clokep> flo-retina: I think disabling unit tests is a good solution for the moment.
14:53:11 <clokep> If they run on Windows, we should be OK. :-D
14:56:09 <flo-retina> pff, the build where I have my timer patch applied still takes 3% of CPU all the time
14:56:16 <flo-retina> and the profiler doesn't show anything useful
14:56:28 * clokep goes to review that.
14:56:40 <flo-retina> (it tells me 98.1% of the time is spent waiting for events, with the CPU idle)
14:58:40 <-- flo-retina has quit (Quit: Instantbird 1.4a1pre -- http://www.instantbird.com)
14:58:42 --> flo-retina has joined #instantbird
14:58:43 * ChanServ sets mode +qo flo-retina flo-retina 
14:58:48 <clokep> flo-retina: So...the change in tabbrowser.xml seems weird to me.
14:58:56 <flo-retina> ah?
14:58:58 <clokep> lines 223 - 239.
14:59:22 <clokep> You're setting docShell.isActive to false, then setting the currentBrowser to something different, then setting isActive again.
14:59:34 <clokep> What is that first line doing?
15:00:05 <flo-retina> If we are staying on the same tab, there's an early return at line 227
15:00:23 <flo-retina> so in that function, we are changing which tab/conversation/browser is the currently active one for that window.
15:00:54 <flo-retina> this.mCurrentBrowser is the browser in the tab that's being unselected, until we change its value
15:01:07 <clokep> Ah, I see.
15:01:09 <flo-retina> (that's a straight port of what the Firefox tabbrowser code does)
15:01:19 <clokep> OK, that makes sense.
15:02:06 <flo-retina> except that for Firefox they complicated things by adding a docShellIsActive property to the browser binding, because e10s didn't want it and they wanted to have a single ifdef.
15:04:10 <clokep> I see...
15:04:17 <clokep> Lots of vars...
15:04:33 <clokep> But that's maintaining consistent styling. :)
15:06:48 <flo-retina> I think some refactoring in tabbrowser.xml to have all the event handlers handled by a single method instead of creating an object caching "this" for each listener would be a good idea, but I didn't want my patch to change hundreds of lines in that file
15:07:01 <flo-retina> we could/should do that as a separate refactoring if we care
15:07:22 <clokep> Bubble's Footer could use a further refactoring too, I think. :)
15:08:31 --> mic|web has joined #instantbird
15:08:37 <mic|web> Hi!
15:08:48 <mic|web> I hope you all had nice christmas days? :)
15:09:49 <clokep> mic|web: Hello, it was fine. I hope yours was well.
15:10:13 <flo-retina> clokep: I have another patch coming soon to cleanup Bubbles' main.css, and the JS code in Footer.js that touches the "class" attributes
15:10:14 <mic|web> Yes, it was, thanks
15:10:24 <flo-retina> mic|web: hello :)
15:10:33 <clokep> flo-retina: So I can't say I understand every single line in there, but I don't see anything obviously wrong.
15:10:38 <flo-retina> s/Footer.js/Footer.html/
15:11:10 <mic|web> clokep: regarding your question (http://log.bezut.info/instantbird/121227/#m19), do you know these methods here: http://lxr.instantbird.org/instantbird/source/chat/modules/imContentSink.jsm#17 ?
15:12:19 <flo-retina> mic|web: and now they actually work, as I had to fix them when writing unit tests ;)
15:12:25 <clokep> mic|web: My question was meant with the context of NOT changing the content sink on the user.
15:12:53 <flo-retina> clokep: I think it would be easier to answer your question if we knew what you are actually trying to do ;)
15:13:08 <clokep> flo-retina: I want to be able to insert MathML.
15:13:21 <flo-retina> wasn't that something aleth was already doing?
15:13:31 <clokep> (I want to convert LaTeX to MathML on the fly actually, but first step is allowing MathML...)
15:13:38 <clokep> I don't remember that, but it's possible.
15:14:10 <flo-retina> how many additional tags do you need for that?
15:14:21 <clokep> I think there's quite a few.
15:14:23 <flo-retina> you want these tags to come from the network, right?
15:14:26 <instantbot> clokep@gmail.com granted review for attachment 2180 on bug 1696.
15:14:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1696 nor, --, ---, florian, ASSI, Bubbles' refreshIntervals function should be rewritten to make timers fire less often
15:15:07 <clokep> It could either be sent as LaTeX and then parsed on display or parsed before sending and sent as MathML.
15:15:24 <clokep> There's a bunch of elements: https://developer.mozilla.org/en-US/docs/MathML/Element
15:15:53 <flo-retina> is the user supposed to speak LaTeX's math code, or would there be some kind of edit UI?
15:16:25 <mic|web> clokep: my plan was to allow particular ids with a filtering function and to insert a node with such an id where I'd need it. It would have been replaced later with the actual content. I've never actually implemented this anywhere though ...
15:17:20 <flo-retina> clokep: thanks for the review! :)
15:17:35 <clokep> flo-retina: Directly input LaTeX for now.
15:18:08 <clokep> (It'd be really nice if this was evaluated in the input box too and showed exactly what was being sent...of course...)
15:18:23 <flo-retina> ok, then you don't need the markup to go on the network, and it's all plain text as far as imContentSink is concerned
15:18:32 <flo-retina> you would just change it all at the UI level in text modifiers
15:18:55 <-- Kaishi has quit (Quit: Kaishi)
15:19:44 <mic|web> Ah, yes. Text modifiers weren't enough for what I wanted to do (it was to append a preview of the content at the end of the message).
15:19:56 <flo-retina> (btw, the text modifiers API seems to have very poor performances, because these functions come from different compartments, and lots of cross compartment wrappers are created on the fly when using them)
15:21:26 <clokep> flo-retina: Do text modifiers go through the content sink?
15:21:36 <clokep> Or is the proper way to do it with text modifiers + add the tags to the "safe" list?
15:22:33 <flo-retina> clokep: the tags created by text modifiers aren't filtered.
15:23:29 <clokep> flo-retina: Excellent. :) Thanks!
15:23:33 <flo-retina> clokep: the text modifiers are handled by imContentSink because we already have a DOM tree when we are there; it avoids reparsing the message to apply the modifiers.
15:24:05 <clokep> I'd like to make Instantbird really good at discussing math, etc.
15:24:11 <flo-retina> :)
15:24:25 <clokep> (Plus it'll convert some of my MIT friends. ;))
15:24:33 <flo-retina> :)
15:24:38 <flo-retina> what do they use currently?
15:24:52 <gaston> just wondering, what does the little flag besides a username in a conversation userlist stands for ?
15:25:12 <flo-retina> gaston: on irc it means "founder" (the person who created the channel)
15:25:49 <gaston> ah, okay - so for xmpp i suppose it's 'first person connected'
15:26:06 <clokep> flo-retina: One of them uses Instantbird (I converted him a long time ago from Digsby because of privacy concerns). The rest use Konversation or Pidgin, I think.
15:27:41 <flo-retina> gaston: for XMPP I would need to look at the code to remember what it is exactly; but it's someone with more permissions than others.
15:29:10 <clokep> flo-retina, gaston: It's if they have a role of "owner".
15:29:14 <clokep> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#85
15:29:30 --> mconley has joined #instantbird
15:30:35 <gaston> i see
15:31:01 <clokep> Yeah, it's just meant to be "someone with more power than an op".
15:32:50 <mic|web> bye - see you next year!
15:32:57 <-- mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client)
15:34:27 --> Optimizer has joined #instantbird
15:38:24 <-- mconley has quit (Input/output error)
15:43:22 <-- Optimizer has quit (Ping timeout)
15:46:31 --> Optimizer has joined #instantbird
16:37:27 <-- Optimizer has quit (Ping timeout)
16:39:44 --> Optimizer has joined #instantbird
16:48:24 <clokep> Optim izer pings out a lot. :-/
16:54:15 --> meh has joined #instantbird
17:00:04 <-- DGMurdockIII has quit (Ping timeout)
17:02:00 <-- rosonline has quit (Ping timeout)
17:02:14 --> DGMurdockIII has joined #instantbird
17:16:11 * Optimizer is now known as devtools
17:16:26 * devtools is now known as Optimizer
17:33:08 --> leoj3n has joined #instantbird
17:56:44 <flo-retina> do we have a bug filed on showing the conv buddy tooltip when hovering a nick in a conversation?
17:57:26 <flo-retina> bug 1693
17:57:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1693 enh, --, ---, nobody, NEW, Show participant tooltip when hovering nick in conversation
18:02:50 <clokep> That's the buddy tooltip when hovering a nick in a PM?
18:03:07 <-- meh has quit (Ping timeout)
18:04:56 <flo-retina> clokep: that's just making the tooltip code detect the class=ib-nick attribute, and then doing the correct thing.
18:05:13 <flo-retina> clokep: unfortunately I think we currently have a separate tooltip for the nicklist/tab and for the content area :(.
18:05:51 <leoj3n> any tickets to allow collapse/hide of unwanted tweets?
18:06:40 <flo-retina> leoj3n: not that I'm aware of.
18:07:00 <leoj3n> Is it a good idea?
18:07:05 <clokep> leoj3n: What makes them unwanted? What's the point of collapsing them?
18:07:20 <leoj3n> to have more space
18:07:34 <clokep> Why do you need more space.
18:07:46 <clokep> Is it because there are too many tweets to read? The scrollbar is too small?
18:07:50 <clokep> What problem are you trying to solve?
18:07:58 * clokep enjoys talking about the problem /before/ talking about solutions. :)
18:08:16 --> mpmc has joined #instantbird
18:08:23 <flo-retina> clokep: :)
18:08:33 <-- jb has quit (Ping timeout)
18:09:09 <leoj3n> well i guess in this instance I want to expunge tweets from a user I stopped following.
18:09:21 <leoj3n> the latest ones still in my visible feed
18:09:51 <leoj3n> a bunch of garbage making it hard to identify the tweets i care about
18:10:23 <flo-retina> do you not care only about the tweets that were added more recently than your latest action on the timeline?
18:10:48 <leoj3n> yeah, a few accumulated before the action.
18:11:10 <leoj3n> but I thought it would be nice to be able to hide tweets occasionally. I can see it being useful in the future.
18:11:22 <leoj3n> mildly useful
18:11:27 <leoj3n> but still
18:17:42 --> meh has joined #instantbird
18:22:22 <-- clokep has quit (Ping timeout)
18:36:07 <instantbot> florian@instantbird.org set the Resolution field on bug 1696 to FIXED.
18:36:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1696 nor, --, 1.4, florian, RESO FIXED, rewrite Bubbles' timer handling so that timers are used only when actually needed
18:37:23 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/cf4b4ae01985 - Florian Quèze - Disable unit tests on Linux to work-around bustage while linking C++ unit tests since the Mozilla 17 update.
18:37:24 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/606ca756dbb9 - Florian Quèze - Re-enable tests on Mac now that we no longer build on PPC (backout ce19d6a4e4dc).
18:37:25 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/caec2bdbc7f5 - Florian Quèze - Bug 1696 - rewrite Bubbles' timer handling so that timers are used only when actually needed, r=clokep.
18:49:50 <instant-buildbot> build #341 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/341
19:08:04 <-- DGMurdockIII has quit (Ping timeout)
19:09:17 <-- leoj3n has quit (Ping timeout)
19:13:24 --> DGMurdockIII has joined #instantbird
19:16:10 --> leoj3n has joined #instantbird
19:29:09 <-- Optimizer has quit (Ping timeout)
19:32:33 --> Optimizer has joined #instantbird
19:38:39 --> mconley has joined #instantbird
19:40:54 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 17.0.1/20121128204232])
19:49:07 <-- leoj3n has quit (Quit: SEEYA!)
20:14:22 --> rosonline has joined #instantbird
20:14:38 <-- meh has quit (Quit: If you ever feel like dying to help the universe, just let me know.)
20:30:39 --> mikk_s has joined #instantbird
20:58:30 <-- mconley has quit (Input/output error)
20:59:51 --> meh has joined #instantbird
21:00:12 <-- rosonline has quit (Quit: http://www.mibbit.com ajax IRC Client)
21:07:37 <-- Optimizer has quit (Ping timeout)
21:09:51 --> mconley has joined #instantbird
21:11:18 <-- mpmc has quit (Connection reset by peer)
21:11:30 --> Optimizer has joined #instantbird
21:13:16 --> clokep has joined #instantbird
21:13:16 * ChanServ sets mode +o clokep 
21:16:32 <-- mikk_s has quit (Client exited)
21:22:18 <-- Optimizer has quit (Ping timeout)
21:25:33 --> Optimizer has joined #instantbird
21:51:27 <-- Optimizer has quit (Ping timeout)
21:55:06 --> Optimizer has joined #instantbird
22:03:24 <instantbot> New Instantbird (UI) bug 1862 filed by florian@instantbird.org.
22:03:25 <instantbot> florian@instantbird.org requested review from the wind for attachment 2181 on bug 1862.
22:03:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1862 tri, --, ---, florian, NEW, Cleanup Bubbles's CSS
22:03:39 <flo-retina> that review is for whoever is first to look at it. Is clokep around? ;)
22:03:52 <flo-retina> no rush on that patch though, it's just simple CSS cleanups
22:04:19 * clokep is watching a bad 80s movies.
22:05:24 <clokep> flo-retina: Is not including the div part more efficient?
22:05:29 <flo-retina> the patch is artificially large because all the variants needed to be modified, but reviewing the changes in 1 variant is enough (I made the changes to all the variants using sed's in-place feature
22:06:03 <flo-retina> clokep: the CSS engine reads from right to left
22:06:23 <flo-retina> ".bubble" is "if (node.classList.contains("bubble"))"
22:06:44 <flo-retina> "div.bubble" is "if (node.classList.contains("bubble") && node.localName == "div")"
22:07:31 <clokep> Ah, OK.
22:07:34 <flo-retina> this isn't really a significant perf improvement as the check on the tag's name is O(1), so I said "cleanup" ;)
22:08:02 <clokep> I was more concerned it was a perf hit than a perf improvement. :)
22:08:06 <flo-retina> "div.bubble p.pseudo {" was really expensive
22:08:50 <flo-retina> the descendant selector is basically a loop checking on the parentNode until the root node is reached, so whenever we can avoid it we should
22:09:51 <clokep> Yup. I knew that. :)
22:09:53 <flo-retina> you'll likely notice that I kept the "p.nick" and "p.action" selectors.
22:10:20 --> rosonline has joined #instantbird
22:10:23 <flo-retina> that's on purpose, as the nick and action classes come from %messageClasses% that are also applied to div class="bubble"
22:12:27 <clokep> Hmm....the changes seem fine to me.
22:12:36 <clokep> Does selecting the nick and the timer still work properly?
22:12:41 <clokep> (Double click on them to highlight them.)
22:12:46 <-- Optimizer has quit (Ping timeout)
22:12:59 <clokep> We fixed something about that at some point...
22:13:18 <flo-retina> the timer?
22:13:38 <clokep> Sorry, the "time" not "timer" (the one that shows on the bubble on hover).
22:13:46 <flo-retina> showing the timestamp next to the nick on hover is broken, I'm fixing that.
22:13:49 <clokep> But the selection breaks at the : in that case anyway, so it doesn't really matter.
22:16:37 --> Optimizer has joined #instantbird
22:17:14 <flo-retina> I needed ".bubble:hover > .indicator > .pseudo > .time {" for the selector (the "> .indicator" is missing in the attached patch)
22:18:35 <flo-retina> things seem to be working fine now
22:18:49 <clokep> :)
22:19:49 * flo-retina commented in the bug for that additional change
22:21:43 <flo-retina> clokep: so, does "the changes seem fine to me." means r+?
22:22:26 <instantbot> clokep@gmail.com granted review for attachment 2181 on bug 1862.
22:22:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1862 tri, --, ---, florian, NEW, Cleanup Bubbles's CSS
22:22:32 <flo-retina> thanks
22:24:28 <instantbot> florian@instantbird.org set the Resolution field on bug 1862 to FIXED.
22:24:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1862 tri, --, 1.4, florian, RESO FIXED, Cleanup Bubbles's CSS
22:24:59 <flo-retina> now I wonder if I should add another patch on top of that to get rid of all the empty text nodes
22:27:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/21f62a39bcd7 - Florian Quèze - Bug 1862 - Cleanup Bubbles's CSS, r=clokep.
22:28:06 --> Kaishi has joined #instantbird
22:32:35 --> mpmc has joined #instantbird
22:34:45 <clokep> That could be good.
22:35:12 <flo-retina> I don't know any way to measure the effect of such a change
22:35:22 <flo-retina> it won't be a significant perf win
22:35:33 <flo-retina> (as creating the nodes doesn't really show up in profiles)
22:35:58 <flo-retina> I don't know how much memory that consumes, and I suspect there's no way in about:memory to know for sure how much memory is used by 'empty text nodes'
22:36:35 <flo-retina> hmm, maybe for the 11k tweets conv the memory difference will be large enough to be more visible than the noise
22:37:03 <flo-retina> I'm also wondering if we want to do that in the theme files, or in imThemes.jsm when loading the file (btw, they are loaded with synchronous I/O :()
22:37:49 <instant-buildbot> build #342 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/342
22:37:50 --> EionRobb has joined #instantbird
22:37:57 <flo-retina> Good night
22:49:18 * clokep remembers filing bug 550.
22:49:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=550 nor, --, ---, nobody, NEW, Normalize nodes to remove empty/combine adjacent text nodes
22:51:00 <-- Optimizer has quit (Ping timeout)
22:55:02 --> Optimizer has joined #instantbird
23:02:06 <-- clokep has quit (Ping timeout)
23:14:27 <-- Optimizer has quit (Ping timeout)
23:18:03 --> Optimizer has joined #instantbird
23:42:53 <-- mpmc has quit (Connection reset by peer)