#instantbird log on 11 18 2012

All times are UTC.

00:05:26 --> rosonlin1 has joined #instantbird
00:05:27 <-- rosonline has quit (Connection reset by peer)
00:05:34 <-- rosonlin1 has quit (Quit: rosonlin1)
00:05:43 --> rosonline has joined #instantbird
00:17:38 <instantbot> New Instantbird (UI) bug 1805 filed by florian@instantbird.org.
00:17:39 <instantbot> florian@instantbird.org requested review from aleth@instantbird.o rg for attachment 2096 on bug 1805.
00:17:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1805 tri, --, ---, florian, NEW, WARNING: no (useful) preprocessor directives found
00:46:33 --> jeffgman has joined #instantbird
00:48:00 <-- jeffgman has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
00:51:58 <instantbot> New Instantbird (UI) bug 1806 filed by florian@instantbird.org.
00:52:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1806 nor, --, ---, nobody, NEW, Leaking the hidden window when playing a sound
00:52:11 --> jeffgman has joined #instantbird
01:01:23 <flo-retina> Good night!
01:07:42 <-- mconley has quit (Input/output error)
01:35:54 <-- jeffgman has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
01:46:24 <-- meh has quit (Quit: The point is: don't lose your dinosaur.)
01:58:26 <-- rosonline has quit (Quit: Experimentem Instantbird 1.3 -- http://www.instantbird.com)
02:53:55 --> ivan has joined #instantbird
03:02:38 --> Optimizer has joined #instantbird
03:36:36 <-- Optimizer has quit (Ping timeout)
04:33:20 --> Kaishi has joined #instantbird
05:12:49 --> clokep has joined #instantbird
05:12:49 * ChanServ sets mode +o clokep 
05:20:23 <instantbot> clokep@gmail.com granted review for attachment 2094 on bug 1803.
05:20:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1803 nor, --, ---, nobody, NEW, Shutdown leak if there was an active IRC channel
05:28:30 <-- clokep has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
06:52:16 --> Optimizer has joined #instantbird
07:36:17 --> FeuerFliege has joined #instantbird
07:38:00 --> jb has joined #instantbird
08:14:18 <-- Optimizer has quit (Ping timeout)
08:34:04 <-- jb has quit (Ping timeout)
08:35:07 --> jb has joined #instantbird
08:49:22 --> deltafalcon has joined #instantbird
09:13:51 <-- Even has quit (Input/output error)
09:17:03 --> Even has joined #instantbird
09:17:04 * ChanServ sets mode +o Even 
09:27:37 --> Optimizer has joined #instantbird
09:29:37 <-- Optimizer has quit (Ping timeout)
09:51:50 --> Optimizer has joined #instantbird
10:08:33 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2097 on bug 1803.
10:08:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1803 nor, --, ---, florian, NEW, Shutdown leak if there was an active IRC channel
10:09:41 <-- Optimizer has quit (Ping timeout)
10:17:51 <-- jb has quit (Ping timeout)
10:18:22 --> jb has joined #instantbird
10:21:01 <-- jb has quit (Ping timeout)
10:21:27 --> jb has joined #instantbird
10:42:28 --> aleth has joined #instantbird
10:42:29 * ChanServ sets mode +h aleth 
10:42:56 <-- jb has quit (Ping timeout)
10:59:56 --> jb has joined #instantbird
11:00:09 --> jb1 has joined #instantbird
11:00:09 <-- jb has quit (Connection reset by peer)
11:02:42 <aleth> flo: Great job on the leaks! I doubt we would ever have figured that IRC one out without the cycle collector tool. Good to know that exists
11:07:24 <flo> aleth: thanks :)
11:07:58 <flo> it's sad that the cycle collector dump is so difficult to use :-/
11:08:25 <aleth> Is it a standalone python program you run on a more general dump?
11:08:36 <flo> and I don't really understand it, at this point I'm more just guessing what I should request, and taking the output as hints
11:09:10 <flo> aleth: you have to change a line in a cycle collector .cpp file, rebuild, then each time the cycle collector runs, it dumps a file in a temp directory.
11:10:06 <flo> aleth: so to extract information, you've got to guess which file matches the process you are interested in, then find the most recent one (the last cycle collection that happened just before finishing shutdown, when everything should already be released)
11:10:29 <flo> aleth: and then there's python tool to get a list of edges for some objects that you request more information about
11:10:56 <aleth> I noticed you had to specify XPCWrappedNative by hand
11:11:05 <flo> usually nsGlobalWindow is interesting (when a whole window as been leaked), for the IRC leak, XPCWrappedNative gave interesting results
11:11:50 <flo> it's a bit of a hit or miss; I tried a few other classes that didn't cause useful information to be printed
11:16:41 <aleth> Are there so many cycles (due to the way JS works internally) that it can't just list them all?
11:17:46 <-- jb1 has quit (Ping timeout)
11:28:45 <flo> aleth: if there's a cycle, you need to know where to start to print something.
11:29:49 <flo> and usually most things are kept alive by the fact that a window is still alive, so a developper will usually want to know what keeps alive that window, and not care about the rest of the mess
11:31:38 <flo> I'm sure it would be possible to make the tools more userfriendly though :). If someone with the required skills cared...
11:32:05 <aleth> Right, there would be a huge amount of duplication, and you'd still have to filter it anyway. That makes sense.
11:33:04 <aleth> Ideally you'd display it graphically I guess, there are python libraries for that kind of graph. But yeah, someone would have to do it...
11:38:24 <-- aleth has quit (Quit: Au revoir)
11:38:41 --> aleth1 has joined #instantbird
11:38:41 * ChanServ sets mode +h aleth1 
11:38:52 <flo> aleth: the tool I would really like to have is one that would let me know what objets are in a JS compartment shown by about:memory as being rather large.
11:40:23 <aleth1> :)
11:45:44 * aleth1 is now known as aleth2
11:46:29 --> jb has joined #instantbird
11:46:59 <flo> for example, what in imConversations.js is currently taking 4MB? What is taking almost 3MB in jsProtoHelper? 1.7MB in twitter.js, 1.5 in xmpp-xml.jsm (are we keeping alive some stanza for longer than they should?), 1.5 in xmpp.jsm, 1.2 in irc.js, 1.1 in imContacts.js
11:48:05 <flo> about:memory gives us the relative memory consumptions of various JS compartments, but that data isn't really actionable (unless some compartement is taking 100 times what we expect it should...)
11:49:35 <-- jb has quit (Ping timeout)
11:50:25 <aleth2> Judging by their blogposts, the memshrink team also seems to be adding memory reporters case by case
11:50:44 <flo> more memory reporters wouldn't help for that
11:51:03 <flo> adding memory reporters will help for the "35.18 MB (23.90%) ── heap-unclassified" part
11:52:06 <aleth2> Wouldn't something have to report the properties of the object and how much memory they are taking?
11:52:39 <aleth2> I guess my assumption was that if there was a general way of doing this automatically they would have done it. Maybe that's wrong...
11:54:29 <flo> it's possible the right tools haven't been built just because we have different needs
11:55:07 <flo> I suspect the memshrink team's most important need is to know which part of the application to blame for excessive memory usage, so that they can reach the right developers to tell them to fix their crap
11:55:13 <aleth2> Could be.
11:55:21 <flo> (I'm over simplifying a bit of course ;))
11:55:47 <aleth2> For the add-on issues I'm sure that's a large part of it ;)
11:55:55 <flo> what I would need when looking at the memory usage of my own code is quite different: I would need to know the allocation place of each object
11:55:59 <aleth2> (and probably not just the add-ons)
11:56:03 <aleth2> I wonder if talking to them would give some good ideas
11:56:33 <flo> probably that we should feel free to contribute better tools ;)
11:56:42 <flo> although I think they are very receptive to feedback
11:57:21 <flo> something I would really like would be to reuse the infrastructure of the gecko built-in profiler, but to use it to generate stacks of object creations
11:58:05 <flo> (as opposed to stack of CPU sucking)
12:00:19 <flo> btw, I wonder if we should file a bug against the cycle collector for that IRC leak/cycle that we had to break ourselves
12:00:19 <aleth2> That's a neat idea.
12:01:24 <aleth2> Somewhat unrelated, but I'd also like to play with the JS debugger a bit, just to find out what that can display
12:02:43 <flo> ah, that would be nice too! :)
12:03:19 <flo> and I definitely want to play with the gecko profiler in Instantbird!
12:04:39 <flo> yesterday I was wondering if the "release peak" at the end of http://ftp.instantbird.com/instantbird/stats/last2years.php is caused by more people, or just by the fact that we turned off nightlies, so nightly users do more update pings (they ping everyday, as opposed to pinging 24hours after the latest update)
12:07:56 <aleth2> I was thinking that releasing just before the weekend (usually a low) will give some unexpected results
12:08:23 <aleth2> Smearing out any peak...
12:08:36 --> Optimizer has joined #instantbird
12:08:52 <aleth2> So it could be that the peak is just due to those pings...
12:13:54 <-- Optimizer has quit (Ping timeout)
12:13:56 <flo> it's probably time to re-enable nightlies and enable auto-updates between 1.2 and 1.3 anyway
12:14:56 <aleth2> Especially since there are some things to land ;)
12:20:30 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2098 on bug 1766.
12:20:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, ---, aleth, ASSI, Automatically authenticate when changing the nick to the account nickname
12:20:37 * aleth2 is now known as aleth
12:21:03 <-- aleth has quit (Quit: Au revoir)
12:21:05 --> aleth has joined #instantbird
12:21:06 * ChanServ sets mode +h aleth 
12:21:29 <aleth> ^^ that fix would have been useful right there ;)
12:44:29 <instantbot> aleth@instantbird.org denied review for attachment 2095 on bug 1804.
12:44:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1804 nor, --, ---, nobody, NEW, JS error at shutdown when exiting with the Command+Q shortcut in a conversation window
12:50:53 <instantbot> aleth@instantbird.org granted review for attachment 2096 on bug 1805.
12:50:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1805 tri, --, ---, florian, NEW, WARNING: no (useful) preprocessor directives found
12:55:51 --> meh has joined #instantbird
13:07:08 --> clokep has joined #instantbird
13:07:08 * ChanServ sets mode +o clokep 
13:17:03 <instantbot> aleth@instantbird.org set the Resolution field on bug 1492 to FIXED.
13:17:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1492 min, --, 1.3, aleth, RESO FIXED, Rename purpleConversation -> prplConversation where appropriate
13:44:00 <flo> aleth: do you mean getting rid of the http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#93 line?
13:44:11 <flo> the patch adds a null check in _forgetConv
13:45:13 <aleth> No, I mean moving the if ("buddies" in this) outside the if (conv) clause, so it gets executed even if the conv has (after this patch) already been deleted
13:46:41 <aleth> Oh, sorry
13:46:48 <aleth> Yes I guess that would do the trick.
13:49:22 <aleth> r+ with that change.
13:50:18 <flo> ok
13:51:18 <flo> this is how about:memory looks for me right now: http://pastebin.mozilla.org/1946841
13:51:38 <flo> I see there that xmpp.jsm is wasteful and/or leaky.
13:52:11 <flo> and console.xul keeps references to lots of DOM nodes that have been removed from the DOM
13:53:53 <-- clokep has quit (Ping timeout)
13:54:18 --> clokep has joined #instantbird
13:54:18 * ChanServ sets mode +o clokep 
14:01:53 <instantbot> clokep@gmail.com granted review for attachment 2097 on bug 1803.
14:01:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1803 nor, --, ---, florian, NEW, Shutdown leak if there was an active IRC channel
14:02:48 <flo> and now it's down to http://pastebin.mozilla.org/1946843
14:03:44 <aleth> I've been asked whether we can connect to "whatsapp", has anyone ever heard of that?
14:04:07 <flo> never heard of that
14:04:09 <aleth> It's a mobile IM client, but I don't know what it uses internally
14:05:45 <aleth> http://www.whatsapp.com/
14:06:01 <clokep> aleth: What are you trying to figure out?
14:07:26 <-- deltafalcon has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
14:11:13 <flo> clokep: he's probably trying to figure out if it's using XMPP underneaf ;)
14:11:26 <flo> aleth: doesn't seem documented anywhere on the website
14:11:42 <flo> aleth: best bet may be to install the android app on an android emulator, and to wireshark that...
14:11:56 <flo> if it's all encrypted you won't see anything
14:15:46 <flo> aleth: I'm not sure there's "a right person" to review bug 1805 ;). It's mostly trivial, so it's kind of "whoever looks at it first" ;)
14:15:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1805 tri, --, ---, florian, NEW, WARNING: no (useful) preprocessor directives found
14:17:01 --> rosonline has joined #instantbird
14:24:08 <clokep> The patch in there looks fine anyway, I checked it over. :)
14:24:41 <flo> I was tired of seeing all these warnings each time I restarted my debug build ;)
14:24:54 <flo> I restarted it a lot to track down these shutdown leaks
14:25:20 <flo> the next step on the leak side is to create a reduced testcase for the sound leak, and to file a BMO bug
14:25:42 <clokep> flo: Do we still need to report the actual error for bug 1800.
14:25:43 <flo> or maybe we should check if the bug exists with the current mozilla-central trunk before bothering with a reduced test case
14:25:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, ---, nobody, NEW, Exception on opening "show all protocols" page
14:26:14 <flo> clokep: when looking at the code, I think yes. When looking at the useless error message pasted in the bug, I think no.
14:26:43 <clokep> flo: That was kind of my thought.
14:26:52 <flo> can proto.init fail with a less stupid error message?
14:26:58 <flo> maybe if the prpl is implemented in JS?
14:27:10 <clokep> I think if the prpl is JS, yes.
14:27:40 <flo> http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#646
14:27:54 <clokep> Oh ahah.
14:28:27 <flo> each actual prpl implementation can override it I guess
14:30:03 <instantbot> clokep@gmail.com denied review for attachment 2093 on bug 1800.
14:30:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, ---, nobody, NEW, Exception on opening "show all protocols" page
14:35:01 <flo> http://crash-stats.instantbird.com/query/query?version=Instantbird%3A1.3&date=&range_value=1&range_unit=weeks&query_search=signature&query_type=exact&query=&build_id=&process_type=all&do_query=1
14:36:58 <flo> nothing really actionable :(
14:37:36 <flo> 18 crashes for 2216 downloads, is that a good rate?
14:47:43 <clokep> That's < 1%.
14:47:46 <clokep> Seems reasonabel.
14:58:45 <aleth> clokep: Yes, I was wondering if it was just XMPP
15:03:01 <aleth> clokep: Basically that patch in bug 1800 was just what I used to figure out what was causing the exception. Is it feasible for the bonjour prpl to throw some more useful error message?
15:03:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, ---, nobody, NEW, Exception on opening "show all protocols" page
15:04:23 <clokep> aleth: It is feasible for /other/ prpls to throw a more useful error message.
15:04:41 <aleth> OK :D
15:06:33 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2099 on bug 1800.
15:06:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, ---, aleth, ASSI, Exception on opening "show all protocols" page
15:11:57 <instantbot> clokep@gmail.com granted review for attachment 2099 on bug 1800.
15:11:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, ---, aleth, ASSI, Exception on opening "show all protocols" page
15:15:58 <aleth> Whatsapp uses some customized XMPP, according to https://github.com/venomous0x/WhatsAPI
15:18:55 <aleth> https://en.wikipedia.org/wiki/WhatsApp
15:18:58 <aleth> Just for the record.
15:26:58 <clokep> aleth: Why are you trying to figure this out? Did I miss part of a conversation? :-S
15:27:12 <aleth> clokep: Someone asked me if instantbird could send messages to it
15:27:21 <clokep> Where?
15:27:28 <aleth> offline ;)
15:28:02 <clokep> Ah, I see. :)
15:28:06 <aleth> And I'd never heard of it before, though it seems from Wikipedia it's quite popular because it requires no account creation etc.
15:28:26 <aleth> Of course there are drawbacks to that approach, but it seems to have given them growth ;)
15:28:31 <instantbot> New Instantbird (UI) bug 1807 filed by rosonline@r7.com.
15:28:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1807 tri, --, ---, nobody, UNCO, An option of VKontakte (ВКонтакте) icon
15:28:48 <aleth> Turns out it's just XMPP underneath, but the message format is nonstandard.
15:31:40 <clokep> Interesting...
15:31:46 <clokep> Is it still XMPP then? :P
15:33:06 <aleth> Not quite I guess :(
15:35:56 <clokep> Seems like it could be done, but you'd need to create a new prpl.
15:36:51 <aleth> Yup.
15:37:51 <aleth> Even if we did that, I don't think we'd want to try to be a full client for it (pretending to be a phone)
15:38:31 <aleth> Though I'm not sure if we could receive messages without it
15:45:40 <clokep> Of course you could support a subset of features.
15:46:43 <clokep> Guess it depends how much you like the person who asked you offline. ;)
16:22:54 --> Optimizer has joined #instantbird
16:49:38 <-- rosonline has quit (Ping timeout)
17:04:35 --> mconley has joined #instantbird
17:18:34 <-- mconley has quit (Ping timeout)
17:21:10 --> jb has joined #instantbird
17:30:44 --> mconley has joined #instantbird
17:49:20 <-- dew has quit (Quit: )
17:49:28 --> dewmugg has joined #instantbird
17:53:31 <-- dewmugg has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
17:56:19 --> dewmugg has joined #instantbird
17:57:00 <dewmugg> hooray 1.3 :)
18:03:22 <aleth> clokep: SASL clearly the key feature for some ;) https://www.linux-magazin.de/NEWS/Instantbird-1.3-unterstuetzt-Freenode-Anmeldung
18:04:49 <-- dewmugg has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
18:05:36 <clokep> :) Nice.
18:07:55 --> dew has joined #instantbird
18:08:49 <dew> wow I didn't know that the nickserv idenfitying was so easy in instantbird :)
18:09:52 <aleth> good to hear it works well for you :)
18:12:39 <-- FeuerFliege has quit (Connection reset by peer)
18:15:03 --> jb1 has joined #instantbird
18:15:09 <-- jb has quit (Ping timeout)
18:15:10 <dew> aleth: do you work for mozilla?
18:15:15 <aleth> dew: no
18:16:03 <aleth> Lots of people contribute who aren't employees (and Instantbird actually isn't a mozilla project anyway)
18:23:31 * flo wonders if working for Mozilla change anything in dew's mind to the contributions made to Instantbird. :)
18:30:00 <dew> no I was just wondering
18:30:09 <dew> I was thinking about applying for a job
18:33:47 <flo-retina> do you know which job you want to apply for yet? :)
18:34:58 <flo-retina> aleth: should I use your @ib.org email for commits now?
18:36:29 * flo-retina assumes yes.
18:37:08 <aleth> flo-retina: yes, I changed it everywhere, it's much simpler to remember.
18:37:16 <flo-retina> it is, indeed!
18:37:25 <aleth> "everywhere" = BIO and BMO ;)
18:37:41 <flo-retina> that new email is faster to type than copy paste (for me)
18:38:41 <flo-retina> aleth: the final string was "Could not use the specified nickname. Your nick remains %S.", right?
18:39:07 <dew> I was looking at software engineer, platform
18:39:17 <aleth> Yes, but lets check with the reviewer -> clokep ;)
18:39:36 <clokep> Updating libqq still doesn't connect. :-S
18:39:54 <flo-retina> clokep: probably still need that captcha crap...
18:39:59 <flo-retina> clokep: are you ok with that string?
18:40:04 <clokep> flo-retina: That sounds good.
18:40:18 <clokep> flo-retina: Maybe, it still gives an error about versions.
18:44:26 <flo-retina> http://pastebin.instantbird.com/103468 did I forget anything?
18:44:45 --> Mnyromyr has joined #instantbird
18:45:28 <clokep> flo-retina: http://pastebin.instantbird.com/103469 was the changes I had made to fake, but I didn't actually get it working. :(
18:46:26 * clokep will file a bug
18:48:09 <flo-retina> clokep: "19:46:27 * clokep will file a bug" exactly what I was going to suggest ;)
18:48:58 <aleth> clokep: this? https://code.google.com/p/libqq-pidgin/issues/detail?id=16#c104
18:49:11 <clokep> aleth: Yes.
18:50:10 <flo-retina> nightlies are reenabled
18:50:39 <flo-retina> bug reports in Chineese :(
18:51:44 <aleth> Last comment translates as "Landlord continue to develop" :P
18:53:20 * flo-retina wonders how one is supposed to enable updates from 1.2 to 1.3
18:53:25 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/2bc4c63b7926 - aleth - Bug 1800 - Improve the exception on opening the "show all protocols" page when a protocol plugin failed to initialize, r=clokep.
18:53:26 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/98fd6cfae591 - Florian Quèze - Bug 1804 - JS error at shutdown when exiting with the Command+Q shortcut in a conversation window, r=aleth.
18:53:27 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/735829d0bdc9 - aleth - Bug 1751 - No feedback when the /nick command fails, r=clokep.
18:53:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/39043e8937a5 - Florian Quèze - Bug 1803 - Shutdown leak if there was an active IRC channel, r=clokep.
18:53:29 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/5286c0725a1f - Florian Quèze - Bug 1805 - WARNING: no (useful) preprocessor directives found, r=aleth.
18:53:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/7ee99b705800 - aleth - Bug 1786 - Don't log password during SASL auth - follow-up to improve the logged string, r=clokep.
18:53:55 <instantbot> New Instantbird (UI) bug 1808 filed by clokep@gmail.com.
18:54:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1808 min, --, ---, nobody, NEW, Update fake
18:54:46 <instantbot> clokep@gmail.com set the Resolution field on bug 1800 to FIXED.
18:54:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1800 nor, --, 1.4, aleth, RESO FIXED, Exception on opening "show all protocols" page
18:56:37 <instantbot> clokep@gmail.com set the Resolution field on bug 1805 to FIXED.
18:56:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1805 tri, --, 1.4, florian, RESO FIXED, WARNING: no (useful) preprocessor directives found
18:57:28 <instantbot> clokep@gmail.com set the Resolution field on bug 1803 to FIXED.
18:57:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1803 nor, --, 1.4, florian, RESO FIXED, Shutdown leak if there was an active IRC channel
18:58:09 <instantbot> clokep@gmail.com set the Resolution field on bug 1751 to FIXED.
18:58:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1751 min, --, 1.4, aleth, RESO FIXED, No feedback when the /nick command fails
18:58:37 <clokep> flo, aleth: Bug 1804 has an r- but is checked in? :-S
18:58:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1804 nor, --, ---, nobody, NEW, JS error at shutdown when exiting with the Command+Q shortcut in a conversation window
19:00:24 <flo-retina> clokep: http://log.bezut.info/instantbird/today#m131
19:00:46 <clokep> flo-retina: Be nice to have that in the bug. ;)
19:01:15 <flo-retina> I'm really looking forward to stop using that update system
19:01:23 <instantbot> clokep@gmail.com set the Resolution field on bug 1804 to FIXED.
19:01:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1804 nor, --, 1.4, florian, RESO FIXED, JS error at shutdown when exiting with the Command+Q shortcut in a conversation window
19:05:37 <aleth> My error console is full of "Warning: Error in parsing value for 'margin-top'.  Declaration dropped." :-/
19:06:06 * clokep has a bunch of random patches in his queue without bugs. :(
19:06:33 <clokep> Like ... http://pastebin.instantbird.com/103472
19:08:46 <flo-retina> "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near <whole query>" is really not helpful :(
19:09:11 <flo-retina> aleth: any example of unparsable margin-top value?
19:09:31 --> qlum has joined #instantbird
19:10:00 <aleth> The location is unhelpful (instantbird.xul, line 0)
19:13:04 <flo-retina> :(
19:20:01 --> rosonline has joined #instantbird
19:24:43 <instantbot> New Core - IRC bug 1809 filed by clokep@gmail.com.
19:24:44 <instantbot> clokep@gmail.com requested review from aleth@instantbird.o rg for attachment 2104 on bug 1809.
19:24:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1809 tri, --, ---, clokep, ASSI, Minor cleanup of IRC usernames
19:25:45 <clokep> aleth: ping
19:27:08 <clokep> aleth: Never mind actually.
19:27:13 <clokep> I was going to ask about bug 1766.
19:27:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, ---, aleth, ASSI, Automatically authenticate when changing the nick to the account nickname
19:27:18 <clokep> But I can't think of a better way to do that either.
19:27:57 <aleth> clokep: Right, it's not super pretty, but I think it's the safest route.
19:29:37 <instantbot> aleth@instantbird.org granted review for attachment 2104 on bug 1809.
19:29:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1809 tri, --, ---, clokep, ASSI, Minor cleanup of IRC usernames
19:34:32 <instantbot> clokep@gmail.com denied review for attachment 2098 on bug 1766.
19:34:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, ---, aleth, ASSI, Automatically authenticate when changing the nick to the account nickname
19:34:35 * clokep was originally going to r+ that...
19:35:17 <aleth> Ahaha :D
19:35:54 <aleth> The 'delete' was originally intentionally absent so I could check if ("isAuthenticated" in this) later, but then I decided against that kind of messiness.
19:37:25 <aleth> And then I forgot to change it...
19:38:01 <clokep> Yes, that seems confusing. :)
19:38:46 <instantbot> clokep@gmail.com granted feedback for attachment 2092 on bug 1511.
19:38:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
19:40:14 <flo-retina> auto-updates to 1.3 are enabled!
19:40:45 <flo-retina> took me 40 minutes :( (!)
19:41:07 <instantbot> aleth@instantbird.org requested review from clokep@gmail.com for attachment 2105 on bug 1766.
19:41:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, ---, aleth, ASSI, Automatically authenticate when changing the nick to the account nickname
19:41:21 <flo-retina> at this point I would say that documenting the right SQL query on the release_process wiki page would be a good idea to save time next time
19:41:26 <flo-retina> but I hope there will be no next time
19:41:33 <flo-retina> as I intend to rewrite the update system soon
19:41:52 <aleth> As long as you didn't say the same thing last time ;)
19:42:50 <flo-retina> nah, I used to think that it would be useful to get Even to rewrite it a third time
19:42:56 <flo-retina> but now I think I'll just do it
19:46:26 <clokep> flo-retina: I'd say copying the SQL somewhere makes sense. :)
19:47:25 <flo-retina> clokep: it would mean I have to clean it up
19:47:33 <clokep> :(
19:47:38 <flo-retina> I did it in 3 different queries; there could be only one
19:47:43 <clokep> You could just save it /somewhere/ for now.
19:48:14 <flo-retina> and this was "easy" today because I "released" all the release candidates that were registered in the system, as we made only one set of rcs :)
19:49:51 <flo-retina> This is more or less what I used:
19:49:52 <flo-retina> UPDATE fulls SET ignore = NULL WHERE fulls.version = '1.3';
19:49:52 <flo-retina> UPDATE channels AS c JOIN fulls AS f on c.full_id = f.full_id SET c.ignore = NULL WHERE f.version = '1.3';
19:49:52 <flo-retina> UPDATE channels AS c JOIN fulls AS f on c.full_id = f.full_id SET c.force = 0 WHERE f.version = '1.3';
19:54:58 <clokep> Seems complicated.
19:57:24 <instantbot> clokep@gmail.com granted review for attachment 2105 on bug 1766.
19:57:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1766 nor, --, ---, aleth, ASSI, Automatically authenticate when changing the nick to the account nickname
20:03:17 <aleth> more things to checkin :)
20:05:29 * clokep looks at bug 1419 again...
20:05:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1419 nor, --, ---, aleth, ASSI, Handle the user's user mode
20:28:26 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
20:56:26 <-- rosonline has quit (Quit: Experimentem Instantbird 1.3 -- http://www.instantbird.com)
21:05:11 --> rosonline has joined #instantbird
21:32:33 <flo-retina> let's see if I can update comm-central's chat quickly ^^
21:33:42 <flo-retina> 1.* -> 1.3 updates are activated for real this time (I had forgotten to clear the cache)
21:34:12 <clokep> :)
21:36:22 <flo-retina> we have 40 chat/ changesets since the latest sync!
21:37:46 <flo-retina> the diffstat is: 48 files changed, 450 insertions(+), 221 deletions(-)
21:38:12 <clokep> That's a lot of changes...
21:38:21 <clokep> I hope there's no conflicts...
21:38:39 --> mikk_s has joined #instantbird
21:40:06 <flo-retina> I wonder if Tb is interested in shipping the 2 new XMPP-based prpls
21:40:24 <-- mconley has quit (Input/output error)
21:40:42 <flo-retina> if it is, that requires changes to package-manifest (ie out of our chat/ module) and I don't think I'm allowed to do that without a review from a Tb peer
21:42:10 <clokep> Mention it in the bug and ask Standard 8?
21:44:41 <flo-retina> I would like to check that in tonight
21:44:51 <flo-retina> so I may file a follow-up
21:45:05 <flo-retina> and I'm not sure if it's Standard8 or bwinton that should decide (is it a code issue or an ux decision?)
21:45:30 --> mconley has joined #instantbird
21:45:48 <clokep> Just set it to mconley and make him decide? :P
21:45:56 <clokep> (I'm teasing, he just seems to be everywhere...)
21:46:22 <mconley> clokep: :D
21:48:04 <-- mconley has quit (Input/output error)
21:48:58 * flo-retina wonders what's causing mconley's I/O errors, and if we could get him to us a real IRC client :-P
21:49:23 <clokep> Is he still using xchat or something?
21:50:20 <flo-retina> I don't know, but he logged in neither as Thunderbir or Instantbir, so... ;)
21:54:25 <flo-retina> clokep: the list of changesets that aren't in c-c is http://pastebin.instantbird.com/103503
21:55:51 <clokep> flo-retina: Some good stuff in there. :)
22:07:04 <-- mikk_s has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
22:11:12 <-- jb1 has quit (Ping timeout)
22:12:26 <flo-retina> clokep: https://bugzilla.mozilla.org/show_bug.cgi?id=812921 if you want to check what I'm doing
22:14:57 <clokep> flo-retina: Don't worry, I've been following. ;)
22:15:29 <flo-retina> I'm not worried. But I'm currently building an up to date trunk build with that patch included
22:18:30 --> jb has joined #instantbird
22:21:30 --> FireFly_TB has joined #instantbird
22:21:46 <-- jb has quit (Ping timeout)
22:31:26 <clokep> flo-retina: Did you take care of what aleth linked to also?
22:31:33 <flo-retina> yes
22:31:52 <clokep> OK. If you need a review....
22:33:34 <clokep> Can anyone hit lists.mozilla.org? It's timing out for me.
22:33:47 <aleth> me too
22:34:10 --> jb has joined #instantbird
22:34:13 <-- meh has quit (Quit: The point is: don't lose your dinosaur.)
22:34:54 <-- jb has quit (Excess Flood)
22:34:58 --> jb has joined #instantbird
22:35:13 <clokep> aleth: Thank you. :) Pings work. :(
22:38:01 <-- rosonline has quit (Quit: http://www.mibbit.com ajax IRC Client)
22:40:14 <-- FireFly_TB has quit (Quit: FireFly_TB)
22:41:03 --> FireFly_TB has joined #instantbird
22:48:18 --> rosonline has joined #instantbird
22:58:42 <-- jb has quit (Ping timeout)
22:59:13 <flo-retina> my local build works, I think I'm ready to push that
23:03:10 <-- rosonline has quit (Quit: http://www.mibbit.com ajax IRC Client)
23:04:19 <-- FireFly_TB has quit (Ping timeout)
23:10:04 <-- flo-retina has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
23:10:19 <-- flo has quit (Quit: Instantbird 1.3 -- http://www.instantbird.com)
23:14:48 <aleth> Needn't really have filed that BMO bug if I had known you were going to merge today ;)
23:15:43 <-- aleth has quit (Input/output error)
23:27:00 --> mconley has joined #instantbird