All times are UTC.
00:17:22 <flo-retina1> I give up (for today at least) on that nss crash 00:17:23 <flo-retina1> good night 00:38:59 <instantbot> clokep@gmail.com set the Resolution field on bug 1775 to FIXED. 00:39:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1775 min, --, 1.3, benediktp, RESO FIXED, Background of element containing the nickname not snuggling up to main bubble border 00:41:21 <instantbot> clokep@gmail.com set the Resolution field on bug 1777 to FIXED. 00:41:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1777 nor, --, 1.3, florian, RESO FIXED, Wait more than 1s before showing NickServ's messages 00:42:59 <-- wnayes has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 00:43:13 <instantbot> clokep@gmail.com set the Resolution field on bug 1764 to FIXED. 00:43:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1764 nor, --, 1.3, clokep, RESO FIXED, Drop ForwardProtocolPrototype 00:44:23 <instantbot> clokep@gmail.com set the Resolution field on bug 1767 to FIXED. 00:44:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1767 maj, --, 1.3, clokep, RESO FIXED, New nightly can't auth with ZNC server 00:50:27 <instant-buildbot> build #346 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/346 01:31:17 <-- Optimizer has quit (Ping timeout) 01:34:34 --> Optimizer has joined #instantbird 01:37:00 <-- Optimizer has quit (Ping timeout) 01:40:31 --> Optimizer has joined #instantbird 02:01:58 <instant-buildbot> build #333 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/333 02:18:00 <-- Mook_as has quit (Quit: Mook_as) 02:51:05 --> micahg has joined #instantbird 02:54:02 <-- Optimizer has quit (Ping timeout) 02:57:33 --> Optimizer has joined #instantbird 02:59:22 <instant-buildbot> build #314 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/314 03:02:30 <-- micahg has quit (Ping timeout) 03:04:23 <-- mconley has quit (Input/output error) 03:35:26 <instant-buildbot> build #680 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/680 03:40:35 <-- Optimizer has quit (Ping timeout) 03:41:12 --> micahg has joined #instantbird 03:43:56 <-- micahg has quit (Ping timeout) 03:44:03 --> Optimizer has joined #instantbird 03:44:45 --> micahg has joined #instantbird 03:47:22 <-- micahg has quit (Ping timeout) 04:11:17 --> jb has joined #instantbird 04:14:56 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com) 04:23:48 <-- jb has quit (Ping timeout) 04:42:21 --> Mook has joined #instantbird 04:45:06 <-- flo-retina1 has quit (Ping timeout) 04:48:27 --> flo-retina has joined #instantbird 04:48:27 * ChanServ sets mode +qo flo-retina flo-retina 05:12:07 <-- Optimizer has quit (Ping timeout) 05:13:07 --> Optimizer has joined #instantbird 05:15:57 <-- Optimizer has quit (Ping timeout) 05:17:01 <instant-buildbot> build #768 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/768 05:21:30 --> Optimizer has joined #instantbird 05:23:56 <-- EionRobb has quit (Quit: Leaving.) 05:24:25 <-- Optimizer has quit (Ping timeout) 05:27:20 --> Optimizer has joined #instantbird 05:30:17 <-- Optimizer has quit (Ping timeout) 05:34:46 --> Optimizer has joined #instantbird 06:35:31 <-- Optimizer has quit (Ping timeout) 07:18:52 <-- Mook has quit (Quit: Mook) 08:16:26 <instant-buildbot> build #681 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/681 08:23:19 --> Optimizer has joined #instantbird 09:11:06 --> Mic has joined #instantbird 09:11:06 * ChanServ sets mode +h Mic 09:11:52 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 09:12:02 --> Mic has joined #instantbird 09:12:02 * ChanServ sets mode +h Mic 09:19:25 <Mic> Hello 09:30:58 <-- flo-retina has quit (Ping timeout) 09:31:09 --> flo-retina has joined #instantbird 09:31:09 * ChanServ sets mode +qo flo-retina flo-retina 09:46:50 <-- Optimizer has quit (Ping timeout) 09:50:07 --> Optimizer has joined #instantbird 10:16:20 <-- Mic has quit (Connection reset by peer) 10:18:59 --> Mic has joined #instantbird 10:18:59 * ChanServ sets mode +h Mic 10:39:15 --> aleth has joined #instantbird 10:39:15 * ChanServ sets mode +h aleth 10:43:49 <-- flo-retina has quit (Ping timeout) 10:46:38 <-- aleth has quit (Quit: Au revoir) 10:46:50 --> aleth has joined #instantbird 10:46:50 * ChanServ sets mode +h aleth 10:56:14 --> meh has joined #instantbird 11:03:43 --> flo-retina has joined #instantbird 11:03:44 * ChanServ sets mode +qo flo-retina flo-retina 11:05:42 <-- flo-retina has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 11:05:45 --> flo-retina has joined #instantbird 11:05:45 * ChanServ sets mode +qo flo-retina flo-retina 11:14:44 <flo-retina> I'm on an up to date nightly, and freenode's nickserv still talked to me :( 11:16:02 <aleth> Nickserv took more than 10s, or do we have another issue? :( 11:16:21 <flo-retina> 12:05:58 - NickServ: This nickname is registered. Please choose a different nickname, or identify via /msg NickServ identify <password>. 11:16:22 <flo-retina> 12:05:58 - NickServ: You are now identified for fqueze_. 11:16:26 <flo-retina> Seems less than a second to me 11:16:49 <aleth> Strange. 11:17:00 <flo-retina> ah, I know the problem 11:17:09 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircServices.jsm#143 11:17:29 <flo-retina> we expect nickserv to reply with the current nick 11:17:38 <flo-retina> but it doesn't, it uses the first nick of the group 11:17:52 <aleth> Aha! :) 11:17:54 <flo-retina> my main freenode nick is fqueze_, and I grouped fqueze into it. I'm currently connected as fqueze. 11:18:38 <flo-retina> bah, I'll probably see that message until clokep is back :-/. 11:18:46 <aleth> I don't think we explicitly support grouped nicks in any way atm 11:19:25 <flo-retina> wouldn't the fix be to just check that NickServ's sentence starts with "You are now identified for \x02" ? 11:19:36 <aleth> I was just going to suggest that :) 11:20:00 <flo-retina> if you are volunteering for writing the patch and it's trivial, I can r+ it ;) 11:20:03 <aleth> Since we can hardly identify for two nicks at once. 11:20:06 <flo-retina> clokep probably wouldn't mine 11:20:13 <flo-retina> *mind 11:29:01 --> mikk_s has joined #instantbird 11:31:22 <-- Mic has quit (Input/output error) 11:50:23 <-- mikk_s has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com) 12:02:15 <-- aleth has quit (Quit: Au revoir) 12:03:21 --> aleth has joined #instantbird 12:03:21 * ChanServ sets mode +h aleth 12:11:43 <instantbot> New Core - IRC bug 1784 filed by aletheia2@fastmail.fm. 12:11:44 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 2075 on bug 1784. 12:11:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1784 nor, --, ---, aletheia2, ASSI, Atheme Nickserv auth success message not recognized when using grouped nicks 12:19:19 --> mikk_s has joined #instantbird 12:30:59 <flo-retina> aleth: "Please test as when I log into freenode, it uses SASL and Nickserv is quiet." uh, shouldn't freenode's nickserv be quiet for me too then? 12:31:58 <aleth> What happens after CAP LS in your logs? 12:32:36 <flo-retina> it's not easy to have a log for freenode only :-/ 12:33:02 <aleth> Look for "irc: SASL authentication successful." 12:33:38 <flo-retina> Warning: :adams.freenode.net 904 fqueze :SASL authentication failed 12:34:28 <flo-retina> Error: Registration completed before SASL authentication completed. Source File: resource:///modules/ircSASL.jsm Line: 72 12:34:55 <flo-retina> and the interesting messages have already scrolled away :( 12:35:04 <flo-retina> too many unrelated messages from other accounts 12:35:14 <-- mikk_s has left #instantbird () 12:35:47 <aleth> That error indicates another auth method has succeeded first. 12:36:06 <aleth> Which is kind of strange 12:36:06 <flo-retina> aleth: do we send the user nick at some point during the SASL authentication? If so, I suspect it expects the main nick of the group :-S 12:36:22 <flo-retina> I'll need to try again later with a debug build and only the freenode account 12:36:51 <aleth> flo-retina: That was my suspicion also, but I don't know. 12:37:36 <flo-retina> that patch to change the way we intercept nickserv's messages still seem like something we should take, but it's possible there's another bug we need to investigate that this change would hide 12:37:40 <aleth> I mean, sure we send the nick along in the auth message\ 12:37:48 <aleth> Yes 12:47:59 <aleth> When you test the patch you can grab a log ;) You're probaby right about the grouped nick being the cause (especially if the SASL login works if you use the first nick) 13:20:43 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 2076 on bug 1779. 13:20:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1779 nor, --, ---, aletheia2, ASSI, Focusing Instantbird by clicking an unselected conversation tab doesn't mark the current conversatio 13:24:41 * aleth thinks not quite so round show nick bubbles are an improvement, as they mimic the shape of the bubbles themselves that way https://i.minus.com/j9rkeLF2RqVcY.png 13:27:42 <flo-retina> aleth: have you also removed the font-weight:bold for that screenshot? 13:27:59 <flo-retina> or is it just that it's not a font I'm used to seeing 13:28:15 <aleth> No, that's the font I guess 13:28:42 <flo-retina> aleth: I think I agree that it's an improvement 13:28:46 <flo-retina> feel free to submit a patch if you want 13:30:18 <flo-retina> aleth: not really related: wouldn't one more pixel of margin right (or -moz-margin-end actually) make the nick next to ":" look nicer? 13:31:12 <flo-retina> it doesn't seem useful for the bold ":" though. Probably due to anti-aliasing :-/ 13:31:30 <aleth> I suspect a lot depends on the font used 13:31:53 <flo-retina> that's quite possible 13:31:54 <aleth> That's also why I'm a bit worried about making changes to the styling so close to release 13:32:26 <flo-retina> changing the border radius can't make it look horrible :) 13:44:05 <flo-retina> it's a little bit unfortunate that this patch will cause this.displayStatusText to be called 13:46:33 <aleth> Hopefully it is smart enough not to do anything if there were no changes 13:47:04 <flo-retina> http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1432 heh :) 13:47:17 <flo-retina> although the tab is still selected at that point, right? 13:47:27 <aleth> Yes, that's the point 13:47:30 <aleth> But: http://lxr.instantbird.org/instantbird/source/instantbird/content/instantbird.js#126 13:47:46 <aleth> (line 172) 13:49:03 <flo-retina> ok, that should be cheap 13:49:16 <flo-retina> window.XULBrowserWindow.setStatusEnd doesn't seem to have similar tests though 13:49:32 <flo-retina> doesn't matter ^^ 13:49:39 <flo-retina> I guess I should test that patch too before commiting it 14:13:57 --> barlas has joined #instantbird 14:33:50 --> mconley has joined #instantbird 15:06:02 <-- mconley has quit (Ping timeout) 15:07:43 --> mconley has joined #instantbird 15:27:03 --> mikk_s has joined #instantbird 15:27:17 <-- mikk_s has quit (Client exited) 15:27:53 <-- Optimizer has quit (Ping timeout) 15:37:10 <-- Kaishi has quit (Quit: Kaishi) 15:37:19 --> Kaishi has joined #instantbird 15:38:11 --> micahg has joined #instantbird 15:38:16 <-- micahg has quit (Quit: Ex-Chat) 15:38:28 <-- Kaishi has quit (Quit: Kaishi) 15:38:39 --> micahg has joined #instantbird 15:39:21 --> Optimizer has joined #instantbird 15:56:23 <-- barlas has quit (Quit: Konversation terminated!) 16:04:04 --> Kaishi has joined #instantbird 16:04:27 <aleth> One day we should profile the display of conversations from hold... 16:04:58 <flo-retina> as soon as we get the profiler working ;) 16:05:15 <flo-retina> conv from hold, or just in the log viewer (it's even easier to reproduce the slowness there) 16:05:21 <aleth> yeah... 16:06:00 <flo-retina> the 3 most obvious performance issues I'm aware of are: loading a large conv, loading a long nicklist, checking "show offline contacts". 16:06:32 <aleth> I've obviously not got enough contacts to ever notice the latter ;) 16:06:32 <flo-retina> we tried to mitigate them, but with limited success because we have limited/poor data 16:06:50 <aleth> But yeah, for the first two we need more fine-grained data 16:06:57 <flo-retina> aleth: it's hardly noticeable in a non-debug build 16:07:24 <flo-retina> aleth: but it makes the animations not smooth (the time of the animation is almost over when the list is actually displayed) 16:07:30 <aleth> I suspect just opening the conversation window (before IB does anything) also takes a surprising amount of time 16:07:51 <flo-retina> "before IB does anything" is possibly wrong 16:08:10 <flo-retina> I'm almost sure some (most?) of our code is executed before the window is actually painted for the first time. 16:08:11 <aleth> s/IB/the conversation binding 16:08:39 <flo-retina> I would also be very interested in valid detailed memory usage data 16:08:45 <aleth> Yes, but I noticed when timing the nicklist that there would be a noticeable pause before the timer would start 16:09:16 <aleth> The nicklist is definitely filled (when opening from hold) before anything is painted btw 16:09:44 <flo-retina> that's most likely very wrong if the conversation is opening in a non visible tab ;) 16:10:04 <aleth> It's one scope for optimization, not blocking the UI 16:10:31 <-- Optimizer has quit (Ping timeout) 16:10:46 <aleth> Even nicer is speeding it up ;) 16:11:46 <flo-retina> both can work together :) 16:11:50 <aleth> :) 16:12:00 <aleth> "async everything" :P 16:12:13 --> Optimizer has joined #instantbird 16:12:22 <flo-retina> I don't think the time actually spent to do something is very relevant 16:12:37 <flo-retina> what's relevant is how much we are making the user wait, and how much power we are draining from the battery 16:13:16 <aleth> Yes, but when we open a long conversation we are always going to make the user wait until he sees the end. 16:13:40 <flo-retina> not if we display only the 20 last messages unless he starts scrolling up 16:13:40 <aleth> Maybe when Mic lands his bug 958 I can look at scrolling into the logs and we can fix this another way... 16:13:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 16:14:01 <aleth> Yup ;) 16:14:06 <flo-retina> I think that's the best long term way to optimize the display of conversations 16:14:27 <flo-retina> btw, removing stupid CSS selectors from bubbles may also help (maybe not enough to be measurable though) 16:15:08 <aleth> Probably every little thing with Bubbles will add up. 16:15:20 <aleth> I doubt there is one huge bottleneck... 16:15:32 <flo-retina> I don't know 16:15:38 <flo-retina> sometimes there are stupid things... 16:15:47 <flo-retina> you probably weren't around the first time I profiled the nick list 16:15:51 <aleth> For the nicklist, it should be ca. twice as fast now, and that was really not much effort 16:15:52 <flo-retina> that was several years ago 16:16:17 <flo-retina> 80+% of the time and CPU was spent updating the count next to "Participants:" each time we added a nick in the list. 16:16:21 <aleth> Oh wow. 16:16:29 <aleth> Very non-obivious... 16:17:08 <flo-retina> I changed it to updating that count only after finishing adding a batch of nicks, and the nicklist became usable for reasonably larges lists of participants (200-300 participants) 16:18:16 <flo-retina> before that simple optimization, opening #ubuntu caused a freeze for 1-2 minutes, causing the IRC account to Ping timeout... 16:18:58 <aleth> 2 minutes is too long ;) 16:19:15 <aleth> The next reasonably obvious way to improve the nicklist would be similar, to send the nicks in batches when opening from hold 16:19:37 <flo-retina> don't we already have the whole list? 16:19:52 <aleth> We do, but if we send them in batches we aren't blocking the UI 16:19:56 <flo-retina> I think we should really display only the 30-50 first nicks until the user scrolls. 16:20:41 <flo-retina> and I don't remember if with your recent optimization patch we still store the color on the DOM node or not, but if we do, that needs to change, so that we don't need the dom nodes for all buddies 16:21:30 <aleth> Right, a dynamically filled list would be nice. Also a lot more work ;) 16:22:02 <aleth> It will be interesting to see a profile of a complete "open channel from hold" process 16:23:14 <flo-retina> "a lot more work" it doesn't sound too difficult to me. Definitely easier than loading old messages at the top of the conversation, or adding an unread ruler ;). 16:24:08 <aleth> flo-retina: I suspect "more work" because the listbox even as is loses items occasionally, as it tries to do its own internal optimizations with the binding attachment etc 16:25:14 <aleth> It's not as if 2000 listitems were bound when we add them, that would take... comparatively forever (I tried) 16:26:38 <flo-retina> we are still creating too many dom nodes 16:26:55 <flo-retina> and inserting them in the dom 16:26:59 <aleth> Yes... 16:27:29 <aleth> I'm just worried that adding them on-the-fly when needed will take too long to be responsive 16:28:20 <flo-retina> aleth: what about starting to build the real full list when the user hovers or focuses the list? 16:28:49 <flo-retina> aleth: that likely gives us a few hundred ms before we have to scroll 16:29:29 <aleth> That might work... 16:51:47 <instantbot> New Core - General bug 1785 filed by aletheia2@fastmail.fm. 16:51:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1785 enh, --, ---, nobody, NEW, Store the nicks contained in a message with the message in the JSON log 16:56:35 --> Mnyromyr has joined #instantbird 17:04:10 <flo-retina> aleth: that bug seems simple, but there's a lot of work there ;) 17:04:27 <aleth> yeah... 17:04:57 <aleth> requires moving a lot of things around 17:06:51 <aleth> Filing the bug was easy though ;) 17:08:36 --> Mic has joined #instantbird 17:08:36 * ChanServ sets mode +h Mic 17:08:55 <flo-retina> aleth: sure 17:09:13 <flo-retina> aleth: you will run into all the "the prplIMessage interface sucks" problems ;) 17:14:20 <-- micahg has quit (Quit: Ex-Chat) 17:17:03 <Mic> "User mentions" are coming to our logs, as it seems? Interesting :) 17:17:27 <flo-retina> aleth: oh, that was the goal? 17:17:30 <Mic> This is definitely a lot better than what we currently have: https://i.minus.com/j9rkeLF2RqVcY.png :) 17:18:22 <flo-retina> heh, we seem to all agree that it's an improvement, so we should take it ;) 17:19:36 <Mic> I'd really like to check how it looks on Windows. 17:26:14 * Mic had the opportunity to play with Windows 8 on a touchscreen-equipped computer today. Worked pretty well :) 17:29:40 --> wesj1 has joined #instantbird 17:30:21 --> micahg has joined #instantbird 17:38:19 <aleth> flo-retina: that wasn't the goal, but now Mic points it out, it does seem similar 17:39:20 <aleth> Mic: http://pastebin.instantbird.com/99625 17:40:13 <flo-retina> aleth: if showing nicks in the log viewer is the goal, what we need is to log the participant list when joining, and to log the nick that enter/leave the room. 17:40:39 <aleth> flo-retina: That may not be the easiest solution though 17:41:07 <flo-retina> aleth: isn't "padding: 0.1em 0.3em 0 0.3em;" the equivalent of "padding: 0.1em 0.3em 0;"? 17:41:27 <flo-retina> and why do you need to add 0.1em of padding-top? 17:42:13 <aleth> flo-retina: Yes, but I find the three parameter version confusing for some reason 17:42:32 <aleth> flo-retina: The padding looked better for me, but that may be font-dependent. Lets see what Mic thinks ;) 17:42:54 <flo-retina> aleth: Mic usually likes extra spacing ;) 17:43:27 <aleth> I'm more unsure about that than about the border radius change of course. 17:50:48 <-- flo-retina has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 17:55:48 * aleth would like to test a Surface keyboard and find out how good it is 17:56:06 --> mikk_s has joined #instantbird 17:57:01 <-- mikk_s has left #instantbird () 18:00:10 <Mic> hmm... 18:00:29 <Mic> I tried both 0em and 0.1em padding at top and at the moment I'd say I like 0 better. 18:02:16 <aleth> Does the text appear centered in the bubble for you that way? 18:02:38 <Mic> One minute.. 18:02:50 <Mic> http://i.imgur.com/JfHxN.png 18:03:15 <Mic> The left part of the image is with 0em padding, the right with extra 0.1em. 18:03:26 <aleth> Right. 18:03:52 <Mic> The left one looks vertically centered (when looking at the upper case "B") for me 18:04:01 <aleth> That's true. 18:05:04 <aleth> What if we moved the entire bubble upwards so its lower border sat closer to the baseline of the normal text? 18:05:15 <aleth> ^^ crazy idea 18:06:26 <aleth> The padding thing must be font-dependent then (how much they add below the baseline) 18:12:07 <Mic> We have font-sizes in the UI that depend on the font-size that the user chose in the preferences dialog :( 18:13:19 <Mic> I'll show you a screenshot if you promise that you won't cry.. 18:13:57 <Mic> http://i.imgur.com/IX6Hr.png 18:14:55 <Mic> gtg, have a nice evening. i'll file this bug later 18:15:13 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 18:21:31 --> Mook_as has joined #instantbird 18:22:56 --> rosonline has joined #instantbird 18:34:13 <aleth> Mic: :( :( 18:34:48 <aleth> I guess that makes that em/px css bug even more urgent :-/ 18:38:51 --> unghost has joined #instantbird 18:49:50 <aleth> Hmm, which font setting did you change? I can't reproduce 18:58:41 <-- wesj1 has quit (Ping timeout) 19:50:04 <-- aleth has quit (Quit: Au revoir) 19:50:12 --> aleth has joined #instantbird 19:50:12 * ChanServ sets mode +h aleth 19:50:41 <-- aleth has quit (Quit: Au revoir) 19:52:01 --> aleth has joined #instantbird 19:52:01 * ChanServ sets mode +h aleth 20:16:00 <-- micahg has quit (Quit: Ex-Chat) 20:32:02 <-- Optimizer has quit (Ping timeout) 20:36:06 --> Optimizer has joined #instantbird 20:45:05 <-- Optimizer has quit (Ping timeout) 20:49:08 --> Optimizer has joined #instantbird 20:49:25 --> jb has joined #instantbird 21:11:55 <-- aleth has quit (Quit: Au revoir) 21:13:44 --> aleth has joined #instantbird 21:13:44 * ChanServ sets mode +h aleth 21:15:31 <-- jb has quit (Ping timeout) 21:40:12 --> flo has joined #instantbird 21:40:13 * ChanServ sets mode +qo flo flo 22:08:42 <flo> http://i.imgur.com/IX6Hr.png is super ugly :( 22:09:35 <Mook_as> that's, umm, very large 22:09:43 <flo> I can't reproduce though :-S 22:15:10 <-- mconley has quit (Input/output error) 22:23:08 <-- flo has quit (Input/output error) 22:23:10 --> flo has joined #instantbird 22:23:11 * ChanServ sets mode +qo flo flo 22:26:21 --> jb has joined #instantbird 22:30:38 --> flo-retina has joined #instantbird 22:30:38 * ChanServ sets mode +qo flo-retina flo-retina 22:31:06 <flo-retina> aleth: so are we taking the border radius change alone, or should I still test the 0.1em padding? 22:32:15 <aleth> flo-retina: definitely the first; test the padding if you like, but it looks like the effect depends on the font and possibly os 22:33:47 <flo-retina> aleth: also, when testing that king of stuff, it's important to test both with letters like "tdfhklb" and like "ypqgj" ;) 22:33:52 <flo-retina> *kind 22:34:13 <aleth> I am tempted to suggest 0.1 top and bottom 22:34:49 <flo-retina> I think I'll dislike enlarging it at the bottom 22:35:02 <aleth> Try it... 22:35:05 <flo-retina> as it's already very close to the hr separating multiple consecutive messages 22:36:48 <aleth> Hmm, yes, I think you are right 22:37:16 <aleth> I think what I was "compensating" a bit with the 0.1 extra padding up top was the fact that the bubble extends below the baseline already 22:39:56 <flo-retina> aleth: debug log of connecting to freenode with a grouped nick: http://pastebin.instantbird.com/99821 22:40:22 <aleth> Thanks! 22:40:56 <aleth> Does SASL work when you try the first grouped nick? 22:40:58 <flo-retina> directly from my terminal, I haven't even looked at it at all 22:41:13 <flo-retina> I can try 22:41:46 <aleth> There doesn't seem to be anything surprising there. SASL fails after we send authenticate (no reason given), then the fallback to Nickserv works 22:42:38 <flo-retina> aleth: yes (debug log of connecting the first nick of the group: http://pastebin.instantbird.com/99823) 22:42:50 <aleth> So our suspicion was correct ;) 22:44:08 <aleth> I wonder if that's worth a bug of the sort "support grouped nicks better" 22:45:08 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 22:45:10 <flo-retina> "The server does not support SASL PLAIN authentication." seems wrong 22:45:44 <flo-retina> I don't understand the meaning of "Registration completed before SASL authentication completed." 22:45:56 <flo-retina> and it's not obvious to me why we send "CAP END" twice 22:46:11 <flo-retina> (but I don't know how all this stuff is supposed to work :)) 22:46:31 <aleth> I don't think this is a failure mode that was anticipated ;) 22:46:58 <aleth> So the interpretations of the messages we receive and write to the error console are a bit off 22:47:19 <flo-retina> that probably deserves a bug ;) 22:47:22 <aleth> Yup. 22:48:08 <aleth> Maybe attach the log (or some stripped version of it)? 22:49:05 <flo-retina> I'm not filing it (I don't know what the problem is anyway :-S) 22:49:22 <flo-retina> I think I'll just test the nickserv eating change 22:49:26 <aleth> I can file it 22:49:46 <aleth> Anything in that log you don't want on BIO? 22:49:54 <flo-retina> or if I file it, it will just be "the auth code has a strange behavior when connecting a grouped freenode account" 22:50:12 <flo-retina> the line that starts with "AUTHENTICATE" 22:50:19 <flo-retina> I shouldn't have pastebined that :( 22:50:33 <aleth> Hmm yes :-/ 22:50:35 <flo-retina> I didn't expect the password to be printed in the debug log 22:50:51 <aleth> We don't write it to the error console... 22:50:57 <aleth> :( 22:51:03 <flo-retina> aleth: I don't believe that :-P 22:51:34 <flo-retina> it seems there's LOG(AUTHENTICATE +) then DEBUG(<what's actually sent>) 22:51:59 <-- jb has quit (Ping timeout) 22:52:03 <aleth> Huh, it's something we are usually careful about 22:52:06 <flo-retina> the sencond parameter of http://lxr.instantbird.org/instantbird/source/chat/modules/socket.jsm#189 has been forgotten it seems 22:52:41 <aleth> I should have caught that on review :-S 22:52:55 <flo-retina> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircSASL.jsm#38 there's nothing here telling that something shouldn't be logged 22:53:40 --> Mic has joined #instantbird 22:53:40 * ChanServ sets mode +h Mic 22:53:44 <aleth> Yes, it needs a third parameter like in all the other instances of that same patch 22:53:59 <aleth> (IDENTIFY etc) 22:54:17 <aleth> I should patch that before 1.3 22:54:51 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 22:54:57 <flo-retina> can you file a bug for the border radius change? So that we have something to point to if for some reason we decided tomorrow that it wasn't a good idea and we should back it out :) 22:55:29 <flo-retina> I could of course take that one line change without bug, but it makes me slightly uncomfortable so close to the release 22:55:40 --> Mic has joined #instantbird 22:55:40 * ChanServ sets mode +h Mic 22:56:31 <instantbot> New Core - IRC bug 1786 filed by aletheia2@fastmail.fm. 22:56:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1786 nor, --, ---, nobody, NEW, Don't log password during SASL auth 22:56:42 <aleth> so I don't forget... 23:00:14 <instantbot> New Instantbird (UI) bug 1787 filed by aletheia2@fastmail.fm. 23:00:15 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 2077 on bug 1787. 23:00:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1787 min, --, ---, aletheia2, ASSI, [Bubbles] Change Show nick border radius to better match the border radius of the bubbles 23:00:26 <flo-retina> thanks :) 23:00:28 <Mic> It's no concern that the border-radius has a fixed (pixel) length? On the other hand: all other radii / width / paddings are set with pixel-lengths too. 23:01:06 <instantbot> florian@instantbird.org granted review for attachment 2075 on bug 1784. 23:01:09 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1784 nor, --, ---, aletheia2, ASSI, Atheme Nickserv auth success message not recognized when using grouped nicks 23:01:56 <flo-retina> Mic: when I played with the font size a few minutes ago to try to reproduce the size issue on your screenshot, I wondered if the border-width of the bubbles shouldn't also be defined in pt 23:02:17 <Mic> I've done that this afternoon. 23:02:31 <Mic> It will almost looked like zoomed in then. 23:02:48 <Mic> (which is not a bad thing in my opinion) 23:03:02 <Mic> I used "em" though. 23:03:58 <Mic> Well, it's not exactly what you suggested. the border-width is the only thing I kept at 2px (because of the indicator bitmap) but I changed border-radius and paddings 23:05:14 <flo-retina> aleth: what's the unescape(encodeURIComponent()) dance for? 23:05:23 <aleth> Unicode. 23:07:09 <flo-retina> what do you want the third parameter to be? 23:07:34 <flo-retina> should it be a base64 encoded string with "<password not logged>" instead of the password while building it? 23:07:45 <flo-retina> or just a clear text string? 23:07:58 <aleth> Similar to here 23:07:59 <aleth> http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircServices.jsm#76 23:08:11 <aleth> e.g. "AUTHENTICATE <password not logged>" 23:09:04 <aleth> I think clear text is all that's needed 23:09:35 <Mook_as> "AUTHENTICATE PFBBU1NXT1JEIE5PVCBMT0dHRUQ+" ;) 23:10:34 <Mic> :D 23:10:48 <Mic> flo-retina: I need to fix bug 1511, would you have a look at this WIP if you've got a moment for it? http://pastebin.instantbird.com/99846 23:10:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts 23:11:03 <Mic> That's what you want it to be like, isn't it? 23:13:27 <flo-retina> Mic: looking 23:13:34 <Mic> Thanks. 23:14:40 <-- Optimizer has quit (Ping timeout) 23:14:52 <flo-retina> Mic: it's what I suggested, yes. Still needs some gtalk handling 23:15:30 <flo-retina> I'm not sure if it should be _accountEquals (because it's not exposed in the idl interface) or accountEquals, so I wouldn't r- any of these names 23:15:58 <Mic> Not only that. I only want to make sure that it's what you wanted before putting time into it (it's late here;). 23:16:22 <flo-retina> Mic: you want to add a comment above accountEquals in jsProtoHelper explaining why a prpl may want to provide a customized implementation 23:16:36 <aleth> nn 23:16:37 <flo-retina> Mic: aren't we on the same timezones? ;) 23:16:45 <-- aleth has quit (Input/output error) 23:16:46 <flo-retina> *timezone 23:17:06 * flo-retina would be curious to know what caused that "Input/output error" :-S 23:18:31 --> Optimizer has joined #instantbird 23:18:33 <Mic> We are, it's late anyways and yes, I'm going to add a comment 23:18:38 <Mic> ;) 23:19:35 * flo-retina would like to remove the patches that may land before 1.3 from his review queue before going to bed 23:19:49 <flo-retina> and it's too late again to hope spending any time on that awful twitter bug :( 23:26:21 <flo-retina> https://bugzilla.instantbird.org/attachment.cgi?id=2076 is indented with tabs :( 23:40:27 <instantbot> florian@instantbird.org granted review for attachment 2076 on bug 1779. 23:40:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1779 nor, --, ---, aletheia2, ASSI, Focusing Instantbird by clicking an unselected conversation tab doesn't mark the current conversatio 23:53:37 --> gerard-majax has joined #instantbird 23:54:28 <instantbot> florian@instantbird.org requested review from benediktp@ymail.com for attachment 2078 on bug 1783. 23:54:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1783 nor, --, ---, florian, NEW, Typing notification never goes away for tabs in a detached window 23:54:46 * flo-retina wonders if Mic is still awake enough to look at a very trivial patch ;) 23:55:10 <Mic> Let's see? 23:56:52 <Mic> flo-retina: ping 23:56:59 <flo-retina> pong? 23:57:25 <Mic> Oh, no. Not awake enough to notice that it's already been requested :( 23:57:38 <flo-retina> ahah :-D