All times are UTC.
00:02:24 <instantbot> florian@instantbird.org cancelled feedback? for attachment 2037 on bug 1562. 00:02:25 <instantbot> florian@instantbird.org requested review from aletheia2@fastmail. fm for attachment 2038 on bug 1562. 00:02:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1562 enh, --, ---, florian, ASSI, Integrate Show Nick 00:03:10 <flo-retina> drive by reviews are of course welcome. 00:09:08 <Mic> Good night 00:09:28 <Mic> I'm really looking forward to this, especially to see how well it works with different themes :) 00:10:26 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 00:18:42 <-- jb has quit (Ping timeout) 01:08:00 <-- Optimizer has quit (Ping timeout) 01:11:50 <-- SM0TVI has quit (Ping timeout) 01:12:57 --> SM0TVI has joined #instantbird 01:58:53 <-- DGMurdockIII has quit (Connection reset by peer) 03:37:08 <instant-buildbot> build #675 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/675 03:43:11 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 03:50:14 --> Optimizer has joined #instantbird 04:34:10 <-- wnayes has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 05:18:03 <instant-buildbot> build #763 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/763 05:58:55 <-- Optimizer has quit (Ping timeout) 06:02:11 --> Optimizer has joined #instantbird 06:40:45 <-- Optimizer has quit (Ping timeout) 06:43:53 --> Optimizer has joined #instantbird 07:18:38 <-- Mook has quit (Quit: Mook) 07:43:27 <-- Optimizer has quit (Ping timeout) 08:18:48 <instant-buildbot> build #676 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/676 08:23:27 --> jb has joined #instantbird 08:50:48 <-- jb has quit (Ping timeout) 09:48:35 --> Optimizer has joined #instantbird 10:01:06 <-- Optimizer has quit (Ping timeout) 10:25:43 --> rosonline has joined #instantbird 10:33:55 --> Optimizer has joined #instantbird 10:36:54 --> flo has joined #instantbird 10:36:55 * ChanServ sets mode +qo flo flo 11:03:16 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 2039 on bug 1610. 11:03:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1610 tri, --, ---, florian, NEW, Display a correct error message in the conversation when receiving a message type=error stanza 11:20:49 <-- flo has quit (Input/output error) 11:20:54 --> flo has joined #instantbird 11:20:55 * ChanServ sets mode +qo flo flo 11:50:57 --> barlas has joined #instantbird 11:53:02 <-- barlas has quit (Quit: Konversation terminated!) 11:58:52 <-- Optimizer has quit (Ping timeout) 12:06:34 <-- rosonline has quit (Client exited) 12:18:30 --> Optimizer has joined #instantbird 12:33:48 --> meh has joined #instantbird 13:00:03 <-- Optimizer has quit (Ping timeout) 13:03:25 --> Optimizer has joined #instantbird 13:20:03 <-- Optimizer has quit (Ping timeout) 13:31:27 --> Optimizer has joined #instantbird 13:51:53 --> aleth has joined #instantbird 13:51:53 * ChanServ sets mode +h aleth 14:01:03 <-- aleth has quit (Quit: Au revoir) 14:01:12 --> aleth has joined #instantbird 14:01:13 * ChanServ sets mode +h aleth 14:01:27 <-- aleth has quit (Quit: Au revoir) 14:01:40 --> aleth has joined #instantbird 14:01:41 * ChanServ sets mode +h aleth 14:10:10 --> clokep_work has joined #instantbird 14:10:10 * ChanServ sets mode +o clokep_work 14:16:58 <flo-retina> aleth, clokep_work: hello :) 14:17:03 <flo-retina> clokep_work: _work on a Sunday? :-/ 14:17:41 <flo-retina> aleth: the twitter icon looks good on twitter tabs :) 14:17:44 <aleth> flo-retina: hello :) 14:17:55 <aleth> I seem to have broken show nick ;-/ 14:17:59 <clokep_work> flo-retina: I'm waiting for my Mozilla profiles to transfer back onto my hard drive, I just installed Windows 8 this morning. 14:18:03 <clokep_work> (Well the release version, I had the RC...) 14:18:10 <flo-retina> aleth: I didn't even notice it the first time I saw it. It was only a few minutes later that I thought "wait, that's the new thing we have just checked-in!" :) 14:18:34 <flo-retina> aleth: yes, everybody on nightlies should disable Show Nick. 14:18:36 <aleth> :) 14:18:59 <flo-retina> aleth: btw, any ETA on the Show Nick integration review? Maybe Show Nick will be completely obsolete tomorrow :). 14:19:14 <aleth> flo-retina: aha! 14:19:22 * aleth hasn't checked his bugmail yet 14:20:12 <flo-retina> aleth: FWIW, to unbreak the Show Nick code that I ported, I had to add "if (!buddy.colorStyle) this._setBuddyColor(buddy);", so nothing too terrible 14:20:19 <aleth> It will be great to have Show Nick integrated. Probably the best 1.3 feature for most people ;) 14:20:30 <flo-retina> aleth: only people using IRC I think 14:20:39 <clokep_work> flo-retina: We can change all those unhandled messages to LOG if you want, I think we originally made them WARN so we would see them when we first integrated JS-IRC. 14:20:39 <aleth> and not using Show Nick already... 14:20:42 <flo-retina> but for Mozilla employees using Instantbird, it may be great :) 14:21:06 <flo-retina> clokep_work: my understanding is that the point of using WARN is to encourage people to file a bug when they see a new one. 14:21:24 <aleth> clokep_work: I think we might find them useful for bug reports 14:21:32 <flo-retina> clokep_work: so if something is known and not a bug, we shouldn't let it be "unhandled" 14:21:36 <aleth> There aren't that many left... 14:21:45 * aleth hints at user mode review ;) 14:24:10 <flo-retina> the warnings I see from JS-IRC at this point are: http://pastebin.instantbird.com/95321 14:24:20 <flo-retina> and I don't have the least idea of what "Unused mode parameters: 2:2" is about 14:24:46 <flo-retina> I also wonder why we don't have location information. Has a recent Mozilla update broken our logging code? :-S 14:26:31 <instantbot> aletheia2@fastmail.fm cleared the Resolution 'INVALID' from bug 1753. 14:26:33 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1753 min, --, ---, nobody, REOP, Unhandled IRC message: :rajaniemi.freenode.net CAP * LS :account-notify extended-join identify-msg m 14:27:24 <clokep_work> aleth: I think you could have waited a few minutes before we really decided what to do before clearing that... 14:27:53 <aleth> clokep_work: You're right, sorry. 14:27:59 --> clokep has joined #instantbird 14:27:59 <flo-retina> clokep_work: don't we all agree that there's "something" to do, even if it's not clear yet what needs to be done? 14:27:59 * ChanServ sets mode +o clokep 14:28:09 <aleth> Still, it's bugspam. 14:28:38 <clokep> I guess. 14:28:44 <aleth> It's not a bug though :P 14:28:53 <clokep> It's a feature. ;) 14:29:22 <clokep> Btw Instantbird looks fine on Win 8 for me. 14:29:28 <clokep> It fits in fairly well, in fact. :) 14:29:40 <aleth> When reviewing the SASL patch, I thought it was consistent with other warnings we have, but it's confusing to see SASL listed. 14:30:11 <aleth> Neat! IB is metro-ready :D 14:30:18 <flo-retina> clokep: is there anything interesting to show on a screenshot, or is it just "as on Win7"? 14:30:38 <clokep> flo-retina: I can put one up, one second. 14:35:44 <-- clokep_work has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 14:36:24 <clokep> Windows 8: http://i.imgur.com/re2Wp.png 14:40:13 <flo-retina> clokep: you have many more IRC channels on hold than I do :) 14:40:25 <flo-retina> even with vertical tabs you couldn't have them all in a single window 14:40:27 <clokep> flo-retina: Too many, probably... 14:40:41 * clokep misses Show Nick. :( 14:41:01 <clokep> aleth: That image also has my (awful?) styling of unread messages. ;) 14:41:24 <flo-retina> clokep: maybe review the patch if you want to have it faster? ;) 14:41:46 * clokep was hoping aleth was going to do it. 14:41:46 * aleth finds the Windows-95-style slider grippy the worst "feature" 14:41:59 <clokep> I'm going to a BBQ soon (to make a Bacon Explosion). 14:42:12 <aleth> BBQ? It's raining here... 14:43:06 <clokep> It's like 48 F out here... ;) 14:43:35 <flo-retina> the weather is horrible here 14:44:59 <flo-retina> very rainy (actually, lots of villages flooded around here), 100+km/h wind... 14:46:52 <flo-retina> ideal to spend time on Instantbird I guess :-D 14:47:06 <flo-retina> as long as the internet connection still works :) 14:47:32 <clokep> Sounds like the hurricane for us... ;) 14:48:22 * clokep needs to restore all his files and build environment. :( 14:48:38 <clokep> I need to go though. If I have time to do some reviews tonight I will! :) 14:48:40 <flo-retina> yeah. Likely let exceptional than what you had. But enough that the national TV learned the name of the 14:48:41 <flo-retina> county 14:48:44 <aleth> ditto, the tree has changed quite a bit ;) 14:49:12 <clokep> aleth: I'd really appreciate it if you could look at the Show Nick code, I'll probably take a look at it at some point, but you know that code wayyy better than me. 14:49:24 <aleth> clokep: Looking at it now 14:50:01 <flo-retina> aleth: cool :) 14:50:02 <clokep> :-D 14:50:05 * clokep hopes to have it tomorrow. 14:50:40 <flo-retina> aleth: less interesting than show nick, I would advice updating the "Visible Tags..." patch (or arguing back against my review comment) before I completely forget it again and have to fully re-review ;) 14:50:55 <flo-retina> *advise 14:51:19 <clokep> Ciao! 14:51:30 <flo-retina> enjoy the BBQ 14:51:33 <flo-retina> :) 14:56:27 <-- Optimizer has quit (Ping timeout) 14:59:38 --> Optimizer has joined #instantbird 15:11:39 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 2040 on bug 1751. 15:11:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1751 nor, --, ---, aletheia2, ASSI, No feedback when the /nick command fails 15:15:22 <flo-retina> to fix the location info, I need to add a ".caller" at the end of http://lxr.instantbird.org/instantbird/source/chat/modules/imXPCOMUtils.jsm#60 15:15:56 <flo-retina> there's a "nativeFrame" in between :-S 15:21:16 <instantbot> florian@instantbird.org granted review for attachment 1873 on bug 1685. 15:21:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1685 enh, --, ---, mook.moz+bugs.instantbird, NEW, Allow logging to be used in non-global scope 15:21:47 <flo-retina> my review queue's length is getting incredibly low :) 15:26:34 <flo-retina> *** Compartment mismatch 0x10d1c9000 vs. 0x10d2fc000 Assertion failure: false (compartment mismatched), at /Users/florian/buildhg/hg.instantbird.org/mozilla/js/src/jscntxtinlines.h:227 15:26:36 <flo-retina> hmm 15:26:50 <flo-retina> (that's a fatal error, the build crashes at startup) 15:33:29 <-- clokep has quit (Ping timeout) 15:52:31 <aleth> flo-retina: How can empty nicks happen? 16:19:58 <instantbot> aletheia2@fastmail.fm denied review for attachment 2038 on bug 1562. 16:20:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1562 enh, --, ---, florian, ASSI, Integrate Show Nick 16:50:44 --> skeledrew has joined #instantbird 16:59:14 <flo-retina> aleth: I don't remember, but it did happen at the time I initially developed the add-on 17:01:10 <-- aleth has quit (Input/output error) 17:01:12 --> aleth has joined #instantbird 17:03:21 <aleth> flo-retina: Shouldn't that throw an ERROR rather than be handled? 17:03:44 <flo-retina> Maybe 17:03:46 <aleth> (at the addBuddy stage) 17:03:59 <aleth> It's bound to cause trouble elsewhere too, if it does happen 17:04:14 <flo-retina> we really really don't want any empty nick in the regexp, as that would always match, and we would take 100% CPU 17:04:27 <aleth> Right :( 17:04:59 <flo-retina> we could get rid of the test in trackNick 17:05:04 <flo-retina> but I don't think that's the expensive one 17:05:13 <flo-retina> and I feel safer with the " .filter(function(nick) nick)" 17:05:28 <aleth> How about refusing to add buddies with blank nicks. Problem solved? 17:05:37 <flo-retina> I thought about "Since we never remove nicks from the array, shouldn't we check we the nick is not already there?" after attaching the patch yesterday 17:06:24 <flo-retina> I don't see an efficient way to detect duplicates (except maybe using an object instead of an array, and using Object.keys), and except if we get thousands of duplicates, I don't think it matters (/a|a/ will be the same as /a/ anyway) 17:06:41 <flo-retina> hmm... but maybe we get thousands of duplicates when an account in #ubuntu is disconnected and reconnected? :( 17:06:55 <aleth> Reconnects was what I was worried about, yes 17:07:00 <flo-retina> refusing to add them to this.buddies? That could work. 17:07:29 <flo-retina> do you have any other idea than the object and using the object keys? 17:07:49 <flo-retina> (well, there's of course .indexOf, but that's O(n)) 17:11:13 <-- Optimizer has quit (Ping timeout) 17:12:53 <flo-retina> I replied to a few other points in the bug 17:14:50 --> Optimizer has joined #instantbird 17:15:10 <flo-retina> I'll update the patch as soon as we decide how we can avoid duplicates 17:15:40 <aleth> So... if we can't drop sort, then finding a nick in the array is O(ln n) 17:16:51 <flo-retina> we can drop sort (or sort only by nick length) if we want 17:17:32 <aleth> But if we need to search for duplicates, maybe keeping the list sorted is the cheapest option? 17:17:38 <aleth> I'm not sure, still thinking 17:19:03 <flo-retina> hmm, insert sort, and if it's already there, don't insert again? 17:20:02 <aleth> Yes, in trackNick I guess 17:20:51 <flo-retina> that would work I guess 17:21:03 * flo-retina dislikes writing binary search code. I seem to always forget a +1 or -1 somewhere 17:21:29 <aleth> What you said about word boundaries seems to suggest we need to keep the sort anyway... 17:21:40 <aleth> (in some form at least) 17:22:17 <aleth> You can steal the binary search code from addNick ;) 17:22:48 <flo-retina> aleth: it means we need to have shorter nicks after long nicks when building the regexp. 17:23:31 <aleth> That's just a (possibly faster) sort criterion. 17:23:48 <flo-retina> and it possibly doesn't even matter for nicks that have only alphanumeric characters 17:23:50 <aleth> It's a bit annoying we might end up with 2 binary searches per added nick 17:25:15 <-- Optimizer has quit (Ping timeout) 17:25:59 <flo-retina> when reconnecting and inserting 2k nicks again (that are most likely already there), it's sad we can't just call .sort and get rid of the duplicates with .reduce or something 17:26:36 <flo-retina> (although I'm assuming here that the built-in C++ sort is much faster than doing a binary search in JS; not sure if that assumption make sense or not) 17:26:37 * instantbot frowns at flo-retina 17:26:46 <flo-retina> instantbot: pff 17:26:49 <instantbot> flo-retina: Sorry, I've no idea what 'pff' might be. 17:26:55 <aleth> Yes :( Plus there's no distinction at addBuddy level between adding 2 or 2000 nicks 17:27:37 <flo-retina> hmm 17:28:24 <flo-retina> could we push to an array of pending nicks, and decide whether to binary sort-insert or resort the whole list at the time we are building the regexp again (at the first displayed message; so only once; not once per nick) 17:28:58 --> Optimizer has joined #instantbird 17:29:45 <aleth> For adding nicks to the nicklist, that would only work if the nicklist was empty at some point 17:31:21 <aleth> i.e. it would then maybe be better instead to have a timeout on removeBuddy, so the buddy isn't actually removed for x sec, and if it's readded in that time the timer is cleared and we never need to re-add the buddy 17:33:01 * flo-retina isn't touching the nicklist for now 17:33:12 <aleth> I don't like that suggestion anyway. 17:33:34 <aleth> We have enough timers... 17:33:56 <flo-retina> aleth: do you also don't see any location information for IRC messages in the error console? 17:34:21 <aleth> flo-retina: No\ 17:34:42 <flo-retina> "No\" = "no location information"? 17:34:47 <aleth> No location info 17:34:54 <flo-retina> ok 17:34:56 * flo-retina files a bug 17:35:24 <aleth> flo-retina: How about changing trackNick to push nicks to a pending array, then add them to the actual list next time the node inserter is called? 17:35:50 <aleth> (That's probably what you suggested earlier, but I misunderstood) 17:35:51 <flo-retina> I suggested that a few lines before 17:36:13 <aleth> I thought you had something more drastic in mind ;) 17:36:52 <flo-retina> oh, maybe we could sort the pending array with the built-in sort, and then merge the two already sorted arrays? 17:37:30 <flo-retina> I've no idea of how to decide how many pending nicks is enough to be worth doing that instead of using insert-sort 17:37:44 <aleth> Nor do I :-/ 17:38:37 <flo-retina> wait, what about a binary search for the position of the first nick to insert from the sorted pending array, and then a binary search for the other nicks, but starting at the position of the nick we have just inserted? 17:38:42 <aleth> Actually the advantage of not doing insert-sort is that the time cost happens later (when the next message is displayed) and not at the same time as we are filling the nicklist etc. which is already busy\ 17:39:24 <aleth> flo-retina: That sounds good :) 17:39:59 <aleth> Each time you insert a nick, update the lower bound on the binary search 17:40:21 * flo-retina wonders if inserting several times in the middle of an existing array is more expensive than building a new array by pushing each element of the previous array 17:40:56 <aleth> That's probably the sort of thing that can only be answered by testing 17:41:03 * flo-retina wonders if he could volunteer aleth to implement that binary insert sort :-D 17:41:24 <flo-retina> probably yes :( 17:41:34 <aleth> Not if you want it in the next few days, sorry :( 17:41:58 <flo-retina> but if inserting in the middle of an array is super expensive, we could as well just merge the two arrays 17:42:09 <flo-retina> aleth: I don't need it in the next few days, today will be just fine :-P 17:42:27 <aleth> I'm running out of time for today already 17:43:16 <aleth> unfortunately... 17:43:35 <flo-retina> :( 17:43:52 * flo-retina would like to push show nick today, but would also like to have time to debug the twitter stream bug 17:43:58 <flo-retina> and is debugging that location info bug right now 17:44:24 <flo-retina> aleth: hmm... can we handle detecting duplicates in a follow-up? :-D 17:44:58 <aleth> That sounds dangerous ;) 17:45:10 <flo-retina> the Object.key version is fast to implement 17:45:29 <flo-retina> is there a real issue with it? 17:45:55 <aleth> Only for people who don't restart IB frequently and idle in busy channels 17:46:15 <flo-retina> why? 17:46:40 <flo-retina> the duplicate problem doesn't exist if we insert nicks as this._nicks[nick] = true; 17:47:10 <aleth> Oh, I see what you mean 17:47:12 <flo-retina> we sort the whole list of keys each time the regexp is rebuilt, but I don't have solid data to show that sorting 2000 nicks is a long operation 17:47:26 <flo-retina> (with the built-in sort) 17:47:59 <aleth> We could try it and find out that way... 17:48:36 <instantbot> New Core - Debug bug 1754 filed by florian@instantbird.org. 17:48:37 <instantbot> florian@instantbird.org requested review from the wind for attachment 2041 on bug 1754. 17:48:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1754 nor, --, ---, nobody, NEW, No location information for messages logged from imXPCOMUtils 17:48:44 <flo-retina> we will need to start using the gecko profiler 17:48:49 <aleth> Someone will have to test IB on slow machines then though. 17:48:54 <flo-retina> I don't remember if it requires gecko 16 or 17 17:49:02 <aleth> 17 I think 17:49:30 <flo-retina> aleth: opening #ubuntu takes 3-5s here on this super fast macbook, but I built with --enable-debu 17:49:31 <flo-retina> g 17:49:42 <aleth> Yup, the profiler would be useful 17:50:06 <aleth> flo-retina: Have you put loglevel up to the default before trying that? 17:50:31 <flo-retina> It probably was at the default level 17:50:39 <flo-retina> but I'm not really sure 17:50:41 <-- Optimizer has quit (Ping timeout) 17:50:50 <flo-retina> logging isn't very expensive when the Error Console window doesn't exist 17:51:11 <aleth> The nicklist population part for #ubuntu takes ~500ms for me, ~1000ms before the patch landed 17:51:40 <flo-retina> debug builds are super slow anyway 17:51:40 <-- deltafalcon has quit (Connection reset by peer) 17:52:04 <flo-retina> but it's not a good way to test performances, as it's not just n times sower than opt builds, it's just different slownesses 17:52:15 <aleth> Right... 17:52:33 <flo-retina> so is the Object.key solution fine with you? 17:52:35 <aleth> Opening a new conv window takes a bit of time too. 17:52:45 <flo-retina> (and can I hope for another review in half an hour? :)) 17:52:49 <aleth> flo-retina: Yes, lets land it and optimize later. 17:53:08 <aleth> Once we know more precisely what needs optimizing ;) 17:53:32 <flo-retina> btw, I didn't pick a reviewer for bug 1754. Whoever sees it first and feels confident with the patch should review it I think. 17:53:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1754 nor, --, ---, nobody, NEW, No location information for messages logged from imXPCOMUtils 17:54:11 --> Optimizer has joined #instantbird 17:55:00 <flo-retina> aleth: unrelated; have you read the comments about the "Visible Tags..." bug? 17:55:05 * flo-retina still has that patch locally applied 17:55:53 <flo-retina> just replacing "let haveTags = !!Services.tags.getTags().length;" with something like "let haveBuddies = !!<richlistbox>.firstChild;" should do I think. 17:56:06 <aleth> uh no, just a sec 17:59:32 <flo-retina> (oh, and I was quite surprised that the patch applied cleanly!) 17:59:53 <aleth> Nobody has touched that code in a looong time ;) 18:01:30 <flo-retina> Indeed. But other patches I applied Friday had bitrotted for completely silly reasons, so... :) 18:02:44 <aleth> Don't you think it should be haveTags && haveBuddies then? 18:02:55 <aleth> (in the opposite order) 18:03:59 <aleth> oh, wait 18:04:01 * aleth rereads bug 18:08:09 <flo-retina> it's impossible to have a buddy displayed if there's no tag 18:12:20 <aleth> OK. I just had to check that every buddy has at least one tag 18:13:12 <flo-retina> aleth: the interdiff of applying the changes discussed in the bug and here is http://pastebin.instantbird.com/95462 18:13:19 <flo-retina> if that looks OKish I'll attach the new patch :) 18:13:47 <flo-retina> aleth: if a buddy doesn't have any tag we automatically assume it has "Contacts" as tag. 18:14:22 --> DGMurdockIII has joined #instantbird 18:15:54 <aleth> flo-retina: Looks good :) 18:16:04 <flo-retina> :) 18:16:33 <flo-retina> if you are too busy to update the Visible Tags patch, I can do it (as long as we agree that what I proposed is the right thing to do) 18:19:33 <instantbot> florian@instantbird.org requested review from aletheia2@fastmail. fm for attachment 2042 on bug 1562. 18:19:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1562 enh, --, ---, florian, ASSI, Integrate Show Nick 18:20:03 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 2043 on bug 1096. 18:20:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too 18:20:09 <-- GeekShad0w has quit (Client exited) 18:21:09 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 17.0/20121031065642]) 18:27:08 * flo-retina applied that with "interdiff attachment.cgi?id=1606 attachment.cgi?id=2043 |sed 's@chrome/instantbird/content/instantbird@instantbird/content@' |patch -p1 18:27:08 <-- Even has quit (Input/output error) 18:27:08 <-- aleth has quit (Input/output error) 18:27:08 <-- Even1 has quit (Input/output error) 18:27:08 <-- flo has quit (Input/output error) 18:27:09 <-- Optimizer has quit (Input/output error) 18:27:10 --> Even has joined #instantbird 18:27:10 --> aleth has joined #instantbird 18:27:10 * ChanServ sets mode +o Even 18:27:10 --> Even1 has joined #instantbird 18:27:10 --> flo has joined #instantbird 18:27:12 --> Optimizer has joined #instantbird 18:28:39 <aleth> clokep: Nickserv no longer recognizes me now on every single reconnect 18:29:54 --> FeuerFliege has joined #instantbird 18:30:05 <flo-retina> aleth: btw, the nicklist keyboard accessibility changes are great! (I didn't have an opportunity to test it since it landed until yesterday) :) 18:30:51 --> sander85 has joined #instantbird 18:31:14 <instantbot> aletheia2@fastmail.fm granted review for attachment 2042 on bug 1562. 18:31:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1562 enh, --, ---, florian, ASSI, Integrate Show Nick 18:33:06 <instantbot> florian@instantbird.org granted review for attachment 2043 on bug 1096. 18:33:08 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too 18:33:32 <aleth> :) 18:34:34 * flo-retina will push all of that now to be 100% sure to not forget :) 18:34:37 <aleth> There is one other potential issue with the way Show Nick works now: I don't think it's possible to turn off the nick colours from the message style. 18:35:01 <aleth> Or will !important be enough? 18:35:20 <flo-retina> that's why I had to use !important in a few places 18:35:26 <aleth> Ah, that's what you did for Dark. 18:35:55 <aleth> Sorry, just mumbling to myself. 18:36:02 <flo-retina> and it's ugly, because .ib-nick[left] is more specific than .ib-nick, so !important in .ib-nick wasn't enough and I had to have it a second time 18:36:40 <flo-retina> I think nicks look better in Dark than in Bubbles 18:36:54 <flo-retina> I'm not satisfied of the way nicks look inside system messages on Bubbles 18:36:59 <aleth> Yes, you did a great job there 18:37:09 <flo-retina> you tested it? :) 18:37:16 <aleth> Briefly :) 18:37:40 <flo-retina> :) 18:37:42 <aleth> You mean they should be less coloured in system messages? 18:38:07 <flo-retina> what annoys me is the border in system messages, it's too close to the other border / hr 18:39:15 <flo-retina> I considered theming nicks inside system messages of Bubbles like they are in Simple (ie just the color and the font-weight change, no background, no border), but then I really don't know how to display old nicks :(. 18:39:54 <flo-retina> I've been tempted to strike through old nicks (and even to do it by default in conv.css) but I'm afraid it would significantly impair readability. 18:39:55 <aleth> Maybe drop the border in system messages? 18:40:03 <aleth> I could see that working as the background is not coloured 18:40:12 <flo-retina> wouldn't it look odd to drop the border but keeping the background? 18:40:21 <aleth> Only one way to find out ;) 18:40:36 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/38fa9b323195 - Florian Quèze - Bug 1562 - Integrate Show Nick, r=aleth. 18:40:38 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fc623481eab2 - Mook - Bug 1685 - Allow logging to be used in non-global scope, r=fqueze. 18:40:39 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c5e36103d80e - aleth - Bug 1096 - Add "Visible tags..." entry to contacts listbox background context menu too, r=fqueze. 18:40:49 <aleth> Striking through old nicks is ugly, I agree 18:40:53 <flo-retina> aleth: the border is quite important for old nicks :( 18:41:09 <aleth> Right :( 18:41:24 <flo-retina> also, I think the smaller font in system messages is wrong 18:42:11 <flo-retina> in regular message when a nick is detected, you more or less want to skip reading it, and instead guess who it is by the length of color of the nick highlight, but in system messages the text of the nick is actually what's important (especially in "foo is now know as bar" messages) 18:42:34 <flo-retina> well, to summarize: I'm not satisfied :). 18:42:50 <aleth> Maybe inspiration will strike tomorrow ;) 18:43:01 <flo-retina> I hope more people will play with it 18:43:09 <aleth> It's good to finally have it built in, also for tagging nicks etc\ 18:43:23 <aleth> Optimizer should be happy ;) 18:43:26 <flo-retina> but even if they don't, it will look exactly like it's looked for years with the Show Nick add-on, because I haven't modified that... (except I added the styling for old nicks) 18:44:18 * flo-retina is glad to have pushed 2 patches that had been waiting in his review queue for way too long :) 18:44:34 <aleth> Not much left in the queue now :) 18:44:43 <Optimizer> damnit, my add-on is now rendered useless ! 18:44:53 <Optimizer> half useless* 18:45:01 <flo-retina> Optimizer: what was that add-on? 18:45:03 * flo-retina doesn't remember 18:45:11 <aleth> Optimizer: more like it can now be optimized ;) 18:45:15 <Optimizer> even I don;t remember anymore 18:45:17 <flo-retina> Optimizer: if that makes you feel better, my "Show Nick" add-on is now completely obsolete ;) 18:45:29 <Optimizer> heh 18:45:34 <Optimizer> not bad 18:45:37 <aleth> It was something to do with clickable nicks, right? 18:45:56 <Optimizer> iirc, it makes IB behave like mibbit 18:46:24 <Optimizer> but I never got it pass the review, was too lazy to continue on it :P 18:46:46 <flo-retina> aleth, I still have bug 1498, wnayes' giant patch, SIPE, a patch that we just need to check-in, and a patch that I would like to r- but don't know how. 18:46:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1498 nor, --, ---, aletheia2, ASSI, "this.buddy is undefined" on merging two IRC buddies 18:47:28 <flo-retina> Optimizer: at least half of my add-ons never pass the review, because a screenshot is required to even be allowed to request review, and I'm too lazy to find screenshots for add-ons that have no visible UI :-D 18:47:39 <aleth> Once wnayes patch is more split up it'll be easier to help review parts of it 18:47:49 --> mconley has joined #instantbird 18:47:50 <Optimizer> I think it was Show Nick + clickable channel links + mibbit style theme for irc 18:48:08 <Optimizer> what are the default settings for integrated show nicks ? 18:48:08 <flo-retina> and I've already given many review comments, so I could almost assume the patch is r- and not currently in the queue :-] 18:48:42 <flo-retina> Optimizer: what do you mean by "settings"? 18:48:58 <Optimizer> I mean, Show Nick has options to remove background color, remove border radius etc etc 18:49:01 <aleth> Optimizer: I wonder if your FF graphical timeline thing might be useful for a log viewer addon of some sort 18:49:33 <Optimizer> I am already thinking of a Console Producer 18:49:47 <Optimizer> that will capture logging information from that page. 18:50:27 <flo-retina> aleth: http://i.minus.com/iDkKASNQwG1Pr.png 18:50:41 <flo-retina> I wonder what happened to that poor "smerz1-" nick 18:50:48 <Optimizer> :( 18:50:51 <aleth> :( 18:50:53 <Optimizer> is that the default ? 18:50:57 <-- mconley has quit (Ping timeout) 18:51:04 <Optimizer> I don;t like background and radius :( 18:51:06 <aleth> Also I dislike that it's matching inside the IP string 18:51:17 <Optimizer> aleth: that will happen 18:51:24 <Optimizer> happens to mine also 18:51:25 <flo-retina> aleth: we are also matching emoticons there :( 18:51:40 <aleth> Optimizer: sounds good 18:51:55 <aleth> Optimizer: The style can be changed by the message style via CSS 18:52:00 <flo-retina> Optimizer: the background and radius are only for the Bubbles theme 18:52:06 <Optimizer> oh 18:52:31 <Optimizer> and for any other theme that does not touch that part, will the color still prevail ? 18:52:52 <aleth> flo-retina: "-" inside the nick counts as word boundary for regex? 18:53:11 <aleth> s/the/that 18:53:33 <aleth> Optimizer: The default is just coloured nick text 18:53:33 <flo-retina> aleth: I'm thinking that there's probably no word boundary between "-" and " " after the nick 18:53:39 --> mconley has joined #instantbird 18:53:56 <Optimizer> was the implementation of Show Nick directly used ? 18:53:58 <flo-retina> aleth: another sucky case is nicks like "_test_" 18:54:10 <flo-retina> because the underline is added before we look for nicks 18:54:39 <flo-retina> and that removes the "_" at the begin/end, and re-displays them using :after and :before :( 18:54:40 <Optimizer> you guys know that that kind of underline appears to be broken ? 18:55:06 <flo-retina> Optimizer: no 18:55:06 <Optimizer> as in before and after the "test" string, the underline is thicker 18:55:20 <Optimizer> as compared to the underline below the test 18:55:29 <aleth> Yes, that's not very pretty 18:55:32 <Optimizer> or is it intended ? 18:55:34 <flo-retina> Optimizer: That's the intended behavior I think 18:55:36 <aleth> But what's the alternative? 18:55:37 <-- mconley has quit (Ping timeout) 18:55:47 <Optimizer> a constant width underline ? 18:56:03 <Optimizer> by changing the position of the underline one pixel down 18:56:25 <Optimizer> _test_ 18:56:32 <flo-retina> Optimizer: it depends on the OS/font used 18:56:45 <Optimizer> there must be some css setting to set it 18:56:50 <Optimizer> without harcoding 18:58:01 --> mconley has joined #instantbird 18:58:47 <flo-retina> Optimizer: this is what I see on Mac: http://i.minus.com/ib119BcTzRthiU.png 18:59:02 <Optimizer> :( 18:59:17 <flo-retina> Optimizer: you will have to zoom a lot to see that the underlined _ characters are different from the rest of the underline 18:59:32 <aleth> You don't have to zoom much on other OS ;) 18:59:32 <Optimizer> yeah 18:59:34 <Optimizer> I see it 18:59:45 <Optimizer> there is anti aliasing 18:59:56 <flo-retina> and the difference is probably only because the anti-aliasing doesn't behave the same on the underline and the characters 19:00:03 <Optimizer> but for me, they are not overlapping 19:00:31 <aleth> Optimizer: file a patch to hide the "_"s? 19:00:40 <Optimizer> :D 19:00:48 <Optimizer> that will break copying ... ? 19:00:52 <Optimizer> also, file a patch ? 19:01:09 <flo-retina> Optimizer: "that will break copying ... ?" no 19:01:30 <Optimizer> if _ is not present, it will not get copyed 19:01:45 <aleth> Well, you know, a bug on bugzilla with patch attached ;) 19:01:51 <flo-retina> Optimizer: you can still make it 100% transparent 19:02:31 <flo-retina> ah, I also have bug 1547 in the queue :( 19:02:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1547 nor, --, ---, nobody, NEW, Check for open conversations when adding a buddy 19:03:32 <flo-retina> is bug 1743 INVALID? 19:03:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1743 enh, --, ---, rosonline, ASSI, Status Jump List of the Ubuntu Unity 19:03:56 <Optimizer> so there is no way via CSS 19:03:58 <aleth> I'm not sure yet. 19:04:20 <flo-retina> Optimizer: "so there is no way via CSS" ??? 19:04:37 <Optimizer> to match up the underscore and underline 19:04:40 <aleth> flo-retina: I suspect it is valid, but affect packaging only. But we don't have a category for that. 19:05:17 <flo-retina> aleth: so would you want to file a "package Instantbird in ubuntu" bug just to mark this one as depending on it? 19:06:00 <flo-retina> would be great if FeuerFliege could comment in https://bugzilla.mozilla.org/show_bug.cgi?id=806079 and resolve as WORKSFORME if that seems the right solution (AFAIK it couldn't be reproduced last time we discussed it) 19:06:14 <aleth> flo-retina: Should I? 19:06:50 <flo-retina> aleth: if you think it's a good way to make the guy not feel ignored, yes 19:07:09 <flo-retina> but I don't think filing a "package in ubuntu" bug in BIO will help get it packaged :( 19:07:10 <aleth> flo-retina: He is trying to set up a PPA afaik ;) 19:07:40 <flo-retina> another guy from the #frenchmoz community is also trying :) 19:07:47 <aleth> Oh good :) 19:08:00 <aleth> It would be great to get IB back into some repos 19:08:04 <flo-retina> well, no he isn't trying. He said he would try. That's quite different :-/. 19:09:32 <flo-retina> looking at https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3A1.3&list_id=3255 are bug 1219 and bug 1608 the only ones that will require strings? 19:09:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding 19:09:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1608 nor, --, ---, nobody, NEW, Replace "buddy" with "contact" in user-facing strings 19:09:44 <flo-retina> and bug 1610 but it's in the review queue already 19:09:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1610 tri, --, ---, florian, NEW, Display a correct error message in the conversation when receiving a message type=error stanza 19:10:35 <aleth> The usermode patch has strings too 19:11:00 <aleth> But it's in the queue 19:12:54 <flo-retina> wait, if there wasn't SIPE, my review queue wouldn't be longer than clokep's!!! 19:13:10 <flo-retina> bug 1751 has a string too 19:13:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1751 min, --, ---, aletheia2, ASSI, No feedback when the /nick command fails 19:15:15 * flo-retina didn't even know bug 1419 existed 19:15:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1419 nor, --, ---, aletheia2, ASSI, Handle the user's user mode 19:15:30 <aleth> You noticed the unhandled message though ;) 19:15:43 <flo-retina> and looking at the patch doesn't make it super obvious either, so I'll just assume it's making MODE awesome :-D 19:16:09 <flo-retina> is it to get rid of the unhandled +i or the unhandled numeric values (I still have no clue what they could mean)? 19:16:12 <aleth> I'm not sure MODE will ever be awesome :-/ 19:16:16 <aleth> Yes 19:16:49 <aleth> The unhandled numeric values, that'll be some other unhandled mode type 19:16:51 --> rosonline has joined #instantbird 19:17:03 <flo-retina> aleth: and do you know what they mean? 19:17:16 <flo-retina> or is that some obscure freenode-only thing? 19:17:23 <aleth> I suspect it's flood control params on freenode 19:17:48 <aleth> Next time you see it, file a bug with the full IRC message, that would help get rid of it 19:18:37 <aleth> (My guess is it's bug 1662) 19:18:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1662 nor, --, ---, nobody, NEW, Unhandled IRC MODE message: +j 19:20:46 <FeuerFliege> flo-retina: I added a comment to https://bugzilla.mozilla.org/show_bug.cgi?id=806079 but I cannot change status on BMO. 19:22:28 <flo-retina> aleth: more Show Nick failures http://i.minus.com/iucF0GjU14KVw.png :( 19:23:35 <flo-retina> maybe we should do \b|[ ,;?!.] instead of \b to reduce such failures 19:23:50 <flo-retina> for now it seems it's only nicks ending in "-" that aren't correctly detected 19:24:08 * flo-retina should file bugs 19:24:20 <aleth> Can we make /b more 'greedy'? 19:24:45 <flo-retina> I think it's built into the JS engine, so hard to change 19:24:49 <flo-retina> but we could use something else instead 19:25:00 <aleth> It might be a lot slower :-/ 19:25:12 --> EionRobb has joined #instantbird 19:25:28 <aleth> You would need [ ,.?!] but also the various brackets etc... 19:29:07 <aleth> The problem is brackets can also be part of nicks themselves 19:50:02 <instantbot> aletheia2@fastmail.fm requested review from clokep@gmail.com for attachment 2044 on bug 1723. 19:50:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1723 nor, --, ---, aletheia2, ASSI, Unhandled IRC message 328: RPL_CHANNEL_URL 19:51:09 <aleth> flo-retina: Do those - nicks match if - is escaped in the regex? 19:53:51 <aleth> Umm, ignore that. 19:54:33 <aleth> The problem is that \b is zero-width. 19:55:43 <-- FeuerFliege has quit (Ping timeout) 20:02:04 --> Mic|web has joined #instantbird 20:02:08 <Mic|web> Hi 20:10:13 <-- Mic|web has quit (Quit: http://www.mibbit.com ajax IRC Client) 20:20:05 <-- mconley has quit (Ping timeout) 20:28:44 <aleth> flo: bug 1728 has strings too 20:28:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1728 enh, --, ---, benediktp, NEW, Show mentions of tracked keywords in own conversations 20:40:34 <-- rosonline has quit (Ping timeout) 20:50:03 <instantbot> New Instantbird (UI) bug 1755 filed by aletheia2@fastmail.fm. 20:50:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1755 nor, --, ---, nobody, NEW, Provide PPA for ubuntu 20:51:55 --> FeuerFliege has joined #instantbird 20:51:58 --> rosonline has joined #instantbird 21:05:40 <-- Optimizer has quit (Ping timeout) 21:08:52 --> Optimizer has joined #instantbird 21:20:43 <flo> aleth: 1728 didn't seem to be likely ready for 1.3, but I may be wrong on that 21:23:24 <flo> FeuerFliege: thanks! :) 21:27:27 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com) 21:28:06 --> rosonline has joined #instantbird 21:36:53 <instantbot> New Core - IRC bug 1756 filed by aletheia2@fastmail.fm. 21:36:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1756 nor, --, ---, nobody, NEW, PRIVMSG parse error 21:38:05 <flo> that bug title seems scary :-S 21:54:07 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com) 21:54:12 --> rosonline has joined #instantbird 22:00:13 <flo-retina> BIO is so slow :( 22:04:25 <instantbot> New Instantbird (UI) bug 1757 filed by florian@instantbird.org. 22:04:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1757 min, --, ---, nobody, NEW, Some nicks aren't detected by Show Nick 22:07:15 <flo-retina> I'll also file a bug for the "Unused mode parameters" warnings 22:07:29 <flo-retina> and I'm afraid twitter will have to wait for another rainy day 22:07:58 --> Mic has joined #instantbird 22:07:58 * ChanServ sets mode +h Mic 22:08:00 <flo-retina> Should we email the localizers to tell them about the upcoming string freeze coming very soon? 22:08:30 <flo-retina> Mic: Good evening :) 22:08:37 <Mic> Good evening 22:08:49 <flo-retina> Mic: will you have time to finish bug 1608 soon (like today or in the next 2 days) or should I take it over? 22:09:21 <Mic> hmm, now where is the bot when you need it.. 22:09:33 <flo-retina> (I'm trying to finish asap the bugs likely to change localizable strings in 1.3) 22:09:37 <flo-retina> Mic: the bug isn't faulty 22:09:46 <flo-retina> it's BIO that takes more than a minute to reply to any request :( 22:09:48 <Mic> It's BIO as it seems 22:10:05 <Mic> Which bug is that? THe Buddy vs Contact one? 22:10:08 <flo-retina> Mic: it's the " Replace "buddy" with "contact" in user-facing strings " but that I r-'ed with trivial details 22:10:27 <Mic> OK, I can finish that tomorrow hopefully. 22:10:35 <flo-retina> "the bug isn't faulty" I meant "bot" of course :) 22:10:37 <flo-retina> ok, great :) 22:10:53 <-- FeuerFliege has quit (Ping timeout) 22:11:05 <flo-retina> I would like to string freeze Wednesday at the latest. Hopefully Tuesday evening. 22:11:50 <flo-retina> Mic: would also be nice to know if you have time for the next version of "Possible to add duplicate accounts " or if clokep should look at it. (There's probably more work there than on the buddy -> contact one) 22:12:18 <flo-retina> that one doesn't have strings though, so if it's finished within the week it's good enough :) 22:12:23 <Mic> I'd need to ask him about this bug, so I better catch him online timittow 22:12:55 <flo-retina> the sooner the better of course, but we all also have other priorities :) 22:13:01 <Mic> *tomorrow 22:13:13 * flo-retina guessed that :) 22:13:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1608 nor, --, ---, nobody, NEW, Replace "buddy" with "contact" in user-facing strings 22:14:21 <Mic> Congratulations instantbot, you're really quick :P 22:15:06 <Mic> I think I could upload a new patch for bug 958 too but I'm not sure how much fallout this bug might have. I wouldn't want to rush it in for 1.3 honestly. :( 22:15:20 <Mic> I mean I can upload it anyways of course. 22:17:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 22:19:05 <flo-retina> Mic: if you have a new patch ready, sure you can upload it 22:19:46 <flo-retina> Mic: if we want it for 1.3, it should land tomorrow I think, so that we have enough time to evaluate potential regressions and decided to back-out/turn it off if it's looking bad. 22:20:07 <flo-retina> Mic: so yes, I more or less assumed that it was too late, as I didn't think you had a new patch ready. 22:20:08 <Mic> OK 22:21:09 <aleth> I also think it's a bit risky to land 958 for 1.3 as it probably needs follow-ups to polish things 22:21:23 <aleth> But wasn't the twitter keyword tabs patch ready? 22:22:31 <flo-retina> aleth: ok, I filed a bug about the mode parameters 22:23:11 <flo-retina> I thought the twitter keyboard tabs patch was still very WIPish, but I honestly haven't looked at either of these patches recently. 22:23:11 <aleth> flo-retina: Thanks, I suspect it'll turn out to be a dupe of that other one, but we'll see. 22:23:29 <flo-retina> man, what's making BIO so slow :( 22:23:51 <flo-retina> aleth: yeah, you will be able to see the raw messages as soon as BIO wakes up 22:24:10 <flo-retina> aleth: ah, bug 1758 :) 22:24:31 <flo-retina> "load averages: 11.86, 21.81, 24.52" :( 22:24:32 <flo-retina> poor server 22:24:44 <aleth> 24.52 22:24:46 <aleth> ouch 22:24:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1758 nor, --, ---, nobody, NEW, Unused mode parameters 22:25:10 <aleth> BIO was just not built for THOUSANDS of bugs ;) 22:26:12 <instantbot> New Core - IRC bug 1758 filed by florian@instantbird.org. 22:26:13 <flo-retina> so the process sucking the CPU is "/usr/local/bin/python /mercurial/instantbird/instantbird/hgweb.cgi" :-S 22:26:15 <flo-retina> that's unexpected 22:26:36 <flo-retina> could a bot be crawling hg.instantbird.org? :-S 22:26:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1758 nor, --, ---, nobody, NEW, Unused mode parameters 22:28:29 <flo-retina> maybe I can copy http://lxr.instantbird.org/robots.txt to http://hg.instantbird.org/robots.txt ? 22:28:59 <flo-retina> done 22:29:08 <flo-retina> I don't know if it will improve the situation, but at least it shouldn't be worse :) 22:30:06 <Mic> If one of you is curious about the Twitter tabs patch, I have put the latest (untested though) on pastebin: http://pastebin.instantbird.com/95622 22:31:08 <flo-retina> Mic: why the change at line 192/193? 22:32:02 <flo-retina> (it will force twitter.properties to be read from the disk when parsing twitter.js, even if the user never looks at the advanced account preferences) 22:32:33 <Mic> I don't remember, I think it's there by accident 22:32:44 <flo-retina> ok, please revert it then :) 22:32:51 <flo-retina> otherwise, I'm surprised you need as few changes :) 22:33:11 <flo-retina> (and of course, please use a getter for the label of the other pref too) 22:33:14 <Mic> Yes, it was surprisingly easy 22:33:27 <flo-retina> maybe the code was correctly designed :) 22:33:53 <-- Optimizer has quit (Ping timeout) 22:34:01 <flo-retina> if you think this can make 1.3, please attach it in a bug and request review very soon :) 22:34:30 <Mic> It's in bug 1728 already, I'll make the changes tomorrow and request review. 22:34:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1728 enh, --, ---, benediktp, NEW, Show mentions of tracked keywords in own conversations 22:34:40 <Mic> Would you like it to go to clokep or to yourself? 22:35:03 <flo-retina> clokep 22:35:13 <flo-retina> and I'll look briefly once he's happy with it 22:35:44 <aleth> You still have bold-font-induced misaligned "." ;) 22:37:14 <flo-retina> aleth: who is the "You" in that sentence? 22:37:20 * Mic . 22:37:24 * flo-retina hopes it's not him, as he has no idea what it is 22:38:06 <Mic> My editor showed the dots of several lines perfectly aligned while the columns were actually off by one. Bold font in one of the lines and poor handling of that by the editor was the cause. 22:38:37 <Mic> aleth: I actually haven't changed that yet ;) 22:43:17 <flo> ok 22:43:30 * flo doesn't have time to troll about editors at the moment :) 22:47:05 <-- meh has quit (Quit: I don't want to live on this planet anymore.) 22:50:35 <flo-retina> aleth: are these messages all about +j? 22:55:01 <aleth> flo-retina: Some are, some I'm not sure about at first glance. 22:55:45 <flo-retina> "324 testib #ubuntu +CLcntjf 5:10 #ubuntu-unregged" seems to be +j and +f 22:55:56 <aleth> BIO still "down" 22:56:11 <flo-retina> and +/- q is also an issue 22:56:20 <flo-retina> aleth: I know :( 22:56:33 <aleth> Yes, MODE is the gift that keeps on giving ;) 22:56:50 <flo-retina> any idea of what to do with a server in that situation? 22:57:19 <aleth> Nope :( See if any particular connection is causing a lot of traffic? 22:57:26 <flo-retina> "load averages: 34.04, 35.38, 26.39" 22:57:50 <flo-retina> still all /usr/local/bin/python /mercurial/instantbird/instantbird/hgweb.cgi ... 22:58:23 <aleth> But who's using it? 23:00:27 <flo-retina> we don't seem to have a lot of requests made to that virtual host :( 23:02:26 <aleth> Then you can just restart that process? 23:02:37 <aleth> Or is that a tricky thing to do? 23:03:26 <flo-retina> it's "Mozilla/5.0 (compatible; bingbot/2.0; +http://www.bing.com/bingbot.htm)" 23:03:28 <flo-retina> pfff 23:04:00 --> passager has joined #instantbird 23:04:00 <aleth> huh :( 23:04:16 <passager> bonjour 23:04:59 <flo-retina> passager: hello :) 23:05:07 <aleth> ^^ interesting that bingbot is using gecko? 23:05:21 <EionRobb> nah, everything says they're Mozilla compatible these days 23:05:24 <flo-retina> what makes you feel it's gecko? 23:05:34 <passager> peut-on régler les couleurs des bulles 23:05:41 <aleth> Just guessing from the Mozilla ID string 23:07:26 <aleth> passager: Only by modifying the message style (which you can do fairly easily) 23:08:00 <aleth> flo-retina: But I don't really know how to interpret that string other than the bingbot part, so.. 23:09:15 <aleth> passager: Of course for normal conversations you can change the colours also from Preferences (by changing the Variant) 23:09:42 <Mic> aleth: do you think it's possible to support user icons on IRC (for private messages) somehow? 23:09:58 <flo-retina> using gravatar? 23:10:09 <aleth> Mic: Where would you get them from? 23:10:11 <passager> ah ok thank you for the info 23:11:02 <passager> and I would like to use Instantbird togheter in a mozilla browser package in a ram only distro 23:11:30 <passager> can I mix both in the same dir to avoid repetition of libraries? 23:12:56 <Mic> aleth: no idea, maybe there's an IRC extension thingie that allows to do that? 23:13:12 <aleth> Mic: you'd have to ask clokep... I've never heard of one. 23:13:29 <passager> IRC ist well: it is part of Seamonkey / Iceape 23:13:45 <passager> by instant messaging through Yahoo etc. not 23:13:48 <aleth> Supporting gravatar (with an add-on?) might work of course. 23:14:47 <flo-retina> it's a party, there's also "Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)" and "Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)" having fun 23:17:41 <aleth> gtg 23:17:54 <-- aleth has quit (Input/output error) 23:20:23 <flo-retina> \o/ 23:20:36 <flo-retina> my .htaccess works, these requests all receive 403 replies immediately now 23:20:56 <flo-retina> load averages: 9.69, 27.26, 30.00, but it should go down soon 23:21:58 <flo-retina> ah, YandexBot is in the party too 23:23:48 <flo-retina> we have Googlebot-Image too 23:24:03 <flo-retina> I wonder what happened so that all these bots jump on that poor server at the same time 23:24:59 <flo-retina> the load average is down to < 1 23:25:04 <flo-retina> I think BIO should be responsive again 23:26:14 --> DGMurdockIII has joined #instantbird 23:27:00 <flo-retina> bing is also indexing our l10n repositories 23:27:08 <flo-retina> and I also see some spammers having fun with pastebin 23:35:15 <flo-retina> Good night 23:35:17 <-- flo-retina has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 23:36:28 <-- flo has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 23:38:39 <-- passager has quit (Client exited) 23:40:02 --> mconley has joined #instantbird 23:42:45 <-- gerard-majax has quit (Ping timeout) 23:53:39 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 17.0/20121031065642]) 23:59:02 <EionRobb> did someone make a change to the .htaccess just recntly? 23:59:24 <EionRobb> whoever did it stuffed up hg links https://hg.instantbird.org/instantbird/file/9386af0e4bc6/purple/purplexpcom/src/purpleTimer.cpp#l54