#instantbird log on 11 02 2012

All times are UTC.

00:00:00 <florian1> and who's committed to finishing what
00:00:44 <clokep> I think so.
00:01:12 <florian1> the crazy pad was https://etherpad.mozilla.org/ib-1-3
00:01:36 <florian1> let's say https://etherpad.mozilla.org/ib-1-3-plan is the real plan :)
00:03:20 <clokep> Yeah, the first one became "Let's actually write down everything!!!"
00:03:30 <florian1> that was brainstorming :)
00:03:44 <florian1> I'm sad that "Show context from logs (Bug 958)" isn't read
00:03:47 <florian1> *ready
00:03:47 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
00:04:04 <clokep> I'd really like SASL to be done, but besides that I'm not sure...
00:04:21 <florian1> and "Account.xml / account manager revamp (bug 1219)" is really something we should have done.
00:04:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1219 tri, --, ---, nobody, NEW, Cleanup the account.xml binding
00:04:35 <florian1> can I volunteer aleth to do it? :-P
00:04:45 <clokep> He tends to do things I volunteer him for. ;)
00:05:01 <clokep> But those are usually trivial. :)
00:05:10 <florian1> this one is relatively trivial too
00:05:44 <florian1> bah, https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3A1.3&list_id=3209 is long :(
00:06:43 * florian1 volunteers clokep for bug 1698
00:06:48 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1698 nor, --, ---, nobody, NEW, NickServ help message eaten for no good reason
00:07:00 <florian1> uh, bug 1610 isn't fixed?
00:07:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1610 tri, --, ---, nobody, NEW, Display a correct error message in the conversation when receiving a message type=error stanza
00:07:22 <clokep> Apparently not?
00:08:15 <florian1> the status of bug 1608 isn't clear, but it looks like something we should do
00:08:18 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1608 nor, --, ---, nobody, NEW, Replace "buddy" with "contact" in user-facing strings
00:09:03 <florian1> what should I change the whiteboard to for bugs that obviously won't make 1.3 but are marked 1.3-wanted?
00:09:11 <florian1> 1.4-wanted?
00:09:56 <clokep> 1.4-wanted, yes.
00:10:24 * clokep would kind of like bug 1712 to land too, but maybe that's ambitious.
00:10:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1712 enh, --, ---, clokep, ASSI, Send long IRC messages in several parts
00:10:46 <florian1> bug 1592 is confusing to me
00:10:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1592 nor, --, ---, nobody, NEW, glib version requirements bad
00:10:58 <florian1> isn't bug 1712 landing tomorrow?
00:12:14 <clokep> florian1: If I finish it, I guess.
00:12:38 <florian1> my review comments there can be addressed in less than 5 minutes
00:13:01 <clokep> OK. :)
00:13:20 <florian1> https://bugzilla.instantbird.org/buglist.cgi?quicksearch=sw%3A1.3&list_id=3209 should now be more realistic
00:13:22 <clokep> Bugspam!
00:14:05 <florian1> I wonder if I should reply to stupid review of the "Addition Chat protocols for Thunderbird" add-on
00:14:08 <florian1> the latest one is " Nice but doesn't do Skype (Pidgin does) and I have a problem with Google Talk because I'm using two factor authentication and this extension doesn't handle that!"
00:15:03 <clokep> Maybe?
00:16:58 <EionRobb> lol
00:17:16 <florian1> "Let's stop reviewing this add-on for what it doesn't have, and start reviewing it for what it does have." was a nice review though :-D.
00:17:51 <florian1> EionRobb: just in case you didn't know, the add-on is completely unrelated to XMPP/Gtalk (that's shipped by default in Thunderbird).
00:18:07 <EionRobb> even funnier :)
00:18:19 <florian1> the stupidest review though is "This add on is not working at all for me, only the default IM are appearing in my set up wizard. Dunno why. Was thinking that it was corrupted because the file i downloaded was 2.9mb and the size shown on this page is 9.2mb."
00:18:35 <EionRobb> lol
00:18:50 <florian1> he knows his download is corrupted, but he doesn't know why it doesn't work, and instead of downloading again he will post a negative review
00:18:53 <EionRobb> maybe I should write a review regarding file transfers ;)
00:19:08 <florian1> EionRobb: that one already exists ;)
00:19:11 <EionRobb> "I am downvoting this add-on due to its poor reviews and lack of file transfers"
00:19:14 <florian1> "is it possible to send a file with yahoo or MSN protocol like yahoo messenger or pidgin it will be awesome, thinks a lot ......"
00:19:15 <clokep> AMO users are almost as bad as YT users. :(
00:19:16 <EionRobb> "I have yet to use it"
00:19:36 <florian1> clokep: YT?
00:20:02 <clokep> florian1: YouTube.
00:20:14 * clokep goes to read florian1 review comments.
00:20:15 <florian1> ah, yes :)
00:27:10 <florian1> clokep: do you know what's up with bug 1113? I don't even remember what it's about
00:27:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1113 nor, --, ---, nobody, NEW, Twitter should start from the last read tweet
00:28:13 <clokep> florian1: One second.
00:30:46 <clokep> florian1: So that bug was about if you start Instantbird, don't read any messages and restart it, it doesn't reshow the Tweets that were previously shown.
00:31:03 <florian1> ah
00:31:10 <clokep> Because we mark them as "read" when they're downloaded, not when they're actually read.
00:31:13 <florian1> that sucks, but it's consistent with IRC
00:31:24 <clokep> I think it's WONTFIX, implement infinite scroll.
00:31:28 <clokep> You can see them in the log viewer.
00:31:37 <florian1> ok, wontfix
00:31:45 <florian1> I was going to suggest removing the 1.3-wanted annotation
00:31:51 <florian1> but if you want to wontfix, go ahead
00:34:22 <clokep> Yeah...I don't know how we'd fix it.
00:34:30 <clokep> It's kind of hard to know if someone "read" something or not. :(
00:35:54 <florian1> hmm, can I say that cleaning up the mess in the error console is also 1.3-wanted? :-]
00:36:23 <florian1> I'd like to get rid of the dozens of "Warning: received presence stanza for unknown buddy" I see
00:36:48 <florian1> and I think there was a Bonjour issue that was also worth fixing
00:36:53 <florian1> but I don't remember exactly what it was
00:37:31 <florian1> bug 1717
00:37:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1717 nor, --, ---, nobody, NEW, JS errors when a Bonjour buddy disconnects
00:37:44 <clokep> florian1: We should get rid of that new Moz 16 warning too.
00:38:01 <florian1> is that the one about mutation observers?
00:39:11 <clokep> Yes.
00:39:36 <clokep> florian1: So you say "I don't understand what aMessage.params[1].lastIndexOf(" ") is here": It's parsing the 001 response message.
00:39:59 <florian1> what's aMessage.params[1] ?
00:40:23 <florian1> it's possible it would have made sense if I had looked at the code around, but I didn't bother lxr'ing
00:40:44 <florian1> that review comment isn't really a request for a change, except if you feel that a comment would be appropriate in the code at that position
00:41:27 <clokep> aMessae.params[1] is "Welcome to the Internet Relay Network <nick>!<user>@<host>"
00:41:56 <florian1> is that string standard?
00:42:12 <clokep> I think so.
00:42:21 <clokep> I'm not super OK with parsing it that way...
00:43:00 <florian1> clokep: "aMessae.params[1] is "Welcome to the Internet Relay Network <nick>!<user>@<host>"" maybe you should include that as a comment
00:43:14 <clokep> florian1: It's a comment 4 lines above that line.
00:43:48 <florian1> ok, then r- for not setting the defaults correctly in your .hgrc :-P
00:44:16 <florian1> you should have http://pastebin.instantbird.com/92962
00:44:53 <florian1> or is that not taken into account by mq (or whatever you used to generate the patch)?
00:45:23 <clokep> It shold be....
00:45:31 <clokep> (It uses export still.)
00:49:11 <instant-buildbot> build #338 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/338
00:51:09 <florian1> https://bugzilla.instantbird.org/attachment.cgi?id=1942&action=diff is likely r+ out of exhaustion (ie. I don't see anything wrong, but I'm not super confident in my ability of spotting tricky details at this time, and this has waited for too long already), so if you want to look at it before I r+, feel free :) 
00:52:08 <clokep> Loading...
00:52:26 <florian1> bugzilla is slow for me too :(
00:53:04 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2027 on bug 1712.
00:53:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1712 enh, --, ---, clokep, ASSI, Send long IRC messages in several parts
00:53:41 <clokep> florian1: I had looked at that a while ago and was OK w/ the changes, but I don't have a feel about whether it'll speed stuff up. :)
00:53:42 <florian1> buildbot is sucking the server's CPU
00:54:20 <clokep> Ahhhh.
00:54:28 <florian1> seems to have quieted down now
00:54:28 * clokep shakes first at instant-buildbot.
00:54:57 * florian1 shakes second at instant-buildbot
00:54:59 * Mook_as wonders if aBuddy.color can be 0
00:55:21 <clokep> Ah, reassign r? to Mook_as!
00:55:37 <Mook_as> r- I hate the world
00:56:53 <-- jb has quit (Ping timeout)
00:57:20 <Mook_as> hmm, the nicks list is guaranteed to be sorted?
00:57:31 <florian1> clokep: it blocks the work on integrating Show Nick, so I would rather r? to someone who will r+ (maybe with a few comments that make sense)
00:57:40 <Mook_as> (in a way compatible with the lowercasing, anyway?)
00:57:44 <clokep> Ahhhh. I see.
00:58:44 <florian1> Mook_as: http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#1077
00:58:50 <florian1> looks a lot like it can be 0
00:59:11 <florian1> were you asking that question because of the "if (!aBuddy.color)" test?
00:59:15 <Mook_as> yep!
00:59:23 <florian1> testing colorStyle instead should do, right?
00:59:45 <Mook_as> or !== undefined, or (possibly) ("color" in aBuddy)
01:01:50 <Mook_as> so, yeah, having some comment somewhere saying that the nicks list is sorted by (lower case) alphabetical order would be nice
01:02:13 <Mook_as> O
01:02:26 <clokep> Looks like we tricked Mook_as into reviewing it. ;)
01:02:30 <florian1> "Array of lowercase nicks kept in the order of the nicklist." isn't this what you are talking about?
01:02:36 <Mook_as> err, I'm not sure what happens if two nicks have the same initial character though, in https://bugzilla.instantbird.org/attachment.cgi?id=1942&action=diff#a/chrome/instantbird/content/instantbird/conversation.xml_sec7
01:02:44 <Mook_as> oh, I didn't know what order the _nicklist_ is in
01:02:52 <Mook_as> so knowing that it was the same order wasn't helpful :)
01:03:15 <florian1> ok, so you mean r- for confusing comment ^^
01:04:08 <Mook_as> or "see comment at X for that order", except worded something less silly
01:04:23 <florian1> what's relying on the initial character?
01:04:49 <Mook_as> is the sort not using the... oh, nevermind, it's an array with more things in it, not a string
01:05:00 <Mook_as> (the sort, a[0] and b[0])
01:05:09 <-- Optimizer has quit (Ping timeout)
01:05:10 <Mook_as> because it's name, and buddy
01:05:27 <florian1> right
01:05:28 <Mook_as> yeah, ignore that part. (unless you want to make it be an object with nice named properties instead)
01:05:48 <florian1> I want, but I think someone said it was slower, or something
01:06:12 <Mook_as> ooh, build is done. and it seems to work. time to go home. bye!
01:06:14 <-- Mook_as has quit (Quit: gone)
01:09:13 --> Optimizer has joined #instantbird
01:14:46 <clokep> florian1: There's something to be said for readability though...
01:15:25 <florian1> is that about using an object with named properties instead of an array?
01:20:29 <clokep> Yes.
01:20:29 <instantbot> florian@instantbird.org denied review for attachment 1942 on bug 1686.
01:20:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1686 nor, --, ---, aletheia2, ASSI, Nicklist speedup: low-hanging fruit
01:21:28 <florian1> clokep: I don't understand "the maxMessageLength is for both incoming and outgoing messages."
01:23:48 <clokep> It is used both for messages that we might be sending to the server and for calculating a message the server might be sending to someone else.
01:23:56 <clokep> Our nick only comes into play for the latter.
01:24:16 <clokep> I don't know if we're using it for outgoing messages at all yet, but we should be.
01:25:05 <florian1> oh, do you mean for the length of the /who commands we send? (or whatever it is we send periodically to refresh the buddy statuses)
01:25:16 <clokep> ISON, yes.
01:25:20 <clokep> Exactly.
01:25:32 <clokep> But that command we can squeeze more into because we don't care about our nick/user/host.
01:25:52 <florian1> that's an internal detail
01:26:06 <florian1> the value I was talking about is the one that's exposed to the UI through XPCOM
01:26:20 <clokep> That changes per conversation.
01:26:28 <florian1> I know
01:26:37 <florian1> I was just asking if we shouldn't try to do a better approximation
01:26:51 <florian1> but the right fix is to change the interfaces to have that exposed per conversation
01:26:58 <florian1> (is that filed btw?)
01:27:09 <florian1> or does it even matter for IRC, now that we are able to split messages?
01:27:34 --> mconley has joined #instantbird
01:28:32 <clokep> It probably doesn't really matter for IRC, although it could be nice to know.
01:28:42 <clokep> And yes, we could do a better approx., but I think that's a different bug. :)
01:29:23 <instantbot> florian@instantbird.org granted review for attachment 2027 on bug 1712.
01:29:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1712 enh, --, ---, clokep, ASSI, Send long IRC messages in several parts
01:29:34 <florian1> ok, I'll check this in and then go to bed
01:29:53 <clokep> I'll file that new bug and close all the bugs.
01:29:57 <clokep> Thanks for the review. :)
01:30:26 <florian1> if it doesn't matter of IRC, we may not need another bug
01:30:36 <florian1> (or maybe we want to remove the value completely if it's now irrelevant?)
01:30:57 <clokep> Bingo.
01:31:11 <clokep> I think...
01:31:23 <florian1> should I test that the tests are still OK before pushing?
01:31:37 <clokep> Hmm...probably. I did test them, but only on Windows.
01:32:44 <florian1> bah, test_purplexpcom.js fails here
01:32:51 <clokep> :-/
01:33:06 <florian1> but the new test passes, so I'll push anyway :)
01:33:47 <florian1> http://pastebin.instantbird.com/93001
01:35:11 <clokep> Sweet. Thanks.
01:35:27 <florian1> doesn't that look familiar?
01:35:28 --> jb has joined #instantbird
01:35:43 <clokep> Yes. :(
01:35:53 <instantbot> clokep@gmail.com set the Resolution field on bug 1712 to FIXED.
01:35:56 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1712 enh, --, 1.3, clokep, RESO FIXED, Send long IRC messages in several parts
01:36:45 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/c2e1ebde9ee1 - Patrick Cloke - Bug 1712 - Send long IRC messages in several parts, r=fqueze.
01:41:41 <florian1> ah, bug 1730 may also want to be fixed for 1.3
01:41:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1730 blo, --, ---, florian, ASSI, Fix compilation of purple/ with glib 2.32 and newer
01:43:43 <-- micahg has quit (Ping timeout)
01:45:31 <florian1> Good night
01:46:35 <instant-buildbot> build #339 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/339
01:50:41 <instant-buildbot> build #308 of macosx-onCommit is complete: Exception [exception interrupted]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/308  blamelist: Florian Qu?ze <florian@queze.net>
01:50:51 <florian1> I stopped the mac onCommit in the hope of having a nightly tomorrow: )
01:53:46 <clokep> Goodnight! :P
01:56:39 --> skeledrew1 has joined #instantbird
01:56:46 <-- skeledrew has quit (Ping timeout)
01:58:16 * clokep is now known as clokep_
02:13:24 <-- mconley has quit (Input/output error)
02:14:19 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2028 on bug 1573.
02:14:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
02:19:44 <clokep_> Mic: Can you update the shared searches to be 1.3 instead of 1.2?
02:21:00 --> Mook has joined #instantbird
02:27:30 <instant-buildbot> build #326 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/326
02:29:42 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2029 on bug 1698.
02:29:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1698 nor, --, ---, clokep, ASSI, NickServ help message eaten for no good reason
02:33:26 <instantbot> clokep@gmail.com set the Resolution field on bug 1113 to WONTFIX.
02:33:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1113 nor, --, ---, nobody, RESO WONTFIX, Twitter should start from the last read tweet
02:39:30 <instantbot> clokep@gmail.com granted review for attachment 2014 on bug 1742.
02:39:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1742 nor, --, ---, nobody, UNCO, Add Odnoklassniki protocol
02:42:45 <clokep_> Bah Bugzilla is crawling...
02:46:17 <Mook> hmm, --^ would probably benefit from locale-specific protocol settings
02:47:38 <clokep_> What specific setting?
02:48:10 <Mook> that thing you just r+ed probably isn't as useful outside Cyrillic-using countries?
02:48:26 <-- jb has quit (Ping timeout)
02:48:38 <Mook> or at least, Russian-ish language using countries. I'm not very clear about how those languages work...
02:53:30 <clokep_> What's your point?
02:53:51 <clokep_> (Yes, you're right. but I'm not sure what "settings" you're talking.)
02:53:59 <Mook> umm, that it's good for a subset of users, but not all of them?
02:54:12 <Mook> oh, I just meant "protocols, but having one per xmpp server is silly"
02:55:03 <clokep_> Yeah, I'm not planning to have one per XMPP server, just the really popular ones.
02:55:28 <clokep_> I think what you're trying to ask is "Why are we shipping that protocol with en-US?".
02:55:30 <clokep_> Yes?
02:55:35 <Mook> that, too.
02:55:54 <Mook> hmm, I wonder if the new account dialog could present the user name field before selecting protocol, and do something smart there
02:56:10 <clokep_> If you don't ship a protocol with all localizations funky stuff will happen if you move between different localizations...which doesn't matter, except if someone switches to a nightly which is only available in en-US.
02:56:20 <clokep_> You don't want them to all of a sudden have missing protocol plug-ins.
02:56:27 <Mook> ah, right. bleh.
02:56:39 <clokep_> I'd like it if (for XMPP and IRC) we could be a bit smarter about it and provide a list of "networks" as well as the protocol.
02:57:00 <Mook> yeah, my worry there is that xmpp users will have no idea what networks mean :)
02:57:23 <clokep_> Right so...if you consider users are stupid they won't know what XMPP is and you should list them at the top level. ;)
02:57:35 <EionRobb> we called them "xmpp/irc services" in the pidgin stats plugin ;)
02:57:41 <clokep_> FWIW Some localizations can show those in the "Top Protocol" list, while they won't be for en-US.
03:05:26 <instantbot> New Instantbird (UI) bug 1750 filed by clokep@gmail.com.
03:05:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1750 min, --, ---, nobody, NEW, Warning: Use of Mutation Events is deprecated. Use MutationObserver instead.
03:05:45 <Mook> oh yeah, I need one of those for komodo as well
03:07:29 * clokep_ hopes aleth handles that one. :-D
03:17:22 --> jb has joined #instantbird
03:18:24 <-- clokep_ has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
03:23:44 <-- jb has quit (Ping timeout)
03:32:51 <-- Optimizer has quit (Ping timeout)
03:34:38 <instant-buildbot> build #673 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/673
03:36:06 --> Optimizer has joined #instantbird
03:49:59 <-- Gizmokid2005 has quit (Ping timeout)
03:52:08 --> jb has joined #instantbird
03:53:36 --> Gizmokid2005 has joined #instantbird
03:54:12 <-- jb has quit (Ping timeout)
03:57:06 <instant-buildbot> build #327 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/327
04:09:27 --> DGMurdockIII has joined #instantbird
04:09:50 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 17.0/20121023124120])
04:27:22 <-- EionRobb has quit (Quit: Leaving.)
04:52:41 --> jb has joined #instantbird
04:54:51 <-- jb has quit (Ping timeout)
05:19:44 --> wesj1 has joined #instantbird
05:20:50 <-- wesj1 has quit (Quit: wesj1)
05:30:26 --> jb has joined #instantbird
05:33:40 <-- jb has quit (Ping timeout)
06:00:27 <instant-buildbot> build #761 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/761
06:45:46 --> wesj1 has joined #instantbird
06:46:14 <-- wesj1 has quit (Quit: wesj1)
06:51:47 <-- Mook has quit (Quit: Mook)
07:14:41 --> FireFly_TB has joined #instantbird
07:45:07 --> meh has joined #instantbird
07:45:48 <-- FireFly_TB has quit (Ping timeout)
08:06:08 <-- gerard-majax_ has quit (Ping timeout)
08:08:54 <-- Optimizer has quit (Ping timeout)
08:12:49 --> Optimizer has joined #instantbird
08:14:04 --> Mic has joined #instantbird
08:14:04 * ChanServ sets mode +h Mic 
08:39:49 <Mic> Hi!
09:11:33 --> FireFly_TB has joined #instantbird
09:14:13 <-- Mic has quit (Ping timeout)
09:42:49 <-- FireFly_TB has quit (Ping timeout)
09:43:32 <-- Optimizer has quit (Ping timeout)
09:48:30 --> Optimizer has joined #instantbird
10:02:10 --> Mic has joined #instantbird
10:02:10 * ChanServ sets mode +h Mic 
10:17:56 --> clokep has joined #instantbird
10:17:56 * ChanServ sets mode +o clokep 
10:21:02 <clokep> Uhhhh...that mailing list email about wanting to send email? (o_O)
10:23:00 --> gerard-majax_ has joined #instantbird
10:24:23 <clokep> Hello Mic, did you see https://etherpad.mozilla.org/ib-1-3-plan? :)
10:25:12 <-- florian1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
10:27:50 <Mic> clokep: can you do check-ins now? :O You have this item in your section...
10:29:00 <clokep> Mic: No, I can't.
10:29:09 <clokep> And it's not in my section, there's a line break! :D
10:35:10 <Mic> I'll update the searchs, by the way. Thanks for the reminder
10:35:33 <clokep> Thank you! :)
10:35:38 <clokep> I've resorted to having to do my own searches. =-o
10:44:05 --> flo-retina has joined #instantbird
10:44:05 * ChanServ sets mode +qo flo-retina flo-retina 
10:44:27 * flo-retina is now known as florian1
10:49:48 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 2028 on bug 1573.
10:49:49 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2030 on bug 1573.
10:49:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
10:51:38 <clokep> Yay bit-rotting my own code. ::(
10:57:21 * clokep thinks aleth is going to hate him...
10:57:22 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 2030 on bug 1573.
10:57:23 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2031 on bug 1573.
10:57:24 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
11:01:08 * florian1 wonders what clokep has done that's so horrible
11:02:14 <clokep> florian1: I pulled an aleth and attached three patches in a row without review in between. :) Two in quick succession!
11:03:49 <clokep> So nothing "so horrible".
11:06:51 <clokep> Your nickserv help bug was an easy five minute fix btw. :) I was scared that was going to be a WTF bug...
11:09:26 <-- clokep has quit (Ping timeout)
11:10:47 <-- Optimizer has quit (Ping timeout)
11:11:59 <florian1> clokep: it really seemed like a "trivial mistake" bug, but probably faster to debug for someone who already knows that code well ;).
11:14:08 --> Optimizer has joined #instantbird
11:33:15 <-- Optimizer has quit (Ping timeout)
11:37:09 --> Optimizer has joined #instantbird
11:50:07 --> clokep_work has joined #instantbird
11:50:07 * ChanServ sets mode +o clokep_work 
11:50:21 --> mikk_s has joined #instantbird
11:50:43 <clokep_work> You know...a great way to get me to add an IRC feature is to have me start using a server that requires it...
11:52:32 <Mic> clokep_work: do you still have the plan to add typing notifications to IRC one day? :D
11:53:10 <Mic> Just as random thought..
11:53:15 <clokep_work> Mic: I'd like to.
11:53:26 <clokep_work> It frequently bothers me when typing to individuals.
11:53:35 <clokep_work> Not that I talk to /that/ many individuals on IRC...
11:54:44 <florian1> and these individuals probably have gtalk anyway ;)
11:56:33 <-- mikk_s has quit (Client exited)
11:57:34 <clokep_work> Yeah...I don't talk to them over GTalk though. :P
12:03:43 <Mic> Brace yourself, a patch is coming...
12:04:23 <florian1> for typing notifications? :)
12:04:34 <clokep_work> florian1: I'm confused, did https://bugzilla.mozilla.org/show_bug.cgi?id=799068 land for Thunderbird 18?
12:04:41 <clokep_work> Which is comm-aurora, right?
12:04:41 <Mic> No, for bug 1511
12:05:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
12:05:36 <florian1> clokep_work: I think it landed on comm-central on the merge day.
12:06:03 <florian1> so it landed in 18 while it was still on central for a few minutes.
12:06:09 <instantbot> benediktp@ymail.com requested review from clokep@gmail.com for attachment 2032 on bug 1511.
12:06:12 <florian1> (and could include string changes for 18)
12:08:49 <clokep_work> florian1: Hmm...OK.
12:08:55 <clokep_work> Trying to figure out that email you sent me...
12:08:58 <florian1> clokep_work: still confused?
12:09:03 <florian1> ah
12:10:24 <florian1> it looks a lot to me like http://mxr.mozilla.org/comm-central/source/chat/modules/jsProtoHelper.jsm#411 would want a try { } catch(e) { Components.utils.reportError(e); }
12:10:42 <florian1> so that we would have the correct location information in the error console, and not make the low level prpl code fail
12:11:20 <clokep_work> Mmmm....probably.
12:14:49 <clokep_work> Is BIO really slow for everyone else still too? :-S
12:18:30 <Mic> Yep
12:19:43 <clokep_work> Mic: I'll just kill the f? flo rian flag on that patch and add it to the v2, K?
12:19:51 <clokep_work> Doh, I stilled pinged him. :(
12:19:55 <Mic> Sure
12:21:04 <clokep_work> Mic: Did you ever try it this way: https://bugzilla.instantbird.org/show_bug.cgi?id=1511#c17
12:21:07 <instantbot> Bug 1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
12:24:02 <Mic> No
12:25:09 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 2032 on bug 1511.
12:25:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
12:25:29 <instantbot> clokep@gmail.com cancelled feedback?(florian@instantbi rd.org) for attachment 1963 on bug 1511.
12:27:30 --> jb has joined #instantbird
12:30:17 <Mic> Offtopic but awesome: http://arstechnica.com/gaming/2012/11/indie-dev-remaking-descent-with-modern-graphics-sound/ :o
12:30:45 <Mic> I always liked this game (especially the first one)
12:31:59 <clokep_work> Never played that. :(
12:50:34 <Mic> When should 1.3 be released by the way?
12:50:56 <instantbot> benediktp@ymail.com granted review for attachment 2026 on bug 1746.
12:50:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1746 nor, --, ---, aletheia2, ASSI, Recent shortcut change eschews cursor shortcuts to moves tabs instead
12:51:21 <clokep_work> "soon" ;)
12:51:32 * clokep_work was assuming in the next couple of weeks.
13:01:06 <florian1> Mic: we want to release before Moz16 is outdated, so before November 20
13:02:00 <florian1> Mic: so we would want to release between November 13 and November 15 I think
13:02:07 <florian1> and string freeze early next week
13:05:54 <clokep_work> If it affects anything, I'm away Nov. 8th to Nov...14th, so don't expect reviews from me in that period. ;)
13:06:16 <florian1> does away mean "in a different timezone" or "offline"?
13:06:57 <florian1> clokep_work: it's the same error that we had in https://bugzilla.mozilla.org/show_bug.cgi?id=790539
13:07:19 <florian1> I think the real error is TypeError: item is undefined and the IRC code isn't at fault here
13:07:32 <clokep_work> florian1: I'll be in UTC, probably offline...unless I steal someone's computer.
13:07:55 <florian1> UTC ? Does that mean UK?
13:07:59 <clokep_work> Yes.
13:08:04 <florian1> Maybe you can go to Mozilla London to steal a computer there :-P
13:08:06 <clokep_work> florian1: What is "item" in this case?
13:08:15 <florian1> clokep_work: something from the Tb UI?
13:08:23 <clokep_work> Maybe. Or just show up at Standard8's house? ;)
13:08:38 <florian1> as I said, we would need a try { } catch(e) { Components.utils.reportError(e); } to have correct location info
13:08:45 <clokep_work> Right. :)
13:09:13 <florian1> clokep_work: is it for vacations or for business?
13:09:23 <clokep_work> florian1: Vacation, visiting a friend going to school in England.
13:09:39 <clokep_work> I Just got a reply to that question about emails: "No, no emails , like emails – like PSI instant messenger." :-S
13:09:55 <florian1> I'm surprised that you have vacations from a Thursday to a Wednesday, but why not :)
13:10:50 <clokep_work> She has classes on Thursday, so it's a block of contiguous time. ;)
13:11:02 <clokep_work> I'm actually off from work that Monday anyway. So I'm just taking a really long weekend?
13:11:29 <-- Optimizer has quit (Ping timeout)
13:12:13 <florian1> so you will be in vacations and "at home" (or at least in your usual timezone) from Monday 5 to Wednesday 7?
13:12:19 <florian1> (or have I completely misunderstood? :))
13:12:54 <clokep_work> Complete misunderstood. ;) I have Monday the 12th off from work.
13:13:09 <clokep_work> I'm traveling from Thursday night on the 8th till Wednesday night of the 14th.
13:13:23 <clokep_work> So I extended my three day weekend by 4 extra days. ;)
13:13:43 <florian1> ah
13:13:49 <florian1> is Monday 12th a holiday in the US?
13:15:04 --> Optimizer has joined #instantbird
13:15:04 <florian1> so you will be at work on the 7th and the 15th?
13:15:43 <clokep_work> Veteran's Day, government offices and schools usually close, not everyone is off though. My company happens to close for it.
13:15:54 <clokep_work> Yup, and part of the 8th most likely...if I packed ahead of time. ;)
13:15:54 <-- jb has quit (Ping timeout)
13:17:06 <florian1> so. When do you suggest we string freeze, and release? :)
13:17:35 <clokep_work> Don't do it around my schedule! I'm not important for this. :P
13:17:59 * florian1 wants to let you write the release notes :-P
13:18:15 <clokep_work> florian1: I think the 15th sounds pretty good. :)
13:18:25 <clokep_work> The week after that is Thanksgiving in the US, if we care.
13:18:43 <florian1> which day is that?
13:19:46 <florian1> Mic: is there any chance of bug 958 being ready soon?
13:19:49 --> FireFly_TB has joined #instantbird
13:19:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows
13:20:11 <Mic> I haven't looked at it in ages, I can try to find some time for it this afternoon
13:20:45 <florian1> Mic: would be nice to at least look enough to estimate if it will take an hour or two to finish or if it still needs several weeks :)
13:23:40 --> FeuerFliege has joined #instantbird
13:25:28 <clokep_work> florian1: 15th is a Thursday, thanksgiving is the Thursday after that.
13:25:54 <florian1> so 22 and 23 are holidays in the US?
13:26:11 <florian1> (is black Friday a holiday?)
13:27:20 <florian1> in France in November we only have the 1st and the 11th (which is a Sunday this year... :()
13:28:35 <clokep_work> Most people have off the Friday also, I don't personally...but I'm taking it off.
13:28:45 <clokep_work> (Also that Wednesday. ;) Traveling again...)
13:29:11 <clokep_work> bug 1737 sounds sucky. :(
13:29:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1737 nor, --, ---, nobody, NEW, Setting a chatroom to auto-join should preserve my handle
13:30:02 <florian1> clokep_work: it also sounds WONTFIX/INVALID.
13:30:13 <florian1> clokep_work: although if the guy attaches a correct patch I may accept it.
13:30:38 <clokep_work> florian1: Because you should try to join the same room a second time?
13:30:57 <florian1> because you should go to the account properties and cleanup the mess yourself
13:31:21 <florian1> that's obviously suboptimal UX, but like all the auto-join thing in general...
13:31:32 <clokep_work> Yeah...
13:34:14 <florian1> clokep_work: so the thing that the user on the mailing list requests very confusingly is likely the <message type="normal"> defined at http://xmpp.org/rfcs/rfc3921.html#rfc.section.2.1.1
13:34:31 <florian1> we only support type=chat and type=groupchat (and indent to suck less with type="error" soon)
13:34:58 --> mconley has joined #instantbird
13:34:59 <clokep_work> "indent"?
13:35:16 <florian1> *intend
13:35:47 <clokep_work> Ah! :)
13:35:50 <clokep_work> I see...
13:36:09 <florian1> I've never seen a reason for type="normal" to be useful
13:36:44 <florian1> I don't even understand what a UI where "the user is expected to reply but without seeing a conversation history" could be
13:37:35 <clokep_work> I don't know. :( Maybe after you reply the conversation goes away? :P
13:37:57 <florian1> it seems a lot like email, and I don't see a reason for sending that through XMPP
13:38:27 <florian1> the user on the mailing list mentions PSI, so I assumed he was requesting an XMPP feature.
13:39:01 <clokep_work> Mmhmm, that makes sense.
13:50:54 --> jb has joined #instantbird
14:02:56 <-- Kaishi has quit (Quit: Kaishi)
14:03:02 --> Kaishi has joined #instantbird
14:04:23 * florian1 looks forward to someone removing http://lxr.instantbird.org/instantbird/source/instantbird/content/utilities.js
14:04:25 <-- Optimizer has quit (Ping timeout)
14:08:16 --> Optimizer has joined #instantbird
14:21:04 * florian1 dislikes the situation in https://bugzilla.mozilla.org/show_bug.cgi?id=736169
14:30:08 <-- Optimizer has quit (Ping timeout)
14:30:22 <-- jb has quit (Ping timeout)
14:33:30 --> Optimizer has joined #instantbird
14:57:08 <-- Kaishi has quit (Quit: Kaishi)
15:09:58 <-- FireFly_TB has quit (Quit: blubb blubb)
15:11:49 --> wesj1 has joined #instantbird
15:17:20 <clokep_work> florian1: Yes, that sucks... :(
15:18:47 <-- Optimizer has quit (Ping timeout)
15:21:30 --> rosonline has joined #instantbird
15:22:33 --> Optimizer has joined #instantbird
15:29:22 <Mic> If I'd want an r-, I could use a "break label;" somewhere, right? ;)
15:30:33 --> jb has joined #instantbird
15:32:40 <-- FeuerFliege has quit (Ping timeout)
15:33:41 <-- wesj1 has quit (Ping timeout)
15:33:41 <florian1> Mic: you can r- your own patches if you want, you don't need help for getting an r- ;)
15:36:38 --> FeuerFliege has joined #instantbird
16:01:53 <florian1> http://i.imgur.com/nsEiV.jpg
16:02:05 <florian1> next step: conversations in the floating chat windows :)
16:07:43 --> DGMurdockIII has joined #instantbird
16:31:58 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
16:35:18 <-- rosonline has quit (Ping timeout)
16:39:35 --> rosonline has joined #instantbird
16:53:22 --> Mook_as has joined #instantbird
16:53:40 <clokep_work> Congrats florian1! :)
16:55:39 <instantbot> aletheia2@fastmail.fm granted review for attachment 2029 on bug 1698.
16:55:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1698 nor, --, ---, clokep, ASSI, NickServ help message eaten for no good reason
17:01:03 --> aleth has joined #instantbird
17:01:04 * ChanServ sets mode +h aleth 
17:01:08 <-- aleth has quit (Input/output error)
17:01:09 --> aleth has joined #instantbird
17:01:10 * ChanServ sets mode +h aleth 
17:01:49 <aleth> clokep_work: Do you have a link to some documentation for the NICKSERV command? How widely supported is it?
17:02:02 <clokep_work> aleth: I have no documentation to that or identify.
17:03:25 <aleth> It's not a general feature of Nickserv implementations newer than version x?
17:04:20 <florian1> clokep_work: will you survive without an RFC to point to?
17:04:26 <florian1> clokep_work: or are you going to write one?
17:04:44 <clokep_work> florian1: It hurts a bit.
17:04:51 <clokep_work> aleth: I'm not sure what you mean.
17:04:58 <clokep_work> It's how the server interacts with services.
17:05:09 <clokep_work> "NickServ" is just the user facing implementation of the services.
17:06:29 <aleth> Maybe I'm confused, but we seem to be communicating with Nickserv without using DMs. And we had those long debates about how to ensure Nickserv is actually Nickserv, a problem which this command would seem to make unnecessary
17:06:47 <clokep_work> Yes, it makes it unnecessary.
17:06:53 <clokep_work> I had no idea those commands existed.
17:07:04 <clokep_work> (The server returns an "Unknown command" if services aren't registered)
17:07:34 <aleth> Great :) Though without documentation kind of limited in its usefulness I guess...
17:08:19 <aleth> Unless we can just assume it's a direct subsitute for DMs to Nickserv, which would be great
17:09:30 <clokep_work> I think it is...
17:09:43 <clokep_work> I can try that easily enough. One second
17:10:08 <clokep_work> aleth: /quote NICKSERV help
17:10:13 <clokep_work> That works so....
17:10:14 <aleth> Sounds like we can improve our Nickserv support quite a bit then ;)
17:10:27 <clokep_work> Parsing the returned stuff is just a PITA, but yes! :)
17:10:36 <clokep_work> ChanServ works too. :)
17:10:39 <clokep_work> At least on MozNet.
17:11:00 <aleth> :)
17:11:48 <aleth> Freenode too, it seems
17:12:52 <clokep_work> aleth: From what I'm googling/reading "everything" supports them.
17:13:04 <clokep_work> So I think we can just /try/ to use them and just make sure we catch the error fairly nicely.
17:13:24 <aleth> Yes. If it fails we're no worse off.
17:13:53 <clokep_work> That's kind of my thought too.
17:14:03 <clokep_work> Is that satisfactory or would you like me to find something more concrete? :)
17:14:47 <aleth> No, I just didn't quite believe the implicit good news, and got suspicious when I couldn't find any docs ;)
17:14:52 * florian1 would like something "concrete" in the form of a patch :-)
17:15:08 <clokep_work> aleth: http://www.stack.nl/~jilles/irc/charybdis-oper-guide/configlines.htm#AEN1671 explains it a bit.
17:15:34 <clokep_work> florian1: RESOLVED INCOMPLETE, Be more specific!
17:15:45 * aleth wonders if we can get the server to send us a list of aliases
17:15:59 <clokep_work> Now, now. Don't be ridiculous.
17:16:20 * aleth sighs
17:16:33 <florian1> clokep_work: when I type "/nick florian" I don't receive any feedback. :(
17:17:42 <clokep_work> florian1: Where do you expect feedback?
17:18:14 <clokep_work> It shuld be printed in every conversation: http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#939
17:18:23 <clokep_work> And I'm fairly certain that works...
17:19:42 <florian1> clokep_work: where I typed it
17:19:56 <florian1> clokep_work: I mean, when it fails
17:21:48 <clokep_work> florian1: Ah, I see.
17:21:50 <clokep_work> File a bug. ;)
17:23:12 <florian1> fair enough :)
17:23:32 <instantbot> New Core - IRC bug 1751 filed by florian@instantbird.org.
17:23:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1751 nor, --, ---, nobody, NEW, No feedback when the /nick command fails
17:24:12 <clokep_work> When our nick fails don't we try variations until it succeeds anyway? :-S
17:25:01 <florian1> clokep_work: no
17:25:12 <florian1> clokep_work: that's only when the nick we tried to login with was already taken
17:25:20 <clokep_work> Ahhhh, right. That makes more sense. :)
17:27:21 <aleth> clokep_work: How about having a services account variable somewhere that assumes initially NICKSERV, CHANSERV etc exist, but removes them from the list after we get unknown command back, so we don't then try again
17:28:05 <clokep_work> aleth: Yes, that's probably a good idea, but I think it's only necessary if we're going to be using a few different commands?
17:28:36 <aleth> Do we expect to?
17:28:36 * clokep_work kind of wonders whether the 4(5? 2?)1 response that handles IDENTIFY not existing and calls the NICKSERV IDENTIFY command should be in the ircServices handler...
17:28:58 <clokep_work> aleth: It can be added if we add more.
17:29:01 <clokep_work> As part of that patch.
17:29:05 <clokep_work> Let's not over engineer things. :)
17:29:06 <aleth> Ok.
17:29:34 <aleth> I was thinking more of remembering if Nickserv exists for now
17:29:51 <clokep_work> I don't think that's necessary in that patch unless we have some reason to remember that it exists.
17:30:13 <clokep_work> Ooooo....wait, this means we can auto-re-identify!
17:30:24 <aleth> ^^ exactly what I was just typing :)
17:30:26 <clokep_work> (NOT as part of that patch!)
17:30:31 <aleth> Sure.
17:30:43 <aleth> It's not at all related 
17:30:52 <aleth> (to SASL that is ;) )
17:30:58 <clokep_work> Yes. :)
17:31:16 <clokep_work> r+ then? :)
17:31:36 <aleth> I need to actually take a look at it first ;)
17:31:57 <aleth> But I'm glad we can ditch PASS :D
17:32:35 <clokep_work> Someone will probably complain they can't get into a server and we'll need to add it back... ;)
17:32:46 <clokep_work> (Which means someone will need to implement the "masked" option in the UI :P)
17:34:16 <aleth> What does that do?
17:35:41 * aleth is now known as flo1
17:35:46 <clokep_work> It's supposed to make it a password field.
17:36:14 * flo1 is now known as aleth
17:36:48 <-- aleth has quit (Quit: Au revoir)
17:36:50 --> aleth has joined #instantbird
17:36:50 * ChanServ sets mode +h aleth 
17:37:51 <aleth> florian1: What do you mean by "the nick change fails" if not that there was a collision?
17:38:10 <florian1> aleth: I think there's a collision
17:38:51 <aleth> If there's a collision, you'll be told your new (modified) nick though
17:39:02 <florian1> ah, no
17:39:24 <aleth> E.g. I just /nick flo'd and was told I was now flo1
17:40:22 <florian1> what's the alternative to imgur again? :)
17:40:28 <aleth> minus?
17:40:38 <florian1> I think it sends NICK florian and then NICK florian1 which is already what I have
17:41:02 <clokep_work> If should then try florian2.
17:41:40 <florian1> http://i.minus.com/ib0ASAxs21v9la.png
17:42:03 <florian1> I suspect we abort changing the nick to the current nick
17:42:35 <clokep_work> Ah, I see what you're saying.
17:42:54 <clokep_work> The expected thing to do in this case is to end up sa florian1 still, right?
17:43:11 <aleth> That's what happens
17:43:11 <florian1> right
17:43:14 <clokep_work> (You just want an error message "Florian is in use, you're already florian1!"
17:43:18 <florian1> but I still have no feedback
17:43:44 <florian1> right, "florian is in use, keeping florian1" or something like that
17:43:58 <florian1> it's a corner case though :)
17:44:15 <clokep_work> Handling corner cases is what make good software. ;)
17:44:18 <aleth> You should maybe add it to the bug description ;)
17:44:39 <florian1> aleth: are you likely to find time to work on that account.xml cleanup bug soon?
17:44:44 <clokep_work> Yeah that should be pretty straightforward to do.
17:44:57 <florian1> would be nice to have the changes to "disconnect" an account while offline, so that it doesn't reconnect when back online
17:44:57 <aleth> florian1: I doubt it. Not next week for sure.
17:45:03 <florian1> :(
17:45:11 <florian1> ok
17:45:20 <aleth> Sorry...
17:45:40 <aleth> Yes, that bug was 1.3 wanted :-(
17:45:48 <florian1> one of the rare things I would look forward to having in 1.3
17:50:30 <-- clokep_work has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
17:50:50 <-- gerard-majax_ has quit (Ping timeout)
17:52:20 <florian1> aleth: maybe "not next week" means "this week"? :-D
17:52:48 <florian1> although in the immediate future, I would prefer a version of the nicklist patch ready to check-in to unblock the Show Nick work
17:53:30 <aleth> Yes, I'll fix those nits asap.
17:53:54 <florian1> I've slept since I wrote that comment, but I think they are trivial :)
17:55:11 <aleth> Btw how about landing (or otherwise) bug 1096 before it becomes even more ancient?
17:55:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1096 nor, --, ---, aletheia2, ASSI, Add "Visible tags..." entry to contacts listbox background context menu too
17:55:31 <aleth> Afaik you thought it needed some testing in nightlies
17:56:28 <florian1> I think it's in the "I feel r- but can't find any reason for it" basket, and has been there for too long
17:56:46 <florian1> actually, it's probably "I vaguely remember I felt" rather than "I feel" ;)
18:05:04 <florian1> http://i.minus.com/iGfKHrfGU2isq.png \o/
18:07:26 --> gg0 has joined #instantbird
18:09:09 <-- florian1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
18:17:35 <-- FeuerFliege has quit (Ping timeout)
18:26:08 <aleth> flo: wow, that didn't take long :)
18:26:46 <-- aleth has quit (Connection reset by peer)
18:28:08 --> aleth has joined #instantbird
18:28:09 * ChanServ sets mode +h aleth 
18:32:08 --> clokep has joined #instantbird
18:32:08 * ChanServ sets mode +o clokep 
18:43:18 --> gerard-majax_ has joined #instantbird
18:46:14 <-- flo has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
18:46:51 <-- jb has quit (Ping timeout)
18:55:38 <-- rosonline has quit (Ping timeout)
18:57:42 --> micahg has joined #instantbird
19:01:46 --> jb has joined #instantbird
19:58:16 --> Kaishi has joined #instantbird
20:09:10 <clokep> aleth: http://pastebin.instantbird.com/93704
20:10:21 <aleth> You fixed it? :)
20:10:39 <clokep> aleth: No, it still looks like crap. But maybe you have magical CSS fingers. :)
20:10:40 <aleth> That was quick...
20:10:51 * aleth has trial and error
20:11:23 <clokep> aleth has patience? ;)
20:12:28 <aleth> or I ask Mic ;)
20:12:38 <clokep> Haha. :)
20:12:44 <clokep> But you were curious so I figured I'd show you.
20:12:49 <clokep> I can send you a screenshot too if you want.
20:13:13 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 2033 on bug 1686.
20:13:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1686 nor, --, ---, aletheia2, ASSI, Nicklist speedup: low-hanging fruit
20:13:30 <aleth> clokep: Looks like the right thing to do... probably the secret is in the tweaking of colours etc
20:13:51 <clokep> aleth: I think it's mostly center is too small.
20:16:46 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
20:19:46 <aleth> clokep: I have a userchrome somewhere that colours the tabs also
20:20:34 <-- clokep has quit (Ping timeout)
20:20:46 <aleth> Populating #ubuntu pre-patch: ~1000ms, after-patch: ~500ms
20:22:13 --> clokep has joined #instantbird
20:22:13 * ChanServ sets mode +o clokep 
20:22:14 <-- clokep has quit (Input/output error)
20:24:17 --> clokep has joined #instantbird
20:24:17 * ChanServ sets mode +o clokep 
20:31:19 <-- jb has quit (Ping timeout)
20:37:50 <-- clokep has quit (Ping timeout)
20:41:51 --> jb has joined #instantbird
20:41:59 --> clokep has joined #instantbird
20:41:59 * ChanServ sets mode +o clokep 
20:42:54 <-- jb has quit (Connection reset by peer)
20:54:26 --> jb has joined #instantbird
20:55:40 <-- deltafalcon has quit (Connection reset by peer)
20:56:53 <-- jb has quit (Ping timeout)
20:57:51 <instantbot> aletheia2@fastmail.fm denied review for attachment 2031 on bug 1573.
20:57:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
21:00:27 <aleth> clokep: my old userchrome https://i.minus.com/jbx7bnrSyx4AoL.png
21:07:03 <clokep> aleth: That looks fairly nice. :)
21:07:39 <aleth> I think the app tab glow style would probably be better though.
21:07:53 <clokep> It flows into the tabbar better IMO.
21:08:10 <aleth> Yes.
21:08:33 <aleth> and it's already associated with "unread messages"
21:08:37 <clokep> aleth: Thanks for the review.
21:08:41 <-- Optimizer has quit (Ping timeout)
21:08:47 <aleth> We'd probably have to switch blue and red though...
21:09:09 <clokep> I've said that a lot anyway. ;)
21:09:09 --> Optimizer has joined #instantbird
21:09:18 <aleth> clokep: I'm not sure about the ircServices thing, just wanted to flag it up.
21:09:33 <clokep> I didn't read the full thing yet btw. :)
21:10:23 <clokep> I think I agree w/ most of your comments, yes. :)
21:10:50 <aleth> Lets get it into nightlies asap so it gets lots of testing :)
21:19:52 <-- mconley has quit (Ping timeout)
21:22:50 <clokep> aleth: Do you think the 001 response should be in ircServices or just 421?
21:24:31 <aleth> clokep: We'd have to reportConnected from ircServices then, so I think it's probably less confusing as is.
21:24:40 <clokep> aleth: Why?
21:24:52 <clokep> We can just handle it the one issue and return false and let the other handler do it's magic.
21:25:28 <aleth> Right, that's true :)
21:25:42 <clokep> aleth: Something like http://pastebin.instantbird.com/93747
21:25:42 <aleth> sendMessage doesn't exactly depend upon reportConnected ;)
21:25:54 <clokep> aleth: Uhhh more like http://pastebin.instantbird.com/93748
21:26:06 <aleth> Yes, looks good.
21:28:04 <clokep> aleth: I like having those in ircServices, it puts a lot more of the auth code all in one place. :)
21:28:11 <aleth> Yes :)
21:28:47 * clokep tests it...
21:28:49 * clokep is now known as clokep_
21:31:02 <clokep_> If I can find the right profile. :(
21:31:03 * clokep_ sighs.
21:33:40 <clokep_> aleth: Is "Whether the user has successfully authenticated with NickServ."
21:33:41 <clokep_> Good enough?
21:33:59 <aleth> Sounds good to me
21:34:13 <-- aleth has quit (Quit: Au revoir)
21:34:26 --> aleth has joined #instantbird
21:34:26 * ChanServ sets mode +h aleth 
21:35:41 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2034 on bug 1573.
21:35:45 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
21:35:56 <clokep_> I need this patch so staticbox stops annoying me to auth. ;)
21:39:29 <aleth> I still think we should handle 421 for the NICKSERV command too (just return true).
21:39:50 <clokep_> Hmm...
21:40:07 <clokep_> Should we error and say "Failed all auth methods" or something or return true?
21:40:22 <aleth> Hmm...
21:40:30 <aleth> Good point.
21:41:15 <aleth> Won't Nickserv complain anyway if the user fails to auth correctly?
21:41:24 <clokep_> Yes. :)
21:41:48 <aleth> We should maybe LOG(Nickserv command does not exist) or sth 
21:42:53 <clokep_> Hm. OK.
21:42:58 <clokep_> So demanding...
21:44:22 <aleth> heh :P
21:44:32 <aleth> I didn't ask for extra comments ;)
21:44:36 <clokep_> aleth: http://pastebin.instantbird.com/93759 or shoudl we not care about password, etc. in that situation?
21:45:05 <aleth> I would drop the password etc and the reference to authentication from the string, keep it general.
21:45:48 <aleth> You don't need the 'else' btw
21:46:12 <aleth> (though if you prefer...)
21:47:06 <-- aleth has quit (Quit: Au revoir)
21:47:14 --> aleth has joined #instantbird
21:47:14 * ChanServ sets mode +h aleth 
21:48:50 <-- skeledrew1 has quit (Ping timeout)
21:55:26 <clokep_> aleth: I wonder if it should be a warn instead of a log. :-S
21:56:45 <aleth> Maybe... especially if we really believe it will never happen ;)
21:56:56 <aleth> It should probably email us :P
21:58:26 <aleth> You're right, WARN is better.
21:58:28 <aleth> naively copying some of the FF app tab css looks a bit odd: https://i.minus.com/jbczgjydFoCRbH.png
22:01:10 <-- aleth has quit (Input/output error)
22:01:12 --> aleth has joined #instantbird
22:01:12 * ChanServ sets mode +h aleth 
22:02:00 --> flo-retina has joined #instantbird
22:02:00 * ChanServ sets mode +qo flo-retina flo-retina 
22:04:20 <flo-retina> I should checkin https://bugzilla.mozilla.org/show_bug.cgi?id=806581 for Instantbird too I guess
22:09:24 <instantbot> florian@instantbird.org granted review for attachment 2033 on bug 1686.
22:09:31 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1686 nor, --, ---, aletheia2, ASSI, Nicklist speedup: low-hanging fruit
22:10:07 <clokep_> aleth: http://pastebin.instantbird.com/93773
22:11:35 <aleth> clokep_:  Looks good :) I was wondering about servers that don't have Nickserv, but then users shouldn't be trying to authenticate :P 
22:11:50 <clokep_> aleth: Then users are screwed and oh well.
22:12:02 <aleth> Yup.
22:13:19 <instantbot> clokep@gmail.com cancelled review?(aletheia2@fastmail. fm) for attachment 2034 on bug 1573.
22:13:20 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 2035 on bug 1573.
22:13:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
22:15:11 <flo-retina> clokep_: were there more things you wanted to check in bug 1511 or is it ready to go?
22:15:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
22:15:21 <flo-retina> (I just reviewed the patch and I don't see anything wrong)
22:15:47 <clokep_> flo-retina: I greatly dislike that patch.
22:16:28 <flo-retina> ah?
22:16:30 <clokep_> I think comment #7 has a way that I /think/ would be clearer.
22:16:48 <clokep_> But besides that, I think it is fine, yes.
22:17:01 <clokep_> Ah comment #17: https://bugzilla.instantbird.org/show_bug.cgi?id=1511#c17
22:17:43 <clokep_> I find it a little bit too "magical".
22:17:56 <clokep_> But I don't intend to object too greatly to it.
22:17:56 <instantbot> aletheia2@fastmail.fm granted review for attachment 2035 on bug 1573.
22:17:59 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
22:18:02 <clokep_> :)
22:18:26 <clokep_> aleth: You look forward to having something you shouldn't notice? ;)
22:18:35 <flo-retina> clokep_: oh, so your concern is the duplication in the case of IRC?
22:18:57 <clokep_> flo-retina: I think it does a poor job of abstracting out the part that might be "difficult" for a protocol implementer.
22:19:15 <aleth> clokep_: I think not noticing anything about auth would be just perfect :D
22:19:32 <clokep_> :)
22:19:39 <clokep_> Well with that and the other patch about NickServ...we should be well on the way!
22:19:44 <flo-retina> clokep_: FWIW it's really not how I would have implemented it.
22:20:07 <-- aleth has quit (Quit: Au revoir)
22:20:16 --> aleth has joined #instantbird
22:20:16 * ChanServ sets mode +h aleth 
22:20:16 <flo-retina> clokep_: I would have kept in the protocol instance an array of all accounts created for that protocol, and iterated only over that array
22:20:43 <flo-retina> so that in case of a protocol without any account, the answer would be O(0) instead of O(n) with n the total number of accounts configured
22:21:14 <clokep_> Hmm....yeah.
22:21:20 <Mook_as> is n ever expected to be large?
22:21:26 <clokep_> I'm not too concerned about that though. Unless people like you have 1000000 accounts. ;)
22:21:33 <flo-retina> that may be over optimization though, as with n < 20, I don't think it makes a visible difference
22:22:01 <flo-retina> Mook_as: no. That's why I was about the r+ the patch.
22:23:21 <flo-retina> but now I'm thinking that it's obviously not doing a good job for GTalk, as we now support gtalk accounts without '@'...
22:23:49 <clokep_> :) Why I asked for r? for you!
22:25:40 <flo-retina> so. Decision. Should we take this (as it's already a significant improvement compared to the current situation), or r- for a new version that handles gtalk correctly (and maybe follow what you said, we we will now have 3 copies of the code iterating over the list of accounts)
22:26:27 <clokep_> I would prefer an r-.
22:26:57 <clokep_> If we want it for 1.3 and Mic doesn't have time, I'll finish it.
22:27:06 <clokep_> Since apparently my list of contributions for 1.3 was just completed. ;)
22:29:03 <aleth> clokep_: You could review that ungainly usermode patch :P
22:29:20 <flo-retina> clokep_: "} else if (aMessage.cap.subcommand == "ACK") {" don't we usually \n before "else"?
22:29:52 <clokep_> flo-retina: Not in any of the IRC code.
22:29:56 <flo-retina> I otherwise don't understand anything in that patch, and don't think I should spend time on it, so I'll assume it's awesome, and file bugs if I discover in the next nightly that it isn't :)
22:30:36 <clokep_> flo-retina: For some reason all the IRC code is in "my" style, where I don't do a line break before else statements...I don't know why we allowed that. :P
22:31:06 <aleth> all the IRC code, apart from the bits that I added, probably ;)
22:31:12 <flo-retina> clokep_: http://pastebin.instantbird.com/93794
22:31:26 <clokep_> flo-retina: Fine....you win.
22:31:32 <flo-retina> the only missing line break is "chat/protocols/irc//irc.js:388:        } else"
22:31:34 <clokep_> I'm late to get sushi with some friends though.
22:31:56 <clokep_> So, I can fix it tomorrow or you can make that change before checking it in.
22:32:00 <clokep_> (And to irc.js:388)
22:32:06 <flo-retina> clokep_: ok, feel free to r- the accountExists patch
22:32:19 <flo-retina> clokep_: go get sushi!
22:32:19 <clokep_> flo-retina: I'll do it when I have comments to write. :)
22:32:23 <flo-retina> I'll deal with the checkins
22:32:44 <-- DGMurdockIII has quit (Connection reset by peer)
22:38:56 <instantbot> florian@instantbird.org denied review for attachment 2032 on bug 1511.
22:38:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
22:40:03 * flo-retina wonders if anybody is interested in taking over bug 1730
22:40:07 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1730 blo, --, ---, florian, ASSI, Fix compilation of purple/ with glib 2.32 and newer
22:42:10 <flo-retina> the patch in bug 1573 doesn't apply because the README file that is modified doesn't exist in the repository
22:42:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1573 enh, --, ---, clokep, ASSI, Support SASL for IRC
22:43:53 --> jb has joined #instantbird
22:50:10 <flo-retina> the patch from bug 1746 doesn't apply
22:50:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1746 nor, --, ---, aletheia2, ASSI, Recent shortcut change eschews cursor shortcuts to moves tabs instead
22:51:10 <flo-retina> there's an #endif at the line just before :(
22:51:41 <aleth> gah, #preprocessors. Sorry.
22:54:13 <-- jb has quit (Quit: jb)
22:54:42 --> jb has joined #instantbird
22:58:30 <-- Optimizer has quit (Ping timeout)
23:02:17 --> Optimizer has joined #instantbird
23:07:32 <flo-retina> the patch from bug 1727 fails too
23:07:35 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1727 min, --, ---, aletheia2, ASSI, Separate strings for channel and user mode system messages
23:08:13 <aleth> Has it been bitrotted by some of the other IRC patches?
23:09:11 <flo-retina> because someone fixed the typo on this line "The paramter is the message.parted.reason, if a part message is given."
23:10:19 <aleth> I think it was one of the patches that got piled up while the tree was broken...
23:13:55 <flo-retina> aleth: in bug 1492, the real API change is the target-purple-conversation-changed notification, right?
23:13:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1492 min, --, ---, aletheia2, ASSI, Rename purpleConversation -> prplConversation where appropriate
23:14:52 <flo-retina> everything else seems just unexposed variable/parameter names
23:15:17 <aleth> Yes, I think that was all.
23:15:40 <aleth> I'd be surprised if that patch hasn't bitrotted though.
23:16:49 <flo-retina> it has
23:17:02 <flo-retina> but that's probably my fault :-[
23:17:14 <-- aleth has quit (Input/output error)
23:18:00 <flo-retina> can I just search&replace purple->prpl in imConversations.js ?
23:18:02 * flo-retina assumes yes
23:20:39 --> wizzrobe has joined #instantbird
23:27:32 <-- jb has quit (Ping timeout)
23:36:54 <-- ecmuller has quit (Connection reset by peer)
23:36:54 <-- Mook_as has quit (Ping timeout)
23:37:09 --> Mook_as has joined #instantbird
23:41:26 --> ecmuller has joined #instantbird
23:42:13 <instantbot> florian@instantbird.org granted review for attachment 2016 on bug 833.
23:42:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=833 enh, --, ---, bugi, ASSI, Add access keys menu bar items
23:44:35 <instantbot> florian@instantbird.org granted review for attachment 2019 on bug 1694.
23:44:36 <instantbot> florian@instantbird.org granted review for attachment 2020 on bug 1694.
23:44:38 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1694 enh, --, ---, aletheia2, ASSI, Use twitter icon for twitter tabs
23:57:55 <-- Optimizer has quit (Ping timeout)