#instantbird log on 10 19 2012

All times are UTC.

00:09:55 <-- AlexanderSalas has quit (Ping timeout)
00:37:13 <-- GeekShadow has quit (Ping timeout)
00:39:57 --> GeekShadow has joined #instantbird
01:17:51 <-- Mook_as has quit (Quit: Mook_as)
01:31:36 --> deOmega has joined #instantbird
01:32:13 <deOmega> Mic:  Thank you very much for reviewing the addon
01:32:50 <deOmega> I was just cleaning out my Yahoo email (I pretty much never use it) and saw your message in there
01:33:54 <deOmega> Note:  I was just trying to change my instantbird addon site email address t something I actually use, but when I click on teh emailed confirmation link...I get an error
01:34:10 <clokep> What's the error?
01:34:13 <deOmega> Error!
01:34:14 <deOmega> Invalid confirmation code!
01:34:43 <clokep> Hmmm....interesting. Is the link to the right website?
01:34:48 <deOmega> i clicked on the link as well as copied and pasted it into the browser and same thing
01:34:48 <-- chrisccoulson has quit (Quit: Ex-Chat)
01:35:08 <deOmega> i can post the link here?
01:35:25 <deOmega> or pm it?
01:35:27 <clokep> PM it to me.
01:36:18 <deOmega> just seemed strange
01:36:33 <clokep> Yeah that's weird...
01:37:03 <clokep> Let me see if I can do anything in the admin interface...
01:37:04 <deOmega> I see the addon is getting used also.  Thanks for the compliment Mic.
01:37:09 <deOmega> ok
01:37:34 <clokep> Ah I can change the email.
01:38:17 <deOmega> Thank you
01:38:32 <clokep> OK you should be all set?
01:38:37 <clokep> Idk if it'll send you a confirmation or what...
01:38:56 <deOmega> awesome.  no confirmation but I will go into teh account and see what it has listed
01:40:20 <deOmega> worked great
01:40:34 <clokep> :) Great!
01:40:36 <deOmega> i had to log out and log back in with that new email so  thank you clokep
01:40:49 <clokep> deOmega: Of course. Glad to be of service. :)
01:41:21 <deOmega> 7 daily users of the addon...  for me that is as much as 70000. :)
01:41:39 <clokep> :)
01:43:11 <deOmega> have a great evening.  I have still be having  relatively little time to play around.  
01:43:45 <clokep> Me too. :(
01:44:20 <-- deOmega has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
01:59:06 <-- Optimizer has quit (Ping timeout)
02:02:30 --> Optimizer has joined #instantbird
02:48:43 <-- clokep has quit (Ping timeout)
03:08:24 --> Mook has joined #instantbird
03:34:55 --> wesj1 has joined #instantbird
03:49:43 <-- wesj1 has quit (Quit: wesj1)
03:58:44 <-- wnayes has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
04:10:57 <-- Optimizer has quit (Ping timeout)
04:14:11 --> Optimizer has joined #instantbird
05:08:32 <-- douglaswth has quit (Ping timeout)
05:09:41 --> douglaswth has joined #instantbird
05:18:45 --> FeuerFliege has joined #instantbird
05:22:30 --> jb has joined #instantbird
05:28:31 --> jb1 has joined #instantbird
05:29:56 <-- jb has quit (Ping timeout)
05:48:47 <-- EionRobb has quit (Quit: Leaving.)
06:06:32 --> Mook-trying-stuff-please-ignor has joined #instantbird
06:06:55 <-- Mook-trying-stuff-please-ignor has left #instantbird ()
06:25:40 <instant-buildbot> build #654 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/654
06:31:45 <-- Optimizer has quit (Ping timeout)
06:35:10 --> Optimizer has joined #instantbird
07:02:23 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
07:04:21 --> FeuerFliege has joined #instantbird
07:05:30 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
07:05:51 --> FeuerFliege has joined #instantbird
07:06:44 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
07:17:22 <-- Optimizer has quit (Ping timeout)
07:19:24 <-- Mook has quit (Quit: Mook)
07:19:33 <-- jb1 has quit (Ping timeout)
07:20:11 --> Optimizer has joined #instantbird
07:20:47 <-- gerard-majax has quit (Ping timeout)
07:24:52 <-- Optimizer has quit (Ping timeout)
07:28:34 --> Optimizer has joined #instantbird
07:46:01 --> FeuerFliege has joined #instantbird
07:46:10 --> FeuerFliege_VM has joined #instantbird
07:46:31 * FeuerFliege_VM is now known as test|1
07:47:36 --> jb has joined #instantbird
07:47:43 <-- jb has quit (Input/output error)
07:47:46 --> jb has joined #instantbird
07:53:03 <-- jb has quit (Input/output error)
07:53:06 --> jb has joined #instantbird
07:53:23 <-- jb has quit (Write error: Broken pipe)
07:53:40 --> jb has joined #instantbird
07:54:36 <-- jb has quit (Input/output error)
07:54:40 --> jb has joined #instantbird
07:55:15 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
07:56:35 --> FeuerFliege has joined #instantbird
07:59:03 <-- jb has quit (Input/output error)
07:59:06 --> jb has joined #instantbird
08:07:45 --> gerard-majax has joined #instantbird
08:18:32 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
08:34:24 --> chrisccoulson has joined #instantbird
08:34:32 <-- chrisccoulson has quit (Client exited)
08:36:15 --> FeuerFliege has joined #instantbird
08:40:21 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
08:41:05 --> FeuerFliege has joined #instantbird
08:46:52 <instantbot> bugi@media.fjmail.de requested review from clokep@gmail.com for attachment 1989 on bug 1108.
08:46:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
08:47:59 --> meh has joined #instantbird
08:52:21 <-- test|1 has quit (Input/output error)
09:11:52 <-- jb has quit (Ping timeout)
09:16:40 <-- sabret00the has quit (Quit: Leaving)
09:23:17 --> FeuerFliege_VM has joined #instantbird
09:31:19 <-- FeuerFliege has quit (Input/output error)
09:35:44 --> jb has joined #instantbird
09:38:27 <-- florian has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
09:52:43 <-- jb has quit (Input/output error)
09:52:47 --> jb has joined #instantbird
09:55:49 --> jb1 has joined #instantbird
09:56:06 <-- jb has quit (Ping timeout)
09:56:12 <-- jb1 has quit (Input/output error)
09:56:16 --> jb has joined #instantbird
10:16:27 --> clokep has joined #instantbird
10:16:27 * ChanServ sets mode +o clokep 
10:18:36 <clokep> Good morning!
10:23:18 * clokep wishes he had interdiff...
10:25:19 --> flo-retina has joined #instantbird
10:25:45 * flo-retina is now known as florian
10:28:12 * clokep doesn't have a build to test bug 1108 on right now...:-/
10:28:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1108 min, --, ---, bugi, ASSI, Names of folder and files are not checked against forbidden names.
10:34:14 <clokep> florian: I put up my WIP for Mozilla 16, I probably wont' have time to work on it until Sunday, the earliest. I'm stuck at something complaining about no rule to make xml.lib.desc required by xml.lib (I think?)
10:34:47 <florian> was that the error you pastebined yesterday?
10:35:05 <clokep> No, the one I pasted bin yesterday I fixed.
10:35:15 <clokep> Let me see if I can get it...
10:35:43 <florian> I can try to work on it tonight
10:35:47 <clokep> florian: http://pastebin.instantbird.com/86156
10:36:13 <clokep> I'm guessing it's just another change in the config directory?
10:36:20 <clokep> But I looked for a little while and couldn't find anything...
10:36:25 <florian> probably something missing in config.mk or rules.mk, yes
10:37:01 <clokep> I also realized it's possible that it isn't necessarily a new change...just something we never had. :)
10:37:31 <clokep> Luckily though our config/rules.mk is pretty close to c-c (if not identical?) so I was able to apply some patches from c-c directly. :)
10:37:57 <florian> :)
10:38:24 <florian> it should be identical when our build system is up to date (it isn't)
10:38:51 <clokep> Ah, well that might answer my next question of...can we just copy & paste the moz 16 files from c-c?
10:40:08 <florian> no
10:40:54 <florian> when taking changes to these files, you often need to port at the same time changes to instantbird/app/ or instantbird/locales/Makefiles.in or instantbird/installer/
10:41:56 <clokep> Ooooo, I see.
10:42:05 <clokep> It's possible I missed some of those changes in things I already ported then btw.
10:42:24 <clokep> But all the mozbugs are listed in that bug...
10:42:54 <florian> usually when I port changes from c-c, I look at the whole changeset that made the changes
10:43:35 <clokep> I was, but I assumed most of it wasn't necessary.
10:44:19 <clokep> Yeah the ones I ported one just touched config.mk and the other config/rules.mk + other things that we don't have copies of (expandlibs, etc.)
10:45:05 <florian> what's expandlibs?
10:45:38 <clokep> expandlibs.py expandlibs_deps.py _exec, _gen https://bugzilla.mozilla.org/attachment.cgi?id=626715&action=diff
10:46:26 <florian> that's the m-c changeset, not c-c
10:47:36 <clokep> Yeah.
10:48:19 <clokep> https://bugzilla.mozilla.org/attachment.cgi?id=631669&action=diff looks like it is the c-c version.
10:48:56 --> FeuerFliege has joined #instantbird
10:48:58 <instantbot> bugi@media.fjmail.de requested review from florian@instantbird .org for attachment 1990 on bug 833.
10:49:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=833 enh, --, ---, bugi, ASSI, Add access keys menu bar items
10:49:39 <florian> clokep: so you ported this one?
10:49:51 <clokep> florian: I ported the m-c one.
10:49:55 <clokep> I didn't see an obvious c-c one.
10:49:59 <florian> :-S
10:50:02 <clokep> 'll check to see if there are further differences tonight though.
10:50:19 <-- FeuerFliege_VM has quit (Input/output error)
10:50:49 <florian> clokep: "I didn't see an obvious c-c one." the way to find it is to look at the hg blame of the file for the modified lines, and then get to the changeset.
10:51:30 <clokep> "of the file" you mean of the file in the c-c repo, right?
10:51:43 <clokep> Yeah I was doing that a bit, I'm not sure why I didn't for this one... :-S
10:52:39 <florian> clokep: ""of the file" you mean of the file in the c-c repo, right?" yes
10:53:10 <florian> clokep: you have noticed that explandlibs is the thing that's supposed to generate the .desc file you were having an error with, right?
10:53:24 <clokep> I think so.
10:53:34 <clokep> But AFAIK we're just using the one from Mozilla.
10:53:37 <clokep> So I guess we're calling it wrong.
10:53:52 <clokep> Also, what sort of rebuild do I Ineed to do when changing config/rules.mk?
10:53:59 <clokep> Is it just picked up automatically or is that clobber time?
11:07:47 <-- soapyhamhocks has quit (Connection reset by peer)
11:08:48 <-- clokep has quit (Ping timeout)
11:12:02 <-- jb has quit (Quit: jb)
11:20:52 --> rosonline has joined #instantbird
11:37:27 --> deOmega has joined #instantbird
11:37:36 <-- deOmega has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
11:48:12 --> AlexanderSalas has joined #instantbird
11:48:48 --> clokep_work has joined #instantbird
11:48:48 * ChanServ sets mode +o clokep_work 
11:54:52 --> jb has joined #instantbird
11:55:27 --> deltafalcon has joined #instantbird
11:58:40 <-- jb has quit (Input/output error)
11:58:44 --> jb has joined #instantbird
12:00:57 <-- deltafalcon has quit (Client exited)
12:01:20 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
12:02:00 <instantbot> aletheia2@fastmail.fm granted review for attachment 1991 on bug 1470.
12:02:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1470 nor, --, ---, aletheia2, ASSI, Reply to tweet only auto-fills the first (of possibly multiple) nicks
12:18:20 --> FeuerFliege has joined #instantbird
12:32:28 <-- rosonline has quit (Ping timeout)
12:32:46 --> rosonline has joined #instantbird
12:33:33 <-- FeuerFliege has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
12:40:18 --> FeuerFliege has joined #instantbird
12:51:36 <-- rosonline has quit (Ping timeout)
12:54:13 --> rosonline has joined #instantbird
12:55:54 <-- rosonline has quit (Ping timeout)
13:00:23 --> rosonline has joined #instantbird
13:04:05 <-- jb has quit (Quit: jb)
13:04:36 --> jb has joined #instantbird
13:08:09 <-- jb has quit (Quit: jb)
13:09:07 --> jb has joined #instantbird
13:09:09 <-- jb has quit (Input/output error)
13:09:16 --> jb has joined #instantbird
13:10:52 --> Kaishi has joined #instantbird
13:12:38 <-- jb has quit (Input/output error)
13:12:43 --> jb has joined #instantbird
13:12:50 <-- jb has quit (Input/output error)
13:13:09 --> jb has joined #instantbird
13:19:05 --> josefec has joined #instantbird
13:19:34 <-- josefec has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
13:30:39 --> mconley has joined #instantbird
13:31:48 <-- rosonline has quit (Ping timeout)
13:34:46 <-- Kaishi has quit (Input/output error)
13:35:56 --> rosonline has joined #instantbird
13:46:40 <-- jb has quit (Quit: jb)
13:52:45 --> jb has joined #instantbird
13:53:02 --> zen_monkey has joined #instantbird
14:04:45 --> Mic has joined #instantbird
14:04:45 * ChanServ sets mode +h Mic 
14:05:15 <Mic> Hi
14:22:19 <FeuerFliege> Hi
14:23:04 <Mic> FeuerFliege: I saw you uploaded a few patchs. Very nice :)
14:24:50 <-- rosonline has quit (Ping timeout)
14:25:43 <FeuerFliege> I just had a little more free time in the last few days :)
14:28:09 <florian> :)
14:30:07 --> rosonline has joined #instantbird
14:30:39 <Mic> Can I authenticate a Twitter account on a new profile by copying the messenger.account.<account id>.oauth pref from a profile where I already authentificated?
14:30:56 <-- Optimizer has quit (Ping timeout)
14:31:11 <Mic> (I tried and it didn't work and I wonder if I did something wrong of it it just doesn't work)
14:31:35 <florian> Mic: if it's between 2 profiles of the same application it should work
14:31:45 <florian> if it's between Tb and Ib, it won't work, as they use different oauth keys
14:34:23 --> Optimizer has joined #instantbird
14:34:55 <Mic> It works :)
14:35:15 <Mic> Thanks, I've only missed  ".options" in the pref name the first time...
14:35:52 <clokep_work> Too lazy to reauthenticate? :P
14:36:19 <Mic> Too lazy to got through the "I can't remember my password"-process
14:37:45 <clokep_work> Unfortunately I doubt we can make that easier. :(
14:41:19 <-- Optimizer has quit (Ping timeout)
14:43:04 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com)
14:44:54 --> Optimizer has joined #instantbird
14:47:37 <FeuerFliege> I reopened my high frequent twitter test conversation :( loading the stream took forever.
14:52:11 <clokep_work> Mic: So I know your restore thing is an experiment, but it works most of the time...
14:52:21 <clokep_work> BUt randomly will lose my OPEN conversations, but not the ones I had on hold.
14:53:16 <Mic> Oh, you're using it? Nice to hear that. I think I've seen this problem too, before
14:54:01 <clokep_work> Mic: Yes, I use it at work.
14:54:12 <clokep_work> (I also don't like that it doesn't restore what was on hold and what wasn't...)
14:54:18 <clokep_work> But that's a separate issue. ;)
14:54:34 * Mic neither but that's not as easy as it seemed.
14:54:55 <clokep_work> I'm also slightly less annoyed that the order of the tabs isn't restored. :-D
14:56:27 <Mic> Yes, that's all things that it should restore properly (+ grouping them in different windows as they were)
14:56:48 <Mic> Ideally
14:57:03 <florian> and keeping the sizes and positions of the windows
14:59:19 <clokep_work> :)
14:59:38 <clokep_work> Mic: Also I saw you had something about Twitter searches in separate tabs? You said it was easy? Do we have a patch? :-D
15:02:46 <Mic> I can show you a WIP if you like.
15:04:13 --> aleth has joined #instantbird
15:04:13 * ChanServ sets mode +h aleth 
15:06:26 <Mic> http://pastebin.instantbird.com/86210
15:07:37 <Mic> @ clokep_work
15:08:19 <aleth> Looks like that is going to be a popular feature :)
15:10:24 <florian> that looks quite promising!
15:10:53 <Mic> I've attached it to the bug, so we don't lose it.
15:10:59 <aleth> Remarkably straightforward...
15:11:25 <aleth> Btw Mic, re session restore, if you implement that in the core you might want to look at the chatRoomFields reconnection info stuff in IRC - maybe some of that should be moved up a level so it is available for all protocols. Then you could persist that info
15:11:31 <Mic> aleth: I was pleasantly surprised too :)
15:11:36 <florian> Mic: finishing it doesn't seem to require too much work; except if there are unimplemented parts that I missed
15:16:21 <Mic> Do incoming tweets contain information which tracked keywords were found in them maybe by the way?
15:17:22 <florian> not sure, but you can change the loglevel to see that
15:17:24 <aleth> Afaik there is no twitter doc page that lists all the fields attached to a tweet
15:17:35 <aleth> Best bet is just to dump some.
15:21:17 <aleth> Mic: this is the best doc I found the other day https://dev.twitter.com/docs/tweet-entities
15:21:56 <florian> would be nice to somehow highlight the keywords, but that may be for a different bug :)
15:23:29 <aleth> oh, and this https://dev.twitter.com/docs/platform-objects/tweets
15:30:30 <Mic> I think if you're following the sender, the tweet should also appear in your timeline.
15:30:55 <Mic> At the moment it's only added to the particular conversation and not added to the timeline anymore.
15:31:07 <aleth> Yes, if it had appeared there without you explicitly tracking the keyword, it should probably remain
15:31:33 <florian> and if I'm tracking "instantbird" and the tweet is an @instantbird @-reply, I probably still want it in the main timeline
15:31:46 <Mic> I meant if you're tracking the keyword but are following the sender too.
15:32:50 <Mic> florian: good point
15:33:24 <florian> (just to be completely clear, I was talking about the "main timeline" of the "instantbird" account)
15:33:28 <aleth> Mic: There are probably flags for those cases
15:35:26 <aleth> Hmm, maybe not.
15:36:10 <clokep_work> Yes, it should appear in both if applicable!
15:36:14 <clokep_work> Kind of weird, but still...
15:37:09 <clokep_work> Mic: Also I don't think you'd want to do the getString("track").split(",") everytime. :)
15:37:13 <clokep_work> But yeah surprisingly simple!
15:37:41 * clokep_work wonders what you should do if you track Mozilla and Firefox and someone tweets #MozillaFirefox ;)
15:38:28 <-- SM0TVI has quit (Connection reset by peer)
15:39:13 <florian> clokep_work: "Mic: Also I don't think you'd want to do the getString("track").split(",") everytime. :)" that's one of the things I would have mentioned in review comments, but Mic said it was an early WIP, so I refrained from pointing out performance issues.
15:39:58 <clokep_work> florian: Fair enough.
15:40:04 <clokep_work> I felt like I needed to add to the conversations. ;)
15:40:09 --> SM0TVI has joined #instantbird
15:40:10 <aleth> clokep_work: You'd stick it in both tabs I think. Put each tweet in all tabs where it satisfies the criterion
15:40:32 * clokep_work wishes he had his WIP for opening user streams...
15:41:38 <Mic> florian: can I observe changes to the list of keywords somehow?
15:42:06 <clokep_work> Mic: You can use a pref observer.
15:42:07 <florian> Mic: not sure. But changes to that list aren't taken into account until the account is reconnected (I think we have a bug on file for that)
15:42:41 <Mic> florian: ah, I've noticed that and wondered if it doesn't update the list at all or if it maybe takes some time before it does
15:43:01 <clokep_work> instantbot: twitter tracked keywords bugs
15:43:03 <aleth> Maybe we should just reconnect whenever someone makes changes to the connection settings?
15:43:07 <instantbot> Zarro boogs found.
15:43:14 <aleth> (for other protocols too)
15:43:28 <clokep_work> bug 677 it looks like.
15:43:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=677 nor, --, ---, nobody, NEW, Reopen Twitter stream when "track" preference changes
15:43:35 <clokep_work> aleth: No. That's a bad UX.
15:43:38 <florian> yeah
15:43:49 <Mic> "You need to reconnect for these changes to take effect. Would you like to reconnect now [Yes] [No]"
15:43:51 <florian> I was about to say "instantbot: bug 677" but I wasn't fast enough
15:43:52 <Mic> :P
15:44:05 <clokep_work> Mic likes the dialogs.
15:44:05 <aleth> Mic: That's what I was thinking, yeah
15:44:39 <aleth> Doesn't need a dialog, just a highlighted button in the account manager after making the change
15:45:05 <florian> it's just the user stream that we need to reconnect, and we can even wait for the new connection to be established before dropping the old one
15:45:20 <aleth> florian: but that would be a twitter-specific fix
15:45:27 <florian> so it will be completely invisible to the user
15:45:33 <florian> aleth: it's a twitter-specific issue
15:45:56 <florian> aleth: in general, we reconnect immediately after an account setting change if the account was disconnected with an error.
15:46:36 <aleth> Ah right, that should cover most cases where it matters, yes.
15:47:10 <florian> on IRC when the user adds things to the auto-joined channels list, we may want to join them immediately
15:48:05 <aleth> or we may want to ditch autojoins ;)
15:48:15 <clokep_work> Eventually, maybe.
15:48:32 <florian> I don't see that coming in less than a year
15:48:33 <aleth> eventually...
15:48:34 <clokep_work> If someone wants something fun to do...the stalked keywords on IRC would be a nice to have.
15:48:34 <florian> but sure
15:48:42 <clokep_work> (And I still think that could be done generically for all accounts.)
15:48:55 <clokep_work> (And yes, I'm going ot keep calling it "stalked" because it's fun...)
15:50:23 <florian> I don't understand from http://www.mozilla.org/en-US/persona/ where I'm supposed to click to access documentation about what I need to do as a developer to support persona
15:51:16 <florian> the "developers FAQ" points to a privacy policy, a blog post about the browserId -> Persona rename, and a blog post about persona vs openId
15:51:54 <aleth> Persona still doesn't work together with the FF password manager, so I'm not sure how ready it is
15:52:01 <florian> ah, I need the "about" link
15:52:24 <Mic> Quite obvious :P
15:52:34 <Mic> Where else would one look?
15:52:54 <aleth> mdn?
15:52:54 <florian> aleth: it's ready enough to be required for demos I create for Mozilla
15:53:20 <aleth> florian: ah. Dogfooding...
15:55:06 <florian> so, browserid.org/developers.html now redirects to https://login.persona.org/developers.html which contains "Cannot GET /developers.html"
15:55:08 <florian> helpful!
16:00:30 <-- AlexanderSalas has quit (Ping timeout)
16:00:50 --> AlexanderSalas has joined #instantbird
16:13:46 <-- FeuerFliege has quit (Ping timeout)
16:14:19 <-- gerard-majax has quit (Ping timeout)
16:21:41 --> rosonline has joined #instantbird
16:26:07 <Mic> bye
16:27:04 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com)
16:27:06 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
16:28:02 --> rosonline has joined #instantbird
16:36:29 --> FeuerFliege has joined #instantbird
16:47:10 <clokep_work> BrowserID was cool when they were going to integrate it into the Fx UI...
16:47:16 <clokep_work> But...that hasn't happened yet, so...
16:49:23 <florian> "that hasn't happened yet" for the last 3 years or so...
16:49:40 <florian> I just read at https://developer.mozilla.org/en-US/docs/Persona/Quick_Setup
16:50:22 <clokep_work> florian: Exactly. I've given up on it happening now.
16:50:54 --> gerard-majax has joined #instantbird
16:51:35 <florian> so to login a user, the web page needs to include a .js file from an external website, to do some Ajax requests, and to call some JS functions on *all* pages after the login has been done. And the web server needs to receive these requests, to do some POST requests to a persona server (and wait for the result before telling the user if the auth is OK or not), and to parse a JSON response.
16:53:18 <clokep_work> Sounds..."easy" ;)
16:53:46 <florian> sure, "Adding the Persona login system to your site takes just five steps"
16:54:05 <florian> I suspect a "banging head against wall" step is missing somewhere :-P
16:54:54 <clokep_work> Perhaps that's missing between each step? ;)
16:55:07 <aleth> Punctuation :P
16:55:19 <florian> the "Add “login” and “logout” buttons." step may be reasonable.
16:56:04 <florian> oh, https://developer.mozilla.org/fr/docs/persona/branding is lovely. The localized the page, but not the text inside the buttons.
16:56:20 <florian> is the persona web page localized, btw?
16:57:05 * clokep_work just wants to know what the demo is. :P
16:57:13 * clokep_work goes home.
16:57:14 <florian> which demo?
16:57:22 <clokep_work> The one you're putting up?
16:57:32 <clokep_work> 11:52:55 AM - florian: aleth: it's ready enough to be required for demos I create for Mozilla
16:57:38 * aleth agrees
16:58:01 <florian> ah, that probably won't be released until January or February
16:58:01 <clokep_work> Anyway, I have family visiting this weekend might not be available for r?s or such. :) So enjoy your weekend!
16:58:21 * clokep_work waits in a suspense, gripping his chair until his fingers turn white.
16:58:28 <-- clokep_work has quit (Input/output error)
16:58:29 <florian> clokep_work: so I should just go ahead and checkin the moz16 update if I feel it works?
16:59:39 <florian> and to be really clear, I haven't coded any demo yet. Just played with SocialAPI, webrtc APIs, looked at Persona, etc...
16:59:55 --> Mook_as has joined #instantbird
17:00:59 <aleth> That would have been very fast work... ;)
17:13:13 <-- jb has quit (Quit: jb)
17:30:47 <-- Optimizer has quit (Connection reset by peer)
17:41:11 --> DGMurdockIII has joined #instantbird
17:52:43 <florian> uh, it seems we've never removed http://lxr.instantbird.org/instantbird/source/purple/purplexpcom/src/purpleStorage.cpp
17:53:54 <florian> anybody interested in doing a patch with a great diffstat? :)
17:57:10 <-- FeuerFliege has quit (Ping timeout)
17:58:37 --> ueffel has joined #instantbird
17:59:27 <-- florian has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
18:07:34 --> clokep has joined #instantbird
18:07:34 * ChanServ sets mode +o clokep 
18:14:50 --> unghost has joined #instantbird
18:18:27 <-- ueffel has quit (Quit: ueffel)
18:18:32 <clokep> flo: If it the Moz16 stuff compiles for you, sure go for it....I never finished it though. :)
18:18:44 * clokep will prepare a patch to remove that file...
18:19:12 <clokep> Uhh...except it is used?
18:19:39 <clokep> Well it's built...and unInited......
18:24:17 --> ueffel has joined #instantbird
18:24:59 <ueffel> hi
18:25:05 <clokep> Hello ueffel!
18:25:12 <ueffel> i got a problem with my smiley theme for instantbird
18:25:39 <clokep> ...
18:25:53 <ueffel> specifically with smileys that got a "." in them
18:26:30 <clokep> Can you be more specific? What is the issue?
18:27:27 <ueffel> o.O for example matches fine with "o.O" but if something like "oXO" where X can be anything it shows a something weird
18:27:49 <ueffel> its not the smiley picture, its like a picture not found dummy
18:27:58 <clokep> Oh hmmm...
18:27:58 * aleth smells a regex problem
18:28:07 <clokep> aleth: Me too. I wonder if our escaping isn't working?
18:28:23 <aleth> clokep: Didn't you have a smiley patch waiting for review?
18:28:29 <aleth> Was that related?
18:28:31 <clokep> It's not done.
18:28:33 <clokep> No.
18:29:47 <ueffel> how would i escape it? "o\.O" or "o\\.O" doesnt do the trick
18:29:59 --> jb has joined #instantbird
18:30:23 <-- jb has quit (Quit: jb)
18:30:32 --> jb has joined #instantbird
18:32:02 <clokep> I don't think it is supposed to be a regular expression at all...
18:32:13 <aleth> It's likely a bug in our code
18:32:26 <aleth> somewhere in here http://lxr.instantbird.org/instantbird/source/chat/modules/imSmileys.jsm#98
18:32:38 * clokep blames wnayes.
18:32:54 <flo> at http://lxr.instantbird.org/instantbird/source/chat/modules/imSmileys.jsm#120
18:33:16 --> Mnyromyr has joined #instantbird
18:33:30 <flo> clokep: has wnayes changed that regexp?
18:33:59 <clokep> flo: No...I ended up in his user repo for some reason and was confused. :)
18:34:03 <clokep> (I have no idea how...)
18:34:24 <aleth> Hmm, don't we have a better escaping regex somewhere already?
18:34:44 * aleth seems to remember assembling one
18:34:46 <flo> aleth: that one was supposed to be good
18:35:01 * aleth hopes he didn't assemble that one then
18:35:03 <flo> who's volunteering for adding unit tests for that smiley code? ;)
18:35:10 <flo> aleth: I did. In 2009.
18:35:28 <aleth> flo: I think that's in clokep's unfinished patch actually
18:36:01 <clokep> flo, aleth: I have some unit tests for finding smileys, but not for cleaning them.
18:36:03 <flo> aleth: but he hasn't finished that patch because he knows it's likely going to be r-'ed ;)
18:36:29 <flo> clokep: don't you also have unit tests for *not* finding smileys? :)
18:38:04 <aleth> That's the one I was referring to (but it might be doing something different) http://lxr.instantbird.org/instantbird/source/chat/modules/jsProtoHelper.jsm#511
18:42:56 <clokep> flo: Yes, the more important part...
18:43:02 <clokep> ueffel: Could you file a bug please? :)
18:43:27 <ueffel> k
18:43:31 <clokep> Thank yoU!
18:43:37 <clokep> Feel free to assign it to...aleth. ;)
18:43:39 <clokep> (JK)
18:43:54 <clokep> (Well or fix it yourself if you understand the issue! :))
18:44:24 <flo> aleth: your regexp escapes these characters that the smiley one doesn't: -{}.,#\s
18:44:43 <aleth> flo: but was there a reason for that (in the smiley code)?
18:45:46 <flo> aleth: I'm not sure
18:46:02 <flo> but if you start touching that code, you can replace all the $1 with $&
18:47:22 <instantbot> New Core - General bug 1733 filed by clokep@gmail.com.
18:47:23 <instantbot> clokep@gmail.com requested review from the wind for attachment 1994 on bug 1733.
18:47:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1733 min, --, ---, nobody, NEW, Remove purpleStorage
18:47:40 --> FeuerFliege has joined #instantbird
18:47:56 <flo> aleth: what's the reason for escaping - ?
18:48:34 <clokep> FYI ^ my build is broken so....untested. :-D
18:49:04 <flo> so escaping {} is useful only if there's something inside them
18:49:16 <aleth> I can't remember off the top of my head
18:49:38 <flo> I don't see why we would need to escape ,
18:49:54 <flo> what's # in regexps?
18:50:04 <clokep> Nothing AFAIK.
18:50:08 <flo> and I'm not sure for \s either (what is it?)
18:50:19 <clokep> \s is spaces.
18:50:21 <aleth> I can never remember all the regex possibilities... was just working from the documentation
18:50:24 <aleth> \s is whitespace
18:50:38 <clokep> (Also if why do we havfe two sets of code to do the same thing? ;))
18:50:49 <flo> but we should that be escaped? Or am I reading the regexp wrong?
18:51:13 <flo> clokep: you mean 2 different proxy handlings?
18:51:36 <clokep> flo: Yes!
18:51:42 <clokep> But you explained that to me the other day. :)
18:52:01 <flo> so Mook_as can't do Instantbird patches while _as, but pushes Tb patches? What's up with that? :-P
18:52:41 <flo> clokep: ah, yes, you know the history of our proxy code :-D
18:52:58 <Mook_as> :p
18:53:28 <Mook_as> (shh, try to let toddw notice :p )
18:53:30 <-- FeuerFliege has quit (Input/output error)
18:54:25 * flo doesn't know toddw
18:55:35 <clokep> Apparently Mook_as' boss. ;)
18:58:19 <-- jb has quit (Ping timeout)
18:58:44 --> jb has joined #instantbird
19:00:23 <instantbot> New Instantbird (UI) bug 1734 filed by steffen2705@web.de.
19:00:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1734 nor, --, ---, nobody, UNCO, Smiley regular expression problem in custom smiley themes
19:00:59 <clokep> Thanks! :)
19:01:46 <ueffel> no problem :)
19:01:46 <ueffel> despite this bug: keep up the good work
19:02:19 <flo> ueffel: I expect this bug will be fixed soon ;)
19:02:28 <ueffel> yay :D
19:02:41 <flo> clokep volunteered aleth to fix it anyway ;)
19:03:28 <aleth> volunteering is not meant to be transitive ;)
19:03:35 --> flo-retina has joined #instantbird
19:03:44 * flo-retina is now known as florian
19:06:11 <instantbot> florian@instantbird.org granted review for attachment 1994 on bug 1733.
19:06:14 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1733 min, --, ---, nobody, NEW, Remove purpleStorage
19:14:54 <flo> aleth: right, in the same way that software isn't meant to contain bugs ;).
19:15:20 <aleth> such is life.
19:19:09 <-- Morian has quit (Ping timeout)
19:19:09 <-- clokep has quit (Ping timeout)
19:19:11 --> clokep has joined #instantbird
19:19:11 * ChanServ sets mode +o clokep 
19:19:15 --> Morian has joined #instantbird
19:19:15 * ChanServ sets mode +h Morian 
19:19:55 <-- DGMurdockIII has quit (Ping timeout)
19:20:23 --> DGMurdockIII has joined #instantbird
19:20:26 <-- Tonnes has quit (Ping timeout)
19:23:00 <-- unghost has quit (Ping timeout)
19:38:16 --> unghost has joined #instantbird
19:39:06 --> st4s3 has joined #instantbird
19:44:46 <aleth> I can't remember why # and \s were included :S \s possibly due to the nick regex being \b...\b. Pretty sure escaping -, was because they appear in ranges (so I guess that's strictly speaking unnecessary if brackets are escaped)
19:45:34 <aleth> Certainly looks a bit redundant to me now
19:47:15 <aleth> # only seems to have a regex meaning as a comment delimeter (?#comment), but the same as for the range ,- would apply
19:48:27 --> Tonnes has joined #instantbird
19:49:53 <-- st4s3 has left #instantbird ()
19:51:51 <flo> aleth: so we can simplify? :)
19:52:05 <aleth> Looks like it... unless I am missing something
19:52:44 <aleth> If we were to use the same regex for both, where would one put a 'global' regex?
19:57:34 <-- rosonline has quit (Broken pipe)
19:59:46 <flo> I don't see a good place for that common regexp
20:00:11 <aleth> I don't think it even makes things more legible.
20:00:22 <flo> if we need it in a dozen places we could put it in a JS module, but we use it only twice, so a module for it is way too much overhead imho
20:06:36 --> Kaishi has joined #instantbird
20:13:35 <-- unghost has quit (Ping timeout)
20:14:54 <-- clokep has quit (Ping timeout)
20:18:56 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1996 on bug 1734.
20:18:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1734 nor, --, ---, aletheia2, ASSI, Smiley regular expression problem in custom smiley themes
20:21:39 <florian> aleth: I thought you were also going to remove the '(' and ')' at http://lxr.instantbird.org/instantbird/source/chat/modules/imSmileys.jsm#132
20:21:47 <florian> and the $1 at http://lxr.instantbird.org/instantbird/source/chat/modules/imSmileys.jsm#139
20:24:03 <aleth> or I could remove that "unused function" :P
20:30:34 --> unghost has joined #instantbird
20:32:15 --> wnayes has joined #instantbird
20:32:26 <instantbot> aletheia2@fastmail.fm cancelled review?(florian@instantbird .org) for attachment 1996 on bug 1734.
20:32:27 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1997 on bug 1734.
20:32:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1734 nor, --, ---, aletheia2, ASSI, Smiley regular expression problem in custom smiley themes
20:33:07 <florian> aleth: I suspect that "unused" function would be quite useful for unit testing
20:34:33 <aleth> Ah! bug 1139 is about reducing false positives. That will be good :)
20:34:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1139 nor, --, ---, clokep, ASSI, fewer false positives for emoticon detection
20:34:52 <aleth> I only remembered "something with smileys"
21:02:36 <-- AlexanderSalas has quit (Connection reset by peer)
21:03:09 <instantbot> florian@instantbird.org granted review for attachment 1997 on bug 1734.
21:03:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1734 nor, --, ---, aletheia2, ASSI, Smiley regular expression problem in custom smiley themes
21:17:21 * florian is building with clokep's moz16 patch
21:18:54 <-- jb has quit (Input/output error)
21:18:57 --> jb has joined #instantbird
21:20:10 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 17.0/20121010150351])
21:25:33 <florian> clokep's patch forgot bug 1490 (the required change is in http://ftp.instantbird.com/instantbird/thunderbird-addon/2.10.4/diffs/purple-changes-tb16.patch)
21:25:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1490 nor, --, ---, nobody, NEW, Remove usage of nsILocalFile for Mozilla 16
21:26:02 <-- jb has quit (Ping timeout)
21:29:45 <-- mconley has quit (Input/output error)
21:48:41 <-- unghost has quit (Quit: Ухожу я от вас (xchat 2.4.5 или старше))
22:08:51 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:14:31 --> Optimizer has joined #instantbird
22:15:09 <-- instant-buildbot has quit (Ping timeout)
22:15:22 --> instant-buildbot has joined #instantbird
22:15:22 * ChanServ sets mode +v instant-buildbot 
22:15:49 <-- Morian has quit (Ping timeout)
22:15:49 --> Morian has joined #instantbird
22:15:50 * ChanServ sets mode +h Morian 
22:17:45 <aleth> clokep: Why do I have usermode +i (invisible - rfc1459)? What does that mean?
22:18:00 <florian> I suspect porting http://hg.mozilla.org/releases/comm-release/rev/410f1fa9ebc6 would fix our linux startup crasher
22:18:24 <aleth> fingers crossed :)
22:18:31 <florian> I'm not doing it
22:18:39 <aleth> ah...
22:18:42 <florian> (I only have mac machines around)
22:19:07 <-- aleth has quit (Quit: Au revoir)
22:19:10 <florian> but if nobody beats me to it, I may check tomorrow afternoon/evening
22:31:45 <florian> Mook_as: so you were really bored? (doing a checkin yourself and then staring all the builds... :-P)
22:32:00 <Mook_as> waiting for the debugger to hit things
22:32:09 <Mook_as> on account of, umm, excessive debugging code slowing crap down
22:33:01 <Mook_as> (also, I assumed that I was _supposed_ to star on my checkins... but then it looks like nobody else is doing it :( )
22:33:11 <Mook_as> (I accidentally starred half of somebody else's build, too)
22:36:11 <florian> there are too many oranges for it to be realistic to star them all + nobody looks at the bugs for the random tests
22:36:42 <florian> and I think people doing seamonkey-only checkins don't even look at the tb tree, so they don't star these builds
22:38:31 <Mook_as> oh, I did that tree because I couldn't find the seamonkey tree :p
22:39:13 <florian> was your check-in for seamonkey? O_o
22:43:12 <Mook_as> I dunno! I think it's tbird, but I'm not clear what things are shared
23:04:05 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
23:12:00 <-- ueffel has quit (Ping timeout)
23:53:16 --> delmundot has joined #instantbird
23:53:45 --> mconley has joined #instantbird
23:54:09 <-- delmundot has quit (Client exited)