#instantbird log on 10 04 2012

All times are UTC.

00:08:50 <-- Optimizer has quit (Ping timeout)
00:11:58 --> Optimizer has joined #instantbird
00:23:02 --> DGMurdockIII has joined #instantbird
00:50:30 --> mconley has joined #instantbird
01:04:53 <-- Mook_as has quit (Quit: Mook_as)
01:23:48 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.89 [Firefox 15.0.1/20120905151427])
01:33:01 <-- Kaishi has quit (Quit: Kaishi)
01:36:20 --> Kaishi has joined #instantbird
01:43:42 <-- clokep_work has quit (Ping timeout)
01:49:09 <-- mconley has quit (Input/output error)
02:11:14 --> Mook has joined #instantbird
02:17:22 <-- micahg has quit (Ping timeout)
02:18:55 --> micahg has joined #instantbird
02:39:00 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
03:24:08 <instant-buildbot> build #636 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/636
03:25:25 <-- micahg has quit (Ping timeout)
03:28:59 --> micahg has joined #instantbird
03:40:02 <-- Kaishi has quit (Ping timeout)
03:43:42 --> Kaishi has joined #instantbird
03:59:12 --> deltafalcon has joined #instantbird
04:08:19 <instant-buildbot> build #731 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/731
04:09:18 <-- Optimizer has quit (Ping timeout)
04:13:23 --> Optimizer has joined #instantbird
04:24:24 <instant-buildbot> build #650 of linux-nightly-default is complete: Failure [failed shell_3]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/650
05:00:57 <-- EionRobb has quit (Quit: Leaving.)
05:04:24 --> clokep_work has joined #instantbird
05:04:24 * ChanServ sets mode +o clokep_work 
05:06:06 <-- clokep_work has quit (Input/output error)
05:06:22 --> clokep_work has joined #instantbird
05:06:22 * ChanServ sets mode +o clokep_work 
05:10:21 <-- clokep_work has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
05:10:31 --> clokep_work has joined #instantbird
05:10:31 * ChanServ sets mode +o clokep_work 
05:16:24 <-- Optimizer has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
05:16:31 --> Optimizer has joined #instantbird
05:32:56 <-- clokep_work has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
06:11:15 --> barlas has joined #instantbird
06:14:01 <-- Optimizer has quit (Ping timeout)
06:17:20 --> Optimizer has joined #instantbird
06:20:04 --> jb has joined #instantbird
06:38:44 <-- jb has quit (Ping timeout)
06:47:44 --> mikk_s has joined #instantbird
06:47:51 <-- mikk_s has quit (Quit: mikk_s)
07:19:05 <-- Mook has quit (Quit: Mook)
07:27:58 <-- Optimizer has quit (Ping timeout)
07:31:39 --> Optimizer has joined #instantbird
07:35:56 <-- Optimizer has quit (Ping timeout)
07:39:19 --> Optimizer has joined #instantbird
07:42:42 --> Mic has joined #instantbird
07:42:42 * ChanServ sets mode +h Mic 
07:55:44 <-- Optimizer has quit (Ping timeout)
07:57:48 --> Optimizer has joined #instantbird
08:23:51 <Mic> Great, a bank website that is verified to be run by the bank (green box in the adress bar) on their pages ...
08:24:06 <Mic> ... except for their online banking part. :S
08:25:42 --> jb has joined #instantbird
08:28:26 * flo is now known as flo-away
08:43:39 --> flo-retina has joined #instantbird
08:43:45 * flo-retina is now known as florian
09:36:02 <-- Even has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
10:32:46 <-- barlas has quit (Ping timeout)
10:40:14 --> barlas has joined #instantbird
10:42:00 --> meh has joined #instantbird
10:47:42 <-- jb has quit (Quit: jb)
10:48:24 --> jb has joined #instantbird
10:51:33 <-- jb has quit (Quit: jb)
10:52:47 --> jb has joined #instantbird
11:24:54 <-- chrisccoulson has quit (Quit: Ex-Chat)
11:30:19 --> chrisccoulson has joined #instantbird
11:35:13 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
11:36:18 <-- Mic has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
11:44:16 --> rosonline has joined #instantbird
11:45:02 <-- Optimizer has quit (Connection reset by peer)
11:48:54 --> Optimizer has joined #instantbird
12:04:04 --> clokep_work has joined #instantbird
12:04:04 * ChanServ sets mode +o clokep_work 
12:40:12 <clokep_work> florian: I have some questions about that patch, but I think overall it's OK.
12:40:25 <florian> let's hope I have some answers :)
12:40:59 <clokep_work> (I have to leave in a minute unfortunately. :()
12:41:11 <clokep_work> let toHexString =  function(charCode) ("0" + charCode.toString(16)).slice(-2);
12:41:19 <clokep_work> Why the "0" that you then slice off?
12:41:50 <florian> that function ensure each character is encoded on 2 hex characters
12:42:02 <florian> so it will add a 0 all the time, and then keep the last 2 characters
12:42:10 <clokep_work> Ah, I see.
12:42:15 <florian> I didn't right this today, it's something we already have in a few places
12:42:20 <florian> *write
12:42:26 <clokep_work> Yay code duplication...
12:42:33 * clokep_work will be back (with an r+ most likely)
12:42:43 <florian> yeah, code duplication for all the crypto stuff
12:43:00 <florian> I think at some point we will really want to put it all together in a single .jsm
12:43:19 <florian> but we didn't have any UTF-8 encode then SHA1 hash implementation yet
12:43:47 <-- Kaishi has quit (Quit: Kaishi)
12:44:13 <-- clokep_work has quit (Ping timeout)
12:49:55 --> AlexanderSalas has joined #instantbird
13:34:00 <-- Optimizer has quit (Ping timeout)
13:34:42 --> mconley has joined #instantbird
13:37:22 --> Optimizer has joined #instantbird
13:43:17 <-- Optimizer has quit (Ping timeout)
13:43:35 <-- rosonline has quit (Ping timeout)
13:45:42 --> rosonline has joined #instantbird
13:46:27 --> Optimizer has joined #instantbird
14:02:57 <florian> I should probably reply in the "New dependency: libcurl" devel @ pidgin thread :-S
14:11:31 <-- Optimizer has quit (Ping timeout)
14:14:49 --> Optimizer has joined #instantbird
14:22:08 <-- rosonline has quit (Quit: Experimentem Instantbird 1.2 -- http://www.instantbird.com)
14:30:32 <-- skeledrew has quit (Ping timeout)
14:31:03 --> skeledrew has joined #instantbird
14:31:45 * florian wonders if mconley knows why http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-folder-display-helpers.js#2826 has a comment saying "something less sucky than do_check_true"
14:32:05 <florian> that assert_true function only logs the failing test, not the passing ones, so I don't see how that's "less sucky" :-S
14:32:05 <mconley> florian: that sounds like asuth
14:34:06 <florian> and it's really annoying that the API is different for each of the test suites :(
14:35:33 <mconley> florian: every couple of years, someone writes a new test framework to replace the last one
14:35:40 <mconley> florian: we're lucky we have so few. :)
14:36:20 <florian> mconley: replacing the last one isn't a problem. The problem is piling more junk above an already messy situation ;).
14:36:47 <mconley> florian: it's certainly not perfect, that's for sure.
14:38:48 <florian> mconley: yeah... "not perfect" is really an understatement here. Btw, even if I'm ranting about mozmill, I'm not blaming you for it :). You just happen to be the only one around with some knowledge of it ;)
14:39:00 <mconley> florian: :D
14:41:51 --> igorko has joined #instantbird
14:45:40 <-- Optimizer has quit (Ping timeout)
14:46:31 <florian> mconley: did you mean mc.eid instead of me.e ?
14:47:01 <mconley> florian: mc.eid gives you the DOM node. mc.e gives you the node wrapped in the Elem lib, so you can do clicks on stuff
14:47:14 <mconley> So mc.click(mc.e("some-button")) is correct
14:47:28 <mconley> but mc.eid("some-button").setAttribute("something", "true"); is also correct
14:48:07 --> Optimizer has joined #instantbird
14:48:10 <florian> is there something better than module.window = mc.window; to access things in the JS scope of the window?
14:52:55 <florian> mconley: "mc.eid gives you the DOM node. mc.e gives you the node wrapped in the Elem lib" it seems to be the opposite.
14:53:12 <florian> mc.e("button-chat") = [object XULElement]
14:53:12 <florian> mc.eid("button-chat") = [object Object]
14:54:21 <mconley> florian: ah, yes, sorry, you're absolutely right
14:54:41 <mconley> although mc.click(mc.e("button-chat")) should still work, I believe.
14:54:58 <mconley> and, nope, I'm wrong
14:55:08 <mconley> it's mc.click(mc.eid("button-chat"))
14:55:15 <florian> mconley: at least you are confirming that the API is confusing, even after using it for a while ;)
14:55:16 <mconley> florian: sorry about the confusion
14:55:27 <mconley> florian: I do not deny this whatsoever. :D
14:55:35 <florian> mconley: no problem, thanks for the help! :)
14:55:49 <mconley> florian: yw
14:57:38 <florian> mc.click(mc.e("button-chat")) fails with "Test Failure: aElem.getNode is not a function"
15:03:17 <-- Optimizer has quit (Ping timeout)
15:03:43 <dew> so I want to write an irc bot, I'm half thinking about starting it as an addon for InstantBird and then I can reinvent the wheel later :P
15:04:00 <florian> dew: can you compile?
15:04:10 <dew> yes
15:04:15 <florian> dew: if you can, you may want to use xpcshell and run Instantbird's IRC code in it
15:04:28 <dew> but I never got the build working properly on windows
15:04:31 <dew> with the pymake
15:04:39 <dew> but this is when I was building firefox
15:05:49 <dew> what's xpcshell?
15:06:40 --> Optimizer has joined #instantbird
15:07:05 <mconley> dew: it's a JS shell with access to XPCOM components
15:07:07 --> clokep_work has joined #instantbird
15:07:07 * ChanServ sets mode +o clokep_work 
15:07:08 <mconley> dew: usually used for testing
15:09:26 <dew> I've heard XPCOM a lot and still don't have the strongest grasp on what it is
15:10:22 * florian requested review from mconley again in https://bugzilla.mozilla.org/show_bug.cgi?id=794946
15:10:35 <mconley> florian: cool, I'll get to that today. :)
15:10:49 <florian> it's really jsut the same patch with your comments taken into account
15:11:14 <florian> I'm just requesting review again to be sure I understood correctly (and haven't added lines I didn't really need at the top)
15:11:34 * clokep_work has half of an IRC bot written...
15:11:35 <mconley> dew: I'm no XPCOM expert for starters, but basically, I think it's a way to register classes / services within Gecko, written in either C++ or Javascript, and accessible to C++ and/or Javascript
15:11:37 * instantbot mumbles something about c++ being evil
15:11:38 <florian> I will use that file as a base for the next tests I'm going to write, so better get this one clean first :)
15:12:05 <mconley> dew: so XPCShell is a great way to test those components without having to spawn a browser window, etc.
15:16:27 <dew> ah so command line testing the gui kind of
15:16:40 <dew> I mean functions within the gui without actually doing them
15:16:53 <dew> and it makes sense that automated tests are done within it :)
15:17:11 <-- florian has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
15:17:25 <-- clokep_work has quit (Ping timeout)
15:21:57 --> clokep_work has joined #instantbird
15:21:57 * ChanServ sets mode +o clokep_work 
15:23:02 <clokep_work> dew: What do you mean "functions within the gui without actually doing them"?
15:24:15 <-- barlas has quit (Connection reset by peer)
15:24:59 <clokep_work> florian: by the way, abstracting the crypto stuff is kind of what I was talking about yesterday.
15:29:06 <-- jb has quit (Ping timeout)
15:29:40 <dew> I mean function calls that the gui does clokep_work
15:29:47 <dew> also what does your irc bot do?
15:31:57 <clokep_work> dew: mconley is suggesting that you can call those directly without the GUI.
15:32:22 <clokep_work> dew: It doesn't do anything. ;) It's a framework, but it's not really finished...it had working infobot support at one point though.
15:32:44 <clokep_work> https://bitbucket.org/clokep/js-lobot/ It needs a redesign though. ;)
15:32:55 <clokep_work> (I.e. probably not a good basis for anything.
15:33:10 <dew> bitbucket eh
15:33:15 <clokep_work> ?
15:33:24 <clokep_work> You'd prefer the awfulness that is GitHub, I assume?
15:33:29 <dew> no I use both
15:33:41 <dew> just if I use hg I use bitbucket
15:33:46 <dew> why is github awful?
15:34:34 <clokep_work> It breaks the whole paradigm of how branches and forks work. Plus you need to go to the website to do too much. I don't want to discuss the merits of git/github and hg right now though. :)
15:36:12 <dew> oh okay
15:36:23 <dew> I guess I'm a little lost
15:36:31 <clokep_work> What's up?
15:37:12 <dew> no I mean on what you mean
15:37:24 <clokep_work> Which part.
15:37:34 <clokep_work> What do you want an IRC bot to do, anyway?
15:37:58 <dew> haha initially, just listen and learn word associations
15:38:11 <dew> and speak according to what it learns from the channel
15:39:56 <clokep_work> OK. So you'd first need to be able to connect, if you were to do it in Instantbird you'd have a couple of options:
15:40:24 <clokep_work> 1. You could make a bot that is an IRC bot, or you could use one that uses the Instantbird APIs to work for any protocol (which is what mine tries to do).
15:42:12 <clokep_work> UHhh...apparently I combined 1 & 2 in there. :)
15:42:17 <clokep_work> So those are your options hah.
15:45:54 --> jb has joined #instantbird
15:51:36 <-- deltafalcon has quit (Connection reset by peer)
16:02:13 <flo-away> clokep_work: so when you said "SASL" you meant "random crypto stuff"?
16:02:39 <flo-away> clokep_work: Isn't there a crypto JSM file included in wnayes' large patch?
16:02:51 <flo-away> I assumed there was, and that we would want to do some clean-up after landing that
16:02:53 <clokep_work> flo-away: I had originally been thinking SASL specifically, but "random crypto stuff" sounds good too.
16:03:04 <clokep_work> There's the blowfish module, there might be another one too.
16:03:28 <clokep_work> flo-away: Any chance you have a TB 15 around and can try to connect to an IRC server for me and see what the actual error thrown is? I'm trying to help someone in #thunderbird...
16:03:43 <clokep_work> (He's running an IRCX server! Weird...)
16:06:50 --> flo-retina has joined #instantbird
16:06:53 * flo-retina is now known as florian
16:07:55 <florian> clokep_work: uh, the first Tb15 I found on my Download folder is in Chinese :-S
16:08:15 <clokep_work> florian: Haha. Fun. :)
16:08:25 <florian> is there a log of #thunderbird?
16:13:09 <clokep_work> florian: FYI I have the server information in a PM.
16:15:24 <clokep_work> http://pastebin.instantbird.com/83120 Is the #hunderbird conversation if anyone else is interested...
16:19:39 <florian> clokep_work: I saw that (that you haave the server information) in the pastebin
16:19:49 <florian> clokep_work: do you still need me to find a tb15?
16:20:05 <clokep_work> florian: I can't reproduce the issue, so I have no idea what's going on.
16:20:09 <clokep_work> Instantbird 1.3a1pre works.
16:23:19 <florian> so you want that guy to send you a debug log, right? :)
16:23:27 <clokep_work> Yes.
16:27:57 <florian> we really need a better way to get debug logs :
16:27:58 <florian> (
16:28:55 <clokep_work> I agree.
16:29:50 --> meh has joined #instantbird
16:30:24 <florian> what about just adding "Copy debug log" in the context menu of each account in the account manager, each conversation tab, and each contact?
16:30:45 <clokep_work> But then we have to store all the messages we get.
16:30:47 <florian> for each received block of data, we would annotate it per account, conversation and contacts
16:31:12 <florian> and we would cleanup after we have 200 items in the log for that {account,conversation,contact}
16:31:23 <florian> clokep_work: the error console already does that in some way
16:31:40 <florian> clokep_work: but very poorly, because if JS-IRC spams the console, I can't see the last twitter thing we received.
16:32:01 <clokep_work> florian: True. I actually wonder if we should make an interface for the type of logging we want and just not make a nice console for it yet and add the types of UI you're talking about.
16:32:10 <florian> on my default profile, the content of the error console scrolls continuously
16:32:41 <florian> clokep_work: I can't parse that last sentence :-S.
16:33:06 <clokep_work> florian: I guess what I'm saying is I wonder if we should add the hooks to a nicer console, but not really build a UI for a nicer console.
16:33:46 <florian> clokep_work: there are 2 separate problems. One is collecting the data in a useful way. The other is displaying it in a way that makes sense as quickly as possible.
16:34:19 <clokep_work> Right. I'm saying add the hooks for collecting the data in a useful way so IRC/XMPP/Twitter can implement those.
16:34:26 <clokep_work> And we don't really worry about displaying it right now.
16:34:47 <florian> we would want to have libpurple implement them at least in part
16:34:56 <florian> so that we can stop abusing the error console for that
16:35:08 <florian> and be able to see *real errors and warnings* before they are scrolled out
16:35:24 <clokep_work> Yes. :)
16:35:33 <clokep_work> Sorry, I should have said IRC/XMPP/Twitter/purplexpcom.
16:36:03 <florian> clokep_work: it's a project on the 1.3 roadmap ;)
16:36:20 <florian> clokep_work: and one of my top priorities after I'm done with memory reporters
16:36:49 <florian> possibly the only thing *I* really want to implement for 1.3
16:36:57 <florian> (well, and show nick :-])
16:37:40 <florian> for the rest, I suspect I'm more useful to the project if I spend time on reviews rather than starting crazy projects
16:38:06 <florian> especially given that we still haven't finished the review of wnayes' patch, and that will still need a significant amount of time
16:38:27 <florian> (as we will need to review again once he updates the patches ;))
16:39:54 * clokep_work kind of hopes he splits the patch up.
16:40:47 --> Mnyromyr has joined #instantbird
16:41:50 <florian> clokep_work: I think he will. But that just makes it less painful, not shorter ;)
16:47:49 <-- Optimizer has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
16:47:55 --> Optimizer has joined #instantbird
16:48:21 --> Mook_as has joined #instantbird
16:49:58 --> wnayes has joined #instantbird
17:00:19 <clokep_work> florian: Touche. :) But much easier!
17:00:38 <clokep_work> We need to do real reviews next GSoC. :-/ During the summer. In specific chunks, I think.
17:01:36 <-- Optimizer has quit (Ping timeout)
17:04:06 --> Optimizer has joined #instantbird
17:16:38 <florian> clokep_work: typical Bonjour junk in my error console: http://i.imgur.com/Q3qxE.png
17:18:16 <florian> hmm, looking at it again, it's possibly our bad
17:19:01 <florian> the code seems to use an executeSoon to dispatch status updates to conversations for some reason, but this.buddy is likely set to null immediately when the buddy is deleted.
17:30:24 <clokep_work> Hmm...should that be fixed? :-D
17:30:51 <florian> sure
17:31:05 <florian> it's possibly just a null check that needs to be added
17:31:22 <florian> but one needs to understand what's actually going on before attempting to patch it
17:31:42 * florian should file a bug, but feels lazy
17:34:57 <florian> wait, no, that's not giving a good example :)
17:36:04 <instantbot> New Core - General bug 1717 filed by florian@instantbird.org.
17:36:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1717 nor, --, ---, nobody, NEW, JS errors when a Bonjour buddy disconnects
17:37:03 <florian> clokep_work: Is there any use in filing a bug for "Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG." without steps to reproduce?
17:37:22 <florian> test
17:37:31 <-- Optimizer has quit (Ping timeout)
17:37:32 <clokep_work> florian: I don't think so. :-/
17:37:32 <florian> well, now I have steps to reproduce :)
17:37:38 <clokep_work> Hahah.
17:38:00 * florian wonders who broke that
17:38:14 <florian> s/who/what/ actually
17:38:20 * clokep_work blames instantbot
17:38:25 <florian> I'm not really interested in blaming someone
17:38:37 <clokep_work> I'll take a look soon.
17:39:10 <florian> although I do like that now that I'm no longer the only one writing code, I'm often not the one that could be blamed for new bugs :)
17:39:37 <florian> test
17:39:38 <florian> test
17:40:05 <clokep_work> I probably broke it...
17:40:29 <instantbot> New Core - IRC bug 1718 filed by florian@instantbird.org.
17:40:53 --> Optimizer has joined #instantbird
17:40:57 <florian> clokep_work: I could be blamed for a few of the JS-XMPP bugs that currently annoy me though ;)
17:40:58 <clokep_work> We definitely had that fixed at one point. :-/
17:41:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1718 nor, --, ---, nobody, NEW, Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
17:41:30 <florian> clokep_work: it's possible it regressed with that ACTION patch
17:41:42 <florian> feels like something that wants some unit tests :)
17:42:06 <clokep_work> florian: I know what's wrong with that.
17:42:11 <clokep_work> I'll fix it now.
17:42:15 <clokep_work> The ACTION patch?
17:42:59 <florian> bug 1615
17:43:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1615 min, --, 1.3, clokep, RESO FIXED, IRC CTCP messages break if there is a line break
17:43:38 <clokep_work> Ah, yes. That is the one that broke it.
17:44:23 <Mook_as> Ohh, that's fun. I can type a linebreak-only message, it just doesn't show up in the channel for everybody else :D
17:44:40 <florian> Mook_as: super useful
17:44:42 <Mook_as> or at least, the logs don't have i
17:44:57 <florian> Mook_as: I'm sure there are plenty of other ways to display junk in a *local* conversation though :-P
17:47:58 <instantbot> clokep@gmail.com requested review from the wind for attachment 1933 on bug 1718.
17:48:01 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1718 nor, --, ---, clokep, ASSI, Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
17:49:07 <clokep_work> Bah instead of erroring with a wrong username it just asks no one?
17:49:50 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1933 on bug 1718.
17:51:57 <clokep_work> Fastest bug fix ever?! :P
17:55:45 <-- igorko has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
17:59:19 <-- jb has quit (Ping timeout)
18:00:05 <clokep_work> florian: Feel free to punt that to aleth.
18:00:13 * clokep_work wonders if "punt" is an American term...
18:01:23 * Mook_as would suspect rugby/football, http://en.wikipedia.org/wiki/Punt_kick
18:02:44 <clokep_work> Mook_as would be right. ;)
18:04:59 * Mook_as cries
18:05:16 <Mook_as> I have awesome program that crashes gdb when I run it under gdb.... sigh
18:07:42 <florian> Mook_as: I suspect it's not that awesome if you need gdb :-P
18:10:16 <Mook_as> well, I only need gdb to figure out the reason this thing crashes without it....
18:10:17 <florian> so the AMO review of my libpurple in Tb add-on was defined because I provided the patches to build it rather than the source code.
18:10:39 * florian wonders if someone that doesn't know that a patch can contain source code is competent to review binary add-ons.
18:11:57 <Mook_as> does GPL actually allow shipping only patches?
18:12:20 <florian> and there's of course no way to reply to that comment
18:12:35 <florian> The email address of that guy is in the internal phonebook though :)
18:12:43 <florian> well, not sure if ":)" or ":(" actually
18:13:30 <clokep_work> Isn't a patch the source code? :P
18:13:34 <Mook_as> oh, somebody-not-jorgev does binary bits for tb?
18:13:44 <clokep_work> Doesn't rkent do them too?
18:13:58 <florian> " If you have any questions or comments on this review, please reply to this email" hmm, maybe that works too, I'm not sure how closely they read the complains from people with denied reviews :)
18:14:23 <florian> clokep_work: I think rkent sends them a source tarball, not patches to send to the try server
18:14:58 <Mook_as> attach a hg bundle ;)
18:16:10 <clokep_work> florian: Sure, I mean doesn't he do /reviews/?
18:16:34 <florian> clokep_work: he isn't allowed to review binary add-ons, these need to be reviewed by amo-admins, not amo-editors
18:16:53 <clokep_work> Ah, interesting.
18:18:49 <florian> clokep_work: so your patch is implementing support for 2 new RFCs? :)
18:19:09 <Mook_as> and the guy doesn't hang out in #amo-editors? (maybe the tbird ones don't, I have no idea)
18:19:27 <florian> he does
18:19:44 <florian> but I email-replied to amo-editors@mozilla.org
18:19:56 <clokep_work> florian: Hmm?
18:19:59 <florian> so I'm not sure if they would appreciate being pinged a few seconds later
18:20:03 <florian> clokep_work: https://bugzilla.instantbird.org/attachment.cgi?id=1933
18:20:35 <clokep_work> Uhhh....that didn't show up when I did hg st. :-/
18:20:50 <clokep_work> (I'm fairly certain my hg repo on this machine is corrupt somehow, btw.)
18:20:58 <clokep_work> Want me to remove that part of the patch? :P
18:21:24 <florian> well, if you take that opportunity to also add a commit message that I won't have to edit, yes :)
18:21:28 <florian> (it looks fine otherwise)
18:21:59 <clokep_work> I can do that, I suppose.
18:24:15 <florian> clokep_work: btw, I typed "/j amo-editors" first before typing the correct "/j #amo-editors"
18:24:42 <clokep_work> florian: That stinks. :P
18:24:47 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1933 on bug 1718.
18:24:48 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1934 on bug 1718.
18:24:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1718 nor, --, ---, clokep, ASSI, Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
18:25:05 <florian> apart from the discussion related to making # optional, it seemed really strange that it opened an "amo-editors" conversation containing only "20:07:57 - There is no channel: amo-editors." as a system message.
18:25:19 <clokep_work> What would you prefer?
18:25:32 <florian> the error message in the conversation where I typed my /j command!
18:25:49 <florian> opening a tab makes it look like it worked
18:25:52 <clokep_work> File a bug.
18:26:17 <clokep_work> I haven't wanted to implement that (a bunch of commands really need it), you need to mark a conversation as waiting for a response then.
18:26:32 <florian> do we have a way to get the difference between /j and the Join Chat dialog (that obviously isn't attached to any existing conv)?
18:26:55 <clokep_work> I'm not sure.
18:32:12 <clokep_work> Do we have any way to tell the join dialog that we didn't successfully join?
18:32:21 * clokep_work would love someone to actually look at the join tab idea.
18:33:21 <florian> clokep_work: I think wnayes said he wanted to look at it
18:33:31 <florian> once the import wizard is finished of course :)
18:33:31 <clokep_work> :)
18:33:52 <florian> clokep_work: maybe you can throw an error in the joinChat method to prevent closing the dialog
18:34:18 <clokep_work> Hmm...we probably could do that.
18:36:45 <Mook_as> is the actual join synchronous?
18:37:32 <clokep_work> Nothing in the IRC code is synchronous.
18:37:46 <clokep_work> We throw stuff at the server and attempt to parse the response.
18:38:31 <florian> clokep_work: so that won't work, the dialog is closed synchronously
18:41:20 <clokep_work> florian: Right. :-/
18:42:47 * clokep_work cries.
18:47:29 <Mook_as> yeah, the whole dialog needs to be changed to async
18:47:40 <Mook_as> (taking success/error callbacks, probably... boo)
18:48:19 --> chrisccoulson_ has joined #instantbird
18:49:46 <-- chrisccoulson has quit (Ping timeout)
18:50:07 * florian is getting increasingly irritated by the amo review process.
18:50:18 <clokep_work> Did you get a response?
18:50:59 <Mook_as> he did, yes, on IRC at least.
18:51:17 <Mook_as> and yeah, it's frustrating for everyone, it looks like
18:51:18 <clokep_work> Is there an on going conversation I should join to also get frustrated?
18:51:57 <Mook_as> there's #amo-editors but I've been trying to not say things, since piling on probably isn't going to help
18:52:12 * clokep_work is annoyed by rooms that don't log...
18:53:05 <florian> clokep_work: do you really need to get frustrated?
18:53:25 <clokep_work> It can't hurt. :)
18:54:45 <florian> clokep_work: do you need the backlog for entertainment? :-P
18:55:16 <Mook_as> I sent what I had :) gotta prove I'm using the JSON logging feature! :p
18:56:47 <florian> Mook_as: how is that related to JSON?
18:57:00 <clokep_work> He sent me logs from Thunderbird.
18:57:02 <clokep_work> Instead of C&P.
18:57:49 <clokep_work> florian: Frankly to me it sounds like "We're lazy, we just want to see the source of the changeset you pushed and don't care that that's not an applicable thought for this situation."
18:58:34 <clokep_work> Although the wording is a bit weird on the page of "Let's say I used" :)
18:58:51 <florian> clokep_work: I'm quite upset by the "This version of your add-on has been disabled." part of the automatic email too.
18:59:21 <florian> "I don't need a detailed build document, just the source." in the comment I received in the email.
18:59:56 <clokep_work> florian: Apply your patches and send him the source of comm-central + mozilla-central bundled? :-D
19:00:16 <florian> bah...
19:02:08 <florian> what's the process? answer: "I don't know then. I'll see when I see."
19:02:20 <florian> how can we optimize for such a process?
19:03:55 * florian feels that at this point he would increase the likelihood of a positive outcome by saying "thanks for <something>" and leaving.
19:04:02 <florian> but it's really hard to find something I'm thankful for in all that non sense.
19:04:08 <Mook_as> all the fish?
19:04:19 <florian> uh, that last message is even better
19:04:32 <clokep_work> florian: Are they Mozilla employees?
19:04:37 <florian> yes
19:04:52 <clokep_work> Honestly? I would complain to my manager about this.
19:05:03 <clokep_work> If I had an interaction like this at my job, I would go talk to my department head.
19:05:13 <clokep_work> They're not only being unhelpful, but rude.
19:05:15 <florian> well, the only one for whom I wasn't sure is connected to IRC from .mv.mozilla.com
19:06:16 <florian> I'm still trying to think of a non rude answer to "Solution is obvious: Fix Thunderbird so you don't need a binary component to add new protocols."
19:06:41 * clokep_work almost responded to that.
19:06:57 <florian> what were you thinking of replying?
19:08:18 <clokep_work> Just saying that it was really rude and not a feasible solution.
19:08:27 <clokep_work> But that seemed not useful.
19:08:29 <florian> clokep_work: "If I had an interaction like this at my job, I would go talk to my department head." This is what makes me think it's worse in this case: they probably behave exactly in the same way (or even worse) with volunteers.
19:10:28 <florian> ah, you replied just when I did :-/
19:12:19 <florian> how did you like my reply? I tried irony as I couldn't find something politically correct to say that would match how I feel :).
19:12:48 <clokep_work> Yes....emotion is hard to tell over IM.
19:13:22 <florian> I think political correctness is even harder face to face though ;)
19:16:50 <Mook_as> if we want something useful out of this, though, it's basically "needs more infra around building binary components" :\
19:17:22 <clokep_work> florian: Did you ever actually try to emscripten libpurple?
19:17:25 <clokep_work> (Just curious.)
19:17:31 <florian> no
19:17:42 <florian> I don't understand how that can work for low level network stuff
19:18:05 <clokep_work> Ah, alright. :(
19:18:07 <florian> ""needs more infra around building binary components" :\" not going to happen. I discussed it a few times already
19:22:00 <Mook_as> oh, no, I meant on your side
19:22:22 <Mook_as> a script to push to try + create a hg bundle, and upload the whole chunk somewhere
19:23:28 * florian finally found something to be thankful for, and moves on.
19:23:56 <florian> Mook_as: what makes you think I intend to build it more than once?
19:25:39 --> Mic has joined #instantbird
19:25:39 * ChanServ sets mode +h Mic 
19:26:24 <Mic> Hello.
19:26:43 <clokep_work> florian: Totally unrelated question..ddid you figure out what is left to get into c-c?
19:27:00 <florian> no
19:27:58 <Mook_as> florian: mostly because I assumed there will be newer libpurple updates in the future
19:28:22 <Mook_as> (as in, not short term, but seemed reasonable to have some sort of release at some point)
19:28:25 <florian> Mook_as: such an update would need to be reviewed by amo-admins again
19:28:34 <florian> Mook_as: so no, that's not going to happen
19:28:57 <florian> the next planned release of that add-on is for compatibility with Tb 24
19:40:31 * flo-away is now known as flo
19:40:45 * flo is now looking at this machine, and not the one connected from "florian"
19:43:48 * clokep_work converted one of his friends to Instantbird from GMail + Facebook + Skype!
19:45:54 --> DGMurdockIII has joined #instantbird
19:46:51 --> jb has joined #instantbird
19:49:34 <flo> :)
19:50:20 <clokep_work> I want to convert one of my other friends too, but she wants video. Bleh.
19:50:49 <flo> such a crazy request :-P
19:51:10 <clokep_work> I thought so!
19:51:56 * clokep_work should have replied "Set the patch to r? clokep."
19:52:07 <clokep_work> I don't she'd get (enjoy) that though.
19:54:10 <flo> clokep_work: that's what I did to that amo reviewer ;)
19:54:23 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
20:04:25 <clokep_work> :)
20:04:38 <clokep_work> We'll see what happens.
20:09:52 <-- instant-buildbot has quit (Ping timeout)
20:09:55 --> instant-buildbot has joined #instantbird
20:09:56 * ChanServ sets mode +v instant-buildbot 
20:10:52 <-- ivan has quit (Ping timeout)
20:11:22 --> ivan has joined #instantbird
20:19:04 <flo> mconley: I replaced all the do_check_eq with assert_true without looking. Thanks for spotting these possible simplifications :).
20:19:28 <mconley> flo: np. :)
20:20:29 --> EionRobb has joined #instantbird
20:27:22 <-- jb has quit (Quit: jb)
20:27:52 --> jb has joined #instantbird
20:30:01 <-- chrisccoulson_ has quit (Ping timeout)
20:30:45 --> chrisccoulson has joined #instantbird
20:31:21 <flo> ah, tb planning is still about money :-S
20:36:16 <EionRobb> don't be silly, you can't make money from open source ;)
20:36:52 <flo> EionRobb: you can post that to the list if you want
20:37:17 <EionRobb> hahaha
20:37:55 <flo> EionRobb: at this point the discussion is about how the money will be used. Not if we can make any :-P
20:38:55 <EionRobb> the money should be used in exchange for goods and services
20:39:02 <EionRobb> money can be used to buy more peanuts
20:39:16 * clokep_work <3s peanuts.
20:48:46 <DGMurdockIII> clokep_work:  jisti has video
20:49:32 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1935 on bug 1704.
20:49:34 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1704 nor, --, ---, clokep, ASSI, Port Bug 787640 - XMPP: Account wizard and account settings window dimension too small, input fields
20:49:49 <clokep_work> DGMurdockIII: I use Instantbird, I'm not going to use jisti.
20:50:31 <DGMurdockIII> clokep_work:  your friend and you could look at how they have implempent video support with Jingle 
20:50:47 <DGMurdockIII> to get it support in instantbird
20:51:00 <clokep_work> DGMurdockIII: I don't think that would be helpful. And my friend isn't technically inclined at all. :P
20:51:12 * clokep_work finds reading other program's code generally not helpful in implementing something.
20:51:22 <flo> especially something that's clearly specified ;)
20:59:24 <-- jb has quit (Ping timeout)
21:08:32 <-- mconley has quit (Input/output error)
21:18:23 --> Kaishi has joined #instantbird
21:19:56 <-- AlexanderSalas has quit (Client exited)
21:55:39 <flo> wow, I just received the "IT Desktop Newsletter - October 2012 Edition"!
21:56:29 <clokep_work> . . .
21:56:42 <flo> the 6th (and last) part of the newsletter reads like this: http://pastebin.instantbird.com/83167
21:58:03 <clokep_work> Fairly nicely written.
21:58:49 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
21:59:46 <Mook_as> did they recommend cz?
22:00:38 <flo> Mook_as: last month they recommended: Adium, and if you happen to not use a Mac the Windows version of Adium is called Pidgin
22:01:24 <Mook_as> ah. that's... way more... non-technical than I expected. but okay
22:02:06 <flo> Mook_as: I don't think technical Mozilla employees need help selecting an IRC client ;)
22:04:50 <clokep_work> No, they just use telnet.
22:04:52 <clokep_work> (o_O)
22:09:22 <flo> I honestly didn't expect that when I wrote my (slightly ranting) reply to the previous edition of that newsletter :)
22:09:43 * clokep_work goes to look at download stats. ;)
22:12:17 <clokep_work> flo: Does http://ftp.instantbird.com/instantbird/stats/last2years.php roll to be the actual newest two years always?
22:12:47 <flo> it's not exactly 2 years
22:13:02 <flo> it's just the last N data points from the whole graph, so that it's more visible
22:13:04 <clokep_work> That wasn't the important part of my question. ;)
22:13:07 <clokep_work> OK.
22:13:11 <flo> and I think N is close to 2 years
22:13:14 <flo> probably around 700
22:13:30 <flo> that's not the download stats though ;)
22:13:39 <clokep_work> I know, it's update pings. :)
22:13:41 <flo> they are at http://queze.net/goinfre/instantbird-1.2.download-count.txt
22:13:44 <clokep_work> Which have been climbing.
22:13:52 <flo> (and 14k seems ridiculously low to me :-S)
22:15:38 <clokep_work> That doesn't include updates, right? Just new downloads?
22:15:47 <flo> right
22:28:00 <clokep_work> flo: http://blog.instantbird.org/2012/10/google-summer-of-code-2012-roundup/#comments
22:29:22 <flo> clokep_work: thanks for sharing :)
22:29:44 <clokep_work> flo: Just trying to make it feel more worth it. ;)
22:29:48 <flo> good luck to that guy if he wants to find that add-on today again ;)
22:33:24 <-- clokep_work has quit (Input/output error)
22:34:35 --> clokep_work has joined #instantbird
22:34:35 * ChanServ sets mode +o clokep_work 
22:39:16 <-- Optimizer has quit (Ping timeout)
22:40:21 --> Optimizer has joined #instantbird
23:31:08 <instantbot> florian@instantbird.org granted review for attachment 1934 on bug 1718.
23:31:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1718 nor, --, ---, clokep, ASSI, Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
23:39:58 <clokep_work> Thanks for the reviews. :)
23:40:26 <instantbot> florian@instantbird.org granted review for attachment 1935 on bug 1704.
23:40:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1704 nor, --, ---, clokep, ASSI, Port Bug 787640 - XMPP: Account wizard and account settings window dimension too small, input fields
23:40:58 * clokep_work awaits his confirmation of his bonus points.
23:41:02 <flo> clokep_work: I'm just eliminating the very simple patches that I can review even while tired, to avoid letting my review queue grow out of control again :)
23:41:27 <flo> is the confirmation once it's tested on a nightly?
23:41:48 * clokep_work sighs. OK...
23:42:16 <flo> or should we let instantbot count the points?
23:42:21 <clokep_work> Maybe!
23:42:22 <flo> clokep_work++ for that patch anyway :)
23:42:33 * clokep_work will close the bugs if you're pushing.
23:42:48 <flo> I'm not going to push on c-c this evening
23:43:04 <flo> so don't close the legacy auth one yet :)
23:43:35 <clokep_work> I would have gotten the revision. :)
23:43:39 <clokep_work> And noticed you didn't push.
23:46:28 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/25d1ab3841be - Florian Qu├Ęze - Bug 789745 - Cannot connect to XMPP servers that don't support SASL authentication, r=clokep.
23:46:29 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/da62debcd5ae - Patrick Cloke - Bug 1718 - Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG, r=fqueze.
23:46:30 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/94e3a2851bee - Richard Marti - Bug 787640 - Account wizard and account settings window dimension too small, input fields cut off/cropped, port input hidden, r=florian.
23:46:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/8c75967e413a - Patrick Cloke - Bug 1704 - Port Bug 787640 - XMPP: Account wizard and account settings window dimension too small, input fields cut off/cropped, port input hidden, r=fqueze.
23:46:35 <instantbot> clokep@gmail.com set the Resolution field on bug 1704 to FIXED.
23:46:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1704 nor, --, 1.3, clokep, RESO FIXED, Port Bug 787640 - XMPP: Account wizard and account settings window dimension too small, input fields
23:47:56 <instantbot> clokep@gmail.com set the Resolution field on bug 1718 to FIXED.
23:47:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1718 nor, --, 1.3, clokep, RESO FIXED, Error: ERR_NOTEXTTOSEND: No text to send for PRIVMSG.
23:51:14 <flo> Good night
23:51:44 <clokep_work> Goodnight!