#instantbird log on 09 21 2012

All times are UTC.

00:19:04 <instant-buildbot> build #318 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/318
00:35:21 --> FireFly_TB has joined #instantbird
00:37:04 <-- FireFly_TB has quit (Ping timeout)
00:39:59 <-- wesj has quit (Input/output error)
00:45:37 <-- clokep_work has quit (Input/output error)
00:46:26 --> clokep_work has joined #instantbird
00:46:26 * ChanServ sets mode +o clokep_work 
00:53:20 <-- clokep_work has quit (Ping timeout)
00:55:42 --> clokep_work has joined #instantbird
00:55:42 * ChanServ sets mode +o clokep_work 
01:00:22 <-- wnayes has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
01:16:52 <-- Mook_as has quit (Quit: Mook_as)
01:36:34 <instant-buildbot> build #286 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/286
01:48:37 --> danieltiecher has joined #instantbird
01:49:18 <danieltiecher> hey guys!
01:50:05 <danieltiecher> dropping a quick question, can I use your protocol code to run a chat server say on node or rhino? :)
01:50:25 <clokep_work> Our code is MPL, so as long as you abide by the license, it should be fine.
01:50:35 <clokep_work> And if you make any improvements we'd love to have them upstreamed to us. :-D
01:50:58 <clokep_work> (And personally I'd think it's cool if you'd hang out and let us know when you finish whatever you're working on and stuff.)
01:51:22 <danieltiecher> well being told that it is possible is really nice :)
01:51:47 <danieltiecher> and will definitely make any improvements reach you upstream
01:52:09 <danieltiecher> i've started my quest looking a way to compile libpurple using emscripten
01:52:26 <clokep_work> Ah, well if you can do /that/ we'd love to know that!
01:52:48 <danieltiecher> but that got really nasty as pidgin and glib are not easily cross-compiled
01:52:58 <clokep_work> I'd imagine. :(
01:53:05 <clokep_work> You should need to compile pidgin though?
01:53:06 <clokep_work> shouldn't
01:53:25 <clokep_work> What's your overall goal here? A IM transport or some kind?
01:54:03 <danieltiecher> yep, my goal was being able to manage msn and gtalk accounts on node
01:54:11 <danieltiecher> a somewhat small meebo for ex.
01:54:52 <danieltiecher> then i tried going with node-ffi and creating the bindings by hand but that got really tiresome, so i stumbled upon instantbird
01:55:14 <danieltiecher> and apparently you have implemented all the protocols in javascript (how nut is that!)
01:55:38 <EionRobb> no, I didn't say all! :)
01:56:09 <danieltiecher> true, but i've assumed it :)
01:56:19 <clokep_work> danieltiecher: We have XMPP and IRC and Twitter in JS.
01:56:34 <clokep_work> Warning: parts might be fairly Mozilla specific JavaScript.
01:57:02 <danieltiecher> hmm, then i might need to invest some quality time in it
01:57:20 <danieltiecher> but what about msn support? are you using libpurple then?
01:58:28 <danieltiecher> and another question: assuming i have instant bird installed on my machine, can i interact with it using js? :)
01:59:33 <danieltiecher> because then i could go on creating a proof of concept doing this, would need to be able to add an account, see my buddy list, send and receive messages
02:00:14 <danieltiecher> and if the project gets approved then i can have a go on trying to port it to run on node
02:00:48 --> mconley has joined #instantbird
02:03:17 <clokep_work> danieltiecher: MSN is via libpurple, but Microsoft has an XMPP interface that could be used.
02:03:22 <clokep_work> Just no one has written code yet for it.
02:03:40 <clokep_work> If Instantbird (one word, please!) is running, you can isntall extensions to let it interact with various things, yes.
02:04:03 <clokep_work> I think there's a couple of extensions for Mozilla toolkit projects that let you control it from outside (Mook would know if he were here...)
02:04:27 <danieltiecher> sorry about the space thing, colloquy is the culprit behind it =/
02:04:54 <danieltiecher> instantbird
02:04:58 <danieltiecher> there :)
02:05:29 <EionRobb> msn over xmpp is alright
02:05:37 <EionRobb> a bit limited, but mostly stable
02:05:51 <EionRobb> the annoying bits is that they use see-other-host now, which libpurple doesn't support
02:06:07 <EionRobb> but the upside is that auth tokens can last for more than a day
02:06:45 <clokep_work> EionRobb: Ah, they can? I didn't realize they lasted longer now.
02:06:57 * clokep_work would really like to support that and drop libpurple's crashy MSN code...
02:07:06 <clokep_work> danieltiecher: Not a big deal. :)
02:07:37 <danieltiecher> wow, didn't knew libpurple tokens only lasted a day
02:07:55 <EionRobb> clokep_work: also, no file transfers (unless you count storing data in that ms cloud thing) and avatars aren't necessarily those that you'd see with msn
02:07:59 <danieltiecher> looks like i'll be going to have a hell of a ride in this project
02:08:06 <EionRobb> no, the msn xmpp auth tokens used to only last for a day
02:08:07 <clokep_work> EionRobb: FT doesn't bother me. ;)
02:08:11 <EionRobb> so you'd have to re-login on the website
02:08:16 <EionRobb> clokep_work: FT should bother you! :P
02:08:26 <danieltiecher> oh :)
02:08:28 <clokep_work> danieltiecher: libpurple doesn't use the XMPP transport. It uses the pure MSN protocol, it doesn't have any limits.
02:08:31 <EionRobb> but now there's a refresh token that will last a year
02:08:31 <clokep_work> EionRobb: Shhh.
02:08:45 <danieltiecher> clokep_work: yep, do know that
02:09:34 <danieltiecher> so i guess i'll need to first research a way to talk to instantbird through js and create my proof of concept
02:10:24 <danieltiecher> then after impressing my client i'll be able to convince him to work on it properly :)
02:10:36 <instant-buildbot> build #304 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/304
02:11:32 <clokep_work> danieltiecher: I'm not positive everything would be easily converted to node, you could almost definitely run the chat/ aspects in spidermonkey though.
02:12:13 <danieltiecher> probably i'll have a biased opinion from you guys but if you are familiar with node-ffi, would you think that investing time on creating a bind to libpurple wouldn't easier for a proof of concept?
02:12:31 <danieltiecher> running it in spidermonkey wouldn't be a problem or them
02:12:57 <danieltiecher> as long as i can easily talk with the chat server using js should be fine
02:13:24 <clokep_work> What is node-ffi?
02:14:36 <danieltiecher> is a tool to create js bindings for cpp code
02:14:58 <danieltiecher> so i could create the necessary bindings for libpurple and go with that
02:15:08 <danieltiecher> https://github.com/rbranson/node-ffi
02:15:45 <clokep_work> Interesting.
02:16:10 <clokep_work> I'm not sure which would be easier...I'd like to think we have an easier API to deal w/, but who knows
02:16:28 <danieltiecher> indeed, the only problem is creating the binding by hand, as my C skills are not that great :P
02:17:14 <danieltiecher> well, after having a look through lib purple's code, anything can be better than that
02:18:10 <danieltiecher> (not trying to be harsh on you, i believe you do have nice a nice API but libpurple is really ugly :P )
02:18:46 <-- mconley has quit (Input/output error)
02:18:53 <clokep_work> What?
02:19:03 <clokep_work> Why are you talking about C? :-S
02:19:16 <clokep_work> You can interact w/ our code purely in JavaScript (via XPCOM).
02:19:19 <EionRobb> aww, I really like libpurple api
02:19:25 <clokep_work> Although I think all of our core interfaces are in JS now anyway.
02:19:31 <danieltiecher> not your code, i was talking about node-ffi
02:20:54 <clokep_work> Oh.
02:21:36 <danieltiecher> hmm, do you have any docs on interacting with your code using js?
02:22:05 <danieltiecher> one sec,my girlfriend's cat is yelling at me asking for food...
02:23:14 <EionRobb> yell back
02:23:17 <clokep_work> http://lxr.instantbird.org/instantbird/source/chat/components/public/
02:24:20 <danieltiecher> and i'm back
02:24:38 <danieltiecher> well, i fear her, cats can be mean when they want :P
02:25:26 <danieltiecher> thanks for the link clokep_work 
02:28:04 <clokep_work> Sounds like girlfriends. ;)
02:29:29 <danieltiecher> haha, she can be mean when she wants as well ;)
02:30:34 <EionRobb> you're dating a cat?  that's just sick, dude
02:31:01 <danieltiecher> wow, irc chats can get way out of hand sometimes :P
02:31:40 <EionRobb> :D
02:33:59 <danieltiecher> on a side note, found https://github.com/astro/node-xmpp and looks like i can talk to gtalk using it and msn over xmpp i assume as well
02:34:17 <danieltiecher> seems to me is my safest bet timewise
02:34:37 <clokep_work> I also know of https://github.com/simonwex/node-irc fwiw.
02:34:43 * clokep_work doesn't understand node...
02:36:53 <danieltiecher> well, node is that thing all those hipster devs are doing or were, maybe they are into scala right now...
02:37:08 <EionRobb> I thought it was erlang?
02:37:16 <clokep_work> Yes, I don't understand why it's "so great".
02:37:20 <danieltiecher> erlang and haskell as well
02:37:23 <EionRobb> :)
02:38:08 <danieltiecher> i even heard that doing fortran and asm is for true hipsters know
02:38:59 <danieltiecher> clokep_work: if you remove all the buzz, being able to code in js on the server have some uses, specially when it comes to having access for the dom in the server
02:39:08 <danieltiecher> you can do some nasty stuff with it
02:39:29 <clokep_work> danieltiecher: I guess I'm just not exciting in programming for servers then.
02:40:01 <danieltiecher> well, i'm a backend guy but do like JS a lot :)
02:40:29 <danieltiecher> specially all the nice additions that are popping in ES6
02:40:57 <danieltiecher> and by using V8 on the server I can take advantage of some of them :)
02:44:19 <clokep_work> I'm a backend guy, I hate UI. ;)
02:44:21 <clokep_work> And I like JS.
02:44:40 <clokep_work> I don't really know anything about V8...almost all SpiderMonkey for me.
02:45:34 <clokep_work> Anyway, if you really want to use node, then your best bet is to find IM-over-node premade libraries...probably.
02:47:32 <danieltiecher> yup, looks like it, wouldn't mind going with spidermonkey and talking to instantbird but my client asked me that i should prefer node based solutions because his team has some knowledge with it
02:48:14 <danieltiecher> but due to the fact that i'm a geek, i need to try every possibility i have at my disposal, specially when i'm getting paid to do it :)
02:51:26 <clokep_work> Right.
03:11:29 <-- skeledrew has quit (Connection reset by peer)
03:11:51 --> skeledrew has joined #instantbird
03:20:41 <-- danieltiecher has quit (Quit: danieltiecher)
03:24:36 <instant-buildbot> build #637 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/637
03:59:10 --> nexxuscommand has joined #instantbird
04:20:31 --> deltafalcon has joined #instantbird
04:29:08 --> Mook has joined #instantbird
04:46:59 <-- clokep_work has quit (Ping timeout)
04:50:53 <-- Kaishi has quit (Quit: Kaishi)
05:00:58 --> jb has joined #instantbird
05:15:13 <instant-buildbot> build #718 of win32-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/718
05:28:31 --> Kaishi has joined #instantbird
05:37:29 <-- EionRobb has quit (Quit: Leaving.)
05:53:00 <-- jb has quit (Connection reset by peer)
06:00:22 <-- Optimizer has quit (Ping timeout)
06:03:45 --> Optimizer has joined #instantbird
06:13:08 --> jb has joined #instantbird
06:13:44 <instant-buildbot> build #621 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/621
06:20:52 <-- Mook has quit (Quit: Mook)
06:28:58 <-- Kaishi has quit (Quit: Kaishi)
06:32:43 --> clokep_work has joined #instantbird
06:32:43 * ChanServ sets mode +o clokep_work 
07:07:34 <-- clokep_work has quit (Input/output error)
07:14:45 <-- jb has quit (Ping timeout)
07:31:19 <-- Optimizer has quit (Ping timeout)
07:34:37 --> Optimizer has joined #instantbird
08:05:28 <-- nexxuscommand has quit (Ping timeout)
08:16:36 <-- Optimizer has quit (Ping timeout)
08:18:25 --> jb has joined #instantbird
08:27:37 --> Even1 has joined #instantbird
08:27:49 <-- Even1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
08:27:59 --> Even1 has joined #instantbird
08:49:06 <flo> uh, it seems purplexpcom builds on neither gecko 16, nor 17, for different reasons: https://tbpl.mozilla.org/?tree=Thunderbird-Try :(
08:52:12 <-- deltafalcon has quit (Client exited)
09:04:41 --> sonny has joined #instantbird
09:09:13 <-- Even1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
09:12:28 * flo just stumbled on https://bugs.gentoo.org/show_bug.cgi?id=35890
09:22:20 <-- flo has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
09:39:49 --> flo-retina has joined #instantbird
09:42:48 --> barlas has joined #instantbird
09:45:58 <-- skeledrew has quit (Ping timeout)
09:49:37 --> skeledrew has joined #instantbird
09:56:10 * flo-retina is now known as florian
09:56:46 <florian> so the failure on mozilla 16 is the nsILocalFile removal (bug 1490) and the failure on Mozilla 17 is the nsnull removal
09:56:50 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1490 nor, --, ---, nobody, NEW, Remove usage of nsILocalFile for Mozilla 16
10:07:22 --> sabret00the_ has joined #instantbird
10:07:46 --> jb1 has joined #instantbird
10:08:04 <-- sabret00the has quit (Ping timeout)
10:08:28 --> jb2 has joined #instantbird
10:08:58 <-- jb has quit (Ping timeout)
10:09:24 <-- jb1 has quit (Ping timeout)
10:15:43 --> sabret00the__ has joined #instantbird
10:16:38 <-- sabret00the_ has quit (Ping timeout)
10:47:46 --> aleth has joined #instantbird
10:47:46 * ChanServ sets mode +h aleth 
10:57:59 --> Optimizer1 has joined #instantbird
10:58:02 <florian> aleth: hello :)
10:59:47 <florian> here are the changes to build purplexpcom on gecko17: https://bugzilla.instantbird.org/attachment.cgi?id=1908&action=diff
10:59:52 <florian> (I didn't do that by hand of course
10:59:53 <florian> )
11:01:16 <florian> nsnull -> nullptr, remove the NS_OUTPARAM and NS_SCRIPTABLE macros, and PRUint32 -> uint64_t in 2 places, and an nsILocalFile -> nsIFile (already required for Gecko 16).
11:14:58 --> meh has joined #instantbird
11:19:09 --> ecmuller has joined #instantbird
11:22:40 <aleth> hi flo :)
11:25:04 <-- barlas has quit (Quit: Konversation terminated!)
11:25:40 <aleth> here's hoping the other moz17 changes can also be solved with search and replace ;)
11:30:32 --> barlas has joined #instantbird
11:51:38 --> rosonline has joined #instantbird
12:08:51 <florian> aleth: am I blocking you with any other patches stuck in my review queue?
12:10:43 <aleth> Not really blocking, but I think bug 1686 is probably bitrotted by 1683
12:10:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1686 nor, --, ---, aletheia2, ASSI, Nicklist speedup: low-hanging fruit
12:11:01 <florian> instantbot: bug 1683
12:11:04 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1683 enh, --, ---, aletheia2, ASSI, Restore participants' active status if still appropriate after a reconnect
12:11:21 <aleth> (which clokep had reviewed)
12:12:23 * aleth is hoping that log viewer review unblocked Mic though ;)
12:12:49 <-- jb2 has quit (Quit: jb2)
12:19:23 <-- rosonline has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
12:35:03 <florian> I wonder how the performance of |[xL, xR] = [xR, xL];| compares to |let tmp = xL; xL = xR; xR = tmp;|
12:37:11 --> AlexanderSalas has joined #instantbird
12:40:31 --> jb has joined #instantbird
12:40:57 <aleth> Yeah... with that array structure overhead
12:41:35 <-- skeledrew has quit (Ping timeout)
12:44:22 <florian> (for the context) I'm reviewing the chat/modules changes of wnayes' patch
12:44:53 <aleth> Is it in a place where performance matters?
12:45:09 <florian> It's in a loop in the blowfish cypher
12:45:30 <florian> but I don't know how often blowfish is called, nor the size of the data
12:45:33 --> Even1 has joined #instantbird
12:45:43 --> rosonline has joined #instantbird
12:45:45 <aleth> Probably not called much atm, but if the module gets reused...
12:45:59 <florian> if it's only the password that's encrypted, it probably doesn't matter
12:46:03 <aleth> I think in his patch it's just during auth
12:46:06 <florian> if it's the whole configuration file, it's another matter :)
12:53:22 <-- aleth has quit (Input/output error)
12:54:21 --> Mic has joined #instantbird
12:54:21 * ChanServ sets mode +h Mic 
13:00:30 <florian> I should have looked at jsImporterHelper.jsm earlier :-/
13:02:19 <Mic> florian: checking with the error console, I'd say that the destructuring assignment is two orders of magnitude slower than the variable approach
13:02:30 <-- MMN-o has quit (Ping timeout)
13:02:39 <florian> how many times did you need to execute it to notice the difference?
13:03:25 <florian> and is this something that we should file as a bug of the JS engine?
13:03:34 <Mic> I ran it in a loop a million times.
13:04:02 <florian> swapping 2 variables with an array and a destructuring assignment is probably something they can optimize.
13:04:09 <Mic> The destructuring assignment took > 1000ms, the variable solution ~ 40ms (I've seen 17ms before)
13:04:36 <florian> I don't think it will be ran a million times in wnayes' code
13:04:40 <florian> (I hope so at least! :))
13:05:47 --> MMN-o has joined #instantbird
13:05:54 <Mic> That's what I used: http://pastebin.instantbird.com/78353
13:07:33 <florian> 340ms for the destructuring assigment and 15ms for the variable on my Firefox 15.0.1
13:08:10 <florian> I'll try in a nightly with ionmonkey
13:08:55 <-- sonny has quit (Ping timeout)
13:09:39 <Mic> I can file that bug on BMO by the way.
13:10:07 <florian> I'll check first if it still applies in a current nightly :)
13:12:04 <florian> 550ms with a current nightly for the destructuring assignment, 15ms (ie unchanged) for the variable
13:12:09 <florian> nice regression :-P
13:16:14 <-- rosonline has quit (Ping timeout)
13:19:18 --> clokep_work has joined #instantbird
13:19:18 * ChanServ sets mode +o clokep_work 
13:20:12 --> rosonline has joined #instantbird
13:21:49 --> FireFly_TB has joined #instantbird
13:22:19 <clokep_work> florian: Blowfish is just used for the password.
13:22:47 <florian> clokep_work: so wnayes probably doesn't care too much about performances :)
13:22:54 <florian> Mic: if you file a bug, please CC me :)
13:23:15 <clokep_work> And me!
13:24:56 <clokep_work> florian: If you want an r for that patch, r=me.
13:25:18 <florian> which patch?
13:25:26 <florian> the purplexpcom fix?
13:25:29 <clokep_work> Yes.
13:25:41 <florian> I don't need an r=, at this point it's to build a libpurple Tb add-on with the try server
13:25:49 <florian> so well, actually I need an r=, but from an AMO reviewer :(
13:29:12 <clokep_work> :(
13:30:08 <clokep_work> I understand it's "at this point", but I meant for Instantbird. ;)
13:32:06 <-- barlas has quit (Ping timeout)
13:33:47 --> mconley has joined #instantbird
13:34:59 --> barlas has joined #instantbird
13:35:05 <Mic> bye
13:35:09 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
13:35:21 <-- FireFly_TB has quit (Quit: FireFly_TB)
13:36:09 <-- clokep_work has quit (Ping timeout)
13:39:54 --> clokep_work has joined #instantbird
13:39:55 * ChanServ sets mode +o clokep_work 
13:41:21 <florian> clokep_work: you can put it in the bug then
13:41:43 <florian> in the past I think I've usually commited these bustage fixes without review
13:50:11 <clokep_work> You have. :)
13:53:44 <rosonline> florian
13:55:21 <-- clokep_work has quit (Ping timeout)
13:55:28 <florian> rosonline: hello. When you want to ask something, it's usually better to just ask it, rather than pinging someone without mentioning what you want to say ;).
13:55:40 <rosonline> OK
13:56:42 <rosonline> I sended  some archives to repo. :-) But I need to revise a sended archive. How do I?
13:58:12 <florian> you just make your changes, then hg commit and hg push (I don't know how the Tortoise UI exposes these actions, but I'm sure you already had to do them to send your first change sets :))
14:00:36 <florian> rosonline: in the purple/ folder, you replaced all existing translations with the English version, was that intentional?
14:03:32 <rosonline> no! I mixed the folder that I translated with the original folder.
14:06:04 <rosonline> But If it can't undo. I translate them and send to repo again
14:06:33 <florian> you can just paste the translated files in the folder, and send that as a new change
14:07:33 --> sonny has joined #instantbird
14:08:53 <-- barlas has quit (Quit: Konversation terminated!)
14:09:10 <rosonline> Ok
14:09:21 <rosonline> I found the original archives
14:13:37 <-- meh has quit (Ping timeout)
14:18:39 --> skeledrew has joined #instantbird
14:18:50 <-- ecmuller has quit (Quit: leaving)
14:21:53 <rosonline> Is there anyway that I could see my translations archives on the Instantbird application?
14:24:38 <florian> yes. There will still be lots of en-US strings though, as you haven't sent any file for the chat/ folder
14:26:11 <florian> if you haven't translated them, I would suggest that you take the Thunderbird translation of that folder, and that adjust the details that aren't right :)
14:26:19 <florian> the Thunderbird translation of these files are in http://hg.mozilla.org/l10n-central/pt-BR/file/tip/chat
14:28:34 --> jb1 has joined #instantbird
14:28:34 <-- jb has quit (Connection reset by peer)
14:29:51 --> meh has joined #instantbird
14:38:34 <rosonline> ok
15:01:32 <-- rosonline has quit (Client exited)
15:02:10 --> rosonline has joined #instantbird
15:02:13 <-- rosonline has quit (Quit: rosonline)
15:10:03 <-- jb1 has quit (Quit: jb1)
15:14:58 <florian> if I review the Pidgin and Colloquy importers, do we have volunteers for the other importers? :)
15:15:38 <-- Optimizer1 has quit (Ping timeout)
15:19:05 --> Optimizer has joined #instantbird
15:23:08 <-- Optimizer has quit (Ping timeout)
15:27:29 --> jb has joined #instantbird
15:48:20 --> rosonline has joined #instantbird
15:50:18 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
16:04:37 --> Optimizer has joined #instantbird
16:04:45 <-- Even1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
16:06:29 --> igorko has joined #instantbird
16:23:08 <-- sonny has quit (Ping timeout)
16:32:30 --> mikk_s has joined #instantbird
16:33:04 <-- Optimizer has quit (Ping timeout)
16:33:46 <-- mikk_s has quit (Quit: mikk_s)
16:44:42 --> Optimizer has joined #instantbird
16:55:01 <-- jb has quit (Ping timeout)
17:04:25 --> sonny has joined #instantbird
17:12:16 <-- sabret00the__ has quit (Quit: Leaving)
17:13:39 --> meh has joined #instantbird
17:17:13 --> Mook_as has joined #instantbird
17:28:31 <-- florian has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
17:46:07 --> wesj has joined #instantbird
17:59:07 <Mook_as> flo: review-ping, bug 1685 + bug 1701 (mostly the former).
17:59:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1685 enh, --, ---, mook.moz+bugs.instantbird, NEW, Allow logging to be used in non-global scope
17:59:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1701 nor, --, ---, mook.moz+bugs.instantbird, NEW, XMPP should strip whitespace around JID
17:59:19 <Mook_as> \o/ doing review-pings with the pingee not in the channel
18:12:07 <-- markh has quit (Ping timeout)
18:12:19 --> markh has joined #instantbird
18:13:45 <-- igorko has quit (Connection reset by peer)
18:15:13 --> igorko has joined #instantbird
18:28:30 <instantbot> New Instantbird (UI) bug 1702 filed by unghost@gmail.com.
18:28:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1702 enh, --, ---, nobody, UNCO, RFE: Allow localizers to ship additional Jabber networks with their localizations
18:31:35 --> Mnyromyr has joined #instantbird
18:58:35 <-- sonny has quit (Ping timeout)
19:06:54 <-- chrisccoulson has quit (Ping timeout)
19:12:01 --> chrisccoulson has joined #instantbird
19:32:39 <-- Optimizer has quit (Ping timeout)
19:34:06 --> clokep_work has joined #instantbird
19:34:06 * ChanServ sets mode +o clokep_work 
19:36:07 --> Optimizer has joined #instantbird
19:38:52 <-- clokep_work has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com)
19:47:51 --> sonny has joined #instantbird
19:51:16 <-- Optimizer has quit (Ping timeout)
19:52:47 --> Optimizer has joined #instantbird
19:54:48 <-- Optimizer has quit (Ping timeout)
19:55:15 <-- rosonline has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
19:56:12 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
20:04:54 --> Optimizer has joined #instantbird
20:18:11 <-- AlexanderSalas has quit (Quit: Goodbye - as-salamu 3alaykum)
20:18:19 --> AlexanderSalas has joined #instantbird
20:20:45 <-- igorko has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com)
20:31:17 --> wnayes has joined #instantbird
20:56:12 <wnayes> The blowfish algorithm would call the [xL, xR] swap 17 times for each decrypt/encrypt call (so for each found password). 
20:57:37 <wnayes> I suppose the first thing I'll take a look at is the var -> let conversion.
21:06:16 <-- sonny has quit (Ping timeout)
21:08:06 --> flo has joined #instantbird
21:08:06 * ChanServ sets mode +qo flo flo 
21:08:21 <flo> Mook_as knows the art of efficient review pings it seems ;)
21:09:44 <flo> wnayes: sounds like a good idea to take that var->let conversion out of the way, yes :)
21:10:53 <wnayes> flo: Would it be a good idea to look through the other UI files too while I'm at it?
21:11:42 <flo> it doesn't sound like the best use of your time, but if you want to do it, I'm not against it
21:13:06 <wnayes> OK. accountwizard.js took maybe a minute or two to switch, and I remembered there were lots of vars in the other UI files.
21:14:43 <-- mconley has quit (Input/output error)
21:15:07 <flo> maybe don't do it in instantbird/content/preferences nor in instantbird/content/tabbrowser.xml
21:15:26 <flo> those files are forks of Firefox similar files, so making them differ even more isn't a great idea
21:16:50 <flo> engineManager.js is also from Firefox
21:17:43 <flo> http://lxr.instantbird.org/instantbird/search?string=var lots of tem
21:17:44 <flo> *them
21:18:04 <flo> and it's not a straight search & replace, as we still use "var " for global variables
21:19:17 <flo> and it's possible in some cases var was actually what we meant (although I hope not!)
21:22:52 <wnayes> Hmm, maybe there are even more than I thought. I might just stick with the one file for now :)
21:23:14 <wnayes> One big patch is enough for now :)
21:30:02 --> sonny has joined #instantbird
21:30:48 <-- AlexanderSalas has quit (Quit: Goodbye - as-salamu 3alaykum)
21:31:49 <flo> wnayes: it's frequent to need a variable, and we have a lot of code that was written several years ago.
21:32:26 <wnayes> flo: Do you want the patch in a bug?
21:33:01 <flo> it's cleaner
21:33:13 <-- flo has quit (Input/output error)
21:33:15 --> flo has joined #instantbird
21:33:15 * ChanServ sets mode +qo flo flo 
21:34:15 <wnayes> Maybe a more general bug for replacing var -> let if the need arises later?
21:34:30 <flo> and I also said "but if you have it right now and want to just pastebin it, that would work too"
21:34:41 <flo> but instantbot shows "21:33:13 <-- flo has quit (Input/output error)" instead :-/
21:35:50 <Mook_as> the network decided just putting it in a pastebin was a bad idea and disconnected you rather than let you say it :p
21:36:27 <flo> Mook_as: possibly
21:43:28 <instantbot> New Instantbird (UI) bug 1703 filed by wnayes@gmail.com.
21:43:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1703 tri, --, ---, nobody, NEW, Change use of var to let in older code
21:46:40 <instantbot> wnayes@gmail.com requested review from florian@instantbird .org for attachment 1909 on bug 1703.
21:46:43 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1703 tri, --, ---, nobody, NEW, Change use of var to let in older code
21:48:29 <-- meh has quit (Quit: OPPA GANGNAM STYLE)
21:48:42 <-- sonny has quit (Ping timeout)
21:52:38 --> sonny has joined #instantbird
22:01:12 <instantbot> florian@instantbird.org granted review for attachment 1909 on bug 1703.
22:01:15 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1703 tri, --, ---, nobody, NEW, Change use of var to let in older code
22:01:19 <flo> wnayes: I assume I should push that right away, right? :)
22:01:33 <flo> maybe with one of Mook_as' patches to keep him happy :)
22:02:47 <Mook_as> (insert nagging here, too lazy to think of them)
22:03:24 <flo> do you really prefer that style re bug 1701?
22:03:27 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1701 nor, --, ---, mook.moz+bugs.instantbird, NEW, XMPP should strip whitespace around JID
22:03:58 <flo> when there's more than one line we rarely omit the { return } even when it's a single expression
22:03:59 <Mook_as> oh, that was only because it wasn't that obvious (IMHO) what the split/[0] was doing
22:04:16 <Mook_as> ah. nah, no preference on that bit
22:05:33 <flo> Mook_as: we could also put a real comment above the whole method "// Keep the non white space characters up to the first slash and ensure they are lowercase" and put the code back on one line :-D
22:05:48 <-- sonny has quit (Ping timeout)
22:07:39 <Mook_as> yep. but at this point discussion over the formatting has way overshadowed the actual code change :p
22:08:04 <flo> how many versions of the format can we find?
22:15:36 <Mook_as> oh, I can probablye get... creative
22:16:37 <flo> :-D
22:16:43 <Mook_as> aJID\n     .trim().\n        .split(/\//,        1)\n.shift()\n           ["toLowerCase"]                   (),
22:18:37 <flo> that's just inefficient though :-P
22:19:09 <instantbot> florian@instantbird.org granted review for attachment 1907 on bug 1701.
22:19:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1701 nor, --, ---, mook.moz+bugs.instantbird, NEW, XMPP should strip whitespace around JID
22:20:59 <instantbot> florian@instantbird.org set the Resolution field on bug 1701 to FIXED.
22:27:54 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/cb7435023341 - Will Nayes - Bug 1703 - Change use of var to let in older code (accountWizard.js), r=fqueze.
22:27:55 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/37d88b32d50e - Mook - Bug 1701 - XMPP should strip whitespace around JID, r=fqueze.
23:39:38 <-- Optimizer has quit (Connection reset by peer)