All times are UTC.
00:00:37 * flo wonders what .def files need to include exactly 00:01:05 <flo> more specifically, do I have to add an NSModule line to purple.def before using it for purplexpcom.dll? 00:04:43 <Mook_as> sounds like yes; http://msdn.microsoft.com/en-us/library/hyx1zcd3.aspx 00:09:39 <flo> it's declared with |extern "C" NS_EXPORT| 00:10:13 <Mook_as> I thought if you are using def files, the normal export stuff is ignored? 00:11:01 <flo> that's my question 00:11:17 <flo> is __declspec(dllexport) ignored if a .def file is specified on the link.exe command line 00:12:08 <flo> the page you linked says "There are three methods for exporting a definition, listed in recommended order of use: 1. The __declspec(dllexport) keyword in the source code 00:12:09 <flo> 2. An EXPORTS statement in a .def file 00:12:09 <flo> 3. An /EXPORT specification in a LINK command 00:12:09 <flo> All three methods can be used in the same program." 00:12:30 <flo> I suspect that means I don't need to add NSModule to the def file, but it's not really clear 00:13:49 <Mook_as> ah. perhaps. 00:14:00 <Mook_as> best way to tell is to build it, and stare at it and see if it's exported :) 00:14:01 <flo> anyway, it's too late to break the Windows build today. I'll see what I can do tomorrow :-P. 00:14:27 <flo> I don't see any .def file for libxml2 and it's clearly used correctly, so I would assume it's ok 00:14:39 <flo> (or I missed the place where libxml2's def file is declared :)) 00:15:18 <flo> Good evening/night 00:19:05 <instant-buildbot> build #308 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/308 00:40:28 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 1836 on bug 1448. 00:40:29 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 1838 on bug 1448. 00:40:30 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1448 nor, --, ---, aletheia2, ASSI, Handle bad log files properly 00:42:49 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 1838 on bug 1448. 00:42:50 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 1839 on bug 1448. 00:42:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1448 nor, --, ---, aletheia2, ASSI, Handle bad log files properly 00:52:27 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 1839 on bug 1448. 00:52:28 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 1840 on bug 1448. 00:52:29 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1448 nor, --, ---, aletheia2, ASSI, Handle bad log files properly 01:00:04 <-- Mook_as has quit (Quit: Mook_as) 01:12:13 <instantbot> firstname.lastname@example.org cancelled review?(florian@instantbird .org) for attachment 1840 on bug 1448. 01:12:14 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 1841 on bug 1448. 01:12:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1448 nor, --, ---, aletheia2, ASSI, Handle bad log files properly 01:13:01 <-- Suiseiseki has quit (Quit: Leaving) 01:15:46 <-- aleth has quit (Quit: Au revoir) 01:32:25 <-- wnayes1 has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 01:40:14 --> Suiseiseki has joined #instantbird 01:53:55 <instant-buildbot> build #276 of macosx-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/276 02:22:13 <instant-buildbot> build #295 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/295 02:41:47 --> Mook has joined #instantbird 02:45:27 <-- groovecoder has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com) 03:01:00 <-- skeledrew has quit (Client exited) 03:01:08 --> skeledrew has joined #instantbird 03:31:56 <instant-buildbot> build #609 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/609 04:24:02 <-- chrisccoulson has quit (Ping timeout) 04:28:20 <-- Suiseiseki has quit (Ping timeout) 04:38:16 --> chrisccoulson has joined #instantbird 04:45:16 --> Suiseiseki has joined #instantbird 05:03:49 <instant-buildbot> build #688 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/688 06:08:06 <-- jb has quit (Quit: jb) 06:14:00 <instant-buildbot> build #594 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/594 07:15:16 --> jb has joined #instantbird 07:31:59 --> Optimizer has joined #instantbird 08:09:51 <-- jb has quit (Ping timeout) 08:14:01 <-- flo has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 08:14:22 --> flo has joined #instantbird 08:14:22 * ChanServ sets mode +qo flo flo 09:18:42 --> aleth has joined #instantbird 09:18:43 * ChanServ sets mode +h aleth 09:22:25 <-- aleth has quit (Quit: Au revoir) 09:22:54 --> aleth has joined #instantbird 09:22:55 * ChanServ sets mode +h aleth 09:31:59 <-- aleth has quit (Quit: Au revoir) 10:17:00 --> mmkmou has joined #instantbird 10:36:53 --> unghost has joined #instantbird 10:38:42 <unghost> flo, Hi, Florian. I've sent you letter about Russian translation for Instantbird. Did you get it? 10:39:14 <flo> unghost: yes, thanks :). 10:40:25 <flo> I wasn't sure exactly how I could reply, except that I'm quite happy that you are volunteering to maintain this locale of Instantbird .:) 10:40:41 <unghost> flo, So, can I bring up russian l10n up to date? Wiki says that I can not do it without permission from locale manager? 10:40:46 <flo> It's too late to localize Instantbird 1.2 10:41:04 <flo> but 1.3 should be released in a few months 10:41:20 <flo> unghost: well, the concept of "locale manager" makes sense only if there are more than one translators for the locale 10:41:37 <flo> if the current one has disappeared and you start translating, you should become the new locale manager I think :) 10:41:50 <unghost> ok. 10:42:51 <unghost> My Empathy installation has been absolutely broken recently, so I'll use Instantbird nowadays 10:43:01 <flo> :) 10:49:18 <flo> unghost: should I use "unghost" as your username for the hg account? 10:51:01 <unghost> flo, http://hg.mozilla.org/l10n-central/ru/pushloghtml 10:51:16 <unghost> username = Alexander Slovesnik <firstname.lastname@example.org> 10:51:37 <unghost> from .hgrc 10:53:00 <unghost> flo, Do I need to use SSH key for check-in? 10:53:12 <flo> no, we it's using https 10:54:11 <flo> you will be pushing to https://hg.instantbird.org/l10n/ru/ and when pushing it will ask for a username (we usually take the IRC nick) and a password (I'll generate one and email it to you) 10:55:01 <flo> I'll take care of this later today :). 10:55:08 <unghost> flo, Thanks 10:55:48 <unghost> hm, in this case please use unghost as login 10:59:56 --> aleth has joined #instantbird 10:59:56 * ChanServ sets mode +h aleth 11:19:52 <-- Optimizer has quit (Ping timeout) 11:20:39 --> Optimizer has joined #instantbird 11:30:39 <-- Optimizer has quit (Ping timeout) 11:33:10 --> Optimizer has joined #instantbird 11:46:39 <-- Optimizer has quit (Ping timeout) 11:52:17 --> Optimizer has joined #instantbird 12:04:47 <-- chrisccoulson has quit (Ping timeout) 12:07:42 <-- Optimizer has quit (Ping timeout) 12:11:12 --> Optimizer has joined #instantbird 12:13:15 <-- Optimizer has quit (Ping timeout) 12:17:01 --> Optimizer has joined #instantbird 12:18:57 --> chrisccoulson has joined #instantbird 12:19:39 <-- Optimizer has quit (Ping timeout) 12:24:30 --> barlas has joined #instantbird 12:35:19 <aleth> Hmm, what happened to clokep's twitter patch that ensured the topic was always set? 12:35:30 <aleth> If it landed, it's not working... 12:50:50 <-- skeledrew has quit (Ping timeout) 12:53:47 <-- chrisccoulson has quit (Ping timeout) 12:56:06 <flo> aleth: https://email@example.com it's in my review queue 12:57:09 <aleth> OK then that explains it :) 12:58:22 --> skeledrew has joined #instantbird 12:58:27 <aleth> I was wondering if there could be a better use for the topic in twitter, but I couldn't come up with anything. 12:59:22 <flo> what's unclear for twitter is how we can find a way to display both direct messages, and users' timelines 12:59:35 <flo> both seem like conversations with a specific username :-S 12:59:41 <aleth> yes :( 13:00:37 <aleth> I tend to think other user's timelines should be displayed as MUCs, which would be part of the answer 13:01:24 <flo> but we would need the context menu to open them then, right? 13:01:32 <aleth> Yes. 13:01:41 <aleth> Then you'd label the tab "@whoever timeline" just like your own... and it would be distinct from DMs 13:02:14 <flo> why do you think it is a MUC? Would it be because you would display the original author of RTs? 13:02:34 <aleth> ideally we'd want the context menu on the tweet and on the participant too 13:03:28 <aleth> Just because it's a timeline (just not yours), with lots of different people speaking. It would be nice to have different colours etc. and in the nicklist, the people followed by that person 13:04:15 <flo> "lots of different people speaking"? 13:04:20 <aleth> "lots of different people speaking" yes, I meant RTsd 13:04:20 <flo> isn't it only that user speaking? 13:04:44 <aleth> But then I'm a bit unsure about how RTs should be displayed as well :-S 13:04:45 <flo> in that case we should also display RT'ed tweets as being from their author in the regular timeline 13:06:00 <aleth> yes... I suppose one would need a "retweeted by" somewhere. Not sure how we would do that 13:07:26 <flo> %S RT by %S ? 13:07:32 <flo> isn't that what twitter.com does anyway? 13:08:03 <aleth> twitter.com shows the original tweet and a "Retweeted by" text in grey underneath 13:10:25 --> chrisccoulson has joined #instantbird 13:11:21 <flo> btw, logged twitter timelines are ugly in Tb because the icons are missing 13:11:29 <flo> I'm not sure how we can log that correctly. 13:11:35 <-- barlas has quit (Ping timeout) 13:11:39 <flo> we would need to have an icon cache somewhere I think 13:12:26 <aleth> Hey, looking at twitter.com: Why don't we display the one-line description of the nick as the topic? 13:13:09 <aleth> e.g. for @instantbird, "Instant messaging has never been easier!" 13:13:58 <aleth> Do you think that would be a good fit? 13:15:00 <aleth> flo: Sounds like that would require changing the log format 13:18:37 <flo> aleth: just adding a hash of the message icon to the log format 13:19:30 <flo> aleth: that would be very good for other people's timeline 13:19:39 <flo> aleth: for the user's timeline, I'm not sure 13:19:43 <flo> except if we offer a way to change it :) 13:19:56 <flo> not sure if the twitter API lets us change that 13:20:34 <aleth> tricky... 13:21:05 <aleth> It's not possible to retrieve the icons from twitter on the fly? 13:21:28 <aleth> (i.e. fetch the icon by user rather than by tweet) 13:21:37 <unghost> flo, Why in manual on https://wiki.instantbird.org/Instantbird:Creating_a_new_localization_%28Mercurial%29 it's advised to check out locale files from l10n-central? "python client.py checkout" pulls mozilla-release and I have a lot of errors with compare-locales 13:22:21 <aleth> Btw I fixed that log error handling bug yesterday to unblock Mic on bug 958, so it would be good if that could get reviewed fairly soon... 13:22:25 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=958 enh, --, ---, benediktp, ASSI, Show last messages (history) in new chat windows 13:30:00 <flo> aleth: it's trivial to retrieve twitter's icons, but for logs, we want to display the icon that the user had at the time of the message, rather than the current one, don't we? 13:30:43 <aleth> flo: I don't know - it would be nice, but is it worth the overhead? 13:31:14 <flo> unghost: you can adapt to pull the right repository :). I think that page was written at the time of Firefox 3.6 or 4.0, way before the rapid releases and the multiple l10n repositories :) 13:31:35 <flo> aleth: would you want to see the icons while looking at the logs while offline? 13:33:00 <aleth> Hmm... good point. I guess I don't know, as currently I never see the icons anyway with Bubbles ;) 13:33:43 <flo> aleth: neither do I, but I think it's something we should fix ;) 13:40:45 <flo> unghost: have you already found http://hg.instantbird.org/l10n/locales-status.html#ru ? :) 13:40:59 <flo> and https://hg.instantbird.org/l10n/en-US/ ? 13:42:22 <unghost> flo, yes and no 13:43:00 <unghost> flo, what the difference between locale in https://hg.instantbird.org/instantbird/ and https://hg.instantbird.org/l10n/en-US/? 13:46:04 <flo> unghost: the en-US has the same directory structure as the locales repository. In the "instantbird" repository you need to look for the <name>/locales/en-US folder. 13:46:22 <flo> + the en-US repository also includes localizable strings for the website 13:46:31 <flo> in case you want http://www.instantbird.com/ to be localized too 13:47:21 <flo> the strings of the application are only used when we release (so we announce a string freeze ~10 days before releasing to give time to update and test translations), but the website strings are updated automatically within an hour after the push 13:48:40 <unghost> ok, thanks 13:50:03 <flo> but of course you don't have to wait for a string freeze before updating the existing strings of the application :) 13:50:33 <flo> .xpi langpacks that you can test against nightly builds are automatically generated when you push to the l10n repository 14:05:52 <-- chrisccoulson has quit (Ping timeout) 14:16:19 <-- Even has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 14:19:35 --> chrisccoulson has joined #instantbird 14:23:00 --> Optimizer has joined #instantbird 14:23:30 <-- mmkmou has quit (Ping timeout) 14:37:34 <instantbot> New Core - Twitter bug 1666 filed by firstname.lastname@example.org. 14:37:36 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1666 enh, --, ---, nobody, NEW, Set twitter topic to the user's self-description 14:40:29 <-- chrisccoulson has quit (Ping timeout) 14:41:17 <instantbot> New Core - Twitter bug 1667 filed by email@example.com. 14:41:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1667 enh, --, ---, nobody, NEW, Display RTs by showing the original tweet 15:03:57 --> wnayes has joined #instantbird 15:16:12 --> mmkmou has joined #instantbird 15:59:15 <flo> unghost: compare-locales (on http://hg.instantbird.org/l10n/locales-status.html#ru) seems happy now :). 15:59:51 <unghost> flo, 15:59:54 <unghost> flo, yup 15:59:56 <flo> unghost: you may want to make some changes to the ru version of http://lxr.instantbird.org/instantbird/source/instantbird/locales/en-US/chrome/instantbird/accountWizard.properties 16:00:09 <flo> ICQ is still very popular in Russia, right? :) 16:00:39 <unghost> yes 16:01:57 <unghost> may I add topProtocol.prpl-icq.description to this file? 16:02:59 <wnayes> unghost: Yes, there should be descriptions for each topProtocol in the above list. 16:03:44 <flo> unghost: and you can remove the protocols (if any) that are irrelevant in Russia 16:05:54 <aleth> wnayes: Maybe that should be added to the l10n wiki? 16:11:19 <wnayes> I guess I basically repeated a comment in the file. But something could be added on the Translation/FAQ page, maybe with an image to show where the string changes show up. 16:13:42 <aleth> Could be that it's unnecessary, but I think flo said hardly any l10n had taken advantage of the possibility to adapt the list, so maybe they missed it for some reason. 16:13:58 <flo> if you add something in the FAQ on the topic, you want to mention that it's "normal" (ie not a surprise) that the changes made to this cause errors on the http://hg.instantbird.org/l10n/locales-status.html page 16:14:43 <flo> aleth: cs, sk and sv-SE used it 16:15:16 <aleth> oh good :) 16:21:38 <wnayes> Maybe it would have been clearer to have written descriptions for every protocol and had instructions to only translate the ones chosen for the list. 16:22:07 --> rosonline has joined #instantbird 16:22:13 <wnayes> (And the errors wouldn't show up) 16:25:13 <aleth> flo: rosonline was asking while you were away (I think) how to get access to the pt-br repo, that he/she has been translating 16:25:46 <flo> aleth: I probably should just give him an account on the locale repository 16:25:55 <flo> would have been nice to have the locale manager coordinate things there... 16:26:13 <aleth> yeah... does he not respond to emails? 16:31:01 --> sonny has joined #instantbird 16:32:31 <unghost> Are there any plans to support popular XMPP networks as plugins, so localizers can add them at accountwizard page? For example http://vk.com/ is more popular in Russia then Facebook. It has IM service, but user should know about http://vk.com/help.php?page=jabber to configure it. 16:33:45 <aleth> unghost: I think this add-on is an example of how this could be done https://addons.instantbird.org/en-US/instantbird/addon/254 16:34:57 <aleth> As far as I know it is also XMPP inside 16:35:42 <aleth> You could take a look and see if you can adapt it for VK? 16:35:42 <unghost> aleth, Is it possible to built-in and ship addon with some locale for Instantbird? 16:36:01 <aleth> I don't know - ask flo ;) 16:36:51 <flo> unghost: interesting question. 16:37:07 <flo> unghost: so generally, we don't want locale repositories to contain any executable code 16:37:14 <flo> so for shipping add-ons, the answer is no. 16:37:38 <flo> but adding some what to offer customized XMPP-based protocols... we can think about it :) 16:38:19 <flo> that could maybe cause some issues when switching back and forth between a localized and non-localized version 16:39:51 <Mook> for vk.com: _xmpp-client._tcp.vk.com seems to have SRV records... :p 16:40:07 <aleth> If it is as popular as you say, that's also an argument for including it by default... 16:40:17 <unghost> something like "searchplugins" directory with customized xmpp plugins. list.txt could contain list of plugins 16:43:42 <unghost> btw, does Instantbird support DNS records? I guess not, cause I have to use vkmessenger.com instead vk.com 16:44:53 <Mook> there's an open bug on it, unfortunately 16:45:18 <flo> unghost: Instantbird supports DNS SRV records. 16:45:22 <flo> Mook: Thunderbird doesn't 16:45:31 <unghost> ok. more hoops for users to jump through. 16:45:31 <Mook> ah! okay. via purple? 16:48:24 <flo> Mook: yes 16:51:13 <unghost> Hm, doesn't work for me in Instantbird 1.2 with vk.com account 16:55:55 <wnayes> Here's the top protocols FAQ entry so far, https://wiki.instantbird.org/Instantbird:Translation/FAQ#How_should_the_top_protocols_information_.28accountWizard.properties.29_be_changed.3F 17:02:06 --> igorko has joined #instantbird 17:03:11 <-- rosonline has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com) 17:03:12 --> Even has joined #instantbird 17:03:12 * ChanServ sets mode +o Even 17:06:01 <instantbot> New Core - Debug bug 1668 filed by firstname.lastname@example.org. 17:06:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1668 nor, --, ---, nobody, NEW, Enhance imXPCOMUtils debug logging to have module-specific prefs 17:06:19 <Mook> oops, forgot the Show Adavanced Fields link 17:06:51 <instantbot> email@example.com requested review from florian@instantbird .org for attachment 1842 on bug 1668. 17:18:45 <flo> oh, Mook is patching Instantbird again? :) 17:21:38 <flo> Mook: do you think this could have some performance impact? 17:22:09 <flo> ah, in most case there will be only one interaction of the loop 17:26:28 <unghost> flo, How can I resolve bug with vk.com? When I try to connect to it directly, I've got SSL error - Timestamp: 25.08.2012 21:23:02 17:26:28 <unghost> Error: Handshake failed (-12276) 17:26:28 <unghost> Source File: http://hg.instantbird.org/instantbird/raw-file/4df52d793c89/purple/libpurple/ssl-nss.c 17:26:29 <unghost> Line: 342 17:26:30 <unghost> Source Code: 17:26:30 <unghost> nss: ssl_nss_handshake_cb 17:27:27 <flo> unghost: you probably want to set a value in the "connect server" field of the advanced properties of the account 17:28:06 <-- Optimizer has quit (Ping timeout) 17:28:28 <unghost> flo, vk.com help page says that it's not needed if client understards DNS records. 17:29:01 <unghost> so is it instantbird bug? 17:33:13 --> Optimizer has joined #instantbird 17:38:25 <flo> unghost: try it and tell us if it works, we will discuss after we know the result whose bug it is ;) 17:43:16 --> rosonline has joined #instantbird 17:43:17 <unghost> flo, http://vk.com/help.php?page=jabber#other . If I use vkmessenger.com as server, it works. But help page says "Clients who do not support DNS records should indicate this as the server: vkmessenger.com". Because Instantbird supports DNS records, it should be not nessesary to indicate server. That's what I'm asking. 17:44:58 --> wnayes1 has joined #instantbird 17:45:42 <-- wnayes has quit (Ping timeout) 17:46:57 <flo> unghost: the "handshake failed" error means that you didn't receive the SSL certificate Instantbird expected 17:47:36 <flo> if you have a firstname.lastname@example.org account and DNS SRV tells to connect to vkmessenger.com, the XMPP specification says the client should connect to vkmessenger.com and expect an SSL certificate for vk.com 17:47:58 <unghost> Just started Pidgin and it works fine without server indication. 17:47:58 <flo> I suspect vk.com is sending a certificate for vkmessenger.com (ie doesn't respect the XMPP spec) 17:48:08 <flo> unghost: Pidgin doesn't check SSL certificates 17:48:26 <flo> (or does it extremely poorly) 17:48:31 <unghost> ok, got it. 17:57:39 <-- rosonline has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com) 18:49:54 --> chrisccoulson has joined #instantbird 19:03:33 --> rosonline has joined #instantbird 19:20:23 <-- rosonline has quit (Client exited) 19:30:44 --> rosonline has joined #instantbird 19:31:27 <-- sonny has quit (Ping timeout) 19:37:40 --> sonny has joined #instantbird 19:38:14 <-- rosonline has quit (Client exited) 19:40:11 <-- sonny has quit (Ping timeout) 19:44:01 --> sonny has joined #instantbird 19:44:38 --> Mic|tb has joined #instantbird 20:10:36 <-- Mic|tb has quit (Quit: Mic|tb) 20:47:31 <-- mmkmou has quit (Quit: Instantbird 1.3a1pre -- http://www.instantbird.com) 20:51:53 <-- chrisccoulson has quit (Ping timeout) 20:52:10 <-- unghost has quit (Quit: Ð£Ñ Ð¾Ð¶Ñ Ñ Ð¾Ñ Ð²Ð°Ñ (xchat 2.4.5 Ð¸Ð»Ð¸ ÑÑÐ°ÑÑÐµ)) 21:13:15 <flo> aleth: "RTs of tweets ending in links don't have broken links (as they often do at the moment)" what do you mean? 21:13:50 <flo> if we receive the information needed to complete a retweet after the 140 characters, we do complete it already, don't we? 21:19:29 <aleth> flo: Not as far as I can tell.. many RTs are cropped and end in "..." 21:20:07 <flo> aleth: the tweets coming from the search API (as opposed to the tracked keyword in the user stream) are crappy; there's not much we can do about it 21:20:21 <aleth> No, this is a standard timeline 21:21:23 <aleth> Almost every incoming RT is cut off. 21:21:44 <flo> you should find what doesn't work in http://lxr.instantbird.org/instantbird/source/chat/protocols/twitter/twitter.js#194 then 21:21:47 <aleth> I thought that was because we don't fetch the original tweet, and the RT itself is cut off of course. 21:21:52 <flo> aleth: what do you mean by "cut off"? 21:22:00 <aleth> By the 140 char limit 21:22:00 <flo> the "..." at the "end" of the URL are expected 21:22:10 <flo> but the URL should be complete in the status bar when you hover it 21:22:13 <aleth> Oh, it also happens without URL 21:22:42 <flo> aleth: we don't "fetch" the original tweet. It's fully included in a retweeted_status property 21:23:00 <aleth> Right. I've never really looked inside the twitter JS 21:23:17 <flo> I just gave you the link to that specific code ;) 21:23:21 <aleth> What you say works for some URLS (when the ... are also linkified) but not all 21:24:13 <aleth> So I guess it's a bug then ;) 21:24:17 <flo> cutting after 140 characters isn't specific to RTs :-P 21:24:36 <flo> it may be a bug, but unless you have specific steps to reproduce, it WFM... 21:26:18 <aleth> It's so common it doesn't need STR for me. It's more a matter of figuring out the pattern... 21:26:36 <flo> I'm scared by that change to statically link libpurple into purplexpcom, but tonight is the best time to land it, right? 21:26:38 <aleth> If it wasn't so common I wouldn't have thought it a limitation of twitter ;) 21:27:05 <aleth> flo: Definitely a weekend is best 21:27:14 <flo> aleth: do you know which tweets I'm talking about when I say "tweets from the search API"? 21:27:17 <aleth> Especially if you think it works and it needs testing 21:27:42 <flo> aleth: oh, I didn't think about it because it's obviously a dead end, but RTs from twitter clients that don't support RTs will obviously be cut and not have valid links at the end. 21:28:04 <aleth> flo: Hmm, that could be it I suppose 21:28:13 <flo> ie tweets where the user copy/pasted the tweet and typed "RT @<username>" by hand at the beginning 21:28:45 <flo> aleth: well, actually; I think it needs automated testing. 21:29:11 <flo> aleth: I'm planning on adding an xpcshell tests that ensures at least one of the libpurple prpls is available 21:29:23 <flo> this should at least prevent uploading a completely broken nightly 21:29:40 <flo> I could still break Bonjour on linux (but I've worked on linux yesterday so things should work there) 21:31:03 <aleth> Beyond a certain point, it'll just need to be tried... I mean you are hardly going to test build on Windows 21:31:52 <aleth> flo: When is the search API used? (I'm guessing it's not related to search then?) 21:33:50 <aleth> Is it to be expected that twitter.com can do better when displaying RTs than we can? Because that seems to be the case 21:37:08 <aleth> So it's not the copy-and-paste thing... 21:37:51 <flo> aleth: do you have something specified in the "Tracked keyword" advanced preference? 21:37:56 <aleth> no 21:38:07 <flo> ok, then you have nothing from the search API 21:38:17 <flo> (you aren't even tracking "instantbird"? ;)) 21:38:38 <aleth> not with the dev profile ;) 21:39:01 <flo> heh 21:39:29 <aleth> Actually I don't think I'm tracking it anywhere... maybe I should :P 21:39:50 <flo> I'm pretty sure clokep does :) 21:56:07 <-- SM0TVI has quit (Ping timeout) 21:57:25 --> SM0TVI has joined #instantbird 22:07:11 <-- Optimizer has quit (Ping timeout) 22:14:32 <-- SM0TVI has quit (Ping timeout) 22:15:48 --> SM0TVI has joined #instantbird 22:31:54 <-- igorko has quit (Quit: Instantbird 1.2 -- http://www.instantbird.com) 22:50:48 * flo is cleaning up lots of WINCE rules at the same time 23:16:09 <aleth> Looks like the issue with the truncated tweets is that the truncated flag is never set to true, even when it should be 23:19:45 <flo> ah 23:19:55 --> ea4eoz has joined #instantbird 23:30:25 <-- mali has quit (Ping timeout) 23:30:28 <flo> anybody interested in reviewing my build-system patch before I land it? 23:31:11 <aleth> I don't know enough about the build system to usefully do it, so just land it ;) 23:31:29 <aleth> Mook maybe? 23:32:26 <flo> He's been idle for 6+ hours, so I think that means no ;) 23:35:49 <flo> aleth: the patch is in bug 1665 if you want to quickly look anyway :) 23:35:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1665 nor, --, ---, nobody, NEW, Statically link libpurple into libpurplexpcom 23:39:40 <aleth> whoa, that took some doing ;) 23:41:27 <flo> the patch is less trivial than the bug title makes it sound ;) 23:42:22 <aleth> finally, a use for try...finally! 23:43:20 <aleth> Can't spot any obvious issues, fwiw :) 23:44:04 <flo> hopefully the makefiles will look way more readable after the patch 23:44:11 <aleth> Why could you remove all the glib references? no longer needed when you link statically? 23:44:19 <flo> although I added new hacks at the same time as I removed old ones ;) 23:44:33 <flo> glib references from where? 23:45:05 <aleth> /purple/libpurple/Makefile.in 23:45:40 <flo> I removed the EXTRA_LIBS variable which is irrelevant when doing a static lib 23:45:54 <flo> and all the dependencies are now linked from purple/purplexpcom/src/Makefile.in 23:46:15 <aleth> Right, I just saw they were much reduced. 23:47:07 <flo> I also de-duplicated the SHARED_LIBRARY_LIBS += $(foreach lib,glib xml2,../libraries/$(lib)/$(LIB_PREFIX)$(lib).$(LIB_SUFFIX)) line (it's the same on Mac and Windows) 23:49:11 <aleth> And once this builds, turning it into an add-on is "just" packaging? 23:49:32 <flo> :-D 23:50:17 <aleth> fingers crossed :) 23:50:27 <aleth> I'm kinda surprised it's even possible to keep the dynamic linking working ;) 23:50:32 <-- wnayes1 has quit (Ping timeout) 23:51:00 <aleth> but then I don't really know anything about it. 23:51:17 <flo> the WIP in bug 1579 should hopefully work a bit better after that 23:51:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1579 enh, --, ---, nobody, NEW, Ship libpurple as an add-on / allow it to be disabled in configure 23:53:57 --> wnayes has joined #instantbird 23:54:06 <flo> I'm not sure that dynamically linked prpls can actually work when packaged in add-ons if we put libpurple in the extensions/ folder 23:54:45 <flo> although on Mac and linux it "should" work, and on Windows I may be able to hack it to work too 23:55:53 <aleth> So the TB version will definitely have to do without dynamic linking? 23:55:58 <flo> hmm, I'm not sure that would work on linux actually 23:56:53 <flo> honnestly, I'm not sure I really care about libpurple prpls packaged in add-ons any more