All times are UTC.
00:00:44 <flo> I think I'll go to bed, and see tomorrow how things are looking 00:01:24 <aleth> Good night :) 00:01:39 <flo> thanks, good night! 00:01:46 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 00:03:58 --> skeledrew has joined #instantbird 00:07:36 <-- aleth has quit (Input/output error) 00:08:32 --> aleth has joined #instantbird 00:08:32 * ChanServ sets mode +h aleth 00:11:02 <-- aleth has quit (Input/output error) 00:11:38 --> aleth has joined #instantbird 00:11:38 * ChanServ sets mode +h aleth 00:18:16 <-- aleth has quit (Input/output error) 00:22:56 --> vicnet has joined #instantbird 00:24:57 <-- vicnet has quit (Quit: Instantbird 1.1a1pre) 00:25:21 --> vicnet has joined #instantbird 00:37:39 <-- timA has quit (Quit: Instantbird 1.1) 00:51:49 <instant-buildbot> build #297 of linux-onCommit is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/297 blamelist: Florian Qu?ze <florian@instantbird.org> 00:53:30 * wesj is now known as wesj|away 01:04:13 <instant-buildbot> build #283 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/283 01:18:26 <-- vicnet has quit (Client exited) 01:21:32 --> vicnet has joined #instantbird 01:35:53 --> rosonline has joined #instantbird 01:54:21 <-- GeekShadow has quit (Ping timeout) 01:54:29 --> GeekShadow has joined #instantbird 02:17:48 <-- vicnet has quit (Ping timeout) 02:30:17 <instant-buildbot> build #577 of linux-nightly-default is complete: Failure [failed compile] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/577 02:32:34 --> vicnet has joined #instantbird 02:43:00 <-- rosonline has quit (Quit: Instantbird 1.1) 02:50:29 <-- GeekShadow has quit (Ping timeout) 02:52:30 --> clokep has joined #instantbird 02:52:30 * ChanServ sets mode +o clokep 02:52:54 --> GeekShadow has joined #instantbird 03:02:07 <clokep> Boo. :( Linux nightly failed. 03:11:35 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:22:53 <-- Suiseiseki has quit (Connection reset by peer) 03:24:27 --> Suiseiseki has joined #instantbird 03:42:17 <-- vicnet has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:42:27 --> vicnet has joined #instantbird 03:47:47 <-- vicnet has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 03:51:41 --> Optimizer has joined #instantbird 03:53:30 <-- Optimizer has quit (Ping timeout) 04:25:28 <instant-buildbot> build #664 of win32-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/664 05:16:54 --> jb has joined #instantbird 05:29:55 <-- EionRobb has quit (Quit: Leaving.) 05:59:41 --> jb1 has joined #instantbird 06:00:49 <-- jb has quit (Ping timeout) 06:10:57 --> Optimizer has joined #instantbird 06:17:45 <instant-buildbot> build #266 of macosx-onCommit is complete: Exception [exception] Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/266 blamelist: Florian Qu?ze <florian@instantbird.org> 06:17:51 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/457382b40fdc - Florian Quèze - Work-around bug 762930 by adding #undef GROUPING lines in accessible/src/base/nsAccessibilityService.cpp and accessible/src/xforms/nsXFormsAccessible.cpp. 06:20:02 <-- Optimizer has quit (Ping timeout) 06:20:35 <instant-buildbot> build #571 of macosx-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/571 06:22:15 <instant-buildbot> build #298 of linux-onCommit is complete: Exception [exception interrupted] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/298 blamelist: Florian Qu?ze <florian@instantbird.org> 06:22:35 <instant-buildbot> build #284 of win32-onCommit is complete: Exception [exception interrupted] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/284 blamelist: Florian Qu?ze <florian@instantbird.org> 06:27:51 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/a0d7856788b8 - Florian Quèze - Fix typo in 'Bug-762930-undef-GROUPING.patch'. 06:30:15 <-- Mook has quit (Quit: Mook) 06:51:58 <instant-buildbot> build #299 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/299 07:18:48 --> gerard-majax has joined #instantbird 07:37:21 --> aleth has joined #instantbird 07:37:21 * ChanServ sets mode +h aleth 07:42:13 <-- SM0TVI has quit (Connection reset by peer) 07:43:39 <-- jb1 has quit (Ping timeout) 07:44:02 --> SM0TVI has joined #instantbird 07:51:25 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 07:51:30 --> Even has joined #instantbird 07:51:30 * ChanServ sets mode +o Even 08:52:46 --> flo has joined #instantbird 08:52:46 * ChanServ sets mode +qo flo flo 08:55:18 <flo> hello from a moz14 nightly :) 08:55:26 <flo> aleth: sorry that the linux nightly didn't build :-/. 08:55:59 <aleth> flo: 2 out of 3 is not bad :) 08:56:20 <flo> I managed to fix the linux compilation ;), but not in time to have a nightly :( 08:57:18 <flo> https://hg.instantbird.org/instantbird/rev/a0d7856788b8 is a perfect example showing that attempting to fix bugs before breakfast isn't a good idea ;). 08:58:45 <flo> for everybody on Windows/Mac: time to look for regressions ;). 08:59:36 <aleth> heh... it was correct in the filename ;) 09:00:03 <flo> not really. I had the same typo there, but fixed it just before commit 09:00:21 <flo> and didn't notice that if I typoed in the filename, it was because I made the same mistake first inside the files :( 09:02:51 <aleth> Here's hoping there's not too many regressions... 09:03:40 <flo> on mac at least, it seems quite usable 09:29:14 --> mmkmou has joined #instantbird 09:41:34 --> jb has joined #instantbird 10:00:23 --> igorko has joined #instantbird 10:18:47 --> clokep has joined #instantbird 10:18:47 * ChanServ sets mode +o clokep 10:19:39 --> meh has joined #instantbird 10:21:06 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:21:12 --> clokep has joined #instantbird 10:21:13 * ChanServ sets mode +o clokep 10:21:29 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:21:34 --> clokep has joined #instantbird 10:21:34 * ChanServ sets mode +o clokep 10:21:50 * clokep is on Moz 14. 10:22:00 --> sonny has joined #instantbird 10:25:03 <flo> clokep: cool :) 10:25:16 <clokep> flo: Everything seems OK here so far... 10:26:02 <clokep> Also, unhandled IRC messages are given a warning level, so they show up in non-debug builds too. 10:26:46 <aleth> There are not that many unhandled IRC messages anymore ;) 10:26:58 <aleth> Just the mode one :-/ 10:31:39 <flo> clokep: I would expect them in the error console, but not the terminal 10:31:42 <aleth> clokep: did you intend to say ACTION there or is that a regression too? 10:31:50 <flo> isn't dump disabled by default in non-debug builds? 10:32:19 <aleth> flo: You have to set an about:config flag to see dumps I think. 10:32:23 <flo> clokep: do you think we need to rephrase that error or make it a warning? 10:32:28 <clokep> flo: I don't think I put it in both, I know they show up in the error console. I don't think we "dump" too. 10:32:42 <clokep> "rephrase that error"...it /is/ a warning AFAIK. 10:33:48 <clokep> aleth: What show up as "ACTION"? 10:33:53 <clokep> I had a message rejected by the server it seems. 10:34:00 <clokep> (/me with a line break in it). 10:34:09 <aleth> "ACTION feels like this is a new scary error" 10:34:14 <aleth> Right. 10:35:16 <aleth> Hmm, that entire line does not show up in the logs. 10:35:16 <flo> so why was that ACTION there? 10:35:31 <clokep> http://pastebin.instantbird.com/57459 is what I sent 10:38:11 <clokep> Send CTCP message probably doesn't do the low level quoting...I don't think I ever implemented that. And that's probably the issue. 10:38:26 <clokep> aleth: I do wonder whether that has \001 on each side of it 10:38:55 <clokep> (Also I think using /action instead of /me is broken...) 10:40:21 <-- sonny has quit (Ping timeout) 10:41:36 * aleth tests /action 10:41:53 <clokep> Seems to work OK... 10:42:16 <clokep> Ah, they are running the same command. 10:42:22 <clokep> Never mind. :) Forget that. 10:42:26 <aleth> Yes. 10:43:00 <clokep> I'll file a bug about the other issue soon. 10:43:27 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 10:43:27 <aleth> That would be it, right. 10:44:09 <flo> clokep: so the conversation moved on to the IRC bug, but I'm still confused about what you wanted for the message when the bonjour toolkit is missing. 10:44:45 <clokep> flo: Ah, is that what that means? OK. :) 10:45:02 <flo> clokep: it's what it means, yes 10:46:37 <clokep> I was just surprised by it, I don't know what would be better. 10:48:00 <aleth> "Bonjour toolkit is not installed"? 10:48:26 <aleth> Or does a normal user never get to see that anyway? 10:50:06 <flo> aleth: I'm afraid anybody opening the error console would see it 10:50:11 <flo> on Windows 10:51:03 <instantbot> New Core - IRC bug 1615 filed by clokep@gmail.com. 10:51:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1615 min, --, ---, nobody, NEW, IRC ACTION (CTCP?) messages break with a line break 10:52:47 <flo> clokep: is this a good opportunity to get rid of the confusing http://lxr.instantbird.org/instantbird/source/instantbird/content/conversation.xml#356 and to handle it all inside the irc prpl? 10:56:39 <clokep> flo: Yes...I thought we handled that already in http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/irc.js#127 but I guess not. 10:57:19 <flo> I think it's not the UI's job to handle those prpl-specific details 10:57:28 <clokep> I agree. 10:58:53 <flo> is "The height of the content has changed, in which case we don't want to change the autoscroll settings as this was not triggered by the user." really a meaning full comment? 10:58:58 <flo> (aleth ^^^) 10:59:17 <flo> what's "the content". Isn't it referring to the "content area" rather than the content? 10:59:27 <flo> what's "the autoscroll settings"? 10:59:50 <aleth> Clearly it is not unambiguous :-/ 11:00:30 <clokep> flo: Is IRC the only proto that uses that? 11:00:37 <flo> clokep: yes 11:01:32 <flo> what about "The height of the content area has changed, causing a scroll event. As this event wasn't triggered by the user, adapted the cached scroll height and width to ensure this even won't affect the auto-scroll behavior."? 11:01:40 <flo> *adapt 11:01:46 <flo> *event 11:01:54 <flo> bah, typing is hard today, not only before breakfast 11:02:05 <flo> (or is this because I should go get lunch? ;)) 11:02:48 <flo> pff, no that's not even really better. To content area size change is caused by the user. 11:03:34 <flo> what about "// Ensure scroll events triggered by a change of the content area size don't affect the auto-scroll behavior." ? 11:04:11 <-- instant-buildbot has quit (Ping timeout) 11:04:18 <aleth> "// Ensure scroll events triggered by a change of the content area size (e.g. new messages being added) don't affect the auto-scroll behavior." ? 11:04:31 <aleth> oh wait 11:04:45 <aleth> That's just wrong. 11:04:46 <-- clokep has quit (Ping timeout) 11:05:16 --> instant-buildbot has joined #instantbird 11:05:17 * ChanServ sets mode +v instant-buildbot 11:05:22 * aleth should probably get lunch too 11:05:48 <flo> the "(e.g. new messages being added)" part doesn't make sense 11:05:58 <flo> the even is the user resizing the window or moving the textbox splitter 11:06:01 <flo> *event 11:06:07 <aleth> "// Ensure scroll events triggered by a change of the content area size don't affect the auto-scroll behavior." seems good to me 11:06:19 <aleth> Yes... 11:06:32 <flo> I can specify that if you thing it adds more clarify 11:06:34 <flo> *clarify 11:06:39 <flo> *clarity (aaah!) 11:06:41 <aleth> Maybe we should add that as an example. 11:07:21 <aleth> I had "Ignore scroll events triggered by the user resizing the window" at one point 11:08:44 <flo> I'm going with " // Ensure scroll events triggered by a change of the 11:08:46 <flo> // content area size (eg. resizing the window or moving the 11:08:46 <flo> // textbox splitter) don't affect the auto-scroll behavior. 11:08:53 <aleth> Yes, that's great 11:08:59 <flo> ok, thanks 11:09:18 <flo> heh, new JS strict warnings... 11:09:32 <flo> JavaScript strict warning: chrome://instantbird/content/blist.js, line 153: variable a redeclares argument 11:09:46 <flo> same for variable b, and same 2 warnings at line 235 11:10:01 <aleth> oh joy... 11:10:40 <flo> we just need to remove the "let " at http://lxr.instantbird.org/instantbird/source/instantbird/content/blist.js#153 right? 11:10:50 <aleth> I think so. 11:10:53 <flo> and on line 235 11:11:19 <aleth> (Unless there is then another warning for assigning to arguments...) 11:11:24 <flo> is that wanted for 1.2 (as the new warnings are a regression of switching to moz 14)? 11:11:33 <flo> I think assigning to arguments is allowed 11:11:39 <aleth> It certainly works. 11:11:55 <aleth> But it might be bad style? 11:12:15 * aleth is unsure of the JS conventions here 11:13:10 <flo> wow 11:13:43 <flo> it was displayed "*** is unsure of the JS conventions here". And when the unread ruler disappeared, it became "*** aleth is unsure..." 11:14:06 <aleth> whoa :( 11:14:23 <aleth> strange... 11:14:37 <flo> just another bubbles + unread ruler brokenness ;) 11:15:09 <aleth> funny how they hid until 2 days before release ;) 11:15:27 <flo> it's always like that 11:15:30 <flo> I hate releases ;) 11:16:00 <flo> I wonder if the massive shutdown leak I'm seeing is caused by that auto-scroll patch. 11:16:03 <aleth> There you go http://pastebin.instantbird.com/57478 11:18:14 <aleth> Does the scrollToElement on the window need removing in the destructor? I would have thought the window would get destroyed first 11:18:53 <flo> I'll first try to unapply the patch to be sure 11:25:50 <instantbot> New Instantbird (UI) bug 1616 filed by aletheia2@fastmail.fm. 11:25:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, nobody, NEW, Bubbles: Unread ruler in split bubble just before an action message hides the sender name 11:33:38 --> sonny has joined #instantbird 11:34:30 <flo> pff, the massive leak exists even without that patch :( 11:34:48 <aleth> A regression then :( 11:34:51 <flo> I wonder if it could be moz14 :( 11:45:57 --> clokep_work has joined #instantbird 11:45:57 * ChanServ sets mode +o clokep_work 11:46:45 <flo> got 3 identical JS errors in my terminal: [Exception... "'[JavaScript Error: "this._buddy is undefined" {file: "resource:///modules/jsProtoHelper.jsm" line: 228}]' when calling method: [nsIRequestObserver::onStopRequest]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "<unknown>" data: yes] 11:46:57 <flo> at shutdown while a connection to a JS-XMPP account was in progress 11:50:06 * clokep_work doesn't like bugs that hide. 11:50:16 <clokep_work> Especially the ones that hibernate until two days before a release, yes. 11:51:06 <flo> this one is possibly related to my patch about the XMPP aliases 11:52:21 <flo> do we care about leaking like a sieve? :-S 11:54:03 <clokep_work> :-/ Probably. 11:54:17 <flo> that's unfortunate 11:55:23 --> Even has joined #instantbird 11:55:23 * ChanServ sets mode +o Even 11:55:36 <-- Even has quit (Quit: Instantbird 0.3a2pre) 11:55:49 <flo> Even1: thanks! :) 11:55:55 <flo> 0.3a2pre?! 11:56:01 --> Even has joined #instantbird 11:56:01 * ChanServ sets mode +o Even 11:56:16 <-- Even has quit (Input/output error) 11:56:23 --> Even has joined #instantbird 11:56:23 * ChanServ sets mode +o Even 11:56:35 <flo> aleth: you will have a nightly to test with in a few minutes :) 11:58:50 <clokep_work> flo: I don't want people to be able to say "OMG Instantbird uses 10X the memory as Miranda!" 11:58:55 <clokep_work> I'm OK w/ it only being 5 times though. :) 11:59:04 <flo> ahah 12:01:35 --> Mic has joined #instantbird 12:01:49 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 12:02:54 --> Mic has joined #instantbird 12:02:55 * ChanServ sets mode +h Mic 12:03:21 <clokep_work> Good afternoon Mic! 12:03:37 <Mic> Hi! 12:04:40 <clokep_work> I had something to tell you. 12:04:43 <clokep_work> But now I totally forgot. :) 12:06:50 <flo> anything giving an obvious idea? http://pastebin.instantbird.com/57499 12:06:55 <flo> this is without aleth's patch 12:08:15 <instant-buildbot> build #579 of linux-nightly-default is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/579 12:08:24 <flo> :) 12:08:35 <aleth> :) 12:08:43 <aleth> uh, nsRect? 12:08:56 <flo> nsGlobalWindow ... 12:09:00 <clokep_work> Looks like a lot of CSS stuff leaks? :P 12:09:35 <flo> leaking a global window causes a leak of everything that window keeps alive 12:09:39 <flo> so lots of DOM stuff 12:09:42 <clokep_work> Bug 1530 12:09:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll broken after moz13 update when restoring from hold and using Bubbles 12:09:50 * clokep_work is being lazy... 12:12:22 <-- flo has quit (Ping timeout) 12:13:40 <clokep_work> Ah, so we're leaking a global window then? That doesn't sound good. :( 12:15:15 --> flo has joined #instantbird 12:15:15 * ChanServ sets mode +qo flo flo 12:17:09 <flo> so, the account manager, the contact list, and the log viewer don't cause the leak. 12:17:29 <flo> we have a large shutdown leak if a conversation window was used to send a message 12:17:51 <flo> opening a conversation and closing it without sending anything doesn't cause the leak 12:18:03 <flo> sending only the typing notifications doesn't cause the leak 12:18:29 <flo> displaying a received message also causes the leak. 12:19:12 <flo> so... what stupid thing could we be doing in the conversation window when displaying a message, that we don't do in the log viewer? 12:20:54 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 12:21:38 <-- mmkmou has quit (Ping timeout) 12:24:28 <aleth> Is it the conversation binding or the browser that causes the leak? 12:24:48 <aleth> The log viewer doesn't have the binding... 12:26:19 <flo> the log viewer has the convbrowser, doesn't it? 12:26:25 <flo> but the code paths in it are a little bit different 12:26:28 <aleth> Yes 12:33:04 <aleth> hi 12:33:33 <flo> aleth: hello :) 12:33:38 <aleth> ^^ sorry, wrong channel ;) 12:39:31 --> mmkmou has joined #instantbird 12:46:04 <aleth> Is it that the convbrowser retains a reference this._conv? 12:50:14 <-- jb has quit (Quit: jb) 12:50:37 --> jb has joined #instantbird 12:51:58 <flo> http://pastebin.instantbird.com/57512 "ref counted object with 1 unknown edge" super useful :( 13:06:38 <flo> has anybody emailed the pl and ru localizers again? 13:06:40 <flo> fr seems ready 13:14:00 <instant-buildbot> build #286 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/286 13:14:22 <-- aleth has quit (Quit: Au revoir) 13:14:36 --> aleth has joined #instantbird 13:14:36 * ChanServ sets mode +h aleth 13:15:06 <aleth> hello moz14 :) 13:17:22 <instantbot> florian@instantbird.org granted review for attachment 1775 on bug 1530. 13:17:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll broken after moz13 update when restoring from hold and using Bubbles 13:17:28 <flo> since the leak also exists without it... 13:19:34 <instantbot> florian@instantbird.org granted review for attachment 1753 on bug 1604. 13:19:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1604 min, --, ---, nobody, NEW, Don't show unread ruler if all the context messages were system messages 13:23:16 * flo will look at a diff -w of https://bugzilla.instantbird.org/attachment.cgi?id=1774 13:23:32 --> deomega1 has joined #instantbird 13:24:14 <flo> aleth: boo, that patch adds trailing whitespace 13:24:36 <deomega1> good day. I may have found the issue for bug 1613 13:24:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1613 nor, --, ---, nobody, UNCO, Twitter feed stops 13:24:43 <aleth> :( sorry 13:25:10 <flo> I'll fix it before the check-in if nothing else needs to be fixed 13:26:33 <aleth> deomega1: what is it? 13:26:42 <deomega1> flo: What is the pastebin you recommended? 13:27:00 <aleth> The one in the topic ;) 13:27:08 <deomega1> I think some of you are unable to access the default one 13:27:08 <flo> aleth: what about duplicating the if (insertTime >= lastInsertTime) test and not moving that whole code block? 13:27:27 <aleth> flo: Sure, if you prefer... 13:27:27 <flo> aleth: or just calling updateLastInsertTime() ? 13:27:39 <deomega1> aleth: thanks 13:27:46 <aleth> I didn't want to do that as it duplicates the DOM attribute lookup 13:28:00 <aleth> (for whatever minimal performance gain that gives... ;)) 13:28:23 <flo> it reduces the risk of confusing developers / changing it only in some of the places and not all in the future, doesn't it? 13:28:30 <aleth> Yes 13:29:32 <flo> just calling updateLastInsertTime has my preference 13:30:47 <-- igorko has quit (Client exited) 13:30:54 <flo> bah, so bug 1616 is yet another reason why the current prplIMessage API sucks :( 13:30:57 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, nobody, NEW, Unread ruler in split bubble just before an action message hides the sender name 13:31:07 <aleth> Absolutely. 13:32:10 <instantbot> florian@instantbird.org denied review for attachment 1774 on bug 1611. 13:32:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1611 nor, --, ---, aletheia2, NEW, Unread ruler movement can cause spurious Bubbles gap time text 13:32:15 <Mic> :) 13:32:40 * flo wonders if r- is the reason for Mic's happiness 13:32:41 <Mic> I think I saw the bug with "***" -> "*** nickname" before and couldn't reproduce 13:32:57 <Mic> and wondered if that meant that I'm slowly going crazy :P 13:34:03 <flo> Mic: when I see strange things like that only once and can't reproduce, I assume it's libpurple's MSN prpl having a party with random memory addresses. 13:37:51 <-- deomega1 has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 13:37:54 --> deomega1 has joined #instantbird 13:37:57 <instantbot> florian@instantbird.org denied review for attachment 1692 on bug 1338. 13:38:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat 13:41:20 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1778 on bug 1611. 13:41:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1611 nor, --, ---, aletheia2, NEW, Unread ruler movement can cause spurious Bubbles gap time text 13:47:23 <instantbot> florian@instantbird.org granted review for attachment 1778 on bug 1611. 13:47:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1611 nor, --, ---, aletheia2, NEW, Unread ruler movement can cause spurious Bubbles gap time text 13:48:46 <deomega1> I am trying to troubleshoot that bug... will let u guys know how it goes 13:49:25 <flo> is there a Tb equivalent of bug 1338 on file? 13:49:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, nobody, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat 13:49:33 <flo> that would be a perfect "excuse" to work on it ;) 13:49:38 <deomega1> i believe that it may be related to teh highlight addon 13:52:39 --> zen_monkey has joined #instantbird 14:01:16 <Mic> bye, have a nice day 14:02:22 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 14:13:57 <-- Even has quit (Connection reset by peer) 14:14:13 <-- Kaishi has quit (Quit: Kaishi) 14:21:04 <flo> aleth: I wrote the patch for Thunderbird, but I think the ib code is exactly the same, so... how do you feel about http://pastebin.instantbird.com/57553 ? 14:23:23 <flo> actually, http://pastebin.instantbird.com/57554 (added a "s" in a comment, and removed 3 lines of dead code) 14:26:49 <aleth> Hmm, doesn't that reenable the buttons too early? The issue with IRC is that it takes longer to disconnect than the timeout 14:30:53 <flo> right 14:30:57 <flo> how is that a problem? 14:31:39 <aleth> Depends on what happens when you click 'connect' and the account is still disconnecting 14:31:47 <flo> you can't 14:31:55 <flo> in the "disconnecting" state there's no visible button 14:32:33 <aleth> aha! ok then it should work 14:32:52 <flo> I'm now wondering how the context menu behaves while in the disconnecting state 14:32:53 <flo> will check 14:33:21 <-- sonny has quit (Ping timeout) 14:48:57 <flo> bah, and now I can't reproduce the bug anymore, my IRC disconnections are taking less than half a second :( 14:50:36 --> sonny has joined #instantbird 15:02:56 <-- mmkmou has quit (Ping timeout) 15:06:22 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1779 on bug 1616. 15:06:23 --> mmkmou has joined #instantbird 15:06:28 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, aletheia2, ASSI, Unread ruler in split bubble just before an action message hides the sender name 15:23:44 --> wnayes has joined #instantbird 15:26:03 --> Optimizer has joined #instantbird 15:26:10 <-- Optimizer has quit (Input/output error) 15:26:40 --> Optimizer has joined #instantbird 15:31:07 <flo> aleth: I think it works this time: http://pastebin.instantbird.com/57579 15:32:14 <flo> I think the new code is way easier to understand, but that may only be because I wrote it ;) 15:33:00 <aleth> No, I agree :) The old code was really hard to pick one's way through 15:33:46 <aleth> I didn't even notice the connect button was kept invisible, hence the chained timeouts in my patch... 15:34:14 <flo> now the next question is... can aleth review this patch for Tb? :-D 15:34:58 <aleth> Not if I have to test it on TB ;) 15:35:08 <deomega1> I believe that the problem with twitter bug 1613 has been resolved, as i have not had any problems since disabling highlight. I would have had an incident by now. SO i will close out the bug as resolved, since it is an addon issue? 15:35:11 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1613 nor, --, ---, nobody, UNCO, Twitter feed stops 15:35:39 <aleth> deomega1: Resolve it as invalid, with your explanation. Thanks! 15:35:41 <deomega1> that should be.. should i close out the bug 15:35:51 <deomega1> cool, thanks 15:36:18 <flo> aleth: do you want to test it on Ib? 15:36:33 <flo> sed can probably trivially fix the paths 15:36:36 <aleth> flo: That I can do. 15:36:50 <aleth> Hmm, can I r+ on TB without editbugs? 15:36:52 <instantbot> jahkae@gmail.com set the Resolution field on bug 1613 to INVALID. 15:36:57 <aleth> s/TB/BMO 15:36:59 <flo> that's another good question 15:37:29 <aleth> Probably easier just to pass it to clokep... 15:38:03 <flo> he already said in the bug that he doesn't know that code at all ;) 15:38:21 <flo> I can also pass it to mconley to keep him busy :-P 15:40:39 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:40:46 --> wnayes has joined #instantbird 15:40:59 <-- aleth has quit (Quit: Au revoir) 15:43:10 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 15:43:15 --> wnayes has joined #instantbird 15:46:09 * wnayes is on Moz14 now :) 15:46:31 <flo> wnayes: cool. If you notice any issue, let us know :) 15:50:35 * flo doesn't understand https://bugzilla.mozilla.org/show_bug.cgi?id=780172 15:55:21 <-- gerard-majax has quit (Ping timeout) 15:55:29 <-- deomega1 has left #instantbird () 15:56:11 <instantbot> florian@instantbird.org denied review for attachment 1779 on bug 1616. 15:56:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, aletheia2, ASSI, Unread ruler in split bubble just before an action message hides the sender name 15:56:29 <flo> aleth: that's almost r+ though ;) 16:03:06 <flo> bah, that patch doesn't apply for instantbird :( 16:09:00 <instantbot> florian@instantbird.org requested review from aletheia2@fastmail. fm for attachment 1780 on bug 1338. 16:09:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, florian, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat 16:10:03 * Optimizer is now known as Optimizing 16:21:50 <-- zen_monkey has quit (Quit: Saliendo) 16:28:37 --> clokep_work has joined #instantbird 16:28:37 * ChanServ sets mode +o clokep_work 16:28:40 * Optimizing is now known as Optimized 16:28:51 * Optimized is now known as Optimizer 16:30:12 <clokep_work> Lots of email... 16:30:25 <flo> clokep_work: things are moving forward ;) 16:32:44 --> myk has joined #instantbird 16:33:36 --> testtb has joined #instantbird 16:33:51 <testtb> Let's see how this new theme look :) 16:34:03 <testtb> hmm 16:35:02 <clokep_work> flo: If you need long disconnect times...add a 1.0s timeout on sending the QUIT command. ;) 16:35:18 <flo> nah, now I just need 2 r+ ;) 16:36:42 <clokep_work> aleth: Please request editbugs on BMO from gerv. If need be, just comment in the bug that you've "r+ed it" and add the actual flag when you get privleges. 16:37:10 <flo> clokep_work: I think he wanted to test the instantbird version before r+ing 16:37:22 <clokep_work> I agree with https://bugzilla.mozilla.org/show_bug.cgi?id=780172 for IRC. ;) I think you're not supposed to send a message more than 1 per second? 16:37:27 <clokep_work> flo: Probably, but in general. :) 16:37:57 <clokep_work> I think Highlight is broken for Twitter right now? 16:38:16 <flo> s/for Twitter // 16:38:49 <clokep_work> Ah, I was thinking of Hide Auto-Joins...which was fixed in the repo, but not the release version. 16:39:02 <flo> how does this (http://i.imgur.com/XOptp.png) feels as an "IRC" theme? 16:39:21 <flo> my understanding was that it was supposed to show more messages because people talk a lot on IRC. 16:39:56 <clokep_work> flo: That's my understanding...and it seems to have a lot of dead space on the left. 16:40:13 <clokep_work> I don't like reading like 4 words per line, it's uncomfortable. 16:41:36 <flo> my window is arguably a little bit small 16:44:53 <clokep_work> Yes, but it's nice when it works for multiple window sizes. 16:45:11 <clokep_work> For reference I keep my window about 1/4 the size of my screen and it's comfortable for reading IRC. :) 16:45:58 <flo> clokep_work: I think the Tb layout with the left pane and a right pane isn't really designed for that, so I don't think we want to optimize for people putting the window on 1/4 of the screen 16:46:30 <clokep_work> flo: I agree. I mean that my content area is probably a similar size. 16:46:50 <flo> but in Instantbird? ;) 16:46:54 <clokep_work> Yes. :) 16:47:21 <-- testtb has quit (Quit: testtb) 16:48:33 --> zen_monkey has joined #instantbird 16:48:41 --> testtb has joined #instantbird 16:50:43 <clokep_work> wnayes: Sorry I didn't have a chance to look at your code yesterday. 16:52:43 <wnayes> clokep_work: That's fine, I want to take a break from mIRC for awhile and take a fresher look at it in a few days. 16:54:43 <flo> clokep_work: with the old theme: http://i.imgur.com/Bk5Hn.png 16:56:08 <-- zen_monkey has left #instantbird (Saliendo) 16:56:11 <clokep_work> flo: The lack of color kills me. 16:58:04 <clokep_work> wnayes: Makes sense. :) I'm glad you're having better luck w/ Pidgin logs. 17:04:45 --> timA has joined #instantbird 17:07:10 --> aleth has joined #instantbird 17:07:11 * ChanServ sets mode +h aleth 17:07:35 <-- wnayes has quit (Ping timeout) 17:09:21 <-- mmkmou has quit (Ping timeout) 17:09:38 <instantbot> aletheia2@fastmail.fm granted review for attachment 1780 on bug 1338. 17:09:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1338 nor, --, ---, florian, NEW, Connect button is disabled after an account spends more than half a second in the disconnecting stat 17:09:55 <-- timA has left #instantbird () 17:10:04 --> timA has joined #instantbird 17:10:10 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1781 on bug 1616. 17:10:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, aletheia2, ASSI, Unread ruler in split bubble just before an action message hides the sender name 17:10:17 --> wnayes has joined #instantbird 17:10:30 <-- timA has left #instantbird () 17:12:35 <aleth> Why don't they just colour the nicks in TB's original style and have done with it? 17:15:30 <aleth> Though it seems a bit odd to add coloured nicks if you want to keep things fairly monochrome. 17:16:36 <aleth> Is there a TB UX team that could look at this? 17:17:19 <aleth> Since I suppose the main thing is it should fit in with the rest of TB... 17:17:27 <flo> The TB UX team is Blake ;) 17:17:41 <aleth> That's ... small ;) 17:18:48 <aleth> I thought there was someone doing the icons etc as well... 17:20:59 <flo> oh yes, Andreas 17:21:06 <flo> he did the current theme :) 17:22:15 <flo> I wonder how difficult it would be to add avatars to Paper Sheets 17:23:39 <-- testtb has quit (Quit: testtb) 17:25:22 <-- sonny has quit (Ping timeout) 17:27:38 <flo> aleth: isn't just putting a conversation on hold also losing the /me? 17:27:40 * flo tests 17:28:26 <flo> hmm, or maybe we reset .message before redisplaying the conversation? 17:29:12 <aleth> http://lxr.instantbird.org/instantbird/source/chat/content/convbrowser.xml#346 I guess 17:29:20 <flo> why are we storing the message without /me in aMsg.message btw? 17:29:56 --> sonny has joined #instantbird 17:30:43 <flo> ah, for replaceKeywordsInHTML to use it 17:30:47 <aleth> To pass it along to replaceKeyWords, and I guess for magic copy 17:32:00 * clokep_work hates that /me is what causes that to happen. 17:32:05 <clokep_work> I sitll think it should be a message flag. 17:32:18 <flo> magic copy uses orignalMessage: http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#895 17:33:06 <aleth> then at least we are consistent after the patch ;) 17:33:39 <aleth> The messageClass is also set based on originalMessage 17:35:25 <aleth> flo: magic copy http://lxr.instantbird.org/instantbird/source/chat/modules/imThemes.jsm#916 relies on msg having the /me removed already. 17:40:04 <-- wesj|away has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 17:42:35 --> wesj1 has joined #instantbird 17:48:04 <flo> clokep_work: https://bugzilla.instantbird.org/attachment.cgi?id=1781&action=diff is the comment understandable for you? :) 17:59:39 <clokep_work> flo: Yes. 18:03:18 <instantbot> florian@instantbird.org granted review for attachment 1781 on bug 1616. 18:03:20 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, ---, aletheia2, ASSI, Unread ruler in split bubble just before an action message hides the sender name 18:03:43 <-- myk has quit (Ping timeout) 18:03:57 --> myk has joined #instantbird 18:07:18 <-- Suiseiseki has quit (Connection reset by peer) 18:08:11 --> Suiseiseki has joined #instantbird 18:08:31 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/871e12a7e1cf - Florian Quèze - Bug 1338 - Connect button is disabled after an account spends more than half a second in the disconnecting state, r=aleth. 18:08:32 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/21e486855c58 - aleth - Bug 1604 - Don't show unread ruler if all the context messages were system messages, r=fqueze. 18:08:33 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/290b023e82ed - aleth - Fix JavaScript strict warning: chrome://instantbird/content/blist.js, line 153/235: variable a/b redeclares argument, r=fqueze. 18:08:34 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/0c4d8120606e - aleth - Bug 1616 - Unread ruler in split bubble just before an action message hides the sender name, r=fqueze. 18:08:35 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/6ca6cf727c46 - aleth - Bug 1611 - Unread ruler movement can cause spurious Bubbles gap time text, r=fqueze. 18:08:36 <instantbot> Check-in: http://hg.instantbird.org/instantbird/rev/fe0c0fb1c1af - aleth - Bug 1530 - Autoscroll broken after moz13 update when restoring from hold and using Bubbles, r=fqueze. 18:08:59 * flo goes home 18:09:02 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com) 18:10:55 <instantbot> clokep@gmail.com set the Resolution field on bug 1530 to FIXED. 18:10:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, 1.2, aletheia2, RESO FIXED, Autoscroll broken after moz13 update when restoring from hold and using Bubbles 18:11:36 <instantbot> clokep@gmail.com set the Resolution field on bug 1611 to FIXED. 18:11:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1611 nor, --, 1.2, aletheia2, RESO FIXED, Unread ruler movement can cause spurious Bubbles gap time text 18:12:07 <instantbot> clokep@gmail.com set the Resolution field on bug 1616 to FIXED. 18:12:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1616 nor, --, 1.2, aletheia2, RESO FIXED, Unread ruler in split bubble just before an action message hides the sender name 18:13:08 <instantbot> clokep@gmail.com set the Resolution field on bug 1604 to FIXED. 18:13:10 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1604 min, --, 1.2, aletheia2, RESO FIXED, Don't show unread ruler if all the context messages were system messages 18:16:04 <clokep_work> Lots done. :) 18:18:02 <clokep_work> I'm planning to do a few patches tonight, I think. 18:25:03 <aleth> lol @ the new "Warning: useless expression // Source File: chrome://global/content/bindings/menulist.xml Line: 389" 18:26:12 <aleth> true though, it's the wrong comment style... 18:29:41 <clokep_work> We'll probably need another "Fix all the warnings in Moz14" bug...but they can wait until after elase. 18:30:07 --> gerard-majax has joined #instantbird 18:30:19 <aleth> yep... 18:31:41 <instant-buildbot> build #300 of linux-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/300 18:33:47 <aleth> Still no idea for the memory leak though/ 18:43:24 <aleth> whoa, pages of bugspam! 18:45:16 <clokep_work> ? 18:45:49 <-- sonny has quit (Ping timeout) 18:46:26 <aleth> Well, not so much spam, just all the review/resolved messages from today... 18:47:02 <clokep_work> Ah, you mean in your mail? Yes. A lot today. :) 18:51:10 <clokep_work> aleth: Thanks for working on these bugs that cropped up btw. :) 18:52:52 --> DGMurdockIII has joined #instantbird 19:12:04 <aleth> clokep_work: They turned up like a bit like a paper jam just when you want to print something ;) 19:12:43 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0.1/20120713134347]) 19:16:53 --> Mnyromyr has joined #instantbird 19:39:52 <instant-buildbot> build #287 of win32-onCommit is complete: Success [build successful] Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/287 19:43:24 <-- clokep_work has quit (Quit: http://www.mibbit.com ajax IRC Client) 19:54:30 <-- jb has quit (Ping timeout) 20:28:48 --> flo has joined #instantbird 20:28:48 * ChanServ sets mode +qo flo flo 20:29:05 <flo> mconley's suggestion to simplify even more the account manager patch makes sense! 20:29:56 --> jb has joined #instantbird 20:30:23 <flo> aleth: http://pastebin.instantbird.com/57717 20:30:42 <aleth> Like for the context menu? Yes, that would improve the style even more :) 20:32:35 <aleth> Why do you need the explicit Iterator? 20:33:08 <aleth> because a for loop won't work? 20:35:31 <flo> a for loop would give me only the name 20:35:40 <flo> a for each loop would give me only the value 20:35:54 --> Mook has joined #instantbird 20:36:24 <aleth> You can't do |for (let [name, state] in disabledItems)| ? I guess it does look wrong 20:37:51 <flo> I'm not sure, so I guess I'll try and tell you the result 20:38:17 <aleth> :) I've never tried that construction either. 20:39:10 <flo> so, how much of the remaining list of bugs can we hope to cleanup before I go to bed? 20:39:10 <Mook> yeah, pretty sure you need the Iterator there in that case 20:39:49 <flo> aleth: without the Iterator(), both name and state are undefined 20:40:14 <aleth> Good to know. 20:40:38 <flo> I'll see if I can reproduce the leak on my linux debug build immediately before the moz14 update, and then immediately after 20:40:46 <flo> just to be sure it's not mac specific :) 20:42:15 <flo> I haven't updated my tree there in 2 months 20:42:26 <flo> it's before the moz13 update! 20:42:53 <aleth> a slightly wider regression window then... ;) 20:44:22 <flo> guess what... 20:44:29 <flo> the leak was already there in my debug build from 2 months ago! 20:45:04 <aleth> Was that when you were plugging the TB shutdown leaks? 20:45:25 <flo> not sure 20:45:35 <aleth> (^^ insert 'after' somewhere sensible) 20:45:36 <flo> but if nobody has complained in the last 2 months, we can probably wait another month to fix it 20:45:51 <flo> I intend to work on memory usage for the next version anyway 20:45:58 <aleth> Especially as there's no obvious candidate... 20:54:05 <flo> I wonder if I should commit what I've just pastebined or wait for mconley to r+ (or -) the new patch 20:56:38 --> clokep has joined #instantbird 20:56:38 * ChanServ sets mode +o clokep 21:02:59 <flo> crap I kept dump statements in the new tb patch :( 21:11:14 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1782 on bug 1614. 21:11:16 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1614 tri, --, ---, clokep, ASSI, Update the credits for Instantbird 1.2 21:18:16 <flo> clokep: have you said we aren't taking nicknames in the credits? 21:18:21 <flo> *haven't 21:18:33 <clokep> flo: No. I just said that the nicknames won't be included. 21:18:41 <clokep> I would prefer using aleth's real name though, yes. 21:18:50 <clokep> If we don't take nicks then...OK.... 21:22:45 <-- aleth has quit (Quit: Au revoir) 21:30:05 <flo> clokep: iirc we "forced" Mic to give us his real name to add him to the credits (but I already knew his name :-D) 21:31:48 <clokep> Ah, I see. 21:31:55 <clokep> Then I'll put up a new patch w/o aleth. :) 21:31:58 <clokep> I have to go though, a friend is here. 21:34:24 --> sonny has joined #instantbird 21:34:35 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105]) 21:35:38 <flo> JavaScript strict warning: chrome://instantbird/content/blist.xul, line 1: function onpopupshowing does not always return a value 21:36:30 <-- clokep has quit (Ping timeout) 22:01:09 <flo> I'm working on bug 1524 22:01:12 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1524 nor, --, ---, nobody, NEW, Moving a JS-XMPP buddy from a tag to another should work and save this change on the server 22:01:31 <-- jb has quit (Ping timeout) 22:05:27 --> vicnet has joined #instantbird 22:11:56 <flo> vicnet: French langpack installed on 1.2a1pre? :) 22:12:22 <vicnet> oui monsieur :) 22:12:47 <vicnet> it's looking good so far 22:18:45 <flo> have you noticed nice improvements in 1.2? 22:19:38 --> Kaishi has joined #instantbird 22:29:11 <-- Kaishi has quit (Quit: Kaishi) 22:29:17 --> Kaishi has joined #instantbird 22:29:55 <vicnet> I have to admit it's been so long that I haven't noticed much... :-] 22:36:02 <Kaishi> hey all 22:36:12 <Kaishi> how can I block someone? 22:36:16 <Kaishi> >__> 22:36:22 <Kaishi> I'm getting spammed by a bot and it's bugging me 22:49:09 <-- sonny has quit (Ping timeout) 23:00:31 --> DGMurdockIII has joined #instantbird 23:12:29 <-- DGMurdockIII has quit (Quit: ChatZilla 0.9.88.2 [Firefox 14.0.1/20120713134347]) 23:27:19 <instantbot> florian@instantbird.org requested feedback from clokep@gmail.com for attachment 1783 on bug 1524. 23:27:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1524 nor, --, ---, florian, NEW, Moving a JS-XMPP buddy from a tag to another should work and save this change on the server 23:27:53 <flo> Good night 23:56:14 <-- Optimizer has quit (Ping timeout)