#instantbird log on 08 01 2012

All times are UTC.

00:01:40 <aleth> phayz: At the moment, the only solutions I can think of are finding/modifying the message style to not display system messages, or writing an add-on
00:01:48 <aleth> It's bug 1230
00:01:52 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1230 nor, --, ---, nobody, NEW, Join/part messages should be handled by imConversations.js.
00:02:08 <aleth> (so in the future, we would like this to be easier...)
00:02:36 <phayz> aleth: thanks for your reply. i *should* have looked at the bug tracker but the home page said if you can't find it in the FAQ, ask in the IRC channel
00:02:52 <aleth> phayz: Sure, no problem! 
00:03:02 <aleth> I don't think an add-on already exists for this, sorry.
00:03:06 <phayz> i'll try modifying one of the themes to see if i can hide them
00:03:27 <phayz> of course if i'm successful i'm submit it for review and others to use if it's OK
00:03:35 <aleth> Good idea.
00:03:38 <clokep> phayz: It should be fairly easy.
00:03:42 <clokep> aleth: can help you with it. ;)
00:03:52 <clokep> (He can hopefully also review the patch I'm about to put up. :P)
00:04:24 <aleth> :P
00:04:30 <phayz> ok, thanks
00:05:20 <aleth> phayz: If you want to do it with an add-on, take a look at the Show Nick code.
00:05:55 <aleth> (Show Nick is an add-on, in case you don't have it...)
00:06:18 <phayz> aleth: thanks, although i promised my mother i wouldn't try my hand at coding. :D
00:07:01 <clokep> Not like you'll break a wrist. :)
00:07:03 <aleth> It's all JS, you could call it web design ;)
00:07:31 <phayz> aleth: true! :)
00:09:12 <aleth> Just without the web.
00:11:26 <instant-buildbot> build #293 of linux-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-onCommit/builds/293
00:13:29 <phayz> is anyone here using gnome 3 and worked out how to get instantbird from the notification area to the top bar?
00:14:10 <aleth> Nobody has worked on gnome3 integration yet.
00:14:41 <aleth> If you come up with any good solutions/ideas file them as bugs please ;)
00:14:54 <phayz> aleth: no problem. i've done this successfully for other apps but i just can't seem to get the right setting
00:15:00 <clokep> aleth: How comfortable are you with the commands component?
00:15:18 <aleth> bug 1382 may be relevant
00:15:21 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1382 min, --, ---, nobody, NEW, Gnome 3 tray context menu partially hidden by tray
00:15:31 <aleth> or it may not be, I don't know.
00:15:40 <phayz> my goal is to have the IB system tray icon always visible and so be notified visually when an even occurs
00:15:56 <aleth> clokep: Some bits more than others...
00:16:02 <phayz> looking...
00:16:59 * clokep thinks Mic will be happy...
00:17:03 <instantbot> clokep@gmail.com requested review from aletheia2@fastmail. fm for attachment 1763 on bug 1439.
00:17:05 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1439 nor, --, ---, clokep, ASSI, Make unambiguous command prefixes work as command aliases
00:17:18 <aleth> Really it would take someone actually using gnome3 to fix this properly.
00:17:33 * clokep uses Unity...unfortunately...
00:17:40 <clokep> Well I use Windows 90% of the time. :P
00:17:56 <aleth> How's the Metro? (no snark intended)
00:18:34 <clokep> I like it so far.
00:18:44 <aleth> clokep: Hey, that's a shorter patch than I expected :)
00:18:44 <clokep> I mean I don't have a touch screen so it's probably not as awesome as it could be.
00:18:48 <clokep> (I don't even have a touch pad.)
00:19:15 <clokep> But Windows 8 runs insanely fast on my laptop (way faster than Windows 7 did). And no major issues yet.
00:19:26 <aleth> Yeah, I can imagine it working really well if you can swipe.
00:19:58 * clokep thought flo went to bed...
00:19:59 <aleth> Wow, a speedup on a windows upgrade? Nice!
00:20:43 <aleth> clokep: You could test the bug 1107 patch before it has its first birthday ;)
00:20:46 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1107 nor, --, ---, aletheia2, ASSI, Contact list section header styling for Linux
00:20:57 <aleth> (next time you are on unity)
00:21:02 <clokep> I can do it now...
00:21:10 <clokep> I never actually use Unity...I just remote desktop into it. ;)
00:21:19 <clokep> (And yes, I mean remote desktop and not vnc. :P)
00:21:32 <aleth> :)
00:21:43 <clokep> Oh wait....I need to get my SSH keys and install putty then hahaha.
00:22:29 <clokep> Well I guess not for a remote session....just means I can't SSH...
00:22:42 <aleth> putty is not a large download ;)
00:23:16 <clokep> Finding my private key from my old drive is the real issue. ;)
00:23:32 <aleth> Btw that bug has screenshots for KDE4 and gnome2, but hasn't been tested with gtk3
00:23:52 <aleth> So it's definitely a good idea to try it on unity...
00:28:15 --> clokep_linux has joined #instantbird
00:29:10 <-- clokep_linux has quit (Client exited)
00:30:01 <-- GeekShadow has quit (Ping timeout)
00:30:34 <clokep> aleth: It's building.
00:30:36 --> GeekShadow has joined #instantbird
00:37:30 <-- timA has quit (Quit: Instantbird 1.1)
00:41:20 <instantbot> aletheia2@fastmail.fm granted review for attachment 1763 on bug 1439.
00:41:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1439 enh, --, ---, clokep, ASSI, Make unambiguous command prefixes work as command aliases
00:43:39 <-- GeekShadow has quit (Ping timeout)
00:43:50 <clokep> aleth: Does that mean "r+ with that fix"?
00:44:06 <aleth> clokep: Yes, but it's a trivial fix, so carry it forward :)
00:46:48 --> GeekShadow has joined #instantbird
00:46:56 <instantbot> clokep@gmail.com granted review for attachment 1764 on bug 1439.
00:46:58 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1439 enh, --, ---, clokep, ASSI, Make unambiguous command prefixes work as command aliases
00:47:16 <aleth> Finally Mic can /j again...
00:47:35 <clokep> Yeah. :)
00:48:21 <clokep> We'll see what flo thinks of it. ;)
00:49:37 <aleth> It's the obvious place to put the fix imho.
01:13:01 <clokep> I thought so too, especially when it's rather simple. :-)
01:32:19 <instant-buildbot> build #261 of macosx-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-onCommit/builds/261
01:42:33 <instant-buildbot> build #281 of win32-onCommit is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/win32-onCommit/builds/281
01:47:40 <-- aleth has quit (Quit: Au revoir)
02:18:51 <instant-buildbot> build #662 of win32-nightly-default is complete: Failure [failed shell]  Build details are at http://buildbot.instantbird.org/builders/win32-nightly-default/builds/662
02:39:04 <-- GeekShadow has quit (Ping timeout)
03:11:43 <instant-buildbot> build #575 of linux-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/linux-nightly-default/builds/575
03:28:40 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0.1/20120713134347])
04:11:36 <-- wnayes has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
04:32:45 --> GeekShadow has joined #instantbird
04:40:45 <-- GeekShadow has quit (Ping timeout)
04:47:02 --> Optimizer has joined #instantbird
06:05:56 <-- EionRobb has quit (Quit: Leaving.)
06:06:41 <instant-buildbot> build #567 of macosx-nightly-default is complete: Success [build successful]  Build details are at http://buildbot.instantbird.org/builders/macosx-nightly-default/builds/567
06:15:21 <-- Optimizer has quit (Ping timeout)
06:32:09 --> GeekShadow has joined #instantbird
06:33:07 <-- Kaishi has quit (Ping timeout)
06:36:56 --> Kaishi has joined #instantbird
07:02:04 <-- GeekShadow has quit (Ping timeout)
07:16:10 --> GeekShadow has joined #instantbird
07:29:41 <-- GeekShadow has quit (Ping timeout)
07:30:15 --> gerard-majax has joined #instantbird
07:30:53 --> gerard-majax_ has joined #instantbird
07:32:06 <-- gerard-majax has quit (Ping timeout)
07:35:50 <-- Even1 has quit (Input/output error)
07:38:34 --> GeekShadow has joined #instantbird
07:53:49 --> DGMurdockIII has joined #instantbird
07:56:53 <-- Mook has quit (Quit: Mook)
08:13:35 --> jb has joined #instantbird
08:23:00 --> Even1 has joined #instantbird
08:23:08 <-- Even1 has quit (Quit: Even1)
08:23:29 --> Even1 has joined #instantbird
08:30:31 <-- clokep has quit (Connection reset by peer)
08:34:59 --> clokep has joined #instantbird
08:34:59 * ChanServ sets mode +o clokep 
08:36:16 * gerard-majax_ is now known as gerard-majax
08:38:57 --> igorko has joined #instantbird
08:43:24 --> aleth has joined #instantbird
08:43:24 * ChanServ sets mode +h aleth 
08:55:26 --> flo has joined #instantbird
08:55:26 * ChanServ sets mode +qo flo flo 
09:14:15 --> Mic has joined #instantbird
09:14:16 * ChanServ sets mode +h Mic 
09:14:36 <-- GeekShadow has quit (Ping timeout)
09:16:39 --> GeekShadow has joined #instantbird
09:16:44 <-- jb has quit (Quit: jb)
09:19:23 --> jb has joined #instantbird
09:20:36 <Mic> :o
09:20:51 <Mic> Australis is the best thing that ever happened to Tb's UI :)
09:21:05 <Mic> It actually looks nice now
09:22:15 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0.1/20120713134347])
09:26:53 <aleth> Hmm, looks like the blog post scheduling didn't work for some reason
09:27:40 <instantbot> florian@instantbird.org granted review for attachment 1573 on bug 1492.
09:27:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1492 min, --, ---, nobody, NEW, Rename purpleConversation -> prplConversation where appropriate
09:29:59 <aleth> Could be a timezone thing.
09:33:57 --> Mic|tb has joined #instantbird
09:34:00 <flo> bah, I wanted to put an r+ on bug 1497, but I thought I would try it before
09:34:03 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
09:34:28 <flo> and both with and without the patch, when I check the "work offline" checkbox of the profile manager, instantbird fails to start, with this error message: An exception occurred while initializing the core component: [Exception... "'Failure' when calling method: [imIAccountsService::processAutoLogin]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///Users/florian/buildhg/obj-instantbird-dbg/mozilla/dist/InstantbirdDebu
09:34:33 <Mic|tb> Ah, thank god - our message styles install on Thunderbird as well :)
09:34:54 <flo> Mic|tb: but you need to go in about:config to start using them, don't you?
09:34:57 <Mic|tb> Their default thing is so unusable when you're used to Bubbles
09:35:11 <aleth> :(
09:35:29 <Mic|tb> An addon adding our themes pane to their options dialog should do, I guess?
09:35:30 * flo wonders if aleth's reaction is for the unusable Tb theme or the startup failure
09:35:45 <flo> Mic|tb: it would work, yes.
09:35:45 <aleth> The startup failure
09:36:18 <aleth> I don't think it was ever tested with the profile manager option before, just with -status offline
09:36:32 <flo> aleth: bah... http://lxr.instantbird.org/instantbird/source/chat/components/src/imAccounts.js#870
09:37:01 <flo> should we just kill these 2 lines?
09:37:43 <-- igorko has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
09:37:52 <Mic> + The themes need to be compatible with Tb to install :(
09:38:00 <aleth> flo: I can't actually reproduce this :-/ When I click on "work offline", that flag just seems to be ignored 
09:39:00 <flo> hmm, I'm not sure I correctly rebuilt without the patch
09:40:07 <aleth> (of course the last comment applies to the latest nightly, without 1497 patch)
09:41:35 <aleth> Mic: only do that if you're willing to support it
09:42:48 <Mic> I might do that to show people that it's possible to have other themes and then let them complain so long that Tb devs want to include it by default :P
09:43:01 <flo> aleth: so I think we agreed that we will need to add a string in the account manager in 1.3 saying "the account will be reconnected when you are no longer offline"
09:43:16 <flo> aleth: how should the account manager know that an account is in that state?
09:43:35 <flo> Mic: include what by default?
09:44:10 <Mic> A way to change the message style themes
09:44:23 <flo> there's one from about:config :-P
09:46:28 <flo> aleth: I didn't rebuild correctly. Without the patch ib starts fine with "work offline" checked
09:48:05 <flo> aleth: I suspect you edited that diff with an editor that stripped trailing whitespace from it :-P
09:48:48 <aleth> Could be... I remember I split the patch in two by hand and regretted it later.
09:50:08 <flo> that list is long: https://bugzilla.instantbird.org/buglist.cgi?bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&target_milestone=1.2&list_id=2502 ! :)
09:50:35 <aleth> flo: I'm not sure what the best way would be for the account manager to know. 
09:50:55 <Mic> The lag when changing between channels with the Tb chat is terrible .. is it rebuilding the participant list everytime that the channel is changed maybe? This would also explain why the activity-highlight (colored nick names of people who already said something) are cleared everytime...
09:50:58 <aleth> 212 bugs :)
09:51:20 --> mmkmou has joined #instantbird
09:51:46 <instantbot> florian@instantbird.org cancelled review?(florian@instantbird .org) for attachment 1585 on bug 1497.
09:51:49 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
09:52:06 <flo> aleth: so do you want use to check-in Attachment #1765 for 1.2?
09:52:44 <flo> *us
09:53:09 <aleth> I'm confused, are you talking about bug 1497 or ??
09:54:01 <flo> yes
09:56:11 <flo> I'm still confused by that bug
09:56:17 <aleth> The drawback I see is that if you start with necko offline, there would no longer be any feedback to the user why the accounts could not connect, right?
09:56:29 <flo> right
09:56:34 * aleth is confused a bit too
09:58:15 <-- jb has quit (Quit: jb)
09:58:44 <aleth> The reason I like the idea of checking it in is because it would fix the bug, but it would be with a non-optimal UI. The question is whether it would be too confusing.
09:59:04 <flo> you mean fix the BMO bug?
09:59:46 <flo> oh, I hadn't even looked at the summary of the bug :-D Do we really connect the accounts when the status is offline? :-S
09:59:57 <aleth> That was the bug ;)
10:01:05 <aleth> Hmm, but I can't reproduce with the latest nightly any more
10:01:21 <flo> hasn't your other patch fixed that?
10:01:37 <aleth> Seems that part was also in bug 1499
10:01:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1499 nor, --, 1.2, aletheia2, RESO FIXED, Avoid attempting to connect accounts while offline, and disconnect connecting accounts when going of
10:01:55 <aleth> It's confusing because we split the patch in two but most of the testing was with the whole patch.
10:01:59 <flo> time to fix the title then? :)
10:05:13 <instantbot> Just appeared in Blog@instantbird.org - http://blog.instantbird.org :
10:05:14 <instantbot> http://blog.instantbird.org/2012/08/tab-completion-in-instantbird-1-2/ - Tab completion in Instantbird 1.2
10:05:54 <aleth> I guess it's 10am on instantbird.com :P
10:07:42 <flo> it's 10am UTC now
10:08:23 --> jb has joined #instantbird
10:09:17 <flo> that post looks great! :)
10:09:29 <aleth> Thanks :)
10:12:29 --> igorko has joined #instantbird
10:15:33 <flo> Mic|tb: no, I don't think it's been filed
10:15:39 <Mic> OK, thanks
10:16:38 <flo> I think it's a candidate for being fixed in Tb15beta though :)
10:23:18 <Mic> ?
10:23:53 <flo> Mic: ??
10:23:54 <Mic> I tried the current nightly build and it wasn't fixed there.
10:24:46 <flo> I meant if someone (possibly me) creates a patch for it within the next 2 weeks, it's likely to be approved to go in comm-beta and be fixed for Tb15
10:25:05 <clokep> Nice post. :)
10:30:07 <-- Mic|tb has quit (Ping timeout)
10:30:17 --> clokep_linux has joined #instantbird
10:30:58 <Mic> Joining #ubuntu with Tb was a bad idea :S
10:30:59 <-- clokep_linux has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
10:31:26 <flo> is this accurate: https://etherpad.mozilla.org/ib-1-2-todo ?
10:32:10 <flo> it seems I'm blocking everything :(
10:34:13 <flo> Mic: you don't have canconfirm on BMO, or is there a specific reason for filing this as unconfirmed?
10:34:28 <Mic> I can't confirm, no.
10:35:57 <flo> email https://bugzilla.mozilla.org/buglist.cgi?quicksearch=reporter%3Abenediktp;list_id=3891963 to Gerv? ;)
10:37:40 <flo> aleth should do it too https://bugzilla.mozilla.org/buglist.cgi?quicksearch=reporter%3Aaleth;list_id=3891980 ;)
10:38:07 <aleth> There's not much there though ;) 
10:38:14 <clokep> flo: Don't you want RESOLVED bugs in there too?
10:38:24 * aleth has more patches on c-c than BMO comments :P
10:38:49 <flo> clokep: well, aleth has one reso inco and one reso dupl, so it doesn't really help ;)
10:39:10 <clokep> Who has the link to the 1.2 draft release notes? I seem to have only viewed it at work...
10:39:13 <clokep> (Mic maybe?)
10:39:27 <flo> http://www.gerv.net/hacking/before-you-mail-gerv.html says " If you want "canconfirm", email me the URLs of three good bug reports you've filed."
10:39:27 * aleth has the awesome bar
10:39:29 <aleth> https://etherpad.mozilla.org/ib1-2-releasenotes-wip2
10:40:02 <aleth> When is the BIO/BMO merge? that should fix things...
10:40:53 <clokep> aleth: We haven't heard anything in a while, I was planning to ping on that bug soon...
10:41:01 <clokep> "Q3" we were told.
10:41:09 <aleth> Same with the new mailing list :-S
10:41:28 <clokep> Yes. I'm starting to get a bit pissed abou tthat...
10:42:23 <flo> "     • Old messages are now styled differently (as "context") in all of the default message styles." is hard to understadn. I had to read it 2-3 times before understanding what change that was referring to
10:43:49 <flo> aleth: much better! :)
10:44:15 <flo> " •  Twitter messages have a context menu that allows both to "Reply",  "Retweet" and to copy the url of the tweet on twitter.com." that was in 1.2? It seems we have had it forever :-S
10:47:17 <clokep> Yeah, 1.2 is taking a long time. :(
10:47:46 <aleth> Going back to 1.1 is not fun.
10:47:53 <flo> aleth: try 0.1
10:47:56 <flo> that's really fun :)
10:48:18 <flo> or even
10:48:27 <flo> if you don't want to be that extreme :)
10:48:52 <aleth> :)
10:51:18 <flo> aleth: I really don't feel confident about the patch in bug 1530
10:51:22 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll subtly broken after moz13 update
10:51:30 <flo> seems like something going to cause obscure regressions at the last minute if we take it now
10:51:42 <-- igorko has quit (Connection reset by peer)
10:51:48 --> igorko has joined #instantbird
10:52:38 <flo> I hadn't noticed bug 1471 had a patch. And it seems trivial! :)
10:52:40 <aleth> flo: How would you feel about taking out the change you didn't like (in addMsg) but committing the fix in showFirstMessages. That can't cause any regressions
10:52:41 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1471 nor, --, ---, aletheia2, NEW, Log viewer content is missing context menu
10:52:50 <aleth> (as far as I can see)
10:53:45 <flo> aleth: is that just the added this._scrollingIntoView = true; ?
10:53:52 <aleth> flo: yes.
10:53:52 <Mic> hmm, I could as well file our bug 1511 in BMO too and attach my patch for it there. After another patch, I could request editbugs then...
10:53:55 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1511 nor, --, ---, benediktp, ASSI, Possible to add duplicate accounts
10:54:04 <aleth> Though one could take the improved comments too ;)
10:54:10 <clokep> Mic: You don't need patches for edit bugs.
10:54:21 <flo> aleth: I would need to look seriously at that code again before agreeing, but I can consider it as it seems acceptable.
10:54:42 <aleth> flo: It does fix a really annoying regression.
10:54:59 <aleth> Even if sadly it's not the whole of the bug.
10:55:25 <flo> I'm willing to believe that (even though I never reproduced that regression (and never really tried; I just never encountered that bug))
10:56:10 <aleth> If you haven't seen it, I suspect it might be OS-specific as to how many scroll events are triggered when.
10:58:11 <-- clokep has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:10:38 <-- Mic has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:32:10 <flo> a mozilla update 2 days before a release? :(
11:32:58 <aleth> maybe not, but you did suggest it at one point ;)
11:33:11 <flo> yeah... :(
11:47:06 --> sonny has joined #instantbird
11:50:52 --> clokep_work has joined #instantbird
11:50:52 * ChanServ sets mode +o clokep_work 
11:54:14 <clokep_work> Well the newest iteration of the Thunderbird theme looks a little better.
11:58:38 <-- Even has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
11:58:46 --> Even has joined #instantbird
11:58:46 * ChanServ sets mode +o Even 
11:59:06 <flo> what do you dislike about it?
12:00:36 * flo thinks the system message timestamp on the left when message timestamps are on the right look really out of place
12:02:55 <-- jb has quit (Quit: jb)
12:03:10 --> jb has joined #instantbird
12:03:42 --> testtb has joined #instantbird
12:05:04 <clokep_work> I'm not a big fan of having the nicks aligned altogether with , if the same person talks multiple times you get a lot of wasted space for that column.
12:06:06 <testtb> right. Lots of people seem to believe they like that though :-/.
12:08:13 <aleth> A media query might solve that.
12:08:17 <-- jb has quit (Quit: jb)
12:09:46 --> jb has joined #instantbird
12:09:46 <flo> things don't look like on the screenshot when I apply the patch :-S
12:11:59 <-- mmkmou has quit (Ping timeout)
12:14:45 * flo isn't that far from suggesting we take bubble without the bubble backgrounds.
12:15:24 --> mmkmou has joined #instantbird
12:15:59 <-- clokep_work has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
12:16:33 <flo> %service% sucks
12:16:45 <flo> it returns IRC for ongoing conversations, and irc for logged conversations
12:23:08 <-- SM0TVI has quit (Quit: I view things as they are, without regard to place or person; my country is the world, and my religion is to do good. -- Thomas Paine (*1737 †1809))
12:23:16 * aleth hopes flo doesn't do that
12:23:36 <flo> what?
12:24:09 <aleth> use a butchered version of Bubbles for TB
12:24:39 <flo> aleth: it's already what's being done ;)
12:25:59 <aleth> Right, but it looks different enough.
12:26:29 <flo> different enough for people to not notice that we wrote some of it? ;)
12:27:10 <flo> with the patch applied, currently things look like this for the ongoing conversation http://i.imgur.com/oonc8.png and like this for the conversation read from the logs: http://i.imgur.com/pRmfd.png
12:27:19 <flo> see which one is displaying more messages ;)
12:27:44 <aleth> I have no idea what they are aiming for
12:28:02 <aleth> "make IRC look more like xchat"?
12:28:10 <flo> butchering classes maybe? ;)
12:29:06 <aleth> ;)
12:29:13 <aleth> At least the ongoing conversation doesn't have the indent ;)
12:29:23 <flo> but it's a bug ;)
12:29:44 --> SM0TVI has joined #instantbird
12:32:18 <-- mmkmou has quit (Ping timeout)
12:55:07 --> mmkmou has joined #instantbird
12:59:36 <flo> what's calling disconnect()? (re your comment in bug 1497)
12:59:39 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1497 nor, --, ---, aletheia2, ASSI, "-status offline" command line parameter doesn't stop accounts from connecting
13:02:15 <aleth> The status observer in imAccount, I think
13:18:44 <-- igorko has quit (Client exited)
13:47:41 <-- Kaishi has quit (Quit: Kaishi)
14:10:49 <-- meh has quit (Ping timeout)
14:12:07 --> meh has joined #instantbird
14:13:58 <-- meh has quit (Ping timeout)
14:18:06 <flo> have I mentioned already a how much I hate our code related to aliases? :-/
14:28:02 --> meh has joined #instantbird
14:36:06 <-- sonny has quit (Ping timeout)
14:48:59 --> zen_monkey has joined #instantbird
15:14:17 <-- gerard-majax has quit (Ping timeout)
15:17:04 <-- zen_monkey has left #instantbird (Saliendo)
15:24:27 --> wnayes has joined #instantbird
15:41:13 --> clokep_work has joined #instantbird
15:41:13 * ChanServ sets mode +o clokep_work 
15:42:24 <clokep_work> flo: Yes, you mention you hate that a lot. :P
15:46:06 <flo> clokep_work: I have a WIP if you want to hate it too ;)
15:46:29 <flo> http://pastebin.instantbird.com/56363
15:47:28 <-- jb has quit (Quit: jb)
15:47:49 --> jb has joined #instantbird
15:47:50 <flo> as is, I've verified that it fixes bug 1557 and bug 1523
15:47:53 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1557 nor, --, ---, nobody, NEW, Contact names set in other clients don't show in Instantbird
15:47:54 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1523 nor, --, ---, nobody, NEW, Aliasing a JS-XMPP buddy should store the alias on the server
15:48:05 <flo> but I'm afraid it causes a regression, that I haven't fully tracked down yet
15:48:22 <flo> so it would be feedback?, not r? yet :)
15:48:22 <clokep_work> Mmhmm.
15:48:26 <clokep_work> It looks complicated.
15:48:57 <flo> assume lines 48-60 don't exist in the pastebin :-/
15:49:57 <flo> http://pastebin.instantbird.com/56364 should look a little more reasonable
15:52:11 * clokep_work sees both _rosterAlias and rosterAlias used.
15:52:14 <clokep_work> Is that correct?
15:52:24 <flo> define "correct" ;)
15:52:38 <clokep_work> Clear. :P
15:52:44 <flo> _rosterAlias is a value. rosterAlias is a setter that causes a notification to be fired ;)
15:53:06 <flo> the serverAlias code in jsProtoHelper is already like that
15:53:32 <flo> the only difference is that now in JS-XMPP I'm dealing with 2 different kinds of server aliases. A read-only one, and a read/write one :-/.
15:53:54 <clokep_work> That sounds awful.
15:54:02 <clokep_work> I think those lines need a comment of some sort. :)
15:54:08 <clokep_work> I immediately assumed it was a typo.
15:54:16 * flo adds "// this sounds awful." as a comment
15:54:44 <clokep_work> Add a proper citation, please. :P
15:55:24 <flo> I thought lines 114-119 were clear enough about the difference between with an without the _
15:56:03 <clokep_work> Yeah those are the exact lines that confused me. :P
15:56:17 <clokep_work> But maybe just because I'm looking at a diff.
15:56:30 <clokep_work> (It makes me tend to not look at close to the code not being changed).
15:58:41 <flo> someday I should do another rewrite of the blist
15:59:09 <flo> to have clear APIs around the various aliases and names
15:59:21 <flo> to make using contacts without caring about tags easier
15:59:36 <clokep_work> Nice. :)
15:59:38 <flo> and to get rid of synchronous sqlite requests
16:00:02 <flo> or maybe even get rid of blist.sqlite completely
16:00:22 <flo> now that we access it only from JS, putting it all in a lazily written JSON file seems way easier
16:02:18 <clokep_work> Is this before or after we rewrite the proxy interfaces? :P
16:02:28 <flo> so how would you feel about it if I told you I'm going to deal with a third serverAlias value in xmpp.jsm to fix the regression? ;)
16:02:38 <flo> what proxy interface?
16:03:30 <flo> we should just make libpurple use the stupid necko APIs instead of its own different stupid APIs; and then drop all the purpleIProxy* crap
16:03:43 <clokep_work> Yeah, I agree.
16:03:55 <clokep_work> What's the third type of alias?
16:04:20 <clokep_work> I feel like XMPP is the result of like too many comproimses or something (note that I have no idea how XMPP was created).
16:04:25 <flo> the locally cached value in sqlite, that is the only one we can access until the account is connected :-D
16:04:26 <clokep_work> It just seems there's too many ways to do a lot of things.
16:04:59 <flo> the 2 server aliases XMPP has aren't stupid. It's our API around aliases that's stupid.
16:05:34 <flo> one is set by the user (a real alias, stored in our server-stored copy of the buddy list) and the other one is the display name set by the contact in his vCard.
16:06:19 --> timA has joined #instantbird
16:07:46 <flo> "It's our API around aliases that's stupid." that's the result either of my misunderstanding of some libpurple APIs back in 2007, or of us inheriting at that time some libpurple APIs that are stupid too :).
16:08:06 <clokep_work> Ah, I see.
16:08:13 <flo> either way, it's old probably now-irrelevant things that are making our API suck.
16:08:16 <clokep_work> So there's our alias (that we set) and their alias that they set, essentailly.
16:08:18 <clokep_work> I guess that's reasonable.
16:08:44 <-- jb has quit (Quit: jb)
16:09:10 --> jb has joined #instantbird
16:09:41 <flo> yeah, it's reasonable
16:11:04 <-- jb has quit (Ping timeout)
16:12:43 <flo> http://lxr.instantbird.org/instantbird/source/chat/protocols/xmpp/xmpp.jsm#347 is also something we should get rid of
16:13:02 <flo> the prpl shouldn't access .buddy, even less .buddy.contact
16:14:07 <flo> but I suspect that requires redesigning the prplIMessage interface and adding an imIMessage wrapper around it so that the contact alias can be added by the imIConversation
16:14:30 --> myk has joined #instantbird
16:15:03 * timA is now known as timA|mtg
16:15:36 <clokep_work> :-/
16:16:32 <flo> prplIMessage is another interface that's known to be old and broken ;)
16:17:25 <flo> one of the rare pieces of idl that we haven't largely modified for the js-proto changes :)
16:17:54 <-- myk has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:18:42 --> myk has joined #instantbird
16:21:16 --> DGMurdockIII has joined #instantbird
16:21:17 <flo> I just changed this line to fix the bug:   get serverAlias() this._rosterAlias || this._vCardFormattedName || this._serverAlias,
16:21:21 <flo> how many comments do you need? :)
16:21:52 <clokep_work> More. ;)
16:28:22 <-- clokep_work has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
16:29:34 * timA|mtg is now known as timA
16:29:35 <flo> do we have a plan for the 3 locales that were shipped for 1.1 but aren't ready?
16:30:27 <flo> aleth: could you add a patch containing only what you think we should check-in for 1.2 in the autoscroll bug? :)
16:36:23 <instantbot> aletheia2@fastmail.fm requested review from florian@instantbird .org for attachment 1766 on bug 1530.
16:36:26 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1530 nor, --, ---, aletheia2, ASSI, Autoscroll subtly broken after moz13 update
16:37:06 <flo> I have a "Re: Instantbird 1.2 string freeze" conversation in my gmail box, but I can't find the original message. Where did it go? :-S
16:38:09 <aleth> Dunno, maybe ask some TB localizers for those locales if they would like to volunteer? ;)
16:39:08 <flo> I hope it hasn't disappeared because gmail thought it was spam. If it did, then the same could have happened for the localizers who haven't done anything :-S
16:40:06 <aleth> oh dear...
16:44:36 <flo> a reply from Michal Stanke contains a full citation of the original message so I can see its content
16:44:44 <flo> but it's still strange that I can't find it :-S
16:48:11 <flo> and nobody's commiting anything to the pt-br repository
16:49:12 <aleth> Strange... I wonder if the guy who showed up here ever figured out how
16:49:22 <flo> he wasn't the locale manager
16:49:41 <flo> and was waiting for that person to show up. Which afaik never happened
17:12:34 --> BYK has joined #instantbird
17:13:49 <-- mmkmou has quit (Ping timeout)
17:22:07 <-- SM0TVI has quit (Ping timeout)
17:23:22 --> SM0TVI has joined #instantbird
17:39:04 --> Mook has joined #instantbird
17:45:46 <flo> so I got a reply to my email to the french translator, saying that he hasn't started because he was busy moving to a house he has just bought, but it expects to start today.
17:48:25 --> jb has joined #instantbird
17:53:01 --> sonny has joined #instantbird
17:57:08 <-- BYK has quit (Quit: Mobile)
18:04:05 <-- timA has quit (Ping timeout)
18:04:52 * aleth hates it when FF loses all its history
18:05:27 --> gerard-majax has joined #instantbird
18:12:27 --> timA has joined #instantbird
18:13:26 * timA is now known as IRCMonkey45475
18:13:59 <-- aleth has quit (Quit: Au revoir)
18:16:48 * IRCMonkey45475 is now known as timA
18:17:08 --> aleth has joined #instantbird
18:17:08 * ChanServ sets mode +h aleth 
18:25:31 <-- jb has quit (Ping timeout)
18:26:05 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1767 on bug 1523.
18:26:13 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1523 nor, --, ---, florian, ASSI, Aliasing a JS-XMPP buddy should store the alias on the server
18:27:15 <-- flo has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
18:30:32 <-- testtb has quit (Ping timeout)
18:33:04 <-- sonny has quit (Ping timeout)
18:39:04 <-- meh has quit (Ping timeout)
18:39:11 --> meh has joined #instantbird
18:41:54 --> FeuerFliege has joined #instantbird
18:54:12 --> Kaishi has joined #instantbird
18:56:06 <-- FeuerFliege has quit (Ping timeout)
18:57:29 <-- timA has quit (Quit: Instantbird 1.1)
19:03:30 --> sonny has joined #instantbird
19:06:41 --> Mnyromyr has joined #instantbird
19:10:09 --> FeuerFliege has joined #instantbird
19:18:22 <-- sonny has quit (Ping timeout)
19:24:49 <-- meh has quit (Ping timeout)
19:29:08 --> meh has joined #instantbird
19:29:36 <-- Kaishi has quit (Ping timeout)
19:32:39 <-- FeuerFliege has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
19:36:50 <-- DGMurdockIII has quit (Quit: ChatZilla [Firefox 14.0.1/20120713134347])
19:40:14 --> sonny has joined #instantbird
19:54:07 --> timA has joined #instantbird
20:00:29 <-- gerard-majax has quit (Ping timeout)
20:24:38 --> FeuerFliege has joined #instantbird
20:30:46 --> jb has joined #instantbird
20:33:22 --> flo has joined #instantbird
20:33:22 * ChanServ sets mode +qo flo flo 
20:36:43 --> DGMurdockIII has joined #instantbird
20:43:23 <-- jb has quit (Ping timeout)
20:44:07 <-- FeuerFliege has quit (Ping timeout)
20:46:18 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
20:51:26 --> EionRobb has joined #instantbird
21:01:52 <flo> aleth: have you ever seen this: http://i.imgur.com/FUhHA.png ?
21:02:44 <flo> there's actually 22s between the 2 messages that time bubbles shows as having a 24min59s interval
21:02:53 <flo> could it be that the unread ruler is confusing Time Bubble's calculations?
21:02:56 <-- myk has quit (Ping timeout)
21:07:29 <aleth> flo: I've not seen that before
21:07:38 <aleth> Was it after restoring from hold, or just elapsed time?
21:07:57 <flo> nothing special
21:08:06 <aleth> I have seen something odd once that might be related
21:08:17 <flo> I just switched between #maildev and a private Gtalk conv, and back to #maildev
21:08:39 <aleth> I sent a message and immediately afterwards the 5+ minute time text appeared underneath
21:08:44 <flo> no steps to reproduce
21:08:53 <aleth> So I sent another message and it remained between the bubbles
21:08:59 <flo> I could point DOMi at it if wanted, but I'm not sure that would give any useful info
21:09:06 <aleth> Closing and then restoring from hold made it go away.
21:09:29 <aleth> I'm not sure what caused that either.
21:10:11 <aleth> In that instance I don't even think there was a ruler...
21:10:36 <aleth> I don't think DOMi would help either, beyond maybe noting the exact timestamps
21:11:17 --> myk has joined #instantbird
21:12:06 <flo> bah, we should also take http://hg.mozilla.org/comm-central/rev/ae63e80cfbfa but it requires string changes :(
21:12:18 <flo> hmm, or maybe we don't care
21:12:38 <flo> as Instantbird is always called Instantbird even in nightlies, as opposed to Daily/Earlybird/Thunderbird
21:13:17 <flo> aleth: the timestamps seem correct, but maybe we could see if there are strange JS values
21:13:32 <flo> aleth: the unread ruler is no longer there as I've switched to the #instantbird tab since that
21:13:48 <flo> but the absurd "24min59s" is still here
21:14:32 <aleth> it's not dynamically calculated.
21:14:34 <aleth> I bet it disappears if you restore from hold.
21:15:07 <flo> I don't doubt it
21:15:45 --> meh has joined #instantbird
21:16:19 <aleth> I don't think the ruler can have anything to do with it as it is only inserted after the time calculation has taken place.
21:16:39 <aleth> But who knows...
21:17:55 <aleth> Hmm, actually I'm not sure that's correct.
21:18:21 <aleth> I'll have to look at the code again.
21:18:42 <flo> aleth: does this http://pastebin.instantbird.com/56491 look like a correct port of http://hg.mozilla.org/comm-central/rev/ac372b721b16 ?
21:19:19 <flo> aleth: I dislike bugs without steps to reproduce, so I'll pretend it didn't happen until I see it again ;).
21:23:59 <aleth> It looks OK, but I have no idea of the context...
21:25:13 --> clokep has joined #instantbird
21:25:13 * ChanServ sets mode +o clokep 
21:27:01 <-- clokep has quit (Ping timeout)
21:27:13 --> clokep has joined #instantbird
21:27:13 * ChanServ sets mode +o clokep 
21:28:51 <flo> clokep may want to look too, "23:18:42 - flo: aleth: does this http://pastebin.instantbird.com/56491 look like a correct port of http://hg.mozilla.org/comm-central/rev/ac372b721b16 ?"
21:29:34 <flo> ie. is any one willing to r= bug 1474 before I check it in ;)
21:29:37 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1474 nor, --, ---, nobody, NEW, Port Mozilla Bug 494311 - Remove the locale from updater.ini
21:30:37 <clokep> flo: That looks fine I think.
21:31:17 <flo> if we can still update in 2 nightlies, it worked fine too ;)
21:31:27 <flo> ok, /me takes r=clokep
21:33:09 <clokep> I also dislike bugs without STR. :P
21:35:54 <clokep> I've also seen weird Time Bubbles stuff occasionally.
21:36:08 <clokep> Two message immediately after each other with like 1 day inbetween.
21:36:58 <-- myk has quit (Ping timeout)
21:37:58 <flo> clokep: what's that app-license.html business in bug 1546?
21:38:02 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
21:38:48 --> myk has joined #instantbird
21:39:23 <-- meh has quit (Quit: I don't want to live on this planet anymore.)
21:40:09 <clokep> flo: What's your question?
21:40:20 <flo> I don't understand what you are doing/trying to do with it
21:40:20 <clokep> It doesn't work still.
21:41:04 <flo> for example why have you changed MAIL_APP_LICENSE_FILE to APP_LICENSE_FILE and stopped using it
21:41:18 <flo> (the value is inlined directly in -DAPP_LICENSE_BLOCK=$(srcdir)/app-license.html)
21:42:30 <-- DGMurdockIII has quit (Connection reset by peer)
21:42:49 --> DGMurdockIII has joined #instantbird
21:43:21 <clokep> I got rid of the MAIL_ prefixes because they don't make any sense.
21:43:42 <clokep> I stopped using it because I was trying to test and get it to work.
21:43:47 <clokep> But it /still/ doesn't work.
21:49:25 <flo> ok
21:49:48 <flo> the magic happens at http://mxr.mozilla.org/comm-central/source/mail/base/jar.mn#115
21:52:44 <flo> we need to port http://hg.mozilla.org/comm-central/rev/f810828f8ca1
21:57:13 <clokep> Hmm...OK.
21:57:26 <flo> clokep: do we need to add the GNU GPLv2 to about:license?
21:57:29 <clokep> Ouch. 2009.
21:57:32 <flo> it used to be there, but it's not there any more
21:57:41 <clokep> flo: I think we should
21:58:18 <flo> "All of the source code to this product is available under licenses which are both free and open source. Most of it is available under the Mozilla Public License 2.0 (MPL). [...]The remainder of the software which is not under the MPL is available under one of a variety of other licenses."
21:58:31 <flo> do we need to edit that sentence to mention the GPL?
21:58:35 <flo> I don't think so
22:01:05 <flo> the GPL and LGPL licenses were removed as part of http://hg.mozilla.org/mozilla-central/rev/beb93f812874
22:01:58 --> jb has joined #instantbird
22:02:30 <flo> clokep: I'm looking at/rewriting the build system part of the patch; can you update the license.html patch? :)
22:02:41 <clokep> flo: Sounds good. :)
22:02:52 <clokep> I'll add the GPL. But I don't think it needs to be mentioned in that paragraph also.
22:03:05 <flo> I think it's mentioned in our app-license.html file
22:03:10 <flo> we may want to add a link in it
22:03:17 <flo> once it's properly included again :)
22:03:24 <flo> do we also need to re-include the LGPL ?
22:03:49 <flo> I think the oscar libpurple prpl is LGPL http://lxr.instantbird.org/instantbird/source/purple/libpurple/protocols/oscar/COPYING 
22:04:00 <flo> if that's even possible for some code linking against libpurple that's GPL'ed :-S
22:04:27 * clokep is confused. ;)
22:04:50 <-- DGMurdockIII has quit (Connection reset by peer)
22:07:17 <flo> confused by what?
22:07:39 <-- Mnyromyr has quit (Quit: ChatZilla 0.9.86 [SeaMonkey 1.1.19/2010030105])
22:08:02 <clokep> I had no idea that was LGPL.
22:08:11 <flo> is LICENSE.txt packaged?
22:08:20 <flo> clokep: I think Pidgin developers don't remember it either ;)
22:12:08 <clokep> I don't think so flo.
22:12:14 <flo> now it is ;)
22:13:49 <flo> clokep: are you also taking care of rephrasing instantbird/LICENSE.txt (now that it's going to be packaged)
22:14:02 <clokep> flo: I can if you'd like.
22:14:25 <flo> cool :)
22:22:27 --> DGMurdockIII has joined #instantbird
22:28:18 <-- sonny has quit (Quit: Instantbird 1.2a1pre -- http://www.instantbird.com)
22:28:27 <clokep> flo: Is there something special I need to do to build with a new license.html?
22:29:11 <EionRobb> lol, funny that liboscar is supposedly lgpl.  you should mention to the pidgin peeps about it
22:29:44 <flo> EionRobb: it's the only part of libpurple that has a license that makes sense for a library ;)
22:31:10 <flo> clokep: you'll need my build system changes
22:31:24 <clokep> OK.
22:36:04 <instantbot> florian@instantbird.org cancelled feedback?(florian@instantbi rd.org) for attachment 1746 on bug 1546.
22:36:05 <instantbot> florian@instantbird.org requested review from clokep@gmail.com for attachment 1768 on bug 1546.
22:36:06 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
22:36:42 * clokep is just re-reading his patch now...
22:36:46 <flo> it's the third or forth time this evening that I'm surprised that auto-scroll hasn't worked while the conversation window wasn't visible.
22:37:07 <flo> I wonder if this is related to our damn autoscroll bug or if it's yet another auto-scroll bug :-S
22:42:17 * aleth wonders if clokep has seen it on Windows
22:42:39 <aleth> since it doesn't show up on Linux
22:43:07 <clokep> aleth: Maybe once or twice. I don't know.
22:46:34 <clokep> flo: With your patch applied I'm getting http://pastebin.instantbird.com/56534
22:47:27 <-- jb has quit (Ping timeout)
22:47:52 <-- aleth has quit (Quit: Au revoir)
22:48:10 --> aleth has joined #instantbird
22:48:10 * ChanServ sets mode +h aleth 
22:48:47 * aleth is seeing an update error
22:48:57 <aleth> "The integrity of this update could not be verified"
22:49:12 <-- aleth has quit (Quit: Au revoir)
22:49:17 --> aleth has joined #instantbird
22:49:17 * ChanServ sets mode +h aleth 
22:49:25 <-- aleth has quit (Quit: aleth)
22:49:29 <flo> apparently copyright years can be removed: https://bugzilla.mozilla.org/show_bug.cgi?id=536336
22:49:29 --> aleth has joined #instantbird
22:49:30 * ChanServ sets mode +h aleth 
22:50:07 <-- aleth has quit (Quit: Au revoir)
22:50:22 --> aleth has joined #instantbird
22:50:23 * ChanServ sets mode +h aleth 
22:50:23 <flo> it's really hard to read things copied from a windows terminal :(
22:50:48 * aleth goes to reinstall IB
22:51:28 <flo> clokep: I suspect the error message isn't included in what you copied
22:52:29 <clokep> flo: Is http://pastebin.instantbird.com/56535 more useful?
22:53:16 <flo> is that the part immediately before?
22:53:59 <clokep> It's the entire log.
22:54:03 <clokep> I redirected output.
22:54:07 <flo> ah
22:54:11 <flo> then use another pastebin service
22:54:26 <flo> accepting a longer paste
22:55:15 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1769 on bug 1546.
22:55:19 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
22:56:54 <clokep> Hmm...maybe http://pastebin.instantbird.com/56536 has enough context
22:57:00 <flo> "The remainder of the software which is under is available under" doesn't mean much
22:57:30 <-- aleth has quit (Quit: Au revoir)
22:57:52 <flo> clokep: the error is at line 167 in that pastebin
22:58:09 --> aleth has joined #instantbird
22:58:09 * ChanServ sets mode +h aleth 
22:58:15 <clokep> Ah-ha.
22:58:19 <flo> is there a file at this path: /c/Users/Patrick/instantbird/instantbird/app/app-license.html ?
22:58:52 <clokep> Ah I believe "The remainder of the software is available under a variety of more permissive licenses." is what I was going for. :)
22:59:21 <flo> I wonder if this could be a pymake bug
22:59:23 <clokep> Yes, that file exists.
23:03:08 <clokep> Any other changes?
23:04:21 <flo> I'm afraid you'll have to tweak the rules in the 3 lines I added to instantbird/content/Makefile.in until pymake is happy
23:05:45 <flo> wouldn't "the Mozilla Public License (MPL) 2.0" (in LICENSE.txt) be more consistent with the other lines?
23:06:12 <flo> we should also change "See license.html for details."
23:06:25 <clokep> To what?
23:06:28 <flo> license.html is now buried into omni.ja
23:06:32 <flo> it's not directly readable
23:06:32 <clokep> I went back and forth on the (MPL)...
23:08:04 <flo> either about:license, or a hint to go look at the about dialog
23:08:58 <clokep> Any hints about what to mess w/ to make pymake happy? :)
23:11:07 <clokep> Ah I think I have it working...
23:11:17 <flo> I think $(shell) is causing the issue
23:12:59 <clokep> This might be a stupid question...but why did you move the include rules.mk line? If I move that back everything seems to work OK.
23:13:32 <flo> really? :)
23:13:52 <clokep> Yes...
23:14:09 <flo> does it really work, or does it just ignore the lines added after that include?
23:15:14 <clokep> I mean the license is OK...
23:16:51 <flo> ok, just revert that change then :)
23:19:39 <clokep> OK!
23:19:42 <instantbot> clokep@gmail.com cancelled review?(florian@instantbird .org) for attachment 1769 on bug 1546.
23:19:43 <instantbot> clokep@gmail.com requested review from florian@instantbird .org for attachment 1770 on bug 1546.
23:19:44 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
23:19:49 <clokep> Oh, I forgot to mention that patch is meant to apply on top of yours.
23:26:45 <flo> have you started looking at my xmpp patch?
23:27:37 <flo> the patch for bug 1524 will need to reuse some of these changes, so I would rather check-in the alias changes before touching the tag changes
23:27:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1524 nor, --, ---, nobody, NEW, Moving a JS-XMPP buddy from a tag to another should work and save this change on the server
23:27:57 <aleth> flo: I think I've figured out what caused the time bubble mismatch
23:28:58 <clokep> flo: I looked at it briefly.
23:29:04 <clokep> I'll look again now.
23:29:20 <flo> I'm renaming license.patch to tools/patches/bonjour-license.patch
23:29:33 <flo> otherwise I'll need to open the file lots of times to know what it's about ;)
23:31:21 <instantbot> clokep@gmail.com granted review for attachment 1767 on bug 1523.
23:31:23 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1523 nor, --, ---, florian, ASSI, Aliasing a JS-XMPP buddy should store the alias on the server
23:31:55 <flo> clokep: who's the reviewer and who's the patch author for that license bug now? :-S
23:33:01 <clokep> flo: I think you did all the hard parts. :)
23:33:57 <flo> the hard part is finding motivation for something so boring, isn't it? ;)
23:34:51 <flo> so I'm the author and you're the reviewer? Are we adding some flags in the bug? ;)
23:35:33 <clokep> Yes, that's fine.
23:35:44 <clokep> We'll just r+ each others, you can be the author and I'll be the reviewer.
23:36:01 <flo> ah, but the license patch is not really only about bonjour now that we added back the GPL and LGPL :(
23:36:38 <flo> bonjour-and-GPL-licenses.patch ?
23:38:56 * flo takes "no answser" as a "yes"
23:38:56 <instantbot> florian@instantbird.org granted review for attachment 1770 on bug 1546.
23:39:00 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
23:39:27 <instantbot> New Instantbird (UI) bug 1611 filed by aletheia2@fastmail.fm.
23:39:32 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1611 nor, --, ---, aletheia2, NEW, Unread ruler movement can cause spurious Bubbles gap time text
23:39:59 <clokep> flo: Yes, that sounds good. :)
23:40:13 <-- timA has quit (Quit: Instantbird 1.1)
23:42:13 <flo> aleth: that explaination makes an awful lot of sense.
23:42:40 <instantbot> clokep@gmail.com granted review for attachment 1768 on bug 1546.
23:42:42 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1546 nor, --, ---, nobody, NEW, license.html not distributed with Instantbird
23:42:44 <flo> splitting and rejoining bubbles was a little bit to magical to work perfectly ;)
23:43:08 <-- myk has quit (Ping timeout)
23:43:16 <clokep> flo: Are you doing the rename yourself then or did you want a new patch? :)
23:43:17 <aleth> This is going to cause a real problem for whoever tries to implement infinite scroll ;)
23:43:28 <flo> clokep: it's already commited
23:43:35 <clokep> Excellent. :)
23:43:55 <flo> aleth: whoever does that will bang his head against a wall, until another wall is needed ;)
23:44:07 <aleth> quite likely :D
23:45:36 <flo> anybody remembers which comm-central changesets I wanted to port for bug 1435 ?
23:45:40 <instantbot> Bug https://bugzilla.instantbird.org/show_bug.cgi?id=1435 nor, --, ---, nobody, NEW, Block updates from Instantbird 1.1 to 1.2 for Windows 2000 and Windows XP < SP2 users
23:45:47 <flo> I think there was some changes in the windows installer
23:47:26 <clokep> No. :-/ I don't think it was mentioned anywhere..
23:48:18 <flo> it's too bad we don't have bonsai to find all the changes in the mail/installer folder :-/
23:52:42 <flo> after reading "_scrollingIntoView would have been set by displayMessage if we hadn't turned off autoscroll. We must keep it set to prevent any _updateAutoScrollEnabled() calls by browserScroll." 3 times, I still don't have any idea of what it means, and guess I need to lxr the file
23:54:52 <aleth> Another way of putting it would be "two scroll events can reset autoScrollEnabled if we don't keep _scrollingIntoView set, which would be done every time we inserted a message if we hadn't turned it off while adding the first messages"
23:55:58 <flo> I'm not sure if this is a bug or if it's the expected behavior
23:56:17 <flo> if the user starts scrolling while the conversation is still being restored, shouldn't we disable auto-scroll?
23:56:44 <aleth> If the user starts scrolling, it will still disable autoscroll
23:57:41 <flo> if I follow exactly the STR in comment 0, I end up with a conversation scrolled all the way to the bottom (ie auto scroll works)
23:58:11 <aleth> That's why I suspect this annoying bug manifests differently on different OS
23:59:18 <aleth> Btw you really do need a long conversation. Just having a progress bar is not enough.
23:59:32 <aleth> But then, it's very reproducible.
23:59:40 <flo> so why is browserScroll called?
23:59:46 <flo> if we aren't auto-scrolling?
23:59:48 <aleth> I have no idea.
23:59:57 <aleth> Something triggers scroll events